From nobody Sun Sep 15 11:54:30 2024 X-Original-To: office@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X660Q6XhZz5WHTp for ; Sun, 15 Sep 2024 11:54:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X660Q2b25z40gX for ; Sun, 15 Sep 2024 11:54:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726401270; a=rsa-sha256; cv=none; b=F8HxiWDH8zGWjRQIHbfvJ7Rp7V58bBm4YB16d5J4nSTJNrHLg0ojAbaWQ8+hKOdB85ghP3 +dskuDCjADki8vHz0zgQ/+a2siZowUCX0qhx+iblJl+GR2R4FGVt4bnyWchaC78maOwdUq BiasZe149OCBdSdAbzNDknkRfCxx0Qq8KHdnFfCVatXYEmLhTYYmNJFbicIJn+ioDkPcpE Eid2ZFhZbYNnLM4FnpYOU7tKhg6zFSUNhEviU5SBfbiODQ/WQiSCeK/lJxpxVAAf3nQnCX pOK+0IX4FD1z802+vyRHJvZfaiwK/RkoGLmwfHlWYrAbFCy2hg4gkOwAnNJRyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726401270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TDa+VxpL8Rb2nr9S6fmAdHvbWBun0zmjmH8jfhFOMOg=; b=WW5boUntAPEzDgILZbfbb/vuZ5gq3sHgMZsLJNn85AuB3kzWebLHq2aDDT5UwBZzfNLOPp ptBpPY3Un5Yh4ielcZXtcfBSOBecCWOdKCc2Y0xFvV6M1z3dglAe3VkwajLlKxrH8oNHuQ eooibhHPuBjPPq96ChOEmHAsDCSA8A3bKIvnGF3ZPTc92ZVPTBkBTJ6zVKFM1cXayMah4U aIHqTnDnhEpDnBxedDvWjIf7yiuQ6Hw8AEG6Fc7CGLWb8KPc4MnKMdkzgokLAwmSHtvqGF kbukPD3egW3sroTcgYKICAQZurN2WLYFGy8zEIP946D4lb+xIJOQM6cG7pziHg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4X660Q2BZBz18sb for ; Sun, 15 Sep 2024 11:54:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 48FBsUVT073613 for ; Sun, 15 Sep 2024 11:54:30 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 48FBsUo1073611 for office@FreeBSD.org; Sun, 15 Sep 2024 11:54:30 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: office@FreeBSD.org Subject: maintainer-feedback requested: [Bug 281516] graphics/libemf: fix build with libc++ 19 Date: Sun, 15 Sep 2024 11:54:30 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: office@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Office applications on FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-office List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-office@FreeBSD.org MIME-Version: 1.0 Bugzilla Automation has asked FreeBSD Office Team for maintainer-feedback: Bug 281516: graphics/libemf: fix build with libc++ 19 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281516 --- Description --- As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes graphics/libemf to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undef= ined template 'std::char_traits' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ libemf.cpp:982:30: note: in instantiation of template class 'std::basic_string' requested here 982 | std::basic_string filename_w( filename, filename + filename_count ); | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ libemf should really use char16_t for its 16-bit character type, but the code is full of Windows assumptions that WCHAR is unsigned short. Since std::basic_string is no longer available, use std::basic_string instead, and cast the result to the appropriate type for GetEnhMetaFileW(). [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals