From nobody Mon Aug 19 16:03:22 2024 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wncp25Bc9z5TH3W for ; Mon, 19 Aug 2024 16:03:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wncp23hgkz49Fm for ; Mon, 19 Aug 2024 16:03:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724083402; a=rsa-sha256; cv=none; b=IV56sGh2VBeRp3xtnqJcDs4zaerHFMFInc5JaTtaf1EeJFgcwT/vv+RPgWkLn5T3SXrnLw TEYdqQnCZSxIUNAMDoQo1Vm9U3rVjy05JFQnaqP5Gy20PW71De8xkXmrw0Z9SIrii4KG67 TCaB6QIqPkzxVrwAsOrHEdXvNhPltXUamKPCt6JwNN9EmNIAKAp6NDwzHhqNAsqccrqN0g 4RkoQ4V3xzYWTq/PKlV/a0orkeoLJ17QAJGLXEMCcMc6FK+cafpxmHoLUZALFbqOY4VVKL tnayzzjBPcOe5G0gRcSUD5HUx3tfNWONhutNFNLL1Gvk/qTpIrtMqBfguTqBVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724083402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FqpEIrj6bNlmYctbyRkeIZRuZ+RkMXHPAeWRku3PWKY=; b=n3SXijpu55HZSYgq4RQNQ+FfT6bUwsBU1SinPTJasqtREhU8gnEUmXjIRnSoKnonzNm8MN 4dBjKxJeJC3ERC1FPCKhP+Osk6m7yi7q5QUUfSHmuH285K3ENxLarJ9CUGRUWP9TKuaS2l x8jFHYEaXyJKpYA2UFXOTSQ7dMJNMoFw9i5QAQhm6nQf7Ll5EzRVx9Lti5kD/gXKkw9/+C HmO/7g3t0p3m2ICtuLpAVKS4/gS2mLOgby6BkrrSwyURW0OhK9KFgzUvXyoPiIjm+V6vPq ZSr1zoQX+ScV1/cPwc+ZyuyE4t/DVjdNFHh5xJA8jHtxi5flo+tlgOoH1mvr3w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wncp23J5kzNT5 for ; Mon, 19 Aug 2024 16:03:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47JG3MXd020439 for ; Mon, 19 Aug 2024 16:03:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47JG3MnD020430 for pf@FreeBSD.org; Mon, 19 Aug 2024 16:03:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 280834] pf: set skip on persists and can't be removed Date: Mon, 19 Aug 2024 16:03:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-pf@freebsd.org Sender: owner-freebsd-pf@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280834 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D6a88e22728d285c4df17216515ce2b8d1= e5a6835 commit 6a88e22728d285c4df17216515ce2b8d1e5a6835 Author: Kristof Provost AuthorDate: 2024-08-16 12:55:31 +0000 Commit: Kristof Provost CommitDate: 2024-08-19 16:02:15 +0000 pfctl: pfik_ifp is always NULL The pfik_ifp field is not provided by the kernel, it is always NULL. Do= not check for it. This caused us to not clear the skip flag on interfaces, leading to unexpected behaviour when a 'set skip' was removed. PR: 280834 Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D46311 sbin/pfctl/pfctl.c | 7 +---- tests/sys/netpfil/pf/set_skip.sh | 61 ++++++++++++++++++++++++++++++++++++= ++++ 2 files changed, 62 insertions(+), 6 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=