From nobody Mon Apr 29 03:49:25 2024 X-Original-To: freebsd-pkgbase@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VSTqj2nKGz5J7vB for ; Mon, 29 Apr 2024 03:50:09 +0000 (UTC) (envelope-from reshadpatuck1@gmail.com) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VSTqh4H14z4vtW; Mon, 29 Apr 2024 03:50:08 +0000 (UTC) (envelope-from reshadpatuck1@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZZ3dZKtI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of reshadpatuck1@gmail.com designates 2a00:1450:4864:20::429 as permitted sender) smtp.mailfrom=reshadpatuck1@gmail.com Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-344047ac7e4so2779544f8f.0; Sun, 28 Apr 2024 20:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714362604; x=1714967404; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7D3N43MplrParu+nFXYUNdQ7n3Xq9+oPjpEvLi+sbPI=; b=ZZ3dZKtIiO5YJNVu/G2Q1gXGT0PpdgNN6+vSemnghMVH/HDByoeTlWy13vidEf01Gm eNryrODOY7csKhfPM7mJiJ9RKdgqunghGNkgBJyfTE5ja9Eq3PnPA4tsOL75iXbDYQ7A ZpJGFaIUSn6LtKp5/jAdYfJj/eunXglo21pb3H4iNJdpUm3nYsFrVSaWXlvug3VmjFxm I6iL1bxT8VbZBAv5ZZrw4Axz+/HA8kc9SuDlN38y9Tfy0QGX3P4eZnHSkeRe1e2KEsn/ JlsYhPy91Dv9gjzPrUMmuttxmQyOt/SyMBAVtOIjcCEzO5gmR8t43LLEFVhTOgUCbr1G XCcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714362604; x=1714967404; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7D3N43MplrParu+nFXYUNdQ7n3Xq9+oPjpEvLi+sbPI=; b=jsjnDUVWOsD2lFljPX6LOp0mvTU2pOE8draCGlFv+gxAT82BXkP3dXjpIP6+4FXleW AE04zkQ5QWGCMdMbdJ/Cj2LeQfw2x+vUqj+BeR0JQ/qUzGUq7Jp1KgpBZHjKsHtWfX+7 XAmZi/ahsvMrxyk548nuhKtDoCq4iPomHT7n3DXnokLri9au1KDHEqT7GgSvSR8/w4bx nxD4dmk6a9dc5T+WhYVEGuby4RhAHAz3iZ7TpDIX7Kvq4TubYINzvSSn2fNJ2MSZGGVa QZReB1v/5TXa6UqtwREyviPzZtg9dNZHg4XgNz7nAQ41qZ6TtmMLEaBuw1SG5w3nbLI+ MtPQ== X-Gm-Message-State: AOJu0YxVIl5nBRSeOVcKDLc7wpohAd4KO3bLa3Yg/5/R6fl7Uf5AcfFI z8YkdnntQ0Ddz0C1frseA4LEHY/+iPY6dMXT8tjbBGSjirZhgrA5qFQ1hHxcBrkiLmIVGLZQ4GH JXOybjVk0D6tmp4oY4nDtiCfB28Sh06m6 X-Google-Smtp-Source: AGHT+IF0r/GG+N3rlJjZXfJ5RN5LNegZKz9yB5ISuRIh7B72Odx4l503Tl3VTWCCjX7NsRDcgongKUeKFGemIpILjn8= X-Received: by 2002:a05:6000:d52:b0:348:870:bbe4 with SMTP id du18-20020a0560000d5200b003480870bbe4mr5031086wrb.7.1714362603972; Sun, 28 Apr 2024 20:50:03 -0700 (PDT) List-Id: Packaging the FreeBSD base system List-Archive: https://lists.freebsd.org/archives/freebsd-pkgbase List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pkgbase@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Reshad Patuck Date: Mon, 29 Apr 2024 09:19:25 +0530 Message-ID: Subject: Re: FreeBSD kernel version 0 To: Baptiste Daroussin Cc: "freebsd-pkgbase@freebsd.org" Content-Type: multipart/alternative; boundary="00000000000006b07f061734269b" X-Spamd-Bar: ++ X-Spamd-Result: default: False [2.94 / 15.00]; SEM_URIBL(3.50)[gitlab.com:url]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_SPAM_LONG(0.94)[0.936]; NEURAL_HAM_MEDIUM(-0.50)[-0.501]; BAD_REP_POLICIES(0.10)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; R_DKIM_ALLOW(0.00)[gmail.com:s=20230601]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::429:from]; MLMMJ_DEST(0.00)[freebsd-pkgbase@freebsd.org]; MID_RHS_MATCH_FROMTLD(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; R_SPF_ALLOW(0.00)[+ip6:2a00:1450:4000::/36]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MISSING_XM_UA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com] X-Rspamd-Queue-Id: 4VSTqh4H14z4vtW --00000000000006b07f061734269b Content-Type: text/plain; charset="UTF-8" Hi Bapt, Thanks for this update. Since I use pkg base with 14.0 on a bunch of systems in production would you know if there are any plans to backport the patches to 14.0? As a hack I am downgrading pkg manually on my system before building the packages for now, this seems not-ideal. I am trying to backport this into a patch that I can apply on 14.0 until 14.1 is available. Can you tell me if these commits are a good starting point? https://gitlab.com/FreeBSD/freebsd-src/-/commit/051d69d6f8b51dc1d7bba58af99be76185312222 https://gitlab.com/FreeBSD/freebsd-src/-/commit/5faaa602cee093269b1a73156c95c6892b4f098d Thanks for the help, Reshad On Fri, 26 Apr 2024 at 17:08, Baptiste Daroussin wrote: > On Fri 26 Apr 16:49, Reshad Patuck wrote: > > Hi, > > > > I have been trying to compile FreeBSD 14.0-RELEASE-p5 on a FreeBSD > > 14.0-RELEASE VM today and it seems like the FreeBSD_version annotation in > > the +MANIFEST file is set to the value "0". > > This caused my system to throw the error "pkg-static: Invalid FreeBSD > > version 0 for package FreeBSD-kernel-generic" when I tried to install the > > pkgs on another FreeBSD 14.0 system. > > > > I had compiled the same version (using the same commit hash) on the 12th > of > > March and it worked fine. > > > > I have attached the following files at https://paste.ee/d/9KcnQ: > > - pkg-base-build-script.sh - The list of commands I used to build a new > pkg > > base instance > > - +MANIFEST-working - the +MANIFEST file from the working pkg of FreeBSD > > 14.0-RELEASE-p5 built on 2024-03-12 > > - +MANIFEST-broken - the +MANIFEST file from the broken pkg of FreeBSD > > 14.0-RELEASE-p5 built on 2024-04-18 > > > > I use a stock FreeBSD 14.0 image in AWS to spin up a new VM each time I > run > > this compilation and have used the same image since February. > > The only thing that runs before I run the compilation is a pkg > installation > > of some tools like git, curl, htop, screen and vim. > > > > Looking at my archives, it seems that the version of pkg had changed from > > '1.20_9' to '1.21.2'. Could there be something here? > > Any help understanding why this difference exists will be much > appreciated. > > > > Best Regards, > > Reshad > > The reason is a bug in the 14.0 Makefiles which are not exposing OSVERSION > (fixed in main, stable and will be in 14.1) and a behaviour fix in pkg > 1.21.2 > which highlights the main issue. > > Up to pkg 1.21.2, pkg was leaking the OS version of the builder host into > the > package, since pkg 1.21.2 pkg stops leaking that informaiton and so the > version > if set to 0. > > Waiting for 14.1 to be release the builders have to export OSVERSION > variable. > the content of the variable should match what ever is the _FreeBSD_version > in > the source being built, this information is available in sys/sys/params.h > > Best regards, > Bapt > --00000000000006b07f061734269b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Bapt,

Thanks for this upd= ate.
Since I use pkg base with 14.0 on a bunch of systems in prod= uction would you know if there are any plans to backport the patches to 14.= 0?
As a hack I am downgrading pkg manually on my system before bu= ilding the packages for now, this seems not-ideal.

I am trying to backport this into a patch that I can apply on 14.0 until 1= 4.1 is available.
Can you tell me if these commits are a good sta= rting point?
https://gitlab.com/FreeBSD/freebsd-src/-/commit= /5faaa602cee093269b1a73156c95c6892b4f098d

Than= ks for the help,
Reshad


On Fri, 26 Apr 20= 24 at 17:08, Baptiste Daroussin <bapt@freebsd.org> wrote:
On Fri 26 Apr 16:49, Reshad Patuck wrote:<= br> > Hi,
>
> I have been trying to compile FreeBSD 14.0-RELEASE-p5 on a FreeBSD
> 14.0-RELEASE VM today and it seems like the FreeBSD_version annotation= in
> the +MANIFEST file is set to the value "0".
> This caused my system to throw the error "pkg-static: Invalid Fre= eBSD
> version 0 for package FreeBSD-kernel-generic" when I tried to ins= tall the
> pkgs on another FreeBSD 14.0 system.
>
> I had compiled the same version (using the same commit hash) on the 12= th of
> March and it worked fine.
>
> I have attached the following files at https://paste.ee/d/9KcnQ: > - pkg-base-build-script.sh - The list of commands I used to build a ne= w pkg
> base instance
> - +MANIFEST-working - the +MANIFEST file from the working pkg of FreeB= SD
> 14.0-RELEASE-p5 built on 2024-03-12
> - +MANIFEST-broken - the +MANIFEST file from the broken pkg of FreeBSD=
> 14.0-RELEASE-p5 built on 2024-04-18
>
> I use a stock FreeBSD 14.0 image in AWS to spin up a new VM each time = I run
> this compilation and have used the same image since February.
> The only thing that runs before I run the compilation is a pkg install= ation
> of some tools like git, curl, htop, screen and vim.
>
> Looking at my archives, it seems that the version of pkg had changed f= rom
> '1.20_9' to '1.21.2'. Could there be something here? > Any help understanding why this difference exists will be much appreci= ated.
>
> Best Regards,
> Reshad

The reason is a bug in the 14.0 Makefiles which are not exposing OSVERSION<= br> (fixed in main, stable and will be in 14.1) and a behaviour fix in pkg 1.21= .2
which highlights the main issue.

Up to pkg 1.21.2, pkg was leaking the OS version of the builder host into t= he
package, since pkg 1.21.2 pkg stops leaking that informaiton and so the ver= sion
if set to 0.

Waiting for 14.1 to be release the builders have to export OSVERSION variab= le.
the content of the variable should match what ever is the _FreeBSD_version = in
the source being built, this information is available in sys/sys/params.h
Best regards,
Bapt
--00000000000006b07f061734269b-- From nobody Mon Apr 29 06:41:35 2024 X-Original-To: freebsd-pkgbase@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VSYdb1ZDTz5JPT6 for ; Mon, 29 Apr 2024 06:41:39 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VSYdZ6Tq5z4M04; Mon, 29 Apr 2024 06:41:38 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714372898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6jbSMZH46x0XnRyQSxmp5AL0ru9pvKPftuHOfkz8KMo=; b=RpyWAcxw9LfefrD3JDoCM6N0dqfLfZQmgvggNG6zKMJDyCsDnzM6hl8K74IHG9G6cpzBHp 2sMIfr2aa/1wr1/Eknb1pKRepHepXTPnjvRApeyRZG+Lsns1z8gllKyq7g97v47sax3kXy IRDzdxR4LDdSRRd/Gp7hOl3zATrWVCuiY4UoQZP1hNx/wgqSG13Na1vEiZngbVoBJBMNuJ ML6375Zvx9Q9cbeLdm0lQBOyMRqPufLX2bk/4LFYgE5IiXScri8522hVCZMH8NcjKAhICu o9IlaJUaHlQ8+C5k5eJ9tgfM+3bBpbflDtawpK5r7QIL7U6e3IQPUnDrk6/g2g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714372898; a=rsa-sha256; cv=none; b=eB1Vd+YHlkaW7frPaEzY9pePvEiZiC83kCiOlb4QNUE9aQurmAL6IE24K/z3dTkO0au4tU RnHSkhdBwuPmxEXYmbWrZt+t6CeVC3VNzAMXkwvOqfKt7vgW0rVbWTf19rT3XRGP8d+0Lq 6W3oQtnyPQRjI82v4ThuwPr2DeMrOnqjwr8OVDbFOp9Z9XOKHcUM/biIqNJ6yGOGKNBSLs vky8pEeNFua1EwxAPpSFqktMTRBE7WgwhknZwJk3oPFH4AXj9JJJNN/BQrJIn603Pzh6/g 9ziNh55sgVIAXcY58p+41zJyXRrURBuIi8Kuh2GLrCmX2YizIt/7xeHPOwMCnw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714372898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6jbSMZH46x0XnRyQSxmp5AL0ru9pvKPftuHOfkz8KMo=; b=YR5MYyqYgcwXYNAFigcTg8Bfibcv9vZxLiqsifZcX099T59IBueNv86XK/5LnZnO8jVUUw ZilxlcR7U4KYiMNwYtpDoz8HN4kAP4Kdufr15OO1kjXOITs83yHAPruyzyKTydvOyy970e LeItOs4I8L+gr5TcqgJKnpl8MvJqFU9hQ/zkv0TEE0htAP3oHhUG9O0Lu+cWD2pgAKzgud eCeY4tOMnXcqAvXaiGD2ZpQG+X4NaNWIirZ4JF8Prp+El5GAkTvcWwZK25UdQympJZ2SHF BtjWY/ENZSOcj9XNLmDglNXuHyCMvVNnuI0cYslRdwKpH7jifiLhvD+zkXdweA== Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VSYdZ5XCSzRCM; Mon, 29 Apr 2024 06:41:38 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id D16621E7574; Mon, 29 Apr 2024 08:41:35 +0200 (CEST) Date: Mon, 29 Apr 2024 08:41:35 +0200 From: Baptiste Daroussin To: Reshad Patuck Cc: "freebsd-pkgbase@freebsd.org" Subject: Re: FreeBSD kernel version 0 Message-ID: References: List-Id: Packaging the FreeBSD base system List-Archive: https://lists.freebsd.org/archives/freebsd-pkgbase List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pkgbase@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon 29 Apr 12:00, Reshad Patuck wrote: > Hi, > > A little bit of trial testing later, I have got pkg base to compile with > this patch https://paste.ee/p/Gj985. > It applies these two lines from Bapt's upstream commits to the releng/14.0 > branch: > https://gitlab.com/FreeBSD/freebsd-src/-/commit/5faaa602cee093269b1a73156c95c6892b4f098d#cd187a45cb8a1c1a5dc57864fbc7840fa73ac75b_2191_2197 > https://gitlab.com/FreeBSD/freebsd-src/-/commit/5faaa602cee093269b1a73156c95c6892b4f098d#cd187a45cb8a1c1a5dc57864fbc7840fa73ac75b_2227_2234 > > This adds '1400097' as the FreeBSD_version annotation in the kernel pkg > file. > I don't know if this is of interest but, before this patch only the kernel > had a value of '0', all other packages had the version '1400097'. > > Since the version has not been bumped since the 14.0 release and I am > building on 14.0 I do not know if this is an actual fix or just adding the > version of the host to the pkg file. > I am just kicking off a full build with my patch now. > > Thanks for the help. > This is the actual fix Best regards, Bapt