From nobody Fri May 3 14:48:28 2024 X-Original-To: scsi@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VWDFS4hn1z5K84N for ; Fri, 3 May 2024 14:48:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VWDFS2rgTz4xJg for ; Fri, 3 May 2024 14:48:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714747708; a=rsa-sha256; cv=none; b=DHOiGi+2ILCbqvOSfqRbRjIVWjHSxHKm+AbOybWuq0QwxXope+VdfuQlbpj9I2ttf6LOIr GkkHamad+wAqO14lIS5DfcZrz2ZjKn7Ks22YE/LCqyx0bRj8E/KmuR+64Q/G0FFQKlI65a UWENT4c8polNFJdDf3Wt+i0c0qgk4mmfPWECiCA9Z186Pz/wPphW7VHpyTkY9NidsW7wZN WfKS0mDPWkMIiXc/cbnDqb3qoBbVgsY1K8m/1n6npGncMoVbUUfW0v7BTYQU+n+vb8keNf l/kpxeAe8q7dZWra1gpWBfzbTnmKp8niRyO5OdQUahEPAOSutspB0NwJTJtYtw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714747708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RLVCwZsK/VJQHw53Sxm2ny3Z5iKJI6kdJK8bChDNM0Y=; b=brK5Lmj3Q5ouibqRJKmTCndUx6GpEoOFKGQ3BttE/HJzvPmvsuvHt4iRtP8a3FaX2FjdqD yXio/xBx+cQRR+5voL0Ggy0Qhr4iU/ff5lJun1WQzK088H5NtOM5aiQ5lXQc1vI2C0kXyk PJSmTfAIUr8yB0Al4mpOuq1wP+2VJMvNLQ264W4nFQqNPayqXZZCqfKZdukAARuCy5YiiO liiU26LWi7AT538eW985fHfBCVYaRCItEfMWrv8hOawGmurKPjo76lizq5vQ/3DK9i9R9+ qXS7QcjwxljQBFBUo5Z/bttyLtTfw8CKDCQcZBlJh2eHsod3ATKW/4T4ezOCYA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VWDFS2SHSzqdZ for ; Fri, 3 May 2024 14:48:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 443EmSsr023126 for ; Fri, 3 May 2024 14:48:28 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 443EmSwr023125 for scsi@FreeBSD.org; Fri, 3 May 2024 14:48:28 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: scsi@FreeBSD.org Subject: [Bug 277673] TRIM visibility bugs Date: Fri, 03 May 2024 14:48:28 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: cam X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: imp@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: scsi@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: SCSI subsystem List-Archive: https://lists.freebsd.org/archives/freebsd-scsi List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-scsi@freebsd.org Sender: owner-freebsd-scsi@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277673 Warner Losh changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress CC| |imp@FreeBSD.org --- Comment #1 from Warner Losh --- da part of this pushed. It was almost correct (I think it would be better to treat each WRITE SAME as 1 range so the stats are consistent with other methods). --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri May 3 15:04:21 2024 X-Original-To: scsi@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VWDbp0X4Yz5K9Qd for ; Fri, 3 May 2024 15:04:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VWDbn6Zp6z50mn for ; Fri, 3 May 2024 15:04:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714748661; a=rsa-sha256; cv=none; b=gIIUwY+ZWRuDcQS1e6NeJrfBHgdeMH5H+73zux6wyxmduMzPhFjR69EEzhXwzAQ9DhtLgb keO63HvOHYurt1wVLNce8BilNXP1qLHkrMQoEoiAFkVIsk4TrysLno1XmSXlOZ+LrXIs7l GiM9V3YsSguVdjKn3LlQ7GtvrHl03xYeV16+MOeU/r6OIPMsF3lrzBzLUwasKhe5GBRT5f JBXAiS0RSyYtxjANbvftpCxxAHvGIRZESyvk6BlzXGJUzQ3n8C9wbZvZ92+WGIUXOxiPsX xTPXfqWn8jKLVpV1kCLHm6Q4BwtHe/3yz95oqR//LvkwVErJJNY5MIaLNgB4wA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714748661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jKa2050v1gnFWeO8NY1nPM5/1cUC8Sg/GxCjLSvRzec=; b=VuTm3Ht8wBOofeK8ZoOdEwRPhSeXUsd6D72q8+NMS2SIUby3YXuSCHo86D0tR+m3MuF0bf sQB/eoX39ScQ63wzrTvI3RpLseSe0wVYD0s3itZT24pNmqTYPYoQ7ud/LXNHmFvgukf7/B 9ep5OfLn6BFL6RHUopc1lFBsyD86OD6sFjt2AucWs66qiEY/SlkFQ6tnEpT0Bqecr/hsT2 u4w1CFAm9h3g81WYvcbcYp+YuKtC8AOgWg61C986g6ck47VlRNlqI3IifbNl1qYSDK2y2j 4XvB1VSNomo4wi01MIJz0TUixk9wqW44fFL99Zh8uF9Nwf/chAqWf2SnjcPDbQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VWDbn69VMzr3R for ; Fri, 3 May 2024 15:04:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 443F4LCL025094 for ; Fri, 3 May 2024 15:04:21 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 443F4L2g025093 for scsi@FreeBSD.org; Fri, 3 May 2024 15:04:21 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: scsi@FreeBSD.org Subject: [Bug 277673] TRIM visibility bugs Date: Fri, 03 May 2024 15:04:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: cam X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: scsi@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: SCSI subsystem List-Archive: https://lists.freebsd.org/archives/freebsd-scsi List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-scsi@freebsd.org Sender: owner-freebsd-scsi@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277673 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dea2d874cca7cdfe6133c1835dadd8f067= 2723fa6 commit ea2d874cca7cdfe6133c1835dadd8f0672723fa6 Author: Matthew Grooms AuthorDate: 2024-05-03 15:01:21 +0000 Commit: Warner Losh CommitDate: 2024-05-03 15:03:31 +0000 geom_stripe: Cascade cantrim just like we do for gmirror If any of the disks can support trim, cascade that up the stack. Otherwise, trims won't pass through striped raid setups. PR: 277673 Reviewed by: imp (minor style tweaks from bug report) sys/geom/stripe/g_stripe.c | 21 ++++++++++++++++++++- sys/geom/stripe/g_stripe.h | 3 +++ 2 files changed, 23 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri May 3 15:05:21 2024 X-Original-To: scsi@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VWDcx4RqRz5K96Q for ; Fri, 3 May 2024 15:05:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VWDcx3Hydz515d for ; Fri, 3 May 2024 15:05:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714748721; a=rsa-sha256; cv=none; b=fzaQr7zXAHN0kzBopRTKTVcM1pZTDYB2GHz1qL0zBAsdqQJrQ0wRF7CANsDxvy532T70/P ySeHeb0RV5w734D7ttz35wNKmrOpwF0bKFNTnWdVrDM1m3yQ/MVySH3eu5taf/MtDK4DJ/ tw8v+IoVGZEg4tTUvyzrtufhis+BN5SlN0m/UWJvnlWz+JRektvt72lYzY8lMCm8VmsOsb 3Xl1wzPqJgd8bnVHKtFgjZOSHyNhpyLAbk+lZdN1E1lkNRZiFLC02iGz0WwBPkdB9Pq6/I jl6Cmvbk4yEk70Q5QB/HJ2gziK+do0q1yZ1700w1IXFThysAes6EILZKSB5VhQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714748721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g5Qbea6vThFnsKxGRtondQBqVPHusqIUrmK2S8f+xHU=; b=foqR0pvzdKMmUORu4PUjHevu/TS+j+3MdRAlf6aLorPZksVCsRNIXTke5h8R/583CSLvbX f34KVOd809qhE1osGkI8Boi9BMInhs6IX5C9xPrAee/plPDXXfGczkOfP3M8efS8bsGu0v 0GqG3bLKPKunz0Jvn4fx0KJyc7JdQUS2W4aYDXLFswBlFXO0kelb8N5qaGmNTU/NXnlmWI jrqK7U8SipyDvX1+3jFLPdH9XmoldJ9zwCK5vBkTANE38hiOKAmaBie+h6/GJpNLRlKIa3 TMx+D9c+YNGpi2y4cSoarBAIeZw/GQgHRUTu5mYU7TJOiv9bTzGpD+QcST4fKQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VWDcx2w05zr5W for ; Fri, 3 May 2024 15:05:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 443F5Lwa028760 for ; Fri, 3 May 2024 15:05:21 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 443F5La5028759 for scsi@FreeBSD.org; Fri, 3 May 2024 15:05:21 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: scsi@FreeBSD.org Subject: [Bug 277673] TRIM visibility bugs Date: Fri, 03 May 2024 15:05:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: cam X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: imp@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: scsi@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: SCSI subsystem List-Archive: https://lists.freebsd.org/archives/freebsd-scsi List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-scsi@freebsd.org Sender: owner-freebsd-scsi@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277673 Warner Losh changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Progress |Closed Resolution|--- |FIXED --- Comment #3 from Warner Losh --- And the second one has landed. I've queued these for MFC next time I do a M= FC run, but it likely won't be in 14.1 due to the lateness of the hour. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri May 3 15:36:46 2024 X-Original-To: scsi@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VWFKB4dVvz5HywV for ; Fri, 3 May 2024 15:36:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VWFKB3chNz57xq for ; Fri, 3 May 2024 15:36:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714750606; a=rsa-sha256; cv=none; b=BxqtJWEaSv/8l3rNNDAfYPerfS9eQtKIK50hwZXz6kaL322JfIKBcqCh+8zou3Dq9nwEhT CosPkG784+jWtLcXoqgElVJCs7QBkDPuVKNJfwut5TPtgscgcZKls9bGKlFIe77znDKN92 CfRrCKMgOQvWRuLYiP08KjIXr3gAd1j18ENCKI/qAZOEk0FHMs1LYmYTfIOFLWkNoDILwB DsNjl6l6ZVc+I6rRTMJa3sMyV7WVb5GzV32o2m+xWCBmgMrmqd6QOnpsCQHM09R6w94lkB nHp7GC2SwSUlYhlifuOTGIbEg4n6F2mkiDUiBlHQvSSV9pkHQENEu6saWrdDMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714750606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=44GcMNGcs4rKgd0HE6rp+CYO1L6a2U6uhPdY0OfsufE=; b=QrfSEF34pyv1jqkvHB4QUwCQJKcLxZRxjKIGJPUs+ETEalssC+pXWSC+VyWDiyXxTiVslQ t/74Mj1OVp3tmM2M/uUiyPwmz/aR26Vny07TT5cgIHmzjEG/OnDA8/qsJ3r6Emhs5DSV7m uRPWizHx6PQ2jxZQZNX/KgQsMIl4OsM+fwCCUm6+VCLNitA9eBOgf8IulKGYF/u0LBv2Ml 8tUbRdMn6StxKg9hXZmf9BPjdQ2q6xQaGa1pIfrO5RQ6IptIOctd1MiPWdFlU3i8WhNxHT 5wx5RlpygXwsN0L9DHgxVHRKT9MQxu+NuOxKTafdD3C2bJWY7K2NDFmgynb7dw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VWFKB3DCpzrqY for ; Fri, 3 May 2024 15:36:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 443FakUY097482 for ; Fri, 3 May 2024 15:36:46 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 443FakUv097481 for scsi@FreeBSD.org; Fri, 3 May 2024 15:36:46 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: scsi@FreeBSD.org Subject: [Bug 277673] TRIM visibility bugs Date: Fri, 03 May 2024 15:36:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: cam X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: mgrooms@shrew.net X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: scsi@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: SCSI subsystem List-Archive: https://lists.freebsd.org/archives/freebsd-scsi List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-scsi@freebsd.org Sender: owner-freebsd-scsi@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277673 --- Comment #4 from mgrooms@shrew.net --- I appreciate you looking at this Warner. I was concerned that second patch might be incorrect for the case that a disk with trim support was added to gstripe and later removed. The new behavior would report a false positive s= ince the G_STRIPE_FLAG_CANDELETE value is irreversibly set to true when one or m= ore disks that support TRIM are added to the stripe. I could rework the patch t= o be smarter for that case if that would be helpful. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sat May 4 14:23:41 2024 X-Original-To: scsi@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VWqfQ1D2xz5Kf2j for ; Sat, 4 May 2024 14:23:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VWqfP5xrjz4Npg for ; Sat, 4 May 2024 14:23:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714832621; a=rsa-sha256; cv=none; b=rcERUqAJRrGb4Yov8RmmmJ/V/a0FlxkMwcB5EY3h69ZZssBTLfSgRSsiViBcNoI4DKFP7f AqKlpKjvq6iOR/PCTVNg2sJXPuYNJUmZRLeJLSJ44leUJkGc1jD26PVQChx5Z039tuJFmc XVvGcLNHGRFaBhayTV3UosXdy4k/iheZJiflzoMHDVNrttX2QwR6Jm7yBJnUo6l36LZAlA C/FBq2o6oDtKWVnPpW/SnyWmYe2TpFtQyGMr52G3Gv0Fp2y9pZusqizOZj2tx+K0WX+DS+ XuSanjHevE5pJ0OEdZK/o+Z+LRwMQ4NwdSEx7ENYECXfh+V7LXgpZIaw1nSJYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714832621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ONAPheEBZEAeAv0quvgDc60zfJjdC4J9V3fHFLowgro=; b=ocLUrpQ/25xJF8ty88l8uamYenO6irta9Oe2am1a8etgnfEYiNPg/tBW9I86mHH1bU9lJV N3C/Dt9SV3RtVvV/OxBoULZgq+9K4RI1CbHkttJvzdsi+2NUA9qgMjNGivh9QXxDDpBQTh cCxgaVgWSDyLmlR7dNccFEPuB10VeM0rL8Bt0Cz/AIq/MXLx+Dnkr2A+/0E6+uPAG2KZkf RpH/KF6wBd80GGQtmqvdOONumuacPeBZnlw/IC39tJG2h7A+4yesY08tG0d6KrbJoFdEl2 E5NjmNCH+rVGaxIHwm5t3kttxMgiJA/wV9RQkoZmicE4e7VuLOuVMhU23xYb4Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VWqfP5YVjzYSD for ; Sat, 4 May 2024 14:23:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 444ENfES029837 for ; Sat, 4 May 2024 14:23:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 444ENf8f029831 for scsi@FreeBSD.org; Sat, 4 May 2024 14:23:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: scsi@FreeBSD.org Subject: [Bug 277673] TRIM visibility bugs Date: Sat, 04 May 2024 14:23:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: cam X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: imp@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: scsi@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: SCSI subsystem List-Archive: https://lists.freebsd.org/archives/freebsd-scsi List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-scsi@freebsd.org Sender: owner-freebsd-scsi@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277673 --- Comment #5 from Warner Losh --- (In reply to mgrooms from comment #4) Yes. keeping a mask of disks that support it and/or recomputing the single = bit when a disk is added / removed would be a bit better. Though the consequenc= es of having it advertised when it isn't possible are low. --=20 You are receiving this mail because: You are the assignee for the bug.=