From nobody Mon Feb 12 08:31:19 2024 X-Original-To: transport@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TYHk45m4pz59JqH; Mon, 12 Feb 2024 08:31:40 +0000 (UTC) (envelope-from dch@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TYHk453fyz4CMq; Mon, 12 Feb 2024 08:31:40 +0000 (UTC) (envelope-from dch@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707726700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BlV+vUNbnHhDiGMyFJZ9zTZgFAtYQORigf+CMXNt4rc=; b=AqdC0tYzBrcxIUxTz8p6LB4cdfJlTa1ZuLKaDfEbzdjhu61t1U+buK1ZUCtWmEbaNcOdOz njYKZvyMwOf+vNBdk/8BFmrrNl3/Luv7XaFqI3q7jQY+2CF984l9C2u2oauEmtu5pCdZE+ fw6L6OMy77h6tZ7JjgqE8etJ7LdY0s+6n9f+fHYY/KqTgXYR942wlCUEZc9X344VQAbXXL RcfccYnbMvXl7ehU3hhIIxD/RHMdXVlzpHRhKATSXJ4b2pDge58ktu8F8nh8Dyb1P9tRUq z381DtqCGflD6mVe5v+9n7pQO2dYMvw7an2aLoDNElUFMQZ7ZFtvKz6pIsDjhQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707726700; a=rsa-sha256; cv=none; b=fxQI8GXxZq7j4N6Y6sAVqs0gpQidpkq2gVgbE3ibIWbqWAHl9jz31kJlKyzRsmAhQdjKjs J2x8KqHb+28Y9P4/qpsDLt0pxp/++sIRyaroUJSFELYPt+plNX6ULB9putATsVPV4QNmQm UMPViORubGyJuzCsD5PVx9m4dnkgYVgz1ewG20+kzcIEJwNwSL0uU4ZIejiCL+UVGgecOX HwQbEPB9QhonxWAfLblr+mKQ2P8CKSQkr6kRjwoMnyndSAwRGltierCu4EBj51IaQCYSrF KV9CkCtGQe8tUW1ziPamOUXoBmq/hAs5r3h1qM1/uOOmxt32vB2xwZPfQxokpA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707726700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BlV+vUNbnHhDiGMyFJZ9zTZgFAtYQORigf+CMXNt4rc=; b=FrAzPTfE0FBXRNAoRzWJh+88hewfRiwADVqzepQ7cZtfSRBbbO5td5JP1iqPpJ0KQjiH3a k01lgLz7U+ba6XY3uO4cJq2ww7/UUHtSFbNZgC2IQHQighG3HSAWqqHFQBV+aEPXyr10vu V3pkN69Fy/VLruIw+TQNRp+IfdPe1Ln4pqNl5NVT9M/SYR5oENdLgI/iGs+4gsZ0pXhvPv l3lRco3HZsyj3hD4OCkfGa7CFRDeONHCm+CfsIhpn4ikUJ5f2Gmj5YW9F5PZP3xQthktLY V4QXkVJI8sfk5gUtCZoUET5uByqVk2tRdXGnXIqGOUUr4qsOqUnwX3q00BwmWA== Received: from fauth2-smtp.messagingengine.com (fauth2-smtp.messagingengine.com [103.168.172.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: dch/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TYHk43jQCzHKl; Mon, 12 Feb 2024 08:31:40 +0000 (UTC) (envelope-from dch@FreeBSD.org) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfauth.nyi.internal (Postfix) with ESMTP id 957FE1200043; Mon, 12 Feb 2024 03:31:39 -0500 (EST) Received: from imap44 ([10.202.2.94]) by compute2.internal (MEProxy); Mon, 12 Feb 2024 03:31:39 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdff rghvvgcuvehothhtlhgvhhhusggvrhdfuceouggthheshfhrvggvuefuffdrohhrgheqne cuggftrfgrthhtvghrnhepteektdelveeitdektdeifeefueffudeukedtfeegvdetkeeu heefgfeiudelgfdtnecuffhomhgrihhnpehfrhgvvggsshgurdhorhhgnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggthhdomhgvshhmthhp rghuthhhphgvrhhsohhnrghlihhthidquddvgeeluddtfeeguddquddvudefuddujeejqd gutghhpeephfhrvggvuefuffdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Feedback-ID: icedc46df:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5C49436A0077; Mon, 12 Feb 2024 03:31:39 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61 List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-transport List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-transport@freebsd.org X-BeenThere: freebsd-transport@freebsd.org MIME-Version: 1.0 Message-Id: In-Reply-To: <202402100934.41A9Y11l044213@gitrepo.freebsd.org> References: <202402100934.41A9Y11l044213@gitrepo.freebsd.org> Date: Mon, 12 Feb 2024 08:31:19 +0000 From: "Dave Cottlehuber" To: "Richard Scheffenegger" Cc: transport@freebsd.org, dev-commits-src-main@freebsd.org Subject: hitting Assertion !callout_active(&tp->t_callout) failed at /usr/src/sys/netinet/tcp_subr.c:2386 after 62d47d7 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, 10 Feb 2024, at 09:34, Richard Scheffenegger wrote: > The branch main has been updated by rscheff: > > URL:=20 > https://cgit.FreeBSD.org/src/commit/?id=3D62d47d73b7eb01f3b0a37541df5e= 7aaa36f54335 > > commit 62d47d73b7eb01f3b0a37541df5e7aaa36f54335 > Author: Richard Scheffenegger > AuthorDate: 2024-02-10 09:28:42 +0000 > Commit: Richard Scheffenegger > CommitDate: 2024-02-10 09:30:00 +0000 > > tcp: stop timers and clean scoreboard in tcp_close() > =20 > Stop timers when in tcp_close() instead of doing that in tcp_disca= rdcb(). > A connection in CLOSED state shall not need any timers. Assert tha= t no > timer is rescheduled after that in tcp_timer_activate() and verfiy= that > this is also the expected state in tcp_discardcb(). > =20 > PR: 276761 > Reviewed By: glebius, tuexen, #transport > Sponsored by: NetApp, Inc. > Differential Revision: https://reviews.freebsd.org/D43792 > --- > sys/netinet/tcp_subr.c | 4 ++-- > sys/netinet/tcp_timer.c | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c > index 6043a3d458e5..90e1496a822c 100644 > --- a/sys/netinet/tcp_subr.c > +++ b/sys/netinet/tcp_subr.c > @@ -2383,10 +2383,9 @@ tcp_discardcb(struct tcpcb *tp) > #endif >=20 > INP_WLOCK_ASSERT(inp); > + MPASS(!callout_active(&tp->t_callout)); I'm repeatedly hitting this assert soon after boot on my ryzen desktop. = I've a coredump. Panic String: Assertion !callout_active(&tp->t_callout) failed at /usr/s= rc/sys/netinet/tcp_subr.c:2386 I'll apply your latest patch in https://bugs.freebsd.org/bugzilla/show_b= ug.cgi?id=3D276761#c16 and report back.. __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:57 57 __asm("movq %%gs:%P1,%0" : "=3Dr" (td) : "n" (offsetof(s= truct pcpu, (kgdb) #0 __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:57 #1 doadump (textdump=3Dtextdump@entry=3D0) at /usr/src/sys/kern/kern_shutdown.c:403 #2 0xffffffff804a39da in db_dump (dummy=3D, dummy2=3D, dummy3=3D, dummy4=3D) at /usr/src/sys/ddb/db_command.c:590 #3 0xffffffff804a37e0 in db_command (last_cmdp=3D, cmd_table=3D, dopager=3Dfalse) at /usr/src/sys/ddb/db_command.c:503 #4 0xffffffff804a3926 in db_command_script ( command=3Dcommand@entry=3D0xffffffff817b9724 = "dump") at /usr/src/sys/ddb/db_command.c:568 #5 0xffffffff804a8c88 in db_script_exec ( scriptname=3Dscriptname@entry=3D0xfffffe0346e96680 "kdb.enter.panic", warnifnotfound=3Dwarnifnotfound@entry=3D0) at /usr/src/sys/ddb/db_sc= ript.c:301 #6 0xffffffff804a8ab2 in db_script_kdbenter (eventname=3D) at /usr/src/sys/ddb/db_script.c:323 #7 0xffffffff804a6b81 in db_trap (type=3D, code=3D) at /usr/src/sys/ddb/db_main.c:266 #8 0xffffffff80ba2aa2 in kdb_trap (type=3Dtype@entry=3D3, code=3Dcode@e= ntry=3D0, tf=3Dtf@entry=3D0xfffffe0346e969c0) at /usr/src/sys/kern/subr_kdb.c:= 790 #9 0xffffffff81057fd6 in trap (frame=3D0xfffffe0346e969c0) at /usr/src/sys/amd64/amd64/trap.c:606 #10 #11 kdb_enter (why=3D, msg=3D) at /usr/src/sys/kern/subr_kdb.c:556 #12 0xffffffff80b532d6 in vpanic ( fmt=3D0xffffffff8120a0cb "Assertion %s failed at %s:%d", ap=3Dap@entry=3D0xfffffe0346e96bf0) at /usr/src/sys/kern/kern_shutdo= wn.c:961 #13 0xffffffff80b53163 in panic ( fmt=3D0xffffffff81980440 "\202\221\024\201\377\377\377\= 377") at /usr/src/sys/kern/kern_shutdown.c:889 #14 0xffffffff80d585e1 in tcp_discardcb (tp=3Dtp@entry=3D0xfffff808d767c= a80) at /usr/src/sys/netinet/tcp_subr.c:2386 #15 0xffffffff80d64e81 in tcp_usr_detach (so=3D0xfffff8012ccd0780) at /usr/src/sys/netinet/tcp_usrreq.c:214 #16 0xffffffff80c05151 in sofree (so=3D0xfffff8012ccd0780) at /usr/src/sys/kern/uipc_socket.c:1205 #17 sorele_locked (so=3Dso@entry=3D0xfffff8012ccd0780) at /usr/src/sys/kern/uipc_socket.c:1232 #18 0xffffffff80c05fad in soclose (so=3D0xfffff8012ccd0780) at /usr/src/sys/kern/uipc_socket.c:1302 #19 0xffffffff80aed71b in fo_close (fp=3D0xfffff8064b7362d0, td=3D0x80) at /usr/src/sys/sys/file.h:390 #20 _fdrop (fp=3Dfp@entry=3D0xfffff8064b7362d0, td=3D0x80, td@entry=3D0xfffff8012cc91000) at /usr/src/sys/kern/kern_descrip.c:3= 666 #21 0xffffffff80af0f83 in closef (fp=3Dfp@entry=3D0xfffff8064b7362d0, td=3Dtd@entry=3D0xfffff8012cc91000) at /usr/src/sys/kern/kern_descri= p.c:2839 #22 0xffffffff80af4ea6 in closefp_impl (fdp=3D0xfffffe02e1a24430, fd=3D9= 5, fp=3D0xfffff8064b7362d0, td=3D0xfffff8012cc91000, audit=3Dtrue) at /usr/src/sys/kern/kern_descrip.c:1315 #23 0xffffffff81059473 in syscallenter (td=3D0xfffff8012cc91000) at /usr/src/sys/amd64/amd64/../../kern/subr_syscall.c:186 #24 amd64_syscall (td=3D0xfffff8012cc91000, traced=3D0) at /usr/src/sys/amd64/amd64/trap.c:1192 #25 #26 0x00003069693b76da in ?? () Backtrace stopped: Cannot access memory at address 0x30696c9b9818 (kgdb) (END) A+ Dave =E2=80=94=E2=80=94=E2=80=94 O for a muse of fire, that would ascend the brightest heaven of inventio= n!