From nobody Mon Dec 22 16:02:15 2025 X-Original-To: dev-commits-doc-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dZjZc2DVzz6LNt7; Mon, 22 Dec 2025 16:02:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dZjZc1WRDz3ZgJ; Mon, 22 Dec 2025 16:02:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766419336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MABniitihes/GOVNeqxAIG3PLw3dF0tbwNY/oSeSQIc=; b=EuuiJRG3ypRfQSo1Zlv35lajmg3HL/OiD67chhb8DlgEjbN/PUc4cohjugqn0qeE9qyFxx KE6PCf8p7vl+OTGs7XI4VL3wYSeh6TQXKuh1EoRgg01No1VTf8CAExQergh7BnXxDs5bnx rpNke9EVAMZfZIFT6zIXeYsNPzpulQbU9bYhgagLdvOSwmSs5NNwRUqQ8CKUI7Z4Y/ceOS XtRmhl/oL2oPrmv7w7UV26XP7ylOqnuKn44BA4Ht13DUqKAer+LS4NqT9iKY/8HCUZ8Abx fqggdD2eHx+EdU0mU1N/GDxkgd/3SesRfUzrZ9ixSyipqSv4Y0nwmL8N0gX5lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766419336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MABniitihes/GOVNeqxAIG3PLw3dF0tbwNY/oSeSQIc=; b=jQfj+W/TxNozlYpQ2JpgyA7I/mUH1aOuoCNuwBM3/5LQjFo+em9BadHYh2nYKpOTJfoEnw D+x9GRaHkBmjg78XdA2LXlrO6lbxv+fbbahi5R6M95jRpRge492YZxDR2HpT8e7Qo4aPjc ktHDtHAkiP8jMnjnWfgWxERrkQHOlYMNlAvlqmOTba/h33CWHvOBh7nxumq3gvz/zrrMxT 6OHYvUydF4PyhCKEjIA6bGtaWObgbj8ffOUs9y6+TBuFbKwldW4karYohdMFym8ARTCmbp wZ8fjM4Bz1Yr4FAcvsjCufxqU1/qfdGEbfbS5d2KCq1yR+UuxNXb6IxZ8UF5Jw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1766419336; a=rsa-sha256; cv=none; b=WHUalbcVMKng79hsvtA/xmSG86OyImxQ1PFTNHPluVdxY0+HAwFNxK5IRG2OVNDqogMRCQ 70LBSRcQ1d+nHVWnOUraNC5r4+SEfBKX5q6ezjkHgrfIWRp89D8yu0Lv+mZp18bm66POjE 9Pk95gEYVnZBjVSKExJ2tjwRsMhphCyoa4Qb6KZ2og4/UBkTzAtyVEBrsu4nBhwBRvUS29 fc/BegVsFq96Kdc9a3yImvsPWd+KqNGfoPdk9G7shiL1EH/sKEL82boJNV0gG4epvzHL3N k7oOIhQFPd0pwol05Vn1qos8dYkgVLTFvlN8VOBMVeYfn0zQc00e/xwe0noAPQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:5c0:4202:5670:296a:1fca:5ea5:94da] (unknown [IPv6:2601:5c0:4202:5670:296a:1fca:5ea5:94da]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4dZjZb6xN9z18gV; Mon, 22 Dec 2025 16:02:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <273f7ba2-f3b0-4a1d-8267-dc48c8d659e2@FreeBSD.org> Date: Mon, 22 Dec 2025 11:02:15 -0500 List-Id: Commit messages for all branches of the doc repository List-Archive: https://lists.freebsd.org/archives/dev-commits-doc-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-doc-all@freebsd.org Sender: owner-dev-commits-doc-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 481fce462d - main - Document various missing __FreeBSD_version values. Content-Language: en-US To: Rick Macklem Cc: src-committers , dev-commits-doc-all@freebsd.org, doc-committers@freebsd.org References: <69447e71.46420.2787bc4a@gitrepo.freebsd.org> <987ad115-9c14-4f5e-8e1d-ef69f84afd9e@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/18/25 21:56, Rick Macklem wrote: > On Thu, Dec 18, 2025 at 5:45 PM John Baldwin wrote: >> >> On 12/18/25 17:53, Rick Macklem wrote: >>> I'm guilty. But someone said that it should only be bumped >>> if no one else has bumped it recently. (Within a few days?) >>> >>> If it isn't getting bumped for every change, the document >>> is basically useless, isn't it? >> >> The main reason it is documented in the porter's handbook is so that if ports >> need to use conditional logic, this is a reference to which versions to use. >> >> Ports doesn't need perfect granularity (especially on main), just something >> that is "close", hence why bumping more often than, say, once a day is >> probably overkill. > Well, for my case it is inevitably "the internal KAPI between the NFS > modules have changed and all of hem need to be rebuilt from sources". > (Since this cannot affect any port, does it make sense to document it?) > > I do put entries in UPDATING. I do wonder for your case why you are bumping __FreeBSD_version? For other API changes that are internal to the kernel (and modules shipped as part of the kernel), we don't generally bump __FreeBSD_version. Changes to APIs include changes to source files (including headers) so the compiler should already recompile the right things based on dependencies for users who are upgrading via source. Our current binary package systems for the base system (both dist sets and pkgbase) always treat the entire kernel + modules as a unit, so users should never get a mismatched set of NFS-related kernel modules using binary updates either. I think the only case where bumping __FreeBSD_version for these commits can catch something is that if a user builds the NFS kernel modules by hand (e.g. cd /sys/modules/nfsfoo; make) or copies a module manually, the bump will prevent loading a new module while an old kernel is running. It won't though prevent loading an old module against a new kernel (the check we do for kernel modules on main and stable branches is just a <= check, not an exact == check). Given that, I'm not sure you need to be bumping __FreeBSD_version for changes that change APIs between in-tree kernel modules that are not used in ports. -- John Baldwin