From nobody Mon Jan 6 05:39:22 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YRNKR11tKz5jxV5 for ; Mon, 06 Jan 2025 05:39:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YRNKQ5FLWz5797 for ; Mon, 6 Jan 2025 05:39:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736141962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NsKjMWS29qP+pMI7ckzq+9O9FvVovHx7GQGBR+R/Fok=; b=S5uy8qOAAcvGT1GnB9rC/CcLpuIrx9lCk7WRkMMukh50fMAGTUUo6ff8a0GkGFCbVxCL0d 0Lb2DICo/lW9GHU5JvGwFBNUbkaiNHIE+zHo9kZUbCnK5M/jKX+joINztW3+mt+CYJxksu xRRslsxHL0EAFCgxY6oks/StP20C+CnMn8rl1qBzwNx/8NadHklqL6O9x0/pG6+iRIztV2 Mp7ibjTMFjphqfkBwhcWb0slEQhzv26uJYfTLHiG02npU2snQODTYfolyKks09ncFHUiEk B78Jej4fa9GtipxMIyzKF5NihwwscT21bHOvkS+vUO6g8wGmAyBcKmsZ6bWPhg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736141962; a=rsa-sha256; cv=none; b=oVPpBwcQZsu8l53QmP89PVbDUfSEfMyD4y1maPPYfwl7NXbClb/pM6mqoI5f3SgBCSdkGg z3NV0W+2xvV8mumWtyVAeqh6oNgjEYc3SZdjZc8LswMpE8QGySJwQBUkVJaeBhXtZVezj0 Fyneba3zQ7LTwrf/yvVDflBlaHwLRoM9h8Bzi7CxMbDr1Fn19o3TRvRfYqVJ+s+4aNhmZJ 3BO6BXvlKUjqqbxkLB+QalnDZIhJtmkM1r1WigG/neP1Q7zD3GVQuVl0Cl4VvCt6B/xLLR O1zksWgHthzKVmHS3+CoLmxGkK112HGeEuzyXJjTNQdI24IbMLUVwf48EgUhIg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YRNKQ4ZF4z19Fg for ; Mon, 06 Jan 2025 05:39:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 5065dMvZ051792 for ; Mon, 6 Jan 2025 05:39:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 5065dMlM051791 for net@FreeBSD.org; Mon, 6 Jan 2025 05:39:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 283848] rtnl_handle_newroute() incomplete check of attrs.rta_table Date: Mon, 06 Jan 2025 05:39:22 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: grahamperrin@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: melifaro@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283848 Graham Perrin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |net@FreeBSD.org --=20 You are receiving this mail because: You are on the CC list for the bug.= From nobody Mon Jan 6 15:56:55 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YRf260XjMz5jmBr for ; Mon, 06 Jan 2025 15:57:02 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YRf250xTDz3wZy for ; Mon, 6 Jan 2025 15:57:01 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=eCrrNtPI; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::d2a as permitted sender) smtp.mailfrom=markjdb@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none) Received: by mail-io1-xd2a.google.com with SMTP id ca18e2360f4ac-844ef6275c5so505664439f.0 for ; Mon, 06 Jan 2025 07:57:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736179020; x=1736783820; darn=freebsd.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=xsdC8Yro+KPOgyMqmPanG8jHNtwrXGYuoMoWwfBlPjY=; b=eCrrNtPIn5uUfK5UvtY1VSbeJsZwlzw8DcxmC0ss7Yz8MAAk0zIaMCwB+bnpqUPxg8 JseAgnpftUN6DsEXblTLn722L+qE4YoOsDp+2bWKWFbsiB4Ltdm9Rxb1zDUqJXdV/Hlz ZySO/YBD3pYojiQnJM/DEp+pCQF5eq4R3v7IUAMmeaVlrvMTlZswpfkIepbJyr3hlmwE MHxfMkK/vOT//HgT7Do/H9qV1tx7tNgjM42eGmpDX/68oOwUh5ogHIXx4CBAgCDBwWAE oMCD1bPMp36yUPyPr/xqEe8eIOrcwB5ajttH1iBE4XZIKq9XmOGL/nKAAhfcU/zBj07X dTEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736179020; x=1736783820; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xsdC8Yro+KPOgyMqmPanG8jHNtwrXGYuoMoWwfBlPjY=; b=MLIUFW1lE9lNTctDRLbaELK4gsqz/gKqll9i6iCmBMpQ5B53ljk0kbJ/XeAOGQuJ74 KMUbQqVVpyR+kJO/WTfIzZu+L8z0yPWZSH1z9coChheU9wEjFzSEwDj5xVZ9Kk+Hupxs ctC88o7JJWt6fmqM6fniRxULC/B46ykp3wPbOR1bdw6uwatB16RGmlPZm7l+NLhEs/rS 34QFA+B3WDypMutxNeGwyJmol2AHiwt2M4MhNmMo7MUqE2vaNidC3jlC3bLeeiEln4AQ Zyv+q9lZXsG3nRvQ51Yx0r3cj3RQV4jjt+oNMHIvPNpoa7MulzvXVE1igbrW8UDBoC9s ztbQ== X-Forwarded-Encrypted: i=1; AJvYcCU5r6CLO/i4KXF8VQwRKYRbar9ztFEyrwTkD+eTM+XmkCUAYmGiAIb1Rf9pbA4B33C23ZYJwwtbO9ps5g==@freebsd.org X-Gm-Message-State: AOJu0YymvhyXjAZfzRzJoXMp6qlY6M2+pgWOXcru8KN5xJIt0FFfv4RN TfKI1ltrTI9fJsCV65bZYfwIeleiR8MX7iRBE/eJOlD4+nM9yJkEMIVInA== X-Gm-Gg: ASbGnctBLNAbcwVsY/iJFaEFSo8FnxA516r3ujePdYmK4tcW5nMtO8xTPfsQz+E5YTF ma+8Gj6zcAzwM0jLU0MSo1V5waIB8KKgQE8V+ffrg/Py6Vabdlbv8ivSzLXORbF3ONnPlYBiQmj aqQ+1c1vYICe0JbxerLlSEC4stnV4VWGhAd4ieckS16+LgDbKHUm9Jb6eEolgfhOl/RqE6gaSp4 XDsrm+E5lKufKcDk0nrzeGSWRk6DuOAEJ3c/rgX6BIrJNXYSDDm/f4CJqpmB30XZIOwl/M= X-Google-Smtp-Source: AGHT+IFeqmOQpGpAtQa/HIOkxMapw/pPc9zUmreti2Yo1AA+EiaJ+Pu3eSzqhO6ABplRqhgG1oD8Kg== X-Received: by 2002:a05:6602:3a8b:b0:84a:5280:596f with SMTP id ca18e2360f4ac-84a52805b2dmr1804400239f.9.1736179019863; Mon, 06 Jan 2025 07:56:59 -0800 (PST) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-8498d7dda03sm885053939f.17.2025.01.06.07.56.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 07:56:58 -0800 (PST) Date: Mon, 6 Jan 2025 10:56:55 -0500 From: Mark Johnston To: Paul Vixie Cc: Santiago Martinez , Jamie Landeg-Jones , freebsd-net@freebsd.org Subject: Re: per-FIB socket binding Message-ID: References: <7772475.EvYhyI6sBW@dhcp-151.access.rits.tisf.net> <28EF197D-0D10-449A-A3C5-8B931F31CA6C@codenetworks.net> <38589000.XM6RcZxFsP@dhcp-151.access.rits.tisf.net> List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <38589000.XM6RcZxFsP@dhcp-151.access.rits.tisf.net> X-Rspamd-Queue-Id: 4YRf250xTDz3wZy X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.60 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), DKIM not aligned (relaxed),none]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::d2a:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; MLMMJ_DEST(0.00)[freebsd-net@freebsd.org]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] On Fri, Dec 27, 2024 at 08:48:48AM +0000, Paul Vixie wrote: > On Tuesday, December 24, 2024 3:34:45 AM UTC Santiago Martinez wrote: > > Hi, > > here’s another user of fibs. Each of our servers have multiple fibs and > > jails with fibs. I like the proposed. > > Santi > > Cool. Read on. > > On Tuesday, December 24, 2024 5:06:32 AM UTC Jamie Landeg-Jones wrote: > > Paul Vixie wrote: > > > ... > > I like that. I isolate 5 seperate networks by assigning a fib to each > > interface, and was initially surprised that I had to jump through ipfw > > hoops to get it to work properly, in fact at the end of my ipfw rules for > > these interfaces, just to guarantee no leaking, ... > > > > So, yes, I agree that it's crocky, and your proposal is how I originally > > expected it to work, and indeed, I can so no reason for it not to work that > > way, but am prepared to be enlightened if anyone else has an opinion on > > this. > > > > Jamie > > Groovy. See attached patch. This is just for TCP since I have no way to test SCTP and I > think UDP will have to be handled at the application layer. There are two one line changes > here. > > First, save the FIB number from the SYN in the syncache. This FIB number was in the > incoming m_pkthdr so I didn't need to change any function signatures. Note that if the > listener socket has a non-zero FIB number it will be used instead of the interface FIB > number -- it's more specific and likely to be right. > > Second, when the initial ACK arrives and it's time for the connection to exit from the > syncache and to become a socket, restore the original FIB number and apply it to the > cloned socket, which will already have inherited its FIB number from the listener socket. > > This works here. The diff is for a 14.2 kernel but is likely backward-portable. I'd very much > like to hear anybody's experience with this patch, or commentary on its approach and/or > advisability. I think the patch is probably a good idea, and the trick of only inheriting the packet's FIB if the socket's is non-zero would avoid breaking compatibility for most cases. One side effect of the patch is that a service listening in FIB 0 that has no route to the source address of a connection attempt from a different FIB would previously not accept such a connection, but now it will. Perhaps that's drastic enough to warrant a sysctl and/or sockopt to control this behaviour. > diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c > index 83f85a50e..0e030f24f 100644 > --- a/sys/netinet/tcp_input.c > +++ b/sys/netinet/tcp_input.c > @@ -1057,7 +1057,7 @@ tcp_input_with_port(struct mbuf **mp, int *offp, int proto, uint16_t port) > } > inc.inc_fport = th->th_sport; > inc.inc_lport = th->th_dport; > - inc.inc_fibnum = so->so_fibnum; > + inc.inc_fibnum = so->so_fibnum || m->m_pkthdr.fibnum; > > /* > * Check for an existing connection attempt in syncache if > diff --git a/sys/netinet/tcp_syncache.c b/sys/netinet/tcp_syncache.c > index 15244a61d..a50648fa5 100644 > --- a/sys/netinet/tcp_syncache.c > +++ b/sys/netinet/tcp_syncache.c > @@ -805,6 +805,7 @@ syncache_socket(struct syncache *sc, struct socket *lso, struct mbuf *m) > */ > if ((so = solisten_clone(lso)) == NULL) > goto allocfail; > + so->so_fibnum = sc->sc_inc.inc_fibnum; It would be better to pass the fibnum to solisten_clone() and assign it there. Otherwise, the value of so_fibnum will be wrong for a short window during which the socket is passed to MAC and other hooks, which might have some surprising effects. > #ifdef MAC > mac_socketpeer_set_from_mbuf(m, so); > #endif From nobody Mon Jan 6 23:32:56 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YRr8S466wz5kQCX for ; Mon, 06 Jan 2025 23:33:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YRr8S1HYcz42nK for ; Mon, 6 Jan 2025 23:33:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736206392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YnM+eoPdPDVYR2ar7rzBUsqblCW2h8BMCg8PutmaFRo=; b=hFddQuNrt8mSbIps/A3CwtG9eNP+FbV38dwSG0J2vcUySZmbMu3VeNo0XlOxKrMG1n/y7r vlhwQuW4T5BOQtP7QU4MvecG27kmRGTTHI5DGLpd4Kh2ZilDpQ/n90z6+h4nx6jGjcwDjK oP+b9Fz5BaxWAXRrvUNRipNNvIBInXB+rcy8lGND2scKZCWbBuojCQTZJNBVjhCe9sGn9M hEHswBg7d4Mjpx5ZvlUMAW3/6g/BkKfl9Hlh+pZkmuwtGHzrXOj+ub45hPr4A3MbIjss8V V/JVHqZQRLjmppZhQDojgM/HzHVol7zlT9Fy4ElR/2QNYxo2nmi5SsGHRi+HHw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736206392; a=rsa-sha256; cv=none; b=dtv/9R0R72Z2ReML2giTE5xVVYkPbOA7aR++y6F1khO4I2MWUf0gsb7BqIsJLHbftQym1W f1K5qB7dgD6Z57kJ+Pgvyoj3llFAJvTXZj1VYNrIN4WC+/4hgoghOSSwT3XEHmx81XgSqf caslfkcQ+pGVXvinFV8EKmJbjvcgfR99WS1bxfBmcOt8fp1jP8XoMZg9hZCQBkBccWysxu 9xkwcFg6PBCTCoKCvXuirQ4c7ldXEl0/Nw4xeSuKJtMrqqsUcaDI4TwUYURFtweLEqlVQ7 ujbYOxGS3hV+bMbWMmbeeNwQlNn7f2y+E905Jz0P4cGX5dN+mBEFEZt1A3uAZw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YRr8S0h04zlxk for ; Mon, 06 Jan 2025 23:33:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 506NXClp089813 for ; Mon, 6 Jan 2025 23:33:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 506NXCas089812 for net@FreeBSD.org; Mon, 6 Jan 2025 23:33:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 166724] if_re(4): watchdog timeout Date: Mon, 06 Jan 2025 23:32:56 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-RELEASE X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: mca_two@hotmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D166724 mca_two@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mca_two@hotmail.com --- Comment #125 from mca_two@hotmail.com --- I never had the issue but since I switched to 14.2 it seems to happen once a week or so. What is the accepted workaround/fix? dmesg shows: re0: port 0xe000-0xe0ff mem 0xf7104000-0xf7104fff,0xf7100000-0xf7103fff irq 19 at dev= ice 0.0 on pci1 re0: Using 1 MSI-X message re0: ASPM disabled re0: Chip rev. 0x54000000 re0: MAC rev. 0x00100000 miibus0: on re0 rgephy0: PHY 1 on miibus0 rgephy0: none, 10baseT, 10baseT-FDX, 10baseT-FDX-flow, 100baseTX, 100baseTX-FDX, 100baseTX-FDX-flow, 1000baseT-FDX, 1000baseT-FDX-master, 1000baseT-FDX-flow, 1000baseT-FDX-flow-master, auto, auto-flow re0: Using defaults for TSO: 65518/35/2048 re0: Ethernet address: 18:31:bf:70:12:6e --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From nobody Tue Jan 7 00:09:02 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YRrxt1BkCz5kSLt for ; Tue, 07 Jan 2025 00:09:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YRrxt0B56z46g2 for ; Tue, 7 Jan 2025 00:09:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736208546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pah4X5s5VK5DdHNCskgkWS1ss0MDX8zrEnFEQVeIMsM=; b=GAHJcSMicSrIB+Lwl0UQOiCMB5i8ujcDdbw3ADhopv8xGMeZ56l5zxsktT+uz7Ty30nB6J QaSTsm6sOkLUDttAjIuit+6Hl+bf7guYacJ4B5CwNrSyeH1Gub/q/3bfQxZwIZpAEOvjE6 220xdoLz9Wtbhyzu3C6hsfr0cISE0nQKhDgmQjuNI4BmdWOP/VHk4RgnofleLfvmUBCiQM fgOmSDIrrr3kkIVM8GiJf0iG0w23b2FB586blIcx12WKVCS+IdvYH19DBjWO9h+RROoPw7 rvwxRV2EMkWXTHLtWz/Siq13JpI8xX0e2IavaNQEEMniC/s0okUHYykLeYOYsg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736208546; a=rsa-sha256; cv=none; b=G1B3GYltC6c4IeTqEYxkKnHD2jgDsyQv3nJPJ0u6I4VsIQsphRfsZ8IPau3uXiq7A1D8mP 7myO+d3bSjDFVOpNgwz//NHLaB2wPTKL8JTa5Kr55pxKWjjd89sA0x1ML+ynqQuN6a80Nc nzmO/7x1ogqmkcN4I4bdvephr3SDbgdaaUScLJ+1FAixyZM7UsKyMwp2ghksHFNMoWXHVZ hun7PHu7TB4z+bqFoIwPasg+/ssFOkZvw7h9+rfuslgQgL4pwC7EYalgDzqrgl/TPO/Nzx Zpas9VLMehGJX47etGzahQpxIzzpWTfhIUFBEVwc33iU10ZV2JxlOHJHDgNeSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YRrxs6c1Vzm0P for ; Tue, 07 Jan 2025 00:09:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 507095QM048803 for ; Tue, 7 Jan 2025 00:09:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 507095LD048802 for net@FreeBSD.org; Tue, 7 Jan 2025 00:09:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 166724] if_re(4): watchdog timeout Date: Tue, 07 Jan 2025 00:09:02 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-RELEASE X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: george@m5p.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D166724 --- Comment #126 from George Mitchell --- The consensus of the 124 previous comments is use your choice of the net/realtek-re-kmod or net/realtek-re-kmod198 ports instead. The second has more of a track record and seems to work every time; the first is based apparently on Realtek's version "1100" driver and fails for some users but = not for others. Your mileage may vary. --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From nobody Tue Jan 7 10:33:20 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YS6pC0Hzwz5kKlG for ; Tue, 07 Jan 2025 10:33:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YS6pB69KLz55B5 for ; Tue, 7 Jan 2025 10:33:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736246002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DIZF7oYUbx+G2Lk8ymqWimFn8ZNgW/1JTz3GA5kodzw=; b=ch/p0PPmmQM5Y2EW312cJYmR9VdjOGCtxuk6vfyXT242BeTxprTCy1APbnPvkQQDl9IxkD W8uhy6f+l33l5GnNSY0HKLfyQUVvBWKNNZjN1RYF1hYn9qUQ4JMGt3jp6FMLcLz6PXJDS/ W845T3B8qF3o501n9akXiV34CqebQMIuMpoGWirTrdaSuy56yTM1dSHUlKiqXcDTSHA8AQ 1jKzJBvwRRUxWNSbIl7I7PdToLntdAdHqxB+aVRLPMgyC+VhOT6+mfhRfpde8hGb3H29pt x0V6zL6Fpbq0HJPJdRJKQ77fKfrkmG5UguvVU90Eefy60nlQCcfyWj8sqyDYZQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736246002; a=rsa-sha256; cv=none; b=o1N/vElpJgn05XGh5FgOAu4jygbJW7UaUvwtSszfPcXHYjPtkw2L0Jx0CDH870ckVqDucZ 3jzHDYlp4+KgejxHGehr6/I+5RO4DNZXJuB/+OYNVzubjV+N0gZ523KA9VgpyjPpxd/9ou 59FdNJM1D3b7qeXxnzkSM6yjWSRS5xnEB86ghy3WngOy/LfDeqIQKAjN0khdtuj0BadiGu l5sJwYd8l0EChpQI02+0KPQTCR9zKmLD+akZmShTcL66pFMaeOjroaWWTULlWAV83+JBCC eNYT3oB7ZxMbzX+H4fVohrnQWYYOcn4+rHIJf6XOH10FltIixJxGt57/oFT6cA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YS6pB5g73z162G for ; Tue, 07 Jan 2025 10:33:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 507AXMgo054164 for ; Tue, 7 Jan 2025 10:33:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 507AXMB8054163 for net@FreeBSD.org; Tue, 7 Jan 2025 10:33:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 166724] if_re(4): watchdog timeout Date: Tue, 07 Jan 2025 10:33:20 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-RELEASE X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: vova@fbsd.ru X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D166724 --- Comment #127 from vova@fbsd.ru --- I've ended up switching to igb0: for the truth - this host is quite old (>10y) if_re worked quite fine for a= ll these years and started to glitch only after upgrading to 14.0, driver from ports helped a little bit, but it still get stuck time to time. Then I've switched to em0: and ... it also was glitched=20 dtrace digging shows that 'iflib_if_transmit:return Error ENOBUFS` so, no hints what was changed in 14.x ... anyway, hardware upgrade to igb0 helped ... Also, on other host re0: works quite fine for me with base system driver --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From nobody Thu Jan 9 05:03:00 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YTCN468Vgz5k0mn for ; Thu, 09 Jan 2025 05:03:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YTCN42L3Cz4BpG for ; Thu, 9 Jan 2025 05:03:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736398980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OvOcwQ54jzaqrjf73Qu4equIhw8fauqs9LfDzlI0pQo=; b=Nh7HaTuwiNSMON/LlZd28SbAeDjI0O95oyxiWvDbA4/VOUsvoBrF471KE/I3CLcKu55RgT sPtugH3M43Bv4jkWoSWMpICdIMgS4351Rqht1Eypk/sHfkMElYQ9MTprQMZ/ORMYyXEnQB nkb3T95D3yXGU+3JvkV98YQVNq66DhGtNndFrr9J9j/Oql73CucqT97w95v/xkMZg48IQX 5/Ztw5igWaHZd4m5LrKcFG9pv+CUrsJ03NzIXXkCmYtujJVYE+2HLqhkQ/WgzNHbUB2sYB WCelKIlrNv+L7IXSldoyfXr+4NRTIW7sHoDZ1NjuBGT/FRb8RUuaEa2PZIHVNQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736398980; a=rsa-sha256; cv=none; b=dQ/Bq1M/KIHz7VkuK+0dRcLpqCm1rx0Q9JpoWIcTbGvOc5lJKC3MtjyDxqaYm+6KEytnyt DB3rAvqZI/KHeBJ+flLxqsaiAyCzfnD8r8C3wcTrJrJAjmfqAQPWrN3Nraer/Ht5jsOTmt FCPfeF5z4AfZaaoIifR6Y9x86PvhOg7ee8/C5a8xKDxgNyxROa7tOZzntaFSIqEMqHb3Vt /HpRzayjD3XuQJ3u0eehfijXnxOtvFLQFFu7/cwbH+oqj8ELm6PjpN0+79Mxystsxz+/Sy zD/mqKv1+eSZHoTFGk/N7zJb8sgOXc6ddcuLx+PFjNiODWLb+PzwMrNoXtzBcw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YTCN41yVTz1Qjx for ; Thu, 09 Jan 2025 05:03:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 509530Yo015519 for ; Thu, 9 Jan 2025 05:03:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 509530M9015518 for net@FreeBSD.org; Thu, 9 Jan 2025 05:03:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 283938] panic due to race between ether_output() and ng_ether_detach() Date: Thu, 09 Jan 2025 05:03:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ziaee@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to cc Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283938 Alexander Ziaee changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |net@FreeBSD.org CC| |nyan@FreeBSD.org, | |ziaee@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Thu Jan 9 15:31:17 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YTTK25GYnz5l0gp for ; Thu, 09 Jan 2025 15:31:18 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.chi.freebsd.org (mxrelay.chi.freebsd.org [IPv6:2610:1c0:1040:6064::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mxrelay.chi.freebsd.org", Issuer "E5" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YTTK23YgLz4FgV; Thu, 9 Jan 2025 15:31:18 +0000 (UTC) (envelope-from daemon-user@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736436678; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MFD7FEjnwCPfaBwN49dUtGWKPmCPvm8/G6W14E26k7I=; b=I3HExF3WOShZxzlNE9Gqap36NzVeBX6cQpSELkgZiGE3OlMafVBboeo6iTEmlW8HE7xqdA 6l7jgSqUojz9XQmRrOQ886FOzb1/TiZn6j6GAmucVNqHEtDQKmFDj8SlngvO+kvN0+bz45 t02bd880kO1MvFnCHSgLlj7G3PESpSfy28iOZAel8naB2kwe4S8QbLAZnRuHvuX2ScKHp9 +vcuLq5RRCSRuMp23ww/5z0ogsVnOItFw1A+1Y4OjdJGivEA6Q6U80xAVRFWyAo8M7iypy xdxwR+JRRnHPUfHvHNTtC/Liv++D9m38fO5mOcrIFiCOjvktogFqW/+thE3Fog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736436678; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MFD7FEjnwCPfaBwN49dUtGWKPmCPvm8/G6W14E26k7I=; b=JSwnaJY9p7sI43xDgcMJt78uFDHs6aYutyzsAop73e4hkQw0unNwSb93sOOkfvxvgQ9NNq hV9ofPfNluNqkVbzogItRAQrFoN7W23+cMVrBrUlSVGHjIbV975VtulW8fONiE3On2tdT9 1ejiAW/4zVg4FlFXGG9oXhLmQjMu6oFGTBi3Mz6BpDfxmaWCII+f3lnai0NSNAvUYHleAD VouiVa1HZC5gno4r9oo2Eh6jTgk8k/ib6u4vD2E0wl2HQ8FzZZHzhHBVrnnWtHIumHk/wf 0z0iMtf8BnCpV78dlVQGN+x1Kwyj6PAsJXiW+r4JP7sTDQziv2kTNgLIPb+0tQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736436678; a=rsa-sha256; cv=none; b=tjvDwlf7G7aK9gY2tMyjy2k5tW15Yr3g8xaM5G4KfWB5mubMARukZeWZi3Ei0D9XzmExvz nFTva/CzyfXbT/2cvxfywTQw6UypU0WbSOL8RlNzKhW0+BO6P+QkJDxUJLli0xV+FzFnd5 6iVwgtRUFcGcmXbcBIJm8FcUDTeVP9Jr2vIQ1SIDyizEMDXrlQpfhLfWkm5NtXXJ9Vni1T foHXDJOhIPyv5HrSJmtp0tmwJZSv/rZ2mB5kKJrlNrByC0OiL93rbGZrrR2qT+XsgWCC/N 6k+sFSh+Kza5hmUEsDx3SRHRGht36Bk+C5erZfWoVOOGxprOTcOHMUJE/nqXYQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from reviews.chi.freebsd.org (reviews.chi.freebsd.org [IPv6:2610:1c0:1040:606c::50:4]) by mxrelay.chi.freebsd.org (Postfix) with ESMTP id ECF492E26; Thu, 09 Jan 2025 15:31:17 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.chi.freebsd.org (Postfix, from userid 1346) id EC64C18465; Thu, 9 Jan 2025 15:31:17 +0000 (UTC) Date: Thu, 9 Jan 2025 15:31:17 +0000 To: Phabricator From: "glebius (Gleb Smirnoff)" Cc: freebsd-net@freebsd.org Reply-to: "glebius (Gleb Smirnoff)" Subject: [Differential] D48204: Add IPv6 support for address parsing and unparsing in ng_ksocket. Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: X-Herald-Rules: <28>, <125>, <128>, <147>, <79> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-3vpvqdpsy6sqgfqvqi4a X-Phabricator-Mail-ID: 4818455 X-Phabricator-Send-Attempt: tcbky7tvj6enj6io In-Reply-To: References: Thread-Index: N2JiNTc4NTM1ZGU5NjEzZjE3NjA3MGE5MzI3IGd/68U= X-Phabricator-Stamps: actor(@glebius) application(Differential) author(@p.mousavizadeh_protonmail.com) herald(H28) herald(H79) herald(H125) herald(H128) herald(H147) monogram(D48204) object-type(DREV) phid(PHID-DREV-3vpvqdpsy6sqgfqvqi4a) reviewer(#manpages) reviewer(#network) revision-repository(rG) revision-status(needs-review) subscriber(#src_committers) subscriber(@donner) subscriber(@freebsd-net-list) subscriber(@glebius) subscriber(@imp) subscriber(@melifaro) subscriber(@nc) tag(#network) via(web) List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" Z2xlYml1cyBhZGRlZCBpbmxpbmUgY29tbWVudHMuCgpJTkxJTkUgQ09NTUVOVFMKCj4gbmdfa3Nv Y2tldC5jOjYyCj4gKyNpbmNsdWRlIDxuZXQvaWYuaD4KPiArI2luY2x1ZGUgPG5ldC9pZl92YXIu aD4KPiArCgpXaGF0IGRvZXMgcmVxdWlyZSBpZl92YXIuaD8KClJFUE9TSVRPUlkKICByRyBGcmVl QlNEIHNyYyByZXBvc2l0b3J5CgpDSEFOR0VTIFNJTkNFIExBU1QgQUNUSU9OCiAgaHR0cHM6Ly9y ZXZpZXdzLmZyZWVic2Qub3JnL0Q0ODIwNC9uZXcvCgpSRVZJU0lPTiBERVRBSUwKICBodHRwczov L3Jldmlld3MuZnJlZWJzZC5vcmcvRDQ4MjA0CgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0dHBzOi8v cmV2aWV3cy5mcmVlYnNkLm9yZy9zZXR0aW5ncy9wYW5lbC9lbWFpbHByZWZlcmVuY2VzLwoKVG86 IHAubW91c2F2aXphZGVoX3Byb3Rvbm1haWwuY29tLCAjbWFucGFnZXMsICNuZXR3b3JrCkNjOiBp bXAsIG5jLCBkb25uZXIsIGZyZWVic2QtbmV0LWxpc3QsIG1lbGlmYXJvLCBnbGViaXVzLCAjc3Jj X2NvbW1pdHRlcnMsIHAubW91c2F2aXphZGVoX3Byb3Rvbm1haWwuY29tLCBnaGlzbGFpbl9zbWFy dGl4LmxsYywga29ucmFkLmtyZWNpd2lsa19rb3JiYW5rLnBsLCBjbWlsbGVyX25ldGFwcC5jb20s IHJhamVzaGFzcCwgbW1hY3ksIGtwcmF2ZWVuLmxrbWxfZ21haWwuY29tLCBjaHJpc19jcmV0YWZv cmNlLmdyLCBzaW1vbnZlbGxhX2dtYWlsLmNvbSwgbm92aWNlX3RlY2hpZS5jb20sIGhlcmJlcnRf bWFpbGJveC5vcmcsIHRvbW1pLnBlcm5pbGFfaWtpLmZpLCB6ZWMsIGRlbHBoaWosIHBzdGVmCg== From nobody Thu Jan 9 15:32:04 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YTTKw4Cqlz5l0Xt for ; Thu, 09 Jan 2025 15:32:04 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.chi.freebsd.org (mxrelay.chi.freebsd.org [IPv6:2610:1c0:1040:6064::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mxrelay.chi.freebsd.org", Issuer "E5" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YTTKw3cq7z4GbQ; Thu, 9 Jan 2025 15:32:04 +0000 (UTC) (envelope-from daemon-user@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736436724; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UqtIW5A9ov1RUBwPGb/pS7ZC52Z2lI9sU75akwcr5GE=; b=cZqOW45yFeezo2GKXpQNWXSkDIJWX2akFK4ZDLl4It0NkYUDCChDe3ra/5VB+St+oze+wz 3kvqgtJBJ2BTIpwA7JP/Izf8xdrYnFYmxqQKdpnYjkmDE9/Gk9iqOBMeR35MzaRAa3Nzzc rWceYPexRfuLpFOxSg+BLoc1BT4gsjNNhU4odx81dfuqQM0EDPRce6cE62rn9ZHUHoxG9F W1ptAqaxgkZA1wi4cgZwm5ImGm1ym+8IvmWXvYD0POhh0tZmZlFKKKT9Fa3NgFaj3CbUi1 O6SIthfr9nbSF/X2JNTV26TxM548S0PPdaq02C6dLRh8rzEQFAXEqHySIAlVEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736436724; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UqtIW5A9ov1RUBwPGb/pS7ZC52Z2lI9sU75akwcr5GE=; b=PF/VGZx7RZNSEykpxYunahhKB0ngsXKskcAiJQV0x1yqjg2dmXgHpcXffxbLpTWyd9JF5B YzCdTexhNDOcRDR3TILuMQZMgINwWQob2qfOPI1FXRMEt+RMm31vrLy4GdjtW7cPAMauTK gsBoLOLFWEUTg9GXSdxK/KB9zd8NfdRGWxKrTA45ogWGsJqDuhhoMW05UrIKKV4FsdT27i lwLBhUdIGE9xixszLsVz6CKQ6ggmv75xCv3B3Ino64llv5tE1MBnzi3Wpdtbe8GFRWZYyp wZauzqLB9VdtxpuhQO0HZP9zDx6fKsoAnss08HbMZg5FDIl4gkO15tIEYuxXyQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736436724; a=rsa-sha256; cv=none; b=gi92YYsRVzmEwMy1yAJBvCf44xAkBHylXqtLt337yIs2LQJ9baB1kORnv9RFLIevH+Tb9e UNTcAKzwH5bhsLdhSqLm6BmZwc5abFImGJgyBNP7zYtdFFsMdv1W1vj2pzezZozY72dFqI ij5ZM6RUgWMt7878Kg7/tCa0qBSScjCMWjqBZoNEgts8493y3gY3jqeLVGlH9Tk/o23Rr4 VE+ywO2+qqyqT0wX8gOJlIaJjqT4GFODj2TUbWqOKClb2c/HSMRylhNktEIA/s0feQtTcf tHmSKw+BgjC4yl4+HGkidv4+qJUYOz4PlvRiTI317lAwzDH6kKqm2s2G4LFnjQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from reviews.chi.freebsd.org (reviews.chi.freebsd.org [IPv6:2610:1c0:1040:606c::50:4]) by mxrelay.chi.freebsd.org (Postfix) with ESMTP id 375712BC5; Thu, 09 Jan 2025 15:32:04 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.chi.freebsd.org (Postfix, from userid 1346) id 36FB01A4D9; Thu, 9 Jan 2025 15:32:04 +0000 (UTC) Date: Thu, 9 Jan 2025 15:32:04 +0000 To: Phabricator From: "glebius (Gleb Smirnoff)" Cc: freebsd-net@freebsd.org Reply-to: "glebius (Gleb Smirnoff)" Subject: [Differential] D48204: Add IPv6 support for address parsing and unparsing in ng_ksocket. Message-ID: <4ae00894f41dce22bdf68a87d2532f53@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: X-Herald-Rules: <28>, <125>, <128>, <147>, <79> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-3vpvqdpsy6sqgfqvqi4a X-Phabricator-Mail-ID: 4818551 X-Phabricator-Send-Attempt: zsodmpfk2qka4otm In-Reply-To: References: Thread-Index: N2JiNTc4NTM1ZGU5NjEzZjE3NjA3MGE5MzI3IGd/6/Q= X-Phabricator-Stamps: actor(@glebius) application(Differential) author(@p.mousavizadeh_protonmail.com) herald(H28) herald(H79) herald(H125) herald(H128) herald(H147) monogram(D48204) object-type(DREV) phid(PHID-DREV-3vpvqdpsy6sqgfqvqi4a) reviewer(#manpages) reviewer(#network) revision-repository(rG) revision-status(needs-review) subscriber(#src_committers) subscriber(@donner) subscriber(@freebsd-net-list) subscriber(@glebius) subscriber(@imp) subscriber(@melifaro) subscriber(@nc) tag(#network) via(web) List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" Z2xlYml1cyBhZGRlZCBhIGNvbW1lbnQuCgoKICBBbHNvLCBhbnkgbWVhbmluZ2Z1bCBjaGFuZ2Ug dG8gYSBtYW51YWwgcGFnZSByZXF1aXJlcyBidW1waW5nIHRoZSAuRGQgdmFsdWUgYXQgdGhlIGJl Z2lubmluZyBvZiB0aGUgcGFnZSB0byB0b2RheSdzIGRhdGUuCgpSRVBPU0lUT1JZCiAgckcgRnJl ZUJTRCBzcmMgcmVwb3NpdG9yeQoKQ0hBTkdFUyBTSU5DRSBMQVNUIEFDVElPTgogIGh0dHBzOi8v cmV2aWV3cy5mcmVlYnNkLm9yZy9ENDgyMDQvbmV3LwoKUkVWSVNJT04gREVUQUlMCiAgaHR0cHM6 Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q0ODIwNAoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczov L3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGluZ3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRv OiBwLm1vdXNhdml6YWRlaF9wcm90b25tYWlsLmNvbSwgI21hbnBhZ2VzLCAjbmV0d29yawpDYzog aW1wLCBuYywgZG9ubmVyLCBmcmVlYnNkLW5ldC1saXN0LCBtZWxpZmFybywgZ2xlYml1cywgI3Ny Y19jb21taXR0ZXJzLCBwLm1vdXNhdml6YWRlaF9wcm90b25tYWlsLmNvbSwgZ2hpc2xhaW5fc21h cnRpeC5sbGMsIGtvbnJhZC5rcmVjaXdpbGtfa29yYmFuay5wbCwgY21pbGxlcl9uZXRhcHAuY29t LCByYWplc2hhc3AsIG1tYWN5LCBrcHJhdmVlbi5sa21sX2dtYWlsLmNvbSwgY2hyaXNfY3JldGFm b3JjZS5nciwgc2ltb252ZWxsYV9nbWFpbC5jb20sIG5vdmljZV90ZWNoaWUuY29tLCBoZXJiZXJ0 X21haWxib3gub3JnLCB0b21taS5wZXJuaWxhX2lraS5maSwgemVjLCBkZWxwaGlqLCBwc3RlZgo= From nobody Thu Jan 9 17:06:46 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YTWRC6TN7z5l7Zh for ; Thu, 09 Jan 2025 17:06:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YTWRC57XYz4Scb for ; Thu, 9 Jan 2025 17:06:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736442407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SL2BAbs65tD8QmTS0q1fH+ykEBdF94KAQTqAraT3RqM=; b=xlgcylgwWW2H20dKFzZiLOv2mQxZZbwkV5Y2GcCmGLWb0qRtRzygb5CYaoYR4lbuhGk8BE fzrogFQvmPx0G8nxf/KNjxYJWB/zTJQpA7tfQi6y/bucZvN+o32VDAAHqP9kAl2ivtjUbq MzRu2qXxvofOC1wFfZmDaNN+er8vTKikRfoP6pMZgsFW2U26Lsx85pNpf9zFDLK2buXhUb 78n4P1hi+q2cMFxDqYh7HUIOIJh7xOtwLYbVwLw00AyoOez9CDAkaIaogErpfpn395cVtF PT+S3k2e7GAo66+OvQR5JXi53aBm/q7xUPcH6k6VvKVV8eZfdnWHViEg33dSWQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736442407; a=rsa-sha256; cv=none; b=QjttaH+L75jaK9VZqEnKsoYplydY0SR8lxl6oLWE7zwWQVoPudaI2+SNVKgRFna+1NUWB9 SbinEJlRMKKK53yTa1b0CvXNgL1W0OspWOvxGa6YGowEGSIVgu5EVNeGgw1BTnd+Bcr1Ob cLycINPk5ZzoqVISG1QtQLoUjUHCbLbRCBpGTVS5pgk27u9wgSISgLDeEib4/dTb8TnRmh DczKqHaNoyMMBwrhZFF0qPrwnnvKibScnYk+RipLLPJv6FPmJjEsZFxeobAS7rZ2+9ny0y QjYbsKVEeOohRe01hl12JA1owycQ2GbspD5yuJUid9PkNbnKgIJfNRqWmPEaYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YTWRC4JcDzbSG for ; Thu, 09 Jan 2025 17:06:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 509H6lfh058168 for ; Thu, 9 Jan 2025 17:06:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 509H6lVp058167 for net@FreeBSD.org; Thu, 9 Jan 2025 17:06:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 282095] enic breaks when changing MTU on interfaces with fib other than 0 Date: Thu, 09 Jan 2025 17:06:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282095 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D0acab8b3d1336d4db73a9946ef76b4bcd= 0b0aabe commit 0acab8b3d1336d4db73a9946ef76b4bcd0b0aabe Author: Doug Ambrisko AuthorDate: 2025-01-09 16:28:37 +0000 Commit: Doug Ambrisko CommitDate: 2025-01-09 16:52:54 +0000 enic(4): fix down/up, MTU changes and more ifconfig down/up cycles was not working. Fix that which is required to support MTU changes. Now doing ifconfig enic0 mtu 3000 for example works. If the MTU is changes in the VIC HW configuration, that is not reflected in and the OS reports the default 1500. I need to look at that but changing it via ifconfig works. So this is different then what Linux does. Change TX interrupt allocation to be in this driver. Change the admin interrupt count to 2. This make multiple queues work but need to be done as pairs so if the VIC has more TX or RX queues setup in the VIC configuration it will use the lesser value. While updating the TX interrupt also add support for devcmd2. Enable checksum offloading. PR: 282095 sys/dev/enic/cq_desc.h | 15 --- sys/dev/enic/enic.h | 76 ++++++-------- sys/dev/enic/enic_res.c | 4 +- sys/dev/enic/enic_res.h | 2 - sys/dev/enic/enic_txrx.c | 39 +++++-- sys/dev/enic/if_enic.c | 173 +++++++++++++++++++++++++++---- sys/dev/enic/vnic_cq.h | 5 +- sys/dev/enic/vnic_dev.c | 235 +++++++++++++++++++++++++++++++++++++--= ---- sys/dev/enic/vnic_dev.h | 8 +- sys/dev/enic/vnic_intr.c | 2 +- sys/dev/enic/vnic_intr.h | 2 +- sys/dev/enic/vnic_resource.h | 1 + sys/dev/enic/vnic_rq.c | 5 +- sys/dev/enic/vnic_rq.h | 1 - sys/dev/enic/vnic_rss.h | 5 - sys/dev/enic/vnic_wq.c | 104 ++++++++++++++++++- sys/dev/enic/vnic_wq.h | 18 +++- 17 files changed, 559 insertions(+), 136 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri Jan 10 09:38:17 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YTxRG6002z5jxr2 for ; Fri, 10 Jan 2025 09:38:18 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.chi.freebsd.org (mxrelay.chi.freebsd.org [IPv6:2610:1c0:1040:6064::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mxrelay.chi.freebsd.org", Issuer "E5" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YTxRG03Xcz49y1; Fri, 10 Jan 2025 09:38:18 +0000 (UTC) (envelope-from daemon-user@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736501898; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=r6YHB8vyAszp2dew4+DnJgydCz94Tb126Jt0Mfozfkc=; b=SCjyoBWu0bXgYnpVfafeDEMb5EiJQwbrYg5HvIUufhc2IvmJcf15ufaFcHSNYMIxL7B0gK wJq2EOyIqPFxAJ/ES4OwyaC09NeOjbkk47FZ4k++rYWmUYjqkLoB951f8m6OvPq/adOFTF loKjJfi3avRyiBp7mLKpO5ReZwlLn+8j2a7XtTyRV+SRDhSEUcMVLdrJrWj5nNsVIABHQ+ iMzdWIT5NDp8znTZDxY/6Pjdc4YUQYo1KycpkcliBpryrEHgRjPjLtCjvaoeS2RipsnMGB pexgS7CnFUntA+Fr3w1LiOvPL/8RG4nv3Ig1kjHi3ata8PM7HQiNAmsCuMmVzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736501898; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=r6YHB8vyAszp2dew4+DnJgydCz94Tb126Jt0Mfozfkc=; b=TGmiIszV8luqyUXEZoJrhjXWWVOCUHMZK611SrFIIyWsC5/HpseX+7gRk3Kphq4WuQ+ZsG NnCQ2EI+aB2v9nnETB/m4+my5+BZJ/RxSF7aPolsxrco3upR+nixMfWmmNWjzySmI2CmXw LmswikdadvNIDVhJNyzmTq9RxSy2SoNErHwVgNlkOvA5Pgb1qAhmhZyIBG1daNdrerSNO7 8Hfj+kFwi5o1Z2h9ZDc7A348Bj+dpsocmWJ7gzuYfduk3oNnC0hKtBvJKC6YLu6+YDM1/u Jn1W7xPWaJEFVe4yV1sgQgahFNCpxDT60DHcnsRtT2xb3xBa09iXBI6JhAoEIw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736501898; a=rsa-sha256; cv=none; b=xdOykd4MwR1wS5r3LU7cTBT2sgsE4BB34tTwfyMBgKkvFDzd2n31CLSF9ceOzYw0eoOaF3 +GkpYuffOfwo+B5eXeKvmI+a6bejyud8dGNR8N0R1nlUxeZvaJI4z/QpaS2ZytZkEmPJqg EYmY23MUl2HYJWJRiiDt296LR8lseo7l+WVXzfd0ysYRxCFAxouoToUUtZyBqmym3RWr3Z 7GusreXmxf/qJny86fifPlXX2KAkvFLA55sUjpTjg++sjt1LNPBzhwh9oqKIsjL0VxcJp0 9txn+3bl/uY7G7t5FkEaiGz1q381kxkEB0A9LD2Bp05toKCC2vHarR27dkIiaQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from reviews.chi.freebsd.org (reviews.chi.freebsd.org [IPv6:2610:1c0:1040:606c::50:4]) by mxrelay.chi.freebsd.org (Postfix) with ESMTP id A536E197A3; Fri, 10 Jan 2025 09:38:17 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.chi.freebsd.org (Postfix, from userid 1346) id A3D1A18CC3; Fri, 10 Jan 2025 09:38:17 +0000 (UTC) Date: Fri, 10 Jan 2025 09:38:17 +0000 To: Phabricator From: "p.mousavizadeh_protonmail.com (Seyed Pouria Mousavizadeh Tehrani)" Cc: freebsd-net@freebsd.org Reply-to: "p.mousavizadeh_protonmail.com (Seyed Pouria Mousavizadeh Tehrani)" Subject: [Differential] D48204: Add IPv6 support for address parsing and unparsing in ng_ksocket. Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , X-Herald-Rules: <28>, <125>, <128>, <147>, <79> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-3vpvqdpsy6sqgfqvqi4a X-Phabricator-Mail-ID: 4820793 X-Phabricator-Send-Attempt: ktkyty5qo4bwp3gz In-Reply-To: References: Thread-Index: N2JiNTc4NTM1ZGU5NjEzZjE3NjA3MGE5MzI3IGeA6ok= X-Phabricator-Stamps: actor(@p.mousavizadeh_protonmail.com) application(Differential) author(@p.mousavizadeh_protonmail.com) herald(H28) herald(H79) herald(H125) herald(H128) herald(H147) monogram(D48204) object-type(DREV) phid(PHID-DREV-3vpvqdpsy6sqgfqvqi4a) reviewer(#manpages) reviewer(#network) revision-repository(rG) revision-status(needs-review) subscriber(#src_committers) subscriber(@donner) subscriber(@freebsd-net-list) subscriber(@glebius) subscriber(@imp) subscriber(@melifaro) subscriber(@nc) tag(#network) via(conduit) List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_ee89a63b142a9a28b16a2a8054427334" --b1_ee89a63b142a9a28b16a2a8054427334 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 cC5tb3VzYXZpemFkZWhfcHJvdG9ubWFpbC5jb20gdXBkYXRlZCB0aGlzIHJldmlzaW9uIHRvIERp ZmYgMTQ5MDM5LgpwLm1vdXNhdml6YWRlaF9wcm90b25tYWlsLmNvbSBhZGRlZCBhIGNvbW1lbnQu CgoKICBCdW1wIC5EZCBpbiBuZ19rc29ja2V0LjQKICB1cGRhdGUgdmFsdWUgZnJvbSBKYW51YXJ5 IDksIDIwMTIgdG8gSmFudWFyeSA5LCAyMDI1CgpSRVBPU0lUT1JZCiAgckcgRnJlZUJTRCBzcmMg cmVwb3NpdG9yeQoKQ0hBTkdFUyBTSU5DRSBMQVNUIFVQREFURQogIGh0dHBzOi8vcmV2aWV3cy5m cmVlYnNkLm9yZy9ENDgyMDQ/dnM9MTQ4NDAyJmlkPTE0OTAzOQoKQ0hBTkdFUyBTSU5DRSBMQVNU IEFDVElPTgogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9ENDgyMDQvbmV3LwoKUkVWSVNJ T04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q0ODIwNAoKQUZGRUNURUQg RklMRVMKICBzaGFyZS9tYW4vbWFuNC9uZ19rc29ja2V0LjQKICBzeXMvbmV0Z3JhcGgvbmdfa3Nv Y2tldC5jCgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9z ZXR0aW5ncy9wYW5lbC9lbWFpbHByZWZlcmVuY2VzLwoKVG86IHAubW91c2F2aXphZGVoX3Byb3Rv bm1haWwuY29tLCAjbWFucGFnZXMsICNuZXR3b3JrCkNjOiBpbXAsIG5jLCBkb25uZXIsIGZyZWVi c2QtbmV0LWxpc3QsIG1lbGlmYXJvLCBnbGViaXVzLCAjc3JjX2NvbW1pdHRlcnMsIHAubW91c2F2 aXphZGVoX3Byb3Rvbm1haWwuY29tLCBnaGlzbGFpbl9zbWFydGl4LmxsYywga29ucmFkLmtyZWNp d2lsa19rb3JiYW5rLnBsLCBjbWlsbGVyX25ldGFwcC5jb20sIHJhamVzaGFzcCwgbW1hY3ksIGtw cmF2ZWVuLmxrbWxfZ21haWwuY29tLCBjaHJpc19jcmV0YWZvcmNlLmdyLCBzaW1vbnZlbGxhX2dt YWlsLmNvbSwgbm92aWNlX3RlY2hpZS5jb20sIGhlcmJlcnRfbWFpbGJveC5vcmcsIHRvbW1pLnBl cm5pbGFfaWtpLmZpLCB6ZWMsIGRlbHBoaWosIHBzdGVmCg== --b1_ee89a63b142a9a28b16a2a8054427334 Content-Type: text/x-patch; charset=utf-8; name="D48204.149039.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D48204.149039.patch" ZGlmZiAtLWdpdCBhL3N5cy9uZXRncmFwaC9uZ19rc29ja2V0LmMgYi9zeXMvbmV0Z3JhcGgvbmdf a3NvY2tldC5jCi0tLSBhL3N5cy9uZXRncmFwaC9uZ19rc29ja2V0LmMKKysrIGIvc3lzL25ldGdy YXBoL25nX2tzb2NrZXQuYwpAQCAtNTgsNiArNTgsOSBAQAogI2luY2x1ZGUgPHN5cy91aW8uaD4K ICNpbmNsdWRlIDxzeXMvdW4uaD4KIAorI2luY2x1ZGUgPG5ldC9pZi5oPgorI2luY2x1ZGUgPG5l dC9pZl92YXIuaD4KKwogI2luY2x1ZGUgPG5ldGdyYXBoL25nX21lc3NhZ2UuaD4KICNpbmNsdWRl IDxuZXRncmFwaC9uZXRncmFwaC5oPgogI2luY2x1ZGUgPG5ldGdyYXBoL25nX3BhcnNlLmg+CkBA IC02Niw2ICs2OSw4IEBACiAjaW5jbHVkZSA8bmV0aW5ldC9pbi5oPgogI2luY2x1ZGUgPG5ldGlu ZXQvaXAuaD4KIAorI2luY2x1ZGUgPG5ldGluZXQ2L3Njb3BlNl92YXIuaD4KKwogI2lmZGVmIE5H X1NFUEFSQVRFX01BTExPQwogc3RhdGljIE1BTExPQ19ERUZJTkUoTV9ORVRHUkFQSF9LU09DS0VU LCAibmV0Z3JhcGhfa3NvY2siLAogICAgICJuZXRncmFwaCBrc29jayBub2RlIik7CkBAIC0xNDcs NiArMTUyLDE5IEBACiAJeyAic3dpcGUiLAlJUFBST1RPX1NXSVBFLAkJUEZfSU5FVAkJfSwKIAl7 ICJlbmNhcCIsCUlQUFJPVE9fRU5DQVAsCQlQRl9JTkVUCQl9LAogCXsgInBpbSIsCUlQUFJPVE9f UElNLAkJUEZfSU5FVAkJfSwKKwl7ICJpcDYiLAlJUFBST1RPX0lQVjYsCQlQRl9JTkVUNgl9LAor CXsgInJhdzYiLAlJUFBST1RPX1JBVywJCVBGX0lORVQ2CX0sCisJeyAiaWNtcDYiLAlJUFBST1RP X0lDTVBWNiwJCVBGX0lORVQ2CX0sCisJeyAiaWdtcDYiLAlJUFBST1RPX0lHTVAsCQlQRl9JTkVU Ngl9LAorCXsgInRjcDYiLAlJUFBST1RPX1RDUCwJCVBGX0lORVQ2CX0sCisJeyAidWRwNiIsCUlQ UFJPVE9fVURQLAkJUEZfSU5FVDYJfSwKKwl7ICJncmU2IiwJSVBQUk9UT19HUkUsCQlQRl9JTkVU Ngl9LAorCXsgImVzcDYiLAlJUFBST1RPX0VTUCwJCVBGX0lORVQ2CX0sCisJeyAiYWg2IiwJSVBQ Uk9UT19BSCwJCVBGX0lORVQ2CX0sCisJeyAic3dpcGU2IiwJSVBQUk9UT19TV0lQRSwJCVBGX0lO RVQ2CX0sCisJeyAiZW5jYXA2IiwJSVBQUk9UT19FTkNBUCwJCVBGX0lORVQ2CX0sCisJeyAiZGl2 ZXJ0NiIsCUlQUFJPVE9fRElWRVJULAkJUEZfSU5FVDYJfSwKKwl7ICJwaW02IiwJSVBQUk9UT19Q SU0sCQlQRl9JTkVUNgl9LAogCXsgTlVMTCwJCS0xCQkJCQl9LAogfTsKIApAQCAtMjk2LDkgKzMx NCw1OCBAQAogCQlicmVhazsKIAkgICAgfQogCi0jaWYgMAotCWNhc2UgUEZfSU5FVDY6CS8qIFhY WCBpbXBsZW1lbnQgdGhpcyBzb21lZGF5ICovCi0jZW5kaWYKKwljYXNlIFBGX0lORVQ2OgorCSAg ICB7CisJCXN0cnVjdCBzb2NrYWRkcl9pbjYgKmNvbnN0IHNpbjYgPSAoc3RydWN0IHNvY2thZGRy X2luNiAqKXNhOworCQljaGFyICplcHRyOworCQljaGFyIGFkZHJbSU5FVDZfQUREUlNUUkxFTl07 CisJCWNoYXIgaWZuYW1lWzE2XTsKKwkJdV9sb25nIHBvcnQ7CisJCWJvb2wgaGFzaWZuYW1lID0g dHJ1ZTsKKworCQkvKiBSRkMgMzk4NiBTZWN0aW9uIDMuMi4yLCBWYWxpZGF0ZSBJUCBsaXRlcmFs IHdpdGhpbiBzcXVhcmUgYnJhY2tldHMuICovCisJCWlmIChzWypvZmZdID09ICdbJyAmJiAoc3Ry c3RyKCZzWypvZmZdLCAiXSIpKSkKKwkJCSgqb2ZmKSsrOworCQllbHNlCisJCQlyZXR1cm4gKEVJ TlZBTCk7CisJCWlmICgoZXB0ciA9IHN0cnN0cigmc1sqb2ZmXSwgIiUiKSkgPT0gTlVMTCkgewor CQkJaGFzaWZuYW1lID0gZmFsc2U7CisJCQllcHRyID0gc3Ryc3RyKCZzWypvZmZdLCAiXSIpOwor CQl9CisJCXNucHJpbnRmKGFkZHIsIGVwdHIgLSAocyArICpvZmYpICsgMSwgIiVzIiwgJnNbKm9m Zl0pOworCQkqb2ZmICs9IChlcHRyIC0gKHMgKyAqb2ZmKSk7CisJCWlmICghaW5ldF9wdG9uKEFG X0lORVQ2LCBhZGRyLCAmc2luNi0+c2luNl9hZGRyKSkKKwkJCXJldHVybiAoRUlOVkFMKTsKKwor CQlpZiAoaGFzaWZuYW1lKSB7CisJCQl1aW50MTZfdCBzY29wZTsKKworCQkJZXB0ciA9IHN0cnN0 cigmc1sqb2ZmXSwgIl0iKTsKKwkJCSgqb2ZmKSsrOworCQkJc25wcmludGYoaWZuYW1lLCBlcHRy IC0gKHMgKyAqb2ZmKSArIDEsICIlcyIsICZzWypvZmZdKTsKKwkJCSpvZmYgKz0gKGVwdHIgLSAo cyArICpvZmYpKTsKKworCQkJaWYgKHNpbjYtPnNpbjZfYWRkci5zNl9hZGRyMTZbMF0gIT0gSVBW Nl9BRERSX0lOVDE2X1VMTCkKKwkJCQlyZXR1cm4gKEVJTlZBTCk7CisJCQlzY29wZSA9IGluNl9n ZXRzY29wZSgmc2luNi0+c2luNl9hZGRyKTsKKwkJCXNpbjYtPnNpbjZfc2NvcGVfaWQgPQorCQkJ ICAgIGluNl9nZXRzY29wZXpvbmUoaWZ1bml0KGlmbmFtZSksIHNjb3BlKTsKKwkJfQorCisJCSgq b2ZmKSsrOworCQlpZiAoc1sqb2ZmXSA9PSAnOicpIHsKKwkJCSgqb2ZmKSsrOworCQkJcG9ydCA9 IHN0cnRvdWwocyArICpvZmYsICZlcHRyLCAxMCk7CisJCQlpZiAocG9ydCA+IDB4ZmZmZiB8fCBl cHRyID09IHMgKyAqb2ZmKQorCQkJCXJldHVybiAoRUlOVkFMKTsKKwkJCSpvZmYgKz0gKGVwdHIg LSAocyArICpvZmYpKTsKKwkJCXNpbjYtPnNpbjZfcG9ydCA9IGh0b25zKHBvcnQpOworCQl9IGVs c2UKKwkJCXNpbjYtPnNpbjZfcG9ydCA9IDA7CisKKwkJc2luNi0+c2luNl9sZW4gPSBzaXplb2Yo KnNpbjYpOworCQlicmVhazsKKwkgICAgfQogCiAJZGVmYXVsdDoKIAkJcmV0dXJuIChFSU5WQUwp OwpAQCAtMzU4LDkgKzQyNSwyNCBAQAogCQlyZXR1cm4oMCk7CiAJICAgIH0KIAotI2lmIDAKLQlj YXNlIFBGX0lORVQ2OgkvKiBYWFggaW1wbGVtZW50IHRoaXMgc29tZWRheSAqLwotI2VuZGlmCisJ Y2FzZSBQRl9JTkVUNjoKKwkgICAgeworCQljb25zdCBzdHJ1Y3Qgc29ja2FkZHJfaW42ICpzaW42 ID0gKGNvbnN0IHN0cnVjdCBzb2NrYWRkcl9pbjYgKilzYTsKKwkJY2hhciBhZGRyW0lORVQ2X0FE RFJTVFJMRU5dOworCisJCWluZXRfbnRvcChBRl9JTkVUNiwgJnNpbjYtPnNpbjZfYWRkciwgYWRk ciwgSU5FVDZfQUREUlNUUkxFTik7CisJCXNsZW4gKz0gc25wcmludGYoY2J1ZiwgY2J1Zmxlbiwg ImluZXQ2L1slc10iLCBhZGRyKTsKKworCQlpZiAoc2luNi0+c2luNl9wb3J0ICE9IDApIHsKKwkJ CXNsZW4gKz0gc25wcmludGYoY2J1ZiArIHN0cmxlbihjYnVmKSwKKwkJCSAgICBjYnVmbGVuIC0g c3RybGVuKGNidWYpLCAiOiVkIiwKKwkJCSAgICAodV9pbnQpbnRvaHMoc2luNi0+c2luNl9wb3J0 KSk7CisJCX0KKwkJaWYgKHNsZW4gPj0gY2J1ZmxlbikKKwkJCXJldHVybiAoRVJBTkdFKTsKKwkJ Km9mZiArPSBzaXplb2YoKnNpbjYpOworCQlyZXR1cm4oMCk7CisJICAgIH0KIAogCWRlZmF1bHQ6 CiAJCXJldHVybiAoKm5nX2tzb2NrZXRfZ2VuZXJpY19zb2NrYWRkcl90eXBlLnN1cGVydHlwZS0+ dW5wYXJzZSkKZGlmZiAtLWdpdCBhL3NoYXJlL21hbi9tYW40L25nX2tzb2NrZXQuNCBiL3NoYXJl L21hbi9tYW40L25nX2tzb2NrZXQuNAotLS0gYS9zaGFyZS9tYW4vbWFuNC9uZ19rc29ja2V0LjQK KysrIGIvc2hhcmUvbWFuL21hbjQvbmdfa3NvY2tldC40CkBAIC0zMiw3ICszMiw3IEBACiAuXCIK IC5cIiBBdXRob3I6IEFyY2hpZSBDb2JicyA8YXJjaGllQEZyZWVCU0Qub3JnPgogLlwiCi0uRGQg SmFudWFyeSA5LCAyMDEyCisuRGQgSmFudWFyeSA5LCAyMDI1CiAuRHQgTkdfS1NPQ0tFVCA0CiAu T3MKIC5TaCBOQU1FCkBAIC0xODMsNyArMTgzLDggQEAKIGVxdWl2YWxlbnQgb2YgdGhlIEMgc3Ry dWN0dXJlCiBpcyBhbiBhY2NlcHRhYmxlIGZvcm0uCiBGb3IgdGhlCi0uRHYgUEZfSU5FVAorLkR2 IFBGX0lORVQgLAorLkR2IFBGX0lORVQ2CiBhbmQKIC5EdiBQRl9MT0NBTAogYWRkcmVzcyBmYW1p bGllcywgYSBtb3JlIGNvbnZlbmllbnQgZm9ybSBpcyBhbHNvIHVzZWQsIHdoaWNoIGlzCkBAIC0x OTEsNyArMTkyLDExIEBACiBhZGRyZXNzLgogRm9yCiAuRHYgUEZfSU5FVCAsCi10aGUgYWRkcmVz cyBpcyBhbiBJUCBhZGRyZXNzIGZvbGxvd2VkIGJ5IGFuIG9wdGlvbmFsIGNvbG9uIGFuZCBwb3J0 IG51bWJlci4KK3RoZSBhZGRyZXNzIGlzIGFuIElQdjQgYWRkcmVzcyBmb2xsb3dlZCBieSBhbiBv cHRpb25hbCBjb2xvbiBhbmQgcG9ydCBudW1iZXIuCitGb3IKKy5EdiBQRl9JTkVUNiAsCit0aGUg YWRkcmVzcyBpcyBhbiBJUHY2IGFkZHJlc3MgZW5jbG9zZWQgaW4gc3F1YXJlIGJyYWNrZXRzIGZv bGxvd2VkCitieSBhbiBvcHRpb25hbCBjb2xvbiBhbmQgcG9ydCBudW1iZXIuCiBGb3IKIC5EdiBQ Rl9MT0NBTCAsCiB0aGUgYWRkcmVzcyBpcyB0aGUgcGF0aG5hbWUgYXMgYSBkb3VibHkgcXVvdGVk IHN0cmluZy4KQEAgLTIwMiw2ICsyMDcsOCBAQAogbG9jYWwvIi90bXAvZm9vLnNvY2tldCIKIC5J dCBEdiBQRl9JTkVUCiBpbmV0LzE5Mi4xNjguMS4xOjEyMzQKKy5JdCBEdiBQRl9JTkVUNgoraW5l dDYvWzIwMDE6OjFdOjEyMzQKIC5JdCBPdGhlcgogLkR2ICJcJnsgZmFtaWx5PTE2IGxlbj0xNiBk YXRhPVsweDcwIDB4MDAgMHgwMSAweDIzXSBcJn0iCiAuRWwKCg== --b1_ee89a63b142a9a28b16a2a8054427334-- From nobody Fri Jan 10 09:49:49 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YTxhY2x9wz5jybf for ; Fri, 10 Jan 2025 09:49:49 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.chi.freebsd.org (mxrelay.chi.freebsd.org [IPv6:2610:1c0:1040:6064::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mxrelay.chi.freebsd.org", Issuer "E5" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YTxhY2QXMz4Cp8; Fri, 10 Jan 2025 09:49:49 +0000 (UTC) (envelope-from daemon-user@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736502589; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZKy+T0SXcc6Cl9xfKsBhQjUunehiF78Y5l94g6AVJ0k=; b=nCGOFs8+fmnTaWhAKuvSHj4o065ri1qmakCATQLGEv2xFzN2vQK5d1xhHpcEyMeJmvZSKA eaE8XtV2GXFVfAeZU2Ew48HxR9omDI9ruPvcYhb09fzxvCs4IV7miXQp62R1wi4DbhIsB7 PDvMByq4AouDpY0f0MmJCamNayu6Cbg6cmWOKsQN81Eiu6T/UwhapZm41/d4QR+tvX4eDm GBoQaoS+UHj1UfaE/WR5NEOFL4M3a5gCgqHpaq9MEMoR0S+HlxwyNgFPGEtIrXCQv8paqo C0GU3h8VnfyYH2HxGcRGOwqZ+1N6k+KIaRdm8l87ZwmxfhTae/d+LOaBdC9O8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736502589; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZKy+T0SXcc6Cl9xfKsBhQjUunehiF78Y5l94g6AVJ0k=; b=vt/iAnxnz8B2c6ioa2HKeyxqaMnwFam64H10780ujBN3Vajch4n3Lhn3eSpx+bK+SCUz0s W52dpOp7pehNwebI43sdc1kYh/1mTIkb7dUrFMv3qE1YL89JmfmQzw5J9U9KxjBHr2Ipbu fnR0EFNhEiWLhuXEaShZ7fOfZk9cuG0rEqt00peawJND1JZLVSfUJeppMV95udVM1Rdtxs QEChMbn2jpp+EuI73Z7Fi0IT0NsTRDXpxAQdmY5H6n29z3/ZIZpO0BwcCNX8UKbvQs+fDf FH7pMUYHVFDqI6qKfF0ZR9t7UeSXwZgFdBpnWd1Oliy8ptkygJjX9/XFSNar8w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736502589; a=rsa-sha256; cv=none; b=LvrUpQDeRj0usoF0sfq5IsnD5eMy/2MyizmwBNRhu5dDuIRnwUWCvNXzHN+E8C0q1XLGBa K7KIZAJyc+TMB0bcV3LiJzlC5LbU2s8OgeymADpG2PwYSmHgyH2O3bK7uU8kcfh7+9ie/T jytnd7aBEb4ypliZa4Vn2IK1Cmd5Wjnlp0lUWjr86N+MAHQ6wTCOIXI1BlTUebCVueOfoL wreX4lP3kKL1Jzv3zV0vSoScjGLkhSSYmxRozFKCLzCMCm7v71esV1Nc9/+QWPxkVucsuz IsW7Gwv/XRYTU+7HxO0oPqrSLGueEmbmvXHdO0Kevk/meqIqfGOElQmkzPQ6UQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from reviews.chi.freebsd.org (reviews.chi.freebsd.org [IPv6:2610:1c0:1040:606c::50:4]) by mxrelay.chi.freebsd.org (Postfix) with ESMTP id 08224191C3; Fri, 10 Jan 2025 09:49:49 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.chi.freebsd.org (Postfix, from userid 1346) id 06D0D3E024; Fri, 10 Jan 2025 09:49:49 +0000 (UTC) Date: Fri, 10 Jan 2025 09:49:49 +0000 To: Phabricator From: "p.mousavizadeh_protonmail.com (Seyed Pouria Mousavizadeh Tehrani)" Cc: freebsd-net@freebsd.org Reply-to: "p.mousavizadeh_protonmail.com (Seyed Pouria Mousavizadeh Tehrani)" Subject: [Differential] D48204: Add IPv6 support for address parsing and unparsing in ng_ksocket. Message-ID: <524d3141e17051be012bf5d070c8bfff@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , X-Herald-Rules: <28>, <125>, <128>, <147>, <79> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-3vpvqdpsy6sqgfqvqi4a X-Phabricator-Mail-ID: 4820886 X-Phabricator-Send-Attempt: fpsd7wvsuvljdqvc In-Reply-To: References: Thread-Index: N2JiNTc4NTM1ZGU5NjEzZjE3NjA3MGE5MzI3IGeA7T0= X-Phabricator-Stamps: actor(@p.mousavizadeh_protonmail.com) application(Differential) author(@p.mousavizadeh_protonmail.com) herald(H28) herald(H79) herald(H125) herald(H128) herald(H147) mention(@glebius) monogram(D48204) object-type(DREV) phid(PHID-DREV-3vpvqdpsy6sqgfqvqi4a) reviewer(#manpages) reviewer(#network) revision-repository(rG) revision-status(needs-review) subscriber(#src_committers) subscriber(@donner) subscriber(@freebsd-net-list) subscriber(@glebius) subscriber(@imp) subscriber(@melifaro) subscriber(@nc) tag(#network) via(web) List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" cC5tb3VzYXZpemFkZWhfcHJvdG9ubWFpbC5jb20gYWRkZWQgYSBjb21tZW50LgoKCiAgQGdsZWJp dXM6IEFsc28sIEhlcmUgaXMgbXkgZ2l0aHViIHJlcG8gYXMgeW91IHJlcXVlc3RlZC4KICBzcG16 dC9mcmVlYnNkLXNyYy90cmVlL2tzb2NrZXRfaXB2NjogRDQ4MjA0IDxodHRwczovL2dpdGh1Yi5j b20vc3BtenQvZnJlZWJzZC1zcmMvdHJlZS9rc29ja2V0X2lwdjY+CgpJTkxJTkUgQ09NTUVOVFMK Cj4gZ2xlYml1cyB3cm90ZSBpbiBuZ19rc29ja2V0LmM6NjIKPiBXaGF0IGRvZXMgcmVxdWlyZSBp Zl92YXIuaD8KCkkgYW0gdXNpbmcgYGlmdW5pdCgpYCBhdCBsaW5lIDM1MiwgYW5kIGl0cyBmdW5j dGlvbiBkZWNsYXJlZCBpbiA8bmV0L2lmX3Zhci5oPi4gTWF5YmUgSSB0aGluayBpdCdzIHJlcXVp cmVkIGR1ZSB0byBteSBsYWNrIG9mIGtub3dsZWRnZSwgU2hvdWxkIEkgcmVtb3ZlIGl0PwoKUkVQ T1NJVE9SWQogIHJHIEZyZWVCU0Qgc3JjIHJlcG9zaXRvcnkKCkNIQU5HRVMgU0lOQ0UgTEFTVCBB Q1RJT04KICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDQ4MjA0L25ldy8KClJFVklTSU9O IERFVEFJTAogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9ENDgyMDQKCkVNQUlMIFBSRUZF UkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL3NldHRpbmdzL3BhbmVsL2VtYWls cHJlZmVyZW5jZXMvCgpUbzogcC5tb3VzYXZpemFkZWhfcHJvdG9ubWFpbC5jb20sICNtYW5wYWdl cywgI25ldHdvcmsKQ2M6IGltcCwgbmMsIGRvbm5lciwgZnJlZWJzZC1uZXQtbGlzdCwgbWVsaWZh cm8sIGdsZWJpdXMsICNzcmNfY29tbWl0dGVycywgcC5tb3VzYXZpemFkZWhfcHJvdG9ubWFpbC5j b20sIGdoaXNsYWluX3NtYXJ0aXgubGxjLCBrb25yYWQua3JlY2l3aWxrX2tvcmJhbmsucGwsIGNt aWxsZXJfbmV0YXBwLmNvbSwgcmFqZXNoYXNwLCBtbWFjeSwga3ByYXZlZW4ubGttbF9nbWFpbC5j b20sIGNocmlzX2NyZXRhZm9yY2UuZ3IsIHNpbW9udmVsbGFfZ21haWwuY29tLCBub3ZpY2VfdGVj aGllLmNvbSwgaGVyYmVydF9tYWlsYm94Lm9yZywgdG9tbWkucGVybmlsYV9pa2kuZmksIHplYywg ZGVscGhpaiwgcHN0ZWYK From nobody Fri Jan 10 19:58:28 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YVCBs0P69z5kS4d for ; Fri, 10 Jan 2025 19:58:29 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.chi.freebsd.org (mxrelay.chi.freebsd.org [IPv6:2610:1c0:1040:6064::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mxrelay.chi.freebsd.org", Issuer "E5" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YVCBr75fXz4T4c; Fri, 10 Jan 2025 19:58:28 +0000 (UTC) (envelope-from daemon-user@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736539109; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KXpJ2VPCi+V1hyt/ApWnr2d4+IsCF6XMIHo2NaB09S4=; b=GyfeMc3tCLw7uLxfqmMXt/CY3WvKYhNWYvcz6VNEIkE/cym7TxeHkVRaMm/Fu3QhIg7Pk8 nMJL76YVxMJFt2H/ZQVJcSxT6P+yC+g1BXIAmOadRb8tOeivXb06idPpm+nETduzUFd4BE M2tlm0ID2AVeXUOJaC7IC2+oQqUgKbJeyrw804ynkdxzEhuhWPvaAk4+nX8M3U4tMRpqq7 sC42UnW1FCfMD6tghq9LA2Uvv3BUe8jY+n4GHOfoKUofDc1Nw1peaFyPE7K6VauxuDRVYz 3IA0y/6/8kRNU51P4ZLxdnfF5V/iVf9uWxI0dFacT8qlQY7JhiNYh8VY4fH3wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736539109; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KXpJ2VPCi+V1hyt/ApWnr2d4+IsCF6XMIHo2NaB09S4=; b=wj8fmtb7mk4v2hdQIkqIBnLs3279bvK88iCsoC5EeTtMpeiB1JBzbdWn4xOVJ8V3xyeT8k 8XGRdzCnSu42mK3ufte18Ghr94fruFLloJK5+o6IL3FpsqMifEJI/xQA28hauXzm2mwXfB Gbi1G2WdJWCRlmrOVnr66fV217JM79gco9YL6f2zPrQp7JgZn0k7O3ED+IHINQMzMNOpcc 9vNLcGY5UTLo7HP2JYpzQhkNdQxQQbZc88kQbcNiuDy1pnefOLOb0tej5mCjF75Kj8q7jH epgrx51QnS76iuZNiD0HhrLlRkr1u424xSP8ync9ZWeVDRdrV27fdEBK7qc1hA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736539109; a=rsa-sha256; cv=none; b=ZbrUFw0y6ApvISmeFtEFUgpEPEpOSlhG1vZE2PCPS6YRgJWgS/WNjjYdl7R8IXmVzmHHn+ f2ljEillFMw6Zz8atvM8rJTqHbtsj1dJ9mDMzkEtj8rHrlrqHW3J5E1nUTtdVVBeXb3Eso R8O7KD0jvln71l7yspReryU+k6a2JehxGuyGgTMFivze7sCwQD7RMrQtuyGPRASXwTf0pY fNdQsJ6se3j6k2EtXM/Kc5fg2SqJyXcSWOxJp1SzrWuQRgF93ehq/+wEiAiJBjMnvAKRbH AHB296K4ZfN39IYLg7SVEMuplvZsweqxyOAuL3HSJqOfrinSWUgxW3tTE9q2eQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from reviews.chi.freebsd.org (reviews.chi.freebsd.org [IPv6:2610:1c0:1040:606c::50:4]) by mxrelay.chi.freebsd.org (Postfix) with ESMTP id A3E22212D1; Fri, 10 Jan 2025 19:58:28 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.chi.freebsd.org (Postfix, from userid 1346) id A436C4D2F6; Fri, 10 Jan 2025 19:58:28 +0000 (UTC) Date: Fri, 10 Jan 2025 19:58:28 +0000 To: Phabricator From: "glebius (Gleb Smirnoff)" Cc: freebsd-net@freebsd.org Reply-to: "glebius (Gleb Smirnoff)" Subject: [Differential] D48204: Add IPv6 support for address parsing and unparsing in ng_ksocket. Message-ID: <6f48c1231d3847dcdebe32b871e07461@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: X-Herald-Rules: <28>, <125>, <128>, <147>, <79> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-3vpvqdpsy6sqgfqvqi4a X-Phabricator-Mail-ID: 4822229 X-Phabricator-Send-Attempt: 42dyu7ynjan6yi4g In-Reply-To: References: Thread-Index: N2JiNTc4NTM1ZGU5NjEzZjE3NjA3MGE5MzI3IGeBe+Q= X-Phabricator-Stamps: actor(@glebius) application(Differential) author(@p.mousavizadeh_protonmail.com) herald(H28) herald(H79) herald(H125) herald(H128) herald(H147) monogram(D48204) object-type(DREV) phid(PHID-DREV-3vpvqdpsy6sqgfqvqi4a) reviewer(#manpages) reviewer(#network) revision-repository(rG) revision-status(needs-review) subscriber(#src_committers) subscriber(@donner) subscriber(@freebsd-net-list) subscriber(@glebius) subscriber(@imp) subscriber(@melifaro) subscriber(@nc) tag(#network) via(web) List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" Z2xlYml1cyBhZGRlZCBpbmxpbmUgY29tbWVudHMuCgpJTkxJTkUgQ09NTUVOVFMKCj4gcC5tb3Vz YXZpemFkZWhfcHJvdG9ubWFpbC5jb20gd3JvdGUgaW4gbmdfa3NvY2tldC5jOjYyCj4gSSBhbSB1 c2luZyBgaWZ1bml0KClgIGF0IGxpbmUgMzUyLCBhbmQgaXRzIGZ1bmN0aW9uIGRlY2xhcmVkIGlu IDxuZXQvaWZfdmFyLmg+LiBNYXliZSBJIHRoaW5rIGl0J3MgcmVxdWlyZWQgZHVlIHRvIG15IGxh Y2sgb2Yga25vd2xlZGdlLCBTaG91bGQgSSByZW1vdmUgaXQ/CgpTb3JyeSwgSSB0aG91Z2ggaXQg YmVsb25ncyB0byBuZXQvaWYuaAoKUkVQT1NJVE9SWQogIHJHIEZyZWVCU0Qgc3JjIHJlcG9zaXRv cnkKCkNIQU5HRVMgU0lOQ0UgTEFTVCBBQ1RJT04KICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5v cmcvRDQ4MjA0L25ldy8KClJFVklTSU9OIERFVEFJTAogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNk Lm9yZy9ENDgyMDQKCkVNQUlMIFBSRUZFUkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qu b3JnL3NldHRpbmdzL3BhbmVsL2VtYWlscHJlZmVyZW5jZXMvCgpUbzogcC5tb3VzYXZpemFkZWhf cHJvdG9ubWFpbC5jb20sICNtYW5wYWdlcywgI25ldHdvcmsKQ2M6IGltcCwgbmMsIGRvbm5lciwg ZnJlZWJzZC1uZXQtbGlzdCwgbWVsaWZhcm8sIGdsZWJpdXMsICNzcmNfY29tbWl0dGVycywgcC5t b3VzYXZpemFkZWhfcHJvdG9ubWFpbC5jb20sIGdoaXNsYWluX3NtYXJ0aXgubGxjLCBrb25yYWQu a3JlY2l3aWxrX2tvcmJhbmsucGwsIGNtaWxsZXJfbmV0YXBwLmNvbSwgcmFqZXNoYXNwLCBtbWFj eSwga3ByYXZlZW4ubGttbF9nbWFpbC5jb20sIGNocmlzX2NyZXRhZm9yY2UuZ3IsIHNpbW9udmVs bGFfZ21haWwuY29tLCBub3ZpY2VfdGVjaGllLmNvbSwgaGVyYmVydF9tYWlsYm94Lm9yZywgdG9t bWkucGVybmlsYV9pa2kuZmksIHplYywgZGVscGhpaiwgcHN0ZWYK From nobody Fri Jan 10 20:04:46 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YVCL66rhBz5kSm5 for ; Fri, 10 Jan 2025 20:04:46 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.chi.freebsd.org (mxrelay.chi.freebsd.org [IPv6:2610:1c0:1040:6064::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mxrelay.chi.freebsd.org", Issuer "E5" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YVCL66MMkz4VV8; Fri, 10 Jan 2025 20:04:46 +0000 (UTC) (envelope-from daemon-user@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736539486; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=bnQjB/hAeN/2ek8agmF1JSmhkPxbPFHljg0xhJB6EBc=; b=R4rZjoM+ZmhBCM6ao+N+7ISGo1r/LaaE7CQcU61gH0eB6qmSlCbcLn6kXEvamXblg8EZaD 3txDqhFdfR3GAY0QcevLeAtvfBInO+AbxwThj72NLRhuqO5lgGHBJdZ7/6oDMpTvJmn2dZ zNk+3BkOoYHoE6BtrFP0iArRu9N4wTc0TcrTIizRY9OoE/KypKQb3M5RITpgrL4hTvQxGf +xqAz83Im2xOyQj5Yp4ucjtOMgEmoW23FlVelRDNa7baoMHK/bSnzkFMpKqNJ279qSY9ka gBdZs6jAhSGc7n623kxAYckcDqA43JJhWgdvvtLyzykmHbK0AxHuDyyo1qtmhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736539486; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=bnQjB/hAeN/2ek8agmF1JSmhkPxbPFHljg0xhJB6EBc=; b=CHVgsBCbsob+z4vuPTrz/syoR+O9ov375WjdG1+HiWTbhtn2mdSKvPhOFGe7xqo8KCbOz4 /jWQefMEr44G8O/AQ5LR6QbSET7WeNQIhdP6EweO3b+f1vm+aPwxdLaNn7Yx9DkaoxTa/k dgd6Mz+XF8K2vYqQGjrQuQul0FurdXwWJxjoan9PMkRuGTmGGq+SE6rsVJhFRgYmFCw23e FLEX/gPYNP14N7JtuuWu4wR0+HJv2UwBzovyXZQhUEF6T+9pR8O9XQChvzZPrY+HPhrmil ha3oHY+Vn7q7YLkuoQJRfm9zlsiW21XjCqGZl+X1DDwN2GQVQkNF9bpwHyu0bg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736539486; a=rsa-sha256; cv=none; b=I0ySZrkfuY484DOPP3gn+E1a5FR5cortCL5Dqidl/HjMcs/SZD/dbkOF+3P+ayFj56cXyW mh0566VwA946J52iWqfKfYHQ4I9HyWJBe/103n3PQe7VzLcDyjrMrGdxHtxTqX/MoqQ9Z7 uUdFaJDZ0UJXlVJvLW8cJOj6eu/fmH2K5eaeBUfmUKm4oYsuCXGb10fZHNi5dZrO7F9lzO aJluE9+4Hoeg76Vlq3HBYVvCm5oJb3KIuXfWwgB707fjoS01zt8rLfN4EUxmtLd4LgaVyW RfIytaGYXkI09gOVGQUFvBs8Hpb56fr8bQNRgthxhjwMsBgLzdH2q0zrWi0FNg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from reviews.chi.freebsd.org (reviews.chi.freebsd.org [IPv6:2610:1c0:1040:606c::50:4]) by mxrelay.chi.freebsd.org (Postfix) with ESMTP id 8A89121347; Fri, 10 Jan 2025 20:04:46 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.chi.freebsd.org (Postfix, from userid 1346) id 8AE0C32491; Fri, 10 Jan 2025 20:04:46 +0000 (UTC) Date: Fri, 10 Jan 2025 20:04:46 +0000 To: Phabricator From: "glebius (Gleb Smirnoff)" Cc: freebsd-net@freebsd.org Reply-to: "glebius (Gleb Smirnoff)" Subject: [Differential] D48204: Add IPv6 support for address parsing and unparsing in ng_ksocket. Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , X-Herald-Rules: <28>, <125>, <128>, <147>, <79> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-3vpvqdpsy6sqgfqvqi4a X-Phabricator-Mail-ID: 4822331 X-Phabricator-Send-Attempt: nkthslatihjwouqx In-Reply-To: References: Thread-Index: N2JiNTc4NTM1ZGU5NjEzZjE3NjA3MGE5MzI3IGeBfV4= X-Phabricator-Stamps: actor(@glebius) application(Differential) author(@p.mousavizadeh_protonmail.com) herald(H28) herald(H79) herald(H125) herald(H128) herald(H147) monogram(D48204) object-type(DREV) phid(PHID-DREV-3vpvqdpsy6sqgfqvqi4a) reviewer(#manpages) reviewer(#network) revision-repository(rG) revision-status(published) subscriber(#src_committers) subscriber(@donner) subscriber(@freebsd-net-list) subscriber(@glebius) subscriber(@imp) subscriber(@melifaro) subscriber(@nc) tag(#network) via(daemon) List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_e448832478bb988307b138da53b342fd" --b1_e448832478bb988307b138da53b342fd Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 VGhpcyByZXZpc2lvbiB3YXMgbm90IGFjY2VwdGVkIHdoZW4gaXQgbGFuZGVkOyBpdCBsYW5kZWQg aW4gc3RhdGUgIk5lZWRzIFJldmlldyIuClRoaXMgcmV2aXNpb24gd2FzIGF1dG9tYXRpY2FsbHkg dXBkYXRlZCB0byByZWZsZWN0IHRoZSBjb21taXR0ZWQgY2hhbmdlcy4KQ2xvc2VkIGJ5IGNvbW1p dCByRzkyMzRhNTA3NTJjZDogbmdfa3NvY2tldDogYWRkIElQdjYgc3VwcG9ydCBmb3IgYWRkcmVz cyBwYXJzaW5nIGFuZCB1bnBhcnNpbmcgKGF1dGhvcmVkIGJ5IHAubW91c2F2aXphZGVoX3Byb3Rv bm1haWwuY29tLCBjb21taXR0ZWQgYnkgZ2xlYml1cykuCgpSRVBPU0lUT1JZCiAgckcgRnJlZUJT RCBzcmMgcmVwb3NpdG9yeQoKQ0hBTkdFUyBTSU5DRSBMQVNUIFVQREFURQogIGh0dHBzOi8vcmV2 aWV3cy5mcmVlYnNkLm9yZy9ENDgyMDQ/dnM9MTQ5MDM5JmlkPTE0OTA5MwoKQ0hBTkdFUyBTSU5D RSBMQVNUIEFDVElPTgogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9ENDgyMDQvbmV3LwoK UkVWSVNJT04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q0ODIwNAoKQUZG RUNURUQgRklMRVMKICBzaGFyZS9tYW4vbWFuNC9uZ19rc29ja2V0LjQKICBzeXMvbmV0Z3JhcGgv bmdfa3NvY2tldC5jCgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNk Lm9yZy9zZXR0aW5ncy9wYW5lbC9lbWFpbHByZWZlcmVuY2VzLwoKVG86IHAubW91c2F2aXphZGVo X3Byb3Rvbm1haWwuY29tLCAjbWFucGFnZXMsICNuZXR3b3JrCkNjOiBpbXAsIG5jLCBkb25uZXIs IGZyZWVic2QtbmV0LWxpc3QsIG1lbGlmYXJvLCBnbGViaXVzLCAjc3JjX2NvbW1pdHRlcnMsIHAu bW91c2F2aXphZGVoX3Byb3Rvbm1haWwuY29tLCBnaGlzbGFpbl9zbWFydGl4LmxsYywga29ucmFk LmtyZWNpd2lsa19rb3JiYW5rLnBsLCBjbWlsbGVyX25ldGFwcC5jb20sIHJhamVzaGFzcCwgbW1h Y3ksIGtwcmF2ZWVuLmxrbWxfZ21haWwuY29tLCBjaHJpc19jcmV0YWZvcmNlLmdyLCBzaW1vbnZl bGxhX2dtYWlsLmNvbSwgbm92aWNlX3RlY2hpZS5jb20sIGhlcmJlcnRfbWFpbGJveC5vcmcsIHRv bW1pLnBlcm5pbGFfaWtpLmZpLCB6ZWMsIGRlbHBoaWosIHBzdGVmCg== --b1_e448832478bb988307b138da53b342fd Content-Type: text/x-patch; charset=utf-8; name="D48204.149093.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D48204.149093.patch" ZGlmZiAtLWdpdCBhL3N5cy9uZXRncmFwaC9uZ19rc29ja2V0LmMgYi9zeXMvbmV0Z3JhcGgvbmdf a3NvY2tldC5jCi0tLSBhL3N5cy9uZXRncmFwaC9uZ19rc29ja2V0LmMKKysrIGIvc3lzL25ldGdy YXBoL25nX2tzb2NrZXQuYwpAQCAtNTgsNiArNTgsOSBAQAogI2luY2x1ZGUgPHN5cy91aW8uaD4K ICNpbmNsdWRlIDxzeXMvdW4uaD4KIAorI2luY2x1ZGUgPG5ldC9pZi5oPgorI2luY2x1ZGUgPG5l dC9pZl92YXIuaD4KKwogI2luY2x1ZGUgPG5ldGdyYXBoL25nX21lc3NhZ2UuaD4KICNpbmNsdWRl IDxuZXRncmFwaC9uZXRncmFwaC5oPgogI2luY2x1ZGUgPG5ldGdyYXBoL25nX3BhcnNlLmg+CkBA IC02Niw2ICs2OSw4IEBACiAjaW5jbHVkZSA8bmV0aW5ldC9pbi5oPgogI2luY2x1ZGUgPG5ldGlu ZXQvaXAuaD4KIAorI2luY2x1ZGUgPG5ldGluZXQ2L3Njb3BlNl92YXIuaD4KKwogI2lmZGVmIE5H X1NFUEFSQVRFX01BTExPQwogc3RhdGljIE1BTExPQ19ERUZJTkUoTV9ORVRHUkFQSF9LU09DS0VU LCAibmV0Z3JhcGhfa3NvY2siLAogICAgICJuZXRncmFwaCBrc29jayBub2RlIik7CkBAIC0xNDcs NiArMTUyLDE5IEBACiAJeyAic3dpcGUiLAlJUFBST1RPX1NXSVBFLAkJUEZfSU5FVAkJfSwKIAl7 ICJlbmNhcCIsCUlQUFJPVE9fRU5DQVAsCQlQRl9JTkVUCQl9LAogCXsgInBpbSIsCUlQUFJPVE9f UElNLAkJUEZfSU5FVAkJfSwKKwl7ICJpcDYiLAlJUFBST1RPX0lQVjYsCQlQRl9JTkVUNgl9LAor CXsgInJhdzYiLAlJUFBST1RPX1JBVywJCVBGX0lORVQ2CX0sCisJeyAiaWNtcDYiLAlJUFBST1RP X0lDTVBWNiwJCVBGX0lORVQ2CX0sCisJeyAiaWdtcDYiLAlJUFBST1RPX0lHTVAsCQlQRl9JTkVU Ngl9LAorCXsgInRjcDYiLAlJUFBST1RPX1RDUCwJCVBGX0lORVQ2CX0sCisJeyAidWRwNiIsCUlQ UFJPVE9fVURQLAkJUEZfSU5FVDYJfSwKKwl7ICJncmU2IiwJSVBQUk9UT19HUkUsCQlQRl9JTkVU Ngl9LAorCXsgImVzcDYiLAlJUFBST1RPX0VTUCwJCVBGX0lORVQ2CX0sCisJeyAiYWg2IiwJSVBQ Uk9UT19BSCwJCVBGX0lORVQ2CX0sCisJeyAic3dpcGU2IiwJSVBQUk9UT19TV0lQRSwJCVBGX0lO RVQ2CX0sCisJeyAiZW5jYXA2IiwJSVBQUk9UT19FTkNBUCwJCVBGX0lORVQ2CX0sCisJeyAiZGl2 ZXJ0NiIsCUlQUFJPVE9fRElWRVJULAkJUEZfSU5FVDYJfSwKKwl7ICJwaW02IiwJSVBQUk9UT19Q SU0sCQlQRl9JTkVUNgl9LAogCXsgTlVMTCwJCS0xCQkJCQl9LAogfTsKIApAQCAtMjk2LDkgKzMx NCw1OCBAQAogCQlicmVhazsKIAkgICAgfQogCi0jaWYgMAotCWNhc2UgUEZfSU5FVDY6CS8qIFhY WCBpbXBsZW1lbnQgdGhpcyBzb21lZGF5ICovCi0jZW5kaWYKKwljYXNlIFBGX0lORVQ2OgorCSAg ICB7CisJCXN0cnVjdCBzb2NrYWRkcl9pbjYgKmNvbnN0IHNpbjYgPSAoc3RydWN0IHNvY2thZGRy X2luNiAqKXNhOworCQljaGFyICplcHRyOworCQljaGFyIGFkZHJbSU5FVDZfQUREUlNUUkxFTl07 CisJCWNoYXIgaWZuYW1lWzE2XTsKKwkJdV9sb25nIHBvcnQ7CisJCWJvb2wgaGFzaWZuYW1lID0g dHJ1ZTsKKworCQkvKiBSRkMgMzk4NiBTZWN0aW9uIDMuMi4yLCBWYWxpZGF0ZSBJUCBsaXRlcmFs IHdpdGhpbiBzcXVhcmUgYnJhY2tldHMuICovCisJCWlmIChzWypvZmZdID09ICdbJyAmJiAoc3Ry c3RyKCZzWypvZmZdLCAiXSIpKSkKKwkJCSgqb2ZmKSsrOworCQllbHNlCisJCQlyZXR1cm4gKEVJ TlZBTCk7CisJCWlmICgoZXB0ciA9IHN0cnN0cigmc1sqb2ZmXSwgIiUiKSkgPT0gTlVMTCkgewor CQkJaGFzaWZuYW1lID0gZmFsc2U7CisJCQllcHRyID0gc3Ryc3RyKCZzWypvZmZdLCAiXSIpOwor CQl9CisJCXNucHJpbnRmKGFkZHIsIGVwdHIgLSAocyArICpvZmYpICsgMSwgIiVzIiwgJnNbKm9m Zl0pOworCQkqb2ZmICs9IChlcHRyIC0gKHMgKyAqb2ZmKSk7CisJCWlmICghaW5ldF9wdG9uKEFG X0lORVQ2LCBhZGRyLCAmc2luNi0+c2luNl9hZGRyKSkKKwkJCXJldHVybiAoRUlOVkFMKTsKKwor CQlpZiAoaGFzaWZuYW1lKSB7CisJCQl1aW50MTZfdCBzY29wZTsKKworCQkJZXB0ciA9IHN0cnN0 cigmc1sqb2ZmXSwgIl0iKTsKKwkJCSgqb2ZmKSsrOworCQkJc25wcmludGYoaWZuYW1lLCBlcHRy IC0gKHMgKyAqb2ZmKSArIDEsICIlcyIsICZzWypvZmZdKTsKKwkJCSpvZmYgKz0gKGVwdHIgLSAo cyArICpvZmYpKTsKKworCQkJaWYgKHNpbjYtPnNpbjZfYWRkci5zNl9hZGRyMTZbMF0gIT0gSVBW Nl9BRERSX0lOVDE2X1VMTCkKKwkJCQlyZXR1cm4gKEVJTlZBTCk7CisJCQlzY29wZSA9IGluNl9n ZXRzY29wZSgmc2luNi0+c2luNl9hZGRyKTsKKwkJCXNpbjYtPnNpbjZfc2NvcGVfaWQgPQorCQkJ ICAgIGluNl9nZXRzY29wZXpvbmUoaWZ1bml0KGlmbmFtZSksIHNjb3BlKTsKKwkJfQorCisJCSgq b2ZmKSsrOworCQlpZiAoc1sqb2ZmXSA9PSAnOicpIHsKKwkJCSgqb2ZmKSsrOworCQkJcG9ydCA9 IHN0cnRvdWwocyArICpvZmYsICZlcHRyLCAxMCk7CisJCQlpZiAocG9ydCA+IDB4ZmZmZiB8fCBl cHRyID09IHMgKyAqb2ZmKQorCQkJCXJldHVybiAoRUlOVkFMKTsKKwkJCSpvZmYgKz0gKGVwdHIg LSAocyArICpvZmYpKTsKKwkJCXNpbjYtPnNpbjZfcG9ydCA9IGh0b25zKHBvcnQpOworCQl9IGVs c2UKKwkJCXNpbjYtPnNpbjZfcG9ydCA9IDA7CisKKwkJc2luNi0+c2luNl9sZW4gPSBzaXplb2Yo KnNpbjYpOworCQlicmVhazsKKwkgICAgfQogCiAJZGVmYXVsdDoKIAkJcmV0dXJuIChFSU5WQUwp OwpAQCAtMzU4LDkgKzQyNSwyNCBAQAogCQlyZXR1cm4oMCk7CiAJICAgIH0KIAotI2lmIDAKLQlj YXNlIFBGX0lORVQ2OgkvKiBYWFggaW1wbGVtZW50IHRoaXMgc29tZWRheSAqLwotI2VuZGlmCisJ Y2FzZSBQRl9JTkVUNjoKKwkgICAgeworCQljb25zdCBzdHJ1Y3Qgc29ja2FkZHJfaW42ICpzaW42 ID0gKGNvbnN0IHN0cnVjdCBzb2NrYWRkcl9pbjYgKilzYTsKKwkJY2hhciBhZGRyW0lORVQ2X0FE RFJTVFJMRU5dOworCisJCWluZXRfbnRvcChBRl9JTkVUNiwgJnNpbjYtPnNpbjZfYWRkciwgYWRk ciwgSU5FVDZfQUREUlNUUkxFTik7CisJCXNsZW4gKz0gc25wcmludGYoY2J1ZiwgY2J1Zmxlbiwg ImluZXQ2L1slc10iLCBhZGRyKTsKKworCQlpZiAoc2luNi0+c2luNl9wb3J0ICE9IDApIHsKKwkJ CXNsZW4gKz0gc25wcmludGYoY2J1ZiArIHN0cmxlbihjYnVmKSwKKwkJCSAgICBjYnVmbGVuIC0g c3RybGVuKGNidWYpLCAiOiVkIiwKKwkJCSAgICAodV9pbnQpbnRvaHMoc2luNi0+c2luNl9wb3J0 KSk7CisJCX0KKwkJaWYgKHNsZW4gPj0gY2J1ZmxlbikKKwkJCXJldHVybiAoRVJBTkdFKTsKKwkJ Km9mZiArPSBzaXplb2YoKnNpbjYpOworCQlyZXR1cm4oMCk7CisJICAgIH0KIAogCWRlZmF1bHQ6 CiAJCXJldHVybiAoKm5nX2tzb2NrZXRfZ2VuZXJpY19zb2NrYWRkcl90eXBlLnN1cGVydHlwZS0+ dW5wYXJzZSkKZGlmZiAtLWdpdCBhL3NoYXJlL21hbi9tYW40L25nX2tzb2NrZXQuNCBiL3NoYXJl L21hbi9tYW40L25nX2tzb2NrZXQuNAotLS0gYS9zaGFyZS9tYW4vbWFuNC9uZ19rc29ja2V0LjQK KysrIGIvc2hhcmUvbWFuL21hbjQvbmdfa3NvY2tldC40CkBAIC0zMiw3ICszMiw3IEBACiAuXCIK IC5cIiBBdXRob3I6IEFyY2hpZSBDb2JicyA8YXJjaGllQEZyZWVCU0Qub3JnPgogLlwiCi0uRGQg SmFudWFyeSA5LCAyMDEyCisuRGQgSmFudWFyeSA5LCAyMDI1CiAuRHQgTkdfS1NPQ0tFVCA0CiAu T3MKIC5TaCBOQU1FCkBAIC0xODMsNyArMTgzLDggQEAKIGVxdWl2YWxlbnQgb2YgdGhlIEMgc3Ry dWN0dXJlCiBpcyBhbiBhY2NlcHRhYmxlIGZvcm0uCiBGb3IgdGhlCi0uRHYgUEZfSU5FVAorLkR2 IFBGX0lORVQgLAorLkR2IFBGX0lORVQ2CiBhbmQKIC5EdiBQRl9MT0NBTAogYWRkcmVzcyBmYW1p bGllcywgYSBtb3JlIGNvbnZlbmllbnQgZm9ybSBpcyBhbHNvIHVzZWQsIHdoaWNoIGlzCkBAIC0x OTEsNyArMTkyLDExIEBACiBhZGRyZXNzLgogRm9yCiAuRHYgUEZfSU5FVCAsCi10aGUgYWRkcmVz cyBpcyBhbiBJUCBhZGRyZXNzIGZvbGxvd2VkIGJ5IGFuIG9wdGlvbmFsIGNvbG9uIGFuZCBwb3J0 IG51bWJlci4KK3RoZSBhZGRyZXNzIGlzIGFuIElQdjQgYWRkcmVzcyBmb2xsb3dlZCBieSBhbiBv cHRpb25hbCBjb2xvbiBhbmQgcG9ydCBudW1iZXIuCitGb3IKKy5EdiBQRl9JTkVUNiAsCit0aGUg YWRkcmVzcyBpcyBhbiBJUHY2IGFkZHJlc3MgZW5jbG9zZWQgaW4gc3F1YXJlIGJyYWNrZXRzIGZv bGxvd2VkCitieSBhbiBvcHRpb25hbCBjb2xvbiBhbmQgcG9ydCBudW1iZXIuCiBGb3IKIC5EdiBQ Rl9MT0NBTCAsCiB0aGUgYWRkcmVzcyBpcyB0aGUgcGF0aG5hbWUgYXMgYSBkb3VibHkgcXVvdGVk IHN0cmluZy4KQEAgLTIwMiw2ICsyMDcsOCBAQAogbG9jYWwvIi90bXAvZm9vLnNvY2tldCIKIC5J dCBEdiBQRl9JTkVUCiBpbmV0LzE5Mi4xNjguMS4xOjEyMzQKKy5JdCBEdiBQRl9JTkVUNgoraW5l dDYvWzIwMDE6OjFdOjEyMzQKIC5JdCBPdGhlcgogLkR2ICJcJnsgZmFtaWx5PTE2IGxlbj0xNiBk YXRhPVsweDcwIDB4MDAgMHgwMSAweDIzXSBcJn0iCiAuRWwKCg== --b1_e448832478bb988307b138da53b342fd-- From nobody Sat Jan 11 06:25:22 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YVT6N04TVz5lMYd for ; Sat, 11 Jan 2025 06:25:32 +0000 (UTC) (envelope-from paul@redbarn.org) Received: from util.redbarn.org (util.redbarn.org [IPv6:2001:559:8000:cd::222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.redbarn.org", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YVT6L6VDGz4mZr; Sat, 11 Jan 2025 06:25:30 +0000 (UTC) (envelope-from paul@redbarn.org) Authentication-Results: mx1.freebsd.org; dkim=fail ("headers rsa verify failed") header.d=redbarn.org header.s=util header.b=fZCPfNqO; spf=pass (mx1.freebsd.org: domain of paul@redbarn.org designates 2001:559:8000:cd::222 as permitted sender) smtp.mailfrom=paul@redbarn.org; dmarc=pass (policy=reject) header.from=redbarn.org Received: from family.redbarn.org (family.redbarn.org [24.104.150.213]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.redbarn.org", Issuer "RapidSSL TLS RSA CA G1" (not verified)) by util.redbarn.org (Postfix) with ESMTPS id 2988A160C31; Sat, 11 Jan 2025 06:25:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=redbarn.org; s=util; t=1736576725; bh=smf6MFk8SLEuXVLnJg6L0n/LLtqyuTSmKb5AsBauQTg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fZCPfNqO58Y+MQZNZRiMuz8wpZMZ5Cy+Q3jXjxFQiEn3hP/nPW0euOfzHprdn6Mdl r0xVblZM85gSaWWEbcpUJZqBGO2XbxPkBOBHqnU26nWCclDXOQpMitROC4c+i/2R9F AILGjD0UXzwaAdPValLDad08xyk/5uf1OlW01eMo= Received: from localhost.localnet (dhcp-159.access.rits.tisf.net [24.104.150.159]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by family.redbarn.org (Postfix) with ESMTPSA id 08798C3F22; Sat, 11 Jan 2025 06:25:25 +0000 (UTC) From: Paul Vixie To: Mark Johnston Cc: freebsd-net@freebsd.org Subject: Re: per-FIB socket binding Date: Sat, 11 Jan 2025 06:25:22 +0000 Message-ID: <3330519.aeNJFYEL58@localhost> Organization: FW In-Reply-To: References: <7772475.EvYhyI6sBW@dhcp-151.access.rits.tisf.net> <38589000.XM6RcZxFsP@dhcp-151.access.rits.tisf.net> List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 4YVT6L6VDGz4mZr X-Spamd-Bar: -- X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; CTE_CASE(0.50)[]; DMARC_POLICY_ALLOW_WITH_FAILURES(-0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:559:8000::/48]; RCVD_IN_DNSWL_MED(-0.20)[24.104.150.213:received]; MIME_GOOD(-0.10)[text/plain]; R_DKIM_REJECT(0.00)[redbarn.org:s=util]; DMARC_POLICY_ALLOW(0.00)[redbarn.org,reject]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; HAS_ORG_HEADER(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[freebsd-net@freebsd.org]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[redbarn.org:-]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:33651, ipnet:2001:559:8000::/48, country:US]; MISSING_XM_UA(0.00)[]; FREEFALL_USER(0.00)[paul]; RCVD_IN_DNSWL_NONE(0.00)[2001:559:8000:cd::222:from] On Monday, January 6, 2025 3:56:55 PM UTC Mark Johnston wrote: > On Fri, Dec 27, 2024 at 08:48:48AM +0000, Paul Vixie wrote: > > ... > I think the patch is probably a good idea, and the trick of only > inheriting the packet's FIB if the socket's is non-zero would avoid > breaking compatibility for most cases. note, i often feel that integers aren't booleans and shouldn't be treated as booleans. however, i can't easily look at x = (y != 0) ? y : z; when i know it could be written instead x = y || z; so if this is forbidden by today's freebsd kernel rules, please educate me. i know that GCC and CLang will optimize down to the same instruction sequence for either, but i prefer the shorter form since in this rare case it is clearer. > One side effect of the patch is that a service listening in FIB 0 that > has no route to the source address of a connection attempt from a > different FIB would previously not accept such a connection, but now it > will. Perhaps that's drastic enough to warrant a sysctl and/or sockopt > to control this behaviour. i hope not. the SYN|ACK will always use the FIB from the interface where the SYN arrived (this is in tcp_syncache.c). if the SYN's source address isn't allowed by uRPF or other checking (in PF or IPFW) this will be determined by the FIB in the SYN's PKTHDR not the one we put into the PCB. whereas if there is some user-mode ACL processing (for example in BIND9's "allow-transfer") there is no way to learn the socket's FIB. i think this excludes the case where we would have rejected a connection if only the interface's FIB had not been stamped onto the PCB. as before please educate me if i'm misunderstanding you, and i apologize in advance for the extra work involved in doing so. > It would be better to pass the fibnum to solisten_clone() and assign it > there. Otherwise, the value of so_fibnum will be wrong for a short > window during which the socket is passed to MAC and other hooks, which > might have some surprising effects. it shall be done. thanks for your review. more reviews would be welcome. i'm working on the bind() case now, so that the socket's FIB if still zero will be made equal to the FIB of the interface where the laddr is found. this still won't handle UDP responses but it will take care of TCP, UDP, and SCTP initiators. and i think i'm going to implement this for SCTP responders even though i can't test it here since it looks simple. (famous last words, i know.) -- Paul Vixie From nobody Sat Jan 11 16:51:07 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YVl0J3P4Nz5kb1d for ; Sat, 11 Jan 2025 16:51:12 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YVl0J1QWbz4pWj for ; Sat, 11 Jan 2025 16:51:12 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-4679fc9b5f1so23542201cf.1 for ; Sat, 11 Jan 2025 08:51:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736614271; x=1737219071; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=N3MGvEA9rDYZ3NKFJMzgsut/XahJp+Dcrdi+JWvQePk=; b=KTgTV9g+RcKWouW3pyLrnAuIvHeihWZSxFAhHRmauimTkjU9d2rzI3Q5LFi03KR7jq qrN+wUU6bS0/ofzTLDur6isl/c+jimX9+HokJCI7qOKglp78GQct7hf2w72IoieUYxcF GLBwx8Pl9ZpwNMWk7xrellXAnaS6ApuuiTlK/+QAo4Kw0fzUeyM8ND+MpB1j3UiQ4gAl LwrU/mu2xm8SBPvecuuYcbmgp8ffWnj0M1vDHzECn59fWWak5g1S18yj2CSqqCcK3YC/ 1PFrUVlhjdJ/YkufVLu+tZtwzeqflRaKh0aFXhUsd8/RhCy7aPo+HqvxwCXHQ25B2W/k 4oKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736614271; x=1737219071; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N3MGvEA9rDYZ3NKFJMzgsut/XahJp+Dcrdi+JWvQePk=; b=vG/D0qEVexQjj+cgysnrKe9MLSeuWPYHGz+hff+JGRhKUOp10c63x9+cBriOL68m8V IBk3lqLOsmenRXJ4zEv5EITIZGqD/zuMIBBVVAK4WCPu9fZhepIRux8DjWN1ufG1NT09 W5yIzJtxtsem1UJdieGLG6s0OFTcgXpDODJeYu66yha7bti56tU0S3l1r+yTT+ZkzqQu r0DzGcgfy/cApmm/IA0mr0sQcWGOsrWqBdfPoixFcjeuONrnW30fnUiuD1ZchnYyN5ZD qhOlI1FyEpCpCfgth1mCDsJQVLbNvNEHkrWNKJJp+lz/hxz3zzDcRi5+89GvVUodFuAv XAbQ== X-Gm-Message-State: AOJu0YzToFhgkTXs5D1lJetmoKGQTnthKg0Bx9BBlilaEDdFslWtiE9+ SdboJv49wan+VYsnGSeZWuVzacaL2TN25eWzJ3nsu/8GdwBN0R5UIP68Nw== X-Gm-Gg: ASbGnctsuC7xLnuJB5KXGBn50TCkBZ1Y2YxdGfE55bSjxfizFPWl1ZX96Lg2oZq3S9t Q17MSdKz0RYyWm96CdAKLoZ1u12DiWBZr8ZVlvoWq/GbPUN5wP10zDFBskkKcMfMRXORZY8G35S ABuOizYqcTBAQDx3OBzWIWlTCbEXO0THMj2/OlXNnBjfXqWaplUw+jLVYd/nODFasM6Iq5Vf7VB CTf++U3NVK9maK8QIr9kTm9TgxF0yboFmbOD90hTGnvA+bdwBQlmetCXmz0K8qEsKmyw10= X-Google-Smtp-Source: AGHT+IEmjYzTRoyhLuOYnK4F/JVs7F9xGaisKoyI2tw7cPbnnx1XxKtvj9Xpt+oJ0aVp7H5i8HMAOA== X-Received: by 2002:ac8:5fd1:0:b0:467:8651:40a2 with SMTP id d75a77b69052e-46c7108ee68mr266995271cf.13.1736614271181; Sat, 11 Jan 2025 08:51:11 -0800 (PST) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46c873216dbsm21652031cf.7.2025.01.11.08.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2025 08:51:10 -0800 (PST) Date: Sat, 11 Jan 2025 11:51:07 -0500 From: Mark Johnston To: Paul Vixie Cc: freebsd-net@freebsd.org Subject: Re: per-FIB socket binding Message-ID: References: <7772475.EvYhyI6sBW@dhcp-151.access.rits.tisf.net> <38589000.XM6RcZxFsP@dhcp-151.access.rits.tisf.net> <3330519.aeNJFYEL58@localhost> List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3330519.aeNJFYEL58@localhost> X-Rspamd-Queue-Id: 4YVl0J1QWbz4pWj X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] On Sat, Jan 11, 2025 at 06:25:22AM +0000, Paul Vixie wrote: > On Monday, January 6, 2025 3:56:55 PM UTC Mark Johnston wrote: > > On Fri, Dec 27, 2024 at 08:48:48AM +0000, Paul Vixie wrote: > > > ... > > > I think the patch is probably a good idea, and the trick of only > > inheriting the packet's FIB if the socket's is non-zero would avoid > > breaking compatibility for most cases. > > note, i often feel that integers aren't booleans and shouldn't be treated as > booleans. however, i can't easily look at > > x = (y != 0) ? y : z; > > when i know it could be written instead > > x = y || z; > > so if this is forbidden by today's freebsd kernel rules, please educate me. i > know that GCC and CLang will optimize down to the same instruction sequence > for either, but i prefer the shorter form since in this rare case it is > clearer. We are not super consistent about it, but style(9) does prescribe explicit comparisons, i.e., "if (count != 0)" rather than "if (count)". In any case, I'd add a comment, since that assignment is a bit subtle. > > One side effect of the patch is that a service listening in FIB 0 that > > has no route to the source address of a connection attempt from a > > different FIB would previously not accept such a connection, but now it > > will. Perhaps that's drastic enough to warrant a sysctl and/or sockopt > > to control this behaviour. > > i hope not. the SYN|ACK will always use the FIB from the interface where the > SYN arrived (this is in tcp_syncache.c). This isn't clear to me. The initial SYN will create a syncache entry in the if (tp->t_state == TCPS_LISTEN && SOLISTENING(so)) case in tcp_input_with_port(). In this case we define inc.inc_fibnum = so->so_fibnum, i.e., the FIB of the listening socket. Then, syncache_add() copies inc to sc_inc, so sc_inc.inc_fibnum for the syncache entry comes from the listening socket, and syncache_respond() sets the SYN|ACK mbuf FIB with M_SETFIB(m, sc->sc_inc.inc_fibnum). What am I missing? (Yes, I should actually do an experiement to check the behaviour.) > if the SYN's source address isn't > allowed by uRPF or other checking (in PF or IPFW) this will be determined by > the FIB in the SYN's PKTHDR not the one we put into the PCB. whereas if there > is some user-mode ACL processing (for example in BIND9's "allow-transfer") > there is no way to learn the socket's FIB. i think this excludes the case > where we would have rejected a connection if only the interface's FIB had not > been stamped onto the PCB. as before please educate me if i'm misunderstanding > you, and i apologize in advance for the extra work involved in doing so. > > > It would be better to pass the fibnum to solisten_clone() and assign it > > there. Otherwise, the value of so_fibnum will be wrong for a short > > window during which the socket is passed to MAC and other hooks, which > > might have some surprising effects. > > it shall be done. thanks for your review. > > more reviews would be welcome. i'm working on the bind() case now, so that the > socket's FIB if still zero will be made equal to the FIB of the interface > where the laddr is found. this still won't handle UDP responses but it will > take care of TCP, UDP, and SCTP initiators. and i think i'm going to implement > this for SCTP responders even though i can't test it here since it looks > simple. (famous last words, i know.) > > -- > Paul Vixie > > From nobody Sun Jan 12 07:17:48 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YW6DM4XFkz5kfSr for ; Sun, 12 Jan 2025 07:17:55 +0000 (UTC) (envelope-from paul@redbarn.org) Received: from util.redbarn.org (util.redbarn.org [24.104.150.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.redbarn.org", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YW6DL6ms5z42lr; Sun, 12 Jan 2025 07:17:54 +0000 (UTC) (envelope-from paul@redbarn.org) Authentication-Results: mx1.freebsd.org; none Received: from family.redbarn.org (family.redbarn.org [IPv6:2001:559:8000:cd::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.redbarn.org", Issuer "RapidSSL TLS RSA CA G1" (not verified)) by util.redbarn.org (Postfix) with ESMTPS id 7D972160C2F; Sun, 12 Jan 2025 07:17:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=redbarn.org; s=util; t=1736666272; bh=yjfUBGpzqRwNxv3qPD8bb+plmyIyxJ7kvKpbYNzTyzc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=qTDVekYgQ3W0TVuUpBwW/x9e+sm0BI3d3xgI7KBW9yNQr/+y0ONyNMy8BIAgr7rnO WG19OPwIR031TotMQBhIV1MNJXn6Fem6p5OIgBI7zJ3BG5wqHhHYGN1PdCx+QjF+Iv F68A6HET9mJyzW0NC6Zi7wO3UbNNPo9AZMxgAnBY= Received: from localhost.localnet (dhcp-159.access.rits.tisf.net [24.104.150.159]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by family.redbarn.org (Postfix) with ESMTPSA id 4BC59C3F22; Sun, 12 Jan 2025 07:17:52 +0000 (UTC) From: Paul Vixie To: Mark Johnston Cc: freebsd-net@freebsd.org Subject: Re: per-FIB socket binding Date: Sun, 12 Jan 2025 07:17:48 +0000 Message-ID: <2841433.BEx9A2HvPv@localhost> Organization: FW In-Reply-To: References: <7772475.EvYhyI6sBW@dhcp-151.access.rits.tisf.net> <3330519.aeNJFYEL58@localhost> List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Rspamd-Queue-Id: 4YW6DL6ms5z42lr X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:33651, ipnet:24.104.150.0/24, country:US] On Saturday, January 11, 2025 4:51:07 PM UTC Mark Johnston wrote: > On Sat, Jan 11, 2025 at 06:25:22AM +0000, Paul Vixie wrote: > > On Monday, January 6, 2025 3:56:55 PM UTC Mark Johnston wrote: > > > On Fri, Dec 27, 2024 at 08:48:48AM +0000, Paul Vixie wrote: > > ... > >=20 > > x =3D y || z; > >=20 > > so if this is forbidden by today's freebsd kernel rules, please educate > > me. i know that GCC and CLang will optimize down to the same instruction > > sequence for either, but i prefer the shorter form since in this rare > > case it is clearer. >=20 > We are not super consistent about it, but style(9) does prescribe > explicit comparisons, i.e., "if (count !=3D 0)" rather than "if (count)". > In any case, I'd add a comment, since that assignment is a bit subtle. i'll add this comment: /* ref. ISO/IEC 9899:2023 =A7 6.5.15 */ =2E..and let the reviewers sort it out. > > ... the SYN|ACK will always use the FIB from the interface where > > the SYN arrived (this is in tcp_syncache.c). >=20 > This isn't clear to me. The initial SYN will create a syncache entry in = the >=20 > if (tp->t_state =3D=3D TCPS_LISTEN && SOLISTENING(so)) >=20 > case in tcp_input_with_port(). In this case we define inc.inc_fibnum =3D > so->so_fibnum, i.e., the FIB of the listening socket. Then, > syncache_add() copies inc to sc_inc, so sc_inc.inc_fibnum for the > syncache entry comes from the listening socket, and syncache_respond() > sets the SYN|ACK mbuf FIB with M_SETFIB(m, sc->sc_inc.inc_fibnum). What > am I missing? (Yes, I should actually do an experiement to check the > behaviour.) this is exactly my understanding of that code. the FIB for the SYN|ACK will= be=20 the one from the interface who received the SYN. it's only later after we=20 receive the ACK that completes the 3-way handshake that we will begin to us= e=20 the FIB of the socket. in terms of your earlier question, this means if we'= re=20 going to drop a SYN because it came in on the wrong interface (some form of= =20 uRPF) then the firewall module (PF or IPFW) will be doing that to the SYN w= ell=20 before a syncache entry is ever created. this seems to imply that the chang= es=20 i'm proposing won't be able to permit connections to complete that would ha= ve=20 not have completed -- which you correctly predicted could be surprising. the kernel implementations of uRPF-like features are unaffected. /* * net.inet.ip.rfc1122_strong_es: the address matches, veri= fy * that the packet arrived via the correct interface. */ if (__predict_false(strong_es && ia->ia_ifp !=3D ifp)) { IPSTAT_INC(ips_badaddr); goto bad; } we're not changing the inbound packet's FIB. /* * net.inet.ip.source_address_validation: drop incoming * packets that pretend to be ours. */ if (V_ip_sav && !(ifp->if_flags & IFF_LOOPBACK) && __predict_false(in_localip_fib(ip->ip_src, ifp->if_fib)= )) =20 { IPSTAT_INC(ips_badaddr); goto bad; } unless i misunderstand, this only rejects packets if the source address is = the=20 same as one of the addresses of the interface it arrives on, whereas the=20 documentation made me expect that a source address which was any address of= =20 any interface would be the trigger. i think my proposal doesn't change this. therefore my focus was on the verrevpath, versrcreach, and antispoof featur= es=20 of IPFW; and the antispoof feature of PF. in those tools, the inbound SYN=20 would be stopped before it ever reached the SYN cache. what i then observed is that the only change resulting from my proposal wou= ld=20 be to the transmission of subsequent segments, which would use the interfac= e's=20 =46IB (if nonzero) rather than the socket's FIB (if zero). if upstream uRPF= =20 would have dropped these segments because they're coming from the wrong pla= ce,=20 then indeed failure would result, and even FIN and RST could not be=20 transmitted, which would mean the socket would die a slow death by eventual= =20 timeout. my proposal would prevent this, but i think any surprise in this c= ase=20 would be a welcome one. if actual segments could not be transmitted because= =20 the socket's FIB did not contain a route back to the connection's source, t= hen=20 failure would be more immediate but the resulting surprise (if any) no less= =20 positive. i hope that if that analysis is correct no-one will demand a socket option = or=20 sysctl. to be effective at fixing path symmetry for multihoming, this logic= =20 has to be the default. =2D-- having finished with accept(), i'm now testing the bind() and bindat()=20 changes, which ought to be effective for any UDP responder who uses a separ= ate=20 socket for each interface address it speaks through, which certainly includ= es=20 all NTP and DNS servers i'm aware of, and may also help QUIC. i've begun to wish for a setfib_fd(2) which would let sshd promote the FIB= =20 from an inbound connection to be process-wide (after fork() before exec().)= =20 that way "netstat -rn" would show the routing table actually being used by = the=20 stdin and stdout of that shell. or perhaps we could just rename SO_SETFIB t= o=20 be SO_FIB and allow getsockopt() to return the FIB? (i'm not sure why it wa= s=20 "set only" in the current implementation.) opinions welcomed, as before.=20 =2D-=20 Paul Vixie From nobody Sun Jan 12 17:37:10 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YWMyw43Pkz5l1Rt for ; Sun, 12 Jan 2025 17:37:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YWMyw0YVdz472f for ; Sun, 12 Jan 2025 17:37:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736703432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gots0RK8gmmRH6rLNwxCV8c9nydR5yqFmAS1Lb5BKAM=; b=ScoYyBZdfOxbkmJov2E298i6Y3EM2sZHz1q+PGHuUYrfM2+Px+KhozYCSSaABBKVVoVxWQ cTATnbac7NWWEN+nBhV7Rk8Zd4EofQXDNLiwUaP8cR1j0QYhrm9PHeMCSDq+hv6PYRakzL Cw/VT1rv78klKv5nRO3JIAe1S63+oZdChN8oiS116h1pM4lEO9yBqzp26IBQ/43tOxw6yE hPnE4BLKD4B198N1CjjxGTX8Ym3Y4sH15cUrM9s//H2okGk4BN6zoBMaFqpkBlVnY9Me3M J7rjlFnKJ/ZqfY9C3elk7ABxZAZl5tZlNBhtICEA0UlcO3g5UeYlHgmcjcXpqw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736703432; a=rsa-sha256; cv=none; b=SFsCqXgKxOhk7OjWKOr4GlhGD0IsjU8LlDa5FLD6xO8N/Va6lKe8qTjVmH0UdLaITqih/a uKgRc8D+M9oZsKLn/jCJA49F4KKhcitRGdB6fqOfSSiNJKCsVPH3dLJkOlsnX+92awtsGW WVC5tmLgim5awexQbFOo9qsj0Ju33PsNk6/lhgwsKHb/5oDFS+6Vc10AgHjw2lFRHKSBe7 dskRAtKObBkgLGsLUYRIzREDozn+a9SMuq3wxucfIQ9EAMVhG31Ydx21SG3CGsXIvhuy1f KqMD0Ft0Ox6I60SWGoLFvZ/NAgem4FS36wNO5g4geaxFbQEvJw/enLWFX/shVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YWMyv71Ymzv7l for ; Sun, 12 Jan 2025 17:37:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 50CHbBt3033585 for ; Sun, 12 Jan 2025 17:37:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 50CHbBMQ033584 for net@FreeBSD.org; Sun, 12 Jan 2025 17:37:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 234624] FreeBSD 12.0 ix driver TX TSO vlan-tagged network regression from 11.2 Date: Sun, 12 Jan 2025 17:37:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: IntelNetworking, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: keywords component cc Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234624 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |IntelNetworking Component|misc |kern CC| |bugmeister@FreeBSD.org --- Comment #4 from Mark Linimon --- ^Triage: to submitter: this aging PR has to deal with FreeBSD 12, which is = out of support. Does this problem still recur on more recent versions of FreeBSD? --=20 You are receiving this mail because: You are the assignee for the bug.=