From nobody Mon Apr 7 19:35:16 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZWfZ95gZJz5s2r0; Mon, 07 Apr 2025 19:35:29 +0000 (UTC) (envelope-from y.jaeyong@gmail.com) Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZWfZ86C0Pz3sYR; Mon, 07 Apr 2025 19:35:28 +0000 (UTC) (envelope-from y.jaeyong@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=aeK3NEjU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of y.jaeyong@gmail.com designates 2607:f8b0:4864:20::933 as permitted sender) smtp.mailfrom=y.jaeyong@gmail.com Received: by mail-ua1-x933.google.com with SMTP id a1e0cc1a2514c-86d30787263so2212598241.1; Mon, 07 Apr 2025 12:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744054527; x=1744659327; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ouw79k4tnMl7vTbMjEufJV43AMCPEQw61NNUlnkViUQ=; b=aeK3NEjUBwDc/lqDOP0WLy5sc7Tipm1aOc7+eLpooRUbra5K5Rox4axwjGvbrbzN5u gxISbO8Hphr5PrfD2n18nztfcx5W7DByuHqYIGZ3psSBIcpR3qPKxfTO+oUhuL823s7l +vKGPXokhN2B2wuXvdEK8sLC7dEFCILIcb6UmsVf8MpnBpFTE/ppXN/tYwGz4ucMLWbl REEw7whUvzy1Mc81ZP83KOpVHdPQm4oVvjvH/qWRrDOzwOvgSlw211wMnaPrBTJ17HTZ a/RpmP0Bo6uNgwfedqW+Lccs5ZGnrseE87/rIFo1KWeUORU239teb8Iox9gtxaESkVB1 leIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744054527; x=1744659327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ouw79k4tnMl7vTbMjEufJV43AMCPEQw61NNUlnkViUQ=; b=iNzS/GP0OCsy8PoR24jMuobfcJZ6wk3Fd5m4JgyJMKJKWsW3krxkb+JvjKGntZtsPe dbduAfzDP6s07UsMwLxF1Cx9C6MYxQQ6BeBQpTSZXYTZg7tCJXQXCOIvxvGYUPAkwgEM HZAirYEsItfAXrvoaWxxjE7OxWkE9dKHTkh8whtgY16ZH9qbWhFBnnTub2C5caeIPDhe 11e6fwH7anko1cUhFP+2bt8QVOpTLsObRItFNfVALnbVryZnSXzu12mAHr3ne50LuBCi 5b6v2hKGWktIC9AQ2rbeePnZJ3JZr1ymxRpVbocloEZSrKcpkqnSytj0pMUUPjmJSjVj EFOg== X-Forwarded-Encrypted: i=1; AJvYcCUl7LIPgYtQHWiLigIHqFyhtnti/XANEZrGRrCBtfRkQfSA6oC7NRHVv2N4+IhxqOJqK+BXBCPpDgdq3cYijqhcZQ==@freebsd.org X-Gm-Message-State: AOJu0YwVBonN1kpeHsRDmp+EIBocVGfoRLZyqnFcHt4uOGOgxY8V+cTv GwMnMjkDTMtrXfeOBdxNC887iF1/vs2BvE2CPxeYnLeSu6jasrYhLsMR2/n+V1l2nwqN2zu8Kgp BGS54uIxkFxFIkFACEsDapJH4bRgvzU84 X-Gm-Gg: ASbGnctJb2bZumUQQ3y8u51EVQHEgv0zzp92Va9FYZaYldu6AatJmUmWA4taq74AK84 +pFT2mdAIP0gPdsZHFjntTuT7cKUasg0HnBe9pJ1C5cD/hOkSPaBqJ+na0JFW22XfZC6Y4LHCk6 fRPaGBPP4dpFPDuFfEu/+5WdXJiOnlp7kUZl9ehx3LU8gobAV9FNkPocGhZ5JcJE2iCpnWgA== X-Google-Smtp-Source: AGHT+IHS8UHhnZQL2tRfMm4uVqZ4ZgT7NOl5MqAyYreDB7wd9+XNd7HrCCtlKjK1oTRxuGwVF2lKlkXDSXlV7P3ZNU8= X-Received: by 2002:a05:6102:3c84:b0:4b9:bd00:454b with SMTP id ada2fe7eead31-4c8553d8d2fmr10685849137.13.1744054527671; Mon, 07 Apr 2025 12:35:27 -0700 (PDT) List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: jaeyong yoo Date: Mon, 7 Apr 2025 15:35:16 -0400 X-Gm-Features: ATxdqUEiC4NhPF1jEH7kUFsIEcJiYOrJfY03XDMhXGfYULj0PEz4vpAx2UxreX4 Message-ID: Subject: Re: HyStart availability in FreeBSD stack To: Cheng Cui Cc: freebsd-net@freebsd.org, freebsd-transport@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.87 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; NEURAL_HAM_LONG(-0.97)[-0.974]; NEURAL_HAM_SHORT(-0.90)[-0.904]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; FREEMAIL_FROM(0.00)[gmail.com]; TAGGED_FROM(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::933:from]; MID_RHS_MATCH_FROMTLD(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MLMMJ_DEST(0.00)[freebsd-net@freebsd.org,freebsd-transport@freebsd.org]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MISSING_XM_UA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com] X-Rspamd-Queue-Id: 4ZWfZ86C0Pz3sYR X-Spamd-Bar: --- I was taking a look into the code for rttsample and can we add calling that rttsample callback at tcp_xmit_timer: - https://github.com/freebsd/freebsd-src/blob/main/sys/netinet/tcp_input.c#= L3682 Looks like that place is to calculate t_srtt for TCP stack for feeding a new RTT from the recent ACK, which seems right for rttsample for HyStart. Thanks, Jaeyong 2025=EB=85=84 3=EC=9B=94 24=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 4:17, j= aeyong yoo =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > Thanks Cheng, > > Yes it looks like it implements newround callback for HyStart. > But shouldn't it also need for "rttsample" callback? > > Thanks, > Jaeyong > > 2025=EB=85=84 3=EC=9B=94 24=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 3:34,= Cheng Cui =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > > > > > > > On Mar 20, 2025, at 16:14, jaeyong yoo wrote: > > > > Hi net/transport, > > > > We are looking for using HyStart but looks like it is only implemented > > in RACK stack but not in FreeBSD TCP Stack. > > Is there a plan to support this in the near future? > > > > Thanks, > > Jaeyong > > > > > > Hi Jaeyong, > > > > Sorry for the delayed response. There is a patch to enable Hystart++ fo= r the default TCP stack. If you can help test it, I think it would be very = helpful to speed up its acceptance. > > > > https://reviews.freebsd.org/D46425 > > > > > > Best Regards, > > Cheng Cui > > > > > >