From nobody Tue Apr 15 12:26:50 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZcNgv0M8fz5t4DT for ; Tue, 15 Apr 2025 12:26:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZcNgt6sSjz3Nfg for ; Tue, 15 Apr 2025 12:26:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744720011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V2Itqk5iaGG+COJg9MKAgnJzCRzeplKr+yfkNrBPxoE=; b=CCsqSjcfSJPu4yYB8EoJR63RF/cTXUD0DaYJ2fHGkxEGZsZrOmoVR81yRWrG9AK5/DHGWY nGg11219nZJoT+ksrWb2RQ+ZvbRpwCTKiAyuAR2pgirIq7kLjOmRYoFuWPZAFHjcM4PeI+ VMo02i9QfzMtO3RF4cNuxhTrnlRoEyTVr/DXKMopuLhcJjQ7vQTnNYb7wZ4wkT/t4It+OH cxCizncKpADKsrC+PRmCdqDncDxJBkhKI4O8sa3Gbk/7cChHZOsNHOkYTIA3uJA9HznAO3 rx3DRvDwLR7BwL1LQEuP5XFnVDHEDr/mWaWWStso+UWFo5MEdEqeg82dOSTWEg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744720011; a=rsa-sha256; cv=none; b=OprkPfoDvfmtTAfTfXWJQ5qC9dTqfYQzE9jRVCuzvM2crE2p9cRuQgrGVNfKNtUK7xJAUh +eI/RmorUpH7hLIZGUbsxijrHkSNVwwNRh+X8Asut7fjiUVf+E3yb/bqGbh9OWBV7Enfy+ jNnoCM5aGqwmd2j7BEjj1/wWiT5hXiXXtNQhvNhrjFeoGcoSz/Duwmrc7RTjzgTDFNBkBk kPk10I/AwMfLy40wUthV2WOV0m3Icfbziu4tqOwYY3s5U3KY4Op2BJurgnQq7R2f5EqNQ7 V1/XKFMnaLL25LL4PuBfy+WnzpJtLRSro05QlD/Vu04EfpBJfw4I+Fup5NwgGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744720011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V2Itqk5iaGG+COJg9MKAgnJzCRzeplKr+yfkNrBPxoE=; b=a3zxmcN3e2EpyQbqP0NtQXjaT07eyC3D7SSPCL52szSjrO5QEMGgouSA+yl7vaE1+VHE4Z nFhgBwgLD9fiqqFD9D2pO7w6H2C0642zbqueVDPfMi0tYmjxbNyw1JxrhBuPKcriICBZNS HjRiijOh72nmkC+eesj1GHIlh5q41IVpPRMGUPXFYWnBZFZh52LEful/RhsphVq0yUwh62 eXu1Nl8h1Sz5wnuohAOUo0dqhAl25Ebv3DYeiVDu2DS7OH0eRB5ITGuvWH3C54/Jd0JaDy lxanISD6Qo7yOefBgNYKNnAIm3HLzNNQ6ech17ieUh/UcPG9MN1X1Azc+1Lg3g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZcNgt6G53zZXt for ; Tue, 15 Apr 2025 12:26:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 53FCQo3m096198 for ; Tue, 15 Apr 2025 12:26:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 53FCQocm096197 for net@FreeBSD.org; Tue, 15 Apr 2025 12:26:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 283426] panic in sbappendaddr_locked() - if_ovpn related? Date: Tue, 15 Apr 2025 12:26:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.2-RELEASE X-Bugzilla-Keywords: crash, regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283426 --- Comment #18 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D1463d5ff13164362f0825c4613dcb4eb4= 2a7396c commit 1463d5ff13164362f0825c4613dcb4eb42a7396c Author: Kristof Provost AuthorDate: 2025-04-01 13:19:26 +0000 Commit: Kristof Provost CommitDate: 2025-04-15 07:27:09 +0000 if_ovpn: fix use-after-free of mbuf m_unshare() can return a new mbuf pointer. We update the 'm' pointer in ovpn_udp_input(), but if we decide to pass on the packet (e.g. because = it's for an unknown peer) the caller (udp_append()) continues with the old 'm' pointer, eventually resulting in a use-after-free. Re-order operations in ovpn_udp_input() so that we don't modify the 'm' pointer until we're committed to keeping the packet. PR: 283426 Test case by: takahiro.kurosawa@gmail.com MFC after: 2 weeks Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 04a7134c1e92c7752ffdc665f99ae26db70866c0) sys/net/if_ovpn.c | 12 +++--- tests/sys/net/if_ovpn/if_ovpn.sh | 81 ++++++++++++++++++++++++++++++++++++= ++++ 2 files changed, 87 insertions(+), 6 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=