From nobody Mon Jun 22 00:41:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gk8Wr3Skcz6hfqG for ; Mon, 22 Jun 2026 00:41:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gk8Wq62Jzz3MLx for ; Mon, 22 Jun 2026 00:41:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782088871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+V/L4li2wLick67GAR6dAfTrjeep2cxCUCuqYsInBcQ=; b=pJzUwYipq1GX5qBgztOgqZUV/eRXyZHqNKPOoddlu3fabyiFBBCdF9ft9+aS/trpE5yHaM CcG1DiyywFemf0jwXxFlZDpO7Ft72EmIyzt5747zRsd2lUQ+Bya5F0Wt0Wqmf0+GNoWd57 C9vqT3O6FA9KEsDy/bCzJbZXGTIBu78gcZlwLKI0FarKpfU7x4M4pBdNieYiUzM9MnpFvw 2bjDMPLRJBaHic/w4rZlVv7DuwT1/bH1eZzssKu9YaZ8WB/vR0dtgg8/UEv3V+3JtM2caK dNDdc6CaUhxKCazsEnMMLCvlrM1H9CGKr8Wszzefn4CdDHD4zX3SXh8GM9wCGA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782088871; a=rsa-sha256; cv=none; b=ZIDgdKjoVDuI4duO38G5D/tn3/jT/cD83skcVeq/BY7nDDQSV8XOUVpY5maPs7597fo40e /vUyT60QhBLOZT7xt4DrS5R46juARBsphI/vNgebvMB0jFlmgMxrD/y09GDAVI5s2hDfkH a1da/S7x79iZPq8sq0HaCii/i/IJH0V/KBGnTMqJf2iFmmAU9pfgLydG6ZNQ5hGXO2zPQ3 3hV78rDVKCmU1qIS0m9GXzQK+uuYdfKtqnKb333rT8sAWuvlBeBRV/cb9MLrYP9maww/9A DMQ0XZXJJ6atqSbbd9vrQz/nSXQqqb7gmdxRFGFSosCjyWP6FXugwG1+DRLcxQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782088871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+V/L4li2wLick67GAR6dAfTrjeep2cxCUCuqYsInBcQ=; b=xPCuc0hG0hkhCzW9SUv7kVRdnJF0XW/MT/Gkvpxsz2YNbQILIHEi8AeqsHGpTqWFsf1w6n xzkHSM6NR/FP6shElmQ3pEG41pJ6k2G93qbC2bUSEd+BKi6LDkVU3OThqu+4S76oSGk5bI P1D+04HRP1QUW4dENone6QRzuph6wWvkQgsVY/PQgny7lxGvyyvnrJdWTLoXW9vOE9wkul BuPFAf01yJoq9OjZdzuQr4B5S6tUPDPrunJDl8UnqLzugUC+QsDsGvUh31efJ3H/ilRglu QOTqnNZQaWaG7iofmiwlRsOhZHkFgP/TtgDXndBF7Ib7k8u1HYgv8JUAp4FbCg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gk8Wq4PBvz8J7 for ; Mon, 22 Jun 2026 00:41:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39d81 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 22 Jun 2026 00:41:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Abdelkader Boudih From: Adrian Chadd Subject: git: 3ffd2baa268d - main - if_fwsubr: remove ARP target hardware address trimming List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3ffd2baa268d298201d54c733dc0e635cc1dca9f Auto-Submitted: auto-generated Date: Mon, 22 Jun 2026 00:41:11 +0000 Message-Id: <6a3884a7.39d81.30d68996@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=3ffd2baa268d298201d54c733dc0e635cc1dca9f commit 3ffd2baa268d298201d54c733dc0e635cc1dca9f Author: Abdelkader Boudih AuthorDate: 2026-06-22 00:31:29 +0000 Commit: Adrian Chadd CommitDate: 2026-06-22 00:31:34 +0000 if_fwsubr: remove ARP target hardware address trimming Per RFC 2734 section 5, the 1394 ARP packet is a fixed 32-octet structure with no target hardware address field. Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D57617 --- sys/net/if_fwsubr.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sys/net/if_fwsubr.c b/sys/net/if_fwsubr.c index ceac93d31d56..07a065653649 100644 --- a/sys/net/if_fwsubr.c +++ b/sys/net/if_fwsubr.c @@ -180,13 +180,6 @@ firewire_output(struct ifnet *ifp, struct mbuf *m, const struct sockaddr *dst, ah->ar_hrd = htons(ARPHRD_IEEE1394); if (unicast) *destfw = *(struct fw_hwaddr *) ar_tha(ah); - - /* - * The standard arp code leaves a hole for the target - * hardware address which we need to close up. - */ - bcopy(ar_tpa(ah), ar_tha(ah), ah->ar_pln); - m_adj(m, -ah->ar_hln); break; } #endif