From nobody Mon Jun 15 01:47:09 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gdtK9555lz6gBC0 for ; Mon, 15 Jun 2026 01:47:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gdtK92vM5z49Vc for ; Mon, 15 Jun 2026 01:47:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781488029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=b2da4ssSC/XrD7wXbhMS3zqa0dxM10o5nHf37gG7Y00=; b=aEJosyOPsQ9nUU9GKYtcgaC0s0zx9/+cYPHl9CeE0eCXy6RB2hHD00hitE136+6XKqVSlx lhsG7z7B4USPz/zXalXo5moBjniZUYL0JlN0W4dKfR8oxisRW1tAhq/NXWUnQaSURDt7G0 3WGJYjetH4aWHQr0tIT+wyxvn++SBLvUFv3Hllre0yQqa63XbRqX1Psh4rKPL3OCxP3OzC cN7f8S/Z6/Obcd96a1M2KzOM30WPL470E0eg/qaez38c8wfzIl9Lk7MM77uC7H7aUygsUr Ib55pILoo3tJxiKjN9asrZQNXrhGcBMZQUc61vr8FeUhsWPTC917PPrgPnbJgw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781488029; a=rsa-sha256; cv=none; b=n1PXHCmZJSe2AO5iGm92Q7e4IngUfL+3wxVrAEkd9zMnF9bSpWVC8IAfW732a3PxcFmJbD +wvOthPXiyTClu8XJnvyTpCzViDhimOGh0CjbrARE+NFC0m3z+Ppw3G/PfWq1ihJk0J4Bc nuWxtQ7MQPLONXERlDNCLucGzBIk8BEMeYqiS5p841AGtg4r1qJJXsqeWIC/0itynmYo5O AVl5bnrdik5/4040uWIpQR/eVLb6KadUk21YJDNs01VJsSvSj7IbRMt9GMpjbgDo4ImTFm /gu4DfpFZCwL8Rkxsszwgwt3WKmYTks5XInOxbpjAcrwulkGISR882OgqvK3ww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781488029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=b2da4ssSC/XrD7wXbhMS3zqa0dxM10o5nHf37gG7Y00=; b=h/gsrMUeSpHRo7olbbRo670HdOGTBAeCr9b1ndQnUs2UV+dBA+idUySzEb893IKgVpzVVO 4s2GFrsvqRDo2DbB17Dg8YnbGB4Tn/uFtfNfEkKizHdiP15JGlft8KQHJzuCQUiBzU8BqA TyoNoEae8oWz0tqRx9tjbguQ3fsghy7M14PCDiPgA8l2H4gdy7cQRrbADFfhb1kAh8fVh/ y2tqSAf37foMrg4o0cWvgBbnC5Tmt9LzYNslgNg5FIoadZkBkACp3a9l1L6nBxrXpWetyj g2etTsZWfTkxCjYp05FSqYeouGL9lbF2sTXae8hK95v/DN2C1DZsYQjKMZxPzw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gdtK92VdJzbVZ for ; Mon, 15 Jun 2026 01:47:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 264d7 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 15 Jun 2026 01:47:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Lo Subject: git: fa75c1cc2426 - main - mwl: return ENOMEM when rx buffer allocation fails List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevlo X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fa75c1cc242665d123ef5bf2f4ced2e076b35450 Auto-Submitted: auto-generated Date: Mon, 15 Jun 2026 01:47:09 +0000 Message-Id: <6a2f599d.264d7.1185c1d0@gitrepo.freebsd.org> The branch main has been updated by kevlo: URL: https://cgit.FreeBSD.org/src/commit/?id=fa75c1cc242665d123ef5bf2f4ced2e076b35450 commit fa75c1cc242665d123ef5bf2f4ced2e076b35450 Author: Kevin Lo AuthorDate: 2026-06-15 01:43:57 +0000 Commit: Kevin Lo CommitDate: 2026-06-15 01:43:57 +0000 mwl: return ENOMEM when rx buffer allocation fails The malloc() failure path returned error, which is 0 at this point, so callers would treat the allocation failure as success. Return ENOMEM instead to correctly propagate the out-of-memory condition. Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D42282 --- sys/dev/mwl/if_mwl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/mwl/if_mwl.c b/sys/dev/mwl/if_mwl.c index 87e2679778db..3dc44ba20ee4 100644 --- a/sys/dev/mwl/if_mwl.c +++ b/sys/dev/mwl/if_mwl.c @@ -2165,7 +2165,7 @@ mwl_rxdma_setup(struct mwl_softc *sc) bf = malloc(bsize, M_MWLDEV, M_NOWAIT | M_ZERO); if (bf == NULL) { device_printf(sc->sc_dev, "malloc of %u rx buffers failed\n", bsize); - return error; + return ENOMEM; } sc->sc_rxdma.dd_bufptr = bf;