From owner-cvs-gnu Mon May 22 06:32:32 1995 Return-Path: cvs-gnu-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA24158 for cvs-gnu-outgoing; Mon, 22 May 1995 06:32:32 -0700 Received: (from adam@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA24146 ; Mon, 22 May 1995 06:32:30 -0700 Date: Mon, 22 May 1995 06:32:30 -0700 From: Adam David Message-Id: <199505221332.GAA24146@freefall.cdrom.com> To: CVS-commiters, cvs-gnu Subject: cvs commit: src/gnu/lib/libreadline display.c Sender: cvs-gnu-owner@freebsd.org Precedence: bulk adam 95/05/22 06:32:30 Modified: gnu/lib/libreadline display.c Log: eliminate coredump for readline(NULL) case From owner-cvs-gnu Mon May 22 10:47:20 1995 Return-Path: cvs-gnu-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id KAA29887 for cvs-gnu-outgoing; Mon, 22 May 1995 10:47:20 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id KAA29881 ; Mon, 22 May 1995 10:47:15 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id KAA05201; Mon, 22 May 1995 10:47:01 -0700 From: "Rodney W. Grimes" Message-Id: <199505221747.KAA05201@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/gnu/lib/libreadline display.c To: adam@freefall.cdrom.com (Adam David) Date: Mon, 22 May 1995 10:47:01 -0700 (PDT) Cc: CVS-commiters@freefall.cdrom.com, cvs-gnu@freefall.cdrom.com In-Reply-To: <199505221332.GAA24146@freefall.cdrom.com> from "Adam David" at May 22, 95 06:32:30 am X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 432 Sender: cvs-gnu-owner@freebsd.org Precedence: bulk > > adam 95/05/22 06:32:30 > > Modified: gnu/lib/libreadline display.c > Log: > eliminate coredump for readline(NULL) case Did I miss a message about code freeze being lifted??? A library is defanitly a critical place to be patching. Reviewd by: ?????? -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-gnu Mon May 22 16:30:26 1995 Return-Path: cvs-gnu-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id QAA01001 for cvs-gnu-outgoing; Mon, 22 May 1995 16:30:26 -0700 Received: from veda.is (root@veda.is [193.4.230.1]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id NAA05197 ; Mon, 22 May 1995 13:38:22 -0700 Received: (from adam@localhost) by veda.is (8.6.11/8.6.9) id UAA10762; Mon, 22 May 1995 20:37:34 GMT From: Adam David Message-Id: <199505222037.UAA10762@veda.is> Subject: Re: cvs commit: src/gnu/lib/libreadline display.c To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes) Date: Mon, 22 May 1995 20:37:32 +0000 () Cc: adam@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-gnu@freefall.cdrom.com In-Reply-To: <199505221933.MAA05512@gndrsh.aac.dev.com> from "Rodney W. Grimes" at May 22, 95 12:33:08 pm X-Mailer: ELM [version 2.4 PL23] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Content-Length: 1267 Sender: cvs-gnu-owner@freebsd.org Precedence: bulk Sorry I caused aggravation, it was not intentional. It would be a good idea at such times of restriction to let the motd refer to a file containing a detailed description of the restrictions (for instance a copy of Rod's message to commiters). For this change to libreadline, a context diff shows nothing useful in addition to the output of 'cvs diff -D yesterday', but here it is anyway: *** display.c.old Mon May 22 20:01:27 1995 --- display.c Mon May 22 12:00:28 1995 *************** *** 746,752 **** escape sequences (like drawing the `unbold' sequence without a corresponding `bold') that manifests itself on certain terminals. */ ! lendiff = strlen (local_prompt); if (current_line == 0 && !_rl_horizontal_scroll_mode && lendiff > visible_length && _rl_last_c_pos > 0 && (ofd - old) >= lendiff && term_cr) --- 746,752 ---- escape sequences (like drawing the `unbold' sequence without a corresponding `bold') that manifests itself on certain terminals. */ ! lendiff = local_prompt ? strlen (local_prompt) : 0; if (current_line == 0 && !_rl_horizontal_scroll_mode && lendiff > visible_length && _rl_last_c_pos > 0 && (ofd - old) >= lendiff && term_cr) -- Adam David From owner-cvs-gnu Mon May 22 16:30:19 1995 Return-Path: cvs-gnu-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id QAA00986 for cvs-gnu-outgoing; Mon, 22 May 1995 16:30:19 -0700 Received: from veda.is (root@veda.is [193.4.230.1]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id MAA02962 ; Mon, 22 May 1995 12:24:58 -0700 Received: (from adam@localhost) by veda.is (8.6.11/8.6.9) id TAA09678; Mon, 22 May 1995 19:24:31 GMT From: Adam David Message-Id: <199505221924.TAA09678@veda.is> Subject: Re: cvs commit: src/gnu/lib/libreadline display.c To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes) Date: Mon, 22 May 1995 19:24:30 +0000 () Cc: adam@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-gnu@freefall.cdrom.com In-Reply-To: <199505221747.KAA05201@gndrsh.aac.dev.com> from "Rodney W. Grimes" at May 22, 95 10:47:01 am X-Mailer: ELM [version 2.4 PL23] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Content-Length: 695 Sender: cvs-gnu-owner@freebsd.org Precedence: bulk > > Modified: gnu/lib/libreadline display.c > > Log: > > eliminate coredump for readline(NULL) case > > Did I miss a message about code freeze being lifted??? Bugfix only, as explicitly permitted by freefall's motd. > A library is defanitly a critical place to be patching. There is no change of interface, only an advertised functionality that dumped core instead of the expected behaviour. > Reviewd by: ?????? Is this necessary for a trivial bugfix? old: strlen(local_prompt) new: local_prompt ? strlen(local_prompt) : 0 local_prompt == NULL is a valid state, as empty prompts may be represented as either "" or NULL in the rest of the code. -- Adam David From owner-cvs-gnu Mon May 22 16:31:04 1995 Return-Path: cvs-gnu-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id QAA01063 for cvs-gnu-outgoing; Mon, 22 May 1995 16:31:04 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id MAA03155 ; Mon, 22 May 1995 12:34:26 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id MAA05512; Mon, 22 May 1995 12:33:08 -0700 From: "Rodney W. Grimes" Message-Id: <199505221933.MAA05512@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/gnu/lib/libreadline display.c To: adam@veda.is (Adam David) Date: Mon, 22 May 1995 12:33:08 -0700 (PDT) Cc: adam@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-gnu@freefall.cdrom.com In-Reply-To: <199505221924.TAA09678@veda.is> from "Adam David" at May 22, 95 07:24:30 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1488 Sender: cvs-gnu-owner@freebsd.org Precedence: bulk > > > > Modified: gnu/lib/libreadline display.c > > > Log: > > > eliminate coredump for readline(NULL) case > > > > Did I miss a message about code freeze being lifted??? > > Bugfix only, as explicitly permitted by freefall's motd. There was a full page message sent to -committers describing in detail on how thing are to be done. Changes in any form to libraries is a reviewable change. > > A library is defanitly a critical place to be patching. > > There is no change of interface, only an advertised functionality > that dumped core instead of the expected behaviour. Change is change, any and every change *can* cause a new bug, the posted process did not say anything about interface changes or not, it said critical system components, and a library is defanitly a critical system component. > > Reviewd by: ?????? > > Is this necessary for a trivial bugfix? YES! No mater how trivial it may look, it can cause a problem if not carefully looked at. I have seen some of the most trivial bug fixes break tons of things due to an oversight. > old: strlen(local_prompt) > new: local_prompt ? strlen(local_prompt) : 0 > > local_prompt == NULL is a valid state, as empty prompts may be represented > as either "" or NULL in the rest of the code. The above is pretty useless, how about a context diff??? -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-gnu Sat May 27 20:36:22 1995 Return-Path: cvs-gnu-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id UAA21521 for cvs-gnu-outgoing; Sat, 27 May 1995 20:36:22 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id UAA21490 ; Sat, 27 May 1995 20:36:07 -0700 Date: Sat, 27 May 1995 20:36:07 -0700 From: "Jordan K. Hubbard" Message-Id: <199505280336.UAA21490@freefall.cdrom.com> To: CVS-commiters, cvs-gnu Subject: cvs commit: src/gnu/lib/libdialog ui_objects.c Sender: cvs-gnu-owner@freebsd.org Precedence: bulk jkh 95/05/27 20:36:06 Modified: gnu/lib/libdialog ui_objects.c Log: Don't make TAB and BACK-TAB destroy field contents incorrectly. Submitted by: gibbs