From owner-cvs-libexec Wed Nov 29 11:52:44 1995 Return-Path: owner-cvs-libexec Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id LAA14893 for cvs-libexec-outgoing; Wed, 29 Nov 1995 11:52:44 -0800 Received: (from guido@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id LAA14880 ; Wed, 29 Nov 1995 11:52:35 -0800 Date: Wed, 29 Nov 1995 11:52:35 -0800 From: Guido van Rooij Message-Id: <199511291952.LAA14880@freefall.freebsd.org> To: CVS-committers, cvs-libexec Subject: cvs commit: src/libexec/ftpd ftpd.c Sender: owner-cvs-libexec@FreeBSD.ORG Precedence: bulk guido 95/11/29 11:52:34 Modified: libexec/ftpd ftpd.c Log: Timeout when an expected accept does not happen after all. This gets rids of dozens of hanging ftpd's because some broken pc implementation `forgets' to open a passive connection. Obtained from: Wietse Venema Revision Changes Path 1.13 +11 -3 src/libexec/ftpd/ftpd.c From owner-cvs-libexec Fri Dec 1 12:38:59 1995 Return-Path: owner-cvs-libexec Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA23420 for cvs-libexec-outgoing; Fri, 1 Dec 1995 12:38:59 -0800 Received: (from guido@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA23408 ; Fri, 1 Dec 1995 12:38:45 -0800 Date: Fri, 1 Dec 1995 12:38:45 -0800 From: Guido van Rooij Message-Id: <199512012038.MAA23408@freefall.freebsd.org> To: CVS-committers, cvs-libexec Subject: cvs commit: src/libexec/rlogind rlogind.c Sender: owner-cvs-libexec@FreeBSD.ORG Precedence: bulk guido 95/12/01 12:38:44 Modified: libexec/rlogind rlogind.c Log: It is not necessary to check if a '-' is in lusername., Checking if lusername starts with a '-' is enough. Otherwise, no users with a '-' in there name can use rlogin. Revision Changes Path 1.7 +1 -1 src/libexec/rlogind/rlogind.c From owner-cvs-libexec Fri Dec 1 13:36:34 1995 Return-Path: owner-cvs-libexec Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id NAA26257 for cvs-libexec-outgoing; Fri, 1 Dec 1995 13:36:34 -0800 Received: from GndRsh.aac.dev.com (GndRsh.aac.dev.com [198.145.92.241]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id NAA26204 ; Fri, 1 Dec 1995 13:36:09 -0800 Received: (from rgrimes@localhost) by GndRsh.aac.dev.com (8.6.12/8.6.12) id NAA29851; Fri, 1 Dec 1995 13:35:56 -0800 From: "Rodney W. Grimes" Message-Id: <199512012135.NAA29851@GndRsh.aac.dev.com> Subject: Re: cvs commit: src/libexec/rlogind rlogind.c To: guido@freefall.freebsd.org (Guido van Rooij) Date: Fri, 1 Dec 1995 13:35:56 -0800 (PST) Cc: CVS-committers@freefall.freebsd.org, cvs-libexec@freefall.freebsd.org In-Reply-To: <199512012038.MAA23408@freefall.freebsd.org> from "Guido van Rooij" at Dec 1, 95 12:38:45 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 647 Sender: owner-cvs-libexec@FreeBSD.ORG Precedence: bulk > > guido 95/12/01 12:38:44 > > Modified: libexec/rlogind rlogind.c > Log: > It is not necessary to check if a '-' is in lusername., Checking if > lusername starts with a '-' is enough. Otherwise, no users with a '-' > in there name can use rlogin. > > Revision Changes Path > 1.7 +1 -1 src/libexec/rlogind/rlogind.c What happens if I start the username with a space or put a space in it some place? (ie, ` -option' or `foouser -foooptions') ?? -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD From owner-cvs-libexec Fri Dec 1 21:48:02 1995 Return-Path: owner-cvs-libexec Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id VAA22518 for cvs-libexec-outgoing; Fri, 1 Dec 1995 21:48:02 -0800 Received: from jhome.DIALix.COM (root@jhome.DIALix.COM [192.203.228.69]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id VAA22426 ; Fri, 1 Dec 1995 21:44:54 -0800 Received: (from peter@localhost) by jhome.DIALix.COM (8.7.2/8.7.2) id NAA01377; Sat, 2 Dec 1995 13:43:35 +0800 (WST) Date: Sat, 2 Dec 1995 13:43:34 +0800 (WST) From: Peter Wemm To: "Rodney W. Grimes" cc: Guido van Rooij , CVS-committers@freefall.freebsd.org, cvs-libexec@freefall.freebsd.org Subject: Re: cvs commit: src/libexec/rlogind rlogind.c In-Reply-To: <199512012135.NAA29851@GndRsh.aac.dev.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-libexec@FreeBSD.ORG Precedence: bulk On Fri, 1 Dec 1995, Rodney W. Grimes wrote: > > guido 95/12/01 12:38:44 > > > > Modified: libexec/rlogind rlogind.c > > Log: > > It is not necessary to check if a '-' is in lusername., Checking if > > lusername starts with a '-' is enough. Otherwise, no users with a '-' > > in there name can use rlogin. > > > > Revision Changes Path > > 1.7 +1 -1 src/libexec/rlogind/rlogind.c > > What happens if I start the username with a space or put a space > in it some place? (ie, ` -option' or `foouser -foooptions') ?? It's fine.. the option "lusername" is passed as a single argv entry. If there's a space in it, it'll simply be treated as a space with a login name. Actually, to be certain of these things, we could get rlogind and telnetd etc to pass in a "--" string to close off the options list.. eg: execl(.... "-h", hostname, "--", lusername); The infamous "-froot" bug was specific to the "shadow" suite (and apparently AIX) where there was a coding error. JFH listed the "f" flag in the getopt string as taking an argument for some bizare reason. So far as I can tell, the BSD login was never susceptable to this bug because of it's correct parsing of arguments with getopt(). -Peter > -- > Rod Grimes rgrimes@gndrsh.aac.dev.com > Accurate Automation Company Reliable computers for FreeBSD > From owner-cvs-libexec Sat Dec 2 03:01:26 1995 Return-Path: owner-cvs-libexec Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA03239 for cvs-libexec-outgoing; Sat, 2 Dec 1995 03:01:26 -0800 Received: from gvr.win.tue.nl (root@gvr.win.tue.nl [131.155.210.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id DAA03196 ; Sat, 2 Dec 1995 03:01:05 -0800 Received: by gvr.win.tue.nl (8.6.10/1.53) id MAA01925; Sat, 2 Dec 1995 12:00:23 +0100 From: guido@gvr.win.tue.nl (Guido van Rooij) Message-Id: <199512021100.MAA01925@gvr.win.tue.nl> Subject: Re: cvs commit: src/libexec/rlogind rlogind.c To: peter@jhome.dialix.com (Peter Wemm) Date: Sat, 2 Dec 1995 12:00:23 +0100 (MET) Cc: rgrimes@gndrsh.aac.dev.com, guido@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-libexec@freefall.freebsd.org In-Reply-To: from "Peter Wemm" at Dec 2, 95 01:43:34 pm X-Mailer: ELM [version 2.4 PL24] Content-Type: text Content-Length: 258 Sender: owner-cvs-libexec@FreeBSD.ORG Precedence: bulk > > So far as I can tell, the BSD login was never susceptable to this bug > because of it's correct parsing of arguments with getopt(). > I remember experimenting with it and being able to do unwanted things though...but that is a long time ago. -Guido From owner-cvs-libexec Sat Dec 2 10:23:09 1995 Return-Path: owner-cvs-libexec Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id KAA22705 for cvs-libexec-outgoing; Sat, 2 Dec 1995 10:23:09 -0800 Received: (from nate@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id KAA22692 ; Sat, 2 Dec 1995 10:23:03 -0800 Date: Sat, 2 Dec 1995 10:23:03 -0800 From: Nate Williams Message-Id: <199512021823.KAA22692@freefall.freebsd.org> To: CVS-committers, cvs-libexec Subject: cvs commit: src/libexec/rlogind rlogind.c Sender: owner-cvs-libexec@FreeBSD.ORG Precedence: bulk nate 95/12/02 10:23:02 Modified: libexec/rlogind rlogind.c Log: Fix typo. Revision Changes Path 1.8 +1 -1 src/libexec/rlogind/rlogind.c