From owner-cvs-sbin Sun May 12 04:10:38 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id EAA14971 for cvs-sbin-outgoing; Sun, 12 May 1996 04:10:38 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id EAA14953 Sun, 12 May 1996 04:10:28 -0700 (PDT) Date: Sun, 12 May 1996 04:10:28 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199605121110.EAA14953@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/newlfs newlfs.8 Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/05/12 04:10:28 Modified: sbin/newlfs newlfs.8 Log: Document LFS as broken. Revision Changes Path 1.2 +3 -0 src/sbin/newlfs/newlfs.8 From owner-cvs-sbin Sun May 12 04:12:25 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id EAA15142 for cvs-sbin-outgoing; Sun, 12 May 1996 04:12:25 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id EAA15123 Sun, 12 May 1996 04:12:18 -0700 (PDT) Date: Sun, 12 May 1996 04:12:18 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199605121112.EAA15123@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/mount_lfs mount_lfs.8 Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/05/12 04:12:18 Modified: sbin/mount_lfs mount_lfs.8 Log: Document LFS as broken. Revision Changes Path 1.2 +3 -0 src/sbin/mount_lfs/mount_lfs.8 From owner-cvs-sbin Mon May 13 10:28:47 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id KAA06563 for cvs-sbin-outgoing; Mon, 13 May 1996 10:28:47 -0700 (PDT) Received: (from wollman@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id KAA06534 Mon, 13 May 1996 10:28:36 -0700 (PDT) Date: Mon, 13 May 1996 10:28:36 -0700 (PDT) From: Garrett Wollman Message-Id: <199605131728.KAA06534@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/mount_std - New directory Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk wollman 96/05/13 10:28:35 src/sbin/mount_std - New directory From owner-cvs-sbin Mon May 13 10:43:31 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id KAA07722 for cvs-sbin-outgoing; Mon, 13 May 1996 10:43:31 -0700 (PDT) Received: (from wollman@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id KAA07703 Mon, 13 May 1996 10:43:21 -0700 (PDT) Date: Mon, 13 May 1996 10:43:21 -0700 (PDT) From: Garrett Wollman Message-Id: <199605131743.KAA07703@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/mount_fdesc Makefile mount_fdesc.8 mount_fdesc.c src/sbin/mount_kernfs Makefile mount_kernfs.8 mount_kernfs.c src/sbin/mount_procfs Makefile mount_procfs.8 mount_procfs.c src/sbin Makefile src/sbin/mount_cd9660 mount_cd9660.c src/sbin/mount_devfs Makefile mount_devfs.8 mount_devfs.c src/sbin/mount_ext2fs mount_ext2fs.c src/sbin/mount_lfs mount_lfs.c src/sbin/mount_nfs mount_nfs.c src/sbin/mount_null mount_null.c src/sbin/mount_portal mount_portal.c src/sbin/mount_std Makefile mount_devfs.8 mount_fdesc.8 mount_kernfs.8 mount_procfs.8 mount_std.8 mount_std.c src/sbin/mount_umap mount_umap.c src/sbin/mount_union mount_union.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk wollman 96/05/13 10:43:20 Modified: sbin Makefile sbin/mount_cd9660 mount_cd9660.c sbin/mount_ext2fs mount_ext2fs.c sbin/mount_lfs mount_lfs.c sbin/mount_nfs mount_nfs.c sbin/mount_null mount_null.c sbin/mount_portal mount_portal.c sbin/mount_umap mount_umap.c sbin/mount_union mount_union.c Added: sbin/mount_std Makefile mount_devfs.8 mount_fdesc.8 mount_kernfs.8 mount_procfs.8 mount_std.8 mount_std.c Removed: sbin/mount_devfs Makefile mount_devfs.8 mount_devfs.c sbin/mount_fdesc Makefile mount_fdesc.8 mount_fdesc.c sbin/mount_kernfs Makefile mount_kernfs.8 mount_kernfs.c sbin/mount_procfs Makefile mount_procfs.8 mount_procfs.c Log: Get rid of the last vestiges of the old MOUNT_* constants in the mount_* programs. While we're at it, collapse the four now-identical mount programs for devfs, fdesc, kernfs, and procfs into links to a new mount_std(8) which can mount any really generic filesystem such as these when called with the appropriate argv[0]. Also, convert the mount programs to use sysexits.h. Revision Changes Path 1.31 +2 -2 src/sbin/Makefile 1.7 +11 -4 src/sbin/mount_cd9660/mount_cd9660.c 1.2 +23 -19 src/sbin/mount_ext2fs/mount_ext2fs.c 1.4 +23 -14 src/sbin/mount_lfs/mount_lfs.c 1.13 +9 -2 src/sbin/mount_nfs/mount_nfs.c 1.4 +15 -8 src/sbin/mount_null/mount_null.c 1.6 +14 -9 src/sbin/mount_portal/mount_portal.c 1.6 +26 -21 src/sbin/mount_umap/mount_umap.c 1.4 +11 -8 src/sbin/mount_union/mount_union.c From owner-cvs-sbin Mon May 13 10:56:43 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id KAA08760 for cvs-sbin-outgoing; Mon, 13 May 1996 10:56:43 -0700 (PDT) Received: (from wollman@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id KAA08742 Mon, 13 May 1996 10:56:36 -0700 (PDT) Date: Mon, 13 May 1996 10:56:36 -0700 (PDT) From: Garrett Wollman Message-Id: <199605131756.KAA08742@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/i386/mount_msdos mount_msdos.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk wollman 96/05/13 10:56:35 Modified: sbin/i386/mount_msdos mount_msdos.c Log: One program I missed in removing MOUNT_* constants. Revision Changes Path 1.4 +21 -17 src/sbin/i386/mount_msdos/mount_msdos.c From owner-cvs-sbin Tue May 14 08:17:11 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id IAA17025 for cvs-sbin-outgoing; Tue, 14 May 1996 08:17:11 -0700 (PDT) Received: (from wollman@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id IAA17000; Tue, 14 May 1996 08:16:53 -0700 (PDT) Date: Tue, 14 May 1996 08:16:53 -0700 (PDT) From: Garrett Wollman Message-Id: <199605141516.IAA17000@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/mount_std mount_std.8 mount_std.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk wollman 96/05/14 08:16:52 Modified: sbin/mount_std mount_std.8 mount_std.c Log: Accept mount(8)'s calling convention of passing just the filesystem type as argv[0]. Revision Changes Path 1.2 +8 -4 src/sbin/mount_std/mount_std.8 1.2 +15 -5 src/sbin/mount_std/mount_std.c From owner-cvs-sbin Fri May 17 01:49:09 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id BAA28645 for cvs-sbin-outgoing; Fri, 17 May 1996 01:49:09 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id BAA28627; Fri, 17 May 1996 01:48:54 -0700 (PDT) Date: Fri, 17 May 1996 01:48:54 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199605170848.BAA28627@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin Makefile Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/05/17 01:48:53 Modified: sbin Makefile Log: Large security hole in mount_union, the underlying filesystem for which doesn't even work. Until pst wakes up, best action deemed to be the simple disabling of this command. Revision Changes Path 1.32 +2 -1 src/sbin/Makefile From owner-cvs-sbin Fri May 17 02:32:26 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id CAA02024 for cvs-sbin-outgoing; Fri, 17 May 1996 02:32:26 -0700 (PDT) Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id CAA02016; Fri, 17 May 1996 02:32:21 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by Root.COM (8.7.5/8.6.5) with SMTP id CAA04114; Fri, 17 May 1996 02:32:25 -0700 (PDT) Message-Id: <199605170932.CAA04114@Root.COM> X-Authentication-Warning: implode.Root.COM: Host localhost [127.0.0.1] didn't use HELO protocol To: "Jordan K. Hubbard" cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin Makefile In-reply-to: Your message of "Fri, 17 May 1996 01:48:54 PDT." <199605170848.BAA28627@freefall.freebsd.org> From: David Greenman Reply-To: davidg@Root.COM Date: Fri, 17 May 1996 02:32:25 -0700 Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >jkh 96/05/17 01:48:53 > > Modified: sbin Makefile > Log: > Large security hole in mount_union, the underlying filesystem for which doesn't > even work. Until pst wakes up, best action deemed to be the simple disabling > of this command. It would have been better to install it without suid root so that the permissions get changed when people next do a "make world". -DG David Greenman Core-team/Principal Architect, The FreeBSD Project From owner-cvs-sbin Fri May 17 02:38:32 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id CAA02558 for cvs-sbin-outgoing; Fri, 17 May 1996 02:38:32 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id CAA02547; Fri, 17 May 1996 02:38:24 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by time.cdrom.com (8.7.5/8.6.9) with SMTP id CAA00275; Fri, 17 May 1996 02:38:19 -0700 (PDT) To: davidg@Root.COM cc: "Jordan K. Hubbard" , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin Makefile In-reply-to: Your message of "Fri, 17 May 1996 02:32:25 PDT." <199605170932.CAA04114@Root.COM> Date: Fri, 17 May 1996 02:38:19 -0700 Message-ID: <273.832325899@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > It would have been better to install it without suid root so that the > permissions get changed when people next do a "make world". Yeah, I thought of that but sort of wimped and decided to go instead for minimum impact (i.e. no changes to mount_union itself). Can we see what pst's final decision on this one is and simply recommend a `chmod u-s /sbin/mount_union' for the time being? Jordan From owner-cvs-sbin Fri May 17 15:46:13 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id PAA26047 for cvs-sbin-outgoing; Fri, 17 May 1996 15:46:13 -0700 (PDT) Received: (from pst@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id PAA26022; Fri, 17 May 1996 15:46:03 -0700 (PDT) Date: Fri, 17 May 1996 15:46:03 -0700 (PDT) From: Paul Traina Message-Id: <199605172246.PAA26022@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/mount_union Makefile Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk pst 96/05/17 15:46:03 Modified: sbin/mount_union Makefile Log: Disable setuid permission for mount_union(1). This covers the security problem descibed in SA-96:10 and Jeff says that when we upgrade to Lite2 (which fixes this problem), mount no longer needs to be setuid, so we'll never be going back. Submitted by: hsu Reviewed by: pst Revision Changes Path 1.4 +0 -3 src/sbin/mount_union/Makefile From owner-cvs-sbin Fri May 17 15:47:09 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id PAA26179 for cvs-sbin-outgoing; Fri, 17 May 1996 15:47:09 -0700 (PDT) Received: (from pst@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id PAA26155; Fri, 17 May 1996 15:47:00 -0700 (PDT) Date: Fri, 17 May 1996 15:47:00 -0700 (PDT) From: Paul Traina Message-Id: <199605172247.PAA26155@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/mount_union Makefile Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk pst 96/05/17 15:46:59 Branch: sbin/mount_union RELENG_2_1_0 Modified: sbin/mount_union Makefile Log: Disable setuid permission for mount_union(1). This covers the security problem descibed in SA-96:10 and Jeff says that when we upgrade to Lite2 (which fixes this problem), mount no longer needs to be setuid, so we'll never be going back. Submitted by: hsu Reviewed by: pst Revision Changes Path 1.3.4.1 +0 -3 src/sbin/mount_union/Makefile From owner-cvs-sbin Fri May 17 21:26:50 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id VAA22733 for cvs-sbin-outgoing; Fri, 17 May 1996 21:26:50 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id VAA22728; Fri, 17 May 1996 21:26:47 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by time.cdrom.com (8.7.5/8.6.9) with SMTP id VAA09562; Fri, 17 May 1996 21:26:40 -0700 (PDT) To: Paul Traina cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/mount_union Makefile In-reply-to: Your message of "Fri, 17 May 1996 15:46:03 PDT." <199605172246.PAA26022@freefall.freebsd.org> Date: Fri, 17 May 1996 21:26:40 -0700 Message-ID: <9560.832393600@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Shall we add it back to its parent Makefile? > pst 96/05/17 15:46:03 > > Modified: sbin/mount_union Makefile > Log: > Disable setuid permission for mount_union(1). > > This covers the security problem descibed in SA-96:10 and Jeff says that > when we upgrade to Lite2 (which fixes this problem), mount no longer needs > to be setuid, so we'll never be going back. > > Submitted by: hsu > Reviewed by: pst > > Revision Changes Path > 1.4 +0 -3 src/sbin/mount_union/Makefile From owner-cvs-sbin Sat May 18 11:22:27 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id LAA12712 for cvs-sbin-outgoing; Sat, 18 May 1996 11:22:27 -0700 (PDT) Received: from precipice.shockwave.com (precipice.shockwave.com [171.69.108.33]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id LAA12699; Sat, 18 May 1996 11:22:18 -0700 (PDT) Received: from shockwave.com (localhost.shockwave.com [127.0.0.1]) by precipice.shockwave.com (8.7.5/8.7.3) with ESMTP id LAA06375; Sat, 18 May 1996 11:20:32 -0700 (PDT) Message-Id: <199605181820.LAA06375@precipice.shockwave.com> To: "Jordan K. Hubbard" cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/mount_union Makefile In-reply-to: Your message of "Fri, 17 May 1996 21:26:40 PDT." <9560.832393600@time.cdrom.com> Date: Sat, 18 May 1996 11:20:32 -0700 From: Paul Traina Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Why was it removed? I didn't see the commit that removed it. From: "Jordan K. Hubbard" Subject: Re: cvs commit: src/sbin/mount_union Makefile Shall we add it back to its parent Makefile? > pst 96/05/17 15:46:03 > > Modified: sbin/mount_union Makefile > Log: > Disable setuid permission for mount_union(1). > > This covers the security problem descibed in SA-96:10 and Jeff says that > when we upgrade to Lite2 (which fixes this problem), mount no longer need >>s > to be setuid, so we'll never be going back. > > Submitted by: hsu > Reviewed by: pst > > Revision Changes Path > 1.4 +0 -3 src/sbin/mount_union/Makefile