From owner-cvs-bin Wed Jun 18 18:08:09 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id SAA23485 for cvs-bin-outgoing; Wed, 18 Jun 1997 18:08:09 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id SAA23401; Wed, 18 Jun 1997 18:07:19 -0700 (PDT) From: John Polstra Received: (from jdp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id SAA10711; Wed, 18 Jun 1997 18:07:07 -0700 (PDT) Date: Wed, 18 Jun 1997 18:07:07 -0700 (PDT) Message-Id: <199706190107.SAA10711@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-bin@FreeBSD.ORG Subject: cvs commit: src/bin/ln symlink.7 Sender: owner-cvs-bin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jdp 1997/06/18 18:07:06 PDT Modified files: bin/ln symlink.7 Log: Try again to explain the existence of lchown() and the absence of lchmod() and lutimes(). Revision Changes Path 1.7 +7 -12 src/bin/ln/symlink.7 From owner-cvs-bin Wed Jun 18 18:09:34 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id SAA23568 for cvs-bin-outgoing; Wed, 18 Jun 1997 18:09:34 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id SAA23537; Wed, 18 Jun 1997 18:09:22 -0700 (PDT) From: John Polstra Received: (from jdp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id SAA10756; Wed, 18 Jun 1997 18:09:10 -0700 (PDT) Date: Wed, 18 Jun 1997 18:09:10 -0700 (PDT) Message-Id: <199706190109.SAA10756@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-bin@FreeBSD.ORG Subject: cvs commit: src/bin/ln symlink.7 Sender: owner-cvs-bin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jdp 1997/06/18 18:09:10 PDT Modified files: (Branch: RELENG_2_2) bin/ln symlink.7 Log: Merge from main branch 1.6 -> 1.7. Revision Changes Path 1.2.8.2 +7 -12 src/bin/ln/symlink.7 From owner-cvs-bin Thu Jun 19 08:16:12 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id IAA01801 for cvs-bin-outgoing; Thu, 19 Jun 1997 08:16:12 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id IAA01710; Thu, 19 Jun 1997 08:14:19 -0700 (PDT) From: "Jordan K. Hubbard" Received: (from jkh@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA15697; Thu, 19 Jun 1997 08:14:02 -0700 (PDT) Date: Thu, 19 Jun 1997 08:14:02 -0700 (PDT) Message-Id: <199706191514.IAA15697@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-bin@FreeBSD.ORG Subject: cvs commit: src/bin/sh expand.c Sender: owner-cvs-bin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 1997/06/19 08:14:02 PDT Modified files: bin/sh expand.c Log: >Number: 3780 >Category: bin >Synopsis: WEXITSTATUS() may return nagative value, which causes sh to generate bad $? PR: 3780 Submitted by: sanewo@ba2.so-net.or.jp Revision Changes Path 1.20 +3 -1 src/bin/sh/expand.c From owner-cvs-bin Thu Jun 19 08:16:16 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id IAA01815 for cvs-bin-outgoing; Thu, 19 Jun 1997 08:16:16 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id IAA01729; Thu, 19 Jun 1997 08:14:40 -0700 (PDT) From: "Jordan K. Hubbard" Received: (from jkh@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA15734; Thu, 19 Jun 1997 08:14:23 -0700 (PDT) Date: Thu, 19 Jun 1997 08:14:23 -0700 (PDT) Message-Id: <199706191514.IAA15734@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-bin@FreeBSD.ORG Subject: cvs commit: src/bin/sh expand.c Sender: owner-cvs-bin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 1997/06/19 08:14:23 PDT Modified files: (Branch: RELENG_2_2) bin/sh expand.c Log: YAMFC from PR#3780 Revision Changes Path 1.11.2.3 +3 -1 src/bin/sh/expand.c From owner-cvs-bin Thu Jun 19 08:31:13 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id IAA02490 for cvs-bin-outgoing; Thu, 19 Jun 1997 08:31:13 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id IAA02463; Thu, 19 Jun 1997 08:30:46 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id BAA13078; Fri, 20 Jun 1997 01:30:14 +1000 Date: Fri, 20 Jun 1997 01:30:14 +1000 From: Bruce Evans Message-Id: <199706191530.BAA13078@godzilla.zeta.org.au> To: cvs-all@FreeBSD.ORG, cvs-bin@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, jkh@FreeBSD.ORG Subject: Re: cvs commit: src/bin/sh expand.c Sender: owner-cvs-bin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Modified files: > bin/sh expand.c > Log: > >Number: 3780 > >Category: bin > >Synopsis: WEXITSTATUS() may return nagative value, which causes sh to generate bad $? > > PR: 3780 > Submitted by: sanewo@ba2.so-net.or.jp The submitted patch misses the point and should never have been committed. See followup mail in the PR about what the problem actually is. Submitted patches are almost never suitable for committing directly. Bruce From owner-cvs-bin Thu Jun 19 10:56:46 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id KAA08471 for cvs-bin-outgoing; Thu, 19 Jun 1997 10:56:46 -0700 (PDT) Received: from time.cdrom.com (root@time.cdrom.com [204.216.27.226]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA08454; Thu, 19 Jun 1997 10:56:31 -0700 (PDT) Received: from time.cdrom.com (jkh@localhost.cdrom.com [127.0.0.1]) by time.cdrom.com (8.8.5/8.6.9) with ESMTP id KAA23921; Thu, 19 Jun 1997 10:56:12 -0700 (PDT) To: Bruce Evans cc: cvs-all@FreeBSD.ORG, cvs-bin@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, jkh@FreeBSD.ORG Subject: Re: cvs commit: src/bin/sh expand.c In-reply-to: Your message of "Fri, 20 Jun 1997 01:30:14 +1000." <199706191530.BAA13078@godzilla.zeta.org.au> Date: Thu, 19 Jun 1997 10:56:12 -0700 Message-ID: <23917.866742972@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-bin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > The submitted patch misses the point and should never have been committed. C'mon, Bruce, don't beat around the bush - what are you trying to say? :-) > See followup mail in the PR about what the problem actually is. OK, sorry, I missed this somehow. > Submitted patches are almost never suitable for committing directly. Well, I did look at it first, sheesh! ;) Given the mastications that sh was doing on the value of the integer there, the fix seemed perfectly correct so I committed it. I didn't know I was walking into a POSIX war in the process, the kind where you generally tend to note 27 different things which are wrong in copious detail and thus scare everyone away from actually trying to treat the affected areas. :-) Been there, done that already, am backing out the change right now. :) Jordan From owner-cvs-bin Thu Jun 19 10:58:55 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id KAA08630 for cvs-bin-outgoing; Thu, 19 Jun 1997 10:58:55 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA08492; Thu, 19 Jun 1997 10:57:24 -0700 (PDT) From: "Jordan K. Hubbard" Received: (from jkh@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA16690; Thu, 19 Jun 1997 10:57:06 -0700 (PDT) Date: Thu, 19 Jun 1997 10:57:06 -0700 (PDT) Message-Id: <199706191757.KAA16690@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-bin@FreeBSD.ORG Subject: cvs commit: src/bin/sh expand.c Sender: owner-cvs-bin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 1997/06/19 10:57:06 PDT Modified files: bin/sh expand.c Log: Back out previous fix - this bug's got diplomatic immunity as a registered political issue. Revision Changes Path 1.21 +1 -3 src/bin/sh/expand.c From owner-cvs-bin Thu Jun 19 10:59:23 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id KAA08661 for cvs-bin-outgoing; Thu, 19 Jun 1997 10:59:23 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA08527; Thu, 19 Jun 1997 10:57:48 -0700 (PDT) From: "Jordan K. Hubbard" Received: (from jkh@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA16726; Thu, 19 Jun 1997 10:57:30 -0700 (PDT) Date: Thu, 19 Jun 1997 10:57:30 -0700 (PDT) Message-Id: <199706191757.KAA16726@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-bin@FreeBSD.ORG Subject: cvs commit: src/bin/sh expand.c Sender: owner-cvs-bin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 1997/06/19 10:57:30 PDT Modified files: (Branch: RELENG_2_2) bin/sh expand.c Log: YABOCFC (Yet Another Backed-Out Change From Current). Revision Changes Path 1.11.2.4 +1 -3 src/bin/sh/expand.c From owner-cvs-bin Thu Jun 19 11:42:19 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id LAA10626 for cvs-bin-outgoing; Thu, 19 Jun 1997 11:42:19 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id LAA10608; Thu, 19 Jun 1997 11:41:40 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id EAA18554; Fri, 20 Jun 1997 04:35:55 +1000 Date: Fri, 20 Jun 1997 04:35:55 +1000 From: Bruce Evans Message-Id: <199706191835.EAA18554@godzilla.zeta.org.au> To: bde@zeta.org.au, jkh@time.cdrom.com Subject: Re: cvs commit: src/bin/sh expand.c Cc: cvs-all@FreeBSD.ORG, cvs-bin@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, jkh@FreeBSD.ORG Sender: owner-cvs-bin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> Submitted patches are almost never suitable for committing directly. > >Well, I did look at it first, sheesh! ;) Given the mastications that >sh was doing on the value of the integer there, the fix seemed >perfectly correct so I committed it. I didn't know I was walking into Yes, the fix seems to address another bug. The home made itoa() is obviously wrong for all negative values. Now it is only obviously wrong when the negation causes overflow :-). Apart from giving undefined behaviour, the overflow normally gives a negative int so you are no closer to printing its absolute value. The fix leaves sh printing wrong exit values. After exit(255), sh prints $? as -1 (-1 is 255 shifted back and forth). Did you test all possible exit values? :-) Bruce