From owner-cvs-lib Sun Mar 23 11:09:16 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id LAA20036 for cvs-lib-outgoing; Sun, 23 Mar 1997 11:09:16 -0800 (PST) Received: (from joerg@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id LAA20009; Sun, 23 Mar 1997 11:09:10 -0800 (PST) Date: Sun, 23 Mar 1997 11:09:10 -0800 (PST) From: Joerg Wunsch Message-Id: <199703231909.LAA20009@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib, cvs-sys Subject: cvs commit: src/lib/libc/gen syslog.c src/sys/sys syslog.h Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk joerg 97/03/23 11:09:09 Branch: lib/libc/gen RELENG_2_2 sys/sys RELENG_2_2 Modified: lib/libc/gen syslog.c sys/sys syslog.h Log: YAMFC: rev 1.13 of both files, providing backward binary compatibility if /var/run/log could not be found. Revision Changes Path 1.9.2.1 +23 -10 src/lib/libc/gen/syslog.c 1.8.2.2 +2 -1 src/sys/sys/syslog.h From owner-cvs-lib Sun Mar 23 14:40:25 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id OAA03680 for cvs-lib-outgoing; Sun, 23 Mar 1997 14:40:25 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id OAA03673; Sun, 23 Mar 1997 14:40:23 -0800 (PST) Date: Sun, 23 Mar 1997 14:40:23 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703232240.OAA03673@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/stdlib random.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/23 14:40:22 Modified: lib/libc/stdlib random.c Log: Add srandomdev() function (use "/dev/urandom" now) Submitted by: wollman & me (add type casts and remove unneded loop) Revision Changes Path 1.6 +40 -0 src/lib/libc/stdlib/random.c From owner-cvs-lib Sun Mar 23 15:08:39 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA05503 for cvs-lib-outgoing; Sun, 23 Mar 1997 15:08:39 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA05493; Sun, 23 Mar 1997 15:08:33 -0800 (PST) Date: Sun, 23 Mar 1997 15:08:33 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703232308.PAA05493@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/stdlib random.3 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/23 15:08:33 Modified: lib/libc/stdlib random.3 Log: Add srandomdev() description Revision Changes Path 1.6 +24 -1 src/lib/libc/stdlib/random.3 From owner-cvs-lib Sun Mar 23 15:09:34 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA05566 for cvs-lib-outgoing; Sun, 23 Mar 1997 15:09:34 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA05559; Sun, 23 Mar 1997 15:09:32 -0800 (PST) Date: Sun, 23 Mar 1997 15:09:32 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703232309.PAA05559@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/stdlib random.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/23 15:09:32 Modified: lib/libc/stdlib random.c Log: Fix urandom reference in the comment Revision Changes Path 1.7 +1 -1 src/lib/libc/stdlib/random.c From owner-cvs-lib Sun Mar 23 15:13:04 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA05851 for cvs-lib-outgoing; Sun, 23 Mar 1997 15:13:04 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA05841; Sun, 23 Mar 1997 15:13:02 -0800 (PST) Date: Sun, 23 Mar 1997 15:13:02 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703232313.PAA05841@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/stdlib Makefile.inc Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/23 15:13:01 Modified: lib/libc/stdlib Makefile.inc Log: Add srandomdev.3 link Revision Changes Path 1.7 +2 -1 src/lib/libc/stdlib/Makefile.inc From owner-cvs-lib Sun Mar 23 15:17:26 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA06141 for cvs-lib-outgoing; Sun, 23 Mar 1997 15:17:26 -0800 (PST) Received: (from imp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA06134; Sun, 23 Mar 1997 15:17:24 -0800 (PST) Date: Sun, 23 Mar 1997 15:17:24 -0800 (PST) From: Warner Losh Message-Id: <199703232317.PAA06134@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libedit el.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk imp 97/03/23 15:17:23 Modified: lib/libedit el.c Log: Fix a minor buffer overflow. Obtained from: BSDi by way of Keith Bostic Revision Changes Path 1.3 +2 -3 src/lib/libedit/el.c From owner-cvs-lib Sun Mar 23 15:27:20 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA07805 for cvs-lib-outgoing; Sun, 23 Mar 1997 15:27:20 -0800 (PST) Received: (from imp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA07798; Sun, 23 Mar 1997 15:27:19 -0800 (PST) Date: Sun, 23 Mar 1997 15:27:19 -0800 (PST) From: Warner Losh Message-Id: <199703232327.PAA07798@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libedit el.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk imp 97/03/23 15:27:18 Branch: lib/libedit RELENG_2_2 Modified: lib/libedit el.c Log: YAMCF: 1.3 fix buffer overflow Revision Changes Path 1.2.6.1 +2 -3 src/lib/libedit/el.c From owner-cvs-lib Sun Mar 23 15:31:54 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA08026 for cvs-lib-outgoing; Sun, 23 Mar 1997 15:31:54 -0800 (PST) Received: (from imp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA08019; Sun, 23 Mar 1997 15:31:52 -0800 (PST) Date: Sun, 23 Mar 1997 15:31:52 -0800 (PST) From: Warner Losh Message-Id: <199703232331.PAA08019@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/gen glob.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk imp 97/03/23 15:31:51 Modified: lib/libc/gen glob.c Log: Buffer overflow. Similar, but different, to the fix that Julian A submitted in PR 2580. Obtained from: BSDi by way of Keith Bostic Should be in 2.2 and 2.1.x. I'll merge into 2.2. Revision Changes Path 1.7 +15 -9 src/lib/libc/gen/glob.c From owner-cvs-lib Sun Mar 23 15:33:22 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA08210 for cvs-lib-outgoing; Sun, 23 Mar 1997 15:33:22 -0800 (PST) Received: (from imp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA08203; Sun, 23 Mar 1997 15:33:18 -0800 (PST) Date: Sun, 23 Mar 1997 15:33:18 -0800 (PST) From: Warner Losh Message-Id: <199703232333.PAA08203@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/gen glob.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk imp 97/03/23 15:33:18 Branch: lib/libc/gen RELENG_2_2 Modified: lib/libc/gen glob.c Log: YAMFC: 1.7: Buffer overflow Revision Changes Path 1.6.2.1 +15 -9 src/lib/libc/gen/glob.c From owner-cvs-lib Sun Mar 23 17:22:12 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id RAA16122 for cvs-lib-outgoing; Sun, 23 Mar 1997 17:22:12 -0800 (PST) Received: (from jmg@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id RAA16108; Sun, 23 Mar 1997 17:22:09 -0800 (PST) Date: Sun, 23 Mar 1997 17:22:09 -0800 (PST) From: John-Mark Gurney Message-Id: <199703240122.RAA16108@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/sys accept.2 connect.2 getsockname.2 socket.2 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jmg 97/03/23 17:22:08 Modified: lib/libc/sys accept.2 connect.2 getsockname.2 socket.2 Log: add xrefs for getpeername, so other people that look for it can find it.. :) Revision Changes Path 1.4 +1 -0 src/lib/libc/sys/accept.2 1.6 +1 -0 src/lib/libc/sys/connect.2 1.6 +1 -0 src/lib/libc/sys/getsockname.2 1.7 +2 -1 src/lib/libc/sys/socket.2 From owner-cvs-lib Sun Mar 23 22:09:59 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA00680 for cvs-lib-outgoing; Sun, 23 Mar 1997 22:09:59 -0800 (PST) Received: (from imp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA00671; Sun, 23 Mar 1997 22:09:55 -0800 (PST) Date: Sun, 23 Mar 1997 22:09:55 -0800 (PST) From: Warner Losh Message-Id: <199703240609.WAA00671@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/stdtime localtime.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk imp 97/03/23 22:09:53 Modified: lib/libc/stdtime localtime.c Log: Don't open the tz file if we're running setuid or setgid to prevent infomration leakage. Submitted by: Julian Assange Revision Changes Path 1.14 +4 -2 src/lib/libc/stdtime/localtime.c From owner-cvs-lib Sun Mar 23 22:11:49 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA00786 for cvs-lib-outgoing; Sun, 23 Mar 1997 22:11:49 -0800 (PST) Received: (from imp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA00779; Sun, 23 Mar 1997 22:11:46 -0800 (PST) Date: Sun, 23 Mar 1997 22:11:46 -0800 (PST) From: Warner Losh Message-Id: <199703240611.WAA00779@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/net res_query.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk imp 97/03/23 22:11:46 Modified: lib/libc/net res_query.c Log: If we're running setuid/setguid then don't open the host alias file to prevent information leakage. Closes PR 2578 Submitted by: Julian Assange Revision Changes Path 1.13 +4 -1 src/lib/libc/net/res_query.c From owner-cvs-lib Sun Mar 23 22:15:10 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA01099 for cvs-lib-outgoing; Sun, 23 Mar 1997 22:15:10 -0800 (PST) Received: (from imp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA01092; Sun, 23 Mar 1997 22:15:08 -0800 (PST) Date: Sun, 23 Mar 1997 22:15:08 -0800 (PST) From: Warner Losh Message-Id: <199703240615.WAA01092@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/nls msgcat.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk imp 97/03/23 22:15:08 Modified: lib/libc/nls msgcat.c Log: Don't honor LANG or NLSPATH if we're setuid/setgid. Fixes PR 2582 Submitted by: Julian Assange Revision Changes Path 1.8 +8 -3 src/lib/libc/nls/msgcat.c From owner-cvs-lib Sun Mar 23 22:41:36 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA02214 for cvs-lib-outgoing; Sun, 23 Mar 1997 22:41:36 -0800 (PST) Received: (from imp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA02207; Sun, 23 Mar 1997 22:41:33 -0800 (PST) Date: Sun, 23 Mar 1997 22:41:33 -0800 (PST) From: Warner Losh Message-Id: <199703240641.WAA02207@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libtermcap pathnames.h termcap.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk imp 97/03/23 22:41:32 Modified: lib/libtermcap pathnames.h termcap.c Log: Don't overflow buffers, and only open alternative termcap files if we're not running setuid or setgid. Fixes PR 2586 Submitted by: Julian Assange Revision Changes Path 1.2 +1 -0 src/lib/libtermcap/pathnames.h 1.8 +7 -2 src/lib/libtermcap/termcap.c From owner-cvs-lib Mon Mar 24 06:07:30 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA09090 for cvs-lib-outgoing; Mon, 24 Mar 1997 06:07:30 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id GAA09082; Mon, 24 Mar 1997 06:07:15 -0800 (PST) Received: by sovcom.kiae.su id AA25969 (5.65.kiae-1 ); Mon, 24 Mar 1997 16:28:58 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Mon, 24 Mar 97 16:28:57 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id QAA00692; Mon, 24 Mar 1997 16:26:07 +0300 (MSK) Date: Mon, 24 Mar 1997 16:26:06 +0300 (MSK) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Warner Losh Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/nls msgcat.c In-Reply-To: <199703240615.WAA01092@freefall.freebsd.org> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sun, 23 Mar 1997, Warner Losh wrote: > imp 97/03/23 22:15:08 > > Modified: lib/libc/nls msgcat.c > Log: > Don't honor LANG or NLSPATH if we're setuid/setgid. > 1) You can't determine setuid/setgid without issetuid() syscall implementing, so this change gives only false sense of security. 2) Please back out LANG honoring, it is functionality degradation. You can disable NLSPATH but only with issetuid() syscall, not now. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-lib Mon Mar 24 06:07:41 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA09111 for cvs-lib-outgoing; Mon, 24 Mar 1997 06:07:41 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id GAA09089; Mon, 24 Mar 1997 06:07:27 -0800 (PST) Received: by sovcom.kiae.su id AA25974 (5.65.kiae-1 ); Mon, 24 Mar 1997 16:29:00 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Mon, 24 Mar 97 16:28:59 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id QAA00700; Mon, 24 Mar 1997 16:28:42 +0300 (MSK) Date: Mon, 24 Mar 1997 16:28:41 +0300 (MSK) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Warner Losh Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c In-Reply-To: <199703240609.WAA00671@freefall.freebsd.org> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sun, 23 Mar 1997, Warner Losh wrote: > imp 97/03/23 22:09:53 > > Modified: lib/libc/stdtime localtime.c > Log: > Don't open the tz file if we're running setuid or setgid to prevent infomration > leakage. You can't determine setuid without issetuid() syscall implementing, so this change gives only false sense of security. Priveledges can be dropped before the moment you check them using getuid()/geteuid() and restored back to suid after your check, so your check gains nothing. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-lib Mon Mar 24 06:07:53 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA09160 for cvs-lib-outgoing; Mon, 24 Mar 1997 06:07:53 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id GAA09109; Mon, 24 Mar 1997 06:07:40 -0800 (PST) Received: by sovcom.kiae.su id AA25940 (5.65.kiae-1 ); Mon, 24 Mar 1997 16:28:54 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Mon, 24 Mar 97 16:28:54 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id QAA00678; Mon, 24 Mar 1997 16:21:46 +0300 (MSK) Date: Mon, 24 Mar 1997 16:21:43 +0300 (MSK) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Warner Losh Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c In-Reply-To: <199703240641.WAA02207@freefall.freebsd.org> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sun, 23 Mar 1997, Warner Losh wrote: > imp 97/03/23 22:41:32 > > Modified: lib/libtermcap pathnames.h termcap.c > Log: > Don't overflow buffers, and only open alternative termcap files if we're > not running setuid or setgid. 1) You can't determine setuid binaries without new issetuid() syscall. 2) I object of disallowing alternative termcap files, I always use my own termcap file (and many users do it to) and treat this step as functionality degradation, please back it out. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-lib Mon Mar 24 06:08:05 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA09194 for cvs-lib-outgoing; Mon, 24 Mar 1997 06:08:05 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id GAA09159; Mon, 24 Mar 1997 06:07:53 -0800 (PST) Received: by sovcom.kiae.su id AA28712 (5.65.kiae-1 ); Mon, 24 Mar 1997 16:34:43 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Mon, 24 Mar 97 16:34:43 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id QAA00720; Mon, 24 Mar 1997 16:29:45 +0300 (MSK) Date: Mon, 24 Mar 1997 16:29:44 +0300 (MSK) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Warner Losh Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/net res_query.c In-Reply-To: <199703240611.WAA00779@freefall.freebsd.org> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sun, 23 Mar 1997, Warner Losh wrote: > imp 97/03/23 22:11:46 > > Modified: lib/libc/net res_query.c > Log: > If we're running setuid/setguid then don't open the host alias file to > prevent information leakage. As I already say, you can't check for setuid now, it is impossible. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-lib Mon Mar 24 06:50:37 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA11390 for cvs-lib-outgoing; Mon, 24 Mar 1997 06:50:37 -0800 (PST) Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.0.193]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id GAA11288; Mon, 24 Mar 1997 06:50:11 -0800 (PST) Received: (from wollman@localhost) by khavrinen.lcs.mit.edu (8.8.5/8.8.5) id JAA13490; Mon, 24 Mar 1997 09:50:05 -0500 (EST) Date: Mon, 24 Mar 1997 09:50:05 -0500 (EST) From: Garrett Wollman Message-Id: <199703241450.JAA13490@khavrinen.lcs.mit.edu> To: Warner Losh Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: cvs commit: src/lib/libc/stdtime localtime.c In-Reply-To: <199703240609.WAA00671@freefall.freebsd.org> References: <199703240609.WAA00671@freefall.freebsd.org> Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk < said: > imp 97/03/23 22:09:53 > Modified: lib/libc/stdtime localtime.c > Log: > Don't open the tz file if we're running setuid or setgid to prevent infomration > leakage. Um, from this description, this sounds like the most incredibly idiotic idea I've ever heard... You've completely broken localtime() for set[ug]id executables. Sorry if that sounds too harsh, but I don't see it as an advance. -GAWollman -- Garrett A. Wollman | O Siem / We are all family / O Siem / We're all the same wollman@lcs.mit.edu | O Siem / The fires of freedom Opinions not those of| Dance in the burning flame MIT, LCS, CRS, or NSA| - Susan Aglukark and Chad Irschick From owner-cvs-lib Mon Mar 24 07:27:30 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA13317 for cvs-lib-outgoing; Mon, 24 Mar 1997 07:27:30 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id HAA13099; Mon, 24 Mar 1997 07:23:25 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 0.56 #1) id E0w9BXb-00057I-00; Mon, 24 Mar 1997 08:20:07 -0700 To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org In-reply-to: Your message of "Mon, 24 Mar 1997 16:21:43 +0300." References: Date: Mon, 24 Mar 1997 08:20:07 -0700 From: Warner Losh Message-Id: Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= writes: : 2) I object of disallowing alternative termcap files, I always use : my own termcap file (and many users do it to) and treat this step : as functionality degradation, please back it out. When you are running with elevated privs, you have to do something to prevent people from specifying files they don't normally have permission to read. I'll see what it takes to put this in with the right checks. Warner From owner-cvs-lib Mon Mar 24 07:27:52 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA13397 for cvs-lib-outgoing; Mon, 24 Mar 1997 07:27:52 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id HAA13105; Mon, 24 Mar 1997 07:23:58 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 0.56 #1) id E0w9BY9-00057R-00; Mon, 24 Mar 1997 08:20:41 -0700 To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= Subject: Re: cvs commit: src/lib/libc/net res_query.c Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org In-reply-to: Your message of "Mon, 24 Mar 1997 16:29:44 +0300." References: Date: Mon, 24 Mar 1997 08:20:40 -0700 From: Warner Losh Message-Id: Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= writes: : As I already say, you can't check for setuid now, it is impossible. Noted. See also the comments right above the code that says the same thing. Warner From owner-cvs-lib Mon Mar 24 07:29:00 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA13472 for cvs-lib-outgoing; Mon, 24 Mar 1997 07:29:00 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id HAA13199; Mon, 24 Mar 1997 07:25:26 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 0.56 #1) id E0w9BWR-000576-00; Mon, 24 Mar 1997 08:18:55 -0700 To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= Subject: Re: cvs commit: src/lib/libc/nls msgcat.c Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org In-reply-to: Your message of "Mon, 24 Mar 1997 16:26:06 +0300." References: Date: Mon, 24 Mar 1997 08:18:55 -0700 From: Warner Losh Message-Id: Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= writes: : 1) You can't determine setuid/setgid without issetuid() syscall : implementing, so this change gives only false sense of security. I know that. It is better than nothing, which is what we have. There is a XXX Really needs isetugid() comment there so we can easily find all the places we've plastered over. : 2) Please back out LANG honoring, it is functionality degradation. OK. I'll do that, but I'll make it safe. : You can disable NLSPATH but only with issetuid() syscall, not now. Then someone should check it in. I'm tired of waiting :-). I'd do it, but I'm sure that my implementation would be busted (which would be basically if euid != uid || egid != gid || P_SETUID). Warner From owner-cvs-lib Mon Mar 24 07:29:23 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA13508 for cvs-lib-outgoing; Mon, 24 Mar 1997 07:29:23 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id HAA13222; Mon, 24 Mar 1997 07:25:55 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 0.56 #1) id E0w9BaA-00057e-00; Mon, 24 Mar 1997 08:22:46 -0700 To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org In-reply-to: Your message of "Mon, 24 Mar 1997 16:28:41 +0300." References: Date: Mon, 24 Mar 1997 08:22:46 -0700 From: Warner Losh Message-Id: Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= writes: : You can't determine setuid without issetuid() syscall implementing, so : this change gives only false sense of security. Priveledges can be : dropped before the moment you check them using getuid()/geteuid() and : restored back to suid after your check, so your check gains nothing. If privs are dropped, then my check is still valid. I think this is acceptible. Since if the privs are dropped, the user is running normal, there is no need for this check which just prevents people from reading files they otherwise shouldn't be reading. Warner From owner-cvs-lib Mon Mar 24 07:31:36 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA13629 for cvs-lib-outgoing; Mon, 24 Mar 1997 07:31:36 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id HAA13365; Mon, 24 Mar 1997 07:27:44 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 0.56 #1) id E0w9Bcy-000586-00; Mon, 24 Mar 1997 08:25:40 -0700 To: Garrett Wollman Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org In-reply-to: Your message of "Mon, 24 Mar 1997 09:50:05 EST." <199703241450.JAA13490@khavrinen.lcs.mit.edu> References: <199703241450.JAA13490@khavrinen.lcs.mit.edu> <199703240609.WAA00671@freefall.freebsd.org> Date: Mon, 24 Mar 1997 08:25:40 -0700 From: Warner Losh Message-Id: Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message <199703241450.JAA13490@khavrinen.lcs.mit.edu> Garrett Wollman writes: : Um, from this description, this sounds like the most incredibly : idiotic idea I've ever heard... You've completely broken localtime() : for set[ug]id executables. : : Sorry if that sounds too harsh, but I don't see it as an advance. The intent of the patch was to disallow non-standard places to be specified. My tests here indicate that it seems to work for the standard places. My fault for not having a good description for the commit messages. If I have actually broken this, please let me know and I'll fix it. I'll also do more testing on this system to make sure that what I thought I saw I really did see. Warner From owner-cvs-lib Mon Mar 24 07:33:42 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA13745 for cvs-lib-outgoing; Mon, 24 Mar 1997 07:33:42 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id HAA13563; Mon, 24 Mar 1997 07:30:04 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 0.56 #1) id E0w9BgH-00058p-00; Mon, 24 Mar 1997 08:29:05 -0700 To: Garrett Wollman Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org In-reply-to: Your message of "Mon, 24 Mar 1997 09:50:05 EST." <199703241450.JAA13490@khavrinen.lcs.mit.edu> References: <199703241450.JAA13490@khavrinen.lcs.mit.edu> <199703240609.WAA00671@freefall.freebsd.org> Date: Mon, 24 Mar 1997 08:29:05 -0700 From: Warner Losh Message-Id: Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk P.S. Here's my test: 8:26am rover:[487]> cp /bin/date ./date-suid 8:26am rover:[488]> sudo chown root ./date-suid 8:26am rover:[489]> sudo chmod 4555 ./date-suid 8:26am rover:[490]> ls -l ./date-suid -r-sr-xr-x 1 root wheel 143360 Mar 24 08:26 ./date-suid 8:26am rover:[492]> ./date-suid Mon Mar 24 08:26:51 MST 1997 8:26am rover:[494]> env TZ=EST ./date-suid Mon Mar 24 10:26:59 EST 1997 From owner-cvs-lib Mon Mar 24 08:51:07 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA17726 for cvs-lib-outgoing; Mon, 24 Mar 1997 08:51:07 -0800 (PST) Received: from sequent.kiae.su (sequent.kiae.su [193.125.152.6]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id IAA17711; Mon, 24 Mar 1997 08:50:43 -0800 (PST) Received: by sequent.kiae.su id AA16178 (5.65.kiae-2 ); Mon, 24 Mar 1997 19:28:01 +0300 Received: by sequent.KIAE.su (UUMAIL/2.0); Mon, 24 Mar 97 19:28:00 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id TAA02126; Mon, 24 Mar 1997 19:25:29 +0300 (MSK) Date: Mon, 24 Mar 1997 19:25:28 +0300 (MSK) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Warner Losh Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c In-Reply-To: <199703240609.WAA00671@freefall.freebsd.org> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sun, 23 Mar 1997, Warner Losh wrote: > imp 97/03/23 22:09:53 > > Modified: lib/libc/stdtime localtime.c > Log: > Don't open the tz file if we're running setuid or setgid to prevent infomration > leakage. I forget to note that this change should be backed out in any case. It broke whole TZ idea. If you need check, do it properly checking ranges and overflowes inside localtime code itself, not by disallowing tz file opening. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-lib Mon Mar 24 09:03:16 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA18243 for cvs-lib-outgoing; Mon, 24 Mar 1997 09:03:16 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id JAA18202; Mon, 24 Mar 1997 09:02:51 -0800 (PST) Received: by sovcom.kiae.su id AA10654 (5.65.kiae-1 ); Mon, 24 Mar 1997 19:25:17 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Mon, 24 Mar 97 19:25:17 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id TAA02114; Mon, 24 Mar 1997 19:20:45 +0300 (MSK) Date: Mon, 24 Mar 1997 19:20:42 +0300 (MSK) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Warner Losh Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c In-Reply-To: Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Mon, 24 Mar 1997, Warner Losh wrote: > In message =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= writes: > : You can't determine setuid without issetuid() syscall implementing, so > : this change gives only false sense of security. Priveledges can be > : dropped before the moment you check them using getuid()/geteuid() and > : restored back to suid after your check, so your check gains nothing. > > If privs are dropped, then my check is still valid. I think this is > acceptible. Since if the privs are dropped, the user is running > normal, there is no need for this check which just prevents people > from reading files they otherwise shouldn't be reading. It is what I call false sense of security. This example show thing you can't bypass without issetuid(): privs initially on privs off (by program) (your check shows nothing and allow some flexibility) intruder write some nasty code to the stack privs on (by program) He got priveledges! There is many programs which falls into that category. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-lib Mon Mar 24 09:08:45 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA18567 for cvs-lib-outgoing; Mon, 24 Mar 1997 09:08:45 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id JAA18405; Mon, 24 Mar 1997 09:05:25 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 0.56 #1) id E0w9DA2-0005II-00; Mon, 24 Mar 1997 10:03:54 -0700 To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org In-reply-to: Your message of "Mon, 24 Mar 1997 19:25:28 +0300." References: Date: Mon, 24 Mar 1997 10:03:54 -0700 From: Warner Losh Message-Id: Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= writes: : I forget to note that this change should be backed out in any case. : It broke whole TZ idea. If you need check, do it properly checking : ranges and overflowes inside localtime code itself, not by disallowing : tz file opening. Ummm, my tests show that it works with all standard TZ values (at least the ones I samples EST, EST5EDT, America/New_York). It didn't work with /home/imp/bogus/time/zone, which was the intent of the change. If my tests were flawed, then please let me know what I broke. I tested this with a setuid copy of date. Any my commit message was horrible in that it cause confusion. All I intended to do was to disallow non-standard places. If that isn't the case, please let me know. Warner From owner-cvs-lib Mon Mar 24 09:10:56 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA18717 for cvs-lib-outgoing; Mon, 24 Mar 1997 09:10:56 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id JAA18479; Mon, 24 Mar 1997 09:07:49 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 0.56 #1) id E0w9DDd-0005Ii-00; Mon, 24 Mar 1997 10:07:37 -0700 To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org In-reply-to: Your message of "Mon, 24 Mar 1997 19:20:42 +0300." References: Date: Mon, 24 Mar 1997 10:07:36 -0700 From: Warner Losh Message-Id: Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= writes: : privs initially on : privs off (by program) : (your check shows nothing and allow some flexibility) : intruder write some nasty code to the stack : privs on (by program) : He got priveledges! Yes. I understand this. This particular change however is just for what files are opened, rather than to guard against buffer overflows. I also understand that other of my patches are vulnerable to this too, but at least some of the holes are closed, and the code is well marked for when I see issetugid() goes into the kernel. There is no false sense of security, because I know the problem isn't completely solved :-). Warner From owner-cvs-lib Mon Mar 24 09:33:55 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA20219 for cvs-lib-outgoing; Mon, 24 Mar 1997 09:33:55 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id JAA20193; Mon, 24 Mar 1997 09:33:42 -0800 (PST) Received: by sovcom.kiae.su id AA14853 (5.65.kiae-1 ); Mon, 24 Mar 1997 19:36:07 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Mon, 24 Mar 97 19:36:06 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id TAA02166; Mon, 24 Mar 1997 19:35:39 +0300 (MSK) Date: Mon, 24 Mar 1997 19:35:37 +0300 (MSK) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Warner Losh Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c In-Reply-To: Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Mon, 24 Mar 1997, Warner Losh wrote: > In message =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= writes: > : 2) I object of disallowing alternative termcap files, I always use > : my own termcap file (and many users do it to) and treat this step > : as functionality degradation, please back it out. > > When you are running with elevated privs, you have to do something to > prevent people from specifying files they don't normally have > permission to read. I'll see what it takes to put this in with the > right checks. The first idea which comes to mind is very simple: if you running with privs, read only world-readable files (f.e. termcap files) I don't see this thing is ever needed for tz files because they are supposed to be only relative to /usr/share/zoneinfo. You need to check only for /../../ constructions inside TZ value. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-lib Mon Mar 24 09:52:40 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA21675 for cvs-lib-outgoing; Mon, 24 Mar 1997 09:52:40 -0800 (PST) Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id JAA21392; Mon, 24 Mar 1997 09:49:30 -0800 (PST) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <16669(2)>; Mon, 24 Mar 1997 09:48:52 PST Received: by crevenia.parc.xerox.com id <177486>; Mon, 24 Mar 1997 09:48:40 -0800 From: Bill Fenner To: ache@nagual.ru, imp@village.org Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Message-Id: <97Mar24.094840pst.177486@crevenia.parc.xerox.com> Date: Mon, 24 Mar 1997 09:48:30 PST Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk I think a lot would be solved by having a library function like access() that also accepts a UID. Then the don't-let-people-access- files-in-a-setuid-program-that-they-wouldn't-normally-have-access-to problem, instead of being solved in N different setuid programs, could be solved once. Bill From owner-cvs-lib Mon Mar 24 10:16:04 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA23375 for cvs-lib-outgoing; Mon, 24 Mar 1997 10:16:04 -0800 (PST) Received: from jekyll.piermont.com (jekyll.piermont.com [206.1.51.15]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA23298; Mon, 24 Mar 1997 10:14:20 -0800 (PST) Received: from [[UNIX: localhost]] ([[UNIX: localhost]]) by jekyll.piermont.com (8.8.5/8.6.12) with SMTP id NAA25490; Mon, 24 Mar 1997 13:13:25 -0500 (EST) Message-Id: <199703241813.NAA25490@jekyll.piermont.com> X-Authentication-Warning: jekyll.piermont.com: [[UNIX: localhost]] didn't use HELO protocol To: Bill Fenner cc: ache@nagual.ru, imp@village.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c In-reply-to: Your message of "Mon, 24 Mar 1997 09:48:30 PST." <97Mar24.094840pst.177486@crevenia.parc.xerox.com> Reply-To: perry@piermont.com X-Reposting-Policy: redistribute only with permission Date: Mon, 24 Mar 1997 13:13:20 -0500 From: "Perry E. Metzger" Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Bill Fenner writes: > I think a lot would be solved by having a library function like > access() that also accepts a UID. Won't work. There is a race condition between the moment you use access() or anything like it and the moment you open the file. That's why no one in their right mind uses access() any longer. This has been done over and over... sigh... Perry From owner-cvs-lib Mon Mar 24 10:19:39 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA23617 for cvs-lib-outgoing; Mon, 24 Mar 1997 10:19:39 -0800 (PST) Received: from critter.dk.tfs.com (phk.cybercity.dk [195.8.133.247]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA23579; Mon, 24 Mar 1997 10:18:42 -0800 (PST) Received: from critter (localhost [127.0.0.1]) by critter.dk.tfs.com (8.8.5/8.8.5) with ESMTP id TAA00230; Mon, 24 Mar 1997 19:17:22 +0100 (CET) To: Bill Fenner cc: ache@nagual.ru, imp@village.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c In-reply-to: Your message of "Mon, 24 Mar 1997 09:48:30 PST." <97Mar24.094840pst.177486@crevenia.parc.xerox.com> Date: Mon, 24 Mar 1997 19:17:22 +0100 Message-ID: <228.859227442@critter> From: Poul-Henning Kamp Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message <97Mar24.094840pst.177486@crevenia.parc.xerox.com>, Bill Fenner writ es: >I think a lot would be solved by having a library function like >access() that also accepts a UID. Then the don't-let-people-access- >files-in-a-setuid-program-that-they-wouldn't-normally-have-access-to >problem, instead of being solved in N different setuid programs, >could be solved once. Well, access_as(2) alone will not do it, you would need a open_as(2), unlink_as(2), rename_as(2) and so on... -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@tfs.com TRW Financial Systems, Inc. Power and ignorance is a disgusting cocktail. From owner-cvs-lib Mon Mar 24 10:25:30 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA24146 for cvs-lib-outgoing; Mon, 24 Mar 1997 10:25:30 -0800 (PST) Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id KAA23811; Mon, 24 Mar 1997 10:22:17 -0800 (PST) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <15473(6)>; Mon, 24 Mar 1997 10:21:39 PST Received: from localhost by crevenia.parc.xerox.com with SMTP id <177486>; Mon, 24 Mar 1997 10:21:28 -0800 To: perry@piermont.com cc: Bill Fenner , ache@nagual.ru, imp@village.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c In-reply-to: Your message of "Mon, 24 Mar 97 10:13:20 PST." <199703241813.NAA25490@jekyll.piermont.com> Date: Mon, 24 Mar 1997 10:21:23 PST From: Bill Fenner Message-Id: <97Mar24.102128pst.177486@crevenia.parc.xerox.com> Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk "Perry E. Metzger" wrote: >Won't work. Er, right. Let me rephrase that. I think it's too early for me to be sending email today =) Bill From owner-cvs-lib Mon Mar 24 15:46:27 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA20499 for cvs-lib-outgoing; Mon, 24 Mar 1997 15:46:27 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA20490; Mon, 24 Mar 1997 15:46:24 -0800 (PST) Date: Mon, 24 Mar 1997 15:46:24 -0800 (PST) From: Mike Pritchard Message-Id: <199703242346.PAA20490@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/gen msgget.3 msgrcv.3 msgsnd.3 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/03/24 15:46:24 Branch: lib/libc/gen RELENG_2_2 Modified: lib/libc/gen msgget.3 msgrcv.3 msgsnd.3 Log: YAMFC: mdoc cleanup. Revision Changes Path 1.2.2.1 +16 -8 src/lib/libc/gen/msgget.3 1.2.2.2 +47 -21 src/lib/libc/gen/msgrcv.3 1.2.2.1 +28 -14 src/lib/libc/gen/msgsnd.3 From owner-cvs-lib Mon Mar 24 18:45:41 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id SAA03399 for cvs-lib-outgoing; Mon, 24 Mar 1997 18:45:41 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id SAA03387; Mon, 24 Mar 1997 18:45:37 -0800 (PST) Date: Mon, 24 Mar 1997 18:45:37 -0800 (PST) From: Mike Pritchard Message-Id: <199703250245.SAA03387@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/gen sleep.3 src/lib/libc/sys chmod.2 mmap.2 ptrace.2 rtprio.2 src/lib/libc/stdlib malloc.3 random.3 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/03/24 18:45:36 Branch: lib/libc/gen RELENG_2_2 lib/libc/stdlib RELENG_2_2 lib/libc/sys RELENG_2_2 Modified: lib/libc/gen sleep.3 lib/libc/stdlib malloc.3 random.3 lib/libc/sys chmod.2 mmap.2 ptrace.2 rtprio.2 Log: YAMFC: .Tn cleanup and other misc cleanup. Revision Changes Path 1.3.2.1 +3 -1 src/lib/libc/gen/sleep.3 1.6.2.1 +2 -2 src/lib/libc/stdlib/malloc.3 1.3.2.1 +3 -3 src/lib/libc/stdlib/random.3 1.3.2.4 +5 -3 src/lib/libc/sys/chmod.2 1.5.2.4 +12 -7 src/lib/libc/sys/mmap.2 1.5.2.3 +4 -2 src/lib/libc/sys/ptrace.2 1.5.2.2 +4 -2 src/lib/libc/sys/rtprio.2 From owner-cvs-lib Mon Mar 24 18:49:33 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id SAA03797 for cvs-lib-outgoing; Mon, 24 Mar 1997 18:49:33 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id SAA03785; Mon, 24 Mar 1997 18:49:31 -0800 (PST) Date: Mon, 24 Mar 1997 18:49:31 -0800 (PST) From: Mike Pritchard Message-Id: <199703250249.SAA03785@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/sys accept.2 connect.2 getsockname.2 socket.2 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/03/24 18:49:30 Branch: lib/libc/sys RELENG_2_2 Modified: lib/libc/sys accept.2 connect.2 getsockname.2 socket.2 Log: YAMFC: Xref getpeername. Revision Changes Path 1.3.2.1 +1 -0 src/lib/libc/sys/accept.2 1.3.2.3 +1 -0 src/lib/libc/sys/connect.2 1.4.2.2 +1 -0 src/lib/libc/sys/getsockname.2 1.3.2.2 +2 -1 src/lib/libc/sys/socket.2 From owner-cvs-lib Mon Mar 24 19:40:04 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id TAA08010 for cvs-lib-outgoing; Mon, 24 Mar 1997 19:40:04 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id TAA07953; Mon, 24 Mar 1997 19:39:58 -0800 (PST) Date: Mon, 24 Mar 1997 19:39:58 -0800 (PST) From: Mike Pritchard Message-Id: <199703250339.TAA07953@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/sys sigaction.2 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/03/24 19:39:57 Modified: lib/libc/sys sigaction.2 Log: Change the description of how attempts to block SIGKILL and SIGSTOP are handled. The system call will actually fail in this case - the system doesn't silently ignore the request. Closes PR# 3047 Pointed out by: fenner Revision Changes Path 1.12 +1 -1 src/lib/libc/sys/sigaction.2 From owner-cvs-lib Mon Mar 24 19:41:44 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id TAA08236 for cvs-lib-outgoing; Mon, 24 Mar 1997 19:41:44 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id TAA08216; Mon, 24 Mar 1997 19:41:41 -0800 (PST) Date: Mon, 24 Mar 1997 19:41:41 -0800 (PST) From: Mike Pritchard Message-Id: <199703250341.TAA08216@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/sys sigaction.2 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/03/24 19:41:39 Branch: lib/libc/sys RELENG_2_2 Modified: lib/libc/sys sigaction.2 Log: YAMFC: document function return type, tell how the system really works when attempts are made to block SIGKILL/SIGSTOP. Revision Changes Path 1.7.2.3 +2 -1 src/lib/libc/sys/sigaction.2 From owner-cvs-lib Mon Mar 24 20:32:15 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id UAA14887 for cvs-lib-outgoing; Mon, 24 Mar 1997 20:32:15 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id UAA14839; Mon, 24 Mar 1997 20:32:05 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id PAA11232; Tue, 25 Mar 1997 15:29:00 +1100 Date: Tue, 25 Mar 1997 15:29:00 +1100 From: Bruce Evans Message-Id: <199703250429.PAA11232@godzilla.zeta.org.au> To: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, mpp@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/sys sigaction.2 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Modified: lib/libc/sys sigaction.2 > Log: > Change the description of how attempts to block SIGKILL and SIGSTOP > are handled. The system call will actually fail in this case - the > system doesn't silently ignore the request. Closes PR# 3047 > > Pointed out by: fenner Actually, sigaction silently ignores attempts to set the SIGKILL and SIGSTOP bits in the signal mask. This behaviour is fully specified by POSIX. It only fails (in connection with SIGKILL and SIGSTOP) for attempts to set the sigaction handler for SIGKILL or SIGSTOP to anything other than SIG_DFL. (At least in 2.2 and -current. 2.1.x non-POSIXly rejects attempts to even read the sigaction for SIGKILL or SIGSTOP.) Bruce From owner-cvs-lib Mon Mar 24 21:34:46 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id VAA19603 for cvs-lib-outgoing; Mon, 24 Mar 1997 21:34:46 -0800 (PST) Received: (from imp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id VAA19561; Mon, 24 Mar 1997 21:34:43 -0800 (PST) Date: Mon, 24 Mar 1997 21:34:43 -0800 (PST) From: Warner Losh Message-Id: <199703250534.VAA19561@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/stdtime localtime.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk imp 97/03/24 21:34:39 Modified: lib/libc/stdtime localtime.c Log: Back out 1.14 until I reproduce trouble reports Revision Changes Path 1.15 +2 -4 src/lib/libc/stdtime/localtime.c From owner-cvs-lib Mon Mar 24 21:36:40 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id VAA19816 for cvs-lib-outgoing; Mon, 24 Mar 1997 21:36:40 -0800 (PST) Received: (from imp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id VAA19809; Mon, 24 Mar 1997 21:36:38 -0800 (PST) Date: Mon, 24 Mar 1997 21:36:38 -0800 (PST) From: Warner Losh Message-Id: <199703250536.VAA19809@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/nls msgcat.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk imp 97/03/24 21:36:38 Modified: lib/libc/nls msgcat.c Log: Restricting $LANG was a really bad idea Pointed out by: Everybody but Jordan. Revision Changes Path 1.9 +2 -4 src/lib/libc/nls/msgcat.c From owner-cvs-lib Mon Mar 24 21:44:29 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id VAA20242 for cvs-lib-outgoing; Mon, 24 Mar 1997 21:44:29 -0800 (PST) Received: from time.cdrom.com (root@time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id VAA20159; Mon, 24 Mar 1997 21:42:58 -0800 (PST) Received: from time.cdrom.com (jkh@localhost [127.0.0.1]) by time.cdrom.com (8.8.5/8.6.9) with ESMTP id VAA00593; Mon, 24 Mar 1997 21:42:56 -0800 (PST) To: Warner Losh cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/nls msgcat.c In-reply-to: Your message of "Mon, 24 Mar 1997 21:36:38 PST." <199703250536.VAA19809@freefall.freebsd.org> Date: Mon, 24 Mar 1997 21:42:56 -0800 Message-ID: <590.859268576@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Pointed out by: Everybody but Jordan. I was busy. :-) Jordan From owner-cvs-lib Tue Mar 25 09:28:32 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA24941 for cvs-lib-outgoing; Tue, 25 Mar 1997 09:28:32 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA24907; Tue, 25 Mar 1997 09:28:04 -0800 (PST) From: Mike Pritchard Message-Id: <199703251728.JAA24907@freefall.freebsd.org> Subject: Re: cvs commit: src/lib/libc/sys sigaction.2 To: bde@zeta.org.au (Bruce Evans) Date: Tue, 25 Mar 1997 09:28:03 -0800 (PST) Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-lib@freefall.freebsd.org In-Reply-To: <199703250429.PAA11232@godzilla.zeta.org.au> from "Bruce Evans" at Mar 25, 97 03:29:00 pm X-Mailer: ELM [version 2.4 PL24] Content-Type: text Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Bruce Evans wrote: > > > Modified: lib/libc/sys sigaction.2 > > Log: > > Change the description of how attempts to block SIGKILL and SIGSTOP > > are handled. The system call will actually fail in this case - the > > system doesn't silently ignore the request. Closes PR# 3047 > > > > Pointed out by: fenner > > Actually, sigaction silently ignores attempts to set the SIGKILL and > SIGSTOP bits in the signal mask. This behaviour is fully specified > by POSIX. > It only fails (in connection with SIGKILL and SIGSTOP) for attempts > to set the sigaction handler for SIGKILL or SIGSTOP to anything other > than SIG_DFL. (At least in 2.2 and -current. 2.1.x non-POSIXly rejects > attempts to even read the sigaction for SIGKILL or SIGSTOP.) Where does it do anything "silently" except for the case of SIG_DFL? -- Mike Pritchard mpp@FreeBSD.org "Go that way. Really fast. If something gets in your way, turn" From owner-cvs-lib Tue Mar 25 09:47:19 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA26648 for cvs-lib-outgoing; Tue, 25 Mar 1997 09:47:19 -0800 (PST) Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id JAA26612; Tue, 25 Mar 1997 09:46:47 -0800 (PST) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <15930(7)>; Tue, 25 Mar 1997 09:46:14 PST Received: from localhost by crevenia.parc.xerox.com with SMTP id <177486>; Tue, 25 Mar 1997 09:46:06 -0800 To: Mike Pritchard cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, freebsd-gnats-submit@freebsd.org, fenner@parc.xerox.com Subject: Re: docs/3047 & cvs commit: src/lib/libc/sys sigaction.2 In-reply-to: Your message of "Mon, 24 Mar 97 19:41:41 PST." <199703250341.TAA08216@freefall.freebsd.org> Date: Tue, 25 Mar 1997 09:45:58 PST From: Bill Fenner Message-Id: <97Mar25.094606pst.177486@crevenia.parc.xerox.com> Sender: owner-cvs-lib@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > Change the description of how attempts to block SIGKILL and SIGSTOP > are handled. The system call will actually fail in this case - the > system doesn't silently ignore the request. Closes PR# 3047 Um, if this is what you took from my wording then I did an even poorer job than the man page did. All I meant was that the antecedent of "This" in the second sentence of NOTE The mask specified in act is not allowed to block SIGKILL or SIGSTOP. This is done silently by the system. is potentially unclear. The first time I read this man page I thought the antecedent was "block SIGKILL [and] SIGSTOP", e.g. "the system silently blocks SIGKILL [and] SIGSTOP". The real meaning (and an alternative reading of the same sentence) is "the system silently ignores attempts to block SIGKILL or SIGSTOP"; I just wanted to make that sentence less ambiguous. Attempting to block SIGKILL and SIGSTOP is not an error and is silently ignored by the system. Everything else that the system call is attempting to do succeeds. (At least, this is what POSIX says, and this is what 2.2 does). (While writing my test program to make absolutely sure, I noticed that the first line should probably read "The mask specified in the sa_mask field" or something similar, too...) Bill From owner-cvs-lib Tue Mar 25 10:17:02 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA28546 for cvs-lib-outgoing; Tue, 25 Mar 1997 10:17:02 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA28396; Tue, 25 Mar 1997 10:15:59 -0800 (PST) From: Mike Pritchard Message-Id: <199703251815.KAA28396@freefall.freebsd.org> Subject: Re: docs/3047 & cvs commit: src/lib/libc/sys sigaction.2 To: fenner@parc.xerox.com (Bill Fenner) Date: Tue, 25 Mar 1997 10:15:58 -0800 (PST) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, freebsd-gnats-submit@freebsd.org, fenner@parc.xerox.com In-Reply-To: <97Mar25.094606pst.177486@crevenia.parc.xerox.com> from "Bill Fenner" at Mar 25, 97 09:45:58 am X-Mailer: ELM [version 2.4 PL24] Content-Type: text Sender: owner-cvs-lib@freebsd.org X-Loop: FreeBSD.org Precedence: bulk I see where I got confused. I looked at the code to sigaction, saw that it would return EINVAL if the signal nuber passed in tried to block these signals., but the statement in question refers to the mask, not the signal number. I'll go fix this and then go dig out my pointy hat :-). Bill Fenner wrote: > > > Change the description of how attempts to block SIGKILL and SIGSTOP > > are handled. The system call will actually fail in this case - the > > system doesn't silently ignore the request. Closes PR# 3047 > > Um, if this is what you took from my wording then I did an even poorer > job than the man page did. > > All I meant was that the antecedent of "This" in the second sentence > of > > NOTE > The mask specified in act is not allowed to block SIGKILL or SIGSTOP. > This is done silently by the system. > > is potentially unclear. The first time I read this man page I thought > the antecedent was "block SIGKILL [and] SIGSTOP", e.g. "the system > silently blocks SIGKILL [and] SIGSTOP". The real meaning (and an > alternative reading of the same sentence) is "the system silently > ignores attempts to block SIGKILL or SIGSTOP"; I just wanted to make > that sentence less ambiguous. > > Attempting to block SIGKILL and SIGSTOP is not an error and is silently > ignored by the system. Everything else that the system call is > attempting to do succeeds. (At least, this is what POSIX says, and > this is what 2.2 does). > > (While writing my test program to make absolutely sure, I noticed that the > first line should probably read "The mask specified in the sa_mask field" > or something similar, too...) > > Bill > -- Mike Pritchard mpp@FreeBSD.org "Go that way. Really fast. If something gets in your way, turn" From owner-cvs-lib Tue Mar 25 10:33:28 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA29527 for cvs-lib-outgoing; Tue, 25 Mar 1997 10:33:28 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA29520; Tue, 25 Mar 1997 10:33:26 -0800 (PST) Date: Tue, 25 Mar 1997 10:33:26 -0800 (PST) From: Mike Pritchard Message-Id: <199703251833.KAA29520@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/sys sigaction.2 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/03/25 10:33:25 Modified: lib/libc/sys sigaction.2 Log: Get my last commit right. The NOTE section now reads: The sa_mask field specified in act is not allowed to block SIGKILL or SIGSTOP. Any attempt to do so will be silently ignored. Now where did I leave that pointy hat... Revision Changes Path 1.13 +4 -2 src/lib/libc/sys/sigaction.2 From owner-cvs-lib Tue Mar 25 10:36:36 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA29651 for cvs-lib-outgoing; Tue, 25 Mar 1997 10:36:36 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA29644; Tue, 25 Mar 1997 10:36:34 -0800 (PST) Date: Tue, 25 Mar 1997 10:36:34 -0800 (PST) From: Mike Pritchard Message-Id: <199703251836.KAA29644@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/sys sigaction.2 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/03/25 10:36:34 Branch: lib/libc/sys RELENG_2_2 Modified: lib/libc/sys sigaction.2 Log: YAMFC: fix my last commit. Revision Changes Path 1.7.2.4 +4 -2 src/lib/libc/sys/sigaction.2 From owner-cvs-lib Tue Mar 25 15:29:19 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA20443 for cvs-lib-outgoing; Tue, 25 Mar 1997 15:29:19 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id PAA20431; Tue, 25 Mar 1997 15:29:14 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id KAA16383; Wed, 26 Mar 1997 10:27:23 +1100 Date: Wed, 26 Mar 1997 10:27:23 +1100 From: Bruce Evans Message-Id: <199703252327.KAA16383@godzilla.zeta.org.au> To: fenner@parc.xerox.com, mpp@freefall.freebsd.org Subject: Re: docs/3047 & cvs commit: src/lib/libc/sys sigaction.2 Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, freebsd-gnats-submit@freebsd.org Sender: owner-cvs-lib@freebsd.org X-Loop: FreeBSD.org Precedence: bulk >silently blocks SIGKILL [and] SIGSTOP". The real meaning (and an >alternative reading of the same sentence) is "the system silently >ignores attempts to block SIGKILL or SIGSTOP"; I just wanted to make >that sentence less ambiguous. Actually, it means "the system silently ignores attempts to set the SIGKILL and SIGSTOP bits in [the kernel's copy of] the signal mask. [This is different from setting the bits and ignoring them when a SIGKILL or SIGSTOP arrives, since the application can tell the difference by reading the kernel's copy of the signal mask. The copy of the mask for the first sigaction call is of course unaffected, since it is const.] >(While writing my test program to make absolutely sure, I noticed that the >first line should probably read "The mask specified in the sa_mask field" >or something similar, too...) Yes. POSIX says this better. Bruce From owner-cvs-lib Wed Mar 26 07:42:14 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA17127 for cvs-lib-outgoing; Wed, 26 Mar 1997 07:42:14 -0800 (PST) Received: (from davidn@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA17113; Wed, 26 Mar 1997 07:42:11 -0800 (PST) Date: Wed, 26 Mar 1997 07:42:11 -0800 (PST) From: David Nugent Message-Id: <199703261542.HAA17113@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/gen getpwent.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidn 97/03/26 07:42:11 Modified: lib/libc/gen getpwent.c Log: Remove minor warning (for -Wall -Wshadow); clarifies code. Revision Changes Path 1.40 +3 -3 src/lib/libc/gen/getpwent.c From owner-cvs-lib Wed Mar 26 19:09:07 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id TAA27865 for cvs-lib-outgoing; Wed, 26 Mar 1997 19:09:07 -0800 (PST) Received: from spinner.DIALix.COM (root@spinner.dialix.com [192.203.228.67]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id TAA27850; Wed, 26 Mar 1997 19:08:57 -0800 (PST) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.5/8.8.5) with ESMTP id LAA04021; Thu, 27 Mar 1997 11:08:18 +0800 (WST) Message-Id: <199703270308.LAA04021@spinner.DIALix.COM> X-Mailer: exmh version 2.0gamma 1/27/96 To: Bill Fenner cc: ache@nagual.ru, imp@village.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c In-reply-to: Your message of "Mon, 24 Mar 1997 09:48:30 PST." <97Mar24.094840pst.177486@crevenia.parc.xerox.com> Date: Thu, 27 Mar 1997 11:08:18 +0800 From: Peter Wemm Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Bill Fenner wrote: > I think a lot would be solved by having a library function like > access() that also accepts a UID. Then the don't-let-people-access- > files-in-a-setuid-program-that-they-wouldn't-normally-have-access-to > problem, instead of being solved in N different setuid programs, > could be solved once. This is one of the things that Linux uses setfsuid() for BTW. the fs (filesystem) id's normally shadow the effective at all times, except when explicitly set by setfs[ug]id. > Bill Cheers, -Peter From owner-cvs-lib Wed Mar 26 19:13:29 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id TAA28111 for cvs-lib-outgoing; Wed, 26 Mar 1997 19:13:29 -0800 (PST) Received: from spinner.DIALix.COM (root@spinner.dialix.com [192.203.228.67]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id TAA28099; Wed, 26 Mar 1997 19:13:11 -0800 (PST) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.5/8.8.5) with ESMTP id LAA04087; Thu, 27 Mar 1997 11:12:08 +0800 (WST) Message-Id: <199703270312.LAA04087@spinner.DIALix.COM> X-Mailer: exmh version 2.0gamma 1/27/96 To: Poul-Henning Kamp cc: Bill Fenner , ache@nagual.ru, imp@village.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c In-reply-to: Your message of "Mon, 24 Mar 1997 19:17:22 +0100." <228.859227442@critter> Date: Thu, 27 Mar 1997 11:12:08 +0800 From: Peter Wemm Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Poul-Henning Kamp wrote: > In message <97Mar24.094840pst.177486@crevenia.parc.xerox.com>, Bill Fenner wr it > es: > >I think a lot would be solved by having a library function like > >access() that also accepts a UID. Then the don't-let-people-access- > >files-in-a-setuid-program-that-they-wouldn't-normally-have-access-to > >problem, instead of being solved in N different setuid programs, > >could be solved once. > > Well, access_as(2) alone will not do it, you would need a open_as(2), > unlink_as(2), rename_as(2) and so on... Err, yeah. I knew that.. :-) Please ignore my previous simplistic reply about access. :-). With setfsuid() etc in a setuid process, you'd do this: setfsuid(getuid()); fd = open(..) setfsuid(geteuid()); And similar for daemons that are running as root but want to access files as a user, eg: ftpd. It works for open, unlink, rename, link, chmod, etc etc, the entire set of VFS syscalls. Cheers, -Peter From owner-cvs-lib Wed Mar 26 20:00:51 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id UAA01371 for cvs-lib-outgoing; Wed, 26 Mar 1997 20:00:51 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id UAA01355; Wed, 26 Mar 1997 20:00:43 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id OAA06953; Thu, 27 Mar 1997 14:50:32 +1100 Date: Thu, 27 Mar 1997 14:50:32 +1100 From: Bruce Evans Message-Id: <199703270350.OAA06953@godzilla.zeta.org.au> To: peter@spinner.dialix.com, phk@critter.dk.tfs.com Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c Cc: ache@nagual.ru, cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, fenner@parc.xerox.com, imp@village.org Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> Well, access_as(2) alone will not do it, you would need a open_as(2), >> unlink_as(2), rename_as(2) and so on... > >Err, yeah. I knew that.. :-) Please ignore my previous simplistic reply >about access. :-). With setfsuid() etc in a setuid process, you'd do >this: > >setfsuid(getuid()); >fd = open(..) >setfsuid(geteuid()); You could also add warnings: warning: this program uses access(), which is unsafe. access() would be unsafer than now, since the effective fs uuid would be more variable. And while we're here: warning: this program uses tmpfile(), which is unsafe. warning: this program uses tmpnam(), which is unsafe. warning: this program uses tempnam(), which is unsafe. warning: this program uses mktemp(), which is unsafe. warning: this program uses mkstemp(), which is yet another wrong interface (it should allow setting the open mode). Bruce From owner-cvs-lib Wed Mar 26 20:22:40 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id UAA02615 for cvs-lib-outgoing; Wed, 26 Mar 1997 20:22:40 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id UAA02478; Wed, 26 Mar 1997 20:20:41 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 1.60 #1) id 0wA6fS-0006QQ-00; Wed, 26 Mar 1997 21:20:02 -0700 To: Bruce Evans Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c Cc: peter@spinner.dialix.com, phk@critter.dk.tfs.com, ache@nagual.ru, cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, fenner@parc.xerox.com In-reply-to: Your message of "Thu, 27 Mar 1997 14:50:32 +1100." <199703270350.OAA06953@godzilla.zeta.org.au> References: <199703270350.OAA06953@godzilla.zeta.org.au> Date: Wed, 26 Mar 1997 21:20:02 -0700 From: Warner Losh Message-Id: Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message <199703270350.OAA06953@godzilla.zeta.org.au> Bruce Evans writes: : You could also add warnings: : : warning: this program uses access(), which is unsafe. : : access() would be unsafer than now, since the effective fs uuid would be : more variable. : : And while we're here: : : warning: this program uses tmpfile(), which is unsafe. : warning: this program uses tmpnam(), which is unsafe. : warning: this program uses tempnam(), which is unsafe. : warning: this program uses mktemp(), which is unsafe. Funny you should mention that. I have that on my list. : warning: this program uses mkstemp(), which is yet another wrong : interface (it should allow setting the open mode). Can you explain this to me? Warner From owner-cvs-lib Wed Mar 26 20:28:11 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id UAA03062 for cvs-lib-outgoing; Wed, 26 Mar 1997 20:28:11 -0800 (PST) Received: from spinner.DIALix.COM (root@spinner.dialix.com [192.203.228.67]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id UAA03005; Wed, 26 Mar 1997 20:27:57 -0800 (PST) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.5/8.8.5) with ESMTP id MAA04679; Thu, 27 Mar 1997 12:27:09 +0800 (WST) Message-Id: <199703270427.MAA04679@spinner.DIALix.COM> X-Mailer: exmh version 2.0gamma 1/27/96 To: Warner Losh cc: Bruce Evans , phk@critter.dk.tfs.com, ache@nagual.ru, cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, fenner@parc.xerox.com Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c In-reply-to: Your message of "Wed, 26 Mar 1997 21:20:02 MST." Date: Thu, 27 Mar 1997 12:27:09 +0800 From: Peter Wemm Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Warner Losh wrote: > In message <199703270350.OAA06953@godzilla.zeta.org.au> Bruce Evans writes: > : warning: this program uses mkstemp(), which is yet another wrong > : interface (it should allow setting the open mode). > > Can you explain this to me? Hmm. Why so Bruce? It creates the file mode 0600, which is quite safe. If you want to allow 3rd party access, you can always: fd = mkstemp(...); fchmod(fd, ....); > Warner Cheers, -Peter From owner-cvs-lib Wed Mar 26 20:53:47 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id UAA04141 for cvs-lib-outgoing; Wed, 26 Mar 1997 20:53:47 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id UAA04133; Wed, 26 Mar 1997 20:53:40 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id PAA09716; Thu, 27 Mar 1997 15:45:40 +1100 Date: Thu, 27 Mar 1997 15:45:40 +1100 From: Bruce Evans Message-Id: <199703270445.PAA09716@godzilla.zeta.org.au> To: bde@zeta.org.au, imp@village.org Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c Cc: ache@nagual.ru, cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, fenner@parc.xerox.com, peter@spinner.dialix.com, phk@critter.dk.tfs.com Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >: warning: this program uses mkstemp(), which is yet another wrong >: interface (it should allow setting the open mode). > >Can you explain this to me? It always opens the file in O_RDWR mode, so callers have to do extra syscalls if they want to make the file write-only, etc. Also, in cases where the temporary file will be moved to become a non-temporary file, it is good to create the file on the same file system as the final file so that it can be moved atomically. There is no support for locating a temporary directory on a specified file system. Bruce From owner-cvs-lib Wed Mar 26 21:02:19 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id VAA04346 for cvs-lib-outgoing; Wed, 26 Mar 1997 21:02:19 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id VAA04341; Wed, 26 Mar 1997 21:02:13 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id QAA10260; Thu, 27 Mar 1997 16:00:16 +1100 Date: Thu, 27 Mar 1997 16:00:16 +1100 From: Bruce Evans Message-Id: <199703270500.QAA10260@godzilla.zeta.org.au> To: imp@village.org, peter@spinner.dialix.com Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c Cc: ache@nagual.ru, bde@zeta.org.au, cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, fenner@parc.xerox.com, phk@critter.dk.tfs.com Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> : warning: this program uses mkstemp(), which is yet another wrong >> : interface (it should allow setting the open mode). >> >> Can you explain this to me? > >Hmm. Why so Bruce? It creates the file mode 0600, which is quite safe. >If you want to allow 3rd party access, you can always: > fd = mkstemp(...); > fchmod(fd, ....); 1. It's non-atomic (though safe if the creator can be trusted). 2. Callers have to do more work, and may forget. E.g., in recent changes, the fd was write-only, but became read-write. This is probably safe in recent changes, but isn't always safe. BTW, mode w+ in fopen.3 is misformatted. Bruce From owner-cvs-lib Thu Mar 27 00:42:32 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id AAA14247 for cvs-lib-outgoing; Thu, 27 Mar 1997 00:42:32 -0800 (PST) Received: from critter.dk.tfs.com ([140.145.230.252]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id AAA14194; Thu, 27 Mar 1997 00:42:17 -0800 (PST) Received: from critter (localhost [127.0.0.1]) by critter.dk.tfs.com (8.8.5/8.8.5) with ESMTP id IAA13764; Thu, 27 Mar 1997 08:16:57 +0100 (CET) To: Peter Wemm cc: Bill Fenner , ache@nagual.ru, imp@village.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libtermcap pathnames.h termcap.c In-reply-to: Your message of "Thu, 27 Mar 1997 11:12:08 +0800." <199703270312.LAA04087@spinner.DIALix.COM> Date: Thu, 27 Mar 1997 08:16:57 +0100 Message-ID: <13762.859447017@critter> From: Poul-Henning Kamp Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message <199703270312.LAA04087@spinner.DIALix.COM>, Peter Wemm writes: >Poul-Henning Kamp wrote: >> In message <97Mar24.094840pst.177486@crevenia.parc.xerox.com>, Bill Fenner w >r > it >> es: >> >I think a lot would be solved by having a library function like >> >access() that also accepts a UID. Then the don't-let-people-access- >> >files-in-a-setuid-program-that-they-wouldn't-normally-have-access-to >> >problem, instead of being solved in N different setuid programs, >> >could be solved once. >> >> Well, access_as(2) alone will not do it, you would need a open_as(2), >> unlink_as(2), rename_as(2) and so on... > >Err, yeah. I knew that.. :-) Please ignore my previous simplistic reply >about access. :-). With setfsuid() etc in a setuid process, you'd do >this: > >setfsuid(getuid()); >fd = open(..) >setfsuid(geteuid()); > >And similar for daemons that are running as root but want to access files >as a user, eg: ftpd. It works for open, unlink, rename, link, chmod, etc >etc, the entire set of VFS syscalls. It sounds to me like adding [gs]etfs[ug]id(2) might be a worthwhile addtion to our arsenal of protections... -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@tfs.com TRW Financial Systems, Inc. Power and ignorance is a disgusting cocktail. From owner-cvs-lib Thu Mar 27 10:08:36 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA05163 for cvs-lib-outgoing; Thu, 27 Mar 1997 10:08:36 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA05149; Thu, 27 Mar 1997 10:08:31 -0800 (PST) Date: Thu, 27 Mar 1997 10:08:31 -0800 (PST) From: Mike Pritchard Message-Id: <199703271808.KAA05149@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/stdio fopen.3 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/03/27 10:08:29 Modified: lib/libc/stdio fopen.3 Log: The w+ entry description was misformatted. Pointed out by: bde Revision Changes Path 1.3 +1 -1 src/lib/libc/stdio/fopen.3 From owner-cvs-lib Thu Mar 27 10:10:33 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA05467 for cvs-lib-outgoing; Thu, 27 Mar 1997 10:10:33 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA05448; Thu, 27 Mar 1997 10:10:27 -0800 (PST) Date: Thu, 27 Mar 1997 10:10:27 -0800 (PST) From: Mike Pritchard Message-Id: <199703271810.KAA05448@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/stdio fopen.3 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/03/27 10:10:25 Branch: lib/libc/stdio RELENG_2_2 Modified: lib/libc/stdio fopen.3 Log: YAMFC: fix w+ entry. Revision Changes Path 1.2.2.1 +1 -1 src/lib/libc/stdio/fopen.3 From owner-cvs-lib Fri Mar 28 04:27:45 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA08480 for cvs-lib-outgoing; Fri, 28 Mar 1997 04:27:45 -0800 (PST) Received: (from bde@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA08471; Fri, 28 Mar 1997 04:27:43 -0800 (PST) Date: Fri, 28 Mar 1997 04:27:43 -0800 (PST) From: Bruce Evans Message-Id: <199703281227.EAA08471@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/sys getdirentries.2 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 97/03/28 04:27:43 Modified: lib/libc/sys getdirentries.2 Log: Fixed #includes in synopsis to compile. Fixed #includes in synopsis to declare the prototype in the synopsis. Fixed stale types in description of struct dirent. Revision Changes Path 1.7 +7 -6 src/lib/libc/sys/getdirentries.2 From owner-cvs-lib Sat Mar 29 09:42:36 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA04419 for cvs-lib-outgoing; Sat, 29 Mar 1997 09:42:36 -0800 (PST) Received: (from jdp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA04411; Sat, 29 Mar 1997 09:42:34 -0800 (PST) Date: Sat, 29 Mar 1997 09:42:34 -0800 (PST) From: John Polstra Message-Id: <199703291742.JAA04411@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libmytinfo defs.h Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jdp 97/03/29 09:42:33 Modified: lib/libmytinfo defs.h Log: Remove conflicting declaration of sys_errlist, which caused make world breakage. Revision Changes Path 1.2 +0 -3 src/lib/libmytinfo/defs.h From owner-cvs-lib Sat Mar 29 11:44:17 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id LAA08591 for cvs-lib-outgoing; Sat, 29 Mar 1997 11:44:17 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id LAA08584; Sat, 29 Mar 1997 11:44:16 -0800 (PST) Date: Sat, 29 Mar 1997 11:44:16 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703291944.LAA08584@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libcompat Makefile Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/29 11:44:15 Modified: lib/libcompat Makefile Log: Remove orand* compatibility as promised (next release) Revision Changes Path 1.13 +1 -5 src/lib/libcompat/Makefile From owner-cvs-lib Sat Mar 29 11:45:09 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id LAA08666 for cvs-lib-outgoing; Sat, 29 Mar 1997 11:45:09 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id LAA08659; Sat, 29 Mar 1997 11:45:08 -0800 (PST) Date: Sat, 29 Mar 1997 11:45:08 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703291945.LAA08659@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libcompat Makefile Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/29 11:45:08 Modified: lib/libcompat Makefile Log: Remove unneded define from CFLAGS (from orand* compatibility) Revision Changes Path 1.14 +1 -1 src/lib/libcompat/Makefile From owner-cvs-lib Sat Mar 29 11:55:08 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id LAA09514 for cvs-lib-outgoing; Sat, 29 Mar 1997 11:55:08 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id LAA09507; Sat, 29 Mar 1997 11:55:05 -0800 (PST) Date: Sat, 29 Mar 1997 11:55:05 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703291955.LAA09507@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/stdlib random.3 random.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/29 11:55:05 Modified: lib/libc/stdlib random.3 random.c Log: Remove orand* code as promised for the next release Revision Changes Path 1.7 +1 -12 src/lib/libc/stdlib/random.3 1.8 +3 -8 src/lib/libc/stdlib/random.c