From owner-cvs-lib Sun Jun 15 11:25:44 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id LAA20048 for cvs-lib-outgoing; Sun, 15 Jun 1997 11:25:44 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id LAA19933; Sun, 15 Jun 1997 11:24:00 -0700 (PDT) From: "Andrey A. Chernov" Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id LAA06825; Sun, 15 Jun 1997 11:23:19 -0700 (PDT) Date: Sun, 15 Jun 1997 11:23:19 -0700 (PDT) Message-Id: <199706151823.LAA06825@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc/stdlib random.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 1997/06/15 11:23:19 PDT Modified files: lib/libc/stdlib random.c Log: srandomdev: use stack junk value in the fallback code too Revision Changes Path 1.10 +3 -2 src/lib/libc/stdlib/random.c From owner-cvs-lib Sun Jun 15 14:06:17 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id OAA25962 for cvs-lib-outgoing; Sun, 15 Jun 1997 14:06:17 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id OAA25885; Sun, 15 Jun 1997 14:04:15 -0700 (PDT) From: Bill Paul Received: (from wpaul@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id OAA07177; Sun, 15 Jun 1997 14:03:34 -0700 (PDT) Date: Sun, 15 Jun 1997 14:03:34 -0700 (PDT) Message-Id: <199706152103.OAA07177@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc/rpc auth_time.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk wpaul 1997/06/15 14:03:33 PDT Modified files: lib/libc/rpc auth_time.c Log: Remember to zero sockaddr_in struct before calling uaddr_to_sockaddr() to populate it. Not doing this can result in a garbage sockaddr_in, which will cause connect() to block inside clnttcp_create(). Revision Changes Path 1.2 +1 -0 src/lib/libc/rpc/auth_time.c From owner-cvs-lib Mon Jun 16 16:40:45 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id QAA09179 for cvs-lib-outgoing; Mon, 16 Jun 1997 16:40:45 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id QAA09032; Mon, 16 Jun 1997 16:38:52 -0700 (PDT) From: David Nugent Received: (from davidn@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id QAA16714; Mon, 16 Jun 1997 16:38:01 -0700 (PDT) Date: Mon, 16 Jun 1997 16:38:01 -0700 (PDT) Message-Id: <199706162338.QAA16714@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libutil login_ok.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidn 1997/06/16 16:38:01 PDT Modified files: lib/libutil login_ok.c Log: Fix infinite loop. PR: 3878 Submitted by: roman@rpd.univ.kiev.ua Revision Changes Path 1.5 +2 -2 src/lib/libutil/login_ok.c From owner-cvs-lib Mon Jun 16 16:44:21 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id QAA09340 for cvs-lib-outgoing; Mon, 16 Jun 1997 16:44:21 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id QAA09244; Mon, 16 Jun 1997 16:42:46 -0700 (PDT) From: David Nugent Received: (from davidn@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id QAA16812; Mon, 16 Jun 1997 16:41:55 -0700 (PDT) Date: Mon, 16 Jun 1997 16:41:55 -0700 (PDT) Message-Id: <199706162341.QAA16812@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libutil login_ok.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidn 1997/06/16 16:41:55 PDT Modified files: (Branch: RELENG_2_2) lib/libutil login_ok.c Log: MFC: fix infinite loop. PR: 3878 Reviewed by: roman@rpd.univ.kiev.ua Revision Changes Path 1.4.2.1 +2 -2 src/lib/libutil/login_ok.c From owner-cvs-lib Tue Jun 17 23:27:58 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id XAA01162 for cvs-lib-outgoing; Tue, 17 Jun 1997 23:27:58 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id XAA01099; Tue, 17 Jun 1997 23:26:19 -0700 (PDT) From: Philippe Charnier Received: (from charnier@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id XAA04681; Tue, 17 Jun 1997 23:26:13 -0700 (PDT) Date: Tue, 17 Jun 1997 23:26:13 -0700 (PDT) Message-Id: <199706180626.XAA04681@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc/net gethostbyname.3 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk charnier 1997/06/17 23:26:13 PDT Modified files: lib/libc/net gethostbyname.3 Log: Typo. Revision Changes Path 1.8 +3 -2 src/lib/libc/net/gethostbyname.3 From owner-cvs-lib Wed Jun 18 21:39:38 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id VAA05129 for cvs-lib-outgoing; Wed, 18 Jun 1997 21:39:38 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id VAA05107; Wed, 18 Jun 1997 21:39:20 -0700 (PDT) From: "Andrey A. Chernov" Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id VAA11254; Wed, 18 Jun 1997 21:39:06 -0700 (PDT) Date: Wed, 18 Jun 1997 21:39:06 -0700 (PDT) Message-Id: <199706190439.VAA11254@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc/net res_comp.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 1997/06/18 21:39:06 PDT Modified files: (Branch: RELENG_2_2) lib/libc/net res_comp.c Log: Merge MAXHOSTNAMELEN check and other changes from -current Revision Changes Path 1.7.2.1 +10 -3 src/lib/libc/net/res_comp.c From owner-cvs-lib Fri Jun 20 10:56:14 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id KAA15351 for cvs-lib-outgoing; Fri, 20 Jun 1997 10:56:14 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA15238; Fri, 20 Jun 1997 10:54:39 -0700 (PDT) From: Bill Paul Received: (from wpaul@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA25600; Fri, 20 Jun 1997 10:54:12 -0700 (PDT) Date: Fri, 20 Jun 1997 10:54:12 -0700 (PDT) Message-Id: <199706201754.KAA25600@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc/rpc get_myaddress.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk wpaul 1997/06/20 10:54:12 PDT Modified files: lib/libc/rpc get_myaddress.c Log: Hm... wonder how long this has been here. The logic in get_myaddress() is broken: it always returns the loopback address due to the following rule: if ((ifreq.ifr_flags & IFF_UP) && ifr->ifr_addr.sa_family == AF_INET && (loopback == 1 && (ifreq.ifr_flags & IFF_LOOPBACK))) { The idea is that we want to select the interface address only if it's up and it's in the AF_INET family. If it turns uout we don't have such an interface available, we make a second pass through the loop, this time settling for the loopback interface. But the logic inadvertently locks out all cases when loopback == 0, so nothing is ever selected until the second pass (when loopback == 1). This is changed to: if (((ifreq.ifr_flags & IFF_UP) && ifr->ifr_addr.sa_family == AF_INET) || (loopback == 1 && (ifreq.ifr_flags & IFF_LOOPBACK))) { which I think does the right thing. This is yet another bogon I discovered during NIS+ testing; I need get_myaddress() to work correctly so that the callback code in the client library will work. Revision Changes Path 1.12 +3 -3 src/lib/libc/rpc/get_myaddress.c From owner-cvs-lib Fri Jun 20 17:16:18 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id RAA04055 for cvs-lib-outgoing; Fri, 20 Jun 1997 17:16:18 -0700 (PDT) Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93]) by hub.freebsd.org (8.8.5/8.8.5) with SMTP id RAA04012; Fri, 20 Jun 1997 17:16:04 -0700 (PDT) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <17932(1)>; Fri, 20 Jun 1997 17:15:32 PDT Received: from localhost by crevenia.parc.xerox.com with SMTP id <177512>; Fri, 20 Jun 1997 17:15:22 -0700 To: Bill Paul cc: cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-lib@freebsd.org Subject: Re: cvs commit: src/lib/libc/rpc get_myaddress.c In-reply-to: Your message of "Fri, 20 Jun 97 10:54:12 PDT." <199706201754.KAA25600@freefall.freebsd.org> Date: Fri, 20 Jun 1997 17:15:13 PDT From: Bill Fenner Message-Id: <97Jun20.171522pdt.177512@crevenia.parc.xerox.com> Sender: owner-cvs-lib@freebsd.org X-Loop: FreeBSD.org Precedence: bulk Bill Paul wrote: > if (((ifreq.ifr_flags & IFF_UP) && > ifr->ifr_addr.sa_family == AF_INET) || > (loopback == 1 && (ifreq.ifr_flags & IFF_LOOPBACK))) { > > which I think does the right thing. No, you want to avoid the loopback interface completely on your first pass, right? (it's got an AF_INET address). You probably want something like if ((((ifreq.ifr_flags & (IFF_UP|IFF_LOOPBACK)) == IFF_UP) && ... Bill