From owner-freebsd-arch Sun Mar 17 8:42: 0 2002 Delivered-To: freebsd-arch@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 821) id EFF0E37B43D; Sun, 17 Mar 2002 08:41:53 -0800 (PST) Date: Sun, 17 Mar 2002 08:41:53 -0800 From: John De Boskey To: Arch List Subject: ftpd ESTALE recovery patch Message-ID: <20020317084153.A3942@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, In a busy cluster, a generated file being handed out by ftp is failing due to an ESTALE condition. The following patch fixes the problem. Failure to open the file is also logged when -l is specified twice (see ftpd(8)). We've been running this for some time and I'd like to get it committed. Comments? Thanks! John http://people.freebsd.org/~jwd/ftpd.estale.patch Index: ftpd.c =================================================================== RCS file: /home/ncvs/src/libexec/ftpd/ftpd.c,v retrieving revision 1.99 diff -u -r1.99 ftpd.c --- ftpd.c 25 Feb 2002 16:39:34 -0000 1.99 +++ ftpd.c 3 Mar 2002 13:25:00 -0000 @@ -1478,7 +1478,15 @@ time_t start; if (cmd == 0) { - fin = fopen(name, "r"), closefunc = fclose; + int try = 0; + while ((fin = fopen(name,"r")) == NULL && errno == ESTALE && try < 3 ) { + sleep(++try); + if (logging > 1) + syslog(LOG_INFO,"get fopen(\"%s\"): %m: attempting retry",name); + } + if (fin == NULL && logging > 1) + syslog(LOG_INFO,"get fopen(\"%s\"): %m",name); + closefunc = fclose; st.st_size = 0; } else { char line[BUFSIZ]; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sun Mar 17 8:55: 7 2002 Delivered-To: freebsd-arch@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 81AAA37B41A; Sun, 17 Mar 2002 08:55:05 -0800 (PST) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g2HGt5lv011121; Sun, 17 Mar 2002 08:55:05 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g2HGroFl011079; Sun, 17 Mar 2002 08:53:50 -0800 (PST) Date: Sun, 17 Mar 2002 08:53:50 -0800 From: "David O'Brien" To: John De Boskey Cc: Arch List Subject: Re: ftpd ESTALE recovery patch Message-ID: <20020317085350.E10393@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <20020317084153.A3942@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020317084153.A3942@FreeBSD.org>; from jwd@FreeBSD.org on Sun, Mar 17, 2002 at 08:41:53AM -0800 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Mar 17, 2002 at 08:41:53AM -0800, John De Boskey wrote: > In a busy cluster, a generated file being handed out by > ftp is failing due to an ESTALE condition. The following > patch fixes the problem. Failure to open the file is also > logged when -l is specified twice (see ftpd(8)). This really does seem like a specific problem of your environment; and this patch is something that really only scratches an itch of yours due to how you've setup your environment. It sounds like you need to copy the generated file to a place it will remain thru out the ftp session. I do not think the patch should go in. And why `3' tries? Why not `10', etc. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sun Mar 17 9:44:54 2002 Delivered-To: freebsd-arch@freebsd.org Received: from bsdone.bsdwins.com (www.bsdwins.com [192.58.184.33]) by hub.freebsd.org (Postfix) with ESMTP id 190AD37B43D; Sun, 17 Mar 2002 09:44:52 -0800 (PST) Received: (from jwd@localhost) by bsdone.bsdwins.com (8.11.6/8.11.0) id g2HHipo08019; Sun, 17 Mar 2002 12:44:51 -0500 (EST) (envelope-from jwd) Date: Sun, 17 Mar 2002 12:44:51 -0500 From: John De Boskey To: "David O'Brien" Cc: Arch List Subject: Re: ftpd ESTALE recovery patch Message-ID: <20020317124451.A7636@bsdwins.com> References: <20020317084153.A3942@FreeBSD.org> <20020317085350.E10393@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020317085350.E10393@dragon.nuxi.com>; from obrien@FreeBSD.ORG on Sun, Mar 17, 2002 at 08:53:50AM -0800 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG ----- David O'Brien's Original Message ----- > On Sun, Mar 17, 2002 at 08:41:53AM -0800, John De Boskey wrote: > > In a busy cluster, a generated file being handed out by > > ftp is failing due to an ESTALE condition. The following > > patch fixes the problem. Failure to open the file is also > > logged when -l is specified twice (see ftpd(8)). > > This really does seem like a specific problem of your environment; and > this patch is something that really only scratches an itch of yours due > to how you've setup your environment. I'm sorry, but I have to disagree. ESTALE is an errno that indicates that an application can retry an operation with success. > It sounds like you need to copy the generated file to a place it will > remain thru out the ftp session. I am not sure I understand what you are trying to say. The target file to be transfered has already been stored in it's permanent location. However, it takes a small finite amount of time for NFS to propogate the information for the (new/replaced) file. Our clusters are able to attempt access during that short time at which point the process fails without the patch. > I do not think the patch should go in. And why `3' tries? Why not `10', > etc. If you can provide a better loop/timeout mechanism, I will be glad to review and incorporate it. Thanks! John http://people.freebsd.org/~jwd/ftpd.estale.patch To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sun Mar 17 10:11:11 2002 Delivered-To: freebsd-arch@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 4A22337B444; Sun, 17 Mar 2002 10:11:09 -0800 (PST) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g2HIB9lv011797; Sun, 17 Mar 2002 10:11:09 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g2HI9sjH011764; Sun, 17 Mar 2002 10:09:54 -0800 (PST) Date: Sun, 17 Mar 2002 10:09:53 -0800 From: "David O'Brien" To: John De Boskey Cc: Arch List Subject: Re: ftpd ESTALE recovery patch Message-ID: <20020317100953.A11577@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG References: <20020317084153.A3942@FreeBSD.org> <20020317085350.E10393@dragon.nuxi.com> <20020317124451.A7636@bsdwins.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020317124451.A7636@bsdwins.com>; from jwd@FreeBSD.ORG on Sun, Mar 17, 2002 at 12:44:51PM -0500 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Mar 17, 2002 at 12:44:51PM -0500, John De Boskey wrote: > ----- David O'Brien's Original Message ----- > > On Sun, Mar 17, 2002 at 08:41:53AM -0800, John De Boskey wrote: > > > In a busy cluster, a generated file being handed out by > > > ftp is failing due to an ESTALE condition. The following > > > patch fixes the problem. Failure to open the file is also > > > logged when -l is specified twice (see ftpd(8)). > > > > This really does seem like a specific problem of your environment; and > > this patch is something that really only scratches an itch of yours due > > to how you've setup your environment. > > I'm sorry, but I have to disagree. ESTALE is an errno that indicates > that an application can retry an operation with success. Then why does so little of our applications do anything when errno == ESTALE? tcsh, sendmail, mail, amd, tcpdump, perl, and kerberosIV. Tcsh just exits, so does mail. sendmail treats it as a permanent failure. Tcpdump's usage of ESTALE is just to to be able to printout more information about a sniffed packet. Perl just passes ESTALE to running scripts. kerberosIV treats it the same as ENOENT. > If you can provide a better loop/timeout mechanism, I will be glad > to review and incorporate it. It should not be committed until there is a more consistent handling of it in of it in the /usr/src rather than just committing it peice meal to only ftpd. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sun Mar 17 10:57:19 2002 Delivered-To: freebsd-arch@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 2A64B37B47D; Sun, 17 Mar 2002 10:57:17 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 2932E5347; Sun, 17 Mar 2002 19:57:14 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: John De Boskey Cc: Arch List Subject: Re: ftpd ESTALE recovery patch References: <20020317084153.A3942@FreeBSD.org> From: Dag-Erling Smorgrav Date: 17 Mar 2002 19:57:13 +0100 In-Reply-To: <20020317084153.A3942@FreeBSD.org> Message-ID: Lines: 14 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG John De Boskey writes: > In a busy cluster, a generated file being handed out by > ftp is failing due to an ESTALE condition. The following > patch fixes the problem. Failure to open the file is also > logged when -l is specified twice (see ftpd(8)). I don't see the point of this. The problem you are experiencing is probably caused by invalid assumptions in your setup, though I can't comment further without more details about what, exactly, you are trying to do. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sun Mar 17 12:37: 6 2002 Delivered-To: freebsd-arch@freebsd.org Received: from bsdone.bsdwins.com (www.bsdwins.com [192.58.184.33]) by hub.freebsd.org (Postfix) with ESMTP id B09C137B404 for ; Sun, 17 Mar 2002 12:36:59 -0800 (PST) Received: (from jwd@localhost) by bsdone.bsdwins.com (8.11.6/8.11.0) id g2HKauU09320; Sun, 17 Mar 2002 15:36:56 -0500 (EST) (envelope-from jwd) Date: Sun, 17 Mar 2002 15:36:56 -0500 From: John De Boskey To: Dag-Erling Smorgrav Cc: Arch List Subject: Re: ftpd ESTALE recovery patch Message-ID: <20020317153656.A9003@bsdwins.com> References: <20020317084153.A3942@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from des@ofug.org on Sun, Mar 17, 2002 at 07:57:13PM +0100 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG ----- Dag-Erling Smorgrav's Original Message ----- > John De Boskey writes: > > In a busy cluster, a generated file being handed out by > > ftp is failing due to an ESTALE condition. The following > > patch fixes the problem. Failure to open the file is also > > logged when -l is specified twice (see ftpd(8)). > > I don't see the point of this. The problem you are experiencing is > probably caused by invalid assumptions in your setup, though I can't I understand your comment, though I have to disagree with it. > comment further without more details about what, exactly, you are > trying to do. Here's a timeline: T(0) - On machine A - create new file in /tmp (/tmp/file) T(1) - On machine A - cp newfile nfsserver:/path/file.new T(2) - On machine A - mv nfsserver:/path/file.new nfsserver:/path/file T(3) - On machine B - ftp connection received get nfsserver:/path/file (get fails randomly without patch) where Time(3) is guarenteed to be greater than Time(4), though the delta between them can be approaching (but not equal to) zero. Basically, we have work nodes 1 through 28, using 2 netapp fileservers for data storage. As we continue to increase the throughput capabilities of the system, the ESTALE return happens more consistently. Ftpd is not the 1st tool we've had to fix. I hope the above helps explain in more detail the issue at hand. Thanks! John To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sun Mar 17 13:37: 2 2002 Delivered-To: freebsd-arch@freebsd.org Received: from dan.emsphone.com (dan.emsphone.com [199.67.51.101]) by hub.freebsd.org (Postfix) with ESMTP id EAF8337B404; Sun, 17 Mar 2002 13:36:58 -0800 (PST) Received: from dan.emsphone.com (dan@localhost [127.0.0.1]) by dan.emsphone.com (8.12.2/8.12.2) with ESMTP id g2HLavph074648; Sun, 17 Mar 2002 15:36:58 -0600 (CST) (envelope-from dan@dan.emsphone.com) Received: (from dan@localhost) by dan.emsphone.com (8.12.2/8.12.2/Submit) id g2HLau11074640; Sun, 17 Mar 2002 15:36:56 -0600 (CST) Date: Sun, 17 Mar 2002 15:36:56 -0600 From: Dan Nelson To: John De Boskey Cc: Dag-Erling Smorgrav , Arch List Subject: Re: ftpd ESTALE recovery patch Message-ID: <20020317213656.GC32545@dan.emsphone.com> References: <20020317084153.A3942@FreeBSD.org> <20020317153656.A9003@bsdwins.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020317153656.A9003@bsdwins.com> User-Agent: Mutt/1.3.27i X-OS: FreeBSD 5.0-CURRENT X-message-flag: Outlook Error Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In the last episode (Mar 17), John De Boskey said: > ----- Dag-Erling Smorgrav's Original Message ----- > > John De Boskey writes: > > > In a busy cluster, a generated file being handed out by ftp is > > > failing due to an ESTALE condition. The following patch fixes the > > > problem. Failure to open the file is also logged when -l is > > > specified twice (see ftpd(8)). > > > > I don't see the point of this. The problem you are experiencing is > > probably caused by invalid assumptions in your setup, though I > > can't comment further without more details about what, exactly, you > > are trying to do. > > Here's a timeline: > > T(0) - On machine A - create new file in /tmp (/tmp/file) > T(1) - On machine A - cp newfile nfsserver:/path/file.new > T(2) - On machine A - mv nfsserver:/path/file.new nfsserver:/path/file > T(3) - On machine B - ftp connection received > get nfsserver:/path/file > (get fails randomly without patch) > > where Time(3) is guarenteed to be greater than Time(4), though > the delta between them can be approaching (but not equal to) > zero. You mean T(2) and T(3), right? > Basically, we have work nodes 1 through 28, using 2 netapp > fileservers for data storage. As we continue to increase the > throughput capabilities of the system, the ESTALE return happens > more consistently. Ftpd is not the 1st tool we've had to fix. Sounds like we've got a bug in either the NFS client or the server, then. When B opens the file, it is already in its final position on the server (at least it should be - is 'mv' a synchronous operation when using NFSv3?), so there should be no stale NFS info. What happens if you sysctl vfs.nfs.access_cache_timeout=0 on the client ? -- Dan Nelson dnelson@allantgroup.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sun Mar 17 17:32:32 2002 Delivered-To: freebsd-arch@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 62A3D37B400 for ; Sun, 17 Mar 2002 17:32:27 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 5E3975346; Mon, 18 Mar 2002 02:32:24 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: arch@freebsd.org Subject: bsd.lib.mk modifications From: Dag-Erling Smorgrav Date: 18 Mar 2002 02:32:23 +0100 Message-ID: Lines: 24 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --=-=-= The attached patch changes the following in bsd.lib.mk: - add an INCSUBDIR variable so that libraries that install their headers in a subdirectory of /usr/include don't have to override the beforeinstall target. - make ${INCS} a prerequisite of _includeinstall so generated headers will be built in time for beforeinstall (again, to avoid overriding beforeinstall). - install static libraries with -C, like headers, since it is common for programs and libraries to depend on them. I haven't put this through buildworld yet, but I'm reasonably confident it'll pass the test. Comments? Objections? DES -- Dag-Erling Smorgrav - des@ofug.org --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=incsubdir.diff Index: bsd.lib.mk =================================================================== RCS file: /home/ncvs/src/share/mk/bsd.lib.mk,v retrieving revision 1.103 diff -u -r1.103 bsd.lib.mk --- bsd.lib.mk 12 Mar 2002 01:18:07 -0000 1.103 +++ bsd.lib.mk 18 Mar 2002 01:15:27 -0000 @@ -261,12 +261,12 @@ beforeinstall: _includeinstall .endif -_includeinstall: +_includeinstall: ${INCS} .if defined(INCS) .for header in ${INCS} cd ${.CURDIR} && \ ${INSTALL} -C -o ${INCOWN} -g ${INCGRP} -m ${INCMODE} \ - ${header} ${DESTDIR}${INCDIR} + ${header} ${DESTDIR}${INCDIR}/${INCSUBDIR} .endfor .endif @@ -286,7 +286,7 @@ realinstall: beforeinstall .if !defined(INTERNALLIB) - ${INSTALL} ${COPY} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \ + ${INSTALL} -C -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \ ${_INSTALLFLAGS} lib${LIB}.a ${DESTDIR}${LIBDIR} .if !defined(NOPROFILE) ${INSTALL} ${COPY} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \ --=-=-=-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sun Mar 17 23: 7:16 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id BADC637B400 for ; Sun, 17 Mar 2002 23:07:12 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id SAA27356; Mon, 18 Mar 2002 18:07:06 +1100 Date: Mon, 18 Mar 2002 18:07:07 +1100 (EST) From: Bruce Evans X-X-Sender: To: Dag-Erling Smorgrav Cc: Subject: Re: bsd.lib.mk modifications In-Reply-To: Message-ID: <20020318174634.D670-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 18 Mar 2002, Dag-Erling Smorgrav wrote: > The attached patch changes the following in bsd.lib.mk: > > - add an INCSUBDIR variable so that libraries that install their > headers in a subdirectory of /usr/include don't have to override > the beforeinstall target. Why not just set INCDIR? I think the most useful meaning for INCDIR is "the (single) directory in which the current set of includes is installed", not "the root of the include tree (default /usr/include)" although the comment in bsd.own.mk suggests the latter meaning. > - make ${INCS} a prerequisite of _includeinstall so generated headers > will be built in time for beforeinstall (again, to avoid overriding > beforeinstall). This may result in the headers being built at install time. Not good. libss (when it existed) showed how to do this better. It had a `hdrs' target which built the headers. src/Makefile.inc1 invoked hdrs before beforeinstall to get the headers built before installing them. > - install static libraries with -C, like headers, since it is common > for programs and libraries to depend on them. OK. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sun Mar 17 23:21:19 2002 Delivered-To: freebsd-arch@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id A715037B440 for ; Sun, 17 Mar 2002 23:20:30 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 9AA495346; Mon, 18 Mar 2002 08:20:28 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Bruce Evans Cc: Subject: Re: bsd.lib.mk modifications References: <20020318174634.D670-100000@gamplex.bde.org> From: Dag-Erling Smorgrav Date: 18 Mar 2002 08:20:27 +0100 In-Reply-To: <20020318174634.D670-100000@gamplex.bde.org> Message-ID: Lines: 54 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bruce Evans writes: > Why not just set INCDIR? I think the most useful meaning for INCDIR is > "the (single) directory in which the current set of includes is installed", > not "the root of the include tree (default /usr/include)" although the > comment in bsd.own.mk suggests the latter meaning. Ah, I interpreted it as the latter. Also, using a separate INCSUBDIR allows the admin to set INCDIR to whatever he wants and still get things "right" (assuming he also patched gcc to look for headers in INCDIR); it just seemed cleaner to do it this way. > > - make ${INCS} a prerequisite of _includeinstall so generated headers > > will be built in time for beforeinstall (again, to avoid overriding > > beforeinstall). > This may result in the headers being built at install time. Well, they should already exist at install time; the problem I'm trying to solve is making sure they exist at 'make includes' time during buildworld. I now use this: @@ -282,13 +282,17 @@ beforeinstall: _includeinstall .endif -_includeinstall: +_includeinstall: ${INCS} .if defined(INCS) .for header in ${INCS} +.if exists(${.OBJDIR}/${header}) + ${INSTALL} -C -o ${INCOWN} -g ${INCGRP} -m ${INCMODE} \ + ${.OBJDIR}/${header} ${DESTDIR}${INCDIR}/${INCSUBDIR} +.else cd ${.CURDIR} && \ ${INSTALL} -C -o ${INCOWN} -g ${INCGRP} -m ${INCMODE} \ - ${header} ${DESTDIR}${INCDIR} - + ${header} ${DESTDIR}${INCDIR}/${INCSUBDIR} +.endif .endfor .endif in an attempt to handle the case where we actually install generated headers. The only case I know of so far is libcrypto, which modifies some headers at build time to remove potentially-legally-troublesome IDEA code, and overrides beforeinstall to deal with this. I'm trying to make the default beforeinstall target smart enough that it doesn't need so much overriding. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Mon Mar 18 8: 3:43 2002 Delivered-To: freebsd-arch@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 4B65B37B404; Mon, 18 Mar 2002 08:03:36 -0800 (PST) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.6) with SMTP id g2IG3Zk26681; Mon, 18 Mar 2002 11:03:35 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Mon, 18 Mar 2002 11:03:34 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: John De Boskey Cc: Arch List Subject: Re: ftpd ESTALE recovery patch In-Reply-To: <20020317084153.A3942@FreeBSD.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 17 Mar 2002, John De Boskey wrote: > In a busy cluster, a generated file being handed out by ftp is > failing due to an ESTALE condition. The following patch fixes the > problem. Failure to open the file is also logged when -l is specified > twice (see ftpd(8)). Generally speaking, ESTALE means the file you're trying to access no longer exists (stale file handle). This occurs in NFS unlike local filesystems due to last-close-removes semantics, as opposed to remove-revokes-access semantics. This is a fatal error condition, not a transient one--by definition, the file you get on a retry will be a different file than the one you started accessing before. It may be that the higher level stream abstractions experience ESTALE more often during open than the lower level fd abstractions as they may generate more NFS RPCs during the open phase, increasing the window for file deletion during open. I would have thought that for large files, you'd be much more likely to get them later, where ESTALE would mean you couldn't consistently return the file contents through a retry, I'm a little surprised you catch so many in open (a very small file?) Reasonable work-arounds include: (1) Copying the file to the client (guarantee that ESTALE can't happen during the transfer itself) (2) Preserve the file for a window on the server, by renaming using rename() in the same directory/file system, so that ESTALE is less likely if the transfer happens in an expected amount of time. NFS file handles persist across server renames assuming they are on the same file system. This accepts the reality of ESTALE but reduces the cost of implementing the feature by constraining the change to the server. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Mon Mar 18 13:34: 2 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 9DDCC37B41A for ; Mon, 18 Mar 2002 13:33:54 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id IAA25935; Tue, 19 Mar 2002 08:33:47 +1100 Date: Tue, 19 Mar 2002 08:33:50 +1100 (EST) From: Bruce Evans X-X-Sender: To: Dag-Erling Smorgrav Cc: Subject: Re: bsd.lib.mk modifications In-Reply-To: Message-ID: <20020319080926.C2957-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 18 Mar 2002, Dag-Erling Smorgrav wrote: > Bruce Evans writes: > > Why not just set INCDIR? I think the most useful meaning for INCDIR is > > "the (single) directory in which the current set of includes is installed", > > not "the root of the include tree (default /usr/include)" although the > > comment in bsd.own.mk suggests the latter meaning. > > Ah, I interpreted it as the latter. Also, using a separate INCSUBDIR > allows the admin to set INCDIR to whatever he wants and still get > things "right" (assuming he also patched gcc to look for headers in > INCDIR); it just seemed cleaner to do it this way. Well, we only have one other example of FOOSUBDIR (MANSUBDIR), and supporting and using it (correctly) always seemed to be harder than changing the "base" to me. This may be because when you want special subdirs, you often want more than one, in a file-specific way. > > > - make ${INCS} a prerequisite of _includeinstall so generated headers > > > will be built in time for beforeinstall (again, to avoid overriding > > > beforeinstall). > > This may result in the headers being built at install time. > > Well, they should already exist at install time; the problem I'm > trying to solve is making sure they exist at 'make includes' time > during buildworld. This was handled for libss by building them for 'make includes' but not for any other install step. > I now use this: > > @@ -282,13 +282,17 @@ > beforeinstall: _includeinstall > .endif > > -_includeinstall: > +_includeinstall: ${INCS} I think any dependency here causes problems. > in an attempt to handle the case where we actually install generated > headers. The only case I know of so far is libcrypto, which modifies > some headers at build time to remove potentially-legally-troublesome > IDEA code, and overrides beforeinstall to deal with this. I'm trying > to make the default beforeinstall target smart enough that it doesn't > need so much overriding. libcrypto is already broken if it changes the object directory at install time (this breaks installing from read-only mounts of the object directory) ... its current beforeinstall target is obviously broken in theory, since it begins with beforeinstall: openssl/opensslconf.h openssl/evp.h This should cause rebuilding of these headers in the openssl subdir of the obj directory if the sources are newer. I think it does. The dependencies for all the other headers in openssl are broken (nonexistent), but not the dependencies for these. All the other headers get built as a side effect of building opensslconf.h. This breaks "make depend; make" after a source update, unless opensslconf.h has changed or the obj directory or openssl subdir is deleted. Thanks for cleaning up this Makefile :-). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Mon Mar 18 15:14: 6 2002 Delivered-To: freebsd-arch@freebsd.org Received: from beastie.mckusick.com (beastie.mckusick.com [209.31.233.184]) by hub.freebsd.org (Postfix) with ESMTP id 28AFD37B400 for ; Mon, 18 Mar 2002 15:14:03 -0800 (PST) Received: from beastie.mckusick.com (localhost [127.0.0.1]) by beastie.mckusick.com (8.11.4/8.9.3) with ESMTP id g2INE2a01358 for ; Mon, 18 Mar 2002 15:14:02 -0800 (PST) (envelope-from mckusick@beastie.mckusick.com) Message-Id: <200203182314.g2INE2a01358@beastie.mckusick.com> To: arch@freebsd.org Subject: __P(()) Macro Date: Mon, 18 Mar 2002 15:14:02 -0800 From: Kirk McKusick Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG OpenBSD has completed the cleanup of the __P(()) macro. While we have agreed in principle to do the same, I note many instances of __P(()) still exist. Hopefully someone will take the bull by the horns and grunt through this task. Kirk McKusick ------- Forwarded Message Date: Mon, 18 Mar 2002 15:56:24 -0700 From: "Todd C. Miller" To: Kirk McKusick Subject: Re: __P(()) Macro Just FYI, OpenBSD 3.1 will ship with __P stuff removed. The macro is still defined for compatibility but nothing uses it besides 3rd party code. - todd ------- End of Forwarded Message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Mon Mar 18 15:23:26 2002 Delivered-To: freebsd-arch@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 4A83537B405 for ; Mon, 18 Mar 2002 15:23:17 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id C71315346; Tue, 19 Mar 2002 00:23:15 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Bruce Evans Cc: Subject: Re: bsd.lib.mk modifications References: <20020319080926.C2957-100000@gamplex.bde.org> From: Dag-Erling Smorgrav Date: 19 Mar 2002 00:23:14 +0100 In-Reply-To: <20020319080926.C2957-100000@gamplex.bde.org> Message-ID: Lines: 19 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bruce Evans writes: > libcrypto is already broken if it changes the object directory at > install time (this breaks installing from read-only mounts of the > object directory) ... its current beforeinstall target is obviously > broken in theory, since it begins with > > beforeinstall: openssl/opensslconf.h openssl/evp.h > > This should cause rebuilding of these headers in the openssl subdir > of the obj directory if the sources are newer. I think it does. Yes, I'm trying to get rid of that... the first step is to move these two headers out of the openssl subdirectory, since make(1) has trouble understanding dependencies and targets that involve subdirectories. This breaks some non-buildword scenarii, though. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Mon Mar 18 15:27:39 2002 Delivered-To: freebsd-arch@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id B1E4637B400 for ; Mon, 18 Mar 2002 15:27:35 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 429575346; Tue, 19 Mar 2002 00:27:34 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Kirk McKusick Cc: arch@freebsd.org Subject: Re: __P(()) Macro References: <200203182314.g2INE2a01358@beastie.mckusick.com> From: Dag-Erling Smorgrav Date: 19 Mar 2002 00:27:33 +0100 In-Reply-To: <200203182314.g2INE2a01358@beastie.mckusick.com> Message-ID: Lines: 14 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Kirk McKusick writes: > OpenBSD has completed the cleanup of the __P(()) macro. > While we have agreed in principle to do the same, I note > many instances of __P(()) still exist. Hopefully someone > will take the bull by the horns and grunt through this task. % current -w __P | grep -v contrib | wc 16963 119390 1257088 That is one hell of a bull. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Mon Mar 18 21:33:13 2002 Delivered-To: freebsd-arch@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 3ABFF37B400 for ; Mon, 18 Mar 2002 21:33:11 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g2J5X9i66739; Mon, 18 Mar 2002 22:33:10 -0700 (MST) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g2J5X9L99089; Mon, 18 Mar 2002 22:33:09 -0700 (MST) (envelope-from imp@village.org) Date: Mon, 18 Mar 2002 22:32:58 -0700 (MST) Message-Id: <20020318.223258.36900350.imp@village.org> To: mckusick@mckusick.com Cc: arch@FreeBSD.ORG Subject: Re: __P(()) Macro From: "M. Warner Losh" In-Reply-To: <200203182314.g2INE2a01358@beastie.mckusick.com> References: <200203182314.g2INE2a01358@beastie.mckusick.com> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <200203182314.g2INE2a01358@beastie.mckusick.com> Kirk McKusick writes: : OpenBSD has completed the cleanup of the __P(()) macro. : While we have agreed in principle to do the same, I note : many instances of __P(()) still exist. Hopefully someone : will take the bull by the horns and grunt through this task. We're working on it too. I've been told to stay out of the kernel for a while to avoid distrbing WIP, so I'm plowing through userland right now. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Tue Mar 19 1:45:29 2002 Delivered-To: freebsd-arch@freebsd.org Received: from alcanet.com.au (mail2.alcanet.com.au [203.62.196.17]) by hub.freebsd.org (Postfix) with ESMTP id C4C2F37B405 for ; Tue, 19 Mar 2002 01:45:25 -0800 (PST) Received: from mfg1.cim.alcatel.com.au (IDENT:root@localhost.localdomain [127.0.0.1]) by alcanet.com.au (8.12.1/8.12.1/Alcanet1.2) with ESMTP id g2J9irIR020975; Tue, 19 Mar 2002 20:44:54 +1100 Received: from gsmx07.alcatel.com.au by cim.alcatel.com.au (PMDF V5.2-32 #37641) with ESMTP id <01KFK3TE6RGWVFP7CW@cim.alcatel.com.au>; Tue, 19 Mar 2002 20:44:45 +1100 Received: (from jeremyp@localhost) by gsmx07.alcatel.com.au (8.11.6/8.11.6) id g2J9ii246085; Tue, 19 Mar 2002 20:44:44 +1100 Content-return: prohibited Date: Tue, 19 Mar 2002 20:44:44 +1100 From: Peter Jeremy Subject: Re: proposition for new socket syscalls {send,recv}fromto In-reply-to: <3C800A80.96CEA9D2@caldera.com>; from sergey@caldera.com on Fri, Mar 01, 2002 at 06:10:56PM -0500 To: Sergey Babkin Cc: arch@FreeBSD.ORG, chawla@caldera.com Mail-Followup-To: Sergey Babkin , arch@FreeBSD.ORG, chawla@caldera.com Message-id: <20020319204443.A46069@gsmx07.alcatel.com.au> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline User-Agent: Mutt/1.2.5i References: <3C800A80.96CEA9D2@caldera.com> Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG [Catching up on old mail] On Fri, Mar 01, 2002 at 06:10:56PM -0500, Sergey Babkin wrote: >In the high-availability clusters it's convenient and typical to assign >an IP address to a logical server (or service). This logical server >may be moved between the physical hosts as neccessary (for example, >if a physical host fails or needs to be shut down for maintenance). >So this addres gets added to an interface of the current physical >host as an alias. Here comes the bad part: this alias happens to be >on the same subnet as the primary address of this interface, and this >may cause a confusion about the source address of the packets coming out >of this host. You might like to look at how (eg) Compaq handles this. I've used TruCluster on Tru64 4.0D/4.0F - it uses this approach and basically ignores the ensuing problems :-(. The clustering code in Tru64 5.x (which I haven't used yet) may do a better job. > But for the UDP servers (for example, tftp or BIND) >there is an issue: This can also affect things like CORBA and FTP where there are multiple TCP connections with the server either setting up or specifying how to set up the secondary connections. I've also had problems convincing SAMBA to behave the way I want it to. >How can we fix this situation ? Everything would become a lot simpler >if we have the calls: > >ssize_t >recvfromto(int s, void *buf, size_t len, int flags, > struct sockaddr *from, int *fromlen, > struct sockaddr *to, int *tolen) ... >ssize_t >sendfromto(int s, void *buf, size_t len, int flags, > const struct sockaddr *from, int fromlen, > const struct sockaddr *to, int tolen) Other than using 'socklen_t *' instead of 'int *' for the former, these look like a good idea. They appear to be easy to use and easy/cheap to implement. Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Tue Mar 19 13:42:50 2002 Delivered-To: freebsd-arch@freebsd.org Received: from gull.prod.itd.earthlink.net (gull.mail.pas.earthlink.net [207.217.120.84]) by hub.freebsd.org (Postfix) with ESMTP id AF1BE37B433 for ; Tue, 19 Mar 2002 13:42:29 -0800 (PST) Received: from pool0205.cvx21-bradley.dialup.earthlink.net ([209.179.192.205] helo=mindspring.com) by gull.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16nRND-00015v-00; Tue, 19 Mar 2002 13:42:28 -0800 Message-ID: <3C97B0B1.BF6AFBCA@mindspring.com> Date: Tue, 19 Mar 2002 13:42:09 -0800 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Kirk McKusick Cc: arch@freebsd.org Subject: Re: __P(()) Macro References: <200203182314.g2INE2a01358@beastie.mckusick.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Kirk McKusick wrote: > OpenBSD has completed the cleanup of the __P(()) macro. > While we have agreed in principle to do the same, I note > many instances of __P(()) still exist. Hopefully someone > will take the bull by the horns and grunt through this task. > > Kirk McKusick I assume that only someone with -current sources could do this? I.e. the delta is only applicable against -current, not -stable, so it will be a 5.0 thing, not a 4.6 thing? -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Tue Mar 19 14:19:58 2002 Delivered-To: freebsd-arch@freebsd.org Received: from beastie.mckusick.com (beastie.mckusick.com [209.31.233.184]) by hub.freebsd.org (Postfix) with ESMTP id 8295B37B400 for ; Tue, 19 Mar 2002 14:19:13 -0800 (PST) Received: from beastie.mckusick.com (localhost [127.0.0.1]) by beastie.mckusick.com (8.11.6/8.11.6) with ESMTP id g2JMDmC00899; Tue, 19 Mar 2002 22:13:48 GMT (envelope-from mckusick@beastie.mckusick.com) Message-Id: <200203192213.g2JMDmC00899@beastie.mckusick.com> To: Terry Lambert Subject: Re: __P(()) Macro Cc: arch@freebsd.org In-Reply-To: Your message of "Tue, 19 Mar 2002 13:42:09 PST." <3C97B0B1.BF6AFBCA@mindspring.com> Date: Tue, 19 Mar 2002 14:13:48 -0800 From: Kirk McKusick Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Date: Tue, 19 Mar 2002 13:42:09 -0800 From: Terry Lambert To: Kirk McKusick CC: arch@freebsd.org Subject: Re: __P(()) Macro Kirk McKusick wrote: > OpenBSD has completed the cleanup of the __P(()) macro. > While we have agreed in principle to do the same, I note > many instances of __P(()) still exist. Hopefully someone > will take the bull by the horns and grunt through this task. > > Kirk McKusick I assume that only someone with -current sources could do this? I.e. the delta is only applicable against -current, not -stable, so it will be a 5.0 thing, not a 4.6 thing? -- Terry It would be my assumption that this would only happen in the 5.0 tree. Kirk To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Tue Mar 19 14:21:27 2002 Delivered-To: freebsd-arch@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id A0C6E37B405 for ; Tue, 19 Mar 2002 14:21:16 -0800 (PST) Received: by elvis.mu.org (Postfix, from userid 1192) id 7A304AE216; Tue, 19 Mar 2002 14:21:16 -0800 (PST) Date: Tue, 19 Mar 2002 14:21:16 -0800 From: Alfred Perlstein To: Kirk McKusick Cc: Terry Lambert , arch@freebsd.org Subject: Re: __P(()) Macro Message-ID: <20020319222116.GV455@elvis.mu.org> References: <3C97B0B1.BF6AFBCA@mindspring.com> <200203192213.g2JMDmC00899@beastie.mckusick.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200203192213.g2JMDmC00899@beastie.mckusick.com> User-Agent: Mutt/1.3.27i Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Kirk McKusick [020319 14:20] wrote: > Date: Tue, 19 Mar 2002 13:42:09 -0800 > From: Terry Lambert > To: Kirk McKusick > CC: arch@freebsd.org > Subject: Re: __P(()) Macro > > Kirk McKusick wrote: > > OpenBSD has completed the cleanup of the __P(()) macro. > > While we have agreed in principle to do the same, I note > > many instances of __P(()) still exist. Hopefully someone > > will take the bull by the horns and grunt through this task. > > > > Kirk McKusick > > I assume that only someone with -current sources could do > this? I.e. the delta is only applicable against -current, > not -stable, so it will be a 5.0 thing, not a 4.6 thing? > > -- Terry > > It would be my assumption that this would only happen in the > 5.0 tree. I'm making the sweep through the kernel now, may I touch ufs/ffs or would that hinder your current devel? -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Tue Mar 19 14:23:22 2002 Delivered-To: freebsd-arch@freebsd.org Received: from beastie.mckusick.com (beastie.mckusick.com [209.31.233.184]) by hub.freebsd.org (Postfix) with ESMTP id 739ED37B402 for ; Tue, 19 Mar 2002 14:23:10 -0800 (PST) Received: from beastie.mckusick.com (localhost [127.0.0.1]) by beastie.mckusick.com (8.11.6/8.11.6) with ESMTP id g2JMHkC00969; Tue, 19 Mar 2002 22:17:46 GMT (envelope-from mckusick@beastie.mckusick.com) Message-Id: <200203192217.g2JMHkC00969@beastie.mckusick.com> To: Alfred Perlstein Subject: Re: __P(()) Macro Cc: arch@freebsd.org In-Reply-To: Your message of "Tue, 19 Mar 2002 14:21:16 PST." <20020319222116.GV455@elvis.mu.org> Date: Tue, 19 Mar 2002 14:17:46 -0800 From: Kirk McKusick Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Date: Tue, 19 Mar 2002 14:21:16 -0800 From: Alfred Perlstein To: Kirk McKusick Cc: Terry Lambert , arch@freebsd.org Subject: Re: __P(()) Macro * Kirk McKusick [020319 14:20] wrote: > Date: Tue, 19 Mar 2002 13:42:09 -0800 > From: Terry Lambert > To: Kirk McKusick > CC: arch@freebsd.org > Subject: Re: __P(()) Macro > > Kirk McKusick wrote: > > OpenBSD has completed the cleanup of the __P(()) macro. > > While we have agreed in principle to do the same, I note > > many instances of __P(()) still exist. Hopefully someone > > will take the bull by the horns and grunt through this task. > > > > Kirk McKusick > > I assume that only someone with -current sources could do > this? I.e. the delta is only applicable against -current, > not -stable, so it will be a 5.0 thing, not a 4.6 thing? > > -- Terry > > It would be my assumption that this would only happen in the > 5.0 tree. I'm making the sweep through the kernel now, may I touch ufs/ffs or would that hinder your current devel? -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ You may do ufs/*. I can handle the change. ~Kirk To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Wed Mar 20 13:40:40 2002 Delivered-To: freebsd-arch@freebsd.org Received: from rwcrmhc52.attbi.com (rwcrmhc52.attbi.com [216.148.227.88]) by hub.freebsd.org (Postfix) with ESMTP id 2451137B429 for ; Wed, 20 Mar 2002 13:40:09 -0800 (PST) Received: from InterJet.elischer.org ([12.232.206.8]) by rwcrmhc52.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020320214007.JYAJ1147.rwcrmhc52.attbi.com@InterJet.elischer.org>; Wed, 20 Mar 2002 21:40:07 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id NAA12938; Wed, 20 Mar 2002 13:31:36 -0800 (PST) Date: Wed, 20 Mar 2002 13:31:35 -0800 (PST) From: Julian Elischer To: Poul-Henning Kamp Cc: arch@freebsd.org Subject: Re: UFS2, GEOM & DARPA - don't get all excited, OK ? In-Reply-To: <13286.1016656684@critter.freebsd.dk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG One thing to look at: Inode in dirent allocation.. there was a Usenix paper on this .. It made a huge performance difference in some cases.. on the first link (one link to file only), you stash the inode info into the dir. On creation of a 2nd link you actually allocate an inode. -------In the 1997 Usenix technical conference proceedings:---------- "Embedded inodes and Explicit Grouping: Exploiting Disk bandwidth for small files" Gregory R Ganger, M.Frans Kaashoek. MIT ----------------------------- This paper actually describes several improvements to FFS, including the one I mentionned above. Kirk of course knows about this, but it should be compatible with Greg's soft-updates work, and would be very cool to have.. All the work for the paper was done for FFS under OpenBSD so it should be directly relevent. (It would be interesting to ask Greg if we would be interested at all in participating in an FFS rewrite because he's only second to Kirk on the topic, even if only on a consultation basis) On Wed, 20 Mar 2002, Poul-Henning Kamp wrote: [NON-Text Body part not included] To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Wed Mar 20 14:48:30 2002 Delivered-To: freebsd-arch@freebsd.org Received: from gull.prod.itd.earthlink.net (gull.mail.pas.earthlink.net [207.217.120.84]) by hub.freebsd.org (Postfix) with ESMTP id 07E8337B41F for ; Wed, 20 Mar 2002 14:48:03 -0800 (PST) Received: from pool0107.cvx21-bradley.dialup.earthlink.net ([209.179.192.107] helo=mindspring.com) by gull.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16nos9-0000zE-00; Wed, 20 Mar 2002 14:47:58 -0800 Message-ID: <3C991186.545ED996@mindspring.com> Date: Wed, 20 Mar 2002 14:47:34 -0800 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Julian Elischer Cc: Poul-Henning Kamp , arch@freebsd.org Subject: Re: UFS2, GEOM & DARPA - don't get all excited, OK ? References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Julian Elischer wrote: > One thing to look at: > Inode in dirent allocation.. > > there was a Usenix paper on this .. > It made a huge performance difference in some cases.. Microsoft has an approach simialt to this. The call it "The FAT Filesystem". 8-) 8-). -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Wed Mar 20 16: 0:31 2002 Delivered-To: freebsd-arch@freebsd.org Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38]) by hub.freebsd.org (Postfix) with ESMTP id D99DE37B41B for ; Wed, 20 Mar 2002 16:00:17 -0800 (PST) Received: from InterJet.elischer.org ([12.232.206.8]) by rwcrmhc51.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020321000017.DTA2626.rwcrmhc51.attbi.com@InterJet.elischer.org>; Thu, 21 Mar 2002 00:00:17 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id PAA13517; Wed, 20 Mar 2002 15:57:11 -0800 (PST) Date: Wed, 20 Mar 2002 15:57:11 -0800 (PST) From: Julian Elischer To: Terry Lambert Cc: Poul-Henning Kamp , arch@freebsd.org Subject: Re: UFS2, GEOM & DARPA - don't get all excited, OK ? In-Reply-To: <3C991186.545ED996@mindspring.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG haha read the papaer. http://www.pdos.lcs.mit.edu/pubs.html under "Storage management" On Wed, 20 Mar 2002, Terry Lambert wrote: > Julian Elischer wrote: > > One thing to look at: > > Inode in dirent allocation.. > > > > there was a Usenix paper on this .. > > It made a huge performance difference in some cases.. > > Microsoft has an approach simialt to this. > > The call it "The FAT Filesystem". > > 8-) 8-). > > -- Terry > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Wed Mar 20 16:37:41 2002 Delivered-To: freebsd-arch@freebsd.org Received: from albatross.prod.itd.earthlink.net (albatross.mail.pas.earthlink.net [207.217.120.120]) by hub.freebsd.org (Postfix) with ESMTP id 882BA37B41A for ; Wed, 20 Mar 2002 16:37:36 -0800 (PST) Received: from pool0083.cvx22-bradley.dialup.earthlink.net ([209.179.198.83] helo=mindspring.com) by albatross.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16nqaB-0004MU-00; Wed, 20 Mar 2002 16:37:31 -0800 Message-ID: <3C992B35.37349A85@mindspring.com> Date: Wed, 20 Mar 2002 16:37:09 -0800 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Julian Elischer Cc: Poul-Henning Kamp , arch@freebsd.org Subject: Re: UFS2, GEOM & DARPA - don't get all excited, OK ? References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Julian Elischer wrote: > On Wed, 20 Mar 2002, Terry Lambert wrote: > > Julian Elischer wrote: > > > One thing to look at: > > > Inode in dirent allocation.. > > > > > > there was a Usenix paper on this .. > > > It made a huge performance difference in some cases.. > > > > Microsoft has an approach simialt to this. > > > > The call it "The FAT Filesystem". > > > > 8-) 8-). > > haha > > read the papaer. > > http://www.pdos.lcs.mit.edu/pubs.html > > under "Storage management" Haha. Personally, I prefer PDF: http://citeseer.nj.nec.com/ganger97embedded.html Also, read the earlier paper about the same thing: http://www.usenix.org/publications/library/proceedings/sf94/forin.html It's well known that making the directory entry into the inode works really well, particularly when you handicap the caching (as they did in the earlier MACH paper, in an apparent attempt to make their numbers better). You can get the same improvement in FFS by faulting in the inodes when you do a directory traversal, so that when you go to open/stat the inodes, they are already in core. This was one of the basis of the paper that I, Ed Lane, and Bryan Cardoza weren't allowed to present in 1994 because of the USL lawsuit, after the USL acquisition by Novell. You can also get a big improvement by returning stat information each time it is changed, and with "open" and other calls, particularly when you are implementing a file system server. Also, one of the earliest technical discussions we had on FS issues at Whistle dealt with actually allocating reference nodes for hard links, which, among other things, results in a different vnode per reference path, which has the effect of making parent pointers reliable (e.g. "fdgetpath()" can be made to work). If you look at the MD-DOS MACH FS paper from 1194, their assumptions are obviously the wrong things to do: they had to slow down FFS for their MS-DOS FS to beat it, including caching all the FAT blocks in core. It's pretty trivial to get a locality based cache of directory and inode blocks in the FFS case, as well, to get similar performance. Actually, this approach should be obvious from the NetWare NWFS approach in Native NetWare, which has a RAM requirement proportional to the disk size for mounts because the directory structure is cached in core in its entirety. Right now, FreeBSD does somewhat the wrong thing, in not resulting in pages being faulted in when a non-blocking availability check occurs (e.g. a check on something that will not block if the data is not available, but triggers a prefetch). The FreeBSD non-blocking I/O implementation actually suffers because of this, since you really want unavailable disk data to result in a fault and a conversion, rather than blocking. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Wed Mar 20 22: 0:38 2002 Delivered-To: freebsd-arch@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id C6B7737B400 for ; Wed, 20 Mar 2002 22:00:34 -0800 (PST) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.2/8.12.2) with ESMTP id g2L60G0M021332; Thu, 21 Mar 2002 07:00:16 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Julian Elischer Cc: arch@freebsd.org Subject: Re: UFS2, GEOM & DARPA - don't get all excited, OK ? In-Reply-To: Your message of "Wed, 20 Mar 2002 13:31:35 PST." Date: Thu, 21 Mar 2002 07:00:16 +0100 Message-ID: <21331.1016690416@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message , Jul ian Elischer writes: > >One thing to look at: >Inode in dirent allocation.. > >there was a Usenix paper on this .. >It made a huge performance difference in some cases.. That is why I specifically said that we are not going to do it. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 7:27:33 2002 Delivered-To: freebsd-arch@freebsd.org Received: from tara.freenix.org (keltia.freenix.org [62.4.20.87]) by hub.freebsd.org (Postfix) with ESMTP id 55C3437B404 for ; Thu, 21 Mar 2002 07:27:29 -0800 (PST) Received: by tara.freenix.org (Postfix/TLS, from userid 101) id 24B852AC4; Thu, 21 Mar 2002 16:27:28 +0100 (CET) Date: Thu, 21 Mar 2002 16:27:28 +0100 From: Ollivier Robert To: arch@freebsd.org Cc: Garrett Rooney Subject: Diffutils Message-ID: <20020321152727.GA16839@tara.freenix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.26i X-Operating-System: FreeBSD 5.0-CURRENT K6-3D/266 & 2x PIII/800 SMP Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I'd like to backout this change in order to put us back in line with what's the whole wolrd is using: plain diffutils 2.7. It doesn't buy us anything that I know of (something that could be fine) and makes us incompatible with the rest of the world which is using plain diffutils and more, makes us more difficult to port something on. The example I have is subversion (CVS successor wanabee) which rely on a plain diffutils diff/diff3. This is force us to install textproc/diffutils just for that and is a special just for FreeBSD for IMO no good reason. PS : and no, I don't want my bikeshed green. green 2000/07/24 00:40:02 PDT Modified files: contrib/diff util.c Log: Get rid of the stupid bug where diff sticks trash in your generated diff output; there being no trailing newline caused it to bitch and moan and ruin diffs. That's dumb, if I may say so myself. Yes, this file is coming off the vendor branch. It hasn't been updated in 6 years. Approved by: peter Revision Changes Path 1.3 +2 -3 src/contrib/diff/util.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 8:52:46 2002 Delivered-To: freebsd-arch@freebsd.org Received: from gate.sim.ionidea.com (ion.so-com.net [212.110.132.83]) by hub.freebsd.org (Postfix) with ESMTP id 26FFD37B404 for ; Thu, 21 Mar 2002 08:52:17 -0800 (PST) Received: (from phantom@localhost) by gate.sim.ionidea.com (8.11.6/8.11.1) id g2LH81T25409; Thu, 21 Mar 2002 19:08:01 +0200 (EET) (envelope-from phantom) Date: Thu, 21 Mar 2002 19:08:01 +0200 From: Alexey Zelkin To: arch@freebsd.org Subject: rcsid's in libc Message-ID: <20020321190801.A25339@gate.sim.ionidea.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.20i X-Operating-System: FreeBSD 4.2-RELEASE i386 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG hi, We have a mess of definitions to include RCS IDs into object files while building libc. Currently we're using following defitions in libc's sources: SYSLIBC_RCS, LIBC_RCS, LIBC_SCCS. Actually only first two defines are enabled by default in libc/Makefile. First one is used to include RCS ID in syscalls object files (asm), second in all others (c). LIBC_SCCS is used in lots of files, but never defined in Makefiles. I'd like to remove LIBC_RCS and LIBC_SCCS usages and switch them to __FBSDID() macro. Also as part of this cleanup I'd like to move all "#if 0"'ed CSRG/Sun/etc SCCS strings to comments area (bottom of copyright as done in many places of our source tree). I've made a small patch against libc/Makefile, libc/sys/*.c and libc/xdr/*.c to show way that I prefer and receive feedback/objections against this cleanup. If no objections will be received I'll hack out other files and commit it. I already tried to show up this question for few times before, but due to different reasons it was postponed. But now (since __FBSDID() macro is introduced and things settled up) I see no reasons to not to do it. Index: Makefile =================================================================== RCS file: /cvs/freebsd/src/lib/libc/Makefile,v retrieving revision 1.31 diff -u -u -r1.31 Makefile --- Makefile 13 Aug 2001 21:48:43 -0000 1.31 +++ Makefile 21 Mar 2002 16:57:20 -0000 @@ -3,18 +3,23 @@ # # All library objects contain rcsid strings by default; they may be # excluded as a space-saving measure. To produce a library that does -# not contain these strings, delete -DLIBC_RCS and -DSYSLIBC_RCS -# from CFLAGS below. To remove these strings from just the system call -# stubs, remove just -DSYSLIBC_RCS from CFLAGS. +# not contain these strings use -DNO_LIBCRCS make's option to build. + LIB=c SHLIB_MAJOR= 5 SHLIB_MINOR= 0 -CFLAGS+=-DLIBC_RCS -DSYSLIBC_RCS -I${.CURDIR}/include -I${.CURDIR}/../../include +CFLAGS+=-I${.CURDIR}/include -I${.CURDIR}/../../include CFLAGS+=-DLIBC_MAJOR=${SHLIB_MAJOR} AINC= -I${.CURDIR}/${MACHINE_ARCH} CLEANFILES+=tags INSTALL_PIC_ARCHIVE= yes PRECIOUSLIB= yes + +.if defined(NO_LIBCRCS) +CFLAGS+=-DSTRIP_FBSDID +.else +CFLAGS+=-DSYSLIBC_RCS +.endif # # Include make rules that are shared with libc_r. Index: sys/__error.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/sys/__error.c,v retrieving revision 1.3 diff -u -u -r1.3 __error.c --- sys/__error.c 10 Apr 2001 04:11:50 -0000 1.3 +++ sys/__error.c 21 Mar 2002 16:32:10 -0000 @@ -29,10 +29,10 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * $FreeBSD: src/lib/libc/sys/__error.c,v 1.3 2001/04/10 04:11:50 deischen Exp $ */ #include +__FBSDID("$FreeBSD$"); extern int errno; Index: sys/ftruncate.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/sys/ftruncate.c,v retrieving revision 1.4 diff -u -u -r1.4 ftruncate.c --- sys/ftruncate.c 24 Jan 2001 13:01:07 -0000 1.4 +++ sys/ftruncate.c 21 Mar 2002 16:33:58 -0000 @@ -30,12 +30,11 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * $FreeBSD: src/lib/libc/sys/ftruncate.c,v 1.4 2001/01/24 13:01:07 deischen Exp $ + * @(#)ftruncate.c 8.1 (Berkeley) 6/17/93 */ -#if defined(LIBC_SCCS) && !defined(lint) -static char sccsid[] = "@(#)ftruncate.c 8.1 (Berkeley) 6/17/93"; -#endif /* LIBC_SCCS and not lint */ +#include +__FBSDID("$FreeBSD$"); #include #include Index: sys/lseek.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/sys/lseek.c,v retrieving revision 1.4 diff -u -u -r1.4 lseek.c --- sys/lseek.c 24 Jan 2001 13:01:07 -0000 1.4 +++ sys/lseek.c 21 Mar 2002 16:34:39 -0000 @@ -30,12 +30,11 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * $FreeBSD: src/lib/libc/sys/lseek.c,v 1.4 2001/01/24 13:01:07 deischen Exp $ + * @(#)lseek.c 8.1 (Berkeley) 6/17/93 */ -#if defined(LIBC_SCCS) && !defined(lint) -static char sccsid[] = "@(#)lseek.c 8.1 (Berkeley) 6/17/93"; -#endif /* LIBC_SCCS and not lint */ +#include +__FBSDID("$FreeBSD$"); #include #include Index: sys/mmap.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/sys/mmap.c,v retrieving revision 1.3 diff -u -u -r1.3 mmap.c --- sys/mmap.c 9 Mar 1998 07:27:58 -0000 1.3 +++ sys/mmap.c 21 Mar 2002 16:35:19 -0000 @@ -29,11 +29,12 @@ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. + * + * @(#)mmap.c 8.1 (Berkeley) 6/17/93 */ -#if defined(LIBC_SCCS) && !defined(lint) -static char sccsid[] = "@(#)mmap.c 8.1 (Berkeley) 6/17/93"; -#endif /* LIBC_SCCS and not lint */ +#include +__FBSDID("$FreeBSD$"); #include #include Index: sys/pread.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/sys/pread.c,v retrieving revision 1.1 diff -u -u -r1.1 pread.c --- sys/pread.c 4 Apr 1999 21:46:24 -0000 1.1 +++ sys/pread.c 21 Mar 2002 16:35:51 -0000 @@ -29,11 +29,12 @@ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. + * + * @(#)mmap.c 8.1 (Berkeley) 6/17/93 */ -#if defined(LIBC_SCCS) && !defined(lint) -static char sccsid[] = "@(#)mmap.c 8.1 (Berkeley) 6/17/93"; -#endif /* LIBC_SCCS and not lint */ +#include +__FBSDID("$FreeBSD$"); #include #include Index: sys/pwrite.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/sys/pwrite.c,v retrieving revision 1.1 diff -u -u -r1.1 pwrite.c --- sys/pwrite.c 4 Apr 1999 21:46:24 -0000 1.1 +++ sys/pwrite.c 21 Mar 2002 16:36:24 -0000 @@ -29,11 +29,12 @@ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. + * + * @(#)mmap.c 8.1 (Berkeley) 6/17/93 */ -#if defined(LIBC_SCCS) && !defined(lint) -static char sccsid[] = "@(#)mmap.c 8.1 (Berkeley) 6/17/93"; -#endif /* LIBC_SCCS and not lint */ +#include +__FBSDID("$FreeBSD$"); #include #include Index: sys/truncate.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/sys/truncate.c,v retrieving revision 1.2 diff -u -u -r1.2 truncate.c --- sys/truncate.c 14 Apr 1997 15:14:58 -0000 1.2 +++ sys/truncate.c 21 Mar 2002 16:36:55 -0000 @@ -29,15 +29,15 @@ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. + * + * @(#)truncate.c 8.1 (Berkeley) 6/17/93 */ -#if defined(LIBC_SCCS) && !defined(lint) -static char sccsid[] = "@(#)truncate.c 8.1 (Berkeley) 6/17/93"; -#endif /* LIBC_SCCS and not lint */ +#include +__FBSDID("$FreeBSD$"); #include #include - #include /* Index: xdr/xdr.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/xdr/xdr.c,v retrieving revision 1.11 diff -u -u -r1.11 xdr.c --- xdr/xdr.c 19 Mar 2001 12:49:57 -0000 1.11 +++ xdr/xdr.c 21 Mar 2002 16:39:16 -0000 @@ -27,14 +27,13 @@ * Sun Microsystems, Inc. * 2550 Garcia Avenue * Mountain View, California 94043 + * + * from: @(#)xdr.c 1.35 87/08/12 + * from: @(#)xdr.c 2.1 88/07/29 4.0 RPCSRC */ #include -#if defined(LIBC_SCCS) && !defined(lint) -/*static char *sccsid = "from: @(#)xdr.c 1.35 87/08/12";*/ -/*static char *sccsid = "from: @(#)xdr.c 2.1 88/07/29 4.0 RPCSRC";*/ -static char *rcsid = "$FreeBSD: src/lib/libc/xdr/xdr.c,v 1.11 2001/03/19 12:49:57 alfred Exp $"; -#endif +__FBSDID("$FreeBSD$"); /* * xdr.c, Generic XDR routines implementation. Index: xdr/xdr_array.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/xdr/xdr_array.c,v retrieving revision 1.9 diff -u -u -r1.9 xdr_array.c --- xdr/xdr_array.c 19 Mar 2001 12:49:57 -0000 1.9 +++ xdr/xdr_array.c 21 Mar 2002 16:40:03 -0000 @@ -27,14 +27,13 @@ * Sun Microsystems, Inc. * 2550 Garcia Avenue * Mountain View, California 94043 + * + * from: @(#)xdr_array.c 1.10 87/08/11 Copyr 1984 Sun Micro + * from: @(#)xdr_array.c 2.1 88/07/29 4.0 RPCSRC */ #include -#if defined(LIBC_SCCS) && !defined(lint) -/*static char *sccsid = "from: @(#)xdr_array.c 1.10 87/08/11 Copyr 1984 Sun Micro";*/ -/*static char *sccsid = "from: @(#)xdr_array.c 2.1 88/07/29 4.0 RPCSRC";*/ -static char *rcsid = "$FreeBSD: src/lib/libc/xdr/xdr_array.c,v 1.9 2001/03/19 12:49:57 alfred Exp $"; -#endif +__FBSDID("$FreeBSD$"); /* * xdr_array.c, Generic XDR routines impelmentation. Index: xdr/xdr_float.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/xdr/xdr_float.c,v retrieving revision 1.10 diff -u -u -r1.10 xdr_float.c --- xdr/xdr_float.c 23 Feb 2002 19:05:26 -0000 1.10 +++ xdr/xdr_float.c 21 Mar 2002 16:40:46 -0000 @@ -27,14 +27,13 @@ * Sun Microsystems, Inc. * 2550 Garcia Avenue * Mountain View, California 94043 + * + * from: @(#)xdr_float.c 1.12 87/08/11 Copyr 1984 Sun Micro + * from: @(#)xdr_float.c 2.1 88/07/29 4.0 RPCSRC */ #include -#if defined(LIBC_SCCS) && !defined(lint) -static char *sccsid = "@(#)xdr_float.c 1.12 87/08/11 Copyr 1984 Sun Micro"; -static char *sccsid = "@(#)xdr_float.c 2.1 88/07/29 4.0 RPCSRC"; -static char *rcsid = "$FreeBSD: src/lib/libc/xdr/xdr_float.c,v 1.10 2002/02/23 19:05:26 jake Exp $"; -#endif +__FBSDID("$FreeBSD$"); /* * xdr_float.c, Generic XDR routines implementation. Index: xdr/xdr_mem.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/xdr/xdr_mem.c,v retrieving revision 1.9 diff -u -u -r1.9 xdr_mem.c --- xdr/xdr_mem.c 19 Mar 2001 12:49:57 -0000 1.9 +++ xdr/xdr_mem.c 21 Mar 2002 16:41:54 -0000 @@ -27,14 +27,13 @@ * Sun Microsystems, Inc. * 2550 Garcia Avenue * Mountain View, California 94043 + * + * from: @(#)xdr_mem.c 1.19 87/08/11 Copyr 1984 Sun Micro + * from: @(#)xdr_mem.c 2.1 88/07/29 4.0 RPCSRC */ #include -#if defined(LIBC_SCCS) && !defined(lint) -/*static char *sccsid = "from: @(#)xdr_mem.c 1.19 87/08/11 Copyr 1984 Sun Micro";*/ -/*static char *sccsid = "from: @(#)xdr_mem.c 2.1 88/07/29 4.0 RPCSRC";*/ -static char *rcsid = "$FreeBSD: src/lib/libc/xdr/xdr_mem.c,v 1.9 2001/03/19 12:49:57 alfred Exp $"; -#endif +__FBSDID("$FreeBSD$"); /* * xdr_mem.h, XDR implementation using memory buffers. Index: xdr/xdr_rec.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/xdr/xdr_rec.c,v retrieving revision 1.13 diff -u -u -r1.13 xdr_rec.c --- xdr/xdr_rec.c 19 Mar 2001 12:49:57 -0000 1.13 +++ xdr/xdr_rec.c 21 Mar 2002 16:42:29 -0000 @@ -27,14 +27,13 @@ * Sun Microsystems, Inc. * 2550 Garcia Avenue * Mountain View, California 94043 + * + * from: @(#)xdr_rec.c 1.21 87/08/11 Copyr 1984 Sun Micro + * from: @(#)xdr_rec.c 2.2 88/08/01 4.0 RPCSRC */ #include -#if defined(LIBC_SCCS) && !defined(lint) -/*static char *sccsid = "from: @(#)xdr_rec.c 1.21 87/08/11 Copyr 1984 Sun Micro";*/ -/*static char *sccsid = "from: @(#)xdr_rec.c 2.2 88/08/01 4.0 RPCSRC";*/ -static char *rcsid = "$FreeBSD: src/lib/libc/xdr/xdr_rec.c,v 1.13 2001/03/19 12:49:57 alfred Exp $"; -#endif +__FBSDID("$FreeBSD$"); /* * xdr_rec.c, Implements TCP/IP based XDR streams with a "record marking" Index: xdr/xdr_reference.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/xdr/xdr_reference.c,v retrieving revision 1.10 diff -u -u -r1.10 xdr_reference.c --- xdr/xdr_reference.c 10 Apr 2001 03:47:40 -0000 1.10 +++ xdr/xdr_reference.c 21 Mar 2002 16:43:05 -0000 @@ -27,14 +27,13 @@ * Sun Microsystems, Inc. * 2550 Garcia Avenue * Mountain View, California 94043 + * + * from: @(#)xdr_reference.c 1.11 87/08/11 SMI + * from: @(#)xdr_reference.c 2.1 88/07/29 4.0 RPCSRC */ #include -#if defined(LIBC_SCCS) && !defined(lint) -/*static char *sccsid = "from: @(#)xdr_reference.c 1.11 87/08/11 SMI";*/ -/*static char *sccsid = "from: @(#)xdr_reference.c 2.1 88/07/29 4.0 RPCSRC";*/ -static char *rcsid = "$FreeBSD: src/lib/libc/xdr/xdr_reference.c,v 1.10 2001/04/10 03:47:40 deischen Exp $"; -#endif +__FBSDID("$FreeBSD$"); /* * xdr_reference.c, Generic XDR routines impelmentation. Index: xdr/xdr_sizeof.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/xdr/xdr_sizeof.c,v retrieving revision 1.3 diff -u -u -r1.3 xdr_sizeof.c --- xdr/xdr_sizeof.c 19 Mar 2001 12:49:57 -0000 1.3 +++ xdr/xdr_sizeof.c 21 Mar 2002 16:46:07 -0000 @@ -1,6 +1,4 @@ /* - * $FreeBSD: src/lib/libc/xdr/xdr_sizeof.c,v 1.3 2001/03/19 12:49:57 alfred Exp $ - * * Sun RPC is a product of Sun Microsystems, Inc. and is provided for * unrestricted use provided that this legend is included on all tape * media and as a part of the software program in whole or part. Users @@ -28,6 +26,10 @@ * 2550 Garcia Avenue * Mountain View, California 94043 */ + +#include +__FBSDID("$FreeBSD$"); + /* * xdr_sizeof.c * Index: xdr/xdr_stdio.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/xdr/xdr_stdio.c,v retrieving revision 1.9 diff -u -u -r1.9 xdr_stdio.c --- xdr/xdr_stdio.c 18 Feb 2002 20:35:18 -0000 1.9 +++ xdr/xdr_stdio.c 21 Mar 2002 16:44:08 -0000 @@ -27,14 +27,13 @@ * Sun Microsystems, Inc. * 2550 Garcia Avenue * Mountain View, California 94043 + * + * from: @(#)xdr_stdio.c 1.16 87/08/11 Copyr 1984 Sun Micro + * from: @(#)xdr_stdio.c 2.1 88/07/29 4.0 RPCSRC */ #include -#if defined(LIBC_SCCS) && !defined(lint) -/*static char *sccsid = "from: @(#)xdr_stdio.c 1.16 87/08/11 Copyr 1984 Sun Micro";*/ -/*static char *sccsid = "from: @(#)xdr_stdio.c 2.1 88/07/29 4.0 RPCSRC";*/ -static char *rcsid = "$FreeBSD: src/lib/libc/xdr/xdr_stdio.c,v 1.9 2002/02/18 20:35:18 mike Exp $"; -#endif +__FBSDID("$FreeBSD$"); /* * xdr_stdio.c, XDR implementation on standard i/o file. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 12:54:35 2002 Delivered-To: freebsd-arch@freebsd.org Received: from ady.warpnet.ro (ady.warpnet.ro [217.156.25.2]) by hub.freebsd.org (Postfix) with ESMTP id 221AC37B404; Thu, 21 Mar 2002 12:54:29 -0800 (PST) Received: from localhost (ady@localhost) by ady.warpnet.ro (8.9.3/8.9.3) with ESMTP id WAA50257; Thu, 21 Mar 2002 22:54:26 +0200 (EET) (envelope-from ady@freebsd.ady.ro) Date: Thu, 21 Mar 2002 22:54:26 +0200 (EET) From: Adrian Penisoara X-Sender: ady@ady.warpnet.ro To: freebsd-arch@freebsd.org, freebsd-net@freebsd.org Subject: Help needed: ALTQ integration into FreeBSD Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, Having the prerequisite agreement of the FreeBSD core team I'm delighted to announce my intention of putting the basis of a "ALTQ framework integration into FreeBSD" project. The current set target is "porting" the sources of the ALTQ project (ALTQ 3.1 is available for the 4.5-RELEASE branch) to FreeBSD-current. This is certainly not a easy nor simple task and I surely don't have all the skills needed right now, so I'm going to need help. I'm looking for a mentor (or more) with FreeBSD core networking knowledge and, if possible, with commit privileges to the right spots. If you know such a person or if you are one please contact me. Also, anybody interested to discuss, contribute or help in any other way is very welcomed to contact me. Reference: ALTQ project home http://www.csl.sony.co.jp/person/kjc/kjc/software.html Thank you very much, Adrian Penisoara Ady (@freebsd.ady.ro) _______________________________________________________________________ | Programming in BASIC causes brain damage. | | (Edsger Wybe Dijkstra) | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 15: 6:22 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mailtoaster1.pipeline.ch (mailtoaster1.pipeline.ch [62.48.0.70]) by hub.freebsd.org (Postfix) with SMTP id 4B7F937B417 for ; Thu, 21 Mar 2002 15:06:14 -0800 (PST) Received: (qmail 93729 invoked from network); 21 Mar 2002 23:04:08 -0000 Received: from unknown (HELO pipeline.ch) ([62.48.0.53]) (envelope-sender ) by mailtoaster1.pipeline.ch (qmail-ldap-1.03) with SMTP for ; 21 Mar 2002 23:04:08 -0000 Message-ID: <3C9A672C.F4A489AB@pipeline.ch> Date: Fri, 22 Mar 2002 00:05:16 +0100 From: Andre Oppermann X-Mailer: Mozilla 4.76 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Adrian Penisoara Cc: freebsd-arch@freebsd.org, freebsd-net@freebsd.org, jeker@n-r-g.com Subject: Re: Help needed: ALTQ integration into FreeBSD References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Adrian Penisoara wrote: > > Hi, > > Having the prerequisite agreement of the FreeBSD core team I'm > delighted to announce my intention of putting the basis of a "ALTQ > framework integration into FreeBSD" project. Does this mean the core team has approved the integration of ALTQ into FreeBSD-current? > The current set target is "porting" the sources of the ALTQ project > (ALTQ 3.1 is available for the 4.5-RELEASE branch) to FreeBSD-current. > This is certainly not a easy nor simple task and I surely don't have all > the skills needed right now, so I'm going to need help. I'm looking for > a mentor (or more) with FreeBSD core networking knowledge and, if > possible, with commit privileges to the right spots. If you know such a > person or if you are one please contact me. Myself and a collegue of mine are starting to work on a couple of FreeBSD networking related projects from next month on. ALTQ is one of the things on our plate but I think we would have got to it not before summer. We want to overhaul a couple of things in the *BSD networking stack (IP but not TCP/UDP) which are out of date in these days. Part of that is to address many issues Garret Wollman has identified in an email on -net many moons ago. Some things that will be addressed are for example the routing table (old and fat structure, policy routing), IPIP tunneling abstractions (GRE etc.) and some more things. The plan is to first research and identify all issues with the currect networking stack in FreeBSD (1 month). Then to research and identify possible new structures/framworks and to publish a research paper with our findings and recommendations (1-2 month). From then on discussion and implementation will begin. This work is funded by my company (Internet Business Solutions AG) because we want to use a FreeBSD kernel in our high-performance and special purpose routing device by Winter 2002. My goal is to submit as much code as possible of the non-special stuff into FreeBSD (as I've done in the past with RADIUS for Brian's ppp and some Netgraph stuff and the OLDCARD in -stable last year (I organized funding for Brian, Julian and Warner to work on it)). -- Andre > Also, anybody interested to discuss, contribute or help in any other > way is very welcomed to contact me. > > Reference: > > ALTQ project home > http://www.csl.sony.co.jp/person/kjc/kjc/software.html > > Thank you very much, > Adrian Penisoara > Ady (@freebsd.ady.ro) > _______________________________________________________________________ > | Programming in BASIC causes brain damage. | > | (Edsger Wybe Dijkstra) | > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-arch" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 15:11: 1 2002 Delivered-To: freebsd-arch@freebsd.org Received: from swan.prod.itd.earthlink.net (swan.mail.pas.earthlink.net [207.217.120.123]) by hub.freebsd.org (Postfix) with ESMTP id AB28537B419; Thu, 21 Mar 2002 15:10:56 -0800 (PST) Received: from pool0042.cvx21-bradley.dialup.earthlink.net ([209.179.192.42] helo=mindspring.com) by swan.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16oBhr-0004w9-00; Thu, 21 Mar 2002 15:10:52 -0800 Message-ID: <3C9A6867.1C38EF1E@mindspring.com> Date: Thu, 21 Mar 2002 15:10:31 -0800 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Adrian Penisoara Cc: freebsd-arch@freebsd.org, freebsd-net@freebsd.org Subject: Re: Help needed: ALTQ integration into FreeBSD References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Julian did some nice QOS work at Whistle that he always shushes me when I mention it. You should beat him over the head for it. It's not necessarily miscible with AltQ, but it had the effect of controlling the amount of buffer space taken on the remote end of a slow link, so that a single transfer over an impedence mismatched link didn't stop all the other traffic, regardless of the QOS settings. From what I remember, AltQ had this problem, and no reasonable way to resolve it. -- Terry Adrian Penisoara wrote: > > Hi, > > Having the prerequisite agreement of the FreeBSD core team I'm > delighted to announce my intention of putting the basis of a "ALTQ > framework integration into FreeBSD" project. > > The current set target is "porting" the sources of the ALTQ project > (ALTQ 3.1 is available for the 4.5-RELEASE branch) to FreeBSD-current. > This is certainly not a easy nor simple task and I surely don't have all > the skills needed right now, so I'm going to need help. I'm looking for > a mentor (or more) with FreeBSD core networking knowledge and, if > possible, with commit privileges to the right spots. If you know such a > person or if you are one please contact me. > > Also, anybody interested to discuss, contribute or help in any other > way is very welcomed to contact me. > > Reference: > > ALTQ project home > http://www.csl.sony.co.jp/person/kjc/kjc/software.html > > Thank you very much, > Adrian Penisoara > Ady (@freebsd.ady.ro) > _______________________________________________________________________ > | Programming in BASIC causes brain damage. | > | (Edsger Wybe Dijkstra) | > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-arch" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 15:24:23 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id B064E37B417 for ; Thu, 21 Mar 2002 15:24:19 -0800 (PST) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.12.1/8.12.1) with ESMTP id g2LNOHYL129780; Thu, 21 Mar 2002 18:24:17 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20020321152727.GA16839@tara.freenix.org> References: <20020321152727.GA16839@tara.freenix.org> Date: Thu, 21 Mar 2002 18:24:16 -0500 To: Ollivier Robert , arch@FreeBSD.ORG From: Garance A Drosihn Subject: Re: Diffutils Cc: Garrett Rooney , "M. Warner Losh" Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 4:27 PM +0100 3/21/02, Ollivier Robert wrote: >I'd like to backout this change in order to put us back in line >with what's the whole wolrd is using: plain diffutils 2.7. > >It doesn't buy us anything that I know of (something that could >be fine) and makes us incompatible with the rest of the world >which is using plain diffutils and more, makes us more difficult >to port something on. This topic came up for discussion on freebsd-standards a few weeks ago. The resolution seemed to be that Warner was going to do it, after first making sure that our version of patch also understands the '\' line (which indicates that the last line of a diff'ed file does not have a terminating newline character). -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 15:45:10 2002 Delivered-To: freebsd-arch@freebsd.org Received: from harrier.prod.itd.earthlink.net (harrier.mail.pas.earthlink.net [207.217.120.12]) by hub.freebsd.org (Postfix) with ESMTP id 6F0D637B400; Thu, 21 Mar 2002 15:44:55 -0800 (PST) Received: from pool0042.cvx21-bradley.dialup.earthlink.net ([209.179.192.42] helo=mindspring.com) by harrier.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16oCEd-0000UD-00; Thu, 21 Mar 2002 15:44:44 -0800 Message-ID: <3C9A7056.84A401EF@mindspring.com> Date: Thu, 21 Mar 2002 15:44:22 -0800 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Andre Oppermann Cc: Adrian Penisoara , freebsd-arch@freebsd.org, freebsd-net@freebsd.org, jeker@n-r-g.com Subject: Re: Help needed: ALTQ integration into FreeBSD References: <3C9A672C.F4A489AB@pipeline.ch> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Andre Oppermann wrote: > The plan is to first research and identify all issues with the currect > networking stack in FreeBSD (1 month). Here are some that I think need to be addressed. o Can't make more that 64k outbound connections, without heroic measures, even with multiple IP addresses. o Exponential slowdown because of in_pcblookup_hash, at some "cliff" equalt to the number of buckets (should use a btree or some other scalable structure) o TCP/IP timers go into timeout wheel out of expiration order, so expiration has to traverse entire list; as most expire before they are e3ver called, this is all dead weight. Should use a per interval list for some small number of granular intervals; adding adds to the end of the list, so expiration can limit traversal to the first entry where the timeout is not expired, and not examine the rest of the outstanding timers. o Jon Lemon's patches don't deal with receiver livelock in the case that the livelock occurs higher in the stack (e.g. in the accept of connections). LRP, per Peter Druschel @ Rice University, is a better approach, overall. o Luigi Rizzo's patches only deal with fixed interval scheduling when polling is on, and so degrade radically with load outside the prediction parameters (e.g. NFS processing vs. packet forwarding vs. user space app.). Using queue depth to user space, and weighted fair share is a better scheduling policy that assures better performance, per Jeff Mogul, DEC Western Research Laboratories. o Fast retransmit (ala TCP Reno) has a number of problems during Fast Recovery that lead to "yoyo mode" (peristaltic congestion). Rate Halving, per Hoe @ Pittsburg Supercomputing Center at Carnegie Mellon is a better approach. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 16:43:38 2002 Delivered-To: freebsd-arch@freebsd.org Received: from castle.jp.FreeBSD.org (castle.jp.FreeBSD.org [210.226.20.15]) by hub.freebsd.org (Postfix) with ESMTP id 9B30937B417; Thu, 21 Mar 2002 16:43:34 -0800 (PST) Received: from localhost (localhost [::1]) by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) with ESMTP/inet6 id g2M0hJc17846; Fri, 22 Mar 2002 09:43:19 +0900 (JST) (envelope-from matusita@jp.FreeBSD.org) Cc: arch@FreeBSD.org, net@FreeBSD.org In-Reply-To: References: X-User-Agent: Mew/1.94.2 XEmacs/21.5 (bamboo) X-FaceAnim: (-O_O-)(O_O- )(_O- )(O- )(- -)( -O)( -O_)( -O_O)(-O_O-) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Dispatcher: imput version 20000228(IM140) Lines: 17 From: Makoto Matsushita To: ady@freebsd.ady.ro Subject: Re: Help needed: ALTQ integration into FreeBSD Date: Fri, 22 Mar 2002 09:43:10 +0900 Message-Id: <20020322094310E.matusita@jp.FreeBSD.org> Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG ady> Having the prerequisite agreement of the FreeBSD core team I'm ady> delighted to announce my intention of putting the basis of a "ALTQ ady> framework integration into FreeBSD" project. Have you ever contact to Cho-san, the author of ALTQ? He is also a FreeBSD committer (kjc@FreeBSD.org), and may willing to help you if he have enough time to do. ALTQ implementation is already integrated into KAME; maybe KAME guys can help you. I've heard a few days ago that a new FreeBSD committer, suz (from KAME team itself), is approved by core, but his account on freefall is *not* created (I dunno why but it's true) so he can't do his work (sigh). -- - Makoto `MAR' Matsushita To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 18:11:17 2002 Delivered-To: freebsd-arch@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id CFD3037B404; Thu, 21 Mar 2002 18:11:11 -0800 (PST) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.6) with SMTP id g2M2B2k35778; Thu, 21 Mar 2002 21:11:02 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Thu, 21 Mar 2002 21:11:02 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Andre Oppermann Cc: Adrian Penisoara , freebsd-arch@freebsd.org, freebsd-net@freebsd.org, jeker@n-r-g.com Subject: Re: Help needed: ALTQ integration into FreeBSD In-Reply-To: <3C9A672C.F4A489AB@pipeline.ch> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 22 Mar 2002, Andre Oppermann wrote: > > Having the prerequisite agreement of the FreeBSD core team I'm > > delighted to announce my intention of putting the basis of a "ALTQ > > framework integration into FreeBSD" project. > > Does this mean the core team has approved the integration of ALTQ into > FreeBSD-current? The core team has neither approved nor rejected anything. However, there were a number of us who said "Yeah, we've been hoping someone would make this happen". Obviously, any final integration decision would be based on having a much better idea about the positive and negative aspects of the work. One of the recommendations we made was that this work definitely be done on 5.0-CURRENT, and take the fine-grained SMP work into account. The other recommendation we made was that this be done in careful coordination with others working on it: there's a lot of interest in ALTQ, and existing porting work. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 18:17:28 2002 Delivered-To: freebsd-arch@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 11B7B37B47C for ; Thu, 21 Mar 2002 18:17:10 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g2M2Gxi85143; Thu, 21 Mar 2002 19:17:00 -0700 (MST) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g2M2GwL21688; Thu, 21 Mar 2002 19:16:58 -0700 (MST) (envelope-from imp@village.org) Date: Thu, 21 Mar 2002 19:16:53 -0700 (MST) Message-Id: <20020321.191653.05178124.imp@village.org> To: roberto@keltia.freenix.fr Cc: arch@FreeBSD.ORG, rooneg@electricjellyfish.net Subject: Re: Diffutils From: "M. Warner Losh" In-Reply-To: <20020321152727.GA16839@tara.freenix.org> References: <20020321152727.GA16839@tara.freenix.org> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I have talked with green about this. He'd like me to fix patch to grok the generated diffs first. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 18:18:18 2002 Delivered-To: freebsd-arch@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 6FD4B37B400 for ; Thu, 21 Mar 2002 18:18:14 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g2M2IBi85163; Thu, 21 Mar 2002 19:18:11 -0700 (MST) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g2M2IAL21707; Thu, 21 Mar 2002 19:18:11 -0700 (MST) (envelope-from imp@village.org) Date: Thu, 21 Mar 2002 19:18:06 -0700 (MST) Message-Id: <20020321.191806.63793563.imp@village.org> To: drosih@rpi.edu Cc: roberto@keltia.freenix.fr, arch@FreeBSD.ORG, rooneg@electricjellyfish.net Subject: Re: Diffutils From: "M. Warner Losh" In-Reply-To: References: <20020321152727.GA16839@tara.freenix.org> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: Garance A Drosihn writes: : This topic came up for discussion on freebsd-standards a few weeks : ago. The resolution seemed to be that Warner was going to do it, : after first making sure that our version of patch also understands : the '\' line (which indicates that the last line of a diff'ed file : does not have a terminating newline character). But if someone else wanted to do it, I won't get in your way. :-) Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 20:55:48 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 079F737B41A; Thu, 21 Mar 2002 20:55:33 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id PAA22182; Fri, 22 Mar 2002 15:55:29 +1100 Date: Fri, 22 Mar 2002 15:55:43 +1100 (EST) From: Bruce Evans X-X-Sender: To: Alexey Zelkin Cc: Subject: Re: rcsid's in libc In-Reply-To: <20020321190801.A25339@gate.sim.ionidea.com> Message-ID: <20020322152800.M16722-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 21 Mar 2002, Alexey Zelkin wrote: > We have a mess of definitions to include RCS IDs into object files > while building libc. Currently we're using following defitions > in libc's sources: SYSLIBC_RCS, LIBC_RCS, LIBC_SCCS. Actually only > first two defines are enabled by default in libc/Makefile. First > one is used to include RCS ID in syscalls object files (asm), second > in all others (c). LIBC_SCCS is used in lots of files, but never > defined in Makefiles. I recently reenabled them all. About 20 files failed to compile due to bitrot in the ifdefed code (e.g., `static chat rcsid[] ...'). Rev.1.8 of libc/Makefile was more than 7 years premature/incomplete in switching from sccsids to rcsids. The sccsids must still be enabled to get an id in the object file in about 80% of the files. > I'd like to remove LIBC_RCS and LIBC_SCCS usages and switch them > to __FBSDID() macro. Also as part of this cleanup I'd like to move > all "#if 0"'ed CSRG/Sun/etc SCCS strings to comments area (bottom > of copyright as done in many places of our source tree). I strongly object to moving the vendor ids. Moving them mainly creates work to move them and creates future work to resolve conflicts for any future merges from the vendor branch. > I've made a small patch against libc/Makefile, libc/sys/*.c and > libc/xdr/*.c to show way that I prefer and receive feedback/objections > against this cleanup. If no objections will be received I'll hack out > other files and commit it. Here are patches for my current version of the Makefile. I don't really like them. The *LIBC*CS defines should go away _after_ __FBSDID() has been added to all files (included generated ones). %%% Index: Makefile =================================================================== RCS file: /home/ncvs/src/lib/libc/Makefile,v retrieving revision 1.31 diff -u -2 -r1.31 Makefile --- Makefile 13 Aug 2001 21:48:43 -0000 1.31 +++ Makefile 21 Mar 2002 13:12:28 -0000 @@ -4,12 +4,20 @@ # All library objects contain rcsid strings by default; they may be # excluded as a space-saving measure. To produce a library that does -# not contain these strings, delete -DLIBC_RCS and -DSYSLIBC_RCS -# from CFLAGS below. To remove these strings from just the system call -# stubs, remove just -DSYSLIBC_RCS from CFLAGS. +# not contain these strings, delete -DLIBC_RCS, -DLIBC_SCCS, -DSYSLIBC_SCCS +# and -DSYSLIBC_RCS from CFLAGS below, and add -DSTRIP_FBSDID to CFLAGS +# (see ). To remove these strings from just the system call +# stubs, remove just -DSYSLIBC_RCS and -DSYSLIBC_RCS from CFLAGS. +# +# XXX NOT all library objects contain rcsid strings by default. Most +# contain only sccsids. Most didn't even contain those until *LIBC_SCCS +# was reenabled recently. There are no ids for syscall stubs whose sources +# are generated. Did I miss anything? LIB=c SHLIB_MAJOR= 5 SHLIB_MINOR= 0 -CFLAGS+=-DLIBC_RCS -DSYSLIBC_RCS -I${.CURDIR}/include -I${.CURDIR}/../../include -CFLAGS+=-DLIBC_MAJOR=${SHLIB_MAJOR} +CFLAGS+=-DLIBC_RCS -DSYSLIBC_RCS +#CFLAGS+=-DLIBC_SCCS -DSYSLIBC_SCCS +CFLAGS+=-DLIBC_MAJOR=${SHLIB_MAJOR} # XXX temporary until SHLIB_MAJOR is 6. +CFLAGS+=-I${.CURDIR}/include AINC= -I${.CURDIR}/${MACHINE_ARCH} CLEANFILES+=tags %%% > I already tried to show up this question for few times before, but > due to different reasons it was postponed. But now (since __FBSDID() > macro is introduced and things settled up) I see no reasons to not > to do it. I still have minor disagreements with obrien about how vendor ids should be ifdefed, and don't want to see __FBSDID() added in lots of wrong places. > Index: Makefile > =================================================================== > RCS file: /cvs/freebsd/src/lib/libc/Makefile,v > retrieving revision 1.31 > diff -u -u -r1.31 Makefile > --- Makefile 13 Aug 2001 21:48:43 -0000 1.31 > +++ Makefile 21 Mar 2002 16:57:20 -0000 > @@ -3,18 +3,23 @@ > # > # All library objects contain rcsid strings by default; they may be > # excluded as a space-saving measure. To produce a library that does > -# not contain these strings, delete -DLIBC_RCS and -DSYSLIBC_RCS > -# from CFLAGS below. To remove these strings from just the system call > -# stubs, remove just -DSYSLIBC_RCS from CFLAGS. > +# not contain these strings use -DNO_LIBCRCS make's option to build. > + > LIB=c > SHLIB_MAJOR= 5 > SHLIB_MINOR= 0 > -CFLAGS+=-DLIBC_RCS -DSYSLIBC_RCS -I${.CURDIR}/include -I${.CURDIR}/../../include > +CFLAGS+=-I${.CURDIR}/include -I${.CURDIR}/../../include > CFLAGS+=-DLIBC_MAJOR=${SHLIB_MAJOR} > AINC= -I${.CURDIR}/${MACHINE_ARCH} > CLEANFILES+=tags > INSTALL_PIC_ARCHIVE= yes > PRECIOUSLIB= yes > + > +.if defined(NO_LIBCRCS) Should be NO_LIB_IDS and apply to all libraries. > +CFLAGS+=-DSTRIP_FBSDID > +.else > +CFLAGS+=-DSYSLIBC_RCS > +.endif An ifdef for this is better than [rotted] instructions about what to comment out. > Index: sys/__error.c > =================================================================== > RCS file: /cvs/freebsd/src/lib/libc/sys/__error.c,v > retrieving revision 1.3 > diff -u -u -r1.3 __error.c > --- sys/__error.c 10 Apr 2001 04:11:50 -0000 1.3 > +++ sys/__error.c 21 Mar 2002 16:32:10 -0000 > @@ -29,10 +29,10 @@ > * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > * SUCH DAMAGE. > * > - * $FreeBSD: src/lib/libc/sys/__error.c,v 1.3 2001/04/10 04:11:50 deischen Exp $ > */ Style bug: not removing the empty line that gave a new paragraph for $FreeBSD > Index: sys/ftruncate.c > =================================================================== > RCS file: /cvs/freebsd/src/lib/libc/sys/ftruncate.c,v > retrieving revision 1.4 > diff -u -u -r1.4 ftruncate.c > --- sys/ftruncate.c 24 Jan 2001 13:01:07 -0000 1.4 > +++ sys/ftruncate.c 21 Mar 2002 16:33:58 -0000 > @@ -30,12 +30,11 @@ > * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > * SUCH DAMAGE. > * > - * $FreeBSD: src/lib/libc/sys/ftruncate.c,v 1.4 2001/01/24 13:01:07 deischen Exp $ > + * @(#)ftruncate.c 8.1 (Berkeley) 6/17/93 > */ I strongly object to moving vendor ids like this. > .... > Index: xdr/xdr.c > =================================================================== > RCS file: /cvs/freebsd/src/lib/libc/xdr/xdr.c,v > retrieving revision 1.11 > diff -u -u -r1.11 xdr.c > --- xdr/xdr.c 19 Mar 2001 12:49:57 -0000 1.11 > +++ xdr/xdr.c 21 Mar 2002 16:39:16 -0000 > @@ -27,14 +27,13 @@ > * Sun Microsystems, Inc. > * 2550 Garcia Avenue > * Mountain View, California 94043 > + * > + * from: @(#)xdr.c 1.35 87/08/12 > + * from: @(#)xdr.c 2.1 88/07/29 4.0 RPCSRC > */ > > #include > -#if defined(LIBC_SCCS) && !defined(lint) > -/*static char *sccsid = "from: @(#)xdr.c 1.35 87/08/12";*/ > -/*static char *sccsid = "from: @(#)xdr.c 2.1 88/07/29 4.0 RPCSRC";*/ > -static char *rcsid = "$FreeBSD: src/lib/libc/xdr/xdr.c,v 1.11 2001/03/19 12:49:57 alfred Exp $"; > -#endif > +__FBSDID("$FreeBSD$"); This demonstrates several layers of how not to handle [vendor] ids. In rev.1.1, there were the 2 commented out sccsids, and an rcsid with and Paul (Vixie?)'s $Id$. Not too bad. The $Id$ was corrupted to a FreeBSD $Id$ in rev.1.2. Rev.1.5 changed $Id$ to $FreeBSD$; rev.1.6 changed $FreeBSD$ to $Id$; rev.1.9 changed $Id$ to $FreeBSD$. The vendor $Id$ is still wrong. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 22: 8: 3 2002 Delivered-To: freebsd-arch@freebsd.org Received: from gull.prod.itd.earthlink.net (gull.mail.pas.earthlink.net [207.217.120.84]) by hub.freebsd.org (Postfix) with ESMTP id EBB7F37B400; Thu, 21 Mar 2002 22:07:54 -0800 (PST) Received: from pool0183.cvx40-bradley.dialup.earthlink.net ([216.244.42.183] helo=mindspring.com) by gull.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16oID9-0004Zq-00; Thu, 21 Mar 2002 22:07:36 -0800 Message-ID: <3C9ACA14.551C554A@mindspring.com> Date: Thu, 21 Mar 2002 22:07:16 -0800 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Makoto Matsushita Cc: ady@freebsd.ady.ro, arch@FreeBSD.org, net@FreeBSD.org Subject: Re: Help needed: ALTQ integration into FreeBSD References: <20020322094310E.matusita@jp.FreeBSD.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Makoto Matsushita wrote: > Have you ever contact to Cho-san, the author of ALTQ? He is also a > FreeBSD committer (kjc@FreeBSD.org), and may willing to help you if he > have enough time to do. > > ALTQ implementation is already integrated into KAME; maybe KAME guys > can help you. I've heard a few days ago that a new FreeBSD committer, > suz (from KAME team itself), is approved by core, but his account on > freefall is *not* created (I dunno why but it's true) so he can't do > his work (sigh). Personally, I'm a little "gun shy" about KAME integration right now. The IPv4 IPSEC code has this nasty habit of reserving space for the IPSEC for non-IPSEC connections. This drops the maximum number of connections supportable by a given amount of RAM by a factor of 4 or more. I understand the need to alloc memory for the stuff when the connection is actually an IPSEC connection, but as it is, not using IPSEC, and just having the crap in your kernel has the bad effect on the maximum number of connections. I would really hate to see something else come in that was not conditionalized on it actually being used. 8-(. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 22:32:42 2002 Delivered-To: freebsd-arch@freebsd.org Received: from tara.freenix.org (keltia.freenix.org [62.4.20.87]) by hub.freebsd.org (Postfix) with ESMTP id F122D37B41C for ; Thu, 21 Mar 2002 22:32:37 -0800 (PST) Received: by tara.freenix.org (Postfix/TLS, from userid 101) id BDA782AAA; Fri, 22 Mar 2002 07:32:36 +0100 (CET) Date: Fri, 22 Mar 2002 07:32:36 +0100 From: Ollivier Robert To: "M. Warner Losh" Cc: arch@FreeBSD.ORG, rooneg@electricjellyfish.net Subject: Re: Diffutils Message-ID: <20020322063236.GA19699@tara.freenix.org> References: <20020321152727.GA16839@tara.freenix.org> <20020321.191653.05178124.imp@village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020321.191653.05178124.imp@village.org> User-Agent: Mutt/1.3.26i X-Operating-System: FreeBSD 5.0-CURRENT K6-3D/266 & 2x PIII/800 SMP Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG According to M. Warner Losh: > I have talked with green about this. He'd like me to fix patch to > grok the generated diffs first. Why? Do we also have a modified patch? The original GNU patch with the original GNU diffutils work fine so what's there to fix? I'm confused. I seem to recall that at one point we went to patch 2.5 then back but that's about it... -- Ollivier ROBERT -=- FreeBSD: The Power to Serve! -=- roberto@keltia.freenix.fr FreeBSD keltia.freenix.fr 5.0-CURRENT #80: Sun Jun 4 22:44:19 CEST 2000 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Thu Mar 21 22:53:37 2002 Delivered-To: freebsd-arch@freebsd.org Received: from picollo.kjc.jp (picollo.ietf53.cw.net [166.63.183.8]) by hub.freebsd.org (Postfix) with ESMTP id E5D9837B41A; Thu, 21 Mar 2002 22:53:31 -0800 (PST) Received: from localhost (kjc@localhost [IPv6:::1]) by picollo.kjc.jp (8.12.2/8.11.3) with ESMTP id g2M5pvkO031624; Fri, 22 Mar 2002 14:52:15 +0900 (JST) Date: Fri, 22 Mar 2002 14:51:46 +0900 (JST) Message-Id: <20020322.145146.41658192.kjc@csl.sony.co.jp> To: matusita@jp.FreeBSD.org Cc: ady@freebsd.ady.ro, arch@FreeBSD.ORG, net@FreeBSD.ORG Subject: Re: Help needed: ALTQ integration into FreeBSD From: Kenjiro Cho In-Reply-To: <20020322094310E.matusita@jp.FreeBSD.org> References: <20020322094310E.matusita@jp.FreeBSD.org> X-Mailer: Mew version 2.2 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > ady> Having the prerequisite agreement of the FreeBSD core team I'm > ady> delighted to announce my intention of putting the basis of a "ALTQ > ady> framework integration into FreeBSD" project. > > Have you ever contact to Cho-san, the author of ALTQ? He is also a > FreeBSD committer (kjc@FreeBSD.org), and may willing to help you if he > have enough time to do. I'm now at IETF and leaving Minneapolis tomorrow morning. I'll talk to Ady when I get back. (yes, I do have an idea on how to integrate fine-grained locking into ALTQ.) -Kenjiro To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Fri Mar 22 3:27:10 2002 Delivered-To: freebsd-arch@freebsd.org Received: from chiark.greenend.org.uk (chiark.greenend.org.uk [212.22.195.2]) by hub.freebsd.org (Postfix) with ESMTP id BC50137B417 for ; Fri, 22 Mar 2002 03:27:07 -0800 (PST) Received: from fanf by chiark.greenend.org.uk with local (Exim 3.12 #1) id 16oNC7-00022T-00 (Debian); Fri, 22 Mar 2002 11:26:51 +0000 Date: Fri, 22 Mar 2002 11:26:51 +0000 From: Tony Finch To: Ollivier Robert Cc: "M. Warner Losh" , arch@FreeBSD.ORG, rooneg@electricjellyfish.net Message-ID: <20020322112651.A5435@chiark.greenend.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Ollivier Robert >According to M. Warner Losh: >> I have talked with green about this. He'd like me to fix patch to >> grok the generated diffs first. > >Why? Do we also have a modified patch? The original GNU patch with the >original GNU diffutils work fine so what's there to fix? >I'm confused. I seem to recall that at one point we went to patch 2.5 then >back but that's about it... FreeBSD is still using patch-2.1 because more recent versions of patch don't understand the output of `cvs diff` -- they fail to find the right file to patch if it is in a subdirectory. As far as I can see there have been no significant changes to the source. Tony. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Fri Mar 22 5:38:15 2002 Delivered-To: freebsd-arch@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 18C2A37B41B for ; Fri, 22 Mar 2002 05:38:12 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g2MDc6i87960; Fri, 22 Mar 2002 06:38:07 -0700 (MST) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g2MDc2L24870; Fri, 22 Mar 2002 06:38:02 -0700 (MST) (envelope-from imp@village.org) Date: Fri, 22 Mar 2002 06:37:51 -0700 (MST) Message-Id: <20020322.063751.68160149.imp@village.org> To: roberto@keltia.freenix.fr Cc: arch@FreeBSD.ORG, rooneg@electricjellyfish.net Subject: Re: Diffutils From: "M. Warner Losh" In-Reply-To: <20020322063236.GA19699@tara.freenix.org> References: <20020321152727.GA16839@tara.freenix.org> <20020321.191653.05178124.imp@village.org> <20020322063236.GA19699@tara.freenix.org> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20020322063236.GA19699@tara.freenix.org> Ollivier Robert writes: : According to M. Warner Losh: : > I have talked with green about this. He'd like me to fix patch to : > grok the generated diffs first. : : Why? Do we also have a modified patch? The original GNU patch with the : original GNU diffutils work fine so what's there to fix? : : I'm confused. I seem to recall that at one point we went to patch 2.5 then : back but that's about it... The patch that we have in the tree is 2.1 and doesn't grok the missing end of line stuff. The 2.5 that we also have in the tree doesn't work with cvs diffs :-(. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Fri Mar 22 6:17:40 2002 Delivered-To: freebsd-arch@freebsd.org Received: from green.bikeshed.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 6545A37B41D; Fri, 22 Mar 2002 06:17:36 -0800 (PST) Received: from localhost (green@localhost) by green.bikeshed.org (8.11.6/8.11.6) with ESMTP id g2MEHZ958962; Fri, 22 Mar 2002 09:17:35 -0500 (EST) (envelope-from green@green.bikeshed.org) Message-Id: <200203221417.g2MEHZ958962@green.bikeshed.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: "M. Warner Losh" Cc: roberto@keltia.freenix.fr, arch@FreeBSD.ORG, rooneg@electricjellyfish.net Subject: Re: Diffutils In-Reply-To: Your message of "Fri, 22 Mar 2002 06:37:51 MST." <20020322.063751.68160149.imp@village.org> From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 22 Mar 2002 09:17:35 -0500 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "M. Warner Losh" wrote: > In message: <20020322063236.GA19699@tara.freenix.org> > Ollivier Robert writes: > : According to M. Warner Losh: > : > I have talked with green about this. He'd like me to fix patch to > : > grok the generated diffs first. > : > : Why? Do we also have a modified patch? The original GNU patch with the > : original GNU diffutils work fine so what's there to fix? > : > : I'm confused. I seem to recall that at one point we went to patch 2.5 then > : back but that's about it... > > The patch that we have in the tree is 2.1 and doesn't grok the missing > end of line stuff. The 2.5 that we also have in the tree doesn't work > with cvs diffs :-(. Our patch 2.1 is also broken on certain "large" patches I've encountered (extremely long lines, for example, seemed to be one issue). Our patch is also a lot more verbose than patch 2.5. So, just for the record, there are more than a couple small differences... -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org <> bfeldman@tislabs.com \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Fri Mar 22 14: 6:20 2002 Delivered-To: freebsd-arch@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id B452937B41E for ; Fri, 22 Mar 2002 14:06:17 -0800 (PST) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g2MM6ILf016878 for ; Fri, 22 Mar 2002 14:06:18 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g2MM53db016877 for arch@freebsd.org; Fri, 22 Mar 2002 14:05:03 -0800 (PST) Date: Fri, 22 Mar 2002 14:05:03 -0800 From: "David O'Brien" To: arch@freebsd.org Subject: Objections to rm'ing the libc/mips* bits? Message-ID: <20020322140503.A16857@dragon.nuxi.com> Reply-To: arch@freebsd.org Mail-Followup-To: arch@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Are there any objections to totally removing all the mips bits from libc? They are part of an abortive porting effort. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Fri Mar 22 14:19:48 2002 Delivered-To: freebsd-arch@freebsd.org Received: from harrier.prod.itd.earthlink.net (harrier.mail.pas.earthlink.net [207.217.120.12]) by hub.freebsd.org (Postfix) with ESMTP id C0CE837B41B for ; Fri, 22 Mar 2002 14:19:44 -0800 (PST) Received: from pool0291.cvx21-bradley.dialup.earthlink.net ([209.179.193.36] helo=mindspring.com) by harrier.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16oXNs-0004R8-00 for arch@freebsd.org; Fri, 22 Mar 2002 14:19:40 -0800 Message-ID: <3C9BADE9.4ADC072D@mindspring.com> Date: Fri, 22 Mar 2002 14:19:21 -0800 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: arch@freebsd.org Subject: Re: Objections to rm'ing the libc/mips* bits? References: <20020322140503.A16857@dragon.nuxi.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG David O'Brien wrote: > > Are there any objections to totally removing all the mips bits from libc? > They are part of an abortive porting effort. I thought the DEveloper's Summit at BSDCon indicated that there was a completed MIPS port, and that it just had not been integrated back into the tree yet? -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Fri Mar 22 15:10: 6 2002 Delivered-To: freebsd-arch@freebsd.org Received: from ady.warpnet.ro (ady.warpnet.ro [217.156.25.2]) by hub.freebsd.org (Postfix) with ESMTP id 5238237B400; Fri, 22 Mar 2002 15:09:57 -0800 (PST) Received: from localhost (ady@localhost) by ady.warpnet.ro (8.9.3/8.9.3) with ESMTP id BAA31650; Sat, 23 Mar 2002 01:09:55 +0200 (EET) (envelope-from ady@freebsd.ady.ro) Date: Sat, 23 Mar 2002 01:09:55 +0200 (EET) From: Adrian Penisoara X-Sender: ady@ady.warpnet.ro To: freebsd-arch@freebsd.org, freebsd-net@freebsd.org Subject: Re: Help needed: ALTQ integration into FreeBSD In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, Thank you all for your replies. I will keep track of all the mentioned issues. In the mean time I will be waiting for Mr. Kenjiro Cho to return and have a chat with him. I will keep you posted with my/our progress. Thanks! Ady (@freebsd.ady.ro) _______________________________________________________________________ | Programming in BASIC causes brain damage. | | (Edsger Wybe Dijkstra) | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Fri Mar 22 15:21:40 2002 Delivered-To: freebsd-arch@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id D6DBA37B404 for ; Fri, 22 Mar 2002 15:21:37 -0800 (PST) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g2MNLaYm002134; Fri, 22 Mar 2002 15:21:36 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g2MNKLTU001235; Fri, 22 Mar 2002 15:20:21 -0800 (PST) Date: Fri, 22 Mar 2002 15:20:21 -0800 From: "David O'Brien" To: Terry Lambert Cc: arch@freebsd.org Subject: Re: Objections to rm'ing the libc/mips* bits? Message-ID: <20020322152021.A1201@dragon.nuxi.com> Reply-To: obrien@freebsd.org References: <20020322140503.A16857@dragon.nuxi.com> <3C9BADE9.4ADC072D@mindspring.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3C9BADE9.4ADC072D@mindspring.com>; from tlambert2@mindspring.com on Fri, Mar 22, 2002 at 02:19:21PM -0800 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Mar 22, 2002 at 02:19:21PM -0800, Terry Lambert wrote: > David O'Brien wrote: > > > > Are there any objections to totally removing all the mips bits from libc? > > They are part of an abortive porting effort. > > I thought the DEveloper's Summit at BSDCon indicated that > there was a completed MIPS port, and that it just had not > been integrated back into the tree yet? Should there be one, I am sure they have a working set of libc bits, and stale WIP we have in libc would only get in the way. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Fri Mar 22 16:42:37 2002 Delivered-To: freebsd-arch@freebsd.org Received: from albatross.prod.itd.earthlink.net (albatross.mail.pas.earthlink.net [207.217.120.120]) by hub.freebsd.org (Postfix) with ESMTP id AE77637B41A; Fri, 22 Mar 2002 16:42:28 -0800 (PST) Received: from pool0381.cvx40-bradley.dialup.earthlink.net ([216.244.43.126] helo=mindspring.com) by albatross.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16oZbv-0004FB-00; Fri, 22 Mar 2002 16:42:19 -0800 Message-ID: <3C9BCF57.625FEE86@mindspring.com> Date: Fri, 22 Mar 2002 16:41:59 -0800 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: obrien@freebsd.org Cc: arch@freebsd.org Subject: Re: Objections to rm'ing the libc/mips* bits? References: <20020322140503.A16857@dragon.nuxi.com> <3C9BADE9.4ADC072D@mindspring.com> <20020322152021.A1201@dragon.nuxi.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG David O'Brien wrote: > > > Are there any objections to totally removing all the mips bits from libc? > > > They are part of an abortive porting effort. > > > > I thought the DEveloper's Summit at BSDCon indicated that > > there was a completed MIPS port, and that it just had not > > been integrated back into the tree yet? > > Should there be one, I am sure they have a working set of libc bits, and > stale WIP we have in libc would only get in the way. Heh. I thought for sure that this was really a subtle way of kicking them in the arse to get them to clean up and commit their code... 8-). -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sat Mar 23 9:39:12 2002 Delivered-To: freebsd-arch@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 7AA4B37B419; Sat, 23 Mar 2002 09:39:10 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g2NHd9i96735; Sat, 23 Mar 2002 10:39:09 -0700 (MST) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g2NHd8L35326; Sat, 23 Mar 2002 10:39:08 -0700 (MST) (envelope-from imp@village.org) Date: Sat, 23 Mar 2002 10:39:01 -0700 (MST) Message-Id: <20020323.103901.14815156.imp@village.org> To: arch@FreeBSD.ORG, obrien@FreeBSD.ORG Subject: Re: Objections to rm'ing the libc/mips* bits? From: "M. Warner Losh" In-Reply-To: <20020322140503.A16857@dragon.nuxi.com> References: <20020322140503.A16857@dragon.nuxi.com> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20020322140503.A16857@dragon.nuxi.com> "David O'Brien" writes: : Are there any objections to totally removing all the mips bits from libc? : They are part of an abortive porting effort. Kill them. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sat Mar 23 9:40:44 2002 Delivered-To: freebsd-arch@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 01BB037B400; Sat, 23 Mar 2002 09:40:42 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g2NHeei96758; Sat, 23 Mar 2002 10:40:40 -0700 (MST) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g2NHedL35351; Sat, 23 Mar 2002 10:40:39 -0700 (MST) (envelope-from imp@village.org) Date: Sat, 23 Mar 2002 10:40:33 -0700 (MST) Message-Id: <20020323.104033.40265569.imp@village.org> To: tlambert2@mindspring.com Cc: obrien@FreeBSD.ORG, arch@FreeBSD.ORG Subject: Re: Objections to rm'ing the libc/mips* bits? From: "M. Warner Losh" In-Reply-To: <3C9BCF57.625FEE86@mindspring.com> References: <3C9BADE9.4ADC072D@mindspring.com> <20020322152021.A1201@dragon.nuxi.com> <3C9BCF57.625FEE86@mindspring.com> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <3C9BCF57.625FEE86@mindspring.com> Terry Lambert writes: : I thought for sure that this was really a subtle way of : kicking them in the arse to get them to clean up and : commit their code... 8-). i started the mips port before all my time got sucked up in pccard stuff, and am unlikely to finish. They should be removed from the tree. If there are others that are doing a mips port, then they will almost certainly need radically different bits to make it work. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sat Mar 23 11:28:52 2002 Delivered-To: freebsd-arch@freebsd.org Received: from aldan.algebra.com (aldan.algebra.com [216.254.65.224]) by hub.freebsd.org (Postfix) with ESMTP id C713137B400 for ; Sat, 23 Mar 2002 11:28:49 -0800 (PST) Received: from aldan.algebra.com (localhost [127.0.0.1]) by aldan.algebra.com (8.12.2/8.12.2) with ESMTP id g2NJSaWw063344 for ; Sat, 23 Mar 2002 14:28:36 -0500 (EST) (envelope-from mi@aldan.algebra.com) Received: (from mi@localhost) by aldan.algebra.com (8.12.2/8.12.2/Submit) id g2NJSasb063343 for arch@FreeBSD.org; Sat, 23 Mar 2002 14:28:36 -0500 (EST) From: Mikhail Teterin Message-Id: <200203231928.g2NJSasb063343@aldan.algebra.com> Subject: review request for bin/11294 To: arch@FreeBSD.org Date: Sat, 23 Mar 2002 14:28:35 -0500 (EST) X-Face: %UW#n0|w>ydeGt/b@1-.UFP=K^~-:0f#O:D7w hJ5G_<5143Bb3kOIs9XpX+"V+~$adGP:J|SLieM31VIhqXeLBli" List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG The PR is nearly 3 years old. Could someone, please, review the proposed improvement: http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/11294 IMHO, it may be usefull for an embedded installation, that does not want to run syslogd locally, but wishes to be able to log messages to a remote host. Thanks! -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sat Mar 23 11:39:25 2002 Delivered-To: freebsd-arch@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id E069437B419 for ; Sat, 23 Mar 2002 11:39:19 -0800 (PST) Received: by elvis.mu.org (Postfix, from userid 1192) id B66CEAE026; Sat, 23 Mar 2002 11:39:19 -0800 (PST) Date: Sat, 23 Mar 2002 11:39:19 -0800 From: Alfred Perlstein To: Mikhail Teterin Cc: arch@FreeBSD.org Subject: Re: review request for bin/11294 Message-ID: <20020323193919.GT10521@elvis.mu.org> References: <200203231928.g2NJSasb063343@aldan.algebra.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200203231928.g2NJSasb063343@aldan.algebra.com> User-Agent: Mutt/1.3.27i Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Mikhail Teterin [020323 11:29] wrote: > The PR is nearly 3 years old. Could someone, please, review the proposed > improvement: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/11294 > > IMHO, it may be usefull for an embedded installation, that does not want > to run syslogd locally, but wishes to be able to log messages to a remote > host. Wouldn't it make sense to just do this via a config file of some sort? This would allow one to modify behavior without recompiling the binaries. :) -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sat Mar 23 11:41:12 2002 Delivered-To: freebsd-arch@freebsd.org Received: from fep02-mail.bloor.is.net.cable.rogers.com (fep02-mail.bloor.is.net.cable.rogers.com [66.185.86.72]) by hub.freebsd.org (Postfix) with ESMTP id DC6E837B417 for ; Sat, 23 Mar 2002 11:41:08 -0800 (PST) Received: from hyperion ([24.156.109.151]) by fep02-mail.bloor.is.net.cable.rogers.com (InterMail vM.5.01.04.06 201-253-122-122-106-20020109) with ESMTP id <20020323194105.CWXD5628.fep02-mail.bloor.is.net.cable.rogers.com@hyperion>; Sat, 23 Mar 2002 14:41:05 -0500 Date: Sat, 23 Mar 2002 14:41:09 -0500 Subject: Re: review request for bin/11294 Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v481) Cc: arch@FreeBSD.org To: Mikhail Teterin From: Joe Abley In-Reply-To: <200203231928.g2NJSasb063343@aldan.algebra.com> Message-Id: Content-Transfer-Encoding: 7bit X-Mailer: Apple Mail (2.481) X-Authentication-Info: Submitted using SMTP AUTH PLAIN at fep02-mail.bloor.is.net.cable.rogers.com from [24.156.109.151] using ID at Sat, 23 Mar 2002 14:41:05 -0500 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Saturday, March 23, 2002, at 02:28 , Mikhail Teterin wrote: > The PR is nearly 3 years old. Could someone, please, review the proposed > improvement: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/11294 the -h option to logger(1) is present in 4-STABLE. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sat Mar 23 11:57:14 2002 Delivered-To: freebsd-arch@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id D047637B41A for ; Sat, 23 Mar 2002 11:57:11 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id D4B4F5347; Sat, 23 Mar 2002 20:57:09 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Mikhail Teterin Cc: arch@FreeBSD.org Subject: Re: review request for bin/11294 References: <200203231928.g2NJSasb063343@aldan.algebra.com> From: Dag-Erling Smorgrav Date: 23 Mar 2002 20:57:09 +0100 In-Reply-To: <200203231928.g2NJSasb063343@aldan.algebra.com> Message-ID: Lines: 25 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Mikhail Teterin writes: > The PR is nearly 3 years old. Could someone, please, review the proposed > improvement: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/11294 The idea is good but the implementation sucks. It should be possible to configure syslog(3) to send to a remote host, without the need for new library functions. This could be done by modifying connectlog() to check a config file (or just a symlink in /etc, malloc.conf(5)- style) and open a UDP socket instead of a Unix socket. You can set the default destination address for a datagram socket with connect(2), so vsyslog(3) doesn't need to know anything about it. Of course, this assumes that the syslog(3) packet format is the same for local and remote logging. We also need to somehow fix the problem where rapid bursts of messages will overflow the syslogd(8) socket and end up on the console instead (this forced me to disable debugging messages in the default libpam build; messages that syslogd(8) would normally have suppressed ended up on the console). I'm not sure how to fix it, though. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sat Mar 23 12:20:21 2002 Delivered-To: freebsd-arch@freebsd.org Received: from aldan.algebra.com (aldan.algebra.com [216.254.65.224]) by hub.freebsd.org (Postfix) with ESMTP id 6101537B404 for ; Sat, 23 Mar 2002 12:20:19 -0800 (PST) Received: from aldan.algebra.com (localhost [127.0.0.1]) by aldan.algebra.com (8.12.2/8.12.2) with ESMTP id g2NKJvWx063518; Sat, 23 Mar 2002 15:20:03 -0500 (EST) (envelope-from mi@aldan.algebra.com) Message-Id: <200203232020.g2NKJvWx063518@aldan.algebra.com> Date: Sat, 23 Mar 2002 15:19:57 -0500 (EST) From: Mikhail Teterin Subject: Re: review request for bin/11294 To: jabley@automagic.org Cc: arch@FreeBSD.org In-Reply-To: MIME-Version: 1.0 Content-Type: TEXT/plain; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 23 Mar, Joe Abley wrote: > > On Saturday, March 23, 2002, at 02:28 , Mikhail Teterin wrote: > >> The PR is nearly 3 years old. Could someone, please, review the proposed >> improvement: >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/11294 > > the -h option to logger(1) is present in 4-STABLE. It is, but the needed functionality is implemented entirely in the logger(1) itself. So for another program to have it, it needs to implement its own. Back three years ago, I needed to do such a thing, and figured this is something, that should be available system-wide. Hence this PR... -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sat Mar 23 14:52:51 2002 Delivered-To: freebsd-arch@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 19F2737B417 for ; Sat, 23 Mar 2002 14:52:46 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id C5B5A5346; Sat, 23 Mar 2002 23:52:43 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Mikhail Teterin Cc: arch@FreeBSD.org Subject: Re: review request for bin/11294 References: <200203231928.g2NJSasb063343@aldan.algebra.com> From: Dag-Erling Smorgrav Date: 23 Mar 2002 23:52:42 +0100 In-Reply-To: Message-ID: Lines: 9 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --=-=-= Here's a patch. To log to a remote host, make /etc/loghost a symlink to its name or IP address ('ln -fs 10.0.5.14 /etc/loghost'). DES -- Dag-Erling Smorgrav - des@ofug.org --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=syslog.diff Index: lib/libc/gen/syslog.c =================================================================== RCS file: /home/ncvs/src/lib/libc/gen/syslog.c,v retrieving revision 1.25 diff -u -r1.25 syslog.c --- lib/libc/gen/syslog.c 9 Mar 2002 11:38:01 -0000 1.25 +++ lib/libc/gen/syslog.c 23 Mar 2002 22:49:07 -0000 @@ -38,7 +38,7 @@ __FBSDID("$FreeBSD: src/lib/libc/gen/syslog.c,v 1.25 2002/03/09 11:38:01 dwmalone Exp $"); #include "namespace.h" -#include +#include #include #include #include @@ -71,6 +71,8 @@ static void disconnectlog(void); /* disconnect from syslogd */ static void connectlog(void); /* (re)connect to syslogd */ +static void connectlog_remote(const char *); +static void connectlog_local(void); /* * Format of the magic cookie passed through the stdio hook @@ -274,6 +276,7 @@ (void)_close(fd); } } + static void disconnectlog() { @@ -289,8 +292,61 @@ connected = 0; /* retry connect */ } +#define _PATH_LOGHOST "/etc/loghost" static void connectlog() +{ + char loghost[MAXHOSTNAMELEN]; + int len; + + if (LogFile != -1 && connected) + return; + if (LogFile != -1) { + _close(LogFile); + LogFile = -1; + } + connected = 0; + len = _readlink(_PATH_LOGHOST, loghost, sizeof loghost); + if (len > 0 && len < sizeof loghost) { + loghost[len] = '\0'; + connectlog_remote(loghost); + } + if (!connected) + connectlog_local(); +} + +#define SYSLOG_SERVICE "syslog" +static void +connectlog_remote(const char *host) +{ + struct addrinfo hints, *res = NULL; + + memset(&hints, 0, sizeof hints); + hints.ai_family = AF_UNSPEC; + hints.ai_socktype = SOCK_DGRAM; + hints.ai_protocol = PF_UNSPEC; + if (getaddrinfo(host, SYSLOG_SERVICE, &hints, &res) != 0) + goto fail; + LogFile = socket(res->ai_family, res->ai_socktype, res->ai_protocol); + if (LogFile == -1) + goto fail; + if (connect(LogFile, res->ai_addr, res->ai_addrlen) == -1) + goto fail; + (void)_fcntl(LogFile, F_SETFD, 1); + freeaddrinfo(res); + connected = 1; + return; + fail: + if (res != NULL) + freeaddrinfo(res); + if (LogFile != -1) { + _close(LogFile); + LogFile = 1; + } +} + +static void +connectlog_local() { struct sockaddr_un SyslogAddr; /* AF_UNIX address of local logger */ --=-=-=-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sat Mar 23 16:37:29 2002 Delivered-To: freebsd-arch@freebsd.org Received: from aldan.algebra.com (aldan.algebra.com [216.254.65.224]) by hub.freebsd.org (Postfix) with ESMTP id 7DCE137B419 for ; Sat, 23 Mar 2002 16:37:26 -0800 (PST) Received: from aldan.algebra.com (localhost [127.0.0.1]) by aldan.algebra.com (8.12.2/8.12.2) with ESMTP id g2O0b7Wx064444; Sat, 23 Mar 2002 19:37:11 -0500 (EST) (envelope-from mi@aldan.algebra.com) Message-Id: <200203240037.g2O0b7Wx064444@aldan.algebra.com> Date: Sat, 23 Mar 2002 19:37:07 -0500 (EST) From: Mikhail Teterin Subject: Re: review request for bin/11294 To: des@ofug.org Cc: arch@FreeBSD.org In-Reply-To: MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 23 Mar, Dag-Erling Smorgrav wrote: > Here's a patch. To log to a remote host, make /etc/loghost a symlink > to its name or IP address ('ln -fs 10.0.5.14 /etc/loghost'). But this implementation has drawbacks, that mine does not, IMHO: . the configuration is system wide -- which is not neccessarily desirable; . logger(1) -- and any other application, which wants this functionalitystill needs its own implementation; Most importantly, however, your design goal (allow to specify loghost different from localhost) is different from mine. I wanted to add an API call to log directly to another host -- at an application's discretion... My API call will not even add any new bloat to the OS -- whatever is added to the libc is removed from the logger(1) :-) Your idea (and a similar one by Joe Abley, where an env-variable is used instead of a symlink) can then be implemented using this same new API call I proposed. -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message From owner-freebsd-arch Sat Mar 23 21: 4:30 2002 Delivered-To: freebsd-arch@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id CA29E37B419 for ; Sat, 23 Mar 2002 21:04:27 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 5E1AF5346; Sun, 24 Mar 2002 06:04:20 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Mikhail Teterin Cc: arch@FreeBSD.org Subject: Re: review request for bin/11294 References: <200203240037.g2O0b7Wx064444@aldan.algebra.com> From: Dag-Erling Smorgrav Date: 24 Mar 2002 06:04:20 +0100 In-Reply-To: <200203240037.g2O0b7Wx064444@aldan.algebra.com> Message-ID: Lines: 14 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Mikhail Teterin writes: > But this implementation has drawbacks, that mine does not, IMHO: > > . the configuration is system wide -- which is not neccessarily > desirable; > [...] This and all your other objections can be fixed using a global variable that overrides the symlink (or an API function that sets the target host). DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message