From owner-freebsd-new-bus Tue Oct 8 8:48:38 2002 Delivered-To: freebsd-new-bus@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1144437B410 for ; Tue, 8 Oct 2002 08:48:38 -0700 (PDT) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC19743E42 for ; Tue, 8 Oct 2002 08:48:37 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 7466 invoked from network); 8 Oct 2002 15:48:34 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 8 Oct 2002 15:48:34 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id g98FmNn5006400 for ; Tue, 8 Oct 2002 11:48:25 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Date: Tue, 08 Oct 2002 11:48:27 -0400 (EDT) From: John Baldwin To: new-bus@FreeBSD.org Subject: BUS_ACCESSOR is busted at best Sender: owner-freebsd-new-bus@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Ok, so what happens if BUS_READ_IVAR or BUS_WRITE_IVAR fails? For the WRITE_IVAR case we just silently fail. How nice. For the READ_IVAR case we return garbage. I think we should change the bus accessors to return the error code from the BUS method and have read_ivar accept a pointer to the right type. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-new-bus" in the body of the message