From owner-cvs-src@FreeBSD.ORG Sun Jul 20 02:14:16 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FEA337B401; Sun, 20 Jul 2003 02:14:16 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2ADC443F85; Sun, 20 Jul 2003 02:14:16 -0700 (PDT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6K9EG0U006494; Sun, 20 Jul 2003 02:14:16 -0700 (PDT) (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6K9EF3h006493; Sun, 20 Jul 2003 02:14:15 -0700 (PDT) Message-Id: <200307200914.h6K9EF3h006493@repoman.freebsd.org> From: Christian Brueffer Date: Sun, 20 Jul 2003 02:14:15 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/usr.sbin/lpr/lpr printcap.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 09:14:17 -0000 brueffer 2003/07/20 02:14:15 PDT FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_4) usr.sbin/lpr/lpr printcap.5 Log: MFC: 1.30 Fix a grammar bogon and a typo Revision Changes Path 1.16.2.12 +1 -1 src/usr.sbin/lpr/lpr/printcap.5 From owner-cvs-src@FreeBSD.ORG Sun Jul 20 03:24:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1431837B401; Sun, 20 Jul 2003 03:24:10 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A76FA43F85; Sun, 20 Jul 2003 03:24:09 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6KAO90U009944; Sun, 20 Jul 2003 03:24:09 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6KAO9tk009943; Sun, 20 Jul 2003 03:24:09 -0700 (PDT) Message-Id: <200307201024.h6KAO9tk009943@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 20 Jul 2003 03:24:09 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/bin/ed Makefile re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 10:24:10 -0000 ru 2003/07/20 03:24:09 PDT FreeBSD src repository Modified files: bin/ed Makefile re.c Log: Make this code WARNS=6 clean again (after GCC 3.1.1 import). Submitted by: Marius Strobl Revision Changes Path 1.27 +0 -1 src/bin/ed/Makefile 1.20 +13 -13 src/bin/ed/re.c From owner-cvs-src@FreeBSD.ORG Sun Jul 20 04:27:55 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD49937B401; Sun, 20 Jul 2003 04:27:55 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5840C43FA3; Sun, 20 Jul 2003 04:27:55 -0700 (PDT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6KBRt0U012881; Sun, 20 Jul 2003 04:27:55 -0700 (PDT) (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6KBRtIG012880; Sun, 20 Jul 2003 04:27:55 -0700 (PDT) Message-Id: <200307201127.h6KBRtIG012880@repoman.freebsd.org> From: "Tim J. Robbins" Date: Sun, 20 Jul 2003 04:27:55 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/smbfs/mount_smbfs mount_smbfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 11:27:56 -0000 tjr 2003/07/20 04:27:55 PDT FreeBSD src repository Modified files: contrib/smbfs/mount_smbfs mount_smbfs.c Log: Pass getvfsbyname() the address of a struct xvfsconf instead of struct vfsconf. This silences a warning, but could also prevent stack corruption problems if xvfsconf ever became larger than vfsconf. PR: 53863 Submitted by: Lukas Ertl Revision Changes Path 1.2 +24 -10 src/contrib/smbfs/mount_smbfs/mount_smbfs.c From owner-cvs-src@FreeBSD.ORG Sun Jul 20 04:57:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B4E737B404; Sun, 20 Jul 2003 04:57:33 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id B434A43FAF; Sun, 20 Jul 2003 04:57:30 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id VAA22351; Sun, 20 Jul 2003 21:57:27 +1000 Date: Sun, 20 Jul 2003 21:57:26 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Ruslan Ermilov In-Reply-To: <200307201024.h6KAO9tk009943@repoman.freebsd.org> Message-ID: <20030720213903.J595@gamplex.bde.org> References: <200307201024.h6KAO9tk009943@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ed Makefile re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 11:57:34 -0000 On Sun, 20 Jul 2003, Ruslan Ermilov wrote: > ru 2003/07/20 03:24:09 PDT > > FreeBSD src repository > > Modified files: > bin/ed Makefile re.c > Log: > Make this code WARNS=6 clean again (after GCC 3.1.1 import). gcc-3.3? The bug is in gcc-3.3, so it shouldn't be fixed here. `expr' may be a better variable name than `exp' for a variable related to expressions, but this is just a minor style issue. pwd/pwd.c has regressed similarly (except 'lg' is a worse variable name than `log' for a variable related to "logical"). I think we mostly avoided mangling variables named `sin' but there are some of these to demangle too. Bruce From owner-cvs-src@FreeBSD.ORG Sun Jul 20 05:04:47 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 83C4337B401; Sun, 20 Jul 2003 05:04:47 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D06C43F3F; Sun, 20 Jul 2003 05:04:44 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6KC4c0U051783 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 20 Jul 2003 15:04:41 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6KC4cah051782; Sun, 20 Jul 2003 15:04:38 +0300 (EEST) (envelope-from ru) Date: Sun, 20 Jul 2003 15:04:38 +0300 From: Ruslan Ermilov To: Bruce Evans Message-ID: <20030720120438.GD47250@sunbay.com> References: <200307201024.h6KAO9tk009943@repoman.freebsd.org> <20030720213903.J595@gamplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+KJYzRxRHjYqLGl5" Content-Disposition: inline In-Reply-To: <20030720213903.J595@gamplex.bde.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ed Makefile re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 12:04:48 -0000 --+KJYzRxRHjYqLGl5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 20, 2003 at 09:57:26PM +1000, Bruce Evans wrote: > On Sun, 20 Jul 2003, Ruslan Ermilov wrote: >=20 > > ru 2003/07/20 03:24:09 PDT > > > > FreeBSD src repository > > > > Modified files: > > bin/ed Makefile re.c > > Log: > > Make this code WARNS=3D6 clean again (after GCC 3.1.1 import). >=20 > gcc-3.3? >=20 Typo. > The bug is in gcc-3.3, so it shouldn't be fixed here. `expr' may > be a better variable name than `exp' for a variable related to > expressions, but this is just a minor style issue. >=20 Why is this a bug in gcc? Compiling re.c,v 1.19 like this works: make WARNS=3D6 re.o DEBUG_FLAGS=3D-fno-builtin > pwd/pwd.c has regressed similarly (except 'lg' is a worse variable > name than `log' for a variable related to "logical"). >=20 > I think we mostly avoided mangling variables named `sin' but there > are some of these to demangle too. --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --+KJYzRxRHjYqLGl5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/GoVWUkv4P6juNwoRArlIAJ9Y3s/TvZBD66cUbGvdgvzpFk3fkACfQFq+ nAOk67TE4gnokmZlQs0EAZ0= =7SPA -----END PGP SIGNATURE----- --+KJYzRxRHjYqLGl5-- From owner-cvs-src@FreeBSD.ORG Sun Jul 20 05:26:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3281C37B401; Sun, 20 Jul 2003 05:26:25 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3D6643F3F; Sun, 20 Jul 2003 05:26:24 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6KCQO0U021320; Sun, 20 Jul 2003 05:26:24 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6KCQO2O021319; Sun, 20 Jul 2003 05:26:24 -0700 (PDT) Message-Id: <200307201226.h6KCQO2O021319@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 20 Jul 2003 05:26:24 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/bin/ed Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 12:26:25 -0000 ru 2003/07/20 05:26:24 PDT FreeBSD src repository Modified files: bin/ed Makefile Log: This code isn't WARNS=6 clean in the standard (crypto) case due to bugs in OpenSSL headers. I was testing in the wrong environmement: standalone build without crypto/ sources. Revision Changes Path 1.28 +1 -0 src/bin/ed/Makefile From owner-cvs-src@FreeBSD.ORG Sun Jul 20 05:38:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47F6037B401; Sun, 20 Jul 2003 05:38:30 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D60D043F93; Sun, 20 Jul 2003 05:38:29 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6KCcT0U021916; Sun, 20 Jul 2003 05:38:29 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6KCcTtU021915; Sun, 20 Jul 2003 05:38:29 -0700 (PDT) Message-Id: <200307201238.h6KCcTtU021915@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 20 Jul 2003 05:38:29 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 12:38:30 -0000 ru 2003/07/20 05:38:29 PDT FreeBSD src repository Modified files: . Makefile Log: The `mk' target is long dead. Revision Changes Path 1.286 +1 -1 src/Makefile From owner-cvs-src@FreeBSD.ORG Sun Jul 20 05:41:39 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB6CC37B401; Sun, 20 Jul 2003 05:41:39 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4635343F3F; Sun, 20 Jul 2003 05:41:39 -0700 (PDT) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6KCfd0U022097; Sun, 20 Jul 2003 05:41:39 -0700 (PDT) (envelope-from deischen@repoman.freebsd.org) Received: (from deischen@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6KCfcVw022096; Sun, 20 Jul 2003 05:41:38 -0700 (PDT) Message-Id: <200307201241.h6KCfcVw022096@repoman.freebsd.org> From: Daniel Eischen Date: Sun, 20 Jul 2003 05:41:38 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/arch/amd64/include pthread_md.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 12:41:40 -0000 deischen 2003/07/20 05:41:38 PDT FreeBSD src repository Modified files: lib/libpthread/arch/amd64/include pthread_md.h Log: Add missing arguments to _amd64_restore_context() when called from THR_SETCONTEXT(). Revision Changes Path 1.2 +4 -2 src/lib/libpthread/arch/amd64/include/pthread_md.h From owner-cvs-src@FreeBSD.ORG Sun Jul 20 12:32:19 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A0E437B401; Sun, 20 Jul 2003 12:32:19 -0700 (PDT) Received: from mail.broadpark.no (mail.broadpark.no [217.13.4.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1D6A743FA3; Sun, 20 Jul 2003 12:32:18 -0700 (PDT) (envelope-from des@des.no) Received: from smtp.des.no (37.80-203-228.nextgentel.com [80.203.228.37]) by mail.broadpark.no (Postfix) with ESMTP id 905FB7888D; Sun, 20 Jul 2003 21:32:16 +0200 (MEST) Received: by smtp.des.no (Pony Express, from userid 666) id 5A5F795957; Sun, 20 Jul 2003 21:32:16 +0200 (CEST) Received: from dwp.des.no (dwp.des.no [10.0.0.4]) by smtp.des.no (Pony Express) with ESMTP id C065E95954; Sun, 20 Jul 2003 21:32:12 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id A104DB822; Sun, 20 Jul 2003 21:32:12 +0200 (CEST) To: Ruslan Ermilov References: <200307201024.h6KAO9tk009943@repoman.freebsd.org> <20030720213903.J595@gamplex.bde.org> <20030720120438.GD47250@sunbay.com> From: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) Date: Sun, 20 Jul 2003 21:32:12 +0200 In-Reply-To: <20030720120438.GD47250@sunbay.com> (Ruslan Ermilov's message of "Sun, 20 Jul 2003 15:04:38 +0300") Message-ID: User-Agent: Gnus/5.090024 (Oort Gnus v0.24) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, hits=-3.0 required=8.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES,USER_AGENT_GNUS_UA version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Bruce Evans Subject: Re: cvs commit: src/bin/ed Makefile re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 19:32:20 -0000 Ruslan Ermilov writes: > On Sun, Jul 20, 2003 at 09:57:26PM +1000, Bruce Evans wrote: > > The bug is in gcc-3.3, so it shouldn't be fixed here. > Why is this a bug in gcc? Compiling re.c,v 1.19 like this works: > > make WARNS=3D6 re.o DEBUG_FLAGS=3D-fno-builtin It *is* a bug in GCC; -fno-builtin should be the default, and / or GCC should learn not to define builtins unless an appropriate prototype is in scope. It is incorrect for the compiler to reserve names like sin, log or exp in compilation units that don't #include . DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Sun Jul 20 13:31:19 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3982F37B401; Sun, 20 Jul 2003 13:31:19 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 896F343FA3; Sun, 20 Jul 2003 13:31:18 -0700 (PDT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6KKVI0U057089; Sun, 20 Jul 2003 13:31:18 -0700 (PDT) (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6KKVIkg057088; Sun, 20 Jul 2003 13:31:18 -0700 (PDT) Message-Id: <200307202031.h6KKVIkg057088@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Sun, 20 Jul 2003 13:31:18 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/calendar/calendars calendar.freebsd X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 20:31:19 -0000 simon 2003/07/20 13:31:18 PDT FreeBSD src repository (doc committer) Modified files: usr.bin/calendar/calendars calendar.freebsd Log: Add my birthday to the calendar. Approved by: ceri (mentor) Revision Changes Path 1.103 +1 -0 src/usr.bin/calendar/calendars/calendar.freebsd From owner-cvs-src@FreeBSD.ORG Sun Jul 20 14:11:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1877537B401; Sun, 20 Jul 2003 14:11:33 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B6CB43FBF; Sun, 20 Jul 2003 14:11:32 -0700 (PDT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6KLBW0U059571; Sun, 20 Jul 2003 14:11:32 -0700 (PDT) (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6KLBWpp059570; Sun, 20 Jul 2003 14:11:32 -0700 (PDT) Message-Id: <200307202111.h6KLBWpp059570@repoman.freebsd.org> From: Nate Lawson Date: Sun, 20 Jul 2003 14:11:32 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/acpica acpi_ec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 21:11:33 -0000 njl 2003/07/20 14:11:32 PDT FreeBSD src repository Modified files: sys/dev/acpica acpi_ec.c Log: Close a race condition by passing status retrieved via a non-SCI call to EcGpeQueryHandler on to any waiting threads through the softc. Similar behavior was in the original version. Also: * Merge EcQuery into EcGpeQueryHandler to simplify locking * Hold EcLock from the initial read of the CSR down to the wakeup or until after the query command has been processed. * ec_gpebit only needs to be a UINT8 Revision Changes Path 1.35 +32 -43 src/sys/dev/acpica/acpi_ec.c From owner-cvs-src@FreeBSD.ORG Sun Jul 20 14:12:22 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA90737B401; Sun, 20 Jul 2003 14:12:22 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 47F7043F93; Sun, 20 Jul 2003 14:12:22 -0700 (PDT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6KLCM0U059615; Sun, 20 Jul 2003 14:12:22 -0700 (PDT) (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6KLCLiv059614; Sun, 20 Jul 2003 14:12:21 -0700 (PDT) Message-Id: <200307202112.h6KLCLiv059614@repoman.freebsd.org> From: Nate Lawson Date: Sun, 20 Jul 2003 14:12:21 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/acpica acpi_ec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 21:12:23 -0000 njl 2003/07/20 14:12:21 PDT FreeBSD src repository Modified files: sys/dev/acpica acpi_ec.c Log: Do not call acpi_MatchHid() for all probe cases since it accesses the namespace. To compensate for it only being used in the !ECDT case, use a more robust approach to indicate a device was probed via ECDT by setting the private ivar to be &acpi_ec_devclass. Without the acpi_MatchHid() call now, it might have been possible for a non-EC device to have had its magic match our previous flag. Pointed out by: takawata Revision Changes Path 1.36 +7 -8 src/sys/dev/acpica/acpi_ec.c From owner-cvs-src@FreeBSD.ORG Sun Jul 20 14:36:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 34CCF37B401; Sun, 20 Jul 2003 14:36:10 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CDF4343F93; Sun, 20 Jul 2003 14:36:09 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6KLa90U060420; Sun, 20 Jul 2003 14:36:09 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6KLa98q060419; Sun, 20 Jul 2003 14:36:09 -0700 (PDT) Message-Id: <200307202136.h6KLa98q060419@repoman.freebsd.org> From: Sam Leffler Date: Sun, 20 Jul 2003 14:36:09 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net80211 ieee80211.c ieee80211_input.c ieee80211_ioctl.c ieee80211_node.c ieee80211_node.h ieee80211_proto.c ieee80211_proto.h ieee80211_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 21:36:10 -0000 sam 2003/07/20 14:36:09 PDT FreeBSD src repository Modified files: sys/net80211 ieee80211.c ieee80211_input.c ieee80211_ioctl.c ieee80211_node.c ieee80211_node.h ieee80211_proto.c ieee80211_proto.h ieee80211_var.h Log: o change ieee80211_new_state handling to use a proper method that drivers override in their sub-class; this eliminates the hack of interpreting the EINPROGRESS return value to mean "don't do any of the normal work" o correct active scanning so the first channel is only scanned once and so per-channel passive mode is properly honored o expose 802.11 FSM state names so every driver doesn't keep a private copy o eliminate node parameter to ieee80211_begin_scan; it was not being used Revision Changes Path 1.5 +1 -1 src/sys/net80211/ieee80211.c 1.5 +10 -6 src/sys/net80211/ieee80211_input.c 1.4 +2 -2 src/sys/net80211/ieee80211_ioctl.c 1.4 +24 -18 src/sys/net80211/ieee80211_node.c 1.3 +1 -2 src/sys/net80211/ieee80211_node.h 1.3 +20 -21 src/sys/net80211/ieee80211_proto.c 1.3 +10 -6 src/sys/net80211/ieee80211_proto.h 1.3 +2 -1 src/sys/net80211/ieee80211_var.h From owner-cvs-src@FreeBSD.ORG Sun Jul 20 14:37:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B455037B401; Sun, 20 Jul 2003 14:37:33 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4B8AF43FAF; Sun, 20 Jul 2003 14:37:33 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6KLbX0U060475; Sun, 20 Jul 2003 14:37:33 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6KLbW1J060474; Sun, 20 Jul 2003 14:37:32 -0700 (PDT) Message-Id: <200307202137.h6KLbW1J060474@repoman.freebsd.org> From: Sam Leffler Date: Sun, 20 Jul 2003 14:37:32 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/wi if_wi.c if_wivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 21:37:34 -0000 sam 2003/07/20 14:37:32 PDT FreeBSD src repository Modified files: sys/dev/wi if_wi.c if_wivar.h Log: track changes to 802.11 code: o override new_state method per new model o use ieee80211_state_name instead of private copy Revision Changes Path 1.148 +21 -22 src/sys/dev/wi/if_wi.c 1.19 +2 -0 src/sys/dev/wi/if_wivar.h From owner-cvs-src@FreeBSD.ORG Sun Jul 20 14:38:21 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B18A737B401; Sun, 20 Jul 2003 14:38:21 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D36043F85; Sun, 20 Jul 2003 14:38:21 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6KLcL0U060562; Sun, 20 Jul 2003 14:38:21 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6KLcLbq060561; Sun, 20 Jul 2003 14:38:21 -0700 (PDT) Message-Id: <200307202138.h6KLcLbq060561@repoman.freebsd.org> From: Sam Leffler Date: Sun, 20 Jul 2003 14:38:21 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ath if_ath.c if_athvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 21:38:22 -0000 sam 2003/07/20 14:38:21 PDT FreeBSD src repository Modified files: sys/dev/ath if_ath.c if_athvar.h Log: track changes to 802.11 code: o override new_state method per new model o use ieee80211_state_name instead of private copy Revision Changes Path 1.4 +22 -22 src/sys/dev/ath/if_ath.c 1.3 +2 -0 src/sys/dev/ath/if_athvar.h From owner-cvs-src@FreeBSD.ORG Sun Jul 20 16:29:47 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F2EE37B401; Sun, 20 Jul 2003 16:29:47 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 188E843F93; Sun, 20 Jul 2003 16:29:47 -0700 (PDT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6KNTk0U066024; Sun, 20 Jul 2003 16:29:46 -0700 (PDT) (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6KNTknI066023; Sun, 20 Jul 2003 16:29:46 -0700 (PDT) Message-Id: <200307202329.h6KNTknI066023@repoman.freebsd.org> From: Mark Murray Date: Sun, 20 Jul 2003 16:29:46 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libtelnet Makefile src/libexec/telnetd Makefile src/usr.bin/telnet Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 23:29:47 -0000 markm 2003/07/20 16:29:46 PDT FreeBSD src repository Modified files: lib/libtelnet Makefile libexec/telnetd Makefile usr.bin/telnet Makefile Log: Test correct macro for "without crypto" option(s). Revision Changes Path 1.16 +1 -1 src/lib/libtelnet/Makefile 1.21 +1 -1 src/libexec/telnetd/Makefile 1.23 +1 -1 src/usr.bin/telnet/Makefile From owner-cvs-src@FreeBSD.ORG Sun Jul 20 17:23:54 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D5AF37B401; Sun, 20 Jul 2003 17:23:54 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 772EE43F75; Sun, 20 Jul 2003 17:23:53 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (smmsp@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h6L0Nqju084686; Sun, 20 Jul 2003 17:23:52 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h6KHZmvW083039; Sun, 20 Jul 2003 10:35:48 -0700 (PDT) Date: Sun, 20 Jul 2003 10:34:27 -0700 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20030720173427.GA83003@dragon.nuxi.com> References: <200307201024.h6KAO9tk009943@repoman.freebsd.org> <20030720213903.J595@gamplex.bde.org> <20030720120438.GD47250@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030720120438.GD47250@sunbay.com> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.1-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Bruce Evans Subject: Re: cvs commit: src/bin/ed Makefile re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 00:23:54 -0000 On Sun, Jul 20, 2003 at 03:04:38PM +0300, Ruslan Ermilov wrote: > > > ru 2003/07/20 03:24:09 PDT > > > FreeBSD src repository > > > > > > Modified files: > > > bin/ed Makefile re.c > > > Log: > > > Make this code WARNS=6 clean again (after GCC 3.1.1 import). > > > > gcc-3.3? > Typo. > > > The bug is in gcc-3.3, so it shouldn't be fixed here. `expr' may > > be a better variable name than `exp' for a variable related to > > expressions, but this is just a minor style issue. > Why is this a bug in gcc? Compiling re.c,v 1.19 like this works: > > make WARNS=6 re.o DEBUG_FLAGS=-fno-builtin Because exp as a built-in or from a lib, shouldn't be visable unless math.h is included. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Sun Jul 20 17:26:53 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0712D37B401; Sun, 20 Jul 2003 17:26:53 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99FE143F85; Sun, 20 Jul 2003 17:26:52 -0700 (PDT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6L0Qq0U074105; Sun, 20 Jul 2003 17:26:52 -0700 (PDT) (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6L0QqZH074104; Sun, 20 Jul 2003 17:26:52 -0700 (PDT) Message-Id: <200307210026.h6L0QqZH074104@repoman.freebsd.org> From: David Xu Date: Sun, 20 Jul 2003 17:26:52 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 00:26:53 -0000 davidxu 2003/07/20 17:26:52 PDT FreeBSD src repository Modified files: sys/kern kern_sig.c Log: Always deliver synchronous signal to UTS for SA threads. Revision Changes Path 1.253 +14 -2 src/sys/kern/kern_sig.c From owner-cvs-src@FreeBSD.ORG Sun Jul 20 19:41:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DD2137B401; Sun, 20 Jul 2003 19:41:02 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2868B43F85; Sun, 20 Jul 2003 19:41:02 -0700 (PDT) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6L2f10U080801; Sun, 20 Jul 2003 19:41:01 -0700 (PDT) (envelope-from jmg@repoman.freebsd.org) Received: (from jmg@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6L2f1rW080800; Sun, 20 Jul 2003 19:41:01 -0700 (PDT) Message-Id: <200307210241.h6L2f1rW080800@repoman.freebsd.org> From: John-Mark Gurney Date: Sun, 20 Jul 2003 19:41:01 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/usb usb_mem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 02:41:03 -0000 jmg 2003/07/20 19:41:01 PDT FreeBSD src repository Modified files: sys/dev/usb usb_mem.c Log: override the tag. usb_block_allocmem allocates a new tag, which when we go looking for free fragments won't match. Since we never free this, we can "throw away" the tag. This is very dirty, and needs to be reimplemented properly, but fixes performance problems with uhci. Also assert that when we overlay a structure on some space, that the space is large enough for the structure. Revision Changes Path 1.2 +5 -1 src/sys/dev/usb/usb_mem.c From owner-cvs-src@FreeBSD.ORG Sun Jul 20 19:47:05 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FAE237B401; Sun, 20 Jul 2003 19:47:05 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DCEE43FAF; Sun, 20 Jul 2003 19:47:05 -0700 (PDT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6L2l50U081032; Sun, 20 Jul 2003 19:47:05 -0700 (PDT) (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6L2l4lx081031; Sun, 20 Jul 2003 19:47:04 -0700 (PDT) Message-Id: <200307210247.h6L2l4lx081031@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 20 Jul 2003 19:47:04 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/rescue/rescue Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 02:47:05 -0000 obrien 2003/07/20 19:47:04 PDT FreeBSD src repository Modified files: rescue/rescue Makefile Log: Missed one, remove one more. Revision Changes Path 1.13 +1 -1 src/rescue/rescue/Makefile From owner-cvs-src@FreeBSD.ORG Sun Jul 20 19:48:36 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 64EB637B401; Sun, 20 Jul 2003 19:48:36 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 041B643F85; Sun, 20 Jul 2003 19:48:36 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6L2mZ0U081079; Sun, 20 Jul 2003 19:48:35 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6L2mZtC081078; Sun, 20 Jul 2003 19:48:35 -0700 (PDT) Message-Id: <200307210248.h6L2mZtC081078@repoman.freebsd.org> From: Sam Leffler Date: Sun, 20 Jul 2003 19:48:35 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net if_media.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 02:48:36 -0000 sam 2003/07/20 19:48:35 PDT FreeBSD src repository Modified files: sys/net if_media.h Log: add monitor mode Revision Changes Path 1.23 +2 -0 src/sys/net/if_media.h From owner-cvs-src@FreeBSD.ORG Sun Jul 20 19:49:43 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B690837B401; Sun, 20 Jul 2003 19:49:43 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0EFD343FA3; Sun, 20 Jul 2003 19:49:43 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6L2ng0U081138; Sun, 20 Jul 2003 19:49:42 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6L2ng2k081137; Sun, 20 Jul 2003 19:49:42 -0700 (PDT) Message-Id: <200307210249.h6L2ng2k081137@repoman.freebsd.org> From: Sam Leffler Date: Sun, 20 Jul 2003 19:49:42 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net80211 ieee80211.c ieee80211_input.c ieee80211_output.c ieee80211_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 02:49:44 -0000 sam 2003/07/20 19:49:42 PDT FreeBSD src repository Modified files: sys/net80211 ieee80211.c ieee80211_input.c ieee80211_output.c ieee80211_var.h Log: add monitor mode Revision Changes Path 1.6 +12 -0 src/sys/net80211/ieee80211.c 1.6 +7 -0 src/sys/net80211/ieee80211_input.c 1.3 +3 -0 src/sys/net80211/ieee80211_output.c 1.4 +3 -1 src/sys/net80211/ieee80211_var.h From owner-cvs-src@FreeBSD.ORG Sun Jul 20 20:12:07 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 678AF37B401; Sun, 20 Jul 2003 20:12:07 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5EF043FAF; Sun, 20 Jul 2003 20:12:06 -0700 (PDT) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6L3C60U082888; Sun, 20 Jul 2003 20:12:06 -0700 (PDT) (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6L3C6MA082887; Sun, 20 Jul 2003 20:12:06 -0700 (PDT) Message-Id: <200307210312.h6L3C6MA082887@repoman.freebsd.org> From: Mike Silbersack Date: Sun, 20 Jul 2003 20:12:06 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/kern uipc_mbuf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 03:12:07 -0000 silby 2003/07/20 20:12:06 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/kern uipc_mbuf.c Log: Add in the promised cluster refcount limit hack. (Not applicable to -current, which has int size refcounts.) 4.x uses char refcounts, which can be overflowed, causing neat panics. This patch works around the problem by hooking into every m_* function that increases the refcount and doing two things: 1. Panicing if the refcount went negative (perhaps due to some external function messing with the refcount.) 2. Making a full copy of the resulting chain in order to keep the refcount under a reasonable threshold if necessary. The kern.ipc.m_clreflimithits sysctl has been made available so that the number of times a copy had to be performed can be monitored. Luckily, this should not be a common occurance. Revision Changes Path 1.51.2.29 +43 -0 src/sys/kern/uipc_mbuf.c From owner-cvs-src@FreeBSD.ORG Sun Jul 20 22:34:13 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 020E037B401; Sun, 20 Jul 2003 22:34:13 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id C991543FAF; Sun, 20 Jul 2003 22:34:10 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id PAA22492; Mon, 21 Jul 2003 15:33:59 +1000 Date: Mon, 21 Jul 2003 15:33:58 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?= In-Reply-To: Message-ID: <20030721152032.X3132@gamplex.bde.org> References: <200307201024.h6KAO9tk009943@repoman.freebsd.org> <20030720213903.J595@gamplex.bde.org> <20030720120438.GD47250@sunbay.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN Content-Transfer-Encoding: QUOTED-PRINTABLE cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Ruslan Ermilov cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ed Makefile re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 05:34:13 -0000 On Sun, 20 Jul 2003, Dag-Erling [iso-8859-1] Sm=F8rgrav wrote: > Ruslan Ermilov writes: > > On Sun, Jul 20, 2003 at 09:57:26PM +1000, Bruce Evans wrote: > > > The bug is in gcc-3.3, so it shouldn't be fixed here. > > Why is this a bug in gcc? Compiling re.c,v 1.19 like this works: > > > > make WARNS=3D6 re.o DEBUG_FLAGS=3D-fno-builtin > > It *is* a bug in GCC; -fno-builtin should be the default, and / or GCC or (non-inclusive) > should learn not to define builtins unless an appropriate prototype is > in scope. It is incorrect for the compiler to reserve names like sin, > log or exp in compilation units that don't #include . Not quite. These names, like all names of existing or future identifiers with external linkage, are reserved for their normal (external linkage) purposes, so it would be OK for the compiler to warn about global and file-scope-static variables in the program with these names. It is just incorrect to warn about using these names in local variables when there cannot be any global declarations with the same name in scope except via undocumented namespace pollution (from compiler builtins in this case). Bruce From owner-cvs-src@FreeBSD.ORG Mon Jul 21 00:04:01 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9BD0137B401; Mon, 21 Jul 2003 00:04:01 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 368D743F3F; Mon, 21 Jul 2003 00:04:01 -0700 (PDT) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6L7400U099720; Mon, 21 Jul 2003 00:04:01 -0700 (PDT) (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6L7401d099719; Mon, 21 Jul 2003 00:04:00 -0700 (PDT) Message-Id: <200307210704.h6L7401d099719@repoman.freebsd.org> From: Mike Silbersack Date: Mon, 21 Jul 2003 00:04:00 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/kern uipc_mbuf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 07:04:02 -0000 silby 2003/07/21 00:04:00 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/kern uipc_mbuf.c Log: Fix a mixup in the previous commit; the m_clreflimithits variable / SYSCTL were not supposed to be under the MBUF_STRESS_TEST section. Noticed by: Igor B. Bykhalo Revision Changes Path 1.51.2.30 +2 -2 src/sys/kern/uipc_mbuf.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 00:51:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D82BB37B404; Mon, 21 Jul 2003 00:51:30 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70E3543F85; Mon, 21 Jul 2003 00:51:30 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6L7pU0U006903; Mon, 21 Jul 2003 00:51:30 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6L7pTU5006902; Mon, 21 Jul 2003 00:51:29 -0700 (PDT) Message-Id: <200307210751.h6L7pTU5006902@repoman.freebsd.org> From: Hartmut Brandt Date: Mon, 21 Jul 2003 00:51:29 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 patm.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 07:51:31 -0000 harti 2003/07/21 00:51:29 PDT FreeBSD src repository Modified files: share/man/man4 patm.4 Log: Always start new sentences on a new line. Submitted by: Anil Madhavapeddy Revision Changes Path 1.2 +36 -27 src/share/man/man4/patm.4 From owner-cvs-src@FreeBSD.ORG Mon Jul 21 02:56:06 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA34C37B401; Mon, 21 Jul 2003 02:56:06 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7773E43F85; Mon, 21 Jul 2003 02:56:06 -0700 (PDT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6L9u60U013123; Mon, 21 Jul 2003 02:56:06 -0700 (PDT) (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6L9u6cJ013122; Mon, 21 Jul 2003 02:56:06 -0700 (PDT) Message-Id: <200307210956.h6L9u6cJ013122@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 21 Jul 2003 02:56:06 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/ipfw ipfw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 09:56:07 -0000 maxim 2003/07/21 02:56:06 PDT FreeBSD src repository Modified files: sbin/ipfw ipfw2.c Log: o Initialize do_pipe before command parsing. PR: bin/54649 Submitted by: Andy Gilligan MFC after: 3 days Revision Changes Path 1.38 +1 -0 src/sbin/ipfw/ipfw2.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 03:43:38 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BE1F37B401; Mon, 21 Jul 2003 03:43:38 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1566043F3F; Mon, 21 Jul 2003 03:43:38 -0700 (PDT) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LAhb0U016073; Mon, 21 Jul 2003 03:43:37 -0700 (PDT) (envelope-from krion@repoman.freebsd.org) Received: (from krion@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LAhbET016072; Mon, 21 Jul 2003 03:43:37 -0700 (PDT) Message-Id: <200307211043.h6LAhbET016072@repoman.freebsd.org> From: Kirill Ponomarew Date: Mon, 21 Jul 2003 03:43:37 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/calendar/calendars calendar.freebsd X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 10:43:39 -0000 krion 2003/07/21 03:43:37 PDT FreeBSD src repository (ports committer) Modified files: usr.bin/calendar/calendars calendar.freebsd Log: Add my birthday to calendar Approved by: fjoe Revision Changes Path 1.104 +1 -0 src/usr.bin/calendar/calendars/calendar.freebsd From owner-cvs-src@FreeBSD.ORG Mon Jul 21 04:04:07 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 094C137B401; Mon, 21 Jul 2003 04:04:07 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99B8843F85; Mon, 21 Jul 2003 04:04:06 -0700 (PDT) (envelope-from akiyama@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LB460U017782; Mon, 21 Jul 2003 04:04:06 -0700 (PDT) (envelope-from akiyama@repoman.freebsd.org) Received: (from akiyama@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LB46Rl017781; Mon, 21 Jul 2003 04:04:06 -0700 (PDT) Message-Id: <200307211104.h6LB46Rl017781@repoman.freebsd.org> From: Shunsuke Akiyama Date: Mon, 21 Jul 2003 04:04:06 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/usb uplcom.c uvscom.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 11:04:07 -0000 akiyama 2003/07/21 04:04:06 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/usb uplcom.c uvscom.c Log: MFC: Apply some fixups in the driver_t's. uvisor.c: 1.11 uvscom.c: 1.15 Revision Changes Path 1.8.2.2 +1 -1 src/sys/dev/usb/uplcom.c 1.9.2.4 +1 -1 src/sys/dev/usb/uvscom.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 04:06:48 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A72C37B401; Mon, 21 Jul 2003 04:06:48 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 08DF643FAF; Mon, 21 Jul 2003 04:06:48 -0700 (PDT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LB6l0U018016; Mon, 21 Jul 2003 04:06:47 -0700 (PDT) (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LB6ltL018015; Mon, 21 Jul 2003 04:06:47 -0700 (PDT) Message-Id: <200307211106.h6LB6ltL018015@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 21 Jul 2003 04:06:47 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/ping6 ping6.c src/usr.sbin/traceroute6 traceroute6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 11:06:48 -0000 maxim 2003/07/21 04:06:47 PDT FreeBSD src repository Modified files: sbin/ping6 ping6.c usr.sbin/traceroute6 traceroute6.c Log: Quote from a Problem Report: The output format specifier for the round-trip time in ping6 should be changed to %.3f instead of %g since %g doesn't accurately represent the precision of the number being output. In particular, %g truncates trailing zeroes. 0.01 ms does not mean the same thing as 0.010 ms. Although they are numerically identical, they do not have the same precision. PR: bin/52324, bin/52750 Submitted by: dg MFC after: 1 week Revision Changes Path 1.23 +1 -1 src/sbin/ping6/ping6.c 1.12 +1 -1 src/usr.sbin/traceroute6/traceroute6.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 04:09:14 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 231E637B401; Mon, 21 Jul 2003 04:09:14 -0700 (PDT) Received: from castle.jp.FreeBSD.org (castle.jp.FreeBSD.org [210.226.20.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4755843F93; Mon, 21 Jul 2003 04:09:12 -0700 (PDT) (envelope-from akiyama@jp.FreeBSD.org) Received: from localhost (castle.jp.FreeBSD.org [2001:218:422:1::15]) h6LB9AT82457; Mon, 21 Jul 2003 20:09:10 +0900 (JST) (envelope-from akiyama@jp.FreeBSD.org) Date: Mon, 21 Jul 2003 20:09:06 +0900 From: Shunsuke Akiyama To: Shunsuke Akiyama In-Reply-To: <200307211104.h6LB46Rl017781@repoman.freebsd.org> References: <200307211104.h6LB46Rl017781@repoman.freebsd.org> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.5 Emacs/21.3 (i386--freebsd) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Message-Id: <20030721200907P.akiyama@jp.FreeBSD.org> X-Dispatcher: imput version 20030322(IM144) Lines: 26 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb uplcom.c uvscom.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 11:09:14 -0000 At Mon, 21 Jul 2003 04:04:06 -0700 (PDT), Shunsuke Akiyama wrote: > akiyama 2003/07/21 04:04:06 PDT > > FreeBSD src repository > > Modified files: (Branch: RELENG_4) > sys/dev/usb uplcom.c uvscom.c > Log: > MFC: Apply some fixups in the driver_t's. > > uvisor.c: 1.11 > uvscom.c: 1.15 Oops, wrong commit message. uplcom.c: 1.9 uvscom.c: 1.10 are correct one. Sorry. -- Shunsuke Akiyama akiyama@jp.FreeBSD.org akiyama@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Jul 21 04:29:43 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF93A37B401; Mon, 21 Jul 2003 04:29:43 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BCCE43FBF; Mon, 21 Jul 2003 04:29:43 -0700 (PDT) (envelope-from akiyama@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LBTh0U018849; Mon, 21 Jul 2003 04:29:43 -0700 (PDT) (envelope-from akiyama@repoman.freebsd.org) Received: (from akiyama@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LBThSX018848; Mon, 21 Jul 2003 04:29:43 -0700 (PDT) Message-Id: <200307211129.h6LBThSX018848@repoman.freebsd.org> From: Shunsuke Akiyama Date: Mon, 21 Jul 2003 04:29:43 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/usb uplcom.c uvscom.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 11:29:44 -0000 akiyama 2003/07/21 04:29:43 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/usb uplcom.c uvscom.c Log: Forced commit to note that the previous commit. Correct MFC revisions are: uplcom.c: 1.9 uvscom.c: 1.10 Revision Changes Path 1.8.2.3 +0 -0 src/sys/dev/usb/uplcom.c 1.9.2.5 +0 -0 src/sys/dev/usb/uvscom.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 04:39:21 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D300E37B401; Mon, 21 Jul 2003 04:39:21 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F38843F93; Mon, 21 Jul 2003 04:39:21 -0700 (PDT) (envelope-from akiyama@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LBdL0U019238; Mon, 21 Jul 2003 04:39:21 -0700 (PDT) (envelope-from akiyama@repoman.freebsd.org) Received: (from akiyama@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LBdLEM019237; Mon, 21 Jul 2003 04:39:21 -0700 (PDT) Message-Id: <200307211139.h6LBdLEM019237@repoman.freebsd.org> From: Shunsuke Akiyama Date: Mon, 21 Jul 2003 04:39:21 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/modules/uftdi Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 11:39:22 -0000 akiyama 2003/07/21 04:39:21 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/modules/uftdi Makefile Log: Add KMODDEPS on ucom. MODULE_DEPENDS works only on CURRENT. Revision Changes Path 1.1.2.2 +1 -0 src/sys/modules/uftdi/Makefile From owner-cvs-src@FreeBSD.ORG Mon Jul 21 04:45:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C4C4A37B401; Mon, 21 Jul 2003 04:45:25 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61AE243FA3; Mon, 21 Jul 2003 04:45:25 -0700 (PDT) (envelope-from akiyama@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LBjP0U019560; Mon, 21 Jul 2003 04:45:25 -0700 (PDT) (envelope-from akiyama@repoman.freebsd.org) Received: (from akiyama@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LBjPtN019559; Mon, 21 Jul 2003 04:45:25 -0700 (PDT) Message-Id: <200307211145.h6LBjPtN019559@repoman.freebsd.org> From: Shunsuke Akiyama Date: Mon, 21 Jul 2003 04:45:25 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/usb uftdi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 11:45:26 -0000 akiyama 2003/07/21 04:45:25 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/usb uftdi.c Log: MFC: The uftdi driver runs with multiple instances. Remove a comment claiming the opposite. uftdi.c: 1.4 Revision Changes Path 1.3.2.2 +0 -5 src/sys/dev/usb/uftdi.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 04:50:07 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 87E8837B401; Mon, 21 Jul 2003 04:50:07 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 249E743FBF; Mon, 21 Jul 2003 04:50:07 -0700 (PDT) (envelope-from akiyama@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LBo60U025028; Mon, 21 Jul 2003 04:50:06 -0700 (PDT) (envelope-from akiyama@repoman.freebsd.org) Received: (from akiyama@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LBo6xs025027; Mon, 21 Jul 2003 04:50:06 -0700 (PDT) Message-Id: <200307211150.h6LBo6xs025027@repoman.freebsd.org> From: Shunsuke Akiyama Date: Mon, 21 Jul 2003 04:50:06 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/usb uftdi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 11:50:08 -0000 akiyama 2003/07/21 04:50:06 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/usb uftdi.c Log: MFC: Fix duplicate sc_dying usage. uftdi.c: 1.7 Revision Changes Path 1.3.2.3 +6 -8 src/sys/dev/usb/uftdi.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 05:00:20 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C3DBC37B401; Mon, 21 Jul 2003 05:00:20 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6093643F93; Mon, 21 Jul 2003 05:00:20 -0700 (PDT) (envelope-from akiyama@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LC0K0U025459; Mon, 21 Jul 2003 05:00:20 -0700 (PDT) (envelope-from akiyama@repoman.freebsd.org) Received: (from akiyama@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LC0JED025458; Mon, 21 Jul 2003 05:00:19 -0700 (PDT) Message-Id: <200307211200.h6LC0JED025458@repoman.freebsd.org> From: Shunsuke Akiyama Date: Mon, 21 Jul 2003 05:00:19 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/usb ucom.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 12:00:21 -0000 akiyama 2003/07/21 05:00:19 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/usb ucom.c Log: MFC: Fix page fault with FTDI's USB serial device. Fix lost characters counting. Move setting receiver state to proper place on ucomstopread(). ucom.c: 1.29 Revision Changes Path 1.24.2.3 +23 -4 src/sys/dev/usb/ucom.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 05:19:24 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5543637B401; Mon, 21 Jul 2003 05:19:24 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3F5C43F75; Mon, 21 Jul 2003 05:19:23 -0700 (PDT) (envelope-from akiyama@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LCJN0U027047; Mon, 21 Jul 2003 05:19:23 -0700 (PDT) (envelope-from akiyama@repoman.freebsd.org) Received: (from akiyama@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LCJNeu027046; Mon, 21 Jul 2003 05:19:23 -0700 (PDT) Message-Id: <200307211219.h6LCJNeu027046@repoman.freebsd.org> From: Shunsuke Akiyama Date: Mon, 21 Jul 2003 05:19:23 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/conf options src/sys/dev/usb uvscom.c src/sys/i386/conf LINT src/sys/modules/uvscom Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 12:19:24 -0000 akiyama 2003/07/21 05:19:23 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/conf options sys/dev/usb uvscom.c sys/i386/conf LINT sys/modules/uvscom Makefile Log: MFC: Fix device freeze to reduce output packet size. And make this value configurable by kernel config or sysctl. options: 1.381 uvscom.c: 1.16 LINT: 1.1137 (from NOTES) Makefile: 1.2 Revision Changes Path 1.191.2.54 +1 -0 src/sys/conf/options 1.9.2.7 +33 -4 src/sys/dev/usb/uvscom.c 1.749.2.146 +3 -0 src/sys/i386/conf/LINT 1.1.2.3 +2 -1 src/sys/modules/uvscom/Makefile From owner-cvs-src@FreeBSD.ORG Mon Jul 21 06:00:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB63037B401; Mon, 21 Jul 2003 06:00:10 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58A0E43F3F; Mon, 21 Jul 2003 06:00:10 -0700 (PDT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LD0A0U028685; Mon, 21 Jul 2003 06:00:10 -0700 (PDT) (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LD09pR028684; Mon, 21 Jul 2003 06:00:09 -0700 (PDT) Message-Id: <200307211300.h6LD09pR028684@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Mon, 21 Jul 2003 06:00:09 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pc98/pc98 pc98gdc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 13:00:11 -0000 nyan 2003/07/21 06:00:09 PDT FreeBSD src repository Modified files: sys/pc98/pc98 pc98gdc.c Log: Supported the gdc_clear function. Submitted by: chi@bd.mbn.or.jp (Chiharu Shibata) Revision Changes Path 1.37 +57 -3 src/sys/pc98/pc98/pc98gdc.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 06:04:56 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AE8C37B401; Mon, 21 Jul 2003 06:04:56 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 21BC543FB1; Mon, 21 Jul 2003 06:04:56 -0700 (PDT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LD4t0U029925; Mon, 21 Jul 2003 06:04:55 -0700 (PDT) (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LD4tiS029924; Mon, 21 Jul 2003 06:04:55 -0700 (PDT) Message-Id: <200307211304.h6LD4tiS029924@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Mon, 21 Jul 2003 06:04:55 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/syscons/dragon dragon_saver.c src/sys/dev/syscons/fire fire_saver.c src/sys/dev/syscons/logo logo_saver.c src/sys/dev/syscons/warp warp_saver.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 13:04:56 -0000 nyan 2003/07/21 06:04:55 PDT FreeBSD src repository Modified files: sys/dev/syscons/dragon dragon_saver.c sys/dev/syscons/fire fire_saver.c sys/dev/syscons/logo logo_saver.c sys/dev/syscons/warp warp_saver.c Log: Use the clear function provided by the video adapter driver. Submitted by: chi@bd.mbn.or.jp (Chiharu Shibata) Revision Changes Path 1.2 +1 -19 src/sys/dev/syscons/dragon/dragon_saver.c 1.10 +2 -5 src/sys/dev/syscons/fire/fire_saver.c 1.12 +2 -5 src/sys/dev/syscons/logo/logo_saver.c 1.13 +2 -5 src/sys/dev/syscons/warp/warp_saver.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 06:10:58 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2C1637B401; Mon, 21 Jul 2003 06:10:58 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F29843F3F; Mon, 21 Jul 2003 06:10:58 -0700 (PDT) (envelope-from akiyama@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LDAw0U030258; Mon, 21 Jul 2003 06:10:58 -0700 (PDT) (envelope-from akiyama@repoman.freebsd.org) Received: (from akiyama@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LDAvlw030257; Mon, 21 Jul 2003 06:10:57 -0700 (PDT) Message-Id: <200307211310.h6LDAvlw030257@repoman.freebsd.org> From: Shunsuke Akiyama Date: Mon, 21 Jul 2003 06:10:57 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/usb ucom.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 13:10:59 -0000 akiyama 2003/07/21 06:10:57 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/usb ucom.c Log: MFC: Fix 'bulk in' and 'bulk out' being reversed in a couple of error messages. ucom.c: 1.26 Revision Changes Path 1.24.2.4 +2 -2 src/sys/dev/usb/ucom.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 06:56:23 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED7E637B401; Mon, 21 Jul 2003 06:56:23 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 934A043F75; Mon, 21 Jul 2003 06:56:23 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LDuN0U032071; Mon, 21 Jul 2003 06:56:23 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LDuNDp032070; Mon, 21 Jul 2003 06:56:23 -0700 (PDT) Message-Id: <200307211356.h6LDuNDp032070@repoman.freebsd.org> From: Hartmut Brandt Date: Mon, 21 Jul 2003 06:56:22 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf NOTES files src/share/man/man4 Makefile harp.4 src/sys/modules Makefile src/sys/dev/harp if_harp.c src/sys/modules/harp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 13:56:24 -0000 harti 2003/07/21 06:56:22 PDT FreeBSD src repository Modified files: sys/conf NOTES files share/man/man4 Makefile sys/modules Makefile Added files: share/man/man4 harp.4 sys/dev/harp if_harp.c sys/modules/harp Makefile Log: This is a pseudo physical interface for the HARP ATM stack. When loaded it attaches to all existing NATM network interfaces in the system and creates a HARP physical interface for each of them. This allows us to use the same set of ATM drivers for all ATM stuff. It is possible to use the same interface for HARP, NATM and netgraph at the same time. Revision Changes Path 1.216 +1 -0 src/share/man/man4/Makefile 1.1 +64 -0 src/share/man/man4/harp.4 (new) 1.1164 +3 -0 src/sys/conf/NOTES 1.809 +1 -0 src/sys/conf/files 1.1 +652 -0 src/sys/dev/harp/if_harp.c (new) 1.341 +1 -0 src/sys/modules/Makefile 1.1 +14 -0 src/sys/modules/harp/Makefile (new) From owner-cvs-src@FreeBSD.ORG Mon Jul 21 07:21:00 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5EE5A37B401; Mon, 21 Jul 2003 07:21:00 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F16FB43F93; Mon, 21 Jul 2003 07:20:59 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LEKx0U033879; Mon, 21 Jul 2003 07:20:59 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LEKwNC033877; Mon, 21 Jul 2003 07:20:58 -0700 (PDT) Message-Id: <200307211420.h6LEKwNC033877@repoman.freebsd.org> From: Hartmut Brandt Date: Mon, 21 Jul 2003 07:20:58 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man9 Makefile zone.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 14:21:00 -0000 harti 2003/07/21 07:20:58 PDT FreeBSD src repository Modified files: share/man/man9 Makefile zone.9 Log: Document uma_zone_set_max and its non-obvious behaviour. Reviewed by: bmilekic Revision Changes Path 1.199 +1 -0 src/share/man/man9/Makefile 1.25 +21 -2 src/share/man/man9/zone.9 From owner-cvs-src@FreeBSD.ORG Mon Jul 21 11:35:52 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DAF5737B401; Mon, 21 Jul 2003 11:35:52 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 762A843F75; Mon, 21 Jul 2003 11:35:52 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LIZq0U051798; Mon, 21 Jul 2003 11:35:52 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LIZpQu051797; Mon, 21 Jul 2003 11:35:51 -0700 (PDT) Message-Id: <200307211835.h6LIZpQu051797@repoman.freebsd.org> From: Poul-Henning Kamp Date: Mon, 21 Jul 2003 11:35:51 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys cdefs.h systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 18:35:53 -0000 phk 2003/07/21 11:35:51 PDT FreeBSD src repository Modified files: sys/sys cdefs.h systm.h Log: Add a new macro __nonnull(x) to use the new GCC33 attribute which checks that an argument is not a NULL pointer. Apply various obvious places. I belive __printf*() implies __nonnull() so it is not needed on functions already tagged that way. Revision Changes Path 1.72 +6 -0 src/sys/sys/cdefs.h 1.195 +16 -16 src/sys/sys/systm.h From owner-cvs-src@FreeBSD.ORG Mon Jul 21 12:10:39 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9BFFE37B407 for ; Mon, 21 Jul 2003 12:10:39 -0700 (PDT) Received: from mail.speakeasy.net (mail9.speakeasy.net [216.254.0.209]) by mx1.FreeBSD.org (Postfix) with ESMTP id 681B543FBF for ; Mon, 21 Jul 2003 12:10:37 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 5573 invoked from network); 21 Jul 2003 19:10:35 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 21 Jul 2003 19:10:35 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6LJAXGI039848; Mon, 21 Jul 2003 15:10:33 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200307202112.h6KLCLiv059614@repoman.freebsd.org> Date: Mon, 21 Jul 2003 15:10:49 -0400 (EDT) From: John Baldwin To: Nate Lawson cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/acpica acpi_ec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 19:10:40 -0000 On 20-Jul-2003 Nate Lawson wrote: > njl 2003/07/20 14:12:21 PDT > > FreeBSD src repository > > Modified files: > sys/dev/acpica acpi_ec.c > Log: > Do not call acpi_MatchHid() for all probe cases since it accesses the > namespace. To compensate for it only being used in the !ECDT case, use > a more robust approach to indicate a device was probed via ECDT by setting > the private ivar to be &acpi_ec_devclass. Without the acpi_MatchHid() call > now, it might have been possible for a non-EC device to have had its magic > match our previous flag. > > Pointed out by: takawata Assuming you are doing a device_add_child() to add the ec, you could add it with the name "acpi_ec" and then only the ec driver would probe it. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Mon Jul 21 12:15:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94A6537B401; Mon, 21 Jul 2003 12:15:26 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE5B643F3F; Mon, 21 Jul 2003 12:15:25 -0700 (PDT) (envelope-from ticso@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LJFP0U054213; Mon, 21 Jul 2003 12:15:25 -0700 (PDT) (envelope-from ticso@repoman.freebsd.org) Received: (from ticso@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LJFPJY054212; Mon, 21 Jul 2003 12:15:25 -0700 (PDT) Message-Id: <200307211915.h6LJFPJY054212@repoman.freebsd.org> From: Bernd Walter Date: Mon, 21 Jul 2003 12:15:25 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf files.alpha src/sys/alpha/conf GENERIC NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 19:15:27 -0000 ticso 2003/07/21 12:15:25 PDT FreeBSD src repository Modified files: sys/conf files.alpha sys/alpha/conf GENERIC NOTES Log: Enable eisa support on alpha. We need eisa bridge support on some models, which now depends on having eisa in the kernel. Revision Changes Path 1.162 +1 -0 src/sys/alpha/conf/GENERIC 1.152 +1 -0 src/sys/alpha/conf/NOTES 1.102 +1 -0 src/sys/conf/files.alpha From owner-cvs-src@FreeBSD.ORG Mon Jul 21 12:54:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0FD537B401; Mon, 21 Jul 2003 12:54:18 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BC6843F75; Mon, 21 Jul 2003 12:54:18 -0700 (PDT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LJsI0U060858; Mon, 21 Jul 2003 12:54:18 -0700 (PDT) (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LJsHM3060857; Mon, 21 Jul 2003 12:54:17 -0700 (PDT) Message-Id: <200307211954.h6LJsHM3060857@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Mon, 21 Jul 2003 12:54:17 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: OPENPAM Subject: cvs commit: src/contrib/openpam/include/security pam_types.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 19:54:19 -0000 des 2003/07/21 12:54:17 PDT FreeBSD src repository Modified files: (Branch: OPENPAM) contrib/openpam/include/security pam_types.h Log: MFP4: revert constification of pam_message.msg (perforce change #34785) Revision Changes Path 1.1.1.9 +11 -11 src/contrib/openpam/include/security/pam_types.h From owner-cvs-src@FreeBSD.ORG Mon Jul 21 12:56:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 43B3D37B401; Mon, 21 Jul 2003 12:56:29 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F342443F75; Mon, 21 Jul 2003 12:56:28 -0700 (PDT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LJuS0U060988; Mon, 21 Jul 2003 12:56:28 -0700 (PDT) (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LJuSt2060987; Mon, 21 Jul 2003 12:56:28 -0700 (PDT) Message-Id: <200307211956.h6LJuSt2060987@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Mon, 21 Jul 2003 12:56:28 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpam/modules/pam_radius pam_radius.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 19:56:30 -0000 des 2003/07/21 12:56:28 PDT FreeBSD src repository Modified files: lib/libpam/modules/pam_radius pam_radius.c Log: Revert previous commit after fixing libpam. Revision Changes Path 1.17 +1 -1 src/lib/libpam/modules/pam_radius/pam_radius.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 13:31:14 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DC0F37B401; Mon, 21 Jul 2003 13:31:14 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BCB6D43F75; Mon, 21 Jul 2003 13:31:13 -0700 (PDT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LKVD0U063130; Mon, 21 Jul 2003 13:31:13 -0700 (PDT) (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LKVDVl063129; Mon, 21 Jul 2003 13:31:13 -0700 (PDT) Message-Id: <200307212031.h6LKVDVl063129@repoman.freebsd.org> From: Hiroki Sato Date: Mon, 21 Jul 2003 13:31:13 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 20:31:14 -0000 hrs 2003/07/21 13:31:13 PDT FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: New release notes: harp(4). Updated release notes: patm(4) (use &man.patm.4;). Revision Changes Path 1.594 +7 -1 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Mon Jul 21 13:38:14 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D62F37B405 for ; Mon, 21 Jul 2003 13:38:14 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 4937243FD7 for ; Mon, 21 Jul 2003 13:38:11 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 34751 invoked by uid 1000); 21 Jul 2003 20:38:12 -0000 Date: Mon, 21 Jul 2003 13:38:12 -0700 (PDT) From: Nate Lawson To: John Baldwin In-Reply-To: Message-ID: <20030721133301.P34741@root.org> References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/acpica acpi_ec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 20:38:14 -0000 On Mon, 21 Jul 2003, John Baldwin wrote: > On 20-Jul-2003 Nate Lawson wrote: > > Modified files: > > sys/dev/acpica acpi_ec.c > > Log: > > Do not call acpi_MatchHid() for all probe cases since it accesses the > > namespace. To compensate for it only being used in the !ECDT case, use > > a more robust approach to indicate a device was probed via ECDT by setting > > the private ivar to be &acpi_ec_devclass. Without the acpi_MatchHid() call > > now, it might have been possible for a non-EC device to have had its magic > > match our previous flag. > > > > Pointed out by: takawata > > Assuming you are doing a device_add_child() to add the ec, you could add it > with the name "acpi_ec" and then only the ec driver would probe it. I do add it with that name but that doesn't prevent it from getting a duplicate probe when the namespace is evaluated (much later). The sequence with ECDT is: acpi_attach() acpi_ec_ecdt_probe() if ECDT present device_add_child("acpi_ec") device_probe_and_attach() acpi_ec_probe() if ECDT magic set in ivars done acpi_ec_attach() allocate resources ... namespace started ... walk all devices, _STA, _INI acpi_ec_probe() <===== same device as already probed above if lookup devclass finds duplicate for _UID ENXIO; don't attach again -Nate From owner-cvs-src@FreeBSD.ORG Mon Jul 21 13:55:39 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5529637B401; Mon, 21 Jul 2003 13:55:39 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E55C843F93; Mon, 21 Jul 2003 13:55:38 -0700 (PDT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LKtc0U064105; Mon, 21 Jul 2003 13:55:38 -0700 (PDT) (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LKtc3l064104; Mon, 21 Jul 2003 13:55:38 -0700 (PDT) Message-Id: <200307212055.h6LKtc3l064104@repoman.freebsd.org> From: Mark Murray Date: Mon, 21 Jul 2003 13:55:38 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/getconf getconf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 20:55:39 -0000 markm 2003/07/21 13:55:38 PDT FreeBSD src repository Modified files: usr.bin/getconf getconf.c Log: Replace an alloca() call with a slightly more standard malloc()/free() pair. Revision Changes Path 1.7 +8 -3 src/usr.bin/getconf/getconf.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 13:59:29 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B406C37B405; Mon, 21 Jul 2003 13:59:29 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E20C43FBF; Mon, 21 Jul 2003 13:59:29 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LKxS0U064228; Mon, 21 Jul 2003 13:59:28 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LKxS9Z064227; Mon, 21 Jul 2003 13:59:28 -0700 (PDT) Message-Id: <200307212059.h6LKxS9Z064227@repoman.freebsd.org> From: Peter Wemm Date: Mon, 21 Jul 2003 13:59:28 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/acpica acpi_wakeup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 20:59:30 -0000 peter 2003/07/21 13:59:28 PDT FreeBSD src repository Modified files: sys/i386/acpica acpi_wakeup.c Log: Commit Ian Dowse's workaround for acpi resume resetting after the LAZY_SWITCH changes. He pointed out the acpi code sets up an identity mapping in the current vmspace and that got messed up by the %cr3 being out of sync with the current page directory. As a workaround, restore %cr3 across the sleep/resume. A more complete fix would be to undo the lazy state and clear the pm_active bit from the borrowed pmap, but this works and people are currently hurting. I'll clean this up. This is mostly Ian's patch, plus a PAE tweak from me. Revision Changes Path 1.22 +8 -0 src/sys/i386/acpica/acpi_wakeup.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:13:20 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ECD9F37B404; Mon, 21 Jul 2003 14:13:20 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 88A4A43FAF; Mon, 21 Jul 2003 14:13:20 -0700 (PDT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LLDK0U065747; Mon, 21 Jul 2003 14:13:20 -0700 (PDT) (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LLDKdU065746; Mon, 21 Jul 2003 14:13:20 -0700 (PDT) Message-Id: <200307212113.h6LLDKdU065746@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Mon, 21 Jul 2003 14:13:20 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: CVSROOT access.doc_src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:13:21 -0000 simon 2003/07/21 14:13:20 PDT FreeBSD src repository (doc committer) Modified files: . access.doc_src Log: I also want src-committers@ mail, since I also plan to work on manual pages. Approved by: ceri (mentor) Revision Changes Path 1.30 +1 -0 CVSROOT/access.doc_src From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:28:56 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9A74737B404 for ; Mon, 21 Jul 2003 14:28:56 -0700 (PDT) Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED0AC43FBD for ; Mon, 21 Jul 2003 14:28:54 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 14006 invoked from network); 21 Jul 2003 21:28:54 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 21 Jul 2003 21:28:54 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6LLSpGI040209; Mon, 21 Jul 2003 17:28:52 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030721133301.P34741@root.org> Date: Mon, 21 Jul 2003 17:29:08 -0400 (EDT) From: John Baldwin To: Nate Lawson cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/acpica acpi_ec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:28:57 -0000 On 21-Jul-2003 Nate Lawson wrote: > On Mon, 21 Jul 2003, John Baldwin wrote: >> On 20-Jul-2003 Nate Lawson wrote: >> > Modified files: >> > sys/dev/acpica acpi_ec.c >> > Log: >> > Do not call acpi_MatchHid() for all probe cases since it accesses the >> > namespace. To compensate for it only being used in the !ECDT case, use >> > a more robust approach to indicate a device was probed via ECDT by setting >> > the private ivar to be &acpi_ec_devclass. Without the acpi_MatchHid() call >> > now, it might have been possible for a non-EC device to have had its magic >> > match our previous flag. >> > >> > Pointed out by: takawata >> >> Assuming you are doing a device_add_child() to add the ec, you could add it >> with the name "acpi_ec" and then only the ec driver would probe it. > > I do add it with that name but that doesn't prevent it from getting a > duplicate probe when the namespace is evaluated (much later). > > The sequence with ECDT is: > acpi_attach() > acpi_ec_ecdt_probe() > if ECDT present > device_add_child("acpi_ec") > device_probe_and_attach() > acpi_ec_probe() > if ECDT magic set in ivars > done The magic part seems evil. I'm not sure yet of a better way to handle that though. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:40:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96BFC37B401; Mon, 21 Jul 2003 14:40:45 -0700 (PDT) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3C78E43F75; Mon, 21 Jul 2003 14:40:44 -0700 (PDT) (envelope-from wkb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.12.9/8.12.9) with ESMTP id h6LLehxd000582; Mon, 21 Jul 2003 23:40:43 +0200 (CEST) (envelope-from wkb@freebie.xs4all.nl) Received: (from wkb@localhost) by freebie.xs4all.nl (8.12.9/8.12.9/Submit) id h6LLehof000581; Mon, 21 Jul 2003 23:40:43 +0200 (CEST) Date: Mon, 21 Jul 2003 23:40:43 +0200 From: Wilko Bulte To: Bernd Walter Message-ID: <20030721214042.GA563@freebie.xs4all.nl> References: <200307211915.h6LJFPJY054212@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307211915.h6LJFPJY054212@repoman.freebsd.org> User-Agent: Mutt/1.4i X-OS: FreeBSD 4.8-STABLE X-PGP: finger wilko@freebsd.org cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/conf files.alpha src/sys/alpha/conf GENERIC NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:40:46 -0000 On Mon, Jul 21, 2003 at 12:15:25PM -0700, Bernd Walter wrote: > ticso 2003/07/21 12:15:25 PDT > > FreeBSD src repository > > Modified files: > sys/conf files.alpha > sys/alpha/conf GENERIC NOTES > Log: > Enable eisa support on alpha. > We need eisa bridge support on some models, which now depends on having > eisa in the kernel. Without having checked: what about the bootfloppy? -- | / o / /_ _ wilko@FreeBSD.org |/|/ / / /( (_) Bulte From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:46:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E7BB37B401; Mon, 21 Jul 2003 14:46:10 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3423843FBD; Mon, 21 Jul 2003 14:46:08 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LLk70U067024; Mon, 21 Jul 2003 14:46:07 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LLk7bb067023; Mon, 21 Jul 2003 14:46:07 -0700 (PDT) Message-Id: <200307212146.h6LLk7bb067023@repoman.freebsd.org> From: Sam Leffler Date: Mon, 21 Jul 2003 14:46:07 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/safe safe.c safereg.h safevar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:46:10 -0000 sam 2003/07/21 14:46:07 PDT FreeBSD src repository Added files: sys/dev/safe safe.c safereg.h safevar.h Log: SafeNet crypto driver (supports only RNG and symmetric ops; no PK support yet) Sponsored by: Global Technology Associates, Inc. MFC after: 1 day Revision Changes Path 1.1 +2246 -0 src/sys/dev/safe/safe.c (new) 1.1 +412 -0 src/sys/dev/safe/safereg.h (new) 1.1 +218 -0 src/sys/dev/safe/safevar.h (new) From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:47:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 084E437B407 for ; Mon, 21 Jul 2003 14:47:30 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id B2AF443FEA for ; Mon, 21 Jul 2003 14:47:27 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 34877 invoked by uid 1000); 21 Jul 2003 21:47:29 -0000 Date: Mon, 21 Jul 2003 14:47:29 -0700 (PDT) From: Nate Lawson To: John Baldwin In-Reply-To: Message-ID: <20030721144250.B34834@root.org> References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/acpica acpi_ec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:47:30 -0000 On Mon, 21 Jul 2003, John Baldwin wrote: > On 21-Jul-2003 Nate Lawson wrote: > > The sequence with ECDT is: > > acpi_attach() > > acpi_ec_ecdt_probe() > > if ECDT present > > device_add_child("acpi_ec") > > device_probe_and_attach() > > acpi_ec_probe() > > if ECDT magic set in ivars > > done > > The magic part seems evil. I'm not sure yet of a better way to handle > that though. The reason this was done is that there are two paths for getting resources about the EC: ECDT and namespace. They can share a common probe/attach function if we take the same route (ivars) for passing the data to probe/attach. Since the ivars are zeroed before device_probe() is called and an already probed ACPI_DEVICE object is extremely unlikely to use the same magic since it's a pointer to the acpi_ec_devclass, this is a low risk approach. -Nate From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:47:48 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 695DD37B425; Mon, 21 Jul 2003 14:47:48 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E603E43FDD; Mon, 21 Jul 2003 14:47:47 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LLll0U067087; Mon, 21 Jul 2003 14:47:47 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LLllvR067086; Mon, 21 Jul 2003 14:47:47 -0700 (PDT) Message-Id: <200307212147.h6LLllvR067086@repoman.freebsd.org> From: Sam Leffler Date: Mon, 21 Jul 2003 14:47:47 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/modules/safe Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:47:48 -0000 sam 2003/07/21 14:47:47 PDT FreeBSD src repository Added files: sys/modules/safe Makefile Log: SafeNet crypto driver Sponsored by: Global Technology Associates, Inc. MFC after: 1 day Revision Changes Path 1.1 +38 -0 src/sys/modules/safe/Makefile (new) From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:48:46 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F4BB37B405; Mon, 21 Jul 2003 14:48:46 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0EE0143F93; Mon, 21 Jul 2003 14:48:46 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LLmj0U067148; Mon, 21 Jul 2003 14:48:45 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LLmjIp067147; Mon, 21 Jul 2003 14:48:45 -0700 (PDT) Message-Id: <200307212148.h6LLmjIp067147@repoman.freebsd.org> From: Sam Leffler Date: Mon, 21 Jul 2003 14:48:45 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/modules Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:48:46 -0000 sam 2003/07/21 14:48:45 PDT FreeBSD src repository Modified files: sys/modules Makefile Log: hook safe driver to the build Revision Changes Path 1.342 +1 -0 src/sys/modules/Makefile From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:50:42 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB06A37B401; Mon, 21 Jul 2003 14:50:42 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 46EB343FA3; Mon, 21 Jul 2003 14:50:42 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LLog0U067359; Mon, 21 Jul 2003 14:50:42 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LLofXd067358; Mon, 21 Jul 2003 14:50:41 -0700 (PDT) Message-Id: <200307212150.h6LLofXd067358@repoman.freebsd.org> From: Sam Leffler Date: Mon, 21 Jul 2003 14:50:41 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf files options X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:50:43 -0000 sam 2003/07/21 14:50:41 PDT FreeBSD src repository Modified files: sys/conf files options Log: safenet driver config glue Sponsored by: Global Technology Associates, Inc. Revision Changes Path 1.810 +1 -0 src/sys/conf/files 1.403 +5 -0 src/sys/conf/options From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:51:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC24B37B401; Mon, 21 Jul 2003 14:51:25 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B71543F75; Mon, 21 Jul 2003 14:51:25 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LLpP0U067415; Mon, 21 Jul 2003 14:51:25 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LLpOH2067414; Mon, 21 Jul 2003 14:51:24 -0700 (PDT) Message-Id: <200307212151.h6LLpOH2067414@repoman.freebsd.org> From: Sam Leffler Date: Mon, 21 Jul 2003 14:51:24 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:51:26 -0000 sam 2003/07/21 14:51:24 PDT FreeBSD src repository Modified files: sys/i386/conf NOTES Log: add safe driver until we can verify it as machine-independent Revision Changes Path 1.1090 +10 -0 src/sys/i386/conf/NOTES From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:51:54 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B5A9237B401 for ; Mon, 21 Jul 2003 14:51:54 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 69D8843FB1 for ; Mon, 21 Jul 2003 14:51:53 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 34925 invoked by uid 1000); 21 Jul 2003 21:51:54 -0000 Date: Mon, 21 Jul 2003 14:51:54 -0700 (PDT) From: Nate Lawson To: Peter Wemm In-Reply-To: <20030721205935.A843937B488@hub.freebsd.org> Message-ID: <20030721144902.R34834@root.org> References: <20030721205935.A843937B488@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/acpica acpi_wakeup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:51:55 -0000 On Mon, 21 Jul 2003, Peter Wemm wrote: > Modified files: > sys/i386/acpica acpi_wakeup.c > Log: > Commit Ian Dowse's workaround for acpi resume resetting after the > LAZY_SWITCH changes. He pointed out the acpi code sets up an identity > mapping in the current vmspace and that got messed up by the %cr3 being > out of sync with the current page directory. As a workaround, restore > %cr3 across the sleep/resume. A more complete fix would be to undo the > lazy state and clear the pm_active bit from the borrowed pmap, but this > works and people are currently hurting. I'll clean this up. > This is mostly Ian's patch, plus a PAE tweak from me. Thank you for following up on this. As I asked on the Usenix conf. call, are there any other registers that are being missed in the save/restore? There are some other aging code in this wakeup code that may not fit with our changing register models. -Nate From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:52:15 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 59C0537B404; Mon, 21 Jul 2003 14:52:15 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9F8943F93; Mon, 21 Jul 2003 14:52:14 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LLqE0U067466; Mon, 21 Jul 2003 14:52:14 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LLqEQM067465; Mon, 21 Jul 2003 14:52:14 -0700 (PDT) Message-Id: <200307212152.h6LLqEQM067465@repoman.freebsd.org> From: Sam Leffler Date: Mon, 21 Jul 2003 14:52:14 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 safe.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:52:15 -0000 sam 2003/07/21 14:52:14 PDT FreeBSD src repository Added files: share/man/man4 safe.4 Log: safenet driver Sponsored by: Global Technology Associates, Inc. Revision Changes Path 1.1 +105 -0 src/share/man/man4/safe.4 (new) From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:52:49 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C25BE37B401; Mon, 21 Jul 2003 14:52:49 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5FE4343F85; Mon, 21 Jul 2003 14:52:49 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LLqm0U067508; Mon, 21 Jul 2003 14:52:48 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LLqmPq067507; Mon, 21 Jul 2003 14:52:48 -0700 (PDT) Message-Id: <200307212152.h6LLqmPq067507@repoman.freebsd.org> From: Sam Leffler Date: Mon, 21 Jul 2003 14:52:48 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:52:50 -0000 sam 2003/07/21 14:52:48 PDT FreeBSD src repository Modified files: share/man/man4 Makefile Log: hookup safenet driver Revision Changes Path 1.217 +1 -0 src/share/man/man4/Makefile From owner-cvs-src@FreeBSD.ORG Mon Jul 21 14:58:05 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FA5037B401; Mon, 21 Jul 2003 14:58:05 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BFB6C43FD7; Mon, 21 Jul 2003 14:58:04 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LLw40U067742; Mon, 21 Jul 2003 14:58:04 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LLw43o067738; Mon, 21 Jul 2003 14:58:04 -0700 (PDT) Message-Id: <200307212158.h6LLw43o067738@repoman.freebsd.org> From: Sam Leffler Date: Mon, 21 Jul 2003 14:58:04 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/crypto Makefile safestats.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 21:58:05 -0000 sam 2003/07/21 14:58:04 PDT FreeBSD src repository Modified files: tools/tools/crypto Makefile Added files: tools/tools/crypto safestats.c Log: add stat dumper for the safenet driver Revision Changes Path 1.5 +5 -1 src/tools/tools/crypto/Makefile 1.1 +69 -0 src/tools/tools/crypto/safestats.c (new) From owner-cvs-src@FreeBSD.ORG Mon Jul 21 15:01:08 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0849737B404; Mon, 21 Jul 2003 15:01:08 -0700 (PDT) Received: from magic.adaptec.com (magic-mail.adaptec.com [208.236.45.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD79F43F3F; Mon, 21 Jul 2003 15:01:06 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6/8.11.6) with ESMTP id h6LM15o15297; Mon, 21 Jul 2003 15:01:05 -0700 Received: from freebsd.org (hollin.btc.adaptec.com [10.100.253.56]) by redfish.adaptec.com (8.8.8p2+Sun/8.8.8) with ESMTP id PAA13081; Mon, 21 Jul 2003 15:01:04 -0700 (PDT) Message-ID: <3F1C6216.3020006@freebsd.org> Date: Mon, 21 Jul 2003 15:58:46 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3) Gecko/20030414 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Wilko Bulte References: <200307211915.h6LJFPJY054212@repoman.freebsd.org> <20030721214042.GA563@freebie.xs4all.nl> In-Reply-To: <20030721214042.GA563@freebie.xs4all.nl> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: Bernd Walter cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Floppies for ALPHA [Re: cvs commit: src/sys/conf files.alpha src/sys/alpha/conf GENERIC NOTES] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 22:01:08 -0000 Wilko Bulte wrote: > On Mon, Jul 21, 2003 at 12:15:25PM -0700, Bernd Walter wrote: > >>ticso 2003/07/21 12:15:25 PDT >> >> FreeBSD src repository >> >> Modified files: >> sys/conf files.alpha >> sys/alpha/conf GENERIC NOTES >> Log: >> Enable eisa support on alpha. >> We need eisa bridge support on some models, which now depends on having >> eisa in the kernel. > > > Without having checked: what about the bootfloppy? > This is a loosing fight. While there is still some value in having floppies for x86, is there really any value in them for Alpha? My understanding is that CD-ROMs have been standard on all Alphas for the past 5-10 years. Netbooting is an easy alternative for those without CDs or bandwidth. We do not do floppies for sparc64 and ia64, and I would hope/expect that we don't do them for amd64. I think it's time to cut them out of Alpha. Scott From owner-cvs-src@FreeBSD.ORG Mon Jul 21 15:04:21 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F41737B401; Mon, 21 Jul 2003 15:04:21 -0700 (PDT) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by mx1.FreeBSD.org (Postfix) with ESMTP id 065BB43F3F; Mon, 21 Jul 2003 15:04:20 -0700 (PDT) (envelope-from wkb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.12.9/8.12.9) with ESMTP id h6LM4Jxd000934; Tue, 22 Jul 2003 00:04:19 +0200 (CEST) (envelope-from wkb@freebie.xs4all.nl) Received: (from wkb@localhost) by freebie.xs4all.nl (8.12.9/8.12.9/Submit) id h6LM4JPN000933; Tue, 22 Jul 2003 00:04:19 +0200 (CEST) Date: Tue, 22 Jul 2003 00:04:19 +0200 From: Wilko Bulte To: Scott Long Message-ID: <20030721220419.GA909@freebie.xs4all.nl> References: <200307211915.h6LJFPJY054212@repoman.freebsd.org> <20030721214042.GA563@freebie.xs4all.nl> <3F1C6216.3020006@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F1C6216.3020006@freebsd.org> User-Agent: Mutt/1.4i X-OS: FreeBSD 4.8-STABLE X-PGP: finger wilko@freebsd.org cc: cvs-src@freebsd.org cc: Bernd Walter cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: Floppies for ALPHA [Re: cvs commit: src/sys/conf files.alpha src/sys/alpha/conf GENERIC NOTES] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 22:04:21 -0000 On Mon, Jul 21, 2003 at 03:58:46PM -0600, Scott Long wrote: > Wilko Bulte wrote: > >On Mon, Jul 21, 2003 at 12:15:25PM -0700, Bernd Walter wrote: > > > >>ticso 2003/07/21 12:15:25 PDT > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/conf files.alpha > >> sys/alpha/conf GENERIC NOTES > >> Log: > >> Enable eisa support on alpha. > >> We need eisa bridge support on some models, which now depends on having > >> eisa in the kernel. > > > > > >Without having checked: what about the bootfloppy? > > > > This is a loosing fight. While there is still some value in having > floppies for x86, is there really any value in them for Alpha? My > understanding is that CD-ROMs have been standard on all Alphas for > the past 5-10 years. Netbooting is an easy alternative for those Correct. On all Alpha's in fact. Even the DEC3000 etc. > without CDs or bandwidth. We do not do floppies for sparc64 and ia64, > and I would hope/expect that we don't do them for amd64. I think it's > time to cut them out of Alpha. Absolutely. But everytime we planned on doing that there was uproar. You obviously loose the network install with just a floppy to boot from. But miniinst.iso fills that gap, at least IMHO. W/ -- | / o / /_ _ wilko@FreeBSD.org |/|/ / / /( (_) Bulte From owner-cvs-src@FreeBSD.ORG Mon Jul 21 15:07:42 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B03D37B404; Mon, 21 Jul 2003 15:07:42 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85F2F43F3F; Mon, 21 Jul 2003 15:07:41 -0700 (PDT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LM7f0U069000; Mon, 21 Jul 2003 15:07:41 -0700 (PDT) (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LM7f3c068999; Mon, 21 Jul 2003 15:07:41 -0700 (PDT) Message-Id: <200307212207.h6LM7f3c068999@repoman.freebsd.org> From: Hiroki Sato Date: Mon, 21 Jul 2003 15:07:41 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 22:07:43 -0000 hrs 2003/07/21 15:07:40 PDT FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: New release notes: safe(4). Revision Changes Path 1.595 +7 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Mon Jul 21 15:10:52 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8633A37B401; Mon, 21 Jul 2003 15:10:52 -0700 (PDT) Received: from srv1.cosmo-project.de (srv1.cosmo-project.de [213.83.6.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1DDF543F93; Mon, 21 Jul 2003 15:10:51 -0700 (PDT) (envelope-from ticso@cicely12.cicely.de) Received: from cicely5.cicely.de (cicely5.cicely.de [IPv6:3ffe:400:8d0:301:200:92ff:fe9b:20e7]) (authenticated bits=0) by srv1.cosmo-project.de (8.12.9/8.12.9) with ESMTP id h6LMAjhR026492 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Tue, 22 Jul 2003 00:10:48 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (cicely12.cicely.de [IPv6:3ffe:400:8d0:301::12]) by cicely5.cicely.de (8.12.9/8.12.9) with ESMTP id h6LMAiAx062978 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Jul 2003 00:10:45 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (localhost [127.0.0.1]) by cicely12.cicely.de (8.12.9/8.12.9) with ESMTP id h6LMAiYV000958; Tue, 22 Jul 2003 00:10:44 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: (from ticso@localhost) by cicely12.cicely.de (8.12.9/8.12.9/Submit) id h6LMAiWi000957; Tue, 22 Jul 2003 00:10:44 +0200 (CEST) Date: Tue, 22 Jul 2003 00:10:43 +0200 From: Bernd Walter To: Wilko Bulte Message-ID: <20030721221043.GH511@cicely12.cicely.de> References: <200307211915.h6LJFPJY054212@repoman.freebsd.org> <20030721214042.GA563@freebie.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030721214042.GA563@freebie.xs4all.nl> X-Operating-System: FreeBSD cicely12.cicely.de 5.1-CURRENT alpha User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.ORG cc: Bernd Walter cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/conf files.alpha src/sys/alpha/conf GENERIC NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: ticso@cicely.de List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 22:10:53 -0000 On Mon, Jul 21, 2003 at 11:40:43PM +0200, Wilko Bulte wrote: > On Mon, Jul 21, 2003 at 12:15:25PM -0700, Bernd Walter wrote: > > ticso 2003/07/21 12:15:25 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/conf files.alpha > > sys/alpha/conf GENERIC NOTES > > Log: > > Enable eisa support on alpha. > > We need eisa bridge support on some models, which now depends on having > > eisa in the kernel. > > Without having checked: what about the bootfloppy? The original situation was that the eisa bridge driver was included into the kernel conditionaly on pci only. Since a while it depend on eisa too. Without this the AS4100 has no ISA bus - and no sio, clock, ... Either we enable eisa or with include the eisa bridge driver without having eisa. Eisa support itself is quite small: [58]cicely12# size eisaconf.o text data bss dec hex filename 5340 848 16 6204 183c eisaconf.o Additionaly there a a few bytes for drivers that have eisa support and are enabled on alpha. The next make release will have to tell us. -- B.Walter BWCT http://www.bwct.de ticso@bwct.de info@bwct.de From owner-cvs-src@FreeBSD.ORG Mon Jul 21 15:18:39 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 435BC37B401; Mon, 21 Jul 2003 15:18:39 -0700 (PDT) Received: from magic.adaptec.com (magic-mail.adaptec.com [208.236.45.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id 881CD43FB1; Mon, 21 Jul 2003 15:18:38 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6/8.11.6) with ESMTP id h6LMIco24699; Mon, 21 Jul 2003 15:18:38 -0700 Received: from freebsd.org (hollin.btc.adaptec.com [10.100.253.56]) by redfish.adaptec.com (8.8.8p2+Sun/8.8.8) with ESMTP id PAA22438; Mon, 21 Jul 2003 15:18:37 -0700 (PDT) Message-ID: <3F1C6633.5070009@freebsd.org> Date: Mon, 21 Jul 2003 16:16:19 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3) Gecko/20030414 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Wilko Bulte References: <200307211915.h6LJFPJY054212@repoman.freebsd.org> <20030721214042.GA563@freebie.xs4all.nl> <3F1C6216.3020006@freebsd.org> <20030721220419.GA909@freebie.xs4all.nl> In-Reply-To: <20030721220419.GA909@freebie.xs4all.nl> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: Bernd Walter cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: Floppies for ALPHA [Re: cvs commit: src/sys/conf files.alpha src/sys/alpha/conf GENERIC NOTES] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 22:18:39 -0000 Wilko Bulte wrote: > On Mon, Jul 21, 2003 at 03:58:46PM -0600, Scott Long wrote: > >>Wilko Bulte wrote: >> >>>On Mon, Jul 21, 2003 at 12:15:25PM -0700, Bernd Walter wrote: >>> >>> >>>>ticso 2003/07/21 12:15:25 PDT >>>> >>>>FreeBSD src repository >>>> >>>>Modified files: >>>> sys/conf files.alpha >>>> sys/alpha/conf GENERIC NOTES >>>>Log: >>>>Enable eisa support on alpha. >>>>We need eisa bridge support on some models, which now depends on having >>>>eisa in the kernel. >>> >>> >>>Without having checked: what about the bootfloppy? >>> >> >>This is a loosing fight. While there is still some value in having >>floppies for x86, is there really any value in them for Alpha? My >>understanding is that CD-ROMs have been standard on all Alphas for >>the past 5-10 years. Netbooting is an easy alternative for those > > > Correct. On all Alpha's in fact. Even the DEC3000 etc. > > >>without CDs or bandwidth. We do not do floppies for sparc64 and ia64, >>and I would hope/expect that we don't do them for amd64. I think it's >>time to cut them out of Alpha. > > > Absolutely. But everytime we planned on doing that there was uproar. > You obviously loose the network install with just a floppy to boot from. > But miniinst.iso fills that gap, at least IMHO. > > W/ > Is there an alternative for those in remote areas that can neither download the miniiso nor buy the cd set? Every time that we talk about downloading iso's, the issue comes up of those in eastern-bloc and asian countries that have little bandwidth. Can Alpha do a 'boot-only' cd image that is <5MB? Scott From owner-cvs-src@FreeBSD.ORG Mon Jul 21 15:35:12 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AE3E37B404; Mon, 21 Jul 2003 15:35:12 -0700 (PDT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 914EE43F85; Mon, 21 Jul 2003 15:35:11 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (localhost [127.0.0.1]) by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6LMZ9wO008820; Mon, 21 Jul 2003 15:35:09 -0700 (PDT) (envelope-from marcel@ns1.xcllnt.net) Received: (from marcel@localhost) by ns1.xcllnt.net (8.12.9/8.12.9/Submit) id h6LMZ98F008819; Mon, 21 Jul 2003 15:35:09 -0700 (PDT) (envelope-from marcel) Date: Mon, 21 Jul 2003 15:35:09 -0700 From: Marcel Moolenaar To: Wilko Bulte Message-ID: <20030721223509.GA8170@ns1.xcllnt.net> References: <200307211915.h6LJFPJY054212@repoman.freebsd.org> <20030721214042.GA563@freebie.xs4all.nl> <3F1C6216.3020006@freebsd.org> <20030721220419.GA909@freebie.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030721220419.GA909@freebie.xs4all.nl> User-Agent: Mutt/1.5.1i cc: cvs-src@FreeBSD.org cc: Bernd Walter cc: src-committers@FreeBSD.org cc: Scott Long cc: cvs-all@FreeBSD.org Subject: Re: Floppies for ALPHA [Re: cvs commit: src/sys/conf files.alpha src/sys/alpha/conf GENERIC NOTES] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 22:35:14 -0000 On Tue, Jul 22, 2003 at 12:04:19AM +0200, Wilko Bulte wrote: > > without CDs or bandwidth. We do not do floppies for sparc64 and ia64, > > and I would hope/expect that we don't do them for amd64. I think it's > > time to cut them out of Alpha. > > Absolutely. But everytime we planned on doing that there was uproar. Alpha is in need of people who actually do some work. If dropping boot floppies makes the maintenance burden lighter than we should do it, even if there's a downside. So, unless people talk with patches, I think we should ignore the uproar and just do it. It's hard enough to get people to port libthr or libkse and that's much more important... Just my $0.02 -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Mon Jul 21 16:20:41 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C21D237B401; Mon, 21 Jul 2003 16:20:41 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F53343F3F; Mon, 21 Jul 2003 16:20:41 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6LNKf0U012358; Mon, 21 Jul 2003 16:20:41 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6LNKfE2012354; Mon, 21 Jul 2003 16:20:41 -0700 (PDT) Message-Id: <200307212320.h6LNKfE2012354@repoman.freebsd.org> From: Sam Leffler Date: Mon, 21 Jul 2003 16:20:41 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/wi if_wi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2003 23:20:42 -0000 sam 2003/07/21 16:20:41 PDT FreeBSD src repository Modified files: sys/dev/wi if_wi.c Log: o Add monitor mode support. This tested fine with prism cards but may require newer lucent/hermes firmware than indicated (investigating). I'm committing this now since it shouldn't hurt anything. o Vaguely related, add bogus frame length check from netbsd. Obtained from: netbsd Revision Changes Path 1.149 +29 -2 src/sys/dev/wi/if_wi.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 17:17:12 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A31A737B401; Mon, 21 Jul 2003 17:17:12 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40E8543F85; Mon, 21 Jul 2003 17:17:12 -0700 (PDT) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M0HB0U022582; Mon, 21 Jul 2003 17:17:11 -0700 (PDT) (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M0HBRN022581; Mon, 21 Jul 2003 17:17:11 -0700 (PDT) Message-Id: <200307220017.h6M0HBRN022581@repoman.freebsd.org> From: Mike Silbersack Date: Mon, 21 Jul 2003 17:17:11 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 00:17:13 -0000 silby 2003/07/21 17:17:11 PDT FreeBSD src repository Modified files: sys/sys systm.h Log: Fix apparent typo in previous commit. Revision Changes Path 1.196 +1 -1 src/sys/sys/systm.h From owner-cvs-src@FreeBSD.ORG Mon Jul 21 17:19:41 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1482437B401; Mon, 21 Jul 2003 17:19:41 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A35C643F93; Mon, 21 Jul 2003 17:19:40 -0700 (PDT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M0Je0U022641; Mon, 21 Jul 2003 17:19:40 -0700 (PDT) (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M0JeCD022640; Mon, 21 Jul 2003 17:19:40 -0700 (PDT) Message-Id: <200307220019.h6M0JeCD022640@repoman.freebsd.org> From: "David E. O'Brien" Date: Mon, 21 Jul 2003 17:19:40 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/crunch/crunchide exec_elf32.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 00:19:41 -0000 obrien 2003/07/21 17:19:40 PDT FreeBSD src repository Modified files: usr.sbin/crunch/crunchide exec_elf32.c Log: Teach crunchide(1) about PowerPC ELF. PR: 54526 Submitted by: Stefan Farfeleder Revision Changes Path 1.12 +4 -0 src/usr.sbin/crunch/crunchide/exec_elf32.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 17:22:53 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 452F837B401; Mon, 21 Jul 2003 17:22:53 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6296143F3F; Mon, 21 Jul 2003 17:22:52 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h6M0Maju023425; Mon, 21 Jul 2003 17:22:36 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h6M0MZfE023424; Mon, 21 Jul 2003 17:22:35 -0700 (PDT) Date: Mon, 21 Jul 2003 17:22:35 -0700 From: "David O'Brien" To: Wilko Bulte Message-ID: <20030722002235.GA23390@dragon.nuxi.com> References: <200307211915.h6LJFPJY054212@repoman.freebsd.org> <20030721214042.GA563@freebie.xs4all.nl> <3F1C6216.3020006@freebsd.org> <20030721220419.GA909@freebie.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030721220419.GA909@freebie.xs4all.nl> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.1-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@freebsd.org cc: Bernd Walter cc: src-committers@freebsd.org cc: Scott Long cc: cvs-all@freebsd.org Subject: Re: Floppies for ALPHA [Re: cvs commit: src/sys/conf files.alpha src/sys/alpha/conf GENERIC NOTES] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 00:22:53 -0000 On Tue, Jul 22, 2003 at 12:04:19AM +0200, Wilko Bulte wrote: > > without CDs or bandwidth. We do not do floppies for sparc64 and ia64, > > and I would hope/expect that we don't do them for amd64. I think it's > > time to cut them out of Alpha. > > Absolutely. But everytime we planned on doing that there was uproar. There has never been an uproar in "modern times" about removing floppy install support for Alpha. The only uproar the last time this came up (during the 5.1 release cycle), the nay sayers did not read carefully and thought x86 was included in the discussion. Sorry, there is RU who wants to keep them for "fun" it seems. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Jul 21 18:35:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8AE3737B401; Mon, 21 Jul 2003 18:35:10 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E3ED443F85; Mon, 21 Jul 2003 18:35:09 -0700 (PDT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M1Z90U026346; Mon, 21 Jul 2003 18:35:09 -0700 (PDT) (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M1Z9q5026345; Mon, 21 Jul 2003 18:35:09 -0700 (PDT) Message-Id: <200307220135.h6M1Z9q5026345@repoman.freebsd.org> From: Olivier Houchard Date: Mon, 21 Jul 2003 18:35:09 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pci if_sis.c if_sisreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 01:35:11 -0000 cognet 2003/07/21 18:35:09 PDT FreeBSD src repository Modified files: sys/pci if_sis.c if_sisreg.h Log: Erm, my previous commit was wrong and sis_tick() was only called each time sis_ioctl() was called, so one had to use ifconfig each time the cable got plugged in to be able to use the connection. Do it a better way now, add a "in_tick" field in the softc structure, call timeout() in sis_tick() and don't call it in sis_init() if in_tick is non-zero. Reported by: Landmark Networks Pointy hat to: cognet Revision Changes Path 1.79 +5 -1 src/sys/pci/if_sis.c 1.22 +1 -0 src/sys/pci/if_sisreg.h From owner-cvs-src@FreeBSD.ORG Mon Jul 21 19:12:56 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9225D37B401; Mon, 21 Jul 2003 19:12:56 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2AAEE43FA3; Mon, 21 Jul 2003 19:12:56 -0700 (PDT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M2Ct0U028813; Mon, 21 Jul 2003 19:12:55 -0700 (PDT) (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M2CtIZ028812; Mon, 21 Jul 2003 19:12:55 -0700 (PDT) Message-Id: <200307220212.h6M2CtIZ028812@repoman.freebsd.org> From: Paul Saab Date: Mon, 21 Jul 2003 19:12:55 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h src/sys/dev/mii brgphy.c miidevs miidevs.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 02:12:57 -0000 ps 2003/07/21 19:12:55 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/bge if_bge.c if_bgereg.h sys/dev/mii brgphy.c miidevs miidevs.h Log: MFC: support for the Broadcom 5705 Revision Changes Path 1.3.2.24 +233 -112 src/sys/dev/bge/if_bge.c 1.1.2.11 +78 -10 src/sys/dev/bge/if_bgereg.h 1.1.2.8 +26 -0 src/sys/dev/mii/brgphy.c 1.4.2.13 +1 -0 src/sys/dev/mii/miidevs 1.4.2.13 +3 -1 src/sys/dev/mii/miidevs.h From owner-cvs-src@FreeBSD.ORG Mon Jul 21 20:23:00 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA7F337B405 for ; Mon, 21 Jul 2003 20:23:00 -0700 (PDT) Received: from mail.speakeasy.net (mail7.speakeasy.net [216.254.0.207]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13D0D43FB1 for ; Mon, 21 Jul 2003 20:22:59 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 20820 invoked from network); 22 Jul 2003 03:22:58 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 22 Jul 2003 03:22:58 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6M3MuGI041027; Mon, 21 Jul 2003 23:22:56 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030721144250.B34834@root.org> Date: Mon, 21 Jul 2003 23:23:12 -0400 (EDT) From: John Baldwin To: Nate Lawson cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/acpica acpi_ec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 03:23:01 -0000 On 21-Jul-2003 Nate Lawson wrote: > On Mon, 21 Jul 2003, John Baldwin wrote: >> On 21-Jul-2003 Nate Lawson wrote: >> > The sequence with ECDT is: >> > acpi_attach() >> > acpi_ec_ecdt_probe() >> > if ECDT present >> > device_add_child("acpi_ec") >> > device_probe_and_attach() >> > acpi_ec_probe() >> > if ECDT magic set in ivars >> > done >> >> The magic part seems evil. I'm not sure yet of a better way to handle >> that though. > > The reason this was done is that there are two paths for getting resources > about the EC: ECDT and namespace. They can share a common probe/attach > function if we take the same route (ivars) for passing the data to > probe/attach. Since the ivars are zeroed before device_probe() is called > and an already probed ACPI_DEVICE object is extremely unlikely to use the > same magic since it's a pointer to the acpi_ec_devclass, this is a low > risk approach. I understand the reason for the magic approach, I'm just uncomfortable with it. I won't object to it though unless I manage to think of something cleaner. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Mon Jul 21 20:42:53 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 51A1C37B404 for ; Mon, 21 Jul 2003 20:42:53 -0700 (PDT) Received: from smtp.mho.com (smtp.mho.net [64.58.4.6]) by mx1.FreeBSD.org (Postfix) with SMTP id 4065643FB1 for ; Mon, 21 Jul 2003 20:42:51 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: (qmail 79140 invoked by uid 1002); 22 Jul 2003 03:42:50 -0000 Received: from adsl-64-58-12-196.mho.net (HELO freebsd.org) (64.58.12.196) by smtp.mho.net with SMTP; 22 Jul 2003 03:42:50 -0000 Message-ID: <3F1CB2C5.5060900@freebsd.org> Date: Mon, 21 Jul 2003 21:43:01 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Poul-Henning Kamp References: <200307211835.h6LIZpQu051797@repoman.freebsd.org> In-Reply-To: <200307211835.h6LIZpQu051797@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys cdefs.h systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 03:42:53 -0000 Poul-Henning Kamp wrote: > phk 2003/07/21 11:35:51 PDT > > FreeBSD src repository > > Modified files: > sys/sys cdefs.h systm.h > Log: > Add a new macro __nonnull(x) to use the new GCC33 attribute which checks > that an argument is not a NULL pointer. > > Apply various obvious places. > > I belive __printf*() implies __nonnull() so it is not needed on functions > already tagged that way. > > Revision Changes Path > 1.72 +6 -0 src/sys/sys/cdefs.h > 1.195 +16 -16 src/sys/sys/systm.h > strtoul and strtol are allowed to have their second argument be NULL. It's even expressly documented in the man page, and a casual look at libkern verifies it. Scott From owner-cvs-src@FreeBSD.ORG Mon Jul 21 23:01:12 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 961A337B401; Mon, 21 Jul 2003 23:01:12 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3435943FAF; Mon, 21 Jul 2003 23:01:12 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M61C0U045325; Mon, 21 Jul 2003 23:01:12 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M61BqO045324; Mon, 21 Jul 2003 23:01:11 -0700 (PDT) Message-Id: <200307220601.h6M61BqO045324@repoman.freebsd.org> From: Poul-Henning Kamp Date: Mon, 21 Jul 2003 23:01:11 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 06:01:13 -0000 phk 2003/07/21 23:01:11 PDT FreeBSD src repository Modified files: sys/sys systm.h Log: Remove __nonnull() on the second argument of strto[u]l() which I used to test that the warning actually was emitted. Spotted by: scottl Revision Changes Path 1.197 +2 -2 src/sys/sys/systm.h From owner-cvs-src@FreeBSD.ORG Mon Jul 21 23:31:13 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E25E637B401; Mon, 21 Jul 2003 23:31:13 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 80BBD43FA3; Mon, 21 Jul 2003 23:31:13 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M6VD0U047514; Mon, 21 Jul 2003 23:31:13 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M6VDwO047513; Mon, 21 Jul 2003 23:31:13 -0700 (PDT) Message-Id: <200307220631.h6M6VDwO047513@repoman.freebsd.org> From: Hartmut Brandt Date: Mon, 21 Jul 2003 23:31:13 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_if.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 06:31:14 -0000 harti 2003/07/21 23:31:13 PDT FreeBSD src repository Modified files: sys/netatm atm_if.h Log: Add several vendor, API and media definitions. This has been forgotten in the previous commit to harp and should unbreak world. Revision Changes Path 1.17 +27 -5 src/sys/netatm/atm_if.h From owner-cvs-src@FreeBSD.ORG Mon Jul 21 23:34:58 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2582937B401; Mon, 21 Jul 2003 23:34:58 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7F2D43F75; Mon, 21 Jul 2003 23:34:57 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M6Yv0U047617; Mon, 21 Jul 2003 23:34:57 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M6Yv4O047616; Mon, 21 Jul 2003 23:34:57 -0700 (PDT) Message-Id: <200307220634.h6M6Yv4O047616@repoman.freebsd.org> From: Peter Wemm Date: Mon, 21 Jul 2003 23:34:57 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/amd64 Makefile.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 06:34:58 -0000 peter 2003/07/21 23:34:57 PDT FreeBSD src repository Added files: lib/libc/amd64 Makefile.inc Log: Turn off the libc/quad functions since they are not needed for amd64 and just cause lots of warnings. Revision Changes Path 1.1 +9 -0 src/lib/libc/amd64/Makefile.inc (new) From owner-cvs-src@FreeBSD.ORG Mon Jul 21 23:44:57 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B4C4F37B401; Mon, 21 Jul 2003 23:44:55 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F68E43F93; Mon, 21 Jul 2003 23:44:55 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M6it0U048156; Mon, 21 Jul 2003 23:44:55 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M6it34048155; Mon, 21 Jul 2003 23:44:55 -0700 (PDT) Message-Id: <200307220644.h6M6it34048155@repoman.freebsd.org> From: Peter Wemm Date: Mon, 21 Jul 2003 23:44:55 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/include ieeefp.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 06:44:58 -0000 peter 2003/07/21 23:44:55 PDT FreeBSD src repository Modified files: sys/amd64/include ieeefp.h Log: Extend the machine/ieeefp.h that was inherited from i386 to support the SSE mxcsr register as well. Since gcc will intermix SSE2 and x87 FP code, the fpsetround() etc mode had better be the same. There are hooks to enable these inlines to be instantiated inside libc for non-gcc or C++ callers. (g++ doesn't like the inlines that tried to extract an integer and convert it to an enum). Revision Changes Path 1.9 +164 -54 src/sys/amd64/include/ieeefp.h From owner-cvs-src@FreeBSD.ORG Mon Jul 21 23:46:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0285637B401; Mon, 21 Jul 2003 23:46:18 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C3C043FB1; Mon, 21 Jul 2003 23:46:17 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M6kH0U048326; Mon, 21 Jul 2003 23:46:17 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M6kHHR048325; Mon, 21 Jul 2003 23:46:17 -0700 (PDT) Message-Id: <200307220646.h6M6kHHR048325@repoman.freebsd.org> From: Peter Wemm Date: Mon, 21 Jul 2003 23:46:17 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/amd64/gen Makefile.inc fpgetmask.c fpgetprec.c fpgetround.c fpgetsticky.c fpsetmask.c fpsetprec.c fpsetround.c fpsetsticky.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 06:46:18 -0000 peter 2003/07/21 23:46:17 PDT FreeBSD src repository Modified files: lib/libc/amd64/gen Makefile.inc Added files: lib/libc/amd64/gen fpgetmask.c fpgetprec.c fpgetround.c fpgetsticky.c fpsetmask.c fpsetprec.c fpsetround.c fpsetsticky.c Log: Instantiate explicit callable versions of the machine/ieeefp.h inlines for the use of non-GCC compilers and C++ code. Revision Changes Path 1.23 +3 -1 src/lib/libc/amd64/gen/Makefile.inc 1.1 +8 -0 src/lib/libc/amd64/gen/fpgetmask.c (new) 1.1 +8 -0 src/lib/libc/amd64/gen/fpgetprec.c (new) 1.1 +8 -0 src/lib/libc/amd64/gen/fpgetround.c (new) 1.1 +8 -0 src/lib/libc/amd64/gen/fpgetsticky.c (new) 1.1 +8 -0 src/lib/libc/amd64/gen/fpsetmask.c (new) 1.1 +8 -0 src/lib/libc/amd64/gen/fpsetprec.c (new) 1.1 +8 -0 src/lib/libc/amd64/gen/fpsetround.c (new) 1.1 +8 -0 src/lib/libc/amd64/gen/fpsetsticky.c (new) From owner-cvs-src@FreeBSD.ORG Mon Jul 21 23:50:35 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9637037B401; Mon, 21 Jul 2003 23:50:35 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 329CF43F85; Mon, 21 Jul 2003 23:50:35 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M6oY0U048534; Mon, 21 Jul 2003 23:50:34 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M6oY32048533; Mon, 21 Jul 2003 23:50:34 -0700 (PDT) Message-Id: <200307220650.h6M6oY32048533@repoman.freebsd.org> From: Peter Wemm Date: Mon, 21 Jul 2003 23:50:34 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/include npx.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 06:50:35 -0000 peter 2003/07/21 23:50:34 PDT FreeBSD src repository Modified files: sys/amd64/include npx.h Log: Go back to 64 bit precision for fadd/fsub/fsqrt etc. This is because on AMD64, gcc (and the ABI) expects the x87 unit to be running in 80/64 mode (not 64/53) so that it can use it for 'long double' operations. It takes the expected precision differences into account when generating code. Revision Changes Path 1.29 +9 -8 src/sys/amd64/include/npx.h From owner-cvs-src@FreeBSD.ORG Mon Jul 21 23:55:49 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28C9C37B401; Mon, 21 Jul 2003 23:55:49 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB3AD43FBD; Mon, 21 Jul 2003 23:55:48 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M6tm0U048714; Mon, 21 Jul 2003 23:55:48 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M6tmmo048713; Mon, 21 Jul 2003 23:55:48 -0700 (PDT) Message-Id: <200307220655.h6M6tmmo048713@repoman.freebsd.org> From: Peter Wemm Date: Mon, 21 Jul 2003 23:55:48 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 06:55:49 -0000 peter 2003/07/21 23:55:48 PDT FreeBSD src repository Modified files: sys/vm swap_pager.c Log: swp_pager_hash() was called before it was instantiated inline. This made gcc (quite rightly) unhappy. Move it earlier. Revision Changes Path 1.209 +29 -29 src/sys/vm/swap_pager.c From owner-cvs-src@FreeBSD.ORG Mon Jul 21 23:58:05 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AEDF37B401; Mon, 21 Jul 2003 23:58:05 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1857543FBF; Mon, 21 Jul 2003 23:58:05 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M6w40U048825; Mon, 21 Jul 2003 23:58:04 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M6w4g0048824; Mon, 21 Jul 2003 23:58:04 -0700 (PDT) Message-Id: <200307220658.h6M6w4g0048824@repoman.freebsd.org> From: Peter Wemm Date: Mon, 21 Jul 2003 23:58:04 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/usb usb_mem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 06:58:05 -0000 peter 2003/07/21 23:58:04 PDT FreeBSD src repository Modified files: sys/dev/usb usb_mem.c Log: Fix a 64 bit bug lost in the inline warning noise. sizeof is not always an int. Do not printf() it as though it were. Revision Changes Path 1.3 +1 -1 src/sys/dev/usb/usb_mem.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 00:02:05 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E97E37B404; Tue, 22 Jul 2003 00:02:05 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id E1F2143FCB; Tue, 22 Jul 2003 00:01:59 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6LJiC0U042649 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 21 Jul 2003 22:44:12 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6LJiB0B042644; Mon, 21 Jul 2003 22:44:11 +0300 (EEST) (envelope-from ru) Date: Mon, 21 Jul 2003 22:44:11 +0300 From: Ruslan Ermilov To: Bernd Walter Message-ID: <20030721194411.GC40673@sunbay.com> References: <200307211915.h6LJFPJY054212@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tNQTSEo8WG/FKZ8E" Content-Disposition: inline In-Reply-To: <200307211915.h6LJFPJY054212@repoman.freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files.alpha src/sys/alpha/conf GENERIC NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 07:02:06 -0000 --tNQTSEo8WG/FKZ8E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 21, 2003 at 12:15:25PM -0700, Bernd Walter wrote: > ticso 2003/07/21 12:15:25 PDT >=20 > FreeBSD src repository >=20 > Modified files: > sys/conf files.alpha=20 > sys/alpha/conf GENERIC NOTES=20 > Log: > Enable eisa support on alpha. > We need eisa bridge support on some models, which now depends on having > eisa in the kernel. > =20 > Revision Changes Path > 1.162 +1 -0 src/sys/alpha/conf/GENERIC > 1.152 +1 -0 src/sys/alpha/conf/NOTES > 1.102 +1 -0 src/sys/conf/files.alpha >=20 Has this been tested with "make release" to not break it? Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --tNQTSEo8WG/FKZ8E Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/HEKLUkv4P6juNwoRAl5PAJ9HvddAqG87nXtYEtwVNDSNdpY06ACfeWzU Cf+Qk95EdCUzchdxMUkmTvI= =fQhU -----END PGP SIGNATURE----- --tNQTSEo8WG/FKZ8E-- From owner-cvs-src@FreeBSD.ORG Tue Jul 22 00:02:42 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0481537B401; Tue, 22 Jul 2003 00:02:42 -0700 (PDT) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by mx1.FreeBSD.org (Postfix) with ESMTP id 517B043F85; Tue, 22 Jul 2003 00:02:40 -0700 (PDT) (envelope-from wkb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.12.9/8.12.9) with ESMTP id h6M72dxd002717; Tue, 22 Jul 2003 09:02:39 +0200 (CEST) (envelope-from wkb@freebie.xs4all.nl) Received: (from wkb@localhost) by freebie.xs4all.nl (8.12.9/8.12.9/Submit) id h6M72dwQ002716; Tue, 22 Jul 2003 09:02:39 +0200 (CEST) Date: Tue, 22 Jul 2003 09:02:39 +0200 From: Wilko Bulte To: Scott Long Message-ID: <20030722070239.GA2687@freebie.xs4all.nl> References: <200307211915.h6LJFPJY054212@repoman.freebsd.org> <20030721214042.GA563@freebie.xs4all.nl> <3F1C6216.3020006@freebsd.org> <20030721220419.GA909@freebie.xs4all.nl> <3F1C6633.5070009@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F1C6633.5070009@freebsd.org> User-Agent: Mutt/1.4i X-OS: FreeBSD 4.8-STABLE X-PGP: finger wilko@freebsd.org cc: cvs-src@freebsd.org cc: Bernd Walter cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: Floppies for ALPHA [Re: cvs commit: src/sys/conf files.alpha src/sys/alpha/conf GENERIC NOTES] X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 07:02:42 -0000 On Mon, Jul 21, 2003 at 04:16:19PM -0600, Scott Long wrote: > Wilko Bulte wrote: > >On Mon, Jul 21, 2003 at 03:58:46PM -0600, Scott Long wrote: > > > >>Wilko Bulte wrote: > >> > >>>On Mon, Jul 21, 2003 at 12:15:25PM -0700, Bernd Walter wrote: > >>> > >>> > >>>>ticso 2003/07/21 12:15:25 PDT > >>>> > >>>>FreeBSD src repository > >>>> > >>>>Modified files: > >>>> sys/conf files.alpha > >>>> sys/alpha/conf GENERIC NOTES > >>>>Log: > >>>>Enable eisa support on alpha. > >>>>We need eisa bridge support on some models, which now depends on having > >>>>eisa in the kernel. > >>> > >>> > >>>Without having checked: what about the bootfloppy? > >>> > >> > >>This is a loosing fight. While there is still some value in having > >>floppies for x86, is there really any value in them for Alpha? My > >>understanding is that CD-ROMs have been standard on all Alphas for > >>the past 5-10 years. Netbooting is an easy alternative for those > > > > > >Correct. On all Alpha's in fact. Even the DEC3000 etc. > > > > > >>without CDs or bandwidth. We do not do floppies for sparc64 and ia64, > >>and I would hope/expect that we don't do them for amd64. I think it's > >>time to cut them out of Alpha. > > > > > >Absolutely. But everytime we planned on doing that there was uproar. > >You obviously loose the network install with just a floppy to boot from. > >But miniinst.iso fills that gap, at least IMHO. > > > >W/ > > > > Is there an alternative for those in remote areas that can neither > download the miniiso nor buy the cd set? Every time that we talk about > downloading iso's, the issue comes up of those in eastern-bloc and > asian countries that have little bandwidth. Can Alpha do a 'boot-only' > cd image that is <5MB? Maybe. But you would need a lot of other stuff to make it useful as an installed system so why would the size of the boot'kit' be so important? I mean, you need the rest of the bits downloaded anyway to get a useful installation. Wilko -- | / o / /_ _ wilko@FreeBSD.org |/|/ / / /( (_) Bulte From owner-cvs-src@FreeBSD.ORG Tue Jul 22 00:41:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D3C737B401; Tue, 22 Jul 2003 00:41:25 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2BBD243FBD; Tue, 22 Jul 2003 00:41:25 -0700 (PDT) (envelope-from luigi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M7fO0U051370; Tue, 22 Jul 2003 00:41:25 -0700 (PDT) (envelope-from luigi@repoman.freebsd.org) Received: (from luigi@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M7fOp2051369; Tue, 22 Jul 2003 00:41:24 -0700 (PDT) Message-Id: <200307220741.h6M7fOp2051369@repoman.freebsd.org> From: Luigi Rizzo Date: Tue, 22 Jul 2003 00:41:24 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/ipfw ipfw.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 07:41:26 -0000 luigi 2003/07/22 00:41:24 PDT FreeBSD src repository Modified files: sbin/ipfw ipfw.8 Log: Add a note that net.inet.ip.fw.autoinc_step is ipfw2-specific Revision Changes Path 1.131 +4 -0 src/sbin/ipfw/ipfw.8 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 01:03:14 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DFFF37B407; Tue, 22 Jul 2003 01:03:14 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A82A43F85; Tue, 22 Jul 2003 01:03:14 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M83D0U058436; Tue, 22 Jul 2003 01:03:13 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M83DNP058435; Tue, 22 Jul 2003 01:03:13 -0700 (PDT) Message-Id: <200307220803.h6M83DNP058435@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 22 Jul 2003 01:03:13 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/usr.bin/make cond.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 08:03:15 -0000 ru 2003/07/22 01:03:13 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) usr.bin/make cond.c Log: MFC: 1.26: Fixed broken arithmetic expression parser. PR: bin/44750 Revision Changes Path 1.12.2.1 +2 -5 src/usr.bin/make/cond.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 01:11:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9825537B401; Tue, 22 Jul 2003 01:11:18 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 195E843FAF; Tue, 22 Jul 2003 01:11:18 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M8BH0U059017; Tue, 22 Jul 2003 01:11:17 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M8BHIh059016; Tue, 22 Jul 2003 01:11:17 -0700 (PDT) Message-Id: <200307220811.h6M8BHIh059016@repoman.freebsd.org> From: Peter Wemm Date: Tue, 22 Jul 2003 01:11:17 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf files.i386 files.pc98 options.i386 options.pc98 src/sys/gnu/i386/fpemul Changelog README control_w.h div_small.s errors.c exception.h fpu_arith.c fpu_asm.h fpu_aux.c fpu_emu.h fpu_entry.c fpu_etc.c fpu_proto.h fpu_system.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 08:11:19 -0000 peter 2003/07/22 01:11:17 PDT FreeBSD src repository Modified files: sys/conf files.i386 files.pc98 options.i386 options.pc98 sys/i386/conf NOTES sys/i386/i386 trap.c sys/i386/include frame.h sys/i386/isa npx.c sys/modules Makefile sys/pc98/conf GENERIC NOTES Removed files: sys/gnu/i386/fpemul Changelog README control_w.h div_small.s errors.c exception.h fpu_arith.c fpu_asm.h fpu_aux.c fpu_emu.h fpu_entry.c fpu_etc.c fpu_proto.h fpu_system.h fpu_trig.c get_address.c load_store.c math_emu.h poly_2xm1.c poly_atan.c poly_div.s poly_l2.c poly_mul64.s poly_sin.c poly_tan.c polynomial.s reg_add_sub.c reg_compare.c reg_constant.c reg_constant.h reg_div.s reg_ld_str.c reg_mul.c reg_norm.s reg_round.s reg_u_add.s reg_u_div.s reg_u_mul.s reg_u_sub.s status_w.h version.h wm_shrx.s wm_sqrt.s sys/i386/i386 math_emu.h math_emulate.c sys/modules/fpu Makefile sys/modules/gnufpu Makefile Log: Initiate de-orbit burn for fpu-less operation. 386+387 is still theoretically supportable, but you'd really be happier with FreeBSD 2.1.8 on it. Revision Changes Path 1.447 +0 -33 src/sys/conf/files.i386 1.273 +0 -33 src/sys/conf/files.pc98 1.195 +0 -2 src/sys/conf/options.i386 1.167 +0 -2 src/sys/conf/options.pc98 1.3 +0 -38 src/sys/gnu/i386/fpemul/Changelog (dead) 1.4 +0 -278 src/sys/gnu/i386/fpemul/README (dead) 1.8 +0 -95 src/sys/gnu/i386/fpemul/control_w.h (dead) 1.9 +0 -97 src/sys/gnu/i386/fpemul/div_small.s (dead) 1.11 +0 -608 src/sys/gnu/i386/fpemul/errors.c (dead) 1.10 +0 -105 src/sys/gnu/i386/fpemul/exception.h (dead) 1.10 +0 -233 src/sys/gnu/i386/fpemul/fpu_arith.c (dead) 1.10 +0 -83 src/sys/gnu/i386/fpemul/fpu_asm.h (dead) 1.15 +0 -233 src/sys/gnu/i386/fpemul/fpu_aux.c (dead) 1.8 +0 -188 src/sys/gnu/i386/fpemul/fpu_emu.h (dead) 1.29 +0 -524 src/sys/gnu/i386/fpemul/fpu_entry.c (dead) 1.9 +0 -176 src/sys/gnu/i386/fpemul/fpu_etc.c (dead) 1.9 +0 -114 src/sys/gnu/i386/fpemul/fpu_proto.h (dead) 1.10 +0 -97 src/sys/gnu/i386/fpemul/fpu_system.h (dead) 1.12 +0 -1371 src/sys/gnu/i386/fpemul/fpu_trig.c (dead) 1.11 +0 -202 src/sys/gnu/i386/fpemul/get_address.c (dead) 1.15 +0 -273 src/sys/gnu/i386/fpemul/load_store.c (dead) 1.6 +0 -47 src/sys/gnu/i386/fpemul/math_emu.h (dead) 1.9 +0 -139 src/sys/gnu/i386/fpemul/poly_2xm1.c (dead) 1.11 +0 -251 src/sys/gnu/i386/fpemul/poly_atan.c (dead) 1.9 +0 -138 src/sys/gnu/i386/fpemul/poly_div.s (dead) 1.11 +0 -316 src/sys/gnu/i386/fpemul/poly_l2.c (dead) 1.9 +0 -122 src/sys/gnu/i386/fpemul/poly_mul64.s (dead) 1.11 +0 -195 src/sys/gnu/i386/fpemul/poly_sin.c (dead) 1.11 +0 -227 src/sys/gnu/i386/fpemul/poly_tan.c (dead) 1.10 +0 -190 src/sys/gnu/i386/fpemul/polynomial.s (dead) 1.9 +0 -300 src/sys/gnu/i386/fpemul/reg_add_sub.c (dead) 1.12 +0 -385 src/sys/gnu/i386/fpemul/reg_compare.c (dead) 1.8 +0 -166 src/sys/gnu/i386/fpemul/reg_constant.c (dead) 1.8 +0 -82 src/sys/gnu/i386/fpemul/reg_constant.h (dead) 1.13 +0 -290 src/sys/gnu/i386/fpemul/reg_div.s (dead) 1.15 +0 -1388 src/sys/gnu/i386/fpemul/reg_ld_str.c (dead) 1.9 +0 -159 src/sys/gnu/i386/fpemul/reg_mul.c (dead) 1.10 +0 -176 src/sys/gnu/i386/fpemul/reg_norm.s (dead) 1.14 +0 -650 src/sys/gnu/i386/fpemul/reg_round.s (dead) 1.12 +0 -240 src/sys/gnu/i386/fpemul/reg_u_add.s (dead) 1.12 +0 -501 src/sys/gnu/i386/fpemul/reg_u_div.s (dead) 1.12 +0 -194 src/sys/gnu/i386/fpemul/reg_u_mul.s (dead) 1.12 +0 -357 src/sys/gnu/i386/fpemul/reg_u_sub.s (dead) 1.7 +0 -106 src/sys/gnu/i386/fpemul/status_w.h (dead) 1.7 +0 -61 src/sys/gnu/i386/fpemul/version.h (dead) 1.10 +0 -258 src/sys/gnu/i386/fpemul/wm_shrx.s (dead) 1.12 +0 -492 src/sys/gnu/i386/fpemul/wm_sqrt.s (dead) 1.1091 +0 -10 src/sys/i386/conf/NOTES 1.10 +0 -156 src/sys/i386/i386/math_emu.h (dead) 1.44 +0 -1582 src/sys/i386/i386/math_emulate.c (dead) 1.255 +2 -17 src/sys/i386/i386/trap.c 1.23 +0 -1 src/sys/i386/include/frame.h 1.142 +3 -25 src/sys/i386/isa/npx.c 1.343 +1 -3 src/sys/modules/Makefile 1.11 +0 -8 src/sys/modules/fpu/Makefile (dead) 1.13 +0 -18 src/sys/modules/gnufpu/Makefile (dead) 1.236 +0 -1 src/sys/pc98/conf/GENERIC 1.11 +0 -10 src/sys/pc98/conf/NOTES From owner-cvs-src@FreeBSD.ORG Tue Jul 22 01:15:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7955E37B401; Tue, 22 Jul 2003 01:15:30 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 16CEC43FAF; Tue, 22 Jul 2003 01:15:30 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M8FT0U059258; Tue, 22 Jul 2003 01:15:29 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M8FT7P059257; Tue, 22 Jul 2003 01:15:29 -0700 (PDT) Message-Id: <200307220815.h6M8FT7P059257@repoman.freebsd.org> From: Peter Wemm Date: Tue, 22 Jul 2003 01:15:29 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4/man4.i386 npx.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 08:15:30 -0000 peter 2003/07/22 01:15:29 PDT FreeBSD src repository Modified files: share/man/man4/man4.i386 npx.4 Log: Update npx status. Reminded by: tjr Revision Changes Path 1.17 +4 -56 src/share/man/man4/man4.i386/npx.4 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 01:19:24 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2E0D837B401; Tue, 22 Jul 2003 01:19:24 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1802343F85; Tue, 22 Jul 2003 01:16:13 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6M8GBV3002170; Tue, 22 Jul 2003 08:16:11 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6M8GB5H008762; Tue, 22 Jul 2003 10:16:11 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Peter Wemm From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 01:11:17 PDT." <200307220811.h6M8BHIh059016@repoman.freebsd.org> Date: Tue, 22 Jul 2003 10:16:11 +0200 Message-ID: <8761.1058861771@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files.i386 files.pc98 options.i386 options.pc98 src/sys/gnu/i386/fpemul Changelog README control_w.h div_small.s errors.c exception.h fpu_arith.c fpu_asm.h fpu_aux.c fpu_emu.h fpu_entry.c fpu_etc.c fpu_proto.h fpu_system.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 08:19:24 -0000 In message <200307220811.h6M8BHIh059016@repoman.freebsd.org>, Peter Wemm writes : > Log: > Initiate de-orbit burn for fpu-less operation. 386+387 is still > theoretically supportable, but you'd really be happier with FreeBSD 2.1.8 > on it. It's nice to see somebody drag FreeBSD kicking and screaming into the century of the fruitbat. Thanks a lot Peter! -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 01:19:48 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D7C7D37B405; Tue, 22 Jul 2003 01:19:48 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE34E43FF3; Tue, 22 Jul 2003 01:17:17 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id B74F12A8B2; Tue, 22 Jul 2003 01:17:16 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <200307220811.h6M8BHIh059016@repoman.freebsd.org> Date: Tue, 22 Jul 2003 01:17:16 -0700 From: Peter Wemm Message-Id: <20030722081716.B74F12A8B2@canning.wemm.org> Subject: Re: cvs commit: src/sys/conf files.i386 files.pc98 options.i386 options.pc98 src/sys/gnu/i386/fpemul Changelog README control_w.h div_small.s errors.c exception.h fpu_arith.c fpu_asm.h fpu_aux.c fpu_emu.h fpu_entry.c fpu_etc.c fpu_proto.h fpu_system.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 08:19:49 -0000 Peter Wemm wrote: > Log: > Initiate de-orbit burn for fpu-less operation. 386+387 is still > theoretically supportable, but you'd really be happier with FreeBSD 2.1.8 > on it. Yes, I have already picked out my spot in hell. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 01:20:11 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B9EF637B528; Tue, 22 Jul 2003 01:20:10 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2589743F93; Tue, 22 Jul 2003 01:20:10 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M8K90U059435; Tue, 22 Jul 2003 01:20:09 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M8K92o059434; Tue, 22 Jul 2003 01:20:09 -0700 (PDT) Message-Id: <200307220820.h6M8K92o059434@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 22 Jul 2003 01:20:09 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/patm if_patm_tx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 08:20:11 -0000 harti 2003/07/22 01:20:09 PDT FreeBSD src repository Modified files: sys/dev/patm if_patm_tx.c Log: When padding an mbuf chain to have a length that is a multiple of 48 bytes for AAL0, we also need to update the packet header. Spotted by: Anil Madhavapeddy Revision Changes Path 1.2 +1 -0 src/sys/dev/patm/if_patm_tx.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 01:20:53 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84B2937B401; Tue, 22 Jul 2003 01:20:53 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id E17A143FBF; Tue, 22 Jul 2003 01:17:50 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6M8Hc0U011379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Jul 2003 11:17:40 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6M8Hcrh011374; Tue, 22 Jul 2003 11:17:38 +0300 (EEST) (envelope-from ru) Date: Tue, 22 Jul 2003 11:17:38 +0300 From: Ruslan Ermilov To: Scott Long , Peter Wemm Message-ID: <20030722081738.GB7811@sunbay.com> References: <200307211915.h6LJFPJY054212@repoman.freebsd.org> <20030721214042.GA563@freebie.xs4all.nl> <3F1C6216.3020006@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1UWUbFP1cBYEclgG" Content-Disposition: inline In-Reply-To: <3F1C6216.3020006@freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: Bernd Walter cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Wilko Bulte Subject: Re: Floppies for ALPHA X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 08:20:53 -0000 --1UWUbFP1cBYEclgG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 21, 2003 at 03:58:46PM -0600, Scott Long wrote: [...] > This is a loosing fight. While there is still some value in having > floppies for x86, is there really any value in them for Alpha? My > understanding is that CD-ROMs have been standard on all Alphas for > the past 5-10 years. Netbooting is an easy alternative for those > without CDs or bandwidth. We do not do floppies for sparc64 and ia64, > and I would hope/expect that we don't do them for amd64. I think it's > time to cut them out of Alpha. >=20 I plan on working on removing floppy support for AMD64 now. Not that we support installing from floppies on AMD64 now, no, this is rather a tidying up of release/Makefile and other infrastructure. After that, it will be trivial to axe the floppy support for Alpha too. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --1UWUbFP1cBYEclgG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD4DBQE/HPMiUkv4P6juNwoRAouzAJUTLay7UKslmsx9w46Neq04jasHAJ9LotiV K4CyS0Pii/jTp/CNN1F6QQ== =/s24 -----END PGP SIGNATURE----- --1UWUbFP1cBYEclgG-- From owner-cvs-src@FreeBSD.ORG Tue Jul 22 01:39:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C14337B401; Tue, 22 Jul 2003 01:39:01 -0700 (PDT) Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.157.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8279643FAF; Tue, 22 Jul 2003 01:39:00 -0700 (PDT) (envelope-from mark@grondar.org) Received: from storm.FreeBSD.org.uk (Ugrondar@localhost [127.0.0.1]) by storm.FreeBSD.org.uk (8.12.9/8.12.9) with ESMTP id h6M8cwHo081876; Tue, 22 Jul 2003 09:38:58 +0100 (BST) (envelope-from mark@grondar.org) Received: (from Ugrondar@localhost)h6M8cwpR081873; Tue, 22 Jul 2003 09:38:58 +0100 (BST) X-Authentication-Warning: storm.FreeBSD.org.uk: Ugrondar set sender to mark@grondar.org using -f Received: from grondar.org (localhost [127.0.0.1])h6M8cNZ2058499; Tue, 22 Jul 2003 09:38:23 +0100 (BST) (envelope-from mark@grondar.org) From: Mark Murray Message-Id: <200307220838.h6M8cNZ2058499@grimreaper.grondar.org> To: Peter Wemm In-Reply-To: Your message of "Tue, 22 Jul 2003 01:11:17 PDT." <200307220811.h6M8BHIh059016@repoman.freebsd.org> Date: Tue, 22 Jul 2003 09:38:22 +0100 Sender: mark@grondar.org X-Spam-Status: No, hits=0.2 required=5.0 tests=EMAIL_ATTRIBUTION,FROM_NO_LOWER,IN_REP_TO, QUOTED_EMAIL_TEXT,REPLY_WITH_QUOTES version=2.55 X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files.i386 files.pc98 options.i386 options.pc98 src/sys/gnu/i386/fpemul Changelog README control_w.h div_small.s errors.c exception.h fpu_arith.c fpu_asm.h fpu_aux.c fpu_emu.h fpu_entry.c fpu_etc.c fpu_proto.h fpu_system.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 08:39:03 -0000 Yay! :-) M Peter Wemm writes: > peter 2003/07/22 01:11:17 PDT > > FreeBSD src repository > > Modified files: > sys/conf files.i386 files.pc98 options.i386 > options.pc98 > sys/i386/conf NOTES > sys/i386/i386 trap.c > sys/i386/include frame.h > sys/i386/isa npx.c > sys/modules Makefile > sys/pc98/conf GENERIC NOTES > Removed files: > sys/gnu/i386/fpemul Changelog README control_w.h div_small.s > errors.c exception.h fpu_arith.c > fpu_asm.h fpu_aux.c fpu_emu.h fpu_entry.c > fpu_etc.c fpu_proto.h fpu_system.h > fpu_trig.c get_address.c load_store.c > math_emu.h poly_2xm1.c poly_atan.c > poly_div.s poly_l2.c poly_mul64.s > poly_sin.c poly_tan.c polynomial.s > reg_add_sub.c reg_compare.c > reg_constant.c reg_constant.h reg_div.s > reg_ld_str.c reg_mul.c reg_norm.s > reg_round.s reg_u_add.s reg_u_div.s > reg_u_mul.s reg_u_sub.s status_w.h > version.h wm_shrx.s wm_sqrt.s > sys/i386/i386 math_emu.h math_emulate.c > sys/modules/fpu Makefile > sys/modules/gnufpu Makefile > Log: > Initiate de-orbit burn for fpu-less operation. 386+387 is still > theoretically supportable, but you'd really be happier with FreeBSD 2.1.8 > on it. > > Revision Changes Path > 1.447 +0 -33 src/sys/conf/files.i386 > 1.273 +0 -33 src/sys/conf/files.pc98 > 1.195 +0 -2 src/sys/conf/options.i386 > 1.167 +0 -2 src/sys/conf/options.pc98 > 1.3 +0 -38 src/sys/gnu/i386/fpemul/Changelog (dead) > 1.4 +0 -278 src/sys/gnu/i386/fpemul/README (dead) > 1.8 +0 -95 src/sys/gnu/i386/fpemul/control_w.h (dead) > 1.9 +0 -97 src/sys/gnu/i386/fpemul/div_small.s (dead) > 1.11 +0 -608 src/sys/gnu/i386/fpemul/errors.c (dead) > 1.10 +0 -105 src/sys/gnu/i386/fpemul/exception.h (dead) > 1.10 +0 -233 src/sys/gnu/i386/fpemul/fpu_arith.c (dead) > 1.10 +0 -83 src/sys/gnu/i386/fpemul/fpu_asm.h (dead) > 1.15 +0 -233 src/sys/gnu/i386/fpemul/fpu_aux.c (dead) > 1.8 +0 -188 src/sys/gnu/i386/fpemul/fpu_emu.h (dead) > 1.29 +0 -524 src/sys/gnu/i386/fpemul/fpu_entry.c (dead) > 1.9 +0 -176 src/sys/gnu/i386/fpemul/fpu_etc.c (dead) > 1.9 +0 -114 src/sys/gnu/i386/fpemul/fpu_proto.h (dead) > 1.10 +0 -97 src/sys/gnu/i386/fpemul/fpu_system.h (dead) > 1.12 +0 -1371 src/sys/gnu/i386/fpemul/fpu_trig.c (dead) > 1.11 +0 -202 src/sys/gnu/i386/fpemul/get_address.c (dead) > 1.15 +0 -273 src/sys/gnu/i386/fpemul/load_store.c (dead) > 1.6 +0 -47 src/sys/gnu/i386/fpemul/math_emu.h (dead) > 1.9 +0 -139 src/sys/gnu/i386/fpemul/poly_2xm1.c (dead) > 1.11 +0 -251 src/sys/gnu/i386/fpemul/poly_atan.c (dead) > 1.9 +0 -138 src/sys/gnu/i386/fpemul/poly_div.s (dead) > 1.11 +0 -316 src/sys/gnu/i386/fpemul/poly_l2.c (dead) > 1.9 +0 -122 src/sys/gnu/i386/fpemul/poly_mul64.s (dead) > 1.11 +0 -195 src/sys/gnu/i386/fpemul/poly_sin.c (dead) > 1.11 +0 -227 src/sys/gnu/i386/fpemul/poly_tan.c (dead) > 1.10 +0 -190 src/sys/gnu/i386/fpemul/polynomial.s (dead) > 1.9 +0 -300 src/sys/gnu/i386/fpemul/reg_add_sub.c (dead) > 1.12 +0 -385 src/sys/gnu/i386/fpemul/reg_compare.c (dead) > 1.8 +0 -166 src/sys/gnu/i386/fpemul/reg_constant.c (dead) > 1.8 +0 -82 src/sys/gnu/i386/fpemul/reg_constant.h (dead) > 1.13 +0 -290 src/sys/gnu/i386/fpemul/reg_div.s (dead) > 1.15 +0 -1388 src/sys/gnu/i386/fpemul/reg_ld_str.c (dead) > 1.9 +0 -159 src/sys/gnu/i386/fpemul/reg_mul.c (dead) > 1.10 +0 -176 src/sys/gnu/i386/fpemul/reg_norm.s (dead) > 1.14 +0 -650 src/sys/gnu/i386/fpemul/reg_round.s (dead) > 1.12 +0 -240 src/sys/gnu/i386/fpemul/reg_u_add.s (dead) > 1.12 +0 -501 src/sys/gnu/i386/fpemul/reg_u_div.s (dead) > 1.12 +0 -194 src/sys/gnu/i386/fpemul/reg_u_mul.s (dead) > 1.12 +0 -357 src/sys/gnu/i386/fpemul/reg_u_sub.s (dead) > 1.7 +0 -106 src/sys/gnu/i386/fpemul/status_w.h (dead) > 1.7 +0 -61 src/sys/gnu/i386/fpemul/version.h (dead) > 1.10 +0 -258 src/sys/gnu/i386/fpemul/wm_shrx.s (dead) > 1.12 +0 -492 src/sys/gnu/i386/fpemul/wm_sqrt.s (dead) > 1.1091 +0 -10 src/sys/i386/conf/NOTES > 1.10 +0 -156 src/sys/i386/i386/math_emu.h (dead) > 1.44 +0 -1582 src/sys/i386/i386/math_emulate.c (dead) > 1.255 +2 -17 src/sys/i386/i386/trap.c > 1.23 +0 -1 src/sys/i386/include/frame.h > 1.142 +3 -25 src/sys/i386/isa/npx.c > 1.343 +1 -3 src/sys/modules/Makefile > 1.11 +0 -8 src/sys/modules/fpu/Makefile (dead) > 1.13 +0 -18 src/sys/modules/gnufpu/Makefile (dead) > 1.236 +0 -1 src/sys/pc98/conf/GENERIC > 1.11 +0 -10 src/sys/pc98/conf/NOTES -- Mark Murray iumop ap!sdn w,I idlaH From owner-cvs-src@FreeBSD.ORG Tue Jul 22 02:02:22 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B4E937B401; Tue, 22 Jul 2003 02:02:22 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE6A843F85; Tue, 22 Jul 2003 02:02:21 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M92L0U061282; Tue, 22 Jul 2003 02:02:21 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M92L6L061281; Tue, 22 Jul 2003 02:02:21 -0700 (PDT) Message-Id: <200307220902.h6M92L6L061281@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 22 Jul 2003 02:02:21 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 09:02:23 -0000 phk 2003/07/22 02:02:21 PDT FreeBSD src repository Modified files: sys/conf kern.post.mk Log: Don't complain about inlines for genassym Revision Changes Path 1.48 +1 -1 src/sys/conf/kern.post.mk From owner-cvs-src@FreeBSD.ORG Tue Jul 22 02:04:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CE5237B401; Tue, 22 Jul 2003 02:04:10 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F03A43FA3; Tue, 22 Jul 2003 02:04:09 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M9490U062243; Tue, 22 Jul 2003 02:04:09 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M949hX062242; Tue, 22 Jul 2003 02:04:09 -0700 (PDT) Message-Id: <200307220904.h6M949hX062242@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 22 Jul 2003 02:04:09 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 09:04:10 -0000 ru 2003/07/22 02:04:09 PDT FreeBSD src repository Modified files: release Makefile Log: /floppies/boot.flp is no longer necessary on bootable i386 CD-ROMs. Forgotten by: jhb Revision Changes Path 1.788 +0 -4 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Tue Jul 22 02:22:01 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 73EF237B401; Tue, 22 Jul 2003 02:22:01 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 121A643F93; Tue, 22 Jul 2003 02:22:01 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M9M00U062964; Tue, 22 Jul 2003 02:22:00 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M9M0YQ062963; Tue, 22 Jul 2003 02:22:00 -0700 (PDT) Message-Id: <200307220922.h6M9M0YQ062963@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 22 Jul 2003 02:22:00 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 09:22:01 -0000 phk 2003/07/22 02:22:00 PDT FreeBSD src repository Modified files: sys/dev/lnc if_lnc.c Log: Don't inline ridiculously very large functions. Compared to the contents of these functions, an extra function call is nano-peanuts. Revision Changes Path 1.96 +4 -4 src/sys/dev/lnc/if_lnc.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 02:27:59 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D47F37B401; Tue, 22 Jul 2003 02:27:59 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B95843F93; Tue, 22 Jul 2003 02:27:59 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M9Rx0U063152; Tue, 22 Jul 2003 02:27:59 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M9RwBh063151; Tue, 22 Jul 2003 02:27:58 -0700 (PDT) Message-Id: <200307220927.h6M9RwBh063151@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 22 Jul 2003 02:27:58 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_object.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 09:28:00 -0000 phk 2003/07/22 02:27:58 PDT FreeBSD src repository Modified files: sys/vm vm_object.c Log: Don't inline very large functions. Gcc has silently not been doing this for a long time. Revision Changes Path 1.301 +1 -1 src/sys/vm/vm_object.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 02:35:46 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C28C937B401; Tue, 22 Jul 2003 02:35:46 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 62A0143F85; Tue, 22 Jul 2003 02:35:46 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6M9Zk0U063555; Tue, 22 Jul 2003 02:35:46 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6M9Zj03063554; Tue, 22 Jul 2003 02:35:45 -0700 (PDT) Message-Id: <200307220935.h6M9Zj03063554@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 22 Jul 2003 02:35:45 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ie if_ie.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 09:35:47 -0000 phk 2003/07/22 02:35:45 PDT FreeBSD src repository Modified files: sys/dev/ie if_ie.c Log: Move inlined function ie_ack() up to before first use. Revision Changes Path 1.95 +8 -8 src/sys/dev/ie/if_ie.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 03:24:42 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA12137B401; Tue, 22 Jul 2003 03:24:42 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8385943F3F; Tue, 22 Jul 2003 03:24:42 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MAOg0U066725; Tue, 22 Jul 2003 03:24:42 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MAOggG066724; Tue, 22 Jul 2003 03:24:42 -0700 (PDT) Message-Id: <200307221024.h6MAOggG066724@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 22 Jul 2003 03:24:42 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 10:24:43 -0000 phk 2003/07/22 03:24:42 PDT FreeBSD src repository Modified files: sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c Log: Don't attempt to inline large functions mb_alloc() and mb_free(), it more than doubles the text size of this file. GCC has wisely ignored us on this previously Revision Changes Path 1.234 +5 -0 src/sys/kern/init_main.c 1.128 +6 -3 src/sys/kern/kern_malloc.c 1.22 +1 -0 src/sys/kern/md5c.c 1.19 +3 -0 src/sys/kern/subr_autoconf.c 1.53 +2 -2 src/sys/kern/subr_mbuf.c 1.106 +20 -0 src/sys/kern/subr_prf.c 1.40 +1 -1 src/sys/kern/tty_subr.c 1.141 +2 -2 src/sys/kern/vfs_cluster.c 1.453 +7 -8 src/sys/kern/vfs_subr.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 03:36:38 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 38F2237B401; Tue, 22 Jul 2003 03:36:38 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5DFF43F3F; Tue, 22 Jul 2003 03:36:37 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MAab0U068374; Tue, 22 Jul 2003 03:36:37 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MAabSj068373; Tue, 22 Jul 2003 03:36:37 -0700 (PDT) Message-Id: <200307221036.h6MAabSj068373@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 22 Jul 2003 03:36:37 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 10:36:38 -0000 phk 2003/07/22 03:36:37 PDT FreeBSD src repository Modified files: sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c Log: Revert stuff which accidentally ended up in the previous commit. Revision Changes Path 1.235 +0 -5 src/sys/kern/init_main.c 1.129 +3 -6 src/sys/kern/kern_malloc.c 1.23 +0 -1 src/sys/kern/md5c.c 1.20 +0 -3 src/sys/kern/subr_autoconf.c 1.107 +0 -20 src/sys/kern/subr_prf.c 1.41 +1 -1 src/sys/kern/tty_subr.c 1.142 +2 -2 src/sys/kern/vfs_cluster.c 1.454 +8 -7 src/sys/kern/vfs_subr.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 03:43:58 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7122137B416; Tue, 22 Jul 2003 03:43:58 -0700 (PDT) Received: from brian.webcom.it (brianlap.inet.it [213.92.1.190]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9096C43FA3; Tue, 22 Jul 2003 03:43:56 -0700 (PDT) (envelope-from andrea@webcom.it) Received: by brian.webcom.it (Postfix, from userid 1000) id C4B192D; Tue, 22 Jul 2003 12:43:54 +0200 (CEST) Date: Tue, 22 Jul 2003 12:43:54 +0200 From: Andrea Campi To: Peter Wemm Message-ID: <20030722104354.GA668@webcom.it> References: <200307212059.h6LKxS9Z064227@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307212059.h6LKxS9Z064227@repoman.freebsd.org> X-Echelon: BND CIA NSA Mossad KGB MI6 IRA detonator nuclear assault strike User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/acpica acpi_wakeup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 10:43:58 -0000 On Mon, Jul 21, 2003 at 01:59:28PM -0700, Peter Wemm wrote: > Modified files: > sys/i386/acpica acpi_wakeup.c > Log: > Commit Ian Dowse's workaround for acpi resume resetting after the > LAZY_SWITCH changes. He pointed out the acpi code sets up an identity > mapping in the current vmspace and that got messed up by the %cr3 being > out of sync with the current page directory. As a workaround, restore > %cr3 across the sleep/resume. A more complete fix would be to undo the > lazy state and clear the pm_active bit from the borrowed pmap, but this > works and people are currently hurting. I'll clean this up. > This is mostly Ian's patch, plus a PAE tweak from me. Thanks! This indeed fixes the issue I told you about. Bye, Andrea -- To boldly go where I surely don't belong. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 03:45:29 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27D9337B401; Tue, 22 Jul 2003 03:45:29 -0700 (PDT) Received: from mx0.freebsd-services.com (survey.codeburst.net [195.149.39.161]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5BAF743FB1; Tue, 22 Jul 2003 03:45:28 -0700 (PDT) (envelope-from paul@freebsd-services.com) Received: by mx0.freebsd-services.com (Postfix, from userid 1002) id 10C2E1B211; Tue, 22 Jul 2003 11:45:25 +0100 (BST) Date: Tue, 22 Jul 2003 11:45:24 +0100 From: Paul Richards To: Poul-Henning Kamp Message-ID: <20030722104524.GA80471@survey.codeburst.net> References: <200307220922.h6M9M0YQ062963@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307220922.h6M9M0YQ062963@repoman.freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 10:45:29 -0000 On Tue, Jul 22, 2003 at 02:22:00AM -0700, Poul-Henning Kamp wrote: > phk 2003/07/22 02:22:00 PDT > > FreeBSD src repository > > Modified files: > sys/dev/lnc if_lnc.c > Log: > Don't inline ridiculously very large functions. > > Compared to the contents of these functions, an extra function call > is nano-peanuts. Both of those functions were called from just one place, inside the interrupt handler. Is there any reason to not inline them? -- Tis a wise thing to know what is wanted, wiser still to know when it has been achieved and wisest of all to know when it is unachievable for then striving is folly. [Magician] From owner-cvs-src@FreeBSD.ORG Tue Jul 22 03:47:21 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E5F6D37B401; Tue, 22 Jul 2003 03:47:20 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF44E43F3F; Tue, 22 Jul 2003 03:47:19 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MAlGV3004229; Tue, 22 Jul 2003 10:47:16 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MAlF5H010037; Tue, 22 Jul 2003 12:47:16 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Paul Richards From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 11:45:24 BST." <20030722104524.GA80471@survey.codeburst.net> Date: Tue, 22 Jul 2003 12:47:15 +0200 Message-ID: <10036.1058870835@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 10:47:21 -0000 In message <20030722104524.GA80471@survey.codeburst.net>, Paul Richards writes: >On Tue, Jul 22, 2003 at 02:22:00AM -0700, Poul-Henning Kamp wrote: >> phk 2003/07/22 02:22:00 PDT >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/lnc if_lnc.c >> Log: >> Don't inline ridiculously very large functions. >> >> Compared to the contents of these functions, an extra function call >> is nano-peanuts. > >Both of those functions were called from just one place, inside the >interrupt handler. Is there any reason to not inline them? Yes, we need to get -Werror on the kernel again, and GCC whines about ridiculously large functions. Inline should not be used unless it has a measurable impact on performance. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 04:00:54 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 833B037B401; Tue, 22 Jul 2003 04:00:54 -0700 (PDT) Received: from shrike.submonkey.net (pc1-cdif2-5-cust38.cdif.cable.ntl.com [81.101.150.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8DC3443F85; Tue, 22 Jul 2003 04:00:53 -0700 (PDT) (envelope-from setantae@submonkey.net) Received: from setantae by shrike.submonkey.net with local (Exim 4.20) id 19eut2-000AAF-87; Tue, 22 Jul 2003 12:00:52 +0100 Date: Tue, 22 Jul 2003 12:00:52 +0100 From: Ceri Davies To: Peter Wemm Message-ID: <20030722110052.GH46900@submonkey.net> Mail-Followup-To: Ceri Davies , Peter Wemm , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200307220811.h6M8BHIh059016@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="A9z/3b/E4MkkD+7G" Content-Disposition: inline In-Reply-To: <200307220811.h6M8BHIh059016@repoman.freebsd.org> User-Agent: Mutt/1.5.4i Sender: Ceri Davies cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files.i386 files.pc98 options.i386 options.pc98 src/sys/gnu/i386/fpemul Changelog README control_w.h div_small.s errors.c exception.h fpu_arith.c fpu_asm.h fpu_aux.c fpu_emu.h fpu_entry.c fpu_etc.c fpu_proto.h fpu_system.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 11:00:55 -0000 --A9z/3b/E4MkkD+7G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 22, 2003 at 01:11:17AM -0700, Peter Wemm wrote: > Initiate de-orbit burn for fpu-less operation. 386+387 is still > theoretically supportable, but you'd really be happier with FreeBSD 2.1= =2E8 > on it. Good call. This has to be worth an entry in UPDATING though. Ceri --=20 --A9z/3b/E4MkkD+7G Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQE/HRlkocfcwTS3JF8RAiv/AJ93EMsuPMVDINzUamxspmefsxmKKACfboBP 15Mf4o0CVP15EBkapPPgjRc= =Pe1y -----END PGP SIGNATURE----- --A9z/3b/E4MkkD+7G-- From owner-cvs-src@FreeBSD.ORG Tue Jul 22 04:08:42 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C8A5C37B401; Tue, 22 Jul 2003 04:08:42 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6908443FB1; Tue, 22 Jul 2003 04:08:42 -0700 (PDT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MB8g0U070725; Tue, 22 Jul 2003 04:08:42 -0700 (PDT) (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MB8g2n070724; Tue, 22 Jul 2003 04:08:42 -0700 (PDT) Message-Id: <200307221108.h6MB8g2n070724@repoman.freebsd.org> From: Warner Losh Date: Tue, 22 Jul 2003 04:08:42 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src UPDATING X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 11:08:43 -0000 imp 2003/07/22 04:08:42 PDT FreeBSD src repository Modified files: . UPDATING Log: note rescue issues and fpu emulation removal Revision Changes Path 1.259 +12 -0 src/UPDATING From owner-cvs-src@FreeBSD.ORG Tue Jul 22 04:25:23 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5998E37B401; Tue, 22 Jul 2003 04:25:23 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E95C143F85; Tue, 22 Jul 2003 04:25:22 -0700 (PDT) (envelope-from paul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MBPM0U071382; Tue, 22 Jul 2003 04:25:22 -0700 (PDT) (envelope-from paul@repoman.freebsd.org) Received: (from paul@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MBPMp0071381; Tue, 22 Jul 2003 04:25:22 -0700 (PDT) Message-Id: <200307221125.h6MBPMp0071381@repoman.freebsd.org> From: Paul Richards Date: Tue, 22 Jul 2003 04:25:22 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/usr.sbin/pkg_install/update pkg_update.pl X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 11:25:23 -0000 paul 2003/07/22 04:25:22 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) usr.sbin/pkg_install/update pkg_update.pl Log: Fix the version matching regex to take account of local port versioning. PR: bin/45484 Revision Changes Path 1.4.2.2 +2 -2 src/usr.sbin/pkg_install/update/pkg_update.pl From owner-cvs-src@FreeBSD.ORG Tue Jul 22 04:28:39 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2264337B401; Tue, 22 Jul 2003 04:28:39 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B35B243FA3; Tue, 22 Jul 2003 04:28:38 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MBSc0U071534; Tue, 22 Jul 2003 04:28:38 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MBScDi071533; Tue, 22 Jul 2003 04:28:38 -0700 (PDT) Message-Id: <200307221128.h6MBScDi071533@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 22 Jul 2003 04:28:38 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/netatm atm_if.c atm_if.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 11:28:39 -0000 harti 2003/07/22 04:28:38 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/netatm atm_if.c atm_if.h Log: Define constants for the upcoming ProATM (IDT77252) driver. Make sure that these constants are the same as in current. Handle the new MEDIA definitions in the code. Revision Changes Path 1.5.2.1 +6 -0 src/sys/netatm/atm_if.c 1.2.2.1 +21 -5 src/sys/netatm/atm_if.h From owner-cvs-src@FreeBSD.ORG Tue Jul 22 04:37:51 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F26D037B401; Tue, 22 Jul 2003 04:37:50 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0DEFE43F3F; Tue, 22 Jul 2003 04:37:49 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id VAA18958; Tue, 22 Jul 2003 21:37:46 +1000 Date: Tue, 22 Jul 2003 21:37:44 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Mark Murray In-Reply-To: <200307212055.h6LKtc3l064104@repoman.freebsd.org> Message-ID: <20030722212644.D7733@gamplex.bde.org> References: <200307212055.h6LKtc3l064104@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/getconf getconf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 11:37:51 -0000 On Mon, 21 Jul 2003, Mark Murray wrote: > markm 2003/07/21 13:55:38 PDT > > FreeBSD src repository > > Modified files: > usr.bin/getconf getconf.c > Log: > Replace an alloca() call with a slightly more standard malloc()/free() > pair. Isn't malloc()/free() more than slightly standard? Variable-length arrays are more than slightly standard too (they became standard before getconf) and are well suited to replacing alloca() here. Bruce From owner-cvs-src@FreeBSD.ORG Tue Jul 22 04:41:16 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE73537B401; Tue, 22 Jul 2003 04:41:16 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7AE8343FA3; Tue, 22 Jul 2003 04:41:16 -0700 (PDT) (envelope-from ticso@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MBfG0U072118; Tue, 22 Jul 2003 04:41:16 -0700 (PDT) (envelope-from ticso@repoman.freebsd.org) Received: (from ticso@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MBfGvA072117; Tue, 22 Jul 2003 04:41:16 -0700 (PDT) Message-Id: <200307221141.h6MBfGvA072117@repoman.freebsd.org> From: Bernd Walter Date: Tue, 22 Jul 2003 04:41:16 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf files files.alpha files.i386 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 11:41:17 -0000 ticso 2003/07/22 04:41:16 PDT FreeBSD src repository Modified files: sys/conf files files.alpha files.i386 Log: relocate eisa into MI files. Suggested by: jhb Revision Changes Path 1.811 +1 -0 src/sys/conf/files 1.103 +0 -1 src/sys/conf/files.alpha 1.448 +0 -1 src/sys/conf/files.i386 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 04:42:46 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A140B37B405; Tue, 22 Jul 2003 04:42:46 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3ECD343F75; Tue, 22 Jul 2003 04:42:46 -0700 (PDT) (envelope-from ticso@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MBgk0U072236; Tue, 22 Jul 2003 04:42:46 -0700 (PDT) (envelope-from ticso@repoman.freebsd.org) Received: (from ticso@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MBgj5J072235; Tue, 22 Jul 2003 04:42:45 -0700 (PDT) Message-Id: <200307221142.h6MBgj5J072235@repoman.freebsd.org> From: Bernd Walter Date: Tue, 22 Jul 2003 04:42:45 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf options options.i386 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 11:42:47 -0000 ticso 2003/07/22 04:42:45 PDT FreeBSD src repository Modified files: sys/conf options options.i386 Log: EISA_SLOTS is mandantory to get opt_eisa.h Put it into MI files. Revision Changes Path 1.404 +2 -0 src/sys/conf/options 1.196 +0 -2 src/sys/conf/options.i386 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 04:53:21 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F1B8737B401; Tue, 22 Jul 2003 04:53:20 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A079243F85; Tue, 22 Jul 2003 04:53:20 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MBrK0U078058; Tue, 22 Jul 2003 04:53:20 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MBrKTU078057; Tue, 22 Jul 2003 04:53:20 -0700 (PDT) Message-Id: <200307221153.h6MBrKTU078057@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 22 Jul 2003 04:53:20 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/proatm README proatm.c proatm.h proatm_rtbl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 11:53:21 -0000 harti 2003/07/22 04:53:20 PDT FreeBSD src repository Added files: (Branch: RELENG_4) sys/dev/proatm README proatm.c proatm.h proatm_rtbl.c Log: This is a driver for ProSum's ProATM cards. These cards use the IDT77252 and the driver supports UBR, CBR and VBR. The driver will not be brought over the current, because current has the patm driver (which uses new ATM infrastructure and hence is hard to MFC). This driver is reported to be very stable. PR: kern/46790 Revision Changes Path 1.1.2.1 +219 -0 src/sys/dev/proatm/README (new) 1.1.2.1 +4535 -0 src/sys/dev/proatm/proatm.c (new) 1.1.2.1 +970 -0 src/sys/dev/proatm/proatm.h (new) 1.1.2.1 +2863 -0 src/sys/dev/proatm/proatm_rtbl.c (new) From owner-cvs-src@FreeBSD.ORG Tue Jul 22 04:58:00 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0599237B401; Tue, 22 Jul 2003 04:58:00 -0700 (PDT) Received: from tara.freenix.org (keltia.freenix.org [62.4.20.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id E12F143F3F; Tue, 22 Jul 2003 04:57:58 -0700 (PDT) (envelope-from roberto@tara.freenix.org) Received: by tara.freenix.org (Postfix/TLS, from userid 101) id AADEF2AA5; Tue, 22 Jul 2003 13:57:57 +0200 (CEST) Date: Tue, 22 Jul 2003 13:57:57 +0200 From: Ollivier Robert To: cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20030722115757.GB85976@tara.freenix.org> Mail-Followup-To: cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200307220811.h6M8BHIh059016@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307220811.h6M8BHIh059016@repoman.freebsd.org> X-Operating-System: MacOS X / PowerBook G4 - FreeBSD 5.0 / 2x PIII/800 SMP User-Agent: Mutt/1.5.3i Subject: Re: cvs commit: src/sys/conf files.i386 files.pc98 options.i386 options.pc98 src/sys/gnu/i386/fpemul Changelog README control_w.h div_small.s errors.c exception.h fpu_arith.c fpu_asm.h fpu_aux.c fpu_emu.h fpu_entry.c fpu_etc.c fpu_proto.h fpu_system.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 11:58:00 -0000 According to Peter Wemm: > Log: > Initiate de-orbit burn for fpu-less operation. 386+387 is still > theoretically supportable, but you'd really be happier with FreeBSD 2.1.8 > on it. Excellent, thanks. -- Ollivier ROBERT -=- FreeBSD: The Power to Serve! -=- roberto@keltia.freenix.fr Darwin snuadh.freenix.org Kernel Version 6.6: Thu May 1 21:48:54 PDT 2003 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 05:03:57 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9524737B401; Tue, 22 Jul 2003 05:03:57 -0700 (PDT) Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.157.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8FDE743F3F; Tue, 22 Jul 2003 05:03:56 -0700 (PDT) (envelope-from mark@grondar.org) Received: from storm.FreeBSD.org.uk (Ugrondar@localhost [127.0.0.1]) by storm.FreeBSD.org.uk (8.12.9/8.12.9) with ESMTP id h6MC3sHo084066; Tue, 22 Jul 2003 13:03:54 +0100 (BST) (envelope-from mark@grondar.org) Received: (from Ugrondar@localhost)h6MC3sff084065; Tue, 22 Jul 2003 13:03:54 +0100 (BST) X-Authentication-Warning: storm.FreeBSD.org.uk: Ugrondar set sender to mark@grondar.org using -f Received: from grondar.org (localhost [127.0.0.1])h6MC1SZ2060408; Tue, 22 Jul 2003 13:01:28 +0100 (BST) (envelope-from mark@grondar.org) From: Mark Murray Message-Id: <200307221201.h6MC1SZ2060408@grimreaper.grondar.org> To: Bruce Evans In-Reply-To: Your message of "Tue, 22 Jul 2003 21:37:44 +1000." <20030722212644.D7733@gamplex.bde.org> Date: Tue, 22 Jul 2003 13:01:28 +0100 Sender: mark@grondar.org X-Spam-Status: No, hits=0.2 required=5.0 tests=EMAIL_ATTRIBUTION,FROM_NO_LOWER,IN_REP_TO, QUOTED_EMAIL_TEXT,REPLY_WITH_QUOTES version=2.55 X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/getconf getconf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 12:03:58 -0000 Bruce Evans writes: > > Replace an alloca() call with a slightly more standard malloc()/free() > > pair. > > Isn't malloc()/free() more than slightly standard? "Understatement". > Variable-length arrays are more than slightly standard too (they became > standard before getconf) and are well suited to replacing alloca() here. There are very many non-alloca() ways to do this. I chose this way. M -- Mark Murray iumop ap!sdn w,I idlaH From owner-cvs-src@FreeBSD.ORG Tue Jul 22 05:46:31 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C1F0A37B401; Tue, 22 Jul 2003 05:46:31 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5AEF143F3F; Tue, 22 Jul 2003 05:46:31 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MCkV0U081119; Tue, 22 Jul 2003 05:46:31 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MCkVMg081118; Tue, 22 Jul 2003 05:46:31 -0700 (PDT) Message-Id: <200307221246.h6MCkVMg081118@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 22 Jul 2003 05:46:31 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_cm.c atm_socket.c atm_subr.c src/sys/netatm/ipatm ipatm_load.c src/sys/netatm/sigpvc sigpvc_if.c src/sys/netatm/spans spans_arp.c spans_cls.c... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 12:46:32 -0000 harti 2003/07/22 05:46:31 PDT FreeBSD src repository Modified files: sys/netatm atm_cm.c atm_socket.c atm_subr.c sys/netatm/ipatm ipatm_load.c sys/netatm/sigpvc sigpvc_if.c sys/netatm/spans spans_arp.c spans_cls.c spans_if.c sys/netatm/uni sscf_uni.c sscop.c uniarp.c uniip.c unisig_if.c Log: Remove the zone limits for all the zones used in the ATM code. These were a left over from when the private memory pools were converted to use uma zones. The limit of UMA zones, however, works differently. When a zone is limited to only one or two pages than, on multi-cpu systems, processes can get stuck on the zonelimit, because all remaining free items are in caches of other CPUs. Also add rudimentary error handling in some places (panic) when a zone cannot be created. Revision Changes Path 1.27 +4 -2 src/sys/netatm/atm_cm.c 1.17 +0 -1 src/sys/netatm/atm_socket.c 1.37 +0 -2 src/sys/netatm/atm_subr.c 1.17 +0 -2 src/sys/netatm/ipatm/ipatm_load.c 1.16 +2 -1 src/sys/netatm/sigpvc/sigpvc_if.c 1.17 +2 -1 src/sys/netatm/spans/spans_arp.c 1.17 +2 -1 src/sys/netatm/spans/spans_cls.c 1.14 +4 -2 src/sys/netatm/spans/spans_if.c 1.18 +0 -2 src/sys/netatm/uni/sscf_uni.c 1.17 +0 -1 src/sys/netatm/uni/sscop.c 1.17 +0 -1 src/sys/netatm/uni/uniarp.c 1.15 +0 -1 src/sys/netatm/uni/uniip.c 1.15 +0 -4 src/sys/netatm/uni/unisig_if.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 05:52:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D401937B401; Tue, 22 Jul 2003 05:52:45 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E43543FD7; Tue, 22 Jul 2003 05:52:38 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6MCqX0U043871 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Jul 2003 15:52:33 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6MCqSWL043864; Tue, 22 Jul 2003 15:52:28 +0300 (EEST) (envelope-from ru) Date: Tue, 22 Jul 2003 15:52:28 +0300 From: Ruslan Ermilov To: Gregory Neil Shapiro Message-ID: <20030722125228.GC36151@sunbay.com> References: <200307100453.h6A4rXeH084564@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pY3vCvL1qV+PayAL" Content-Disposition: inline In-Reply-To: <200307100453.h6A4rXeH084564@repoman.freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/sendmail Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 12:52:46 -0000 --pY3vCvL1qV+PayAL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 09, 2003 at 09:53:32PM -0700, Gregory Neil Shapiro wrote: > gshapiro 2003/07/09 21:53:32 PDT >=20 > FreeBSD src repository >=20 > Modified files: > etc/sendmail Makefile=20 > Log: > Continue trying to build SENDMAIL_CF if the user uses SENDMAIL_CF > instead of SENDMAIL_MC but don't remove on it 'make clean' as the > user may not have the original .mc file and removing it could be > dangerous (e.g., make SENDMAIL_CF=3D/etc/mail/sendmail.cf clean). > =20 > Noticed by: peter > MFC after: 3 days > =20 > Revision Changes Path > 1.26 +5 -2 src/etc/sendmail/Makefile >=20 Gregory, I have trouble understanding what this commit fixes. I have read the preceding discussion where you explained to Peter that SENDMAIL_CF should have a /full/path/to/sendmail.cf, but even after that it's still unclear: just reverting to rev. 1.24 of etc/sendmail/Makefile gives the below, which looks very consistent to me: : Script started on Tue Jul 22 15:46:47 2003 : # ident Makefile : Makefile: : $FreeBSD: src/etc/sendmail/Makefile,v 1.24 2003/07/06 18:54:18 gshap= iro Exp $ : # ls -l /etc/mail/sendmail.cf : -r--r--r-- 1 root wheel 57028 Jul 22 15:02 /etc/mail/sendmail.cf : # make -n clean SENDMAIL_CF=3D/etc/mail/sendmail.cf : rm -f freebsd.cf =20 No attempts to remove /etc/mail/sendmail.cf. : # make -n install SENDMAIL_CF=3D/etc/mail/sendmail.cf No attempts to install the file over itself. : # make -n install SENDMAIL_CF=3D/foo/bar/sendmail.cf : install -o root -g wheel -m 644 /foo/bar/sendmail.cf /etc/mail/sendmail.= cf : # make -n clean SENDMAIL_CF=3D/foo/bar/sendmail.cf : rm -f freebsd.cf =20 No attempts to remove /foo/bar/sendmail.cf, either. : Script done on Tue Jul 22 15:47:47 2003 We weren't removing the ${SENDMAIL_CF} file because we weren't adding it to the list of files to build (${ALL}) which we then remove (CLEANFILES=3D${ALL}). Can you please clarify this? Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --pY3vCvL1qV+PayAL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/HTOMUkv4P6juNwoRAhutAJ40MpeaAGTSOKV7qKoqQlhGPAL4hwCcDwCZ sl9ca6lnbmCeSXkXg+dYm6g= =OKcK -----END PGP SIGNATURE----- --pY3vCvL1qV+PayAL-- From owner-cvs-src@FreeBSD.ORG Tue Jul 22 06:11:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA69237B401; Tue, 22 Jul 2003 06:11:27 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F45343F85; Tue, 22 Jul 2003 06:11:27 -0700 (PDT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MDBR0U083233; Tue, 22 Jul 2003 06:11:27 -0700 (PDT) (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MDBQfv083232; Tue, 22 Jul 2003 06:11:26 -0700 (PDT) Message-Id: <200307221311.h6MDBQfv083232@repoman.freebsd.org> From: Diomidis Spinellis Date: Tue, 22 Jul 2003 06:11:26 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/bin/sh alias.c cd.c exec.c exec.h expand.c input.c jobs.c memalloc.c nodes.c.pat output.c parser.c redir.c var.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 13:11:28 -0000 dds 2003/07/22 06:11:26 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) bin/sh alias.c cd.c exec.c exec.h expand.c input.c jobs.c memalloc.c nodes.c.pat output.c parser.c redir.c var.c Log: MFC: Changes following CScout analysis: - Removed dead declarations - Made objects that should have been declared as static, static. The changes use STATIC instead of static, following the existing convention in the rest of the code. alias.c: 1.17 cd.c: 1.33 exec.c: 1.23 exec.h: 1.11 expand.c: 1.44 input.c: 1.20 jobs.c: 1.64 memalloc.c: 1.25 nodes.c.pat: 1.14 output.c: 1.18 parser.c: 1.49 redir.c: 1.24 var.c: 1.25 Revision Changes Path 1.12.2.3 +1 -1 src/bin/sh/alias.c 1.20.2.4 +2 -2 src/bin/sh/cd.c 1.14.2.5 +1 -1 src/bin/sh/exec.c 1.9.2.2 +0 -1 src/bin/sh/exec.h 1.31.2.6 +6 -6 src/bin/sh/expand.c 1.14.2.3 +1 -1 src/bin/sh/input.c 1.27.2.11 +4 -4 src/bin/sh/jobs.c 1.15.2.3 +3 -3 src/bin/sh/memalloc.c 1.7.2.2 +4 -4 src/bin/sh/nodes.c.pat 1.10.2.3 +1 -1 src/bin/sh/output.c 1.29.2.10 +11 -11 src/bin/sh/parser.c 1.12.2.5 +1 -1 src/bin/sh/redir.c 1.15.2.3 +4 -4 src/bin/sh/var.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 06:30:38 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0410037B401; Tue, 22 Jul 2003 06:30:38 -0700 (PDT) Received: from godel.mtl.distributel.net (nat.MTL.distributel.NET [66.38.181.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3ED7E43F75; Tue, 22 Jul 2003 06:30:37 -0700 (PDT) (envelope-from bmilekic@technokratis.com) Received: from godel.mtl.distributel.net (localhost [127.0.0.1]) h6M9YhEH058369; Tue, 22 Jul 2003 09:34:43 GMT (envelope-from bmilekic@technokratis.com) Received: (from bmilekic@localhost) by godel.mtl.distributel.net (8.12.9/8.12.9/Submit) id h6M9YhBe058368; Tue, 22 Jul 2003 09:34:43 GMT X-Authentication-Warning: godel.mtl.distributel.net: bmilekic set sender to bmilekic@technokratis.com using -f Date: Tue, 22 Jul 2003 09:34:43 +0000 From: Bosko Milekic To: Poul-Henning Kamp Message-ID: <20030722093443.GD58118@technokratis.com> References: <200307221024.h6MAOggG066724@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307221024.h6MAOggG066724@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 13:30:38 -0000 On Tue, Jul 22, 2003 at 03:24:42AM -0700, Poul-Henning Kamp wrote: > phk 2003/07/22 03:24:42 PDT > > FreeBSD src repository > > Modified files: > sys/kern init_main.c kern_malloc.c md5c.c > subr_autoconf.c subr_mbuf.c subr_prf.c > tty_subr.c vfs_cluster.c vfs_subr.c > Log: > Don't attempt to inline large functions mb_alloc() and mb_free(), > it more than doubles the text size of this file. > > GCC has wisely ignored us on this previously Oh, I had no idea it was previously ignoring the inline... I guess GCC's warnings just got fixed recently. -- Bosko Milekic * bmilekic@technokratis.com * bmilekic@FreeBSD.org TECHNOkRATIS Consulting Services * http://www.technokratis.com/ From owner-cvs-src@FreeBSD.ORG Tue Jul 22 06:32:47 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7CD3B37B404; Tue, 22 Jul 2003 06:32:47 -0700 (PDT) Received: from godel.mtl.distributel.net (nat.MTL.distributel.NET [66.38.181.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id 751AD43F75; Tue, 22 Jul 2003 06:32:46 -0700 (PDT) (envelope-from bmilekic@technokratis.com) Received: from godel.mtl.distributel.net (localhost [127.0.0.1]) h6M9aqEH058401; Tue, 22 Jul 2003 09:36:52 GMT (envelope-from bmilekic@technokratis.com) Received: (from bmilekic@localhost) by godel.mtl.distributel.net (8.12.9/8.12.9/Submit) id h6M9aq5q058400; Tue, 22 Jul 2003 09:36:52 GMT X-Authentication-Warning: godel.mtl.distributel.net: bmilekic set sender to bmilekic@technokratis.com using -f Date: Tue, 22 Jul 2003 09:36:52 +0000 From: Bosko Milekic To: Hartmut Brandt Message-ID: <20030722093652.GE58118@technokratis.com> References: <200307221246.h6MCkVMg081118@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307221246.h6MCkVMg081118@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netatm atm_cm.c atm_socket.c atm_subr.c src/sys/netatm/ipatm ipatm_load.c src/sys/netatm/sigpvc sigpvc_if.c src/sys/netatm/spans spans_arp.c spans_cls.c spans_if.c src/sys/netatm/uni sscf_uni.c sscop.c uniarp.c uniip.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 13:32:48 -0000 On Tue, Jul 22, 2003 at 05:46:31AM -0700, Hartmut Brandt wrote: > harti 2003/07/22 05:46:31 PDT [...] > Also add rudimentary error handling in some places (panic) when a zone > cannot be created. This is probably a good move but, FWIW, these are never supposed to fail as the UMA zone creation code calls an allocation with M_WAITOK, regardless of who or where the caller is. -- Bosko Milekic * bmilekic@technokratis.com * bmilekic@FreeBSD.org TECHNOkRATIS Consulting Services * http://www.technokratis.com/ From owner-cvs-src@FreeBSD.ORG Tue Jul 22 06:40:09 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 83F8A37B401; Tue, 22 Jul 2003 06:40:09 -0700 (PDT) Received: from mailhub.fokus.fraunhofer.de (mailhub.fokus.fraunhofer.de [193.174.154.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C26643F3F; Tue, 22 Jul 2003 06:40:07 -0700 (PDT) (envelope-from brandt@fokus.fraunhofer.de) Received: from beagle (beagle [193.175.132.100])h6MDe3v09611; Tue, 22 Jul 2003 15:40:03 +0200 (MEST) Date: Tue, 22 Jul 2003 15:40:03 +0200 (CEST) From: Harti Brandt To: Bosko Milekic In-Reply-To: <20030722093652.GE58118@technokratis.com> Message-ID: <20030722153538.E83041@beagle.fokus.fraunhofer.de> References: <200307221246.h6MCkVMg081118@repoman.freebsd.org> <20030722093652.GE58118@technokratis.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netatm atm_cm.c atm_socket.c atm_subr.c src/sys/netatm/ipatm ipatm_load.c src/sys/netatm/sigpvc sigpvc_if.c src/sys/netatm/spans spans_arp.c spans_cls.c spans_if.c src/sys/neta X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Hartmut Brandt List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 13:40:09 -0000 On Tue, 22 Jul 2003, Bosko Milekic wrote: BM> BM>On Tue, Jul 22, 2003 at 05:46:31AM -0700, Hartmut Brandt wrote: BM>> harti 2003/07/22 05:46:31 PDT BM>[...] BM>> Also add rudimentary error handling in some places (panic) when a zone BM>> cannot be created. BM> BM> This is probably a good move but, FWIW, these are never supposed to BM> fail as the UMA zone creation code calls an allocation with M_WAITOK, BM> regardless of who or where the caller is. You are right. Now the handling is at least consistent and things may change... Looking at the (undocumented) flags parameter of uma_zcreate() I would think you could specify M_NOWAIT, but alas these flags serve entirely different purpose (see uma.h). I'll think, I'll keep the panics. harti -- harti brandt, http://www.fokus.fraunhofer.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.fraunhofer.de, harti@freebsd.org From owner-cvs-src@FreeBSD.ORG Tue Jul 22 06:41:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9AA6C37B401; Tue, 22 Jul 2003 06:41:18 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 359F943FA3; Tue, 22 Jul 2003 06:41:18 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MDfI0U084785; Tue, 22 Jul 2003 06:41:18 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MDfHN0084784; Tue, 22 Jul 2003 06:41:17 -0700 (PDT) Message-Id: <200307221341.h6MDfHN0084784@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 22 Jul 2003 06:41:17 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/conf files src/sys/i386/conf LINT X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 13:41:19 -0000 harti 2003/07/22 06:41:17 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/conf files sys/i386/conf LINT Log: Connect the ProATM driver to the build. PR: kern/46790 Revision Changes Path 1.340.2.138 +1 -0 src/sys/conf/files 1.749.2.147 +4 -0 src/sys/i386/conf/LINT From owner-cvs-src@FreeBSD.ORG Tue Jul 22 06:46:24 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA49F37B401; Tue, 22 Jul 2003 06:46:24 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 887B543F85; Tue, 22 Jul 2003 06:46:24 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MDkO0U085042; Tue, 22 Jul 2003 06:46:24 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MDkOvN085041; Tue, 22 Jul 2003 06:46:24 -0700 (PDT) Message-Id: <200307221346.h6MDkOvN085041@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 22 Jul 2003 06:46:24 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/etc rc.atm X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 13:46:25 -0000 harti 2003/07/22 06:46:24 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) etc rc.atm Log: Recognize the ProATM cards. PR: kern/46790 Revision Changes Path 1.6.2.4 +4 -1 src/etc/rc.atm From owner-cvs-src@FreeBSD.ORG Tue Jul 22 06:54:32 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5829837B404; Tue, 22 Jul 2003 06:54:32 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BAE4043F93; Tue, 22 Jul 2003 06:54:31 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MDsV0U085523; Tue, 22 Jul 2003 06:54:31 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MDsVEd085522; Tue, 22 Jul 2003 06:54:31 -0700 (PDT) Message-Id: <200307221354.h6MDsVEd085522@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 22 Jul 2003 06:54:31 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libfetch Makefile src/usr.bin/fetch Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 13:54:33 -0000 ru 2003/07/22 06:54:31 PDT FreeBSD src repository Modified files: lib/libfetch Makefile usr.bin/fetch Makefile Log: Make sure the crypto versions of libfetch and fetch(1) appear in the "crypto" distribution. Approved by: des Revision Changes Path 1.42 +1 -0 src/lib/libfetch/Makefile 1.15 +1 -0 src/usr.bin/fetch/Makefile From owner-cvs-src@FreeBSD.ORG Tue Jul 22 07:18:03 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 114CD37B401; Tue, 22 Jul 2003 07:18:03 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 445BB43F3F; Tue, 22 Jul 2003 07:18:01 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id AAA00911; Wed, 23 Jul 2003 00:17:26 +1000 Date: Wed, 23 Jul 2003 00:17:24 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Poul-Henning Kamp In-Reply-To: <10036.1058870835@critter.freebsd.dk> Message-ID: <20030722235600.X8165@gamplex.bde.org> References: <10036.1058870835@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Paul Richards cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 14:18:03 -0000 On Tue, 22 Jul 2003, Poul-Henning Kamp wrote: > In message <20030722104524.GA80471@survey.codeburst.net>, Paul Richards writes: > >On Tue, Jul 22, 2003 at 02:22:00AM -0700, Poul-Henning Kamp wrote: > >> phk 2003/07/22 02:22:00 PDT > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/dev/lnc if_lnc.c > >> Log: > >> Don't inline ridiculously very large functions. > >> > >> Compared to the contents of these functions, an extra function call > >> is nano-peanuts. > > > >Both of those functions were called from just one place, inside the > >interrupt handler. Is there any reason to not inline them? > > Yes, we need to get -Werror on the kernel again, and GCC whines about > ridiculously large functions. I think you mean "gcc emits the requested diagnostic about functions that it doesn't inline, whether they are large or small". Just turn off -Winline to not request this diagnostic. > Inline should not be used unless it has a measurable impact on > performance. Several places, including if_lnc.c, used __inline to get cleaner code at no cost in performance. Removing __inline adds a tiny cost. I build RELENG_3, RELENG_4, -current, and my version of old version of -current all with the -current gcc. I only turned off -Winline for my version of -current since -Werror isn't on in the others. The number of inlining failures for a kernel with similar features but unsimilar bloat is: RELENG_3: 19 (15 for writertc in clock.c) RELENG_4: 39 (18 for writertc in clock.c) -current: 3167 (the leaf inlines haven't changed that much, but the bloat around them has) -my-not-very-current: ? (see no evil) Bruce From owner-cvs-src@FreeBSD.ORG Tue Jul 22 07:28:16 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E07A37B401; Tue, 22 Jul 2003 07:28:16 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D14643F93; Tue, 22 Jul 2003 07:28:15 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MESCV3009074; Tue, 22 Jul 2003 14:28:12 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MESB5H011952; Tue, 22 Jul 2003 16:28:11 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Bruce Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 23 Jul 2003 00:17:24 +1000." <20030722235600.X8165@gamplex.bde.org> Date: Tue, 22 Jul 2003 16:28:11 +0200 Message-ID: <11951.1058884091@critter.freebsd.dk> cc: Paul Richards cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 14:28:16 -0000 In message <20030722235600.X8165@gamplex.bde.org>, Bruce Evans writes: >Several places, including if_lnc.c, used __inline to get cleaner code >at no cost in performance. Removing __inline adds a tiny cost. You know, I would have agreed with you on that, if we were talking about a CPU with no caches, no branch-prediction and no prefetching. For modern CPUs however it would be hard to prove the above statement true or false with any sort of measurement setup we have access to, and it would be even harder if not downright impossible to prove that the result was generally applicable to a majority of the current hardware on the market. In this particular case I think, any effect, positive or negative, will depend on the ratio of transmitted and received packets (because RX-only or TX-only irq's might be able to prefetch over the call but not the inline version) I would _really_ love to nail up a policy note which says that "inline" should only be used if it is possible to show an effect, either because inlining reduces the code size (in this particular case less bytes to execute is generally an indication of better performance) or by showing actual performance improvements from the inlining. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 07:45:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13DD337B405 for ; Tue, 22 Jul 2003 07:45:02 -0700 (PDT) Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id 76DE343FB1 for ; Tue, 22 Jul 2003 07:44:57 -0700 (PDT) (envelope-from john@baldwin.cx) Received: (qmail 27894 invoked from network); 22 Jul 2003 14:44:56 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 22 Jul 2003 14:44:56 -0000 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6MEitGI042522; Tue, 22 Jul 2003 10:44:55 -0400 (EDT) (envelope-from john@baldwin.cx) Received: from zion.baldwin.cx (localhost [127.0.0.1]) by zion.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6MEitPg095890; Tue, 22 Jul 2003 10:44:55 -0400 (EDT) (envelope-from john@zion.baldwin.cx) Received: from localhost (localhost [[UNIX: localhost]]) by zion.baldwin.cx (8.12.9/8.12.9/Submit) id h6MEitWV095889; Tue, 22 Jul 2003 10:44:55 -0400 (EDT) From: John Baldwin To: "David E. O'Brien" Date: Tue, 22 Jul 2003 10:39:57 -0400 User-Agent: KMail/1.5 References: <200307192040.h6JKebpc053687@repoman.freebsd.org> In-Reply-To: <200307192040.h6JKebpc053687@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200307221035.49251.jhb@FreeBSD.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/rescue/rescue Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 14:45:02 -0000 On Saturday 19 July 2003 04:40 pm, David E. O'Brien wrote: > obrien 2003/07/19 13:40:37 PDT > > FreeBSD src repository > > Modified files: > rescue/rescue Makefile > Log: > Trim /rescue. > > Discussed on: freebsd-arch@ No consensus though. Several people objected to the removal of several of these programs. What is the size difference in rescue after these changes? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Tue Jul 22 07:45:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5991137B408 for ; Tue, 22 Jul 2003 07:45:02 -0700 (PDT) Received: from mail.speakeasy.net (mail13.speakeasy.net [216.254.0.213]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2623743FCB for ; Tue, 22 Jul 2003 07:44:58 -0700 (PDT) (envelope-from john@baldwin.cx) Received: (qmail 23410 invoked from network); 22 Jul 2003 14:44:56 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 22 Jul 2003 14:44:56 -0000 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6MEisGI042519; Tue, 22 Jul 2003 10:44:54 -0400 (EDT) (envelope-from john@baldwin.cx) Received: from zion.baldwin.cx (localhost [127.0.0.1]) by zion.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6MEisPg095877; Tue, 22 Jul 2003 10:44:54 -0400 (EDT) (envelope-from john@zion.baldwin.cx) Received: by zion.baldwin.cx (8.12.9/8.12.9/Submit) id h6MEisx8095876; Tue, 22 Jul 2003 10:44:54 -0400 (EDT) From: John Baldwin To: Ruslan Ermilov Date: Tue, 22 Jul 2003 10:39:12 -0400 User-Agent: KMail/1.5 References: <200307220904.h6M949hX062242@repoman.freebsd.org> In-Reply-To: <200307220904.h6M949hX062242@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200307221039.12782.jhb@FreeBSD.org> cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 14:45:02 -0000 On Tuesday 22 July 2003 05:04 am, Ruslan Ermilov wrote: > ru 2003/07/22 02:04:09 PDT > > FreeBSD src repository > > Modified files: > release Makefile > Log: > /floppies/boot.flp is no longer necessary on bootable i386 CD-ROMs. > > Forgotten by: jhb I left it there so that people can choose which method they want to use to make bootable CD's. It was intentional, not a bug. The method is chosen at mkisofs invocation time, not when laying out the hierarchy. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Tue Jul 22 08:04:51 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7189C37B401; Tue, 22 Jul 2003 08:04:51 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0728543FAF; Tue, 22 Jul 2003 08:04:51 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MF4o0U090148; Tue, 22 Jul 2003 08:04:50 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MF4oBq090147; Tue, 22 Jul 2003 08:04:50 -0700 (PDT) Message-Id: <200307221504.h6MF4oBq090147@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 22 Jul 2003 08:04:50 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sbin/atm/atm Makefile atm.h atm_proatm.c atm_show.c atm_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 15:04:52 -0000 harti 2003/07/22 08:04:50 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sbin/atm/atm Makefile atm.h atm_show.c atm_subr.c Added files: (Branch: RELENG_4) sbin/atm/atm atm_proatm.c Log: Handle the new device, API, vendor codes for the ProATM card. Add printing of ProATM statistics. Submitted by: Vincent Jardin Revision Changes Path 1.4.2.2 +2 -2 src/sbin/atm/atm/Makefile 1.4.2.1 +3 -0 src/sbin/atm/atm/atm.h 1.1.2.1 +624 -0 src/sbin/atm/atm/atm_proatm.c (new) 1.3.2.2 +3 -0 src/sbin/atm/atm/atm_show.c 1.3.2.2 +11 -0 src/sbin/atm/atm/atm_subr.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 08:09:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90E2337B401; Tue, 22 Jul 2003 08:09:33 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB78443FA3; Tue, 22 Jul 2003 08:09:32 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h6MF9Vju072917; Tue, 22 Jul 2003 08:09:32 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h6MF9V3M072916; Tue, 22 Jul 2003 08:09:31 -0700 (PDT) Date: Tue, 22 Jul 2003 08:09:31 -0700 From: "David O'Brien" To: John Baldwin Message-ID: <20030722150931.GA72888@dragon.nuxi.com> References: <200307192040.h6JKebpc053687@repoman.freebsd.org> <200307221035.49251.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307221035.49251.jhb@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.1-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/rescue/rescue Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 15:09:33 -0000 On Tue, Jul 22, 2003 at 10:39:57AM -0400, John Baldwin wrote: > On Saturday 19 July 2003 04:40 pm, David E. O'Brien wrote: > > obrien 2003/07/19 13:40:37 PDT > > > > FreeBSD src repository > > > > Modified files: > > rescue/rescue Makefile > > Log: > > Trim /rescue. > > > > Discussed on: freebsd-arch@ > > No consensus though. Several people objected to the removal of > several of these programs. What is the size difference in rescue > after these changes? REPEAT AFTER ME -- IT ISN'T JUST ABOUT THE SIZE. Which in particular are you saying there was a strong desire by someone to keep? -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Jul 22 08:11:09 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C93537B401; Tue, 22 Jul 2003 08:11:09 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC90F43F3F; Tue, 22 Jul 2003 08:11:08 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MFB80U090479; Tue, 22 Jul 2003 08:11:08 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MFB8M8090478; Tue, 22 Jul 2003 08:11:08 -0700 (PDT) Message-Id: <200307221511.h6MFB8M8090478@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 22 Jul 2003 08:11:08 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm/ipatm ipatm_if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 15:11:09 -0000 harti 2003/07/22 08:11:08 PDT FreeBSD src repository Modified files: sys/netatm/ipatm ipatm_if.c Log: Allocate network interfaces from malloc() instead of using a zone. Usually one needs only a couple of them so using a zone is waste of memory (esp. on multi-cpu systems). Revision Changes Path 1.16 +6 -6 src/sys/netatm/ipatm/ipatm_if.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 08:15:04 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3EA4337B401; Tue, 22 Jul 2003 08:15:04 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5631743FB1; Tue, 22 Jul 2003 08:14:53 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6MFEi0U059899 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Jul 2003 18:14:45 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6MFEiYr059898; Tue, 22 Jul 2003 18:14:44 +0300 (EEST) (envelope-from ru) Date: Tue, 22 Jul 2003 18:14:44 +0300 From: Ruslan Ermilov To: John Baldwin Message-ID: <20030722151444.GA59592@sunbay.com> References: <200307220904.h6M949hX062242@repoman.freebsd.org> <200307221039.12782.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9jxsPFA5p3P2qPhR" Content-Disposition: inline In-Reply-To: <200307221039.12782.jhb@FreeBSD.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 15:15:04 -0000 --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 22, 2003 at 10:39:12AM -0400, John Baldwin wrote: > On Tuesday 22 July 2003 05:04 am, Ruslan Ermilov wrote: > > ru 2003/07/22 02:04:09 PDT > > > > FreeBSD src repository > > > > Modified files: > > release Makefile > > Log: > > /floppies/boot.flp is no longer necessary on bootable i386 CD-ROMs. > > > > Forgotten by: jhb >=20 > I left it there so that people can choose which method they want to use > to make bootable CD's. It was intentional, not a bug. The method is > chosen at mkisofs invocation time, not when laying out the hierarchy. >=20 How they can choose it? --- mkisoimages.sh 24 Jan 2002 10:44:15 -0000 1.6 +++ mkisoimages.sh 11 Apr 2002 16:39:13 -0000 1.7 @@ -4,7 +4,7 @@ # Author: Jordan K Hubbard # Date: 22 June 2001 # -# $FreeBSD: src/release/i386/mkisoimages.sh,v 1.6 2002/01/24 10:44:15 murr= ay Exp $ +# $FreeBSD: src/release/i386/mkisoimages.sh,v 1.7 2002/04/11 16:39:13 jhb = Exp $ # # This script is used by release/Makefile to build the (optional) ISO imag= es # for a FreeBSD release. It is considered architecture dependent since ea= ch @@ -25,7 +25,7 @@ if [ "x$1" =3D "x-b" ]; then # This is highly x86-centric and will be used directly below. - bootable=3D"-b floppies/boot.flp -c floppies/boot.catalog" + bootable=3D"-b boot/cdboot -no-emul-boot" shift else bootable=3D"" Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --9jxsPFA5p3P2qPhR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/HVTkUkv4P6juNwoRAtn1AJ4yckZQKxttl2ozgHaKlghuPZxwIgCfUGdQ BsY1LbB431ifaaVNLKtcYQA= =FmkY -----END PGP SIGNATURE----- --9jxsPFA5p3P2qPhR-- From owner-cvs-src@FreeBSD.ORG Tue Jul 22 08:24:57 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 11FC237B401; Tue, 22 Jul 2003 08:24:57 -0700 (PDT) Received: from godel.mtl.distributel.net (nat.MTL.distributel.NET [66.38.181.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A6FC43FB1; Tue, 22 Jul 2003 08:24:56 -0700 (PDT) (envelope-from bmilekic@technokratis.com) Received: from godel.mtl.distributel.net (localhost [127.0.0.1]) h6MBT2EH059117; Tue, 22 Jul 2003 11:29:02 GMT (envelope-from bmilekic@technokratis.com) Received: (from bmilekic@localhost) by godel.mtl.distributel.net (8.12.9/8.12.9/Submit) id h6MBT16j059116; Tue, 22 Jul 2003 11:29:01 GMT X-Authentication-Warning: godel.mtl.distributel.net: bmilekic set sender to bmilekic@technokratis.com using -f Date: Tue, 22 Jul 2003 11:29:01 +0000 From: Bosko Milekic To: Bruce Evans Message-ID: <20030722112901.GA59012@technokratis.com> References: <200307221024.h6MAOggG066724@repoman.freebsd.org> <20030722093443.GD58118@technokratis.com> <20030723003823.R8380@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030723003823.R8380@gamplex.bde.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 15:24:57 -0000 On Wed, Jul 23, 2003 at 12:54:22AM +1000, Bruce Evans wrote: > Inlining was broken in gcc-3.1 (2002/05/09). subr_mbuf.c worked as intended > for almost a year until then. subr_mbuf.c now doesn't even attempt to work > like its comments say it is intended to: > > % /****************************************************************************** > % * Internal routines. > % * > % * Because mb_alloc() and mb_free() are inlines (to keep the common > % * cases down to a maximum of one function call), below are a few > % * routines used only internally for the sole purpose of making certain > % * functions smaller. > % */ > > But mb_alloc() and mb_free() aren't inlines... > > > I guess GCC's warnings just got fixed recently. > > I suspect the warning got broken in gcc-3.1 too. It seemed to work > perfectly when I turned it back on in 1997 (bsd.kern.mk 1.6). However, > it can't have been completely broken for gcc-3.1, since I needed to > turn it off for the high-resolution profiling case. > > Bruce Yeah, hmmmm. :-( Is there a way to force GCC to inline them, despite what it thinks? As I said on some other list, in retrospect, I would re-evaluate the way this is done but currently have diverted my attention to a somewhat different approach. What concerns me about GCC's idea of what is "inlinable" code and what is not is that in some scenarios (admittedly this may not be the case for mb_alloc), we will have an inlined version of some function for an application such as the following: inline-function-A() { blah blah; } /* Exported API */ real-out-of-line-function1() { inline-function-A(); if (one_more_thing) try_this(); } /* Some other Exported API */ real-out-of-line-function2() { inline-function-A(); } In such a scenario, the inline-function-A(), only inlined in two places, reduces code duplication. Even if it's slightly bigger than what GCC thinks "is OK," I could still see a legitimate reason for inlining it. P.S.: I've re-added the src-committers, cvs-src, and cvs-all lists to the To header as I'm curious if anyone else knows the answer as well. I hope you don't mind. Regards, -- Bosko Milekic * bmilekic@technokratis.com * bmilekic@FreeBSD.org TECHNOkRATIS Consulting Services * http://www.technokratis.com/ From owner-cvs-src@FreeBSD.ORG Tue Jul 22 08:50:55 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA42E37B401; Tue, 22 Jul 2003 08:50:55 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6551C43FCB; Tue, 22 Jul 2003 08:50:55 -0700 (PDT) (envelope-from mux@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MFot0U097330; Tue, 22 Jul 2003 08:50:55 -0700 (PDT) (envelope-from mux@repoman.freebsd.org) Received: (from mux@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MFos9b097329; Tue, 22 Jul 2003 08:50:54 -0700 (PDT) Message-Id: <200307221550.h6MFos9b097329@repoman.freebsd.org> From: Maxime Henrion Date: Tue, 22 Jul 2003 08:50:54 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/fxp if_fxp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 15:50:56 -0000 mux 2003/07/22 08:50:54 PDT FreeBSD src repository Modified files: sys/dev/fxp if_fxp.c Log: De-inline some functions. It doesn't gain us anything and bloats code size by 3616 bytes. Furthemore, it was previously ignored by GCC. While I'm at it, fix some bogus comments. Revision Changes Path 1.188 +13 -13 src/sys/dev/fxp/if_fxp.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 08:51:41 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 289CD37B401; Tue, 22 Jul 2003 08:51:41 -0700 (PDT) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4DDBF43F93; Tue, 22 Jul 2003 08:51:40 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) h6MFpdh5039146; Tue, 22 Jul 2003 08:51:39 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost)h6MFpdtR039145; Tue, 22 Jul 2003 08:51:39 -0700 (PDT) Date: Tue, 22 Jul 2003 08:51:39 -0700 From: Steve Kargl To: Bosko Milekic Message-ID: <20030722155139.GA39123@troutmask.apl.washington.edu> References: <200307221024.h6MAOggG066724@repoman.freebsd.org> <20030722093443.GD58118@technokratis.com> <20030723003823.R8380@gamplex.bde.org> <20030722112901.GA59012@technokratis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030722112901.GA59012@technokratis.com> User-Agent: Mutt/1.4.1i cc: cvs-src@freebsd.org cc: phk@phk.freebsd.dk cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Bruce Evans Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 15:51:41 -0000 On Tue, Jul 22, 2003 at 11:29:01AM +0000, Bosko Milekic wrote: > > Is there a way to force GCC to inline them, despite what it thinks? info gcc `-finline-limit=N' By default, gcc limits the size of functions that can be inlined. This flag allows the control of this limit for functions that are explicitly marked as inline (i.e., marked with the inline keyword or defined within the class definition in c++). N is the size of functions that can be inlined in number of pseudo instructions (not counting parameter handling). The default value of N is 600. Increasing this value can result in more inlined code at the cost of compilation time and memory consumption. Decreasing usually -- Steve From owner-cvs-src@FreeBSD.ORG Tue Jul 22 09:30:32 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 227CF37B401; Tue, 22 Jul 2003 09:30:32 -0700 (PDT) Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net [66.199.86.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DC2C43FA3; Tue, 22 Jul 2003 09:30:30 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: from HAL9000.homeunix.com (localhost [127.0.0.1]) by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h6MGU9hC008154; Tue, 22 Jul 2003 09:30:09 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h6MGU7Cj008153; Tue, 22 Jul 2003 09:30:07 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Tue, 22 Jul 2003 09:30:07 -0700 From: David Schultz To: Poul-Henning Kamp Message-ID: <20030722163007.GA6080@HAL9000.homeunix.com> Mail-Followup-To: Poul-Henning Kamp , Bruce Evans , Paul Richards , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <20030722235600.X8165@gamplex.bde.org> <11951.1058884091@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11951.1058884091@critter.freebsd.dk> cc: Paul Richards cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: Bruce Evans Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 16:30:32 -0000 On Tue, Jul 22, 2003, Poul-Henning Kamp wrote: > In message <20030722235600.X8165@gamplex.bde.org>, Bruce Evans writes: > > >Several places, including if_lnc.c, used __inline to get cleaner code > >at no cost in performance. Removing __inline adds a tiny cost. > > You know, I would have agreed with you on that, if we were talking > about a CPU with no caches, no branch-prediction and no prefetching. > > For modern CPUs however it would be hard to prove the above statement > true or false with any sort of measurement setup we have access to, > and it would be even harder if not downright impossible to prove > that the result was generally applicable to a majority of the current > hardware on the market. gcc is a bad model to follow here. It disables inlining to salvage compile time where its register allocation algorithms don't scale. And since it's disabling the inlining all by itself, there's no need to bend over backwards to appease it. The cost of not inlining is insignificant on i386, but it can be very significant on architectures with sliding register windows, such as sparc64. On sparc64, a trap is taken every time the procedure call depth changes by more than 6. An inlining can mean the difference between super-efficient procedure calls and having to slide the register window back and forth at great penalty. This problem wouldn't be so bad if we had a production-quality sparc64 compiler that did aggressive tail-call elimination, but for the moment we're stuck with gcc. Another argument for inlining is that there are some very large functions where inlining the function allows the compiler to optimize away most of it after constant propagation. The savings can be substantial if you can optimize a test in an inner loop. For instance, vm_object_backing_scan() takes a mode flag that is a compile-time constant. (In this particular case, however, there may be a significant code size difference that we don't want to pay for, since the function is used more than once.) > I would _really_ love to nail up a policy note which says that "inline" > should only be used if it is possible to show an effect, either because > inlining reduces the code size (in this particular case less bytes to > execute is generally an indication of better performance) or by > showing actual performance improvements from the inlining. There is reason for concern about cases where inline really is misused, either because it massively increases code size or because it is unimportant to performance and detracts from debuggability. But I would not like to see a policy that shifts the burden of proof onto authors of new code.[1] A policy about gratuitous sweeps through other people's code, on the other hand... [1] In practice, just about any contentious case of inlining is going to be a wash anyway, and neither side of the argument is entirely without merit. I'm mostly opposed to a new policy on the grounds that it's just another stupid rule, complete with technicolor bikesheds, to throw in the faces of people trying to do something useful. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 09:35:43 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B31A37B401; Tue, 22 Jul 2003 09:35:43 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 72FB943FA3; Tue, 22 Jul 2003 09:35:41 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id CAA10340; Wed, 23 Jul 2003 02:35:32 +1000 Date: Wed, 23 Jul 2003 02:35:31 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Bosko Milekic In-Reply-To: <20030722112901.GA59012@technokratis.com> Message-ID: <20030723022239.F8681@gamplex.bde.org> References: <200307221024.h6MAOggG066724@repoman.freebsd.org> <20030723003823.R8380@gamplex.bde.org> <20030722112901.GA59012@technokratis.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 16:35:43 -0000 On Tue, 22 Jul 2003, Bosko Milekic wrote: > > On Wed, Jul 23, 2003 at 12:54:22AM +1000, Bruce Evans wrote: > > Inlining was broken in gcc-3.1 (2002/05/09). subr_mbuf.c worked as intended > > for almost a year until then. subr_mbuf.c now doesn't even attempt to work > > like its comments say it is intended to: > > > > % /****************************************************************************** > > % * Internal routines. > > % * > > % * Because mb_alloc() and mb_free() are inlines (to keep the common > > % * cases down to a maximum of one function call), below are a few > > % * routines used only internally for the sole purpose of making certain > > % * functions smaller. > > % */ > > > > But mb_alloc() and mb_free() aren't inlines... > > > > > I guess GCC's warnings just got fixed recently. > > > > I suspect the warning got broken in gcc-3.1 too. It seemed to work > > perfectly when I turned it back on in 1997 (bsd.kern.mk 1.6). However, > > it can't have been completely broken for gcc-3.1, since I needed to > > turn it off for the high-resolution profiling case. > > > > Bruce > > Yeah, hmmmm. :-( > > Is there a way to force GCC to inline them, despite what it thinks? > As I said on some other list, in retrospect, I would re-evaluate the > way this is done but currently have diverted my attention to a > somewhat different approach. My initial investigation of this problem: % From bde@zeta.org.au Sat Jul 19 13:34:58 2003 +1000 % Date: Sat, 19 Jul 2003 13:34:54 +1000 (EST) % From: Bruce Evans % X-X-Sender: bde@gamplex.bde.org % To: "Jacques A. Vidrine" % cc: Nate Lawson , kan@freebsd.org, current@freebsd.org % Subject: Re: warning: inlining failed % In-Reply-To: <20030718194029.GC70721@madman.celabo.org> % Message-ID: <20030719121303.O25023@gamplex.bde.org> % References: <20030718121511.I26395@root.org> <20030718194029.GC70721@madman.celabo.org> % MIME-Version: 1.0 % Content-Type: TEXT/PLAIN; charset=US-ASCII % Status: O % X-Status: % X-Keywords: % X-UID: 8213 % % On Fri, 18 Jul 2003, Jacques A. Vidrine wrote: % % > On Fri, Jul 18, 2003 at 12:18:14PM -0700, Nate Lawson wrote: % > > Warner mentioned this was due to the gcc import. Nearly every part of the % > > kernel that uses newbus or buf.h prints out lots of warnings. Can someone % > > see about fixing this, whether it's by fixing our headers or build flags % > > or gcc itself? I've already wasted a few reboot cycles because valid % > > warnings were lost in the crowd. % > > % > > cc -O -pipe -mcpu=pentiumpro -D_KERNEL -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -DKLD_MODULE -nostdinc -I- -I. -I@ -I@/dev -I@/../include -I/usr/include -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -c % > > /home/src/sys/modules/ext2fs/../../gnu/ext2fs/ext2_vfsops.c % > > /home/src/sys/gnu/ext2fs/ext2_vfsops.c: In function `compute_sb_data': % > > @/sys/buf.h:281: warning: inlining failed in call to `BUF_LOCK' % > > /home/src/sys/gnu/ext2fs/ext2_vfsops.c:496: warning: called from here % > ... % > Does `-finline-limit=1200' (or bigger) help? % % Maybe. It allows larger declared-inline functions to actually be inlined % of course. This probably helps performance negatively in the case of % large functions like BUF_LOCK. % % > I think GCC 3.3 added a warning for when inline functions generated `a % > lot' of instructions. In such a case, the function is not inlined. I % > believe this also happened with GCC 3.2, but it just didn't normally % > tell you about it. % % A warning (-Winline) about gcc not inlining a function because the % function involves "a lot" of instructions has existed for ages, and % FreeBSD has used it since since I reenabled it in 1997 in rev.1.6 of % bsd.kern.mk, but it was apparently broken in at least gcc-3.[1-2]. % The main differences between gcc-3.2 and gcc-3.3 in this area seem to % be just that the warning actually works in gcc-3.3, and gcc-3.3 has % more options for quantifying "a lot" than anyone would want to know % about. % % Since gcc now warns when it should, and successful inlining of all % inline functions in FreeBSD was apparently broken in gcc-3.1, gcc-3.3 % now emits hundreds or thousands of warnings about functions that it % can't inline. -Wunline was supposed to let us fix bogus inlining % incrementatally, but this was defeated by it not working in gcc-3.[1-2]. % % E.g., according to my kernel backups, non-inlining of BUF_LOCK started % with gcc-3.1. Some relevant history: % % 1996/06/26: BUF_LOCK implemented (as an inline) in buf.h rev.1.71 % 2002/05/09: kernel built on this date by gcc-2.95.4 (20020320) has no % static copies of BUF_LOCK % 2002/06/29: kernel built on this date by gcc-3.1 (20020529) has 11 % static copies of BUF_LOCK % % The new options for controlling inlining are: % % -finline-linit= % --param max-inline-insns= % --param max-inline-insns-single= % --param max-inline-insns-auto= % --param min-inline-insns= % --param max-inline-insns-rtl= % % See gcc.info for details. % % I couldn't find a setting that I liked. Most things compile with % --param max-inline-insns-single=1600, which sort of corresponds to % -finline-linit=3200 (more than 5 times larger than the default). % A few files need amazingly larger values. Compiling with values % smaller than the default unconvered interesting bugs in the source % code (invalid asm and an unitiialized variable). What I want is % for leaf functions declared as inline to always be inlined unless % they are larger than some limit, but the gcc controls are mainly for % for limiting the size of non-leaf functions. Apparently-small % functions can become amazingly large due to nested inllining. This % gives inlining failures which are not entirely the fault of bloat in % the inline functions. E.g., the following trick (which is used a lot % in subr_mbuf.c and kern_descrip.c) doesn't actually give inline functions: % % %%% % static inline int % bigfunc(int foo, int flags) % { % /* Large code. */ % ... % return (resultoflargecode); % } % % static int % smallfunc1(int foo) % { % return (bigfunc(foo, 1)); % } % % static int % smallfunc2(int foo) % { % return (bigfunc(foo, 2)); % } % % static int % smallfunc3(int foo) % { % return (bigfunc(foo, 3)); % } % ... % %%% % % This trick is used mainly to avoid repeating the relevant parts of % bigfunc() at the source level. Repeating them at the object level is % wanted and expected to do more than just avoid a function call since % large sections of code can be optimized away when `flags' has a constant % value. But gcc-3 doesn't like this trick since it gives large code % to inline. The effectivness of the desired inlining (or lack thereof) % is apparently null. No one noticed when the inlining stopped with % gcc-3.1 14 months ago. (I checked that the interesting inlining of % mb_alloc() was done on 2002/05/09 but not on 2002/06/29.) % % Bruce > What concerns me about GCC's idea of what is "inlinable" code and what > is not is that in some scenarios (admittedly this may not be the case > for mb_alloc), we will have an inlined version of some function for an > application such as the following: > > inline-function-A() { > blah blah; > } > > /* Exported API */ > real-out-of-line-function1() { > inline-function-A(); > if (one_more_thing) > try_this(); > } > > /* Some other Exported API */ > real-out-of-line-function2() { > inline-function-A(); > } > > In such a scenario, the inline-function-A(), only inlined in two > places, reduces code duplication. Even if it's slightly bigger than > what GCC thinks "is OK," I could still see a legitimate reason for > inlining it. I think gcc's inlining heuristics are tuned towards automatic inlining, and it should try harder for explicit inline keywords (for C, maybe not for C++). Maybe we should set the inlining limits to infinity for the kernel since we know what we are doing with the inline keywords (just like for register keywords ;-) and we don't use automatic inlining. Bruce From owner-cvs-src@FreeBSD.ORG Tue Jul 22 09:42:26 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 76DC837B401; Tue, 22 Jul 2003 09:42:26 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9939243FCB; Tue, 22 Jul 2003 09:42:24 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MGgLV3017269; Tue, 22 Jul 2003 16:42:21 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MGgK5H013095; Tue, 22 Jul 2003 18:42:20 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: David Schultz From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 09:30:07 PDT." <20030722163007.GA6080@HAL9000.homeunix.com> Date: Tue, 22 Jul 2003 18:42:20 +0200 Message-ID: <13094.1058892140@critter.freebsd.dk> cc: Paul Richards cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: Bruce Evans Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 16:42:27 -0000 In message <20030722163007.GA6080@HAL9000.homeunix.com>, David Schultz writes: >The cost of not inlining is insignificant on i386, but it can be >very significant on architectures with sliding register windows, >such as sparc64. On sparc64, a trap is taken every time the >procedure call depth changes by more than 6. An inlining can mean >the difference between super-efficient procedure calls and having >to slide the register window back and forth at great penalty. Fine, but if you are not able to measure the difference and the code is bigger, is it worth it ? Considering that modern CPU caches are about an order of magnitude to small to avoid being a performance throttle, I think code size will prove to be a more significant issue on all current platforms. I agree that constant propagation is a worthwhile reason, but I will still tend to think that if it increases code size for no measurable performance gain, we're on slippery slope... >There is reason for concern about cases where inline really is >misused, either because it massively increases code size or >because it is unimportant to performance and detracts from >debuggability. Here we agree. >[1] In practice, just about any contentious case of inlining is > going to be a wash anyway, and neither side of the argument > is entirely without merit. I'm mostly opposed to a new policy > on the grounds that it's just another stupid rule, complete > with technicolor bikesheds, to throw in the faces of people > trying to do something useful. I far prefer to just fix the problems, but clearly the sort of inline (and register) use we have in the tree indicates that at least some of our contributors are in need of a guideline for when to inline things. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 10:27:16 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 994AA37B401; Tue, 22 Jul 2003 10:27:16 -0700 (PDT) Received: from godel.mtl.distributel.net (nat.MTL.distributel.NET [66.38.181.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9C0743F85; Tue, 22 Jul 2003 10:27:15 -0700 (PDT) (envelope-from bmilekic@technokratis.com) Received: from godel.mtl.distributel.net (localhost [127.0.0.1]) h6MDVMEH059953; Tue, 22 Jul 2003 13:31:22 GMT (envelope-from bmilekic@technokratis.com) Received: (from bmilekic@localhost) by godel.mtl.distributel.net (8.12.9/8.12.9/Submit) id h6MDVLrW059952; Tue, 22 Jul 2003 13:31:21 GMT X-Authentication-Warning: godel.mtl.distributel.net: bmilekic set sender to bmilekic@technokratis.com using -f Date: Tue, 22 Jul 2003 13:31:21 +0000 From: Bosko Milekic To: Bruce Evans Message-ID: <20030722133121.GA59912@technokratis.com> References: <200307221024.h6MAOggG066724@repoman.freebsd.org> <20030722093443.GD58118@technokratis.com> <20030723003823.R8380@gamplex.bde.org> <20030722112901.GA59012@technokratis.com> <20030723022239.F8681@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030723022239.F8681@gamplex.bde.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 17:27:17 -0000 On Wed, Jul 23, 2003 at 02:35:31AM +1000, Bruce Evans wrote: [... very good explanation ommitted... ] > > What concerns me about GCC's idea of what is "inlinable" code and what > > is not is that in some scenarios (admittedly this may not be the case > > for mb_alloc), we will have an inlined version of some function for an > > application such as the following: > > > > inline-function-A() { > > blah blah; > > } > > > > /* Exported API */ > > real-out-of-line-function1() { > > inline-function-A(); > > if (one_more_thing) > > try_this(); > > } > > > > /* Some other Exported API */ > > real-out-of-line-function2() { > > inline-function-A(); > > } > > > > In such a scenario, the inline-function-A(), only inlined in two > > places, reduces code duplication. Even if it's slightly bigger than > > what GCC thinks "is OK," I could still see a legitimate reason for > > inlining it. > > I think gcc's inlining heuristics are tuned towards automatic inlining, > and it should try harder for explicit inline keywords (for C, maybe > not for C++). Maybe we should set the inlining limits to infinity for > the kernel since we know what we are doing with the inline keywords > (just like for register keywords ;-) and we don't use automatic > inlining. > > Bruce I would tend to lean in this direction as well. Just blindly turning all our inlines that GCC now builds as functions into functions does not seem like a good solution. I see these commits flying by, notably the recent one in fxp, and I'm wondering if perhaps one or two of those functions that were changed could have stayed inlines, were it not for the nested inlining, as you point out above. At the same time, at least this warning exposed that we should carefully re-evaluate what we inline and when. -- Bosko Milekic * bmilekic@technokratis.com * bmilekic@FreeBSD.org TECHNOkRATIS Consulting Services * http://www.technokratis.com/ From owner-cvs-src@FreeBSD.ORG Tue Jul 22 10:47:32 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA96837B405; Tue, 22 Jul 2003 10:47:32 -0700 (PDT) Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net [66.199.86.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id B13A343F3F; Tue, 22 Jul 2003 10:47:31 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: from HAL9000.homeunix.com (localhost [127.0.0.1]) by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h6MHlRhC008562; Tue, 22 Jul 2003 10:47:27 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h6MHlLAR008561; Tue, 22 Jul 2003 10:47:21 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Tue, 22 Jul 2003 10:47:21 -0700 From: David Schultz To: Poul-Henning Kamp Message-ID: <20030722174721.GA8358@HAL9000.homeunix.com> Mail-Followup-To: Poul-Henning Kamp , Bruce Evans , Paul Richards , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20030722163007.GA6080@HAL9000.homeunix.com> <13094.1058892140@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13094.1058892140@critter.freebsd.dk> cc: Paul Richards cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: Bruce Evans Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 17:47:33 -0000 On Tue, Jul 22, 2003, Poul-Henning Kamp wrote: > In message <20030722163007.GA6080@HAL9000.homeunix.com>, David Schultz writes: > > >The cost of not inlining is insignificant on i386, but it can be > >very significant on architectures with sliding register windows, > >such as sparc64. On sparc64, a trap is taken every time the > >procedure call depth changes by more than 6. An inlining can mean > >the difference between super-efficient procedure calls and having > >to slide the register window back and forth at great penalty. > > Fine, but if you are not able to measure the difference and the > code is bigger, is it worth it ? Inlining C++ code on sparc64 is a huge win, but that's mostly because C++ is very heavy on function calls. I don't know exactly what the impact would be on most parts of the FreeBSD kernel. > >[1] In practice, just about any contentious case of inlining is > > going to be a wash anyway, and neither side of the argument > > is entirely without merit. I'm mostly opposed to a new policy > > on the grounds that it's just another stupid rule, complete > > with technicolor bikesheds, to throw in the faces of people > > trying to do something useful. > > I far prefer to just fix the problems, but clearly the sort of > inline (and register) use we have in the tree indicates that at > least some of our contributors are in need of a guideline for > when to inline things. If you want to add a few lines to style(9) to the effect of ``be careful, inlining allows you to shoot yourself in the foot with exponentially more bullets than you expected'', that's fine with me. But I'd rather see inlines fixed or complained about only when someone really did screw up. I worry that if people are prevented from using inlines, they will not decompose their code into separate functions as much in the first place, regardless of whether the optimization was justified. If the inline doesn't increase code size, it is certainly the lesser of two evils, and, in my opinion, not worth fussing about. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 10:58:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F5F437B401; Tue, 22 Jul 2003 10:58:30 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2613643F3F; Tue, 22 Jul 2003 10:58:30 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MHwT0U004238; Tue, 22 Jul 2003 10:58:29 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MHwTLH004237; Tue, 22 Jul 2003 10:58:29 -0700 (PDT) Message-Id: <200307221758.h6MHwTLH004237@repoman.freebsd.org> From: Sam Leffler Date: Tue, 22 Jul 2003 10:58:29 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/i386/conf LINT src/sys/modules Makefile src/sys/conf files options src/sys/dev/safe safe.c safereg.h safevar.h src/sys/modules/safe Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 17:58:30 -0000 sam 2003/07/22 10:58:29 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/i386/conf LINT sys/modules Makefile sys/conf files options Added files: (Branch: RELENG_4) sys/dev/safe safe.c safereg.h safevar.h sys/modules/safe Makefile Log: MFC SafeNet crypto driver Sponsored by: Global Technology Associates, Inc. Revision Changes Path 1.340.2.139 +1 -0 src/sys/conf/files 1.191.2.55 +5 -0 src/sys/conf/options 1.1.2.1 +2253 -0 src/sys/dev/safe/safe.c (new) 1.1.2.1 +412 -0 src/sys/dev/safe/safereg.h (new) 1.1.2.1 +226 -0 src/sys/dev/safe/safevar.h (new) 1.749.2.148 +4 -0 src/sys/i386/conf/LINT 1.110.2.72 +1 -0 src/sys/modules/Makefile 1.1.2.1 +38 -0 src/sys/modules/safe/Makefile (new) From owner-cvs-src@FreeBSD.ORG Tue Jul 22 11:00:40 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A00437B401; Tue, 22 Jul 2003 11:00:40 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DBF1443FA3; Tue, 22 Jul 2003 11:00:39 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MI0d0U004381; Tue, 22 Jul 2003 11:00:39 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MI0dXd004380; Tue, 22 Jul 2003 11:00:39 -0700 (PDT) Message-Id: <200307221800.h6MI0dXd004380@repoman.freebsd.org> From: Sam Leffler Date: Tue, 22 Jul 2003 11:00:39 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/share/man/man4 Makefile safe.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 18:00:40 -0000 sam 2003/07/22 11:00:39 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) share/man/man4 Makefile Added files: (Branch: RELENG_4) share/man/man4 safe.4 Log: MFC: SafeNet crypto driver man page Revision Changes Path 1.83.2.67 +1 -0 src/share/man/man4/Makefile 1.1.2.1 +105 -0 src/share/man/man4/safe.4 (new) From owner-cvs-src@FreeBSD.ORG Tue Jul 22 11:01:43 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED70437B40B; Tue, 22 Jul 2003 11:01:42 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 47EE943F3F; Tue, 22 Jul 2003 11:01:42 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MI1g0U004489; Tue, 22 Jul 2003 11:01:42 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MI1fJo004488; Tue, 22 Jul 2003 11:01:41 -0700 (PDT) Message-Id: <200307221801.h6MI1fJo004488@repoman.freebsd.org> From: Sam Leffler Date: Tue, 22 Jul 2003 11:01:41 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/tools/tools/crypto Makefile safestats.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 18:01:43 -0000 sam 2003/07/22 11:01:41 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) tools/tools/crypto Makefile Added files: (Branch: RELENG_4) tools/tools/crypto safestats.c Log: MFC: safenet driver stats program Revision Changes Path 1.2.2.3 +5 -1 src/tools/tools/crypto/Makefile 1.1.2.1 +69 -0 src/tools/tools/crypto/safestats.c (new) From owner-cvs-src@FreeBSD.ORG Tue Jul 22 11:26:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F39F037B401 for ; Tue, 22 Jul 2003 11:26:17 -0700 (PDT) Received: from mail.speakeasy.net (mail10.speakeasy.net [216.254.0.210]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75A9D43F75 for ; Tue, 22 Jul 2003 11:26:16 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 6089 invoked from network); 22 Jul 2003 18:26:15 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 22 Jul 2003 18:26:15 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6MIQDGI042977; Tue, 22 Jul 2003 14:26:13 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030722151444.GA59592@sunbay.com> Date: Tue, 22 Jul 2003 14:26:28 -0400 (EDT) From: John Baldwin To: Ruslan Ermilov cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 18:26:18 -0000 On 22-Jul-2003 Ruslan Ermilov wrote: > On Tue, Jul 22, 2003 at 10:39:12AM -0400, John Baldwin wrote: >> On Tuesday 22 July 2003 05:04 am, Ruslan Ermilov wrote: >> > ru 2003/07/22 02:04:09 PDT >> > >> > FreeBSD src repository >> > >> > Modified files: >> > release Makefile >> > Log: >> > /floppies/boot.flp is no longer necessary on bootable i386 CD-ROMs. >> > >> > Forgotten by: jhb >> >> I left it there so that people can choose which method they want to use >> to make bootable CD's. It was intentional, not a bug. The method is >> chosen at mkisofs invocation time, not when laying out the hierarchy. >> > How they can choose it? They don't use MAKE_ISOS and invoke mkisofs on their own. I have never used MAKE_ISOS when building a release and have always used my own buildreliso script. > --- mkisoimages.sh 24 Jan 2002 10:44:15 -0000 1.6 > +++ mkisoimages.sh 11 Apr 2002 16:39:13 -0000 1.7 > @@ -4,7 +4,7 @@ > # Author: Jordan K Hubbard > # Date: 22 June 2001 > # > -# $FreeBSD: src/release/i386/mkisoimages.sh,v 1.6 2002/01/24 10:44:15 murray Exp $ > +# $FreeBSD: src/release/i386/mkisoimages.sh,v 1.7 2002/04/11 16:39:13 jhb Exp $ > # > # This script is used by release/Makefile to build the (optional) ISO images > # for a FreeBSD release. It is considered architecture dependent since each > @@ -25,7 +25,7 @@ > if [ "x$1" = "x-b" ]; then > # This is highly x86-centric and will be used directly below. > - bootable="-b floppies/boot.flp -c floppies/boot.catalog" > + bootable="-b boot/cdboot -no-emul-boot" > shift > else > bootable="" > > > Cheers, > -- > Ruslan Ermilov Sysadmin and DBA, > ru@sunbay.com Sunbay Software Ltd, > ru@FreeBSD.org FreeBSD committer -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Tue Jul 22 11:40:06 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBEA437B401; Tue, 22 Jul 2003 11:40:06 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id B181F43FA3; Tue, 22 Jul 2003 11:40:02 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6MIdx0U081653 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Jul 2003 21:39:59 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6MIdxOw081648; Tue, 22 Jul 2003 21:39:59 +0300 (EEST) (envelope-from ru) Date: Tue, 22 Jul 2003 21:39:59 +0300 From: Ruslan Ermilov To: John Baldwin Message-ID: <20030722183959.GB80514@sunbay.com> References: <20030722151444.GA59592@sunbay.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Pd0ReVV5GZGQvF3a" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 18:40:07 -0000 --Pd0ReVV5GZGQvF3a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 22, 2003 at 02:26:28PM -0400, John Baldwin wrote: >=20 > On 22-Jul-2003 Ruslan Ermilov wrote: > > On Tue, Jul 22, 2003 at 10:39:12AM -0400, John Baldwin wrote: > >> On Tuesday 22 July 2003 05:04 am, Ruslan Ermilov wrote: > >> > ru 2003/07/22 02:04:09 PDT > >> > > >> > FreeBSD src repository > >> > > >> > Modified files: > >> > release Makefile > >> > Log: > >> > /floppies/boot.flp is no longer necessary on bootable i386 CD-ROMs. > >> > > >> > Forgotten by: jhb > >>=20 > >> I left it there so that people can choose which method they want to use > >> to make bootable CD's. It was intentional, not a bug. The method is > >> chosen at mkisofs invocation time, not when laying out the hierarchy. > >>=20 > > How they can choose it? >=20 > They don't use MAKE_ISOS and invoke mkisofs on their own. I have never > used MAKE_ISOS when building a release and have always used my own buildr= eliso > script. > =20 So you agree there's no sense to keep the boot.flp on the second CD-ROM image in official version? Your own script can take care of copying it to the CD-ROM if necessary. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --Pd0ReVV5GZGQvF3a Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/HYT/Ukv4P6juNwoRAo9LAJ9SW4lj8P9bNuBnsLkrdNO0aOf1igCfbfkM eJOcn2qJOEocAFqyKkwY6Vg= =TA62 -----END PGP SIGNATURE----- --Pd0ReVV5GZGQvF3a-- From owner-cvs-src@FreeBSD.ORG Tue Jul 22 11:45:54 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA15537B407 for ; Tue, 22 Jul 2003 11:45:54 -0700 (PDT) Received: from mail.speakeasy.net (mail8.speakeasy.net [216.254.0.208]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40CD843FAF for ; Tue, 22 Jul 2003 11:45:52 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 28850 invoked from network); 22 Jul 2003 18:45:49 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 22 Jul 2003 18:45:49 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6MIjiGI043044; Tue, 22 Jul 2003 14:45:45 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030722183959.GB80514@sunbay.com> Date: Tue, 22 Jul 2003 14:46:00 -0400 (EDT) From: John Baldwin To: Ruslan Ermilov cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 18:45:55 -0000 On 22-Jul-2003 Ruslan Ermilov wrote: > On Tue, Jul 22, 2003 at 02:26:28PM -0400, John Baldwin wrote: >> >> On 22-Jul-2003 Ruslan Ermilov wrote: >> > On Tue, Jul 22, 2003 at 10:39:12AM -0400, John Baldwin wrote: >> >> On Tuesday 22 July 2003 05:04 am, Ruslan Ermilov wrote: >> >> > ru 2003/07/22 02:04:09 PDT >> >> > >> >> > FreeBSD src repository >> >> > >> >> > Modified files: >> >> > release Makefile >> >> > Log: >> >> > /floppies/boot.flp is no longer necessary on bootable i386 CD-ROMs. >> >> > >> >> > Forgotten by: jhb >> >> >> >> I left it there so that people can choose which method they want to use >> >> to make bootable CD's. It was intentional, not a bug. The method is >> >> chosen at mkisofs invocation time, not when laying out the hierarchy. >> >> >> > How they can choose it? >> >> They don't use MAKE_ISOS and invoke mkisofs on their own. I have never >> used MAKE_ISOS when building a release and have always used my own buildreliso >> script. >> > So you agree there's no sense to keep the boot.flp on the second > CD-ROM image in official version? Your own script can take care > of copying it to the CD-ROM if necessary. No, my intention was to allow distributors like FreeBSD Mall, BSD Mall, etc. to easily choose which method they wanted to use. I.e., if they weren't comfortable with cdboot, they could still roll an ISO from the same tree using boot.flp without having to jump through hoops. However, if no one wants to use boot.flp anymore, then it should be removed outright since 2.88 floppies don't "really" exist in a useful fashion. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Tue Jul 22 11:54:37 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 057EA37B401 for ; Tue, 22 Jul 2003 11:54:37 -0700 (PDT) Received: from mail26c.sbc-webhosting.com (mail26c.sbc-webhosting.com [216.173.237.166]) by mx1.FreeBSD.org (Postfix) with SMTP id 4795943F93 for ; Tue, 22 Jul 2003 11:54:35 -0700 (PDT) (envelope-from alc@imimic.com) Received: from www.imimic.com (64.143.12.21)0-04402155; Tue, 22 Jul 2003 14:54:15 -0400 (EDT) Sender: alc@FreeBSD.ORG Message-ID: <3F1D8858.670C08B2@imimic.com> Date: Tue, 22 Jul 2003 13:54:16 -0500 From: "Alan L. Cox" Organization: iMimic Networking, Inc. X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386) X-Accept-Language: en MIME-Version: 1.0 To: Steve Kargl References: <200307221024.h6MAOggG066724@repoman.freebsd.org> <20030722093443.GD58118@technokratis.com> <20030723003823.R8380@gamplex.bde.org> <20030722112901.GA59012@technokratis.com> <20030722155139.GA39123@troutmask.apl.washington.edu> Content-Type: text/plain; charset=x-user-defined Content-Transfer-Encoding: 7bit X-Loop-Detect: 1 cc: phk@phk.freebsd.dk cc: src-committers@freebsd.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 18:54:37 -0000 Steve Kargl wrote: > > On Tue, Jul 22, 2003 at 11:29:01AM +0000, Bosko Milekic wrote: > > > > Is there a way to force GCC to inline them, despite what it thinks? > > info gcc > > `-finline-limit=N' > By default, gcc limits the size of functions that can be inlined. > This flag allows the control of this limit for functions that are > explicitly marked as inline (i.e., marked with the inline keyword > or defined within the class definition in c++). N is the size of > functions that can be inlined in number of pseudo instructions > (not counting parameter handling). The default value of N is 600. > Increasing this value can result in more inlined code at the cost > of compilation time and memory consumption. Decreasing usually > There is another way. The following example illustrates its use. static int vm_object_backing_scan(vm_object_t object, int op) __attribute__((always_inline)); Regards, Alan From owner-cvs-src@FreeBSD.ORG Tue Jul 22 11:56:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A3B437B404; Tue, 22 Jul 2003 11:56:30 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 411CD43F93; Tue, 22 Jul 2003 11:56:25 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6MIuM0U083392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Jul 2003 21:56:22 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6MIuLDi083380; Tue, 22 Jul 2003 21:56:21 +0300 (EEST) (envelope-from ru) Date: Tue, 22 Jul 2003 21:56:21 +0300 From: Ruslan Ermilov To: John Baldwin Message-ID: <20030722185621.GD80514@sunbay.com> References: <20030722183959.GB80514@sunbay.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="n/aVsWSeQ4JHkrmm" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: Murray Stokely cc: cvs-all@FreeBSD.org cc: Chern Lee Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 18:56:31 -0000 --n/aVsWSeQ4JHkrmm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 22, 2003 at 02:46:00PM -0400, John Baldwin wrote: > >> >> On Tuesday 22 July 2003 05:04 am, Ruslan Ermilov wrote: > >> >> > ru 2003/07/22 02:04:09 PDT > >> >> > > >> >> > FreeBSD src repository > >> >> > > >> >> > Modified files: > >> >> > release Makefile > >> >> > Log: > >> >> > /floppies/boot.flp is no longer necessary on bootable i386 CD-R= OMs. > >> >> > > >> >> > Forgotten by: jhb > >> >>=20 > >> >> I left it there so that people can choose which method they want to= use > >> >> to make bootable CD's. It was intentional, not a bug. The method = is > >> >> chosen at mkisofs invocation time, not when laying out the hierarch= y. > >> >>=20 > >> > How they can choose it? > >>=20 > >> They don't use MAKE_ISOS and invoke mkisofs on their own. I have never > >> used MAKE_ISOS when building a release and have always used my own bui= ldreliso > >> script. > >> =20 > > So you agree there's no sense to keep the boot.flp on the second > > CD-ROM image in official version? Your own script can take care > > of copying it to the CD-ROM if necessary. >=20 > No, my intention was to allow distributors like FreeBSD Mall, > BSD Mall, etc. to easily choose which method they wanted to use. > I.e., if they weren't comfortable with cdboot, they could still roll > an ISO from the same tree using boot.flp without having to jump > through hoops. However, if no one wants to use boot.flp anymore, > then it should be removed outright since 2.88 floppies don't "really" > exist in a useful fashion. >=20 Murray, Chern, that's your call then. Would you like me to revert this change? Do you need the /floppies/boot.flp on the 1st and 2nd i386 CD-ROMs? Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --n/aVsWSeQ4JHkrmm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/HYjVUkv4P6juNwoRAhLsAJ9EjGJf64fe1QWp1UC2Q5+WB3UbrACdFm9Z Fs2h2InkJIbCySDVclZ/cU0= =M3s/ -----END PGP SIGNATURE----- --n/aVsWSeQ4JHkrmm-- From owner-cvs-src@FreeBSD.ORG Tue Jul 22 11:58:35 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6506737B401; Tue, 22 Jul 2003 11:58:35 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D951F43F3F; Tue, 22 Jul 2003 11:58:34 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MIwY0U007439; Tue, 22 Jul 2003 11:58:34 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MIwY2g007438; Tue, 22 Jul 2003 11:58:34 -0700 (PDT) Message-Id: <200307221858.h6MIwY2g007438@repoman.freebsd.org> From: Sam Leffler Date: Tue, 22 Jul 2003 11:58:34 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_input.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 18:58:36 -0000 sam 2003/07/22 11:58:34 PDT FreeBSD src repository Modified files: sys/netinet ip_input.c Log: add IPSEC_FILTERGIF suport for FAST_IPSEC PR: kern/51922 Submitted by: Eric Masson MFC after: 1 week Revision Changes Path 1.240 +7 -0 src/sys/netinet/ip_input.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 12:05:49 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2BCF137B401 for ; Tue, 22 Jul 2003 12:05:49 -0700 (PDT) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3C3FC43F93 for ; Tue, 22 Jul 2003 12:05:46 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 3126 invoked from network); 22 Jul 2003 19:05:45 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 22 Jul 2003 19:05:45 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6MJ5hGI043104; Tue, 22 Jul 2003 15:05:43 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030722185621.GD80514@sunbay.com> Date: Tue, 22 Jul 2003 15:05:59 -0400 (EDT) From: John Baldwin To: Ruslan Ermilov cc: cvs-src@FreeBSD.org cc: Murray Stokely cc: Chern Lee cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 19:05:49 -0000 On 22-Jul-2003 Ruslan Ermilov wrote: > On Tue, Jul 22, 2003 at 02:46:00PM -0400, John Baldwin wrote: >> >> >> On Tuesday 22 July 2003 05:04 am, Ruslan Ermilov wrote: >> >> >> > ru 2003/07/22 02:04:09 PDT >> >> >> > >> >> >> > FreeBSD src repository >> >> >> > >> >> >> > Modified files: >> >> >> > release Makefile >> >> >> > Log: >> >> >> > /floppies/boot.flp is no longer necessary on bootable i386 CD-ROMs. >> >> >> > >> >> >> > Forgotten by: jhb >> >> >> >> >> >> I left it there so that people can choose which method they want to use >> >> >> to make bootable CD's. It was intentional, not a bug. The method is >> >> >> chosen at mkisofs invocation time, not when laying out the hierarchy. >> >> >> >> >> > How they can choose it? >> >> >> >> They don't use MAKE_ISOS and invoke mkisofs on their own. I have never >> >> used MAKE_ISOS when building a release and have always used my own buildreliso >> >> script. >> >> >> > So you agree there's no sense to keep the boot.flp on the second >> > CD-ROM image in official version? Your own script can take care >> > of copying it to the CD-ROM if necessary. >> >> No, my intention was to allow distributors like FreeBSD Mall, >> BSD Mall, etc. to easily choose which method they wanted to use. >> I.e., if they weren't comfortable with cdboot, they could still roll >> an ISO from the same tree using boot.flp without having to jump >> through hoops. However, if no one wants to use boot.flp anymore, >> then it should be removed outright since 2.88 floppies don't "really" >> exist in a useful fashion. >> > Murray, Chern, that's your call then. Would you like me to revert > this change? Do you need the /floppies/boot.flp on the 1st and > 2nd i386 CD-ROMs? The vendors@ list might be the best place to ask. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Tue Jul 22 12:08:47 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 29D6437B401; Tue, 22 Jul 2003 12:08:47 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE1CA43F75; Tue, 22 Jul 2003 12:08:46 -0700 (PDT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MJ8k0U008796; Tue, 22 Jul 2003 12:08:46 -0700 (PDT) (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MJ8k1q008795; Tue, 22 Jul 2003 12:08:46 -0700 (PDT) Message-Id: <200307221908.h6MJ8k1q008795@repoman.freebsd.org> From: Sam Leffler Date: Tue, 22 Jul 2003 12:08:46 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 ath_hal.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 19:08:47 -0000 sam 2003/07/22 12:08:46 PDT FreeBSD src repository Modified files: share/man/man4 ath_hal.4 Log: correct device table a la ath(4) Revision Changes Path 1.3 +4 -4 src/share/man/man4/ath_hal.4 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 12:12:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 42DA137B401; Tue, 22 Jul 2003 12:12:18 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5C5443FB1; Tue, 22 Jul 2003 12:12:17 -0700 (PDT) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MJCH0U008988; Tue, 22 Jul 2003 12:12:17 -0700 (PDT) (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MJCHpB008987; Tue, 22 Jul 2003 12:12:17 -0700 (PDT) Message-Id: <200307221912.h6MJCHpB008987@repoman.freebsd.org> From: Mike Silbersack Date: Tue, 22 Jul 2003 12:12:17 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/kern uipc_mbuf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 19:12:18 -0000 silby 2003/07/22 12:12:17 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/kern uipc_mbuf.c Log: Fix up an error check in m_clreflimit and turn it into a KASSERT. Revision Changes Path 1.51.2.31 +3 -3 src/sys/kern/uipc_mbuf.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 12:13:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CBBC437B401; Tue, 22 Jul 2003 12:13:45 -0700 (PDT) Received: from mx0.freebsd-services.com (survey.codeburst.net [195.149.39.161]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1D7E43FB1; Tue, 22 Jul 2003 12:13:44 -0700 (PDT) (envelope-from paul@freebsd-services.com) Received: by mx0.freebsd-services.com (Postfix, from userid 1002) id C6F5E1B211; Tue, 22 Jul 2003 20:13:43 +0100 (BST) Date: Tue, 22 Jul 2003 20:13:43 +0100 From: Paul Richards To: Poul-Henning Kamp Message-ID: <20030722191343.GB90991@survey.codeburst.net> References: <20030722163007.GA6080@HAL9000.homeunix.com> <13094.1058892140@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13094.1058892140@critter.freebsd.dk> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.ORG cc: David Schultz cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: Bruce Evans Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 19:13:46 -0000 On Tue, Jul 22, 2003 at 06:42:20PM +0200, Poul-Henning Kamp wrote: > In message <20030722163007.GA6080@HAL9000.homeunix.com>, David Schultz writes: > > >The cost of not inlining is insignificant on i386, but it can be > >very significant on architectures with sliding register windows, > >such as sparc64. On sparc64, a trap is taken every time the > >procedure call depth changes by more than 6. An inlining can mean > >the difference between super-efficient procedure calls and having > >to slide the register window back and forth at great penalty. > > Fine, but if you are not able to measure the difference and the > code is bigger, is it worth it ? Though in the case of if_lnc the code was not bigger. There was no downside to the use of inline in this case and you've changed perfectly valid code just to shut up gcc. A lot of gcc warnings are worth having on by default because they catch a lot of potential bugs. With those the few cases where it's deliberate are worth working around to shut up the warning so they can be left on by default for the rest of the tree. I don't think inline is one of those checks though, since there are perfectly good reasons to use it sometimes that gcc doesn't like. I don't think it should be a default warning therefore, perhaps the "policy" should be to run your code through with it on so you get warned about potential abuses and then make your own judgement and not be a slave to the compiler in this case. -- Tis a wise thing to know what is wanted, wiser still to know when it has been achieved and wisest of all to know when it is unachievable for then striving is folly. [Magician] From owner-cvs-src@FreeBSD.ORG Tue Jul 22 12:22:08 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE1E837B401; Tue, 22 Jul 2003 12:22:08 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F5A143F93; Tue, 22 Jul 2003 12:22:08 -0700 (PDT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MJM80U009402; Tue, 22 Jul 2003 12:22:08 -0700 (PDT) (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MJM8Vt009401; Tue, 22 Jul 2003 12:22:08 -0700 (PDT) Message-Id: <200307221922.h6MJM8Vt009401@repoman.freebsd.org> From: Diomidis Spinellis Date: Tue, 22 Jul 2003 12:22:08 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/sed/TEST sed.test X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 19:22:09 -0000 dds 2003/07/22 12:22:08 PDT FreeBSD src repository Modified files: usr.bin/sed/TEST sed.test Log: Test 8.16 in sed.test tests the ability of a sed to handle an empty regular expression as the first argument to a substitute command. If used to test a sed which (erroneously) evaluates this at translation time rather than at execution time, the bugged sed is put into an infinite loop. This mode of failure seems excessive. Such a failing sed is the Free Software Foundation's sed 3.02. The specific test was also not being executed for the BSD sed. Both problems are now fixed. PR: misc/25585 Submitted by: Walter Briscoe Approved by: schweikh (mentor) MFC after: 2 weeks Revision Changes Path 1.3 +19 -11 src/usr.bin/sed/TEST/sed.test From owner-cvs-src@FreeBSD.ORG Tue Jul 22 12:23:46 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E64A37B401; Tue, 22 Jul 2003 12:23:46 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C0B943FA3; Tue, 22 Jul 2003 12:23:46 -0700 (PDT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MJNj0U009449; Tue, 22 Jul 2003 12:23:45 -0700 (PDT) (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MJNjIU009448; Tue, 22 Jul 2003 12:23:45 -0700 (PDT) Message-Id: <200307221923.h6MJNjIU009448@repoman.freebsd.org> From: Diomidis Spinellis Date: Tue, 22 Jul 2003 12:23:45 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/sed sed.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 19:23:46 -0000 dds 2003/07/22 12:23:45 PDT FreeBSD src repository Modified files: usr.bin/sed sed.1 Log: Fixed .Nm element, updated HISTORY section, added AUTHORS section. Reviewed by: schweikh (mentor) MFC after: 2 weeks Revision Changes Path 1.30 +6 -2 src/usr.bin/sed/sed.1 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 12:33:37 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D706337B401; Tue, 22 Jul 2003 12:33:37 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 743FF43FA3; Tue, 22 Jul 2003 12:33:37 -0700 (PDT) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MJXb0U009842; Tue, 22 Jul 2003 12:33:37 -0700 (PDT) (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MJXbaG009841; Tue, 22 Jul 2003 12:33:37 -0700 (PDT) Message-Id: <200307221933.h6MJXbaG009841@repoman.freebsd.org> From: Mike Silbersack Date: Tue, 22 Jul 2003 12:33:37 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/sys mbuf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 19:33:38 -0000 silby 2003/07/22 12:33:37 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/sys mbuf.h Log: Improve the verbosity of the "freeing free cluster" KASSERT, and add a new KASSERT that checks to see if a cluster's refcount is 0 in MCLALLOC. Revision Changes Path 1.44.2.20 +6 -1 src/sys/sys/mbuf.h From owner-cvs-src@FreeBSD.ORG Tue Jul 22 13:19:53 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB87D37B401 for ; Tue, 22 Jul 2003 13:19:53 -0700 (PDT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9157143F85 for ; Tue, 22 Jul 2003 13:19:52 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from athlon.pn.xcllnt.net (athlon.pn.xcllnt.net [192.168.4.3]) by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6MKJJwO015170; Tue, 22 Jul 2003 13:19:19 -0700 (PDT) (envelope-from marcel@piii.pn.xcllnt.net) Received: from athlon.pn.xcllnt.net (localhost [127.0.0.1]) by athlon.pn.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6MKJJw9042362; Tue, 22 Jul 2003 13:19:19 -0700 (PDT) (envelope-from marcel@athlon.pn.xcllnt.net) Received: (from marcel@localhost) by athlon.pn.xcllnt.net (8.12.9/8.12.9/Submit) id h6MKJIKq042361; Tue, 22 Jul 2003 13:19:18 -0700 (PDT) (envelope-from marcel) Date: Tue, 22 Jul 2003 13:19:18 -0700 From: Marcel Moolenaar To: "Alan L. Cox" Message-ID: <20030722201918.GA1052@athlon.pn.xcllnt.net> References: <200307221024.h6MAOggG066724@repoman.freebsd.org> <20030722093443.GD58118@technokratis.com> <20030723003823.R8380@gamplex.bde.org> <20030722112901.GA59012@technokratis.com> <20030722155139.GA39123@troutmask.apl.washington.edu> <3F1D8858.670C08B2@imimic.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F1D8858.670C08B2@imimic.com> User-Agent: Mutt/1.5.4i cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 20:19:54 -0000 On Tue, Jul 22, 2003 at 01:54:16PM -0500, Alan L. Cox wrote: > > > > `-finline-limit=N' > > By default, gcc limits the size of functions that can be inlined. > > This flag allows the control of this limit for functions that are > > explicitly marked as inline (i.e., marked with the inline keyword > > or defined within the class definition in c++). N is the size of > > functions that can be inlined in number of pseudo instructions > > (not counting parameter handling). The default value of N is 600. > > Increasing this value can result in more inlined code at the cost > > of compilation time and memory consumption. Decreasing usually > > > > There is another way. The following example illustrates its use. > > static int vm_object_backing_scan(vm_object_t object, int op) > __attribute__((always_inline)); I hope we can come up with a scheme that allows us to control inlining on a per-platform basis. Current events demonstrate pretty good how people treat optimizations (which inlining is) as machine independent fodder and how easy it is to generalize beyond sensibility. Unfortunately, the use of an expression-like syntax (inline or __attribute__ keyword) makes this harder than with a statement- like syntax (like #pragma), because of the 2-D space (platforms vs functions). -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Tue Jul 22 13:21:49 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 36F3537B401; Tue, 22 Jul 2003 13:21:49 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9BD043FA3; Tue, 22 Jul 2003 13:21:48 -0700 (PDT) (envelope-from roberto@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MKLm0U018004; Tue, 22 Jul 2003 13:21:48 -0700 (PDT) (envelope-from roberto@repoman.freebsd.org) Received: (from roberto@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MKLmlF018003; Tue, 22 Jul 2003 13:21:48 -0700 (PDT) Message-Id: <200307222021.h6MKLmlF018003@repoman.freebsd.org> From: Ollivier Robert Date: Tue, 22 Jul 2003 13:21:48 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 20:21:49 -0000 roberto 2003/07/22 13:21:48 PDT FreeBSD src repository Modified files: . access Log: Null commit to notify that Thomas Quinot (thomas@) doesn't need mentoring anymore. Thansk for all your work and keep it up. You've been a nice mentee :-) Revision Changes Path 1.607 +0 -0 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Tue Jul 22 13:27:06 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 04B2437B401; Tue, 22 Jul 2003 13:27:06 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id D2AE443F75; Tue, 22 Jul 2003 13:27:04 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MKQwV3020936; Tue, 22 Jul 2003 20:26:58 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MKQv5H015049; Tue, 22 Jul 2003 22:26:57 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Marcel Moolenaar From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 13:19:18 PDT." <20030722201918.GA1052@athlon.pn.xcllnt.net> Date: Tue, 22 Jul 2003 22:26:57 +0200 Message-ID: <15048.1058905617@critter.freebsd.dk> cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 20:27:06 -0000 In message <20030722201918.GA1052@athlon.pn.xcllnt.net>, Marcel Moolenaar write s: >I hope we can come up with a scheme that allows us to control >inlining on a per-platform basis. What GCC needs is the "auxillary info file" concept like the old MW compiler had, a file where you wrote hints to the optimizer and supressed warnings. If I remember right you could silence warnings by file+line or function+line, and you could specify various properties by global_name or function+local_name. That would allow us to keep different files for different archs... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 13:54:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9BD6437B401; Tue, 22 Jul 2003 13:54:27 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3935943F93; Tue, 22 Jul 2003 13:54:27 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MKsQ0U019189; Tue, 22 Jul 2003 13:54:26 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MKsQLX019188; Tue, 22 Jul 2003 13:54:26 -0700 (PDT) Message-Id: <200307222054.h6MKsQLX019188@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 22 Jul 2003 13:54:26 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 20:54:28 -0000 phk 2003/07/22 13:54:26 PDT FreeBSD src repository Modified files: sys/vm swap_pager.c Log: Remove all but one of the inlines here, this reduces the code size by 2032 bytes and has no measurable impact on performance. Revision Changes Path 1.210 +9 -10 src/sys/vm/swap_pager.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 13:59:44 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D7D637B401 for ; Tue, 22 Jul 2003 13:59:44 -0700 (PDT) Received: from mail26d.sbc-webhosting.com (mail26d.sbc-webhosting.com [216.173.237.167]) by mx1.FreeBSD.org (Postfix) with SMTP id 0D2A343F3F for ; Tue, 22 Jul 2003 13:59:43 -0700 (PDT) (envelope-from alc@imimic.com) Received: from www.imimic.com (64.143.12.21)1-0799337576; Tue, 22 Jul 2003 16:59:36 -0400 (EDT) Sender: alc@FreeBSD.ORG Message-ID: <3F1DA5B9.A877E8D9@imimic.com> Date: Tue, 22 Jul 2003 15:59:37 -0500 From: "Alan L. Cox" Organization: iMimic Networking, Inc. X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386) X-Accept-Language: en MIME-Version: 1.0 To: Marcel Moolenaar References: <200307221024.h6MAOggG066724@repoman.freebsd.org> <20030722093443.GD58118@technokratis.com> <20030723003823.R8380@gamplex.bde.org> <20030722112901.GA59012@technokratis.com> <20030722155139.GA39123@troutmask.apl.washington.edu> <3F1D8858.670C08B2@imimic.com> <20030722201918.GA1052@athlon.pn.xcllnt.net> Content-Type: text/plain; charset=x-user-defined Content-Transfer-Encoding: 7bit X-Loop-Detect: 1 cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 20:59:44 -0000 Marcel Moolenaar wrote: > > On Tue, Jul 22, 2003 at 01:54:16PM -0500, Alan L. Cox wrote: > > > > > > `-finline-limit=N' > > > By default, gcc limits the size of functions that can be inlined. > > > This flag allows the control of this limit for functions that are > > > explicitly marked as inline (i.e., marked with the inline keyword > > > or defined within the class definition in c++). N is the size of > > > functions that can be inlined in number of pseudo instructions > > > (not counting parameter handling). The default value of N is 600. > > > Increasing this value can result in more inlined code at the cost > > > of compilation time and memory consumption. Decreasing usually > > > > > > > There is another way. The following example illustrates its use. > > > > static int vm_object_backing_scan(vm_object_t object, int op) > > __attribute__((always_inline)); > > I hope we can come up with a scheme that allows us to control > inlining on a per-platform basis. Current events demonstrate > pretty good how people treat optimizations (which inlining is) > as machine independent fodder and how easy it is to generalize > beyond sensibility. > Unfortunately, the use of an expression-like syntax (inline or > __attribute__ keyword) makes this harder than with a statement- > like syntax (like #pragma), because of the 2-D space (platforms > vs functions). > I chose my example very carefully... In the case of vm_object_backing_scan(), I could argue that "always inline" is correct regardless of platform. This function was written with inlining as an expectation. It looks something like this: vm_object_backing_scan(..., int op) { ... if (op == "constant #1") ... else if (op == "constant #2") ... Furthermore, all call sites pass a constant as the value for op. Consequently, if the code is inlined, all but the relevent case are removed as dead code. I also recall this idiom being used in the i386 pmap. I suspect that gcc fails to inline this code because it makes the inline vs. no-inline decision before it does dead code elimination. Regards, Alan From owner-cvs-src@FreeBSD.ORG Tue Jul 22 14:01:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6852337B401; Tue, 22 Jul 2003 14:01:33 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A71343F85; Tue, 22 Jul 2003 14:01:31 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.9/8.12.3) with ESMTP id h6ML1TFL051689; Tue, 22 Jul 2003 15:01:30 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 22 Jul 2003 15:01:20 -0600 (MDT) Message-Id: <20030722.150120.118025104.imp@bsdimp.com> To: sam@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200307212320.h6LNKfE2012354@repoman.freebsd.org> References: <200307212320.h6LNKfE2012354@repoman.freebsd.org> X-Mailer: Mew version 2.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/wi if_wi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 21:01:33 -0000 In message: <200307212320.h6LNKfE2012354@repoman.freebsd.org> Sam Leffler writes: : o Add monitor mode support. This tested fine with prism cards but may require : newer lucent/hermes firmware than indicated (investigating). I'm committing : this now since it shouldn't hurt anything. Only certain versions of lucent/hermes firmware have this. 6.10 was said not to have it, 6.30 was said to have it, and 5.xx and 8.xx are known not to have it. Warner From owner-cvs-src@FreeBSD.ORG Tue Jul 22 14:18:46 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 68B2837B401; Tue, 22 Jul 2003 14:18:46 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B84B43FB1; Tue, 22 Jul 2003 14:18:45 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.9/8.12.3) with ESMTP id h6MLIZFL051755; Tue, 22 Jul 2003 15:18:36 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 22 Jul 2003 15:18:28 -0600 (MDT) Message-Id: <20030722.151828.83724752.imp@bsdimp.com> To: das@freebsd.org From: "M. Warner Losh" In-Reply-To: <20030722163007.GA6080@HAL9000.homeunix.com> References: <20030722235600.X8165@gamplex.bde.org> <11951.1058884091@critter.freebsd.dk> <20030722163007.GA6080@HAL9000.homeunix.com> X-Mailer: Mew version 2.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: phk@phk.freebsd.dk cc: src-committers@freebsd.org cc: bde@zeta.org.au cc: paul@freebsd-services.com cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 21:18:46 -0000 In message: <20030722163007.GA6080@HAL9000.homeunix.com> David Schultz writes: : There is reason for concern about cases where inline really is : misused, either because it massively increases code size or : because it is unimportant to performance and detracts from : debuggability. But I would not like to see a policy that shifts : the burden of proof onto authors of new code.[1] A policy about : gratuitous sweeps through other people's code, on the other : hand... There's one other place that we use inlining. We use it to make sure that modules do not contain references to certain symbols. For example: /* * make this inline so that we don't have to worry about dangling references * to it in the modules or the code. */ static __inline const struct pccard_product * pccard_product_lookup(device_t dev, const struct pccard_product *tab, size_t ent_size, pccard_product_match_fn matchfn) { return CARD_DO_PRODUCT_LOOKUP(device_get_parent(dev), dev, tab, ent_size, matchfn); } We do this to get the type safty of the function call and not have to make that a macro. We do *NOT* want references to pccard_product_lookup, but the CARD_DO_.. kobj call allows the indirection that makes it possible to use the same module in kernels with and without pccard support. This isn't either of the performance or size trade-offs. It is a design decision to use inline over #define. If the new gcc breaks this, then it becomes a #define... Warner From owner-cvs-src@FreeBSD.ORG Tue Jul 22 14:21:43 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AE3E37B401; Tue, 22 Jul 2003 14:21:43 -0700 (PDT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D37A43F3F; Tue, 22 Jul 2003 14:21:42 -0700 (PDT) (envelope-from sam@errno.com) Received: from melange.errno.com (melange.errno.com [66.127.85.82]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.9) with ESMTP id h6MLLc7N036417 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Tue, 22 Jul 2003 14:21:40 -0700 (PDT) (envelope-from sam@errno.com) Date: Tue, 22 Jul 2003 14:21:38 -0700 From: Sam Leffler To: "M. Warner Losh" Message-ID: <346809425.1058883698@melange.errno.com> In-Reply-To: <20030722.150120.118025104.imp@bsdimp.com> References: <200307212320.h6LNKfE2012354@repoman.freebsd.org> <20030722.150120.118025104.imp@bsdimp.com> X-Mailer: Mulberry/3.0.3 (Win32) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/wi if_wi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 21:21:43 -0000 > In message: <200307212320.h6LNKfE2012354@repoman.freebsd.org> > Sam Leffler writes: > : o Add monitor mode support. This tested fine with prism cards but > may require : newer lucent/hermes firmware than indicated > (investigating). I'm committing : this now since it shouldn't hurt > anything. > > Only certain versions of lucent/hermes firmware have this. 6.10 was > said not to have it, 6.30 was said to have it, and 5.xx and 8.xx are > known not to have it. I can verify 6.10 does not have it. Unfortunately I'm having trouble loading new firmware to verify/not verify other versions. The original author of the change for Lucent-specific bits says 8.10 works but hasn't tested other versions. I'd like to narrow the firmware revs to only enable this for known-good revs but that may take a bunch of work... Sam From owner-cvs-src@FreeBSD.ORG Tue Jul 22 14:23:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DFA737B401; Tue, 22 Jul 2003 14:23:02 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C055843FAF; Tue, 22 Jul 2003 14:23:01 -0700 (PDT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MLN10U021238; Tue, 22 Jul 2003 14:23:01 -0700 (PDT) (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MLN1qm021237; Tue, 22 Jul 2003 14:23:01 -0700 (PDT) Message-Id: <200307222123.h6MLN1qm021237@repoman.freebsd.org> From: Diomidis Spinellis Date: Tue, 22 Jul 2003 14:23:01 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/defaults pccard.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 21:23:02 -0000 dds 2003/07/22 14:23:01 PDT FreeBSD src repository Modified files: etc/defaults pccard.conf Log: Added entry for Billionton LM5LT-10N Fixed small typo Reviewed by: imp Approved by: imp Revision Changes Path 1.262 +8 -1 src/etc/defaults/pccard.conf From owner-cvs-src@FreeBSD.ORG Tue Jul 22 14:23:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E21737B401; Tue, 22 Jul 2003 14:23:30 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6AE7243FBF; Tue, 22 Jul 2003 14:23:29 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id EF8DB2A8B2; Tue, 22 Jul 2003 14:23:28 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Marcel Moolenaar In-Reply-To: <20030722201918.GA1052@athlon.pn.xcllnt.net> Date: Tue, 22 Jul 2003 14:23:28 -0700 From: Peter Wemm Message-Id: <20030722212328.EF8DB2A8B2@canning.wemm.org> cc: "Alan L. Cox" cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 21:23:30 -0000 Marcel Moolenaar wrote: > On Tue, Jul 22, 2003 at 01:54:16PM -0500, Alan L. Cox wrote: > > > > > > `-finline-limit=N' > > > By default, gcc limits the size of functions that can be inlined. > > > This flag allows the control of this limit for functions that are > > > explicitly marked as inline (i.e., marked with the inline keyword > > > or defined within the class definition in c++). N is the size of > > > functions that can be inlined in number of pseudo instructions > > > (not counting parameter handling). The default value of N is 600. > > > Increasing this value can result in more inlined code at the cost > > > of compilation time and memory consumption. Decreasing usually > > > > > > > There is another way. The following example illustrates its use. > > > > static int vm_object_backing_scan(vm_object_t object, int op) > > __attribute__((always_inline)); > > I hope we can come up with a scheme that allows us to control > inlining on a per-platform basis. Current events demonstrate > pretty good how people treat optimizations (which inlining is) > as machine independent fodder and how easy it is to generalize > beyond sensibility. > Unfortunately, the use of an expression-like syntax (inline or > __attribute__ keyword) makes this harder than with a statement- > like syntax (like #pragma), because of the 2-D space (platforms > vs functions). Sure, but we're also limited by what the compiler provides. gcc should probably provide #pragma hooks as a way to set the equivalent of things like 'cc --param max-inline-insns-single=2400', but as far as I'm aware, it doesn't. For what its worth, if we use __attribute__((always_inline)), it should be #define __always_inline__ __attribute__((__always_inline__)) and declare functions as int foo(int bar) __always_inline__; so that we can avoid embedding more gcc-isms in such a way that isn't trivial to #define away. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 14:28:53 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C362737B401; Tue, 22 Jul 2003 14:28:53 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 62A5E43FB1; Tue, 22 Jul 2003 14:28:53 -0700 (PDT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MLSr0U021465; Tue, 22 Jul 2003 14:28:53 -0700 (PDT) (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MLSr1P021464; Tue, 22 Jul 2003 14:28:53 -0700 (PDT) Message-Id: <200307222128.h6MLSr1P021464@repoman.freebsd.org> From: Paul Saab Date: Tue, 22 Jul 2003 14:28:53 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 21:28:54 -0000 ps 2003/07/22 14:28:53 PDT FreeBSD src repository Modified files: . access Log: Welcome Atul Mukker from LSI. He'll be taking over for Eric Moore in maintaing the amr driver and other stuff. Approved by: core (ages ago) Revision Changes Path 1.608 +1 -0 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Tue Jul 22 14:30:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DAA0F37B405; Tue, 22 Jul 2003 14:30:29 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC72243FA3; Tue, 22 Jul 2003 14:30:28 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 76A9E2A7EA; Tue, 22 Jul 2003 14:30:28 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: "Alan L. Cox" In-Reply-To: <3F1DA5B9.A877E8D9@imimic.com> Date: Tue, 22 Jul 2003 14:30:28 -0700 From: Peter Wemm Message-Id: <20030722213028.76A9E2A7EA@canning.wemm.org> cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 21:30:30 -0000 "Alan L. Cox" wrote: > Marcel Moolenaar wrote: > > > > On Tue, Jul 22, 2003 at 01:54:16PM -0500, Alan L. Cox wrote: > > > > > > > > `-finline-limit=N' > > > > By default, gcc limits the size of functions that can be inlined. > > > > This flag allows the control of this limit for functions that are > > > > explicitly marked as inline (i.e., marked with the inline keyword > > > > or defined within the class definition in c++). N is the size of > > > > functions that can be inlined in number of pseudo instructions > > > > (not counting parameter handling). The default value of N is 600. > > > > Increasing this value can result in more inlined code at the cost > > > > of compilation time and memory consumption. Decreasing usually > > > > > > > > > > There is another way. The following example illustrates its use. > > > > > > static int vm_object_backing_scan(vm_object_t object, int op) > > > __attribute__((always_inline)); > > > > I hope we can come up with a scheme that allows us to control > > inlining on a per-platform basis. Current events demonstrate > > pretty good how people treat optimizations (which inlining is) > > as machine independent fodder and how easy it is to generalize > > beyond sensibility. > > Unfortunately, the use of an expression-like syntax (inline or > > __attribute__ keyword) makes this harder than with a statement- > > like syntax (like #pragma), because of the 2-D space (platforms > > vs functions). > > > > I chose my example very carefully... > > In the case of vm_object_backing_scan(), I could argue that "always > inline" is correct regardless of platform. This function was written > with inlining as an expectation. It looks something like this: > > vm_object_backing_scan(..., int op) > { > ... > if (op == "constant #1") > ... > else if (op == "constant #2") > ... > > Furthermore, all call sites pass a constant as the value for op. > Consequently, if the code is inlined, all but the relevent case are > removed as dead code. > > I also recall this idiom being used in the i386 pmap. > > I suspect that gcc fails to inline this code because it makes the inline > vs. no-inline decision before it does dead code elimination. Yes, your suspicion is correct. It does its estimation before any optimization, dead code elimination, etc. Alexander mentioned the exact way it does it, but its something like "instruction_estimate = (number of C keywords + some parser stuff) * 10".. so all the do { } while (0) stuff counts as ~100 instructions in the estimate. A KOBJ call is estimated at (I think Alexander mentioned) 571 instructions instead of a couple. The bad thing here is that since ~gcc-3.1, all these inlines have been silently turned off without warning. This might explain some of the stack issues with kobj/newbus/etc on the expensive function call architectures. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 14:33:08 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E272737B401; Tue, 22 Jul 2003 14:33:08 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id D3F2E43F75; Tue, 22 Jul 2003 14:33:07 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MLX1V3024117; Tue, 22 Jul 2003 21:33:01 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MLWw5H015382; Tue, 22 Jul 2003 23:33:00 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: "Alan L. Cox" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 15:59:37 CDT." <3F1DA5B9.A877E8D9@imimic.com> Date: Tue, 22 Jul 2003 23:32:58 +0200 Message-ID: <15381.1058909578@critter.freebsd.dk> cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 21:33:09 -0000 In message <3F1DA5B9.A877E8D9@imimic.com>, "Alan L. Cox" writes: >I chose my example very carefully... There are several issues here Alan, and let us try to keep them separated to the extent possible, the two main issues are: 1. Should GCC _always_ respect when we put __inline in the the source code ? 2. When should we put __inline in the source code ? The fact that GCC silently has been ignoring __inline in the past means that a fair number of the __inlines we have in the tree have had no effect. Examining the worst of the __inlines in the tree also indicates that GCC does in fact have a much better idea about the consequence of inlining than at least some of our programmers. In particular people seem to overlook recursive expansion of newbus, busdma, VOP and KOBJ inside their inline functions. But the fact that GCC has been ignoring the inline request is not the same as they wouldn't have an effect (positive or negative) if respected, it merely means that we have not by other means noticed that they had no effect. In other words, all inlines which GCC currently complains about are highly suspect from a performance point of view, which also, ipso facto means that while the heuristics of GCC may not be optimal, it has nontheless handed us a list of suspect pieces of source code which we should evaluate carefully. To take your example vm_object_backing_scan(), lets run it through the mill: GCC has until now ignored the request to inline this function, and neither you, I nor anybody else noticed that (Well, OK... Bruce may have noticed :-) Now GCC tells us that it ignores it, and we want to make an informed decision if we want to force it to be inlined or if GCC was right, after all. Your reasoning about common and constant subexpression elimination is a very reasonable and convincing argument for inlining it. Compiling the file with and without the inline, and forcing GCC to respect the inline finds: text data bss dec hex filename inlined: 17408 76 420 17904 45f0 vm_object.o regular: 14944 76 420 15440 3c50 vm_object.o ----- 2464 At least I find that 2k+ code is a non-trivial amount which is likely, through prefetch and cache flushing, to have a negative performance impact. Given two conflicting arguments, we need to resort to reality for the answer, and what we need to reinstate the inline on an informed basis is a realistic benchmark which indicates a positive performance impact of the (respected) inline request. Until we have that benchmark, the inline has been removed because that retains the status quo and puts us closer to being able to get the kernel -Werror again (by raising the inline-limit) without bloating the kernel text segment with 100k+ produced by inlines which may not be beneficial. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 14:34:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D74537B401; Tue, 22 Jul 2003 14:34:10 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DD7243FA3; Tue, 22 Jul 2003 14:34:08 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.9/8.12.3) with ESMTP id h6MLY0FL051900; Tue, 22 Jul 2003 15:34:00 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 22 Jul 2003 15:33:51 -0600 (MDT) Message-Id: <20030722.153351.56335621.imp@bsdimp.com> To: sam@errno.com From: "M. Warner Losh" In-Reply-To: <346809425.1058883698@melange.errno.com> References: <200307212320.h6LNKfE2012354@repoman.freebsd.org> <20030722.150120.118025104.imp@bsdimp.com> <346809425.1058883698@melange.errno.com> X-Mailer: Mew version 2.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/wi if_wi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 21:34:11 -0000 In message: <346809425.1058883698@melange.errno.com> Sam Leffler writes: : > In message: <200307212320.h6LNKfE2012354@repoman.freebsd.org> : > Sam Leffler writes: : > : o Add monitor mode support. This tested fine with prism cards but : > may require : newer lucent/hermes firmware than indicated : > (investigating). I'm committing : this now since it shouldn't hurt : > anything. : > : > Only certain versions of lucent/hermes firmware have this. 6.10 was : > said not to have it, 6.30 was said to have it, and 5.xx and 8.xx are : > known not to have it. : : I can verify 6.10 does not have it. Unfortunately I'm having trouble : loading new firmware to verify/not verify other versions. The original : author of the change for Lucent-specific bits says 8.10 works but hasn't : tested other versions. I'd like to narrow the firmware revs to only enable : this for known-good revs but that may take a bunch of work... I can't find the web page now that had this information. It was considered a 'bug' in the firmware and removed. Warner From owner-cvs-src@FreeBSD.ORG Tue Jul 22 14:40:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 322F437B407 for ; Tue, 22 Jul 2003 14:40:18 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id C372843F93 for ; Tue, 22 Jul 2003 14:40:16 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MLeFV3024316; Tue, 22 Jul 2003 21:40:15 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MLeE5H015674; Tue, 22 Jul 2003 23:40:15 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: "M. Warner Losh" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 15:18:28 MDT." <20030722.151828.83724752.imp@bsdimp.com> Date: Tue, 22 Jul 2003 23:40:14 +0200 Message-ID: <15673.1058910014@critter.freebsd.dk> cc: src-committers@FreeBSD.org cc: bde@zeta.org.au cc: paul@freebsd-services.com cc: cvs-src@FreeBSD.org cc: das@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 21:40:18 -0000 In message <20030722.151828.83724752.imp@bsdimp.com>, "M. Warner Losh" writes: >There's one other place that we use inlining. We use it to make sure >that modules do not contain references to certain symbols. For >example: > >/* > * make this inline so that we don't have to worry about dangling references > * to it in the modules or the code. > */ >static __inline const struct pccard_product * >pccard_product_lookup(device_t dev, const struct pccard_product *tab, > size_t ent_size, pccard_product_match_fn matchfn) >{ > return CARD_DO_PRODUCT_LOOKUP(device_get_parent(dev), dev, > tab, ent_size, matchfn); >} > >We do this to get the type safty of the function call and not have to >make that a macro. We do *NOT* want references to >pccard_product_lookup, but the CARD_DO_.. kobj call allows the >indirection that makes it possible to use the same module in kernels >with and without pccard support. I would argue that this should be solved by giving non-pccard kernels a stub function which returns whatever error is logical (NULL in this case ?) rather than abusing either of macros or inlines. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 14:58:36 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 105CE37B404 for ; Tue, 22 Jul 2003 14:58:36 -0700 (PDT) Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216]) by mx1.FreeBSD.org (Postfix) with ESMTP id B5BE443FBD for ; Tue, 22 Jul 2003 14:58:33 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 26222 invoked from network); 22 Jul 2003 21:58:32 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 22 Jul 2003 21:58:32 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6MLwPGI043549; Tue, 22 Jul 2003 17:58:27 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030722.151828.83724752.imp@bsdimp.com> Date: Tue, 22 Jul 2003 17:58:42 -0400 (EDT) From: John Baldwin To: "M. Warner Losh" cc: phk@phk.freebsd.dk cc: src-committers@freebsd.org cc: bde@zeta.org.au cc: paul@freebsd-services.com cc: cvs-src@freebsd.org cc: das@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 21:58:36 -0000 On 22-Jul-2003 M. Warner Losh wrote: > In message: <20030722163007.GA6080@HAL9000.homeunix.com> > David Schultz writes: >: There is reason for concern about cases where inline really is >: misused, either because it massively increases code size or >: because it is unimportant to performance and detracts from >: debuggability. But I would not like to see a policy that shifts >: the burden of proof onto authors of new code.[1] A policy about >: gratuitous sweeps through other people's code, on the other >: hand... > > There's one other place that we use inlining. We use it to make sure > that modules do not contain references to certain symbols. For > example: > > /* > * make this inline so that we don't have to worry about dangling references > * to it in the modules or the code. > */ > static __inline const struct pccard_product * > pccard_product_lookup(device_t dev, const struct pccard_product *tab, > size_t ent_size, pccard_product_match_fn matchfn) > { > return CARD_DO_PRODUCT_LOOKUP(device_get_parent(dev), dev, > tab, ent_size, matchfn); > } > > We do this to get the type safty of the function call and not have to > make that a macro. We do *NOT* want references to > pccard_product_lookup, but the CARD_DO_.. kobj call allows the > indirection that makes it possible to use the same module in kernels > with and without pccard support. > > This isn't either of the performance or size trade-offs. It is a > design decision to use inline over #define. If the new gcc breaks > this, then it becomes a #define... I think that this is a bandaid solution though. Ideally if you load a device driver, it really contains several modules: one base module for the base code and one module for each bus attachment. The base attachment must link for the load to complete, but if a bus attachment doesn't link due to missing symbols because that bus isn't present in the kernel, it's not an error. At least that's how I think it should work. The acpi module already has this issue now that it calls pci and isa functions. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Tue Jul 22 15:39:15 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C02EB37B404 for ; Tue, 22 Jul 2003 15:39:15 -0700 (PDT) Received: from mail26a.sbc-webhosting.com (mail26a.sbc-webhosting.com [216.173.237.164]) by mx1.FreeBSD.org (Postfix) with SMTP id CD22143F93 for ; Tue, 22 Jul 2003 15:39:13 -0700 (PDT) (envelope-from alc@imimic.com) Received: from www.imimic.com (64.143.12.21)4-0539423539; Tue, 22 Jul 2003 18:38:59 -0400 (EDT) Sender: alc@FreeBSD.ORG Message-ID: <3F1DBD05.A4886D5E@imimic.com> Date: Tue, 22 Jul 2003 17:39:01 -0500 From: "Alan L. Cox" Organization: iMimic Networking, Inc. X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386) X-Accept-Language: en MIME-Version: 1.0 To: Poul-Henning Kamp References: <15381.1058909578@critter.freebsd.dk> Content-Type: text/plain; charset=x-user-defined Content-Transfer-Encoding: 7bit X-Loop-Detect: 1 cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 22:39:16 -0000 Poul-Henning Kamp wrote: > > In message <3F1DA5B9.A877E8D9@imimic.com>, "Alan L. Cox" writes: > > >I chose my example very carefully... > ... > To take your example vm_object_backing_scan(), lets run it through > the mill: > > GCC has until now ignored the request to inline this function, and > neither you, I nor anybody else noticed that (Well, OK... Bruce > may have noticed :-) Now GCC tells us that it ignores it, and we > want to make an informed decision if we want to force it to be > inlined or if GCC was right, after all. I've known about this for several months. :-) (That's why I knew about the "always inline" directive.) > Your reasoning about common and constant subexpression elimination > is a very reasonable and convincing argument for inlining it. > > Compiling the file with and without the inline, and forcing GCC > to respect the inline finds: > > text data bss dec hex filename > inlined: 17408 76 420 17904 45f0 vm_object.o > regular: 14944 76 420 15440 3c50 vm_object.o > ----- > 2464 > > At least I find that 2k+ code is a non-trivial amount which is > likely, through prefetch and cache flushing, to have a negative > performance impact. > > Given two conflicting arguments, we need to resort to reality for > the answer, and what we need to reinstate the inline on an informed > basis is a realistic benchmark which indicates a positive performance > impact of the (respected) inline request. > > Until we have that benchmark, the inline has been removed because > that retains the status quo and puts us closer to being able to get > the kernel -Werror again (by raising the inline-limit) without > bloating the kernel text segment with 100k+ produced by inlines > which may not be beneficial. > In general, I agree with you that a vast majority of the inlines should be removed. We should, however, have an override for exceptional cases. Again, in the case of vm_object_backing_scan(), code size is a bad predictor of inlining's effect. Inlining is being used to achieve a form of code specialization that will actually reduce the size of the code that is *executed*. In conclusion, my point is not that you should stop what you're doing. It is rather that there are exceptional cases where gcc is doing the wrong thing and we should have an override to force inlining that can be applied. Alan From owner-cvs-src@FreeBSD.ORG Tue Jul 22 15:40:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 26E1437B405; Tue, 22 Jul 2003 15:40:02 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D61C43F3F; Tue, 22 Jul 2003 15:40:00 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.9/8.12.3) with ESMTP id h6MMdvFL052383; Tue, 22 Jul 2003 16:39:57 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 22 Jul 2003 16:39:46 -0600 (MDT) Message-Id: <20030722.163946.94245610.imp@bsdimp.com> To: phk@phk.freebsd.dk From: "M. Warner Losh" In-Reply-To: <15673.1058910014@critter.freebsd.dk> References: <20030722.151828.83724752.imp@bsdimp.com> <15673.1058910014@critter.freebsd.dk> X-Mailer: Mew version 2.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: src-committers@FreeBSD.org cc: bde@zeta.org.au cc: paul@freebsd-services.com cc: cvs-src@FreeBSD.org cc: das@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 22:40:02 -0000 In message: <15673.1058910014@critter.freebsd.dk> "Poul-Henning Kamp" writes: : In message <20030722.151828.83724752.imp@bsdimp.com>, "M. Warner Losh" writes: : : >There's one other place that we use inlining. We use it to make sure : >that modules do not contain references to certain symbols. For : >example: : > : >/* : > * make this inline so that we don't have to worry about dangling references : > * to it in the modules or the code. : > */ : >static __inline const struct pccard_product * : >pccard_product_lookup(device_t dev, const struct pccard_product *tab, : > size_t ent_size, pccard_product_match_fn matchfn) : >{ : > return CARD_DO_PRODUCT_LOOKUP(device_get_parent(dev), dev, : > tab, ent_size, matchfn); : >} : > : >We do this to get the type safty of the function call and not have to : >make that a macro. We do *NOT* want references to : >pccard_product_lookup, but the CARD_DO_.. kobj call allows the : >indirection that makes it possible to use the same module in kernels : >with and without pccard support. : : I would argue that this should be solved by giving non-pccard kernels : a stub function which returns whatever error is logical (NULL in this : case ?) rather than abusing either of macros or inlines. There's no convenient way to do that, to be honest. Easy to say, hard to do. And you need it for pci, eisa, isa and other things. And it doesn't let you then load pccard after boot. I don't think it is a viable solution. Warner From owner-cvs-src@FreeBSD.ORG Tue Jul 22 15:44:17 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 55DC937B401; Tue, 22 Jul 2003 15:44:17 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0673143FB1; Tue, 22 Jul 2003 15:43:44 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.9/8.12.3) with ESMTP id h6MMgWFL052417; Tue, 22 Jul 2003 16:42:32 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 22 Jul 2003 16:42:23 -0600 (MDT) Message-Id: <20030722.164223.00776481.imp@bsdimp.com> To: jhb@FreeBSD.org From: "M. Warner Losh" In-Reply-To: References: <20030722.151828.83724752.imp@bsdimp.com> X-Mailer: Mew version 2.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: bde@zeta.org.au cc: paul@freebsd-services.com cc: cvs-src@FreeBSD.org cc: das@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 22:44:18 -0000 In message: John Baldwin writes: : : On 22-Jul-2003 M. Warner Losh wrote: : > In message: <20030722163007.GA6080@HAL9000.homeunix.com> : > David Schultz writes: : >: There is reason for concern about cases where inline really is : >: misused, either because it massively increases code size or : >: because it is unimportant to performance and detracts from : >: debuggability. But I would not like to see a policy that shifts : >: the burden of proof onto authors of new code.[1] A policy about : >: gratuitous sweeps through other people's code, on the other : >: hand... : > : > There's one other place that we use inlining. We use it to make sure : > that modules do not contain references to certain symbols. For : > example: : > : > /* : > * make this inline so that we don't have to worry about dangling references : > * to it in the modules or the code. : > */ : > static __inline const struct pccard_product * : > pccard_product_lookup(device_t dev, const struct pccard_product *tab, : > size_t ent_size, pccard_product_match_fn matchfn) : > { : > return CARD_DO_PRODUCT_LOOKUP(device_get_parent(dev), dev, : > tab, ent_size, matchfn); : > } : > : > We do this to get the type safty of the function call and not have to : > make that a macro. We do *NOT* want references to : > pccard_product_lookup, but the CARD_DO_.. kobj call allows the : > indirection that makes it possible to use the same module in kernels : > with and without pccard support. : > : > This isn't either of the performance or size trade-offs. It is a : > design decision to use inline over #define. If the new gcc breaks : > this, then it becomes a #define... : : I think that this is a bandaid solution though. Ideally if you : load a device driver, it really contains several modules: one base : module for the base code and one module for each bus attachment. : The base attachment must link for the load to complete, but if a : bus attachment doesn't link due to missing symbols because that : bus isn't present in the kernel, it's not an error. At least that's : how I think it should work. The acpi module already has this issue : now that it calls pci and isa functions. I tried playing with that, but it is also a hard problem. You then have strong ordering issues, which makes it hard to unload pccard and reload it w/o unloading all things that depend on it. Eg, I don't want to have to unload the if_wi_pccard driver when I want to unload and reload pccard.ko. Warner From owner-cvs-src@FreeBSD.ORG Tue Jul 22 15:53:07 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A56FD37B401 for ; Tue, 22 Jul 2003 15:53:07 -0700 (PDT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 51CD743F85 for ; Tue, 22 Jul 2003 15:53:06 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from athlon.pn.xcllnt.net (athlon.pn.xcllnt.net [192.168.4.3]) by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6MMqfwO015923; Tue, 22 Jul 2003 15:52:41 -0700 (PDT) (envelope-from marcel@piii.pn.xcllnt.net) Received: from athlon.pn.xcllnt.net (localhost [127.0.0.1]) by athlon.pn.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6MMqfw9061557; Tue, 22 Jul 2003 15:52:41 -0700 (PDT) (envelope-from marcel@athlon.pn.xcllnt.net) Received: (from marcel@localhost) by athlon.pn.xcllnt.net (8.12.9/8.12.9/Submit) id h6MMqfTG061556; Tue, 22 Jul 2003 15:52:41 -0700 (PDT) (envelope-from marcel) Date: Tue, 22 Jul 2003 15:52:41 -0700 From: Marcel Moolenaar To: Poul-Henning Kamp Message-ID: <20030722225241.GA61493@athlon.pn.xcllnt.net> References: <3F1DA5B9.A877E8D9@imimic.com> <15381.1058909578@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15381.1058909578@critter.freebsd.dk> User-Agent: Mutt/1.5.4i cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 22:53:08 -0000 On Tue, Jul 22, 2003 at 11:32:58PM +0200, Poul-Henning Kamp wrote: > > text data bss dec hex filename > inlined: 17408 76 420 17904 45f0 vm_object.o > regular: 14944 76 420 15440 3c50 vm_object.o > ----- > 2464 > > At least I find that 2k+ code is a non-trivial amount which is > likely, through prefetch and cache flushing, to have a negative > performance impact. Oh? vm_object_backing_scan() has 3 call-sites. Each of the call-sites has numerous calls to other functions that may or may not be predicted right, prefetched right or mess up the instruction or unified caches. While the inlined code yields a larger amount of text, I find it hard to claim that this by itself overshadows the performance advantages of increased ILP, improved scheduling due to dead-code elimination, better cache behaviour due to increased locality, branch misprediction avoidance, call overhead avoidance, or just plain better PRE (partial redundant expression elimination), GCM (global code motion), GVN (global value numbering) or RA (register allocation). Although I do support the removal of the inline keyword to allow -Werror again and also to provide a sensible (though pessimistic) starting point for reintroducing some of them, I do not think there's any ground to use performance gains or losses to defend the removal of the inline keyword without also providing the results of measurements performed on all platforms (ok, all tier 1 platforms). -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Tue Jul 22 15:56:46 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94E3E37B401; Tue, 22 Jul 2003 15:56:46 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3396B43FA3; Tue, 22 Jul 2003 15:56:43 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MMuZV3030549; Tue, 22 Jul 2003 22:56:35 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MMuY5H016120; Wed, 23 Jul 2003 00:56:34 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: "Alan L. Cox" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 17:39:01 CDT." <3F1DBD05.A4886D5E@imimic.com> Date: Wed, 23 Jul 2003 00:56:34 +0200 Message-ID: <16119.1058914594@critter.freebsd.dk> cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 22:56:46 -0000 In message <3F1DBD05.A4886D5E@imimic.com>, "Alan L. Cox" writes: >Poul-Henning Kamp wrote: >> Compiling the file with and without the inline, and forcing GCC >> to respect the inline finds: >> >> text data bss dec hex filename >> inlined: 17408 76 420 17904 45f0 vm_object.o >> regular: 14944 76 420 15440 3c50 vm_object.o >> ----- >> 2464 >> >Again, in the case of vm_object_backing_scan(), code size is a >bad predictor of inlining's effect. Inlining is being used to achieve a >form of code specialization that will actually reduce the size of the >code that is *executed*. 00001ef0 t vm_object_backing_scan 000023e0 t vm_object_qcollapse The non-inlined function is 1264 bytes, it is inlined 3 times, so best case you have saved up to 1328 bytes from being (mostly) branched over. On the other hand, you have 2464 bytes to cache rather than 1264 bytes to cache. If you had said "I ran a benchmark and it is in fact faster" that would make me conceeded right away. >In conclusion, my point is not that you should stop what you're doing. >It is rather that there are exceptional cases where gcc is doing the >wrong thing and we should have an override to force inlining that can be >applied. I agree that there are exceptional cases, I agree that we need some sort of __inline_damnit, but I still request that we only used it when we know for a fact that there is an actual benefit. And the only two criteria I think are trivial to use for proving an actual benefit is: 1. less code is generated. 2. it runs faster in tests. I am very reluctant to accept "a speculated benefit" when there is as strong a counter indication as 2k extra code segment. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:06:22 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F77A37B401; Tue, 22 Jul 2003 16:06:22 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 234E243FB1; Tue, 22 Jul 2003 16:06:21 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MN6EV3030824; Tue, 22 Jul 2003 23:06:14 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MN6D5H016269; Wed, 23 Jul 2003 01:06:13 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Marcel Moolenaar From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 15:52:41 PDT." <20030722225241.GA61493@athlon.pn.xcllnt.net> Date: Wed, 23 Jul 2003 01:06:12 +0200 Message-ID: <16268.1058915172@critter.freebsd.dk> cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:06:22 -0000 In message <20030722225241.GA61493@athlon.pn.xcllnt.net>, Marcel Moolenaar writ es: >vm_object_backing_scan() has 3 call-sites. Each of the call-sites >has numerous calls to other functions that may or may not be >predicted right, prefetched right or mess up the instruction or >unified caches. While the inlined code yields a larger amount of >text, I find it hard to claim that this by itself overshadows the >performance advantages of increased ILP, improved scheduling due >to dead-code elimination, better cache behaviour due to increased >locality, branch misprediction avoidance, call overhead avoidance, >or just plain better PRE (partial redundant expression elimination), >GCM (global code motion), GVN (global value numbering) or RA >(register allocation). The crucial point here is that nobody seems to have actually run any performance test on this, and the complexity is clearly way out of the "feynmann method" solution space. >Although I do support the removal of the inline keyword to allow >-Werror again and also to provide a sensible (though pessimistic) >starting point for reintroducing some of them, I do not think >there's any ground to use performance gains or losses to defend >the removal of the inline keyword without also providing the >results of measurements performed on all platforms (ok, all tier >1 platforms). The reason it was removed was, as I said earlier, to retain the status quo (since GCC had ignored it). We're arguing what it will take to actually start inlining that function. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:07:55 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 17FCE37B401 for ; Tue, 22 Jul 2003 16:07:55 -0700 (PDT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 452A943FB1 for ; Tue, 22 Jul 2003 16:07:54 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from athlon.pn.xcllnt.net (athlon.pn.xcllnt.net [192.168.4.3]) by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6MN7VwO015996; Tue, 22 Jul 2003 16:07:31 -0700 (PDT) (envelope-from marcel@piii.pn.xcllnt.net) Received: from athlon.pn.xcllnt.net (localhost [127.0.0.1]) by athlon.pn.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6MN7Vw9061606; Tue, 22 Jul 2003 16:07:31 -0700 (PDT) (envelope-from marcel@athlon.pn.xcllnt.net) Received: (from marcel@localhost) by athlon.pn.xcllnt.net (8.12.9/8.12.9/Submit) id h6MN7VO4061605; Tue, 22 Jul 2003 16:07:31 -0700 (PDT) (envelope-from marcel) Date: Tue, 22 Jul 2003 16:07:31 -0700 From: Marcel Moolenaar To: Poul-Henning Kamp Message-ID: <20030722230731.GB61493@athlon.pn.xcllnt.net> References: <3F1DBD05.A4886D5E@imimic.com> <16119.1058914594@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16119.1058914594@critter.freebsd.dk> User-Agent: Mutt/1.5.4i cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:07:55 -0000 On Wed, Jul 23, 2003 at 12:56:34AM +0200, Poul-Henning Kamp wrote: > > And the only two criteria I think are trivial to use for proving an > actual benefit is: > 1. less code is generated. > 2. it runs faster in tests. criterium 1 is the worst possible. Only criterium 2 makes sense. ia64 specifically moves all the hard work to the compiler. It's not unsurprising that a normal -O yields marginal performance. Only when one takes advantage of speculation, prefetching and optimization techniques that increase ILP (which most of the time imply code expansion -- loop unrolling, inlining, code duplication) will you see a performance increase. The old gcc metric of less code is better has been demonstrated to not work in general nowadays. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:12:20 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BCCED37B401; Tue, 22 Jul 2003 16:12:20 -0700 (PDT) Received: from godel.mtl.distributel.net (nat.MTL.distributel.NET [66.38.181.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB63543F75; Tue, 22 Jul 2003 16:12:19 -0700 (PDT) (envelope-from bmilekic@technokratis.com) Received: from godel.mtl.distributel.net (localhost [127.0.0.1]) h6MJGMEH062222; Tue, 22 Jul 2003 19:16:22 GMT (envelope-from bmilekic@technokratis.com) Received: (from bmilekic@localhost) by godel.mtl.distributel.net (8.12.9/8.12.9/Submit) id h6MJGMPF062221; Tue, 22 Jul 2003 19:16:22 GMT X-Authentication-Warning: godel.mtl.distributel.net: bmilekic set sender to bmilekic@technokratis.com using -f Date: Tue, 22 Jul 2003 19:16:22 +0000 From: Bosko Milekic To: Poul-Henning Kamp Message-ID: <20030722191622.GA61992@technokratis.com> References: <3F1DBD05.A4886D5E@imimic.com> <16119.1058914594@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16119.1058914594@critter.freebsd.dk> User-Agent: Mutt/1.4.1i cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Steve Kargl cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:12:21 -0000 On Wed, Jul 23, 2003 at 12:56:34AM +0200, Poul-Henning Kamp wrote: ... > I agree that there are exceptional cases, I agree that we need some > sort of __inline_damnit, but I still request that we only used it when > we know for a fact that there is an actual benefit. > > And the only two criteria I think are trivial to use for proving an > actual benefit is: > 1. less code is generated. > 2. it runs faster in tests. > > I am very reluctant to accept "a speculated benefit" when there is > as strong a counter indication as 2k extra code segment. What about the example I (and Bruce) posted in the other thread? That example does not necessarily meet your criteria but it certainly is valid as it minimizes code duplication and does not necessarily impact badly on performance (think of a case where the tradeoff between having it as a function call or inlined in a couple of places is evened out). > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. -- Bosko Milekic * bmilekic@technokratis.com * bmilekic@FreeBSD.org TECHNOkRATIS Consulting Services * http://www.technokratis.com/ From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:14:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2F09337B401; Tue, 22 Jul 2003 16:14:33 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C21A843F85; Tue, 22 Jul 2003 16:14:32 -0700 (PDT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MNEW0U027474; Tue, 22 Jul 2003 16:14:32 -0700 (PDT) (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MNEWmc027473; Tue, 22 Jul 2003 16:14:32 -0700 (PDT) Message-Id: <200307222314.h6MNEWmc027473@repoman.freebsd.org> From: Warner Losh Date: Tue, 22 Jul 2003 16:14:32 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys cdefs.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:14:33 -0000 imp 2003/07/22 16:14:32 PDT FreeBSD src repository Modified files: sys/sys cdefs.h Log: There is strong reason to believe that gcc 4 will also support __attribute__((__nonnull__(x)), assume it so. Revision Changes Path 1.73 +1 -1 src/sys/sys/cdefs.h From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:17:03 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4EB437B401; Tue, 22 Jul 2003 16:17:03 -0700 (PDT) Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net [66.199.86.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 01CC943FAF; Tue, 22 Jul 2003 16:17:01 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: from HAL9000.homeunix.com (localhost [127.0.0.1]) by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h6MNGvhC010079; Tue, 22 Jul 2003 16:16:57 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h6MNGuUm010078; Tue, 22 Jul 2003 16:16:56 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Tue, 22 Jul 2003 16:16:56 -0700 From: David Schultz To: Poul-Henning Kamp Message-ID: <20030722231656.GA9715@HAL9000.homeunix.com> Mail-Followup-To: Poul-Henning Kamp , "Alan L. Cox" , Marcel Moolenaar , Steve Kargl , Bosko Milekic , Bruce Evans , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <3F1DA5B9.A877E8D9@imimic.com> <15381.1058909578@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15381.1058909578@critter.freebsd.dk> cc: "Alan L. Cox" cc: src-committers@FreeBSD.ORG cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.ORG cc: Steve Kargl cc: cvs-all@FreeBSD.ORG cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:17:04 -0000 On Tue, Jul 22, 2003, Poul-Henning Kamp wrote: > Compiling the file with and without the inline, and forcing GCC > to respect the inline finds: > > text data bss dec hex filename > inlined: 17408 76 420 17904 45f0 vm_object.o > regular: 14944 76 420 15440 3c50 vm_object.o > ----- > 2464 > > At least I find that 2k+ code is a non-trivial amount which is > likely, through prefetch and cache flushing, to have a negative > performance impact. There's a reason I used this example earlier also. ;-) vm_object_backing_scan() is basically a template function that gets instantiated into several variants that have a little bit of code in common. For a given VM object, control will pass to only one instance of the inline function, so you likely won't get better temporal locality by un-inlining it. Moreover, the un-inlined version is actually much larger than any of the inlined instances due to (lack of) constant propagation / dead code elimination, so it could potentially blow out your ICACHE all by itself. But I think the main performance hit here is actually going to be all the branches that can no longer be optimized out of the inner loop that iterates over all the pages in the object. > Given two conflicting arguments, we need to resort to reality for > the answer, and what we need to reinstate the inline on an informed > basis is a realistic benchmark which indicates a positive performance > impact of the (respected) inline request. We're in agreement here, except that I believe the burden of proof should be on the person going around and removing others' inlines. I think that in this case, inlining will help by a very modest amount, but I could be wrong. Without proof to the contrary, I think it's safest in general to assume that the original author knew what he was doing (but see below). > There are several issues here Alan, and let us try to keep them > separated to the extent possible, the two main issues are: > > 1. Should GCC _always_ respect when we put __inline in the the source > code ? It's really ugly to have to say __always_inline in some places and __inline in others. I think the programmer should get what he asks for when he says __inline, because the vast majority of FreeBSD committers are smarter than gcc. [Insert cynical reply here.] gcc's feature of refusing to inline large functions isn't even designed to reduce code size. It's a kludge to prevent gcc from falling off a big-O cliff when attempting to compile huge functions---perhaps a response to some inane compiler benchmark. > 2. When should we put __inline in the source code ? This is the more important question to me. Undoubtedly __inline has been abused, but I'd rather see a real person fix them than the compiler. It shouldn't be too difficult to compile the kernel with and without -fno-inline and compare the object file sizes. There will be a few cases where it is obviously right to inline, and a few cases where it is obviously wrong. In most of the remaining cases, such as vm_object_backing_scan(), the difference between inlining or not will be far enough into the noise that only careful benchmarking can provide a good answer. Actually, it might be interesting to make a list of all the functions in the kernel that contain inline calls sorted by the bytes of bloat. Then for all those grey areas, developers could be asked to look at the list and reconsider their use of inlines, and you wouldn't have to waste your talent trying to evaluate each one. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:18:14 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C0D937B401; Tue, 22 Jul 2003 16:18:14 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6062243F85; Tue, 22 Jul 2003 16:18:13 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MNI9V3030991; Tue, 22 Jul 2003 23:18:09 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MNI75H016373; Wed, 23 Jul 2003 01:18:08 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Marcel Moolenaar From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 16:07:31 PDT." <20030722230731.GB61493@athlon.pn.xcllnt.net> Date: Wed, 23 Jul 2003 01:18:07 +0200 Message-ID: <16372.1058915887@critter.freebsd.dk> cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:18:14 -0000 In message <20030722230731.GB61493@athlon.pn.xcllnt.net>, Marcel Moolenaar writ es: >On Wed, Jul 23, 2003 at 12:56:34AM +0200, Poul-Henning Kamp wrote: >> >> And the only two criteria I think are trivial to use for proving an >> actual benefit is: >> 1. less code is generated. >> 2. it runs faster in tests. > >criterium 1 is the worst possible. Only criterium 2 makes sense. No, if inlining a functions results in less code overall it also, ipso facto results in faster execution. Ie: A calls B bytes instructions in target function C bytes to setup args to target function D bytes target function overhead (stack frame etc) Not inlined: X = A * C + D + B Inlined Y = A * C - optimizations + inlining overhead If Y < X, then you have by definition a performance gain. ...even on highy ornamental CPUs like Convex vector engines and the ia64. >The old gcc metric of less code is better has been demonstrated >to not work in general nowadays. Make sure you don't compare apples with oranges. We are not talking about what kinds of optimizations the compiler performs, we are talking about the code you give it to perform on. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:28:35 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8870437B401; Tue, 22 Jul 2003 16:28:35 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 62DBD43F3F; Tue, 22 Jul 2003 16:28:34 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MNSPV3031128; Tue, 22 Jul 2003 23:28:25 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MNSO5H016475; Wed, 23 Jul 2003 01:28:24 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: David Schultz From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 16:16:56 PDT." <20030722231656.GA9715@HAL9000.homeunix.com> Date: Wed, 23 Jul 2003 01:28:24 +0200 Message-ID: <16474.1058916504@critter.freebsd.dk> cc: "Alan L. Cox" cc: src-committers@FreeBSD.ORG cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.ORG cc: Steve Kargl cc: cvs-all@FreeBSD.ORG cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:28:36 -0000 In message <20030722231656.GA9715@HAL9000.homeunix.com>, David Schultz writes: Please remember that the problem at hand is getting -Werror back on the kernel so we can catch issues like the warning in umtx. We could either do that by lobotomizing the warning in the compiler or by setting the limit high enough to inline everything so marked. Since the warning has indeed pointed out a fair number of bogus inlines, the first option did not seem attractive. >Actually, it might be interesting to make a list of all the >functions in the kernel that contain inline calls sorted by the >bytes of bloat. Then for all those grey areas, developers could >be asked to look at the list and reconsider their use of inlines, >and you wouldn't have to waste your talent trying to evaluate each one. This is more or less what I have been spending my day doing, only I used the GCC metric as indication to target the most likely offenders. My experiments have shown that if we had just raised the limit high enough to inline everything that we have marked as inline, the GENERIC kernel text segment would have grown by more than 100 k. The inlines I have removed today have all been inlines which GCC has previously ignored and which added significant code segment size, typically 2k+. You can see some of my raw data here: http://phk/misc/inline.txt The first table should be self explanatory. The table at the bottom has three fields: last limit where GCC refused the inlining name of functions calls to funcion. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:30:49 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 551AB37B401; Tue, 22 Jul 2003 16:30:49 -0700 (PDT) Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net [66.199.86.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DECE43F93; Tue, 22 Jul 2003 16:30:48 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: from HAL9000.homeunix.com (localhost [127.0.0.1]) by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h6MNUlhC010157; Tue, 22 Jul 2003 16:30:47 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h6MNUlIu010156; Tue, 22 Jul 2003 16:30:47 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Tue, 22 Jul 2003 16:30:47 -0700 From: David Schultz To: Poul-Henning Kamp Message-ID: <20030722233047.GB9715@HAL9000.homeunix.com> Mail-Followup-To: Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200307222054.h6MKsQLX019188@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307222054.h6MKsQLX019188@repoman.freebsd.org> cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:30:49 -0000 On Tue, Jul 22, 2003, Poul-Henning Kamp wrote: > Remove all but one of the inlines here, this reduces the code size by > 2032 bytes and has no measurable impact on performance. Whew! This is far less contentious than your last commit, mostly since swap performance isn't critical. There's actually no good reason for swp_pager_force_pagein() to be inline, either, but it can't hurt given that there's only one call site. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:32:59 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C11037B401; Tue, 22 Jul 2003 16:32:59 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id D04AC43FBF; Tue, 22 Jul 2003 16:32:58 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 6913E2A7EA; Tue, 22 Jul 2003 16:32:58 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: "Poul-Henning Kamp" In-Reply-To: <16372.1058915887@critter.freebsd.dk> Date: Tue, 22 Jul 2003 16:32:58 -0700 From: Peter Wemm Message-Id: <20030722233258.6913E2A7EA@canning.wemm.org> cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:32:59 -0000 "Poul-Henning Kamp" wrote: > If Y < X, then you have by definition a performance gain. Only if you look at the classic model where you ignore things like speculation and assume that every instruction is executed exactly once etc. Mainframe optimization strategy is not necessarily applicable to to contemporary cpus. To consider: - costs of branches and branch prediction hits and misses - cache effects - memory bandwidth effects. eg: uninlining the VOP_* stuff costs a ~5% world slowdown due to extra memory IO for argument processing on i386. - speculative execution - not all the code is executed and so on. If adding 2K of code to the kernel for 3 inlines means that the fast path execution through the extra code is in fact faster in the usual case, then its worth it. We dont have to execute or cache all of that extra 2K of code. cache line granularity and hardware prefetch is limited to 64 or 128 bytes for a reason. I suspect Alan Cox already knows the answer to 'which is faster' in the vm_object_backing_scan() case and he's waiting for you to put your foot in it. :-) Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:39:53 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 78AED37B401 for ; Tue, 22 Jul 2003 16:39:50 -0700 (PDT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B2CD43F93 for ; Tue, 22 Jul 2003 16:39:49 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from athlon.pn.xcllnt.net (athlon.pn.xcllnt.net [192.168.4.3]) by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6MNdOwO016196; Tue, 22 Jul 2003 16:39:24 -0700 (PDT) (envelope-from marcel@piii.pn.xcllnt.net) Received: from athlon.pn.xcllnt.net (localhost [127.0.0.1]) by athlon.pn.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6MNdNw9061681; Tue, 22 Jul 2003 16:39:23 -0700 (PDT) (envelope-from marcel@athlon.pn.xcllnt.net) Received: (from marcel@localhost) by athlon.pn.xcllnt.net (8.12.9/8.12.9/Submit) id h6MNdNOD061680; Tue, 22 Jul 2003 16:39:23 -0700 (PDT) (envelope-from marcel) Date: Tue, 22 Jul 2003 16:39:23 -0700 From: Marcel Moolenaar To: Poul-Henning Kamp Message-ID: <20030722233923.GD61493@athlon.pn.xcllnt.net> References: <20030722230731.GB61493@athlon.pn.xcllnt.net> <16372.1058915887@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16372.1058915887@critter.freebsd.dk> User-Agent: Mutt/1.5.4i cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:39:53 -0000 On Wed, Jul 23, 2003 at 01:18:07AM +0200, Poul-Henning Kamp wrote: > In message <20030722230731.GB61493@athlon.pn.xcllnt.net>, Marcel Moolenaar writ > es: > >On Wed, Jul 23, 2003 at 12:56:34AM +0200, Poul-Henning Kamp wrote: > >> > >> And the only two criteria I think are trivial to use for proving an > >> actual benefit is: > >> 1. less code is generated. > >> 2. it runs faster in tests. > > > >criterium 1 is the worst possible. Only criterium 2 makes sense. > > No, if inlining a functions results in less code overall it also, > ipso facto results in faster execution. Proof it. I can give a counter example to show that I seriously doubt this statement: Inlining a function that has only 1 caller, and the call is on a cold path (ie a nested if or else that's almost never executed) can create an interference with the hot path by virtue of increasing branch distances (over the inlined code -- cache interference) or due to code commoning or code motion or simply because the compiler picks the wrong heuristic for edge weights, because the almost never executed code is larger and is chosen as the more important of the if-then-else cases. The non-inlined code is likely to be larger due to the call-site and function prologue and epilogue, but can easily yield better performance do it being out of the way of the common path. Inlining cold code hardly ever benefits, no matter how much it decreases the overall code size. It all boils down to locality: the prime characteristic that makes caches work. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:43:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4523D37B401; Tue, 22 Jul 2003 16:43:30 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 04E5B43F75; Tue, 22 Jul 2003 16:43:29 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MNhOV3031330; Tue, 22 Jul 2003 23:43:24 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MNhN5H016643; Wed, 23 Jul 2003 01:43:23 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Peter Wemm From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 16:32:58 PDT." <20030722233258.6913E2A7EA@canning.wemm.org> Date: Wed, 23 Jul 2003 01:43:23 +0200 Message-ID: <16642.1058917403@critter.freebsd.dk> cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:43:30 -0000 In message <20030722233258.6913E2A7EA@canning.wemm.org>, Peter Wemm writes: >"Poul-Henning Kamp" wrote: > >> If Y < X, then you have by definition a performance gain. > >Only if you look at the classic model where you ignore things like >speculation and assume that every instruction is executed exactly once etc. >Mainframe optimization strategy is not necessarily applicable to to >contemporary cpus. You overinterpret now. My criteria #1 says: If inlining a function reduces the code size, it is by definition beneficial. It does not say anything about what happens when you removing an inline, and it does not say what happens when inlining increases the code size. It only says that if you can reduce the code size by adding an inline request, then you are on right track, and will not have to run further benchmarks to prove that it is beneficial. There can be corner cases where this in fact hurts your performance, for instance by expanding a function of non-executed code in a much repeated loop, but I certainly trust that you wouldn't even think about inlining the function in the first place then. >I suspect Alan Cox already knows the answer to 'which is faster' in >the vm_object_backing_scan() case and he's waiting for you to put your foot >in it. :-) So far he has not said "I actually measured it", despite having had several good chances to do so :-) I think we all, me included, have to admit that we have seldom if ever actually benchmarked or even just checked the size impact of the inlines we have put in, mostly we have relied on our intuition to determine where an inline made sense. And now GCC has told us that we were wrong in some number of the cases and that should prompt us to trust our intuition a little bit less and rely more on actual facts instead. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:49:13 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A9E637B401; Tue, 22 Jul 2003 16:49:13 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7277643F3F; Tue, 22 Jul 2003 16:49:12 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MNn8V3031415; Tue, 22 Jul 2003 23:49:08 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MNn75H016722; Wed, 23 Jul 2003 01:49:07 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Marcel Moolenaar From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 16:39:23 PDT." <20030722233923.GD61493@athlon.pn.xcllnt.net> Date: Wed, 23 Jul 2003 01:49:06 +0200 Message-ID: <16721.1058917746@critter.freebsd.dk> cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:49:13 -0000 In message <20030722233923.GD61493@athlon.pn.xcllnt.net>, Marcel Moolenaar writ es: >On Wed, Jul 23, 2003 at 01:18:07AM +0200, Poul-Henning Kamp wrote: >> In message <20030722230731.GB61493@athlon.pn.xcllnt.net>, Marcel Moolenaar writ >> es: >> >On Wed, Jul 23, 2003 at 12:56:34AM +0200, Poul-Henning Kamp wrote: >> >> >> >> And the only two criteria I think are trivial to use for proving an >> >> actual benefit is: >> >> 1. less code is generated. >> >> 2. it runs faster in tests. >> > >> >criterium 1 is the worst possible. Only criterium 2 makes sense. >> >> No, if inlining a functions results in less code overall it also, >> ipso facto results in faster execution. > >Proof it. I can give a counter example to show that I seriously >doubt this statement: > >Inlining a function that has only 1 caller, and the call is on >a cold path (ie a nested if or else that's almost never executed) Why on earth would you even think about inlining in that case ? We are not talking about heuristics for getting the compiler to mindlessly inline functions here. We are talking about the burden of proof the programmer must lift, once he has spotted what he thinks is a promising inline candidate. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:50:34 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3739137B401; Tue, 22 Jul 2003 16:50:34 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C769343FA3; Tue, 22 Jul 2003 16:50:33 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6MNoX0U034159; Tue, 22 Jul 2003 16:50:33 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6MNoXJx034155; Tue, 22 Jul 2003 16:50:33 -0700 (PDT) Message-Id: <200307222350.h6MNoXJx034155@repoman.freebsd.org> From: Peter Wemm Date: Tue, 22 Jul 2003 16:50:33 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys cdefs.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:50:34 -0000 peter 2003/07/22 16:50:33 PDT FreeBSD src repository Modified files: sys/sys cdefs.h Log: Attempt to preempt any new gcc-ism references to __attribute__((__always_inline__)) by adding an __always_inline macro (used like __dead2 etc). __inline_damnit has also been suggested but we have a precedent of keeping the names similar so they are easier to find. Revision Changes Path 1.74 +6 -0 src/sys/sys/cdefs.h From owner-cvs-src@FreeBSD.ORG Tue Jul 22 16:49:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 244CE37B425; Tue, 22 Jul 2003 16:49:27 -0700 (PDT) Received: from rwcrmhc13.comcast.net (rwcrmhc13.comcast.net [204.127.198.39]) by mx1.FreeBSD.org (Postfix) with ESMTP id 17CF843F3F; Tue, 22 Jul 2003 16:49:25 -0700 (PDT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([12.233.125.100]) by attbi.com (rwcrmhc13) with ESMTP id <2003072223491201500o83moe>; Tue, 22 Jul 2003 23:49:12 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id QAA52894; Tue, 22 Jul 2003 16:49:11 -0700 (PDT) Date: Tue, 22 Jul 2003 16:49:09 -0700 (PDT) From: Julian Elischer To: Poul-Henning Kamp In-Reply-To: <16474.1058916504@critter.freebsd.dk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Mailman-Approved-At: Tue, 22 Jul 2003 16:53:44 -0700 cc: "Alan L. Cox" cc: src-committers@FreeBSD.ORG cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.ORG cc: David Schultz cc: Steve Kargl cc: cvs-all@FreeBSD.ORG cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 23:49:27 -0000 On Wed, 23 Jul 2003, Poul-Henning Kamp wrote: > > You can see some of my raw data here: http://phk/misc/inline.txt > This doesn't resolve... I tried adding a .dk to it but that also fails.. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 17:04:01 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 34B0B37B401; Tue, 22 Jul 2003 17:04:01 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id EEAE143FA3; Tue, 22 Jul 2003 17:03:59 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6N03qV3031667; Wed, 23 Jul 2003 00:03:52 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6N03o5H016832; Wed, 23 Jul 2003 02:03:51 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Julian Elischer From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 16:49:09 PDT." Date: Wed, 23 Jul 2003 02:03:50 +0200 Message-ID: <16831.1058918630@critter.freebsd.dk> X-Mailman-Approved-At: Tue, 22 Jul 2003 17:09:31 -0700 cc: "Alan L. Cox" cc: src-committers@FreeBSD.ORG cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.ORG cc: David Schultz cc: Steve Kargl cc: cvs-all@FreeBSD.ORG cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 00:04:01 -0000 In message , Ju lian Elischer writes: > > >On Wed, 23 Jul 2003, Poul-Henning Kamp wrote: > >> >> You can see some of my raw data here: http://phk/misc/inline.txt >> > >This doesn't resolve... sorry, http://phk.freebsd.dk/misc/inline.txt And while I'm here, let me show you guys the most compelling argument why we should be critical of even trivial uses of __inline. (My apologies to Justin for using his code as an example, it is not meant as a critisism of Justin or his code, I belive we all could have fallen in this trap) If you look in aic79xx_inline.h you will find a family of functions called ahd_in[bwlq]_scbram(). The base text size we have with the inlining is: 100718 4496 0 105214 19afe aic79xx.o then a bug is fixed in ahd_inb_scbram() and due to the cascading effect of the inlines we suddendly find that we have 4976 bytes more code to execute: 105694 4496 0 110190 1ae6e aic79xx.o If on the other hand the bottom function in the cascade, ahd_ibb_scbram() was not inlined in the first place, we would have had before the bugfix: 98878 4496 0 103374 193ce aic79xx.o and and after: 98926 4496 0 103422 193fe aic79xx.o How many of you are actually in the habit of reevaluating if a "harmless bugfix" has any implications in relation to inlining ? That is the sort of thing which makes me belive that unless proven beneficial (by one of the two criteria), inline is harmful. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 17:25:58 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10B0737B401; Tue, 22 Jul 2003 17:25:58 -0700 (PDT) Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net [66.199.86.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 39F1C43F93; Tue, 22 Jul 2003 17:25:57 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from HAL9000.homeunix.com (localhost [127.0.0.1]) by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h6N0PqhC010489; Tue, 22 Jul 2003 17:25:52 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: (from das@localhost) by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h6N0PpIX010488; Tue, 22 Jul 2003 17:25:51 -0700 (PDT) (envelope-from das@FreeBSD.org) Date: Tue, 22 Jul 2003 17:25:51 -0700 From: David Schultz To: Poul-Henning Kamp Message-ID: <20030723002551.GA10353@HAL9000.homeunix.com> Mail-Followup-To: Poul-Henning Kamp , "Alan L. Cox" , Marcel Moolenaar , Steve Kargl , Bosko Milekic , Bruce Evans , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <20030722231656.GA9715@HAL9000.homeunix.com> <16474.1058916504@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16474.1058916504@critter.freebsd.dk> cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 00:25:58 -0000 On Wed, Jul 23, 2003, Poul-Henning Kamp wrote: > In message <20030722231656.GA9715@HAL9000.homeunix.com>, David Schultz writes: > > Please remember that the problem at hand is getting -Werror back > on the kernel so we can catch issues like the warning in umtx. > > We could either do that by lobotomizing the warning in the compiler > or by setting the limit high enough to inline everything so marked. > > Since the warning has indeed pointed out a fair number of bogus > inlines, the first option did not seem attractive. I would just as soon make gcc always inline, and fix the places where the programmer really screwed up. It would be nice if there were a way to get gcc to generate a warning for new code with expensive inlines, but have a way to disable the warning on a case-by-case basis. (I think you mentioned something like this a little while ago.) > >Actually, it might be interesting to make a list of all the > >functions in the kernel that contain inline calls sorted by the > >bytes of bloat. Then for all those grey areas, developers could > >be asked to look at the list and reconsider their use of inlines, > >and you wouldn't have to waste your talent trying to evaluate each one. > > This is more or less what I have been spending my day doing, only > I used the GCC metric as indication to target the most likely > offenders. > > My experiments have shown that if we had just raised the limit high > enough to inline everything that we have marked as inline, the > GENERIC kernel text segment would have grown by more than 100 k. 100K out of a 2 MB text segment isn't necessarily too bad, but it depends where the 100K is. Note that Intel's own compiler inlines fairly aggressively (and even supports partial inlining based on profiling data), and the guys at Intel aren't dummies. Inlining can be quite effective even when it does increase the size of the code, as Peter and others have already discussed. In non-obvious cases, you either have to understand the code in question or do some serious benchmarking. > The inlines I have removed today have all been inlines which GCC > has previously ignored and which added significant code segment > size, typically 2k+. > > You can see some of my raw data here: http://phk/misc/inline.txt Cool. It looks like gcc's estimation of __asm is way off for some reason. I still suggest that you only fix the ones that are obviously wrong and nudge various maintainers about the rest if you really care. A number of people are not convinced that some of the uninlining you've done so far is appropriate or worth your time. Besides, then you don't have to listen to all of us telling you what color to paint the bikeshed. ;-) It would also be interesting to do this sort of analysis in userland, where there is often less concern about performance and more concern about code size. If I finish $realwork before midnight, I'll see if I can come up with a good way to get at raw function sizes for userland with/without inlines and spit out the results in a useful way. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 17:35:15 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E3ADE37B405; Tue, 22 Jul 2003 17:35:15 -0700 (PDT) Received: from skyline.ome.meisei-u.ac.jp (skyline.ome.meisei-u.ac.jp [160.194.0.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2873E43F85; Tue, 22 Jul 2003 17:35:14 -0700 (PDT) (envelope-from root@skyline.ome.meisei-u.ac.jp) Received: from skyline.ome.meisei-u.ac.jp (localhost [127.0.0.1]) id h6N0Z21U016679; Wed, 23 Jul 2003 09:35:02 +0900 (JST) Received: (from root@localhost)h6N0Z1ab016678; Wed, 23 Jul 2003 09:35:01 +0900 (JST) Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) h6N0QaoW059483 for ; Wed, 23 Jul 2003 09:26:37 +0900 (JST) (envelope-from owner-cvs-all@freebsd.org) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 6FCA2564C1; Tue, 22 Jul 2003 17:26:09 -0700 (PDT) (envelope-from owner-cvs-all@freebsd.org) Received: from hub.freebsd.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 0604937B40E; Tue, 22 Jul 2003 17:26:08 -0700 (PDT) Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10B0737B401; Tue, 22 Jul 2003 17:25:58 -0700 (PDT) Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net [66.199.86.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 39F1C43F93; Tue, 22 Jul 2003 17:25:57 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from HAL9000.homeunix.com (localhost [127.0.0.1]) by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h6N0PqhC010489; Tue, 22 Jul 2003 17:25:52 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: (from das@localhost) by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h6N0PpIX010488; Tue, 22 Jul 2003 17:25:51 -0700 (PDT) (envelope-from das@FreeBSD.org) Date: Tue, 22 Jul 2003 17:25:51 -0700 From: David Schultz To: Poul-Henning Kamp Message-ID: <20030723002551.GA10353@HAL9000.homeunix.com> Mail-Followup-To: Poul-Henning Kamp , "Alan L. Cox" , Marcel Moolenaar , Steve Kargl , Bosko Milekic , Bruce Evans , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <20030722231656.GA9715@HAL9000.homeunix.com> <16474.1058916504@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16474.1058916504@critter.freebsd.dk> X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Sender: owner-cvs-all@freebsd.org Errors-To: owner-cvs-all@freebsd.org X-Virus-Scanned: by amavisd-milter (http://amavis.org/) cc: "Alan L. Cox" cc: src-committers@freebsd.org cc: Bosko Milekic cc: Steve Kargl cc: cvs-src@freebsd.org cc: Bruce Evans cc: cvs-all@freebsd.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 00:35:16 -0000 On Wed, Jul 23, 2003, Poul-Henning Kamp wrote: > In message <20030722231656.GA9715@HAL9000.homeunix.com>, David Schultz writes: > > Please remember that the problem at hand is getting -Werror back > on the kernel so we can catch issues like the warning in umtx. > > We could either do that by lobotomizing the warning in the compiler > or by setting the limit high enough to inline everything so marked. > > Since the warning has indeed pointed out a fair number of bogus > inlines, the first option did not seem attractive. I would just as soon make gcc always inline, and fix the places where the programmer really screwed up. It would be nice if there were a way to get gcc to generate a warning for new code with expensive inlines, but have a way to disable the warning on a case-by-case basis. (I think you mentioned something like this a little while ago.) > >Actually, it might be interesting to make a list of all the > >functions in the kernel that contain inline calls sorted by the > >bytes of bloat. Then for all those grey areas, developers could > >be asked to look at the list and reconsider their use of inlines, > >and you wouldn't have to waste your talent trying to evaluate each one. > > This is more or less what I have been spending my day doing, only > I used the GCC metric as indication to target the most likely > offenders. > > My experiments have shown that if we had just raised the limit high > enough to inline everything that we have marked as inline, the > GENERIC kernel text segment would have grown by more than 100 k. 100K out of a 2 MB text segment isn't necessarily too bad, but it depends where the 100K is. Note that Intel's own compiler inlines fairly aggressively (and even supports partial inlining based on profiling data), and the guys at Intel aren't dummies. Inlining can be quite effective even when it does increase the size of the code, as Peter and others have already discussed. In non-obvious cases, you either have to understand the code in question or do some serious benchmarking. > The inlines I have removed today have all been inlines which GCC > has previously ignored and which added significant code segment > size, typically 2k+. > > You can see some of my raw data here: http://phk/misc/inline.txt Cool. It looks like gcc's estimation of __asm is way off for some reason. I still suggest that you only fix the ones that are obviously wrong and nudge various maintainers about the rest if you really care. A number of people are not convinced that some of the uninlining you've done so far is appropriate or worth your time. Besides, then you don't have to listen to all of us telling you what color to paint the bikeshed. ;-) It would also be interesting to do this sort of analysis in userland, where there is often less concern about performance and more concern about code size. If I finish $realwork before midnight, I'll see if I can come up with a good way to get at raw function sizes for userland with/without inlines and spit out the results in a useful way. _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" From owner-cvs-src@FreeBSD.ORG Tue Jul 22 17:36:17 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F0F8D37B401; Tue, 22 Jul 2003 17:36:16 -0700 (PDT) Received: from skyline.ome.meisei-u.ac.jp (skyline.ome.meisei-u.ac.jp [160.194.0.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 93EB743FB1; Tue, 22 Jul 2003 17:36:14 -0700 (PDT) (envelope-from root@skyline.ome.meisei-u.ac.jp) Received: from skyline.ome.meisei-u.ac.jp (localhost [127.0.0.1]) id h6N0aA1U017101; Wed, 23 Jul 2003 09:36:10 +0900 (JST) Received: (from root@localhost)h6N0a9i7017100; Wed, 23 Jul 2003 09:36:09 +0900 (JST) Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by ns.meisei-u.ac.jp (8.12.9/8.12.9) with ESMTP id h6N0QakN065275 for ; Wed, 23 Jul 2003 09:26:36 +0900 (JST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id B7221564F1; Tue, 22 Jul 2003 17:26:09 -0700 (PDT) (envelope-from owner-cvs-all@freebsd.org) Received: from hub.freebsd.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id A0E8237B407; Tue, 22 Jul 2003 17:26:08 -0700 (PDT) Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10B0737B401; Tue, 22 Jul 2003 17:25:58 -0700 (PDT) Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net [66.199.86.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 39F1C43F93; Tue, 22 Jul 2003 17:25:57 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from HAL9000.homeunix.com (localhost [127.0.0.1]) by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h6N0PqhC010489; Tue, 22 Jul 2003 17:25:52 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: (from das@localhost) by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h6N0PpIX010488; Tue, 22 Jul 2003 17:25:51 -0700 (PDT) (envelope-from das@FreeBSD.org) Date: Tue, 22 Jul 2003 17:25:51 -0700 From: David Schultz To: Poul-Henning Kamp Message-ID: <20030723002551.GA10353@HAL9000.homeunix.com> Mail-Followup-To: Poul-Henning Kamp , "Alan L. Cox" , Marcel Moolenaar , Steve Kargl , Bosko Milekic , Bruce Evans , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <20030722231656.GA9715@HAL9000.homeunix.com> <16474.1058916504@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16474.1058916504@critter.freebsd.dk> X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Sender: owner-cvs-all@freebsd.org Errors-To: owner-cvs-all@freebsd.org X-Virus-Scanned: by amavisd-milter (http://amavis.org/) cc: "Alan L. Cox" cc: src-committers@freebsd.org cc: Bosko Milekic cc: Steve Kargl cc: cvs-src@freebsd.org cc: Bruce Evans cc: cvs-all@freebsd.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 00:36:17 -0000 On Wed, Jul 23, 2003, Poul-Henning Kamp wrote: > In message <20030722231656.GA9715@HAL9000.homeunix.com>, David Schultz writes: > > Please remember that the problem at hand is getting -Werror back > on the kernel so we can catch issues like the warning in umtx. > > We could either do that by lobotomizing the warning in the compiler > or by setting the limit high enough to inline everything so marked. > > Since the warning has indeed pointed out a fair number of bogus > inlines, the first option did not seem attractive. I would just as soon make gcc always inline, and fix the places where the programmer really screwed up. It would be nice if there were a way to get gcc to generate a warning for new code with expensive inlines, but have a way to disable the warning on a case-by-case basis. (I think you mentioned something like this a little while ago.) > >Actually, it might be interesting to make a list of all the > >functions in the kernel that contain inline calls sorted by the > >bytes of bloat. Then for all those grey areas, developers could > >be asked to look at the list and reconsider their use of inlines, > >and you wouldn't have to waste your talent trying to evaluate each one. > > This is more or less what I have been spending my day doing, only > I used the GCC metric as indication to target the most likely > offenders. > > My experiments have shown that if we had just raised the limit high > enough to inline everything that we have marked as inline, the > GENERIC kernel text segment would have grown by more than 100 k. 100K out of a 2 MB text segment isn't necessarily too bad, but it depends where the 100K is. Note that Intel's own compiler inlines fairly aggressively (and even supports partial inlining based on profiling data), and the guys at Intel aren't dummies. Inlining can be quite effective even when it does increase the size of the code, as Peter and others have already discussed. In non-obvious cases, you either have to understand the code in question or do some serious benchmarking. > The inlines I have removed today have all been inlines which GCC > has previously ignored and which added significant code segment > size, typically 2k+. > > You can see some of my raw data here: http://phk/misc/inline.txt Cool. It looks like gcc's estimation of __asm is way off for some reason. I still suggest that you only fix the ones that are obviously wrong and nudge various maintainers about the rest if you really care. A number of people are not convinced that some of the uninlining you've done so far is appropriate or worth your time. Besides, then you don't have to listen to all of us telling you what color to paint the bikeshed. ;-) It would also be interesting to do this sort of analysis in userland, where there is often less concern about performance and more concern about code size. If I finish $realwork before midnight, I'll see if I can come up with a good way to get at raw function sizes for userland with/without inlines and spit out the results in a useful way. _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" From owner-cvs-src@FreeBSD.ORG Tue Jul 22 17:36:29 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6052D37B404; Tue, 22 Jul 2003 17:36:29 -0700 (PDT) Received: from skyline.ome.meisei-u.ac.jp (skyline.ome.meisei-u.ac.jp [160.194.0.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D09443F93; Tue, 22 Jul 2003 17:36:26 -0700 (PDT) (envelope-from root@skyline.ome.meisei-u.ac.jp) Received: from skyline.ome.meisei-u.ac.jp (localhost [127.0.0.1]) id h6N0aL1U017171; Wed, 23 Jul 2003 09:36:21 +0900 (JST) Received: (from root@localhost)h6N0aLYU017170; Wed, 23 Jul 2003 09:36:21 +0900 (JST) Received: from nancy.myaw.ei.meisei-u.ac.jp (nancy.myaw.ei.meisei-u.ac.jp [160.194.103.29]) by ns.meisei-u.ac.jp (8.12.9/8.12.9) with ESMTP id h6N0QbkN065276 for ; Wed, 23 Jul 2003 09:26:37 +0900 (JST) Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) h6N0QaoW059483 for ; Wed, 23 Jul 2003 09:26:37 +0900 (JST) (envelope-from owner-cvs-all@freebsd.org) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 6FCA2564C1; Tue, 22 Jul 2003 17:26:09 -0700 (PDT) (envelope-from owner-cvs-all@freebsd.org) Received: from hub.freebsd.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 0604937B40E; Tue, 22 Jul 2003 17:26:08 -0700 (PDT) Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10B0737B401; Tue, 22 Jul 2003 17:25:58 -0700 (PDT) Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net [66.199.86.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 39F1C43F93; Tue, 22 Jul 2003 17:25:57 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from HAL9000.homeunix.com (localhost [127.0.0.1]) by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h6N0PqhC010489; Tue, 22 Jul 2003 17:25:52 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: (from das@localhost) by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h6N0PpIX010488; Tue, 22 Jul 2003 17:25:51 -0700 (PDT) (envelope-from das@FreeBSD.org) Date: Tue, 22 Jul 2003 17:25:51 -0700 From: David Schultz To: Poul-Henning Kamp Message-ID: <20030723002551.GA10353@HAL9000.homeunix.com> Mail-Followup-To: Poul-Henning Kamp , "Alan L. Cox" , Marcel Moolenaar , Steve Kargl , Bosko Milekic , Bruce Evans , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <20030722231656.GA9715@HAL9000.homeunix.com> <16474.1058916504@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16474.1058916504@critter.freebsd.dk> X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Sender: owner-cvs-all@freebsd.org Errors-To: owner-cvs-all@freebsd.org X-Virus-Scanned: by amavisd-milter (http://amavis.org/) cc: "Alan L. Cox" cc: src-committers@freebsd.org cc: Bosko Milekic cc: Steve Kargl cc: cvs-src@freebsd.org cc: Bruce Evans cc: cvs-all@freebsd.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 00:36:29 -0000 On Wed, Jul 23, 2003, Poul-Henning Kamp wrote: > In message <20030722231656.GA9715@HAL9000.homeunix.com>, David Schultz writes: > > Please remember that the problem at hand is getting -Werror back > on the kernel so we can catch issues like the warning in umtx. > > We could either do that by lobotomizing the warning in the compiler > or by setting the limit high enough to inline everything so marked. > > Since the warning has indeed pointed out a fair number of bogus > inlines, the first option did not seem attractive. I would just as soon make gcc always inline, and fix the places where the programmer really screwed up. It would be nice if there were a way to get gcc to generate a warning for new code with expensive inlines, but have a way to disable the warning on a case-by-case basis. (I think you mentioned something like this a little while ago.) > >Actually, it might be interesting to make a list of all the > >functions in the kernel that contain inline calls sorted by the > >bytes of bloat. Then for all those grey areas, developers could > >be asked to look at the list and reconsider their use of inlines, > >and you wouldn't have to waste your talent trying to evaluate each one. > > This is more or less what I have been spending my day doing, only > I used the GCC metric as indication to target the most likely > offenders. > > My experiments have shown that if we had just raised the limit high > enough to inline everything that we have marked as inline, the > GENERIC kernel text segment would have grown by more than 100 k. 100K out of a 2 MB text segment isn't necessarily too bad, but it depends where the 100K is. Note that Intel's own compiler inlines fairly aggressively (and even supports partial inlining based on profiling data), and the guys at Intel aren't dummies. Inlining can be quite effective even when it does increase the size of the code, as Peter and others have already discussed. In non-obvious cases, you either have to understand the code in question or do some serious benchmarking. > The inlines I have removed today have all been inlines which GCC > has previously ignored and which added significant code segment > size, typically 2k+. > > You can see some of my raw data here: http://phk/misc/inline.txt Cool. It looks like gcc's estimation of __asm is way off for some reason. I still suggest that you only fix the ones that are obviously wrong and nudge various maintainers about the rest if you really care. A number of people are not convinced that some of the uninlining you've done so far is appropriate or worth your time. Besides, then you don't have to listen to all of us telling you what color to paint the bikeshed. ;-) It would also be interesting to do this sort of analysis in userland, where there is often less concern about performance and more concern about code size. If I finish $realwork before midnight, I'll see if I can come up with a good way to get at raw function sizes for userland with/without inlines and spit out the results in a useful way. _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" From owner-cvs-src@FreeBSD.ORG Tue Jul 22 17:32:13 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1355A37B404; Tue, 22 Jul 2003 17:32:13 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7537D43F93; Tue, 22 Jul 2003 17:32:12 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 1606C2A8B2; Tue, 22 Jul 2003 17:32:12 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: "Poul-Henning Kamp" In-Reply-To: <16831.1058918630@critter.freebsd.dk> Date: Tue, 22 Jul 2003 17:32:12 -0700 From: Peter Wemm Message-Id: <20030723003212.1606C2A8B2@canning.wemm.org> X-Mailman-Approved-At: Tue, 22 Jul 2003 17:49:54 -0700 cc: "Alan L. Cox" cc: src-committers@FreeBSD.ORG cc: Bosko Milekic cc: Steve Kargl cc: cvs-src@FreeBSD.ORG cc: David Schultz cc: Marcel Moolenaar cc: Bruce Evans cc: cvs-all@FreeBSD.ORG cc: Julian Elischer Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 00:32:13 -0000 "Poul-Henning Kamp" wrote: > That is the sort of thing which makes me belive that unless proven > beneficial (by one of the two criteria), inline is harmful. There is a great leap there. Just because somebody isn't willing to spend considerable time to re-prove that the runtime improvement is still there to your satisfaction, that doesn't mean that it is harmful. Take the i386 interrupt vector code. Thats an example where it is massively inlined. Having a non-inlined function that does all the calculations and bit shifting is much smaller in code size, but slower at runtime. You have not proven your assertion that smaller code is implicitly faster. It might be more convenient for you to measure, but it doesn't mean anything without the same exhaustive runtime measurement that you would have us do. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 18:07:47 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03A8C37B401; Tue, 22 Jul 2003 18:07:47 -0700 (PDT) Received: from smtp1.server.rpi.edu (smtp1.server.rpi.edu [128.113.2.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E39443F3F; Tue, 22 Jul 2003 18:07:46 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp1.server.rpi.edu (8.12.9/8.12.9) with ESMTP id h6N17i9t012551; Tue, 22 Jul 2003 21:07:44 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20030723003212.1606C2A8B2@canning.wemm.org> References: <20030723003212.1606C2A8B2@canning.wemm.org> Date: Tue, 22 Jul 2003 21:07:42 -0400 To: Peter Wemm From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 01:07:47 -0000 At 5:32 PM -0700 7/22/03, Peter Wemm wrote: > >Take the i386 interrupt vector code. Thats an example where >it is massively inlined. Having a non-inlined function that >does all the calculations and bit shifting is much smaller >in code size, but slower at runtime. If I understand this discussion correctly, then the previous version of gcc (in freebsd-current) was NOT inlining these sections event though we thought it was. Might we expect some performance improvements now that we know to force gcc to inline the functions? -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Tue Jul 22 18:21:23 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E0C337B401 for ; Tue, 22 Jul 2003 18:21:23 -0700 (PDT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB93843F3F for ; Tue, 22 Jul 2003 18:21:20 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from athlon.pn.xcllnt.net (athlon.pn.xcllnt.net [192.168.4.3]) by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6N1KowO016726; Tue, 22 Jul 2003 18:20:50 -0700 (PDT) (envelope-from marcel@piii.pn.xcllnt.net) Received: from athlon.pn.xcllnt.net (localhost [127.0.0.1]) by athlon.pn.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6N1Knw9061945; Tue, 22 Jul 2003 18:20:49 -0700 (PDT) (envelope-from marcel@athlon.pn.xcllnt.net) Received: (from marcel@localhost) by athlon.pn.xcllnt.net (8.12.9/8.12.9/Submit) id h6N1KmiL061944; Tue, 22 Jul 2003 18:20:48 -0700 (PDT) (envelope-from marcel) Date: Tue, 22 Jul 2003 18:20:48 -0700 From: Marcel Moolenaar To: Poul-Henning Kamp Message-ID: <20030723012048.GB61884@athlon.pn.xcllnt.net> References: <20030722233923.GD61493@athlon.pn.xcllnt.net> <16721.1058917746@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16721.1058917746@critter.freebsd.dk> User-Agent: Mutt/1.5.4i cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 01:21:23 -0000 On Wed, Jul 23, 2003 at 01:49:06AM +0200, Poul-Henning Kamp wrote: > >> >On Wed, Jul 23, 2003 at 12:56:34AM +0200, Poul-Henning Kamp wrote: > >> >> > >> >> And the only two criteria I think are trivial to use for proving an > >> >> actual benefit is: > >> >> 1. less code is generated. > >> >> 2. it runs faster in tests. > >> > > >> >criterium 1 is the worst possible. Only criterium 2 makes sense. > >> > >> No, if inlining a functions results in less code overall it also, > >> ipso facto results in faster execution. > > > >Proof it. I can give a counter example to show that I seriously > >doubt this statement: > > > >Inlining a function that has only 1 caller, and the call is on > >a cold path (ie a nested if or else that's almost never executed) > > Why on earth would you even think about inlining in that case ? That's not the point. You make unqualified general statements that smaller code yields faster execution (ipso facto). I give one (trivial) counter example to illustrate where your claim does not trivially hold and ask for proof. Give me the proof or stop spreading FUD. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Tue Jul 22 18:34:43 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 99D0C37B401; Tue, 22 Jul 2003 18:34:43 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 092C043F3F; Tue, 22 Jul 2003 18:34:43 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id DFA102A7EA; Tue, 22 Jul 2003 18:34:42 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Garance A Drosihn In-Reply-To: Date: Tue, 22 Jul 2003 18:34:42 -0700 From: Peter Wemm Message-Id: <20030723013442.DFA102A7EA@canning.wemm.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 01:34:44 -0000 Garance A Drosihn wrote: > At 5:32 PM -0700 7/22/03, Peter Wemm wrote: > > > >Take the i386 interrupt vector code. Thats an example where > >it is massively inlined. Having a non-inlined function that > >does all the calculations and bit shifting is much smaller > >in code size, but slower at runtime. > > If I understand this discussion correctly, then the previous > version of gcc (in freebsd-current) was NOT inlining these > sections event though we thought it was. In some cases, yes, that was happening. Not the interrupt code though because thats generated by hand in assembler. Things like some kobj and VOP_* wrappers were not being inlined as they should be. What has been highlighted is that inline has been abused over time. The argument is how and where to draw the line in cost vs benefit. 'inline' is a hint to the compiler that you believe that the increased code size cost is worth it. The problem is that some inlines were being failed because the gcc cost estimation was happening before optimization and was way out of sync with reality. eg: a reference to curthread blows the estimate out of the water, even though it accounts for 1 or 2 instructions only. The other problem is that many of the original measurements were done years ago by folks who are no longer with us (eg: John Dyson) on hardware that is no longer an accurate representative of current hardware. On the other hand, many of us still use that older hardware and so tuning there is a much bigger issue. eg: my home desktop predates John Dyson leaving. Meanwhile, -Werror is still disabled. We have been sneaking in potentially fatal errors. eg: kern_umtx.c has what looks like a legitimate problem to me, but its lost in the inline noise. > Might we expect some > performance improvements now that we know to force gcc to > inline the functions? Thats an interesting question, isn't it? Somebody had previously measured a 5% slowdown as a result of not inlining the VOP_* function wrappers. I wonder if this is part of the 4.x -> 5.x slowdown that hasn't been resolved yet. I dont know how many VOP_* calls are or are not presently being inlined though. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From owner-cvs-src@FreeBSD.ORG Tue Jul 22 19:11:08 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B877937B401; Tue, 22 Jul 2003 19:11:08 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E4C243F3F; Tue, 22 Jul 2003 19:11:08 -0700 (PDT) (envelope-from deischen@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6N2B80U041919; Tue, 22 Jul 2003 19:11:08 -0700 (PDT) (envelope-from deischen@repoman.freebsd.org) Received: (from deischen@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6N2B8K9041918; Tue, 22 Jul 2003 19:11:08 -0700 (PDT) Message-Id: <200307230211.h6N2B8K9041918@repoman.freebsd.org> From: Daniel Eischen Date: Tue, 22 Jul 2003 19:11:07 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/thread thr_cancel.c thr_cond.c thr_detach.c thr_kern.c thr_mutex.c thr_private.h thr_resume_np.c thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 02:11:09 -0000 deischen 2003/07/22 19:11:07 PDT FreeBSD src repository Modified files: lib/libpthread/thread thr_cancel.c thr_cond.c thr_detach.c thr_kern.c thr_mutex.c thr_private.h thr_resume_np.c thr_sig.c Log: Move idle kse wakeup to outside of regions where locks are held. This eliminates ping-ponging of locks, where the idle KSE wakes up only to find the lock it needs is being held. This gives little or no gain to M:N mode but greatly speeds up 1:1 mode. Reviewed & Tested by: davidxu Revision Changes Path 1.26 +6 -3 src/lib/libpthread/thread/thr_cancel.c 1.48 +8 -2 src/lib/libpthread/thread/thr_cond.c 1.23 +5 -3 src/lib/libpthread/thread/thr_detach.c 1.80 +57 -35 src/lib/libpthread/thread/thr_kern.c 1.39 +12 -6 src/lib/libpthread/thread/thr_mutex.c 1.94 +2 -2 src/lib/libpthread/thread/thr_private.h 1.18 +13 -5 src/lib/libpthread/thread/thr_resume_np.c 1.63 +27 -17 src/lib/libpthread/thread/thr_sig.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 20:08:35 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F13C37B401; Tue, 22 Jul 2003 20:08:35 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8621D43F85; Tue, 22 Jul 2003 20:08:34 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6N38Y0U044819; Tue, 22 Jul 2003 20:08:34 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6N38YAZ044818; Tue, 22 Jul 2003 20:08:34 -0700 (PDT) Message-Id: <200307230308.h6N38YAZ044818@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 22 Jul 2003 20:08:34 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ia64/include _regset.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 03:08:36 -0000 marcel 2003/07/22 20:08:34 PDT FreeBSD src repository Modified files: sys/ia64/include _regset.h Log: We sloppily created an array for the high FP registers (f32-f127), but this just created a weird inconsistency when porting gdb(1). Instead, we name each high FP register seperately, like we do for all the other registers. Revision Changes Path 1.3 +96 -2 src/sys/ia64/include/_regset.h From owner-cvs-src@FreeBSD.ORG Tue Jul 22 21:23:37 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB5E137B401; Tue, 22 Jul 2003 21:23:37 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A82243F85; Tue, 22 Jul 2003 21:23:37 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6N4Nb0U053817; Tue, 22 Jul 2003 21:23:37 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6N4Nbk1053816; Tue, 22 Jul 2003 21:23:37 -0700 (PDT) Message-Id: <200307230423.h6N4Nbk1053816@repoman.freebsd.org> From: Peter Wemm Date: Tue, 22 Jul 2003 21:23:37 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun Makefile src/lib/msun/src math_private.h s_copysignf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 04:23:38 -0000 peter 2003/07/22 21:23:37 PDT FreeBSD src repository Modified files: lib/msun Makefile lib/msun/src math_private.h s_copysignf.c Log: Now that we do not need to do runtime detection for the broken default fp emulator, stop doing the runtime selection of hardware or emulated floating point operations on i386. Note that I have not suppressed the duplicate compiles yet. While here, fix the alpha. It has provided specific copysign/copysignf functions since the beginning of time, but they have never been used. Revision Changes Path 1.31 +7 -4 src/lib/msun/Makefile 1.14 +13 -1 src/lib/msun/src/math_private.h 1.8 +1 -1 src/lib/msun/src/s_copysignf.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 21:25:05 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E5AB37B401; Tue, 22 Jul 2003 21:25:05 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB9ED43F85; Tue, 22 Jul 2003 21:25:04 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6N4P40U053885; Tue, 22 Jul 2003 21:25:04 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6N4P4qX053884; Tue, 22 Jul 2003 21:25:04 -0700 (PDT) Message-Id: <200307230425.h6N4P4qX053884@repoman.freebsd.org> From: Peter Wemm Date: Tue, 22 Jul 2003 21:25:04 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun Makefile src/lib/msun/src get_hw_float.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 04:25:05 -0000 peter 2003/07/22 21:25:04 PDT FreeBSD src repository Modified files: lib/msun Makefile Removed files: lib/msun/src get_hw_float.c Log: No longer need the internal __get_hw_float() function. Revision Changes Path 1.32 +0 -1 src/lib/msun/Makefile 1.5 +0 -50 src/lib/msun/src/get_hw_float.c (dead) From owner-cvs-src@FreeBSD.ORG Tue Jul 22 21:28:52 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B8AE437B401; Tue, 22 Jul 2003 21:28:52 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 53EF143F85; Tue, 22 Jul 2003 21:28:52 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6N4Sq0U054071; Tue, 22 Jul 2003 21:28:52 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6N4Sq15054070; Tue, 22 Jul 2003 21:28:52 -0700 (PDT) Message-Id: <200307230428.h6N4Sq15054070@repoman.freebsd.org> From: Peter Wemm Date: Tue, 22 Jul 2003 21:28:52 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/include asm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 04:28:53 -0000 peter 2003/07/22 21:28:52 PDT FreeBSD src repository Modified files: sys/i386/include asm.h Log: Remove _ARCH_INDIRECT, it was the glue to enable having both hardware and software versions of the floating point code in libm. The runtime selection was done by reading the hw.floatingpoint sysctl via __get_hw_float(). Revision Changes Path 1.12 +0 -67 src/sys/i386/include/asm.h From owner-cvs-src@FreeBSD.ORG Tue Jul 22 21:53:48 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E201437B401; Tue, 22 Jul 2003 21:53:48 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F87443FA3; Tue, 22 Jul 2003 21:53:48 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6N4rm0U055102; Tue, 22 Jul 2003 21:53:48 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6N4rl2h055101; Tue, 22 Jul 2003 21:53:47 -0700 (PDT) Message-Id: <200307230453.h6N4rl2h055101@repoman.freebsd.org> From: Peter Wemm Date: Tue, 22 Jul 2003 21:53:47 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun Makefile src/lib/msun/src e_acos.c e_asin.c e_atan2.c e_exp.c e_fmod.c e_log.c e_log10.c e_remainder.c e_scalb.c e_sqrt.c math_private.h s_atan.c s_ceil.c... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 04:53:49 -0000 peter 2003/07/22 21:53:47 PDT FreeBSD src repository Modified files: lib/msun Makefile lib/msun/src e_acos.c e_asin.c e_atan2.c e_exp.c e_fmod.c e_log.c e_log10.c e_remainder.c e_scalb.c e_sqrt.c math_private.h s_atan.c s_ceil.c s_copysign.c s_copysignf.c s_cos.c s_finite.c s_floor.c s_ilogb.c s_logb.c s_rint.c s_scalbn.c s_significand.c s_sin.c s_tan.c Log: Only provide one copy of the math functions. If we provide a MD function, do not also provide a __generic_XXX version as well. This is how we used to runtime select the generic vs i387 versions on the i386 platform. This saves a pile of #defines in the src/math_private.h file to undo the __generic_XXX renames in some of the *.c files. Revision Changes Path 1.33 +7 -15 src/lib/msun/Makefile 1.9 +1 -1 src/lib/msun/src/e_acos.c 1.10 +1 -1 src/lib/msun/src/e_asin.c 1.9 +1 -1 src/lib/msun/src/e_atan2.c 1.9 +1 -1 src/lib/msun/src/e_exp.c 1.8 +1 -1 src/lib/msun/src/e_fmod.c 1.9 +1 -1 src/lib/msun/src/e_log.c 1.10 +1 -1 src/lib/msun/src/e_log10.c 1.9 +1 -1 src/lib/msun/src/e_remainder.c 1.9 +2 -2 src/lib/msun/src/e_scalb.c 1.9 +1 -1 src/lib/msun/src/e_sqrt.c 1.15 +0 -40 src/lib/msun/src/math_private.h 1.9 +1 -1 src/lib/msun/src/s_atan.c 1.9 +1 -1 src/lib/msun/src/s_ceil.c 1.9 +1 -1 src/lib/msun/src/s_copysign.c 1.9 +1 -1 src/lib/msun/src/s_copysignf.c 1.9 +1 -1 src/lib/msun/src/s_cos.c 1.8 +1 -1 src/lib/msun/src/s_finite.c 1.9 +1 -1 src/lib/msun/src/s_floor.c 1.8 +1 -1 src/lib/msun/src/s_ilogb.c 1.9 +1 -1 src/lib/msun/src/s_logb.c 1.10 +1 -1 src/lib/msun/src/s_rint.c 1.9 +1 -1 src/lib/msun/src/s_scalbn.c 1.9 +1 -1 src/lib/msun/src/s_significand.c 1.9 +1 -1 src/lib/msun/src/s_sin.c 1.9 +1 -1 src/lib/msun/src/s_tan.c From owner-cvs-src@FreeBSD.ORG Tue Jul 22 22:32:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B30037B401; Tue, 22 Jul 2003 22:32:02 -0700 (PDT) Received: from zibbi.icomtek.csir.co.za (zibbi.icomtek.csir.co.za [146.64.24.58]) by mx1.FreeBSD.org (Postfix) with ESMTP id 408F043FCB; Tue, 22 Jul 2003 22:32:00 -0700 (PDT) (envelope-from jhay@zibbi.icomtek.csir.co.za) Received: from zibbi.icomtek.csir.co.za (localhost [IPv6:::1]) h6N5Vv5v007319; Wed, 23 Jul 2003 07:31:57 +0200 (SAST) (envelope-from jhay@zibbi.icomtek.csir.co.za) Received: (from jhay@localhost) by zibbi.icomtek.csir.co.za (8.12.9/8.12.9/Submit) id h6N5VvG7007318; Wed, 23 Jul 2003 07:31:57 +0200 (SAST) (envelope-from jhay) Date: Wed, 23 Jul 2003 07:31:56 +0200 From: John Hay To: Mark Murray Message-ID: <20030723053156.GA7229@zibbi.icomtek.csir.co.za> References: <20030718055914.GA91210@zibbi.icomtek.csir.co.za> <200307180717.h6I7HYZ2006152@grimreaper.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307180717.h6I7HYZ2006152@grimreaper.grondar.org> User-Agent: Mutt/1.4i cc: cvs-src@FreeBSD.org cc: John Hay cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/lib Makefile src/libexec Makefile src/usr.bin Makefile src/crypto/telnet/arpa telnet.h src/crypto/telnet/libtelnet auth-proto.h auth.c auth.h enc-proto.h enc_des.c encrypt.c encrypt.h genget.c getent.c kerberos.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 05:32:02 -0000 On Fri, Jul 18, 2003 at 08:17:33AM +0100, Mark Murray wrote: > John Hay writes: > > Hi Mark, dit you test a make release with this? It seems to fail when it > > tries to build the fixit crunch binary: > > *DAMN* I forgot to commit that. Thanks for the reminder! > Hi Mark, is the fix still in the pipeline? My daily releases are still failing every night. John -- John Hay -- John.Hay@icomtek.csir.co.za / jhay@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Tue Jul 22 22:44:55 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 50AD337B401; Tue, 22 Jul 2003 22:44:55 -0700 (PDT) Received: from builder.freebsdmall.com (builder.freebsdmall.com [65.86.180.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB3FF43F93; Tue, 22 Jul 2003 22:44:54 -0700 (PDT) (envelope-from murray@builder.freebsdmall.com) Received: (from root@localhost) by builder.freebsdmall.com (8.12.9/8.11.6) id h6N5issW053400; Tue, 22 Jul 2003 22:44:54 -0700 (PDT) (envelope-from murray) Date: Tue, 22 Jul 2003 22:44:52 -0700 From: Murray Stokely To: Ruslan Ermilov Message-ID: <20030722224451.I215@freebsdmall.com> References: <20030722183959.GB80514@sunbay.com> <20030722185621.GD80514@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20030722185621.GD80514@sunbay.com>; from ru@FreeBSD.org on Tue, Jul 22, 2003 at 09:56:21PM +0300 X-GPG-Key-ID: 1024D/0E451F7D X-GPG-Key-Fingerprint: E2CA 411D DD44 53FD BB4B 3CB5 B4D7 10A2 0E45 1F7D cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org cc: Chern Lee cc: John Baldwin Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 05:44:55 -0000 On Tue, Jul 22, 2003 at 09:56:21PM +0300, Ruslan Ermilov wrote: > this change? Do you need the /floppies/boot.flp on the 1st and > 2nd i386 CD-ROMs? We should still at least have conditional support for emulation booting. I don't like your change without at least some documented way to build bootable emulation CDROMs. I'm sure many vendors build their products with their own mkisofs command lines, and I don't think this change was just "forgotten" by John. - Murray From owner-cvs-src@FreeBSD.ORG Tue Jul 22 22:46:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD77C37B401; Tue, 22 Jul 2003 22:46:10 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA79A43F85; Tue, 22 Jul 2003 22:46:09 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6N5k8V3037135; Wed, 23 Jul 2003 05:46:08 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6N5k75H019837; Wed, 23 Jul 2003 07:46:07 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Peter Wemm From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 22 Jul 2003 18:34:42 PDT." <20030723013442.DFA102A7EA@canning.wemm.org> Date: Wed, 23 Jul 2003 07:46:07 +0200 Message-ID: <19836.1058939167@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Garance A Drosihn Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 05:46:11 -0000 In message <20030723013442.DFA102A7EA@canning.wemm.org>, Peter Wemm writes: >What has been highlighted is that inline has been abused over time. The >argument is how and where to draw the line in cost vs benefit. 'inline' is >a hint to the compiler that you believe that the increased code size cost >is worth it. The problem is that some inlines were being failed because >the gcc cost estimation was happening before optimization and was way out >of sync with reality. eg: a reference to curthread blows the estimate out >of the water, even though it accounts for 1 or 2 instructions only. That is only half the problem Peter. The other half of the problem is that since GCC ignored some of the inlines, people may have looked at the object size and thinking "Ok, that had no significant cost and I probably saved a couple of instructions" despite the fact that nothing happened at all. Once we increase the GCC limit to get the cases you mention above inlined, then these impotent inlines suddenly explode in our face as pessimizations. Those were the onces I tried to deal with yesterday. >The other problem is that many of the original measurements were done years >ago by folks who are no longer with us (eg: John Dyson) on hardware that >is no longer an accurate representative of current hardware. This is really only an issue in the few cases where measurements were actually performed. I don't see anyone saying "I always test my code to see if inline has han impact". >> Might we expect some >> performance improvements now that we know to force gcc to >> inline the functions? > >Thats an interesting question, isn't it? Somebody had previously measured >a 5% slowdown as a result of not inlining the VOP_* function wrappers. >I wonder if this is part of the 4.x -> 5.x slowdown that hasn't been >resolved yet. I dont know how many VOP_* calls are or are not presently >being inlined though. In generic all VOP's are inlined at a limit>= 270 so I think the ansker is "none". -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 22:53:54 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A67B37B401; Tue, 22 Jul 2003 22:53:54 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 092C643F85; Tue, 22 Jul 2003 22:53:54 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6N5rr0U058774; Tue, 22 Jul 2003 22:53:53 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6N5rrpN058773; Tue, 22 Jul 2003 22:53:53 -0700 (PDT) Message-Id: <200307230553.h6N5rrpN058773@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 22 Jul 2003 22:53:53 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 05:53:54 -0000 ru 2003/07/22 22:53:53 PDT FreeBSD src repository Modified files: release Makefile Log: Do not define BIGBOOTSIZE and the friends for amd64; it serves no useful purpose other than wasting CPU time in "make release" creating useless boot.flp. Desired by: peter Revision Changes Path 1.789 +0 -3 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Tue Jul 22 22:55:04 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1481837B401; Tue, 22 Jul 2003 22:55:04 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A361D43F75; Tue, 22 Jul 2003 22:55:03 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6N5t30U058824; Tue, 22 Jul 2003 22:55:03 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6N5t3s5058823; Tue, 22 Jul 2003 22:55:03 -0700 (PDT) Message-Id: <200307230555.h6N5t3s5058823@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 22 Jul 2003 22:55:03 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release/amd64 dokern.sh fixit_crunch.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 05:55:04 -0000 ru 2003/07/22 22:55:03 PDT FreeBSD src repository Removed files: release/amd64 dokern.sh fixit_crunch.conf Log: amd64 will not provide floppies. Revision Changes Path 1.82 +0 -52 src/release/amd64/dokern.sh (dead) 1.11 +0 -25 src/release/amd64/fixit_crunch.conf (dead) From owner-cvs-src@FreeBSD.ORG Tue Jul 22 23:00:57 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C33737B401; Tue, 22 Jul 2003 23:00:57 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A81043F75; Tue, 22 Jul 2003 23:00:57 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6N60v0U059137; Tue, 22 Jul 2003 23:00:57 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6N60uTe059136; Tue, 22 Jul 2003 23:00:56 -0700 (PDT) Message-Id: <200307230600.h6N60uTe059136@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 22 Jul 2003 23:00:56 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 06:00:58 -0000 ru 2003/07/22 23:00:56 PDT FreeBSD src repository Modified files: release Makefile Log: Revert revision 1.788, and explain a bit the intent of having the boot.flp image on the second CD-ROM. Explained by: jhb Desired by: vendors Revision Changes Path 1.790 +5 -0 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Tue Jul 22 23:03:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 839CD37B401; Tue, 22 Jul 2003 23:03:25 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45A2E43F93; Tue, 22 Jul 2003 23:03:24 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6N63FV3037376; Wed, 23 Jul 2003 06:03:15 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6N63D5H019957; Wed, 23 Jul 2003 08:03:14 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: "Alan L. Cox" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 23 Jul 2003 00:36:28 CDT." <3F1E1EDC.5124C137@imimic.com> Date: Wed, 23 Jul 2003 08:03:13 +0200 Message-ID: <19956.1058940193@critter.freebsd.dk> cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Marcel Moolenaar cc: Steve Kargl cc: cvs-all@FreeBSD.org cc: Peter Wemm Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 06:03:25 -0000 In message <3F1E1EDC.5124C137@imimic.com>, "Alan L. Cox" writes: >Poul-Henning Kamp wrote: >> >> In message <20030722233258.6913E2A7EA@canning.wemm.org>, Peter Wemm writes: >> >"Poul-Henning Kamp" wrote: >> > >> >> If Y < X, then you have by definition a performance gain. >> > >> >Only if you look at the classic model where you ignore things like >> >speculation and assume that every instruction is executed exactly once etc. >> >Mainframe optimization strategy is not necessarily applicable to to >> >contemporary cpus. >> ... >> >I suspect Alan Cox already knows the answer to 'which is faster' in >> >the vm_object_backing_scan() case and he's waiting for you to put your foot >> >in it. :-) >> > >Ok, here goes: I've actually measured it. :-) > >Specifically, I tested the "always inline" directive on the i386's >pmap_changebit(). This function is used by several pmap functions, >including pmap_clear_reference(). I did not, however, spend enough time >to construct a test that I considered conclusive. Ok, and what was the result of your mesurement ? Did it help or not ? >Now, let's look at code size. On one hand, inlining pmap_changebit() >increases the overall size of the kernel. On the other hand, it reduces >the size of the code that implements pmap_clear_reference() from ~400 >bytes to ~350 bytes, mostly through the elimination of conditional >branches. My experience is that the latter notion of code size is more >likely to correlate with real performance than the former. Compile without inline, check object size: 15485 160 548 16193 3f41 pmap.o compile with inline, check object size: 16029 160 548 16737 4161 pmap.o The uninlined function is 368 bytes, so three copies of the full function would be 1104 bytes, consequently we have saved about "half of the function" by inlining it. Such a reasoning would satisfy me that people have actually done some amount of work to test their inlining, and given the tightloop use in this case, satisfy as a probable performance improvement. But obviously, when GCC is able to ignore the inlining and we don't notice, then people have not done any such reasoning... As I said many times already, I am not adverse to people adding inline when they have done their homework, I am only against the purely speculative inlining. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Jul 22 23:04:00 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A2BA37B401; Tue, 22 Jul 2003 23:04:00 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF4FC43F75; Tue, 22 Jul 2003 23:03:53 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6N63o0U045263 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Jul 2003 09:03:50 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6N63ou3045258; Wed, 23 Jul 2003 09:03:50 +0300 (EEST) (envelope-from ru) Date: Wed, 23 Jul 2003 09:03:50 +0300 From: Ruslan Ermilov To: Murray Stokely Message-ID: <20030723060349.GA45101@sunbay.com> References: <20030722183959.GB80514@sunbay.com> <20030722185621.GD80514@sunbay.com> <20030722224451.I215@freebsdmall.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="h31gzZEtNLTqOjlF" Content-Disposition: inline In-Reply-To: <20030722224451.I215@freebsdmall.com> User-Agent: Mutt/1.5.4i cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org cc: Chern Lee cc: John Baldwin Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 06:04:00 -0000 --h31gzZEtNLTqOjlF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 22, 2003 at 10:44:52PM -0700, Murray Stokely wrote: > On Tue, Jul 22, 2003 at 09:56:21PM +0300, Ruslan Ermilov wrote: > > this change? Do you need the /floppies/boot.flp on the 1st and > > 2nd i386 CD-ROMs? >=20 > We should still at least have conditional support for emulation > booting. I don't like your change without at least some documented > way to build bootable emulation CDROMs. I'm sure many vendors build > their products with their own mkisofs command lines, and I don't think > this change was just "forgotten" by John. >=20 I have reverted the change. How about if I add a knob (for i386 only) that tells i386/mkisoimages.sh to create a bootable image using floppy emulation, and copying boot.flp only in this case? Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --h31gzZEtNLTqOjlF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/HiVFUkv4P6juNwoRAsGnAJ457BsCBLLMUx+IpgUXZQdyy5oBNQCffAmd 2pUsLlg1lXaSqgXuvsJuTgc= =nAa+ -----END PGP SIGNATURE----- --h31gzZEtNLTqOjlF-- From owner-cvs-src@FreeBSD.ORG Wed Jul 23 00:15:26 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D82D37B401; Wed, 23 Jul 2003 00:15:26 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 359B043F75; Wed, 23 Jul 2003 00:15:24 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id RAA21724; Wed, 23 Jul 2003 17:15:12 +1000 Date: Wed, 23 Jul 2003 17:15:11 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Poul-Henning Kamp In-Reply-To: <16474.1058916504@critter.freebsd.dk> Message-ID: <20030723170147.X1276@gamplex.bde.org> References: <16474.1058916504@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: "Alan L. Cox" cc: src-committers@FreeBSD.ORG cc: Bosko Milekic cc: Steve Kargl cc: cvs-src@FreeBSD.ORG cc: David Schultz cc: cvs-all@FreeBSD.ORG cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 07:15:26 -0000 On Wed, 23 Jul 2003, Poul-Henning Kamp wrote: > In message <20030722231656.GA9715@HAL9000.homeunix.com>, David Schultz writes: > > Please remember that the problem at hand is getting -Werror back > on the kernel so we can catch issues like the warning in umtx. Straw problem. Kernel developers can easily turn off -Winline and turn on -Werror. I turned off -Winline in my version of the old version of -current that I use a few minutes after importing gcc, and never turned off -Werror: %%% Index: kern.mk =================================================================== RCS file: /home/ncvs/src/sys/conf/kern.mk,v retrieving revision 1.31 diff -u -2 -r1.31 kern.mk --- kern.mk 13 Oct 2002 02:52:22 -0000 1.31 +++ kern.mk 11 Jul 2003 14:45:37 -0000 @@ -8,5 +8,5 @@ # also pop up, but are easier to fix. CWARNFLAGS?= -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes \ - -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual \ + -Wmissing-prototypes -Wpointer-arith -Wcast-qual \ -fformat-extensions -ansi # %%% > We could either do that by lobotomizing the warning in the compiler > or by setting the limit high enough to inline everything so marked. > > Since the warning has indeed pointed out a fair number of bogus > inlines, the first option did not seem attractive. Turning off -Winline essentially gives the gcc-3.2 brokenness of -Winline without touching the compiler. -Winline has been turned off for a long time for the i386 LINT, as a side effect of the i386 LINT testing high resolution profiling and -Winline actually producing warnings for the high resolution profiling case (-finstrument-functions at least used to conflict with inliniing). No one seemed to notice when I turned it off. Bruce From owner-cvs-src@FreeBSD.ORG Wed Jul 23 00:39:12 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 11A2137B401; Wed, 23 Jul 2003 00:39:12 -0700 (PDT) Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.157.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id F07B843FA3; Wed, 23 Jul 2003 00:39:10 -0700 (PDT) (envelope-from mark@grondar.org) Received: from storm.FreeBSD.org.uk (Ugrondar@localhost [127.0.0.1]) by storm.FreeBSD.org.uk (8.12.9/8.12.9) with ESMTP id h6N7d9Ho049669; Wed, 23 Jul 2003 08:39:09 +0100 (BST) (envelope-from mark@grondar.org) Received: (from Ugrondar@localhost)h6N7d9nC049663; Wed, 23 Jul 2003 08:39:09 +0100 (BST) X-Authentication-Warning: storm.FreeBSD.org.uk: Ugrondar set sender to mark@grondar.org using -f Received: from grondar.org (localhost [127.0.0.1])h6N7a5Z2071198; Wed, 23 Jul 2003 08:36:05 +0100 (BST) (envelope-from mark@grondar.org) From: Mark Murray Message-Id: <200307230736.h6N7a5Z2071198@grimreaper.grondar.org> To: John Hay In-Reply-To: Your message of "Wed, 23 Jul 2003 07:31:56 +0200." <20030723053156.GA7229@zibbi.icomtek.csir.co.za> Date: Wed, 23 Jul 2003 08:36:04 +0100 Sender: mark@grondar.org X-Spam-Status: No, hits=0.2 required=5.0 tests=EMAIL_ATTRIBUTION,FROM_NO_LOWER,IN_REP_TO, QUOTED_EMAIL_TEXT,REPLY_WITH_QUOTES version=2.55 X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib Makefile src/libexec Makefile src/usr.bin Makefile src/crypto/telnet/arpa telnet.h src/crypto/telnet/libtelnet auth-proto.h auth.c auth.h enc-proto.h enc_des.c encrypt.c encrypt.h genget.c getent.c kerberos.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 07:39:12 -0000 John Hay writes: > On Fri, Jul 18, 2003 at 08:17:33AM +0100, Mark Murray wrote: > > John Hay writes: > > > Hi Mark, dit you test a make release with this? It seems to fail when it > > > tries to build the fixit crunch binary: > > > > *DAMN* I forgot to commit that. Thanks for the reminder! > > > > Hi Mark, is the fix still in the pipeline? My daily releases are still > failing every night. Yes. I'm working on a slew of problems related to this very issue. Please be patient :-). M -- Mark Murray iumop ap!sdn w,I idlaH From owner-cvs-src@FreeBSD.ORG Wed Jul 23 01:18:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4852C37B401; Wed, 23 Jul 2003 01:18:27 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D858743FAF; Wed, 23 Jul 2003 01:18:26 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6N8IQ0U072214; Wed, 23 Jul 2003 01:18:26 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6N8IQBD072212; Wed, 23 Jul 2003 01:18:26 -0700 (PDT) Message-Id: <200307230818.h6N8IQBD072212@repoman.freebsd.org> From: Hartmut Brandt Date: Wed, 23 Jul 2003 01:18:26 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/proatm proatm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 08:18:27 -0000 harti 2003/07/23 01:18:26 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/proatm proatm.c Log: Fix the copyright. Fix a problem with a board stopping. Add sanity checks for m_pkthdr. Submitted by: Vincent Jardin Revision Changes Path 1.1.2.2 +69 -19 src/sys/dev/proatm/proatm.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 02:24:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1678B37B401; Wed, 23 Jul 2003 02:24:45 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A854543FDD; Wed, 23 Jul 2003 02:24:44 -0700 (PDT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6N9Oi0U075804; Wed, 23 Jul 2003 02:24:44 -0700 (PDT) (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6N9OiuI075803; Wed, 23 Jul 2003 02:24:44 -0700 (PDT) Message-Id: <200307230924.h6N9OiuI075803@repoman.freebsd.org> From: Bruce Evans Date: Wed, 23 Jul 2003 02:24:44 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/msun Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 09:24:45 -0000 bde 2003/07/23 02:24:44 PDT FreeBSD src repository Modified files: lib/msun Makefile Log: Fixed some style bugs (misplacement and misformatting of some commented-out code). Revision Changes Path 1.34 +2 -4 src/lib/msun/Makefile From owner-cvs-src@FreeBSD.ORG Wed Jul 23 05:09:15 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D42A37B401; Wed, 23 Jul 2003 05:09:15 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D0DE443FBF; Wed, 23 Jul 2003 05:09:14 -0700 (PDT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NC9E0U090731; Wed, 23 Jul 2003 05:09:14 -0700 (PDT) (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NC9EpX090730; Wed, 23 Jul 2003 05:09:14 -0700 (PDT) Message-Id: <200307231209.h6NC9EpX090730@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Wed, 23 Jul 2003 05:09:14 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pc98/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 12:09:15 -0000 nyan 2003/07/23 05:09:14 PDT FreeBSD src repository Modified files: sys/pc98/conf NOTES Log: MFi386: revision 1.1090. Revision Changes Path 1.12 +10 -0 src/sys/pc98/conf/NOTES From owner-cvs-src@FreeBSD.ORG Wed Jul 23 05:12:55 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B3DE37B401; Wed, 23 Jul 2003 05:12:55 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF33143FA3; Wed, 23 Jul 2003 05:12:54 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NCCs0U090933; Wed, 23 Jul 2003 05:12:54 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NCCsEi090932; Wed, 23 Jul 2003 05:12:54 -0700 (PDT) Message-Id: <200307231212.h6NCCsEi090932@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 23 Jul 2003 05:12:54 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 12:12:55 -0000 ru 2003/07/23 05:12:54 PDT FreeBSD src repository Modified files: release Makefile Log: Make NO_FLOPPIES really mean "no floppies", including not even creating the "floppies" directory on FTP and CD-ROMs. Enforce NO_FLOPPIES on amd64. Tested for: amd64, i386 with -DNO_FLOPPIES Revision Changes Path 1.791 +11 -2 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Wed Jul 23 00:28:57 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 53ADD37B401; Wed, 23 Jul 2003 00:28:57 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40A9E43F85; Wed, 23 Jul 2003 00:28:55 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id RAA24100; Wed, 23 Jul 2003 17:28:36 +1000 Date: Wed, 23 Jul 2003 17:28:35 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Peter Wemm In-Reply-To: <20030723003212.1606C2A8B2@canning.wemm.org> Message-ID: <20030723171520.E1276@gamplex.bde.org> References: <20030723003212.1606C2A8B2@canning.wemm.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Mailman-Approved-At: Wed, 23 Jul 2003 05:20:10 -0700 cc: "Alan L. Cox" cc: Poul-Henning Kamp cc: src-committers@FreeBSD.ORG cc: Julian Elischer cc: Steve Kargl cc: cvs-src@FreeBSD.ORG cc: David Schultz cc: Bosko Milekic cc: cvs-all@FreeBSD.ORG cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 07:28:57 -0000 On Tue, 22 Jul 2003, Peter Wemm wrote: > "Poul-Henning Kamp" wrote: > > > That is the sort of thing which makes me belive that unless proven > > beneficial (by one of the two criteria), inline is harmful. > > There is a great leap there. Just because somebody isn't willing to spend > considerable time to re-prove that the runtime improvement is still there > to your satisfaction, that doesn't mean that it is harmful. > > Take the i386 interrupt vector code. Thats an example where it is massively > inlined. Having a non-inlined function that does all the calculations > and bit shifting is much smaller in code size, but slower at runtime. A good bad example :-). I've wanted to try uninlining that code for years. Everything except fast interrupt handlers gets demultiplexed through sched_ithd() and ithread_schedule(), so we do some calculations and bit shifting anyway; we may even have to repeat some. Anyway, interrupt handlers aren't called very often, and interrupt handler time is dominated by hardware access time on non-old machines, starting with the PIC/APIC accesses in Xintr*. We still do *PIC mask setting and EOI in Xintr*, but we do *PIC mask unsetting from C code. Bruce From owner-cvs-src@FreeBSD.ORG Wed Jul 23 06:24:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 41C6337B404; Wed, 23 Jul 2003 06:24:33 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE4A143FCB; Wed, 23 Jul 2003 06:24:32 -0700 (PDT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NDOW0U094916; Wed, 23 Jul 2003 06:24:32 -0700 (PDT) (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NDOWb1094915; Wed, 23 Jul 2003 06:24:32 -0700 (PDT) Message-Id: <200307231324.h6NDOWb1094915@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Wed, 23 Jul 2003 06:24:32 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man7 Makefile rescue.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 13:24:34 -0000 simon 2003/07/23 06:24:32 PDT FreeBSD src repository (doc committer) Modified files: share/man/man7 Makefile Added files: share/man/man7 rescue.7 Log: Add manual page to document the new rescue utilities in /rescue. Most text by: Tim Kientzle Reviewed by: ru, doc@ Approved by: ceri (mentor) Revision Changes Path 1.27 +1 -1 src/share/man/man7/Makefile 1.1 +182 -0 src/share/man/man7/rescue.7 (new) From owner-cvs-src@FreeBSD.ORG Wed Jul 23 07:25:55 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A6ED37B401; Wed, 23 Jul 2003 07:25:55 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DCCA143F75; Wed, 23 Jul 2003 07:25:54 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NEPs0U098567; Wed, 23 Jul 2003 07:25:54 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NEPrCn098566; Wed, 23 Jul 2003 07:25:53 -0700 (PDT) Message-Id: <200307231425.h6NEPrCn098566@repoman.freebsd.org> From: Hartmut Brandt Date: Wed, 23 Jul 2003 07:25:53 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm/ipatm ipatm_load.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 14:25:55 -0000 harti 2003/07/23 07:25:53 PDT FreeBSD src repository Modified files: sys/netatm/ipatm ipatm_load.c Log: Get rid of the zone for network interfaces. We have converted this to use malloc(9). Revision Changes Path 1.18 +0 -7 src/sys/netatm/ipatm/ipatm_load.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 07:28:58 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FEF137B401; Wed, 23 Jul 2003 07:28:58 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C3EC43F75; Wed, 23 Jul 2003 07:28:58 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NESv0U098804; Wed, 23 Jul 2003 07:28:57 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NESvZP098803; Wed, 23 Jul 2003 07:28:57 -0700 (PDT) Message-Id: <200307231428.h6NESvZP098803@repoman.freebsd.org> From: Hartmut Brandt Date: Wed, 23 Jul 2003 07:28:57 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_cm.c atm_device.c src/sys/netatm/ipatm ipatm_vcm.c src/sys/netatm/uni uniarp.c uniarp_cache.c uniarp_vcm.c unisig_decode.c unisig_subr.c unisig_vc_state.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 14:28:59 -0000 harti 2003/07/23 07:28:57 PDT FreeBSD src repository Modified files: sys/netatm atm_cm.c atm_device.c sys/netatm/ipatm ipatm_vcm.c sys/netatm/uni uniarp.c uniarp_cache.c uniarp_vcm.c unisig_decode.c unisig_subr.c unisig_vc_state.c Log: Convert a lot of uma_zalloc() calls to be NOWAIT instead of WAITOK. All these may be called from contexts where we cannot sleep (callout handlers for example). Revision Changes Path 1.28 +10 -5 src/sys/netatm/atm_cm.c 1.21 +2 -1 src/sys/netatm/atm_device.c 1.15 +4 -2 src/sys/netatm/ipatm/ipatm_vcm.c 1.18 +2 -1 src/sys/netatm/uni/uniarp.c 1.12 +2 -1 src/sys/netatm/uni/uniarp_cache.c 1.14 +4 -2 src/sys/netatm/uni/uniarp_vcm.c 1.16 +1 -1 src/sys/netatm/uni/unisig_decode.c 1.15 +15 -13 src/sys/netatm/uni/unisig_subr.c 1.16 +8 -4 src/sys/netatm/uni/unisig_vc_state.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 07:40:52 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6695837B401; Wed, 23 Jul 2003 07:40:52 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02BF943F93; Wed, 23 Jul 2003 07:40:52 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NEep0U099976; Wed, 23 Jul 2003 07:40:51 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NEepJi099975; Wed, 23 Jul 2003 07:40:51 -0700 (PDT) Message-Id: <200307231440.h6NEepJi099975@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 23 Jul 2003 07:40:51 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile src/share/man/man7 release.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 14:40:52 -0000 ru 2003/07/23 07:40:51 PDT FreeBSD src repository Modified files: release Makefile share/man/man7 release.7 Log: Added the WORLDDIR variable (defaulting to ${.CURDIR}/..) that points to a directory where "make buildworld" was run. Useful for building 5.x snapshots on 4.x. Revision Changes Path 1.792 +4 -2 src/release/Makefile 1.29 +7 -0 src/share/man/man7/release.7 From owner-cvs-src@FreeBSD.ORG Wed Jul 23 08:04:32 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C6F8037B401; Wed, 23 Jul 2003 08:04:32 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 65A8443FD7; Wed, 23 Jul 2003 08:04:32 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NF4W0U002250; Wed, 23 Jul 2003 08:04:32 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NF4WUp002249; Wed, 23 Jul 2003 08:04:32 -0700 (PDT) Message-Id: <200307231504.h6NF4WUp002249@repoman.freebsd.org> From: Hartmut Brandt Date: Wed, 23 Jul 2003 08:04:32 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 15:04:33 -0000 harti 2003/07/23 08:04:32 PDT FreeBSD src repository Modified files: sys/netatm atm_if.c Log: Handle the new MEDIA definitions. Revision Changes Path 1.23 +9 -0 src/sys/netatm/atm_if.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 10:14:59 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B9E437B404 for ; Wed, 23 Jul 2003 10:14:59 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 23CF843F75 for ; Wed, 23 Jul 2003 10:14:58 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 39580 invoked by uid 1000); 23 Jul 2003 17:14:58 -0000 Date: Wed, 23 Jul 2003 10:14:58 -0700 (PDT) From: Nate Lawson To: Garance A Drosihn In-Reply-To: Message-ID: <20030723101220.B39567@root.org> References: <20030723003212.1606C2A8B2@canning.wemm.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 17:14:59 -0000 On Tue, 22 Jul 2003, Garance A Drosihn wrote: > At 5:32 PM -0700 7/22/03, Peter Wemm wrote: > >Take the i386 interrupt vector code. Thats an example where > >it is massively inlined. Having a non-inlined function that > >does all the calculations and bit shifting is much smaller > >in code size, but slower at runtime. > > If I understand this discussion correctly, then the previous > version of gcc (in freebsd-current) was NOT inlining these > sections event though we thought it was. Might we expect some > performance improvements now that we know to force gcc to > inline the functions? Excellent troll. :) [FYI, the long-winded discussion underway is whether the many cases of inlining actually do have any performance gain. Not all requests for inline were rejected, only those for "large" functions where gcc's idea of large is also being debated.] -Nate From owner-cvs-src@FreeBSD.ORG Wed Jul 23 10:26:54 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D64DD37B401 for ; Wed, 23 Jul 2003 10:26:54 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 7DF4D43FAF for ; Wed, 23 Jul 2003 10:26:53 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 39607 invoked by uid 1000); 23 Jul 2003 17:26:54 -0000 Date: Wed, 23 Jul 2003 10:26:54 -0700 (PDT) From: Nate Lawson To: "Simon L. Nielsen" In-Reply-To: <20030723132439.D550137B401@hub.freebsd.org> Message-ID: <20030723102603.O39567@root.org> References: <20030723132439.D550137B401@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man7 Makefile rescue.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 17:26:55 -0000 What's it doing in section 7? I thought system utils are section 8? -Nate On Wed, 23 Jul 2003, Simon L. Nielsen wrote: > > Modified files: > share/man/man7 Makefile > Added files: > share/man/man7 rescue.7 > Log: > Add manual page to document the new rescue utilities in /rescue. > > Most text by: Tim Kientzle > Reviewed by: ru, doc@ > Approved by: ceri (mentor) > > Revision Changes Path > 1.27 +1 -1 src/share/man/man7/Makefile > 1.1 +182 -0 src/share/man/man7/rescue.7 (new) From owner-cvs-src@FreeBSD.ORG Wed Jul 23 10:56:31 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 83D8B37B404 for ; Wed, 23 Jul 2003 10:56:31 -0700 (PDT) Received: from mail.speakeasy.net (mail9.speakeasy.net [216.254.0.209]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40F1A43FAF for ; Wed, 23 Jul 2003 10:56:29 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 19161 invoked from network); 23 Jul 2003 17:56:28 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 23 Jul 2003 17:56:28 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6NHuPGI046296; Wed, 23 Jul 2003 13:56:25 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030722.164223.00776481.imp@bsdimp.com> Date: Wed, 23 Jul 2003 13:56:43 -0400 (EDT) From: John Baldwin To: "M. Warner Losh" cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: bde@zeta.org.au cc: paul@freebsd-services.com cc: cvs-src@FreeBSD.org cc: das@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 17:56:31 -0000 On 22-Jul-2003 M. Warner Losh wrote: > In message: > John Baldwin writes: >: >: On 22-Jul-2003 M. Warner Losh wrote: >: > In message: <20030722163007.GA6080@HAL9000.homeunix.com> >: > David Schultz writes: >: >: There is reason for concern about cases where inline really is >: >: misused, either because it massively increases code size or >: >: because it is unimportant to performance and detracts from >: >: debuggability. But I would not like to see a policy that shifts >: >: the burden of proof onto authors of new code.[1] A policy about >: >: gratuitous sweeps through other people's code, on the other >: >: hand... >: > >: > There's one other place that we use inlining. We use it to make sure >: > that modules do not contain references to certain symbols. For >: > example: >: > >: > /* >: > * make this inline so that we don't have to worry about dangling references >: > * to it in the modules or the code. >: > */ >: > static __inline const struct pccard_product * >: > pccard_product_lookup(device_t dev, const struct pccard_product *tab, >: > size_t ent_size, pccard_product_match_fn matchfn) >: > { >: > return CARD_DO_PRODUCT_LOOKUP(device_get_parent(dev), dev, >: > tab, ent_size, matchfn); >: > } >: > >: > We do this to get the type safty of the function call and not have to >: > make that a macro. We do *NOT* want references to >: > pccard_product_lookup, but the CARD_DO_.. kobj call allows the >: > indirection that makes it possible to use the same module in kernels >: > with and without pccard support. >: > >: > This isn't either of the performance or size trade-offs. It is a >: > design decision to use inline over #define. If the new gcc breaks >: > this, then it becomes a #define... >: >: I think that this is a bandaid solution though. Ideally if you >: load a device driver, it really contains several modules: one base >: module for the base code and one module for each bus attachment. >: The base attachment must link for the load to complete, but if a >: bus attachment doesn't link due to missing symbols because that >: bus isn't present in the kernel, it's not an error. At least that's >: how I think it should work. The acpi module already has this issue >: now that it calls pci and isa functions. > > I tried playing with that, but it is also a hard problem. You then > have strong ordering issues, which makes it hard to unload pccard and > reload it w/o unloading all things that depend on it. > > Eg, I don't want to have to unload the if_wi_pccard driver when I want > to unload and reload pccard.ko. Umm, you should be having to unload if_wi then when unloading pccard. If if_wi tries to call a pccard method on an attached pccard device after pccard is unloaded, I'm sure lots of things are going to break. Hmmm. I guess if unloading pccard detaches all pccard devices and their children then it is safe if you always use KOBJ methods and never link against any functions for your bus attachments. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Wed Jul 23 10:58:42 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2953F37B401; Wed, 23 Jul 2003 10:58:42 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B89ED43FAF; Wed, 23 Jul 2003 10:58:41 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NHwf0U016579; Wed, 23 Jul 2003 10:58:41 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NHwfVq016578; Wed, 23 Jul 2003 10:58:41 -0700 (PDT) Message-Id: <200307231758.h6NHwfVq016578@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 23 Jul 2003 10:58:41 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i4b/capi/iavc iavc.h iavc_lli.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 17:58:42 -0000 phk 2003/07/23 10:58:41 PDT FreeBSD src repository Modified files: sys/i4b/capi/iavc iavc.h iavc_lli.c Log: Undo agressive inlining which GCC previously wisely ignored. The this eliminates 67% of the text segment (relative to respected inline requests). Revision Changes Path 1.2 +11 -152 src/sys/i4b/capi/iavc/iavc.h 1.7 +158 -0 src/sys/i4b/capi/iavc/iavc_lli.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 11:03:23 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB27137B401; Wed, 23 Jul 2003 11:03:23 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67B4643F3F; Wed, 23 Jul 2003 11:03:23 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NI3N0U017697; Wed, 23 Jul 2003 11:03:23 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NI3NQS017696; Wed, 23 Jul 2003 11:03:23 -0700 (PDT) Message-Id: <200307231803.h6NI3NQS017696@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 23 Jul 2003 11:03:23 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/rp rp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 18:03:24 -0000 phk 2003/07/23 11:03:23 PDT FreeBSD src repository Modified files: sys/dev/rp rp.c Log: Undo single-intance inlining which is way above the comfort limit for GCC. Revision Changes Path 1.50 +2 -3 src/sys/dev/rp/rp.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 11:23:48 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1ED0E37B401 for ; Wed, 23 Jul 2003 11:23:47 -0700 (PDT) Received: from mail.speakeasy.net (mail7.speakeasy.net [216.254.0.207]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8CB7243FB1 for ; Wed, 23 Jul 2003 11:23:45 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 4157 invoked from network); 23 Jul 2003 18:23:45 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 23 Jul 2003 18:23:45 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6NINgGI046372; Wed, 23 Jul 2003 14:23:43 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200307231803.h6NI3NQS017696@repoman.freebsd.org> Date: Wed, 23 Jul 2003 14:24:00 -0400 (EDT) From: John Baldwin To: Poul-Henning Kamp cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/rp rp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 18:23:48 -0000 On 23-Jul-2003 Poul-Henning Kamp wrote: > phk 2003/07/23 11:03:23 PDT > > FreeBSD src repository > > Modified files: > sys/dev/rp rp.c > Log: > Undo single-intance inlining which is way above the comfort limit for GCC. Single instance inlining can not hurt. It can help by reducing call stack depth and code size however. I thought you were for reducing code size, not increasing it. Please use __always_inline to shut up gcc instead of de-inlining for single instance inlines. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Wed Jul 23 11:32:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 428D637B401; Wed, 23 Jul 2003 11:32:18 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2586D43F85; Wed, 23 Jul 2003 11:32:17 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6NIWFV3047709; Wed, 23 Jul 2003 18:32:15 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6NIWE5H024543; Wed, 23 Jul 2003 20:32:15 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: John Baldwin From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 23 Jul 2003 14:24:00 EDT." Date: Wed, 23 Jul 2003 20:32:14 +0200 Message-ID: <24542.1058985134@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/rp rp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 18:32:18 -0000 In message , John Baldwin writes: > >On 23-Jul-2003 Poul-Henning Kamp wrote: >> phk 2003/07/23 11:03:23 PDT >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/rp rp.c >> Log: >> Undo single-intance inlining which is way above the comfort limit for GCC. > >Single instance inlining can not hurt. It can help by reducing call >stack depth and code size however. I thought you were for reducing code >size, not increasing it. Please use __always_inline to shut up gcc >instead of de-inlining for single instance inlines. Please provide data showing actual improvement for inlining. If I changed this to __always_inline, I would change the code generated, to start inlining these functions. We don't know the effect of that. Instead I preserve the status quo by removing the inline request which GCC ignores. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Jul 23 11:53:22 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA2A237B405 for ; Wed, 23 Jul 2003 11:53:22 -0700 (PDT) Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E4DE43F75 for ; Wed, 23 Jul 2003 11:53:21 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 4088 invoked from network); 23 Jul 2003 18:53:19 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 23 Jul 2003 18:53:19 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6NIr9GI046426; Wed, 23 Jul 2003 14:53:09 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <24542.1058985134@critter.freebsd.dk> Date: Wed, 23 Jul 2003 14:53:26 -0400 (EDT) From: John Baldwin To: Poul-Henning Kamp cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/rp rp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 18:53:23 -0000 On 23-Jul-2003 Poul-Henning Kamp wrote: > In message , John Baldwin writes: >> >>On 23-Jul-2003 Poul-Henning Kamp wrote: >>> phk 2003/07/23 11:03:23 PDT >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/dev/rp rp.c >>> Log: >>> Undo single-intance inlining which is way above the comfort limit for GCC. >> >>Single instance inlining can not hurt. It can help by reducing call >>stack depth and code size however. I thought you were for reducing code >>size, not increasing it. Please use __always_inline to shut up gcc >>instead of de-inlining for single instance inlines. > > Please provide data showing actual improvement for inlining. text data bss dec hex filename 23554 440 1088 25082 61fa rp.o.both 23421 440 1088 24949 6175 rp.o.non 23394 440 1088 24922 615a rp.o.recv Inlining both is worse than inlining neither, but inlining just rp_do_receive() saves a whopping 27 bytes. Even inlining both is just a difference of 133 bytes or almost 0.5% of the code. > If I changed this to __always_inline, I would change the code generated, > to start inlining these functions. We don't know the effect of that. Bull. We've been inlining these functions in 4.x and the like for quite some time since if I'm reading things correctly gcc didn't start to refuse inlining until gcc 3.x. > Instead I preserve the status quo by removing the inline request which > GCC ignores. No, you are just setting the results of a gcc bug in stone. In FreeBSD < 5.0 the status quo is to inline, and there are a lot more of those releases than 5.0 and 5.1. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Wed Jul 23 11:59:39 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FFB437B401; Wed, 23 Jul 2003 11:59:39 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED6ED43FA3; Wed, 23 Jul 2003 11:59:38 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NIxc0U019781; Wed, 23 Jul 2003 11:59:38 -0700 (PDT) (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NIxcJY019780; Wed, 23 Jul 2003 11:59:38 -0700 (PDT) Message-Id: <200307231859.h6NIxcJY019780@repoman.freebsd.org> From: John Baldwin Date: Wed, 23 Jul 2003 11:59:38 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/i386 mpapic.c src/sys/i386/include apic.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 18:59:39 -0000 jhb 2003/07/23 11:59:38 PDT FreeBSD src repository Modified files: sys/i386/i386 mpapic.c sys/i386/include apic.h Log: Add a new macro APIC_ICRLO_RESV_MASK that contains all of the reserved fields in the low 32 bits of the local APIC ICR register. Use this macro in place of APIC_RESV2_MASK when masking off existing bits from the ICR when writing to it to send an IPI. Tested by: scottl Revision Changes Path 1.63 +2 -2 src/sys/i386/i386/mpapic.c 1.22 +1 -0 src/sys/i386/include/apic.h From owner-cvs-src@FreeBSD.ORG Wed Jul 23 12:04:28 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E193C37B405; Wed, 23 Jul 2003 12:04:28 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E6FE43FA3; Wed, 23 Jul 2003 12:04:28 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NJ4S0U020944; Wed, 23 Jul 2003 12:04:28 -0700 (PDT) (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NJ4Sdg020943; Wed, 23 Jul 2003 12:04:28 -0700 (PDT) Message-Id: <200307231904.h6NJ4Sdg020943@repoman.freebsd.org> From: John Baldwin Date: Wed, 23 Jul 2003 12:04:28 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/i386 mp_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 19:04:30 -0000 jhb 2003/07/23 12:04:28 PDT FreeBSD src repository Modified files: sys/i386/i386 mp_machdep.c Log: Use macros from apic.h to when writing to the ICR to send IPIs to startup APs rather than magic numbers. Tested by: scottl Revision Changes Path 1.213 +12 -5 src/sys/i386/i386/mp_machdep.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 12:49:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94AEA37B401; Wed, 23 Jul 2003 12:49:33 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2FE4B43F75; Wed, 23 Jul 2003 12:49:33 -0700 (PDT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NJnX0U028310; Wed, 23 Jul 2003 12:49:33 -0700 (PDT) (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NJnWEh028309; Wed, 23 Jul 2003 12:49:32 -0700 (PDT) Message-Id: <200307231949.h6NJnWEh028309@repoman.freebsd.org> From: Alan Cox Date: Wed, 23 Jul 2003 12:49:32 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 19:49:34 -0000 alc 2003/07/23 12:49:32 PDT FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/i386/i386 pmap.c Log: Annotate pmap_changebit() as __always_inline. This function was written as a template that when inlined is specialized for the caller through constant value propagation and dead code elimination. Thus, the specialized code that is generated for pmap_clear_reference() et al. avoids several conditional branches inside of a loop. Revision Changes Path 1.424 +2 -1 src/sys/amd64/amd64/pmap.c 1.419 +2 -1 src/sys/i386/i386/pmap.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:03:43 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 179D537B401; Wed, 23 Jul 2003 13:03:43 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A4EA843F75; Wed, 23 Jul 2003 13:03:42 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NK3g0U029884; Wed, 23 Jul 2003 13:03:42 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NK3gG6029883; Wed, 23 Jul 2003 13:03:42 -0700 (PDT) Message-Id: <200307232003.h6NK3gG6029883@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 13:03:42 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf kern.pre.mk kmod.mk newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:03:43 -0000 peter 2003/07/23 13:03:42 PDT FreeBSD src repository Modified files: sys/conf kern.pre.mk kmod.mk newvers.sh Log: Provide a knob for raising the inline instruction estimate threshold and set an initial value. This is aimed at getting us closer to being able to turn -Werror back on and we can adjust the settings later on. Yes, we could turn off -Wno-inline instead, but that would hide the effect of gcc's bogo-estimator ignoring inline (either rightly or wrongly). Revision Changes Path 1.28 +3 -0 src/sys/conf/kern.pre.mk 1.138 +3 -0 src/sys/conf/kmod.mk 1.54 +1 -1 src/sys/conf/newvers.sh From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:07:49 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D571837B401; Wed, 23 Jul 2003 13:07:49 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7259543F3F; Wed, 23 Jul 2003 13:07:49 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NK7n0U030124; Wed, 23 Jul 2003 13:07:49 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NK7nbY030123; Wed, 23 Jul 2003 13:07:49 -0700 (PDT) Message-Id: <200307232007.h6NK7nbY030123@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 13:07:49 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:07:50 -0000 peter 2003/07/23 13:07:49 PDT FreeBSD src repository Modified files: sys/conf newvers.sh Log: ARGH. I *knew* I'd eventually accidently commit this. Change 5.1-XP back to 5.1-CURRENT. Revision Changes Path 1.55 +1 -1 src/sys/conf/newvers.sh From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:09:29 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2EA1537B405 for ; Wed, 23 Jul 2003 13:09:29 -0700 (PDT) Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id C10E243FAF for ; Wed, 23 Jul 2003 13:09:26 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 2213 invoked from network); 23 Jul 2003 20:09:26 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 23 Jul 2003 20:09:26 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6NK9NGI046596; Wed, 23 Jul 2003 16:09:23 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200307232007.h6NK7nbY030123@repoman.freebsd.org> Date: Wed, 23 Jul 2003 16:09:40 -0400 (EDT) From: John Baldwin To: Peter Wemm cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:09:29 -0000 On 23-Jul-2003 Peter Wemm wrote: > peter 2003/07/23 13:07:49 PDT > > FreeBSD src repository > > Modified files: > sys/conf newvers.sh > Log: > ARGH. I *knew* I'd eventually accidently commit this. Change 5.1-XP back > to 5.1-CURRENT. HAHAHAHAHAHAHAHAHAHHAHA!!!!!!!! -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:10:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14B0F37B404; Wed, 23 Jul 2003 13:10:10 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A1BDF43F75; Wed, 23 Jul 2003 13:10:09 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NKA90U030197; Wed, 23 Jul 2003 13:10:09 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NKA9iF030196; Wed, 23 Jul 2003 13:10:09 -0700 (PDT) Message-Id: <200307232010.h6NKA9iF030196@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 13:10:09 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:10:11 -0000 peter 2003/07/23 13:10:09 PDT FreeBSD src repository Modified files: sys/conf kern.pre.mk Log: Turn -Werror back on. Revision Changes Path 1.29 +1 -1 src/sys/conf/kern.pre.mk From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:15:50 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E61437B401; Wed, 23 Jul 2003 13:15:50 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A87243F85; Wed, 23 Jul 2003 13:15:50 -0700 (PDT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NKFn0U030552; Wed, 23 Jul 2003 13:15:49 -0700 (PDT) (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NKFnm0030551; Wed, 23 Jul 2003 13:15:49 -0700 (PDT) Message-Id: <200307232015.h6NKFnm0030551@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Wed, 23 Jul 2003 13:15:49 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/tinderbox tinderbox.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:15:51 -0000 des 2003/07/23 13:15:49 PDT FreeBSD src repository Modified files: tools/tools/tinderbox tinderbox.1 Log: Improve the markup a little. Revision Changes Path 1.4 +11 -11 src/tools/tools/tinderbox/tinderbox.1 From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:16:12 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC8FB37B401; Wed, 23 Jul 2003 13:16:12 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 612AB43FB1; Wed, 23 Jul 2003 13:16:12 -0700 (PDT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NKGC0U030590; Wed, 23 Jul 2003 13:16:12 -0700 (PDT) (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NKGB2o030589; Wed, 23 Jul 2003 13:16:11 -0700 (PDT) Message-Id: <200307232016.h6NKGB2o030589@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Wed, 23 Jul 2003 13:16:11 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/tinderbox tbmaster.1 tbmaster.pl X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:16:13 -0000 des 2003/07/23 13:16:11 PDT FreeBSD src repository Modified files: tools/tools/tinderbox tbmaster.1 tbmaster.pl Log: Rewrite tbmaster to use configuration files instead of a hard-coded hash. Revision Changes Path 1.3 +138 -108 src/tools/tools/tinderbox/tbmaster.1 1.30 +155 -155 src/tools/tools/tinderbox/tbmaster.pl From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:16:37 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3491737B401; Wed, 23 Jul 2003 13:16:37 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D324A43F75; Wed, 23 Jul 2003 13:16:36 -0700 (PDT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NKGa0U030649; Wed, 23 Jul 2003 13:16:36 -0700 (PDT) (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NKGaD5030648; Wed, 23 Jul 2003 13:16:36 -0700 (PDT) Message-Id: <200307232016.h6NKGaD5030648@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Wed, 23 Jul 2003 13:16:36 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/tinderbox Makefile ada.rc current.rc default.rc dsa.rc dwp.rc releng_4.rc stanley.rc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:16:37 -0000 des 2003/07/23 13:16:36 PDT FreeBSD src repository Modified files: tools/tools/tinderbox Makefile Added files: tools/tools/tinderbox ada.rc current.rc default.rc dsa.rc dwp.rc releng_4.rc stanley.rc Log: Sample configuration files. Revision Changes Path 1.6 +9 -0 src/tools/tools/tinderbox/Makefile 1.1 +10 -0 src/tools/tools/tinderbox/ada.rc (new) 1.1 +8 -0 src/tools/tools/tinderbox/current.rc (new) 1.1 +21 -0 src/tools/tools/tinderbox/default.rc (new) 1.1 +10 -0 src/tools/tools/tinderbox/dsa.rc (new) 1.1 +10 -0 src/tools/tools/tinderbox/dwp.rc (new) 1.1 +8 -0 src/tools/tools/tinderbox/releng_4.rc (new) 1.1 +11 -0 src/tools/tools/tinderbox/stanley.rc (new) From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:22:51 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C51237B404; Wed, 23 Jul 2003 13:22:51 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D837643FAF; Wed, 23 Jul 2003 13:22:50 -0700 (PDT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NKMo0U030868; Wed, 23 Jul 2003 13:22:50 -0700 (PDT) (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NKMo8V030867; Wed, 23 Jul 2003 13:22:50 -0700 (PDT) Message-Id: <200307232022.h6NKMo8V030867@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Wed, 23 Jul 2003 13:22:50 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/tinderbox Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:22:51 -0000 des 2003/07/23 13:22:50 PDT FreeBSD src repository Modified files: tools/tools/tinderbox Makefile Log: Install rc files from ${.CURDIR}, not ${.OBJDIR}. Revision Changes Path 1.7 +2 -1 src/tools/tools/tinderbox/Makefile From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:28:24 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 322EF37B401; Wed, 23 Jul 2003 13:28:24 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C370D43FB1; Wed, 23 Jul 2003 13:28:23 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NKSN0U031049; Wed, 23 Jul 2003 13:28:23 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NKSNeT031048; Wed, 23 Jul 2003 13:28:23 -0700 (PDT) Message-Id: <200307232028.h6NKSNeT031048@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 23 Jul 2003 13:28:23 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/include cpufunc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:28:24 -0000 phk 2003/07/23 13:28:23 PDT FreeBSD src repository Modified files: sys/i386/include cpufunc.h Log: Stop GCC from whining when people use a 16 bit port number for inb() and outb() Revision Changes Path 1.134 +2 -2 src/sys/i386/include/cpufunc.h From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:28:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2942537B404 for ; Wed, 23 Jul 2003 13:28:45 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 0FC2E43FBF for ; Wed, 23 Jul 2003 13:28:44 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 40061 invoked by uid 1000); 23 Jul 2003 20:28:45 -0000 Date: Wed, 23 Jul 2003 13:28:45 -0700 (PDT) From: Nate Lawson To: Peter Wemm In-Reply-To: <20030723200754.F3BD137B421@hub.freebsd.org> Message-ID: <20030723132810.U40029@root.org> References: <20030723200754.F3BD137B421@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:28:45 -0000 On Wed, 23 Jul 2003, Peter Wemm wrote: > Modified files: > sys/conf newvers.sh > Log: > ARGH. I *knew* I'd eventually accidently commit this. Change 5.1-XP back > to 5.1-CURRENT. > > Revision Changes Path > 1.55 +1 -1 src/sys/conf/newvers.sh I WANT MY CLOUDS AND SKY THEME BACK. PLEASE REVERT. -Nate From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:29:15 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BFD9837B401; Wed, 23 Jul 2003 13:29:14 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C700B43FA3; Wed, 23 Jul 2003 13:29:13 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NKTD0U031127; Wed, 23 Jul 2003 13:29:13 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NKTDHP031126; Wed, 23 Jul 2003 13:29:13 -0700 (PDT) Message-Id: <200307232029.h6NKTDHP031126@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 13:29:13 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_umtx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:29:15 -0000 peter 2003/07/23 13:29:13 PDT FreeBSD src repository Modified files: sys/kern kern_umtx.c Log: Initialize 'blocked' to NULL. I think this was a real problem, but I am not sure about that. The lack of -Werror and the inline noise hid this for a while. Revision Changes Path 1.12 +1 -0 src/sys/kern/kern_umtx.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:47:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A9D4337B401; Wed, 23 Jul 2003 13:47:25 -0700 (PDT) Received: from arthur.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id E427243F93; Wed, 23 Jul 2003 13:47:24 -0700 (PDT) (envelope-from simon@arthur.nitro.dk) Received: by arthur.nitro.dk (Postfix, from userid 1000) id ABE0D10BF82; Wed, 23 Jul 2003 22:47:22 +0200 (CEST) Date: Wed, 23 Jul 2003 22:47:22 +0200 From: "Simon L. Nielsen" To: Nate Lawson Message-ID: <20030723204721.GA1886@FreeBSD.org> References: <20030723132439.D550137B401@hub.freebsd.org> <20030723102603.O39567@root.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l" Content-Disposition: inline In-Reply-To: <20030723102603.O39567@root.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man7 Makefile rescue.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:47:26 -0000 --XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2003.07.23 10:26:54 -0700, Nate Lawson wrote: > What's it doing in section 7? I thought system utils are section 8? I thought section 7 was more appropriate, since rescue is not a command but rather a system. It was also a bit inspired by docs/35011, which argues that some of the parts of section 8 really should be in section 7. I guess it could be argued that it should be in section 8, but none of the reviwers commented on the section number. > On Wed, 23 Jul 2003, Simon L. Nielsen wrote: > > > > Modified files: > > share/man/man7 Makefile > > Added files: > > share/man/man7 rescue.7 > > Log: > > Add manual page to document the new rescue utilities in /rescue. > > > > Most text by: Tim Kientzle > > Reviewed by: ru, doc@ > > Approved by: ceri (mentor) > > > > Revision Changes Path > > 1.27 +1 -1 src/share/man/man7/Makefile > > 1.1 +182 -0 src/share/man/man7/rescue.7 (new) --=20 Simon L. Nielsen New PGP key 0x27359A51 Fingerprint: 912B F341 7E90 2049 05B4 3800 87DA 5C0D 2735 9A51 --XsQoSWH+UP9D9v3l Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQE/HvRZh9pcDSc1mlERAkk1AJ9TVhcld6M7JQM30vduEiMzURjhOwCdFzvF n5bt0252v6iP+CxR6Ka6QrE= =wXrJ -----END PGP SIGNATURE----- --XsQoSWH+UP9D9v3l-- From owner-cvs-src@FreeBSD.ORG Wed Jul 23 13:53:38 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E12F737B401; Wed, 23 Jul 2003 13:53:38 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E86F43F93; Wed, 23 Jul 2003 13:53:38 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NKrc0U032155; Wed, 23 Jul 2003 13:53:38 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NKrb0P032154; Wed, 23 Jul 2003 13:53:37 -0700 (PDT) Message-Id: <200307232053.h6NKrb0P032154@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 23 Jul 2003 13:53:37 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile src/release/i386 mkisoimages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 20:53:39 -0000 ru 2003/07/23 13:53:37 PDT FreeBSD src repository Modified files: release Makefile release/i386 mkisoimages.sh Log: Added the (undocumented) EMUL_BOOT variable (for TARGET=i386 only) that causes the bootable ISO images to be created using the floppy emulation (the old method) as opposed to the new "cdboot" method. Only copy boot.flp to the 2nd CD-ROM if this variable is defined. Reviewed by: murray Revision Changes Path 1.793 +6 -2 src/release/Makefile 1.8 +6 -4 src/release/i386/mkisoimages.sh From owner-cvs-src@FreeBSD.ORG Wed Jul 23 14:00:37 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A15137B413 for ; Wed, 23 Jul 2003 14:00:37 -0700 (PDT) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70D7D43FE1 for ; Wed, 23 Jul 2003 14:00:29 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 13310 invoked from network); 23 Jul 2003 21:00:28 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 23 Jul 2003 21:00:28 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6NL0QGI046718; Wed, 23 Jul 2003 17:00:27 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200307232053.h6NKrb0P032154@repoman.freebsd.org> Date: Wed, 23 Jul 2003 17:00:44 -0400 (EDT) From: John Baldwin To: Ruslan Ermilov cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/release Makefile src/release/i386 mkisoimages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 21:00:38 -0000 On 23-Jul-2003 Ruslan Ermilov wrote: > ru 2003/07/23 13:53:37 PDT > > FreeBSD src repository > > Modified files: > release Makefile > release/i386 mkisoimages.sh > Log: > Added the (undocumented) EMUL_BOOT variable (for TARGET=i386 only) > that causes the bootable ISO images to be created using the floppy > emulation (the old method) as opposed to the new "cdboot" method. > > Only copy boot.flp to the 2nd CD-ROM if this variable is defined. > > Reviewed by: murray I would always copy the floppy. The reason is so that all of the needed bits for both boot types are available to vendors. I can see vendors taking the contents of an ISO, mounting it using mdconfig, adding more bit in another dir, then using mkisofs to generate a new ISO with a different boot method. This would be done w/o rolling an entire release but using the ISO from the Project's release. In other words, I don't think we should require vendors to roll an entire release just to use boot.flp instead of cdboot or vice versa. Please just leave both cdboot and boot.flp on both ISOs. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Wed Jul 23 14:13:42 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E336E37B401; Wed, 23 Jul 2003 14:13:41 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5930D43F3F; Wed, 23 Jul 2003 14:13:29 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6NLDJ0U046645 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 24 Jul 2003 00:13:20 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6NLDJmR046640; Thu, 24 Jul 2003 00:13:19 +0300 (EEST) (envelope-from ru) Date: Thu, 24 Jul 2003 00:13:19 +0300 From: Ruslan Ermilov To: John Baldwin Message-ID: <20030723211319.GD41895@sunbay.com> References: <200307232053.h6NKrb0P032154@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IU5/I01NYhRvwH70" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile src/release/i386 mkisoimages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 21:13:44 -0000 --IU5/I01NYhRvwH70 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 23, 2003 at 05:00:44PM -0400, John Baldwin wrote: >=20 > On 23-Jul-2003 Ruslan Ermilov wrote: > > ru 2003/07/23 13:53:37 PDT > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > release Makefile=20 > > release/i386 mkisoimages.sh=20 > > Log: > > Added the (undocumented) EMUL_BOOT variable (for TARGET=3Di386 only) > > that causes the bootable ISO images to be created using the floppy > > emulation (the old method) as opposed to the new "cdboot" method. > > =20 > > Only copy boot.flp to the 2nd CD-ROM if this variable is defined. > > =20 > > Reviewed by: murray >=20 > I would always copy the floppy. The reason is so that all of the needed > bits for both boot types are available to vendors. >=20 Running "make release" with -DEMUL_BOOT but without -DMAKE_ISOS does just that. My intent was for a standard "make release" to not have unnecessary bits. There's no point in cdrom/disc2/floppies/boot.flp if we aren't even going to use it. > I can see vendors > taking the contents of an ISO, mounting it using mdconfig, adding more > bit in another dir, then using mkisofs to generate a new ISO with a > different boot method. This would be done w/o rolling an entire release > but using the ISO from the Project's release. In other words, I don't > think we should require vendors to roll an entire release just to use > boot.flp instead of cdboot or vice versa. Please just leave both cdboot > and boot.flp on both ISOs. >=20 boot.flp is always available on the 1st disc in a set anyway; I don't see a problem copying it from here to the custom 2nd disc. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --IU5/I01NYhRvwH70 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/HvpvUkv4P6juNwoRAiPPAJ9GdlglpO4tShXRu0MKhFtrNm0EFACaAuhy w/QQdYF9IWsyJ5HVFTLiGgs= =Ey9G -----END PGP SIGNATURE----- --IU5/I01NYhRvwH70-- From owner-cvs-src@FreeBSD.ORG Wed Jul 23 14:22:36 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBB0737B401; Wed, 23 Jul 2003 14:22:36 -0700 (PDT) Received: from magic.adaptec.com (magic-mail.adaptec.com [208.236.45.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id 400A143F93; Wed, 23 Jul 2003 14:22:36 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6/8.11.6) with ESMTP id h6NLMao12455; Wed, 23 Jul 2003 14:22:36 -0700 Received: from freebsd.org (hollin.btc.adaptec.com [10.100.253.56]) by redfish.adaptec.com (8.8.8p2+Sun/8.8.8) with ESMTP id OAA17655; Wed, 23 Jul 2003 14:22:35 -0700 (PDT) Message-ID: <3F1EFC12.3020506@freebsd.org> Date: Wed, 23 Jul 2003 15:20:18 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3) Gecko/20030414 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ruslan Ermilov References: <200307232053.h6NKrb0P032154@repoman.freebsd.org> <20030723211319.GD41895@sunbay.com> In-Reply-To: <20030723211319.GD41895@sunbay.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: John Baldwin Subject: Re: cvs commit: src/release Makefile src/release/i386 mkisoimages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 21:22:37 -0000 Ruslan Ermilov wrote: > On Wed, Jul 23, 2003 at 05:00:44PM -0400, John Baldwin wrote: > >>On 23-Jul-2003 Ruslan Ermilov wrote: >> >>>ru 2003/07/23 13:53:37 PDT >>> >>> FreeBSD src repository >>> >>> Modified files: >>> release Makefile >>> release/i386 mkisoimages.sh >>> Log: >>> Added the (undocumented) EMUL_BOOT variable (for TARGET=i386 only) >>> that causes the bootable ISO images to be created using the floppy >>> emulation (the old method) as opposed to the new "cdboot" method. >>> >>> Only copy boot.flp to the 2nd CD-ROM if this variable is defined. >>> >>> Reviewed by: murray >> >>I would always copy the floppy. The reason is so that all of the needed >>bits for both boot types are available to vendors. >> > > Running "make release" with -DEMUL_BOOT but without -DMAKE_ISOS does > just that. My intent was for a standard "make release" to not have > unnecessary bits. There's no point in cdrom/disc2/floppies/boot.flp > if we aren't even going to use it. > > >>I can see vendors >>taking the contents of an ISO, mounting it using mdconfig, adding more >>bit in another dir, then using mkisofs to generate a new ISO with a >>different boot method. This would be done w/o rolling an entire release >>but using the ISO from the Project's release. In other words, I don't >>think we should require vendors to roll an entire release just to use >>boot.flp instead of cdboot or vice versa. Please just leave both cdboot >>and boot.flp on both ISOs. >> > > boot.flp is always available on the 1st disc in a set anyway; I don't > see a problem copying it from here to the custom 2nd disc. > > > Cheers, I believe that John is asking for you to not limit the options that are available, and also not require that a 'make release' is re-run to have those options be available. Whether or not *you* choose to use this flexibility is not the point. I think that John's position is quite reasonable. Scott From owner-cvs-src@FreeBSD.ORG Wed Jul 23 14:25:20 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E893C37B401; Wed, 23 Jul 2003 14:25:20 -0700 (PDT) Received: from mx0.freebsd-services.com (survey.codeburst.net [195.149.39.161]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8362943F3F; Wed, 23 Jul 2003 14:25:19 -0700 (PDT) (envelope-from paul@freebsd-services.com) Received: by mx0.freebsd-services.com (Postfix, from userid 1002) id 305A21B211; Wed, 23 Jul 2003 22:25:17 +0100 (BST) Date: Wed, 23 Jul 2003 22:25:17 +0100 From: Paul Richards To: Poul-Henning Kamp Message-ID: <20030723212516.GE90991@survey.codeburst.net> References: <24542.1058985134@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24542.1058985134@critter.freebsd.dk> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: John Baldwin Subject: Re: cvs commit: src/sys/dev/rp rp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 21:25:21 -0000 On Wed, Jul 23, 2003 at 08:32:14PM +0200, Poul-Henning Kamp wrote: > In message , John Baldwin writes: > > > >On 23-Jul-2003 Poul-Henning Kamp wrote: > >> phk 2003/07/23 11:03:23 PDT > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/dev/rp rp.c > >> Log: > >> Undo single-intance inlining which is way above the comfort limit for GCC. > > > >Single instance inlining can not hurt. It can help by reducing call > >stack depth and code size however. I thought you were for reducing code > >size, not increasing it. Please use __always_inline to shut up gcc > >instead of de-inlining for single instance inlines. > > Please provide data showing actual improvement for inlining. > > If I changed this to __always_inline, I would change the code generated, > to start inlining these functions. We don't know the effect of that. > > Instead I preserve the status quo by removing the inline request which > GCC ignores. You're not preserving the status quo. You're preserving the *broken* behaviour of recent versions of gcc. This all worked fine until gcc broke and single-instance inlining is a perfectly valid programming practice for several reasons which have all been covered in this thread without you finding any counter argument and yet you're continuing to remove them. -- Paul. From owner-cvs-src@FreeBSD.ORG Wed Jul 23 14:26:17 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B5CBD37B401; Wed, 23 Jul 2003 14:26:17 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E3B343F93; Wed, 23 Jul 2003 14:26:17 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 391E12A7EA; Wed, 23 Jul 2003 14:26:17 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <200307232010.h6NKA9iF030196@repoman.freebsd.org> Date: Wed, 23 Jul 2003 14:26:17 -0700 From: Peter Wemm Message-Id: <20030723212617.391E12A7EA@canning.wemm.org> Subject: Re: cvs commit: src/sys/conf kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 21:26:18 -0000 Peter Wemm wrote: > peter 2003/07/23 13:10:09 PDT > > FreeBSD src repository > > Modified files: > sys/conf kern.pre.mk > Log: > Turn -Werror back on. Note that if you run into something that doesn't compile cleanly yet, you can use 'make WERROR=' when building the kernel. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From owner-cvs-src@FreeBSD.ORG Wed Jul 23 14:28:44 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E5D8E37B401; Wed, 23 Jul 2003 14:28:43 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2FC2E43FAF; Wed, 23 Jul 2003 14:28:38 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6NLSV0U048462 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 24 Jul 2003 00:28:31 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6NLSUmJ048461; Thu, 24 Jul 2003 00:28:30 +0300 (EEST) (envelope-from ru) Date: Thu, 24 Jul 2003 00:28:30 +0300 From: Ruslan Ermilov To: Scott Long Message-ID: <20030723212830.GA48101@sunbay.com> References: <200307232053.h6NKrb0P032154@repoman.freebsd.org> <20030723211319.GD41895@sunbay.com> <3F1EFC12.3020506@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline In-Reply-To: <3F1EFC12.3020506@freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: John Baldwin Subject: Re: cvs commit: src/release Makefile src/release/i386 mkisoimages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 21:28:44 -0000 --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 23, 2003 at 03:20:18PM -0600, Scott Long wrote: > Ruslan Ermilov wrote: > >On Wed, Jul 23, 2003 at 05:00:44PM -0400, John Baldwin wrote: > > > >>On 23-Jul-2003 Ruslan Ermilov wrote: > >> > >>>ru 2003/07/23 13:53:37 PDT > >>> > >>> FreeBSD src repository > >>> > >>> Modified files: > >>> release Makefile=20 > >>> release/i386 mkisoimages.sh=20 > >>> Log: > >>> Added the (undocumented) EMUL_BOOT variable (for TARGET=3Di386 only) > >>> that causes the bootable ISO images to be created using the floppy > >>> emulation (the old method) as opposed to the new "cdboot" method. > >>>=20 > >>> Only copy boot.flp to the 2nd CD-ROM if this variable is defined. > >>>=20 > >>> Reviewed by: murray > >> > >>I would always copy the floppy. The reason is so that all of the needed > >>bits for both boot types are available to vendors. > >> > > > >Running "make release" with -DEMUL_BOOT but without -DMAKE_ISOS does > >just that. My intent was for a standard "make release" to not have > >unnecessary bits. There's no point in cdrom/disc2/floppies/boot.flp > >if we aren't even going to use it. > > > > > >>I can see vendors > >>taking the contents of an ISO, mounting it using mdconfig, adding more > >>bit in another dir, then using mkisofs to generate a new ISO with a > >>different boot method. This would be done w/o rolling an entire release > >>but using the ISO from the Project's release. In other words, I don't > >>think we should require vendors to roll an entire release just to use > >>boot.flp instead of cdboot or vice versa. Please just leave both cdboot > >>and boot.flp on both ISOs. > >> > > > >boot.flp is always available on the 1st disc in a set anyway; I don't > >see a problem copying it from here to the custom 2nd disc. > > > > > >Cheers, >=20 > I believe that John is asking for you to not limit the options that are > available, and also not require that a 'make release' is re-run to have > those options be available. Whether or not *you* choose to use this > flexibility is not the point. I think that John's position is quite > reasonable. >=20 How is my change limiting it, please explain? mdconfig ... 2nd_cdrom_image mount it mess with the contents copy boot.flp from the 1st CD to floppies/boot.flp use mkisofs -b floppies/boot.flp Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/Hv3+Ukv4P6juNwoRAsQKAJ9DYkXANDpz9SNHujLO4MQSdDfFbgCeMaCu 8IHDMDrxLUUDyUV9DmGHlBg= =Nyhv -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z-- From owner-cvs-src@FreeBSD.ORG Wed Jul 23 14:36:36 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 11FD937B401; Wed, 23 Jul 2003 14:36:36 -0700 (PDT) Received: from magic.adaptec.com (magic-mail.adaptec.com [208.236.45.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DC2643FA3; Wed, 23 Jul 2003 14:36:35 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6/8.11.6) with ESMTP id h6NLaZo11659; Wed, 23 Jul 2003 14:36:35 -0700 Received: from freebsd.org (hollin.btc.adaptec.com [10.100.253.56]) by redfish.adaptec.com (8.8.8p2+Sun/8.8.8) with ESMTP id OAA25223; Wed, 23 Jul 2003 14:36:34 -0700 (PDT) Message-ID: <3F1EFF55.9040502@freebsd.org> Date: Wed, 23 Jul 2003 15:34:13 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3) Gecko/20030414 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Peter Wemm References: <20030723212617.391E12A7EA@canning.wemm.org> In-Reply-To: <20030723212617.391E12A7EA@canning.wemm.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 21:36:36 -0000 Peter Wemm wrote: > Peter Wemm wrote: > >>peter 2003/07/23 13:10:09 PDT >> >> FreeBSD src repository >> >> Modified files: >> sys/conf kern.pre.mk >> Log: >> Turn -Werror back on. > > > Note that if you run into something that doesn't compile cleanly yet, you > can use 'make WERROR=' when building the kernel. > > Cheers, > -Peter > -- > Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com > "All of this is for nothing if we don't go to the stars" - JMS/B5 > > I would have prefered that the few problems that are currently visible were fixed before turning this on. Scott From owner-cvs-src@FreeBSD.ORG Wed Jul 23 14:50:09 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E1F8837B401; Wed, 23 Jul 2003 14:50:09 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 71E6C43F85; Wed, 23 Jul 2003 14:50:09 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 621002A8B2; Wed, 23 Jul 2003 14:50:09 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <20030723212617.391E12A7EA@canning.wemm.org> Date: Wed, 23 Jul 2003 14:50:09 -0700 From: Peter Wemm Message-Id: <20030723215009.621002A8B2@canning.wemm.org> Subject: Re: cvs commit: src/sys/conf kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 21:50:10 -0000 Peter Wemm wrote: > Peter Wemm wrote: > > peter 2003/07/23 13:10:09 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/conf kern.pre.mk > > Log: > > Turn -Werror back on. > > Note that if you run into something that doesn't compile cleanly yet, you > can use 'make WERROR=' when building the kernel. It seems the INVARIANT_SUPPORT option has a big effect. I did my testing with that enabled along with INVARIANTS. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From owner-cvs-src@FreeBSD.ORG Wed Jul 23 14:54:24 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A41E37B401; Wed, 23 Jul 2003 14:54:24 -0700 (PDT) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F2A343F3F; Wed, 23 Jul 2003 14:54:22 -0700 (PDT) (envelope-from wkb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.12.9/8.12.9) with ESMTP id h6NLsLxd063164; Wed, 23 Jul 2003 23:54:21 +0200 (CEST) (envelope-from wkb@freebie.xs4all.nl) Received: (from wkb@localhost) by freebie.xs4all.nl (8.12.9/8.12.9/Submit) id h6NLsJs9063163; Wed, 23 Jul 2003 23:54:19 +0200 (CEST) Date: Wed, 23 Jul 2003 23:54:19 +0200 From: Wilko Bulte To: Nate Lawson Message-ID: <20030723215419.GA63135@freebie.xs4all.nl> References: <20030723200754.F3BD137B421@hub.freebsd.org> <20030723132810.U40029@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030723132810.U40029@root.org> User-Agent: Mutt/1.4i X-OS: FreeBSD 4.8-STABLE X-PGP: finger wilko@freebsd.org cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: Peter Wemm Subject: Re: cvs commit: src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 21:54:24 -0000 On Wed, Jul 23, 2003 at 01:28:45PM -0700, Nate Lawson wrote: > On Wed, 23 Jul 2003, Peter Wemm wrote: > > Modified files: > > sys/conf newvers.sh > > Log: > > ARGH. I *knew* I'd eventually accidently commit this. Change 5.1-XP back > > to 5.1-CURRENT. > > > > Revision Changes Path > > 1.55 +1 -1 src/sys/conf/newvers.sh > > I WANT MY CLOUDS AND SKY THEME BACK. PLEASE REVERT. /me packs a box of Genuine Dutch Clouds(TM) and ships them to Nate. -- | / o / /_ _ wilko@FreeBSD.org |/|/ / / /( (_) Bulte From owner-cvs-src@FreeBSD.ORG Wed Jul 23 15:00:09 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F1FC37B401; Wed, 23 Jul 2003 15:00:09 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4AFD643F85; Wed, 23 Jul 2003 15:00:09 -0700 (PDT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NM090U035870; Wed, 23 Jul 2003 15:00:09 -0700 (PDT) (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NM08vo035869; Wed, 23 Jul 2003 15:00:08 -0700 (PDT) Message-Id: <200307232200.h6NM08vo035869@repoman.freebsd.org> From: Diomidis Spinellis Date: Wed, 23 Jul 2003 15:00:08 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/sys connect.2 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 22:00:10 -0000 dds 2003/07/23 15:00:08 PDT FreeBSD src repository Modified files: lib/libc/sys connect.2 Log: Document an additional error return value. The connect(2) call can also return EACCES on non-Unix domain sockets as demonstrated by the following program: #include #include #include #include #include #include #include #include int main(int argc, char *argv[]) { struct sockaddr_in rem_addr; int sock; if ((sock = socket(AF_INET, SOCK_STREAM, 0)) < 0) { perror("socket"); exit(1); } bzero((char *)&rem_addr, sizeof(rem_addr)); rem_addr.sin_family = AF_INET; rem_addr.sin_addr.s_addr = INADDR_NONE; rem_addr.sin_port = htons(10000); if (connect(sock, (struct sockaddr *)&rem_addr, sizeof(rem_addr)) < 0) { perror("connect"); exit(1); } } The call chain returning this value is probably: kern/uipc_syscalls.c:connect kern/uipc_socket.c:soconnect netinet/tcp_usrreq.c:tcp_usr_connect netinet/tcp_output.c:tcp_output netinet/ip_output.c:ip_output Reviewed by: schweikh (mentor) MFC after: 2 weeks Revision Changes Path 1.24 +6 -0 src/lib/libc/sys/connect.2 From owner-cvs-src@FreeBSD.ORG Wed Jul 23 15:02:31 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1275537B401; Wed, 23 Jul 2003 15:02:31 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A22B543F3F; Wed, 23 Jul 2003 15:02:30 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NM2U0U036054; Wed, 23 Jul 2003 15:02:30 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NM2UA0036053; Wed, 23 Jul 2003 15:02:30 -0700 (PDT) Message-Id: <200307232202.h6NM2UA0036053@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 15:02:30 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 22:02:31 -0000 peter 2003/07/23 15:02:30 PDT FreeBSD src repository Modified files: sys/conf kern.pre.mk Log: Turn -Werror back off again. Leaving out the invariants options causes more trouble than I expected. Revision Changes Path 1.30 +1 -1 src/sys/conf/kern.pre.mk From owner-cvs-src@FreeBSD.ORG Wed Jul 23 15:04:22 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7174537B401; Wed, 23 Jul 2003 15:04:22 -0700 (PDT) Received: from pool-151-200-10-97.res.east.verizon.net (pool-141-156-222-108.res.east.verizon.net [141.156.222.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 53ACE43F93; Wed, 23 Jul 2003 15:04:21 -0700 (PDT) (envelope-from mtm@identd.net) Received: from kokeb.ambesa.net (3o77zfd3uqo26ycy@localhost [127.0.0.1]) id h6NM4K49062911; Wed, 23 Jul 2003 18:04:20 -0400 (EDT) (envelope-from mtm@identd.net) Received: (from mtm@localhost) by kokeb.ambesa.net (8.12.9/8.12.9/Submit) id h6NM4JtC062910; Wed, 23 Jul 2003 18:04:19 -0400 (EDT) (envelope-from mtm@identd.net) X-Authentication-Warning: kokeb.ambesa.net: mtm set sender to mtm@identd.net using -f Date: Wed, 23 Jul 2003 18:04:19 -0400 From: Mike Makonnen To: Peter Wemm Message-ID: <20030723220418.GA62833@kokeb.ambesa.net> References: <200307232029.h6NKTDHP031126@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307232029.h6NKTDHP031126@repoman.freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD/5.1-CURRENT (i386) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_umtx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 22:04:23 -0000 On Wed, Jul 23, 2003 at 01:29:13PM -0700, Peter Wemm wrote: > peter 2003/07/23 13:29:13 PDT > > FreeBSD src repository > > Modified files: > sys/kern kern_umtx.c > Log: > Initialize 'blocked' to NULL. I think this was a real problem, but I > am not sure about that. The lack of -Werror and the inline noise hid > this for a while. No, I don't think it was a problem. It does get initialized before use in the same if.. statement it is compared in: uq = umtx_lookup(td, umtx); if (uq == NULL || (uq != NULL && (blocked = TAILQ_FIRST(&uq->uq_tdq)) != NULL && ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ It might be against style, though. Cheers. -- Mike Makonnen | GPG-KEY: http://www.identd.net/~mtm/mtm.asc mtm@identd.net | D228 1A6F C64E 120A A1C9 A3AA DAE1 E2AF DBCC 68B9 mtm@FreeBSD.Org| FreeBSD - Unleash the Daemon! From owner-cvs-src@FreeBSD.ORG Wed Jul 23 15:08:26 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 48EC937B401; Wed, 23 Jul 2003 15:08:26 -0700 (PDT) Received: from pool-151-200-10-97.res.east.verizon.net (pool-141-156-222-108.res.east.verizon.net [141.156.222.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4BCC343F75; Wed, 23 Jul 2003 15:08:24 -0700 (PDT) (envelope-from mtm@identd.net) Received: from kokeb.ambesa.net (jbng1nt9a1wpru62@localhost [127.0.0.1]) id h6NM8G49062938; Wed, 23 Jul 2003 18:08:16 -0400 (EDT) (envelope-from mtm@identd.net) Received: (from mtm@localhost) by kokeb.ambesa.net (8.12.9/8.12.9/Submit) id h6NM8GDc062937; Wed, 23 Jul 2003 18:08:16 -0400 (EDT) (envelope-from mtm@identd.net) X-Authentication-Warning: kokeb.ambesa.net: mtm set sender to mtm@identd.net using -f Date: Wed, 23 Jul 2003 18:08:16 -0400 From: Mike Makonnen To: Peter Wemm Message-ID: <20030723220816.GB62833@kokeb.ambesa.net> References: <200307232029.h6NKTDHP031126@repoman.freebsd.org> <20030723220418.GA62833@kokeb.ambesa.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030723220418.GA62833@kokeb.ambesa.net> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD/5.1-CURRENT (i386) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_umtx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 22:08:26 -0000 On Wed, Jul 23, 2003 at 06:04:19PM -0400, Mike Makonnen wrote: > > No, I don't think it was a problem. It does get initialized before > use in the same if.. statement it is compared in: > > uq = umtx_lookup(td, umtx); > if (uq == NULL || > (uq != NULL && (blocked = TAILQ_FIRST(&uq->uq_tdq)) != NULL && > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Argh, I don't know why I bother to open my mouth lately. I see where it was happening. Just ignore me... Cheers. -- Mike Makonnen | GPG-KEY: http://www.identd.net/~mtm/mtm.asc mtm@identd.net | D228 1A6F C64E 120A A1C9 A3AA DAE1 E2AF DBCC 68B9 mtm@FreeBSD.Org| FreeBSD - Unleash the Daemon! From owner-cvs-src@FreeBSD.ORG Wed Jul 23 15:36:00 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 090DF37B401 for ; Wed, 23 Jul 2003 15:36:00 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 9323D43FB1 for ; Wed, 23 Jul 2003 15:35:58 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 40356 invoked by uid 1000); 23 Jul 2003 22:35:59 -0000 Date: Wed, 23 Jul 2003 15:35:59 -0700 (PDT) From: Nate Lawson To: Mike Makonnen In-Reply-To: <20030723220418.GA62833@kokeb.ambesa.net> Message-ID: <20030723153526.O40342@root.org> References: <200307232029.h6NKTDHP031126@repoman.freebsd.org> <20030723220418.GA62833@kokeb.ambesa.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Peter Wemm Subject: Re: cvs commit: src/sys/kern kern_umtx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 22:36:00 -0000 On Wed, 23 Jul 2003, Mike Makonnen wrote: > On Wed, Jul 23, 2003 at 01:29:13PM -0700, Peter Wemm wrote: > > peter 2003/07/23 13:29:13 PDT > > sys/kern kern_umtx.c > > Log: > > Initialize 'blocked' to NULL. I think this was a real problem, but I > > am not sure about that. The lack of -Werror and the inline noise hid > > this for a while. > > No, I don't think it was a problem. It does get initialized before > use in the same if.. statement it is compared in: > > uq = umtx_lookup(td, umtx); > if (uq == NULL || > (uq != NULL && (blocked = TAILQ_FIRST(&uq->uq_tdq)) != NULL && > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > It might be against style, though. That isn't an initialization, that's assignment. -Nate From owner-cvs-src@FreeBSD.ORG Wed Jul 23 16:17:16 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5807E37B401; Wed, 23 Jul 2003 16:17:16 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E8FB243F85; Wed, 23 Jul 2003 16:17:15 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NNHF0U042723; Wed, 23 Jul 2003 16:17:15 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NNHF1M042722; Wed, 23 Jul 2003 16:17:15 -0700 (PDT) Message-Id: <200307232317.h6NNHF1M042722@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 16:17:15 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 sys_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 23:17:16 -0000 peter 2003/07/23 16:17:15 PDT FreeBSD src repository Modified files: sys/amd64/amd64 sys_machdep.c Log: Set the %gs base to pcb_gsbase, not pcb_fsbase. Oops. Discovered by: davidxu Revision Changes Path 1.84 +1 -1 src/sys/amd64/amd64/sys_machdep.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 16:20:21 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8824F37B401; Wed, 23 Jul 2003 16:20:21 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 247F343F75; Wed, 23 Jul 2003 16:20:21 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NNKK0U042855; Wed, 23 Jul 2003 16:20:20 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NNKKQp042854; Wed, 23 Jul 2003 16:20:20 -0700 (PDT) Message-Id: <200307232320.h6NNKKQp042854@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 16:20:20 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 23:20:22 -0000 peter 2003/07/23 16:20:20 PDT FreeBSD src repository Modified files: sys/amd64/amd64 machdep.c Log: Make the breakpoint instruction trap gate available to users. ptrace() needs this. Submitted by: Mark Kettenis Revision Changes Path 1.585 +1 -1 src/sys/amd64/amd64/machdep.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 16:44:07 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC11137B404; Wed, 23 Jul 2003 16:44:07 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC2F243FA3; Wed, 23 Jul 2003 16:44:06 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.9/8.12.3) with ESMTP id h6NNhlFL061901; Wed, 23 Jul 2003 17:43:47 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 23 Jul 2003 17:43:42 -0600 (MDT) Message-Id: <20030723.174342.72711741.imp@bsdimp.com> To: jhb@FreeBSD.org From: "M. Warner Losh" In-Reply-To: References: <20030722.164223.00776481.imp@bsdimp.com> X-Mailer: Mew version 2.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: bde@zeta.org.au cc: paul@freebsd-services.com cc: cvs-src@FreeBSD.org cc: das@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 23:44:08 -0000 In message: John Baldwin writes: : Umm, you should be having to unload if_wi then when unloading pccard. No you should not. it is a big pain in the ass, and completely unnecessary. : If if_wi tries to call a pccard method on an attached pccard device : after pccard is unloaded, I'm sure lots of things are going to break. it can't do that. When pccard detaches, it detaches its children. with nothing there to reattach the devices to pccard. : Hmmm. I guess if unloading pccard detaches all pccard devices and their : children then it is safe if you always use KOBJ methods and never link : against any functions for your bus attachments. That's why pccard tries very hard to refuse to export ANY symbols that pccard client drivers use. Other busses should do likewise. warner From owner-cvs-src@FreeBSD.ORG Wed Jul 23 16:50:01 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 17C9837B401; Wed, 23 Jul 2003 16:50:01 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A93FC43F85; Wed, 23 Jul 2003 16:50:00 -0700 (PDT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NNo00U049297; Wed, 23 Jul 2003 16:50:00 -0700 (PDT) (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NNo0ks049296; Wed, 23 Jul 2003 16:50:00 -0700 (PDT) Message-Id: <200307232350.h6NNo0ks049296@repoman.freebsd.org> From: Warner Losh Date: Wed, 23 Jul 2003 16:50:00 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/devd devd.cc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 23:50:01 -0000 imp 2003/07/23 16:50:00 PDT FreeBSD src repository Modified files: sbin/devd devd.cc Log: Remove old workaround Revision Changes Path 1.16 +1 -3 src/sbin/devd/devd.cc From owner-cvs-src@FreeBSD.ORG Wed Jul 23 16:50:26 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A95037B405; Wed, 23 Jul 2003 16:50:26 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB97443FBD; Wed, 23 Jul 2003 16:50:25 -0700 (PDT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NNoP0U049367; Wed, 23 Jul 2003 16:50:25 -0700 (PDT) (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NNoPcm049366; Wed, 23 Jul 2003 16:50:25 -0700 (PDT) Message-Id: <200307232350.h6NNoPcm049366@repoman.freebsd.org> From: Warner Losh Date: Wed, 23 Jul 2003 16:50:25 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/devd token.l X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 23:50:26 -0000 imp 2003/07/23 16:50:25 PDT FreeBSD src repository Modified files: sbin/devd token.l Log: Simplistic C comment re is wrong, use more correct one Revision Changes Path 1.4 +1 -1 src/sbin/devd/token.l From owner-cvs-src@FreeBSD.ORG Wed Jul 23 17:04:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BAF8A37B401; Wed, 23 Jul 2003 17:04:02 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57F9643FAF; Wed, 23 Jul 2003 17:04:02 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O0420U050870; Wed, 23 Jul 2003 17:04:02 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O0424f050869; Wed, 23 Jul 2003 17:04:02 -0700 (PDT) Message-Id: <200307240004.h6O0424f050869@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 17:04:02 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/tar/src tar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 00:04:03 -0000 peter 2003/07/23 17:04:02 PDT FreeBSD src repository Modified files: contrib/tar/src tar.c Log: Fix an annoying bug in tar. When it converted 'tar zcf' to 'tar -z -c -f' it forgot to null terminate the new argv[] array. If you mixed this with $TAR_OPTIONS, phkmalloc and a whole bunch of other variables, you could end up with a segfault. This isn't strictly a phkmalloc victory since tar walks off the end of an array rather than use uninitialized malloc memory, but phkmalloc makes it easier to provoke. Revision Changes Path 1.3 +4 -1 src/contrib/tar/src/tar.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 17:12:49 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFB9A37B401 for ; Wed, 23 Jul 2003 17:12:48 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id A09B943FE0 for ; Wed, 23 Jul 2003 17:12:47 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 40501 invoked by uid 1000); 24 Jul 2003 00:12:49 -0000 Date: Wed, 23 Jul 2003 17:12:49 -0700 (PDT) From: Nate Lawson To: Peter Wemm In-Reply-To: <20030724000408.E479E37B481@hub.freebsd.org> Message-ID: <20030723171139.I40342@root.org> References: <20030724000408.E479E37B481@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/tar/src tar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 00:12:49 -0000 On Wed, 23 Jul 2003, Peter Wemm wrote: > Fix an annoying bug in tar. When it converted 'tar zcf' to 'tar -z -c -f' > it forgot to null terminate the new argv[] array. If you mixed this > with $TAR_OPTIONS, phkmalloc and a whole bunch of other variables, you > could end up with a segfault. This isn't strictly a phkmalloc victory > since tar walks off the end of an array rather than use uninitialized > malloc memory, but phkmalloc makes it easier to provoke. > > Revision Changes Path > 1.3 +4 -1 src/contrib/tar/src/tar.c It is a victory for the Peter Murphy field though since without it, we would never have triggered this bug. -Nate From owner-cvs-src@FreeBSD.ORG Wed Jul 23 17:15:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D49737B401; Wed, 23 Jul 2003 17:15:33 -0700 (PDT) Received: from smtp.omnis.com (smtp.omnis.com [216.239.128.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9312043FCB; Wed, 23 Jul 2003 17:15:32 -0700 (PDT) (envelope-from wes@softweyr.com) Received: from salty.rapid.stbernard.com (corp-2.ipinc.com [199.245.188.2]) by smtp-relay.omnis.com (Postfix) with ESMTP id DFFFC9BEA8; Wed, 23 Jul 2003 17:15:31 -0700 (PDT) From: Wes Peters Organization: Softweyr.com To: Bruce Evans , Poul-Henning Kamp Date: Wed, 23 Jul 2003 17:15:31 -0700 User-Agent: KMail/1.5.2 References: <10036.1058870835@critter.freebsd.dk> <20030722235600.X8165@gamplex.bde.org> In-Reply-To: <20030722235600.X8165@gamplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200307231715.31186.wes@softweyr.com> cc: Paul Richards cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 00:15:34 -0000 On Tuesday 22 July 2003 07:17, Bruce Evans wrote: > On Tue, 22 Jul 2003, Poul-Henning Kamp wrote: > > Paul Richards writes: > > > > > >Both of those functions were called from just one place, inside > > > the interrupt handler. Is there any reason to not inline them? > > > > Yes, we need to get -Werror on the kernel again, and GCC whines > > about ridiculously large functions. > > I think you mean "gcc emits the requested diagnostic about functions > that it doesn't inline, whether they are large or small". > > Just turn off -Winline to not request this diagnostic. > > > Inline should not be used unless it has a measurable impact on > > performance. > > Several places, including if_lnc.c, used __inline to get cleaner code > at no cost in performance. Removing __inline adds a tiny cost. Not if the compiler didn't actually *do* the inline, right? -- "Where am I, and what am I doing in this handbasket?" Wes Peters wes@softweyr.com From owner-cvs-src@FreeBSD.ORG Wed Jul 23 17:31:31 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C053A37B401; Wed, 23 Jul 2003 17:31:31 -0700 (PDT) Received: from possum.cryptohill.net (cambist.cryptohill.net [24.244.145.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id EEB9743F93; Wed, 23 Jul 2003 17:31:30 -0700 (PDT) (envelope-from jeroen@vangelderen.org) Received: from vangelderen.org (grolsch.cryptohill.net [24.244.145.13]) by possum.cryptohill.net (Postfix) with ESMTP id 662A8AE300; Wed, 23 Jul 2003 20:31:28 -0400 (EDT) Date: Wed, 23 Jul 2003 20:31:27 -0400 Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v552) To: Wilko Bulte From: "Jeroen C. van Gelderen" In-Reply-To: <20030723215419.GA63135@freebie.xs4all.nl> Message-Id: <29C8FA46-BD6E-11D7-BF05-000393754B1C@vangelderen.org> Content-Transfer-Encoding: 7bit X-Mailer: Apple Mail (2.552) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: Peter Wemm cc: Nate Lawson Subject: Re: cvs commit: src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 00:31:32 -0000 On Wednesday, Jul 23, 2003, at 17:54 US/Eastern, Wilko Bulte wrote: > On Wed, Jul 23, 2003 at 01:28:45PM -0700, Nate Lawson wrote: >> On Wed, 23 Jul 2003, Peter Wemm wrote: >>> Modified files: >>> sys/conf newvers.sh >>> Log: >>> ARGH. I *knew* I'd eventually accidently commit this. Change >>> 5.1-XP back >>> to 5.1-CURRENT. >>> >>> Revision Changes Path >>> 1.55 +1 -1 src/sys/conf/newvers.sh >> >> I WANT MY CLOUDS AND SKY THEME BACK. PLEASE REVERT. > > /me packs a box of Genuine Dutch Clouds(TM) and ships them to Nate. /my Genuinely Dutch hands FedEx some Bahamiam Clouds(TM) to Nate. -J -- Jeroen C. van Gelderen - jeroen@vangelderen.org Do not fear to be eccentric in opinion, for every opinion now accepted was once eccentric. -- Bertrand Russel From owner-cvs-src@FreeBSD.ORG Wed Jul 23 17:10:58 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 51FD137B401; Wed, 23 Jul 2003 17:10:58 -0700 (PDT) Received: from smtp.omnis.com (smtp.omnis.com [216.239.128.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 84FBC43FAF; Wed, 23 Jul 2003 17:10:57 -0700 (PDT) (envelope-from wes@softweyr.com) Received: from salty.rapid.stbernard.com (corp-2.ipinc.com [199.245.188.2]) by smtp-relay.omnis.com (Postfix) with ESMTP id 18C599BE83; Wed, 23 Jul 2003 17:10:56 -0700 (PDT) From: Wes Peters Organization: Softweyr.com To: "Poul-Henning Kamp" , Peter Wemm Date: Wed, 23 Jul 2003 17:10:46 -0700 User-Agent: KMail/1.5.2 References: <16642.1058917403@critter.freebsd.dk> In-Reply-To: <16642.1058917403@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200307231710.46896.wes@softweyr.com> X-Mailman-Approved-At: Wed, 23 Jul 2003 18:09:27 -0700 cc: "Alan L. Cox" cc: src-committers@FreeBSD.org cc: Bosko Milekic cc: Bruce Evans cc: cvs-src@FreeBSD.org cc: Steve Kargl cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 00:10:58 -0000 On Tuesday 22 July 2003 16:43, Poul-Henning Kamp wrote: > > I think we all, me included, have to admit that we have seldom if > ever actually benchmarked or even just checked the size impact of > the inlines we have put in, mostly we have relied on our intuition > to determine where an inline made sense. > > And now GCC has told us that we were wrong in some number of > the cases and that should prompt us to trust our intuition a little > bit less and rely more on actual facts instead. As a general note, I think it is quite hard to predict how any such "optimization" is going to behave across even the common x86 family processors. We've seen many times that optimizing for p4 is not the same as optimizing for Athlon, etc. These days, benchmark results on a single architecture are arguably no more valid than no benchmark results at all. That said, "my athlon is your athlon" (XP 2000+, will be running -current after this weekend) for anyone who needs one for testing. Not a speed daemon by todays standards, but it was yesterday... -- "Where am I, and what am I doing in this handbasket?" Wes Peters wes@softweyr.com From owner-cvs-src@FreeBSD.ORG Wed Jul 23 18:41:36 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C540337B401; Wed, 23 Jul 2003 18:41:35 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 634F743F93; Wed, 23 Jul 2003 18:41:35 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O1fZ0U055431; Wed, 23 Jul 2003 18:41:35 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O1fZ4C055430; Wed, 23 Jul 2003 18:41:35 -0700 (PDT) Message-Id: <200307240141.h6O1fZ4C055430@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 18:41:35 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 01:41:37 -0000 peter 2003/07/23 18:41:35 PDT FreeBSD src repository Modified files: usr.sbin Makefile Log: Attach acpi, boot0cfg, lptcontrol, sicontrol, spkrtest, zzz for amd64. Revision Changes Path 1.263 +11 -1 src/usr.sbin/Makefile From owner-cvs-src@FreeBSD.ORG Wed Jul 23 18:42:50 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CEE337B401; Wed, 23 Jul 2003 18:42:50 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9EA2343FAF; Wed, 23 Jul 2003 18:42:49 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O1gn0U055478; Wed, 23 Jul 2003 18:42:49 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O1gn7m055477; Wed, 23 Jul 2003 18:42:49 -0700 (PDT) Message-Id: <200307240142.h6O1gn7m055477@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 18:42:49 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 01:42:50 -0000 peter 2003/07/23 18:42:49 PDT FreeBSD src repository Modified files: sbin Makefile Log: Build /sbin/gpt on amd64 for good luck as well. Revision Changes Path 1.124 +2 -1 src/sbin/Makefile From owner-cvs-src@FreeBSD.ORG Wed Jul 23 18:59:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED4D637B401; Wed, 23 Jul 2003 18:59:18 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8535A43F75; Wed, 23 Jul 2003 18:59:18 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O1xI0U056138; Wed, 23 Jul 2003 18:59:18 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O1xIFE056137; Wed, 23 Jul 2003 18:59:18 -0700 (PDT) Message-Id: <200307240159.h6O1xIFE056137@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 18:59:18 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netncp ncp_ncp.c src/sys/netsmb smb_usr.c src/sys/fs/smbfs smbfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 01:59:19 -0000 peter 2003/07/23 18:59:18 PDT FreeBSD src repository Modified files: sys/netncp ncp_ncp.c sys/netsmb smb_usr.c sys/fs/smbfs smbfs_vfsops.c Log: size_t != int. Make this compile on 64 bit platforms (eg: amd64). Also, "u_short value; if (value > 0xffff)" can never be true. Revision Changes Path 1.20 +2 -1 src/sys/fs/smbfs/smbfs_vfsops.c 1.18 +2 -1 src/sys/netncp/ncp_ncp.c 1.5 +1 -2 src/sys/netsmb/smb_usr.c From owner-cvs-src@FreeBSD.ORG Wed Jul 23 19:05:49 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2A9D37B401; Wed, 23 Jul 2003 19:05:49 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40E8A43F3F; Wed, 23 Jul 2003 19:05:49 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O25n0U057371; Wed, 23 Jul 2003 19:05:49 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O25mjX057370; Wed, 23 Jul 2003 19:05:48 -0700 (PDT) Message-Id: <200307240205.h6O25mjX057370@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 19:05:48 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 02:05:50 -0000 peter 2003/07/23 19:05:48 PDT FreeBSD src repository Modified files: lib Makefile Log: Connect libncp/libsmb to the build. They compile, but have a couple of silly bugs that probably wont quite make a segfault. eg: passing a pointer to an int to sysctl instead of a pointer to a size_t. Revision Changes Path 1.165 +5 -0 src/lib/Makefile From owner-cvs-src@FreeBSD.ORG Wed Jul 23 19:07:15 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2639837B401; Wed, 23 Jul 2003 19:07:15 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4E1A43F85; Wed, 23 Jul 2003 19:07:14 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O27E0U057422; Wed, 23 Jul 2003 19:07:14 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O27Eba057421; Wed, 23 Jul 2003 19:07:14 -0700 (PDT) Message-Id: <200307240207.h6O27Eba057421@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 19:07:14 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 02:07:15 -0000 peter 2003/07/23 19:07:14 PDT FreeBSD src repository Modified files: usr.sbin Makefile Log: Add mount_nwfs/mount_smbfs to the build for amd64. Revision Changes Path 1.264 +2 -0 src/usr.sbin/Makefile From owner-cvs-src@FreeBSD.ORG Wed Jul 23 19:09:22 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 56E2237B401; Wed, 23 Jul 2003 19:09:20 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E613843FBF; Wed, 23 Jul 2003 19:09:19 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O29J0U057486; Wed, 23 Jul 2003 19:09:19 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O29JFl057485; Wed, 23 Jul 2003 19:09:19 -0700 (PDT) Message-Id: <200307240209.h6O29JFl057485@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 19:09:19 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 02:09:22 -0000 peter 2003/07/23 19:09:19 PDT FreeBSD src repository Modified files: usr.bin Makefile Log: Connect ncplist, ncplogin, and smbutil to the amd64 build. Revision Changes Path 1.244 +6 -0 src/usr.bin/Makefile From owner-cvs-src@FreeBSD.ORG Wed Jul 23 23:11:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8CE5837B401; Wed, 23 Jul 2003 23:11:30 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6972343F93; Wed, 23 Jul 2003 23:11:26 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id QAA13196; Thu, 24 Jul 2003 16:11:00 +1000 Date: Thu, 24 Jul 2003 16:10:59 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Wes Peters In-Reply-To: <200307231715.31186.wes@softweyr.com> Message-ID: <20030724160423.L3020@gamplex.bde.org> References: <10036.1058870835@critter.freebsd.dk> <20030722235600.X8165@gamplex.bde.org> <200307231715.31186.wes@softweyr.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Paul Richards cc: cvs-src@FreeBSD.org cc: Poul-Henning Kamp cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 06:11:31 -0000 On Wed, 23 Jul 2003, Wes Peters wrote: > On Tuesday 22 July 2003 07:17, Bruce Evans wrote: > > Several places, including if_lnc.c, used __inline to get cleaner code > > at no cost in performance. Removing __inline adds a tiny cost. > > Not if the compiler didn't actually *do* the inline, right? Removing the inline gives the same tiny cost as not doing it, except it costs more in bogusness points (since the bogusness is in the source code instead of in the compiler). Bruce From owner-cvs-src@FreeBSD.ORG Thu Jul 24 00:19:56 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9903037B401; Thu, 24 Jul 2003 00:19:56 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2ED6A43F3F; Thu, 24 Jul 2003 00:19:56 -0700 (PDT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O7Jt0U078782; Thu, 24 Jul 2003 00:19:55 -0700 (PDT) (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O7JtIC078781; Thu, 24 Jul 2003 00:19:55 -0700 (PDT) Message-Id: <200307240719.h6O7JtIC078781@repoman.freebsd.org> From: Mark Murray Date: Thu, 24 Jul 2003 00:19:55 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libtelnet Makefile src/libexec/telnetd Makefile src/usr.bin/telnet Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 07:19:57 -0000 markm 2003/07/24 00:19:55 PDT FreeBSD src repository Modified files: lib/libtelnet Makefile libexec/telnetd Makefile usr.bin/telnet Makefile Log: Ensure that for the cryptographic instances of *telnet*, the "crypto" distribution is used. This only affects release-building. Revision Changes Path 1.17 +1 -0 src/lib/libtelnet/Makefile 1.22 +1 -0 src/libexec/telnetd/Makefile 1.24 +1 -0 src/usr.bin/telnet/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jul 24 00:34:31 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E454937B401; Thu, 24 Jul 2003 00:34:31 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F9D543F75; Thu, 24 Jul 2003 00:34:31 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O7YV0U079333; Thu, 24 Jul 2003 00:34:31 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O7YVCZ079332; Thu, 24 Jul 2003 00:34:31 -0700 (PDT) Message-Id: <200307240734.h6O7YVCZ079332@repoman.freebsd.org> From: Marcel Moolenaar Date: Thu, 24 Jul 2003 00:34:31 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/include ucontext.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 07:34:32 -0000 marcel 2003/07/24 00:34:31 PDT FreeBSD src repository Modified files: sys/alpha/include ucontext.h Log: Use a spare for the thread pointer (mc_thrptr). The thread pointer is only read and written by set_mcontext() and get_mcontext() for use by threading libraries. Revision Changes Path 1.7 +2 -1 src/sys/alpha/include/ucontext.h From owner-cvs-src@FreeBSD.ORG Thu Jul 24 00:41:09 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C9B337B401; Thu, 24 Jul 2003 00:41:09 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ABC8343FA3; Thu, 24 Jul 2003 00:41:08 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O7f80U079689; Thu, 24 Jul 2003 00:41:08 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O7f8QB079688; Thu, 24 Jul 2003 00:41:08 -0700 (PDT) Message-Id: <200307240741.h6O7f8QB079688@repoman.freebsd.org> From: Marcel Moolenaar Date: Thu, 24 Jul 2003 00:41:08 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/include alpha_cpu.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 07:41:09 -0000 marcel 2003/07/24 00:41:08 PDT FreeBSD src repository Modified files: sys/alpha/include alpha_cpu.h Log: Implement alpha_pal_wrunique() and alpha_pal_rdunique(). Both are used to set and get the thread pointer. Note that a context switch will automaticly save and restore the thread pointer. Revision Changes Path 1.10 +17 -0 src/sys/alpha/include/alpha_cpu.h From owner-cvs-src@FreeBSD.ORG Thu Jul 24 00:42:43 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3809737B401; Thu, 24 Jul 2003 00:42:43 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C7B1343F75; Thu, 24 Jul 2003 00:42:42 -0700 (PDT) (envelope-from gordon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O7gg0U079737; Thu, 24 Jul 2003 00:42:42 -0700 (PDT) (envelope-from gordon@repoman.freebsd.org) Received: (from gordon@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O7ggZl079736; Thu, 24 Jul 2003 00:42:42 -0700 (PDT) Message-Id: <200307240742.h6O7ggZl079736@repoman.freebsd.org> From: Gordon Tetlow Date: Thu, 24 Jul 2003 00:42:42 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/rescue/rescue Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 07:42:43 -0000 gordon 2003/07/24 00:42:42 PDT FreeBSD src repository Modified files: rescue/rescue Makefile Log: Fix rescue build using -j. The problem appears to be make not being able to find the source when the object was specified as /foo.o. The fix makes the build go through a make objs before compiling the rest of the crunchgen. This ensures that the dhclient bits are built in the correct place where they are picked up for the final compile of rescue. I'd like to thank dwhite@ and gad@ for helping me track down the problem. Fast testing box provided by: phk@ (thanks) Revision Changes Path 1.14 +3 -2 src/rescue/rescue/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jul 24 00:48:12 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A47337B401; Thu, 24 Jul 2003 00:48:12 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB82443F93; Thu, 24 Jul 2003 00:48:11 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O7mB0U085322; Thu, 24 Jul 2003 00:48:11 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O7mBvk085321; Thu, 24 Jul 2003 00:48:11 -0700 (PDT) Message-Id: <200307240748.h6O7mBvk085321@repoman.freebsd.org> From: Marcel Moolenaar Date: Thu, 24 Jul 2003 00:48:11 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 07:48:12 -0000 marcel 2003/07/24 00:48:11 PDT FreeBSD src repository Modified files: sys/alpha/alpha machdep.c Log: In get_mcontext() and set_mcontext() save and restore the current thread pointer. Revision Changes Path 1.206 +15 -3 src/sys/alpha/alpha/machdep.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 00:49:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D74F537B401; Thu, 24 Jul 2003 00:49:45 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7148A43F3F; Thu, 24 Jul 2003 00:49:45 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O7nj0U085375; Thu, 24 Jul 2003 00:49:45 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O7njxL085374; Thu, 24 Jul 2003 00:49:45 -0700 (PDT) Message-Id: <200307240749.h6O7njxL085374@repoman.freebsd.org> From: Marcel Moolenaar Date: Thu, 24 Jul 2003 00:49:45 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha machdep.c support.s X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 07:49:46 -0000 marcel 2003/07/24 00:49:45 PDT FreeBSD src repository Modified files: sys/alpha/alpha machdep.c support.s Log: Implement casuptr(). Revision Changes Path 1.207 +0 -6 src/sys/alpha/alpha/machdep.c 1.15 +29 -1 src/sys/alpha/alpha/support.s From owner-cvs-src@FreeBSD.ORG Thu Jul 24 00:51:50 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B115D37B401; Thu, 24 Jul 2003 00:51:50 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4BD6343F75; Thu, 24 Jul 2003 00:51:50 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O7po0U085578; Thu, 24 Jul 2003 00:51:50 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O7pnsd085577; Thu, 24 Jul 2003 00:51:49 -0700 (PDT) Message-Id: <200307240751.h6O7pnsd085577@repoman.freebsd.org> From: Marcel Moolenaar Date: Thu, 24 Jul 2003 00:51:49 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libthr/arch/alpha/alpha _curthread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 07:51:51 -0000 marcel 2003/07/24 00:51:49 PDT FreeBSD src repository Modified files: lib/libthr/arch/alpha/alpha _curthread.c Log: Implement _get_curthread and _set_curthread. We use GCCs builtin function this, which expands to PAL calls (rduniq and wruniq). This needs adjustment when TLS is implemented. Revision Changes Path 1.2 +6 -1 src/lib/libthr/arch/alpha/alpha/_curthread.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 01:15:21 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA1FB37B401; Thu, 24 Jul 2003 01:15:21 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CE9543F3F; Thu, 24 Jul 2003 01:15:21 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O8FK0U087366; Thu, 24 Jul 2003 01:15:20 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O8FKoZ087365; Thu, 24 Jul 2003 01:15:20 -0700 (PDT) Message-Id: <200307240815.h6O8FKoZ087365@repoman.freebsd.org> From: Hartmut Brandt Date: Thu, 24 Jul 2003 01:15:20 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_cm.c atm_device.c atm_if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 08:15:22 -0000 harti 2003/07/24 01:15:20 PDT FreeBSD src repository Modified files: sys/netatm atm_cm.c atm_device.c atm_if.c Log: Add BPF support to HARP network interfaces. This allows one to see the traffic on LLC multiplexed connections (like CLIP). PR: kern/51831 Submitted by: Vincent Jardin MFC after: 2 weeks Revision Changes Path 1.29 +12 -0 src/sys/netatm/atm_cm.c 1.22 +12 -0 src/sys/netatm/atm_device.c 1.24 +13 -0 src/sys/netatm/atm_if.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 01:51:23 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9408D37B401; Thu, 24 Jul 2003 01:51:23 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31FA543F75; Thu, 24 Jul 2003 01:51:23 -0700 (PDT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O8pM0U088888; Thu, 24 Jul 2003 01:51:22 -0700 (PDT) (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O8pM8w088887; Thu, 24 Jul 2003 01:51:22 -0700 (PDT) Message-Id: <200307240851.h6O8pM8w088887@repoman.freebsd.org> From: David Xu Date: Thu, 24 Jul 2003 01:51:22 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 08:51:23 -0000 davidxu 2003/07/24 01:51:22 PDT FreeBSD src repository Modified files: sys/amd64/amd64 machdep.c Log: Set fault address to si_addr. Reviewed by: peter Revision Changes Path 1.586 +3 -0 src/sys/amd64/amd64/machdep.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 01:52:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CB8437B401; Thu, 24 Jul 2003 01:52:45 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0808B43FA3; Thu, 24 Jul 2003 01:52:45 -0700 (PDT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O8qi0U088939; Thu, 24 Jul 2003 01:52:44 -0700 (PDT) (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O8qiD8088938; Thu, 24 Jul 2003 01:52:44 -0700 (PDT) Message-Id: <200307240852.h6O8qiD8088938@repoman.freebsd.org> From: David Xu Date: Thu, 24 Jul 2003 01:52:44 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 08:52:45 -0000 davidxu 2003/07/24 01:52:44 PDT FreeBSD src repository Modified files: sys/amd64/amd64 vm_machdep.c Log: Implement cpu_set_upcall and cpu_set_upcall_kse. Reviewed by: peter Revision Changes Path 1.212 +68 -0 src/sys/amd64/amd64/vm_machdep.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 02:13:04 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B00AD37B401; Thu, 24 Jul 2003 02:13:04 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E5CD43F85; Thu, 24 Jul 2003 02:13:04 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O9D40U090699; Thu, 24 Jul 2003 02:13:04 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O9D4E8090698; Thu, 24 Jul 2003 02:13:04 -0700 (PDT) Message-Id: <200307240913.h6O9D4E8090698@repoman.freebsd.org> From: Hartmut Brandt Date: Thu, 24 Jul 2003 02:13:03 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_device.c atm_subr.c atm_var.h src/sys/netatm/uni sscf_uni.c sscf_uni_var.h sscop_pdu.c sscop_var.h uniarp_input.c uniip_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 09:13:05 -0000 harti 2003/07/24 02:13:03 PDT FreeBSD src repository Modified files: sys/netatm atm_device.c atm_subr.c atm_var.h sys/netatm/uni sscf_uni.c sscf_uni_var.h sscop_pdu.c sscop_var.h uniarp_input.c uniip_var.h Log: Constify the arguments to several pdu_print functions. Revision Changes Path 1.23 +2 -6 src/sys/netatm/atm_device.c 1.38 +4 -7 src/sys/netatm/atm_subr.c 1.21 +3 -2 src/sys/netatm/atm_var.h 1.19 +1 -5 src/sys/netatm/uni/sscf_uni.c 1.6 +2 -1 src/sys/netatm/uni/sscf_uni_var.h 1.12 +1 -5 src/sys/netatm/uni/sscop_pdu.c 1.7 +2 -1 src/sys/netatm/uni/sscop_var.h 1.13 +1 -5 src/sys/netatm/uni/uniarp_input.c 1.6 +2 -1 src/sys/netatm/uni/uniip_var.h From owner-cvs-src@FreeBSD.ORG Thu Jul 24 02:14:50 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D883137B401; Thu, 24 Jul 2003 02:14:50 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7EB0E43FAF; Thu, 24 Jul 2003 02:14:50 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O9Eo0U090838; Thu, 24 Jul 2003 02:14:50 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O9EotE090837; Thu, 24 Jul 2003 02:14:50 -0700 (PDT) Message-Id: <200307240914.h6O9EotE090837@repoman.freebsd.org> From: Hartmut Brandt Date: Thu, 24 Jul 2003 02:14:50 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_device.c atm_subr.c atm_var.h src/sys/netatm/uni sscf_uni.c sscf_uni_var.h sscop_pdu.c sscop_var.h uniarp_input.c uniip_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 09:14:51 -0000 harti 2003/07/24 02:14:50 PDT FreeBSD src repository Modified files: sys/netatm atm_device.c atm_subr.c atm_var.h sys/netatm/uni sscf_uni.c sscf_uni_var.h sscop_pdu.c sscop_var.h uniarp_input.c uniip_var.h Log: Forced commit for the MFC. MFC after: 2 weeks Revision Changes Path 1.24 +0 -0 src/sys/netatm/atm_device.c 1.39 +0 -0 src/sys/netatm/atm_subr.c 1.22 +0 -0 src/sys/netatm/atm_var.h 1.20 +0 -0 src/sys/netatm/uni/sscf_uni.c 1.7 +0 -0 src/sys/netatm/uni/sscf_uni_var.h 1.13 +0 -0 src/sys/netatm/uni/sscop_pdu.c 1.8 +0 -0 src/sys/netatm/uni/sscop_var.h 1.14 +0 -0 src/sys/netatm/uni/uniarp_input.c 1.7 +0 -0 src/sys/netatm/uni/uniip_var.h From owner-cvs-src@FreeBSD.ORG Thu Jul 24 02:30:40 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B03F37B401; Thu, 24 Jul 2003 02:30:40 -0700 (PDT) Received: from shrike.submonkey.net (pc1-cdif2-5-cust38.cdif.cable.ntl.com [81.101.150.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31F7743FAF; Thu, 24 Jul 2003 02:30:39 -0700 (PDT) (envelope-from setantae@submonkey.net) Received: from setantae by shrike.submonkey.net with local (Exim 4.20) id 19fcQn-000HQ9-L9; Thu, 24 Jul 2003 10:30:37 +0100 Date: Thu, 24 Jul 2003 10:30:37 +0100 From: Ceri Davies To: "Simon L. Nielsen" Message-ID: <20030724093037.GB46900@submonkey.net> Mail-Followup-To: Ceri Davies , "Simon L. Nielsen" , Nate Lawson , cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org References: <20030723132439.D550137B401@hub.freebsd.org> <20030723102603.O39567@root.org> <20030723204721.GA1886@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9Hhx61DPNOHVwUu9" Content-Disposition: inline In-Reply-To: <20030723204721.GA1886@FreeBSD.org> User-Agent: Mutt/1.5.4i Sender: Ceri Davies cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Nate Lawson Subject: Re: cvs commit: src/share/man/man7 Makefile rescue.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 09:30:40 -0000 --9Hhx61DPNOHVwUu9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 23, 2003 at 10:47:22PM +0200, Simon L. Nielsen wrote: > On 2003.07.23 10:26:54 -0700, Nate Lawson wrote: >=20 > > What's it doing in section 7? I thought system utils are section 8? >=20 > I thought section 7 was more appropriate, since rescue is not a command > but rather a system. It was also a bit inspired by docs/35011, which > argues that some of the parts of section 8 really should be in section > 7. I'm agreeing with Simon here. This manpage documents the rescue system, not the rescue command, and therefore belongs in section 7. I'm not anywhere near a -CURRENT machine at the moment, but if running $ /rescue/rescue doesn't do anything, then as far as I'm concerned it doesn't belong in section 8. If it does, then a new manpage should be written documenting the command rescue(8) and added to section 8. Ceri --=20 User: DO YOU ACCEPT JESUS CHRIST AS YOUR PERSONAL LORD AND SAVIOR? Iniaes: Sure, I can accept all forms of payment. -- www.chatterboxchallenge.com --9Hhx61DPNOHVwUu9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQE/H6c9ocfcwTS3JF8RAn5bAJ9nsP0YvD1gtPJRhP7smOY1HVGcugCZAYec ikXYtlkLrSdDAPToouZlllQ= =wkpb -----END PGP SIGNATURE----- --9Hhx61DPNOHVwUu9-- From owner-cvs-src@FreeBSD.ORG Thu Jul 24 03:33:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C547337B401; Thu, 24 Jul 2003 03:33:02 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D64943FB1; Thu, 24 Jul 2003 03:33:02 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OAX20U094868; Thu, 24 Jul 2003 03:33:02 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OAX2fS094867; Thu, 24 Jul 2003 03:33:02 -0700 (PDT) Message-Id: <200307241033.h6OAX2fS094867@repoman.freebsd.org> From: Hartmut Brandt Date: Thu, 24 Jul 2003 03:33:02 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_proto.c atm_subr.c atm_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 10:33:03 -0000 harti 2003/07/24 03:33:02 PDT FreeBSD src repository Modified files: sys/netatm atm_proto.c atm_subr.c atm_var.h Log: Create a subtree 'harp' of the net sysctl tree. This uses a fixed OID as the other protocol family sub-trees do, that is equal to the protocol family identifier. Make the ATM layer debugging flags available under this tree. Submitted by: Vincent Jardin MFC after: 2 weeks Revision Changes Path 1.11 +3 -0 src/sys/netatm/atm_proto.c 1.40 +22 -3 src/sys/netatm/atm_subr.c 1.23 +6 -0 src/sys/netatm/atm_var.h From owner-cvs-src@FreeBSD.ORG Thu Jul 24 03:44:46 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D29B37B401; Thu, 24 Jul 2003 03:44:46 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2977743FBD; Thu, 24 Jul 2003 03:44:46 -0700 (PDT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OAik0U095369; Thu, 24 Jul 2003 03:44:46 -0700 (PDT) (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OAijXk095368; Thu, 24 Jul 2003 03:44:45 -0700 (PDT) Message-Id: <200307241044.h6OAijXk095368@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Thu, 24 Jul 2003 03:44:45 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/tinderbox tbmaster.pl X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 10:44:46 -0000 des 2003/07/24 03:44:45 PDT FreeBSD src repository Modified files: tools/tools/tinderbox tbmaster.pl Log: Complain about extraneous command line arguments. Revision Changes Path 1.31 +3 -0 src/tools/tools/tinderbox/tbmaster.pl From owner-cvs-src@FreeBSD.ORG Thu Jul 24 04:17:37 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 97BF437B404; Thu, 24 Jul 2003 04:17:37 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F69B43FAF; Thu, 24 Jul 2003 04:17:37 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OBHa0U097433; Thu, 24 Jul 2003 04:17:36 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OBHaUY097432; Thu, 24 Jul 2003 04:17:36 -0700 (PDT) Message-Id: <200307241117.h6OBHaUY097432@repoman.freebsd.org> From: Hartmut Brandt Date: Thu, 24 Jul 2003 04:17:36 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 11:17:38 -0000 harti 2003/07/24 04:17:36 PDT FreeBSD src repository Modified files: sys/netatm atm_if.c Log: Now that we have if_detach() don't try to get rid of all the interface stuff (routes, ...) by hand - simply use if_detach(). Submitted by: Vincent Jardin MFC after: 2 week Revision Changes Path 1.25 +5 -95 src/sys/netatm/atm_if.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 05:24:42 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F5C437B404; Thu, 24 Jul 2003 05:24:42 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D67A743FAF; Thu, 24 Jul 2003 05:24:41 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OCOf0U006306; Thu, 24 Jul 2003 05:24:41 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OCOfjv006305; Thu, 24 Jul 2003 05:24:41 -0700 (PDT) Message-Id: <200307241224.h6OCOfjv006305@repoman.freebsd.org> From: Hartmut Brandt Date: Thu, 24 Jul 2003 05:24:41 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm/uni sscf_uni.c sscf_uni_lower.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 12:24:43 -0000 harti 2003/07/24 05:24:41 PDT FreeBSD src repository Modified files: sys/netatm/uni sscf_uni.c sscf_uni_lower.c Log: Free the UNI vcc to the same zone from where it was allocated from. This resulted in a panic when detaching the uni31 signalling manager. Revision Changes Path 1.21 +1 -1 src/sys/netatm/uni/sscf_uni.c 1.12 +2 -2 src/sys/netatm/uni/sscf_uni_lower.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 06:45:06 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 607DB37B401; Thu, 24 Jul 2003 06:45:06 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2ABC43F75; Thu, 24 Jul 2003 06:45:05 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6ODj50U010284; Thu, 24 Jul 2003 06:45:05 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6ODj5LO010283; Thu, 24 Jul 2003 06:45:05 -0700 (PDT) Message-Id: <200307241345.h6ODj5LO010283@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 24 Jul 2003 06:45:05 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 13:45:06 -0000 ru 2003/07/24 06:45:05 PDT FreeBSD src repository Modified files: release Makefile Log: Replaced the hardcoded target names in the touch(1) commands with ${.TARGET}, to ease maintenance. Revision Changes Path 1.794 +15 -15 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jul 24 07:37:03 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A324C37B401; Thu, 24 Jul 2003 07:37:03 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3C2A843F75; Thu, 24 Jul 2003 07:37:03 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OEb20U013120; Thu, 24 Jul 2003 07:37:02 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OEb2dR013119; Thu, 24 Jul 2003 07:37:02 -0700 (PDT) Message-Id: <200307241437.h6OEb2dR013119@repoman.freebsd.org> From: Hartmut Brandt Date: Thu, 24 Jul 2003 07:37:02 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm/spans spans_cls.c spans_proto.c spans_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 14:37:04 -0000 harti 2003/07/24 07:37:01 PDT FreeBSD src repository Modified files: sys/netatm/spans spans_cls.c spans_proto.c spans_var.h Log: Create a sysctl that allows to enable/disable printing of SPANS messages. While here delete to sys/types.h includes when sys/param.h is also included. Submitted by: Vincent Jardin MFC after: 2 weeks Revision Changes Path 1.18 +8 -16 src/sys/netatm/spans/spans_cls.c 1.13 +3 -1 src/sys/netatm/spans/spans_proto.c 1.8 +4 -0 src/sys/netatm/spans/spans_var.h From owner-cvs-src@FreeBSD.ORG Thu Jul 24 08:09:31 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0BB2237B401 for ; Thu, 24 Jul 2003 08:09:31 -0700 (PDT) Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id A1E9943FAF for ; Thu, 24 Jul 2003 08:09:28 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 9673 invoked from network); 24 Jul 2003 15:09:28 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 24 Jul 2003 15:09:28 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6OF9PGI048927; Thu, 24 Jul 2003 11:09:26 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030723.174342.72711741.imp@bsdimp.com> Date: Thu, 24 Jul 2003 11:09:42 -0400 (EDT) From: John Baldwin To: "M. Warner Losh" cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: bde@zeta.org.au cc: paul@freebsd-services.com cc: cvs-src@FreeBSD.org cc: das@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 15:09:31 -0000 On 23-Jul-2003 M. Warner Losh wrote: >: Hmmm. I guess if unloading pccard detaches all pccard devices and their >: children then it is safe if you always use KOBJ methods and never link >: against any functions for your bus attachments. > > That's why pccard tries very hard to refuse to export ANY symbols that > pccard client drivers use. Other busses should do likewise. Yes, unfortunately that means I need to duplicate some code in some places now. E.g. isab_attach() must die. pcib_attach() is a harder nut to crack, but it is only used by acpi and I think all acpi systems require pci anyways. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Thu Jul 24 08:25:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C91D637B401; Thu, 24 Jul 2003 08:25:18 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5ED1243FB1; Thu, 24 Jul 2003 08:25:18 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OFPI0U016512; Thu, 24 Jul 2003 08:25:18 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OFPIRb016511; Thu, 24 Jul 2003 08:25:18 -0700 (PDT) Message-Id: <200307241525.h6OFPIRb016511@repoman.freebsd.org> From: Hartmut Brandt Date: Thu, 24 Jul 2003 08:25:18 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm/ipatm ipatm_input.c ipatm_load.c ipatm_output.c ipatm_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 15:25:19 -0000 harti 2003/07/24 08:25:18 PDT FreeBSD src repository Modified files: sys/netatm/ipatm ipatm_input.c ipatm_load.c ipatm_output.c ipatm_var.h Log: Make the debugging variable that controls dumping of IP over ATM packets accessible as a sysctl. Submitted by: Vincent Jardin MFC after: 2 weeks Revision Changes Path 1.13 +0 -4 src/sys/netatm/ipatm/ipatm_input.c 1.19 +15 -2 src/sys/netatm/ipatm/ipatm_load.c 1.12 +0 -3 src/sys/netatm/ipatm/ipatm_output.c 1.7 +4 -1 src/sys/netatm/ipatm/ipatm_var.h From owner-cvs-src@FreeBSD.ORG Thu Jul 24 10:07:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D52C37B401; Thu, 24 Jul 2003 10:07:18 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE3AE43F75; Thu, 24 Jul 2003 10:07:17 -0700 (PDT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OH7H0U027585; Thu, 24 Jul 2003 10:07:17 -0700 (PDT) (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OH7Hxa027584; Thu, 24 Jul 2003 10:07:17 -0700 (PDT) Message-Id: <200307241707.h6OH7Hxa027584@repoman.freebsd.org> From: Mike Makonnen Date: Thu, 24 Jul 2003 10:07:17 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 17:07:18 -0000 mtm 2003/07/24 10:07:17 PDT FreeBSD src repository Modified files: sys/kern kern_sig.c Log: The POSIX spec also requires that kern_sigtimedwait return EINVAL if tv_nsec of the timeout is less than zero. Revision Changes Path 1.254 +1 -1 src/sys/kern/kern_sig.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 10:19:16 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F89737B408; Thu, 24 Jul 2003 10:19:16 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA69443F93; Thu, 24 Jul 2003 10:19:15 -0700 (PDT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OHJF0U028335; Thu, 24 Jul 2003 10:19:15 -0700 (PDT) (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OHJFJP028334; Thu, 24 Jul 2003 10:19:15 -0700 (PDT) Message-Id: <200307241719.h6OHJFJP028334@repoman.freebsd.org> From: Mark Murray Date: Thu, 24 Jul 2003 10:19:15 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libtelnet Makefile src/libexec/telnetd Makefile src/usr.bin/telnet Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 17:19:16 -0000 markm 2003/07/24 10:19:15 PDT FreeBSD src repository Modified files: lib/libtelnet Makefile libexec/telnetd Makefile usr.bin/telnet Makefile Log: Make sure that a "make release" (more accurately the bit that makes the crunched binary) get a non-cryptographic telnet. This is overkill in that it covers stuff that is not normally used in a crunched binary. Revision Changes Path 1.18 +2 -0 src/lib/libtelnet/Makefile 1.23 +2 -0 src/libexec/telnetd/Makefile 1.25 +2 -0 src/usr.bin/telnet/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jul 24 10:28:53 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F32E37B401; Thu, 24 Jul 2003 10:28:53 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B80B43F93; Thu, 24 Jul 2003 10:28:53 -0700 (PDT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OHSq0U028707; Thu, 24 Jul 2003 10:28:52 -0700 (PDT) (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OHSqBP028706; Thu, 24 Jul 2003 10:28:52 -0700 (PDT) Message-Id: <200307241728.h6OHSqBP028706@repoman.freebsd.org> From: Mark Murray Date: Thu, 24 Jul 2003 10:28:52 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 17:28:53 -0000 markm 2003/07/24 10:28:52 PDT FreeBSD src repository Modified files: release Makefile Log: Get the correct set of cryptographically-infected binaries automagically from the (secure|kerberos5)/Makefile:[KS]PROG. Revision Changes Path 1.795 +11 -7 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jul 24 10:46:08 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14A5B37B408 for ; Thu, 24 Jul 2003 10:46:08 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id AE43743F85 for ; Thu, 24 Jul 2003 10:46:06 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 42001 invoked by uid 1000); 24 Jul 2003 17:46:07 -0000 Date: Thu, 24 Jul 2003 10:46:07 -0700 (PDT) From: Nate Lawson To: John Baldwin In-Reply-To: Message-ID: <20030724104435.M41972@root.org> References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 17:46:08 -0000 On Thu, 24 Jul 2003, John Baldwin wrote: > On 23-Jul-2003 M. Warner Losh wrote: > >: Hmmm. I guess if unloading pccard detaches all pccard devices and their > >: children then it is safe if you always use KOBJ methods and never link > >: against any functions for your bus attachments. > > > > That's why pccard tries very hard to refuse to export ANY symbols that > > pccard client drivers use. Other busses should do likewise. > > Yes, unfortunately that means I need to duplicate some code in some > places now. E.g. isab_attach() must die. pcib_attach() is a harder > nut to crack, but it is only used by acpi and I think all acpi systems > require pci anyways. I don't think acpi requires pci. The _CRS and _ADR methods work for other buses and there is no reason pci would be required. However, it's safe to assume that any machine that has acpi has some form of pci also. -Nate From owner-cvs-src@FreeBSD.ORG Thu Jul 24 11:11:28 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5132F37B401; Thu, 24 Jul 2003 11:11:28 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E3A1743F75; Thu, 24 Jul 2003 11:11:27 -0700 (PDT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OIBR0U031202; Thu, 24 Jul 2003 11:11:27 -0700 (PDT) (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OIBR43031201; Thu, 24 Jul 2003 11:11:27 -0700 (PDT) Message-Id: <200307241811.h6OIBR43031201@repoman.freebsd.org> From: Mark Murray Date: Thu, 24 Jul 2003 11:11:27 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 18:11:28 -0000 markm 2003/07/24 11:11:27 PDT FreeBSD src repository Modified files: release Makefile Log: Forced commit. The previous commit included some commented-out macro-assignments with comments documenting their function. These macros were of considerable use to me in building a test "make release". Revision Changes Path 1.796 +0 -0 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jul 24 11:14:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2E7AF37B401; Thu, 24 Jul 2003 11:14:29 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8EE9143F93; Thu, 24 Jul 2003 11:14:29 -0700 (PDT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OIET0U031331; Thu, 24 Jul 2003 11:14:29 -0700 (PDT) (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OIETtp031330; Thu, 24 Jul 2003 11:14:29 -0700 (PDT) Message-Id: <200307241814.h6OIETtp031330@repoman.freebsd.org> From: Mark Murray Date: Thu, 24 Jul 2003 11:14:29 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 18:14:30 -0000 markm 2003/07/24 11:14:29 PDT FreeBSD src repository Modified files: . Makefile.inc1 Log: Don't lint(1) so early in the build. Its OK to keep this for the "make all" phase. Revision Changes Path 1.382 +2 -1 src/Makefile.inc1 From owner-cvs-src@FreeBSD.ORG Thu Jul 24 11:17:22 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7868337B404; Thu, 24 Jul 2003 11:17:22 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1538243F85; Thu, 24 Jul 2003 11:17:22 -0700 (PDT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OIHL0U031452; Thu, 24 Jul 2003 11:17:21 -0700 (PDT) (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OIHLIP031451; Thu, 24 Jul 2003 11:17:21 -0700 (PDT) Message-Id: <200307241817.h6OIHLIP031451@repoman.freebsd.org> From: Mike Makonnen Date: Thu, 24 Jul 2003 11:17:21 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc rc.subr X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 18:17:22 -0000 mtm 2003/07/24 11:17:21 PDT FreeBSD src repository Modified files: etc rc.subr Log: Missing quotes around a variable. In this case we are only evaluating the $_precmd command as a string. We're not actually trying to evaluate the contents of the command. Reported by: Glenn Johnson Revision Changes Path 1.14 +1 -1 src/etc/rc.subr From owner-cvs-src@FreeBSD.ORG Thu Jul 24 11:30:26 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E06E37B401; Thu, 24 Jul 2003 11:30:26 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0DE543F85; Thu, 24 Jul 2003 11:30:25 -0700 (PDT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OIUP0U032097; Thu, 24 Jul 2003 11:30:25 -0700 (PDT) (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OIUPWd032096; Thu, 24 Jul 2003 11:30:25 -0700 (PDT) Message-Id: <200307241830.h6OIUPWd032096@repoman.freebsd.org> From: Mark Murray Date: Thu, 24 Jul 2003 11:30:25 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/bin/ed Makefile src/games/factor Makefile src/lib Makefile src/usr.bin Makefile src/usr.sbin Makefile src/usr.sbin/ppp Makefile src/usr.sbin/pppd Makefile src/usr.sbin/sendmail Makefile src/usr.sbin/tcpdump/tcpdump ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 18:30:26 -0000 markm 2003/07/24 11:30:25 PDT FreeBSD src repository Modified files: bin/ed Makefile games/factor Makefile lib Makefile usr.bin Makefile usr.sbin Makefile usr.sbin/ppp Makefile usr.sbin/pppd Makefile usr.sbin/sendmail Makefile usr.sbin/tcpdump/tcpdump Makefile Log: Don't check for the existance of src/crypto/ for building items that may contain crypto. The days of ITAR paranoia are over, and the simple macro tests that remain are sufficient. Revision Changes Path 1.29 +1 -1 src/bin/ed/Makefile 1.7 +1 -1 src/games/factor/Makefile 1.166 +1 -1 src/lib/Makefile 1.245 +1 -1 src/usr.bin/Makefile 1.265 +1 -1 src/usr.sbin/Makefile 1.98 +1 -1 src/usr.sbin/ppp/Makefile 1.26 +1 -1 src/usr.sbin/pppd/Makefile 1.43 +1 -2 src/usr.sbin/sendmail/Makefile 1.37 +1 -2 src/usr.sbin/tcpdump/tcpdump/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jul 24 11:56:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96A6537B404 for ; Thu, 24 Jul 2003 11:56:25 -0700 (PDT) Received: from mail.speakeasy.net (mail13.speakeasy.net [216.254.0.213]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C17543F85 for ; Thu, 24 Jul 2003 11:56:24 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 9694 invoked from network); 24 Jul 2003 18:56:23 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 24 Jul 2003 18:56:23 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6OIuLGI049420; Thu, 24 Jul 2003 14:56:21 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030724104435.M41972@root.org> Date: Thu, 24 Jul 2003 14:56:38 -0400 (EDT) From: John Baldwin To: Nate Lawson cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 18:56:26 -0000 On 24-Jul-2003 Nate Lawson wrote: > On Thu, 24 Jul 2003, John Baldwin wrote: >> On 23-Jul-2003 M. Warner Losh wrote: >> >: Hmmm. I guess if unloading pccard detaches all pccard devices and their >> >: children then it is safe if you always use KOBJ methods and never link >> >: against any functions for your bus attachments. >> > >> > That's why pccard tries very hard to refuse to export ANY symbols that >> > pccard client drivers use. Other busses should do likewise. >> >> Yes, unfortunately that means I need to duplicate some code in some >> places now. E.g. isab_attach() must die. pcib_attach() is a harder >> nut to crack, but it is only used by acpi and I think all acpi systems >> require pci anyways. > > I don't think acpi requires pci. The _CRS and _ADR methods work for other > buses and there is no reason pci would be required. However, it's safe to > assume that any machine that has acpi has some form of pci also. That last is what I'm assuming, not that ACPI strictly requires PCI. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Thu Jul 24 12:08:20 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E840437B407 for ; Thu, 24 Jul 2003 12:08:20 -0700 (PDT) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6EA2843FA3 for ; Thu, 24 Jul 2003 12:08:18 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 2496 invoked from network); 24 Jul 2003 19:08:17 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 24 Jul 2003 19:08:17 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6OJ8FGI049473; Thu, 24 Jul 2003 15:08:16 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200307240751.h6O7pnsd085577@repoman.freebsd.org> Date: Thu, 24 Jul 2003 15:08:32 -0400 (EDT) From: John Baldwin To: Marcel Moolenaar cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/lib/libthr/arch/alpha/alpha _curthread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 19:08:21 -0000 On 24-Jul-2003 Marcel Moolenaar wrote: > marcel 2003/07/24 00:51:49 PDT > > FreeBSD src repository > > Modified files: > lib/libthr/arch/alpha/alpha _curthread.c > Log: > Implement _get_curthread and _set_curthread. We use GCCs builtin > function this, which expands to PAL calls (rduniq and wruniq). > This needs adjustment when TLS is implemented. This trashes SMP since we use the per-CPU unique value already to maintain the per-cpu data pointer. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Thu Jul 24 12:08:26 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 53C1A37B47C for ; Thu, 24 Jul 2003 12:08:25 -0700 (PDT) Received: from mail.speakeasy.net (mail13.speakeasy.net [216.254.0.213]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2935643FA3 for ; Thu, 24 Jul 2003 12:08:22 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 5415 invoked from network); 24 Jul 2003 19:08:21 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 24 Jul 2003 19:08:21 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6OJ8IGI049476; Thu, 24 Jul 2003 15:08:19 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200307241811.h6OIBR43031201@repoman.freebsd.org> Date: Thu, 24 Jul 2003 15:08:35 -0400 (EDT) From: John Baldwin To: Mark Murray cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 19:08:27 -0000 On 24-Jul-2003 Mark Murray wrote: > markm 2003/07/24 11:11:27 PDT > > FreeBSD src repository > > Modified files: > release Makefile > Log: > Forced commit. > > The previous commit included some commented-out macro-assignments > with comments documenting their function. These macros were of > considerable use to me in building a test "make release". If they aren't documented in release(7) that is the preferred location for release building documentation now adays. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Thu Jul 24 12:19:52 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D696537B401; Thu, 24 Jul 2003 12:19:52 -0700 (PDT) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A04243F3F; Thu, 24 Jul 2003 12:19:49 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201]) by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6OJJnwO028496; Thu, 24 Jul 2003 12:19:49 -0700 (PDT) (envelope-from marcel@piii.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) by dhcp01.pn.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6OJJhAq001054; Thu, 24 Jul 2003 12:19:44 -0700 (PDT) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.9/8.12.9/Submit) id h6OJJhq4001053; Thu, 24 Jul 2003 12:19:43 -0700 (PDT) (envelope-from marcel) Date: Thu, 24 Jul 2003 12:19:43 -0700 From: Marcel Moolenaar To: John Baldwin Message-ID: <20030724191943.GA1028@dhcp01.pn.xcllnt.net> References: <200307240751.h6O7pnsd085577@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libthr/arch/alpha/alpha _curthread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 19:19:53 -0000 On Thu, Jul 24, 2003 at 03:08:32PM -0400, John Baldwin wrote: > > On 24-Jul-2003 Marcel Moolenaar wrote: > > marcel 2003/07/24 00:51:49 PDT > > > > FreeBSD src repository > > > > Modified files: > > lib/libthr/arch/alpha/alpha _curthread.c > > Log: > > Implement _get_curthread and _set_curthread. We use GCCs builtin > > function this, which expands to PAL calls (rduniq and wruniq). > > This needs adjustment when TLS is implemented. > > This trashes SMP since we use the per-CPU unique value already > to maintain the per-cpu data pointer. Writing to the per-CPU unique value is an unprivileged operation. You cannot possibly use that for in-kernel use without saving and restoring it on kernel exit/entry. Which is what needs to be done. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Thu Jul 24 12:53:04 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3052137B401; Thu, 24 Jul 2003 12:53:04 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C111343FA3; Thu, 24 Jul 2003 12:53:03 -0700 (PDT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OJr30U041818; Thu, 24 Jul 2003 12:53:03 -0700 (PDT) (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OJr3tS041817; Thu, 24 Jul 2003 12:53:03 -0700 (PDT) Message-Id: <200307241953.h6OJr3tS041817@repoman.freebsd.org> From: Mark Murray Date: Thu, 24 Jul 2003 12:53:03 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libgeom Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 19:53:04 -0000 markm 2003/07/24 12:53:02 PDT FreeBSD src repository Modified files: lib/libgeom Makefile Log: Remove GCC-specific debugging option. OK'ed by: phk Revision Changes Path 1.7 +1 -1 src/lib/libgeom/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jul 24 12:58:57 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBDED37B401; Thu, 24 Jul 2003 12:58:56 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 86C8443F93; Thu, 24 Jul 2003 12:58:56 -0700 (PDT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OJwu0U042171; Thu, 24 Jul 2003 12:58:56 -0700 (PDT) (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OJwuwH042170; Thu, 24 Jul 2003 12:58:56 -0700 (PDT) Message-Id: <200307241958.h6OJwuwH042170@repoman.freebsd.org> From: Mark Murray Date: Thu, 24 Jul 2003 12:58:56 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libwrap Makefile src/usr.sbin/tcpdchk Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 19:58:57 -0000 markm 2003/07/24 12:58:56 PDT FreeBSD src repository Modified files: lib/libwrap Makefile usr.sbin/tcpdchk Makefile Log: Turn on the extended syntax, which TCP_wrappers has by default, as distributed. Revision Changes Path 1.14 +1 -1 src/lib/libwrap/Makefile 1.10 +1 -1 src/usr.sbin/tcpdchk/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jul 24 13:20:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3CD8A37B404; Thu, 24 Jul 2003 13:20:18 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1357243F3F; Thu, 24 Jul 2003 13:20:17 -0700 (PDT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6OKKG0U043908; Thu, 24 Jul 2003 13:20:16 -0700 (PDT) (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6OKKGOG043906; Thu, 24 Jul 2003 13:20:16 -0700 (PDT) Message-Id: <200307242020.h6OKKGOG043906@repoman.freebsd.org> From: Mark Murray Date: Thu, 24 Jul 2003 13:20:16 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/ppp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 20:20:19 -0000 markm 2003/07/24 13:20:16 PDT FreeBSD src repository Modified files: usr.sbin/ppp Makefile Log: Hide more crypto from being crunched at release time. Revision Changes Path 1.99 +1 -1 src/usr.sbin/ppp/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jul 24 14:00:01 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 98F7637B404 for ; Thu, 24 Jul 2003 14:00:01 -0700 (PDT) Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED82643F3F for ; Thu, 24 Jul 2003 13:59:59 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 3607 invoked from network); 24 Jul 2003 20:59:59 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 24 Jul 2003 20:59:59 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6OKxvGI049707; Thu, 24 Jul 2003 16:59:57 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030724191943.GA1028@dhcp01.pn.xcllnt.net> Date: Thu, 24 Jul 2003 17:00:13 -0400 (EDT) From: John Baldwin To: Marcel Moolenaar cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libthr/arch/alpha/alpha _curthread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 21:00:02 -0000 On 24-Jul-2003 Marcel Moolenaar wrote: > On Thu, Jul 24, 2003 at 03:08:32PM -0400, John Baldwin wrote: >> >> On 24-Jul-2003 Marcel Moolenaar wrote: >> > marcel 2003/07/24 00:51:49 PDT >> > >> > FreeBSD src repository >> > >> > Modified files: >> > lib/libthr/arch/alpha/alpha _curthread.c >> > Log: >> > Implement _get_curthread and _set_curthread. We use GCCs builtin >> > function this, which expands to PAL calls (rduniq and wruniq). >> > This needs adjustment when TLS is implemented. >> >> This trashes SMP since we use the per-CPU unique value already >> to maintain the per-cpu data pointer. > > Writing to the per-CPU unique value is an unprivileged operation. > You cannot possibly use that for in-kernel use without saving and > restoring it on kernel exit/entry. Which is what needs to be done. There is a chicken and egg problem. We use the unique value to initialize the per-cpu pointer on kernel entry. We only have one such beast, and in the kernel we cache it in a register that userland gets to clobber (and frequently does). If you can think of a better way to store the per-cpu pointer such that kernel entry can load it into the register go for it. Read some code: syscall(...) { ... /* * Find our per-cpu globals. */ #ifdef SMP s = intr_disable(); #endif pcpup = (struct pcpu *) alpha_pal_rdval(); td = curthread; #ifdef SMP td->td_md.md_kernnest++; intr_restore(s); #endif ... } -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Thu Jul 24 16:21:20 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 67C9137B401; Thu, 24 Jul 2003 16:21:20 -0700 (PDT) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 43CB743F85; Thu, 24 Jul 2003 16:21:19 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201]) by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6ONLIwO029605; Thu, 24 Jul 2003 16:21:18 -0700 (PDT) (envelope-from marcel@piii.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) by dhcp01.pn.xcllnt.net (8.12.9/8.12.9) with ESMTP id h6ONLHAq001937; Thu, 24 Jul 2003 16:21:17 -0700 (PDT) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.9/8.12.9/Submit) id h6ONLHY5001936; Thu, 24 Jul 2003 16:21:17 -0700 (PDT) (envelope-from marcel) Date: Thu, 24 Jul 2003 16:21:17 -0700 From: Marcel Moolenaar To: John Baldwin Message-ID: <20030724232117.GA1913@dhcp01.pn.xcllnt.net> References: <20030724191943.GA1028@dhcp01.pn.xcllnt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libthr/arch/alpha/alpha _curthread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 23:21:20 -0000 On Thu, Jul 24, 2003 at 05:00:13PM -0400, John Baldwin wrote: > > There is a chicken and egg problem. We use the unique value to > initialize the per-cpu pointer on kernel entry. We only have one > such beast, and in the kernel we cache it in a register that userland > gets to clobber (and frequently does). If you can think of a better > way to store the per-cpu pointer such that kernel entry can load it > into the register go for it. I see where the confusion is: > pcpup = (struct pcpu *) alpha_pal_rdval(); ^^^^^^^^^^^^^^^^^^^^^^ This is not the per-CPU unique value. I had to add alpha_pal_rdunique() in order to access it. In numbers: PAL_rdval = PAL_OSF1_rdval = 0x0032 PAL_rdunique = 0x009e PAL_rdval is a privileged operation PAL_rdunique isn't. There is no fundamental problem (although my alpha does reboot when I run a 1:1-threaded application, so there is a problem :-) -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Thu Jul 24 16:33:26 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 74DBD37B404; Thu, 24 Jul 2003 16:33:26 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D98F943F3F; Thu, 24 Jul 2003 16:33:25 -0700 (PDT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6ONXP0U053445; Thu, 24 Jul 2003 16:33:25 -0700 (PDT) (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6ONXPDZ053444; Thu, 24 Jul 2003 16:33:25 -0700 (PDT) Message-Id: <200307242333.h6ONXPDZ053444@repoman.freebsd.org> From: Robert Watson Date: Thu, 24 Jul 2003 16:33:25 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/posix1e acl_to_text.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 23:33:27 -0000 rwatson 2003/07/24 16:33:25 PDT FreeBSD src repository Modified files: lib/libc/posix1e acl_to_text.c Log: Print group name in getfacl output when calculating an effective permission set based on a more restrictive mask. Submitted by: Glen Gibb Revision Changes Path 1.11 +3 -2 src/lib/libc/posix1e/acl_to_text.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 17:10:34 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B20A237B401; Thu, 24 Jul 2003 17:10:34 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E9B843F3F; Thu, 24 Jul 2003 17:10:34 -0700 (PDT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P0AY0U061086; Thu, 24 Jul 2003 17:10:34 -0700 (PDT) (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P0AYKW061085; Thu, 24 Jul 2003 17:10:34 -0700 (PDT) Message-Id: <200307250010.h6P0AYKW061085@repoman.freebsd.org> From: Scott Long Date: Thu, 24 Jul 2003 17:10:33 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release/i386 drivers.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 00:10:35 -0000 scottl 2003/07/24 17:10:33 PDT FreeBSD src repository Modified files: release/i386 drivers.conf Log: Move the mlx driver back into the kernel so that the drivers floppy doesn't overflow. Revision Changes Path 1.29 +0 -1 src/release/i386/drivers.conf From owner-cvs-src@FreeBSD.ORG Thu Jul 24 17:11:15 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF57437B401; Thu, 24 Jul 2003 17:11:15 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 491AC43F3F; Thu, 24 Jul 2003 17:11:15 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P0BF0U061126; Thu, 24 Jul 2003 17:11:15 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P0BEt8061125; Thu, 24 Jul 2003 17:11:14 -0700 (PDT) Message-Id: <200307250011.h6P0BEt8061125@repoman.freebsd.org> From: Marcel Moolenaar Date: Thu, 24 Jul 2003 17:11:14 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ia64/ia64 trap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 00:11:16 -0000 marcel 2003/07/24 17:11:14 PDT FreeBSD src repository Modified files: sys/ia64/ia64 trap.c Log: Disable the single-step trap on a debug related trap, including of course the single-step trap itself. Revision Changes Path 1.85 +2 -0 src/sys/ia64/ia64/trap.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 17:21:38 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 327B937B401; Thu, 24 Jul 2003 17:21:38 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C320343F93; Thu, 24 Jul 2003 17:21:37 -0700 (PDT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P0Lb0U061529; Thu, 24 Jul 2003 17:21:37 -0700 (PDT) (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P0Lbgk061528; Thu, 24 Jul 2003 17:21:37 -0700 (PDT) Message-Id: <200307250021.h6P0Lbgk061528@repoman.freebsd.org> From: David Xu Date: Thu, 24 Jul 2003 17:21:37 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 00:21:38 -0000 davidxu 2003/07/24 17:21:37 PDT FreeBSD src repository Modified files: sys/amd64/amd64 vm_machdep.c Log: Align upcall stack top to odd times of 8. GCC accounts return address in callee function for stack alignment. Revision Changes Path 1.213 +1 -0 src/sys/amd64/amd64/vm_machdep.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 17:30:46 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 967CB37B401; Thu, 24 Jul 2003 17:30:46 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33FCB43F75; Thu, 24 Jul 2003 17:30:46 -0700 (PDT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P0Uk0U061911; Thu, 24 Jul 2003 17:30:46 -0700 (PDT) (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P0UjqO061910; Thu, 24 Jul 2003 17:30:45 -0700 (PDT) Message-Id: <200307250030.h6P0UjqO061910@repoman.freebsd.org> From: Paul Saab Date: Thu, 24 Jul 2003 17:30:45 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/contrib/tar/src tar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 00:30:47 -0000 ps 2003/07/24 17:30:45 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) contrib/tar/src tar.c Log: MFC: rev 1.3 Null terminate the new argv[] array when converting 'tar zcf' to 'tar -z -c -f' Revision Changes Path 1.2.2.2 +5 -2 src/contrib/tar/src/tar.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 17:37:09 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BFB1937B404; Thu, 24 Jul 2003 17:37:09 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A3A343FB1; Thu, 24 Jul 2003 17:37:09 -0700 (PDT) (envelope-from mckay@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P0b90U062110; Thu, 24 Jul 2003 17:37:09 -0700 (PDT) (envelope-from mckay@repoman.freebsd.org) Received: (from mckay@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P0b87J062109; Thu, 24 Jul 2003 17:37:08 -0700 (PDT) Message-Id: <200307250037.h6P0b87J062109@repoman.freebsd.org> From: Stephen McKay Date: Thu, 24 Jul 2003 17:37:08 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/usr.sbin/ctm/ctm ctm.h ctm_input.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 00:37:10 -0000 mckay 2003/07/24 17:37:08 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) usr.sbin/ctm/ctm ctm.h ctm_input.c Log: MFC:(ctm.h:1.18 ctm_input.c:1.10) Remove the maximum patch size limit. (Missed that "MFC after" of 7 days by quite a bit eh? :-) Sorry!) Submitted by: Stephen Montgomery-Smith PR: 50461 Revision Changes Path 1.14.2.3 +1 -2 src/usr.sbin/ctm/ctm/ctm.h 1.8.2.1 +0 -4 src/usr.sbin/ctm/ctm/ctm_input.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 17:48:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C08C37B404; Thu, 24 Jul 2003 17:48:30 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB07D43FB1; Thu, 24 Jul 2003 17:48:29 -0700 (PDT) (envelope-from mckay@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P0mT0U062625; Thu, 24 Jul 2003 17:48:29 -0700 (PDT) (envelope-from mckay@repoman.freebsd.org) Received: (from mckay@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P0mTjZ062624; Thu, 24 Jul 2003 17:48:29 -0700 (PDT) Message-Id: <200307250048.h6P0mTjZ062624@repoman.freebsd.org> From: Stephen McKay Date: Thu, 24 Jul 2003 17:48:29 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/ctm/ctm_rmail ctm_rmail.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 00:48:30 -0000 mckay 2003/07/24 17:48:29 PDT FreeBSD src repository Modified files: usr.sbin/ctm/ctm_rmail ctm_rmail.1 Log: Make the example "too large" message in the manual match the updated one actually sent by ctm_smail since rev 1.13. Revision Changes Path 1.28 +1 -1 src/usr.sbin/ctm/ctm_rmail/ctm_rmail.1 From owner-cvs-src@FreeBSD.ORG Thu Jul 24 18:11:49 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CC8C37B401; Thu, 24 Jul 2003 18:11:49 -0700 (PDT) Received: from obsecurity.dyndns.org (adsl-63-207-60-135.dsl.lsan03.pacbell.net [63.207.60.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA2C443F85; Thu, 24 Jul 2003 18:11:41 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: from rot13.obsecurity.org (rot13.obsecurity.org [10.0.0.5]) by obsecurity.dyndns.org (Postfix) with ESMTP id 6D68D66D32; Thu, 24 Jul 2003 18:11:40 -0700 (PDT) Received: by rot13.obsecurity.org (Postfix, from userid 1000) id 64B22C10; Thu, 24 Jul 2003 18:11:40 -0700 (PDT) Date: Thu, 24 Jul 2003 18:11:40 -0700 From: Kris Kennaway To: Stephen McKay Message-ID: <20030725011140.GA3844@rot13.obsecurity.org> References: <200307250037.h6P0b87J062109@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6" Content-Disposition: inline In-Reply-To: <200307250037.h6P0b87J062109@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/ctm/ctm ctm.h ctm_input.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 01:11:49 -0000 --IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 24, 2003 at 05:37:08PM -0700, Stephen McKay wrote: > mckay 2003/07/24 17:37:08 PDT >=20 > FreeBSD src repository >=20 > Modified files: (Branch: RELENG_4) > usr.sbin/ctm/ctm ctm.h ctm_input.c=20 > Log: > MFC:(ctm.h:1.18 ctm_input.c:1.10) Remove the maximum patch size limit. > =20 > (Missed that "MFC after" of 7 days by quite a bit eh? :-) Sorry!) Hmm..I haven't been getting MFC reminders for some reason. Is the service broken? Kris --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQE/IIPMWry0BWjoQKURAoDTAJ9rU96lV3Z+18VFwsuj2VVJ8o/DFwCgqQiY tf9j8dUSrLD3l6sQV4POGlU= =whgd -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6-- From owner-cvs-src@FreeBSD.ORG Thu Jul 24 22:01:40 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC79037B404; Thu, 24 Jul 2003 22:01:40 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4274043F93; Thu, 24 Jul 2003 22:01:40 -0700 (PDT) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P51e0U080653; Thu, 24 Jul 2003 22:01:40 -0700 (PDT) (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P51doV080652; Thu, 24 Jul 2003 22:01:39 -0700 (PDT) Message-Id: <200307250501.h6P51doV080652@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Thu, 24 Jul 2003 22:01:39 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/modules/firewire/fwe Makefile src/sys/modules/firewire/sbp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 05:01:41 -0000 simokawa 2003/07/24 22:01:39 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/modules/firewire/fwe Makefile sys/modules/firewire/sbp Makefile Log: Add KMODDEPS. Revision Changes Path 1.2.2.3 +1 -0 src/sys/modules/firewire/fwe/Makefile 1.2.2.2 +1 -0 src/sys/modules/firewire/sbp/Makefile From owner-cvs-src@FreeBSD.ORG Thu Jul 24 22:08:00 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CAD8437B401; Thu, 24 Jul 2003 22:08:00 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7554043FAF; Thu, 24 Jul 2003 22:08:00 -0700 (PDT) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P5800U081769; Thu, 24 Jul 2003 22:08:00 -0700 (PDT) (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P580vO081768; Thu, 24 Jul 2003 22:08:00 -0700 (PDT) Message-Id: <200307250508.h6P580vO081768@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Thu, 24 Jul 2003 22:08:00 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/firewire firewire.c fwdev.c fwdma.c fwohci.c fwohci_pci.c if_fwe.c sbp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 05:08:01 -0000 simokawa 2003/07/24 22:08:00 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/firewire firewire.c fwdev.c fwdma.c fwohci.c fwohci_pci.c if_fwe.c sbp.c Log: Sync with -current: - Configuraiton ROM fix. - Allow retrieval of local Configuration ROM. - Add some debug messages. - Include file clean up. Revision Changes Path 1.3.2.25 +32 -15 src/sys/dev/firewire/firewire.c 1.2.4.12 +22 -7 src/sys/dev/firewire/fwdev.c 1.1.2.2 +16 -2 src/sys/dev/firewire/fwdma.c 1.1.2.22 +6 -14 src/sys/dev/firewire/fwohci.c 1.3.2.14 +10 -0 src/sys/dev/firewire/fwohci_pci.c 1.1.2.13 +0 -4 src/sys/dev/firewire/if_fwe.c 1.5.2.21 +8 -3 src/sys/dev/firewire/sbp.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 22:16:21 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D626337B405; Thu, 24 Jul 2003 22:16:21 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7075A43F3F; Thu, 24 Jul 2003 22:16:21 -0700 (PDT) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P5GL0U082148; Thu, 24 Jul 2003 22:16:21 -0700 (PDT) (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P5GL8F082147; Thu, 24 Jul 2003 22:16:21 -0700 (PDT) Message-Id: <200307250516.h6P5GL8F082147@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Thu, 24 Jul 2003 22:16:21 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/usr.sbin/fwcontrol fwcontrol.8 fwcontrol.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 05:16:22 -0000 simokawa 2003/07/24 22:16:21 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) usr.sbin/fwcontrol fwcontrol.8 fwcontrol.c Log: Sync with -current: - Decode bus_info block. - Allow retrieval of local Configuration ROM. - Clear Configuration ROM buffer in advance for '-d' option. - Manpage fix. Revision Changes Path 1.1.2.7 +39 -32 src/usr.sbin/fwcontrol/fwcontrol.8 1.1.2.9 +13 -5 src/usr.sbin/fwcontrol/fwcontrol.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 22:18:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 479E537B401; Thu, 24 Jul 2003 22:18:10 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFDF343F75; Thu, 24 Jul 2003 22:18:09 -0700 (PDT) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P5I90U082213; Thu, 24 Jul 2003 22:18:09 -0700 (PDT) (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P5I94A082212; Thu, 24 Jul 2003 22:18:09 -0700 (PDT) Message-Id: <200307250518.h6P5I94A082212@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Thu, 24 Jul 2003 22:18:09 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/share/man/man4 firewire.4 fwohci.4 sbp.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 05:18:10 -0000 simokawa 2003/07/24 22:18:09 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) share/man/man4 firewire.4 fwohci.4 sbp.4 Log: Sync with -current. Revision Changes Path 1.1.2.4 +6 -6 src/share/man/man4/firewire.4 1.1.2.5 +0 -1 src/share/man/man4/fwohci.4 1.1.2.4 +17 -7 src/share/man/man4/sbp.4 From owner-cvs-src@FreeBSD.ORG Thu Jul 24 22:37:14 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96FAA37B401; Thu, 24 Jul 2003 22:37:14 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33E1343FA3; Thu, 24 Jul 2003 22:37:14 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P5bD0U082880; Thu, 24 Jul 2003 22:37:13 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P5bDaj082879; Thu, 24 Jul 2003 22:37:13 -0700 (PDT) Message-Id: <200307250537.h6P5bDaj082879@repoman.freebsd.org> From: Marcel Moolenaar Date: Thu, 24 Jul 2003 22:37:13 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ia64/ia64 machdep.c mem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 05:37:15 -0000 marcel 2003/07/24 22:37:13 PDT FreeBSD src repository Modified files: sys/ia64/ia64 machdep.c mem.c Log: Move ia64_pa_access() from machdep.c to mem.c and declare it static. It's only used in mem.c and cannot accidentally be used elsewhere this way. Revision Changes Path 1.143 +0 -6 src/sys/ia64/ia64/machdep.c 1.15 +6 -0 src/sys/ia64/ia64/mem.c From owner-cvs-src@FreeBSD.ORG Thu Jul 24 22:38:15 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D64EB37B401; Thu, 24 Jul 2003 22:38:15 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E1CC43F3F; Thu, 24 Jul 2003 22:38:11 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6P5c70U038569 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 25 Jul 2003 08:38:07 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6P5c666038564; Fri, 25 Jul 2003 08:38:06 +0300 (EEST) (envelope-from ru) Date: Fri, 25 Jul 2003 08:38:06 +0300 From: Ruslan Ermilov To: Scott Long Message-ID: <20030725053806.GA36982@sunbay.com> References: <200307250010.h6P0AYKW061085@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lEGEL1/lMxI0MVQ2" Content-Disposition: inline In-Reply-To: <200307250010.h6P0AYKW061085@repoman.freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release/i386 drivers.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 05:38:16 -0000 --lEGEL1/lMxI0MVQ2 Content-Type: multipart/mixed; boundary="vkogqOf2sHV7VnPd" Content-Disposition: inline --vkogqOf2sHV7VnPd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 24, 2003 at 05:10:33PM -0700, Scott Long wrote: > scottl 2003/07/24 17:10:33 PDT >=20 > FreeBSD src repository >=20 > Modified files: > release/i386 drivers.conf=20 > Log: > Move the mlx driver back into the kernel so that the drivers floppy doe= sn't > overflow. > =20 > Revision Changes Path > 1.29 +0 -1 src/release/i386/drivers.conf >=20 Which reminds me. The floppy wasn't overflowing when building 5.x snapshot on 4.x, due to the differences in file system layout between 4.x and 5.x. Please see the attached if you're interested. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --vkogqOf2sHV7VnPd Content-Type: message/rfc822 Content-Disposition: inline Date: Wed, 12 Mar 2003 00:32:21 +0200 From: Ruslan Ermilov To: Poul-Henning Kamp , Kirk McKusick Cc: current@FreeBSD.org Subject: Re: MINCYLGRPS (was: 4-stable releases on -current?) Message-ID: <20030311223221.GA84474@sunbay.com> References: <20030224094711.GA289@zibbi.icomtek.csir.co.za> <20030224102649.GA31100@sunbay.com> <20030224163505.GA12550@zibbi.icomtek.csir.co.za> <20030224172230.GA89139@sunbay.com> <20030224173812.GA14630@zibbi.icomtek.csir.co.za> <20030224174437.GA94899@sunbay.com> <20030224201528.GA10344@sunbay.com> <20030225180219.GA58778@zibbi.icomtek.csir.co.za> <20030225195202.GA72331@sunbay.com> <20030226124810.GB88741@sunbay.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline In-Reply-To: <20030226124810.GB88741@sunbay.com> User-Agent: Mutt/1.5.3i --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey, is anybody ever going to answer this email? On Wed, Feb 26, 2003 at 02:48:10PM +0200, Ruslan Ermilov wrote: > On Tue, Feb 25, 2003 at 09:52:02PM +0200, Ruslan Ermilov wrote: > > On Tue, Feb 25, 2003 at 08:02:19PM +0200, John Hay wrote: > [...] > > > Ok, with the patches below I can get to where it tries to build the > > > fixit floppy in release.10. It breaks because the floppy is too small. > > > I must still check to make sure it is true. > > >=20 > > We'll know this in less than 1:30 -- I've just launched the > > snapshot build for 4.x/i386 on my fast -stable box. > >=20 > > While I was writing it, it's already finished (successfully). > >=20 > > ftp://ftp.sunbay.net/pub/FreeBSD/snapshots/i386/4.x-20030225-STABLE/ > >=20 > OK, I've tracked it down to the differences in newfs(8) between > 4.x and 5.x. In 4.x, newfs'ing a 1.44MB floppy results in a > single cylinder group, but in 5.x there's a thing called > MINCYLGRPS, which results in fewer free space on a floppy: >=20 > : # uname -r > : 4.7-STABLE > : # ./x > : Warning: Block size restricts cylinders per group to 6. > : Warning: 1216 sector(s) in last cylinder unallocated > : /dev/vn0c: 2880 sectors in 1 cylinders of 1 tracks, 4096 sectors > : 1.4MB in 1 cyl groups (6 c/g, 12.00MB/g, 384 i/g) > : super-block backups (for fsck -b #) at: > : 32 > : Filesystem 1K-blocks Used Avail Capacity iused ifree %iused Mou= nted on > : /dev/vn0 1363 0 1363 0% 1 381 0% =20 >=20 > : # uname -r > : 5.0-CURRENT > : # ./x > : /dev/md0c: 1.4MB (2880 sectors) block size 4096, fragment size 512 > : using 4 cylinder groups of 0.36MB, 91 blks, 128 inodes. > : super-block backups (for fsck -b #) at: > : 32, 760, 1488, 2216 > : Filesystem 1K-blocks Used Avail Capacity iused ifree %iused Moun= ted on > : /dev/md0 1311 0 1311 0% 1 509 0% =20 >=20 > With this patch to newfs(8), >=20 > : Index: mkfs.c > : =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > : RCS file: /home/ncvs/src/sbin/newfs/mkfs.c,v > : retrieving revision 1.74 > : diff -u -p -r1.74 mkfs.c > : --- mkfs.c 22 Feb 2003 23:26:11 -0000 1.74 > : +++ mkfs.c 26 Feb 2003 11:20:57 -0000 > : @@ -317,7 +317,7 @@ mkfs(struct partition *pp, char *fsys) > : for ( ; sblock.fs_fpg < maxblkspercg; sblock.fs_fpg +=3D sblock.fs_fr= ag) { > : sblock.fs_ipg =3D roundup(howmany(sblock.fs_fpg, fragsperinode), > : INOPB(&sblock)); > : - if (sblock.fs_size / sblock.fs_fpg < MINCYLGRPS) > : + if (sblock.fs_size / sblock.fs_fpg < (Oflag =3D=3D 2 ? MINCYLGRPS : = 1)) > : break; > : if (CGSIZE(&sblock) < (unsigned long)sblock.fs_bsize) > : continue; >=20 > I still don't get the same picture as on 4.x, but it's now at least > sufficient to make release.10 happy. >=20 > : # ./x > : /dev/md0c: 1.4MB (2880 sectors) block size 4096, fragment size 512 > : using 1 cylinder groups of 1.41MB, 361 blks, 416 inodes. > : super-block backups (for fsck -b #) at: > : 32 > : Filesystem 1K-blocks Used Avail Capacity iused ifree %iused Moun= ted on > : /dev/md0 1359 0 1359 0% 1 413 0% =20 >=20 > John, I'm sending you the complete patchset in another email. >=20 >=20 > Cheers, > --=20 > Ruslan Ermilov Sysadmin and DBA, > ru@sunbay.com Sunbay Software AG, > ru@FreeBSD.org FreeBSD committer, > +380.652.512.251 Simferopol, Ukraine >=20 > http://www.FreeBSD.org The Power To Serve > http://www.oracle.com Enabling The Information Age > FSIMG=3Dfixit.flp > FSSIZE=3D1440 > FSLABEL=3Dfd1440 > FSINODE=3D4000 >=20 > dd of=3D${FSIMG} if=3D/dev/zero count=3D${FSSIZE} bs=3D1k 2>/dev/null >=20 > case `uname -r` in > 4.*) > DEVICE=3Dvn0 > vnconfig -s labels -c /dev/${DEVICE} ${FSIMG} > ;; > 5.*) > DEVICE=3D`mdconfig -a -t vnode -f ${FSIMG}` > ;; > esac >=20 > disklabel -w -B ${DEVICE} ${FSLABEL} > newfs -i ${FSINODE} -o space -m 0 /dev/${DEVICE}c >=20 > #disklabel ${DEVICE} > df -i /dev/${DEVICE} >=20 > case `uname -r` in > 4.*) > vnconfig -u ${DEVICE} > ;; > 5.*) > mdconfig -d -u ${DEVICE} > ;; > esac --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+bmP0Ukv4P6juNwoRAoDrAJ4p7FifjoJam7S7zbPw+7qln8KA7ACePbX8 MZAndoVgEOF5zz7oLcOzzmM= =Cv/V -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf-- --vkogqOf2sHV7VnPd-- --lEGEL1/lMxI0MVQ2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/IMI+Ukv4P6juNwoRAkOsAJ9EsdQ4bBK8DjSx6LuWbhi46LjUzQCfeQGH HvZfaNafZ3v6SlqMclAUzSY= =c9fS -----END PGP SIGNATURE----- --lEGEL1/lMxI0MVQ2-- From owner-cvs-src@FreeBSD.ORG Thu Jul 24 23:39:47 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C358837B401; Thu, 24 Jul 2003 23:39:47 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F89D43FAF; Thu, 24 Jul 2003 23:39:47 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P6dl0U085985; Thu, 24 Jul 2003 23:39:47 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P6dlAj085984; Thu, 24 Jul 2003 23:39:47 -0700 (PDT) Message-Id: <200307250639.h6P6dlAj085984@repoman.freebsd.org> From: Hartmut Brandt Date: Thu, 24 Jul 2003 23:39:47 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm/uni uniarp.c uniarp_input.c unisig_msg.c unisig_proto.c unisig_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 06:39:48 -0000 harti 2003/07/24 23:39:47 PDT FreeBSD src repository Modified files: sys/netatm/uni uniarp.c uniarp_input.c unisig_msg.c unisig_proto.c unisig_var.h Log: Make the debugging variable that controls printing of UNI messages accessible as a sysctl and move the debugging stuff out of DIAGNOSTICS. Submitted by: Vincent Jardin MFC after: 2 weeks Revision Changes Path 1.19 +8 -1 src/sys/netatm/uni/uniarp.c 1.15 +0 -2 src/sys/netatm/uni/uniarp_input.c 1.16 +9 -11 src/sys/netatm/uni/unisig_msg.c 1.11 +7 -1 src/sys/netatm/uni/unisig_proto.c 1.8 +5 -0 src/sys/netatm/uni/unisig_var.h From owner-cvs-src@FreeBSD.ORG Thu Jul 24 23:43:41 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D8E7137B401; Thu, 24 Jul 2003 23:43:41 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 748DB43F85; Thu, 24 Jul 2003 23:43:41 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P6hf0U086247; Thu, 24 Jul 2003 23:43:41 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P6hfY2086246; Thu, 24 Jul 2003 23:43:41 -0700 (PDT) Message-Id: <200307250643.h6P6hfY2086246@repoman.freebsd.org> From: Hartmut Brandt Date: Thu, 24 Jul 2003 23:43:41 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_cm.c atm_device.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 06:43:42 -0000 harti 2003/07/24 23:43:41 PDT FreeBSD src repository Modified files: sys/netatm atm_cm.c atm_device.c Log: Hand the packet to bpf not only in the LLC/SNAP case, but for all connections. While this confuses tcpdump, it enables other applications to see and analyze non-IP traffic (signalling, for example). Pointed out by: Vincent Jardin Revision Changes Path 1.30 +12 -11 src/sys/netatm/atm_cm.c 1.25 +1 -2 src/sys/netatm/atm_device.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 00:16:29 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3CECF37B401; Fri, 25 Jul 2003 00:16:29 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE04843F3F; Fri, 25 Jul 2003 00:16:28 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P7GS0U088649; Fri, 25 Jul 2003 00:16:28 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P7GS5K088648; Fri, 25 Jul 2003 00:16:28 -0700 (PDT) Message-Id: <200307250716.h6P7GS5K088648@repoman.freebsd.org> From: Hartmut Brandt Date: Fri, 25 Jul 2003 00:16:28 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 07:16:29 -0000 harti 2003/07/25 00:16:28 PDT FreeBSD src repository Modified files: sys/netatm atm_if.c Log: Set the interface type of the network interfaces to IFT_IPOVERATM(114). This is specified by RFC2320. Revision Changes Path 1.26 +1 -1 src/sys/netatm/atm_if.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 00:18:07 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F98037B401; Fri, 25 Jul 2003 00:18:07 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 299C543F3F; Fri, 25 Jul 2003 00:18:07 -0700 (PDT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P7I60U088718; Fri, 25 Jul 2003 00:18:07 -0700 (PDT) (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P7I6aT088717; Fri, 25 Jul 2003 00:18:06 -0700 (PDT) Message-Id: <200307250718.h6P7I6aT088717@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Fri, 25 Jul 2003 00:18:06 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/tinderbox current.rc releng_4.rc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 07:18:08 -0000 des 2003/07/25 00:18:06 PDT FreeBSD src repository Modified files: tools/tools/tinderbox current.rc releng_4.rc Log: Ready to go live. Revision Changes Path 1.2 +1 -0 src/tools/tools/tinderbox/current.rc 1.2 +1 -0 src/tools/tools/tinderbox/releng_4.rc From owner-cvs-src@FreeBSD.ORG Fri Jul 25 00:25:57 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24C3837B401; Fri, 25 Jul 2003 00:25:57 -0700 (PDT) Received: from mail.broadpark.no (mail.broadpark.no [217.13.4.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id E3B3F43FA3; Fri, 25 Jul 2003 00:25:53 -0700 (PDT) (envelope-from des@des.no) Received: from smtp.des.no (37.80-203-228.nextgentel.com [80.203.228.37]) by mail.broadpark.no (Postfix) with ESMTP id 45570787EC; Fri, 25 Jul 2003 09:25:52 +0200 (MEST) Received: by smtp.des.no (Pony Express, from userid 666) id 0B177963F9; Fri, 25 Jul 2003 09:25:52 +0200 (CEST) Received: from dwp.des.no (dwp.des.no [10.0.0.4]) by smtp.des.no (Pony Express) with ESMTP id 5E8429595E; Fri, 25 Jul 2003 09:25:48 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 0FEC0B822; Fri, 25 Jul 2003 09:25:48 +0200 (CEST) To: Mark Murray References: <200307241830.h6OIUPWd032096@repoman.freebsd.org> From: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) Date: Fri, 25 Jul 2003 09:25:47 +0200 In-Reply-To: <200307241830.h6OIUPWd032096@repoman.freebsd.org> (Mark Murray's message of "Thu, 24 Jul 2003 11:30:25 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.090024 (Oort Gnus v0.24) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, hits=-3.0 required=8.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES,USER_AGENT_GNUS_UA version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ed Makefile src/games/factor Makefile src/lib Makefile src/usr.bin Makefile src/usr.sbin Makefile src/usr.sbin/ppp Makefile src/usr.sbin/pppd Makefile src/usr.sbin/sendmail Makefile src/usr.sbin/tcpdump/tcpdump ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 07:25:57 -0000 Mark Murray writes: > Log: > Don't check for the existance of src/crypto/ for building items that > may contain crypto. The days of ITAR paranoia are over, and the simple > macro tests that remain are sufficient. Wheee! DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Fri Jul 25 00:41:28 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2225A37B404 for ; Fri, 25 Jul 2003 00:41:28 -0700 (PDT) Received: from smtp.mho.com (smtp.mho.net [64.58.4.6]) by mx1.FreeBSD.org (Postfix) with SMTP id 3E5B543FBF for ; Fri, 25 Jul 2003 00:41:25 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: (qmail 89197 invoked by uid 1002); 25 Jul 2003 07:41:24 -0000 Received: from adsl-64-58-12-196.mho.net (HELO freebsd.org) (64.58.12.196) by smtp.mho.net with SMTP; 25 Jul 2003 07:41:24 -0000 Message-ID: <3F20DF2D.8030209@freebsd.org> Date: Fri, 25 Jul 2003 01:41:33 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ruslan Ermilov References: <200307250010.h6P0AYKW061085@repoman.freebsd.org> <20030725053806.GA36982@sunbay.com> In-Reply-To: <20030725053806.GA36982@sunbay.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release/i386 drivers.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 07:41:28 -0000 Ruslan Ermilov wrote: > On Thu, Jul 24, 2003 at 05:10:33PM -0700, Scott Long wrote: > >>scottl 2003/07/24 17:10:33 PDT >> >> FreeBSD src repository >> >> Modified files: >> release/i386 drivers.conf >> Log: >> Move the mlx driver back into the kernel so that the drivers floppy doesn't >> overflow. >> >> Revision Changes Path >> 1.29 +0 -1 src/release/i386/drivers.conf >> > > Which reminds me. The floppy wasn't overflowing when building > 5.x snapshot on 4.x, due to the differences in file system > layout between 4.x and 5.x. Please see the attached if you're > interested. > > > Cheers, > > Now that -O2 is the default for newfs in 5-current, does the 'Oflag == 2' trick still work? Even if it does, it feels like a hack to me. I'd rather that newfs have an option to directly override the number of c/g's, rather than rely on indirect calculations and magic constants. Please don't commit this until we have discussed it more. Scott > ------------------------------------------------------------------------ > > Subject: > Re: MINCYLGRPS (was: 4-stable releases on -current?) > From: > Ruslan Ermilov > Date: > Wed, 12 Mar 2003 00:32:21 +0200 > To: > Poul-Henning Kamp , Kirk McKusick > > > Hey, is anybody ever going to answer this email? > > On Wed, Feb 26, 2003 at 02:48:10PM +0200, Ruslan Ermilov wrote: > >>On Tue, Feb 25, 2003 at 09:52:02PM +0200, Ruslan Ermilov wrote: >> >>>On Tue, Feb 25, 2003 at 08:02:19PM +0200, John Hay wrote: >> >>[...] >> >>>>Ok, with the patches below I can get to where it tries to build the >>>>fixit floppy in release.10. It breaks because the floppy is too small. >>>>I must still check to make sure it is true. >>>> >>> >>>We'll know this in less than 1:30 -- I've just launched the >>>snapshot build for 4.x/i386 on my fast -stable box. >>> >>>While I was writing it, it's already finished (successfully). >>> >>>ftp://ftp.sunbay.net/pub/FreeBSD/snapshots/i386/4.x-20030225-STABLE/ >>> >> >>OK, I've tracked it down to the differences in newfs(8) between >>4.x and 5.x. In 4.x, newfs'ing a 1.44MB floppy results in a >>single cylinder group, but in 5.x there's a thing called >>MINCYLGRPS, which results in fewer free space on a floppy: >> >>: # uname -r >>: 4.7-STABLE >>: # ./x >>: Warning: Block size restricts cylinders per group to 6. >>: Warning: 1216 sector(s) in last cylinder unallocated >>: /dev/vn0c: 2880 sectors in 1 cylinders of 1 tracks, 4096 sectors >>: 1.4MB in 1 cyl groups (6 c/g, 12.00MB/g, 384 i/g) >>: super-block backups (for fsck -b #) at: >>: 32 >>: Filesystem 1K-blocks Used Avail Capacity iused ifree %iused Mounted on >>: /dev/vn0 1363 0 1363 0% 1 381 0% >> >>: # uname -r >>: 5.0-CURRENT >>: # ./x >>: /dev/md0c: 1.4MB (2880 sectors) block size 4096, fragment size 512 >>: using 4 cylinder groups of 0.36MB, 91 blks, 128 inodes. >>: super-block backups (for fsck -b #) at: >>: 32, 760, 1488, 2216 >>: Filesystem 1K-blocks Used Avail Capacity iused ifree %iused Mounted on >>: /dev/md0 1311 0 1311 0% 1 509 0% >> >>With this patch to newfs(8), >> >>: Index: mkfs.c >>: =================================================================== >>: RCS file: /home/ncvs/src/sbin/newfs/mkfs.c,v >>: retrieving revision 1.74 >>: diff -u -p -r1.74 mkfs.c >>: --- mkfs.c 22 Feb 2003 23:26:11 -0000 1.74 >>: +++ mkfs.c 26 Feb 2003 11:20:57 -0000 >>: @@ -317,7 +317,7 @@ mkfs(struct partition *pp, char *fsys) >>: for ( ; sblock.fs_fpg < maxblkspercg; sblock.fs_fpg += sblock.fs_frag) { >>: sblock.fs_ipg = roundup(howmany(sblock.fs_fpg, fragsperinode), >>: INOPB(&sblock)); >>: - if (sblock.fs_size / sblock.fs_fpg < MINCYLGRPS) >>: + if (sblock.fs_size / sblock.fs_fpg < (Oflag == 2 ? MINCYLGRPS : 1)) >>: break; >>: if (CGSIZE(&sblock) < (unsigned long)sblock.fs_bsize) >>: continue; >> >>I still don't get the same picture as on 4.x, but it's now at least >>sufficient to make release.10 happy. >> >>: # ./x >>: /dev/md0c: 1.4MB (2880 sectors) block size 4096, fragment size 512 >>: using 1 cylinder groups of 1.41MB, 361 blks, 416 inodes. >>: super-block backups (for fsck -b #) at: >>: 32 >>: Filesystem 1K-blocks Used Avail Capacity iused ifree %iused Mounted on >>: /dev/md0 1359 0 1359 0% 1 413 0% >> >>John, I'm sending you the complete patchset in another email. >> >> >>Cheers, >>-- >>Ruslan Ermilov Sysadmin and DBA, >>ru@sunbay.com Sunbay Software AG, >>ru@FreeBSD.org FreeBSD committer, >>+380.652.512.251 Simferopol, Ukraine >> >>http://www.FreeBSD.org The Power To Serve >>http://www.oracle.com Enabling The Information Age > > >>FSIMG=fixit.flp >>FSSIZE=1440 >>FSLABEL=fd1440 >>FSINODE=4000 >> >>dd of=${FSIMG} if=/dev/zero count=${FSSIZE} bs=1k 2>/dev/null >> >>case `uname -r` in >>4.*) >> DEVICE=vn0 >> vnconfig -s labels -c /dev/${DEVICE} ${FSIMG} >> ;; >>5.*) >> DEVICE=`mdconfig -a -t vnode -f ${FSIMG}` >> ;; >>esac >> >>disklabel -w -B ${DEVICE} ${FSLABEL} >>newfs -i ${FSINODE} -o space -m 0 /dev/${DEVICE}c >> >>#disklabel ${DEVICE} >>df -i /dev/${DEVICE} >> >>case `uname -r` in >>4.*) >> vnconfig -u ${DEVICE} >> ;; >>5.*) >> mdconfig -d -u ${DEVICE} >> ;; >>esac > > > > > From owner-cvs-src@FreeBSD.ORG Fri Jul 25 00:52:21 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6AD7737B401; Fri, 25 Jul 2003 00:52:21 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 07A0A43F75; Fri, 25 Jul 2003 00:52:21 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P7qK0U095342; Fri, 25 Jul 2003 00:52:20 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P7qKI5095341; Fri, 25 Jul 2003 00:52:20 -0700 (PDT) Message-Id: <200307250752.h6P7qKI5095341@repoman.freebsd.org> From: Marcel Moolenaar Date: Fri, 25 Jul 2003 00:52:20 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ia64/conf SKI X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 07:52:22 -0000 marcel 2003/07/25 00:52:20 PDT FreeBSD src repository Modified files: sys/ia64/conf SKI Log: Remove INVARIANT* and WITNESS. This makes the simulator much more pleasant to use. Revision Changes Path 1.15 +0 -3 src/sys/ia64/conf/SKI From owner-cvs-src@FreeBSD.ORG Fri Jul 25 01:02:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B53337B401; Fri, 25 Jul 2003 01:02:25 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 37EDF43F3F; Fri, 25 Jul 2003 01:02:25 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P82P0U095823; Fri, 25 Jul 2003 01:02:25 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P82Oak095822; Fri, 25 Jul 2003 01:02:24 -0700 (PDT) Message-Id: <200307250802.h6P82Oak095822@repoman.freebsd.org> From: Marcel Moolenaar Date: Fri, 25 Jul 2003 01:02:24 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ia64/ia64 trap.c src/sys/ia64/include _regset.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 08:02:26 -0000 marcel 2003/07/25 01:02:24 PDT FreeBSD src repository Modified files: sys/ia64/ia64 trap.c sys/ia64/include _regset.h Log: Remove __aligned(16) from the definition of struct _ia64_fpreg. It's a non-standard construct. Instead, redefine struct _ia64_fpreg as a union and put a long double in it. On ia64 and for LP64, this is defined by the ABI to have 16-byte alignment. For ILP32 a long double has 4-byte alignment, but we don't support ILP32. Note that the in-memory image of a long double does not match the in- memory image of spilled FP registers. This means that one cannot use the fpr_flt field to interpet the bits. For this reason we continue to use an aggregate type. Revision Changes Path 1.86 +4 -4 src/sys/ia64/ia64/trap.c 1.4 +129 -128 src/sys/ia64/include/_regset.h From owner-cvs-src@FreeBSD.ORG Fri Jul 25 01:09:19 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B1C837B401; Fri, 25 Jul 2003 01:09:19 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB7CD43F85; Fri, 25 Jul 2003 01:09:18 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P89I0U096963; Fri, 25 Jul 2003 01:09:18 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P89IiB096962; Fri, 25 Jul 2003 01:09:18 -0700 (PDT) Message-Id: <200307250809.h6P89IiB096962@repoman.freebsd.org> From: Hartmut Brandt Date: Fri, 25 Jul 2003 01:09:18 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/atm/ilmid Makefile ilmid.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 08:09:19 -0000 harti 2003/07/25 01:09:18 PDT FreeBSD src repository Modified files: sbin/atm/ilmid Makefile ilmid.c Log: Make ilmid WARNS=6 clean. The problem were a couple of unused function arguments and missing consts. Revision Changes Path 1.9 +1 -0 src/sbin/atm/ilmid/Makefile 1.30 +13 -14 src/sbin/atm/ilmid/ilmid.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 01:15:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 136BA37B401; Fri, 25 Jul 2003 01:15:10 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A51E643F75; Fri, 25 Jul 2003 01:15:09 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P8F90U097241; Fri, 25 Jul 2003 01:15:09 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P8F9vl097240; Fri, 25 Jul 2003 01:15:09 -0700 (PDT) Message-Id: <200307250815.h6P8F9vl097240@repoman.freebsd.org> From: Hartmut Brandt Date: Fri, 25 Jul 2003 01:15:09 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/atm/ilmid ilmid.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 08:15:10 -0000 harti 2003/07/25 01:15:09 PDT FreeBSD src repository Modified files: sbin/atm/ilmid ilmid.c Log: Due to a gcc bug, it doesn't like local variables with names like 'sin'. Rename this for the moment. Also fix a sparc64 alignment warning. Revision Changes Path 1.31 +3 -3 src/sbin/atm/ilmid/ilmid.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 01:22:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BD9A37B401; Fri, 25 Jul 2003 01:22:08 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7572C43F3F; Fri, 25 Jul 2003 01:22:08 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P8M80U097488; Fri, 25 Jul 2003 01:22:08 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P8M84Z097487; Fri, 25 Jul 2003 01:22:08 -0700 (PDT) Message-Id: <200307250822.h6P8M84Z097487@repoman.freebsd.org> From: Hartmut Brandt Date: Fri, 25 Jul 2003 01:22:08 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libatm Makefile ioctl_subr.c ip_addr.c ip_checksum.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 08:22:11 -0000 harti 2003/07/25 01:22:08 PDT FreeBSD src repository Modified files: lib/libatm Makefile ioctl_subr.c ip_addr.c ip_checksum.c Log: Make library WARNS=6 clean. The problems have been: alignment on sparc64 and one of the usual sizeof(in_addr_t) == sizeof(u_long) bugs. Revision Changes Path 1.7 +1 -1 src/lib/libatm/Makefile 1.9 +4 -4 src/lib/libatm/ioctl_subr.c 1.9 +2 -1 src/lib/libatm/ip_addr.c 1.8 +1 -1 src/lib/libatm/ip_checksum.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 01:23:08 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E43937B401; Fri, 25 Jul 2003 01:23:08 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9BC5143FA3; Fri, 25 Jul 2003 01:23:07 -0700 (PDT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P8N70U097527; Fri, 25 Jul 2003 01:23:07 -0700 (PDT) (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P8N7bQ097526; Fri, 25 Jul 2003 01:23:07 -0700 (PDT) Message-Id: <200307250823.h6P8N7bQ097526@repoman.freebsd.org> From: Maxim Konovalov Date: Fri, 25 Jul 2003 01:23:07 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sbin/ipfw ipfw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 08:23:08 -0000 maxim 2003/07/25 01:23:07 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sbin/ipfw ipfw2.c Log: MFC rev. 1.38: initialize do_pipe before command parsing. Revision Changes Path 1.4.2.17 +1 -0 src/sbin/ipfw/ipfw2.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 01:24:07 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE9B537B404; Fri, 25 Jul 2003 01:24:07 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 00DCD43F3F; Fri, 25 Jul 2003 01:24:04 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6P8Nv0U054686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 25 Jul 2003 11:23:57 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6P8NvUa054681; Fri, 25 Jul 2003 11:23:57 +0300 (EEST) (envelope-from ru) Date: Fri, 25 Jul 2003 11:23:57 +0300 From: Ruslan Ermilov To: Scott Long Message-ID: <20030725082357.GA53826@sunbay.com> References: <200307250010.h6P0AYKW061085@repoman.freebsd.org> <20030725053806.GA36982@sunbay.com> <3F20DF2D.8030209@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YiEDa0DAkWCtVeE4" Content-Disposition: inline In-Reply-To: <3F20DF2D.8030209@freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Bruce Evans cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/release/i386 drivers.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 08:24:08 -0000 --YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 25, 2003 at 01:41:33AM -0600, Scott Long wrote: > Ruslan Ermilov wrote: > >On Thu, Jul 24, 2003 at 05:10:33PM -0700, Scott Long wrote: > > > >>scottl 2003/07/24 17:10:33 PDT > >> > >> FreeBSD src repository > >> > >> Modified files: > >> release/i386 drivers.conf=20 > >> Log: > >> Move the mlx driver back into the kernel so that the drivers floppy=20 > >> doesn't > >> overflow. > >>=20 > >> Revision Changes Path > >> 1.29 +0 -1 src/release/i386/drivers.conf > >> > > > >Which reminds me. The floppy wasn't overflowing when building > >5.x snapshot on 4.x, due to the differences in file system > >layout between 4.x and 5.x. Please see the attached if you're > >interested. > > > > > >Cheers, > > > > >=20 > Now that -O2 is the default for newfs in 5-current, does the 'Oflag =3D= =3D=20 > 2' trick still work? >=20 Yes it does: 1. doFS.sh creates file systems with -O1 2. The patch affects the -O1 case: dd if=3D/dev/zero of=3Dfloppy.img bs=3D1k count=3D1440 mdconfig -a -t vnode -f floppy.img -u 0 disklabel -r -w md0 fd1440 newfs -O1 -ospace -m0 -i40000 /dev/md0c df -k /dev/md0 mdconfig -d -u 0 Using this script, which resembles the numbers for drivers.flp, I get: 1. Unpatched newfs(8): : /dev/md0c: 1.4MB (2880 sectors) block size 4096, fragment size 512 : using 2 cylinder groups of 1.22MB, 312 blks, 32 inodes. ^ : super-block backups (for fsck -b #) at: : 32, 2528 : Filesystem 1K-blocks Used Avail Capacity Mounted on : /dev/md0 1391 0 1391 0% ^^^^ 2. Patched newfs(8): : /dev/md0c: 1.4MB (2880 sectors) block size 4096, fragment size 512 : using 1 cylinder groups of 1.41MB, 361 blks, 64 inodes. ^ : super-block backups (for fsck -b #) at: : 32 : Filesystem 1K-blocks Used Avail Capacity Mounted on : /dev/md0 1403 0 1403 0% ^^^^ > Even if it does, it feels like a hack to me. I'd > rather that newfs have an option to directly override the number of > c/g's, rather than rely on indirect calculations and magic constants. >=20 *Shrug*, an option to override a minimum value? > Please don't commit this until we have discussed it more. >=20 I'm not committing it since February 26th, so waiting a couple of months more is not an issue. :-) Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --YiEDa0DAkWCtVeE4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/IOkdUkv4P6juNwoRAnHFAJ97AWx5ddTXEWzHyn9z03dwjERRzwCeJQ+N 3sASD8tUhZZkiuT9s5DHGQg= =lrTe -----END PGP SIGNATURE----- --YiEDa0DAkWCtVeE4-- From owner-cvs-src@FreeBSD.ORG Fri Jul 25 01:35:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB4FA37B401; Fri, 25 Jul 2003 01:35:27 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 60FED43F75; Fri, 25 Jul 2003 01:35:27 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P8ZQ0U097922; Fri, 25 Jul 2003 01:35:27 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P8ZQYA097921; Fri, 25 Jul 2003 01:35:26 -0700 (PDT) Message-Id: <200307250835.h6P8ZQYA097921@repoman.freebsd.org> From: Hartmut Brandt Date: Fri, 25 Jul 2003 01:35:26 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_ioctl.h atm_socket.c src/sys/netatm/ipatm ipatm_usrreq.c ipatm_var.h ipatm_vcm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 08:35:28 -0000 harti 2003/07/25 01:35:26 PDT FreeBSD src repository Modified files: sys/netatm atm_ioctl.h atm_socket.c sys/netatm/ipatm ipatm_usrreq.c ipatm_var.h ipatm_vcm.c Log: Add support for VBR and CBR PVCs for IP over ATM. Submitted by: Vincent Jardin MFC after: 2 weeks Revision Changes Path 1.6 +6 -0 src/sys/netatm/atm_ioctl.h 1.18 +3 -1 src/sys/netatm/atm_socket.c 1.12 +101 -0 src/sys/netatm/ipatm/ipatm_usrreq.c 1.8 +2 -0 src/sys/netatm/ipatm/ipatm_var.h 1.16 +93 -5 src/sys/netatm/ipatm/ipatm_vcm.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 01:50:41 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 67AE337B401; Fri, 25 Jul 2003 01:50:41 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C354943FAF; Fri, 25 Jul 2003 01:50:40 -0700 (PDT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P8oe0U098364; Fri, 25 Jul 2003 01:50:40 -0700 (PDT) (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P8oeAt098363; Fri, 25 Jul 2003 01:50:40 -0700 (PDT) Message-Id: <200307250850.h6P8oeAt098363@repoman.freebsd.org> From: Bruce Evans Date: Fri, 25 Jul 2003 01:50:40 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/usr.sbin/iostat iostat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 08:50:41 -0000 bde 2003/07/25 01:50:39 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) usr.sbin/iostat iostat.c Log: MFC: 1.25 (use essentially the same formatting of the CPU stats percentages as in vmstat so that they never coalesce). PR: 41674 Revision Changes Path 1.17.2.3 +2 -2 src/usr.sbin/iostat/iostat.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 01:54:42 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D1ACF37B401; Fri, 25 Jul 2003 01:54:42 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8052243F85; Fri, 25 Jul 2003 01:54:42 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P8sg0U098537; Fri, 25 Jul 2003 01:54:42 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P8sfom098536; Fri, 25 Jul 2003 01:54:41 -0700 (PDT) Message-Id: <200307250854.h6P8sfom098536@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 25 Jul 2003 01:54:41 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile src/share/man/man7 release.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 08:54:43 -0000 ru 2003/07/25 01:54:41 PDT FreeBSD src repository Modified files: release Makefile share/man/man7 release.7 Log: Moved the boot floppy generation code out from release.9 to release.10. The release.9 target is now responsible only for generation of MFS root file systems, that are built for all architectures, even those that do not provide a floppy installation option. The release.10 target is now responsible for creation of a set of boot, MFS root, and fixit floppies, and the NO_FLOPPIES variable now affects only this target. Also, replaced the FIXIT_TARGET variable with a check of whether the *FIXITSIZE variables are present for a given architecture, similar to how this is done when generating boot floppies. Discussed with: jhb Revision Changes Path 1.797 +32 -49 src/release/Makefile 1.30 +4 -4 src/share/man/man7/release.7 From owner-cvs-src@FreeBSD.ORG Fri Jul 25 01:55:52 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DF9A37B401; Fri, 25 Jul 2003 01:55:52 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C54043F93; Fri, 25 Jul 2003 01:55:52 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P8tp0U098673; Fri, 25 Jul 2003 01:55:51 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P8tpCr098669; Fri, 25 Jul 2003 01:55:51 -0700 (PDT) Message-Id: <200307250855.h6P8tpCr098669@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 25 Jul 2003 01:55:51 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 08:55:52 -0000 ru 2003/07/25 01:55:51 PDT FreeBSD src repository Modified files: release Makefile Log: The RELEASE9 knob is now OBE. OK'ed by: jhb Revision Changes Path 1.798 +1 -7 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Fri Jul 25 02:59:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28C2837B401; Fri, 25 Jul 2003 02:59:18 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B731F43F93; Fri, 25 Jul 2003 02:59:17 -0700 (PDT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6P9xH0U002005; Fri, 25 Jul 2003 02:59:17 -0700 (PDT) (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6P9xHRH002004; Fri, 25 Jul 2003 02:59:17 -0700 (PDT) Message-Id: <200307250959.h6P9xHRH002004@repoman.freebsd.org> From: Maxim Konovalov Date: Fri, 25 Jul 2003 02:59:16 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_dummynet.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 09:59:18 -0000 maxim 2003/07/25 02:59:16 PDT FreeBSD src repository Modified files: sys/netinet ip_dummynet.c Log: o Do not overwrite saved interrupt priority level by alloc_hash(), use a separate variable. o Restore interrupt priority level before return (no-op in HEAD). Spotted by: Don Bowman MFC after: 5 days Revision Changes Path 1.67 +8 -6 src/sys/netinet/ip_dummynet.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 03:35:57 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DAD6437B401; Fri, 25 Jul 2003 03:35:57 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4644143F3F; Fri, 25 Jul 2003 03:35:57 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PAZv0U004511; Fri, 25 Jul 2003 03:35:57 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PAZuTl004510; Fri, 25 Jul 2003 03:35:56 -0700 (PDT) Message-Id: <200307251035.h6PAZuTl004510@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 25 Jul 2003 03:35:56 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/share/mk bsd.libnames.mk src/secure/usr.sbin/sshd Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 10:35:58 -0000 ru 2003/07/25 03:35:56 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) share/mk bsd.libnames.mk secure/usr.sbin/sshd Makefile Log: Fixed broken -DNOSHARED build in secure/usr.sbin/sshd. Revision Changes Path 1.5.2.10 +2 -2 src/secure/usr.sbin/sshd/Makefile 1.28.2.11 +3 -2 src/share/mk/bsd.libnames.mk From owner-cvs-src@FreeBSD.ORG Fri Jul 25 04:14:04 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B62737B401; Fri, 25 Jul 2003 04:14:04 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CCF6643F3F; Fri, 25 Jul 2003 04:14:03 -0700 (PDT) (envelope-from mux@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PBE30U006795; Fri, 25 Jul 2003 04:14:03 -0700 (PDT) (envelope-from mux@repoman.freebsd.org) Received: (from mux@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PBE3xj006794; Fri, 25 Jul 2003 04:14:03 -0700 (PDT) Message-Id: <200307251114.h6PBE3xj006794@repoman.freebsd.org> From: Maxime Henrion Date: Fri, 25 Jul 2003 04:14:03 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/games/fortune/datfiles fortunes X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 11:14:04 -0000 mux 2003/07/25 04:14:03 PDT FreeBSD src repository Modified files: games/fortune/datfiles fortunes Log: Remove a duplicate entry. Revision Changes Path 1.115 +0 -4 src/games/fortune/datfiles/fortunes From owner-cvs-src@FreeBSD.ORG Fri Jul 25 05:23:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0064D37B401; Fri, 25 Jul 2003 05:23:27 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 90F1043F3F; Fri, 25 Jul 2003 05:23:26 -0700 (PDT) (envelope-from mux@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PCNQ0U015355; Fri, 25 Jul 2003 05:23:26 -0700 (PDT) (envelope-from mux@repoman.freebsd.org) Received: (from mux@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PCNQYJ015354; Fri, 25 Jul 2003 05:23:26 -0700 (PDT) Message-Id: <200307251223.h6PCNQYJ015354@repoman.freebsd.org> From: Maxime Henrion Date: Fri, 25 Jul 2003 05:23:26 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/net ip6opt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 12:23:27 -0000 mux 2003/07/25 05:23:26 PDT FreeBSD src repository Modified files: lib/libc/net ip6opt.c Log: An u_int8_t can never be bigger than 255, so remove a useless check. Spotted by: GCC Revision Changes Path 1.4 +0 -2 src/lib/libc/net/ip6opt.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 05:32:09 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F89837B401; Fri, 25 Jul 2003 05:32:09 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1BA4143FA3; Fri, 25 Jul 2003 05:32:09 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PCW80U015700; Fri, 25 Jul 2003 05:32:08 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PCW8wd015699; Fri, 25 Jul 2003 05:32:08 -0700 (PDT) Message-Id: <200307251232.h6PCW8wd015699@repoman.freebsd.org> From: Hartmut Brandt Date: Fri, 25 Jul 2003 05:32:08 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm/spans spans_cls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 12:32:09 -0000 harti 2003/07/25 05:32:08 PDT FreeBSD src repository Modified files: sys/netatm/spans spans_cls.c Log: Print the offending SPANS message only if printing is enabled. Revision Changes Path 1.19 +2 -1 src/sys/netatm/spans/spans_cls.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 05:33:39 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B073737B401; Fri, 25 Jul 2003 05:33:39 -0700 (PDT) Received: from watery.cc.kogakuin.ac.jp (watery.cc.kogakuin.ac.jp [133.80.152.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 679BE43FBF; Fri, 25 Jul 2003 05:33:38 -0700 (PDT) (envelope-from nyan@jp.FreeBSD.org) Received: from localhost (localhost [IPv6:::1])h6PCXaFd081718; Fri, 25 Jul 2003 21:33:36 +0900 (JST) (envelope-from nyan@jp.FreeBSD.org) Date: Fri, 25 Jul 2003 21:31:23 +0900 (JST) Message-Id: <20030725.213123.74673434.nyan@jp.FreeBSD.org> To: ru@FreeBSD.org From: Takahashi Yoshihiro In-Reply-To: <200307250854.h6P8sfom098536@repoman.freebsd.org> References: <200307250854.h6P8sfom098536@repoman.freebsd.org> X-Mailer: Mew version 3.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile src/share/man/man7 release.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 12:33:40 -0000 In article <200307250854.h6P8sfom098536@repoman.freebsd.org> Ruslan Ermilov writes: > ru 2003/07/25 01:54:41 PDT > > FreeBSD src repository > > Modified files: > release Makefile > share/man/man7 release.7 > Log: > Moved the boot floppy generation code out from release.9 to release.10. - sh -e ${DOFS_SH} mfsroot ${RD} ${MNT} \ + sh -e ${DOFS_SH} mfsroot-small ${RD} ${MNT} \ (snip) + @sh -e ${DOFS_SH} ${RD}/floppies/mfsroot-small.flp \ + ${RD} ${MNT} ${SMALLBOOTSIZE} ${RD}/mfsroot/mfsroot-small.gz \ + ${BOOTINODE} ${SMALLBOOTLABEL} This change breaks small floppy image support. The filename of MFS filesystem should be 'mfsroot', not 'mfsroot-small'. Because we use the following command to load MFS filesystem. > load -t mfs_root /mfsroot --- TAKAHASHI Yoshihiro From owner-cvs-src@FreeBSD.ORG Fri Jul 25 05:40:04 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B9DED37B401; Fri, 25 Jul 2003 05:40:04 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5417543F85; Fri, 25 Jul 2003 05:40:04 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PCe40U015994; Fri, 25 Jul 2003 05:40:04 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PCe3xH015993; Fri, 25 Jul 2003 05:40:03 -0700 (PDT) Message-Id: <200307251240.h6PCe3xH015993@repoman.freebsd.org> From: Hartmut Brandt Date: Fri, 25 Jul 2003 05:40:03 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/atm/fore_dnld fore_dnld.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 12:40:05 -0000 harti 2003/07/25 05:40:03 PDT FreeBSD src repository Modified files: sbin/atm/fore_dnld fore_dnld.c Log: When deciding whether to download the microcode or not look at the API rather than at the vendor. We have three different Fore cards and only the PCA200 need the microcode. Look also at the RAM address and load the code only if it is not zero. A zero RAM address means either a bug in the driver or this is a interface created by harp(4) in which case fatm(4) handles the microcode issue. Revision Changes Path 1.10 +3 -3 src/sbin/atm/fore_dnld/fore_dnld.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 06:01:03 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 016FD37B401; Fri, 25 Jul 2003 06:01:03 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id A017D43F85; Fri, 25 Jul 2003 06:00:48 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6PD0f0U085761 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 25 Jul 2003 16:00:42 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6PD0fCr085756; Fri, 25 Jul 2003 16:00:41 +0300 (EEST) (envelope-from ru) Date: Fri, 25 Jul 2003 16:00:41 +0300 From: Ruslan Ermilov To: Takahashi Yoshihiro Message-ID: <20030725130041.GA84040@sunbay.com> References: <200307250854.h6P8sfom098536@repoman.freebsd.org> <20030725.213123.74673434.nyan@jp.FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline In-Reply-To: <20030725.213123.74673434.nyan@jp.FreeBSD.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile src/share/man/man7 release.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 13:01:03 -0000 --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 25, 2003 at 09:31:23PM +0900, Takahashi Yoshihiro wrote: > In article <200307250854.h6P8sfom098536@repoman.freebsd.org> > Ruslan Ermilov writes: >=20 > > ru 2003/07/25 01:54:41 PDT > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > release Makefile=20 > > share/man/man7 release.7=20 > > Log: > > Moved the boot floppy generation code out from release.9 to release.1= 0. >=20 > - sh -e ${DOFS_SH} mfsroot ${RD} ${MNT} \ > + sh -e ${DOFS_SH} mfsroot-small ${RD} ${MNT} \ > (snip) > + @sh -e ${DOFS_SH} ${RD}/floppies/mfsroot-small.flp \ > + ${RD} ${MNT} ${SMALLBOOTSIZE} ${RD}/mfsroot/mfsroot-small.gz \ > + ${BOOTINODE} ${SMALLBOOTLABEL} >=20 > This change breaks small floppy image support. The filename of MFS > filesystem should be 'mfsroot', not 'mfsroot-small'. Because we use > the following command to load MFS filesystem. >=20 > > load -t mfs_root /mfsroot >=20 Would the following work for you? %%% Index: Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/release/Makefile,v retrieving revision 1.798 diff -u -r1.798 Makefile --- Makefile 25 Jul 2003 08:55:51 -0000 1.798 +++ Makefile 25 Jul 2003 12:58:42 -0000 @@ -1087,7 +1087,11 @@ @echo "echo Please insert MFS root floppy and press enter:" >> ${RD}/imag= e.${FSIMAGE}/boot/loader.rc @echo "read" >> ${RD}/image.${FSIMAGE}/boot/loader.rc .endif +.if defined(FDSIZE) && ${FDSIZE} =3D=3D "SMALL" + @echo "load -t mfs_root /mfsroot-small" >> ${RD}/image.${FSIMAGE}/boot/lo= ader.rc +.else @echo "load -t mfs_root /mfsroot" >> ${RD}/image.${FSIMAGE}/boot/loader.rc +.endif .if ${TARGET_ARCH} !=3D "ia64" @echo "set hint.acpi.0.disabled=3D1" >> ${RD}/image.${FSIMAGE}/boot/loade= r.rc .endif %%% Or do you insist that it's always named /mfsroot? Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/ISn5Ukv4P6juNwoRAl5YAJ9jtkxyZpVfgvIjYOG7fJVogIRbVACfajra OWbBD9W0MAzP4AStqE/bIAY= =vuY1 -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7-- From owner-cvs-src@FreeBSD.ORG Fri Jul 25 06:15:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B36F37B401; Fri, 25 Jul 2003 06:15:45 -0700 (PDT) Received: from watery.cc.kogakuin.ac.jp (watery.cc.kogakuin.ac.jp [133.80.152.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 784F943F85; Fri, 25 Jul 2003 06:15:44 -0700 (PDT) (envelope-from nyan@jp.FreeBSD.org) Received: from localhost (localhost [IPv6:::1])h6PDFhFd083396; Fri, 25 Jul 2003 22:15:43 +0900 (JST) (envelope-from nyan@jp.FreeBSD.org) Date: Fri, 25 Jul 2003 22:15:24 +0900 (JST) Message-Id: <20030725.221524.41705123.nyan@jp.FreeBSD.org> To: ru@FreeBSD.org From: Takahashi Yoshihiro In-Reply-To: <20030725130041.GA84040@sunbay.com> References: <200307250854.h6P8sfom098536@repoman.freebsd.org> <20030725.213123.74673434.nyan@jp.FreeBSD.org> <20030725130041.GA84040@sunbay.com> X-Mailer: Mew version 3.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile src/share/man/man7 release.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 13:15:46 -0000 In article <20030725130041.GA84040@sunbay.com> Ruslan Ermilov writes: > Would the following work for you? Yes, probably. --- TAKAHASHI Yoshihiro From owner-cvs-src@FreeBSD.ORG Fri Jul 25 06:39:12 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E0D837B401; Fri, 25 Jul 2003 06:39:12 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D06BD43F75; Fri, 25 Jul 2003 06:39:11 -0700 (PDT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PDdB0U019033; Fri, 25 Jul 2003 06:39:11 -0700 (PDT) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PDdBR6019032; Fri, 25 Jul 2003 06:39:11 -0700 (PDT) Message-Id: <200307251339.h6PDdBR6019032@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 25 Jul 2003 06:39:11 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 13:39:12 -0000 ru 2003/07/25 06:39:11 PDT FreeBSD src repository Modified files: release Makefile Log: Make the PC98 small boot floppy usable again. Spotted by: nyan Reviewed by: nyan Revision Changes Path 1.799 +4 -0 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Fri Jul 25 07:08:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 405B437B401; Fri, 25 Jul 2003 07:08:33 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE1BE43FBD; Fri, 25 Jul 2003 07:08:32 -0700 (PDT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PE8W0U021000; Fri, 25 Jul 2003 07:08:32 -0700 (PDT) (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PE8W3N020999; Fri, 25 Jul 2003 07:08:32 -0700 (PDT) Message-Id: <200307251408.h6PE8W3N020999@repoman.freebsd.org> From: Hiroki Sato Date: Fri, 25 Jul 2003 07:08:32 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 14:08:33 -0000 hrs 2003/07/25 07:08:32 PDT FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: New release notes: bge(4) 5705 support. Update release notes: rescue(7) man page. MFC: safe(4). Revision Changes Path 1.596 +6 -1 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Fri Jul 25 07:08:41 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2A7937B416; Fri, 25 Jul 2003 07:08:41 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C8EB43F75; Fri, 25 Jul 2003 07:08:41 -0700 (PDT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PE8f0U021030; Fri, 25 Jul 2003 07:08:41 -0700 (PDT) (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PE8fV5021029; Fri, 25 Jul 2003 07:08:41 -0700 (PDT) Message-Id: <200307251408.h6PE8fV5021029@repoman.freebsd.org> From: Hiroki Sato Date: Fri, 25 Jul 2003 07:08:41 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 14:08:42 -0000 hrs 2003/07/25 07:08:41 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: New release notes: proatm driver. MFC: bge(4), safe(4). Revision Changes Path 1.22.2.360 +12 -1 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Fri Jul 25 08:54:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F38DF37B401; Fri, 25 Jul 2003 08:54:24 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E15743F3F; Fri, 25 Jul 2003 08:54:24 -0700 (PDT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PFsO0U031024; Fri, 25 Jul 2003 08:54:24 -0700 (PDT) (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PFsOxg031023; Fri, 25 Jul 2003 08:54:24 -0700 (PDT) Message-Id: <200307251554.h6PFsOxg031023@repoman.freebsd.org> From: Bruce Evans Date: Fri, 25 Jul 2003 08:54:23 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/libkern scanc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 15:54:25 -0000 bde 2003/07/25 08:54:23 PDT FreeBSD src repository Modified files: sys/libkern scanc.c Log: Backed out the micro-optimization in 1.4. It was to help gcc-2.6.3 on i486's (and probably i386's), but it has had very little effect since gcc-2.7 or gcc-2.95. With gcc-3.3, it gave a small pessimization for at least i386's, athlon-xp's and pentium4's, a small optimization (I think) for pentium1's, and made no difference for i386's. (movzbl is best for all the later processors, and the micro-optimization was to stop it being used on i486's.) Revision Changes Path 1.10 +1 -6 src/sys/libkern/scanc.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 09:27:17 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5CEB537B401; Fri, 25 Jul 2003 09:27:17 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67DE943F85; Fri, 25 Jul 2003 09:27:16 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h6PGRFju037672; Fri, 25 Jul 2003 09:27:15 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h6PGRBq6037671; Fri, 25 Jul 2003 09:27:11 -0700 (PDT) Date: Fri, 25 Jul 2003 09:27:11 -0700 From: "David O'Brien" To: Takahashi Yoshihiro Message-ID: <20030725162711.GB37608@dragon.nuxi.com> References: <200307250854.h6P8sfom098536@repoman.freebsd.org> <20030725.213123.74673434.nyan@jp.FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030725.213123.74673434.nyan@jp.FreeBSD.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.1-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: ru@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile src/share/man/man7 release.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 16:27:17 -0000 On Fri, Jul 25, 2003 at 09:31:23PM +0900, Takahashi Yoshihiro wrote: > In article <200307250854.h6P8sfom098536@repoman.freebsd.org> > Ruslan Ermilov writes: > + @sh -e ${DOFS_SH} ${RD}/floppies/mfsroot-small.flp \ > + ${RD} ${MNT} ${SMALLBOOTSIZE} ${RD}/mfsroot/mfsroot-small.gz \ > + ${BOOTINODE} ${SMALLBOOTLABEL} > > This change breaks small floppy image support. What is the "small floppy" image for now days? From owner-cvs-src@FreeBSD.ORG Fri Jul 25 09:29:54 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC66B37B401; Fri, 25 Jul 2003 09:29:53 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 310B043F85; Fri, 25 Jul 2003 09:29:53 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h6PGTqju037696; Fri, 25 Jul 2003 09:29:52 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h6PGTqQx037695; Fri, 25 Jul 2003 09:29:52 -0700 (PDT) Date: Fri, 25 Jul 2003 09:29:52 -0700 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20030725162952.GC37608@dragon.nuxi.com> References: <200307250854.h6P8sfom098536@repoman.freebsd.org> <20030725.213123.74673434.nyan@jp.FreeBSD.org> <20030725130041.GA84040@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030725130041.GA84040@sunbay.com> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.1-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Takahashi Yoshihiro cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile src/share/man/man7 release.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 16:29:54 -0000 On Fri, Jul 25, 2003 at 04:00:41PM +0300, Ruslan Ermilov wrote: > Index: Makefile > =================================================================== > RCS file: /home/ncvs/src/release/Makefile,v > retrieving revision 1.798 > diff -u -r1.798 Makefile > --- Makefile 25 Jul 2003 08:55:51 -0000 1.798 > +++ Makefile 25 Jul 2003 12:58:42 -0000 > @@ -1087,7 +1087,11 @@ > @echo "echo Please insert MFS root floppy and press enter:" >> ${RD}/image.${FSIMAGE}/boot/loader.rc > @echo "read" >> ${RD}/image.${FSIMAGE}/boot/loader.rc > .endif > +.if defined(FDSIZE) && ${FDSIZE} == "SMALL" > + @echo "load -t mfs_root /mfsroot-small" >> ${RD}/image.${FSIMAGE}/boot/loader.rc > +.else > @echo "load -t mfs_root /mfsroot" >> ${RD}/image.${FSIMAGE}/boot/loader.rc > +.endif Can we *PLEASE* stop this .ifdef maze? Why not set ${MFSROOT_NAME} much higher up and have a single @echo "load -t mfs_root ${MFSROOT_NAME}" >> ${RD}/image.${FSIMAGE}/boot/loader.rc From owner-cvs-src@FreeBSD.ORG Fri Jul 25 09:49:47 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 48A2937B401; Fri, 25 Jul 2003 09:49:47 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D94AB43FBD; Fri, 25 Jul 2003 09:49:46 -0700 (PDT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PGnk0U043413; Fri, 25 Jul 2003 09:49:46 -0700 (PDT) (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PGnkmQ043412; Fri, 25 Jul 2003 09:49:46 -0700 (PDT) Message-Id: <200307251649.h6PGnkmQ043412@repoman.freebsd.org> From: Nate Lawson Date: Fri, 25 Jul 2003 09:49:46 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/acpica acpi_ec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 16:49:47 -0000 njl 2003/07/25 09:49:46 PDT FreeBSD src repository Modified files: sys/dev/acpica acpi_ec.c Log: Add an informational debugging printf of the maximum time spent in EcEventWait(). If you get AE_HARDWARE_NO_RESPONSE errors, please enable this info by setting hw.acpi.verbose=1 in loader.conf. Revision Changes Path 1.37 +10 -0 src/sys/dev/acpica/acpi_ec.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 10:02:35 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BCFD37B401; Fri, 25 Jul 2003 10:02:35 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8808D43FA3; Fri, 25 Jul 2003 10:02:34 -0700 (PDT) (envelope-from mp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PH2Y0U044018; Fri, 25 Jul 2003 10:02:34 -0700 (PDT) (envelope-from mp@repoman.freebsd.org) Received: (from mp@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PH2Y81044017; Fri, 25 Jul 2003 10:02:34 -0700 (PDT) Message-Id: <200307251702.h6PH2Y81044017@repoman.freebsd.org> From: Mark Peek Date: Fri, 25 Jul 2003 10:02:34 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc_r/uthread Makefile.inc uthread_kqueue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 17:02:36 -0000 mp 2003/07/25 10:02:34 PDT FreeBSD src repository Modified files: lib/libc_r/uthread Makefile.inc Added files: lib/libc_r/uthread uthread_kqueue.c Log: Add wrapper for kqueue() to keep track of the allocated fd and allow it to be closed. This fixes a file descriptor leak when closing a kqueue() fd. Reviewed by: deischen MFC after: 1 week Revision Changes Path 1.37 +1 -0 src/lib/libc_r/uthread/Makefile.inc 1.1 +53 -0 src/lib/libc_r/uthread/uthread_kqueue.c (new) From owner-cvs-src@FreeBSD.ORG Fri Jul 25 10:11:16 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C4C7437B401; Fri, 25 Jul 2003 10:11:16 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61F5143F75; Fri, 25 Jul 2003 10:11:16 -0700 (PDT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PHBG0U045295; Fri, 25 Jul 2003 10:11:16 -0700 (PDT) (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PHBGw2045294; Fri, 25 Jul 2003 10:11:16 -0700 (PDT) Message-Id: <200307251711.h6PHBGw2045294@repoman.freebsd.org> From: Nate Lawson Date: Fri, 25 Jul 2003 10:11:16 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/zzz zzz.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 17:11:17 -0000 njl 2003/07/25 10:11:16 PDT FreeBSD src repository Modified files: usr.sbin/zzz zzz.sh Log: Fix output from an error message. Use sysctl -n instead of sed Submitted by: Scott Lambert Revision Changes Path 1.2 +5 -5 src/usr.sbin/zzz/zzz.sh From owner-cvs-src@FreeBSD.ORG Fri Jul 25 10:32:46 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC00837B401; Fri, 25 Jul 2003 10:32:46 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B6FC44032; Fri, 25 Jul 2003 10:32:43 -0700 (PDT) (envelope-from schweikh@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PHWh0U046306; Fri, 25 Jul 2003 10:32:43 -0700 (PDT) (envelope-from schweikh@repoman.freebsd.org) Received: (from schweikh@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PHWhTT046305; Fri, 25 Jul 2003 10:32:43 -0700 (PDT) Message-Id: <200307251732.h6PHWhTT046305@repoman.freebsd.org> From: Jens Schweikhardt Date: Fri, 25 Jul 2003 10:32:43 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/find find.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 17:32:47 -0000 schweikh 2003/07/25 10:32:43 PDT FreeBSD src repository Modified files: usr.bin/find find.1 Log: State that in -exec ... ; the semicolon should be quoted if invoked from a shell. PR: docs/54667 Submitted by: Patrick Alken MFC after: 3 days Revision Changes Path 1.55 +4 -0 src/usr.bin/find/find.1 From owner-cvs-src@FreeBSD.ORG Fri Jul 25 11:22:54 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA5AF37B401; Fri, 25 Jul 2003 11:22:54 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1601743F3F; Fri, 25 Jul 2003 11:22:54 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PIMr0U049208; Fri, 25 Jul 2003 11:22:53 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PIMrNm049207; Fri, 25 Jul 2003 11:22:53 -0700 (PDT) Message-Id: <200307251822.h6PIMrNm049207@repoman.freebsd.org> From: Peter Wemm Date: Fri, 25 Jul 2003 11:22:53 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 18:22:55 -0000 peter 2003/07/25 11:22:53 PDT FreeBSD src repository Modified files: usr.sbin Makefile Log: Fix amd64 build by deleting trailing whitespace. Doh! Revision Changes Path 1.266 +1 -1 src/usr.sbin/Makefile From owner-cvs-src@FreeBSD.ORG Fri Jul 25 11:40:37 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4034B37B401; Fri, 25 Jul 2003 11:40:37 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFDBF43F75; Fri, 25 Jul 2003 11:40:36 -0700 (PDT) (envelope-from gad@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PIea0U049888; Fri, 25 Jul 2003 11:40:36 -0700 (PDT) (envelope-from gad@repoman.freebsd.org) Received: (from gad@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PIea2N049887; Fri, 25 Jul 2003 11:40:36 -0700 (PDT) Message-Id: <200307251840.h6PIea2N049887@repoman.freebsd.org> From: Garance A Drosehn Date: Fri, 25 Jul 2003 11:40:36 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys cdefs.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 18:40:37 -0000 gad 2003/07/25 11:40:36 PDT FreeBSD src repository Modified files: sys/sys cdefs.h Log: Discussions on src-committers with alfred and bde pointed out that the "do-nothing" versions of __RCSID(), __RCSID_SOURCE(), __SCCSID(), and __COPYRIGHT() were not strictly correct. They should not expand into [nothing], because the ';' which follows them would then cause a syntax error (in a strict C compiler, if not gcc...). So, change the do-nothing versions of those macros to use the 'struct __hack' tactic, as was already used with __FBSDID(). Approved by: discussions with bde MFC after: 1 week Revision Changes Path 1.75 +8 -6 src/sys/sys/cdefs.h From owner-cvs-src@FreeBSD.ORG Fri Jul 25 11:58:40 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD4E737B401; Fri, 25 Jul 2003 11:58:40 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4A07D43F85; Fri, 25 Jul 2003 11:58:40 -0700 (PDT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PIwe0U050580; Fri, 25 Jul 2003 11:58:40 -0700 (PDT) (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PIwdid050579; Fri, 25 Jul 2003 11:58:39 -0700 (PDT) Message-Id: <200307251858.h6PIwdid050579@repoman.freebsd.org> From: Alan Cox Date: Fri, 25 Jul 2003 11:58:39 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha pmap.c src/sys/amd64/amd64 pmap.c src/sys/ia64/ia64 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 18:58:41 -0000 alc 2003/07/25 11:58:39 PDT FreeBSD src repository Modified files: sys/alpha/alpha pmap.c sys/amd64/amd64 pmap.c sys/ia64/ia64 pmap.c Log: MFi386 revision 1.416 Add vm object locking to pmap_prefault(). Note: powerpc and sparc64 do not implement this function. Revision Changes Path 1.131 +10 -7 src/sys/alpha/alpha/pmap.c 1.425 +10 -7 src/sys/amd64/amd64/pmap.c 1.115 +10 -7 src/sys/ia64/ia64/pmap.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 12:17:47 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C19037B401; Fri, 25 Jul 2003 12:17:47 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2850F43FA3; Fri, 25 Jul 2003 12:17:47 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PJHk0U052208; Fri, 25 Jul 2003 12:17:47 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PJHk1C052207; Fri, 25 Jul 2003 12:17:46 -0700 (PDT) Message-Id: <200307251917.h6PJHk1C052207@repoman.freebsd.org> From: Peter Wemm Date: Fri, 25 Jul 2003 12:17:46 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libncp ncpl_conn.c ncpl_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 19:17:48 -0000 peter 2003/07/25 12:17:46 PDT FreeBSD src repository Modified files: lib/libncp ncpl_conn.c ncpl_subr.c Log: Fix for 64 bit platforms. sysctl's length args are pointers to size_t, not int. This could be fatal where size_t is long. Reviewed by: bp Revision Changes Path 1.8 +4 -2 src/lib/libncp/ncpl_conn.c 1.9 +2 -1 src/lib/libncp/ncpl_subr.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 12:42:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 036FF37B401; Fri, 25 Jul 2003 12:42:45 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 932F843FA3; Fri, 25 Jul 2003 12:42:44 -0700 (PDT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PJgi0U053074; Fri, 25 Jul 2003 12:42:44 -0700 (PDT) (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PJgixb053073; Fri, 25 Jul 2003 12:42:44 -0700 (PDT) Message-Id: <200307251942.h6PJgixb053073@repoman.freebsd.org> From: Bill Paul Date: Fri, 25 Jul 2003 12:42:44 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 19:42:45 -0000 wpaul 2003/07/25 12:42:44 PDT FreeBSD src repository Modified files: sys/dev/bge if_bge.c if_bgereg.h Log: Convert bge(4) to use busdma. I have not tested this on anything besides x86 yet since I don't have access to a non-x86 FreeBSD box at the moment. Volunteers welcome. Revision Changes Path 1.45 +798 -122 src/sys/dev/bge/if_bge.c 1.19 +63 -10 src/sys/dev/bge/if_bgereg.h From owner-cvs-src@FreeBSD.ORG Fri Jul 25 13:33:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 072C037B401; Fri, 25 Jul 2003 13:33:45 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 97ABC43FD7; Fri, 25 Jul 2003 13:33:44 -0700 (PDT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PKXi0U061301; Fri, 25 Jul 2003 13:33:44 -0700 (PDT) (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PKXi4B061300; Fri, 25 Jul 2003 13:33:44 -0700 (PDT) Message-Id: <200307252033.h6PKXi4B061300@repoman.freebsd.org> From: Bill Paul Date: Fri, 25 Jul 2003 13:33:44 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 20:33:45 -0000 wpaul 2003/07/25 13:33:44 PDT FreeBSD src repository Modified files: sys/dev/bge if_bge.c if_bgereg.h Log: Remove alpha vtophys() hack from if_bgereg.h and clean up unneeded #includes formerly required to pull in vtophys support, since we don't need them anymore. Revision Changes Path 1.46 +0 -2 src/sys/dev/bge/if_bge.c 1.20 +0 -5 src/sys/dev/bge/if_bgereg.h From owner-cvs-src@FreeBSD.ORG Fri Jul 25 13:53:05 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9680837B401; Fri, 25 Jul 2003 13:53:05 -0700 (PDT) Received: from cirb503493.alcatel.com.au (c211-28-27-130.belrs2.nsw.optusnet.com.au [211.28.27.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B20743F85; Fri, 25 Jul 2003 13:53:03 -0700 (PDT) (envelope-from PeterJeremy@optushome.com.au) Received: from cirb503493.alcatel.com.au (localhost.alcatel.com.au [127.0.0.1])h6PKr0gh035279; Sat, 26 Jul 2003 06:53:00 +1000 (EST) (envelope-from jeremyp@cirb503493.alcatel.com.au) Received: (from jeremyp@localhost) by cirb503493.alcatel.com.au (8.12.8/8.12.8/Submit) id h6PKqqvA035278; Sat, 26 Jul 2003 06:52:52 +1000 (EST) Date: Sat, 26 Jul 2003 06:52:52 +1000 From: Peter Jeremy To: Wes Peters Message-ID: <20030725205252.GA9176@cirb503493.alcatel.com.au> References: <16642.1058917403@critter.freebsd.dk> <200307231710.46896.wes@softweyr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307231710.46896.wes@softweyr.com> User-Agent: Mutt/1.4.1i cc: cvs-src@freebsd.org cc: Poul-Henning Kamp cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 20:53:06 -0000 On Wed, Jul 23, 2003 at 05:10:46PM -0700, Wes Peters wrote: >As a general note, I think it is quite hard to predict how any such >"optimization" is going to behave across even the common x86 family >processors. We've seen many times that optimizing for p4 is not the >same as optimizing for Athlon, etc. These days, benchmark results on a >single architecture are arguably no more valid than no benchmark >results at all. > >That said, "my athlon is your athlon" (XP 2000+, will be running >-current after this weekend) for anyone who needs one for testing. >Not a speed daemon by todays standards, but it was yesterday... Actually, I'd go so far as to suggest that you couldn't safely extrapolate from your XP 2000+ to an XP 3200+ and even less an MP 2800+. As the CPU multipliers increase, accessing main memory becomes the dominant performance factor - and SMP systems just make that worse by increasing the memory bus load. "Code size" and "instructions executed" become less relevant than "amount of code transferred to cache" and "cache misses" - and the latter is probably predominantly mis-predicted branches and data accesses. Peter From owner-cvs-src@FreeBSD.ORG Fri Jul 25 13:56:58 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 00C5537B40B; Fri, 25 Jul 2003 13:56:57 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B25043F75; Fri, 25 Jul 2003 13:56:57 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PKuv0U062248; Fri, 25 Jul 2003 13:56:57 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PKuv0Q062247; Fri, 25 Jul 2003 13:56:57 -0700 (PDT) Message-Id: <200307252056.h6PKuv0Q062247@repoman.freebsd.org> From: Peter Wemm Date: Fri, 25 Jul 2003 13:56:57 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/mount_nwfs mount_nwfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 20:56:59 -0000 peter 2003/07/25 13:56:57 PDT FreeBSD src repository Modified files: usr.sbin/mount_nwfs mount_nwfs.c Log: Make this 64 bit clean. Use size_t for sysctl() length pointer args. Revision Changes Path 1.8 +2 -1 src/usr.sbin/mount_nwfs/mount_nwfs.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 14:02:29 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F08437B404; Fri, 25 Jul 2003 14:02:29 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 925DC43F93; Fri, 25 Jul 2003 14:02:25 -0700 (PDT) (envelope-from mux@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PL2P0U063698; Fri, 25 Jul 2003 14:02:25 -0700 (PDT) (envelope-from mux@repoman.freebsd.org) Received: (from mux@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PL2PFL063697; Fri, 25 Jul 2003 14:02:25 -0700 (PDT) Message-Id: <200307252102.h6PL2PFL063697@repoman.freebsd.org> From: Maxime Henrion Date: Fri, 25 Jul 2003 14:02:25 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_contig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 21:02:29 -0000 mux 2003/07/25 14:02:25 PDT FreeBSD src repository Modified files: sys/vm vm_contig.c Log: Add support for the M_ZERO flag to contigmalloc(). Reviewed by: jeff Revision Changes Path 1.21 +5 -1 src/sys/vm/vm_contig.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 14:10:19 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E8D9237B401; Fri, 25 Jul 2003 14:10:19 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 814BB43FA3; Fri, 25 Jul 2003 14:10:19 -0700 (PDT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PLAJ0U065063; Fri, 25 Jul 2003 14:10:19 -0700 (PDT) (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PLAJtL065061; Fri, 25 Jul 2003 14:10:19 -0700 (PDT) Message-Id: <200307252110.h6PLAJtL065061@repoman.freebsd.org> From: "David E. O'Brien" Date: Fri, 25 Jul 2003 14:10:19 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/acpica OsdEnvironment.c acpi_machdep.c acpi_wakeup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 21:10:20 -0000 obrien 2003/07/25 14:10:19 PDT FreeBSD src repository Modified files: sys/amd64/acpica OsdEnvironment.c acpi_machdep.c acpi_wakeup.c Log: Use __FBSDID(). Brought to you by: a boring talk at OLS Revision Changes Path 1.10 +3 -2 src/sys/amd64/acpica/OsdEnvironment.c 1.10 +3 -2 src/sys/amd64/acpica/acpi_machdep.c 1.20 +4 -2 src/sys/amd64/acpica/acpi_wakeup.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 14:11:31 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10B5F37B405 for ; Fri, 25 Jul 2003 14:11:31 -0700 (PDT) Received: from mail26a.sbc-webhosting.com (mail26a.sbc-webhosting.com [216.173.237.164]) by mx1.FreeBSD.org (Postfix) with SMTP id 3011F43FBD for ; Fri, 25 Jul 2003 14:11:29 -0700 (PDT) (envelope-from alc@imimic.com) Received: from www.imimic.com (64.143.12.21)0-0961157485; Fri, 25 Jul 2003 17:11:26 -0400 (EDT) Sender: alc@FreeBSD.ORG Message-ID: <3F219CFF.ECFF953D@imimic.com> Date: Fri, 25 Jul 2003 16:11:27 -0500 From: "Alan L. Cox" Organization: iMimic Networking, Inc. X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386) X-Accept-Language: en MIME-Version: 1.0 To: Maxime Henrion References: <200307252102.h6PL2PFL063697@repoman.freebsd.org> Content-Type: text/plain; charset=x-user-defined Content-Transfer-Encoding: 7bit X-Loop-Detect: 1 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_contig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 21:11:31 -0000 Maxime Henrion wrote: > > mux 2003/07/25 14:02:25 PDT > > FreeBSD src repository > > Modified files: > sys/vm vm_contig.c > Log: > Add support for the M_ZERO flag to contigmalloc(). > > Reviewed by: jeff > > Revision Changes Path > 1.21 +5 -1 src/sys/vm/vm_contig.c This has a bug. The page is not mapped at the time you perform bzero(). (In fact, it is not mapped until after the vm_map_wire() occurs.) Thus, you need to use pmap_zero_page() instead. Your tests probably succeeded because of page prezeroing. (With prezeroing, you never exercised the bug.) I'm pretty sure that I sent you an e-mail about this. If not, I apologize. Regards, Alan From owner-cvs-src@FreeBSD.ORG Fri Jul 25 14:15:46 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C905937B401; Fri, 25 Jul 2003 14:15:46 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F44A43FBF; Fri, 25 Jul 2003 14:15:46 -0700 (PDT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PLFk0U065478; Fri, 25 Jul 2003 14:15:46 -0700 (PDT) (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PLFj4p065477; Fri, 25 Jul 2003 14:15:45 -0700 (PDT) Message-Id: <200307252115.h6PLFj4p065477@repoman.freebsd.org> From: "David E. O'Brien" Date: Fri, 25 Jul 2003 14:15:45 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 amd64-gdbstub.c atomic.c autoconf.c critical.c db_disasm.c db_interface.c db_trace.c dump_machdep.c elf_machdep.c genassym.c identcpu.c in_cksum.c... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 21:15:47 -0000 obrien 2003/07/25 14:15:45 PDT FreeBSD src repository Modified files: sys/amd64/amd64 amd64-gdbstub.c atomic.c autoconf.c critical.c db_disasm.c db_interface.c db_trace.c dump_machdep.c elf_machdep.c genassym.c identcpu.c in_cksum.c initcpu.c legacy.c machdep.c mem.c nexus.c pmap.c sys_machdep.c trap.c tsc.c vm_machdep.c Log: Use __FBSDID(). Brought to you by: a boring talk at Ottawa Linux Symposium Revision Changes Path 1.25 +2 -1 src/sys/amd64/amd64/amd64-gdbstub.c 1.5 +3 -2 src/sys/amd64/amd64/atomic.c 1.174 +4 -2 src/sys/amd64/amd64/autoconf.c 1.10 +3 -2 src/sys/amd64/amd64/critical.c 1.27 +3 -2 src/sys/amd64/amd64/db_disasm.c 1.74 +3 -2 src/sys/amd64/amd64/db_interface.c 1.58 +3 -2 src/sys/amd64/amd64/db_trace.c 1.9 +3 -2 src/sys/amd64/amd64/dump_machdep.c 1.16 +3 -2 src/sys/amd64/amd64/elf_machdep.c 1.148 +4 -2 src/sys/amd64/amd64/genassym.c 1.126 +3 -1 src/sys/amd64/amd64/identcpu.c 1.4 +1 -1 src/sys/amd64/amd64/in_cksum.c 1.46 +3 -2 src/sys/amd64/amd64/initcpu.c 1.51 +3 -2 src/sys/amd64/amd64/legacy.c 1.587 +4 -2 src/sys/amd64/amd64/machdep.c 1.110 +5 -3 src/sys/amd64/amd64/mem.c 1.54 +3 -2 src/sys/amd64/amd64/nexus.c 1.426 +4 -2 src/sys/amd64/amd64/pmap.c 1.85 +4 -3 src/sys/amd64/amd64/sys_machdep.c 1.262 +4 -2 src/sys/amd64/amd64/trap.c 1.201 +3 -2 src/sys/amd64/amd64/tsc.c 1.214 +4 -2 src/sys/amd64/amd64/vm_machdep.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 14:16:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4AC337B401; Fri, 25 Jul 2003 14:16:27 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A4AC43FB1; Fri, 25 Jul 2003 14:16:27 -0700 (PDT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PLGQ0U065537; Fri, 25 Jul 2003 14:16:26 -0700 (PDT) (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PLGQb1065536; Fri, 25 Jul 2003 14:16:26 -0700 (PDT) Message-Id: <200307252116.h6PLGQb1065536@repoman.freebsd.org> From: "David E. O'Brien" Date: Fri, 25 Jul 2003 14:16:26 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/ia32 ia32_genassym.c ia32_misc.c ia32_signal.c ia32_syscall.c ia32_sysvec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 21:16:28 -0000 obrien 2003/07/25 14:16:26 PDT FreeBSD src repository Modified files: sys/amd64/ia32 ia32_genassym.c ia32_misc.c ia32_signal.c ia32_syscall.c ia32_sysvec.c Log: Use __FBSDID(). Brought to you by: a boring talk at Ottawa Linux Symposium Revision Changes Path 1.2 +2 -1 src/sys/amd64/ia32/ia32_genassym.c 1.11 +3 -2 src/sys/amd64/ia32/ia32_misc.c 1.3 +3 -2 src/sys/amd64/ia32/ia32_signal.c 1.3 +3 -2 src/sys/amd64/ia32/ia32_syscall.c 1.6 +3 -2 src/sys/amd64/ia32/ia32_sysvec.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 14:18:40 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 937ED37B401; Fri, 25 Jul 2003 14:18:40 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A8BB43F93; Fri, 25 Jul 2003 14:18:32 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6PLIS0U035473 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 26 Jul 2003 00:18:28 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6PLIOE2035466; Sat, 26 Jul 2003 00:18:24 +0300 (EEST) (envelope-from ru) Date: Sat, 26 Jul 2003 00:18:24 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20030725211823.GD34677@sunbay.com> References: <200307250854.h6P8sfom098536@repoman.freebsd.org> <20030725.213123.74673434.nyan@jp.FreeBSD.org> <20030725162711.GB37608@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Xm/fll+QQv+hsKip" Content-Disposition: inline In-Reply-To: <20030725162711.GB37608@dragon.nuxi.com> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Takahashi Yoshihiro cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile src/share/man/man7 release.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 21:18:41 -0000 --Xm/fll+QQv+hsKip Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 25, 2003 at 09:27:11AM -0700, David O'Brien wrote: > On Fri, Jul 25, 2003 at 09:31:23PM +0900, Takahashi Yoshihiro wrote: > > In article <200307250854.h6P8sfom098536@repoman.freebsd.org> > > Ruslan Ermilov writes: > > + @sh -e ${DOFS_SH} ${RD}/floppies/mfsroot-small.flp \ > > + ${RD} ${MNT} ${SMALLBOOTSIZE} ${RD}/mfsroot/mfsroot-small.gz \ > > + ${BOOTINODE} ${SMALLBOOTLABEL} > >=20 > > This change breaks small floppy image support. >=20 > What is the "small floppy" image for now days? >=20 1.2MB floppy. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --Xm/fll+QQv+hsKip Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/IZ6fUkv4P6juNwoRAoYYAJ9tlln4Y3cA7nwt7XMu9pq5cmROdgCdEVSS ewLlrRS/WU4zBhrgNCEIoBg= =RKAn -----END PGP SIGNATURE----- --Xm/fll+QQv+hsKip-- From owner-cvs-src@FreeBSD.ORG Fri Jul 25 14:18:53 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5460537B401; Fri, 25 Jul 2003 14:18:53 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD3DF43F3F; Fri, 25 Jul 2003 14:18:52 -0700 (PDT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PLIq0U065616; Fri, 25 Jul 2003 14:18:52 -0700 (PDT) (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PLIq35065615; Fri, 25 Jul 2003 14:18:52 -0700 (PDT) Message-Id: <200307252118.h6PLIq35065615@repoman.freebsd.org> From: "David E. O'Brien" Date: Fri, 25 Jul 2003 14:18:52 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/isa clock.c intr_machdep.c isa.c isa_dma.c ithread.c npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 21:18:53 -0000 obrien 2003/07/25 14:18:52 PDT FreeBSD src repository Modified files: sys/amd64/isa clock.c intr_machdep.c isa.c isa_dma.c ithread.c npx.c Log: Use __FBSDID(). Brought to you by: a boring talk at Ottawa Linux Symposium Revision Changes Path 1.200 +4 -2 src/sys/amd64/isa/clock.c 1.76 +4 -2 src/sys/amd64/isa/intr_machdep.c 1.144 +3 -3 src/sys/amd64/isa/isa.c 1.15 +4 -2 src/sys/amd64/isa/isa_dma.c 1.22 +4 -2 src/sys/amd64/isa/ithread.c 1.142 +4 -2 src/sys/amd64/isa/npx.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 14:19:12 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A340737B405; Fri, 25 Jul 2003 14:19:12 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 890BC43F75; Fri, 25 Jul 2003 14:19:08 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6PLJ20U035530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 26 Jul 2003 00:19:02 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6PLJ2gx035525; Sat, 26 Jul 2003 00:19:02 +0300 (EEST) (envelope-from ru) Date: Sat, 26 Jul 2003 00:19:02 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20030725211902.GE34677@sunbay.com> References: <200307250854.h6P8sfom098536@repoman.freebsd.org> <20030725.213123.74673434.nyan@jp.FreeBSD.org> <20030725130041.GA84040@sunbay.com> <20030725162952.GC37608@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mR8QP4gmHujQHb1c" Content-Disposition: inline In-Reply-To: <20030725162952.GC37608@dragon.nuxi.com> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Takahashi Yoshihiro cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile src/share/man/man7 release.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 21:19:13 -0000 --mR8QP4gmHujQHb1c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 25, 2003 at 09:29:52AM -0700, David O'Brien wrote: > On Fri, Jul 25, 2003 at 04:00:41PM +0300, Ruslan Ermilov wrote: > > Index: Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > RCS file: /home/ncvs/src/release/Makefile,v > > retrieving revision 1.798 > > diff -u -r1.798 Makefile > > --- Makefile 25 Jul 2003 08:55:51 -0000 1.798 > > +++ Makefile 25 Jul 2003 12:58:42 -0000 > > @@ -1087,7 +1087,11 @@ > > @echo "echo Please insert MFS root floppy and press enter:" >> ${RD}/= image.${FSIMAGE}/boot/loader.rc > > @echo "read" >> ${RD}/image.${FSIMAGE}/boot/loader.rc > > .endif > > +.if defined(FDSIZE) && ${FDSIZE} =3D=3D "SMALL" > > + @echo "load -t mfs_root /mfsroot-small" >> ${RD}/image.${FSIMAGE}/boo= t/loader.rc > > +.else > > @echo "load -t mfs_root /mfsroot" >> ${RD}/image.${FSIMAGE}/boot/load= er.rc > > +.endif >=20 > Can we *PLEASE* stop this .ifdef maze? Why not set ${MFSROOT_NAME} much > higher up and have a single > @echo "load -t mfs_root ${MFSROOT_NAME}" >> ${RD}/image.${FSIMAGE}/bo= ot/loader.rc >=20 Feel free to. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --mR8QP4gmHujQHb1c Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/IZ7GUkv4P6juNwoRAmdQAJ9ACCOSwVacba2QUXXB83dMhiF+YwCeNgOu W1/Gl6t/oULT3J1v4z1PoWo= =rjBe -----END PGP SIGNATURE----- --mR8QP4gmHujQHb1c-- From owner-cvs-src@FreeBSD.ORG Fri Jul 25 14:19:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 65B7D37B4D2; Fri, 25 Jul 2003 14:19:19 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 71DD043FAF; Fri, 25 Jul 2003 14:19:19 -0700 (PDT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PLJJ0U065685; Fri, 25 Jul 2003 14:19:19 -0700 (PDT) (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PLJJHQ065684; Fri, 25 Jul 2003 14:19:19 -0700 (PDT) Message-Id: <200307252119.h6PLJJHQ065684@repoman.freebsd.org> From: "David E. O'Brien" Date: Fri, 25 Jul 2003 14:19:19 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/pci pci_bus.c pci_cfgreg.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 21:19:25 -0000 obrien 2003/07/25 14:19:19 PDT FreeBSD src repository Modified files: sys/amd64/pci pci_bus.c pci_cfgreg.c Log: Use __FBSDID(). Brought to you by: a boring talk at Ottawa Linux Symposium Revision Changes Path 1.100 +3 -3 src/sys/amd64/pci/pci_bus.c 1.103 +3 -3 src/sys/amd64/pci/pci_cfgreg.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 14:21:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C9EA337B422; Fri, 25 Jul 2003 14:21:45 -0700 (PDT) Received: from cirb503493.alcatel.com.au (c211-28-27-130.belrs2.nsw.optusnet.com.au [211.28.27.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2094343FA3; Fri, 25 Jul 2003 14:21:44 -0700 (PDT) (envelope-from PeterJeremy@optushome.com.au) Received: from cirb503493.alcatel.com.au (localhost.alcatel.com.au [127.0.0.1])h6PLLggh035317; Sat, 26 Jul 2003 07:21:42 +1000 (EST) (envelope-from jeremyp@cirb503493.alcatel.com.au) Received: (from jeremyp@localhost) by cirb503493.alcatel.com.au (8.12.8/8.12.8/Submit) id h6PLLgfe035316; Sat, 26 Jul 2003 07:21:42 +1000 (EST) Date: Sat, 26 Jul 2003 07:21:42 +1000 From: Peter Jeremy To: Poul-Henning Kamp Message-ID: <20030725212142.GB9176@cirb503493.alcatel.com.au> References: <20030722231656.GA9715@HAL9000.homeunix.com> <16474.1058916504@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16474.1058916504@critter.freebsd.dk> User-Agent: Mutt/1.4.1i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 21:21:46 -0000 On Wed, Jul 23, 2003 at 01:28:24AM +0200, Poul-Henning Kamp wrote: >Please remember that the problem at hand is getting -Werror back >on the kernel so we can catch issues like the warning in umtx. Why is -Werror such a holy grail? The warnings are still there - developers should be able to use script(1) or output redirection and grep(1) to find them. Not having -Werror has the benefit that you get to see all the warnings and make doesn't just die at the first error. I agree that warnings should be minimised so you can easily see new warnings but in some cases, compiler warnings are wrong or require code obfuscation to quieten. At least in the past, gcc could not do sufficient data-flow analysis to correctly determine uninitialised variables when the variable in question was only used within conditionally executed code - and it erred on the side of caution. Removing this warning means adding an unnecessary initialisation - increasing code size and reducing performance (admittedly trivially). Likewise, is "(type *)(intptr_t)foo" any clearer than "(type *)foo" to remove "const" or "volatile". It definitely increases the "code complexity" (as per McCabe or similar). >My experiments have shown that if we had just raised the limit high >enough to inline everything that we have marked as inline, the >GENERIC kernel text segment would have grown by more than 100 k. > >The inlines I have removed today have all been inlines which GCC >has previously ignored and which added significant code segment >size, typically 2k+. > >You can see some of my raw data here: http://phk/misc/inline.txt These all discuss static code size. Aside from the regular "what can we remove from the kernel so it fits on the boot-floppy again" threads, static code size is irrelevant. The critical issue is kernel performance - which on high-end processors is more dependent on how much code gets moved from RAM into cache and secondarily on the amount of code executed. "More code" does not translate to "more code executed" - quite a number of optimisation techniques demonstrate the opposite. The objective is to minimise the length of the most common code paths and either eliminate branches or ensure that the CPU predicts them correctly - if this means that a rarely executed code path bloats, this is still a win. Peter From owner-cvs-src@FreeBSD.ORG Fri Jul 25 14:30:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF73B37B401; Fri, 25 Jul 2003 14:30:18 -0700 (PDT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 32B1343F93; Fri, 25 Jul 2003 14:30:16 -0700 (PDT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 282672ED44B; Fri, 25 Jul 2003 14:30:16 -0700 (PDT) Date: Fri, 25 Jul 2003 14:30:16 -0700 From: Alfred Perlstein To: Peter Jeremy Message-ID: <20030725213016.GZ42924@elvis.mu.org> References: <20030722231656.GA9715@HAL9000.homeunix.com> <16474.1058916504@critter.freebsd.dk> <20030725212142.GB9176@cirb503493.alcatel.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030725212142.GB9176@cirb503493.alcatel.com.au> User-Agent: Mutt/1.4.1i cc: cvs-src@freebsd.org cc: Poul-Henning Kamp cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 21:30:19 -0000 * Peter Jeremy [030725 14:21] wrote: > On Wed, Jul 23, 2003 at 01:28:24AM +0200, Poul-Henning Kamp wrote: > >Please remember that the problem at hand is getting -Werror back > >on the kernel so we can catch issues like the warning in umtx. > > Why is -Werror such a holy grail? The warnings are still there - > developers should be able to use script(1) or output redirection and > grep(1) to find them. Not having -Werror has the benefit that you get > to see all the warnings and make doesn't just die at the first error. Not having -Werror is stupid. Please. It wastes so much damn time when you accidentally miss some warning emitted. Your arguement wastes developer time and makes it more irritating to work on a system that should be fun to work on. -Alfred From owner-cvs-src@FreeBSD.ORG Fri Jul 25 14:53:58 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 04B8A37B401; Fri, 25 Jul 2003 14:53:58 -0700 (PDT) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9AA6F43F93; Fri, 25 Jul 2003 14:53:56 -0700 (PDT) (envelope-from wkb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.12.9/8.12.9) with ESMTP id h6PLrtmW000680; Fri, 25 Jul 2003 23:53:55 +0200 (CEST) (envelope-from wkb@freebie.xs4all.nl) Received: (from wkb@localhost) by freebie.xs4all.nl (8.12.9/8.12.9/Submit) id h6PLrtNu000679; Fri, 25 Jul 2003 23:53:55 +0200 (CEST) Date: Fri, 25 Jul 2003 23:53:55 +0200 From: Wilko Bulte To: Ruslan Ermilov Message-ID: <20030725215355.GA658@freebie.xs4all.nl> References: <200307250854.h6P8sfom098536@repoman.freebsd.org> <20030725.213123.74673434.nyan@jp.FreeBSD.org> <20030725162711.GB37608@dragon.nuxi.com> <20030725211823.GD34677@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030725211823.GD34677@sunbay.com> User-Agent: Mutt/1.4i X-OS: FreeBSD 4.8-STABLE X-PGP: finger wilko@freebsd.org cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: Takahashi Yoshihiro cc: cvs-all@FreeBSD.ORG cc: David O'Brien Subject: Re: cvs commit: src/release Makefile src/share/man/man7 release.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 21:53:58 -0000 On Sat, Jul 26, 2003 at 12:18:24AM +0300, Ruslan Ermilov wrote: > On Fri, Jul 25, 2003 at 09:27:11AM -0700, David O'Brien wrote: > > On Fri, Jul 25, 2003 at 09:31:23PM +0900, Takahashi Yoshihiro wrote: > > > In article <200307250854.h6P8sfom098536@repoman.freebsd.org> > > > Ruslan Ermilov writes: > > > + @sh -e ${DOFS_SH} ${RD}/floppies/mfsroot-small.flp \ > > > + ${RD} ${MNT} ${SMALLBOOTSIZE} ${RD}/mfsroot/mfsroot-small.gz \ > > > + ${BOOTINODE} ${SMALLBOOTLABEL} > > > > > > This change breaks small floppy image support. > > > > What is the "small floppy" image for now days? > > > 1.2MB floppy. Wow... want a drive? ;) Seriously: sounds like an axe-candidate to me. Or is this pc98 stuff? -- | / o / /_ _ wilko@FreeBSD.org |/|/ / / /( (_) Bulte From owner-cvs-src@FreeBSD.ORG Fri Jul 25 15:17:29 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B136637B401; Fri, 25 Jul 2003 15:17:29 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4EFCE43F93; Fri, 25 Jul 2003 15:17:29 -0700 (PDT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PMHT0U069106; Fri, 25 Jul 2003 15:17:29 -0700 (PDT) (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PMHTfQ069105; Fri, 25 Jul 2003 15:17:29 -0700 (PDT) Message-Id: <200307252217.h6PMHTfQ069105@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Fri, 25 Jul 2003 15:17:28 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/tinderbox current.rc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 22:17:30 -0000 des 2003/07/25 15:17:28 PDT FreeBSD src repository Modified files: tools/tools/tinderbox current.rc Log: powerpc isn't tinderbox-ready yet. Revision Changes Path 1.3 +1 -1 src/tools/tools/tinderbox/current.rc From owner-cvs-src@FreeBSD.ORG Fri Jul 25 15:26:44 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB83737B401; Fri, 25 Jul 2003 15:26:44 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5979843F93; Fri, 25 Jul 2003 15:26:44 -0700 (PDT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PMQi0U069415; Fri, 25 Jul 2003 15:26:44 -0700 (PDT) (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PMQiJk069414; Fri, 25 Jul 2003 15:26:44 -0700 (PDT) Message-Id: <200307252226.h6PMQiJk069414@repoman.freebsd.org> From: Alan Cox Date: Fri, 25 Jul 2003 15:26:44 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_descrip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 22:26:45 -0000 alc 2003/07/25 15:26:44 PDT FreeBSD src repository Modified files: sys/kern kern_descrip.c Log: revision 1.51 of vm/uma_core.c modified uma_large_malloc() to acquire Giant when needed. Revision Changes Path 1.209 +0 -6 src/sys/kern/kern_descrip.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 15:36:51 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5463E37B436; Fri, 25 Jul 2003 15:36:49 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B1FF43FBD; Fri, 25 Jul 2003 15:36:49 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6PMam0U069924; Fri, 25 Jul 2003 15:36:48 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6PMamJ0069923; Fri, 25 Jul 2003 15:36:48 -0700 (PDT) Message-Id: <200307252236.h6PMamJ0069923@repoman.freebsd.org> From: Marcel Moolenaar Date: Fri, 25 Jul 2003 15:36:48 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ia64/include setjmp.h src/lib/libc/ia64/gen _setjmp.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 22:36:52 -0000 marcel 2003/07/25 15:36:48 PDT FreeBSD src repository Modified files: sys/ia64/include setjmp.h lib/libc/ia64/gen _setjmp.S Log: Revert previous commit. We don't use setjmp()/longjmp() for context switching anymore, so there's no need to save and restore GP. This change breaks threaded applications linked against libc_r. Pull the tier 2 card again: relink. This will link against libthr instead. Revision Changes Path 1.11 +2 -4 src/lib/libc/ia64/gen/_setjmp.S 1.11 +1 -2 src/sys/ia64/include/setjmp.h From owner-cvs-src@FreeBSD.ORG Fri Jul 25 16:24:37 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7173037B401; Fri, 25 Jul 2003 16:24:37 -0700 (PDT) Received: from ns1.sanda.gr.jp (ns1.sanda.gr.jp [219.117.208.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DCFC43F75; Fri, 25 Jul 2003 16:24:35 -0700 (PDT) (envelope-from non@ever.sanda.gr.jp) Received: from oliv.ever.sanda.gr.jp (oliv [10.93.63.4]) by ns1.sanda.gr.jp (8.11.6/3.7W) with ESMTP id h6PNOOh64054; Sat, 26 Jul 2003 08:24:24 +0900 (JST) Received: from localhost (localhost.ever.sanda.gr.jp [127.0.0.1]) by oliv.ever.sanda.gr.jp (8.12.6/8.12.6) with ESMTP id h6PNOMYw015557; Sat, 26 Jul 2003 08:24:23 +0900 (JST) (envelope-from non@ever.sanda.gr.jp) Date: Sat, 26 Jul 2003 08:24:22 +0900 (JST) Message-Id: <20030726.082422.16063984.non@ever.sanda.gr.jp> To: wkb@freebie.xs4all.nl From: non@ever.sanda.gr.jp In-Reply-To: <20030725215355.GA658@freebie.xs4all.nl> References: <20030725162711.GB37608@dragon.nuxi.com> <20030725211823.GD34677@sunbay.com> <20030725215355.GA658@freebie.xs4all.nl> X-Mailer: Mew version 3.2 on Emacs 20.7 / Mule 4.0 (HANANOEN) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: src-committers@FreeBSD.org cc: ru@FreeBSD.org cc: obrien@FreeBSD.org cc: cvs-src@FreeBSD.org cc: nyan@jp.FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile src/share/man/man7 release.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 23:24:37 -0000 From: Wilko Bulte Date: Fri, 25 Jul 2003 23:53:55 +0200 > > > > This change breaks small floppy image support. > > > > > > What is the "small floppy" image for now days? > > > > > 1.2MB floppy. > > Wow... want a drive? I can give you, too. > Seriously: sounds like an axe-candidate to me. > > Or is this pc98 stuff? Yes and no. Older PC-98x1 machines only support 1.2MB floppy drive for booting. Newer machines support 1.4MB to boot. // Noriaki Mitsunaga // From owner-cvs-src@FreeBSD.ORG Fri Jul 25 16:37:56 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 496CC37B401; Fri, 25 Jul 2003 16:37:56 -0700 (PDT) Received: from magic.adaptec.com (magic-mail.adaptec.com [208.236.45.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D83C43F3F; Fri, 25 Jul 2003 16:37:55 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6/8.11.6) with ESMTP id h6PNbso16660; Fri, 25 Jul 2003 16:37:54 -0700 Received: from freebsd.org (hollin.btc.adaptec.com [10.100.253.56]) by redfish.adaptec.com (8.8.8p2+Sun/8.8.8) with ESMTP id QAA19412; Fri, 25 Jul 2003 16:37:53 -0700 (PDT) Message-ID: <3F21BEC4.5090807@freebsd.org> Date: Fri, 25 Jul 2003 17:35:32 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3) Gecko/20030414 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ruslan Ermilov References: <200307250854.h6P8sfom098536@repoman.freebsd.org> <20030725.213123.74673434.nyan@jp.FreeBSD.org> <20030725130041.GA84040@sunbay.com> <20030725162952.GC37608@dragon.nuxi.com> <20030725211902.GE34677@sunbay.com> In-Reply-To: <20030725211902.GE34677@sunbay.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Takahashi Yoshihiro cc: cvs-all@freebsd.org cc: David O'Brien Subject: Re: cvs commit: src/release Makefile src/share/man/man7 release.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2003 23:37:56 -0000 Ruslan Ermilov wrote: > On Fri, Jul 25, 2003 at 09:29:52AM -0700, David O'Brien wrote: > >>On Fri, Jul 25, 2003 at 04:00:41PM +0300, Ruslan Ermilov wrote: >> >>>Index: Makefile >>>=================================================================== >>>RCS file: /home/ncvs/src/release/Makefile,v >>>retrieving revision 1.798 >>>diff -u -r1.798 Makefile >>>--- Makefile 25 Jul 2003 08:55:51 -0000 1.798 >>>+++ Makefile 25 Jul 2003 12:58:42 -0000 >>>@@ -1087,7 +1087,11 @@ >>> @echo "echo Please insert MFS root floppy and press enter:" >> ${RD}/image.${FSIMAGE}/boot/loader.rc >>> @echo "read" >> ${RD}/image.${FSIMAGE}/boot/loader.rc >>> .endif >>>+.if defined(FDSIZE) && ${FDSIZE} == "SMALL" >>>+ @echo "load -t mfs_root /mfsroot-small" >> ${RD}/image.${FSIMAGE}/boot/loader.rc >>>+.else >>> @echo "load -t mfs_root /mfsroot" >> ${RD}/image.${FSIMAGE}/boot/loader.rc >>>+.endif >> >>Can we *PLEASE* stop this .ifdef maze? Why not set ${MFSROOT_NAME} much >>higher up and have a single >> @echo "load -t mfs_root ${MFSROOT_NAME}" >> ${RD}/image.${FSIMAGE}/boot/loader.rc >> > > Feel free to. > > > Cheers, Guys, the release is broken again, after having worked for only about 12 hours. This continued breakage, along with obvious lack of design, thought, and testing is unacceptable. I'm going to start doing summary backouts if it does not get fixed. + [ -d /R/stage/mfsfd ] + set -e + cd /R/stage/mfsfd + cpio+ find -dump . /mnt -print 6153 blocks + df -ki /mnt Filesystem 1K-blocks Used Avail Capacity iused ifree %iused Mounted on /dev/md0c 4175 3147 1028 75% 95 543 15% /mnt + tail+ df -1 -ki /mnt + set /dev/md0c 4175 3147 1028 75% 95 543 15% /mnt + echo *** Filesystem is 4320 K, 1028 left *** Filesystem is 4320 K, 1028 left + echo *** 8000 bytes/inode, 543 left *** 8000 bytes/inode, 543 left + break + umount /mnt + mdconfig -d -u md0 mfsroot: 70.0% rm: mfsroot-small: No such file or directory *** Error code 1 Stop in /usr/src/release. + umount /dev *** Error code 1 From owner-cvs-src@FreeBSD.ORG Fri Jul 25 19:21:50 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD05337B401; Fri, 25 Jul 2003 19:21:50 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 25B0E43FE0; Fri, 25 Jul 2003 19:21:50 -0700 (PDT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q2Ln0U087023; Fri, 25 Jul 2003 19:21:49 -0700 (PDT) (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q2LnJn087022; Fri, 25 Jul 2003 19:21:49 -0700 (PDT) Message-Id: <200307260221.h6Q2LnJn087022@repoman.freebsd.org> From: "Tim J. Robbins" Date: Fri, 25 Jul 2003 19:21:49 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/fs/ntfs ntfs_subr.c ntfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 02:21:51 -0000 tjr 2003/07/25 19:21:49 PDT FreeBSD src repository Modified files: sys/fs/ntfs ntfs_subr.c ntfs_vfsops.c Log: Revise and improve ntfs_subr.c 1.30: read only a single cluster at a time in ntfs_writentvattr_plain and ntfs_readntvattr_plain, and purge the boot block from the buffer cache if isn't exactly one cluster long. These two changes work around the same buffer cache bug that ntfs_subr.c 1.30 tried to, but in a different way. This may decrease throughput by reading smaller amounts of data from the disk at a time, but may increase it by avoiding bogus writes of clean buffers. Problem (re)reported by Karel J. Bosschaart on -current. Revision Changes Path 1.31 +20 -17 src/sys/fs/ntfs/ntfs_subr.c 1.55 +8 -0 src/sys/fs/ntfs/ntfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 19:27:51 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B5A2737B401; Fri, 25 Jul 2003 19:27:51 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5149C43F93; Fri, 25 Jul 2003 19:27:51 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q2Rp0U087227; Fri, 25 Jul 2003 19:27:51 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q2Rp7c087226; Fri, 25 Jul 2003 19:27:51 -0700 (PDT) Message-Id: <200307260227.h6Q2Rp7c087226@repoman.freebsd.org> From: Peter Wemm Date: Fri, 25 Jul 2003 19:27:51 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf kern.pre.mk kmod.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 02:27:52 -0000 peter 2003/07/25 19:27:51 PDT FreeBSD src repository Modified files: sys/conf kern.pre.mk kmod.mk Log: Change the inline limit switch to something that exists in gcc-3.2. Unfortunately, it has different units. Revision Changes Path 1.31 +2 -2 src/sys/conf/kern.pre.mk 1.139 +2 -2 src/sys/conf/kmod.mk From owner-cvs-src@FreeBSD.ORG Fri Jul 25 19:36:51 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD4E537B401; Fri, 25 Jul 2003 19:36:51 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A5A543F75; Fri, 25 Jul 2003 19:36:51 -0700 (PDT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q2ap0U087623; Fri, 25 Jul 2003 19:36:51 -0700 (PDT) (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q2aoSO087622; Fri, 25 Jul 2003 19:36:50 -0700 (PDT) Message-Id: <200307260236.h6Q2aoSO087622@repoman.freebsd.org> From: David Xu Date: Fri, 25 Jul 2003 19:36:50 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/arch/amd64/amd64 context.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 02:36:52 -0000 davidxu 2003/07/25 19:36:50 PDT FreeBSD src repository Modified files: lib/libpthread/arch/amd64/amd64 context.S Log: Fix typo. Revision Changes Path 1.2 +5 -5 src/lib/libpthread/arch/amd64/amd64/context.S From owner-cvs-src@FreeBSD.ORG Fri Jul 25 20:46:40 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F3D337B401; Fri, 25 Jul 2003 20:46:40 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B38B43F75; Fri, 25 Jul 2003 20:46:40 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q3ke0U091121; Fri, 25 Jul 2003 20:46:40 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q3kdMr091120; Fri, 25 Jul 2003 20:46:39 -0700 (PDT) Message-Id: <200307260346.h6Q3kdMr091120@repoman.freebsd.org> From: Peter Wemm Date: Fri, 25 Jul 2003 20:46:39 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 03:46:41 -0000 peter 2003/07/25 20:46:39 PDT FreeBSD src repository Modified files: sys/conf kern.pre.mk Log: Turn -Werror back on again. I've tested with/without invariants/witness/etc on i386, sparc64, amd64 and alpha for GENERIC. Lint probably still needs fixing, as do a couple of other drivers that have broken recently and not been noticed. Revision Changes Path 1.32 +1 -1 src/sys/conf/kern.pre.mk From owner-cvs-src@FreeBSD.ORG Fri Jul 25 20:47:57 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31E1037B401; Fri, 25 Jul 2003 20:47:57 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2F4B43FAF; Fri, 25 Jul 2003 20:47:56 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q3lu0U096512; Fri, 25 Jul 2003 20:47:56 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q3luO3096511; Fri, 25 Jul 2003 20:47:56 -0700 (PDT) Message-Id: <200307260347.h6Q3luO3096511@repoman.freebsd.org> From: Peter Wemm Date: Fri, 25 Jul 2003 20:47:56 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/firewire fwohcireg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 03:47:57 -0000 peter 2003/07/25 20:47:56 PDT FreeBSD src repository Modified files: sys/dev/firewire fwohcireg.h Log: Fix some recently introduced warnings. 'Declaration does not declare anything' etc. Revision Changes Path 1.12 +2 -2 src/sys/dev/firewire/fwohcireg.h From owner-cvs-src@FreeBSD.ORG Fri Jul 25 20:55:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8237A37B401; Fri, 25 Jul 2003 20:55:33 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 221E643FAF; Fri, 25 Jul 2003 20:55:33 -0700 (PDT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q3tW0U096861; Fri, 25 Jul 2003 20:55:32 -0700 (PDT) (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q3tWkN096860; Fri, 25 Jul 2003 20:55:32 -0700 (PDT) Message-Id: <200307260355.h6Q3tWkN096860@repoman.freebsd.org> From: Alan Cox Date: Fri, 25 Jul 2003 20:55:32 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 03:55:33 -0000 alc 2003/07/25 20:55:32 PDT FreeBSD src repository Modified files: sys/vm uma_core.c Log: Gulp ... call kmem_malloc() without Giant. Revision Changes Path 1.62 +1 -7 src/sys/vm/uma_core.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 21:02:23 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C3F237B401; Fri, 25 Jul 2003 21:02:23 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ECDAE43F3F; Fri, 25 Jul 2003 21:02:22 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q42M0U097170; Fri, 25 Jul 2003 21:02:22 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q42M4x097169; Fri, 25 Jul 2003 21:02:22 -0700 (PDT) Message-Id: <200307260402.h6Q42M4x097169@repoman.freebsd.org> From: Peter Wemm Date: Fri, 25 Jul 2003 21:02:22 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/smbfs/lib/smb rap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 04:02:23 -0000 peter 2003/07/25 21:02:22 PDT FreeBSD src repository Modified files: contrib/smbfs/lib/smb rap.c Log: Use #include rather than so that the strdup() prototype gets brought into scope. This is a big deal for 64 bit systems where the default return value of 'int' is != pointer. Reviewed by: bp Revision Changes Path 1.2 +2 -1 src/contrib/smbfs/lib/smb/rap.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 21:03:19 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B1FD737B401; Fri, 25 Jul 2003 21:03:19 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 443A943F3F; Fri, 25 Jul 2003 21:03:19 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q43J0U098114; Fri, 25 Jul 2003 21:03:19 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q43IvU098113; Fri, 25 Jul 2003 21:03:18 -0700 (PDT) Message-Id: <200307260403.h6Q43IvU098113@repoman.freebsd.org> From: Peter Wemm Date: Fri, 25 Jul 2003 21:03:18 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/smbfs/lib/smb kiconv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 04:03:20 -0000 peter 2003/07/25 21:03:18 PDT FreeBSD src repository Modified files: contrib/smbfs/lib/smb kiconv.c Log: Fixes for 64 bit cleanliness. The length arg to sysctl is a pointer to size_t not int. Reviewed by: bp Revision Changes Path 1.2 +17 -2 src/contrib/smbfs/lib/smb/kiconv.c From owner-cvs-src@FreeBSD.ORG Fri Jul 25 21:46:01 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D491037B407 for ; Fri, 25 Jul 2003 21:46:01 -0700 (PDT) Received: from smtp.mho.com (smtp.mho.net [64.58.4.6]) by mx1.FreeBSD.org (Postfix) with SMTP id 8D6B543F3F for ; Fri, 25 Jul 2003 21:45:59 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: (qmail 32474 invoked by uid 1002); 26 Jul 2003 04:45:58 -0000 Received: from adsl-64-58-12-196.mho.net (HELO freebsd.org) (64.58.12.196) by smtp.mho.net with SMTP; 26 Jul 2003 04:45:58 -0000 Message-ID: <3F220790.8010209@freebsd.org> Date: Fri, 25 Jul 2003 22:46:08 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Alan Cox References: <200307260355.h6Q3tWkN096860@repoman.freebsd.org> In-Reply-To: <200307260355.h6Q3tWkN096860@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 04:46:02 -0000 Alan Cox wrote: > alc 2003/07/25 20:55:32 PDT > > FreeBSD src repository > > Modified files: > sys/vm uma_core.c > Log: > Gulp ... call kmem_malloc() without Giant. > > Revision Changes Path > 1.62 +1 -7 src/sys/vm/uma_core.c > Wooo! From owner-cvs-src@FreeBSD.ORG Fri Jul 25 22:10:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C1A5237B401; Fri, 25 Jul 2003 22:10:02 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4EFAE43F85; Fri, 25 Jul 2003 22:10:02 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 37B3C2A7EA; Fri, 25 Jul 2003 22:10:02 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Alan Cox In-Reply-To: <200307260355.h6Q3tWkN096860@repoman.freebsd.org> Date: Fri, 25 Jul 2003 22:10:02 -0700 From: Peter Wemm Message-Id: <20030726051002.37B3C2A7EA@canning.wemm.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 05:10:03 -0000 Alan Cox wrote: > Modified files: > sys/vm uma_core.c > Log: > Gulp ... call kmem_malloc() without Giant. So, let me guess, now would be a great time to update the kernel on my desktop, right? :-) Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From owner-cvs-src@FreeBSD.ORG Fri Jul 25 22:57:54 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 216DE37B401; Fri, 25 Jul 2003 22:57:54 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4E4B43FA3; Fri, 25 Jul 2003 22:57:53 -0700 (PDT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q5vr0U002960; Fri, 25 Jul 2003 22:57:53 -0700 (PDT) (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q5vrm6002959; Fri, 25 Jul 2003 22:57:53 -0700 (PDT) Message-Id: <200307260557.h6Q5vrm6002959@repoman.freebsd.org> From: Scott Long Date: Fri, 25 Jul 2003 22:57:53 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 05:57:54 -0000 scottl 2003/07/25 22:57:53 PDT FreeBSD src repository Modified files: release Makefile Log: Fix the release build with a forgotten '-f'. Revision Changes Path 1.800 +3 -3 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Fri Jul 25 23:14:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DA8D37B407 for ; Fri, 25 Jul 2003 23:14:02 -0700 (PDT) Received: from smtp.mho.com (smtp.mho.net [64.58.4.6]) by mx1.FreeBSD.org (Postfix) with SMTP id 81B8143F93 for ; Fri, 25 Jul 2003 23:14:00 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: (qmail 7184 invoked by uid 1002); 26 Jul 2003 06:13:59 -0000 Received: from adsl-64-58-12-196.mho.net (HELO freebsd.org) (64.58.12.196) by smtp.mho.net with SMTP; 26 Jul 2003 06:13:59 -0000 Message-ID: <3F221C30.4050003@freebsd.org> Date: Sat, 26 Jul 2003 00:14:08 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: src-committers@FreeBSD.org References: <200307260557.h6Q5vrm6002959@repoman.freebsd.org> In-Reply-To: <200307260557.h6Q5vrm6002959@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 06:14:03 -0000 Scott Long wrote: > scottl 2003/07/25 22:57:53 PDT > > FreeBSD src repository > > Modified files: > release Makefile > Log: > Fix the release build with a forgotten '-f'. > > Revision Changes Path > 1.800 +3 -3 src/release/Makefile > Instead of putting a snide remark into commit log about this, I'll take a different approach. For the love of god, people, the minimum requirement for checking something in to our repo is that it *COMPILES*! Things have gotten far too sloppy, and it only wastes developer and user time! What good are the daily release snapshots if they don't build for days or weeks on end? What good is it to tell our userbase to track the tree with cvs and cvsup when the tree won't build? Not long ago we used to require that any commit to the kernel be tested before-hand by building LINT, and that any commit to the rest of the tree be tested by building world. That was back in the days when building world took 2-3 hours on fast hardware. The project has resources available to it now that can build world in less than an hour and build a release in less than two. There is no excuse for not testing before committing. That said, I'm pleased with the work that has gone on this summer and appreciate all of the hard effort. The schedules for 4.9 and 5.2 will be published shortly, both of which have the potential to be important and exciting releases =-) Scott From owner-cvs-src@FreeBSD.ORG Fri Jul 25 23:47:41 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CBA3237B401; Fri, 25 Jul 2003 23:47:41 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A50243F85; Fri, 25 Jul 2003 23:47:41 -0700 (PDT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q6lf0U005686; Fri, 25 Jul 2003 23:47:41 -0700 (PDT) (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q6lfID005685; Fri, 25 Jul 2003 23:47:41 -0700 (PDT) Message-Id: <200307260647.h6Q6lfID005685@repoman.freebsd.org> From: Scott Long Date: Fri, 25 Jul 2003 23:47:41 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 06:47:42 -0000 scottl 2003/07/25 23:47:41 PDT FreeBSD src repository Modified files: release Makefile Log: Bah, I go and get all preachy, and then commit from the wrong branch. Revert the use of '-j8'. Apologies to: ru Revision Changes Path 1.801 +2 -2 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Sat Jul 26 00:23:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A31F37B404; Sat, 26 Jul 2003 00:23:25 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1581243F75; Sat, 26 Jul 2003 00:23:25 -0700 (PDT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q7NO0U007854; Sat, 26 Jul 2003 00:23:24 -0700 (PDT) (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q7NOOh007853; Sat, 26 Jul 2003 00:23:24 -0700 (PDT) Message-Id: <200307260723.h6Q7NOOh007853@repoman.freebsd.org> From: Scott Long Date: Sat, 26 Jul 2003 00:23:24 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_socket2.c vfs_export.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 07:23:26 -0000 scottl 2003/07/26 00:23:24 PDT FreeBSD src repository Modified files: sys/kern uipc_socket2.c vfs_export.c Log: Guard against MLEN growing larger than a uint8_t due to MSIZE grwoing to a value of 512 in LINT. This keeps gcc from complaining. Revision Changes Path 1.114 +2 -0 src/sys/kern/uipc_socket2.c 1.324 +2 -0 src/sys/kern/vfs_export.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 00:23:26 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A488537B401; Sat, 26 Jul 2003 00:23:26 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 37EF243F75; Sat, 26 Jul 2003 00:23:26 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q7NQ0U007881; Sat, 26 Jul 2003 00:23:26 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q7NPmc007880; Sat, 26 Jul 2003 00:23:25 -0700 (PDT) Message-Id: <200307260723.h6Q7NPmc007880@repoman.freebsd.org> From: Marcel Moolenaar Date: Sat, 26 Jul 2003 00:23:25 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ia64/include acpica_machdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 07:23:27 -0000 marcel 2003/07/26 00:23:25 PDT FreeBSD src repository Modified files: sys/ia64/include acpica_machdep.h Log: Unbreak ia64 builds now -Werror is enabled again. Avoid obsolete memory operand construct. Revision Changes Path 1.2 +6 -6 src/sys/ia64/include/acpica_machdep.h From owner-cvs-src@FreeBSD.ORG Sat Jul 26 00:32:24 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 348B837B401; Sat, 26 Jul 2003 00:32:24 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7C1F43F85; Sat, 26 Jul 2003 00:32:23 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q7WN0U008569; Sat, 26 Jul 2003 00:32:23 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q7WNqX008568; Sat, 26 Jul 2003 00:32:23 -0700 (PDT) Message-Id: <200307260732.h6Q7WNqX008568@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 26 Jul 2003 00:32:23 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/coda coda_fbsd.c coda_vnops.c src/sys/compat/linux linux_misc.c src/sys/dev/raidframe rf_freebsdkintf.c src/sys/fs/hpfs hpfs_vfsops.c src/sys/fs/msdosfs msdosfs_vfsops.c src/sys/fs/ntfs ntfs_vfsops.c src/sys/fs/nwfs ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 07:32:24 -0000 phk 2003/07/26 00:32:23 PDT FreeBSD src repository Modified files: sys/coda coda_fbsd.c coda_vnops.c sys/compat/linux linux_misc.c sys/dev/raidframe rf_freebsdkintf.c sys/fs/hpfs hpfs_vfsops.c sys/fs/msdosfs msdosfs_vfsops.c sys/fs/ntfs ntfs_vfsops.c sys/fs/nwfs nwfs_io.c sys/fs/smbfs smbfs_io.c smbfs_vnops.c sys/fs/udf udf_vfsops.c sys/fs/unionfs union_subr.c union_vnops.c sys/gnu/ext2fs ext2_vfsops.c sys/i386/ibcs2 imgact_coff.c sys/isofs/cd9660 cd9660_vfsops.c sys/kern kern_exec.c vfs_syscalls.c vfs_vnops.c vnode_if.src sys/ufs/ffs ffs_vfsops.c sys/ufs/ufs ufs_extattr.c sys/vm swap_pager.c Log: Add a "int fd" argument to VOP_OPEN() which in the future will contain the filedescriptor number on opens from userland. The index is used rather than a "struct file *" since it conveys a bit more information, which may be useful to in particular fdescfs and /dev/fd/* For now pass -1 all over the place. Revision Changes Path 1.31 +1 -1 src/sys/coda/coda_fbsd.c 1.50 +3 -3 src/sys/coda/coda_vnops.c 1.146 +1 -1 src/sys/compat/linux/linux_misc.c 1.19 +3 -3 src/sys/dev/raidframe/rf_freebsdkintf.c 1.35 +1 -1 src/sys/fs/hpfs/hpfs_vfsops.c 1.104 +2 -2 src/sys/fs/msdosfs/msdosfs_vfsops.c 1.56 +1 -1 src/sys/fs/ntfs/ntfs_vfsops.c 1.29 +2 -2 src/sys/fs/nwfs/nwfs_io.c 1.22 +2 -2 src/sys/fs/smbfs/smbfs_io.c 1.39 +1 -1 src/sys/fs/smbfs/smbfs_vnops.c 1.14 +1 -1 src/sys/fs/udf/udf_vfsops.c 1.75 +4 -4 src/sys/fs/unionfs/union_subr.c 1.102 +1 -1 src/sys/fs/unionfs/union_vnops.c 1.106 +1 -1 src/sys/gnu/ext2fs/ext2_vfsops.c 1.60 +1 -1 src/sys/i386/ibcs2/imgact_coff.c 1.112 +2 -2 src/sys/isofs/cd9660/cd9660_vfsops.c 1.225 +1 -1 src/sys/kern/kern_exec.c 1.325 +1 -1 src/sys/kern/vfs_syscalls.c 1.191 +1 -1 src/sys/kern/vfs_vnops.c 1.64 +1 -0 src/sys/kern/vnode_if.src 1.215 +2 -2 src/sys/ufs/ffs/ffs_vfsops.c 1.66 +1 -1 src/sys/ufs/ufs/ufs_extattr.c 1.211 +1 -1 src/sys/vm/swap_pager.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 00:35:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D61E37B401; Sat, 26 Jul 2003 00:35:33 -0700 (PDT) Received: from h190n1fls34o809.telia.com (h190n1fls34o809.telia.com [213.67.96.190]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F0A443FA3; Sat, 26 Jul 2003 00:35:32 -0700 (PDT) (envelope-from pawel.worach@telia.com) Received: from corona (corona.sajd.net [192.168.1.20])h6Q7ZUv05378; Sat, 26 Jul 2003 09:35:30 +0200 (MEST) From: "Pawel Worach" To: "'Alan Cox'" , Date: Sat, 26 Jul 2003 09:35:29 +0200 Message-ID: <000001c35348$7d73d600$4116f00a@corona> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook, Build 10.0.4510 In-Reply-To: <200307260355.h6Q3tWkN096860@repoman.freebsd.org> Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 Subject: RE: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 07:35:33 -0000 alc 2003/07/25 20:55:32 PDT FreeBSD src repository Modified files: sys/vm uma_core.c=20 Log: Gulp ... call kmem_malloc() without Giant. Could this change affect user applications? After a reboot with this kernel squid crashes randomly with the stack every time. This could of course be a squid bug but i just have to make sure before i file one :) #0 0x2825e39f in kill () from /usr/lib/libc.so.5 #1 0x282cab2b in abort () from /usr/lib/libc.so.5 #2 0x0807c8e3 in xassert () at debug.cc:363 #3 0x080c8c31 in UFSStoreState::queueRead(char*, unsigned, long long, = void (*)(void*, char const*, int), void*) (this=3D0x91af010,=20 buf=3D0x912c018 "", size=3D4096, offset=3D0, callback=3D0x80b8598 , callback_data=3D0x91ab010) at = ufs/store_io_ufs.cc:570 #4 0x080b721b in storeRead (sio=3DCannot access memory at address 0x0 ) at ../include/RefCount.h:71 ... From owner-cvs-src@FreeBSD.ORG Sat Jul 26 00:48:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F96A37B401 for ; Sat, 26 Jul 2003 00:48:27 -0700 (PDT) Received: from mail26c.sbc-webhosting.com (mail26c.sbc-webhosting.com [216.173.237.166]) by mx1.FreeBSD.org (Postfix) with SMTP id 74D5643FA3 for ; Sat, 26 Jul 2003 00:48:26 -0700 (PDT) (envelope-from alc@imimic.com) Received: from www.imimic.com (64.143.12.21)2-0216095692; Sat, 26 Jul 2003 03:48:12 -0400 (EDT) Sender: alc@FreeBSD.ORG Message-ID: <3F22323C.CA08C37C@imimic.com> Date: Sat, 26 Jul 2003 02:48:12 -0500 From: "Alan L. Cox" Organization: iMimic Networking, Inc. X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386) X-Accept-Language: en MIME-Version: 1.0 To: Pawel Worach References: <000001c35348$7d73d600$4116f00a@corona> Content-Type: text/plain; charset=x-user-defined Content-Transfer-Encoding: 7bit X-Loop-Detect: 1 cc: 'Alan Cox' cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 07:48:27 -0000 Pawel Worach wrote: > > alc 2003/07/25 20:55:32 PDT > > FreeBSD src repository > > Modified files: > sys/vm uma_core.c > Log: > Gulp ... call kmem_malloc() without Giant. > > Could this change affect user applications? > After a reboot with this kernel squid crashes > randomly with the stack every time. > This could of course be a squid bug but i just > have to make sure before i file one :) > No, I wouldn't expect that to be a symptom. Regardless, please try backing out this one commit and see if it has any effect. Regards, Alan > #0 0x2825e39f in kill () from /usr/lib/libc.so.5 > #1 0x282cab2b in abort () from /usr/lib/libc.so.5 > #2 0x0807c8e3 in xassert () at debug.cc:363 > #3 0x080c8c31 in UFSStoreState::queueRead(char*, unsigned, long long, void > (*)(void*, char const*, int), void*) (this=0x91af010, > buf=0x912c018 "", size=4096, offset=0, callback=0x80b8598 > , callback_data=0x91ab010) at ufs/store_io_ufs.cc:570 > #4 0x080b721b in storeRead (sio=Cannot access memory at address 0x0 > ) at ../include/RefCount.h:71 > ... From owner-cvs-src@FreeBSD.ORG Sat Jul 26 01:03:44 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A2C037B401; Sat, 26 Jul 2003 01:03:44 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 138DD43F85; Sat, 26 Jul 2003 01:03:44 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q83h0U016021; Sat, 26 Jul 2003 01:03:43 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q83hOl016020; Sat, 26 Jul 2003 01:03:43 -0700 (PDT) Message-Id: <200307260803.h6Q83hOl016020@repoman.freebsd.org> From: Marcel Moolenaar Date: Sat, 26 Jul 2003 01:03:43 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ia64/include setjmp.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 08:03:45 -0000 marcel 2003/07/26 01:03:43 PDT FreeBSD src repository Modified files: sys/ia64/include setjmp.h Log: Avoid using __aligned(16). Instead define the jmp_buf in terms of long doubles. This gives us 16-byte alignment. Add a CTASSERT for the size of the jmp_buf to detect ABI breakages. Revision Changes Path 1.12 +11 -9 src/sys/ia64/include/setjmp.h From owner-cvs-src@FreeBSD.ORG Sat Jul 26 01:09:56 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A8F0E37B405 for ; Sat, 26 Jul 2003 01:09:56 -0700 (PDT) Received: from mail26d.sbc-webhosting.com (mail26d.sbc-webhosting.com [216.173.237.167]) by mx1.FreeBSD.org (Postfix) with SMTP id D79B943FBD for ; Sat, 26 Jul 2003 01:09:54 -0700 (PDT) (envelope-from alc@imimic.com) Received: from www.imimic.com (64.143.12.21)3-088096978; Sat, 26 Jul 2003 04:09:38 -0400 (EDT) Sender: alc@FreeBSD.ORG Message-ID: <3F223742.48F28685@imimic.com> Date: Sat, 26 Jul 2003 03:09:38 -0500 From: "Alan L. Cox" Organization: iMimic Networking, Inc. X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386) X-Accept-Language: en MIME-Version: 1.0 To: Peter Wemm References: <20030726051002.37B3C2A7EA@canning.wemm.org> Content-Type: text/plain; charset=x-user-defined Content-Transfer-Encoding: 7bit X-Loop-Detect: 1 cc: Alan Cox cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 08:09:57 -0000 Peter Wemm wrote: > > Alan Cox wrote: > > Modified files: > > sys/vm uma_core.c > > Log: > > Gulp ... call kmem_malloc() without Giant. > > So, let me guess, now would be a great time to update the kernel on my > desktop, right? :-) > I sincerely hope that it doesn't turn out to be a bad time. :-) To everyone: There are two "failure modes" that I would anticipate if something is wrong. The first would be an assertion failure that Giant isn't held somewhere. This is no big deal. The second would be seemingly random kernel crashes, probably in the vm system, due to corruption of a vm object or vm page queue. This is worrisome. It means that I've missed some access to a vm object or the vm page "cache" queues that requires synchronization. Unfortunately, due to the use of vm objects as a kind of page table page container in the various pmaps, I haven't been able to add as many assertions as I would like. Regards, Alan From owner-cvs-src@FreeBSD.ORG Sat Jul 26 01:54:56 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C3C137B401; Sat, 26 Jul 2003 01:54:56 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1BD5243FB1; Sat, 26 Jul 2003 01:54:54 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id SAA16012; Sat, 26 Jul 2003 18:54:50 +1000 Date: Sat, 26 Jul 2003 18:54:48 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Ruslan Ermilov In-Reply-To: <20030725082357.GA53826@sunbay.com> Message-ID: <20030726184513.D5126@gamplex.bde.org> References: <200307250010.h6P0AYKW061085@repoman.freebsd.org> <20030725053806.GA36982@sunbay.com> <3F20DF2D.8030209@freebsd.org> <20030725082357.GA53826@sunbay.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Scott Long cc: Bruce Evans cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/release/i386 drivers.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 08:54:57 -0000 On Fri, 25 Jul 2003, Ruslan Ermilov wrote: > On Fri, Jul 25, 2003 at 01:41:33AM -0600, Scott Long wrote: > > Ruslan Ermilov wrote: > > >Which reminds me. The floppy wasn't overflowing when building > > >5.x snapshot on 4.x, due to the differences in file system > > >layout between 4.x and 5.x. Please see the attached if you're > > >interested. > > ... > > Now that -O2 is the default for newfs in 5-current, does the 'Oflag == > > 2' trick still work? > > > Yes it does: > > 1. doFS.sh creates file systems with -O1 > 2. The patch affects the -O1 case: > > > Even if it does, it feels like a hack to me. I'd > > rather that newfs have an option to directly override the number of > > c/g's, rather than rely on indirect calculations and magic constants. > > > *Shrug*, an option to override a minimum value? > > > Please don't commit this until we have discussed it more. I think the 'Oflag == 2' trick is a hack to avoid touching the -O2 case, since the -O2 implementors haven't responded and others don't have enough experience with -O2 to know what is right. OTOH, with -O1 it is well known that you can't have too few cylinder groups except possibly for unuseful disk sizes like 40MB, so removing the limit just fixes a bug. Anyway, there was no limit in until recently, so we have lots of practical experience with using 1 cylinder group. Bruce From owner-cvs-src@FreeBSD.ORG Sat Jul 26 02:16:51 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C495B37B401; Sat, 26 Jul 2003 02:16:51 -0700 (PDT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 38DDD43FA3; Sat, 26 Jul 2003 02:16:51 -0700 (PDT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 301572ED464; Sat, 26 Jul 2003 02:16:51 -0700 (PDT) Date: Sat, 26 Jul 2003 02:16:51 -0700 From: Alfred Perlstein To: Poul-Henning Kamp Message-ID: <20030726091651.GB42924@elvis.mu.org> References: <200307260732.h6Q7WNqX008568@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307260732.h6Q7WNqX008568@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/coda coda_fbsd.c coda_vnops.c src/sys/compat/linux linux_misc.c src/sys/dev/raidframe rf_freebsdkintf.c src/sys/fs/hpfs hpfs_vfsops.c src/sys/fs/msdosfs msdosfs_vfsops.c src/sys/fs/ntfs ntfs_vfsops.c src/sys/fs/nwfs ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 09:16:52 -0000 * Poul-Henning Kamp [030726 00:32] wrote: > phk 2003/07/26 00:32:23 PDT > > FreeBSD src repository > > Modified files: > sys/coda coda_fbsd.c coda_vnops.c > sys/compat/linux linux_misc.c > sys/dev/raidframe rf_freebsdkintf.c > Log: > Add a "int fd" argument to VOP_OPEN() which in the future will > contain the filedescriptor number on opens from userland. > > The index is used rather than a "struct file *" since it conveys a bit > more information, which may be useful to in particular fdescfs and /dev/fd/* > > For now pass -1 all over the place. This seems like a mistake, it forces one to have a struct filedesc instead of merely faking up a struct file. What if one wants to have a cookie without a filedesc? Am I mistaken? If there was a discussion on this you might want to float a "Discussed on: " in the log messages to shut me up. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' From owner-cvs-src@FreeBSD.ORG Sat Jul 26 02:54:20 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 74EBF37B401; Sat, 26 Jul 2003 02:54:20 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 134C543F75; Sat, 26 Jul 2003 02:54:20 -0700 (PDT) (envelope-from takawata@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q9sI0U021550; Sat, 26 Jul 2003 02:54:19 -0700 (PDT) (envelope-from takawata@repoman.freebsd.org) Received: (from takawata@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q9sI1X021549; Sat, 26 Jul 2003 02:54:18 -0700 (PDT) Message-Id: <200307260954.h6Q9sI1X021549@repoman.freebsd.org> From: Takanori Watanabe Date: Sat, 26 Jul 2003 02:54:17 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/acpica acpi_button.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 09:54:20 -0000 takawata 2003/07/26 02:54:17 PDT FreeBSD src repository Modified files: sys/dev/acpica acpi_button.c Log: Enable wake up GPE before shutdown, not only for sleeping. Revision Changes Path 1.12 +1 -0 src/sys/dev/acpica/acpi_button.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 03:13:31 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ABE9F37B401; Sat, 26 Jul 2003 03:13:31 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 492A743F93; Sat, 26 Jul 2003 03:13:31 -0700 (PDT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QADV0U023453; Sat, 26 Jul 2003 03:13:31 -0700 (PDT) (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QADU3u023452; Sat, 26 Jul 2003 03:13:30 -0700 (PDT) Message-Id: <200307261013.h6QADU3u023452@repoman.freebsd.org> From: Marcel Moolenaar Date: Sat, 26 Jul 2003 03:13:30 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ia64/include cpu.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 10:13:32 -0000 marcel 2003/07/26 03:13:30 PDT FreeBSD src repository Modified files: sys/ia64/include cpu.h Log: Remove prototype of ia64_pa_access(). The function has been moved to mem.c where it's been made static. Revision Changes Path 1.34 +0 -1 src/sys/ia64/include/cpu.h From owner-cvs-src@FreeBSD.ORG Sat Jul 26 04:43:38 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 26AC437B401; Sat, 26 Jul 2003 04:43:38 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB5DD43FAF; Sat, 26 Jul 2003 04:43:37 -0700 (PDT) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QBhb0U029747; Sat, 26 Jul 2003 04:43:37 -0700 (PDT) (envelope-from ume@repoman.freebsd.org) Received: (from ume@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QBhbKq029746; Sat, 26 Jul 2003 04:43:37 -0700 (PDT) Message-Id: <200307261143.h6QBhbKq029746@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Sat, 26 Jul 2003 04:43:37 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/net if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 11:43:38 -0000 ume 2003/07/26 04:43:37 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/net if.c Log: MFC 1.164: Disabling multicast on vlan interface caused kernel panic. Revision Changes Path 1.85.2.24 +2 -0 src/sys/net/if.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 04:53:41 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E829637B401; Sat, 26 Jul 2003 04:53:40 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87E5543F75; Sat, 26 Jul 2003 04:53:40 -0700 (PDT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QBre0U035497; Sat, 26 Jul 2003 04:53:40 -0700 (PDT) (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QBre3x035496; Sat, 26 Jul 2003 04:53:40 -0700 (PDT) Message-Id: <200307261153.h6QBre3x035496@repoman.freebsd.org> From: Bruce Evans Date: Sat, 26 Jul 2003 04:53:40 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/buslogic bt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 11:53:41 -0000 bde 2003/07/26 04:53:40 PDT FreeBSD src repository Modified files: sys/dev/buslogic bt.c Log: Fixed wrong function names in the error message that was translated to C in rev.1.32 so that it doesn't take 2 commits for all branches to fix this message. Revision Changes Path 1.41 +3 -3 src/sys/dev/buslogic/bt.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 05:06:26 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 911E837B401; Sat, 26 Jul 2003 05:06:26 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F91543F75; Sat, 26 Jul 2003 05:06:26 -0700 (PDT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QC6P0U036925; Sat, 26 Jul 2003 05:06:25 -0700 (PDT) (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QC6Pf5036924; Sat, 26 Jul 2003 05:06:25 -0700 (PDT) Message-Id: <200307261206.h6QC6Pf5036924@repoman.freebsd.org> From: Bruce Evans Date: Sat, 26 Jul 2003 05:06:25 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/buslogic bt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 12:06:27 -0000 bde 2003/07/26 05:06:25 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/buslogic bt.c Log: MFC (1.32: translate to C: don't use hard newlines in a string literal; 1.41: use the correct function name in the string literal). This is part of making some RELENG_4 kernels buildable by gcc-3.3. Revision Changes Path 1.25.2.2 +5 -5 src/sys/dev/buslogic/bt.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 05:09:59 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4039D37B401; Sat, 26 Jul 2003 05:09:59 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D2FCA43F93; Sat, 26 Jul 2003 05:09:58 -0700 (PDT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QC9w0U036998; Sat, 26 Jul 2003 05:09:58 -0700 (PDT) (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QC9w1v036997; Sat, 26 Jul 2003 05:09:58 -0700 (PDT) Message-Id: <200307261209.h6QC9w1v036997@repoman.freebsd.org> From: Bruce Evans Date: Sat, 26 Jul 2003 05:09:58 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_3 Subject: cvs commit: src/sys/dev/buslogic bt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 12:09:59 -0000 bde 2003/07/26 05:09:58 PDT FreeBSD src repository Modified files: (Branch: RELENG_3) sys/dev/buslogic bt.c Log: MFC (1.32: translate to C: don't use hard newlines in a string literal; 1.41: use the correct function name in the string literal). This is part of making some RELENG_3 kernels compilable by gcc-3.3. Revision Changes Path 1.13.2.7 +5 -5 src/sys/dev/buslogic/bt.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 05:14:59 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28E2B37B401; Sat, 26 Jul 2003 05:14:59 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA3DA43FB1; Sat, 26 Jul 2003 05:14:58 -0700 (PDT) (envelope-from pb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QCEw0U037236; Sat, 26 Jul 2003 05:14:58 -0700 (PDT) (envelope-from pb@repoman.freebsd.org) Received: (from pb@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QCEw8d037235; Sat, 26 Jul 2003 05:14:58 -0700 (PDT) Message-Id: <200307261214.h6QCEw8d037235@repoman.freebsd.org> From: Pierre Beyssac Date: Sat, 26 Jul 2003 05:14:58 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/burncd burncd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 12:14:59 -0000 pb 2003/07/26 05:14:58 PDT FreeBSD src repository Modified files: usr.sbin/burncd burncd.c Log: Fix "write from stdin". Reviewed by: sos MFC after: 1 week Revision Changes Path 1.37 +6 -3 src/usr.sbin/burncd/burncd.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 05:38:51 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 89E1537B404; Sat, 26 Jul 2003 05:38:51 -0700 (PDT) Received: from musique.teaser.net (musique.teaser.net [213.91.2.11]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3BF1543F93; Sat, 26 Jul 2003 05:38:50 -0700 (PDT) (envelope-from e-masson@kisoft-services.com) Received: from notbsdems.interne.kisoft-services.com (nantes.kisoft-services.com [193.56.60.243]) by musique.teaser.net (Postfix) with ESMTP id B35A772519; Sat, 26 Jul 2003 14:38:48 +0200 (CEST) Received: by notbsdems.interne.kisoft-services.com (Postfix, from userid 1001) id 846685AF02; Sat, 26 Jul 2003 14:38:38 +0200 (CEST) To: Sam Leffler From: Eric Masson In-Reply-To: <200307221858.h6MIwY2g007438@repoman.freebsd.org> (Sam Leffler's message of "Tue, 22 Jul 2003 11:58:34 -0700 (PDT)") References: <200307221858.h6MIwY2g007438@repoman.freebsd.org> X-Operating-System: FreeBSD 4.8-STABLE i386 Date: Sat, 26 Jul 2003 14:38:38 +0200 Message-ID: <86el0dea41.fsf@notbsdems.interne.kisoft-services.com> User-Agent: Gnus/5.1003 (Gnus v5.10.3) XEmacs/21.4 (Common Lisp, berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_input.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 12:38:52 -0000 >>>>> "Sam" == Sam Leffler writes: Sam> Modified files: sys/netinet ip_input.c Log: add IPSEC_FILTERGIF Sam> suport for FAST_IPSEC Thanks Sam. Regards Eric Masson -- Newsgroups: fr.comp.mail je suis à la recherche d'un shema électronique d'un émetteur G.P.S (Global position system) ou à defaut une adrs Email -+- N in Guide du Neuneu Usenet - Sans son GNU, on est perdu -+- From owner-cvs-src@FreeBSD.ORG Sat Jul 26 05:41:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F2BD37B401; Sat, 26 Jul 2003 05:41:45 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F1DC743F75; Sat, 26 Jul 2003 05:41:44 -0700 (PDT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QCfi0U038164; Sat, 26 Jul 2003 05:41:44 -0700 (PDT) (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QCfixe038163; Sat, 26 Jul 2003 05:41:44 -0700 (PDT) Message-Id: <200307261241.h6QCfixe038163@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Sat, 26 Jul 2003 05:41:44 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/devfs devfs.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 12:41:45 -0000 simon 2003/07/26 05:41:44 PDT FreeBSD src repository (doc committer) Modified files: sbin/devfs devfs.8 Log: Minor mdoc(7) cleanup, based on the PR below. PR: docs/54826 Submitted by: Lukas Ertl Reviewed by: ru Approved by: ceri (mentor) Revision Changes Path 1.7 +4 -2 src/sbin/devfs/devfs.8 From owner-cvs-src@FreeBSD.ORG Sat Jul 26 05:57:57 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D6BE37B401; Sat, 26 Jul 2003 05:57:57 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A39743F93; Sat, 26 Jul 2003 05:57:57 -0700 (PDT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QCvv0U038740; Sat, 26 Jul 2003 05:57:57 -0700 (PDT) (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QCvuBw038739; Sat, 26 Jul 2003 05:57:56 -0700 (PDT) Message-Id: <200307261257.h6QCvuBw038739@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Sat, 26 Jul 2003 05:57:56 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/fsck fsck.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 12:57:58 -0000 simon 2003/07/26 05:57:56 PDT FreeBSD src repository (doc committer) Modified files: sbin/fsck fsck.8 Log: Remove references to the '-l' option in synopsis. The rest of the description of this option was removed in v. 1.22. PR: docs/54880 Submitted by: Lukas Ertl Approved by: ceri (mentor) Revision Changes Path 1.33 +1 -2 src/sbin/fsck/fsck.8 From owner-cvs-src@FreeBSD.ORG Sat Jul 26 05:58:09 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C1D0A37B407; Sat, 26 Jul 2003 05:58:09 -0700 (PDT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D33643F3F; Sat, 26 Jul 2003 05:58:09 -0700 (PDT) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id 215B32ED44A; Sat, 26 Jul 2003 05:58:09 -0700 (PDT) Date: Sat, 26 Jul 2003 14:58:09 +0200 From: Maxime Henrion To: "Alan L. Cox" Message-ID: <20030726125809.GC65432@elvis.mu.org> References: <200307252102.h6PL2PFL063697@repoman.freebsd.org> <3F219CFF.ECFF953D@imimic.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="kORqDWCi7qDJ0mEj" Content-Disposition: inline In-Reply-To: <3F219CFF.ECFF953D@imimic.com> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_contig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 12:58:10 -0000 --kORqDWCi7qDJ0mEj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Alan L. Cox wrote: > Maxime Henrion wrote: > > > > mux 2003/07/25 14:02:25 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/vm vm_contig.c > > Log: > > Add support for the M_ZERO flag to contigmalloc(). > > > > Reviewed by: jeff > > > > Revision Changes Path > > 1.21 +5 -1 src/sys/vm/vm_contig.c > > This has a bug. The page is not mapped at the time you perform > bzero(). (In fact, it is not mapped until after the vm_map_wire() > occurs.) Thus, you need to use pmap_zero_page() instead. > > Your tests probably succeeded because of page prezeroing. (With > prezeroing, you never exercised the bug.) > > I'm pretty sure that I sent you an e-mail about this. If not, I > apologize. I sent you two mails aout this, specifically asking if I was allowed to touch the page before vm_map_wire() was called, because I was pretty sure nothing else could be wrong in this patch :-). I never received your answer, so maybe it got lost, but anyways, here is a patch which should fix this issue. Does this look OK to you? Thanks, Maxime --kORqDWCi7qDJ0mEj Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="vm_contig.patch.2" Index: vm_contig.c =================================================================== RCS file: /space2/ncvs/src/sys/vm/vm_contig.c,v retrieving revision 1.21 diff -u -p -r1.21 vm_contig.c --- vm_contig.c 25 Jul 2003 21:02:25 -0000 1.21 +++ vm_contig.c 26 Jul 2003 12:57:03 -0000 @@ -261,7 +261,7 @@ again1: vm_page_insert(m, kernel_object, OFF_TO_IDX(tmp_addr - VM_MIN_KERNEL_ADDRESS)); if ((flags & M_ZERO) && !(m->flags & PG_ZERO)) - bzero((void *)tmp_addr, PAGE_SIZE); + pmap_zero_page(m); m->flags = 0; tmp_addr += PAGE_SIZE; } --kORqDWCi7qDJ0mEj-- From owner-cvs-src@FreeBSD.ORG Sat Jul 26 05:58:29 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5709E37B401; Sat, 26 Jul 2003 05:58:29 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E87D643FAF; Sat, 26 Jul 2003 05:58:28 -0700 (PDT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QCwS0U038831; Sat, 26 Jul 2003 05:58:28 -0700 (PDT) (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QCwSwd038830; Sat, 26 Jul 2003 05:58:28 -0700 (PDT) Message-Id: <200307261258.h6QCwSwd038830@repoman.freebsd.org> From: David Xu Date: Sat, 26 Jul 2003 05:58:28 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/amd64/gen signalcontext.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 12:58:29 -0000 davidxu 2003/07/26 05:58:28 PDT FreeBSD src repository Modified files: lib/libc/amd64/gen signalcontext.c Log: Set mc_len to sizeof(mcontext_t), otherwise it is an invalid context. Revision Changes Path 1.2 +1 -0 src/lib/libc/amd64/gen/signalcontext.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 06:04:42 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1354B37B401; Sat, 26 Jul 2003 06:04:42 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A16E343F75; Sat, 26 Jul 2003 06:04:41 -0700 (PDT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QD4f0U039977; Sat, 26 Jul 2003 06:04:41 -0700 (PDT) (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QD4fao039976; Sat, 26 Jul 2003 06:04:41 -0700 (PDT) Message-Id: <200307261304.h6QD4fao039976@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Sat, 26 Jul 2003 06:04:41 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 13:04:42 -0000 simon 2003/07/26 06:04:40 PDT FreeBSD src repository (doc committer) Modified files: release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: The /rescue system is now enabled by default again, so remove note saying that it is disabled. Approved by: ceri (mentor) Revision Changes Path 1.597 +0 -8 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Sat Jul 26 07:20:39 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3ACB137B401; Sat, 26 Jul 2003 07:20:39 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC50E43FAF; Sat, 26 Jul 2003 07:20:38 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QEKc0U043486; Sat, 26 Jul 2003 07:20:38 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QEKbSQ043482; Sat, 26 Jul 2003 07:20:37 -0700 (PDT) Message-Id: <200307261420.h6QEKbSQ043482@repoman.freebsd.org> From: Hartmut Brandt Date: Sat, 26 Jul 2003 07:20:37 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netatm atm_cm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 14:20:39 -0000 harti 2003/07/26 07:20:37 PDT FreeBSD src repository Modified files: sys/netatm atm_cm.c Log: Silence a gcc-warning. Do this by inlining the macro-call. This is not very nice - the compiler should just silently optimize away the unused else clause. Revision Changes Path 1.31 +1 -2 src/sys/netatm/atm_cm.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 07:57:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AAAC037B401; Sat, 26 Jul 2003 07:57:27 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4694443F75; Sat, 26 Jul 2003 07:57:27 -0700 (PDT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QEvR0U045242; Sat, 26 Jul 2003 07:57:27 -0700 (PDT) (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QEvQFB045241; Sat, 26 Jul 2003 07:57:26 -0700 (PDT) Message-Id: <200307261457.h6QEvQFB045241@repoman.freebsd.org> From: Hartmut Brandt Date: Sat, 26 Jul 2003 07:57:26 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/patm if_patm_rx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 14:57:28 -0000 harti 2003/07/26 07:57:26 PDT FreeBSD src repository Modified files: sys/dev/patm if_patm_rx.c Log: Inline a function that gcc refused to inline. This function was used only in one place and it just served as semantic sugar. Revision Changes Path 1.2 +2 -7 src/sys/dev/patm/if_patm_rx.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 08:29:11 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 248E537B401; Sat, 26 Jul 2003 08:29:11 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B6AA043FBF; Sat, 26 Jul 2003 08:29:10 -0700 (PDT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QFTA0U047274; Sat, 26 Jul 2003 08:29:10 -0700 (PDT) (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QFTA08047273; Sat, 26 Jul 2003 08:29:10 -0700 (PDT) Message-Id: <200307261529.h6QFTA08047273@repoman.freebsd.org> From: Maxim Konovalov Date: Sat, 26 Jul 2003 08:29:10 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/fsck fsck.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 15:29:11 -0000 maxim 2003/07/26 08:29:10 PDT FreeBSD src repository Modified files: sbin/fsck fsck.c Log: o Fix usage(): remove '-l', add missed '-f', sort. Revision Changes Path 1.16 +1 -1 src/sbin/fsck/fsck.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 09:43:30 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0A6D37B401; Sat, 26 Jul 2003 09:43:30 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2881843F93; Sat, 26 Jul 2003 09:43:27 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6QGhL0U042516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 26 Jul 2003 19:43:21 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6QGhJq7042511; Sat, 26 Jul 2003 19:43:19 +0300 (EEST) (envelope-from ru) Date: Sat, 26 Jul 2003 19:43:19 +0300 From: Ruslan Ermilov To: Bruce Evans Message-ID: <20030726164319.GC41833@sunbay.com> References: <200307250010.h6P0AYKW061085@repoman.freebsd.org> <20030725053806.GA36982@sunbay.com> <3F20DF2D.8030209@freebsd.org> <20030725082357.GA53826@sunbay.com> <20030726184513.D5126@gamplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yLVHuoLXiP9kZBkt" Content-Disposition: inline In-Reply-To: <20030726184513.D5126@gamplex.bde.org> User-Agent: Mutt/1.5.4i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Scott Long cc: Bruce Evans cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/release/i386 drivers.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 16:43:31 -0000 --yLVHuoLXiP9kZBkt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 26, 2003 at 06:54:48PM +1000, Bruce Evans wrote: > On Fri, 25 Jul 2003, Ruslan Ermilov wrote: >=20 > > On Fri, Jul 25, 2003 at 01:41:33AM -0600, Scott Long wrote: > > > Ruslan Ermilov wrote: > > > >Which reminds me. The floppy wasn't overflowing when building > > > >5.x snapshot on 4.x, due to the differences in file system > > > >layout between 4.x and 5.x. Please see the attached if you're > > > >interested. > > > ... > > > Now that -O2 is the default for newfs in 5-current, does the 'Oflag = =3D=3D > > > 2' trick still work? > > > > > Yes it does: > > > > 1. doFS.sh creates file systems with -O1 > > 2. The patch affects the -O1 case: > > > > > Even if it does, it feels like a hack to me. I'd > > > rather that newfs have an option to directly override the number of > > > c/g's, rather than rely on indirect calculations and magic constants. > > > > > *Shrug*, an option to override a minimum value? > > > > > Please don't commit this until we have discussed it more. >=20 > I think the 'Oflag =3D=3D 2' trick is a hack to avoid touching the -O2 ca= se, > since the -O2 implementors haven't responded and others don't have enough > experience with -O2 to know what is right. OTOH, with -O1 it is well > known that you can't have too few cylinder groups except possibly for > unuseful disk sizes like 40MB, so removing the limit just fixes a bug. > Anyway, there was no limit in until recently, so we have lots of practical > experience with using 1 cylinder group. >=20 Yes, this is exactly the case. Kirk never responded, and I was not sure about the -O2 case. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --yLVHuoLXiP9kZBkt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/Iq+nUkv4P6juNwoRAkPoAJ9+dxcnryGZC2/+roWOHblxU07UngCghe6i QfU5ZK9DcSanCtf2hJmmR60= =ggzf -----END PGP SIGNATURE----- --yLVHuoLXiP9kZBkt-- From owner-cvs-src@FreeBSD.ORG Sat Jul 26 10:45:46 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A96FB37B401; Sat, 26 Jul 2003 10:45:46 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45A4C43F75; Sat, 26 Jul 2003 10:45:46 -0700 (PDT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QHjk0U063877; Sat, 26 Jul 2003 10:45:46 -0700 (PDT) (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QHjjRN063876; Sat, 26 Jul 2003 10:45:45 -0700 (PDT) Message-Id: <200307261745.h6QHjjRN063876@repoman.freebsd.org> From: Warner Losh Date: Sat, 26 Jul 2003 10:45:45 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/pccard pccarddevs X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 17:45:47 -0000 imp 2003/07/26 10:45:45 PDT FreeBSD src repository Modified files: sys/dev/pccard pccarddevs Log: MFNetBSD: 1.183: gmcgarry; Add Sharp PALDIO 611S 1.184: martin; Socket LP 10/100 CF Obtained from: NetBSD Revision Changes Path 1.61 +6 -1 src/sys/dev/pccard/pccarddevs From owner-cvs-src@FreeBSD.ORG Sat Jul 26 10:46:44 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2F0237B401; Sat, 26 Jul 2003 10:46:44 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6037E43F75; Sat, 26 Jul 2003 10:46:44 -0700 (PDT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QHki0U063921; Sat, 26 Jul 2003 10:46:44 -0700 (PDT) (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QHki8v063920; Sat, 26 Jul 2003 10:46:44 -0700 (PDT) Message-Id: <200307261746.h6QHki8v063920@repoman.freebsd.org> From: Warner Losh Date: Sat, 26 Jul 2003 10:46:44 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/pccard pccarddevs.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 17:46:45 -0000 imp 2003/07/26 10:46:44 PDT FreeBSD src repository Modified files: sys/dev/pccard pccarddevs.h Log: Sync to 1.61 of pccarddevs Revision Changes Path 1.61 +11 -2 src/sys/dev/pccard/pccarddevs.h From owner-cvs-src@FreeBSD.ORG Sat Jul 26 10:52:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7756837B401; Sat, 26 Jul 2003 10:52:10 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 12E9A43F75; Sat, 26 Jul 2003 10:52:10 -0700 (PDT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QHq90U064169; Sat, 26 Jul 2003 10:52:09 -0700 (PDT) (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QHq9Bx064168; Sat, 26 Jul 2003 10:52:09 -0700 (PDT) Message-Id: <200307261752.h6QHq9Bx064168@repoman.freebsd.org> From: Warner Losh Date: Sat, 26 Jul 2003 10:52:09 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ed if_ed_pccard.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 17:52:11 -0000 imp 2003/07/26 10:52:09 PDT FreeBSD src repository Modified files: sys/dev/ed if_ed_pccard.c Log: Add Socket Communications Low Power 10/100 CF Ethernet card. Obtained from: NetBSD (information, not code) Revision Changes Path 1.50 +1 -0 src/sys/dev/ed/if_ed_pccard.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 11:50:55 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F10737B401; Sat, 26 Jul 2003 11:50:55 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D87743F85; Sat, 26 Jul 2003 11:50:54 -0700 (PDT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QIos0U067571; Sat, 26 Jul 2003 11:50:54 -0700 (PDT) (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QIosK1067570; Sat, 26 Jul 2003 11:50:54 -0700 (PDT) Message-Id: <200307261850.h6QIosK1067570@repoman.freebsd.org> From: Mike Makonnen Date: Sat, 26 Jul 2003 11:50:54 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d dhclient X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 18:50:55 -0000 mtm 2003/07/26 11:50:54 PDT FreeBSD src repository Modified files: etc/rc.d dhclient Log: When stopping a dhcp interface, don't just release the lease on the address, also kill the dhclient process. Instead of doing the release in the stop command, move it to the precmd stage and allow rc.subr(8) to automatically kill the dhclient process by leaving the stop command undefined. Noticed by: mbr Revision Changes Path 1.7 +7 -12 src/etc/rc.d/dhclient From owner-cvs-src@FreeBSD.ORG Sat Jul 26 11:58:48 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08A3D37B401; Sat, 26 Jul 2003 11:58:48 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9898543F93; Sat, 26 Jul 2003 11:58:47 -0700 (PDT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QIwl0U067846; Sat, 26 Jul 2003 11:58:47 -0700 (PDT) (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QIwlMG067840; Sat, 26 Jul 2003 11:58:47 -0700 (PDT) Message-Id: <200307261858.h6QIwlMG067840@repoman.freebsd.org> From: Mike Makonnen Date: Sat, 26 Jul 2003 11:58:47 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d dhclient X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 18:58:48 -0000 mtm 2003/07/26 11:58:47 PDT FreeBSD src repository Modified files: etc/rc.d dhclient Log: Define the stop command to do nothing when only a specific interface is to be stopped. In this case we don't want to go beyond releasing the lease. Revision Changes Path 1.8 +1 -0 src/etc/rc.d/dhclient From owner-cvs-src@FreeBSD.ORG Sat Jul 26 13:31:38 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 632C837B401; Sat, 26 Jul 2003 13:31:38 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEA2843F93; Sat, 26 Jul 2003 13:31:36 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6QKVXV3010743; Sat, 26 Jul 2003 20:31:34 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6QKVP5H056217; Sat, 26 Jul 2003 22:31:32 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Alfred Perlstein From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 26 Jul 2003 02:16:51 PDT." <20030726091651.GB42924@elvis.mu.org> Date: Sat, 26 Jul 2003 22:31:25 +0200 Message-ID: <56216.1059251485@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/coda coda_fbsd.c coda_vnops.c src/sys/compat/linux linux_misc.c src/sys/dev/raidframe rf_freebsdkintf.c src/sys/fs/hpfs hpfs_vfsops.c src/sys/fs/msdosfs msdosfs_vfsops.c src/sys/fs/ntfs ntfs_vfsops.c src/sys/fs/nwfs ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 20:31:38 -0000 In message <20030726091651.GB42924@elvis.mu.org>, Alfred Perlstein writes: >* Poul-Henning Kamp [030726 00:32] wrote: >> phk 2003/07/26 00:32:23 PDT >> >> FreeBSD src repository >> >> Modified files: >> sys/coda coda_fbsd.c coda_vnops.c >> sys/compat/linux linux_misc.c >> sys/dev/raidframe rf_freebsdkintf.c >> Log: >> Add a "int fd" argument to VOP_OPEN() which in the future will >> contain the filedescriptor number on opens from userland. >> >> The index is used rather than a "struct file *" since it conveys a bit >> more information, which may be useful to in particular fdescfs and /dev/fd/* >> >> For now pass -1 all over the place. > >This seems like a mistake, it forces one to have a struct filedesc instead >of merely faking up a struct file. > >What if one wants to have a cookie without a filedesc? > >Am I mistaken? I'm afraid that I totally fail to even understand your question... The objective here is to improve the situation where a vnode open results in a non-vnode method vector on the file, /dev/fd[0-2], /dev/stream etc. The index can be used with the (already) passed thread pointer to access the relevant file entry. BTW: I am not done with this change, the next commit adds the identical argument to vn_open(). -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sat Jul 26 13:54:59 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FA1C37B401; Sat, 26 Jul 2003 13:54:59 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EED5F43F85; Sat, 26 Jul 2003 13:54:58 -0700 (PDT) (envelope-from jdp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QKsw0U079228; Sat, 26 Jul 2003 13:54:58 -0700 (PDT) (envelope-from jdp@repoman.freebsd.org) Received: (from jdp@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QKsw2o079227; Sat, 26 Jul 2003 13:54:58 -0700 (PDT) Message-Id: <200307262054.h6QKsw2o079227@repoman.freebsd.org> From: John Polstra Date: Sat, 26 Jul 2003 13:54:58 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/wi if_wi_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 20:54:59 -0000 jdp 2003/07/26 13:54:58 PDT FreeBSD src repository Modified files: sys/dev/wi if_wi_pci.c Log: Fix a couple of bugs in the resume handler. Don't call the if_init function unless the device is configured up. Without this fix, the device ends up in the RUNNING state even though it is configured down. Also, check the RUNNING flag before calling the if_start function, in case the if_init function failed for one reason or another. Revision Changes Path 1.18 +3 -2 src/sys/dev/wi/if_wi_pci.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 14:03:57 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 240DD37B401; Sat, 26 Jul 2003 14:03:57 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D8C343FBF; Sat, 26 Jul 2003 14:03:56 -0700 (PDT) (envelope-from jdp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QL3u0U080842; Sat, 26 Jul 2003 14:03:56 -0700 (PDT) (envelope-from jdp@repoman.freebsd.org) Received: (from jdp@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QL3uQh080841; Sat, 26 Jul 2003 14:03:56 -0700 (PDT) Message-Id: <200307262103.h6QL3uQh080841@repoman.freebsd.org> From: John Polstra Date: Sat, 26 Jul 2003 14:03:56 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/wi if_wi.c if_wi_pci.c if_wivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 21:03:57 -0000 jdp 2003/07/26 14:03:55 PDT FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/wi if_wi.c if_wi_pci.c if_wivar.h Log: MFC suspend/resume support for the wi driver: if_wi.c 1.120 if_wi_pci.c 1.11, 1.12 (relevant style fixes only), 1.18 if_wivar.h 1.14 Revision Changes Path 1.103.2.4 +1 -2 src/sys/dev/wi/if_wi.c 1.8.2.4 +35 -0 src/sys/dev/wi/if_wi_pci.c 1.8.2.4 +1 -0 src/sys/dev/wi/if_wivar.h From owner-cvs-src@FreeBSD.ORG Sat Jul 26 14:29:29 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AF3737B401; Sat, 26 Jul 2003 14:29:29 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AAD3343F75; Sat, 26 Jul 2003 14:29:28 -0700 (PDT) (envelope-from mbr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QLTS0U095518; Sat, 26 Jul 2003 14:29:28 -0700 (PDT) (envelope-from mbr@repoman.freebsd.org) Received: (from mbr@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QLTSfO095517; Sat, 26 Jul 2003 14:29:28 -0700 (PDT) Message-Id: <200307262129.h6QLTSfO095517@repoman.freebsd.org> From: Martin Blapp Date: Sat, 26 Jul 2003 14:29:28 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/isc-dhcp FREEBSD-upgrade X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 21:29:29 -0000 mbr 2003/07/26 14:29:28 PDT FreeBSD src repository Modified files: contrib/isc-dhcp FREEBSD-upgrade Log: Add notice about the local change in r1.25 Revision Changes Path 1.15 +1 -0 src/contrib/isc-dhcp/FREEBSD-upgrade From owner-cvs-src@FreeBSD.ORG Sat Jul 26 14:35:03 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22C4337B401; Sat, 26 Jul 2003 14:35:03 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1572243F3F; Sat, 26 Jul 2003 14:35:02 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6QLYxV3011618; Sat, 26 Jul 2003 21:34:59 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6QLYm5H056901; Sat, 26 Jul 2003 23:34:48 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Peter Jeremy From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 26 Jul 2003 07:21:42 +1000." <20030725212142.GB9176@cirb503493.alcatel.com.au> Date: Sat, 26 Jul 2003 23:34:48 +0200 Message-ID: <56900.1059255288@critter.freebsd.dk> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 21:35:04 -0000 In message <20030725212142.GB9176@cirb503493.alcatel.com.au>, Peter Jeremy writ es: >On Wed, Jul 23, 2003 at 01:28:24AM +0200, Poul-Henning Kamp wrote: >>Please remember that the problem at hand is getting -Werror back >>on the kernel so we can catch issues like the warning in umtx. > >Why is -Werror such a holy grail? I think I can say without doubt that next to Bruce, I have been trawling more code in the FreeBSD kernel than anybody and consequently seem more bogus code and "neat hacks" than I care for. When I first started to interest myself with the mechanics of sanitizing the kernel source, it was because two common symbols had the same name, which gave rather non-newtonian behaviour under a given set of circumstances which I ran into rather often. Subsequently, I have written a couple of minor scripts to try to help make sure certain kinds of consistency remains in force in the kernel (this was the genesis of src/tools btw). I have even gone as far as to spend a fair bit of time testing various code analysis tools, a decade ago I used Purify, these days FlexeLint is my favourite, on the kernel correctling as I go the most severe problems I found that way. Considering that we pride our selves of having the "most experienced" source code in the industry, and generally belive that we are better than the rest, the sort of bugs I have found and corrected have amazed me, most so the long list of programs nailed by phkmalloc. And on a more abstract level it is a sobering thought in that light, that the way we write code is essentially unchanged since the time when the guy who taught me to program, was taught it, by some of the people who helped write the first ALGOL-60 compiler. We still have no tools which help us translate high level abstractions into low level code or for that matter to validate the high level abstractions in the first place. Number people have gone from pencil and paper to spreadsheets, writes from type writers to word processing, graphic artists from brush and pen to illustrator and photoshop. But programmers, they still go directly from brainwave to source code with no technology assistance. I am sure that most languages have expressions about the state of cobblers kids footwear and what bakers kids eat, and they apply to programmers as much as that. If we could even just claim that people have gotten better at it but we have not attained a reduction in bugs per line of code over the last 40 years that anybody has been able to measure. (And no, don't point to another language which is much better for writing operating system kernels, it would be a waste of your time.) Given all that, I firmly belive we should embrace every little bit of help we can get from tools and programs we have, even if that means minor inconveniences and a certain cramping of style here and there. The role of the source code we write is to express clearly and efficiently our intention for the compiler to interpret into executable code, and failing that, to make it clear what the intent is, so that a future improved compiler can get the chance. For every dubious construct in that source code the compiler can warns us about, we will have a certain fraction of actual bugs less. Provided, of course, that people actually read the warnings. And that is why -Werror is not a holy grail, but a damn efficient means forcing the bastards to read the warnings. I will readily agree that GCC is far from optimal in many ways, and the particular way used to control which detected conditions are fatal, which are warnings and which are ignored is very deficient. But it is the best we have, and it is better than having nothing. And should anybody take a liking to the idea of improving GCCs suitability to our coding standards and ideals, I am sure he would find people like Peter, Bruce and me very grateful. Another project in the same category would be a source-code locking analyzer ie: read the source code, check that locks are locked/unlocked in the right order, the right number of times etc etc etc. Pretty much what WITNESS does at runtime, but done at compile time and covering the entire source code including all the exceptions, rather than only the beaten path which WITNESS sees. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sat Jul 26 14:48:47 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E287637B401; Sat, 26 Jul 2003 14:48:46 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7FF5143F93; Sat, 26 Jul 2003 14:48:46 -0700 (PDT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QLmk0U005461; Sat, 26 Jul 2003 14:48:46 -0700 (PDT) (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QLmk88005460; Sat, 26 Jul 2003 14:48:46 -0700 (PDT) Message-Id: <200307262148.h6QLmk88005460@repoman.freebsd.org> From: Alan Cox Date: Sat, 26 Jul 2003 14:48:46 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_contig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 21:48:47 -0000 alc 2003/07/26 14:48:46 PDT FreeBSD src repository Modified files: sys/vm vm_contig.c Log: Acquire Giant rather than asserting it is held in contigmalloc(). This is a prerequisite to removing further uses of Giant from UMA. Revision Changes Path 1.22 +2 -1 src/sys/vm/vm_contig.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 14:58:08 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C32637B404; Sat, 26 Jul 2003 14:58:08 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9301A43FBD; Sat, 26 Jul 2003 14:58:07 -0700 (PDT) (envelope-from gj@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6QLw70U010715; Sat, 26 Jul 2003 14:58:07 -0700 (PDT) (envelope-from gj@repoman.freebsd.org) Received: (from gj@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6QLw7tk010714; Sat, 26 Jul 2003 14:58:07 -0700 (PDT) Message-Id: <200307262158.h6QLw7tk010714@repoman.freebsd.org> From: Gary Jennejohn Date: Sat, 26 Jul 2003 14:58:07 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net if_spppsubr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2003 21:58:08 -0000 gj 2003/07/26 14:58:07 PDT FreeBSD src repository Modified files: sys/net if_spppsubr.c Log: Use M_WAITOK instead of M_WAIT in sppp_attach(). Revision Changes Path 1.103 +1 -1 src/sys/net/if_spppsubr.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 17:13:51 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08D0437B401; Sat, 26 Jul 2003 17:13:51 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB6A943F85; Sat, 26 Jul 2003 17:13:50 -0700 (PDT) (envelope-from robert@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6R0Do0U035800; Sat, 26 Jul 2003 17:13:50 -0700 (PDT) (envelope-from robert@repoman.freebsd.org) Received: (from robert@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6R0Dolw035799; Sat, 26 Jul 2003 17:13:50 -0700 (PDT) Message-Id: <200307270013.h6R0Dolw035799@repoman.freebsd.org> From: Robert Drehmel Date: Sat, 26 Jul 2003 17:13:50 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pci ncr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jul 2003 00:13:51 -0000 robert 2003/07/26 17:13:50 PDT FreeBSD src repository Modified files: sys/pci ncr.c Log: Changed the type of the variable `qidx' from u_int8_t to int, mainly to quiet a warning emitted by GCC 3.3 about comparing a variable to a value which is larger than the former can hold. The value was checked to make sure the `np->squeue' array is not accessed behind its boundary. This worked due to possibly accidental truncation when (np->squeueput + 1) was larger than or equal to MAX_START (256) when it was assigned to `qidx'. `qidx' is used to hold the next position in the start queue for an insertion. The new type was chosen because some other code in the function ncr_freeze_devq() also uses plain integers to hold those indices. Wrapped the line after the closing parenthesis of an `if' condition. Revision Changes Path 1.176 +3 -2 src/sys/pci/ncr.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 19:00:01 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 42DCC37B401; Sat, 26 Jul 2003 19:00:01 -0700 (PDT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id B36F643F75; Sat, 26 Jul 2003 19:00:00 -0700 (PDT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id A4CCA2ED474; Sat, 26 Jul 2003 19:00:00 -0700 (PDT) Date: Sat, 26 Jul 2003 19:00:00 -0700 From: Alfred Perlstein To: Poul-Henning Kamp Message-ID: <20030727020000.GA10457@elvis.mu.org> References: <20030726091651.GB42924@elvis.mu.org> <56216.1059251485@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56216.1059251485@critter.freebsd.dk> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/coda coda_fbsd.c coda_vnops.c src/sys/compat/linux linux_misc.c src/sys/dev/raidframe rf_freebsdkintf.c src/sys/fs/hpfs hpfs_vfsops.c src/sys/fs/msdosfs msdosfs_vfsops.c src/sys/fs/ntfs ntfs_vfsops.c src/sys/fs/nwfs ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jul 2003 02:00:01 -0000 * Poul-Henning Kamp [030726 13:31] wrote: > In message <20030726091651.GB42924@elvis.mu.org>, Alfred Perlstein writes: > >* Poul-Henning Kamp [030726 00:32] wrote: > >> phk 2003/07/26 00:32:23 PDT > >> Log: > >> Add a "int fd" argument to VOP_OPEN() which in the future will > >> contain the filedescriptor number on opens from userland. > >> > >> The index is used rather than a "struct file *" since it conveys a bit > >> more information, which may be useful to in particular fdescfs and /dev/fd/* > >> > >> For now pass -1 all over the place. > > > >This seems like a mistake, it forces one to have a struct filedesc instead > >of merely faking up a struct file. > > > >What if one wants to have a cookie without a filedesc? > > > >Am I mistaken? > > I'm afraid that I totally fail to even understand your question... > > The objective here is to improve the situation where a vnode open > results in a non-vnode method vector on the file, /dev/fd[0-2], > /dev/stream etc. The index can be used with the (already) passed > thread pointer to access the relevant file entry. > > BTW: I am not done with this change, the next commit adds the > identical argument to vn_open(). I was mistaken as to what I thought you were trying to accomplish here. I thought you were doing the "each device open gets a cookie" thing from linux via some hack. But instead it appears to be some weird optimization. Nevermind I guess. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' From owner-cvs-src@FreeBSD.ORG Sat Jul 26 22:43:59 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 20C6637B401; Sat, 26 Jul 2003 22:43:59 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B453043F75; Sat, 26 Jul 2003 22:43:58 -0700 (PDT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6R5hw0U056875; Sat, 26 Jul 2003 22:43:58 -0700 (PDT) (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6R5hwBK056874; Sat, 26 Jul 2003 22:43:58 -0700 (PDT) Message-Id: <200307270543.h6R5hwBK056874@repoman.freebsd.org> From: Alan Cox Date: Sat, 26 Jul 2003 22:43:58 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_object.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jul 2003 05:43:59 -0000 alc 2003/07/26 22:43:58 PDT FreeBSD src repository Modified files: sys/vm vm_object.c Log: Allow vm_object_reference() on kernel_object without Giant. Revision Changes Path 1.302 +4 -2 src/sys/vm/vm_object.c From owner-cvs-src@FreeBSD.ORG Sat Jul 26 23:44:12 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E33237B401; Sat, 26 Jul 2003 23:44:12 -0700 (PDT) Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id EFDE143F75; Sat, 26 Jul 2003 23:44:10 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6R6i8V3019855; Sun, 27 Jul 2003 06:44:08 GMT (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6R6i75H060743; Sun, 27 Jul 2003 08:44:07 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Alfred Perlstein From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 26 Jul 2003 19:00:00 PDT." <20030727020000.GA10457@elvis.mu.org> Date: Sun, 27 Jul 2003 08:44:07 +0200 Message-ID: <60742.1059288247@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/coda coda_fbsd.c coda_vnops.c src/sys/compat/linux linux_misc.c src/sys/dev/raidframe rf_freebsdkintf.c src/sys/fs/hpfs hpfs_vfsops.c src/sys/fs/msdosfs msdosfs_vfsops.c src/sys/fs/ntfs ntfs_vfsops.c src/sys/fs/nwfs ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jul 2003 06:44:12 -0000 In message <20030727020000.GA10457@elvis.mu.org>, Alfred Perlstein writes: >I thought you were doing the "each device open gets a cookie" thing >from linux via some hack. But instead it appears to be some weird >optimization. Nevermind I guess. Not quite that bad, my aim is to not take the detour over vnodes for devices opened from userland (I posted a "proof of concept" patch for this some weeks ago.) This gains us 4-6% wall-clock on fsck. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sat Jul 26 23:46:35 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BBFB937B401; Sat, 26 Jul 2003 23:46:35 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 553B743FBD; Sat, 26 Jul 2003 23:46:35 -0700 (PDT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6R6kZ0U059908; Sat, 26 Jul 2003 23:46:35 -0700 (PDT) (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6R6kYbd059907; Sat, 26 Jul 2003 23:46:34 -0700 (PDT) Message-Id: <200307270646.h6R6kYbd059907@repoman.freebsd.org> From: David Xu Date: Sat, 26 Jul 2003 23:46:34 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c thr_sigwait.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jul 2003 06:46:36 -0000 davidxu 2003/07/26 23:46:34 PDT FreeBSD src repository Modified files: lib/libpthread/thread thr_private.h thr_sig.c thr_sigwait.c Log: Simplify sigwait code a bit by using a waitset and removing oldsigmask. Reviewed by: deischen Revision Changes Path 1.95 +5 -2 src/lib/libpthread/thread/thr_private.h 1.64 +7 -15 src/lib/libpthread/thread/thr_sig.c 1.32 +5 -5 src/lib/libpthread/thread/thr_sigwait.c