From owner-freebsd-audit@FreeBSD.ORG Mon May 12 08:59:41 2003 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6848937B401 for ; Mon, 12 May 2003 08:59:41 -0700 (PDT) Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4A7043FB1 for ; Mon, 12 May 2003 08:59:37 -0700 (PDT) (envelope-from fjoe@iclub.nsu.ru) Received: from mail by mx.nsu.ru with drweb-scanned (Exim 3.36 #1 (Debian)) id 19FFjt-0005ti-00 for ; Mon, 12 May 2003 23:01:21 +0700 Received: from iclub.nsu.ru ([193.124.215.97] ident=root) by mx.nsu.ru with esmtp (Exim 3.36 #1 (Debian)) id 19FFjY-0005sS-00 for ; Mon, 12 May 2003 23:01:00 +0700 Received: from iclub.nsu.ru (fjoe@localhost [127.0.0.1]) by iclub.nsu.ru (8.12.9/8.12.9) with ESMTP id h4CFwmh2006062 for ; Mon, 12 May 2003 22:58:48 +0700 (NSS) (envelope-from fjoe@iclub.nsu.ru) Received: (from fjoe@localhost) by iclub.nsu.ru (8.12.9/8.12.9/Submit) id h4CFwmvd006061 for freebsd-audit@freebsd.org; Mon, 12 May 2003 22:58:48 +0700 (NSS) Date: Mon, 12 May 2003 22:58:47 +0700 From: Max Khon To: freebsd-audit@freebsd.org Message-ID: <20030512155847.GA5689@iclub.nsu.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i X-Envelope-To: freebsd-audit@freebsd.org X-Bogosity: No, tests=bogofilter, spamicity=0.106204, version=0.11.1.4 X-Spam-Status: No, hits=-107.9 required=5.0 tests=BOGOFILTER_TEST_PASS,USER_AGENT_MUTT,USER_IN_WHITELIST version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) Subject: realpath(3) X-BeenThere: freebsd-audit@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Security Audit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 May 2003 15:59:41 -0000 hi, there! I am going to MFC realpath(3) and would like to get another round of review before MFC. Please look at http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/realpath.c?rev=1.19&content-type=text/x-cvsweb-markup /fjoe From owner-freebsd-audit@FreeBSD.ORG Tue May 13 00:34:15 2003 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DB9537B401 for ; Tue, 13 May 2003 00:34:15 -0700 (PDT) Received: from numeri.campus.luth.se (numeri.campus.luth.se [130.240.197.103]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DEA743F93 for ; Tue, 13 May 2003 00:34:14 -0700 (PDT) (envelope-from k@numeri.campus.luth.se) Received: from numeri.campus.luth.se (localhost [127.0.0.1]) by numeri.campus.luth.se (8.12.9/8.12.9) with ESMTP id h4D7YBdZ096952; Tue, 13 May 2003 09:34:11 +0200 (CEST) (envelope-from k@numeri.campus.luth.se) Received: (from k@localhost) by numeri.campus.luth.se (8.12.9/8.12.9/Submit) id h4D7YB5V096951; Tue, 13 May 2003 09:34:11 +0200 (CEST) Date: Tue, 13 May 2003 09:34:11 +0200 From: Johan Karlsson To: Max Khon Message-ID: <20030513073411.GA96739@numeri.campus.luth.se> References: <20030512155847.GA5689@iclub.nsu.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030512155847.GA5689@iclub.nsu.ru> User-Agent: Mutt/1.4i cc: FreeBSD-audit Subject: Re: realpath(3) X-BeenThere: freebsd-audit@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Security Audit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 May 2003 07:34:15 -0000 Hi On Mon, May 12, 2003 at 22:58 (+0700) +0000, Max Khon wrote: > hi, there! > > I am going to MFC realpath(3) and would like to get another round of > review before MFC. Please look at > > http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/realpath.c?rev=1.19&content-type=text/x-cvsweb-markup There are three realy minor things found by trying to make the code WARNS=6 clean. The comparisions on line 94 and line 173 comapares unsigned versus signed. The variable 'symlink' shadows a function from unistd.h and should be chnaged. Thanks for doing the MFC. /Johan K > > /fjoe > > _______________________________________________ > freebsd-audit@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-audit > To unsubscribe, send any mail to "freebsd-audit-unsubscribe@freebsd.org" -- Johan Karlsson mailto:johan@FreeBSD.org