From owner-freebsd-i18n@FreeBSD.ORG Mon Sep 22 10:09:16 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 395F016A4B3; Mon, 22 Sep 2003 10:09:16 -0700 (PDT) Received: from mail.ryu16.org (YahooBB219005044040.bbtec.net [219.5.44.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id C796F43FB1; Mon, 22 Sep 2003 10:09:08 -0700 (PDT) (envelope-from imura@ryu16.org) Received: from redeye.xt.ryu16.org (localhost [127.0.0.1]) by mail.ryu16.org (8.12.9p1/8.12.9) with ESMTP id h8MH94gb078483; Tue, 23 Sep 2003 02:09:04 +0900 (JST) (envelope-from imura@redeye.xt.ryu16.org) Received: (from imura@localhost) by redeye.xt.ryu16.org (8.12.9p1/8.12.9/Submit) id h8MH93xv078482; Tue, 23 Sep 2003 02:09:03 +0900 (JST) (envelope-from imura) Date: Tue, 23 Sep 2003 02:09:03 +0900 From: "R. Imura" To: freebsd-fs@freebsd.org, freebsd-i18n@freebsd.org Message-ID: <20030922170903.GA43754@ryu16.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i-ja.1 cc: bp@freebsd.org cc: sobomax@freebsd.org Subject: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2003 17:09:16 -0000 Hi all, I made a patch for multi-byte character extension of three file systems with enhanced LIBICONV in the kernel. File systems are cd9660(joliet part), msdosfs, and ntfs. http://www.ryu16.org/FreeBSD/kiconv/kiconv-5_current-20030921.diff I believe this will be good news to many of the people, such as Asian using multi-byte characters and others using single-byte characters which FreeBSD doesn't prepare convertion tables yet. Currently it is only limitted to 8 bit ascii characters convertion by LIBICONV or ports/cd9660_unicode or external libdata/msdosfs tables. I extented LIBICONV to handle 16 bit characters and add new kiconv library to generate convertion tables. If iconv(3) has a convertion rule, these file systems can use the rule. (So, ports/cd9660_unicode and libdata/msdosfs will be obsoluted. It also throw ports/{japanese,korean}/msdosfs away.) Here is the summary. New Library - kiconv(3) New Kernel Options (Kernel Modules) - CD9660_ICONV (cd9660_iconv.ko) - MSDOSFS_ICONV (msdosfs_iconv.ko) - NTFS_ICONV (ntfs_iconv.ko) Related Kernel Options (Kernel Modules) - CD9660 (cd9660.ko) - MSDOSFS (msdosfs.ko) - NTFS (ntfs.ko) - LIBICONV (libiconv.ko) Related Port - ports/converters/libiconv For example, with the cd9660 case, the multi-byte character convertion will be enabled when all of CD9660, CD9660_ICONV, and LIBICONV are specified. When only with CD9660, it behaves as before. kiconv(3) uses dlopen(3) to load userland iconv(3) library and generate a character convertion table. Then, copyin(9) the table via sysctl and kernel side iconv(9) uses this table for character convertion. (this is same as existent LIBICONV architecture) If someone has much better idea or kind of enhancement, a thing to do is only replace/add kiconv(3) and iconv(9). Any comments? And is it possible to apply this patch to upcoming FreeBSD-5.2? I tested them with Japanise on i386 machine, and did make release with i386/pc98/alpha/sparc64/ia64/amd64 via cross building. Note that because of bumping MODULE_VERSION of libiconv, kern/56570 must be applied before play with this patch. (loading smbfs will crash your system) P.S. Though it may be very small thing, I think this will be one of a benefit to chose FreeBSD, because many peple (are forced to) live with MS Windows, and this enhancement shorten a distance between FreeBSD and Windows environment. Best Regards, - R. Imura From owner-freebsd-i18n@FreeBSD.ORG Tue Sep 23 04:04:21 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9AC016A4B3; Tue, 23 Sep 2003 04:04:21 -0700 (PDT) Received: from mail.ryu16.org (YahooBB219005044040.bbtec.net [219.5.44.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id E92664400B; Tue, 23 Sep 2003 04:04:18 -0700 (PDT) (envelope-from imura@ryu16.org) Received: from redeye.xt.ryu16.org (localhost [127.0.0.1]) by mail.ryu16.org (8.12.9p1/8.12.9) with ESMTP id h8NB4Ggb019628; Tue, 23 Sep 2003 20:04:16 +0900 (JST) (envelope-from imura@redeye.xt.ryu16.org) Received: (from imura@localhost) by redeye.xt.ryu16.org (8.12.9p1/8.12.9/Submit) id h8NB4GiB019627; Tue, 23 Sep 2003 20:04:16 +0900 (JST) (envelope-from imura) Date: Tue, 23 Sep 2003 20:04:16 +0900 From: "R. Imura" To: freebsd-fs@freebsd.org, freebsd-i18n@freebsd.org Message-ID: <20030923110416.GA16446@ryu16.org> References: <20030922170903.GA43754@ryu16.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030922170903.GA43754@ryu16.org> User-Agent: Mutt/1.4.1i-ja.1 cc: bp@freebsd.org cc: sobomax@freebsd.org Subject: Re: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2003 11:04:22 -0000 Hi, On Tue, Sep 23, 2003 at 02:09:03AM +0900, R. Imura wrote: > I made a patch for multi-byte character extension > of three file systems with enhanced LIBICONV in the > kernel. File systems are cd9660(joliet part), msdosfs, > and ntfs. > > http://www.ryu16.org/FreeBSD/kiconv/kiconv-5_current-20030921.diff I should tell you one important thing that about 200 Japanese have been using this patch and there aren't any problem reported yet. Regards, - R. Imura From owner-freebsd-i18n@FreeBSD.ORG Tue Sep 23 05:02:17 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A827116A4B3; Tue, 23 Sep 2003 05:02:17 -0700 (PDT) Received: from sbtm.yonsei.net (sbtm.yonsei.net [61.100.191.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id 04BF743FE1; Tue, 23 Sep 2003 05:02:17 -0700 (PDT) (envelope-from perky@sbtm.yonsei.net) Received: by sbtm.yonsei.net (Postfix, from userid 1001) id 08E6F28411; Tue, 23 Sep 2003 21:03:00 +0900 (KST) Date: Tue, 23 Sep 2003 21:02:59 +0900 From: Hye-Shik Chang To: "R. Imura" Message-ID: <20030923120259.GA84509@fallin.lv> References: <20030922170903.GA43754@ryu16.org> <20030923110416.GA16446@ryu16.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030923110416.GA16446@ryu16.org> Organization: Yonsei University User-Agent: Mutt/1.5.4i cc: freebsd-fs@freebsd.org cc: freebsd-i18n@freebsd.org Subject: Re: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2003 12:02:17 -0000 On Tue, Sep 23, 2003 at 08:04:16PM +0900, R. Imura wrote: > Hi, > > On Tue, Sep 23, 2003 at 02:09:03AM +0900, R. Imura wrote: > > I made a patch for multi-byte character extension > > of three file systems with enhanced LIBICONV in the > > kernel. File systems are cd9660(joliet part), msdosfs, > > and ntfs. > > > > http://www.ryu16.org/FreeBSD/kiconv/kiconv-5_current-20030921.diff > > I should tell you one important thing that about 200 Japanese have > been using this patch and there aren't any problem reported yet. and 1 Korean. Thank you so much!! Hye-Shik =) From owner-freebsd-i18n@FreeBSD.ORG Tue Sep 23 05:09:43 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F06B16A4B3; Tue, 23 Sep 2003 05:09:43 -0700 (PDT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E4DD43F85; Tue, 23 Sep 2003 05:09:41 -0700 (PDT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.10/8.12.10) with ESMTP id h8NC9eRA029969; Tue, 23 Sep 2003 16:09:40 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.10/8.12.10/Submit) id h8NC9dkq029968; Tue, 23 Sep 2003 16:09:39 +0400 (MSD) (envelope-from ache) Date: Tue, 23 Sep 2003 16:09:38 +0400 From: Andrey Chernov To: "R. Imura" Message-ID: <20030923120936.GA29844@nagual.pp.ru> References: <20030922170903.GA43754@ryu16.org> <20030923110416.GA16446@ryu16.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030923110416.GA16446@ryu16.org> User-Agent: Mutt/1.5.4i cc: freebsd-fs@freebsd.org cc: bp@freebsd.org cc: sobomax@freebsd.org cc: freebsd-i18n@freebsd.org Subject: Re: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2003 12:09:43 -0000 On Tue, Sep 23, 2003 at 20:04:16 +0900, R. Imura wrote: > Hi, > > On Tue, Sep 23, 2003 at 02:09:03AM +0900, R. Imura wrote: > > I made a patch for multi-byte character extension > > of three file systems with enhanced LIBICONV in the > > kernel. File systems are cd9660(joliet part), msdosfs, > > and ntfs. > > > > http://www.ryu16.org/FreeBSD/kiconv/kiconv-5_current-20030921.diff > > I should tell you one important thing that about 200 Japanese have > been using this patch and there aren't any problem reported yet. All you need at this stage is to find one committer who understand multibyte/asian stuff enough (it is not me) and can integrate this patches into kernel module. I personally don't think it belongs to port, but, rather KLD module, especially if it covers most of Unicode. From owner-freebsd-i18n@FreeBSD.ORG Tue Sep 23 05:28:26 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 838DB16A4B3; Tue, 23 Sep 2003 05:28:26 -0700 (PDT) Received: from sbtm.yonsei.net (sbtm.yonsei.net [61.100.191.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA8F443FEC; Tue, 23 Sep 2003 05:28:25 -0700 (PDT) (envelope-from perky@sbtm.yonsei.net) Received: by sbtm.yonsei.net (Postfix, from userid 1001) id E692028411; Tue, 23 Sep 2003 21:29:08 +0900 (KST) Date: Tue, 23 Sep 2003 21:29:08 +0900 From: Hye-Shik Chang To: "R. Imura" Message-ID: <20030923122908.GA84813@fallin.lv> References: <20030922170903.GA43754@ryu16.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030922170903.GA43754@ryu16.org> Organization: Yonsei University User-Agent: Mutt/1.5.4i cc: freebsd-fs@freebsd.org cc: freebsd-i18n@freebsd.org Subject: Re: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2003 12:28:26 -0000 On Tue, Sep 23, 2003 at 02:09:03AM +0900, R. Imura wrote: > Hi all, > > I made a patch for multi-byte character extension > of three file systems with enhanced LIBICONV in the > kernel. File systems are cd9660(joliet part), msdosfs, > and ntfs. > > http://www.ryu16.org/FreeBSD/kiconv/kiconv-5_current-20030921.diff > [snip] > Related Kernel Options (Kernel Modules) > - CD9660 (cd9660.ko) > - MSDOSFS (msdosfs.ko) I found your patch to sys/fs/msdosfs can become simpler with Darwin's msdosfs modification that gathers a unicode string first and convert it later. I have a UTF-8 hardcoded patch that ported from Darwin to FreeBSD CURRENT. (the patch didn't tested by anybody else than I. :) http://people.freebsd.org/~perky/msdosfs-utf8.diff Regards, Hye-Shik =) From owner-freebsd-i18n@FreeBSD.ORG Tue Sep 23 13:24:30 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A3BE16A4B3; Tue, 23 Sep 2003 13:24:30 -0700 (PDT) Received: from baraca.united.net.ua (vlan1.baraca.united.net.ua [195.234.212.67]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2145B43FBF; Tue, 23 Sep 2003 13:24:28 -0700 (PDT) (envelope-from sobomax@portaone.com) Received: from portaone.com (office-l6-gw.united.net.ua [193.111.8.74]) h8NKNhYu020544; Tue, 23 Sep 2003 23:23:53 +0300 (EEST) (envelope-from sobomax@portaone.com) Message-ID: <3F70ABCF.6030300@portaone.com> Date: Tue, 23 Sep 2003 23:23:43 +0300 From: Maxim Sobolev User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 (ax) X-Accept-Language: en-us, en, ru, uk MIME-Version: 1.0 To: Andrey Chernov References: <20030922170903.GA43754@ryu16.org> <20030923110416.GA16446@ryu16.org> <20030923120936.GA29844@nagual.pp.ru> In-Reply-To: <20030923120936.GA29844@nagual.pp.ru> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-fs@FreeBSD.ORG cc: bp@FreeBSD.ORG cc: sobomax@FreeBSD.ORG cc: freebsd-i18n@FreeBSD.ORG Subject: Re: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2003 20:24:30 -0000 Andrey Chernov wrote: > On Tue, Sep 23, 2003 at 20:04:16 +0900, R. Imura wrote: > >>Hi, >> >>On Tue, Sep 23, 2003 at 02:09:03AM +0900, R. Imura wrote: >> >>>I made a patch for multi-byte character extension >>>of three file systems with enhanced LIBICONV in the >>>kernel. File systems are cd9660(joliet part), msdosfs, >>>and ntfs. >>> >>> http://www.ryu16.org/FreeBSD/kiconv/kiconv-5_current-20030921.diff >> >>I should tell you one important thing that about 200 Japanese have >>been using this patch and there aren't any problem reported yet. > > > All you need at this stage is to find one committer who understand > multibyte/asian stuff enough (it is not me) and can integrate this patches > into kernel module. I personally don't think it belongs to port, but, > rather KLD module, especially if it covers most of Unicode. I agree with Andrey, this patch is something that FreeBSD really needs. -Maxim From owner-freebsd-i18n@FreeBSD.ORG Wed Sep 24 08:03:03 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB13716A4BF; Wed, 24 Sep 2003 08:03:03 -0700 (PDT) Received: from mail.ryu16.org (YahooBB219005044040.bbtec.net [219.5.44.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4029343FBD; Wed, 24 Sep 2003 08:02:59 -0700 (PDT) (envelope-from imura@ryu16.org) Received: from redeye.xt.ryu16.org (localhost [127.0.0.1]) by mail.ryu16.org (8.12.9p1/8.12.9) with ESMTP id h8OF2tgb082820; Thu, 25 Sep 2003 00:02:55 +0900 (JST) (envelope-from imura@redeye.xt.ryu16.org) Received: (from imura@localhost) by redeye.xt.ryu16.org (8.12.9p1/8.12.9/Submit) id h8OF2s2N082819; Thu, 25 Sep 2003 00:02:54 +0900 (JST) (envelope-from imura) Date: Thu, 25 Sep 2003 00:02:54 +0900 From: "R. Imura" To: Andrey Chernov Message-ID: <20030924150254.GA27255@ryu16.org> References: <20030922170903.GA43754@ryu16.org> <20030923110416.GA16446@ryu16.org> <20030923120936.GA29844@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030923120936.GA29844@nagual.pp.ru> User-Agent: Mutt/1.4.1i-ja.1 cc: freebsd-fs@freebsd.org cc: bp@freebsd.org cc: sobomax@freebsd.org cc: freebsd-i18n@freebsd.org Subject: Re: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2003 15:03:04 -0000 On Tue, Sep 23, 2003 at 04:09:38PM +0400, Andrey Chernov wrote: > All you need at this stage is to find one committer who understand > multibyte/asian stuff enough (it is not me) and can integrate this patches Hmm, I don't know who is good at mutlibyte/asian stuff in FreeBSD. Anybody kindly would like to look at this? Or... I know well about Japanese, and little about Korean(KSC5601) and Chinese(Big5, GB2312, but not about GB18030). Though I've once given up committer's work a few years ago, if permitted, I think I can do myself. > into kernel module. I personally don't think it belongs to port, but, > rather KLD module, especially if it covers most of Unicode. It already does, or do you think about something different from me? Unicode convertion part is in libiconv.ko and *_iconv.ko. Regards, - R. Imura From owner-freebsd-i18n@FreeBSD.ORG Wed Sep 24 08:09:53 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F8F716A4B3; Wed, 24 Sep 2003 08:09:53 -0700 (PDT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B70E43FF5; Wed, 24 Sep 2003 08:09:51 -0700 (PDT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.10/8.12.10) with ESMTP id h8OF9okB030238; Wed, 24 Sep 2003 19:09:50 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.10/8.12.10/Submit) id h8OF9nsd030237; Wed, 24 Sep 2003 19:09:49 +0400 (MSD) (envelope-from ache) Date: Wed, 24 Sep 2003 19:09:46 +0400 From: Andrey Chernov To: "R. Imura" Message-ID: <20030924150944.GA30192@nagual.pp.ru> References: <20030922170903.GA43754@ryu16.org> <20030923110416.GA16446@ryu16.org> <20030923120936.GA29844@nagual.pp.ru> <20030924150254.GA27255@ryu16.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030924150254.GA27255@ryu16.org> User-Agent: Mutt/1.5.4i cc: freebsd-fs@freebsd.org cc: bp@freebsd.org cc: freebsd-i18n@freebsd.org cc: sobomax@freebsd.org Subject: Re: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2003 15:09:53 -0000 On Thu, Sep 25, 2003 at 00:02:54 +0900, R. Imura wrote: > It already does, or do you think about something different from me? > Unicode convertion part is in libiconv.ko and *_iconv.ko. I mean making cd9660 system KLD and not a port. From owner-freebsd-i18n@FreeBSD.ORG Wed Sep 24 09:06:26 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E013D16A4B3; Wed, 24 Sep 2003 09:06:26 -0700 (PDT) Received: from mail.ryu16.org (YahooBB219005044040.bbtec.net [219.5.44.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B5E643FDF; Wed, 24 Sep 2003 09:06:25 -0700 (PDT) (envelope-from imura@ryu16.org) Received: from redeye.xt.ryu16.org (localhost [127.0.0.1]) by mail.ryu16.org (8.12.9p1/8.12.9) with ESMTP id h8OG6Ogb085355; Thu, 25 Sep 2003 01:06:24 +0900 (JST) (envelope-from imura@redeye.xt.ryu16.org) Received: (from imura@localhost) by redeye.xt.ryu16.org (8.12.9p1/8.12.9/Submit) id h8OG6OUS085354; Thu, 25 Sep 2003 01:06:24 +0900 (JST) (envelope-from imura) Date: Thu, 25 Sep 2003 01:06:23 +0900 From: "R. Imura" To: Andrey Chernov Message-ID: <20030924160623.GB27255@ryu16.org> References: <20030922170903.GA43754@ryu16.org> <20030923110416.GA16446@ryu16.org> <20030923120936.GA29844@nagual.pp.ru> <20030924150254.GA27255@ryu16.org> <20030924150944.GA30192@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030924150944.GA30192@nagual.pp.ru> User-Agent: Mutt/1.4.1i-ja.1 cc: freebsd-fs@freebsd.org cc: bp@freebsd.org cc: freebsd-i18n@freebsd.org cc: sobomax@freebsd.org Subject: Re: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2003 16:06:27 -0000 On Wed, Sep 24, 2003 at 07:09:46PM +0400, Andrey Chernov wrote: > On Thu, Sep 25, 2003 at 00:02:54 +0900, R. Imura wrote: > > > It already does, or do you think about something different from me? > > Unicode convertion part is in libiconv.ko and *_iconv.ko. > > I mean making cd9660 system KLD and not a port. Ah, I understood. Thanks. :) - R. Imura From owner-freebsd-i18n@FreeBSD.ORG Fri Sep 26 03:31:04 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E7EB916A4B3; Fri, 26 Sep 2003 03:31:04 -0700 (PDT) Received: from relay.butya.kz (butya-gw.butya.kz [212.19.129.142]) by mx1.FreeBSD.org (Postfix) with ESMTP id D9C2F43FDF; Fri, 26 Sep 2003 03:31:01 -0700 (PDT) (envelope-from bp@butya.kz) Received: by relay.butya.kz (Postfix, from userid 1000) id 42C095935; Fri, 26 Sep 2003 17:30:56 +0700 (ALMST) Date: Fri, 26 Sep 2003 17:30:55 +0700 From: Boris Popov To: "R. Imura" Message-ID: <20030926103055.GD48438@vertex.kz> References: <20030922170903.GA43754@ryu16.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030922170903.GA43754@ryu16.org> User-Agent: Mutt/1.4.1i cc: freebsd-fs@freebsd.org cc: sobomax@freebsd.org cc: freebsd-i18n@freebsd.org Subject: Re: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Sep 2003 10:31:05 -0000 On Tue, Sep 23, 2003 at 02:09:03AM +0900, R. Imura wrote: > > I made a patch for multi-byte character extension > of three file systems with enhanced LIBICONV in the > kernel. File systems are cd9660(joliet part), msdosfs, > and ntfs. Great work, I should say! The patch itself looks good. There is only one minor note: function iconv_vfs_refcount() looks like misplaced one. It doesn't really belong to the iconv module and pollutes it with mount.h. May be getting this function into one of vfs_*.c files would be a better idea, although I'm don't have strong opinion on that. > > New Kernel Options (Kernel Modules) > - CD9660_ICONV (cd9660_iconv.ko) > - MSDOSFS_ICONV (msdosfs_iconv.ko) > - NTFS_ICONV (ntfs_iconv.ko) *_iconv.ko modules aren't strictly necessary and at some point they could be integrated into corresponding fs modules. libiconv.ko module isn't that large to significantly bloat install floppies. > > Any comments? And is it possible to apply this > patch to upcoming FreeBSD-5.2? I think yes. In addition, it is a good candidate for MFC into RELENG_4. > > P.S. > Though it may be very small thing, No this is great thing, thanks for your work! -- Boris Popov http://rbp.euro.ru From owner-freebsd-i18n@FreeBSD.ORG Fri Sep 26 10:41:42 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE98116A4B3; Fri, 26 Sep 2003 10:41:42 -0700 (PDT) Received: from mail.ryu16.org (YahooBB219005044109.bbtec.net [219.5.44.109]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A2EE43FA3; Fri, 26 Sep 2003 10:41:38 -0700 (PDT) (envelope-from imura@ryu16.org) Received: from redeye.xt.ryu16.org (localhost [127.0.0.1]) by mail.ryu16.org (8.12.9p1/8.12.9) with ESMTP id h8QHfa29005874; Sat, 27 Sep 2003 02:41:36 +0900 (JST) (envelope-from imura@redeye.xt.ryu16.org) Received: (from imura@localhost) by redeye.xt.ryu16.org (8.12.9p1/8.12.9/Submit) id h8QHfamX005873; Sat, 27 Sep 2003 02:41:36 +0900 (JST) (envelope-from imura) Date: Sat, 27 Sep 2003 02:41:35 +0900 From: "R. Imura" To: freebsd-fs@freebsd.org, freebsd-i18n@freebsd.org Message-ID: <20030926174135.GB3529@ryu16.org> References: <20030922170903.GA43754@ryu16.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030922170903.GA43754@ryu16.org> User-Agent: Mutt/1.4.1i-ja.1 Subject: Re: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Sep 2003 17:41:43 -0000 On Tue, Sep 23, 2003 at 02:09:03AM +0900, R. Imura wrote: > Hi all, > > I made a patch for multi-byte character extension > of three file systems with enhanced LIBICONV in the > kernel. File systems are cd9660(joliet part), msdosfs, > and ntfs. > > http://www.ryu16.org/FreeBSD/kiconv/kiconv-5_current-20030921.diff I must apologize that www.ryu16.org was unavailable for disk crash, since 9/25 03:00(JST) to 9/27 02:30(JST). (/usr, /var, /home has gone...) Now temporarily recovered. I must replace my machine with new one completely... (It's notebook.) - R. Imura From owner-freebsd-i18n@FreeBSD.ORG Sat Sep 27 05:25:09 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C9CDA16A4B3; Sat, 27 Sep 2003 05:25:09 -0700 (PDT) Received: from mail.ryu16.org (YahooBB219005044109.bbtec.net [219.5.44.109]) by mx1.FreeBSD.org (Postfix) with ESMTP id C4FCE43FDF; Sat, 27 Sep 2003 05:25:04 -0700 (PDT) (envelope-from imura@ryu16.org) Received: from redeye.xt.ryu16.org (localhost [127.0.0.1]) by mail.ryu16.org (8.12.9p1/8.12.9) with ESMTP id h8RCP2wN013193; Sat, 27 Sep 2003 21:25:02 +0900 (JST) (envelope-from imura@redeye.xt.ryu16.org) Received: (from imura@localhost) by redeye.xt.ryu16.org (8.12.9p1/8.12.9/Submit) id h8RCP2HE013192; Sat, 27 Sep 2003 21:25:02 +0900 (JST) (envelope-from imura) Date: Sat, 27 Sep 2003 21:25:02 +0900 From: "R. Imura" To: Boris Popov Message-ID: <20030927122502.GA8470@ryu16.org> References: <20030922170903.GA43754@ryu16.org> <20030926103055.GD48438@vertex.kz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030926103055.GD48438@vertex.kz> User-Agent: Mutt/1.4.1i-ja.1 cc: freebsd-fs@freebsd.org cc: sobomax@freebsd.org cc: freebsd-i18n@freebsd.org Subject: Re: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Sep 2003 12:25:10 -0000 Hi, On Fri, Sep 26, 2003 at 05:30:55PM +0700, Boris Popov wrote: > *_iconv.ko modules aren't strictly necessary and at some point > they could be integrated into corresponding fs modules. libiconv.ko module > isn't that large to significantly bloat install floppies. I don't like this idea, because this means GENERIC kernel has libiconv.ko. > I think yes. In addition, it is a good candidate for MFC into RELENG_4. I think there is a difficulty problem to MFC into RELENG_4. Since DYNAMICROOT is unavailable with RELENG_4, mount_cd9660 will not work w/o /usr. Maybe some knobs should be made to switch dynamic/static linking mount_cd9660/mount_msdosfs/mount_ntfs, and default is statically linked. A patch for RELENG_4 is here: (fjoe's fix should be feeded back, but not yet.) http://www.ryu16.org/FreeBSD/kiconv/kiconv-4_stable-20030911.diff Regards, - R. Imura