From owner-freebsd-bugbusters@FreeBSD.ORG Thu Apr 29 07:36:26 2004 Return-Path: Delivered-To: freebsd-bugbusters@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C3D6516A4CE for ; Thu, 29 Apr 2004 07:36:26 -0700 (PDT) Received: from shaft.techsupport.co.uk (shaft.techsupport.co.uk [212.250.77.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 851D243D2D for ; Thu, 29 Apr 2004 07:36:26 -0700 (PDT) (envelope-from setantae@submonkey.net) Received: from cpc2-cdif3-6-0-cust204.cdif.cable.ntl.com ([81.103.67.204] helo=shrike.submonkey.net ident=mailnull) by shaft.techsupport.co.uk with esmtp (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.31; FreeBSD) id 1BJCeH-000MsF-47 for freebsd-bugbusters@freebsd.org; Thu, 29 Apr 2004 15:36:25 +0100 Received: from setantae by shrike.submonkey.net with local (Exim 4.32; FreeBSD) id 1BJCeF-000IjQ-79 for freebsd-bugbusters@freebsd.org; Thu, 29 Apr 2004 15:36:23 +0100 Date: Thu, 29 Apr 2004 15:36:23 +0100 From: Ceri Davies To: freebsd-bugbusters Message-ID: <20040429143623.GM10877@submonkey.net> References: <20040414073119.GC1544@isis.wad.cz> <20040414103655.GN465@submonkey.net> <20040421093315.GC1051@isis.wad.cz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Re2uCLPLNzqOLVJA" Content-Disposition: inline In-Reply-To: <20040421093315.GC1051@isis.wad.cz> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.4i Sender: Ceri Davies Subject: Re: per-user send-pr defaults: ~/.send-pr.rc? X-BeenThere: freebsd-bugbusters@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Coordination of the Problem Report handling effort. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2004 14:36:26 -0000 --Re2uCLPLNzqOLVJA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 21, 2004 at 11:33:15AM +0200, Roman Neuhauser wrote: > # ceri@FreeBSD.org / 2004-04-14 11:36:55 +0100: > > On Wed, Apr 14, 2004 at 09:31:19AM +0200, Roman Neuhauser wrote: > > > Would a patch for send-pr adding support for defaults handling using > > > an rc file be welcome? If so, should I target send-pr as is in our tr= ee, > > > the one from the 4.0 tarball, or upstream cvs? > >=20 > > I'd certainly be interested in looking at it. At the moment my plan to > > upgrade is entirely {hub,www,freefall}.FreeBSD.org based - there seems > > to be no pressing need to upgrade the distributed send-pr, so I'd target > > the in-tree send-pr. If it should turn out that a client-side upgrade > > is worth the effort then we can bring the patches forward (I had to do > > the same for our local edit-pr hacks). >=20 > I've used the attached patch to submit some PRs (65668 - 65680), and > it was a relief. > =20 > It's not commitable as-is (e. g. note -s/-S are swapped), I'd just > like to know whether I'm on the right track. Roman, Apologies for the delay in responding - I meant to get to this much sooner. I'm out of the country for a couple of weeks as of tomorrow so any further replies will be delayed accordingly - I won't have any email access while I'm there. This looks really good so far to me. I'd recommend at first look that the file be renamed .send-pr.conf (or just .send-pr), and perhaps an option to ignore it would be useful too (I think most commands use -f for that, which is already taken). I'm slightly uncomfortable with allowing users to specify a default priority and severity, but those fields are becoming useless anyway so this may not be too much of an issue - I need to think about that a bit. There's also a bit of churn in the variable names, but if this is necessary for clarity (which looks the case) then it's a necessary evil. Thanks again for working on this. Ceri --=20 --Re2uCLPLNzqOLVJA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAkRLmocfcwTS3JF8RAjtYAJ4p2MKx3rxkbSjFiIHIThJXcOBxQgCfb0no bEb3kW3GrlgZSZ0pdOebx+0= =wuuO -----END PGP SIGNATURE----- --Re2uCLPLNzqOLVJA--