From owner-freebsd-bugbusters@FreeBSD.ORG Mon Oct 25 14:03:57 2004 Return-Path: Delivered-To: freebsd-bugbusters@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3438B16A4CE for ; Mon, 25 Oct 2004 14:03:57 +0000 (GMT) Received: from kfep07.dion.ne.jp (kfep07.dion.ne.jp [203.181.105.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4897D43D48 for ; Mon, 25 Oct 2004 14:03:55 +0000 (GMT) (envelope-from kunihiro.kusano@k4.dion.ne.jp) Received: from k4.dion.ne.jp ([210.255.17.76]) by kfep07.dion.ne.jp with ESMTP id <20041025140352694.VDLI@kfep07.dion.ne.jp> for ; Mon, 25 Oct 2004 23:03:52 +0900 Message-ID: <417D07C6.2070607@k4.dion.ne.jp> Date: Mon, 25 Oct 2004 23:03:50 +0900 From: Kunihiro Kusano User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:0.9.8) Gecko/20020312 X-Accept-Language: ja, en-us MIME-Version: 1.0 To: bugbusters@FreeBSD.org Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subject: A problem of directory X-BeenThere: freebsd-bugbusters@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Coordination of the Problem Report handling effort. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Oct 2004 14:03:57 -0000 >Submitter-Id: current-users >Originator: Kunihiro Kusano >Organization: no >Confidential: no >synopsis: A problem of directory >Severity: non-critical >Priority: medium >Category: kern >Class: change-request >Release: FreeBSD 4.5-RELEASE-p2+ i386 >Environment: System: FreeBSD catherine 4.5-RELEASE-p2+ FreeBSD 4.5-RELEASE-p2+ #105: Tue Oct 19 17:08;43 JST 2004 kusano@catherine:/usr/src/compile/CATHERINE i386 machine: IBM Think Pad 2635-9aj >Description: See below "How-To-Repeat. In this case, "." and "../x" are identical. I thought that as "rmdir ." returns "Invalid argument", "rmdir ../x" also returns the same error message. You know /bin/rmdir depends on rmdir(2). So this is a problem of system call. I read a part of code for rmdir() function which is in the /sys/kern/vfs_syscalls.c. And I found that the program compares "struct vnode pointer". One is for result directory, the other is for its parent directory. When only command line argument is "rmdir .", these two values can be identical. This is not enough. Struct proc has current directory vnode pointer. ^^^^^^ ^^^^^^^ ^^^^^ ^^^^^^ I think program should use this value. See below a.patch. >How-To-Repeat: $ mkdir x $ cd x $ rmdir . rmdir: .: Invalid argument $ rmdir ../x $ /bin/pwd pwd: .: No such file or directory $ >Fix: --- a.patch begins here --- --- org/vfs_syscalls.c Tue Jan 8 05:47:34 2002 +++ vfs_syscalls.c Tue Oct 19 17:05:41 2004 @@ -2784,9 +2784,10 @@ rmdir(p, uap) syscallarg(char *)path; } */ *uap; { - register struct vnode *vp; + register struct vnode *vp, *cvp; int error; struct nameidata nd; + struct filedesc *fdp; bwillwrite(); NDINIT(&nd, DELETE, LOCKPARENT | LOCKLEAF, UIO_USERSPACE, @@ -2798,10 +2799,13 @@ rmdir(p, uap) error = ENOTDIR; goto out; } + + fdp = p->p_fd; + cvp = fdp->fd_cdir; /* current directory vnode ptr */ /* * No rmdir "." please. */ - if ( nd.ni_dvp == vp) { + if ( cvp == vp) { error = EINVAL; goto out; } --- a.patch ends here --- From owner-freebsd-bugbusters@FreeBSD.ORG Mon Oct 25 14:22:50 2004 Return-Path: Delivered-To: freebsd-bugbusters@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE26416A4CE for ; Mon, 25 Oct 2004 14:22:50 +0000 (GMT) Received: from pittgoth.com (14.zlnp1.xdsl.nauticom.net [209.195.149.111]) by mx1.FreeBSD.org (Postfix) with ESMTP id 745AD43D1F for ; Mon, 25 Oct 2004 14:22:50 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from localhost (64-144-75-99.client.dsl.net [64.144.75.99]) (authenticated bits=0) by pittgoth.com (8.12.10/8.12.10) with ESMTP id i9PEMnex074749 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 25 Oct 2004 10:22:49 -0400 (EDT) (envelope-from trhodes@FreeBSD.org) Date: Mon, 25 Oct 2004 10:23:35 -0400 From: Tom Rhodes To: Kunihiro Kusano Message-ID: <20041025102335.13692ea8@localhost> In-Reply-To: <417D07C6.2070607@k4.dion.ne.jp> References: <417D07C6.2070607@k4.dion.ne.jp> X-Mailer: Sylpheed-Claws 0.9.12b (GTK+ 1.2.10; i386-portbld-freebsd5.3) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit cc: bugbusters@FreeBSD.org Subject: Re: A problem of directory X-BeenThere: freebsd-bugbusters@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Coordination of the Problem Report handling effort. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Oct 2004 14:22:51 -0000 On Mon, 25 Oct 2004 23:03:50 +0900 Kunihiro Kusano wrote: [SNIP]: PR and patch. I'll look at this since I have a few minutes. :) -- Tom Rhodes From owner-freebsd-bugbusters@FreeBSD.ORG Wed Oct 27 17:49:37 2004 Return-Path: Delivered-To: freebsd-bugbusters@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FA2016A4CE for ; Wed, 27 Oct 2004 17:49:37 +0000 (GMT) Received: from mail.cpinternet.com (mail.cpinternet.com [209.240.224.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7FA043D49 for ; Wed, 27 Oct 2004 17:49:36 +0000 (GMT) (envelope-from jcmalc@cpinternet.com) X-Node: 4 Received: from cpinternet.com (modem0214-cp-tnt-mpls2.cpinternet.com [64.61.211.214]) by mail.cpinternet.com (8.12.10/8.12.10) with ESMTP id i9RHnZ6O020152 for ; Wed, 27 Oct 2004 12:49:35 -0500 (CDT) Message-ID: <417FDFD9.4080003@cpinternet.com> Date: Wed, 27 Oct 2004 13:50:17 -0400 From: john User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031107 Debian/1.5-3 X-Accept-Language: en MIME-Version: 1.0 To: bugbusters@FreeBSD.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Web page failure X-BeenThere: freebsd-bugbusters@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Coordination of the Problem Report handling effort. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2004 17:49:37 -0000 Hi, I just spent an hour composing a bug report on your web page. If the image that I am supposed to enter is P74MJPQW, THEN YOUR WEB PAGE DOESN'T WORK. Trust me - I am not a robot robot robot robot robot robot robot robot From owner-freebsd-bugbusters@FreeBSD.ORG Wed Oct 27 18:59:49 2004 Return-Path: Delivered-To: freebsd-bugbusters@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D3BD916A4CE for ; Wed, 27 Oct 2004 18:59:49 +0000 (GMT) Received: from mail.cpinternet.com (mail.cpinternet.com [209.240.224.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 836ED43D5C for ; Wed, 27 Oct 2004 18:59:49 +0000 (GMT) (envelope-from jcmalc@cpinternet.com) X-Node: 4 Received: from cpinternet.com (modem0106-cp-tnt-mpls2.cpinternet.com [64.61.211.106]) by mail.cpinternet.com (8.12.10/8.12.10) with ESMTP id i9RIxl6O022629 for ; Wed, 27 Oct 2004 13:59:48 -0500 (CDT) Message-ID: <417FF04E.6050501@cpinternet.com> Date: Wed, 27 Oct 2004 15:00:30 -0400 From: john User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031107 Debian/1.5-3 X-Accept-Language: en MIME-Version: 1.0 To: bugbusters@FreeBSD.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: XFree86 server crash. X-BeenThere: freebsd-bugbusters@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Coordination of the Problem Report handling effort. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2004 18:59:50 -0000 ENVIRONMENT. Compaq Presario sr1053wm. I can't provide log files at this point because freebsd works badly on my machine. DESCRIPTION --------------- I have installed freebsd 5.2.1 about 20 times with various options on my machine. The result is always the same. The XFree 86 server always crashes. THIS IS PROBABLY NOT DUE TO BAD DISKS. I have tried disks from two different sources, including the boxed set. I have also tried version 5.0. XFREE86 DOES WORK ON MY HARDWARE - THE PROBLEM IS YOUR INSTALLER (probably). I also have Openbsd and Suse on the same machine. XFree86 works on both of these systems. (note I am using partition magic) I HAVE HAD SEVERAL PROBLEMS INSTALLING XFREE86. 1.. Xconfig reports and error and asks me if I want to try again. 2 ncursses doesn't work either. It didn't write a config file at all the last time I checked. 3. The script version wrote a config file but xfree86 still crashed. 4. Leaving x alone doesn't work either. 5. The computer hangs when I chose the "exit install" option. (unplugging first doesn't help). 6 I have tried several different configuration settings including all of the different ones suggested by the Compaq support staff.( they don't really know what is in their boxes ) All of the configuration setting that I have tried have been on the conservative side. I have reviewed a lot of posts on various forums concerning difficulties installing XFree86 with Freebsd on Compaq computers. I haven't seen very many posts about solutions. WHERE ARE THE LOG FILES? My installation of Freebsd doesn't work well enough for me to send them. Programs like Mozilla don;t work. (probably needs x).. I have not been able to get FreeBSD to mount a foreign file system so I can't use Windows or Linux to send the logs. HOW TO REPEAT THE PROBLEM Try to install FreeBSD on a Presario sr1053wm. Good luck! About ready to give up John .. .. From owner-freebsd-bugbusters@FreeBSD.ORG Wed Oct 27 19:20:37 2004 Return-Path: Delivered-To: freebsd-bugbusters@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7FAD916A4CE for ; Wed, 27 Oct 2004 19:20:37 +0000 (GMT) Received: from smtp.rdsnet.ro (smtp.rdsnet.ro [62.231.74.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8CAD243D53 for ; Wed, 27 Oct 2004 19:20:36 +0000 (GMT) (envelope-from itetcu@people.tecnik93.com) Received: (qmail 32637 invoked by uid 89); 27 Oct 2004 19:20:38 -0000 Received: from unknown (HELO rdsnet.ro) (62.231.74.131) by 0 with SMTP; 27 Oct 2004 19:20:38 -0000 Received: (qmail 22967 invoked from network); 27 Oct 2004 19:20:34 -0000 Received: from unknown (HELO buh.cameradicommercio.ro) (82.76.1.117) by mail.rdsnet.ro with SMTP; 27 Oct 2004 19:20:34 -0000 Received: from it.buh.cameradicommercio.ro (it.buh.cameradicommercio.ro [192.168.0.10]) by buh.cameradicommercio.ro (Postfix) with ESMTP id F193C60B0; Wed, 27 Oct 2004 22:20:32 +0300 (EEST) Received: from it.buh.cameradicommercio.ro (localhost.buh.tecnik93.com [127.0.0.1]) by it.buh.cameradicommercio.ro (Postfix) with SMTP id 87C40234; Wed, 27 Oct 2004 22:20:42 +0300 (EEST) Date: Wed, 27 Oct 2004 22:20:39 +0300 From: Ion-Mihai Tetcu To: john Message-ID: <20041027222039.47420f38@it.buh.cameradicommercio.ro> In-Reply-To: <417FF04E.6050501@cpinternet.com> References: <417FF04E.6050501@cpinternet.com> X-Mailer: Sylpheed-Claws 0.9.12b (GTK+ 1.2.10; i386-portbld-freebsd5.3) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit cc: bugbusters@FreeBSD.org Subject: Re: XFree86 server crash. X-BeenThere: freebsd-bugbusters@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Coordination of the Problem Report handling effort. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2004 19:20:37 -0000 On Wed, 27 Oct 2004 15:00:30 -0400 john wrote: > ENVIRONMENT. > > Compaq Presario sr1053wm. > > I can't provide log files at this point because freebsd works badly on > my machine. Please post this to the appropriate list, which is question@freebsd.org -- IOnut Unregistered ;) FreeBSD "user"