Date: Fri, 23 Jul 2004 00:15:51 +0300 From: Ville =?ISO-8859-1?Q?Skytt=E4?= <scop@FreeBSD.org> To: "'freebsd-cvsweb@freebsd.org'" <freebsd-cvsweb@freebsd.org> Subject: Re: Bug in sub hrefquote Message-ID: <1090530951.29086.371.camel@bobcat.mine.nu> In-Reply-To: <762A181C0D966E459A2EB3B810142C7707B2196B@nmrusdunsx12.nmrlan.net> References: <762A181C0D966E459A2EB3B810142C7707B2196B@nmrusdunsx12.nmrlan.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2004-07-16 at 18:09, Quezada, Alex wrote: Hi, and sorry for the delay, > this routine is incorrectly translating spaces into +: > y/ /+/; > > This is wrong, and if you have directories in your path that include > spaces, the link you get is wrong. I have replaced this with a substitution > of '%20', which works as expected. That change should be ok (see also below), but could you provide an exact reproducer for this? Ie. name of the directory, the resulting link, where in the CVSweb UI it occurs, and the browser + version. I've spotted a few places where hrefquote() is clearly used in a wrong way (<a name="..." in dir listings), but I haven't noticed any problems with whitespace in paths for a long time. > There's probably other ways to do this (like urlencode), but this > seems simpler. I would like to get rid of hrefquote() altogether. Will look into it soonish. > PS: I figured out my broken binary problem. BEA Weblogic's cgi interpreter > was the culprit. I installed Apache, and all is peachy now. What OS do you use? It is possible that we need to add a few binmode() calls here and there.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1090530951.29086.371.camel>