From owner-freebsd-net@FreeBSD.ORG Sun Nov 21 17:12:11 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4BCF16A4CF for ; Sun, 21 Nov 2004 17:12:11 +0000 (GMT) Received: from outbound0.sv.meer.net (outbound0.sv.meer.net [205.217.152.13]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7384C43D31 for ; Sun, 21 Nov 2004 17:12:11 +0000 (GMT) (envelope-from gnn@neville-neil.com) Received: from mail.meer.net (mail.meer.net [209.157.152.14]) iALHC9wN074973; Sun, 21 Nov 2004 09:12:10 -0800 (PST) (envelope-from gnn@neville-neil.com) Received: from minion.local.neville-neil.com (h229.neville-neil.com [209.157.133.229] (may be forged)) by mail.meer.net (8.12.10/8.12.10/meer) with ESMTP id iALHC9nH051079; Sun, 21 Nov 2004 09:12:09 -0800 (PST) (envelope-from gnn@neville-neil.com) Date: Sun, 21 Nov 2004 09:12:10 -0800 Message-ID: From: gnn@freebsd.org To: James In-Reply-To: <20041115222310.GA93130@scylla.towardex.com> References: <20041115222310.GA93130@scylla.towardex.com> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.5 Emacs/21.2 (powerpc-apple-darwin) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII cc: freebsd-net@freebsd.org Subject: Re: Initial review request for IPv6 Fast Forwarding and IP6STEALTH X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Nov 2004 17:12:11 -0000 At Mon, 15 Nov 2004 17:23:10 -0500, James wrote: > Attached is initial code for ip6_fastforward() that I'm proposing > for FreeBSD 5.x. This code was written for an internally modified > FreeBSD 4.9, however in the next few weeks, I will be porting this > into FreeBSD 5.3 tree and submit a final draft for review back to > freebsd-net here. However in the mean time, if any experienced folks > can feed any suggestions or critics for this code, I will gladily > appreciate your input and make necessary changes for the final > draft. > > We have been testing this code on a core router in occaid.org IPv6 > network for a few days now, and so far we've had zero problems and > so far is running very stable. Hi James, A few comments for you: Issues found: ip6_forward_rt is a global value that is used without locking ASSERTS still include the old name apc_inet6_fastfwd Stats are updated directly but I don't think we lock those yet. Don't define M2MMAX in line, put it outside with a comment. If the mbuf is already freed then how can we safely use m->m_pkthdr.rcvif? at line 223 Improve the indenting in the commented case at line 298. I understand the idea, and it's good, but it's a bit confusing to read. Remove #if code at 553 which is specific to the APC product. Later, George