From owner-freebsd-standards@FreeBSD.ORG Mon Sep 20 00:51:53 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1DDE716A4CE; Mon, 20 Sep 2004 00:51:53 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.177]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC23043D2F; Mon, 20 Sep 2004 00:51:52 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.155] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1C9CPH-0007iV-00; Mon, 20 Sep 2004 02:51:51 +0200 Received: from [217.227.156.246] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1C9CPH-0007Jw-00; Mon, 20 Sep 2004 02:51:51 +0200 From: Max Laier To: freebsd-arch@freebsd.org Date: Mon, 20 Sep 2004 02:50:40 +0200 User-Agent: KMail/1.7 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3113315.aWgR6iTeVk"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200409200250.49518.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: freebsd-hackers@freebsd.org cc: freebsd-standards@freebsd.org cc: freebsd-net@freebsd.org Subject: Global (non _KERNEL) place for sockaddr_union? X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2004 00:51:53 -0000 --nextPart3113315.aWgR6iTeVk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi, http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/71836 is the symptom. Now= I am=20 looking for a clean solution to it. What is needed is an include file that= =20 defines union sockaddr_union in a way that is useable from kernel and=20 userland. Historically it seems that this union first apeared in context of= =20 ipsec within the kernel. pf has adopted it, but uses it in the userland as= =20 well. I am sure that it can be usefull in a lot of places that have to deal= =20 with/store different address formats. My question now is, what would be a good place to define this? Are there an= y=20 fromal standarts that might define it already? (Couldn't find anything) Is= =20 there anything else that I must consider? At some point I though netinet/in.h might be a good place, but that'd requi= re=20 inclusion of sys/socket.h, which certainly is not a good solution. Opinions? Ideas? > #include > #include >=20 > union sockaddr_union { > struct sockaddr sa; > struct sockaddr_in sin; > struct sockaddr_in6 sin6; > struct sockaddr_storage __su_pad; /* maybe not a bad idea */ > }; =46reeBSD: netipsec/keydb.h, line 43 (_KERNEL) NetBSD: netipsec/keydb.h, line 46 (_KERNEL) OpenBSD: netinet/ip_ipsp.h, line 50 (non _KERNEL) KAME: net/pfvar.h, line 699 (non _KERNEL, ! __OpenBSD__) Linux: Doesn't seem to have it. Or has it under a different name? =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart3113315.aWgR6iTeVk Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBTilpXyyEoT62BG0RAmpDAJ9IVZ1sV1GhHYyMXaAIx2hBZ9Bo1QCfaIYn XH9Pl7Y8VcPBVr9kgjdhvc8= =QH3p -----END PGP SIGNATURE----- --nextPart3113315.aWgR6iTeVk-- From owner-freebsd-standards@FreeBSD.ORG Mon Sep 20 02:26:56 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D3C5116A4CE; Mon, 20 Sep 2004 02:26:56 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id B033843D2F; Mon, 20 Sep 2004 02:26:56 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i8K2SqAq027289; Sun, 19 Sep 2004 19:28:52 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i8K2SqpY027288; Sun, 19 Sep 2004 19:28:52 -0700 Date: Sun, 19 Sep 2004 19:28:52 -0700 From: Brooks Davis To: Max Laier Message-ID: <20040920022852.GA21281@odin.ac.hmc.edu> References: <200409200250.49518.max@love2party.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3MwIy2ne0vdjdPXF" Content-Disposition: inline In-Reply-To: <200409200250.49518.max@love2party.net> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=3.0 required=8.0 tests=SUSPICIOUS_RECIPS autolearn=no version=2.63 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: freebsd-hackers@freebsd.org cc: freebsd-net@freebsd.org cc: freebsd-standards@freebsd.org cc: freebsd-arch@freebsd.org Subject: Re: Global (non _KERNEL) place for sockaddr_union? X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2004 02:26:57 -0000 --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 20, 2004 at 02:50:40AM +0200, Max Laier wrote: > Hi, >=20 > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/71836 is the symptom. N= ow I am=20 > looking for a clean solution to it. What is needed is an include file tha= t=20 > defines union sockaddr_union in a way that is useable from kernel and=20 > userland. Historically it seems that this union first apeared in context = of=20 > ipsec within the kernel. pf has adopted it, but uses it in the userland a= s=20 > well. I am sure that it can be usefull in a lot of places that have to de= al=20 > with/store different address formats. >=20 > My question now is, what would be a good place to define this? Are there = any=20 > fromal standarts that might define it already? (Couldn't find anything) I= s=20 > there anything else that I must consider? >=20 > At some point I though netinet/in.h might be a good place, but that'd req= uire=20 > inclusion of sys/socket.h, which certainly is not a good solution. >=20 > Opinions? Ideas? >=20 > > #include > > #include > >=20 > > union sockaddr_union { > > struct sockaddr sa; > > struct sockaddr_in sin; > > struct sockaddr_in6 sin6; > > struct sockaddr_storage __su_pad; /* maybe not a bad idea */ > > }; I don't see an elegant solution. Stuffing it off in its own file may be the best thing if you're going to use it. Overall, I'd say it's bad idea that PF be better off without. It appears to save a few casts, but nothing worth the pain of generalizing the declaration. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --3MwIy2ne0vdjdPXF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBTkBkXY6L6fI4GtQRAkN5AJ4vSbihrYfqgTxU4MrgF4vNXFYr6ACeJ0Uh aeCoFMPqPGpWIYLi5DDzc4c= =WKvT -----END PGP SIGNATURE----- --3MwIy2ne0vdjdPXF-- From owner-freebsd-standards@FreeBSD.ORG Mon Sep 20 03:40:54 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 784C016A4CE; Mon, 20 Sep 2004 03:40:54 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.185]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE95643D54; Mon, 20 Sep 2004 03:40:53 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.179] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1C9F2o-0002Lr-00; Mon, 20 Sep 2004 05:40:50 +0200 Received: from [217.227.156.246] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1C9F2n-0007vz-00; Mon, 20 Sep 2004 05:40:50 +0200 From: Max Laier To: Brooks Davis Date: Mon, 20 Sep 2004 05:39:38 +0200 User-Agent: KMail/1.7 References: <200409200250.49518.max@love2party.net> <20040920022852.GA21281@odin.ac.hmc.edu> In-Reply-To: <20040920022852.GA21281@odin.ac.hmc.edu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3010729.AUYAN69HKC"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200409200539.48073.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: freebsd-hackers@freebsd.org cc: freebsd-net@freebsd.org cc: freebsd-standards@freebsd.org cc: freebsd-arch@freebsd.org Subject: Re: Global (non _KERNEL) place for sockaddr_union? X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2004 03:40:54 -0000 --nextPart3010729.AUYAN69HKC Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 20 September 2004 04:28, Brooks Davis wrote: > On Mon, Sep 20, 2004 at 02:50:40AM +0200, Max Laier wrote: > > Hi, > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/71836 is the symptom.= Now > > I am looking for a clean solution to it. What is needed is an include > > file that defines union sockaddr_union in a way that is useable from > > kernel and userland. Historically it seems that this union first apeared > > in context of ipsec within the kernel. pf has adopted it, but uses it in > > the userland as well. I am sure that it can be usefull in a lot of plac= es > > that have to deal with/store different address formats. > > > > My question now is, what would be a good place to define this? Are there > > any fromal standarts that might define it already? (Couldn't find > > anything) Is there anything else that I must consider? > > > > At some point I though netinet/in.h might be a good place, but that'd > > require inclusion of sys/socket.h, which certainly is not a good > > solution. > > > > Opinions? Ideas? > > > > > #include > > > #include > > > > > > union sockaddr_union { > > > struct sockaddr sa; > > > struct sockaddr_in sin; > > > struct sockaddr_in6 sin6; > > > struct sockaddr_storage __su_pad; /* maybe not a bad idea */ > > > }; > > I don't see an elegant solution. Stuffing it off in its own file may > be the best thing if you're going to use it. Overall, I'd say it's bad > idea that PF be better off without. It appears to save a few casts, > but nothing worth the pain of generalizing the declaration. > > -- Brooks =46irst of all, the padding is bogus as sin6 is big enough. Especially sinc= e one=20 point here is to save space. I was a bit confused there, sorry. Especially= =20 since this is an important point: In pf this union is uses to - for example= -=20 store address information in tables. It allows to store IPv4 and IPv6=20 addresses in the same table without creating overhead in the memory footpri= nt=20 or having to deal with different objects for every address type. The fewer= =20 casts are just an additional benefit. Maybe you are right and a new header is the easiest way out. Moving this ou= t=20 of under _KERNEL would require all includer of netipsec/keydb.h to include= =20 sys/socket.h and netinet/in.h. As I was saying, I don't have a good idea=20 either. The only thing that came to my mind just now is to add a protecting= =20 define and #ifdef around the two places that define it. But I have no idea= =20 how clean (in terms of style) such a solution is. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart3010729.AUYAN69HKC Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBTlEEXyyEoT62BG0RAr9TAJ42DYbnMVi2Cgj9TICFk7YXCo0YFgCfQdyg ORVq+9JZZUGaOxLFYXMf82U= =cYA3 -----END PGP SIGNATURE----- --nextPart3010729.AUYAN69HKC-- From owner-freebsd-standards@FreeBSD.ORG Mon Sep 20 04:22:20 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2F71A16A4CE; Mon, 20 Sep 2004 04:22:20 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5D7F43D39; Mon, 20 Sep 2004 04:22:19 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i8K4OHI6010640; Sun, 19 Sep 2004 21:24:17 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i8K4OHbu010635; Sun, 19 Sep 2004 21:24:17 -0700 Date: Sun, 19 Sep 2004 21:24:17 -0700 From: Brooks Davis To: Max Laier Message-ID: <20040920042417.GB9460@odin.ac.hmc.edu> References: <200409200250.49518.max@love2party.net> <20040920022852.GA21281@odin.ac.hmc.edu> <200409200539.48073.max@love2party.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GRPZ8SYKNexpdSJ7" Content-Disposition: inline In-Reply-To: <200409200539.48073.max@love2party.net> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: freebsd-hackers@freebsd.org cc: freebsd-net@freebsd.org cc: freebsd-standards@freebsd.org cc: freebsd-arch@freebsd.org Subject: Re: Global (non _KERNEL) place for sockaddr_union? X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2004 04:22:20 -0000 --GRPZ8SYKNexpdSJ7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 20, 2004 at 05:39:38AM +0200, Max Laier wrote: > On Monday 20 September 2004 04:28, Brooks Davis wrote: > > On Mon, Sep 20, 2004 at 02:50:40AM +0200, Max Laier wrote: > > > Hi, > > > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/71836 is the sympto= m. Now > > > I am looking for a clean solution to it. What is needed is an include > > > file that defines union sockaddr_union in a way that is useable from > > > kernel and userland. Historically it seems that this union first apea= red > > > in context of ipsec within the kernel. pf has adopted it, but uses it= in > > > the userland as well. I am sure that it can be usefull in a lot of pl= aces > > > that have to deal with/store different address formats. > > > > > > My question now is, what would be a good place to define this? Are th= ere > > > any fromal standarts that might define it already? (Couldn't find > > > anything) Is there anything else that I must consider? > > > > > > At some point I though netinet/in.h might be a good place, but that'd > > > require inclusion of sys/socket.h, which certainly is not a good > > > solution. > > > > > > Opinions? Ideas? > > > > > > > #include > > > > #include > > > > > > > > union sockaddr_union { > > > > struct sockaddr sa; > > > > struct sockaddr_in sin; > > > > struct sockaddr_in6 sin6; > > > > struct sockaddr_storage __su_pad; /* maybe not a bad idea */ > > > > }; > > > > I don't see an elegant solution. Stuffing it off in its own file may > > be the best thing if you're going to use it. Overall, I'd say it's bad > > idea that PF be better off without. It appears to save a few casts, > > but nothing worth the pain of generalizing the declaration. >=20 > First of all, the padding is bogus as sin6 is big enough. Especially sinc= e one=20 > point here is to save space. I was a bit confused there, sorry. Especiall= y=20 > since this is an important point: In pf this union is uses to - for examp= le -=20 > store address information in tables. It allows to store IPv4 and IPv6=20 > addresses in the same table without creating overhead in the memory footp= rint=20 > or having to deal with different objects for every address type. The fewe= r=20 > casts are just an additional benefit. > > Maybe you are right and a new header is the easiest way out. Moving this = out=20 > of under _KERNEL would require all includer of netipsec/keydb.h to includ= e=20 > sys/socket.h and netinet/in.h. As I was saying, I don't have a good idea= =20 > either. The only thing that came to my mind just now is to add a protecti= ng=20 > define and #ifdef around the two places that define it. But I have no ide= a=20 > how clean (in terms of style) such a solution is. If it's primairly for well defined storage, why not remove the sa and put it in netinet/in.h? If you're just looking for the family and length, it doesn't matter if you access it as .sa, .sin, or .sin6. You might have to name it something else which could be problematic for portability, but it might be worth the pain if you could push it back to OpenBSD. -- Brooks -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --GRPZ8SYKNexpdSJ7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBTltvXY6L6fI4GtQRApA7AKC4bgZvLAzTVpzVhHVfXEwQd+JWtACgrBrG wdii84flDaNUq1uEym+j+Ms= =P8eR -----END PGP SIGNATURE----- --GRPZ8SYKNexpdSJ7-- From owner-freebsd-standards@FreeBSD.ORG Mon Sep 20 11:02:25 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0A7B16A52B for ; Mon, 20 Sep 2004 11:02:25 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B51F843D41 for ; Mon, 20 Sep 2004 11:02:25 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8KB2P3F001526 for ; Mon, 20 Sep 2004 11:02:25 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8KB2NWE001518 for freebsd-standards@freebsd.org; Mon, 20 Sep 2004 11:02:23 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 20 Sep 2004 11:02:23 GMT Message-Id: <200409201102.i8KB2NWE001518@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: freebsd-standards@FreeBSD.org Subject: Current problem reports assigned to you X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2004 11:02:26 -0000 Current FreeBSD problem reports Critical problems Serious problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2001/03/05] bin/25542 standards /bin/sh: null char in quoted string p [2002/02/25] standards/35307standards standard include files are not standard c o [2002/12/13] kern/46239 standards posix semaphore implementation errors o [2003/04/21] standards/51209standards [PATCH] add a64l()/l64a/l64a_r functions p [2003/06/05] standards/52972standards /bin/sh arithmetic not POSIX compliant o [2003/06/18] kern/53447 standards poll(2) semantics differ from susV3/POSIX o [2003/07/12] standards/54410standards one-true-awk not POSIX compliant (no exte o [2003/09/15] standards/56906standards Several math(3) functions fail to set err o [2004/01/01] standards/60772standards _Bool and bool should be unsigned 9 problems total. Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- f [1995/01/11] kern/105 standards Distributed libm (msun) has non-standard o [2000/09/24] bin/21519 standards sys/dir.h should be deprecated some more o [2001/01/16] bin/24390 standards Replacing old dir-symlinks when using /bi s [2001/01/24] standards/24590standards timezone function not compatible witn Sin s [2001/06/18] kern/28260 standards UIO_MAXIOV needs to be made public p [2001/11/20] standards/32126standards getopt(3) not Unix-98 conformant o [2002/02/27] misc/35381 standards incorrect floating-point display of large s [2002/03/19] standards/36076standards Implementation of POSIX fuser command o [2002/06/14] standards/39256standards [v]snprintf aren't POSIX-conformant for s o [2002/07/09] kern/40378 standards stdlib.h gives needless warnings with -an p [2002/08/12] standards/41576standards POSIX compliance of ln(1) o [2002/10/23] standards/44425standards getcwd() succeeds even if current dir has o [2002/12/09] standards/46119standards Priority problems for SCHED_OTHER using p o [2002/12/23] standards/46504standards Warnings in headers o [2003/06/22] standards/53613standards FreeBSD doesn't define EPROTO o [2003/07/24] standards/54809standards pcvt deficits o [2003/07/25] standards/54833standards more pcvt deficits o [2003/07/25] standards/54839standards pcvt deficits o [2003/07/31] standards/55112standards glob.h, glob_t's gl_pathc should be "size o [2003/09/05] standards/56476standards cd9660 unicode support simple hack o [2003/10/29] standards/58676standards grantpt(3) alters storage used by ptsname p [2003/12/26] standards/60597standards FreeBSD's /usr/include lacks of cpio.h s [2004/02/14] standards/62858standards malloc(0) not C99 compliant p [2004/02/21] standards/63173standards Patch to add getopt_long_only(3) to libc o [2004/03/29] kern/64875 standards [patch] add a system call: fdatasync() o [2004/05/07] standards/66357standards make POSIX conformance problem ('sh -e' & o [2004/05/11] standards/66531standards _gettemp uses a far smaller set of filena o [2004/08/22] standards/70813standards [PATCH] ls not Posix compliant o [2004/08/26] docs/70985 standards [patch] sh(1): incomplete documentation o 29 problems total. From owner-freebsd-standards@FreeBSD.ORG Mon Sep 20 19:11:46 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 51E1816A4CE; Mon, 20 Sep 2004 19:11:46 +0000 (GMT) Received: from mail.dt.e-technik.uni-dortmund.de (krusty.dt.e-technik.Uni-Dortmund.DE [129.217.163.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3313F43D5A; Mon, 20 Sep 2004 19:11:45 +0000 (GMT) (envelope-from ma@dt.e-technik.uni-dortmund.de) Received: from localhost (localhost [127.0.0.1])28AF13F69E; Mon, 20 Sep 2004 21:11:44 +0200 (CEST) Received: from mail.dt.e-technik.uni-dortmund.de ([127.0.0.1]) by localhost (krusty [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 30720-01-5; Mon, 20 Sep 2004 21:11:44 +0200 (CEST) Received: from m2a2.dyndns.org (p508EEE7E.dip.t-dialin.net [80.142.238.126]) D02EC3F69A; Mon, 20 Sep 2004 21:11:40 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by merlin.emma.line.org (Postfix) with ESMTP id C2BF1D1F96; Mon, 20 Sep 2004 21:11:38 +0200 (CEST) Received: from merlin.emma.line.org ([127.0.0.1]) by localhost (m2a2.dyndns.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 01064-03-2; Mon, 20 Sep 2004 21:11:38 +0200 (CEST) Received: by merlin.emma.line.org (Postfix, from userid 500) id 3391CC9FB3; Mon, 20 Sep 2004 21:11:38 +0200 (CEST) To: freebsd-current@freebsd.org, re@freebsd.org, freebsd-hackers@freebsd.org, freebsd-standards@freebsd.org Mail-Followup-To: freebsd-standards@freebsd.org From: Matthias Andree Date: Mon, 20 Sep 2004 21:11:38 +0200 Message-ID: User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new at dt.e-technik.uni-dortmund.de Subject: PATCH: fix bogus "unset" abort in /bin/sh (been pending for TWO YEARS) X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: freebsd-standards@freebsd.org List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2004 19:11:46 -0000 [WARNING: Reply-To and Mail-Followup-To set to funnel the discussion.] Greetings, FreeBSD's /bin/sh has a long-standing bug that causes premature abort of a script when set -e is set and a nonexistant variable is unset. This violates IEEE Std 1003.1 and harms portability of scripts to FreeBSD. http://www.opengroup.org/onlinepubs/009695399/utilities/unset.html Either test of these must print "good" else the shell is b0rked: /bin/sh -c 'set -e ; BONK= ; unset BONK ; unset BONK ; echo good' /bin/sh -c 'set -e ; f() { :; } ; unset -f f ; unset -f f ; echo good' After merging the patch below and MFC'ing, please close standards/45738. This patch (against 5.3-BETA) fixes the problems for me (yes I know it is not very helpful without more context but I can't paste half the files here for the mailing list): --- src/bin/sh/exec.c.orig Thu Apr 15 05:08:30 2004 +++ src/bin/sh/exec.c Sat Sep 18 13:16:34 2004 @@ -701,7 +701,7 @@ delete_cmd_entry(); return (0); } - return (1); + return (0); } /* --- src/bin/sh/var.c.orig Thu Apr 15 05:08:31 2004 +++ src/bin/sh/var.c Sat Sep 18 13:16:34 2004 @@ -761,7 +761,7 @@ } } - return (1); + return (0); } -- Matthias Andree Encrypted mail welcome: my GnuPG key ID is 0x052E7D95 (PGP/MIME preferred) From owner-freebsd-standards@FreeBSD.ORG Tue Sep 21 10:02:25 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D87CF16A4CE; Tue, 21 Sep 2004 10:02:25 +0000 (GMT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9051743D4C; Tue, 21 Sep 2004 10:02:25 +0000 (GMT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id B72AD653B5; Tue, 21 Sep 2004 11:02:24 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 22905-02; Tue, 21 Sep 2004 11:02:24 +0100 (BST) Received: from empiric.dek.spc.org (adsl-67-121-95-65.dsl.snfc21.pacbell.net [67.121.95.65]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id A265E65213; Tue, 21 Sep 2004 11:02:23 +0100 (BST) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id 0F3BA6455; Tue, 21 Sep 2004 03:02:20 -0700 (PDT) Date: Tue, 21 Sep 2004 03:02:20 -0700 From: Bruce M Simpson To: Max Laier Message-ID: <20040921100220.GC842@empiric.icir.org> Mail-Followup-To: Max Laier , freebsd-arch@freebsd.org, freebsd-hackers@freebsd.org, freebsd-standards@freebsd.org, freebsd-net@freebsd.org References: <200409200250.49518.max@love2party.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FCuugMFkClbJLl1L" Content-Disposition: inline In-Reply-To: <200409200250.49518.max@love2party.net> cc: freebsd-hackers@freebsd.org cc: freebsd-net@freebsd.org cc: freebsd-standards@freebsd.org cc: freebsd-arch@freebsd.org Subject: Re: Global (non _KERNEL) place for sockaddr_union? X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2004 10:02:26 -0000 --FCuugMFkClbJLl1L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 20, 2004 at 02:50:40AM +0200, Max Laier wrote: > My question now is, what would be a good place to define this? Are there = any=20 > fromal standarts that might define it already? (Couldn't find anything) I= s=20 > there anything else that I must consider? I think Brooks' recommendation is sound and should probably be followed as it's fairly close to my original recommendation to you in private. The problem is that the definition of the union depends on what you wish to use it for, and which address families are visible to the application or kernel module which is using the definition. You may find that such a definition has to have conditionalized members. This is usually not a problem so long as they are all the same size. And a sockaddr union embedded in a struct probably should have a member with type 'struct sockaddr_storage' if it's to support all address families in future, although this commits more storage in the enclosing struct and may waste space in some cases. As you point out, you cannot do this in pf, as it defeats the intent of keeping larger members out of the table in the first place, and the union is there to make some casts go away. If it's any consolation, I'm going through very similar pain with XORP's new firewall manager right now with respect to address families (and templatized C++ classes). Regards, BMS --FCuugMFkClbJLl1L Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Comment: '' iD8DBQFBT/wsueUpAYYNtTsRAnCbAKCZrI2SsVz6q/Uu0loceoJREQc/zACggs6O e98ZL0h6Z/r8TWtUkJ8P+30= =buDH -----END PGP SIGNATURE----- --FCuugMFkClbJLl1L-- From owner-freebsd-standards@FreeBSD.ORG Tue Sep 21 16:12:10 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9A32916A4D1; Tue, 21 Sep 2004 16:12:10 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 65E9343D1F; Tue, 21 Sep 2004 16:12:06 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i8LGEKR4023672; Tue, 21 Sep 2004 09:14:21 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i8LGEKi4023671; Tue, 21 Sep 2004 09:14:20 -0700 Date: Tue, 21 Sep 2004 09:14:20 -0700 From: Brooks Davis To: Max Laier , freebsd-arch@freebsd.org, freebsd-hackers@freebsd.org, freebsd-standards@freebsd.org, freebsd-net@freebsd.org Message-ID: <20040921161420.GA17290@odin.ac.hmc.edu> References: <200409200250.49518.max@love2party.net> <20040921100220.GC842@empiric.icir.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k+w/mQv8wyuph6w0" Content-Disposition: inline In-Reply-To: <20040921100220.GC842@empiric.icir.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=3.0 required=8.0 tests=SUSPICIOUS_RECIPS autolearn=no version=2.63 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Subject: Re: Global (non _KERNEL) place for sockaddr_union? X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2004 16:12:10 -0000 --k+w/mQv8wyuph6w0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 21, 2004 at 03:02:20AM -0700, Bruce M Simpson wrote: > On Mon, Sep 20, 2004 at 02:50:40AM +0200, Max Laier wrote: > > My question now is, what would be a good place to define this? Are ther= e any=20 > > fromal standarts that might define it already? (Couldn't find anything)= Is=20 > > there anything else that I must consider? >=20 > I think Brooks' recommendation is sound and should probably be followed > as it's fairly close to my original recommendation to you in private. >=20 > The problem is that the definition of the union depends on what you wish > to use it for, and which address families are visible to the application > or kernel module which is using the definition. The real problem may be that KAME mistakenly gave sockaddr_union a general name when it isn't and such a type would be hell to actually work with. A custom union that does exactly what pf needs may be the best approach. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --k+w/mQv8wyuph6w0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBUFNcXY6L6fI4GtQRAmqKAKDCDS6aW5tOLvwi5OE7cOny3qj6xgCfRBDr 0QaUauCEGn2Ij3DHL0SBPwg= =5V32 -----END PGP SIGNATURE----- --k+w/mQv8wyuph6w0-- From owner-freebsd-standards@FreeBSD.ORG Tue Sep 21 17:09:29 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EA5416A4CE; Tue, 21 Sep 2004 17:09:29 +0000 (GMT) Received: from cheer.mahoroba.org (gw4.mahoroba.org [218.45.22.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 77B2043D3F; Tue, 21 Sep 2004 17:09:28 +0000 (GMT) (envelope-from ume@FreeBSD.org) Received: from lyrics.mahoroba.org (IDENT:9kBdVg6hWs9CTiaZ5lSoJ4DoJ3SyWu3oLpw0YErULbFeN7uGd/W9zJAlIDdVvliL@lyrics.mahoroba.org [IPv6:3ffe:501:185b:8010:280:88ff:fe03:4841]) (user=ume mech=CRAM-MD5 bits=0)i8LH9CAr031165 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 22 Sep 2004 02:09:20 +0900 (JST) (envelope-from ume@FreeBSD.org) Date: Wed, 22 Sep 2004 02:09:11 +0900 Message-ID: From: Hajimu UMEMOTO To: Brooks Davis In-Reply-To: <20040921161420.GA17290@odin.ac.hmc.edu> References: <200409200250.49518.max@love2party.net> <20040921100220.GC842@empiric.icir.org> <20040921161420.GA17290@odin.ac.hmc.edu> User-Agent: xcite1.38> Wanderlust/2.11.3 (Wonderwall) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/21.3 (i386--freebsd) MULE/5.0 (SAKAKI) X-Operating-System: FreeBSD 5.3-BETA5 MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by amavisd-new X-Virus-Status: Clean X-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=2.64 X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on cheer.mahoroba.org cc: Max Laier cc: freebsd-net@freebsd.org cc: freebsd-standards@freebsd.org cc: freebsd-hackers@freebsd.org cc: freebsd-arch@freebsd.org Subject: Re: Global (non _KERNEL) place for sockaddr_union? X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2004 17:09:29 -0000 Hi, >>>>> On Tue, 21 Sep 2004 09:14:20 -0700 >>>>> Brooks Davis said: brooks> The real problem may be that KAME mistakenly gave sockaddr_union a brooks> general name when it isn't and such a type would be hell to actually brooks> work with. A custom union that does exactly what pf needs may be the brooks> best approach. I believe KAME doesn't use non standard struct such as sock_union. Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/ From owner-freebsd-standards@FreeBSD.ORG Tue Sep 21 17:13:24 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE7CD16A4CE; Tue, 21 Sep 2004 17:13:24 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7BCDF43D31; Tue, 21 Sep 2004 17:13:24 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i8LHFdOe031312; Tue, 21 Sep 2004 10:15:39 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i8LHFd0h031311; Tue, 21 Sep 2004 10:15:39 -0700 Date: Tue, 21 Sep 2004 10:15:39 -0700 From: Brooks Davis To: Hajimu UMEMOTO Message-ID: <20040921171539.GA30996@odin.ac.hmc.edu> References: <200409200250.49518.max@love2party.net> <20040921100220.GC842@empiric.icir.org> <20040921161420.GA17290@odin.ac.hmc.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sdtB3X0nJg68CQEu" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: freebsd-net@FreeBSD.org cc: freebsd-arch@FreeBSD.org cc: freebsd-hackers@FreeBSD.org cc: Max Laier cc: freebsd-standards@FreeBSD.org Subject: Re: Global (non _KERNEL) place for sockaddr_union? X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2004 17:13:25 -0000 --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 22, 2004 at 02:09:11AM +0900, Hajimu UMEMOTO wrote: > Hi, >=20 > >>>>> On Tue, 21 Sep 2004 09:14:20 -0700 > >>>>> Brooks Davis said: >=20 > brooks> The real problem may be that KAME mistakenly gave sockaddr_union a > brooks> general name when it isn't and such a type would be hell to actua= lly > brooks> work with. A custom union that does exactly what pf needs may be= the > brooks> best approach. >=20 > I believe KAME doesn't use non standard struct such as sock_union. Oops, you are correct, it's part of fastipsec, not KAME. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --sdtB3X0nJg68CQEu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBUGG7XY6L6fI4GtQRAmuhAJ9RmMTuSRuAs9YIhRNJ55xq0k1KgwCfY/y3 zqiSVO6mzuxWu2C7MB4GKi8= =lDSM -----END PGP SIGNATURE----- --sdtB3X0nJg68CQEu-- From owner-freebsd-standards@FreeBSD.ORG Tue Sep 21 18:26:15 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE05B16A4CE for ; Tue, 21 Sep 2004 18:26:15 +0000 (GMT) Received: from mail.vicor-nb.com (bigwoop.vicor-nb.com [208.206.78.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id C1D1E43D46 for ; Tue, 21 Sep 2004 18:26:14 +0000 (GMT) (envelope-from julian@elischer.org) Received: from elischer.org (julian.vicor-nb.com [208.206.78.97]) by mail.vicor-nb.com (Postfix) with ESMTP id 53D507A3D2 for ; Tue, 21 Sep 2004 11:26:14 -0700 (PDT) Message-ID: <41507246.2050809@elischer.org> Date: Tue, 21 Sep 2004 11:26:14 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030516 X-Accept-Language: en, hu MIME-Version: 1.0 To: freebsd-standards@freebsd.org References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: PATCH: fix bogus "unset" abort in /bin/sh (been pending for TWO YEARS) X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2004 18:26:15 -0000 anyone handling this? Matthias Andree wrote: >[WARNING: Reply-To and Mail-Followup-To set to funnel the discussion.] > >Greetings, > >FreeBSD's /bin/sh has a long-standing bug that causes premature abort of >a script when set -e is set and a nonexistant variable is unset. > >This violates IEEE Std 1003.1 and harms portability of scripts to FreeBSD. >http://www.opengroup.org/onlinepubs/009695399/utilities/unset.html > >Either test of these must print "good" else the shell is b0rked: > >/bin/sh -c 'set -e ; BONK= ; unset BONK ; unset BONK ; echo good' >/bin/sh -c 'set -e ; f() { :; } ; unset -f f ; unset -f f ; echo good' > >After merging the patch below and MFC'ing, please close standards/45738. > >This patch (against 5.3-BETA) fixes the problems for me (yes I know it >is not very helpful without more context but I can't paste half the >files here for the mailing list): > >--- src/bin/sh/exec.c.orig Thu Apr 15 05:08:30 2004 >+++ src/bin/sh/exec.c Sat Sep 18 13:16:34 2004 >@@ -701,7 +701,7 @@ > delete_cmd_entry(); > return (0); > } >- return (1); >+ return (0); > } > > /* >--- src/bin/sh/var.c.orig Thu Apr 15 05:08:31 2004 >+++ src/bin/sh/var.c Sat Sep 18 13:16:34 2004 >@@ -761,7 +761,7 @@ > } > } > >- return (1); >+ return (0); > } > > > From owner-freebsd-standards@FreeBSD.ORG Thu Sep 23 00:15:20 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6643B16A4CF; Thu, 23 Sep 2004 00:15:07 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C60443D49; Thu, 23 Sep 2004 00:15:07 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.209] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1CAHGM-0004lG-00; Thu, 23 Sep 2004 02:15:06 +0200 Received: from [217.83.8.169] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1CAHGM-0007dJ-00; Thu, 23 Sep 2004 02:15:06 +0200 From: Max Laier To: freebsd-arch@freebsd.org Date: Thu, 23 Sep 2004 02:14:00 +0200 User-Agent: KMail/1.7 References: <200409200250.49518.max@love2party.net> In-Reply-To: <200409200250.49518.max@love2party.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2497037.U2RBP6rdQP"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200409230214.08477.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: freebsd-hackers@freebsd.org cc: freebsd-standards@freebsd.org cc: freebsd-net@freebsd.org Subject: Re: Global (non _KERNEL) place for sockaddr_union? X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2004 00:15:20 -0000 --nextPart2497037.U2RBP6rdQP Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 20 September 2004 02:50, Max Laier wrote: > Hi, > > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/71836 is the symptom. N= ow I > am looking for a clean solution to it. What is needed is an include file > that defines union sockaddr_union in a way that is useable from kernel and > userland. Historically it seems that this union first apeared in context = of > ipsec within the kernel. pf has adopted it, but uses it in the userland as > well. I am sure that it can be usefull in a lot of places that have to de= al > with/store different address formats. > > My question now is, what would be a good place to define this? Are there > any fromal standarts that might define it already? (Couldn't find anythin= g) > Is there anything else that I must consider? > > At some point I though netinet/in.h might be a good place, but that'd > require inclusion of sys/socket.h, which certainly is not a good solution. > > Opinions? Ideas? As no real solution has come up and we couldn't agree what to do with it=20 either, I'll resort to an easy hack:=20 http://people.freebsd.org/~mlaier/sockaddr_union.fix.diff This will fix the issue and not create new problems. With the small excepti= on=20 for userland programs that try to include before=20 and make use of sockaddr_union. Those programs do not exist,= =20 however, and have been broken before. Any objections? [ I know it's ugly already. ] =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart2497037.U2RBP6rdQP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBUhVQXyyEoT62BG0RAoYnAJ9SzMK7ZPV3NYZ36DYJlj53KFNqjgCfQ2YO J3R7FE7EG21pdyvCi0DM6aA= =I8lU -----END PGP SIGNATURE----- --nextPart2497037.U2RBP6rdQP-- From owner-freebsd-standards@FreeBSD.ORG Thu Sep 23 06:19:46 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B094B16A4CE; Thu, 23 Sep 2004 06:19:46 +0000 (GMT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B62E43D2F; Thu, 23 Sep 2004 06:19:46 +0000 (GMT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 63E04651F7; Thu, 23 Sep 2004 07:19:44 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 56232-03; Thu, 23 Sep 2004 07:19:43 +0100 (BST) Received: from empiric.dek.spc.org (adsl-64-171-185-240.dsl.snfc21.pacbell.net [64.171.185.240]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id 49AA5651F4; Thu, 23 Sep 2004 07:19:43 +0100 (BST) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id 4E70F63D3; Wed, 22 Sep 2004 23:19:40 -0700 (PDT) Date: Wed, 22 Sep 2004 23:19:40 -0700 From: Bruce M Simpson To: Max Laier Message-ID: <20040923061940.GA870@empiric.icir.org> Mail-Followup-To: Max Laier , freebsd-arch@freebsd.org, freebsd-hackers@freebsd.org, freebsd-standards@freebsd.org, freebsd-net@freebsd.org References: <200409200250.49518.max@love2party.net> <200409230214.08477.max@love2party.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline In-Reply-To: <200409230214.08477.max@love2party.net> cc: freebsd-hackers@freebsd.org cc: freebsd-net@freebsd.org cc: freebsd-standards@freebsd.org cc: freebsd-arch@freebsd.org Subject: Re: Global (non _KERNEL) place for sockaddr_union? X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2004 06:19:46 -0000 --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings earthmen, On Thu, Sep 23, 2004 at 02:14:00AM +0200, Max Laier wrote: > As no real solution has come up and we couldn't agree what to do with it= =20 > either, I'll resort to an easy hack:=20 > http://people.freebsd.org/~mlaier/sockaddr_union.fix.diff =2E.. > Any objections? [ I know it's ugly already. ] Looks fine to me; I agree that this workaround is not ideal but it is acceptable given the circumstances. Regards, BMS --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Comment: '' iD8DBQFBUmr7ueUpAYYNtTsRAk91AJ4/PL+dXh5v+8ne91fS0n/RGtZlkgCfavC8 I38NJmMOCN9m0ZgiR8+uQX8= =mtHb -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh-- From owner-freebsd-standards@FreeBSD.ORG Thu Sep 23 15:51:42 2004 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8568016A4CF; Thu, 23 Sep 2004 15:51:42 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 634A443D46; Thu, 23 Sep 2004 15:51:42 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from freefall.freebsd.org (keramida@localhost [127.0.0.1]) i8NFpgqx009460; Thu, 23 Sep 2004 15:51:42 GMT (envelope-from keramida@freefall.freebsd.org) Received: (from keramida@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8NFpgX7009456; Thu, 23 Sep 2004 15:51:42 GMT (envelope-from keramida) Date: Thu, 23 Sep 2004 15:51:42 GMT From: Giorgos Keramidas Message-Id: <200409231551.i8NFpgX7009456@freefall.freebsd.org> To: keramida@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-standards@FreeBSD.org Subject: Re: bin/72006: floating point formating in non-C locales X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2004 15:51:42 -0000 Synopsis: floating point formating in non-C locales Responsible-Changed-From-To: freebsd-bugs->freebsd-standards Responsible-Changed-By: keramida Responsible-Changed-When: Thu Sep 23 15:49:27 GMT 2004 Responsible-Changed-Why: This is probably something that a -standards guru can resolve. http://www.freebsd.org/cgi/query-pr.cgi?pr=72006 From owner-freebsd-standards@FreeBSD.ORG Thu Sep 23 16:00:43 2004 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 83A2116A4CF for ; Thu, 23 Sep 2004 16:00:43 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D208843D5C for ; Thu, 23 Sep 2004 16:00:38 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i8NG0cBj010396 for ; Thu, 23 Sep 2004 16:00:38 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8NG0cDt010395; Thu, 23 Sep 2004 16:00:38 GMT (envelope-from gnats) Date: Thu, 23 Sep 2004 16:00:38 GMT Message-Id: <200409231600.i8NG0cDt010395@freefall.freebsd.org> To: freebsd-standards@FreeBSD.org From: Giorgos Keramidas Subject: Re: bin/72006: floating point formating in non-C locales X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Giorgos Keramidas List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2004 16:00:43 -0000 The following reply was made to PR bin/72006; it has been noted by GNATS. From: Giorgos Keramidas To: Mikhail Teterin Cc: bug-followup@freebsd.org Subject: Re: bin/72006: floating point formating in non-C locales Date: Thu, 23 Sep 2004 18:48:32 +0300 On 2004-09-23 11:28, Mikhail Teterin wrote: > >$ printf "%'.02f\n" 12345678 > >12,345,678.00 > > Are we planning to ever _recognize_ such numbers? [...] We need a > judgment of some standards guru. True. Thanks for being patient with my (probably too pedantic) comments :-) From owner-freebsd-standards@FreeBSD.ORG Sat Sep 25 08:40:26 2004 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C44A16A4CE for ; Sat, 25 Sep 2004 08:40:26 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1911D43D3F for ; Sat, 25 Sep 2004 08:40:26 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i8P8ePK2093100 for ; Sat, 25 Sep 2004 08:40:25 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8P8ePN3093099; Sat, 25 Sep 2004 08:40:25 GMT (envelope-from gnats) Resent-Date: Sat, 25 Sep 2004 08:40:25 GMT Resent-Message-Id: <200409250840.i8P8ePN3093099@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-standards@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Peter Wullinger Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08BFB16A4CE for ; Sat, 25 Sep 2004 08:39:16 +0000 (GMT) Received: from mout2.freenet.de (mout2.freenet.de [194.97.50.155]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E19743D31 for ; Sat, 25 Sep 2004 08:39:15 +0000 (GMT) (envelope-from dhke@freenet.de) Received: from [194.97.50.135] (helo=mx2.freenet.de) by mout2.freenet.de with esmtpa (Exim 4.42) id 1CB85K-0003NP-Or for FreeBSD-gnats-submit@freebsd.org; Sat, 25 Sep 2004 10:39:14 +0200 Received: from p5091dacf.dip.t-dialin.net ([80.145.218.207] helo=peter.home.wul) by mx2.freenet.de with esmtpa (ID dhke@freenet.de) (Exim 4.42 #1) id 1CB85K-0002ld-9I for FreeBSD-gnats-submit@freebsd.org; Sat, 25 Sep 2004 10:39:14 +0200 Received: (qmail 4128 invoked by uid 1001); 25 Sep 2004 08:39:11 -0000 Message-Id: <20040925083911.4127.qmail@peter.home.wul> Date: 25 Sep 2004 08:39:11 -0000 From: Peter Wullinger To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: standards/72076: [patch] German locales use old %d.%m.%y date format instead of newer ISO date X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Peter Wullinger List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Sep 2004 08:40:26 -0000 >Number: 72076 >Category: standards >Synopsis: [patch] German locales use old %d.%m.%y date format instead of newer ISO date >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-standards >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Sep 25 08:40:25 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Peter Wullinger >Release: FreeBSD 5.2-CURRENT i386 >Organization: - >Environment: Any FreeBSD System with locale support. >Description: DIN 5008 (German norm for text processing) defines the old date format (%d.%m.%Y) to be obsolete and to be used only, if unambigous. In international communications the new format (%Y-%m-%d) is now required and FreeBSD should respect this. References: - DIN 5008 - EN 28 601 - ISO 8601 Thanks to Oliver Lietz for bringing this to my attention. >How-To-Repeat: % export LC_ALL=de_DE.UTF-8 % date +%x or % export LC_ALL=de_DE.ISO8859-1 % date +%x >Fix: Apply the following patch and "make && make install" in /usr/share/timedef --- /usr/src/share/timedef/de_DE.UTF-8.src.orig Sat Sep 25 09:16:23 2004 +++ /usr/src/share/timedef/de_DE.UTF-8.src Sat Sep 25 09:11:59 2004 @@ -59,7 +59,7 @@ # # x_fmt # -%d.%m.%Y +%Y-%m-%d # # c_fmt # --- /usr/src/share/timedef/de_DE.ISO8859-1.src.orig Sat Sep 25 09:16:23 2004 +++ /usr/src/share/timedef/de_DE.ISO8859-1.src Sat Sep 25 09:11:53 2004 @@ -59,7 +59,7 @@ # # x_fmt # -%d.%m.%Y +%Y-%m-%d # # c_fmt # Port patch for misc/utf8locale pending. >Release-Note: >Audit-Trail: >Unformatted: