From owner-freebsd-standards@FreeBSD.ORG Mon Nov 1 11:02:13 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 15A9916A4D6 for ; Mon, 1 Nov 2004 11:02:13 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id F0DF343D49 for ; Mon, 1 Nov 2004 11:02:12 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1B2C0N094329 for ; Mon, 1 Nov 2004 11:02:12 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iA1B2CA6094323 for freebsd-standards@freebsd.org; Mon, 1 Nov 2004 11:02:12 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 1 Nov 2004 11:02:12 GMT Message-Id: <200411011102.iA1B2CA6094323@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: freebsd-standards@FreeBSD.org Subject: Current problem reports assigned to you X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 11:02:13 -0000 Current FreeBSD problem reports Critical problems Serious problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2001/03/05] bin/25542 standards /bin/sh: null char in quoted string p [2002/02/25] standards/35307standards standard include files are not standard c o [2002/12/13] kern/46239 standards posix semaphore implementation errors o [2003/04/21] standards/51209standards [PATCH] add a64l()/l64a/l64a_r functions p [2003/06/05] standards/52972standards /bin/sh arithmetic not POSIX compliant o [2003/06/18] kern/53447 standards poll(2) semantics differ from susV3/POSIX o [2003/07/12] standards/54410standards one-true-awk not POSIX compliant (no exte o [2003/09/15] standards/56906standards Several math(3) functions fail to set err o [2004/01/01] standards/60772standards _Bool and bool should be unsigned 9 problems total. Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- f [1995/01/11] kern/105 standards Distributed libm (msun) has non-standard o [2000/09/24] bin/21519 standards sys/dir.h should be deprecated some more o [2001/01/16] bin/24390 standards Replacing old dir-symlinks when using /bi s [2001/01/24] standards/24590standards timezone function not compatible witn Sin s [2001/06/18] kern/28260 standards UIO_MAXIOV needs to be made public p [2001/11/20] standards/32126standards getopt(3) not Unix-98 conformant o [2002/02/27] misc/35381 standards incorrect floating-point display of large s [2002/03/19] standards/36076standards Implementation of POSIX fuser command o [2002/06/14] standards/39256standards [v]snprintf aren't POSIX-conformant for s o [2002/07/09] kern/40378 standards stdlib.h gives needless warnings with -an p [2002/08/12] standards/41576standards POSIX compliance of ln(1) o [2002/10/23] standards/44425standards getcwd() succeeds even if current dir has o [2002/12/09] standards/46119standards Priority problems for SCHED_OTHER using p o [2002/12/23] standards/46504standards Warnings in headers o [2003/06/22] standards/53613standards FreeBSD doesn't define EPROTO o [2003/07/24] standards/54809standards pcvt deficits o [2003/07/25] standards/54833standards more pcvt deficits o [2003/07/25] standards/54839standards pcvt deficits o [2003/07/31] standards/55112standards glob.h, glob_t's gl_pathc should be "size o [2003/09/05] standards/56476standards cd9660 unicode support simple hack o [2003/10/29] standards/58676standards grantpt(3) alters storage used by ptsname p [2003/12/26] standards/60597standards FreeBSD's /usr/include lacks of cpio.h s [2004/02/14] standards/62858standards malloc(0) not C99 compliant p [2004/02/21] standards/63173standards Patch to add getopt_long_only(3) to libc o [2004/03/29] kern/64875 standards [patch] add a system call: fdatasync() o [2004/05/07] standards/66357standards make POSIX conformance problem ('sh -e' & o [2004/05/11] standards/66531standards _gettemp uses a far smaller set of filena o [2004/08/22] standards/70813standards [PATCH] ls not Posix compliant o [2004/08/26] docs/70985 standards [patch] sh(1): incomplete documentation o o [2004/09/22] standards/72006standards floating point formating in non-C locales 30 problems total. From owner-freebsd-standards@FreeBSD.ORG Mon Nov 1 22:19:56 2004 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9AAED16A4CE; Mon, 1 Nov 2004 22:19:56 +0000 (GMT) Received: from dan.emsphone.com (dan.emsphone.com [199.67.51.101]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4CC4243D3F; Mon, 1 Nov 2004 22:19:56 +0000 (GMT) (envelope-from dan@dan.emsphone.com) Received: (from dan@localhost) by dan.emsphone.com (8.12.11/8.13.1) id iA1MJtI0083241; Mon, 1 Nov 2004 16:19:55 -0600 (CST) (envelope-from dan) Date: Mon, 1 Nov 2004 16:19:55 -0600 From: Dan Nelson To: Mark Linimon Message-ID: <20041101221955.GA55850@dan.emsphone.com> References: <200410300716.i9U7Gi48004946@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410300716.i9U7Gi48004946@freefall.freebsd.org> X-OS: FreeBSD 5.3-BETA7 X-message-flag: Outlook Error User-Agent: Mutt/1.5.6i cc: freebsd-bugs@FreeBSD.org cc: freebsd-standards@FreeBSD.org Subject: Re: kern/72394: [PATCH] syslog is not thread-safe X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 22:19:56 -0000 In the last episode (Oct 30), Mark Linimon said: > Synopsis: [PATCH] syslog is not thread-safe > > Responsible-Changed-From-To: freebsd-standards->freebsd-bugs > Responsible-Changed-By: linimon > Responsible-Changed-When: Sat Oct 30 07:15:43 GMT 2004 > Responsible-Changed-Why: > This sounds more like a kern bug than something for the standards folks. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=72394 Well, I guess the "unp_connect" message is a kernel bug, but that's a very minor part of the PR, and is marked with an "XXXRW: Temporary debugging printf" comment anyway. The larger issue is the lack of locking in the syslog family of libc functions, which POSIX requires. -- Dan Nelson dnelson@allantgroup.com From owner-freebsd-standards@FreeBSD.ORG Wed Nov 3 21:10:41 2004 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7C0B16A4FE for ; Wed, 3 Nov 2004 21:10:41 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C2E443D1F for ; Wed, 3 Nov 2004 21:10:33 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) iA3LAXNS052985 for ; Wed, 3 Nov 2004 21:10:33 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iA3LAXFv052984; Wed, 3 Nov 2004 21:10:33 GMT (envelope-from gnats) Resent-Date: Wed, 3 Nov 2004 21:10:33 GMT Resent-Message-Id: <200411032110.iA3LAXFv052984@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-standards@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jilles Tjoelker Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E441716A4CE for ; Wed, 3 Nov 2004 21:02:30 +0000 (GMT) Received: from mailhost.stack.nl (vaak.stack.nl [131.155.140.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29AEA43D6B for ; Wed, 3 Nov 2004 21:02:30 +0000 (GMT) (envelope-from jilles@stack.nl) Received: from hammer.stack.nl (hammer.stack.nl [IPv6:2001:610:1108:5010::153]) by mailhost.stack.nl (Postfix) with ESMTP id 3B88F1F066 for ; Wed, 3 Nov 2004 22:02:29 +0100 (CET) Received: by hammer.stack.nl (Postfix, from userid 1677) id 19704619F; Wed, 3 Nov 2004 22:02:29 +0100 (CET) Message-Id: <20041103210229.19704619F@hammer.stack.nl> Date: Wed, 3 Nov 2004 22:02:29 +0100 (CET) From: Jilles Tjoelker To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: standards/73500: 'set +o' in /bin/sh does not include unset options X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jilles Tjoelker List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 21:10:41 -0000 >Number: 73500 >Category: standards >Synopsis: 'set +o' in /bin/sh does not include unset options >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-standards >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Nov 03 21:10:33 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Jilles Tjoelker >Release: FreeBSD 6.0-CURRENT amd64 >Organization: MCGV Stack >Environment: System: FreeBSD hammer.stack.nl 6.0-CURRENT FreeBSD 6.0-CURRENT #3: Mon Nov 1 18:36:46 CET 2004 marcolz@hammer.stack.nl:/usr/obj/usr/src/sys/HAMMER amd64 >Description: The output of 'set +o' only contains options that are set, not options that are unset. IEEE Std 1003.1-2001 says: +o Write the current option settings to standard output in a format that is suitable for reinput to the shell as commands that achieve the same options settings. Obviously, the current implementation does not achieve that. The man page says this which might be interpreted both ways: If +o is used without an argument, the current option settings are output in a format suitable for re-input into the shell. >How-To-Repeat: jilles@hammer /home/jilles$ /bin/sh $ set +o set -o interactive -o monitor -o stdin $ A more complicated real-world-like demonstration is the following shell script: #!/bin/sh settings="$(set +o)" set -o noglob eval "$settings" echo /* It outputs '/*' with the current version of /bin/sh. The script works correctly (shows all files directly under /) with bash-2.05b.007_2 and Solaris 10 /usr/xpg4/bin/sh. >Fix: Include unset options with '+o' in the output of 'set +o'. Patch included. --- options.c.diff begins here --- --- src/bin/sh/options.c.orig Wed Apr 7 10:12:45 2004 +++ src/bin/sh/options.c Wed Nov 3 18:42:45 2004 @@ -196,7 +196,7 @@ STATIC void minus_o(char *name, int val) { - int doneset, i; + int i; if (name == NULL) { if (val) { @@ -207,16 +207,11 @@ optlist[i].val ? "on" : "off"); } else { /* Output suitable for re-input to shell. */ - for (doneset = i = 0; i < NOPTS; i++) - if (optlist[i].val) { - if (!doneset) { - out1str("set"); - doneset = 1; - } - out1fmt(" -o %s", optlist[i].name); - } - if (doneset) - out1c('\n'); + out1str("set"); + for (i = 0; i < NOPTS; i++) + out1fmt(" %co %s", optlist[i].val ? '-' : '+', + optlist[i].name); + out1c('\n'); } } else { for (i = 0; i < NOPTS; i++) --- options.c.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: From owner-freebsd-standards@FreeBSD.ORG Thu Nov 4 08:46:27 2004 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CFF7816A4CE; Thu, 4 Nov 2004 08:46:27 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B018543D1D; Thu, 4 Nov 2004 08:46:27 +0000 (GMT) (envelope-from roam@FreeBSD.org) Received: from freefall.freebsd.org (roam@localhost [127.0.0.1]) iA48kRDV067556; Thu, 4 Nov 2004 08:46:27 GMT (envelope-from roam@freefall.freebsd.org) Received: (from roam@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iA48kR7f067552; Thu, 4 Nov 2004 08:46:27 GMT (envelope-from roam) Date: Thu, 4 Nov 2004 08:46:27 GMT From: Peter Pentchev Message-Id: <200411040846.iA48kR7f067552@freefall.freebsd.org> To: roam@FreeBSD.org, freebsd-standards@FreeBSD.org, tjr@FreeBSD.org Subject: Re: standards/73500: 'set +o' in /bin/sh does not include unset options X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 08:46:27 -0000 Synopsis: 'set +o' in /bin/sh does not include unset options Responsible-Changed-From-To: freebsd-standards->tjr Responsible-Changed-By: roam Responsible-Changed-When: Thu Nov 4 08:45:37 GMT 2004 Responsible-Changed-Why: Over to Tim J. Robbins, who implemented the current 'set +o' output in rev. 1.19 of options.c. http://www.freebsd.org/cgi/query-pr.cgi?pr=73500