Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Jan 2004 02:32:16 -0800 (PST)
From:      Juli Mallett <jmallett@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 45527 for review
Message-ID:  <200401181032.i0IAWGYx012758@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=45527

Change 45527 by jmallett@jmallett_oingo on 2004/01/18 02:31:59

	Cleanup attempts, etc.

Affected files ...

.. //depot/projects/mips/sys/mips/mips/exception.S#12 edit
.. //depot/projects/mips/sys/mips/mips/tlb.c#20 edit

Differences ...

==== //depot/projects/mips/sys/mips/mips/exception.S#12 (text+ko) ====

@@ -204,6 +204,7 @@
 	nop
 	nop
 	eret
+	.set at
 VEND(XTLBMissVector)
 
 /*

==== //depot/projects/mips/sys/mips/mips/tlb.c#20 (text+ko) ====

@@ -153,8 +153,8 @@
 	tlb_remove_pages(pmap, va, eva - va);
 }
 
-static void
-tlb_insert(vm_offset_t va, pt_entry_t pte0, pt_entry_t pte1)
+void
+tlb_update(vm_offset_t va, pt_entry_t pte0, pt_entry_t pte1)
 {
 	u_long ehi;
 	int i;
@@ -212,13 +212,6 @@
 		tlb_invalidate_one(va);
 }
 
-void
-tlb_update(vm_offset_t va, pt_entry_t pte0, pt_entry_t pte1)
-{
-	va &= ~PAGE_MASK;
-	tlb_insert(va, pte0, pte1);
-}
-
 /*
  * PTE was not dirty and is being written to.  XXX kernel only for now.
  */
@@ -238,19 +231,8 @@
 		panic("write to invalid page");
 	if (pte_ro(pte))
 		panic("write to ro page");
-
- 	/*
-	 * XXX I don't like these, but it looks like the fact of the
-	 * matter is that they happen, for example I have something in
-	 * front of me right now where the even side of the buffer is
-	 * dirty, and so is the odd side, but in the buffer, the left
-	 * side is marked, and there's some reason why a reload didn't
-	 * happen, so just let it go... let it go...
-	 */
-#if 0
 	if (pte_dirty(pte))
 		panic("dirty page caused a TLBMod");
-#endif
 
 	/*
 	 * Mark the page dirty.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200401181032.i0IAWGYx012758>