From owner-cvs-src@FreeBSD.ORG Sun May 28 01:24:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B278C16BA8E; Sun, 28 May 2006 01:08:53 +0000 (UTC) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7248543D46; Sun, 28 May 2006 01:08:53 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S17l81049613; Sun, 28 May 2006 01:07:47 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S17lFS049612; Sun, 28 May 2006 01:07:47 GMT (envelope-from iedowse) Message-Id: <200605280107.k4S17lFS049612@repoman.freebsd.org> From: Ian Dowse Date: Sun, 28 May 2006 01:07:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb uhci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 01:25:07 -0000 iedowse 2006-05-28 01:07:46 UTC FreeBSD src repository Modified files: sys/dev/usb uhci.c Log: Fix a harmless typo where the software pointer in the dummy QH for control transfers did not match the hardware pointer. Revision Changes Path 1.166 +1 -1 src/sys/dev/usb/uhci.c From owner-cvs-src@FreeBSD.ORG Sun May 28 01:37:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E60D16BABA; Sun, 28 May 2006 01:18:20 +0000 (UTC) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F29B043D48; Sun, 28 May 2006 01:18:19 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S1HD9A050025; Sun, 28 May 2006 01:17:13 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S1HDVZ050024; Sun, 28 May 2006 01:17:13 GMT (envelope-from iedowse) Message-Id: <200605280117.k4S1HDVZ050024@repoman.freebsd.org> From: Ian Dowse Date: Sun, 28 May 2006 01:17:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb uhci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 01:37:14 -0000 iedowse 2006-05-28 01:17:13 UTC FreeBSD src repository Modified files: sys/dev/usb uhci.c Log: NULL out ii->stdstart and ii->stdend when they are invalid. This is not necessary for correct operation but makes it clearer that freed transfer descriptors cannot be accessed. Revision Changes Path 1.167 +10 -1 src/sys/dev/usb/uhci.c From owner-cvs-src@FreeBSD.ORG Sun May 28 02:09:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E746916AB4C; Sun, 28 May 2006 02:04:26 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A82FC43D4C; Sun, 28 May 2006 02:04:20 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S23Dva053793; Sun, 28 May 2006 02:03:13 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S23DfP053792; Sun, 28 May 2006 02:03:13 GMT (envelope-from davidxu) Message-Id: <200605280203.k4S23DfP053792@repoman.freebsd.org> From: David Xu Date: Sun, 28 May 2006 02:03:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/include npx.h src/sys/i386/i386 vm_machdep.c src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 02:09:32 -0000 davidxu 2006-05-28 02:03:13 UTC FreeBSD src repository Modified files: sys/i386/include npx.h sys/i386/i386 vm_machdep.c sys/i386/isa npx.c Log: When creating a new thread, inherit floating-point environment from current thread, this is required by POSIX pthread_create document. Revision Changes Path 1.272 +1 -0 src/sys/i386/i386/vm_machdep.c 1.30 +4 -0 src/sys/i386/include/npx.h 1.167 +30 -0 src/sys/i386/isa/npx.c From owner-cvs-src@FreeBSD.ORG Sun May 28 02:14:13 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9CBC116AB97 for ; Sun, 28 May 2006 02:06:16 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.174]) by mx1.FreeBSD.org (Postfix) with ESMTP id B117C43D58 for ; Sun, 28 May 2006 02:06:09 +0000 (GMT) (envelope-from minimarmot@gmail.com) Received: by ug-out-1314.google.com with SMTP id m3so50091uge for ; Sat, 27 May 2006 19:06:08 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=od/cYLwbNHBdq5KMbFzFYWA1sbdxktlRp9dcSJJP0usXn/0FOs4DU+qnJs+iL9QFNUZaFsEbbEkItZiZRUO82KUdrn5aFgjWekIqHo+iCji8wGJwUqSjJSVG96vG7WNFU0CKKFG7vl+26gfjbMgxHg08avjyQh4awQ5cDysXO5c= Received: by 10.66.216.20 with SMTP id o20mr747212ugg; Sat, 27 May 2006 19:06:08 -0700 (PDT) Received: by 10.67.87.3 with HTTP; Sat, 27 May 2006 19:06:08 -0700 (PDT) Message-ID: <47d0403c0605271906r5a618490k750c85d5a148150@mail.gmail.com> Date: Sat, 27 May 2006 21:06:08 -0500 From: "Ben Kaduk" To: "Alexander Leidinger" In-Reply-To: <20060527190751.3628e119@Magellan.Leidinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20060527104539.1f4c0738@Magellan.Leidinger.net> <13817.1148720224@critter.freebsd.dk> <20060527123344.355119b8@Magellan.Leidinger.net> <47d0403c0605270827n665ccd5ved9ba0effccf248b@mail.gmail.com> <20060527190751.3628e119@Magellan.Leidinger.net> Cc: cvs-src@freebsd.org, Poul-Henning Kamp , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 02:14:23 -0000 On 5/27/06, Alexander Leidinger wrote: > Quoting "Ben Kaduk" (Sat, 27 May 2006 10:27:05 -05= 00): > > > > At http://www.leidinger.net/FreeBSD/doxygen_notreviewed.png I have a > > > screenshot of the the index page of the HTML documentation. It shows > > > the following text in a very prominent position: > > > ---snip--- > > > > I have a few comments about the wording of this disclaimer. > > > > > > > IMPORTANT: This API documentation may contain functions which are > > > either public or for internal use only. Since we have not reviewed > > > > Do you mean "not public" here? > > No. I want to say that we not only have public function there, but also > functions for internal use only. I don't know if this is needed. It's > also ok for me if someone changes this disclaimer completely. Probably the phrase "this API documentation may contain both functions which are public and functions that are for internal use only" will better express this sentiment. > [snip] > > Thanks for putting in the work to generate Doxygen documentation. I > > am just starting to read the kernel code, and I feel that the call > > graphs, etc. that it generates will be quite helpful. > > And the HTML version is even better to browse than the PDF version I > have on my website. > > Bye, > Alexander. > > -- > Selling GoodYear Eagle F1 235/40ZR18, 2x 4mm + 2x 5mm, ~150 EUR > you have to pick it up between Germany/Saarland and Luxembourg/Capellen > http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE= 7 > http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 7207713= 7 > That is true -- html is more friendly to switching back and forth. I think I will follow the discussion in this thread and perhaps make further suggestions to the disclaimer as necessary. -Ben Kaduk From owner-cvs-src@FreeBSD.ORG Sun May 28 02:16:53 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 718C716ABCA; Sun, 28 May 2006 02:12:57 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from mrout1-b.corp.dcn.yahoo.com (mrout1-b.corp.dcn.yahoo.com [216.109.112.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0212643D46; Sun, 28 May 2006 02:12:56 +0000 (GMT) (envelope-from gnn@neville-neil.com) Received: from traveling-laptop-140.corp.yahoo.com.neville-neil.com (proxy7.corp.yahoo.com [216.145.48.98]) by mrout1-b.corp.dcn.yahoo.com (8.13.6/8.13.4/y.out) with ESMTP id k4S2CPoe023035; Sat, 27 May 2006 19:12:26 -0700 (PDT) Date: Sun, 28 May 2006 11:12:19 +0900 Message-ID: From: gnn@freebsd.org To: Robert Watson In-Reply-To: <20060527200440.G79162@fledge.watson.org> References: <20060526204457.3e545e4f@Magellan.Leidinger.net> <11534.1148678206@critter.freebsd.dk> <20060527104539.1f4c0738@Magellan.Leidinger.net> <20060527200440.G79162@fledge.watson.org> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.0.50 (i386-apple-darwin8.5.1) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: cvs-src@freebsd.org, Poul-Henning Kamp , src-committers@freebsd.org, Alexander Leidinger , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 02:17:04 -0000 Am I allowed to call this a tempest in a teacup? There, I just have. While I think that there have been some very good points made both ways, I believe that since the documentation will be generated only by people who are using the system, and will not appear on line, or in a manual, that we do not need to worry about this. It is, IMHO, easier to go through and mark things up AFTER we have them visible and so visibility should be the first goal. Since there is, as far as I know, no other or better tool for this job I suggest we go with what we have and begin to mark things correctly now. Having everything by default internal, IMHO, leaves us just where we were before, lots of twisty little APIs all undocumented. My $0.02. Later, George From owner-cvs-src@FreeBSD.ORG Sun May 28 03:27:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C6D216B4E6 for ; Sun, 28 May 2006 03:27:38 +0000 (UTC) (envelope-from silby@silby.com) Received: from relay02.pair.com (relay02.pair.com [209.68.5.16]) by mx1.FreeBSD.org (Postfix) with SMTP id 8D46143D53 for ; Sun, 28 May 2006 03:27:37 +0000 (GMT) (envelope-from silby@silby.com) Received: (qmail 65380 invoked from network); 28 May 2006 03:27:36 -0000 Received: from unknown (HELO localhost) (unknown) by unknown with SMTP; 28 May 2006 03:27:36 -0000 X-pair-Authenticated: 209.68.2.70 Date: Sat, 27 May 2006 22:27:31 -0500 (CDT) From: Mike Silbersack To: Ian Dowse In-Reply-To: <200605272346.k4RNkEe9035978@repoman.freebsd.org> Message-ID: <20060527222700.F8982@odysseus.silby.com> References: <200605272346.k4RNkEe9035978@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb if_axe.c if_axereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 03:27:51 -0000 On Sat, 27 May 2006, Ian Dowse wrote: > iedowse 2006-05-27 23:46:14 UTC > > FreeBSD src repository > > Modified files: > sys/dev/usb if_axe.c if_axereg.h > Log: > Defer axe_tick processing to a USB task, since axe miibus operations > need to sleep. This avoids an INVARIANTS panic. It looks like if_rue > and if_aue need a similar change, but I don't have hardware to test. > > Revision Changes Path > 1.37 +19 -0 src/sys/dev/usb/if_axe.c > 1.9 +1 -0 src/sys/dev/usb/if_axereg.h Yes, if_rue definitely needs a similar change! Once I finish messing with if_bfe, then I'll plug my rue adaptor back in and take a stab at this. Mike "Silby" Silbersack From owner-cvs-src@FreeBSD.ORG Sun May 28 03:48:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7ADE716BB7D; Sun, 28 May 2006 03:42:08 +0000 (UTC) (envelope-from parv@pair.com) Received: from mta9.adelphia.net (mta9.adelphia.net [68.168.78.199]) by mx1.FreeBSD.org (Postfix) with ESMTP id A904D43D4C; Sun, 28 May 2006 03:42:07 +0000 (GMT) (envelope-from parv@pair.com) Received: from default.chvlva.adelphia.net ([69.160.66.115]) by mta9.adelphia.net (InterMail vM.6.01.05.02 201-2131-123-102-20050715) with ESMTP id <20060528034207.OTDZ8718.mta9.adelphia.net@default.chvlva.adelphia.net>; Sat, 27 May 2006 23:42:07 -0400 Received: by default.chvlva.adelphia.net (Postfix, from userid 1000) id C64FBBB33; Sat, 27 May 2006 23:42:36 -0400 (EDT) Date: Sat, 27 May 2006 23:42:36 -0400 From: Parv To: Joe Marcus Clarke Message-ID: <20060528034236.GA2872@holestein.holy.cow> Mail-Followup-To: Joe Marcus Clarke , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200605271712.k4RHC2gp069996@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200605271712.k4RHC2gp069996@repoman.freebsd.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/mtree BSD.root.dist src/share/man/man7 hier.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 03:48:46 -0000 in message <200605271712.k4RHC2gp069996@repoman.freebsd.org>, wrote Joe Marcus Clarke thusly... > > Add a /media to FreeBSD. /media is a directory designed to > contain subdirectories that will be used for removable media > mount points (i.e. mount points for CDs, floppy disks, USB > drives, etc.). While the primary purpose of /media is to > provide a location for HAL > (http://www.freedesktop.org/wiki/Software_2fhal) to mount > volumes, it could be used by any application that needs to > manage removable media volumes. Was there something wrong with /mnt? - Parv -- From owner-cvs-src@FreeBSD.ORG Sun May 28 04:16:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D85C216B718; Sun, 28 May 2006 04:14:28 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9464943D46; Sun, 28 May 2006 04:14:28 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 7433A1A4D9A; Sat, 27 May 2006 21:14:28 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 9ADDB514AA; Sun, 28 May 2006 00:14:27 -0400 (EDT) Date: Sun, 28 May 2006 00:14:27 -0400 From: Kris Kennaway To: Joe Marcus Clarke , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20060528041427.GA19074@xor.obsecurity.org> References: <200605271712.k4RHC2gp069996@repoman.freebsd.org> <20060528034236.GA2872@holestein.holy.cow> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: <20060528034236.GA2872@holestein.holy.cow> User-Agent: Mutt/1.4.2.1i Cc: Subject: Re: cvs commit: src/etc/mtree BSD.root.dist src/share/man/man7 hier.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 04:16:24 -0000 --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 27, 2006 at 11:42:36PM -0400, Parv wrote: > in message <200605271712.k4RHC2gp069996@repoman.freebsd.org>, wrote > Joe Marcus Clarke thusly... > > > > Add a /media to FreeBSD. /media is a directory designed to > > contain subdirectories that will be used for removable media > > mount points (i.e. mount points for CDs, floppy disks, USB > > drives, etc.). While the primary purpose of /media is to > > provide a location for HAL > > (http://www.freedesktop.org/wiki/Software_2fhal) to mount > > volumes, it could be used by any application that needs to > > manage removable media volumes. >=20 > Was there something wrong with /mnt? See the discussion on arch@ Kris --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEeSOiWry0BWjoQKURAtSgAKCgAHikKg9OuwDva9SWJlhOBzuOGQCeKaBK EAqmO93twj0XXTwwLMXXqaM= =CWmQ -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs-- From owner-cvs-src@FreeBSD.ORG Sun May 28 04:17:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D88F16B926; Sun, 28 May 2006 04:17:06 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD53E43D46; Sun, 28 May 2006 04:17:05 +0000 (GMT) (envelope-from marcus@FreeBSD.org) Received: from shumai.marcuscom.com (shumai.marcuscom.com [192.168.1.4]) by creme-brulee.marcuscom.com (8.13.6/8.13.6) with ESMTP id k4S4HOHq096789; Sun, 28 May 2006 00:17:24 -0400 (EDT) (envelope-from marcus@FreeBSD.org) From: Joe Marcus Clarke To: Parv In-Reply-To: <20060528034236.GA2872@holestein.holy.cow> References: <200605271712.k4RHC2gp069996@repoman.freebsd.org> <20060528034236.GA2872@holestein.holy.cow> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-RUhbO0TVkrL6mNE58WUp" Organization: FreeBSD, Inc. Date: Sun, 28 May 2006 00:16:50 -0400 Message-Id: <1148789811.67880.53.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 FreeBSD GNOME Team Port Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/mtree BSD.root.dist src/share/man/man7 hier.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 04:17:56 -0000 --=-RUhbO0TVkrL6mNE58WUp Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2006-05-27 at 23:42 -0400, Parv wrote: > in message <200605271712.k4RHC2gp069996@repoman.freebsd.org>, wrote > Joe Marcus Clarke thusly... > > > > Add a /media to FreeBSD. /media is a directory designed to > > contain subdirectories that will be used for removable media > > mount points (i.e. mount points for CDs, floppy disks, USB > > drives, etc.). While the primary purpose of /media is to > > provide a location for HAL > > (http://www.freedesktop.org/wiki/Software_2fhal) to mount > > volumes, it could be used by any application that needs to > > manage removable media volumes. >=20 > Was there something wrong with /mnt? Yes. Read the hier(7) entry and the discussion on arch@. Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-RUhbO0TVkrL6mNE58WUp Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBEeSQyb2iPiv4Uz4cRAloOAKCgrc5uTyBCnZN+Q/XFQxHpAdg8TwCfc7jW XXDMHGkGUSdAFboQGZpo56Y= =BKRJ -----END PGP SIGNATURE----- --=-RUhbO0TVkrL6mNE58WUp-- From owner-cvs-src@FreeBSD.ORG Sun May 28 04:25:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB15A16B91D; Sun, 28 May 2006 04:23:18 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail04.syd.optusnet.com.au (mail04.syd.optusnet.com.au [211.29.132.185]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D7F243D55; Sun, 28 May 2006 04:23:18 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail04.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id k4S4NFZT013270 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Sun, 28 May 2006 14:23:16 +1000 Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.13.6/8.13.6) with ESMTP id k4S4NFUl026173; Sun, 28 May 2006 14:23:15 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.13.6/8.13.6/Submit) id k4S4NFbt026172; Sun, 28 May 2006 14:23:15 +1000 (EST) (envelope-from peter) Date: Sun, 28 May 2006 14:23:15 +1000 From: Peter Jeremy To: Joe Marcus Clarke , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20060528042315.GM744@turion.vk2pj.dyndns.org> References: <200605271712.k4RHC2gp069996@repoman.freebsd.org> <20060528034236.GA2872@holestein.holy.cow> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060528034236.GA2872@holestein.holy.cow> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.11 Cc: Subject: Re: cvs commit: src/etc/mtree BSD.root.dist src/share/man/man7 hier.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 04:25:31 -0000 On Sat, 2006-May-27 23:42:36 -0400, Parv wrote: >in message <200605271712.k4RHC2gp069996@repoman.freebsd.org>, wrote >Joe Marcus Clarke thusly... >> >> Add a /media to FreeBSD. /media is a directory designed to > >Was there something wrong with /mnt? Yes. /mnt is for temporarily mounting a single arbitrary filesystem. /media is a container to hold mountpoints for (typically automatically) mounting a number of filesystems. We've been through this bikeshed - please refer to the archives for details. -- Peter Jeremy From owner-cvs-src@FreeBSD.ORG Sun May 28 04:51:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6AFF216C120; Sun, 28 May 2006 04:41:53 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 035F043D4C; Sun, 28 May 2006 04:41:53 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S4ejwi064323; Sun, 28 May 2006 04:40:45 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S4ej96064322; Sun, 28 May 2006 04:40:45 GMT (envelope-from davidxu) Message-Id: <200605280440.k4S4ej96064322@repoman.freebsd.org> From: David Xu Date: Sun, 28 May 2006 04:40:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 04:51:22 -0000 davidxu 2006-05-28 04:40:45 UTC FreeBSD src repository Modified files: sys/i386/isa npx.c Log: If parent thread never used FPU, the only work is to clear flag PCB_NPXINITDONE for new thread and let trap code initialize it. Revision Changes Path 1.168 +6 -1 src/sys/i386/isa/npx.c From owner-cvs-src@FreeBSD.ORG Sun May 28 04:51:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 41C7B16B63E; Sun, 28 May 2006 04:49:04 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F11FF43D46; Sun, 28 May 2006 04:49:03 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S4luvv072389; Sun, 28 May 2006 04:47:56 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S4lueA072388; Sun, 28 May 2006 04:47:56 GMT (envelope-from davidxu) Message-Id: <200605280447.k4S4lueA072388@repoman.freebsd.org> From: David Xu Date: Sun, 28 May 2006 04:47:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 04:52:06 -0000 davidxu 2006-05-28 04:47:56 UTC FreeBSD src repository Modified files: sys/i386/i386 vm_machdep.c Log: PCB_NPXINITDONE is cleared by npx_fork_thread. Revision Changes Path 1.273 +1 -1 src/sys/i386/i386/vm_machdep.c From owner-cvs-src@FreeBSD.ORG Sun May 28 05:23:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 022AC16BA69; Sun, 28 May 2006 05:15:38 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BAF443D46; Sun, 28 May 2006 05:15:37 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout1.pacific.net.au (Postfix) with ESMTP id 45CCF328578; Sun, 28 May 2006 15:15:36 +1000 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k4S5FX9H032023; Sun, 28 May 2006 15:15:34 +1000 Date: Sun, 28 May 2006 15:15:34 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: David Xu In-Reply-To: <200605280203.k4S23DfP053792@repoman.freebsd.org> Message-ID: <20060528134646.V19811@delplex.bde.org> References: <200605280203.k4S23DfP053792@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include npx.h src/sys/i386/i386 vm_machdep.c src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 05:23:59 -0000 On Sun, 28 May 2006, David Xu wrote: > davidxu 2006-05-28 02:03:13 UTC > > FreeBSD src repository > > Modified files: > sys/i386/include npx.h > sys/i386/i386 vm_machdep.c > sys/i386/isa npx.c > Log: > When creating a new thread, inherit floating-point environment from > current thread, this is required by POSIX pthread_create document. > > Revision Changes Path > 1.272 +1 -0 src/sys/i386/i386/vm_machdep.c > 1.30 +4 -0 src/sys/i386/include/npx.h > 1.167 +30 -0 src/sys/i386/isa/npx.c POSIX seems to require inheriting the entire environment, but this change does extra work to disinherit everything except the control word(s), except in the fxsr case it is missing the extra work to disinherit the status bits in the mxcsr. BTW, setjmp()/longjmp() has much larger bugs in this area (they preserve the FP control word but don't even know about mxcsr even on amd64 where mxcsr is primary, so they they mess up both the control and status in mxcsr). This change also does a lot of work to determine the control word(s), and a lot of work to use the old control word(s) even if the old control word(s) are the default. The case where the old thread has the default (!PCB_NPXINITDONE) FP state should be optimized by doing nothing except checking for this case. Otherwise, if preserving only the control word(s) is required, some optimizations are possible with extra complications (*). Otherwise (when the whole environment needs to be preserved then it is simplest and fastest to copy the entire state (the data registers may need to be cleared for security, but not doing so would give less important leaks than already exist). Then the new interface wouldn't be needed. (*) The control word(s) can be obtained much more efficiently than using npxgetregs(). In most cases the control word(s) won't have changed from their default and nothing needs to be done except for checking that they haven't changed. OTOH, the FP environment contains status words which have changed in most cases, so this sort of optimization won't work if the FP environment must be inherited. This change has some style bugs (with highest density in npx.h). Bruce From owner-cvs-src@FreeBSD.ORG Sun May 28 05:31:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D90E16C39F; Sun, 28 May 2006 05:28:17 +0000 (UTC) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A330B43D55; Sun, 28 May 2006 05:28:16 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S5R9qw076599; Sun, 28 May 2006 05:27:09 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S5R9Qi076598; Sun, 28 May 2006 05:27:09 GMT (envelope-from iedowse) Message-Id: <200605280527.k4S5R9Qi076598@repoman.freebsd.org> From: Ian Dowse Date: Sun, 28 May 2006 05:27:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb ehci.c ehci_pci.c ohci.c ohci_pci.c ohcireg.h ohcivar.h sl811hs.c sl811hsvar.h uhci.c uhci_pci.c uhcivar.h usb_mem.c usbdi.c usbdivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 05:31:29 -0000 iedowse 2006-05-28 05:27:09 UTC FreeBSD src repository Modified files: sys/dev/usb ehci.c ehci_pci.c ohci.c ohci_pci.c ohcireg.h ohcivar.h sl811hs.c sl811hsvar.h uhci.c uhci_pci.c uhcivar.h usb_mem.c usbdi.c usbdivar.h Log: Use the limited scatter-gather capabilities of ehci, ohci and uhci host controllers to avoid the need to allocate any multi-page physically contiguous memory blocks. This makes it possible to use USB devices reliably on low-memory systems or when memory is too fragmented for contiguous allocations to succeed. The USB subsystem now uses bus_dmamap_load() directly on the buffers supplied by USB peripheral drivers, so this also avoids having to copy data back and forth before and after transfers. The ehci and ohci controllers support scatter/gather as long as the buffer is contiguous in the virtual address space. For uhci the hardware cannot handle a physical address discontinuity within a USB packet, so it is necessary to copy small memory fragments at times. Revision Changes Path 1.46 +64 -77 src/sys/dev/usb/ehci.c 1.22 +30 -0 src/sys/dev/usb/ehci_pci.c 1.161 +240 -183 src/sys/dev/usb/ohci.c 1.47 +33 -1 src/sys/dev/usb/ohci_pci.c 1.23 +2 -1 src/sys/dev/usb/ohcireg.h 1.43 +2 -3 src/sys/dev/usb/ohcivar.h 1.3 +7 -6 src/sys/dev/usb/sl811hs.c 1.2 +0 -1 src/sys/dev/usb/sl811hsvar.h 1.168 +219 -45 src/sys/dev/usb/uhci.c 1.58 +29 -0 src/sys/dev/usb/uhci_pci.c 1.41 +3 -0 src/sys/dev/usb/uhcivar.h 1.9 +1 -1 src/sys/dev/usb/usb_mem.c 1.94 +168 -58 src/sys/dev/usb/usbdi.c 1.45 +13 -2 src/sys/dev/usb/usbdivar.h From owner-cvs-src@FreeBSD.ORG Sun May 28 06:17:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C570116A442; Sun, 28 May 2006 06:17:23 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8636D43D53; Sun, 28 May 2006 06:17:23 +0000 (GMT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S6GG6v079645; Sun, 28 May 2006 06:16:16 GMT (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S6GFHx079644; Sun, 28 May 2006 06:16:15 GMT (envelope-from dds) Message-Id: <200605280616.k4S6GFHx079644@repoman.freebsd.org> From: Diomidis Spinellis Date: Sun, 28 May 2006 06:16:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/games/fortune/datfiles fortunes X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 06:18:20 -0000 dds 2006-05-28 06:16:15 UTC FreeBSD src repository Modified files: games/fortune/datfiles fortunes Log: Layers are for cakes, not for software. -- Bart Smaalders From Performance Anti-patterns. ACM Queue 4(1):44-50. February 2006. (Author confirmed via email that the quote is his own). Revision Changes Path 1.216 +3 -0 src/games/fortune/datfiles/fortunes From owner-cvs-src@FreeBSD.ORG Sun May 28 06:22:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A4C716BEB0; Sun, 28 May 2006 06:20:15 +0000 (UTC) (envelope-from parv@pair.com) Received: from mta13.adelphia.net (mta13.mail.adelphia.net [68.168.78.44]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFEED43D4C; Sun, 28 May 2006 06:20:13 +0000 (GMT) (envelope-from parv@pair.com) Received: from default.chvlva.adelphia.net ([69.160.66.115]) by mta13.adelphia.net (InterMail vM.6.01.05.02 201-2131-123-102-20050715) with ESMTP id <20060528062012.JBHK9479.mta13.adelphia.net@default.chvlva.adelphia.net>; Sun, 28 May 2006 02:20:12 -0400 Received: by default.chvlva.adelphia.net (Postfix, from userid 1000) id 40E76BB1D; Sun, 28 May 2006 02:02:23 -0400 (EDT) Date: Sun, 28 May 2006 02:02:23 -0400 From: Parv To: Peter Jeremy Message-ID: <20060528060223.GA4790@holestein.holy.cow> Mail-Followup-To: Peter Jeremy , Joe Marcus Clarke , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200605271712.k4RHC2gp069996@repoman.freebsd.org> <20060528034236.GA2872@holestein.holy.cow> <20060528042315.GM744@turion.vk2pj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060528042315.GM744@turion.vk2pj.dyndns.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Joe Marcus Clarke , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/mtree BSD.root.dist src/share/man/man7 hier.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 06:22:34 -0000 in message <20060528042315.GM744@turion.vk2pj.dyndns.org>, wrote Peter Jeremy thusly... > > On Sat, 2006-May-27 23:42:36 -0400, Parv wrote: > >in message <200605271712.k4RHC2gp069996@repoman.freebsd.org>, wrote > >Joe Marcus Clarke thusly... > >> > >> Add a /media to FreeBSD. /media is a directory designed to > > > >Was there something wrong with /mnt? > > Yes. /mnt is for temporarily mounting a single arbitrary filesystem. > /media is a container to hold mountpoints for (typically automatically) > mounting a number of filesystems. We've been through this bikeshed - > please refer to the archives for details. I thank you (and Joe M & Kris K) for the pointer. I will read the arch@ archive. - Parv -- From owner-cvs-src@FreeBSD.ORG Sun May 28 06:44:41 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 5DEEC16B15F; Sun, 28 May 2006 06:38:11 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: Bruce Evans Date: Sun, 28 May 2006 14:38:06 +0800 User-Agent: KMail/1.8.2 References: <200605280203.k4S23DfP053792@repoman.freebsd.org> <20060528134646.V19811@delplex.bde.org> In-Reply-To: <20060528134646.V19811@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200605281438.06966.davidxu@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/include npx.h src/sys/i386/i386 vm_machdep.c src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 06:44:51 -0000 On Sunday 28 May 2006 13:15, Bruce Evans wrote: > On Sun, 28 May 2006, David Xu wrote: > > davidxu 2006-05-28 02:03:13 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/i386/include npx.h > > sys/i386/i386 vm_machdep.c > > sys/i386/isa npx.c > > Log: > > When creating a new thread, inherit floating-point environment from > > current thread, this is required by POSIX pthread_create document. > > > > Revision Changes Path > > 1.272 +1 -0 src/sys/i386/i386/vm_machdep.c > > 1.30 +4 -0 src/sys/i386/include/npx.h > > 1.167 +30 -0 src/sys/i386/isa/npx.c > > POSIX seems to require inheriting the entire environment, but this > change does extra work to disinherit everything except the control > word(s), except in the fxsr case it is missing the extra work to > disinherit the status bits in the mxcsr. No, pthread_create is not fork, they are different. http://www.opengroup.org/onlinepubs/009695399/basedefs/fenv.h.html I think you misunderstood x86's float-pointing status and POSIX float point environment. POSIX defined following environment flags: FE_DOWNWARD FE_TONEAREST FE_TOWARDZERO FE_UPWARD which when implemented by x86, they are in control word, status word is nothing to do with new threads, no pending exceptions should be inherited by new thread. > BTW, setjmp()/longjmp() has > much larger bugs in this area (they preserve the FP control word but > don't even know about mxcsr even on amd64 where mxcsr is primary, so > they they mess up both the control and status in mxcsr). > > This change also does a lot of work to determine the control word(s), > and a lot of work to use the old control word(s) even if the old control > word(s) are the default. This was already fixed in my second commit. > The case where the old thread has the default > (!PCB_NPXINITDONE) FP state should be optimized by doing nothing except > checking for this case. Otherwise, if preserving only the control > word(s) is required, some optimizations are possible with extra > complications (*). Otherwise (when the whole environment needs to be > preserved then it is simplest and fastest to copy the entire state > (the data registers may need to be cleared for security, but not doing > so would give less important leaks than already exist). Then the new > interface wouldn't be needed. > > (*) The control word(s) can be obtained much more efficiently than using > npxgetregs(). In most cases the control word(s) won't have changed from > their default and nothing needs to be done except for checking that they > haven't changed. OTOH, the FP environment contains status words which > have changed in most cases, so this sort of optimization won't work if > the FP environment must be inherited. > Well, I am trying to do things correctly, fix bugs and then optimize it, rather than do nothing, and leave the bug there. > This change has some style bugs (with highest density in npx.h). > > Bruce From owner-cvs-src@FreeBSD.ORG Sun May 28 07:03:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96D6C16CF8A; Sun, 28 May 2006 06:53:05 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55D6043D48; Sun, 28 May 2006 06:53:05 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S6pvX7081003; Sun, 28 May 2006 06:51:57 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S6pvuT081002; Sun, 28 May 2006 06:51:57 GMT (envelope-from davidxu) Message-Id: <200605280651.k4S6pvuT081002@repoman.freebsd.org> From: David Xu Date: Sun, 28 May 2006 06:51:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 machdep.c ptrace_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 07:03:35 -0000 davidxu 2006-05-28 06:51:57 UTC FreeBSD src repository Modified files: sys/i386/i386 machdep.c ptrace_machdep.c Log: Clear high 16 bits of mxcsr register, according to Intel document, if the high 16 bits is non-zero, fxrstor instruction will generate GP fault, resulting kernel crash, this bug can be triggered by setcontext and ptrace(PT_SETXMMREGS). Revision Changes Path 1.627 +3 -0 src/sys/i386/i386/machdep.c 1.5 +2 -0 src/sys/i386/i386/ptrace_machdep.c From owner-cvs-src@FreeBSD.ORG Sun May 28 07:03:38 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2819D16BF96 for ; Sun, 28 May 2006 06:54:49 +0000 (UTC) (envelope-from cokane@ramen.cokane.org) Received: from smtp3.fuse.net (mail-out3.fuse.net [216.68.8.177]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE5E543D58 for ; Sun, 28 May 2006 06:54:46 +0000 (GMT) (envelope-from cokane@ramen.cokane.org) Received: from gx6.fuse.net ([66.117.224.249]) by smtp3.fuse.net (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20060528065446.HHZB21196.smtp3.fuse.net@gx6.fuse.net> for ; Sun, 28 May 2006 02:54:46 -0400 Received: from ramen.cokane.org ([66.117.224.249]) by gx6.fuse.net (InterMail vG.1.02.00.02 201-2136-104-102-20041210) with SMTP id <20060528065445.JYQD24896.gx6.fuse.net@ramen.cokane.org> for ; Sun, 28 May 2006 02:54:45 -0400 Received: (qmail 40701 invoked by uid 1001); 28 May 2006 06:56:08 -0000 Date: Sun, 28 May 2006 06:56:08 +0000 From: Coleman Kane To: Yu-Shun Wang Message-ID: <20060528065608.GA40631@ramen.coleyandcheryl> References: <200605122039.k4CKdNlh034483@repoman.freebsd.org> <20060512213633.J54242@maildrop.int.zabbadoz.net> <59764.192.168.4.1.1147470337.squirrel@mail.abi01.homeunix.org> <44775803.3060404@isi.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44775803.3060404@isi.edu> User-Agent: Mutt/1.4.1i Cc: src-committers@freebsd.org, Max Laier , cvs-src@freebsd.org, cvs-all@freebsd.org, "Bjoern A. Zeeb" , Max Laier Subject: Re: cvs commit: src/sbin Makefile src/sbin/ip6fw Makefile ip6fw.8 ip6fw.c sample.sh src/sys/conf files options src/sys/modules Makefile src/sys/modules/ip6fw Makefile src/sys/net net_osdep.h src/sys/netinet ip_fw2.c src/sys/netinet6 ip6_forward.c ip6_fw.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 07:03:52 -0000 On Fri, May 26, 2006 at 12:33:23PM -0700, Yu-Shun Wang wrote, and it was proclaimed: > Max Laier wrote: > >On Fri, May 12, 2006 11:38 pm, Bjoern A. Zeeb wrote: > >>On Fri, 12 May 2006, Max Laier wrote: > >> > >>> Log: > >>> Remove ip6fw. Since ipfw has full functional IPv6 support now and - in > >>> contrast to ip6fw - is properly lockes, it is time to retire ip6fw. > >>could you add an entry to UPDATING because of incompatible syntax etc. > >>so people will be able to find out before updating that their ip6fw > >>rc.firewall6 scripts no longer work... > > > >Will post to UPDATING, bump __FreeBSD_version and update ObsoleteFiles in > >a bit. > > Hi, > > I am probably missing something here. But both rc.firewall > and rc.firewall6 flush all rules before adding their own. > The result on my system is that v4 rules were wiped out. > Any ways to resolve this? (I commented out the flush line > in rc.firewall6 for now. But that's not good if you are > v6 only.) > > Thanks, > > yushun > Now that the firewall code is combined, shouldn't the only necessary script be rc.firewall for both inet6 and inet4? -- coleman kane From owner-cvs-src@FreeBSD.ORG Sun May 28 07:31:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27FF316CE19; Sun, 28 May 2006 07:16:44 +0000 (UTC) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DBC3A43D46; Sun, 28 May 2006 07:16:43 +0000 (GMT) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S7FaX3083207; Sun, 28 May 2006 07:15:36 GMT (envelope-from jmg@repoman.freebsd.org) Received: (from jmg@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S7Fa1E083206; Sun, 28 May 2006 07:15:36 GMT (envelope-from jmg) Message-Id: <200605280715.k4S7Fa1E083206@repoman.freebsd.org> From: John-Mark Gurney Date: Sun, 28 May 2006 07:15:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/file magic.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 07:32:02 -0000 jmg 2006-05-28 07:15:36 UTC FreeBSD src repository Modified files: usr.bin/file magic.5 Log: document that even if magic is newer than magic.mgc, it isn't used compiling mgc on a big endian system (specificly tested sparc64) breaks, using one from a little endian system works Revision Changes Path 1.24 +18 -0 src/usr.bin/file/magic.5 From owner-cvs-src@FreeBSD.ORG Sun May 28 07:40:07 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 1431316BDE8 for ; Sun, 28 May 2006 07:23:24 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: cvs-src@freebsd.org Date: Sun, 28 May 2006 15:23:20 +0800 User-Agent: KMail/1.8.2 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200605281523.20325.davidxu@freebsd.org> Subject: cvs log for i386/machdep.c and i386/ptrace_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 07:40:12 -0000 I just got error message on my console when committing some bug fixes: /tmp/cvsIWwZ2B: 12 lines, 556 characters. Checking in i386/machdep.c; /home/ncvs/src/sys/i386/i386/machdep.c,v <-- machdep.c new revision: 1.627; previous revision: 1.626 done Checking in i386/ptrace_machdep.c; /home/ncvs/src/sys/i386/i386/ptrace_machdep.c,v <-- ptrace_machdep.c new revision: 1.5; previous revision: 1.4 done cvs [log aborted]: received broken pipe signal Mailing the commit message to 'src-committers@FreeBSD.org cvs-src@FreeBSD.org cvs-all@FreeBSD.org'. so if you didn't get the cvs log message, here it is: Clear high 16 bits of mxcsr register, according to Intel document, if the high 16 bits is non-zero, fxrstor instruction will generate GP fault, resulting kernel crash, this bug can be triggered by setcontext and ptrace(PT_SETXMMREGS). -- David Xu From owner-cvs-src@FreeBSD.ORG Sun May 28 07:41:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4512316BF21; Sun, 28 May 2006 07:25:18 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id D848643D46; Sun, 28 May 2006 07:25:17 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout1.pacific.net.au (Postfix) with ESMTP id AF60E328CDE; Sun, 28 May 2006 17:25:16 +1000 (EST) Received: from epsplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k4S7PEbe027476; Sun, 28 May 2006 17:25:15 +1000 Date: Sun, 28 May 2006 17:25:14 +1000 (EST) From: Bruce Evans X-X-Sender: bde@epsplex.bde.org To: David Xu In-Reply-To: <200605280440.k4S4ej96064322@repoman.freebsd.org> Message-ID: <20060528163018.F1344@epsplex.bde.org> References: <200605280440.k4S4ej96064322@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 07:41:57 -0000 On Sun, 28 May 2006, David Xu wrote: > davidxu 2006-05-28 04:40:45 UTC > > FreeBSD src repository > > Modified files: > sys/i386/isa npx.c > Log: > If parent thread never used FPU, the only work is to clear flag PCB_NPXINITDONE doesn't mean that a thread never used the FPU. It means that the FPU state is not the default. > PCB_NPXINITDONE for new thread and let trap code initialize it. > > Revision Changes Path > 1.168 +6 -1 src/sys/i386/isa/npx.c Why do so much? If PCB_NPXINITDONE is clear in the parent, then it is already clear in the child, since it has just been copied (the whole pcb has been copied). It doesn't take a function call to check if PCB_INITDONE is clear in the parent. cpu_fork() calls npxsave() to force the FPU state to the pcb so that it is automatically copied at no extra cost when the whole pcb is copied. This causes the entire FPU state to be inherited. Why is cpu_set_upcall() different? I the old difference was just an invalid "optimization" and the new difference is not good. POSIX requires fork() to duplicate the process _exactly_ except for some things not including any FPU or even integer state, and FreeBSD implements this except for clobbering a few integer registers. POSIX places fewer requirments on pthread_create() by listing things that are inherited and not requiring things not listed to be preserved; old versions of POSIX apparently didn't even require the FPU state to be preserved, but that was a bug and was fixed by aligning with SUS. Since there is considerable experience that duplicating the whole FPU state in fork() doesn't cause problems, I think it wouldn't cause problems in pthread_create() either. Anyway, POSIX must really mean that the whole FP environment must be inherited, so all that pthread_create() is permitted to do differently than fork() is scrubbing the data registers. Bruce From owner-cvs-src@FreeBSD.ORG Sun May 28 07:41:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 91BB216C22C; Sun, 28 May 2006 07:25:20 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5220943D4C; Sun, 28 May 2006 07:25:20 +0000 (GMT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S7OCNM083568; Sun, 28 May 2006 07:24:12 GMT (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S7OCl5083567; Sun, 28 May 2006 07:24:12 GMT (envelope-from dds) Message-Id: <200605280724.k4S7OCl5083567@repoman.freebsd.org> From: Diomidis Spinellis Date: Sun, 28 May 2006 07:24:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vnode_if.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 07:42:08 -0000 dds 2006-05-28 07:24:12 UTC FreeBSD src repository Modified files: sys/kern vnode_if.src Log: Add missing % signs in the lock annotations of the functions: lookup, rename, strategy, islocked The missing % sign meant that the lines were processed as plain comments and the corresponding assertions were never generated. Revision Changes Path 1.80 +8 -8 src/sys/kern/vnode_if.src From owner-cvs-src@FreeBSD.ORG Sun May 28 08:53:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 25FA416C0F9; Sun, 28 May 2006 08:29:56 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D765743D48; Sun, 28 May 2006 08:29:55 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S8SmNq087611; Sun, 28 May 2006 08:28:48 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S8Sm3f087610; Sun, 28 May 2006 08:28:48 GMT (envelope-from rwatson) Message-Id: <200605280828.k4S8Sm3f087610@repoman.freebsd.org> From: Robert Watson Date: Sun, 28 May 2006 08:28:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_exec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 08:53:58 -0000 rwatson 2006-05-28 08:28:48 UTC FreeBSD src repository Modified files: sys/kern kern_exec.c Log: In execve(), audit the path name being executed. In the future, it would also be good to audit the interpreter pathname, if any. Obtained from: TrustedBSD Project Revision Changes Path 1.293 +2 -2 src/sys/kern/kern_exec.c From owner-cvs-src@FreeBSD.ORG Sun May 28 08:54:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 423B616CBD4; Sun, 28 May 2006 08:30:58 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8DC0243D5C; Sun, 28 May 2006 08:30:57 +0000 (GMT) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S8TnXX087659; Sun, 28 May 2006 08:29:49 GMT (envelope-from matteo@repoman.freebsd.org) Received: (from matteo@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S8TnF0087658; Sun, 28 May 2006 08:29:49 GMT (envelope-from matteo) Message-Id: <200605280829.k4S8TnF0087658@repoman.freebsd.org> From: Matteo Riondato Date: Sun, 28 May 2006 08:29:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/jail jail.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 08:54:34 -0000 matteo 2006-05-28 08:29:49 UTC FreeBSD src repository Modified files: usr.sbin/jail jail.8 Log: Mention ruleset #4 (devfsrules_jail) in jail's man page. MFC after: 3 Revision Changes Path 1.78 +3 -1 src/usr.sbin/jail/jail.8 From owner-cvs-src@FreeBSD.ORG Sun May 28 08:59:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E798416CC25; Sun, 28 May 2006 08:33:59 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DEB343D48; Sun, 28 May 2006 08:33:59 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout1.pacific.net.au (Postfix) with ESMTP id F2CC532867B; Sun, 28 May 2006 18:33:57 +1000 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k4S8XtLC017337; Sun, 28 May 2006 18:33:56 +1000 Date: Sun, 28 May 2006 18:33:55 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: David Xu In-Reply-To: <200605281438.06966.davidxu@freebsd.org> Message-ID: <20060528174007.R20314@delplex.bde.org> References: <200605280203.k4S23DfP053792@repoman.freebsd.org> <20060528134646.V19811@delplex.bde.org> <200605281438.06966.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include npx.h src/sys/i386/i386 vm_machdep.c src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 09:00:07 -0000 On Sun, 28 May 2006, David Xu wrote: > On Sunday 28 May 2006 13:15, Bruce Evans wrote: >>> ... >> POSIX seems to require inheriting the entire environment, but this >> change does extra work to disinherit everything except the control >> word(s), except in the fxsr case it is missing the extra work to >> disinherit the status bits in the mxcsr. > > No, pthread_create is not fork, they are different. > http://www.opengroup.org/onlinepubs/009695399/basedefs/fenv.h.html > I think you misunderstood x86's float-pointing status and POSIX float > point environment. No, I know a little about floating point. > POSIX defined following environment flags: > FE_DOWNWARD > FE_TONEAREST > FE_TOWARDZERO > FE_UPWARD These are just a small part of the FP environment. They are a fairly standard part of the control of the environment. FP environments also have status, and there may be any amount of machine-dependent control and status bits. The FP environment main access functions in fenv.h (fegetenv(w) and fesetenv(2)) act on the entire environment. On i386's and amd64's, they are implemented using fnstenv[+stmxcsr] and fldenv[+ldmxcsr]. Using fnstenv and fldenv ensures getting everything although some things might not be needed and fnstenv and fldenv might be less efficient than alternatives. See fenv.h.html for these details expression in different ways. It defines the "entire floating-point environment" as being [the collection of any status flags and control modes supported by the implementation]. > which when implemented by x86, they are in control word, status word > is nothing to do with new threads, no pending exceptions should be > inherited by new thread. The above rounding flags are in the FP control word and the control part of the mxcsr on i386's. Exception bits are in a separate FP word but in the same mxcsr. Exceptions aren't pending with the default environment; they have happened and are recorded in the exception bits. MD parts of the environment have other things like last-instruction pointers. Using fnstenv and fldenv ensures getting everything, except there are complications for the mxcsr. With only SSE, the environment would just consist of the mxcsr. It may be a bug in POSIX for POSIX to require inheriting the _entire_ FP environment. Perhaps it should require some things to be reset. This is hard for it to even express, since most parts of the FP environment are opaque to it. Your change has the strange behaviour of resetting everything except the mxcsr exception bits. Bruce From owner-cvs-src@FreeBSD.ORG Sun May 28 09:28:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C89F16B609; Sun, 28 May 2006 09:07:09 +0000 (UTC) (envelope-from chris@hitnet.RWTH-Aachen.DE) Received: from ms-dienst.rz.rwth-aachen.de (ms-1.rz.RWTH-Aachen.DE [134.130.3.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id E04D443D48; Sun, 28 May 2006 09:07:08 +0000 (GMT) (envelope-from chris@hitnet.RWTH-Aachen.DE) Received: from circe (circe.rz.RWTH-Aachen.DE [134.130.3.36]) by ms-dienst.rz.rwth-aachen.de (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0IZY004K1XBUWE@ms-dienst.rz.rwth-aachen.de>; Sun, 28 May 2006 11:07:07 +0200 (MEST) Received: from talos.rz.RWTH-Aachen.DE ([134.130.3.22]) by circe (MailMonitor for SMTP v1.2.2 ) ; Sun, 28 May 2006 11:07:06 +0200 (MEST) Received: from bigboss.hitnet.rwth-aachen.de (bigspace.hitnet.RWTH-Aachen.DE [137.226.181.2]) by smarthost.rwth-aachen.de (8.13.1/8.13.1/1) with ESMTP id k4S975ur000363; Sun, 28 May 2006 11:07:05 +0200 Received: from haakonia.hitnet.rwth-aachen.de ([137.226.181.92]) by bigboss.hitnet.rwth-aachen.de with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1FkHEn-0006Si-Ug; Sun, 28 May 2006 11:07:05 +0200 Received: by haakonia.hitnet.rwth-aachen.de (Postfix, from userid 1001) id 8FAA03F42E; Sun, 28 May 2006 11:07:05 +0200 (CEST) Date: Sun, 28 May 2006 11:07:05 +0200 From: Christian Brueffer In-reply-to: <200605280527.k4S5R9Qi076598@repoman.freebsd.org> To: Ian Dowse Message-id: <20060528090705.GA1475@haakonia.hitnet.RWTH-Aachen.DE> MIME-version: 1.0 Content-type: multipart/signed; boundary=VbJkn9YxBvnuCH5J; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-disposition: inline User-Agent: Mutt/1.5.11 X-Operating-System: FreeBSD 6.1-STABLE X-PGP-Key: http://people.FreeBSD.org/~brueffer/brueffer.key.asc X-PGP-Fingerprint: A5C8 2099 19FF AACA F41B B29B 6C76 178C A0ED 982D References: <200605280527.k4S5R9Qi076598@repoman.freebsd.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ehci.c ehci_pci.c ohci.c ohci_pci.c ohcireg.h ohcivar.h sl811hs.c sl811hsvar.h uhci.c uhci_pci.c uhcivar.h usb_mem.c usbdi.c usbdivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 09:28:48 -0000 --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 28, 2006 at 05:27:09AM +0000, Ian Dowse wrote: > iedowse 2006-05-28 05:27:09 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/usb ehci.c ehci_pci.c ohci.c ohci_pci.c=20 > ohcireg.h ohcivar.h sl811hs.c=20 > sl811hsvar.h uhci.c uhci_pci.c uhcivar.h=20 > usb_mem.c usbdi.c usbdivar.h=20 > Log: > Use the limited scatter-gather capabilities of ehci, ohci and uhci > host controllers to avoid the need to allocate any multi-page > physically contiguous memory blocks. This makes it possible to use > USB devices reliably on low-memory systems or when memory is too > fragmented for contiguous allocations to succeed. > =20 > The USB subsystem now uses bus_dmamap_load() directly on the buffers > supplied by USB peripheral drivers, so this also avoids having to > copy data back and forth before and after transfers. The ehci and > ohci controllers support scatter/gather as long as the buffer is > contiguous in the virtual address space. For uhci the hardware > cannot handle a physical address discontinuity within a USB packet, > so it is necessary to copy small memory fragments at times. > =20 Thanks! - Christian --=20 Christian Brueffer chris@unixpages.org brueffer@FreeBSD.org GPG Key: http://people.freebsd.org/~brueffer/brueffer.key.asc GPG Fingerprint: A5C8 2099 19FF AACA F41B B29B 6C76 178C A0ED 982D --VbJkn9YxBvnuCH5J Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (FreeBSD) iD8DBQFEeWg5bHYXjKDtmC0RAlC/AKC62jAahB+wJe3iIvlh7mF4UYxrcwCgseOo YWWO+ruS7oH34GTrzonAntM= =2SiT -----END PGP SIGNATURE----- --VbJkn9YxBvnuCH5J-- From owner-cvs-src@FreeBSD.ORG Sun May 28 09:57:48 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4350916D643; Sun, 28 May 2006 09:50:51 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F386043D46; Sun, 28 May 2006 09:50:50 +0000 (GMT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S9ngpG001428; Sun, 28 May 2006 09:49:42 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S9ngZP001427; Sun, 28 May 2006 09:49:42 GMT (envelope-from simon) Message-Id: <200605280949.k4S9ngZP001427@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Sun, 28 May 2006 09:49:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/jail jail.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 09:57:56 -0000 simon 2006-05-28 09:49:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/jail jail.8 Log: Revert MFC of 1.73, since mounting devfs without a devfs ruleset inside a jail is a very bad idea security wise. Revision Changes Path 1.67.2.8 +0 -1 src/usr.sbin/jail/jail.8 From owner-cvs-src@FreeBSD.ORG Sun May 28 10:01:47 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 869A916D200; Sun, 28 May 2006 09:41:56 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: Bruce Evans Date: Sun, 28 May 2006 17:41:52 +0800 User-Agent: KMail/1.8.2 References: <200605280440.k4S4ej96064322@repoman.freebsd.org> <20060528163018.F1344@epsplex.bde.org> In-Reply-To: <20060528163018.F1344@epsplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200605281741.52752.davidxu@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 10:01:51 -0000 On Sunday 28 May 2006 15:25, Bruce Evans wrote: > On Sun, 28 May 2006, David Xu wrote: > > davidxu 2006-05-28 04:40:45 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/i386/isa npx.c > > Log: > > If parent thread never used FPU, the only work is to clear flag > > PCB_NPXINITDONE doesn't mean that a thread never used the FPU. It > means that the FPU state is not the default. > PCB_NPXINITDONE does mean thread used FPU, I don't know where you got the information. > > PCB_NPXINITDONE for new thread and let trap code initialize it. > > > > Revision Changes Path > > 1.168 +6 -1 src/sys/i386/isa/npx.c > > Why do so much? If PCB_NPXINITDONE is clear in the parent, then it > is already clear in the child, since it has just been copied (the whole > pcb has been copied). It doesn't take a function call to check if > PCB_INITDONE is clear in the parent. > I have already checked PCB_NPXINITDONE for parent thread, if it is not set, npx_fork_thread will return from fast path. > cpu_fork() calls npxsave() to force the FPU state to the pcb so that > it is automatically copied at no extra cost when the whole pcb is > copied. This causes the entire FPU state to be inherited. Why is > cpu_set_upcall() different? I the old difference was just an invalid > "optimization" and the new difference is not good. POSIX requires > fork() to duplicate the process _exactly_ except for some things not > including any FPU or even integer state, and FreeBSD implements this > except for clobbering a few integer registers. POSIX places fewer > requirments on pthread_create() by listing things that are inherited > and not requiring things not listed to be preserved; old versions of > POSIX apparently didn't even require the FPU state to be preserved, > but that was a bug and was fixed by aligning with SUS. Since there > is considerable experience that duplicating the whole FPU state in > fork() doesn't cause problems, I think it wouldn't cause problems in > pthread_create() either. Anyway, POSIX must really mean that the > whole FP environment must be inherited, so all that pthread_create() > is permitted to do differently than fork() is scrubbing the data > registers. > fork and pthread_create are different, cpu_set_upcall is for new thread when the process is threaded application, pthread_create executes code from different point, while fork continues from the syscall, the new thread entry function DOES NOT understand pending exceptions, the new thread should be started with clean FPU state, it is not needed to mess new thread's FPU state. > Bruce From owner-cvs-src@FreeBSD.ORG Sun May 28 10:04:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A4BD16BF8A; Sun, 28 May 2006 09:45:23 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B99543D6A; Sun, 28 May 2006 09:45:22 +0000 (GMT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4S9iEIx001075; Sun, 28 May 2006 09:44:14 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4S9iE9F001074; Sun, 28 May 2006 09:44:14 GMT (envelope-from simon) Message-Id: <200605280944.k4S9iE9F001074@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Sun, 28 May 2006 09:44:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/jail jail.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 10:04:13 -0000 simon 2006-05-28 09:44:14 UTC FreeBSD src repository Modified files: usr.sbin/jail jail.8 Log: Revert 1.73, since mounting devfs without a devfs ruleset inside a jail is a very bad idea security wise. Approved by: trhodes (jcamou mentor) No response: jcamou Revision Changes Path 1.79 +0 -1 src/usr.sbin/jail/jail.8 From owner-cvs-src@FreeBSD.ORG Sun May 28 10:43:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 15F0B16A67F; Sun, 28 May 2006 10:39:18 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id D7F1B43D4C; Sun, 28 May 2006 10:39:16 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from Andro-Beta.Leidinger.net (p54A5F984.dip.t-dialin.net [84.165.249.132]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.4/8.13.4) with ESMTP id k4SAcsgF076446; Sun, 28 May 2006 12:38:55 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k4SAdChb081510; Sun, 28 May 2006 12:39:12 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Date: Sun, 28 May 2006 12:39:15 +0200 From: Alexander Leidinger To: Robert Watson Message-ID: <20060528123915.7fe8e278@Magellan.Leidinger.net> In-Reply-To: <20060527200440.G79162@fledge.watson.org> References: <20060526204457.3e545e4f@Magellan.Leidinger.net> <11534.1148678206@critter.freebsd.dk> <20060527104539.1f4c0738@Magellan.Leidinger.net> <20060527200440.G79162@fledge.watson.org> Organization: FreeBSD X-Mailer: Sylpheed-Claws 2.2.0 (GTK+ 2.8.17; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new Cc: cvs-src@FreeBSD.org, Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 10:43:48 -0000 Quoting Robert Watson (Sat, 27 May 2006 20:09:54 +0100 (BST)): > > On Sat, 27 May 2006, Alexander Leidinger wrote: > > >> Can we agree that no functions will be put into publicized documentation > >> until somebody has considered if the function actually is a public function > >> or not ? > > > > Does this mean you want to have everything marked as "@internal" by default? > > I don't think there's a switch which does this, so you would have to mark > > every function with @internal by hand. > > This sounds very worrying. Not documented functions are not included in the doxygen output by default. I've changed this default since we have nearly no documented function. If we switch back to the default, you get what you want, but it's not helpful anymore (for e.g. our SoC students or anyone else who wants to help improving the kernel). > > What about adding a comment to the pages which tells everyone that we are > > working on this documentation and so far we haven't reviewed every function > > and decided if it is an internal one or not. > > > > And the most important point is: what does it mean if a function is > > internal? Does it mean 3rd party developers are not allowed to use them, but > > committers are free to use it? Or does it mean nobody is allowed to use them > > except they are used in the same subsystem (or even only in a small part of > > the subsystem as specified in the docu of the functions)? > > Who is this documentation for? If it's for us, then it should document > everything. But if it's for third party developers, it certainly should not > document everything. Over the last few years, we've been informally working > to refine the set of functions and symbols depended on by device drivers, and > on several occasions we've had discussions about taking this much more > seriously. Scott already commented why this doesn't matter in a different branch of this discussion. So I don't comment on this part of the above paragraph. I think this documentation is for (junior) kernel developers in the beginning. And as long as we document which parts of the API are for 3rd party developers (either my marking other parts as internal, or by adding a sentence that a particular function is part of the API which 3rd party developers are allowed to use), we can ship even with every other part of the kernel-docs visible (it doesn't matter according to Scott, and I agree). This way a 3rd party developer is able to get the big picture and maybe understand ambiguous parts of the API better. If hi then decides to use internal functions, he isn't allowed to moan (and as Scott said he probably would have done it even when we don't include the internal API in the docs). But when we have marked the internal functions as such, we can also generate an official version without the internal functions. It's just a switch. But so far I think we need to include everything until a subsystem is fully documented. Since we have no API docs, everyone has to have a look at the kernel on his own. This only provides a little bit of help here. > If you want an example of one way to approach this, take a look at Apple's KPI > drive. They explicitly document which functions, data structures, > definitions, etc, may be depended on by drivers of particular types. This > helps to eliminate ABI breakage across versions, allowing device drivers to > work on many versions of Mac OS X. As a general rule, third party code should > only use documented KPIs, or it will risk getting broken due to API changes > (and no longer compile) or due to ABI changes (where the code compiles but may > corrupt kernel data structures). If we want to support third party device > driver vendors better, we need to take this issue more seriously. For that > matter, if we even want books on how to write device drivers, we need to take > it seriously! Yes. I agree. And until we documented which functions form the official API and which ones are internal, we should tell 3rd party developers about this as proposed in another branch of this thread. See http://www.leidinger.net/FreeBSD/doxygen_notreviewed.png for an example. > So if this is documentation for use by developers modifying the code without a > concern about APIs and ABIs changing, this is fine. But it cannot be > documentation for third party developers writing to any of our > pluggable/loadable interfaces in its current form, because that documentation > is by definition exclusive, not inclusive -- things should only appear in it > when explicitly intended to be there. Since we are Open Source they can have a look and use unofficial parts without our docs. But when we clearly say "this is for internal use only", they can't moan. And we as developers have a benefit from the docs too. Bye, Alexander. -- Selling GoodYear Eagle F1 235/40ZR18, 2x 4mm + 2x 5mm, ~150 EUR you have to pick it up between Germany/Saarland and Luxembourg/Capellen http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-cvs-src@FreeBSD.ORG Sun May 28 10:44:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E000516B590; Sun, 28 May 2006 10:43:02 +0000 (UTC) (envelope-from dds@aueb.gr) Received: from mx-out-01.forthnet.gr (mx-out.forthnet.gr [193.92.150.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F09243D48; Sun, 28 May 2006 10:43:01 +0000 (GMT) (envelope-from dds@aueb.gr) Received: from mx-av-01.forthnet.gr (mx-av.forthnet.gr [193.92.150.27]) by mx-out-01.forthnet.gr (8.13.6/8.13.6) with ESMTP id k4SAgxMh001068; Sun, 28 May 2006 13:42:59 +0300 Received: from mx-in-04.forthnet.gr (mx-in-04.forthnet.gr [193.92.150.163]) by mx-av-01.forthnet.gr (8.13.6/8.13.6) with ESMTP id k4SAgxTi022089; Sun, 28 May 2006 13:42:59 +0300 Received: from [192.168.136.16] (ppp76-181.adsl.forthnet.gr [195.74.246.181]) by mx-in-04.forthnet.gr (8.13.6/8.13.6) with ESMTP id k4S8flbe025102; Sun, 28 May 2006 11:41:48 +0300 Authentication-Results: mx-in-04.forthnet.gr from=dds@aueb.gr; sender-id=neutral; spf=neutral Message-ID: <44797EB7.60406@aueb.gr> Date: Sun, 28 May 2006 13:43:03 +0300 From: Diomidis Spinellis User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060404 SeaMonkey/1.0.1 MIME-Version: 1.0 To: src-committers@FreeBSD.ORG References: <200605280724.k4S7OCl5083567@repoman.freebsd.org> In-Reply-To: <200605280724.k4S7OCl5083567@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-7; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vnode_if.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 10:44:31 -0000 Diomidis Spinellis wrote: > dds 2006-05-28 07:24:12 UTC > > FreeBSD src repository > > Modified files: > sys/kern vnode_if.src > Log: > Add missing % signs in the lock annotations of the functions: > lookup, rename, strategy, islocked > The missing % sign meant that the lines were processed as plain > comments and the corresponding assertions were never generated. > > Revision Changes Path > 1.80 +8 -8 src/sys/kern/vnode_if.src To avoid this from happening again in the future, I intend to replace the "#!" and "#%" special comments that mark the pre- and post-conditions with a character sequence that can't be mistaken for a comment, and also add some error checking in the corresponding awk script. If you have any strong objections please speak up within the coming week. Diomidis - dds@ From owner-cvs-src@FreeBSD.ORG Sun May 28 11:15:34 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 71C6B16A7F0; Sun, 28 May 2006 11:15:34 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CEAE343D4C; Sun, 28 May 2006 11:15:33 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout2.pacific.net.au (Postfix) with ESMTP id 531E16E680; Sun, 28 May 2006 21:15:32 +1000 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k4SBFTkg002154; Sun, 28 May 2006 21:15:30 +1000 Date: Sun, 28 May 2006 21:15:29 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: David Xu In-Reply-To: <200605281741.52752.davidxu@freebsd.org> Message-ID: <20060528201544.L20679@delplex.bde.org> References: <200605280440.k4S4ej96064322@repoman.freebsd.org> <20060528163018.F1344@epsplex.bde.org> <200605281741.52752.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 11:15:34 -0000 On Sun, 28 May 2006, David Xu wrote: > On Sunday 28 May 2006 15:25, Bruce Evans wrote: >> On Sun, 28 May 2006, David Xu wrote: >>> davidxu 2006-05-28 04:40:45 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/i386/isa npx.c >>> Log: >>> If parent thread never used FPU, the only work is to clear flag >> >> PCB_NPXINITDONE doesn't mean that a thread never used the FPU. It >> means that the FPU state is not the default. >> > PCB_NPXINITDONE does mean thread used FPU, I don't know where you got > the information. >From discussions with deischen when we designed and he implemented it. PCB_NPXINITDONE is cleared by npxdrop(). npxdrop() is called by npxgetregs() (this gives another bug in the new code -- see below) and by fpstate_drop(). fpstate_drop() is called from several places, notably by sendsig() to give a clean state for signal handlers, and by exec_setregs(). So it is normal for a single thread to have used the FPU many times despite PCB_NPXINITDONE being clear -- after the first use of the FPU, this happens in every signal handler and after every exec(). Another bug in new code: npxgetregs() drops (resets to the default) the npx state of fpcurthread when the state is in the npx and cpu_fxsr is clear. It does this because that's what the hardware (fnsave) does and reloading the state would be a pessimization for most callers. It is designed to be called mainly from sendsig() where resetting the state is exactly what is wanted. Calling it from the new code clobbers the parent's state in this case. > >>> PCB_NPXINITDONE for new thread and let trap code initialize it. >>> >>> Revision Changes Path >>> 1.168 +6 -1 src/sys/i386/isa/npx.c >> >> Why do so much? If PCB_NPXINITDONE is clear in the parent, then it >> is already clear in the child, since it has just been copied (the whole >> pcb has been copied). It doesn't take a function call to check if >> PCB_INITDONE is clear in the parent. >> > I have already checked PCB_NPXINITDONE for parent thread, if it is not set, > npx_fork_thread will return from fast path. Yes, why do so much? Check the parent's flag in the caller and clear the child's flag when it is known to be already clear. >> cpu_fork() calls npxsave() to force the FPU state to the pcb so that >> it is automatically copied at no extra cost when the whole pcb is >> copied. This causes the entire FPU state to be inherited. Why is >> cpu_set_upcall() different? I the old difference was just an invalid >> "optimization" and the new difference is not good. POSIX requires >> fork() to duplicate the process _exactly_ except for some things not >> including any FPU or even integer state, and FreeBSD implements this >> except for clobbering a few integer registers. POSIX places fewer >> requirments on pthread_create() by listing things that are inherited >> and not requiring things not listed to be preserved; old versions of >> POSIX apparently didn't even require the FPU state to be preserved, >> but that was a bug and was fixed by aligning with SUS. Since there >> is considerable experience that duplicating the whole FPU state in >> fork() doesn't cause problems, I think it wouldn't cause problems in >> pthread_create() either. Anyway, POSIX must really mean that the >> whole FP environment must be inherited, so all that pthread_create() >> is permitted to do differently than fork() is scrubbing the data >> registers. >> > > fork and pthread_create are different, cpu_set_upcall is for new thread when > the process is threaded application, pthread_create executes code from > different point, while fork continues from the syscall, the new thread > entry function DOES NOT understand pending exceptions, the new thread > should be started with clean FPU state, it is not needed to mess new thread's > FPU state. Starting with a clean FP state like the old code does is safest, but POSIX explicitly requires copying the environment, and bugs in the new code result in half of the most dangerous part of the environment (the SSE half of the exception flags) being copied anyway. Pending exceptions are not the only problem here. Pending exceptions are an i387 thing. Most exceptions are non-pending ones for IEEE inexact. Bruce From owner-cvs-src@FreeBSD.ORG Sun May 28 11:16:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B64716A855; Sun, 28 May 2006 11:16:25 +0000 (UTC) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 104F343D53; Sun, 28 May 2006 11:16:25 +0000 (GMT) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SBFGdO018167; Sun, 28 May 2006 11:15:16 GMT (envelope-from wilko@repoman.freebsd.org) Received: (from wilko@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SBFGCk018166; Sun, 28 May 2006 11:15:16 GMT (envelope-from wilko) Message-Id: <200605281115.k4SBFGCk018166@repoman.freebsd.org> From: Wilko Bulte Date: Sun, 28 May 2006 11:15:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/alpha/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 11:16:27 -0000 wilko 2006-05-28 11:15:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/alpha/conf GENERIC Log: Remove GEOM_GPT. I encountered repeatable Unaligned access panics similar to: fatal kernel trap: trap entry = 0x4 (unaligned access fault) cpuid = 0 faulting va = 0xfffffc0000fae1c2 opcode = 0x28 register = 0x1 pc = 0xfffffc00004d07dc ra = 0xfffffc00004d0a1c sp = 0xfffffe0031875bc0 curthread = 0xfffffc007da237a0 pid = 2, comm = g_event These occur when a floppy or a CD (the 6.1R install CD will do in most cases) is in the drive during boot. A floppy or CD inserted *after* the system was booted did not give me this problem. Interestingly enough booting from the 6.1-R install CD sometimes caused the crash, sometimes it did not. When it did not panic an installation of 6.1-R was possible without any incidents. A subsequent boot from HD with the CD still present sometimes(...) worked fine, sometimes paniced. Taking GEOM_GPT out of the kernel config file allows booting without incidents. We do not need GPT on Alpha, so this is the easy way out. Discussed with: phk Revision Changes Path 1.186.2.4 +0 -1 src/sys/alpha/conf/GENERIC From owner-cvs-src@FreeBSD.ORG Sun May 28 12:06:35 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 3CA4A16AB7F; Sun, 28 May 2006 12:06:30 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: Bruce Evans Date: Sun, 28 May 2006 20:06:26 +0800 User-Agent: KMail/1.8.2 References: <200605280440.k4S4ej96064322@repoman.freebsd.org> <200605281741.52752.davidxu@freebsd.org> <20060528201544.L20679@delplex.bde.org> In-Reply-To: <20060528201544.L20679@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200605282006.26364.davidxu@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 12:06:55 -0000 On Sunday 28 May 2006 19:15, Bruce Evans wrote: > Starting with a clean FP state like the old code does is safest, but POSIX > explicitly requires copying the environment, and bugs in the new code > result in half of the most dangerous part of the environment (the SSE > half of the exception flags) being copied anyway. > > Pending exceptions are not the only problem here. Pending exceptions > are an i387 thing. Most exceptions are non-pending ones for IEEE inexact. > > Bruce how about following patch ? Index: npx.c =================================================================== RCS file: /home/ncvs/src/sys/i386/isa/npx.c,v retrieving revision 1.168 diff -u -u -r1.168 npx.c --- npx.c 28 May 2006 04:40:45 -0000 1.168 +++ npx.c 28 May 2006 11:40:58 -0000 @@ -99,6 +99,7 @@ #define fxrstor(addr) __asm("fxrstor %0" : : "m" (*(addr))) #define fxsave(addr) __asm __volatile("fxsave %0" : "=m" (*(addr))) #define ldmxcsr(__csr) __asm __volatile("ldmxcsr %0" : : "m" (__csr)) +#define stmxcsr(addr) __asm __volatile("stmxcsr %0" : "=m" (*(addr))) #endif #define start_emulating() __asm("smsw %%ax; orb %0,%%al; lmsw %%ax" \ : : "n" (CR0_TS) : "ax") @@ -950,7 +951,8 @@ { union savefpu *state; u_int32_t mxcsr; - u_int32_t cw; + u_int16_t cw; + register_t s; if (!(td->td_pcb->pcb_flags & PCB_NPXINITDONE)) { newtd->td_pcb->pcb_flags &= ~PCB_NPXINITDONE; @@ -958,21 +960,40 @@ } state = &newtd->td_pcb->pcb_save; - /* get control word */ - if (npxgetregs(td, state)) - return; - if (cpu_fxsr) { - mxcsr = state->sv_xmm.sv_env.en_mxcsr; - cw = state->sv_xmm.sv_env.en_cw; + s = intr_disable(); + if (curthread == PCPU_GET(fpcurthread)) { +#ifdef CPU_ENABLE_SSE + if (cpu_fxsr) { + stmxcsr(&mxcsr); + fnstcw(&cw); + } + else +#endif + { + mxcsr = 0; + fnstcw(&cw); + } } else { - cw = state->sv_87.sv_env.en_cw; - mxcsr = 0; +#ifdef CPU_ENABLE_SSE + if (cpu_fxsr) { + mxcsr = td->td_pcb->pcb_save.sv_xmm.sv_env.en_mxcsr; + cw = td->td_pcb->pcb_save.sv_87.sv_env.en_cw; + } + else +#endif + { + mxcsr = 0; + cw = td->td_pcb->pcb_save.sv_87.sv_env.en_cw; + } } + intr_restore(s); bcopy(&npx_cleanstate, state, sizeof(*state)); +#ifdef CPU_ENABLE_SSE if (cpu_fxsr) { state->sv_xmm.sv_env.en_cw = cw; - state->sv_xmm.sv_env.en_mxcsr = mxcsr; + state->sv_xmm.sv_env.en_mxcsr = mxcsr & ~0x3F; } else +#endif state->sv_87.sv_env.en_cw = cw; newtd->td_pcb->pcb_flags |= PCB_NPXINITDONE; } From owner-cvs-src@FreeBSD.ORG Sun May 28 12:33:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB48116A6EF; Sun, 28 May 2006 12:33:39 +0000 (UTC) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 887E843D46; Sun, 28 May 2006 12:33:39 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SCWVGH023127; Sun, 28 May 2006 12:32:31 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SCWVmb023126; Sun, 28 May 2006 12:32:31 GMT (envelope-from stefanf) Message-Id: <200605281232.k4SCWVmb023126@repoman.freebsd.org> From: Stefan Farfeleder Date: Sun, 28 May 2006 12:32:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/id id.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 12:33:48 -0000 stefanf 2006-05-28 12:32:30 UTC FreeBSD src repository Modified files: usr.bin/id id.c Log: Print the euid after the gid as demanded by POSIX. Submitted by: Martin Nagy PR: 96239 MFC after: 2 weeks Revision Changes Path 1.27 +3 -3 src/usr.bin/id/id.c From owner-cvs-src@FreeBSD.ORG Sun May 28 12:58:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 235CC16BCBC; Sun, 28 May 2006 12:58:57 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1224D43D66; Sun, 28 May 2006 12:58:49 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from Andro-Beta.Leidinger.net (p54A5F984.dip.t-dialin.net [84.165.249.132]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.4/8.13.4) with ESMTP id k4SCwRvC077045; Sun, 28 May 2006 14:58:28 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k4SCwlAj001550; Sun, 28 May 2006 14:58:47 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Date: Sun, 28 May 2006 14:58:50 +0200 From: Alexander Leidinger To: "Ben Kaduk" Message-ID: <20060528145850.332a26e9@Magellan.Leidinger.net> In-Reply-To: <47d0403c0605271906r5a618490k750c85d5a148150@mail.gmail.com> References: <20060527104539.1f4c0738@Magellan.Leidinger.net> <13817.1148720224@critter.freebsd.dk> <20060527123344.355119b8@Magellan.Leidinger.net> <47d0403c0605270827n665ccd5ved9ba0effccf248b@mail.gmail.com> <20060527190751.3628e119@Magellan.Leidinger.net> <47d0403c0605271906r5a618490k750c85d5a148150@mail.gmail.com> Organization: FreeBSD X-Mailer: Sylpheed-Claws 2.2.0 (GTK+ 2.8.17; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new Cc: cvs-src@FreeBSD.org, Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 12:58:57 -0000 Quoting "Ben Kaduk" (Sat, 27 May 2006 21:06:08 -0500): > On 5/27/06, Alexander Leidinger wrote: > > Quoting "Ben Kaduk" (Sat, 27 May 2006 10:27:05 -0500): > > > Do you mean "not public" here? > > > > No. I want to say that we not only have public function there, but also > > functions for internal use only. I don't know if this is needed. It's > > also ok for me if someone changes this disclaimer completely. > > Probably the phrase "this API documentation may contain both functions > which are public and functions that are for internal use only" will > better express this sentiment. Thanks. Bye, Alexander. -- Selling GoodYear Eagle F1 235/40ZR18, 2x 4mm + 2x 5mm, ~150 EUR you have to pick it up between Germany/Saarland and Luxembourg/Capellen http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-cvs-src@FreeBSD.ORG Sun May 28 13:04:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 387B816BDD6; Sun, 28 May 2006 13:04:15 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8ECDD43D82; Sun, 28 May 2006 13:03:57 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from Andro-Beta.Leidinger.net (p54A5F984.dip.t-dialin.net [84.165.249.132]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.4/8.13.4) with ESMTP id k4SD3W9N077072; Sun, 28 May 2006 15:03:33 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k4SD3nsJ002299; Sun, 28 May 2006 15:03:50 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Date: Sun, 28 May 2006 15:03:53 +0200 From: Alexander Leidinger To: gnn@FreeBSD.org Message-ID: <20060528150353.094da5b8@Magellan.Leidinger.net> In-Reply-To: References: <20060526204457.3e545e4f@Magellan.Leidinger.net> <11534.1148678206@critter.freebsd.dk> <20060527104539.1f4c0738@Magellan.Leidinger.net> <20060527200440.G79162@fledge.watson.org> Organization: FreeBSD X-Mailer: Sylpheed-Claws 2.2.0 (GTK+ 2.8.17; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=MP_bZOgGMsfDDlwEw7O_ynqdnU X-Virus-Scanned: by amavisd-new Cc: cvs-src@FreeBSD.org, Poul-Henning Kamp , src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 13:04:26 -0000 --MP_bZOgGMsfDDlwEw7O_ynqdnU Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Quoting gnn@FreeBSD.org (Sun, 28 May 2006 11:12:19 +0900): > Am I allowed to call this a tempest in a teacup? > > There, I just have. > > While I think that there have been some very good points made both > ways, I believe that since the documentation will be generated only by > people who are using the system, and will not appear on line, or in a > manual, that we do not need to worry about this. It is, IMHO, easier As Scott already said: it doesn't matter if it is made public or not. "The bad guys"(TM) will use non-public functions regardless. And since generating all docs isn't fast (I need several hours to generate the current ones on my Athlon XP 2200+), it would be nice to have them online somewhere. I already have a disclaimer file (attached), I just wait for the "when this text is included it's ok for me" from those people which worry about the misuse of the docs. > to go through and mark things up AFTER we have them visible and so > visibility should be the first goal. Since there is, as far as I > know, no other or better tool for this job I suggest we go with what > we have and begin to mark things correctly now. Having everything by > default internal, IMHO, leaves us just where we were before, lots of > twisty little APIs all undocumented. > > My $0.02. I agree. Bye, Alexander. -- Selling GoodYear Eagle F1 235/40ZR18, 2x 4mm + 2x 5mm, ~150 EUR you have to pick it up between Germany/Saarland and Luxembourg/Capellen http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 --MP_bZOgGMsfDDlwEw7O_ynqdnU Content-Type: text/plain; name=notreviewed.dox Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename=notreviewed.dox /** @mainpage * IMPORTANT: This API documentation may contain both functions which * are public and functions that are for internal use only. Since we have not * reviewed every part of the documentation yet, some internal functions * are not marked as such. Until we finish reviewing the API documentation * and add appropriate comments to functions which are only for internal use, * you should take this into account. In case you want to use a function of * this kernel subsystem in another kernel subsystem you should search for * precedence of use outside this subsystem. If the function is not used * outside this subsystem you should ask on the mailinglists about it, else * you risk breaking something. */ --MP_bZOgGMsfDDlwEw7O_ynqdnU-- From owner-cvs-src@FreeBSD.ORG Sun May 28 13:05:42 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D56B16B855; Sun, 28 May 2006 13:05:42 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9304D43D48; Sun, 28 May 2006 13:05:41 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 1CB1B46BE2; Sun, 28 May 2006 09:05:41 -0400 (EDT) Date: Sun, 28 May 2006 14:05:40 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Alexander Leidinger In-Reply-To: <20060528123915.7fe8e278@Magellan.Leidinger.net> Message-ID: <20060528140217.K79162@fledge.watson.org> References: <20060526204457.3e545e4f@Magellan.Leidinger.net> <11534.1148678206@critter.freebsd.dk> <20060527104539.1f4c0738@Magellan.Leidinger.net> <20060527200440.G79162@fledge.watson.org> <20060528123915.7fe8e278@Magellan.Leidinger.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 13:05:49 -0000 On Sun, 28 May 2006, Alexander Leidinger wrote: Sounds good. >>> What about adding a comment to the pages which tells everyone that we are >>> working on this documentation and so far we haven't reviewed every >>> function and decided if it is an internal one or not. >>> >>> And the most important point is: what does it mean if a function is >>> internal? Does it mean 3rd party developers are not allowed to use them, >>> but committers are free to use it? Or does it mean nobody is allowed to >>> use them except they are used in the same subsystem (or even only in a >>> small part of the subsystem as specified in the docu of the functions)? >> >> Who is this documentation for? If it's for us, then it should document >> everything. But if it's for third party developers, it certainly should >> not document everything. Over the last few years, we've been informally >> working to refine the set of functions and symbols depended on by device >> drivers, and on several occasions we've had discussions about taking this >> much more seriously. > > Scott already commented why this doesn't matter in a different branch of > this discussion. So I don't comment on this part of the above paragraph. > > I think this documentation is for (junior) kernel developers in the > beginning. And as long as we document which parts of the API are for 3rd > party developers (either my marking other parts as internal, or by adding a > sentence that a particular function is part of the API which 3rd party > developers are allowed to use), we can ship even with every other part of > the kernel-docs visible (it doesn't matter according to Scott, and I agree). > This way a 3rd party developer is able to get the big picture and maybe > understand ambiguous parts of the API better. If hi then decides to use > internal functions, he isn't allowed to moan (and as Scott said he probably > would have done it even when we don't include the internal API in the docs). > > But when we have marked the internal functions as such, we can also generate > an official version without the internal functions. It's just a switch. But > so far I think we need to include everything until a subsystem is fully > documented. > > Since we have no API docs, everyone has to have a look at the kernel on his > own. This only provides a little bit of help here. If we agree this is documentation for people working on the kernel rather than documentation for people programming third party components intended to plug into our plug-in interfaces, then this is all good. The goal of providing well-defined plug-in interfaces isn't to prevent a third party developer from shooting their feet -- after all, they are running code in the kernel address space. The goal is to help them not shoot their feet in the event they are not trying to do so. We do this by documenting what interfaces they should use, and telling them that if they use these interfaces, we will try to avoid shooting their feet for them. >> If you want an example of one way to approach this, take a look at Apple's >> KPI drive. They explicitly document which functions, data structures, >> definitions, etc, may be depended on by drivers of particular types. This >> helps to eliminate ABI breakage across versions, allowing device drivers to >> work on many versions of Mac OS X. As a general rule, third party code >> should only use documented KPIs, or it will risk getting broken due to API >> changes (and no longer compile) or due to ABI changes (where the code >> compiles but may corrupt kernel data structures). If we want to support >> third party device driver vendors better, we need to take this issue more >> seriously. For that matter, if we even want books on how to write device >> drivers, we need to take it seriously! > > Yes. I agree. And until we documented which functions form the official API > and which ones are internal, we should tell 3rd party developers about this > as proposed in another branch of this thread. See > http://www.leidinger.net/FreeBSD/doxygen_notreviewed.png for an example. I like the way this appears. >> So if this is documentation for use by developers modifying the code >> without a concern about APIs and ABIs changing, this is fine. But it >> cannot be documentation for third party developers writing to any of our >> pluggable/loadable interfaces in its current form, because that >> documentation is by definition exclusive, not inclusive -- things should >> only appear in it when explicitly intended to be there. > > Since we are Open Source they can have a look and use unofficial parts > without our docs. But when we clearly say "this is for internal use only", > they can't moan. And we as developers have a benefit from the docs too. Exactly. But I do think we should provide separate explicitly documentation for APIs intended to be consumed by third parties. Robert N M Watson From owner-cvs-src@FreeBSD.ORG Sun May 28 13:08:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D79316A54B; Sun, 28 May 2006 13:08:32 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9E7743D46; Sun, 28 May 2006 13:08:31 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 1D01D46C73; Sun, 28 May 2006 09:08:31 -0400 (EDT) Date: Sun, 28 May 2006 14:08:31 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Alexander Leidinger In-Reply-To: <20060528150353.094da5b8@Magellan.Leidinger.net> Message-ID: <20060528140604.J79162@fledge.watson.org> References: <20060526204457.3e545e4f@Magellan.Leidinger.net> <11534.1148678206@critter.freebsd.dk> <20060527104539.1f4c0738@Magellan.Leidinger.net> <20060527200440.G79162@fledge.watson.org> <20060528150353.094da5b8@Magellan.Leidinger.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: gnn@FreeBSD.org, Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 13:08:33 -0000 On Sun, 28 May 2006, Alexander Leidinger wrote: > Quoting gnn@FreeBSD.org (Sun, 28 May 2006 11:12:19 +0900): > >> Am I allowed to call this a tempest in a teacup? >> >> There, I just have. >> >> While I think that there have been some very good points made both ways, I >> believe that since the documentation will be generated only by people who >> are using the system, and will not appear on line, or in a manual, that we >> do not need to worry about this. It is, IMHO, easier > > As Scott already said: it doesn't matter if it is made public or not. "The > bad guys"(TM) will use non-public functions regardless. I think the bad guys concept is a red herring. Not even having the source code matters for bad guys -- there's some darn evil code that runs on entirely closed source platforms and run-time patches kernels. This code is by necessity very fragile, and the vendors of those closed source systems work hard to try and convince people to use published APIs, and add APIs to try and facilitate it. Otherwise they risk one of the Evil Apps hitting the Critical Must Support List, and leaving them stuck for how to change the kernel in the future. Presumably, what matters to us is making it clear what APIs (structures, etc) are intended for "external" use -- i.e., use that doesn't closely track internal development. It's seeming to me more and more like we should consider Doxygen an "internal" use tool, label it as such, and not try to use it as documentation for developers programming to plug-in interfaces. Robert N M Watson From owner-cvs-src@FreeBSD.ORG Sun May 28 13:58:26 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0233716AD19; Sun, 28 May 2006 13:58:26 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A1B143D55; Sun, 28 May 2006 13:58:25 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout1.pacific.net.au (Postfix) with ESMTP id EC109329FE6; Sun, 28 May 2006 23:58:23 +1000 (EST) Received: from epsplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k4SDwL0a008692; Sun, 28 May 2006 23:58:22 +1000 Date: Sun, 28 May 2006 23:58:21 +1000 (EST) From: Bruce Evans X-X-Sender: bde@epsplex.bde.org To: David Xu In-Reply-To: <200605282006.26364.davidxu@freebsd.org> Message-ID: <20060528223012.H2592@epsplex.bde.org> References: <200605280440.k4S4ej96064322@repoman.freebsd.org> <200605281741.52752.davidxu@freebsd.org> <20060528201544.L20679@delplex.bde.org> <200605282006.26364.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 13:58:27 -0000 On Sun, 28 May 2006, David Xu wrote: > On Sunday 28 May 2006 19:15, Bruce Evans wrote: > >> Starting with a clean FP state like the old code does is safest, but POSIX >> explicitly requires copying the environment, and bugs in the new code >> result in half of the most dangerous part of the environment (the SSE >> half of the exception flags) being copied anyway. >> >> Pending exceptions are not the only problem here. Pending exceptions >> are an i387 thing. Most exceptions are non-pending ones for IEEE inexact. > > how about following patch ? I want one that removes about 30 lines, not one that adds about 20 lines. > Index: npx.c > =================================================================== > RCS file: /home/ncvs/src/sys/i386/isa/npx.c,v > retrieving revision 1.168 > diff -u -u -r1.168 npx.c > --- npx.c 28 May 2006 04:40:45 -0000 1.168 > +++ npx.c 28 May 2006 11:40:58 -0000 > @@ -99,6 +99,7 @@ > #define fxrstor(addr) __asm("fxrstor %0" : : "m" (*(addr))) > #define fxsave(addr) __asm __volatile("fxsave %0" : "=m" (*(addr))) > #define ldmxcsr(__csr) __asm __volatile("ldmxcsr %0" : : "m" (__csr)) > +#define stmxcsr(addr) __asm __volatile("stmxcsr %0" : "=m" (*(addr))) > #endif > #define start_emulating() __asm("smsw %%ax; orb %0,%%al; lmsw %%ax" \ > : : "n" (CR0_TS) : "ax") > @@ -950,7 +951,8 @@ > { > union savefpu *state; > u_int32_t mxcsr; > - u_int32_t cw; > + u_int16_t cw; > + register_t s; > > if (!(td->td_pcb->pcb_flags & PCB_NPXINITDONE)) { > newtd->td_pcb->pcb_flags &= ~PCB_NPXINITDONE; > @@ -958,21 +960,40 @@ > } > > state = &newtd->td_pcb->pcb_save; > - /* get control word */ > - if (npxgetregs(td, state)) > - return; > - if (cpu_fxsr) { > - mxcsr = state->sv_xmm.sv_env.en_mxcsr; > - cw = state->sv_xmm.sv_env.en_cw; > + s = intr_disable(); > + if (curthread == PCPU_GET(fpcurthread)) { > +#ifdef CPU_ENABLE_SSE > + if (cpu_fxsr) { > + stmxcsr(&mxcsr); > + fnstcw(&cw); > + } > + else > +#endif > + { > + mxcsr = 0; > + fnstcw(&cw); > + } > } else { > - cw = state->sv_87.sv_env.en_cw; > - mxcsr = 0; > +#ifdef CPU_ENABLE_SSE > + if (cpu_fxsr) { > + mxcsr = td->td_pcb->pcb_save.sv_xmm.sv_env.en_mxcsr; > + cw = td->td_pcb->pcb_save.sv_87.sv_env.en_cw; > + } > + else > +#endif > + { > + mxcsr = 0; > + cw = td->td_pcb->pcb_save.sv_87.sv_env.en_cw; > + } > } > + intr_restore(s); Save the parent's state using npxsave() as in cpu_fork(). This is much cleaner and and only slightly less efficient. I still think the entire environment in that state needs to be copied. > bcopy(&npx_cleanstate, state, sizeof(*state)); > +#ifdef CPU_ENABLE_SSE > if (cpu_fxsr) { > state->sv_xmm.sv_env.en_cw = cw; > - state->sv_xmm.sv_env.en_mxcsr = mxcsr; > + state->sv_xmm.sv_env.en_mxcsr = mxcsr & ~0x3F; OK if it is correct to not copy the environment. BTW, your other patch that masks the top 16 bits in mxcsr needs to be extended to sometimes mask 0x40 (DAZ). The amd64 arch manual says to mask with mxcsr_mask which is in the fxsave image. Cleared bits in mxcsr_mask indicate reserved bits in a future-proof way. Unfortunately, this isn't past-proof so the following complications are needed: if the CPU stores 0 in mxcsr_mask, it means that mxcsr_mask is not supported; old CPUs (at least amd64 ones) that don't support mxcsr_mask also don't support DAZ, so the correct mask for them is 0xFFBF. These complications are implemented in Linux's i386 so I suppose they are no-ops at worst for non-amd64 CPUs. Linux stores the mask in a global variable. I think this breaks the asymmetric SMP case more than necessary. FreeBSD's amd64 uses mxcsr_mask without fixing up the case where it is 0. So does Linux-2.6.10's x86_64 (it Initializes the global variable but doesn't use it). Behaviour of mxcsr and DAZ on some CPUs: AXP2600 (Barton): mxcsr_mask = 0; attempting to set DAZ traps P3-800 (freefall): same as AXP2600 A64 (Id0xf48 stepping 8): mxcsr_mask = 0xFFFF; setting DAZ works > } else > +#endif vm_machdep.c is missing a DEV_NPX ifdef around the call here. Of course, lots of things would break if the option to not use npx were exercised. CPU_ENABLE_SSE is a silly option too. > state->sv_87.sv_env.en_cw = cw; > newtd->td_pcb->pcb_flags |= PCB_NPXINITDONE; > } > Bruce From owner-cvs-src@FreeBSD.ORG Sun May 28 14:09:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5CF7916B3B9; Sun, 28 May 2006 14:09:00 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD14D43D7B; Sun, 28 May 2006 14:08:56 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SE7loi039309; Sun, 28 May 2006 14:07:47 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SE7leG039308; Sun, 28 May 2006 14:07:47 GMT (envelope-from netchild) Message-Id: <200605281407.k4SE7leG039308@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 28 May 2006 14:07:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/midi midi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 14:09:17 -0000 netchild 2006-05-28 14:07:47 UTC FreeBSD src repository Modified files: sys/dev/sound/midi midi.c Log: Use a more appropriate printf format for size_t. This should unbreak the tinderbox build (64bit architectures). Revision Changes Path 1.17 +1 -1 src/sys/dev/sound/midi/midi.c From owner-cvs-src@FreeBSD.ORG Sun May 28 15:21:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 60B5916C121; Sun, 28 May 2006 15:21:58 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 80A3043D53; Sun, 28 May 2006 15:21:54 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k4SFLl61058934; Sun, 28 May 2006 09:21:53 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4479C00B.8090504@samsco.org> Date: Sun, 28 May 2006 09:21:47 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ian Dowse References: <200605280527.k4S5R9Qi076598@repoman.freebsd.org> In-Reply-To: <200605280527.k4S5R9Qi076598@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ehci.c ehci_pci.c ohci.c ohci_pci.c ohcireg.h ohcivar.h sl811hs.c sl811hsvar.h uhci.c uhci_pci.c uhcivar.h usb_mem.c usbdi.c usbdivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 15:21:58 -0000 Ian Dowse wrote: > iedowse 2006-05-28 05:27:09 UTC > > FreeBSD src repository > > Modified files: > sys/dev/usb ehci.c ehci_pci.c ohci.c ohci_pci.c > ohcireg.h ohcivar.h sl811hs.c > sl811hsvar.h uhci.c uhci_pci.c uhcivar.h > usb_mem.c usbdi.c usbdivar.h > Log: > Use the limited scatter-gather capabilities of ehci, ohci and uhci > host controllers to avoid the need to allocate any multi-page > physically contiguous memory blocks. This makes it possible to use > USB devices reliably on low-memory systems or when memory is too > fragmented for contiguous allocations to succeed. > > The USB subsystem now uses bus_dmamap_load() directly on the buffers > supplied by USB peripheral drivers, so this also avoids having to > copy data back and forth before and after transfers. The ehci and > ohci controllers support scatter/gather as long as the buffer is > contiguous in the virtual address space. For uhci the hardware > cannot handle a physical address discontinuity within a USB packet, > so it is necessary to copy small memory fragments at times. > Excellent work, good job! Scott From owner-cvs-src@FreeBSD.ORG Sun May 28 15:26:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C33EB16A757; Sun, 28 May 2006 15:26:31 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ADD6B43D6D; Sun, 28 May 2006 15:26:27 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SFPIDt054571; Sun, 28 May 2006 15:25:18 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SFPIR6054570; Sun, 28 May 2006 15:25:18 GMT (envelope-from netchild) Message-Id: <200605281525.k4SFPIR6054570@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 28 May 2006 15:25:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/doc/subsys Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 Doxyfile-netgraph Doxyfile-netinet ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 15:26:32 -0000 netchild 2006-05-28 15:25:18 UTC FreeBSD src repository Modified files: sys/doc/subsys Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 Doxyfile-netgraph Doxyfile-netinet Doxyfile-netinet6 Doxyfile-netipsec Doxyfile-opencrypto Doxyfile-vm Makefile Added files: sys/doc/subsys notreviewed.dox Log: Add a disclaimer regarding public/internal functions to every subsystem for now. Discussed on: cvs-all Helped with the wording: "Ben Kaduk" Revision Changes Path 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-cam 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-crypto 1.2 +2 -1 src/sys/doc/subsys/Doxyfile-dev_pci 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-dev_sound 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-dev_usb 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-geom 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-i4b 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-kern 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-libkern 1.2 +2 -1 src/sys/doc/subsys/Doxyfile-linux 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-net80211 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-netgraph 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-netinet 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-netinet6 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-netipsec 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-opencrypto 1.2 +1 -1 src/sys/doc/subsys/Doxyfile-vm 1.2 +1 -0 src/sys/doc/subsys/Makefile 1.1 +14 -0 src/sys/doc/subsys/notreviewed.dox (new) From owner-cvs-src@FreeBSD.ORG Sun May 28 18:31:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B56616B5AC; Sun, 28 May 2006 18:31:46 +0000 (UTC) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CAE8543D48; Sun, 28 May 2006 18:31:45 +0000 (GMT) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SIUaD5080212; Sun, 28 May 2006 18:30:36 GMT (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SIUaRH080211; Sun, 28 May 2006 18:30:36 GMT (envelope-from silby) Message-Id: <200605281830.k4SIUaRH080211@repoman.freebsd.org> From: Mike Silbersack Date: Sun, 28 May 2006 18:30:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 18:31:46 -0000 silby 2006-05-28 18:30:36 UTC FreeBSD src repository Modified files: sys/i386/i386 busdma_machdep.c Log: Add a quick hack to ensure that bus_dmamem_alloc properly aligns small allocations with large alignment requirements. Add a panic to detect cases where we've still failed to properly align. Revision Changes Path 1.78 +14 -2 src/sys/i386/i386/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Sun May 28 18:32:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B93E16AFA9; Sun, 28 May 2006 18:32:43 +0000 (UTC) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9642943D58; Sun, 28 May 2006 18:32:42 +0000 (GMT) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SIVW6B080274; Sun, 28 May 2006 18:31:33 GMT (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SIVW3I080273; Sun, 28 May 2006 18:31:32 GMT (envelope-from silby) Message-Id: <200605281831.k4SIVW3I080273@repoman.freebsd.org> From: Mike Silbersack Date: Sun, 28 May 2006 18:31:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 18:32:44 -0000 silby 2006-05-28 18:31:32 UTC FreeBSD src repository Modified files: sys/amd64/amd64 busdma_machdep.c Log: MFi386 rev 1.78: Add a quick hack to ensure that bus_dmamem_alloc properly aligns small allocations with large alignment requirements. Add a panic to detect cases where we've still failed to properly align. Revision Changes Path 1.75 +14 -2 src/sys/amd64/amd64/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Sun May 28 18:41:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 317DA16C6D3; Sun, 28 May 2006 18:41:20 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3048343D67; Sun, 28 May 2006 18:41:16 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (2wb3tk2y5wvwgwyr@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.4/8.13.3) with ESMTP id k4SIfFeN034349; Sun, 28 May 2006 11:41:15 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.4/8.13.3/Submit) id k4SIfFir034348; Sun, 28 May 2006 11:41:15 -0700 (PDT) (envelope-from jmg) Date: Sun, 28 May 2006 11:41:15 -0700 From: John-Mark Gurney To: Alexander Leidinger Message-ID: <20060528184114.GR49081@funkthat.com> Mail-Followup-To: Alexander Leidinger , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200605261806.k4QI67D3007680@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200605261806.k4QI67D3007680@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 18:41:31 -0000 Alexander Leidinger wrote this message on Fri, May 26, 2006 at 18:06 +0000: > This is the kernel subsystem API documentation generation framework. a) where is a guide for the proper bit for documenting, hopefully it's simply adding a comment block in front of the function. b) I really hope we don't start adding machine parsable tags, as computers these days should be smart enough to parse data from human parsable text. (i.e. ever look at reStructuredText?) -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Sun May 28 18:42:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4F8416A6B3; Sun, 28 May 2006 18:42:57 +0000 (UTC) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7482643D46; Sun, 28 May 2006 18:42:57 +0000 (GMT) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SIflYu080875; Sun, 28 May 2006 18:41:47 GMT (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SIfl3Q080874; Sun, 28 May 2006 18:41:47 GMT (envelope-from silby) Message-Id: <200605281841.k4SIfl3Q080874@repoman.freebsd.org> From: Mike Silbersack Date: Sun, 28 May 2006 18:41:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bfe if_bfe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 18:43:06 -0000 silby 2006-05-28 18:41:47 UTC FreeBSD src repository Modified files: sys/dev/bfe if_bfe.c Log: 1. Make sure that the TX and RX descriptor rings are 4096 byte aligned. Also use BUS_DMA_ALLOCNOW to be on the safe side. 2. Look for the Descriptor Error, and Descriptor Protocol Error flags from the card, and down the interface if we detect either. #1 (along with fixes to busdma) makes sure that this card works in all memory situations. Prior to this change, it was just luck that 512 count RX/TX lists were properly aligned. Now we can use any size of RX/TX lists and still have them properly aligned. #2 ensures that we don't get into an endless interrupt storm if busdma fails us. Descriptor Protocol Error would occur if we misaligned the TX/RX rings, and Descriptor Error would occur if we tried to give the card descriptors or rings with addresses > 1G. Trying to reinitialize the card isn't going to fix these errors, hence we don't try. Revision Changes Path 1.39 +21 -6 src/sys/dev/bfe/if_bfe.c From owner-cvs-src@FreeBSD.ORG Sun May 28 18:44:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B59E16C7A2; Sun, 28 May 2006 18:44:13 +0000 (UTC) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB51643D67; Sun, 28 May 2006 18:44:09 +0000 (GMT) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SIgxks080921; Sun, 28 May 2006 18:42:59 GMT (envelope-from jmg@repoman.freebsd.org) Received: (from jmg@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SIgxlo080920; Sun, 28 May 2006 18:42:59 GMT (envelope-from jmg) Message-Id: <200605281842.k4SIgxlo080920@repoman.freebsd.org> From: John-Mark Gurney Date: Sun, 28 May 2006 18:42:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src MAINTAINERS X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 18:44:16 -0000 jmg 2006-05-28 18:42:59 UTC FreeBSD src repository Modified files: . MAINTAINERS Log: document that I'm still maintaining kqueue and want to review commits to it before they hit the tree... Revision Changes Path 1.133 +1 -0 src/MAINTAINERS From owner-cvs-src@FreeBSD.ORG Sun May 28 18:45:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C16D816AB33; Sun, 28 May 2006 18:45:49 +0000 (UTC) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C1CC43D55; Sun, 28 May 2006 18:45:49 +0000 (GMT) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SIido0081026; Sun, 28 May 2006 18:44:39 GMT (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SIidQR081025; Sun, 28 May 2006 18:44:39 GMT (envelope-from silby) Message-Id: <200605281844.k4SIidQR081025@repoman.freebsd.org> From: Mike Silbersack Date: Sun, 28 May 2006 18:44:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bfe if_bfereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 18:45:51 -0000 silby 2006-05-28 18:44:39 UTC FreeBSD src repository Modified files: sys/dev/bfe if_bfereg.h Log: Re-revert back to rev 1.8: - Reduce the number of RX and TX buffers bfe uses so that it does not use more bounce buffers than busdma is willing to allow it to use See if_bfe.c for comments on why this is now safe to do. Revision Changes Path 1.10 +2 -2 src/sys/dev/bfe/if_bfereg.h From owner-cvs-src@FreeBSD.ORG Sun May 28 18:45:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44D9516B3E8; Sun, 28 May 2006 18:45:57 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E75AA43D46; Sun, 28 May 2006 18:45:56 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SIiloh081056; Sun, 28 May 2006 18:44:47 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SIilSC081055; Sun, 28 May 2006 18:44:47 GMT (envelope-from rodrigc) Message-Id: <200605281844.k4SIilSC081055@repoman.freebsd.org> From: Craig Rodrigues Date: Sun, 28 May 2006 18:44:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern vfs_mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 18:45:59 -0000 rodrigc 2006-05-28 18:44:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern vfs_mount.c Log: MFC: 1.208 In devfs_first(), set mp->mnt_opt to a valid empty list of mount options instead of leaving it NULL. This eliminates a kernel panic when trying to do a mount -o update of /dev. Noticed by: cjsp Reviewed by: phk Revision Changes Path 1.196.2.9 +5 -0 src/sys/kern/vfs_mount.c From owner-cvs-src@FreeBSD.ORG Sun May 28 19:00:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E798716ABB9; Sun, 28 May 2006 19:00:38 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8DD4C43D48; Sun, 28 May 2006 19:00:38 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SIxSrW081738; Sun, 28 May 2006 18:59:28 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SIxSwX081737; Sun, 28 May 2006 18:59:28 GMT (envelope-from rodrigc) Message-Id: <200605281859.k4SIxSwX081737@repoman.freebsd.org> From: Craig Rodrigues Date: Sun, 28 May 2006 18:59:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/mountd mountd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 19:00:40 -0000 rodrigc 2006-05-28 18:59:28 UTC FreeBSD src repository Modified files: usr.sbin/mountd mountd.c Log: Do not log "can't delete export" messages if nmount() returns ENOTSUP. This eliminates spurious log entries for trying to delete exports for filesystems like devfs and procfs. Revision Changes Path 1.86 +1 -1 src/usr.sbin/mountd/mountd.c From owner-cvs-src@FreeBSD.ORG Sun May 28 19:14:19 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 947FA16AA82; Sun, 28 May 2006 19:14:19 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9E0B543D5E; Sun, 28 May 2006 19:14:18 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [IPv6:::1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k4SJC8ll095061; Sun, 28 May 2006 13:12:08 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 28 May 2006 13:12:12 -0600 (MDT) Message-Id: <20060528.131212.-1037137048.imp@bsdimp.com> To: netchild@freebsd.org From: "M. Warner Losh" In-Reply-To: <20060528123915.7fe8e278@Magellan.Leidinger.net> References: <20060527104539.1f4c0738@Magellan.Leidinger.net> <20060527200440.G79162@fledge.watson.org> <20060528123915.7fe8e278@Magellan.Leidinger.net> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, phk@phk.freebsd.dk, src-committers@freebsd.org, rwatson@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 19:14:20 -0000 In message: <20060528123915.7fe8e278@Magellan.Leidinger.net> Alexander Leidinger writes: : But when we have marked the internal functions as such, we can also : generate an official version without the internal functions. It's just : a switch. But so far I think we need to include everything until a : subsystem is fully documented. I think we should document everything and mark the *EXTERNAL* functions as such. I agree with your commentary about having full kernel docs, and approved API subset as well. However, kernel functions are by default internal unless we deside otherwise. : Since we have no API docs, everyone has to have a look at the kernel on : his own. This only provides a little bit of help here. We have api docs. Please don't say that we have none. There's a bunch of documentation in the man9 section of the man page. Sure, it is incomplete, misleading and obsolete in places, but it is documentation. : Since we are Open Source they can have a look and use unofficial parts : without our docs. But when we clearly say "this is for internal use : only", they can't moan. And we as developers have a benefit from the : docs too. I agree with this. I guess my only point of disagreement are the default sense of internal/external. Warner From owner-cvs-src@FreeBSD.ORG Sun May 28 19:16:11 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F3D816AD42; Sun, 28 May 2006 19:16:11 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from pasmtp.tele.dk (pasmtp.tele.dk [193.162.159.95]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1EAAB43D72; Sun, 28 May 2006 19:16:06 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (0x535c0e2a.sgnxx1.adsl-dhcp.tele.dk [83.92.14.42]) by pasmtp.tele.dk (Postfix) with ESMTP id 7FD1D1EC322; Sun, 28 May 2006 21:15:59 +0200 (CEST) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.6/8.13.6) with ESMTP id k4SJFtx8001922; Sun, 28 May 2006 21:15:55 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: "M. Warner Losh" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 28 May 2006 13:12:12 MDT." <20060528.131212.-1037137048.imp@bsdimp.com> Date: Sun, 28 May 2006 21:15:55 +0200 Message-ID: <1921.1148843755@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: rwatson@freebsd.org, src-committers@freebsd.org, netchild@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 19:16:13 -0000 In message <20060528.131212.-1037137048.imp@bsdimp.com>, "M. Warner Losh" write s: >In message: <20060528123915.7fe8e278@Magellan.Leidinger.net> > Alexander Leidinger writes: >: But when we have marked the internal functions as such, we can also >: generate an official version without the internal functions. It's just >: a switch. But so far I think we need to include everything until a >: subsystem is fully documented. > >I think we should document everything and mark the *EXTERNAL* >functions as such. Seconded. If Doxygen does not currently understand this much more sensible model, then it would be a worthwhile project to teach it about it. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sun May 28 19:16:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 78F3C16BBCD; Sun, 28 May 2006 19:16:27 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 72EA443D6D; Sun, 28 May 2006 19:16:20 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from Andro-Beta.Leidinger.net (p54A5F984.dip.t-dialin.net [84.165.249.132]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.4/8.13.4) with ESMTP id k4SJFsui078414; Sun, 28 May 2006 21:15:55 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k4SJGG8b055421; Sun, 28 May 2006 21:16:17 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Date: Sun, 28 May 2006 21:16:20 +0200 From: Alexander Leidinger To: John-Mark Gurney Message-ID: <20060528211620.766e0ed0@Magellan.Leidinger.net> In-Reply-To: <20060528184114.GR49081@funkthat.com> References: <200605261806.k4QI67D3007680@repoman.freebsd.org> <20060528184114.GR49081@funkthat.com> Organization: FreeBSD X-Mailer: Sylpheed-Claws 2.2.0 (GTK+ 2.8.17; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 19:16:37 -0000 Quoting John-Mark Gurney (Sun, 28 May 2006 11:41:15 -0700): > Alexander Leidinger wrote this message on Fri, May 26, 2006 at 18:06 +0000: > > This is the kernel subsystem API documentation generation framework. > > a) where is a guide for the proper bit for documenting, hopefully it's > simply adding a comment block in front of the function. > b) I really hope we don't start adding machine parsable tags, as > computers these days should be smart enough to parse data from human > parsable text. (i.e. ever look at reStructuredText?) It's not XML. The complete manual is at http://www.stack.nl/~dimitri/doxygen/manual.html How a comment in front of the function should look like is shown at http://www.stack.nl/~dimitri/doxygen/docblocks.html short: /** \brief Brief description. * Brief description continued. * * Detailed description starts here. */ A list of commands (like the \brief above) is at http://www.stack.nl/~dimitri/doxygen/commands.html Bye, Alexander. -- Selling GoodYear Eagle F1 235/40ZR18, 2x 4mm + 2x 5mm, ~150 EUR you have to pick it up between Germany/Saarland and Luxembourg/Capellen http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-cvs-src@FreeBSD.ORG Sun May 28 19:42:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1DCCB16A50A; Sun, 28 May 2006 19:42:01 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 198D443D53; Sun, 28 May 2006 19:41:59 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from Andro-Beta.Leidinger.net (p54A5F984.dip.t-dialin.net [84.165.249.132]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.4/8.13.4) with ESMTP id k4SJfVVl078508; Sun, 28 May 2006 21:41:32 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k4SJfr6d059097; Sun, 28 May 2006 21:41:54 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Date: Sun, 28 May 2006 21:41:57 +0200 From: Alexander Leidinger To: "M. Warner Losh" Message-ID: <20060528214157.71671d52@Magellan.Leidinger.net> In-Reply-To: <20060528.131212.-1037137048.imp@bsdimp.com> References: <20060527104539.1f4c0738@Magellan.Leidinger.net> <20060527200440.G79162@fledge.watson.org> <20060528123915.7fe8e278@Magellan.Leidinger.net> <20060528.131212.-1037137048.imp@bsdimp.com> Organization: FreeBSD X-Mailer: Sylpheed-Claws 2.2.0 (GTK+ 2.8.17; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new Cc: cvs-src@FreeBSD.org, phk@phk.freebsd.dk, src-committers@FreeBSD.org, rwatson@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 19:42:06 -0000 Quoting "M. Warner Losh" (Sun, 28 May 2006 13:12:12 -0600 (MDT)): > In message: <20060528123915.7fe8e278@Magellan.Leidinger.net> > Alexander Leidinger writes: > : But when we have marked the internal functions as such, we can also > : generate an official version without the internal functions. It's just > : a switch. But so far I think we need to include everything until a > : subsystem is fully documented. > > I think we should document everything and mark the *EXTERNAL* > functions as such. I agree with your commentary about having full > kernel docs, and approved API subset as well. However, kernel > functions are by default internal unless we deside otherwise. We can make this a 3-tier document. We can mark some functions as @internal, some without any special markup (they are public then), and some with some special comments/notes/whatever (we have to invent something). The functions marked as @internal are only for the use in the subsystem itself (maybe together with any other documented constraint). The functions without any special markup can be used in other subsystems of the kernel. And finally the special marked functions -- let's call them EXTERNAL -- can be used by 3rd party developers. How does this sound? > : Since we have no API docs, everyone has to have a look at the kernel on > : his own. This only provides a little bit of help here. > > We have api docs. Please don't say that we have none. There's a > bunch of documentation in the man9 section of the man page. Sure, it > is incomplete, misleading and obsolete in places, but it is > documentation. Sorry... there are docs which document the API, I agree. But we don't really have well known API documentation (as in high level overview, what fits together how, and such). You have to know what you want to do, then you can make use of plenty of docs. But if you don't know what you are searching, it's not easy (maybe more easy as in linux, I don't know, but not as easy as it could be). Bye, Alexander. -- Selling GoodYear Eagle F1 235/40ZR18, 2x 4mm + 2x 5mm, ~150 EUR you have to pick it up between Germany/Saarland and Luxembourg/Capellen http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-cvs-src@FreeBSD.ORG Sun May 28 20:01:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 727D316C148; Sun, 28 May 2006 20:01:23 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B9A343D77; Sun, 28 May 2006 20:01:12 +0000 (GMT) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SK03od086753; Sun, 28 May 2006 20:00:03 GMT (envelope-from dwmalone@repoman.freebsd.org) Received: (from dwmalone@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SK03NA086749; Sun, 28 May 2006 20:00:03 GMT (envelope-from dwmalone) Message-Id: <200605282000.k4SK03NA086749@repoman.freebsd.org> From: David Malone Date: Sun, 28 May 2006 20:00:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net bpf_filter.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 20:01:23 -0000 dwmalone 2006-05-28 20:00:02 UTC FreeBSD src repository Modified files: sys/net bpf_filter.c Log: Avoid unwanted sign extension of indexed byte load in bpf code. PR: 89748 Submitted by: Guy Harris Obtained from: NetBSD via OpenBSD MFC after: 2 weeks Revision Changes Path 1.27 +2 -2 src/sys/net/bpf_filter.c From owner-cvs-src@FreeBSD.ORG Sun May 28 20:05:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DFD4D16C88B; Sun, 28 May 2006 20:05:33 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 64EAB43D58; Sun, 28 May 2006 20:05:08 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [IPv6:::1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k4SK1aqD095602; Sun, 28 May 2006 14:01:36 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 28 May 2006 14:01:40 -0600 (MDT) Message-Id: <20060528.140140.652863809.imp@bsdimp.com> To: netchild@FreeBSD.ORG From: "M. Warner Losh" In-Reply-To: <20060528214157.71671d52@Magellan.Leidinger.net> References: <20060528123915.7fe8e278@Magellan.Leidinger.net> <20060528.131212.-1037137048.imp@bsdimp.com> <20060528214157.71671d52@Magellan.Leidinger.net> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.ORG, phk@phk.freebsd.dk, src-committers@FreeBSD.ORG, rwatson@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 20:05:42 -0000 In message: <20060528214157.71671d52@Magellan.Leidinger.net> Alexander Leidinger writes: : Quoting "M. Warner Losh" (Sun, 28 May 2006 13:12:12 -0600 (MDT)): : : > In message: <20060528123915.7fe8e278@Magellan.Leidinger.net> : > Alexander Leidinger writes: : > : But when we have marked the internal functions as such, we can also : > : generate an official version without the internal functions. It's just : > : a switch. But so far I think we need to include everything until a : > : subsystem is fully documented. : > : > I think we should document everything and mark the *EXTERNAL* : > functions as such. I agree with your commentary about having full : > kernel docs, and approved API subset as well. However, kernel : > functions are by default internal unless we deside otherwise. : : We can make this a 3-tier document. We can mark some functions as : @internal, some without any special markup (they are public then), and : some with some special comments/notes/whatever (we have to invent : something). : : The functions marked as @internal are only for the use in the subsystem : itself (maybe together with any other documented constraint). The : functions without any special markup can be used in other subsystems of : the kernel. And finally the special marked functions -- let's call them : EXTERNAL -- can be used by 3rd party developers. : : How does this sound? One area where we have had problems in the past is when the 2nd tier of functions changes. Many interfaces that the designer had intended to be private were used inappropriately elsewhere in the kernel. We have issues with this in vinum, many of the file system drivers, many of the tty drivers, etc. Of course, there used to be almost no documentation at all, so people just used what seemed right, despite the original author's intentions. Usually these sub-systems have well defined interfaces to each other, and other sub-systems calling in is a bad thing. Ditto with the driver <-> driver abstraction layers (tty, sound, etc). They should be using only what you call the external interfaces and nothing else. So I'm not sure how well your proposal maps to our current needs. : > : Since we have no API docs, everyone has to have a look at the kernel on : > : his own. This only provides a little bit of help here. : > : > We have api docs. Please don't say that we have none. There's a : > bunch of documentation in the man9 section of the man page. Sure, it : > is incomplete, misleading and obsolete in places, but it is : > documentation. : : Sorry... there are docs which document the API, I agree. But we don't : really have well known API documentation (as in high level overview, : what fits together how, and such). You have to know what you want to : do, then you can make use of plenty of docs. But if you don't know what : you are searching, it's not easy (maybe more easy as in linux, I don't : know, but not as easy as it could be). Again, between the handbook and the man pages we have this. It needs a lot of work, but we do have it. It shows what to do at a very rudamentary level, but you can find what you want. I'm not sure you'll ever find the high level overview in the sources. There's rarely a good place for it, and it changes with time. Warner From owner-cvs-src@FreeBSD.ORG Sun May 28 20:10:18 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE1BD16B687; Sun, 28 May 2006 20:10:18 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45BBA43D69; Sun, 28 May 2006 20:10:17 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (0d0i1xt7xqqcga5o@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.4/8.13.3) with ESMTP id k4SKAHvE036702; Sun, 28 May 2006 13:10:17 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.4/8.13.3/Submit) id k4SKAGg6036701; Sun, 28 May 2006 13:10:16 -0700 (PDT) (envelope-from jmg) Date: Sun, 28 May 2006 13:10:16 -0700 From: John-Mark Gurney To: Alexander Leidinger Message-ID: <20060528201016.GS49081@funkthat.com> Mail-Followup-To: Alexander Leidinger , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200605261806.k4QI67D3007680@repoman.freebsd.org> <20060528184114.GR49081@funkthat.com> <20060528211620.766e0ed0@Magellan.Leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060528211620.766e0ed0@Magellan.Leidinger.net> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 20:10:36 -0000 Alexander Leidinger wrote this message on Sun, May 28, 2006 at 21:16 +0200: > Quoting John-Mark Gurney (Sun, 28 May 2006 11:41:15 -0700): > A list of commands (like the \brief above) is at > http://www.stack.nl/~dimitri/doxygen/commands.html Yeh, that's what I was afraid of... :( I take it you didn't look at reStructuredText: http://docutils.sourceforge.net/rst.html Commands are sooo last century... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Sun May 28 20:10:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9A7E116C91F; Sun, 28 May 2006 20:10:28 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5631E43D69; Sun, 28 May 2006 20:10:28 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SK9IEW088542; Sun, 28 May 2006 20:09:18 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SK9Ius088541; Sun, 28 May 2006 20:09:18 GMT (envelope-from rodrigc) Message-Id: <200605282009.k4SK9Ius088541@repoman.freebsd.org> From: Craig Rodrigues Date: Sun, 28 May 2006 20:09:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/nullfs null_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 20:10:44 -0000 rodrigc 2006-05-28 20:09:18 UTC FreeBSD src repository Modified files: sys/fs/nullfs null_vfsops.c Log: Modify MNT_UPDATE behavior for nullfs so that it does not return EOPNOTSUPP if an "export" parameter was passed in. This should allow nullfs mounts to be NFS exported. PR: kern/87906 MFC after: 1 week Revision Changes Path 1.78 +7 -2 src/sys/fs/nullfs/null_vfsops.c From owner-cvs-src@FreeBSD.ORG Sun May 28 20:21:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D2E416CA20; Sun, 28 May 2006 20:21:11 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1645943D46; Sun, 28 May 2006 20:21:10 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k4SKL3Il061125; Sun, 28 May 2006 14:21:08 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <447A062F.90704@samsco.org> Date: Sun, 28 May 2006 14:21:03 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Craig Rodrigues References: <200605282009.k4SK9Ius088541@repoman.freebsd.org> In-Reply-To: <200605282009.k4SK9Ius088541@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/nullfs null_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 20:21:37 -0000 Craig Rodrigues wrote: > rodrigc 2006-05-28 20:09:18 UTC > > FreeBSD src repository > > Modified files: > sys/fs/nullfs null_vfsops.c > Log: > Modify MNT_UPDATE behavior for nullfs so that it does not > return EOPNOTSUPP if an "export" parameter was passed in. > This should allow nullfs mounts to be NFS exported. > > PR: kern/87906 > MFC after: 1 week > > Revision Changes Path > 1.78 +7 -2 src/sys/fs/nullfs/null_vfsops.c No, it won't. The null_checkexp routine is wrong. It should be removed so that the default stdcheckexp routine will be called. Why? Because what null_checkexp is doing right now is passing the call down to the lower filesystem. If that filesystem isn't also exported, then the call will fail. When you export nullfs, you are exporting the nullfs mountpoint, not the lower mountpoint. Thus, there is no need to play the mountpoint pivot games with this call. Scott From owner-cvs-src@FreeBSD.ORG Sun May 28 20:22:33 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 995E716BA02; Sun, 28 May 2006 20:21:59 +0000 (UTC) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from mail-gw0.york.ac.uk (mail-gw0.york.ac.uk [144.32.128.245]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD34F43D5C; Sun, 28 May 2006 20:21:58 +0000 (GMT) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from ury.york.ac.uk (ury.york.ac.uk [144.32.108.81]) by mail-gw0.york.ac.uk (8.13.6/8.13.6) with ESMTP id k4SKLs91004261; Sun, 28 May 2006 21:21:54 +0100 (BST) Received: from ury.york.ac.uk (localhost.york.ac.uk [127.0.0.1]) by ury.york.ac.uk (8.13.6/8.13.6) with ESMTP id k4SKMv04005407; Sun, 28 May 2006 21:22:57 +0100 (BST) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from localhost (gavin@localhost) by ury.york.ac.uk (8.13.6/8.13.6/Submit) with ESMTP id k4SKMvgS005404; Sun, 28 May 2006 21:22:57 +0100 (BST) (envelope-from gavin.atkinson@ury.york.ac.uk) X-Authentication-Warning: ury.york.ac.uk: gavin owned process doing -bs Date: Sun, 28 May 2006 21:22:57 +0100 (BST) From: Gavin Atkinson X-X-Sender: gavin@ury.york.ac.uk To: Hiroki Sato In-Reply-To: <200605271908.k4RJ87JM005208@repoman.freebsd.org> Message-ID: <20060528212022.J4753@ury.york.ac.uk> References: <200605271908.k4RJ87JM005208@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-York-MailScanner: Found to be clean X-York-MailScanner-From: gavin.atkinson@ury.york.ac.uk Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 20:22:36 -0000 On Sat, 27 May 2006, Hiroki Sato wrote: > hrs 2006-05-27 19:08:07 UTC > > Modified files: (Branch: RELENG_6) > release/doc/en_US.ISO8859-1/errata article.sgml > Log: > New errata item: 6.1R includes a small undocumented change > of some public definition names. I wonder if this should say "source and binary-level" rather than just "source-level", as it seems that the change in question exchanges the meaning of the values 18 and 19 in adition to renaming them. Gavin From owner-cvs-src@FreeBSD.ORG Sun May 28 20:33:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 20EA016BB1D; Sun, 28 May 2006 20:28:15 +0000 (UTC) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4438943D62; Sun, 28 May 2006 20:28:07 +0000 (GMT) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SKQvRs089664; Sun, 28 May 2006 20:26:57 GMT (envelope-from wilko@repoman.freebsd.org) Received: (from wilko@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SKQvrR089663; Sun, 28 May 2006 20:26:57 GMT (envelope-from wilko) Message-Id: <200605282026.k4SKQvrR089663@repoman.freebsd.org> From: Wilko Bulte Date: Sun, 28 May 2006 20:26:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/hardware/alpha proc-alpha.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 20:33:05 -0000 wilko 2006-05-28 20:26:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/hardware/alpha proc-alpha.sgml Log: Add pointer to historical overview of the various Alpha CPU models. Revision Changes Path 1.77.2.7 +8 -0 src/release/doc/en_US.ISO8859-1/hardware/alpha/proc-alpha.sgml From owner-cvs-src@FreeBSD.ORG Sun May 28 20:44:24 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 990D916CDEB; Sun, 28 May 2006 20:36:49 +0000 (UTC) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5650E43D46; Sun, 28 May 2006 20:36:49 +0000 (GMT) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SKZdmf090212; Sun, 28 May 2006 20:35:39 GMT (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SKZdKc090211; Sun, 28 May 2006 20:35:39 GMT (envelope-from silby) Message-Id: <200605282035.k4SKZdKc090211@repoman.freebsd.org> From: Mike Silbersack Date: Sun, 28 May 2006 20:35:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bfe if_bfe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 20:44:29 -0000 silby 2006-05-28 20:35:39 UTC FreeBSD src repository Modified files: sys/dev/bfe if_bfe.c Log: Back out the BUS_DMA_ALLOCNOW change from rev 1.39. Scottl informed me that it's unnecessary, as the TX/RX lists are static allocations. Revision Changes Path 1.40 +3 -3 src/sys/dev/bfe/if_bfe.c From owner-cvs-src@FreeBSD.ORG Sun May 28 21:10:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 940A816C78D; Sun, 28 May 2006 20:59:45 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1E04F43D53; Sun, 28 May 2006 20:59:45 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id A82E246BF1; Sun, 28 May 2006 16:59:44 -0400 (EDT) Date: Sun, 28 May 2006 21:59:44 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: "M. Warner Losh" In-Reply-To: <20060528.140140.652863809.imp@bsdimp.com> Message-ID: <20060528215904.B79162@fledge.watson.org> References: <20060528123915.7fe8e278@Magellan.Leidinger.net> <20060528.131212.-1037137048.imp@bsdimp.com> <20060528214157.71671d52@Magellan.Leidinger.net> <20060528.140140.652863809.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.ORG, phk@phk.freebsd.dk, src-committers@FreeBSD.ORG, netchild@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 21:10:38 -0000 On Sun, 28 May 2006, M. Warner Losh wrote: > : > : Since we have no API docs, everyone has to have a look at the kernel on > : > : his own. This only provides a little bit of help here. > : > > : > We have api docs. Please don't say that we have none. There's a > : > bunch of documentation in the man9 section of the man page. Sure, it > : > is incomplete, misleading and obsolete in places, but it is > : > documentation. > : > : Sorry... there are docs which document the API, I agree. But we don't > : really have well known API documentation (as in high level overview, > : what fits together how, and such). You have to know what you want to > : do, then you can make use of plenty of docs. But if you don't know what > : you are searching, it's not easy (maybe more easy as in linux, I don't > : know, but not as easy as it could be). > > Again, between the handbook and the man pages we have this. It needs a lot > of work, but we do have it. It shows what to do at a very rudamentary > level, but you can find what you want. > > I'm not sure you'll ever find the high level overview in the sources. > There's rarely a good place for it, and it changes with time. Historically, the BSD Book, and now the FreeBSD Book have served this role. Robert N M Watson From owner-cvs-src@FreeBSD.ORG Sun May 28 22:34:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3EF816CD75; Sun, 28 May 2006 22:16:38 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A4D8E43D5F; Sun, 28 May 2006 22:16:38 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SMFSbN005702; Sun, 28 May 2006 22:15:28 GMT (envelope-from kris@repoman.freebsd.org) Received: (from kris@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SMFSmK005701; Sun, 28 May 2006 22:15:28 GMT (envelope-from kris) Message-Id: <200605282215.k4SMFSmK005701@repoman.freebsd.org> From: Kris Kennaway Date: Sun, 28 May 2006 22:15:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern subr_stack.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 22:34:42 -0000 kris 2006-05-28 22:15:28 UTC FreeBSD src repository Modified files: sys/kern subr_stack.c Log: Correct typos MFC after: 2 weeks Revision Changes Path 1.3 +3 -3 src/sys/kern/subr_stack.c From owner-cvs-src@FreeBSD.ORG Sun May 28 22:58:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE17316B05F; Sun, 28 May 2006 22:47:03 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7948F43D48; Sun, 28 May 2006 22:47:03 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SMjr23007234; Sun, 28 May 2006 22:45:53 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SMjr3d007233; Sun, 28 May 2006 22:45:53 GMT (envelope-from rodrigc) Message-Id: <200605282245.k4SMjr3d007233@repoman.freebsd.org> From: Craig Rodrigues Date: Sun, 28 May 2006 22:45:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/nullfs null_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 22:58:08 -0000 rodrigc 2006-05-28 22:45:52 UTC FreeBSD src repository Modified files: sys/fs/nullfs null_vfsops.c Log: Remove incorrect null_checkexp() routine. This will allow the NFS server to call vfs_stdcheckexp() on the exported nullfs filesystem, not the underlying filesystem being nullfs mounted. If the lower filesystem was not NFS exported, then the NFS exported null filesystem would not work. Pointed out by: scottl PR: kern/87906 MFC after: 1 week Revision Changes Path 1.79 +0 -14 src/sys/fs/nullfs/null_vfsops.c From owner-cvs-src@FreeBSD.ORG Sun May 28 23:21:01 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id D0C6D16A791; Sun, 28 May 2006 23:19:54 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: Bruce Evans Date: Mon, 29 May 2006 07:19:49 +0800 User-Agent: KMail/1.8.2 References: <200605280440.k4S4ej96064322@repoman.freebsd.org> <200605282006.26364.davidxu@freebsd.org> <20060528223012.H2592@epsplex.bde.org> In-Reply-To: <20060528223012.H2592@epsplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200605290719.49433.davidxu@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 23:21:05 -0000 On Sunday 28 May 2006 21:58, Bruce Evans wrote: > OK if it is correct to not copy the environment. > I will revert changes, I think I should keep it safe as before. > BTW, your other patch that masks the top 16 bits in mxcsr needs to be > extended to sometimes mask 0x40 (DAZ). The amd64 arch manual says to > mask with mxcsr_mask which is in the fxsave image. Cleared bits in > mxcsr_mask indicate reserved bits in a future-proof way. Unfortunately, > this isn't past-proof so the following complications are needed: if > the CPU stores 0 in mxcsr_mask, it means that mxcsr_mask is not > supported; old CPUs (at least amd64 ones) that don't support mxcsr_mask > also don't support DAZ, so the correct mask for them is 0xFFBF. These > complications are implemented in Linux's i386 so I suppose they are > no-ops at worst for non-amd64 CPUs. Linux stores the mask in a global > variable. I think this breaks the asymmetric SMP case more than > necessary. process migrates from one CPU to another, I don't think you can use such CPUs in same system if they are different in this case. > FreeBSD's amd64 uses mxcsr_mask without fixing up the case > where it is 0. So does Linux-2.6.10's x86_64 (it Initializes the > global variable but doesn't use it). > > Behaviour of mxcsr and DAZ on some CPUs: > > AXP2600 (Barton): mxcsr_mask = 0; attempting to set DAZ traps > P3-800 (freefall): same as AXP2600 > A64 (Id0xf48 stepping 8): mxcsr_mask = 0xFFFF; setting DAZ works > > > } else > > +#endif I haven't tried DAZ bit, will you fix it ? > > vm_machdep.c is missing a DEV_NPX ifdef around the call here. Of course, > lots of things would break if the option to not use npx were exercised. > CPU_ENABLE_SSE is a silly option too. > yes, silly. > > state->sv_87.sv_env.en_cw = cw; > > newtd->td_pcb->pcb_flags |= PCB_NPXINITDONE; > > } > > Bruce From owner-cvs-src@FreeBSD.ORG Sun May 28 23:38:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 161D316A920; Sun, 28 May 2006 23:38:16 +0000 (UTC) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3B3F43D48; Sun, 28 May 2006 23:38:15 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SNb5iV010485; Sun, 28 May 2006 23:37:05 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SNb5Qh010484; Sun, 28 May 2006 23:37:05 GMT (envelope-from iedowse) Message-Id: <200605282337.k4SNb5Qh010484@repoman.freebsd.org> From: Ian Dowse Date: Sun, 28 May 2006 23:37:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb ehci.c ohci.c uhci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 23:38:16 -0000 iedowse 2006-05-28 23:37:04 UTC FreeBSD src repository Modified files: sys/dev/usb ehci.c ohci.c uhci.c Log: If a zero-length bulk or interrupt transfer is requested then assume USBD_FORCE_SHORT_XFER to ensure that we actually build and execute a transfer. This means that the various alloc_sqtd_chain functions will always construct a transfer, so it is safe to modify the allocated descriptors on return. Previously there were cases where a zero length transfer would cause a NULL dereference. Reported by: bp Revision Changes Path 1.47 +2 -1 src/sys/dev/usb/ehci.c 1.162 +7 -9 src/sys/dev/usb/ohci.c 1.169 +8 -8 src/sys/dev/usb/uhci.c From owner-cvs-src@FreeBSD.ORG Mon May 29 00:37:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27D8016A940; Mon, 29 May 2006 00:37:39 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D73AD43D48; Mon, 29 May 2006 00:37:38 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4T0aSCT014262; Mon, 29 May 2006 00:36:28 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4T0aS9b014261; Mon, 29 May 2006 00:36:28 GMT (envelope-from thompsa) Message-Id: <200605290036.k4T0aS9b014261@repoman.freebsd.org> From: Andrew Thompson Date: Mon, 29 May 2006 00:36:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/net if_bridge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 00:37:53 -0000 thompsa 2006-05-29 00:36:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/net if_bridge.c Log: MFC r1.59, 1.60 - Add support for fragmenting ipv4 packets - Recalculate the IP checksum after pfil(9) Together these allow NFS to work over the bridge Revision Changes Path 1.11.2.31 +101 -8 src/sys/net/if_bridge.c From owner-cvs-src@FreeBSD.ORG Mon May 29 00:41:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8309316A68B; Mon, 29 May 2006 00:41:27 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D4A143D4C; Mon, 29 May 2006 00:41:27 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4T0eGt3014490; Mon, 29 May 2006 00:40:16 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4T0eGSU014489; Mon, 29 May 2006 00:40:16 GMT (envelope-from thompsa) Message-Id: <200605290040.k4T0eGSU014489@repoman.freebsd.org> From: Andrew Thompson Date: Mon, 29 May 2006 00:40:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/net if_bridge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 00:41:28 -0000 thompsa 2006-05-29 00:40:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/net if_bridge.c Log: MFC r1.61: Fix style(9) nits, whitespace and parentheses. Revision Changes Path 1.11.2.32 +52 -61 src/sys/net/if_bridge.c From owner-cvs-src@FreeBSD.ORG Mon May 29 02:59:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6A8E16B3AF; Mon, 29 May 2006 02:59:52 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0EAC143D5E; Mon, 29 May 2006 02:59:48 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4T2wb7R029727; Mon, 29 May 2006 02:58:37 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4T2wbVe029726; Mon, 29 May 2006 02:58:37 GMT (envelope-from davidxu) Message-Id: <200605290258.k4T2wbVe029726@repoman.freebsd.org> From: David Xu Date: Mon, 29 May 2006 02:58:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/include npx.h src/sys/i386/isa npx.c src/sys/i386/i386 vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 02:59:53 -0000 davidxu 2006-05-29 02:58:37 UTC FreeBSD src repository Modified files: sys/i386/include npx.h sys/i386/isa npx.c sys/i386/i386 vm_machdep.c Log: Backout changes trying to inherit floating-point environment, although POSIX (susv3) requires this, but it is unclear what should be inherited, duplicating whole 387 stack for new thread seems to be unnecessary and dangerous. Revert to previous code, force a new thread to be started with clean FP state. Revision Changes Path 1.274 +1 -2 src/sys/i386/i386/vm_machdep.c 1.31 +0 -3 src/sys/i386/include/npx.h 1.169 +0 -35 src/sys/i386/isa/npx.c From owner-cvs-src@FreeBSD.ORG Mon May 29 03:06:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 987C116A7AC; Mon, 29 May 2006 03:06:01 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5475A43D46; Mon, 29 May 2006 03:06:01 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4T34ovQ031371; Mon, 29 May 2006 03:04:50 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4T34oL6031370; Mon, 29 May 2006 03:04:50 GMT (envelope-from rodrigc) Message-Id: <200605290304.k4T34oL6031370@repoman.freebsd.org> From: Craig Rodrigues Date: Mon, 29 May 2006 03:04:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/mountd Makefile mountd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 03:06:01 -0000 rodrigc 2006-05-29 03:04:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/mountd Makefile mountd.c Log: Convert mountd to use nmount(). Remove hardcoded dependencies on ufs, cd9660, msdosfs, and ntfs. MFC: mountd.c 1.84, 1.85, 1.86 - exclude changes to pass in errmsg mount option, because errmsg is not in RELENG_6's vfs_mount.c as a default mount option. Makefile 1.17 PR: bin/97642 Revision Changes Path 1.15.10.2 +6 -1 src/usr.sbin/mountd/Makefile 1.81.2.2 +128 -74 src/usr.sbin/mountd/mountd.c From owner-cvs-src@FreeBSD.ORG Mon May 29 03:17:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 886A516A546; Mon, 29 May 2006 03:17:25 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4345C43D46; Mon, 29 May 2006 03:17:25 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4T3GE3B031858; Mon, 29 May 2006 03:16:14 GMT (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4T3GEma031857; Mon, 29 May 2006 03:16:14 GMT (envelope-from hrs) Message-Id: <200605290316.k4T3GEma031857@repoman.freebsd.org> From: Hiroki Sato Date: Mon, 29 May 2006 03:16:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/hardware/alpha proc-alpha.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 03:17:26 -0000 hrs 2006-05-29 03:16:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/hardware/alpha proc-alpha.sgml Log: Unbreak build. Revision Changes Path 1.77.2.8 +1 -1 src/release/doc/en_US.ISO8859-1/hardware/alpha/proc-alpha.sgml From owner-cvs-src@FreeBSD.ORG Mon May 29 05:44:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3149B16A721; Mon, 29 May 2006 05:44:39 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E2F3F43D48; Mon, 29 May 2006 05:44:38 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4T5hRnY049712; Mon, 29 May 2006 05:43:27 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4T5hRQ6049711; Mon, 29 May 2006 05:43:27 GMT (envelope-from delphij) Message-Id: <200605290543.k4T5hRQ6049711@repoman.freebsd.org> From: Xin LI Date: Mon, 29 May 2006 05:43:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern subr_disk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 05:44:39 -0000 delphij 2006-05-29 05:43:26 UTC FreeBSD src repository Modified files: sys/kern subr_disk.c Log: Unexpand TAILQ_FIRST(foo) == NULL to TAILQ_EMPTY(foo). Revision Changes Path 1.87 +2 -2 src/sys/kern/subr_disk.c From owner-cvs-src@FreeBSD.ORG Mon May 29 06:13:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C46616A52F; Mon, 29 May 2006 06:13:16 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82B6243D60; Mon, 29 May 2006 06:13:13 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4T6C1TE055307; Mon, 29 May 2006 06:12:01 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4T6C1tV055306; Mon, 29 May 2006 06:12:01 GMT (envelope-from alc) Message-Id: <200605290612.k4T6C1tV055306@repoman.freebsd.org> From: Alan Cox Date: Mon, 29 May 2006 06:12:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sparc64/include pmap.h src/sys/sparc64/sparc64 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 06:13:44 -0000 alc 2006-05-29 06:12:01 UTC FreeBSD src repository Modified files: sys/sparc64/include pmap.h sys/sparc64/sparc64 pmap.c Log: MFalpha/amd64/arm/ia64 Retire pmap_track_modified(). We no longer need it because we do not create managed mappings within the clean submap. To prevent regressions, add assertions blocking the creation of managed mappings within the clean submap. Revision Changes Path 1.46 +0 -9 src/sys/sparc64/include/pmap.h 1.154 +7 -14 src/sys/sparc64/sparc64/pmap.c From owner-cvs-src@FreeBSD.ORG Mon May 29 07:34:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B944516A424; Mon, 29 May 2006 07:34:05 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id 39E8643D48; Mon, 29 May 2006 07:34:05 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 60E2C2088; Mon, 29 May 2006 09:33:58 +0200 (CEST) X-Spam-Tests: none X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on tim.des.no Received: from xps.des.no (des.no [80.203.243.180]) by tim.des.no (Postfix) with ESMTP id 5258B2082; Mon, 29 May 2006 09:33:58 +0200 (CEST) Received: by xps.des.no (Postfix, from userid 1001) id 2FA3A33CAD; Mon, 29 May 2006 09:33:58 +0200 (CEST) From: des@des.no (Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?=) To: Alexander Leidinger References: <20060527104539.1f4c0738@Magellan.Leidinger.net> <13817.1148720224@critter.freebsd.dk> <20060527123344.355119b8@Magellan.Leidinger.net> Date: Mon, 29 May 2006 09:33:57 +0200 In-Reply-To: <20060527123344.355119b8@Magellan.Leidinger.net> (Alexander Leidinger's message of "Sat, 27 May 2006 12:33:44 +0200") Message-ID: <863bet9tei.fsf@xps.des.no> User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 07:34:05 -0000 Alexander Leidinger writes: > AFAIK marking them as internal is not possible automatically. Sure it is. We have the Doxygen source code, don't we? DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Mon May 29 09:10:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 56C4816A457; Mon, 29 May 2006 09:10:11 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr5.xs4all.nl (smtp-vbr5.xs4all.nl [194.109.24.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9EB3F43D46; Mon, 29 May 2006 09:10:10 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr5.xs4all.nl (8.13.6/8.13.6) with ESMTP id k4T9A8RI023719; Mon, 29 May 2006 11:10:09 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.6/8.13.3) with ESMTP id k4T9A8HG036074; Mon, 29 May 2006 11:10:08 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.6/8.13.6/Submit) id k4T9A8Zh036073; Mon, 29 May 2006 11:10:08 +0200 (CEST) (envelope-from wb) Date: Mon, 29 May 2006 11:10:08 +0200 From: Wilko Bulte To: Hiroki Sato Message-ID: <20060529091008.GA36057@freebie.xs4all.nl> References: <200605290316.k4T3GEma031857@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200605290316.k4T3GEma031857@repoman.freebsd.org> User-Agent: Mutt/1.5.11 X-Virus-Scanned: by XS4ALL Virus Scanner Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/release/doc/en_US.ISO8859-1/hardware/alpha proc-alpha.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 09:10:11 -0000 On Mon, May 29, 2006 at 03:16:13AM +0000, Hiroki Sato wrote.. > hrs 2006-05-29 03:16:13 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > release/doc/en_US.ISO8859-1/hardware/alpha proc-alpha.sgml > Log: > Unbreak build. Hum.. Sorry.. -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon May 29 10:22:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A3FC16A444; Mon, 29 May 2006 10:22:39 +0000 (UTC) (envelope-from ru@ip.net.ua) Received: from cielago.ip.net.ua (cielago.ip.net.ua [82.193.96.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D82743D4C; Mon, 29 May 2006 10:22:37 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by cielago.ip.net.ua (8.13.6/8.13.6) with ESMTP id k4TAKjSx021957 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 29 May 2006 13:20:46 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.6/8.13.6) id k4TALQpL044673; Mon, 29 May 2006 13:21:27 +0300 (EEST) (envelope-from ru) Date: Mon, 29 May 2006 13:21:26 +0300 From: Ruslan Ermilov To: John-Mark Gurney Message-ID: <20060529102126.GD44223@ip.net.ua> References: <200605280715.k4S7Fa1E083206@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zCKi3GIZzVBPywwA" Content-Disposition: inline In-Reply-To: <200605280715.k4S7Fa1E083206@repoman.freebsd.org> User-Agent: Mutt/1.5.11 X-Virus-Scanned: by amavisd-new Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/file magic.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 10:22:39 -0000 --zCKi3GIZzVBPywwA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi John-Mark, On Sun, May 28, 2006 at 07:15:36AM +0000, John-Mark Gurney wrote: > jmg 2006-05-28 07:15:36 UTC >=20 > FreeBSD src repository >=20 > Modified files: > usr.bin/file magic.5=20 > Log: [...] > compiling mgc on a big endian system (specificly tested sparc64) breaks, > using one from a little endian system works > =20 > Revision Changes Path > 1.24 +18 -0 src/usr.bin/file/magic.5 >=20 I have another experience from cross-build research. Namely, only a native endianness format of *.mgc file works. Just confirmed this on a freshly installed 6.1-RELEASE: : Script started on Mon May 29 13:01:57 2006 : sun# uname -sm : FreeBSD sparc64 : sun# file magic.mgc* : magic.mgc: magic binary file for file(1) cmd (version 2) (big endian) : magic.mgc_: magic binary file for file(1) cmd (version 2) (little endian) : sun# file /bin/sh : /bin/sh: ELF 64-bit MSB executable, SPARC V9, version 1 (FreeBSD), dynami= cally linked (uses shared libs), stripped : sun# mv magic.mgc magic.mgc~ : sun# mv magic.mgc_ magic.mgc : sun# file /bin/sh : /bin/sh: data, dynamically linked (uses shared libs), stripped : sun# file magic.mgc* : magic.mgc: magic binary file for file(1) cmd (version 33554432) (big end= ian) : magic.mgc~: JPEG 2000 image : sun# exit : exit :=20 : Script done on Mon May 29 13:02:49 2006 I.e., using a LE magic.mgc gives bullshit on a BE system. Can you please re-check? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --zCKi3GIZzVBPywwA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEessmqRfpzJluFF4RAtFyAKCGW9OjBsnkF0zoDbdgAMMmthiCzgCffRJS s5Gtnryzyta6G+Eb1+jX8Ng= =FFAs -----END PGP SIGNATURE----- --zCKi3GIZzVBPywwA-- From owner-cvs-src@FreeBSD.ORG Mon May 29 10:57:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47EDE16A441; Mon, 29 May 2006 10:57:40 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 03A6043D46; Mon, 29 May 2006 10:57:40 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TAuRaZ009292; Mon, 29 May 2006 10:56:27 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TAuRNV009291; Mon, 29 May 2006 10:56:27 GMT (envelope-from maxim) Message-Id: <200605291056.k4TAuRNV009291@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 29 May 2006 10:56:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fifo/fifo_misc fifo_misc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 10:57:45 -0000 maxim 2006-05-29 10:56:27 UTC FreeBSD src repository Modified files: tools/regression/fifo/fifo_misc fifo_misc.c Log: o Test truncate(2) on fifo: it should ignore the request and return success. PR: kern/98064 Submitted by: Kirk Russell Revision Changes Path 1.5 +19 -0 src/tools/regression/fifo/fifo_misc/fifo_misc.c From owner-cvs-src@FreeBSD.ORG Mon May 29 10:58:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D40716A45D; Mon, 29 May 2006 10:58:31 +0000 (UTC) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E35AF43D55; Mon, 29 May 2006 10:58:25 +0000 (GMT) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TAvDWS009358; Mon, 29 May 2006 10:57:13 GMT (envelope-from jmg@repoman.freebsd.org) Received: (from jmg@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TAvD5k009357; Mon, 29 May 2006 10:57:13 GMT (envelope-from jmg) Message-Id: <200605291057.k4TAvD5k009357@repoman.freebsd.org> From: John-Mark Gurney Date: Mon, 29 May 2006 10:57:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/file magic.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 10:58:32 -0000 jmg 2006-05-29 10:57:13 UTC FreeBSD src repository Modified files: usr.bin/file magic.5 Log: remove comment about systems, I got confused which arch one of my systems was... Pointed out by: ru Revision Changes Path 1.25 +0 -4 src/usr.bin/file/magic.5 From owner-cvs-src@FreeBSD.ORG Mon May 29 10:59:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2CEDC16A44A; Mon, 29 May 2006 10:59:56 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id B96BB43D58; Mon, 29 May 2006 10:59:55 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (k3feyqrefj2neppp@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.4/8.13.3) with ESMTP id k4TAxt1f059752; Mon, 29 May 2006 03:59:55 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.4/8.13.3/Submit) id k4TAxtBE059751; Mon, 29 May 2006 03:59:55 -0700 (PDT) (envelope-from jmg) Date: Mon, 29 May 2006 03:59:55 -0700 From: John-Mark Gurney To: Ruslan Ermilov Message-ID: <20060529105954.GX49081@funkthat.com> References: <200605280715.k4S7Fa1E083206@repoman.freebsd.org> <20060529102126.GD44223@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060529102126.GD44223@ip.net.ua> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/file magic.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 10:59:56 -0000 Ruslan Ermilov wrote this message on Mon, May 29, 2006 at 13:21 +0300: > On Sun, May 28, 2006 at 07:15:36AM +0000, John-Mark Gurney wrote: > > jmg 2006-05-28 07:15:36 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.bin/file magic.5 > > Log: > [...] > > compiling mgc on a big endian system (specificly tested sparc64) breaks, > > using one from a little endian system works > > > > Revision Changes Path > > 1.24 +18 -0 src/usr.bin/file/magic.5 > > > I have another experience from cross-build research. Namely, > only a native endianness format of *.mgc file works. Just > confirmed this on a freshly installed 6.1-RELEASE: > > : Script started on Mon May 29 13:01:57 2006 > : sun# uname -sm > : FreeBSD sparc64 > : sun# file magic.mgc* > : magic.mgc: magic binary file for file(1) cmd (version 2) (big endian) > : magic.mgc_: magic binary file for file(1) cmd (version 2) (little endian) > : sun# file /bin/sh > : /bin/sh: ELF 64-bit MSB executable, SPARC V9, version 1 (FreeBSD), dynamically linked (uses shared libs), stripped > : sun# mv magic.mgc magic.mgc~ > : sun# mv magic.mgc_ magic.mgc > : sun# file /bin/sh > : /bin/sh: data, dynamically linked (uses shared libs), stripped > : sun# file magic.mgc* > : magic.mgc: magic binary file for file(1) cmd (version 33554432) (big endian) > : magic.mgc~: JPEG 2000 image > : sun# exit > : exit > : > : Script done on Mon May 29 13:02:49 2006 > > I.e., using a LE magic.mgc gives bullshit on a BE system. Can you > please re-check? This was w/ a -current system... Hmm. this is wierd: # cd /usr/share/misc # uname -a FreeBSD carbon.funkthat.com 7.0-CURRENT FreeBSD 7.0-CURRENT #27: Mon Apr 17 19:02:25 PDT 2006 jmg@carbon.funkthat.com:/usr/home/jmg/p4/world/src/sys/i386/compile/carbon i386 # file -C -m magic # file magic magic: magic text file for file(1) cmd # file /tmp/*.CRW Segmentation fault (core dumped) That last part was the wierd part... and if I copied the magic.mgc from my 5.4-R box, it worked fine w/ the same line to match the CRW... (See below before you point out that above isn't a sparc64 box) And the magic line is: # tail -n 1 magic 0 string II\x1a\x00 Canon RAW If I remove that line, the compile works, and file returns data: # file /tmp/*.CRW /tmp/CRW_0171.CRW: data Wow, I must of really been tired when I made that commit, now that I think about it, I was testing i386 to i386.. so I'll drop the big endian bit, but it is a bit worry some that -current's file is broken.. # ident magic magic: $Id: Localstuff,v 1.4 2003/03/23 04:17:27 christos Exp $ Add the above magic line to that file, and I get a seg fault... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Mon May 29 11:01:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 77A8116A42A; Mon, 29 May 2006 11:01:23 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3259E43D46; Mon, 29 May 2006 11:01:23 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TB0Adm009584; Mon, 29 May 2006 11:00:10 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TB0A9N009583; Mon, 29 May 2006 11:00:10 GMT (envelope-from maxim) Message-Id: <200605291100.k4TB0A9N009583@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 29 May 2006 11:00:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/misc bsd-family-tree X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 11:01:23 -0000 maxim 2006-05-29 11:00:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/misc bsd-family-tree Log: MFC revs. 1.104, 1.105: add FreeBSD 5.5, correct dates. Revision Changes Path 1.95.2.5 +24 -21 src/share/misc/bsd-family-tree From owner-cvs-src@FreeBSD.ORG Mon May 29 11:06:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E051116A423; Mon, 29 May 2006 11:06:19 +0000 (UTC) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 380D043D46; Mon, 29 May 2006 11:06:19 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.13.4/8.13.3) with ESMTP id k4TB6Hs1027195; Mon, 29 May 2006 15:06:17 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Mon, 29 May 2006 15:06:17 +0400 (MSD) From: Maxim Konovalov To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <200605291056.k4TAuRNV009291@repoman.freebsd.org> Message-ID: <20060529150459.L26579@mp2.macomnet.net> References: <200605291056.k4TAuRNV009291@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Subject: Re: cvs commit: src/tools/regression/fifo/fifo_misc fifo_misc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 11:06:21 -0000 On Mon, 29 May 2006, 10:56-0000, Maxim Konovalov wrote: > maxim 2006-05-29 10:56:27 UTC > > FreeBSD src repository > > Modified files: > tools/regression/fifo/fifo_misc fifo_misc.c > Log: > o Test truncate(2) on fifo: it should ignore the request and > return success. > > PR: kern/98064 > Submitted by: Kirk Russell ATM this test just panics system. I hope we will fix this RSN. See kern/98064 for details. -- Maxim Konovalov From owner-cvs-src@FreeBSD.ORG Mon May 29 11:07:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA9CD16A42C; Mon, 29 May 2006 11:07:39 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4DE4E43D58; Mon, 29 May 2006 11:07:39 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TB6QW7011102; Mon, 29 May 2006 11:06:26 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TB6QY7011101; Mon, 29 May 2006 11:06:26 GMT (envelope-from maxim) Message-Id: <200605291106.k4TB6QY7011101@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 29 May 2006 11:06:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libc/stdlib strtol.3 strtoul.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 11:07:40 -0000 maxim 2006-05-29 11:06:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libc/stdlib strtol.3 strtoul.3 Log: MFC rev. 1.21 strtol.3 and rev. 1.22 strtoul.3: .Xr strtonum(3). Revision Changes Path 1.20.2.1 +1 -0 src/lib/libc/stdlib/strtol.3 1.21.2.1 +1 -0 src/lib/libc/stdlib/strtoul.3 From owner-cvs-src@FreeBSD.ORG Mon May 29 11:09:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB6BF16A41F; Mon, 29 May 2006 11:09:27 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9439243D53; Mon, 29 May 2006 11:09:27 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TB8Ekp011290; Mon, 29 May 2006 11:08:14 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TB8E92011289; Mon, 29 May 2006 11:08:14 GMT (envelope-from maxim) Message-Id: <200605291108.k4TB8E92011289@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 29 May 2006 11:08:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/tools/debugscripts dot.gdbinit X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 11:09:28 -0000 maxim 2006-05-29 11:08:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) tools/debugscripts dot.gdbinit Log: MFC rev. 1.9: correct comments. Revision Changes Path 1.8.2.1 +2 -3 src/tools/debugscripts/dot.gdbinit From owner-cvs-src@FreeBSD.ORG Mon May 29 12:56:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3568E16A5D0; Mon, 29 May 2006 12:56:50 +0000 (UTC) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4D4143D46; Mon, 29 May 2006 12:56:49 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TCtaxg042502; Mon, 29 May 2006 12:55:36 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TCtas4042501; Mon, 29 May 2006 12:55:36 GMT (envelope-from nyan) Message-Id: <200605291255.k4TCtas4042501@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Mon, 29 May 2006 12:55:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/pc98 fixit-small_crunch.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 12:56:51 -0000 nyan 2006-05-29 12:55:36 UTC FreeBSD src repository Modified files: release/pc98 fixit-small_crunch.conf Log: Remove the telnet command because of filesystem full. Revision Changes Path 1.8 +0 -1 src/release/pc98/fixit-small_crunch.conf From owner-cvs-src@FreeBSD.ORG Mon May 29 14:09:18 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5024016A895; Mon, 29 May 2006 14:09:18 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 389D143D78; Mon, 29 May 2006 14:09:12 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout1.pacific.net.au (Postfix) with ESMTP id 9B76C328719; Tue, 30 May 2006 00:09:11 +1000 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k4TE99Sd019399; Tue, 30 May 2006 00:09:10 +1000 Date: Tue, 30 May 2006 00:09:10 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: David Xu In-Reply-To: <200605290719.49433.davidxu@freebsd.org> Message-ID: <20060530000449.A24521@delplex.bde.org> References: <200605280440.k4S4ej96064322@repoman.freebsd.org> <200605282006.26364.davidxu@freebsd.org> <20060528223012.H2592@epsplex.bde.org> <200605290719.49433.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 14:09:27 -0000 On Mon, 29 May 2006, David Xu wrote: > On Sunday 28 May 2006 21:58, Bruce Evans wrote: > >> OK if it is correct to not copy the environment. >> > I will revert changes, I think I should keep it safe as before. Thanks. I couldn't find any more details about this using google. >> ... old CPUs (at least amd64 ones) that don't support mxcsr_mask >> also don't support DAZ, so the correct mask for them is 0xFFBF. These >> complications are implemented in Linux's i386 so I suppose they are >> no-ops at worst for non-amd64 CPUs. Linux stores the mask in a global >> variable. I think this breaks the asymmetric SMP case more than >> necessary. > process migrates from one CPU to another, I don't think you can use such > CPUs in same system if they are different in this case. Only actually using DAZ is sure not to work. > I haven't tried DAZ bit, will you fix it ? No, not in -current, sorry. I'll check your fix for it. Bruce From owner-cvs-src@FreeBSD.ORG Mon May 29 14:44:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3DCA016AC8B; Mon, 29 May 2006 14:44:21 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A870743D48; Mon, 29 May 2006 14:44:19 +0000 (GMT) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TEh6iv054409; Mon, 29 May 2006 14:43:06 GMT (envelope-from matteo@repoman.freebsd.org) Received: (from matteo@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TEh6pS054408; Mon, 29 May 2006 14:43:06 GMT (envelope-from matteo) Message-Id: <200605291443.k4TEh6pS054408@repoman.freebsd.org> From: Matteo Riondato Date: Mon, 29 May 2006 14:43:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/etc/rc.d moused X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 14:44:21 -0000 matteo 2006-05-29 14:43:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc/rc.d moused Log: MFC rev 1.10: Correctly set moused_$2_enable when moused_nondefault_enable is set to NO PR: conf/92654 Revision Changes Path 1.9.2.1 +1 -2 src/etc/rc.d/moused From owner-cvs-src@FreeBSD.ORG Mon May 29 14:53:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F9AA16A4CA; Mon, 29 May 2006 14:53:06 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4A42C43D4C; Mon, 29 May 2006 14:53:06 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TEpqKg055063; Mon, 29 May 2006 14:51:52 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TEpqg6055062; Mon, 29 May 2006 14:51:52 GMT (envelope-from des) Message-Id: <200605291451.k4TEpqg6055062@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Mon, 29 May 2006 14:51:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools/tinderbox/etc releng_5.rc update_releng_5.rc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 14:53:06 -0000 des 2006-05-29 14:51:52 UTC FreeBSD src repository Modified files: tools/tools/tinderbox/etc releng_5.rc update_releng_5.rc Log: Add RELENG_5_5 to the 5.x lineup. Revision Changes Path 1.10 +1 -1 src/tools/tools/tinderbox/etc/releng_5.rc 1.4 +1 -1 src/tools/tools/tinderbox/etc/update_releng_5.rc From owner-cvs-src@FreeBSD.ORG Mon May 29 15:27:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A49516A806; Mon, 29 May 2006 15:27:03 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9DFF43D48; Mon, 29 May 2006 15:27:02 +0000 (GMT) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TFPnBH059323; Mon, 29 May 2006 15:25:49 GMT (envelope-from matteo@repoman.freebsd.org) Received: (from matteo@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TFPnBC059322; Mon, 29 May 2006 15:25:49 GMT (envelope-from matteo) Message-Id: <200605291525.k4TFPnBC059322@repoman.freebsd.org> From: Matteo Riondato Date: Mon, 29 May 2006 15:25:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/examples/etc README.examples X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 15:27:05 -0000 matteo 2006-05-29 15:25:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/examples/etc README.examples Log: MFC rev 1.15-1.16 Update README.examples according to the current state of the examples/etc directory PR: conf/97232 Revision Changes Path 1.14.8.1 +30 -18 src/share/examples/etc/README.examples From owner-cvs-src@FreeBSD.ORG Mon May 29 15:33:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E497B16AB7A; Mon, 29 May 2006 15:33:06 +0000 (UTC) (envelope-from ru@ip.net.ua) Received: from cielago.ip.net.ua (cielago.ip.net.ua [82.193.96.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C59543D5D; Mon, 29 May 2006 15:32:58 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by cielago.ip.net.ua (8.13.6/8.13.6) with ESMTP id k4TFVUmj055426 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 29 May 2006 18:31:31 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.6/8.13.6) id k4TFW2g3046389; Mon, 29 May 2006 18:32:02 +0300 (EEST) (envelope-from ru) Date: Mon, 29 May 2006 18:32:02 +0300 From: Ruslan Ermilov To: John-Mark Gurney Message-ID: <20060529153202.GE44223@ip.net.ua> References: <200605280715.k4S7Fa1E083206@repoman.freebsd.org> <20060529102126.GD44223@ip.net.ua> <20060529105954.GX49081@funkthat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ylS2wUBXLOxYXZFQ" Content-Disposition: inline In-Reply-To: <20060529105954.GX49081@funkthat.com> User-Agent: Mutt/1.5.11 X-Virus-Scanned: by amavisd-new Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/file magic.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 15:33:08 -0000 --ylS2wUBXLOxYXZFQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 29, 2006 at 03:59:55AM -0700, John-Mark Gurney wrote: > Hmm. this is wierd: > # cd /usr/share/misc > # uname -a > FreeBSD carbon.funkthat.com 7.0-CURRENT FreeBSD 7.0-CURRENT #27: Mon Apr = 17 19:02:25 PDT 2006 jmg@carbon.funkthat.com:/usr/home/jmg/p4/world/src= /sys/i386/compile/carbon i386 > # file -C -m magic > # file magic > magic: magic text file for file(1) cmd > # file /tmp/*.CRW > Segmentation fault (core dumped) >=20 > That last part was the wierd part... and if I copied the magic.mgc > from my 5.4-R box, it worked fine w/ the same line to match the CRW... > (See below before you point out that above isn't a sparc64 box) >=20 > And the magic line is: > # tail -n 1 magic > 0 string II\x1a\x00 Canon RAW >=20 > If I remove that line, the compile works, and file returns data: > # file /tmp/*.CRW > /tmp/CRW_0171.CRW: data >=20 > Wow, I must of really been tired when I made that commit, now that I > think about it, I was testing i386 to i386.. so I'll drop the big > endian bit, but it is a bit worry some that -current's file is broken.. >=20 > # ident magic > magic: > $Id: Localstuff,v 1.4 2003/03/23 04:17:27 christos Exp $ >=20 > Add the above magic line to that file, and I get a seg fault... >=20 It doesn't really matter what the last line looks like; everything that matches the last line will cause the file(1) to coredump. I verified on 7-CURRENT, i386 and amd64. NetBSD-current doesn't exhibit this problem. Hint: grep ^file /usr/src/MAINTAINERS Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --ylS2wUBXLOxYXZFQ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEexPyqRfpzJluFF4RAu7vAJ9NlP4uO2OyRWNqwPyub+Vfz4vnhQCgklFV HNXu+ooJ/lPT48qUDmj/mG4= =/e7L -----END PGP SIGNATURE----- --ylS2wUBXLOxYXZFQ-- From owner-cvs-src@FreeBSD.ORG Mon May 29 15:47:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F1F5716B07A; Mon, 29 May 2006 15:47:43 +0000 (UTC) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id A0AFD43DD3; Mon, 29 May 2006 15:47:04 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.13.4/8.13.3) with ESMTP id k4TFl3l8066295; Mon, 29 May 2006 19:47:03 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Mon, 29 May 2006 19:47:03 +0400 (MSD) From: Maxim Konovalov To: Craig Rodrigues In-Reply-To: <200605261244.k4QCiCsl057619@repoman.freebsd.org> Message-ID: <20060529193947.M63890@mp2.macomnet.net> References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 15:47:55 -0000 Hi Craig, Reply to a random commit. On Fri, 26 May 2006, 12:44-0000, Craig Rodrigues wrote: > rodrigc 2006-05-26 12:44:12 UTC > > FreeBSD src repository > > Modified files: > sys/ufs/ffs ffs_vfsops.c > Log: > Remove "update" from ffs_opts. It has been moved to global_opts > in vfs_mount.c. It seems after recent changes our mount code behaves in very strange way: [root@sonnie ~]# grep vol0 /etc/exports /vol0 -ro [root@sonnie ~]# mount | grep vol0 /dev/ad0s2d on /vol0 (ufs, NFS exported, local, soft-updates) [root@sonnie ~]# mount -u -o ro /vol0 mount: /dev/ad0s2d: Operation not permitted [root@sonnie ~]# mount -u -r /vol0 mount: /dev/ad0s2d: Operation not permitted [root@sonnie ~]# sed -i.bak 's@/vol0@#/vol0@' /etc/exports && killall -HUP mountd [root@sonnie ~]# mount | grep vol0 /dev/ad0s2d on /vol0 (ufs, local, soft-updates) [root@sonnie ~]# mount -u -o ro /vol0 mount: /dev/ad0s2d: No such file or directory [root@sonnie ~]# mount -u -r /vol0 mount: /dev/ad0s2d: No such file or directory -- Maxim Konovalov From owner-cvs-src@FreeBSD.ORG Mon May 29 17:00:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AE2B16AC57; Mon, 29 May 2006 17:00:53 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB72143D4C; Mon, 29 May 2006 17:00:52 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TGxdET079665; Mon, 29 May 2006 16:59:39 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TGxdDg079664; Mon, 29 May 2006 16:59:39 GMT (envelope-from mjacob) Message-Id: <200605291659.k4TGxdDg079664@repoman.freebsd.org> From: Matt Jacob Date: Mon, 29 May 2006 16:59:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 17:00:53 -0000 mjacob 2006-05-29 16:59:39 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt_pci.c Log: When setting verbose, *set* it, don't *add* it. Revision Changes Path 1.30 +1 -1 src/sys/dev/mpt/mpt_pci.c From owner-cvs-src@FreeBSD.ORG Mon May 29 17:38:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1ED7916A488; Mon, 29 May 2006 17:38:57 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1E4AE43D46; Mon, 29 May 2006 17:38:55 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4THbffb083855; Mon, 29 May 2006 17:37:41 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4THbf0E083854; Mon, 29 May 2006 17:37:41 GMT (envelope-from ru) Message-Id: <200605291737.k4THbf0E083854@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 29 May 2006 17:37:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/midi midi.c sequencer.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 17:38:57 -0000 ru 2006-05-29 17:37:41 UTC FreeBSD src repository Modified files: sys/dev/sound/midi midi.c sequencer.c Log: Fix build with -Wundef. Revision Changes Path 1.18 +2 -2 src/sys/dev/sound/midi/midi.c 1.19 +2 -2 src/sys/dev/sound/midi/sequencer.c From owner-cvs-src@FreeBSD.ORG Mon May 29 17:56:18 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7255816A898; Mon, 29 May 2006 17:56:18 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E1F6143D72; Mon, 29 May 2006 17:56:11 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4THsvjn088495; Mon, 29 May 2006 17:54:57 GMT (envelope-from flz@repoman.freebsd.org) Received: (from flz@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4THsvVa088494; Mon, 29 May 2006 17:54:57 GMT (envelope-from flz) Message-Id: <200605291754.k4THsvVa088494@repoman.freebsd.org> From: Florent Thoumie Date: Mon, 29 May 2006 17:54:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/usb usbdevs uscanner.c src/share/man/man4 uscanner.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 17:56:23 -0000 flz 2006-05-29 17:54:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/usb usbdevs uscanner.c share/man/man4 uscanner.4 Log: MFC: - Add support for the Acer Acerscan 640BT. - Add documentation bits. src/sys/dev/usb/usbdevs: rev 1.256 -> 1.257 src/sys/dev/usb/uscanner.c: rev 1.69 -> 1.70 src/share/man/man4/uscanner.4: rev 1.23 -> 1.24 PR: usb/95616 Submitted by: Matthieu Guegan Revision Changes Path 1.18.2.2 +3 -1 src/share/man/man4/uscanner.4 1.232.2.13 +1 -0 src/sys/dev/usb/usbdevs 1.63.2.2 +1 -0 src/sys/dev/usb/uscanner.c From owner-cvs-src@FreeBSD.ORG Mon May 29 18:01:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6110E16A786; Mon, 29 May 2006 18:01:05 +0000 (UTC) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D08943D5A; Mon, 29 May 2006 18:01:02 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.13.4/8.13.3) with ESMTP id k4TI1018029463; Mon, 29 May 2006 22:01:00 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Mon, 29 May 2006 22:01:00 +0400 (MSD) From: Maxim Konovalov To: Craig Rodrigues In-Reply-To: <20060529193947.M63890@mp2.macomnet.net> Message-ID: <20060529215827.D78736@mp2.macomnet.net> References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 18:01:16 -0000 On Mon, 29 May 2006, 19:47+0400, Maxim Konovalov wrote: > Hi Craig, > > Reply to a random commit. > > On Fri, 26 May 2006, 12:44-0000, Craig Rodrigues wrote: > > > rodrigc 2006-05-26 12:44:12 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/ufs/ffs ffs_vfsops.c > > Log: > > Remove "update" from ffs_opts. It has been moved to global_opts > > in vfs_mount.c. > > It seems after recent changes our mount code behaves in very strange > way: > > [root@sonnie ~]# grep vol0 /etc/exports > /vol0 -ro > [root@sonnie ~]# mount | grep vol0 > /dev/ad0s2d on /vol0 (ufs, NFS exported, local, soft-updates) > [root@sonnie ~]# mount -u -o ro /vol0 > mount: /dev/ad0s2d: Operation not permitted > [root@sonnie ~]# mount -u -r /vol0 > mount: /dev/ad0s2d: Operation not permitted > [root@sonnie ~]# sed -i.bak 's@/vol0@#/vol0@' /etc/exports && killall > -HUP mountd > [root@sonnie ~]# mount | grep vol0 > /dev/ad0s2d on /vol0 (ufs, local, soft-updates) > [root@sonnie ~]# mount -u -o ro /vol0 > mount: /dev/ad0s2d: No such file or directory > [root@sonnie ~]# mount -u -r /vol0 > mount: /dev/ad0s2d: No such file or directory More stranges (different system with the same src): [root@fujic ~]# mount | grep vol0 /dev/ad0s2d on /vol0 (ufs, local, soft-updates) [root@fujic ~]# mount -u -o ro /vol0 [root@fujic ~]# mount | grep vol0 /dev/ad0s2d on /vol0 (ufs, local, soft-updates) [root@fujic ~]# mount -u -r /vol0 [root@fujic ~]# mount | grep vol0 /dev/ad0s2d on /vol0 (ufs, local, read-only, soft-updates) [root@fujic ~]# mount -u -o rw /vol0 [root@fujic ~]# mount | grep vol0 /dev/ad0s2d on /vol0 (ufs, local, soft-updates) So "mount -u -o ro" doesn't work but "mount -u -o rw" does. -- Maxim Konovalov From owner-cvs-src@FreeBSD.ORG Mon May 29 18:06:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B282E16A671; Mon, 29 May 2006 18:06:40 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40AF343D55; Mon, 29 May 2006 18:06:40 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TI5QPf090572; Mon, 29 May 2006 18:05:26 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TI5Q6o090571; Mon, 29 May 2006 18:05:26 GMT (envelope-from scottl) Message-Id: <200605291805.k4TI5Q6o090571@repoman.freebsd.org> From: Scott Long Date: Mon, 29 May 2006 18:05:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/modules/mfi Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 18:06:43 -0000 scottl 2006-05-29 18:05:26 UTC FreeBSD src repository Modified files: sys/modules/mfi Makefile Log: Remove cruft. Revision Changes Path 1.3 +0 -5 src/sys/modules/mfi/Makefile From owner-cvs-src@FreeBSD.ORG Mon May 29 18:42:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AEB116A5FD; Mon, 29 May 2006 18:42:11 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B206843D48; Mon, 29 May 2006 18:42:10 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TIeusa092525; Mon, 29 May 2006 18:40:56 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TIeuZn092524; Mon, 29 May 2006 18:40:56 GMT (envelope-from maxim) Message-Id: <200605291840.k4TIeuZn092524@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 29 May 2006 18:40:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/sockets/unix_cmsg Makefile README unix_cmsg.c unix_cmsg.t X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 18:42:11 -0000 maxim 2006-05-29 18:40:56 UTC FreeBSD src repository Added files: tools/regression/sockets/unix_cmsg Makefile README unix_cmsg.c unix_cmsg.t Log: o Add a collection of regression tests for ancillary (control) data passing for unix domain sockets, stream and datagram. There are 15 tests: Test/Type of socket STREAM DGRAM ---------------------------------------------------------------------- Sending, receiving cmsgcred 1 6 Receiving sockcred (listening socket has LOCAL_CREDS) 2 n/a Receiving sockcred (accepted socket has LOCAL_CREDS) 3 n/a Receiving sockcred n/a 7 Sending cmsgcred, receiving sockcred 4 8 Sending, receiving timestamp 5 9 Sending, receiving cmsgcred (no control data) 10 13 Sending cmsgcred, receiving sockcred (no control data) 11 14 Sending, receiving timestamp (no control data) 12 15 Currently we pass 8 tests. All the rest marked as TODO. PR: kern/90800 Submitted by: Andrey Simonenko Revision Changes Path 1.1 +7 -0 src/tools/regression/sockets/unix_cmsg/Makefile (new) 1.1 +127 -0 src/tools/regression/sockets/unix_cmsg/README (new) 1.1 +1632 -0 src/tools/regression/sockets/unix_cmsg/unix_cmsg.c (new) 1.1 +57 -0 src/tools/regression/sockets/unix_cmsg/unix_cmsg.t (new) From owner-cvs-src@FreeBSD.ORG Mon May 29 19:30:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 81AEC16A43E; Mon, 29 May 2006 19:30:57 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C00DA43D5C; Mon, 29 May 2006 19:30:56 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TJTgXG000161; Mon, 29 May 2006 19:29:42 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TJTgjb000160; Mon, 29 May 2006 19:29:42 GMT (envelope-from maxim) Message-Id: <200605291929.k4TJTgjb000160@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 29 May 2006 19:29:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 19:31:00 -0000 maxim 2006-05-29 19:29:41 UTC FreeBSD src repository Modified files: sys Makefile Log: o Add net80211/ to cscope dir list. Revision Changes Path 1.36 +4 -4 src/sys/Makefile From owner-cvs-src@FreeBSD.ORG Mon May 29 19:33:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C663216A45A; Mon, 29 May 2006 19:33:47 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82C6B43D55; Mon, 29 May 2006 19:33:47 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TJWXP3000453; Mon, 29 May 2006 19:32:33 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TJWXTu000446; Mon, 29 May 2006 19:32:33 GMT (envelope-from cognet) Message-Id: <200605291932.k4TJWXTu000446@repoman.freebsd.org> From: Olivier Houchard Date: Mon, 29 May 2006 19:32:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/sa11x0 sa11x0_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 19:33:53 -0000 cognet 2006-05-29 19:32:32 UTC FreeBSD src repository Modified files: sys/arm/sa11x0 sa11x0_var.h Log: Nuke sa11x0_attach_args. It's a NetBSDIsm, and we have no use for it. Submitted by: kevlo Revision Changes Path 1.3 +0 -9 src/sys/arm/sa11x0/sa11x0_var.h From owner-cvs-src@FreeBSD.ORG Mon May 29 08:11:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9EB6616A55E; Mon, 29 May 2006 08:11:12 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F79543D62; Mon, 29 May 2006 08:11:05 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from Andro-Beta.Leidinger.net (p54A5FF80.dip.t-dialin.net [84.165.255.128]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.4/8.13.4) with ESMTP id k4T8AU3o081576; Mon, 29 May 2006 10:10:31 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k4T8AxVH065780; Mon, 29 May 2006 10:10:59 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Mon, 29 May 2006 10:10:58 +0200 Message-ID: <20060529101058.obvbkq7a4gkk8o4k@netchild.homeip.net> X-Priority: 3 (Normal) Date: Mon, 29 May 2006 10:10:58 +0200 From: Alexander Leidinger To: "M. Warner Losh" References: <20060528123915.7fe8e278@Magellan.Leidinger.net> <20060528.131212.-1037137048.imp@bsdimp.com> <20060528214157.71671d52@Magellan.Leidinger.net> <20060528.140140.652863809.imp@bsdimp.com> In-Reply-To: <20060528.140140.652863809.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1) / FreeBSD-4.11 X-Virus-Scanned: by amavisd-new X-Mailman-Approved-At: Mon, 29 May 2006 20:07:09 +0000 Cc: cvs-src@FreeBSD.org, phk@phk.freebsd.dk, src-committers@FreeBSD.org, rwatson@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/doc/subsys Dependencies Doxyfile-cam Doxyfile-crypto Doxyfile-dev_pci Doxyfile-dev_sound Doxyfile-dev_usb Doxyfile-geom Doxyfile-i4b Doxyfile-kern Doxyfile-libkern Doxyfile-linux Doxyfile-net80211 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 08:11:24 -0000 Quoting "M. Warner Losh" (from Sun, 28 May 2006 =20 14:01:40 -0600 (MDT)): > In message: <20060528214157.71671d52@Magellan.Leidinger.net> > Alexander Leidinger writes: > : We can make this a 3-tier document. We can mark some functions as > : @internal, some without any special markup (they are public then), and > : some with some special comments/notes/whatever (we have to invent > : something). > : > : The functions marked as @internal are only for the use in the subsystem > : itself (maybe together with any other documented constraint). The > : functions without any special markup can be used in other subsystems of > : the kernel. And finally the special marked functions -- let's call them > : EXTERNAL -- can be used by 3rd party developers. > : > : How does this sound? > > One area where we have had problems in the past is when the 2nd tier > of functions changes. Many interfaces that the designer had intended > to be private were used inappropriately elsewhere in the kernel. We > have issues with this in vinum, many of the file system drivers, many > of the tty drivers, etc. Of course, there used to be almost no > documentation at all, so people just used what seemed right, despite > the original author's intentions. Usually these sub-systems have well > defined interfaces to each other, and other sub-systems calling in is > a bad thing. Ditto with the driver <-> driver abstraction layers > (tty, sound, etc). They should be using only what you call the > external interfaces and nothing else. So I'm not sure how well your > proposal maps to our current needs. Maybe I didn't expressed myself good enough... or we don't share the =20 same definition of 3rd party software. Let's assume we have a graph of software API layers in the kernel. =20 Some functions (=3D internal) in each node in the graph are only for use =20 in the same node. Some functions (=3D public) are allowed to be used in =20 directly connected adjacent nodes, and some functions (=3D external) are =20 allowed to be called "from everywhere". The "everywhere" part is a simplification, it doesn't make sense to =20 use the disk driver API when you write a sound driver, but it shows =20 what I have in mind regarding those 3 documentation levels. > : > : Since we have no API docs, everyone has to have a look at the kernel= on > : > : his own. This only provides a little bit of help here. > : > > : > We have api docs. Please don't say that we have none. There's a > : > bunch of documentation in the man9 section of the man page. Sure, it > : > is incomplete, misleading and obsolete in places, but it is > : > documentation. > : > : Sorry... there are docs which document the API, I agree. But we don't > : really have well known API documentation (as in high level overview, > : what fits together how, and such). You have to know what you want to > : do, then you can make use of plenty of docs. But if you don't know what > : you are searching, it's not easy (maybe more easy as in linux, I don't > : know, but not as easy as it could be). > > Again, between the handbook and the man pages we have this. It needs > a lot of work, but we do have it. It shows what to do at a very > rudamentary level, but you can find what you want. > > I'm not sure you'll ever find the high level overview in the sources. > There's rarely a good place for it, and it changes with time. The disclaimer I committed yesterday shows up on the front page of =20 every API documentation. It's just a file with some C style comments =20 and doxygen markup. A high level overview of a subsystem can be =20 written the same way and included in the generated documentation. And =20 an overview which handles the higher level perspective of several =20 subsystem can be written the same way. They don't have to be =20 integrated into the source files, but keeping it besides the source =20 files is just fine IMO. It's like putting a "design =20 decissions"-document beneath the source files (or a readme, install =20 instructions, upgrade hints, whatever). Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 guru, n: =09A computer owner who can read the manual. From owner-cvs-src@FreeBSD.ORG Mon May 29 20:08:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E48216A421; Mon, 29 May 2006 20:08:55 +0000 (UTC) (envelope-from cel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A7E543D46; Mon, 29 May 2006 20:08:55 +0000 (GMT) (envelope-from cel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TK7eHY008128; Mon, 29 May 2006 20:07:40 GMT (envelope-from cel@repoman.freebsd.org) Received: (from cel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TK7eO4008127; Mon, 29 May 2006 20:07:40 GMT (envelope-from cel) Message-Id: <200605292007.k4TK7eO4008127@repoman.freebsd.org> From: Chuck Lever Date: Mon, 29 May 2006 20:07:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/nfs4client nfs4_dev.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 20:08:55 -0000 cel 2006-05-29 20:07:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/nfs4client nfs4_dev.c Log: Add better sanity checking to the logic that handles ioctl processing for nfsclient and nfs4client in order to prevent local root users from panicing the system. MFC of nfs4client/nfs4_dev.c revision 1.9. PR: kern/77463 Submitted by: Wojciech A. Koszek Reviewed by: cel, rees Security: Local root users can panic the system at will Sponsored by: Network Appliance, Incorporated Revision Changes Path 1.7.2.1 +7 -4 src/sys/nfs4client/nfs4_dev.c From owner-cvs-src@FreeBSD.ORG Mon May 29 20:16:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A6D5A16A827; Mon, 29 May 2006 20:16:44 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 54BBC43D5A; Mon, 29 May 2006 20:16:44 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TKFTQZ009728; Mon, 29 May 2006 20:15:29 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TKFTBY009727; Mon, 29 May 2006 20:15:29 GMT (envelope-from mjacob) Message-Id: <200605292015.k4TKFTBY009727@repoman.freebsd.org> From: Matt Jacob Date: Mon, 29 May 2006 20:15:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 20:16:47 -0000 mjacob 2006-05-29 20:15:29 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt.h Log: Add a MPT_PRT_NEGOTIATION print level. Revision Changes Path 1.21 +1 -0 src/sys/dev/mpt/mpt.h From owner-cvs-src@FreeBSD.ORG Mon May 29 20:22:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF76616A5F9; Mon, 29 May 2006 20:22:25 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5924943D99; Mon, 29 May 2006 20:22:00 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TKKk5K009963; Mon, 29 May 2006 20:20:46 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TKKkgl009962; Mon, 29 May 2006 20:20:46 GMT (envelope-from mjacob) Message-Id: <200605292020.k4TKKkgl009962@repoman.freebsd.org> From: Matt Jacob Date: Mon, 29 May 2006 20:20:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt_raid.c mpt_raid.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 20:22:26 -0000 mjacob 2006-05-29 20:20:45 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt_raid.c mpt_raid.h Log: Add a mpt_is_raid_volume function which will tell you whether the passed target id is one of the RAID VolumeID. This result is used to decide whether to try and do actual SPI negotiations on the real side of the raid/passthru bus pair. The reason we check this is that we can have both RAID volumes and real devices on the same bus. Revision Changes Path 1.9 +19 -2 src/sys/dev/mpt/mpt_raid.c 1.5 +1 -0 src/sys/dev/mpt/mpt_raid.h From owner-cvs-src@FreeBSD.ORG Mon May 29 20:31:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D9C316A77E; Mon, 29 May 2006 20:31:55 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E585F43D72; Mon, 29 May 2006 20:31:54 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TKUeMA010755; Mon, 29 May 2006 20:30:40 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TKUerk010754; Mon, 29 May 2006 20:30:40 GMT (envelope-from mjacob) Message-Id: <200605292030.k4TKUerk010754@repoman.freebsd.org> From: Matt Jacob Date: Mon, 29 May 2006 20:30:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt_cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 20:31:56 -0000 mjacob 2006-05-29 20:30:40 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt_cam.c Log: + Change some debug messages to MPT_PRT_NEGOTIATE level (so we can see the results of SPI negotiation w/o being overwhelmed with other crap). + For U320 devices, check against both Settings *and* DV flags before deciding whether we need to skip actual SPI settings for a device. + Go back to creating a 'physical disk' side of a raid/passthru bus that is limited to the number of maximum physical disks. Actually, this isn't probably *quite* right yet for one RAID volume, and if we ever end up with finding a device that supports more than one RAID volume (not likely), it probably won't quite be right either. The problem here is that the creating of this 'physical' passthru sim is just a cheap way to leverage off the CAM midlayer to do our negotiation for us on the subentities that make up a RAID volume. It almost causes more trouble than it is worth because we have to remember which side we're talking to in terms of forming commands and which target ids are real and so on. Bleah. + Skip trying to actually do SPI settings for the RAID volumes on the real side of the raid/passthru bus pair- this just confuses the issue. The underlying real physical devices will have the negotiation performed and the Raid volume will inherit the resultant settings. At the sime time, non-RAID devices can be on the same real bus, so *do* perform negotiations with them. + At the end of doing all of the settings twiddling, *ahem*, remember to go update the settings on the card itself (dunno how this got nuked). At this point, negotiations *seem* to be being done (again) correctly for both RAID volumes and their subentities. And they seem to be *mostly* now right for other non-RAID entities on the same bus (I ended up with 3 out of 8 other disks still at narror/async- haven't the slightest idea why yes). Finally, negotiations on a normal bus seem to work (again). There's still more work coming into this area, but we're in the final stretch. Revision Changes Path 1.20 +79 -74 src/sys/dev/mpt/mpt_cam.c From owner-cvs-src@FreeBSD.ORG Mon May 29 20:35:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8155A16ABC1; Mon, 29 May 2006 20:35:43 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2370A43D73; Mon, 29 May 2006 20:35:43 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TKYSd1010998; Mon, 29 May 2006 20:34:28 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TKYSYP010997; Mon, 29 May 2006 20:34:28 GMT (envelope-from mjacob) Message-Id: <200605292034.k4TKYSYP010997@repoman.freebsd.org> From: Matt Jacob Date: Mon, 29 May 2006 20:34:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt.c mpt.h mpt_cam.c mpt_cam.h mpt_debug.c mpt_pci.c mpt_raid.c mpt_raid.h mpt_reg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 20:35:44 -0000 mjacob 2006-05-29 20:34:28 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt.c mpt.h mpt_cam.c mpt_cam.h mpt_debug.c mpt_pci.c mpt_raid.c mpt_raid.h mpt_reg.h Log: Add acknowledgements to LSI-Logic for support Revision Changes Path 1.30 +4 -0 src/sys/dev/mpt/mpt.c 1.22 +4 -0 src/sys/dev/mpt/mpt.h 1.21 +3 -0 src/sys/dev/mpt/mpt_cam.c 1.4 +3 -0 src/sys/dev/mpt/mpt_cam.h 1.16 +3 -0 src/sys/dev/mpt/mpt_debug.c 1.31 +3 -0 src/sys/dev/mpt/mpt_pci.c 1.10 +8 -0 src/sys/dev/mpt/mpt_raid.c 1.6 +8 -0 src/sys/dev/mpt/mpt_raid.h 1.4 +3 -0 src/sys/dev/mpt/mpt_reg.h From owner-cvs-src@FreeBSD.ORG Mon May 29 21:31:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 73A6716A449; Mon, 29 May 2006 21:31:29 +0000 (UTC) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 449D343E22; Mon, 29 May 2006 21:30:28 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TLSvwJ025596; Mon, 29 May 2006 21:28:57 GMT (envelope-from tegge@repoman.freebsd.org) Received: (from tegge@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TLSu32025595; Mon, 29 May 2006 21:28:56 GMT (envelope-from tegge) Message-Id: <200605292128.k4TLSu32025595@repoman.freebsd.org> From: Tor Egge Date: Mon, 29 May 2006 21:28:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_exit.c src/sys/vm vm_extern.h vm_glue.c vm_map.c vm_map.h vm_meter.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 21:31:35 -0000 tegge 2006-05-29 21:28:56 UTC FreeBSD src repository Modified files: sys/kern kern_exit.c sys/vm vm_extern.h vm_glue.c vm_map.c vm_map.h vm_meter.c Log: Close race between vmspace_exitfree() and exit1() and races between vmspace_exitfree() and vmspace_free() which could result in the same vmspace being freed twice. Factor out part of exit1() into new function vmspace_exit(). Attach to vmspace0 to allow old vmspace to be freed earlier. Add new function, vmspace_acquire_ref(), for obtaining a vmspace reference for a vmspace belonging to another process. Avoid changing vmspace refcount from 0 to 1 since that could also lead to the same vmspace being freed twice. Change vmtotal() and swapout_procs() to use vmspace_acquire_ref(). Reviewed by: alc Revision Changes Path 1.289 +2 -29 src/sys/kern/kern_exit.c 1.78 +2 -0 src/sys/vm/vm_extern.h 1.215 +3 -6 src/sys/vm/vm_glue.c 1.374 +91 -16 src/sys/vm/vm_map.c 1.119 +0 -1 src/sys/vm/vm_map.h 1.86 +6 -1 src/sys/vm/vm_meter.c From owner-cvs-src@FreeBSD.ORG Mon May 29 22:03:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A0E7216B367; Mon, 29 May 2006 22:03:15 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from nccn1.nccn.net (nccn1.nccn.net [12.165.58.11]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB14143D70; Mon, 29 May 2006 22:03:14 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (66-53-242-201.stkn.mdsg-pacwest.com [66.53.242.201] (may be forged)) by nccn1.nccn.net (8.12.8/8.12.8/*SLiM* NO UCE! [V13]) with ESMTP id k4TM2xMG026198; Mon, 29 May 2006 15:03:02 -0700 Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id k4TM2mjt021917; Mon, 29 May 2006 15:02:51 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200605292202.k4TM2mjt021917@gw.catspoiler.org> Date: Mon, 29 May 2006 15:02:48 -0700 (PDT) From: Don Lewis To: dds@FreeBSD.org In-Reply-To: <200605280724.k4S7OCl5083567@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii X-MailScanner-Information: Please contact the ISP for more information X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vnode_if.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 22:03:30 -0000 On 28 May, Diomidis Spinellis wrote: > dds 2006-05-28 07:24:12 UTC > > FreeBSD src repository > > Modified files: > sys/kern vnode_if.src > Log: > Add missing % signs in the lock annotations of the functions: > lookup, rename, strategy, islocked > The missing % sign meant that the lines were processed as plain > comments and the corresponding assertions were never generated. > > Revision Changes Path > 1.80 +8 -8 src/sys/kern/vnode_if.src [appearing from the void] The additional sanity checking generated by this patch made my system unbootable with DEBUG_VFS_LOCKS enabled. ASSERT_VI_UNLOCKED() calls are added to VOP_ISLOCKED_APV(), but there is an explicit call to VOP_ISLOCKED() in vput() with the vnode interlock held. This could be fixed by re-ordering the code in vput(), but there are also a number of places in lower level code that are called with the vnode interlock held that contain calls to ASSERT_VOP_LOCKED(), which in turn calls VOP_ISLOCKED(). Possible fixes: Specify the locking value as "-" for vop_islocked() in vnode_if.src Introduce a new locking value, similar to "=", but which skips the interlock check. Note: vnode_if.awk does not implement the "=" vnode lock assertion. The fdvp and fvp initial vnode lock state assertions can't be checked by the generated wrapper. If fdvp and fvp happen to be references to tdvp and/or tvp, which must be locked, then fdvp and/or fvp will also be locked. They should only be unlocked if they are different vnodes than tdvp and tvp. The proper sanity checking appears to be done in vop_rename_pre(). The initial lock value for fdvp and fvp should probably be set to "-" in vnode_if.src, or to another value that only generates the interlock assertion. VOP_RENAME_APV() calls ASSERT_VI_UNLOCKED() on tvp before and after the vop->vop_rename() call, even though tvp may be NULL. vnode_if.src specifies the initial lock state as "X", which indicates that the check should be skipped if the vnode pointer is NULL, but vnode_if.awk does not handle the "X" value at all, and adds an unconditional interlock check. vop_rename_pre() does the conditional vnode lock check, so maybe the interlock check could be done there as well and omitted from the wrapper. The final state is specified as "U", though this should also be a conditional check, but there is no vnode locking value that generates a conditional unlock assertion. vop_rename_post() does not do any lock state sanity checks. BTW, the VOP_ISLOCKED(9) man page does not document that the return value is the shared/exclusive lock type. [disappearing into the void] From owner-cvs-src@FreeBSD.ORG Mon May 29 22:41:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 871F216A8D6; Mon, 29 May 2006 22:41:21 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8934743D82; Mon, 29 May 2006 22:41:18 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TMe3lp030581; Mon, 29 May 2006 22:40:03 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TMe33H030580; Mon, 29 May 2006 22:40:03 GMT (envelope-from njl) Message-Id: <200605292240.k4TMe33H030580@repoman.freebsd.org> From: Nate Lawson Date: Mon, 29 May 2006 22:40:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/i386/cpufreq est.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 22:41:27 -0000 njl 2006-05-29 22:40:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/i386/cpufreq est.c Log: MFC: newer Intel and VIA C7-M support Revision Changes Path 1.7.2.1 +371 -17 src/sys/i386/cpufreq/est.c From owner-cvs-src@FreeBSD.ORG Tue May 30 00:44:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CCD116A880; Tue, 30 May 2006 00:44:23 +0000 (UTC) (envelope-from cel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 308F943D4C; Tue, 30 May 2006 00:44:23 +0000 (GMT) (envelope-from cel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4U0h8I0042726; Tue, 30 May 2006 00:43:08 GMT (envelope-from cel@repoman.freebsd.org) Received: (from cel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4U0h7BG042725; Tue, 30 May 2006 00:43:07 GMT (envelope-from cel) Message-Id: <200605300043.k4U0h7BG042725@repoman.freebsd.org> From: Chuck Lever Date: Tue, 30 May 2006 00:43:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/nfsclient nfs.h nfs_socket.c nfsmount.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 00:44:23 -0000 cel 2006-05-30 00:43:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/nfsclient nfs.h nfs_socket.c nfsmount.h Log: Refactor the NFS over UDP retransmit timeout estimation logic to allow the estimator to be more easily tuned and maintained. There should be no functional change except there is now a lower limit on the retransmit timeout to prevent the client from retransmitting faster than the server's disks can fill requests, and an upper limit to prevent the estimator from taking too long to retransmit during a server outage. Reviewed by: mohan, kris, silby Sponsored by: Network Appliance, Incorporated Revision Changes Path 1.90.2.1 +25 -0 src/sys/nfsclient/nfs.h 1.125.2.9 +131 -60 src/sys/nfsclient/nfs_socket.c 1.30.2.1 +2 -2 src/sys/nfsclient/nfsmount.h From owner-cvs-src@FreeBSD.ORG Tue May 30 01:54:18 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D3B9F16A782; Tue, 30 May 2006 01:54:18 +0000 (UTC) (envelope-from cel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D892943D6D; Tue, 30 May 2006 01:54:14 +0000 (GMT) (envelope-from cel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4U1qxu3054542; Tue, 30 May 2006 01:52:59 GMT (envelope-from cel@repoman.freebsd.org) Received: (from cel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4U1qxk4054541; Tue, 30 May 2006 01:52:59 GMT (envelope-from cel) Message-Id: <200605300152.k4U1qxk4054541@repoman.freebsd.org> From: Chuck Lever Date: Tue, 30 May 2006 01:52:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/nfs4client nfs4_vfsops.c src/sys/nfsclient nfs.h nfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 01:54:19 -0000 cel 2006-05-30 01:52:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/nfs4client nfs4_vfsops.c sys/nfsclient nfs.h nfs_vfsops.c Log: NFS over TCP retransmit behavior should default to a 60 second time out, mimicing the NFS reference implementation. NFS over TCP does not need fast retransmit timeouts, since network loss and congestion are managed by the transport (TCP), unlike with NFS over UDP. A long timeout prevents the unnecessary retransmission of non- idempotent NFS requests. Reviewed by: mohans, silby, rees? Sponsored by: Network Appliance, Incorporated Revision Changes Path 1.20.2.4 +8 -2 src/sys/nfs4client/nfs4_vfsops.c 1.90.2.2 +2 -1 src/sys/nfsclient/nfs.h 1.177.2.2 +7 -2 src/sys/nfsclient/nfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Tue May 30 02:11:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DF83D16AA68; Tue, 30 May 2006 02:11:17 +0000 (UTC) (envelope-from brooks@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 41F9D43D48; Tue, 30 May 2006 02:11:17 +0000 (GMT) (envelope-from brooks@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4U2A1rh056434; Tue, 30 May 2006 02:10:01 GMT (envelope-from brooks@repoman.freebsd.org) Received: (from brooks@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4U2A1Fk056433; Tue, 30 May 2006 02:10:01 GMT (envelope-from brooks) Message-Id: <200605300210.k4U2A1Fk056433@repoman.freebsd.org> From: Brooks Davis Date: Tue, 30 May 2006 02:10:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc netstart X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 02:11:29 -0000 brooks 2006-05-30 02:10:01 UTC FreeBSD src repository Modified files: etc netstart Log: Remove reference to no longer existant /etc/rc.d/pccard. PR: conf/98055 Submitted by: thierry herbelot Revision Changes Path 1.67 +0 -1 src/etc/netstart From owner-cvs-src@FreeBSD.ORG Tue May 30 02:33:53 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2234616A44F; Tue, 30 May 2006 02:33:53 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from rwcrmhc13.comcast.net (rwcrmhc13.comcast.net [204.127.192.83]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87AB943D48; Tue, 30 May 2006 02:33:52 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-24-147-19-128.hsd1.ma.comcast.net (c-71-233-168-2.hsd1.ma.comcast.net[71.233.168.2](misconfigured sender)) by comcast.net (rwcrmhc13) with ESMTP id <20060530023351m1300a39qde>; Tue, 30 May 2006 02:33:51 +0000 Received: from c-24-147-19-128.hsd1.ma.comcast.net (localhost [127.0.0.1]) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1) with ESMTP id k4U2XoQJ035875; Mon, 29 May 2006 22:33:51 -0400 (EDT) (envelope-from rodrigc@c-24-147-19-128.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1/Submit) id k4U2XoDS035874; Mon, 29 May 2006 22:33:50 -0400 (EDT) (envelope-from rodrigc) Date: Mon, 29 May 2006 22:33:49 -0400 From: Craig Rodrigues To: Maxim Konovalov Message-ID: <20060530023349.GA35840@crodrigues.org> References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> <20060529215827.D78736@mp2.macomnet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060529215827.D78736@mp2.macomnet.net> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 02:33:53 -0000 On Mon, May 29, 2006 at 10:01:00PM +0400, Maxim Konovalov wrote: > [root@fujic ~]# mount -u -r /vol0 > [root@fujic ~]# mount | grep vol0 > /dev/ad0s2d on /vol0 (ufs, local, read-only, soft-updates) > [root@fujic ~]# mount -u -o rw /vol0 > [root@fujic ~]# mount | grep vol0 > /dev/ad0s2d on /vol0 (ufs, local, soft-updates) > > So "mount -u -o ro" doesn't work but "mount -u -o rw" does. mount -u -o ro does not work, but mount -u -r works? I suspect I know what the problem is....it would require a fix to mount(8) which I didn't have time to get around to until now. -- Craig Rodrigues rodrigc@crodrigues.org From owner-cvs-src@FreeBSD.ORG Tue May 30 02:59:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F63016A4D0; Tue, 30 May 2006 02:59:53 +0000 (UTC) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99ABA43D48; Tue, 30 May 2006 02:59:52 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4U2wbZB059074; Tue, 30 May 2006 02:58:37 GMT (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4U2wb0X059073; Tue, 30 May 2006 02:58:37 GMT (envelope-from ps) Message-Id: <200605300258.k4U2wb0X059073@repoman.freebsd.org> From: Paul Saab Date: Tue, 30 May 2006 02:58:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern vfs_vnops.c src/sys/sys file.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 02:59:53 -0000 ps 2006-05-30 02:58:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern vfs_vnops.c sys/sys file.h Log: MFC: Allow concurrent read(2)/readv(2) access to a file. Lock file offset against multiple read calls. Revision Changes Path 1.233.2.2 +17 -4 src/sys/kern/vfs_vnops.c 1.70.2.1 +7 -1 src/sys/sys/file.h From owner-cvs-src@FreeBSD.ORG Tue May 30 03:45:34 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 481B216A464; Tue, 30 May 2006 03:45:34 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from sccrmhc12.comcast.net (sccrmhc12.comcast.net [63.240.77.82]) by mx1.FreeBSD.org (Postfix) with ESMTP id 874C443D46; Tue, 30 May 2006 03:45:33 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-24-147-19-128.hsd1.ma.comcast.net (c-71-233-168-2.hsd1.ma.comcast.net[71.233.168.2](misconfigured sender)) by comcast.net (sccrmhc12) with ESMTP id <2006053003453201200ek8t6e>; Tue, 30 May 2006 03:45:32 +0000 Received: from c-24-147-19-128.hsd1.ma.comcast.net (localhost [127.0.0.1]) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1) with ESMTP id k4U3jWLT036495; Mon, 29 May 2006 23:45:32 -0400 (EDT) (envelope-from rodrigc@c-24-147-19-128.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1/Submit) id k4U3jVxS036494; Mon, 29 May 2006 23:45:31 -0400 (EDT) (envelope-from rodrigc) Date: Mon, 29 May 2006 23:45:31 -0400 From: Craig Rodrigues To: Maxim Konovalov Message-ID: <20060530034531.GA36462@crodrigues.org> References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> <20060529215827.D78736@mp2.macomnet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060529215827.D78736@mp2.macomnet.net> User-Agent: Mutt/1.4.2.1i Cc: Craig Rodrigues , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 03:45:34 -0000 On Mon, May 29, 2006 at 10:01:00PM +0400, Maxim Konovalov wrote: > So "mount -u -o ro" doesn't work but "mount -u -o rw" does. Can you try the following patch? Index: mount.c =================================================================== RCS file: /home/ncvs/src/sbin/mount/mount.c,v retrieving revision 1.84 diff -u -u -r1.84 mount.c --- mount.c 10 May 2006 14:40:40 -0000 1.84 +++ mount.c 30 May 2006 03:39:32 -0000 @@ -184,6 +184,19 @@ return (0); } +static +int specified_ro(int argc, char *argv[]) +{ + int i; + for (i=1; i < argc; i++) { + if (strcmp(argv[i], "ro") == 0 && + strcmp(argv[i-1], "-o") == 0) { + return 1; + } + } + return 0; +} + int main(int argc, char *argv[]) { @@ -200,6 +213,9 @@ options = NULL; vfslist = NULL; vfstype = "ufs"; + + if (specified_ro(argc, argv)) + ro = 1; while ((ch = getopt(argc, argv, "adF:fo:prwt:uv")) != -1) switch (ch) { case 'a': -- Craig Rodrigues rodrigc@crodrigues.org From owner-cvs-src@FreeBSD.ORG Tue May 30 04:01:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E5EAD16A77B; Tue, 30 May 2006 04:01:39 +0000 (UTC) (envelope-from grog@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A2BD743D48; Tue, 30 May 2006 04:01:39 +0000 (GMT) (envelope-from grog@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4U40NH0070160; Tue, 30 May 2006 04:00:23 GMT (envelope-from grog@repoman.freebsd.org) Received: (from grog@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4U40NxT070159; Tue, 30 May 2006 04:00:23 GMT (envelope-from grog) Message-Id: <200605300400.k4U40NxT070159@repoman.freebsd.org> From: Greg Lehey Date: Tue, 30 May 2006 04:00:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/calendar day.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 04:01:41 -0000 grog 2006-05-30 04:00:23 UTC FreeBSD src repository Modified files: usr.bin/calendar day.c Log: Don't go past the end of the month with a repetitive entry of the style "every Monday": mon * Do Foo. Previously, at the end of the month, this could cause a printout of the following nature when invoked with -A 7: 36 May* Do Foo MFC after: 2 weeks Revision Changes Path 1.22 +3 -0 src/usr.bin/calendar/day.c From owner-cvs-src@FreeBSD.ORG Tue May 30 04:12:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 147C016A4DF; Tue, 30 May 2006 04:12:28 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.FreeBSD.org (Postfix) with ESMTP id BCEAE43D69; Tue, 30 May 2006 04:12:24 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.6/8.13.6) with ESMTP id k4U4CBXL048958; Tue, 30 May 2006 08:12:11 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.13.6/8.13.6/Submit) id k4U4CB9V048957; Tue, 30 May 2006 08:12:11 +0400 (MSD) (envelope-from ache) Date: Tue, 30 May 2006 08:12:10 +0400 From: Andrey Chernov To: Craig Rodrigues Message-ID: <20060530041210.GA48857@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Craig Rodrigues , Maxim Konovalov , Craig Rodrigues , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> <20060529215827.D78736@mp2.macomnet.net> <20060530034531.GA36462@crodrigues.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060530034531.GA36462@crodrigues.org> User-Agent: Mutt/1.5.11 Cc: Craig Rodrigues , cvs-src@FreeBSD.ORG, Maxim Konovalov , src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 04:12:28 -0000 On Mon, May 29, 2006 at 11:45:31PM -0400, Craig Rodrigues wrote: > + if (strcmp(argv[i], "ro") == 0 && > + strcmp(argv[i-1], "-o") == 0) { > + return 1; It looks like hack. There is comma separated list for -o needs to be fully parsed, f.e. '-o acls,ro' -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue May 30 05:58:25 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D29516A424; Tue, 30 May 2006 05:58:25 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from cantva.canterbury.ac.nz (cantva.canterbury.ac.nz [132.181.2.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BFDF43D4C; Tue, 30 May 2006 05:58:23 +0000 (GMT) (envelope-from andrew@fubar.geek.nz) Received: from CONVERSION-DAEMON.it.canterbury.ac.nz by it.canterbury.ac.nz (PMDF V6.2-X27 #31178) id <01M31IRJZ89S9UZOYB@it.canterbury.ac.nz>; Tue, 30 May 2006 17:58:21 +1200 (NEW ZEALAND STANDARD TIME) Received: from [192.168.1.10] ([222.155.31.185]) by it.canterbury.ac.nz (PMDF V6.2-X27 #31178) with ESMTPA id <01M31IRIZA5W9UY8G2@it.canterbury.ac.nz>; Tue, 30 May 2006 17:58:21 +1200 (NEW ZEALAND STANDARD TIME) Date: Tue, 30 May 2006 17:58:19 +1200 From: Andrew Turner In-reply-to: <10582.1148668175@critter.freebsd.dk> To: Poul-Henning Kamp Message-id: <447BDEFB.9090302@fubar.geek.nz> MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_uumUDU02hx4x+/xfROzXcg)" User-Agent: Thunderbird 1.5.0.2 (X11/20060425) References: <10582.1148668175@critter.freebsd.dk> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/ofw ofw_console.c src/sys/dev/zs zs.c src/sys/ia64/ia64 ssc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 05:58:25 -0000 This is a multi-part message in MIME format. --Boundary_(ID_uumUDU02hx4x+/xfROzXcg) Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Poul-Henning Kamp wrote: > NB: this may actually not compile. The attached patch makes it compile for me on PowerPC. It locks up when loading the console currently so I can't test it. Andrew > In message <200605261825.k4QIPYEB008871@repoman.freebsd.org>, Poul-Henning Kamp > writes: > >> phk 2006-05-26 18:25:34 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/ofw ofw_console.c >> sys/dev/zs zs.c >> sys/ia64/ia64 ssc.c >> Log: >> Update to new console api. >> >> Revision Changes Path >> 1.33 +11 -28 src/sys/dev/ofw/ofw_console.c >> 1.35 +1 -13 src/sys/dev/zs/zs.c >> 1.27 +10 -16 src/sys/ia64/ia64/ssc.c >> >> > > --Boundary_(ID_uumUDU02hx4x+/xfROzXcg) Content-type: text/plain; name="patch_cons" Content-transfer-encoding: 7bit Content-disposition: inline; filename="patch_cons" Index: ofw_console.c =================================================================== RCS file: /cvsroot/src/sys/dev/ofw/ofw_console.c,v retrieving revision 1.33 diff -u -r1.33 ofw_console.c --- ofw_console.c 26 May 2006 18:25:34 -0000 1.33 +++ ofw_console.c 29 May 2006 09:58:22 -0000 @@ -79,8 +79,7 @@ static cn_getc_t ofw_cngetc; static cn_putc_t ofw_cnputc; -CONSOLE_DRIVER(ofw) - ofw_cons_checkc, ofw_cons_putc, NULL); +CONSOLE_DRIVER(ofw); static void cn_drvinit(void *unused) @@ -227,7 +226,7 @@ tp = (struct tty *)v; - while ((c = ofw_cons_checkc(NULL)) != -1) { + while ((c = ofw_cngetc(NULL)) != -1) { if (tp->t_state & TS_ISOPEN) { ttyld_rint(tp, c); } @@ -237,7 +236,7 @@ } static void -ofw_cons_probe(struct consdev *cp) +ofw_cnprobe(struct consdev *cp) { int chosen; @@ -269,7 +268,7 @@ } static void -ofw_cneterm(struct consdev *cp) +ofw_cnterm(struct consdev *cp) { } --Boundary_(ID_uumUDU02hx4x+/xfROzXcg)-- From owner-cvs-src@FreeBSD.ORG Tue May 30 06:43:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D1E0716A421; Tue, 30 May 2006 06:43:19 +0000 (UTC) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F3D143D4C; Tue, 30 May 2006 06:43:19 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4U6g30s090451; Tue, 30 May 2006 06:42:03 GMT (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4U6g3cO090450; Tue, 30 May 2006 06:42:03 GMT (envelope-from ps) Message-Id: <200605300642.k4U6g3cO090450@repoman.freebsd.org> From: Paul Saab Date: Tue, 30 May 2006 06:42:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ciss ciss.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 06:43:19 -0000 ps 2006-05-30 06:42:03 UTC FreeBSD src repository Modified files: sys/dev/ciss ciss.c Log: Spin until a request structure is available in the ioctl path. Revision Changes Path 1.71 +2 -2 src/sys/dev/ciss/ciss.c From owner-cvs-src@FreeBSD.ORG Tue May 30 07:09:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7871216A424; Tue, 30 May 2006 07:09:58 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 322D643D46; Tue, 30 May 2006 07:09:58 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4U78f2Y099229; Tue, 30 May 2006 07:08:41 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4U78fbe099228; Tue, 30 May 2006 07:08:41 GMT (envelope-from cperciva) Message-Id: <200605300708.k4U78fbe099228@repoman.freebsd.org> From: Colin Percival Date: Tue, 30 May 2006 07:08:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/portsnap/portsnap portsnap.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 07:09:58 -0000 cperciva 2006-05-30 07:08:41 UTC FreeBSD src repository Modified files: usr.sbin/portsnap/portsnap portsnap.sh Log: Use some features of sh(1) which I didn't know about until today ("read" can read two variables at once; and suffix pattern deletion) to make the extract command fork fewer processes. With the portsnap snapshot and the ports tree in swap-backed memory disks on my 1.4GHz laptop, this reduces 178800 processes and 195/56/126 seconds of real/user/sys time to 44600 processes and 103/34/60 seconds. Revision Changes Path 1.25 +2 -5 src/usr.sbin/portsnap/portsnap/portsnap.sh From owner-cvs-src@FreeBSD.ORG Tue May 30 07:11:49 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7764516A43A; Tue, 30 May 2006 07:11:49 +0000 (UTC) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id D7C9C43D4C; Tue, 30 May 2006 07:11:46 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.13.4/8.13.3) with ESMTP id k4U7BYje096883; Tue, 30 May 2006 11:11:35 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Tue, 30 May 2006 11:11:34 +0400 (MSD) From: Maxim Konovalov To: Craig Rodrigues In-Reply-To: <20060530034531.GA36462@crodrigues.org> Message-ID: <20060530110750.A96470@mp2.macomnet.net> References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> <20060529215827.D78736@mp2.macomnet.net> <20060530034531.GA36462@crodrigues.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 07:11:52 -0000 On Mon, 29 May 2006, 23:45-0400, Craig Rodrigues wrote: > On Mon, May 29, 2006 at 10:01:00PM +0400, Maxim Konovalov wrote: > > So "mount -u -o ro" doesn't work but "mount -u -o rw" does. > > Can you try the following patch? It works for my particular case but as Ache says it doesn't work in general: [root@sonnie ~]# mount -u -o noexec,ro /vol0 [root@sonnie ~]# mount | grep vol0 /dev/ad0s2d on /vol0 (ufs, local, noexec, soft-updates) -- Maxim Konovalov From owner-cvs-src@FreeBSD.ORG Tue May 30 07:48:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2777116A42F; Tue, 30 May 2006 07:48:11 +0000 (UTC) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E286A43D55; Tue, 30 May 2006 07:48:09 +0000 (GMT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4U7krDP002539; Tue, 30 May 2006 07:46:53 GMT (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4U7kr2E002538; Tue, 30 May 2006 07:46:53 GMT (envelope-from harti) Message-Id: <200605300746.k4U7kr2E002538@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 30 May 2006 07:46:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: BEGEMOT Cc: Subject: cvs commit: src/contrib/bsnmp NEWS src/contrib/bsnmp/gensnmpdef gensnmpdef.1 gensnmpdef.c src/contrib/bsnmp/gensnmptree gensnmptree.1 gensnmptree.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 07:48:13 -0000 harti 2006-05-30 07:46:52 UTC FreeBSD src repository Modified files: (Branch: BEGEMOT) contrib/bsnmp NEWS contrib/bsnmp/gensnmpdef gensnmpdef.1 gensnmpdef.c contrib/bsnmp/gensnmptree gensnmptree.1 gensnmptree.c Log: Vendor patch: add support for the BITS construct and enumerations in both gensnmpdef and gensnmptree. Add include and typedef directives to gensnmptree. Submitted by: soc-sheryana (partly) Revision Changes Path 1.1.1.10 +4 -0 src/contrib/bsnmp/NEWS 1.1.1.5 +23 -8 src/contrib/bsnmp/gensnmpdef/gensnmpdef.1 1.1.1.3 +163 -9 src/contrib/bsnmp/gensnmpdef/gensnmpdef.c 1.1.1.7 +76 -27 src/contrib/bsnmp/gensnmptree/gensnmptree.1 1.1.1.11 +649 -70 src/contrib/bsnmp/gensnmptree/gensnmptree.c From owner-cvs-src@FreeBSD.ORG Tue May 30 07:58:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31B5216A44A; Tue, 30 May 2006 07:58:14 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF0FF43D48; Tue, 30 May 2006 07:58:13 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4U7uvuk003937; Tue, 30 May 2006 07:56:57 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4U7uv3S003936; Tue, 30 May 2006 07:56:57 GMT (envelope-from phk) Message-Id: <200605300756.k4U7uv3S003936@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 30 May 2006 07:56:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ofw ofw_console.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 07:58:15 -0000 phk 2006-05-30 07:56:57 UTC FreeBSD src repository Modified files: sys/dev/ofw ofw_console.c Log: Fix various typos and brainos in last commit. Submmited by: Andrew Turner Revision Changes Path 1.34 +4 -5 src/sys/dev/ofw/ofw_console.c From owner-cvs-src@FreeBSD.ORG Tue May 30 08:08:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B8DF616A41F; Tue, 30 May 2006 08:08:21 +0000 (UTC) (envelope-from Hartmut.Brandt@dlr.de) Received: from smtp-3.dlr.de (smtp-3.dlr.de [195.37.61.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15EA843D46; Tue, 30 May 2006 08:08:20 +0000 (GMT) (envelope-from Hartmut.Brandt@dlr.de) Received: from beagle.kn.op.dlr.de ([129.247.173.6]) by smtp-3.dlr.de over TLS secured channel with Microsoft SMTPSVC(6.0.3790.1830); Tue, 30 May 2006 10:08:19 +0200 Date: Tue, 30 May 2006 10:08:21 +0200 (CEST) From: Harti Brandt X-X-Sender: brandt_h@beagle.kn.op.dlr.de To: src-committers@FreeBSD.org In-Reply-To: <200605300746.k4U7kr2E002538@repoman.freebsd.org> Message-ID: <20060530100208.R86320@beagle.kn.op.dlr.de> References: <200605300746.k4U7kr2E002538@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 30 May 2006 08:08:19.0277 (UTC) FILETIME=[3630DFD0:01C683C0] Cc: cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/bsnmp NEWS src/contrib/bsnmp/gensnmpdef gensnmpdef.1 gensnmpdef.c src/contrib/bsnmp/gensnmptree gensnmptree.1 gensnmptree.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Harti Brandt List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 08:08:21 -0000 On Tue, 30 May 2006, Hartmut Brandt wrote: HB>harti 2006-05-30 07:46:52 UTC HB> HB> FreeBSD src repository HB> HB> Modified files: (Branch: BEGEMOT) HB> contrib/bsnmp NEWS HB> contrib/bsnmp/gensnmpdef gensnmpdef.1 gensnmpdef.c HB> contrib/bsnmp/gensnmptree gensnmptree.1 gensnmptree.c HB> Log: HB> Vendor patch: add support for the BITS construct and enumerations in both HB> gensnmpdef and gensnmptree. Add include and typedef directives to gensnmptree. HB> HB> Submitted by: soc-sheryana (partly) Ups. This should read soc-shteryana. Sorry. harti From owner-cvs-src@FreeBSD.ORG Tue May 30 09:40:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D12E616A4FD; Tue, 30 May 2006 09:40:26 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8237643D5D; Tue, 30 May 2006 09:40:11 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4U9csEc045233; Tue, 30 May 2006 09:38:54 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4U9csHi045232; Tue, 30 May 2006 09:38:54 GMT (envelope-from ru) Message-Id: <200605300938.k4U9csHi045232@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 30 May 2006 09:38:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/modules/acpi/acpi Makefile src/sys/modules/acpi/acpi_asus Makefile src/sys/modules/acpi/acpi_panasonic Makefile src/sys/modules/acpi/acpi_toshiba Makefile src/sys/modules/acpi/acpi_video Makefile src/sys/modules/fdc Makefile ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 09:40:29 -0000 ru 2006-05-30 09:38:54 UTC FreeBSD src repository Modified files: sys/modules/acpi/acpi Makefile sys/modules/acpi/acpi_asus Makefile sys/modules/acpi/acpi_panasonic Makefile sys/modules/acpi/acpi_toshiba Makefile sys/modules/acpi/acpi_video Makefile sys/modules/fdc Makefile sys/modules/geom/geom_eli Makefile sys/modules/cpufreq Makefile Log: Dike out WARNS from kernel module makefiles. Kernels and modules use a different mechanism for setting warning flags, and using WARNS here only has null or negative effects. Submitted by: bde (I think it means "submitted") Revision Changes Path 1.16 +0 -1 src/sys/modules/acpi/acpi/Makefile 1.8 +0 -1 src/sys/modules/acpi/acpi_asus/Makefile 1.4 +0 -1 src/sys/modules/acpi/acpi_panasonic/Makefile 1.5 +0 -1 src/sys/modules/acpi/acpi_toshiba/Makefile 1.6 +0 -1 src/sys/modules/acpi/acpi_video/Makefile 1.9 +0 -1 src/sys/modules/cpufreq/Makefile 1.15 +0 -1 src/sys/modules/fdc/Makefile 1.3 +0 -1 src/sys/modules/geom/geom_eli/Makefile From owner-cvs-src@FreeBSD.ORG Tue May 30 09:50:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AE0216AA4E; Tue, 30 May 2006 09:50:25 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1606143D5A; Tue, 30 May 2006 09:50:22 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 5058846D04; Tue, 30 May 2006 05:50:22 -0400 (EDT) Date: Tue, 30 May 2006 10:50:22 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Hartmut Brandt In-Reply-To: <200605300746.k4U7kr2E002538@repoman.freebsd.org> Message-ID: <20060530104925.E79162@fledge.watson.org> References: <200605300746.k4U7kr2E002538@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/bsnmp NEWS src/contrib/bsnmp/gensnmpdef gensnmpdef.1 gensnmpdef.c src/contrib/bsnmp/gensnmptree gensnmptree.1 gensnmptree.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 09:50:27 -0000 On Tue, 30 May 2006, Hartmut Brandt wrote: > harti 2006-05-30 07:46:52 UTC > > FreeBSD src repository > > Modified files: (Branch: BEGEMOT) > contrib/bsnmp NEWS > contrib/bsnmp/gensnmpdef gensnmpdef.1 gensnmpdef.c > contrib/bsnmp/gensnmptree gensnmptree.1 gensnmptree.c > Log: > Vendor patch: add support for the BITS construct and enumerations in both > gensnmpdef and gensnmptree. Add include and typedef directives to gensnmptree. > > Submitted by: soc-sheryana (partly) FYI, soc-shteryana is now shteryana. We decided the soc- thing wasn't all that helpful, and have renamed the accounts of students from last year. Well, not all yet, I'm working my way through, but certainly for soc2006 repeat participants we have. Robert N M Watson From owner-cvs-src@FreeBSD.ORG Tue May 30 09:54:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9FA616A556; Tue, 30 May 2006 09:54:06 +0000 (UTC) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 768EC43D46; Tue, 30 May 2006 09:54:03 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id k4U9s3OZ086615; Tue, 30 May 2006 02:54:03 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id k4U9s2lU086614; Tue, 30 May 2006 02:54:02 -0700 (PDT) (envelope-from obrien) Date: Tue, 30 May 2006 02:54:02 -0700 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20060530095402.GB86239@dragon.NUXI.org> References: <200605280715.k4S7Fa1E083206@repoman.freebsd.org> <20060529102126.GD44223@ip.net.ua> <20060529105954.GX49081@funkthat.com> <20060529153202.GE44223@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060529153202.GE44223@ip.net.ua> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/file magic.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 09:54:08 -0000 On Mon, May 29, 2006 at 06:32:02PM +0300, Ruslan Ermilov wrote: > It doesn't really matter what the last line looks like; everything > that matches the last line will cause the file(1) to coredump. > I verified on 7-CURRENT, i386 and amd64. NetBSD-current doesn't > exhibit this problem. Hint: grep ^file /usr/src/MAINTAINERS What is that suppose to mean?!? I don't see anything constructive from you - such as a patch in my inbox. -- -- David (obrien@FreeBSD.org) Q: Because it reverses the logical flow of conversation. A: Why is top-posting (putting a reply at the top of the message) frowned upon? From owner-cvs-src@FreeBSD.ORG Tue May 30 10:18:45 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B55D616A473; Tue, 30 May 2006 10:18:45 +0000 (UTC) (envelope-from ru@ip.net.ua) Received: from cielago.ip.net.ua (cielago.ip.net.ua [82.193.96.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id CDA5043D5E; Tue, 30 May 2006 10:18:42 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by cielago.ip.net.ua (8.13.6/8.13.6) with ESMTP id k4UAHh5e035084 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 30 May 2006 13:17:44 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.6/8.13.6) id k4UAIQnr061615; Tue, 30 May 2006 13:18:26 +0300 (EEST) (envelope-from ru) Date: Tue, 30 May 2006 13:18:25 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20060530101825.GC60856@ip.net.ua> References: <200605280715.k4S7Fa1E083206@repoman.freebsd.org> <20060529102126.GD44223@ip.net.ua> <20060529105954.GX49081@funkthat.com> <20060529153202.GE44223@ip.net.ua> <20060530095402.GB86239@dragon.NUXI.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="A6N2fC+uXW/VQSAv" Content-Disposition: inline In-Reply-To: <20060530095402.GB86239@dragon.NUXI.org> User-Agent: Mutt/1.5.11 X-Virus-Scanned: by amavisd-new Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/file magic.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 10:18:46 -0000 --A6N2fC+uXW/VQSAv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi David, On Tue, May 30, 2006 at 02:54:02AM -0700, David O'Brien wrote: > On Mon, May 29, 2006 at 06:32:02PM +0300, Ruslan Ermilov wrote: > > It doesn't really matter what the last line looks like; everything > > that matches the last line will cause the file(1) to coredump. > > I verified on 7-CURRENT, i386 and amd64. NetBSD-current doesn't > > exhibit this problem. Hint: grep ^file /usr/src/MAINTAINERS >=20 > What is that suppose to mean?!? >=20 > I don't see anything constructive from you - such as a patch in my inbox. > =20 Here's what I meant by the above: There's a bug in version 4.12 that we currently have that manifests itself as follows: # tail -1 magic 0 string FOO FOO # echo FOO | file - Segmentation fault (core dumped) Could you, as a maintainer, consider upgrading our file(1) to the latest version 4.16, where this problem seems to have been fixed? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --A6N2fC+uXW/VQSAv Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEfBvxqRfpzJluFF4RAqOqAJ92sy+R3SNLiL85Z8cPNo688vE0UgCgnM0h jHcy0B6/sMd2YMUN9L7kKrI= =uNCc -----END PGP SIGNATURE----- --A6N2fC+uXW/VQSAv-- From owner-cvs-src@FreeBSD.ORG Tue May 30 11:53:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5BD8816A420; Tue, 30 May 2006 11:53:16 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15A2643D46; Tue, 30 May 2006 11:53:16 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UBpwQ7058868; Tue, 30 May 2006 11:51:58 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UBpwbD058867; Tue, 30 May 2006 11:51:58 GMT (envelope-from cognet) Message-Id: <200605301151.k4UBpwbD058867@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 30 May 2006 11:51:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/sa11x0 assabet_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 11:53:16 -0000 cognet 2006-05-30 11:51:58 UTC FreeBSD src repository Modified files: sys/arm/sa11x0 assabet_machdep.c Log: Uncomment the call to cpu_idcache_wbinv_all() after the MMU has been enabled. It has been commented out for a reason I forgot but I suspect does not apply anymore. Technically speaking it's not required to do it, has the data and the instruction cache have been disabled in _start(). However, it may change in the future, so I don't want to rely on this behavior. Submitted by: kevlo Revision Changes Path 1.14 +1 -1 src/sys/arm/sa11x0/assabet_machdep.c From owner-cvs-src@FreeBSD.ORG Tue May 30 13:07:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CEA7316A449; Tue, 30 May 2006 13:07:11 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8174443D4C; Tue, 30 May 2006 13:07:11 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UD5s2O075480; Tue, 30 May 2006 13:05:54 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UD5rTr075479; Tue, 30 May 2006 13:05:53 GMT (envelope-from glebius) Message-Id: <200605301305.k4UD5rTr075479@repoman.freebsd.org> From: Gleb Smirnoff Date: Tue, 30 May 2006 13:05:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 13:07:12 -0000 glebius 2006-05-30 13:05:53 UTC FreeBSD src repository Modified files: . access Log: Welcome Paolo Pisati to src committers. He is working on libalias and ipfw and may be more network stuff in future. Approved by: core Revision Changes Path 1.772 +1 -0 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Tue May 30 13:11:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F62916A48B; Tue, 30 May 2006 13:11:09 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id CAB1243D48; Tue, 30 May 2006 13:11:08 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 87FAA46C57; Tue, 30 May 2006 09:11:08 -0400 (EDT) Date: Tue, 30 May 2006 14:11:08 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Gleb Smirnoff In-Reply-To: <200605301305.k4UD5rTr075479@repoman.freebsd.org> Message-ID: <20060530141009.A25073@fledge.watson.org> References: <200605301305.k4UD5rTr075479@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 13:11:10 -0000 On Tue, 30 May 2006, Gleb Smirnoff wrote: > glebius 2006-05-30 13:05:53 UTC > > FreeBSD src repository > > Modified files: > . access > Log: > Welcome Paolo Pisati to src committers. He is working on libalias and > ipfw and may be more network stuff in future. Paolo is also one of our Summer of Code 2006 students, working the project "Study, analyze and improve the interrupt handling infrastructure in FreeBSD" with John Baldwin as his mentor. Welcome, Paolo! Robert N M Watson From owner-cvs-src@FreeBSD.ORG Tue May 30 14:22:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBEF516A425; Tue, 30 May 2006 14:22:27 +0000 (UTC) (envelope-from benno@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7A9343D46; Tue, 30 May 2006 14:22:27 +0000 (GMT) (envelope-from benno@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UELABC005463; Tue, 30 May 2006 14:21:10 GMT (envelope-from benno@repoman.freebsd.org) Received: (from benno@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UEL9DN005462; Tue, 30 May 2006 14:21:09 GMT (envelope-from benno) Message-Id: <200605301421.k4UEL9DN005462@repoman.freebsd.org> From: Benno Rice Date: Tue, 30 May 2006 14:21:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/arm pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 14:22:35 -0000 benno 2006-05-30 14:21:09 UTC FreeBSD src repository Modified files: sys/arm/arm pmap.c Log: In pmap_mapdev we correctly round the address off to the nearest page boundary, but we must also add the offset back on to the va we return. Revision Changes Path 1.48 +1 -1 src/sys/arm/arm/pmap.c From owner-cvs-src@FreeBSD.ORG Tue May 30 14:23:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 89D0F16A4C2; Tue, 30 May 2006 14:23:56 +0000 (UTC) (envelope-from doginou@dong.ci0.org) Received: from dong.ci0.org (cognet.ci0.org [80.65.224.102]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F9FA43D4C; Tue, 30 May 2006 14:23:54 +0000 (GMT) (envelope-from doginou@dong.ci0.org) Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1]) by dong.ci0.org (8.13.6/8.13.4) with ESMTP id k4UEuxe0084470; Tue, 30 May 2006 16:57:00 +0200 (CEST) (envelope-from doginou@dong.ci0.org) Received: (from doginou@localhost) by dong.ci0.org (8.13.6/8.13.4/Submit) id k4UEuxxe084469; Tue, 30 May 2006 16:56:59 +0200 (CEST) (envelope-from doginou) Date: Tue, 30 May 2006 16:56:59 +0200 From: Olivier Houchard To: Benno Rice Message-ID: <20060530145659.GA84456@ci0.org> References: <200605301421.k4UEL9DN005462@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200605301421.k4UEL9DN005462@repoman.freebsd.org> User-Agent: Mutt/1.4.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/arm/arm pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 14:24:03 -0000 On Tue, May 30, 2006 at 02:21:09PM +0000, Benno Rice wrote: > benno 2006-05-30 14:21:09 UTC > > FreeBSD src repository > > Modified files: > sys/arm/arm pmap.c > Log: > In pmap_mapdev we correctly round the address off to the nearest page > boundary, but we must also add the offset back on to the va we return. > > Revision Changes Path > 1.48 +1 -1 src/sys/arm/arm/pmap.c Pointy hat to: cognet Thanks for fixing this ! Olivier From owner-cvs-src@FreeBSD.ORG Tue May 30 14:32:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90DDF16A8BB; Tue, 30 May 2006 14:32:36 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70AF643D82; Tue, 30 May 2006 14:32:27 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UEV9bJ006123; Tue, 30 May 2006 14:31:09 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UEV9Pe006122; Tue, 30 May 2006 14:31:09 GMT (envelope-from des) Message-Id: <200605301431.k4UEV9Pe006122@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Tue, 30 May 2006 14:31:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools README src/tools/tools/tinderbox .cvsignore Makefile powerpc.diff tbmaster.1 tbmaster.pl tinderbox.1 tinderbox.pl src/tools/tools/tinderbox/etc Makefile default.rc head.rc releng_4.rc releng_5.rc releng_6.rc ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 14:32:46 -0000 des 2006-05-30 14:31:09 UTC FreeBSD src repository Modified files: tools/tools README Removed files: tools/tools/tinderbox .cvsignore Makefile powerpc.diff tbmaster.1 tbmaster.pl tinderbox.1 tinderbox.pl tools/tools/tinderbox/etc Makefile default.rc head.rc releng_4.rc releng_5.rc releng_6.rc update_head.rc update_releng_4.rc update_releng_5.rc update_releng_6.rc tools/tools/tinderbox/www .cvsignore Makefile daemon.png.uu index.cgi tb.css valid-css.png.uu valid-xhtml10.png.uu Log: The tinderbox has moved to projcvs. Revision Changes Path 1.47 +0 -1 src/tools/tools/README 1.2 +0 -2 src/tools/tools/tinderbox/.cvsignore (dead) 1.10 +0 -15 src/tools/tools/tinderbox/Makefile (dead) 1.11 +0 -18 src/tools/tools/tinderbox/etc/Makefile (dead) 1.11 +0 -21 src/tools/tools/tinderbox/etc/default.rc (dead) 1.4 +0 -12 src/tools/tools/tinderbox/etc/head.rc (dead) 1.12 +0 -9 src/tools/tools/tinderbox/etc/releng_4.rc (dead) 1.11 +0 -9 src/tools/tools/tinderbox/etc/releng_5.rc (dead) 1.5 +0 -11 src/tools/tools/tinderbox/etc/releng_6.rc (dead) 1.3 +0 -4 src/tools/tools/tinderbox/etc/update_head.rc (dead) 1.4 +0 -4 src/tools/tools/tinderbox/etc/update_releng_4.rc (dead) 1.5 +0 -4 src/tools/tools/tinderbox/etc/update_releng_5.rc (dead) 1.4 +0 -4 src/tools/tools/tinderbox/etc/update_releng_6.rc (dead) 1.4 +0 -59 src/tools/tools/tinderbox/powerpc.diff (dead) 1.23 +0 -289 src/tools/tools/tinderbox/tbmaster.1 (dead) 1.64 +0 -590 src/tools/tools/tinderbox/tbmaster.pl (dead) 1.17 +0 -319 src/tools/tools/tinderbox/tinderbox.1 (dead) 1.49 +0 -663 src/tools/tools/tinderbox/tinderbox.pl (dead) 1.2 +0 -3 src/tools/tools/tinderbox/www/.cvsignore (dead) 1.7 +0 -25 src/tools/tools/tinderbox/www/Makefile (dead) 1.2 +0 -144 src/tools/tools/tinderbox/www/daemon.png.uu (dead) 1.27 +0 -201 src/tools/tools/tinderbox/www/index.cgi (dead) 1.6 +0 -65 src/tools/tools/tinderbox/www/tb.css (dead) 1.2 +0 -25 src/tools/tools/tinderbox/www/valid-css.png.uu (dead) 1.2 +0 -57 src/tools/tools/tinderbox/www/valid-xhtml10.png.uu (dead) From owner-cvs-src@FreeBSD.ORG Tue May 30 15:49:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0196E16A41F; Tue, 30 May 2006 15:49:14 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B165D43D5F; Tue, 30 May 2006 15:49:13 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UFltNq019761; Tue, 30 May 2006 15:47:55 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UFltOp019760; Tue, 30 May 2006 15:47:55 GMT (envelope-from cognet) Message-Id: <200605301547.k4UFltOp019760@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 30 May 2006 15:47:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/sa11x0 assabet_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 15:49:22 -0000 cognet 2006-05-30 15:47:55 UTC FreeBSD src repository Modified files: sys/arm/sa11x0 assabet_machdep.c Log: The Assabet has 32MB of RAM, not 16. Submitted by: kevlo Revision Changes Path 1.15 +3 -2 src/sys/arm/sa11x0/assabet_machdep.c From owner-cvs-src@FreeBSD.ORG Tue May 30 16:09:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 763EF16A988; Tue, 30 May 2006 16:09:17 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 334CF43D4C; Tue, 30 May 2006 16:09:17 +0000 (GMT) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UG7xDm023393; Tue, 30 May 2006 16:07:59 GMT (envelope-from matteo@repoman.freebsd.org) Received: (from matteo@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UG7xXh023392; Tue, 30 May 2006 16:07:59 GMT (envelope-from matteo) Message-Id: <200605301607.k4UG7xXh023392@repoman.freebsd.org> From: Matteo Riondato Date: Tue, 30 May 2006 16:07:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d jail X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 16:09:24 -0000 matteo 2006-05-30 16:07:59 UTC FreeBSD src repository Modified files: etc/rc.d jail Log: style(9) Revision Changes Path 1.33 +12 -12 src/etc/rc.d/jail From owner-cvs-src@FreeBSD.ORG Tue May 30 16:22:07 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 881C416A7AE; Tue, 30 May 2006 16:22:07 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 418B543D4C; Tue, 30 May 2006 16:22:07 +0000 (GMT) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UGKnLM023962; Tue, 30 May 2006 16:20:49 GMT (envelope-from matteo@repoman.freebsd.org) Received: (from matteo@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UGKnOf023961; Tue, 30 May 2006 16:20:49 GMT (envelope-from matteo) Message-Id: <200605301620.k4UGKnOf023961@repoman.freebsd.org> From: Matteo Riondato Date: Tue, 30 May 2006 16:20:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d jail src/etc/defaults rc.conf src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 16:22:08 -0000 matteo 2006-05-30 16:20:48 UTC FreeBSD src repository Modified files: etc/rc.d jail etc/defaults rc.conf share/man/man5 rc.conf.5 Log: Add jail__exec_afterstart rc.conf variable, where is 1,2 and so on. It specifies the command to be run as Nth after jail startup. sh(1)-fu by: Dario Freni PR: conf/97697 MFC after: 2 weeks Reviewed by: ru@ (man page) Revision Changes Path 1.286 +3 -0 src/etc/defaults/rc.conf 1.34 +35 -1 src/etc/rc.d/jail 1.298 +17 -1 src/share/man/man5/rc.conf.5 From owner-cvs-src@FreeBSD.ORG Tue May 30 16:56:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6735916AD6F; Tue, 30 May 2006 16:56:57 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 212F543D6B; Tue, 30 May 2006 16:56:57 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UGtc4v033350; Tue, 30 May 2006 16:55:38 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UGtcMA033349; Tue, 30 May 2006 16:55:38 GMT (envelope-from cognet) Message-Id: <200605301655.k4UGtcMA033349@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 30 May 2006 16:55:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/arm pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 16:57:02 -0000 cognet 2006-05-30 16:55:38 UTC FreeBSD src repository Modified files: sys/arm/arm pmap.c Log: In pmap_is_prefaultable(), assert that the pte isn't NULL if pmap_get_pde_pte() returns TRUE. Suggested by: ssouhlal Revision Changes Path 1.49 +1 -0 src/sys/arm/arm/pmap.c From owner-cvs-src@FreeBSD.ORG Tue May 30 17:21:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 32BC616A7AC; Tue, 30 May 2006 17:21:50 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id E52E443D46; Tue, 30 May 2006 17:21:49 +0000 (GMT) (envelope-from linimon@lonesome.com) Received: by mail.soaustin.net (Postfix, from userid 502) id 8893C4E08; Tue, 30 May 2006 12:21:49 -0500 (CDT) Date: Tue, 30 May 2006 12:21:49 -0500 To: Dag-Erling Smorgrav Message-ID: <20060530172149.GD28227@soaustin.net> References: <200605301431.k4UEV9Pe006122@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200605301431.k4UEV9Pe006122@repoman.freebsd.org> User-Agent: Mutt/1.5.9i From: linimon@lonesome.com (Mark Linimon) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/tools README src/tools/tools/tinderbox .cvsignore Makefile powerpc.diff tbmaster.1 tbmaster.pl tinderbox.1 tinderbox.pl src/tools/tools/tinderbox/etc Makefile default.rc head.rc releng_4.rc releng_5.rc releng_6.rc ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 17:22:01 -0000 On Tue, May 30, 2006 at 02:31:09PM +0000, Dag-Erling Smorgrav wrote: > The tinderbox has moved to projcvs. IMHO this is cool. mcl From owner-cvs-src@FreeBSD.ORG Tue May 30 17:44:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 19F5916A7B0; Tue, 30 May 2006 17:44:26 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E2BC343D68; Tue, 30 May 2006 17:44:22 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UHh4x5045786; Tue, 30 May 2006 17:43:04 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UHh4Nd045785; Tue, 30 May 2006 17:43:04 GMT (envelope-from mjacob) Message-Id: <200605301743.k4UHh4Nd045785@repoman.freebsd.org> From: Matt Jacob Date: Tue, 30 May 2006 17:43:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp_freebsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 17:44:33 -0000 mjacob 2006-05-30 17:43:04 UTC FreeBSD src repository Modified files: sys/dev/isp isp_freebsd.c Log: Don't set CAM_DEV_QFRZN when we get an ABORT_TASK. Just by itself, this makes no sense. Revision Changes Path 1.117 +1 -1 src/sys/dev/isp/isp_freebsd.c From owner-cvs-src@FreeBSD.ORG Tue May 30 18:42:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3DD316A7C7; Tue, 30 May 2006 18:42:45 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B1B3E43D46; Tue, 30 May 2006 18:42:45 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UIfRWn051649; Tue, 30 May 2006 18:41:27 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UIfRSO051648; Tue, 30 May 2006 18:41:27 GMT (envelope-from jkim) Message-Id: <200605301841.k4UIfRSO051648@repoman.freebsd.org> From: Jung-uk Kim Date: Tue, 30 May 2006 18:41:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pci agp_amd64.c agp_sis.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 18:42:53 -0000 jkim 2006-05-30 18:41:27 UTC FreeBSD src repository Modified files: sys/pci agp_amd64.c agp_sis.c Log: Move SiS 760 to where it belongs. PR: 98094 Submitted by: Mike M < mmcgus at yahoo dot com > Revision Changes Path 1.11 +2 -0 src/sys/pci/agp_amd64.c 1.20 +0 -2 src/sys/pci/agp_sis.c From owner-cvs-src@FreeBSD.ORG Tue May 30 19:04:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D88E16ABF7; Tue, 30 May 2006 19:04:11 +0000 (UTC) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 39C9343D69; Tue, 30 May 2006 19:04:11 +0000 (GMT) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UJ2qin052814; Tue, 30 May 2006 19:02:52 GMT (envelope-from wilko@repoman.freebsd.org) Received: (from wilko@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UJ2qGk052813; Tue, 30 May 2006 19:02:52 GMT (envelope-from wilko) Message-Id: <200605301902.k4UJ2qGk052813@repoman.freebsd.org> From: Wilko Bulte Date: Tue, 30 May 2006 19:02:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 19:04:22 -0000 wilko 2006-05-30 19:02:52 UTC FreeBSD src repository Modified files: . access Log: store adrian's commit bit for safekeeping per his request to core. With hat: core-secretary Approved by: core Revision Changes Path 1.773 +0 -1 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Tue May 30 19:11:37 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A2FC16AD31; Tue, 30 May 2006 19:11:37 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 152EA43D48; Tue, 30 May 2006 19:11:37 +0000 (GMT) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UJAInl054373; Tue, 30 May 2006 19:10:18 GMT (envelope-from matteo@repoman.freebsd.org) Received: (from matteo@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UJAIMw054372; Tue, 30 May 2006 19:10:18 GMT (envelope-from matteo) Message-Id: <200605301910.k4UJAIMw054372@repoman.freebsd.org> From: Matteo Riondato Date: Tue, 30 May 2006 19:10:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools/recoverdisk Makefile recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 19:11:48 -0000 matteo 2006-05-30 19:10:18 UTC FreeBSD src repository Modified files: tools/tools/recoverdisk Makefile recoverdisk.c Log: Make recoverdisk compile on amd64 and possibly other 64bit archs. Bump WARNS to 6. PR: amd64/97566 Reviewed by: phk@ MFC after: 3 days Revision Changes Path 1.5 +1 -1 src/tools/tools/recoverdisk/Makefile 1.7 +4 -4 src/tools/tools/recoverdisk/recoverdisk.c From owner-cvs-src@FreeBSD.ORG Tue May 30 19:19:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C570716AE03; Tue, 30 May 2006 19:19:20 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5AAD843D5D; Tue, 30 May 2006 19:19:20 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UJI17A054746; Tue, 30 May 2006 19:18:01 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UJI1VK054745; Tue, 30 May 2006 19:18:01 GMT (envelope-from ru) Message-Id: <200605301918.k4UJI1VK054745@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 30 May 2006 19:18:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf kern.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 19:19:34 -0000 ru 2006-05-30 19:18:01 UTC FreeBSD src repository Modified files: sys/conf kern.mk Log: Enable -Wundef warnings for kernel/module compiles. From cpp.info: `-Wundef' Warn whenever an identifier which is not a macro is encountered in an `#if' directive, outside of `defined'. Such identifiers are replaced with zero. Revision Changes Path 1.48 +4 -1 src/sys/conf/kern.mk From owner-cvs-src@FreeBSD.ORG Tue May 30 19:22:20 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 290F416A71F; Tue, 30 May 2006 19:22:20 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail11.syd.optusnet.com.au (mail11.syd.optusnet.com.au [211.29.132.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 965AC43D8F; Tue, 30 May 2006 19:21:48 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail11.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id k4UJLJWS009841 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Wed, 31 May 2006 05:21:19 +1000 Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.13.6/8.13.6) with ESMTP id k4UJLILV003141; Wed, 31 May 2006 05:21:18 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.13.6/8.13.6/Submit) id k4UJLIwT003140; Wed, 31 May 2006 05:21:18 +1000 (EST) (envelope-from peter) Date: Wed, 31 May 2006 05:21:18 +1000 From: Peter Jeremy To: Andrey Chernov , Craig Rodrigues , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20060530192118.GB723@turion.vk2pj.dyndns.org> References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> <20060529215827.D78736@mp2.macomnet.net> <20060530034531.GA36462@crodrigues.org> <20060530041210.GA48857@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060530041210.GA48857@nagual.pp.ru> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.11 Cc: Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 19:22:38 -0000 On Tue, 2006-May-30 08:12:10 +0400, Andrey Chernov wrote: >On Mon, May 29, 2006 at 11:45:31PM -0400, Craig Rodrigues wrote: > >> + if (strcmp(argv[i], "ro") == 0 && >> + strcmp(argv[i-1], "-o") == 0) { >> + return 1; > >It looks like hack. There is comma separated list for -o needs to be fully >parsed, f.e. '-o acls,ro' There's already code in mount(8) that understands how to merge conflicting option lists (from the command line and fstab). It needs to be taught that: - -r, ro and norw are equivalent - rw and noro are equivalent - -r/ro/norw and rw/noro are complementary. -- Peter Jeremy From owner-cvs-src@FreeBSD.ORG Tue May 30 19:25:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B9D016A6F3; Tue, 30 May 2006 19:25:21 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6567343D5F; Tue, 30 May 2006 19:25:20 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UJO1U7055156; Tue, 30 May 2006 19:24:01 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UJO1wZ055155; Tue, 30 May 2006 19:24:01 GMT (envelope-from ru) Message-Id: <200605301924.k4UJO1wZ055155@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 30 May 2006 19:24:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net bpf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 19:25:29 -0000 ru 2006-05-30 19:24:01 UTC FreeBSD src repository Modified files: sys/net bpf.c Log: Fix -Wundef warnings. Revision Changes Path 1.165 +7 -7 src/sys/net/bpf.c From owner-cvs-src@FreeBSD.ORG Tue May 30 19:30:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BAAA16AE70; Tue, 30 May 2006 19:30:46 +0000 (UTC) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id A8DFB43D64; Tue, 30 May 2006 19:30:39 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.13.4/8.13.3) with ESMTP id k4UJUceK070462; Tue, 30 May 2006 23:30:38 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Tue, 30 May 2006 23:30:38 +0400 (MSD) From: Maxim Konovalov To: Matteo Riondato In-Reply-To: <200605301910.k4UJAIMw054372@repoman.freebsd.org> Message-ID: <20060530232844.W69922@mp2.macomnet.net> References: <200605301910.k4UJAIMw054372@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/tools/recoverdisk Makefile recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 19:31:02 -0000 On Tue, 30 May 2006, 19:10-0000, Matteo Riondato wrote: > matteo 2006-05-30 19:10:18 UTC > > FreeBSD src repository > > Modified files: > tools/tools/recoverdisk Makefile recoverdisk.c > Log: > Make recoverdisk compile on amd64 and possibly other 64bit archs. > Bump WARNS to 6. > > PR: amd64/97566 > Reviewed by: phk@ > MFC after: 3 days Thanks! I didn't see amd64/97566 in freebsd-bugs maillist and can't find it in freebsd-bugs archive. Where did it go and why? -- Maxim Konovalov From owner-cvs-src@FreeBSD.ORG Tue May 30 19:38:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C279C16A894; Tue, 30 May 2006 19:38:10 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from vsmtp2.tin.it (vsmtp2.tin.it [212.216.176.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id C49D443D46; Tue, 30 May 2006 19:38:05 +0000 (GMT) (envelope-from matteo@FreeBSD.org) Received: from kaiser.sig11.org (82.50.117.52) by vsmtp2.tin.it (7.2.072.1) id 4477DF30003AA022; Tue, 30 May 2006 21:39:47 +0200 Received: by kaiser.sig11.org (Postfix, from userid 1000) id 1021C618D; Tue, 30 May 2006 21:38:04 +0200 (CEST) Date: Tue, 30 May 2006 21:38:04 +0200 From: Matteo Riondato To: Maxim Konovalov Message-ID: <20060530193804.GH29390@kaiser.sig11.org> Mail-Followup-To: Matteo Riondato , Maxim Konovalov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200605301910.k4UJAIMw054372@repoman.freebsd.org> <20060530232844.W69922@mp2.macomnet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060530232844.W69922@mp2.macomnet.net> User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/tools/recoverdisk Makefile recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 19:38:17 -0000 On Tue, May 30, 2006 at 11:30:38PM +0400, Maxim Konovalov wrote: > Thanks! I didn't see amd64/97566 in freebsd-bugs maillist and can't > find it in freebsd-bugs archive. Where did it go and why? $ARCH/XYZ bugs are mailed to freebsd-$ARCH@. IMHO all bug reports should be mailed to freebsd-bugs@ too, but I'm sure bugmasters@ had their reasons to do so. Best Regards -- Matteo Riondato FreeBSD Committer (http://www.freebsd.org) G.U.F.I. Staff Member (http://www.gufi.org) FreeSBIE Developer (http://www.freesbie.org) From owner-cvs-src@FreeBSD.ORG Tue May 30 19:38:18 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A521F16A8DA; Tue, 30 May 2006 19:38:12 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id F348143D46; Tue, 30 May 2006 19:38:11 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id k4UJc7dh040911; Tue, 30 May 2006 15:38:07 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Ruslan Ermilov Date: Tue, 30 May 2006 15:37:42 -0400 User-Agent: KMail/1.6.2 References: <200605301924.k4UJO1wZ055155@repoman.freebsd.org> In-Reply-To: <200605301924.k4UJO1wZ055155@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200605301537.44979.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV 0.88/1499/Mon May 29 16:35:17 2006 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net bpf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 19:38:26 -0000 On Tuesday 30 May 2006 03:24 pm, Ruslan Ermilov wrote: > ru 2006-05-30 19:24:01 UTC > > FreeBSD src repository > > Modified files: > sys/net bpf.c > Log: > Fix -Wundef warnings. > > Revision Changes Path > 1.165 +7 -7 src/sys/net/bpf.c Thanks! Jung-uk Kim From owner-cvs-src@FreeBSD.ORG Tue May 30 19:53:53 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BCEB16AAE3; Tue, 30 May 2006 19:53:53 +0000 (UTC) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 60E0C43D5D; Tue, 30 May 2006 19:53:52 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.13.4/8.13.3) with ESMTP id k4UJroh2070999; Tue, 30 May 2006 23:53:51 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Tue, 30 May 2006 23:53:50 +0400 (MSD) From: Maxim Konovalov To: linimon@freebsd.org In-Reply-To: <20060530193804.GH29390@kaiser.sig11.org> Message-ID: <20060530235134.I69922@mp2.macomnet.net> References: <200605301910.k4UJAIMw054372@repoman.freebsd.org> <20060530232844.W69922@mp2.macomnet.net> <20060530193804.GH29390@kaiser.sig11.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Matteo Riondato , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/tools/tools/recoverdisk Makefile recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 19:54:01 -0000 [ "To:" changed ] On Tue, 30 May 2006, 21:38+0200, Matteo Riondato wrote: > On Tue, May 30, 2006 at 11:30:38PM +0400, Maxim Konovalov wrote: > > Thanks! I didn't see amd64/97566 in freebsd-bugs maillist and can't > > find it in freebsd-bugs archive. Where did it go and why? > > $ARCH/XYZ bugs are mailed to freebsd-$ARCH@. IMHO all bug reports should be > mailed to freebsd-bugs@ too, but I'm sure bugmasters@ had their > reasons to do so. That's something new for me. Mark, is it possible to mail them to freebsd-bugs as well? -- Maxim Konovalov From owner-cvs-src@FreeBSD.ORG Tue May 30 20:04:29 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09C6816AA4A; Tue, 30 May 2006 20:04:29 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 361D043D46; Tue, 30 May 2006 20:04:26 +0000 (GMT) (envelope-from linimon@lonesome.com) Received: by mail.soaustin.net (Postfix, from userid 502) id D13564222; Tue, 30 May 2006 15:04:25 -0500 (CDT) Date: Tue, 30 May 2006 15:04:25 -0500 To: Maxim Konovalov Message-ID: <20060530200425.GA16937@soaustin.net> References: <200605301910.k4UJAIMw054372@repoman.freebsd.org> <20060530232844.W69922@mp2.macomnet.net> <20060530193804.GH29390@kaiser.sig11.org> <20060530235134.I69922@mp2.macomnet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060530235134.I69922@mp2.macomnet.net> User-Agent: Mutt/1.5.9i From: linimon@lonesome.com (Mark Linimon) Cc: Matteo Riondato , src-committers@freebsd.org, cvs-all@freebsd.org, linimon@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/tools/tools/recoverdisk Makefile recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 20:04:38 -0000 On Tue, May 30, 2006 at 11:53:50PM +0400, Maxim Konovalov wrote: > That's something new for me. Mark, is it possible to mail them to > freebsd-bugs as well? Not easily possible (it just mails to the default assignee). Further, I'm not sure that increasing the traffic on -bugs even _more_ is advisable, it's pretty near impossible to drink from the firehose as it is. If people see things on -${ARCH} that should be in 'kern' they should fix them up. I don't subscribe to those lists and thus don't often work on those PR (just once every month or so; to work on the -i386 PRs takes some, er, liquid courage to go tackle.) mcl From owner-cvs-src@FreeBSD.ORG Tue May 30 20:08:52 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B75D016AD5A; Tue, 30 May 2006 20:08:52 +0000 (UTC) (envelope-from flag@newluxor.wired.org) Received: from mail.oltrelinux.com (krisma.oltrelinux.com [194.242.226.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E2E743D5E; Tue, 30 May 2006 20:08:51 +0000 (GMT) (envelope-from flag@newluxor.wired.org) Received: from newluxor.wired.org (ip-89-202.sn2.eutelia.it [83.211.89.202]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.oltrelinux.com (Postfix) with ESMTP id 0089311AE97; Tue, 30 May 2006 22:08:51 +0200 (CEST) Received: from newluxor.wired.org (localhost [127.0.0.1]) by newluxor.wired.org (8.13.6/8.13.6) with ESMTP id k4UK8DFP001635; Tue, 30 May 2006 22:08:13 +0200 (CEST) (envelope-from flag@newluxor.wired.org) Received: (from flag@localhost) by newluxor.wired.org (8.13.6/8.13.6/Submit) id k4UK8896001634; Tue, 30 May 2006 22:08:08 +0200 (CEST) (envelope-from flag) Date: Tue, 30 May 2006 22:08:07 +0200 From: Paolo Pisati To: Robert Watson Message-ID: <20060530200807.GA1613@tin.it> References: <200605301305.k4UD5rTr075479@repoman.freebsd.org> <20060530141009.A25073@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060530141009.A25073@fledge.watson.org> User-Agent: Mutt/1.4.2.1i X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at krisma.oltrelinux.com Cc: cvs-src@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 20:09:08 -0000 On Tue, May 30, 2006 at 02:11:08PM +0100, Robert Watson wrote: > Paolo is also one of our Summer of Code 2006 students, working the project > "Study, analyze and improve the interrupt handling infrastructure in > FreeBSD" with John Baldwin as his mentor. > > Welcome, Paolo! > > Robert N M Watson Thanks, much appreciated! :) -- Paolo Piso's first law: nothing work as expected! From owner-cvs-src@FreeBSD.ORG Tue May 30 20:09:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEAF316AEE8; Tue, 30 May 2006 20:09:35 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C0E1743D80; Tue, 30 May 2006 20:09:31 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UK8CrS058694; Tue, 30 May 2006 20:08:12 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UK8Ctt058693; Tue, 30 May 2006 20:08:12 GMT (envelope-from marius) Message-Id: <200605302008.k4UK8Ctt058693@repoman.freebsd.org> From: Marius Strobl Date: Tue, 30 May 2006 20:08:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_tap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 20:09:48 -0000 marius 2006-05-30 20:08:12 UTC FreeBSD src repository Modified files: sys/net if_tap.c Log: Revert the (int *) -> (intptr_t *) conversion done as part of rev. 1.59 for IOCTLs where casting data to intptr_t * isn't the right thing to do as _IO() isn't used for them but _IOR(..., int)/_IOW(..., int) are (i.e. for all IOCTLs except VMIO_SIOCSIFFLAGS), fixing tap(4) on big-endian LP64 machines. PR: sparc64/98084 OK'ed by: emax MFC after: 1 week Revision Changes Path 1.61 +10 -10 src/sys/net/if_tap.c From owner-cvs-src@FreeBSD.ORG Tue May 30 20:16:00 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 483E416ADFD; Tue, 30 May 2006 20:16:00 +0000 (UTC) (envelope-from matteo@freebsd.org) Received: from vsmtp2.tin.it (vsmtp2.tin.it [212.216.176.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id A916843D5F; Tue, 30 May 2006 20:15:59 +0000 (GMT) (envelope-from matteo@freebsd.org) Received: from kaiser.sig11.org (82.50.117.52) by vsmtp2.tin.it (7.2.072.1) id 4477DF30003B1ECC; Tue, 30 May 2006 22:17:42 +0200 Received: by kaiser.sig11.org (Postfix, from userid 1000) id 4C0E0618D; Tue, 30 May 2006 22:15:58 +0200 (CEST) Date: Tue, 30 May 2006 22:15:58 +0200 From: Matteo Riondato To: Mark Linimon Message-ID: <20060530201558.GI29390@kaiser.sig11.org> Mail-Followup-To: Matteo Riondato , Mark Linimon , Maxim Konovalov , linimon@freebsd.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200605301910.k4UJAIMw054372@repoman.freebsd.org> <20060530232844.W69922@mp2.macomnet.net> <20060530193804.GH29390@kaiser.sig11.org> <20060530235134.I69922@mp2.macomnet.net> <20060530200425.GA16937@soaustin.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060530200425.GA16937@soaustin.net> User-Agent: Mutt/1.5.11 Cc: cvs-src@freebsd.org, Maxim Konovalov , src-committers@freebsd.org, cvs-all@freebsd.org, linimon@freebsd.org Subject: Re: cvs commit: src/tools/tools/recoverdisk Makefile recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 20:16:05 -0000 On Tue, May 30, 2006 at 03:04:25PM -0500, Mark Linimon wrote: > On Tue, May 30, 2006 at 11:53:50PM +0400, Maxim Konovalov wrote: > > That's something new for me. Mark, is it possible to mail them to > > freebsd-bugs as well? > > Not easily possible (it just mails to the default assignee). Further, I'm > not sure that increasing the traffic on -bugs even _more_ is advisable, it's > pretty near impossible to drink from the firehose as it is. I agree. Personally, I use the web interface to look at PR's mailed to ML's I don't follow, but can only do this every 2 weeks or so.. Best Regards -- Matteo Riondato FreeBSD Committer (http://www.freebsd.org) G.U.F.I. Staff Member (http://www.gufi.org) FreeSBIE Developer (http://www.freesbie.org) From owner-cvs-src@FreeBSD.ORG Tue May 30 20:23:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A776416B0F9; Tue, 30 May 2006 20:23:30 +0000 (UTC) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 76B3143D8E; Tue, 30 May 2006 20:23:06 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.13.4/8.13.3) with ESMTP id k4UKN4Ua071561; Wed, 31 May 2006 00:23:04 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Wed, 31 May 2006 00:23:04 +0400 (MSD) From: Maxim Konovalov To: Mark Linimon In-Reply-To: <20060530200425.GA16937@soaustin.net> Message-ID: <20060531001204.O69922@mp2.macomnet.net> References: <200605301910.k4UJAIMw054372@repoman.freebsd.org> <20060530232844.W69922@mp2.macomnet.net> <20060530193804.GH29390@kaiser.sig11.org> <20060530235134.I69922@mp2.macomnet.net> <20060530200425.GA16937@soaustin.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Matteo Riondato , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, linimon@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/tools/tools/recoverdisk Makefile recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 20:23:35 -0000 On Tue, 30 May 2006, 15:04-0500, Mark Linimon wrote: > On Tue, May 30, 2006 at 11:53:50PM +0400, Maxim Konovalov wrote: > > That's something new for me. Mark, is it possible to mail them to > > freebsd-bugs as well? > > Not easily possible (it just mails to the default assignee). Further, I'm > not sure that increasing the traffic on -bugs even _more_ is advisable, it's > pretty near impossible to drink from the firehose as it is. > > If people see things on -${ARCH} that should be in 'kern' they should fix > them up. I don't subscribe to those lists and thus don't often work on > those PR (just once every month or so; to work on the -i386 PRs takes some, > er, liquid courage to go tackle.) Categories are ofter misfilled and sometimes bugs in the PRs are arch independent. As far as I see a volume of non-i386 bugs is not big: at the moment we have 22 sparc64, 100+ amd64, 3 ia64, 3 powerpc, 13 alpha PRs. Arm is bugless. On the other hand it not feasible to subscribe to all our arches lists just to get PRs. -- Maxim Konovalov From owner-cvs-src@FreeBSD.ORG Tue May 30 20:23:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B3B016B121; Tue, 30 May 2006 20:23:31 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5FFB43D94; Tue, 30 May 2006 20:23:10 +0000 (GMT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UKLpJ9059401; Tue, 30 May 2006 20:21:51 GMT (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UKLpDP059400; Tue, 30 May 2006 20:21:51 GMT (envelope-from dds) Message-Id: <200605302021.k4UKLpDP059400@repoman.freebsd.org> From: Diomidis Spinellis Date: Tue, 30 May 2006 20:21:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vnode_if.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 20:24:02 -0000 dds 2006-05-30 20:21:51 UTC FreeBSD src repository Modified files: sys/kern vnode_if.src Log: Remove incorrect lock validation specifications that caused failed assertions with DEBUG_VFS_LOCKS. We should reinstate them with correct specifications, possibly after extendng vnode_if.awk Noted by: truckman@ Revision Changes Path 1.81 +0 -7 src/sys/kern/vnode_if.src From owner-cvs-src@FreeBSD.ORG Tue May 30 20:34:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 614D916B317; Tue, 30 May 2006 20:34:08 +0000 (UTC) (envelope-from mohans@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15CB343D7D; Tue, 30 May 2006 20:34:03 +0000 (GMT) (envelope-from mohans@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UKWipW059965; Tue, 30 May 2006 20:32:44 GMT (envelope-from mohans@repoman.freebsd.org) Received: (from mohans@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UKWipm059964; Tue, 30 May 2006 20:32:44 GMT (envelope-from mohans) Message-Id: <200605302032.k4UKWipm059964@repoman.freebsd.org> From: Mohan Srinivasan Date: Tue, 30 May 2006 20:32:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/nfsclient nfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 20:34:13 -0000 mohans 2006-05-30 20:32:44 UTC FreeBSD src repository Modified files: sys/nfsclient nfs_vfsops.c Log: Kris Kennaway found that for '/' NFS mounts, the MPSAFE mount flag was not being set, which means Giant would be acquired for these mounts. Revision Changes Path 1.184 +2 -1 src/sys/nfsclient/nfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Tue May 30 20:51:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D957916B47A; Tue, 30 May 2006 20:51:25 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B407C43DA2; Tue, 30 May 2006 20:51:13 +0000 (GMT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UKnsj6068809; Tue, 30 May 2006 20:49:54 GMT (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UKnsX2068808; Tue, 30 May 2006 20:49:54 GMT (envelope-from dds) Message-Id: <200605302049.k4UKnsX2068808@repoman.freebsd.org> From: Diomidis Spinellis Date: Tue, 30 May 2006 20:49:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vnode_if.src src/sys/tools vnode_if.awk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 20:51:28 -0000 dds 2006-05-30 20:49:54 UTC FreeBSD src repository Modified files: sys/kern vnode_if.src sys/tools vnode_if.awk Log: Assertion code specifications are introduced using special character sequences that are distinct from comments. %% is used for argument locks; %! for pre- and post-conditions. Revision Changes Path 1.82 +182 -182 src/sys/kern/vnode_if.src 1.54 +5 -5 src/sys/tools/vnode_if.awk From owner-cvs-src@FreeBSD.ORG Tue May 30 20:57:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 65ACF16B08C; Tue, 30 May 2006 20:57:47 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B33543D69; Tue, 30 May 2006 20:57:46 +0000 (GMT) (envelope-from linimon@lonesome.com) Received: by mail.soaustin.net (Postfix, from userid 502) id 983834DE9; Tue, 30 May 2006 15:57:45 -0500 (CDT) Date: Tue, 30 May 2006 15:57:45 -0500 To: Maxim Konovalov Message-ID: <20060530205745.GA32229@soaustin.net> References: <200605301910.k4UJAIMw054372@repoman.freebsd.org> <20060530232844.W69922@mp2.macomnet.net> <20060530193804.GH29390@kaiser.sig11.org> <20060530235134.I69922@mp2.macomnet.net> <20060530200425.GA16937@soaustin.net> <20060531001204.O69922@mp2.macomnet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060531001204.O69922@mp2.macomnet.net> User-Agent: Mutt/1.5.9i From: linimon@lonesome.com (Mark Linimon) Cc: src-committers@FreeBSD.org, linimon@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Matteo Riondato , Mark Linimon Subject: Re: cvs commit: src/tools/tools/recoverdisk Makefile recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 20:57:55 -0000 On Wed, May 31, 2006 at 12:23:04AM +0400, Maxim Konovalov wrote: > Categories are often misfiled and sometimes bugs in the PRs are arch > independent. Yes, well, it just requires human intervention to notice. I keep meaning to write up something about that ... maybe now that I'm back from vacation. > On the other hand it not feasible to subscribe to all our arches lists > just to get PRs. Yes, but rather than trying to 'push' this information, I would suggest that people 'pull' it via webpage queries. mcl From owner-cvs-src@FreeBSD.ORG Tue May 30 21:14:48 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3373316A442; Tue, 30 May 2006 21:14:48 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E2D8543D4C; Tue, 30 May 2006 21:14:47 +0000 (GMT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4ULDSto071090; Tue, 30 May 2006 21:13:29 GMT (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4ULDSGe071089; Tue, 30 May 2006 21:13:28 GMT (envelope-from dds) Message-Id: <200605302113.k4ULDSGe071089@repoman.freebsd.org> From: Diomidis Spinellis Date: Tue, 30 May 2006 21:13:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/tools vnode_if.awk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 21:14:52 -0000 dds 2006-05-30 21:13:28 UTC FreeBSD src repository Modified files: sys/tools vnode_if.awk Log: - Add two checks for syntax errors - Improve error reporting - Remove redundant conditionals Revision Changes Path 1.55 +13 -7 src/sys/tools/vnode_if.awk From owner-cvs-src@FreeBSD.ORG Tue May 30 21:15:07 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28F3316ABBA; Tue, 30 May 2006 21:15:07 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B84C443D48; Tue, 30 May 2006 21:15:06 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4ULDlh9071141; Tue, 30 May 2006 21:13:47 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4ULDlea071140; Tue, 30 May 2006 21:13:47 GMT (envelope-from cognet) Message-Id: <200605302113.k4ULDlea071140@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 30 May 2006 21:13:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf Makefile.arm src/sys/arm/arm elf_trampoline.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 21:15:11 -0000 cognet 2006-05-30 21:13:47 UTC FreeBSD src repository Modified files: sys/conf Makefile.arm sys/arm/arm elf_trampoline.c Log: To avoid problems, invalidate the data cache and disable the MMU once we're done uncompressing the kernel. Revision Changes Path 1.6 +32 -2 src/sys/arm/arm/elf_trampoline.c 1.27 +6 -2 src/sys/conf/Makefile.arm From owner-cvs-src@FreeBSD.ORG Tue May 30 21:37:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E426916AF65; Tue, 30 May 2006 21:37:31 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6AD5D43D76; Tue, 30 May 2006 21:37:31 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4ULaC7f074779; Tue, 30 May 2006 21:36:12 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4ULaC0P074778; Tue, 30 May 2006 21:36:12 GMT (envelope-from imp) Message-Id: <200605302136.k4ULaC0P074778@repoman.freebsd.org> From: Warner Losh Date: Tue, 30 May 2006 21:36:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pci pcireg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 21:37:37 -0000 imp 2006-05-30 21:36:12 UTC FreeBSD src repository Modified files: sys/dev/pci pcireg.h Log: Add a define for the Standard SD Host Controller Base Peripheral. Revision Changes Path 1.52 +1 -0 src/sys/dev/pci/pcireg.h From owner-cvs-src@FreeBSD.ORG Tue May 30 22:44:50 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DCF616B38E; Tue, 30 May 2006 22:44:50 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.152]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0802D43D4C; Tue, 30 May 2006 22:44:49 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-24-147-19-128.hsd1.ma.comcast.net (c-71-233-168-2.hsd1.ma.comcast.net[71.233.168.2](misconfigured sender)) by comcast.net (rwcrmhc12) with ESMTP id <20060530224448m1200j0vtne>; Tue, 30 May 2006 22:44:48 +0000 Received: from c-24-147-19-128.hsd1.ma.comcast.net (localhost [127.0.0.1]) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1) with ESMTP id k4UMimei042578; Tue, 30 May 2006 18:44:48 -0400 (EDT) (envelope-from rodrigc@c-24-147-19-128.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1/Submit) id k4UMim6W042577; Tue, 30 May 2006 18:44:48 -0400 (EDT) (envelope-from rodrigc) Date: Tue, 30 May 2006 18:44:48 -0400 From: Craig Rodrigues To: Maxim Konovalov Message-ID: <20060530224448.GA42556@crodrigues.org> References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> <20060529215827.D78736@mp2.macomnet.net> <20060530034531.GA36462@crodrigues.org> <20060530110750.A96470@mp2.macomnet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060530110750.A96470@mp2.macomnet.net> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 22:45:02 -0000 On Tue, May 30, 2006 at 11:11:34AM +0400, Maxim Konovalov wrote: > [root@sonnie ~]# mount -u -o noexec,ro /vol0 Can you try this patch? Index: mount.c =================================================================== RCS file: /home/ncvs/src/sbin/mount/mount.c,v retrieving revision 1.84 diff -u -u -r1.84 mount.c --- mount.c 10 May 2006 14:40:40 -0000 1.84 +++ mount.c 30 May 2006 20:13:23 -0000 @@ -184,6 +184,32 @@ return (0); } +static +int specified_ro(int argc, char *argv[]) +{ + int i; + char *optbuf, *opt; + int ret = 0; + + for (i=1; i < argc; i++) { + if (strcmp(argv[i-1], "-o") == 0) { + optbuf = strdup(argv[i]); + if (optbuf == NULL) + err(1, NULL); + + for (opt = optbuf; (opt = strtok(opt, ",")) != NULL; + opt = NULL) { + if (strcmp(opt, "ro") == 0) { + ret = 1; + break; + } + } + free(optbuf); + } + } + return (ret); +} + int main(int argc, char *argv[]) { @@ -200,6 +226,9 @@ options = NULL; vfslist = NULL; vfstype = "ufs"; + + if (specified_ro(argc, argv)) + ro = 1; while ((ch = getopt(argc, argv, "adF:fo:prwt:uv")) != -1) switch (ch) { case 'a': -- Craig Rodrigues rodrigc@crodrigues.org From owner-cvs-src@FreeBSD.ORG Tue May 30 22:45:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 07E3B16AA22; Tue, 30 May 2006 22:45:27 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F60B43D5C; Tue, 30 May 2006 22:45:20 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UMi1vk083159; Tue, 30 May 2006 22:44:01 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UMi0J7083158; Tue, 30 May 2006 22:44:00 GMT (envelope-from mjacob) Message-Id: <200605302244.k4UMi0J7083158@repoman.freebsd.org> From: Matt Jacob Date: Tue, 30 May 2006 22:44:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_all.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 22:45:38 -0000 mjacob 2006-05-30 22:44:00 UTC FreeBSD src repository Modified files: sys/cam cam_xpt.c sys/cam/scsi scsi_all.h Log: Handle some of the inquiry flags that have come into usage as of SPC2r20. Specifically, handle the BQueue flag which will indicate that a device supports the Basic Queueing model (no Head of Queue or Ordered tags). When this flag is set, SID_CmdQueue is clear. This has causes FreeBSD to assume that the device did not support tagged operations. MFC after: 1 month Revision Changes Path 1.159 +4 -5 src/sys/cam/cam_xpt.c 1.25 +13 -1 src/sys/cam/scsi/scsi_all.h From owner-cvs-src@FreeBSD.ORG Tue May 30 23:45:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FA9E16A5A1; Tue, 30 May 2006 23:45:41 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2AE1943D46; Tue, 30 May 2006 23:45:41 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UNiLdL090220; Tue, 30 May 2006 23:44:21 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UNiLsN090219; Tue, 30 May 2006 23:44:21 GMT (envelope-from davidxu) Message-Id: <200605302344.k4UNiLsN090219@repoman.freebsd.org> From: David Xu Date: Tue, 30 May 2006 23:44:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/include md_var.h npx.h src/sys/i386/i386 initcpu.c machdep.c ptrace_machdep.c src/sys/i386/isa npx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 23:45:45 -0000 davidxu 2006-05-30 23:44:21 UTC FreeBSD src repository Modified files: sys/i386/include md_var.h npx.h sys/i386/i386 initcpu.c machdep.c ptrace_machdep.c sys/i386/isa npx.c Log: Use the method described in IA-32 Intel Architecture Software Developer's Manual chapter 11.6.6 to get valid mxcsr bits, use the mxcsr mask to clear invalid bits passed by user code. Reviewed by: bde Revision Changes Path 1.54 +1 -0 src/sys/i386/i386/initcpu.c 1.628 +3 -3 src/sys/i386/i386/machdep.c 1.6 +5 -6 src/sys/i386/i386/ptrace_machdep.c 1.75 +1 -0 src/sys/i386/include/md_var.h 1.32 +2 -2 src/sys/i386/include/npx.h 1.170 +9 -0 src/sys/i386/isa/npx.c From owner-cvs-src@FreeBSD.ORG Tue May 30 23:52:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3ED8516A6B9; Tue, 30 May 2006 23:52:09 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D055643D55; Tue, 30 May 2006 23:52:04 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4UNojKh091578; Tue, 30 May 2006 23:50:45 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4UNojlx091577; Tue, 30 May 2006 23:50:45 GMT (envelope-from cognet) Message-Id: <200605302350.k4UNojlx091577@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 30 May 2006 23:50:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/arm pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 23:52:12 -0000 cognet 2006-05-30 23:50:45 UTC FreeBSD src repository Modified files: sys/arm/arm pmap.c Log: Protect the mapping used for pmap_copy_page/pmap_zero_page with a mutex. Revision Changes Path 1.50 +15 -2 src/sys/arm/arm/pmap.c From owner-cvs-src@FreeBSD.ORG Tue May 30 23:58:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8658916A5BF; Tue, 30 May 2006 23:58:53 +0000 (UTC) (envelope-from flata@magnesium.net) Received: from toxic.magnesium.net (toxic.magnesium.net [207.154.84.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 453E943D46; Tue, 30 May 2006 23:58:53 +0000 (GMT) (envelope-from flata@magnesium.net) Received: by toxic.magnesium.net (Postfix, from userid 1212) id 1E9FDDA8B2; Tue, 30 May 2006 16:58:53 -0700 (PDT) Date: Tue, 30 May 2006 13:58:53 -1000 From: Juli Mallett To: Craig Rodrigues Message-ID: <20060530235853.GA42051@toxic.magnesium.net> References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> <20060529215827.D78736@mp2.macomnet.net> <20060530034531.GA36462@crodrigues.org> <20060530110750.A96470@mp2.macomnet.net> <20060530224448.GA42556@crodrigues.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060530224448.GA42556@crodrigues.org> User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.org, Maxim Konovalov , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 23:58:58 -0000 * Craig Rodrigues [ 2006-05-30 ] [ Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c ] > On Tue, May 30, 2006 at 11:11:34AM +0400, Maxim Konovalov wrote: > > [root@sonnie ~]# mount -u -o noexec,ro /vol0 > > Can you try this patch? Instead of playing games with strcmp(3) to avoid getopt(3), you might want to try using the existing getopt(3). I think something like this might make sense, but it's not even compile tested. I'm not sure if the second chunk is necessary, but I get the impression from surrounding code that it prevents a redundant "noro,noro" in the options list. %%% Index: mount.c =================================================================== RCS file: /home/ncvs/src/sbin/mount/mount.c,v retrieving revision 1.84 diff -u -r1.84 mount.c --- mount.c 10 May 2006 14:40:40 -0000 1.84 +++ mount.c 30 May 2006 23:55:43 -0000 @@ -215,8 +215,11 @@ init_flags |= MNT_FORCE; break; case 'o': - if (*optarg) + if (*optarg) { options = catopt(options, optarg); + if (strcmp(optarg, "ro") == 0) + ro = 1; + } break; case 'p': fstab_style = 1; @@ -240,6 +243,7 @@ break; case 'w': options = catopt(options, "noro"); + ro = 0; break; case '?': default: %%% From owner-cvs-src@FreeBSD.ORG Wed May 31 00:18:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BDC1E16B7FB; Wed, 31 May 2006 00:18:49 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 797CF43D4C; Wed, 31 May 2006 00:18:49 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4V0HUbX094367; Wed, 31 May 2006 00:17:30 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4V0HTgP094366; Wed, 31 May 2006 00:17:29 GMT (envelope-from davidxu) Message-Id: <200605310017.k4V0HTgP094366@repoman.freebsd.org> From: David Xu Date: Wed, 31 May 2006 00:17:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 00:18:52 -0000 davidxu 2006-05-31 00:17:29 UTC FreeBSD src repository Modified files: sys/i386/i386 machdep.c Log: Clear invalid bits only if CPU supports SSE, otherwise, some fields in struct save87 will be cleared unexpectly. Revision Changes Path 1.629 +2 -1 src/sys/i386/i386/machdep.c From owner-cvs-src@FreeBSD.ORG Wed May 31 00:32:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 99FCB16A59E; Wed, 31 May 2006 00:32:58 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 550C043D53; Wed, 31 May 2006 00:32:58 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4V0VcGd095132; Wed, 31 May 2006 00:31:38 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4V0Vchu095131; Wed, 31 May 2006 00:31:38 GMT (envelope-from delphij) Message-Id: <200605310031.k4V0Vchu095131@repoman.freebsd.org> From: Xin LI Date: Wed, 31 May 2006 00:31:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libthr/thread thr_spec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 00:33:04 -0000 delphij 2006-05-31 00:31:38 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_spec.c Log: Explicitly request pre-zeroed memory instead of memset'ing our own. Ok'ed by: davidxu Revision Changes Path 1.5 +1 -5 src/lib/libthr/thread/thr_spec.c From owner-cvs-src@FreeBSD.ORG Wed May 31 00:37:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ECE6416ABD7; Wed, 31 May 2006 00:37:04 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A607B43D46; Wed, 31 May 2006 00:37:04 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4V0Zj9r095293; Wed, 31 May 2006 00:35:45 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4V0ZjNT095292; Wed, 31 May 2006 00:35:45 GMT (envelope-from mjacob) Message-Id: <200605310035.k4V0ZjNT095292@repoman.freebsd.org> From: Matt Jacob Date: Wed, 31 May 2006 00:35:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 00:37:06 -0000 mjacob 2006-05-31 00:35:45 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt_pci.c Log: Pick reasonable alignment constraints so that we don't ask too much of bus_dmamem_alloc/malloc. Replace the device_printf calls in the memalloc function mpt_prt. Revision Changes Path 1.32 +25 -27 src/sys/dev/mpt/mpt_pci.c From owner-cvs-src@FreeBSD.ORG Wed May 31 00:39:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E71B16B71B; Wed, 31 May 2006 00:39:17 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7D3A43D4C; Wed, 31 May 2006 00:39:16 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4V0bvWD095423; Wed, 31 May 2006 00:37:57 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4V0bvFD095422; Wed, 31 May 2006 00:37:57 GMT (envelope-from mjacob) Message-Id: <200605310037.k4V0bvFD095422@repoman.freebsd.org> From: Matt Jacob Date: Wed, 31 May 2006 00:37:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 busdma_machdep.c src/sys/amd64/amd64 busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 00:39:26 -0000 mjacob 2006-05-31 00:37:56 UTC FreeBSD src repository Modified files: sys/i386/i386 busdma_machdep.c sys/amd64/amd64 busdma_machdep.c Log: Turn the panic on not being able to meet alignment constraints in bus_dmamem_alloc into the more reasonable EINVAL return. Also, reclaim memory allocated but then not used if we had an error return. Revision Changes Path 1.76 +22 -4 src/sys/amd64/amd64/busdma_machdep.c 1.79 +22 -4 src/sys/i386/i386/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Wed May 31 00:40:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 446C716B50B; Wed, 31 May 2006 00:40:13 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4D0043D48; Wed, 31 May 2006 00:40:12 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4V0crYm095506; Wed, 31 May 2006 00:38:53 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4V0crDD095505; Wed, 31 May 2006 00:38:53 GMT (envelope-from mjacob) Message-Id: <200605310038.k4V0crDD095505@repoman.freebsd.org> From: Matt Jacob Date: Wed, 31 May 2006 00:38:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ia64/ia64 busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 00:40:17 -0000 mjacob 2006-05-31 00:38:53 UTC FreeBSD src repository Modified files: sys/ia64/ia64 busdma_machdep.c Log: Since it's to all intents and purposes identical code to amd64 && i386, match the recent changes to bus_dmamem_alloc here. Revision Changes Path 1.40 +42 -6 src/sys/ia64/ia64/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Wed May 31 01:32:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4A1716B17D; Wed, 31 May 2006 01:32:11 +0000 (UTC) (envelope-from grog@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 723D243D70; Wed, 31 May 2006 01:32:10 +0000 (GMT) (envelope-from grog@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4V1UoxU008787; Wed, 31 May 2006 01:30:50 GMT (envelope-from grog@repoman.freebsd.org) Received: (from grog@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4V1UoBh008786; Wed, 31 May 2006 01:30:50 GMT (envelope-from grog) Message-Id: <200605310130.k4V1UoBh008786@repoman.freebsd.org> From: Greg Lehey Date: Wed, 31 May 2006 01:30:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/calendar day.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 01:32:17 -0000 grog 2006-05-31 01:30:50 UTC FreeBSD src repository Modified files: usr.bin/calendar day.c Log: Correct previous commit. We don't want to suppress an entry because it runs into the following month. Instead adjust month and day, wrapping round into next year where necessary. MFC after: 14 days Revision Changes Path 1.23 +5 -3 src/usr.bin/calendar/day.c From owner-cvs-src@FreeBSD.ORG Wed May 31 05:49:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 292BD16A53A; Wed, 31 May 2006 05:49:03 +0000 (UTC) (envelope-from dds@aueb.gr) Received: from mx-out-01.forthnet.gr (mx-out.forthnet.gr [193.92.150.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 60FA543D46; Wed, 31 May 2006 05:49:01 +0000 (GMT) (envelope-from dds@aueb.gr) Received: from mx-av-03.forthnet.gr (mx-av.forthnet.gr [193.92.150.27]) by mx-out-01.forthnet.gr (8.13.6/8.13.6) with ESMTP id k4V5mxt2018062; Wed, 31 May 2006 08:48:59 +0300 Received: from mx-in-02.forthnet.gr (mx-in-02.forthnet.gr [193.92.150.185]) by mx-av-03.forthnet.gr (8.13.6/8.13.6) with ESMTP id k4V5mxvh006202; Wed, 31 May 2006 08:48:59 +0300 Received: from [192.168.136.16] (ppp76-181.adsl.forthnet.gr [195.74.246.181]) by mx-in-02.forthnet.gr (8.13.6/8.13.6) with ESMTP id k4V5mwfX025831; Wed, 31 May 2006 08:48:59 +0300 Authentication-Results: mx-in-02.forthnet.gr from=dds@aueb.gr; sender-id=neutral; spf=neutral Message-ID: <447D2E4B.5080602@aueb.gr> Date: Wed, 31 May 2006 08:48:59 +0300 From: Diomidis Spinellis User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060404 SeaMonkey/1.0.1 MIME-Version: 1.0 To: Don Lewis References: <200605292202.k4TM2mjt021917@gw.catspoiler.org> In-Reply-To: <200605292202.k4TM2mjt021917@gw.catspoiler.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vnode_if.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 05:49:03 -0000 Don Lewis wrote: > On 28 May, Diomidis Spinellis wrote: >> dds 2006-05-28 07:24:12 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/kern vnode_if.src >> Log: >> Add missing % signs in the lock annotations of the functions: >> lookup, rename, strategy, islocked >> The missing % sign meant that the lines were processed as plain >> comments and the corresponding assertions were never generated. >> >> Revision Changes Path >> 1.80 +8 -8 src/sys/kern/vnode_if.src > > [appearing from the void] > > The additional sanity checking generated by this patch made my system > unbootable with DEBUG_VFS_LOCKS enabled. > > ASSERT_VI_UNLOCKED() calls are added to VOP_ISLOCKED_APV(), but there > is an explicit call to VOP_ISLOCKED() in vput() with the vnode > interlock held. This could be fixed by re-ordering the code in > vput(), but there are also a number of places in lower level code that > are called with the vnode interlock held that contain calls to > ASSERT_VOP_LOCKED(), which in turn calls VOP_ISLOCKED(). Possible > fixes: > Specify the locking value as "-" for vop_islocked() in vnode_if.src > > Introduce a new locking value, similar to "=", but which skips the > interlock check. Note: vnode_if.awk does not implement the "=" > vnode lock assertion. > > The fdvp and fvp initial vnode lock state assertions can't be checked > by the generated wrapper. If fdvp and fvp happen to be references to > tdvp and/or tvp, which must be locked, then fdvp and/or fvp will also > be locked. They should only be unlocked if they are different vnodes > than tdvp and tvp. The proper sanity checking appears to be done in > vop_rename_pre(). The initial lock value for fdvp and fvp should > probably be set to "-" in vnode_if.src, or to another value that only > generates the interlock assertion. > > VOP_RENAME_APV() calls ASSERT_VI_UNLOCKED() on tvp before and after > the vop->vop_rename() call, even though tvp may be NULL. vnode_if.src > specifies the initial lock state as "X", which indicates that the > check should be skipped if the vnode pointer is NULL, but vnode_if.awk > does not handle the "X" value at all, and adds an unconditional > interlock check. vop_rename_pre() does the conditional vnode lock > check, so maybe the interlock check could be done there as well and > omitted from the wrapper. The final state is specified as "U", though > this should also be a conditional check, but there is no vnode locking > value that generates a conditional unlock assertion. > vop_rename_post() does not do any lock state sanity checks. > > BTW, the VOP_ISLOCKED(9) man page does not document that the return > value is the shared/exclusive lock type. > > [disappearing into the void] I committed a stopgap measure (I disabled the erroneous checks), and will look at how I can correctly enable them again. Do you think that booting with DEBUG_VFS_LOCKS and performing a kernel build would be enough to gain confidence that a particular assertion is correctly generated? Any proposals for additional tests? (The system I use for testing has unfortunately only a single processor). Diomidis From owner-cvs-src@FreeBSD.ORG Wed May 31 05:58:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94B7716A73D; Wed, 31 May 2006 05:58:02 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.FreeBSD.org (Postfix) with ESMTP id D417A43D46; Wed, 31 May 2006 05:58:01 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.6/8.13.6) with ESMTP id k4V5r0Bi067530; Wed, 31 May 2006 09:53:00 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.13.6/8.13.6/Submit) id k4V5qxlx067529; Wed, 31 May 2006 09:52:59 +0400 (MSD) (envelope-from ache) Date: Wed, 31 May 2006 09:52:59 +0400 From: Andrey Chernov To: Craig Rodrigues Message-ID: <20060531055259.GB67241@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Craig Rodrigues , Maxim Konovalov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> <20060529215827.D78736@mp2.macomnet.net> <20060530034531.GA36462@crodrigues.org> <20060530110750.A96470@mp2.macomnet.net> <20060530224448.GA42556@crodrigues.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060530224448.GA42556@crodrigues.org> User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.ORG, Maxim Konovalov , src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 05:58:03 -0000 On Tue, May 30, 2006 at 06:44:48PM -0400, Craig Rodrigues wrote: > On Tue, May 30, 2006 at 11:11:34AM +0400, Maxim Konovalov wrote: > > [root@sonnie ~]# mount -u -o noexec,ro /vol0 > > Can you try this patch? > > + for (i=1; i < argc; i++) { > + if (strcmp(argv[i-1], "-o") == 0) { Why re-invent the wheel? You already have getopt(3) for that sort of parsing, just add a little to 'o' case. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Wed May 31 06:47:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D94F816A462; Wed, 31 May 2006 06:47:05 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 261EB43D5D; Wed, 31 May 2006 06:47:05 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4V6jihX038291; Wed, 31 May 2006 06:45:44 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4V6jieX038290; Wed, 31 May 2006 06:45:44 GMT (envelope-from scottl) Message-Id: <200605310645.k4V6jieX038290@repoman.freebsd.org> From: Scott Long Date: Wed, 31 May 2006 06:45:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT approvers X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 06:47:08 -0000 scottl 2006-05-31 06:45:44 UTC FreeBSD src repository Modified files: . approvers Log: Give ownership of the RELENG_5_5 branch to the security officer. Approved by: re Revision Changes Path 1.35 +1 -2 CVSROOT/approvers From owner-cvs-src@FreeBSD.ORG Wed May 31 07:45:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D11A16A41F; Wed, 31 May 2006 07:45:35 +0000 (UTC) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8548043D58; Wed, 31 May 2006 07:45:34 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.13.4/8.13.3) with ESMTP id k4V7iEq3070986; Wed, 31 May 2006 11:44:14 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Wed, 31 May 2006 11:44:14 +0400 (MSD) From: Maxim Konovalov To: Craig Rodrigues In-Reply-To: <20060530224448.GA42556@crodrigues.org> Message-ID: <20060531114119.T70660@mp2.macomnet.net> References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> <20060529215827.D78736@mp2.macomnet.net> <20060530034531.GA36462@crodrigues.org> <20060530110750.A96470@mp2.macomnet.net> <20060530224448.GA42556@crodrigues.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 07:45:35 -0000 On Tue, 30 May 2006, 18:44-0400, Craig Rodrigues wrote: > On Tue, May 30, 2006 at 11:11:34AM +0400, Maxim Konovalov wrote: > > [root@sonnie ~]# mount -u -o noexec,ro /vol0 > > Can you try this patch? [...] This one works, thanks! But I worry about mountd/NFS interaction to mount I described in my first email. Any ideas? -- Maxim Konovalov From owner-cvs-src@FreeBSD.ORG Wed May 31 08:11:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B90E616A41F; Wed, 31 May 2006 08:11:55 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7633543D48; Wed, 31 May 2006 08:11:55 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4V8AYQq044019; Wed, 31 May 2006 08:10:34 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4V8AYVx044018; Wed, 31 May 2006 08:10:34 GMT (envelope-from maxim) Message-Id: <200605310810.k4V8AYVx044018@repoman.freebsd.org> From: Maxim Konovalov Date: Wed, 31 May 2006 08:10:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/sockets/unix_cmsg unix_cmsg.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 08:11:55 -0000 maxim 2006-05-31 08:10:34 UTC FreeBSD src repository Modified files: tools/regression/sockets/unix_cmsg unix_cmsg.c Log: o Let getopt(3) report errors in command line arguments. o If something is wrong with options, then output short usage help message. o Output errstr returned from strtonum(3). PR: bin/98141 Submitted by: Andrey Simonenko Revision Changes Path 1.2 +11 -13 src/tools/regression/sockets/unix_cmsg/unix_cmsg.c From owner-cvs-src@FreeBSD.ORG Wed May 31 08:30:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E6E516A422; Wed, 31 May 2006 08:30:53 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-0-0-cust107.cdif.cable.ntl.com [81.104.168.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 53EA243D4C; Wed, 31 May 2006 08:30:52 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.62 (FreeBSD)) (envelope-from ) id 1FlM6K-00078T-UJ; Wed, 31 May 2006 09:30:48 +0100 Date: Wed, 31 May 2006 09:30:48 +0100 From: Ceri Davies To: Mark Linimon Message-ID: <20060531083048.GL21998@submonkey.net> Mail-Followup-To: Ceri Davies , Mark Linimon , Maxim Konovalov , linimon@FreeBSD.org, Matteo Riondato , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200605301910.k4UJAIMw054372@repoman.freebsd.org> <20060530232844.W69922@mp2.macomnet.net> <20060530193804.GH29390@kaiser.sig11.org> <20060530235134.I69922@mp2.macomnet.net> <20060530200425.GA16937@soaustin.net> <20060531001204.O69922@mp2.macomnet.net> <20060530205745.GA32229@soaustin.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zOTFI1MayFoZtDo5" Content-Disposition: inline In-Reply-To: <20060530205745.GA32229@soaustin.net> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.11 Sender: Ceri Davies Cc: src-committers@FreeBSD.org, linimon@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Matteo Riondato , Maxim Konovalov Subject: Re: cvs commit: src/tools/tools/recoverdisk Makefile recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 08:30:54 -0000 --zOTFI1MayFoZtDo5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 30, 2006 at 03:57:45PM -0500, Mark Linimon wrote: > On Wed, May 31, 2006 at 12:23:04AM +0400, Maxim Konovalov wrote: > > Categories are often misfiled and sometimes bugs in the PRs are arch > > independent. >=20 > Yes, well, it just requires human intervention to notice. I keep meaning > to write up something about that ... maybe now that I'm back from vacatio= n. >=20 > > On the other hand it not feasible to subscribe to all our arches lists > > just to get PRs. >=20 > Yes, but rather than trying to 'push' this information, I would suggest > that people 'pull' it via webpage queries. Or a cronjob, preferably. Note that GNATS has always worked this way, it's nothing new. Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --zOTFI1MayFoZtDo5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEfVQ4ocfcwTS3JF8RAlv8AJ4zyWoG8a75hjoV3Ak+V74Su0LnYwCfRAQ1 eppSFD9/3fTrvJNoKJq9PGs= =cumh -----END PGP SIGNATURE----- --zOTFI1MayFoZtDo5-- From owner-cvs-src@FreeBSD.ORG Wed May 31 09:07:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D48116A420; Wed, 31 May 2006 09:07:11 +0000 (UTC) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2ABAC43D48; Wed, 31 May 2006 09:07:11 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4V95orF054772; Wed, 31 May 2006 09:05:50 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4V95njZ054771; Wed, 31 May 2006 09:05:50 GMT (envelope-from iedowse) Message-Id: <200605310905.k4V95njZ054771@repoman.freebsd.org> From: Ian Dowse Date: Wed, 31 May 2006 09:05:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/i386/libi386 biosdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 09:07:11 -0000 iedowse 2006-05-31 09:05:49 UTC FreeBSD src repository Modified files: sys/boot/i386/libi386 biosdisk.c Log: Increment the disk block offset after writing, not before. This fixes filesystem corruption when nextboot.conf is located after cylinder 1023. The bug appears to have been introduced at the time bd_read was copied to create bd_write. PR: bin/98005 Reported by: yar MFC after: 1 week Revision Changes Path 1.47 +3 -3 src/sys/boot/i386/libi386/biosdisk.c From owner-cvs-src@FreeBSD.ORG Wed May 31 09:08:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 845F716A41F; Wed, 31 May 2006 09:08:55 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (adsl-75-1-14-242.dsl.scrm01.sbcglobal.net [75.1.14.242]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0524943D58; Wed, 31 May 2006 09:08:54 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id k4V98jre001315; Wed, 31 May 2006 02:08:48 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200605310908.k4V98jre001315@gw.catspoiler.org> Date: Wed, 31 May 2006 02:08:45 -0700 (PDT) From: Don Lewis To: dds@FreeBSD.org In-Reply-To: <200605302049.k4UKnsX2068808@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vnode_if.src src/sys/tools vnode_if.awk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 09:08:55 -0000 On 30 May, Diomidis Spinellis wrote: > dds 2006-05-30 20:49:54 UTC > > FreeBSD src repository > > Modified files: > sys/kern vnode_if.src > sys/tools vnode_if.awk > Log: > Assertion code specifications are introduced using special character > sequences that are distinct from comments. %% is used for argument > locks; %! for pre- and post-conditions. > > Revision Changes Path > 1.82 +182 -182 src/sys/kern/vnode_if.src > 1.54 +5 -5 src/sys/tools/vnode_if.awk [appearing from the void] Thanks! [disappearing into the void] From owner-cvs-src@FreeBSD.ORG Wed May 31 09:20:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A588E16A420; Wed, 31 May 2006 09:20:32 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (adsl-75-1-14-242.dsl.scrm01.sbcglobal.net [75.1.14.242]) by mx1.FreeBSD.org (Postfix) with ESMTP id 584D043D53; Wed, 31 May 2006 09:20:32 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id k4V9KGEn001337; Wed, 31 May 2006 02:20:23 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200605310920.k4V9KGEn001337@gw.catspoiler.org> Date: Wed, 31 May 2006 02:20:16 -0700 (PDT) From: Don Lewis To: dds@aueb.gr In-Reply-To: <447D2E4B.5080602@aueb.gr> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vnode_if.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 09:20:32 -0000 On 31 May, Diomidis Spinellis wrote: > Don Lewis wrote: >> On 28 May, Diomidis Spinellis wrote: >>> dds 2006-05-28 07:24:12 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/kern vnode_if.src >>> Log: >>> Add missing % signs in the lock annotations of the functions: >>> lookup, rename, strategy, islocked >>> The missing % sign meant that the lines were processed as plain >>> comments and the corresponding assertions were never generated. >>> >>> Revision Changes Path >>> 1.80 +8 -8 src/sys/kern/vnode_if.src >> >> [appearing from the void] >> >> The additional sanity checking generated by this patch made my system >> unbootable with DEBUG_VFS_LOCKS enabled. >> >> ASSERT_VI_UNLOCKED() calls are added to VOP_ISLOCKED_APV(), but there >> is an explicit call to VOP_ISLOCKED() in vput() with the vnode >> interlock held. This could be fixed by re-ordering the code in >> vput(), but there are also a number of places in lower level code that >> are called with the vnode interlock held that contain calls to >> ASSERT_VOP_LOCKED(), which in turn calls VOP_ISLOCKED(). Possible >> fixes: >> Specify the locking value as "-" for vop_islocked() in vnode_if.src >> >> Introduce a new locking value, similar to "=", but which skips the >> interlock check. Note: vnode_if.awk does not implement the "=" >> vnode lock assertion. >> >> The fdvp and fvp initial vnode lock state assertions can't be checked >> by the generated wrapper. If fdvp and fvp happen to be references to >> tdvp and/or tvp, which must be locked, then fdvp and/or fvp will also >> be locked. They should only be unlocked if they are different vnodes >> than tdvp and tvp. The proper sanity checking appears to be done in >> vop_rename_pre(). The initial lock value for fdvp and fvp should >> probably be set to "-" in vnode_if.src, or to another value that only >> generates the interlock assertion. >> >> VOP_RENAME_APV() calls ASSERT_VI_UNLOCKED() on tvp before and after >> the vop->vop_rename() call, even though tvp may be NULL. vnode_if.src >> specifies the initial lock state as "X", which indicates that the >> check should be skipped if the vnode pointer is NULL, but vnode_if.awk >> does not handle the "X" value at all, and adds an unconditional >> interlock check. vop_rename_pre() does the conditional vnode lock >> check, so maybe the interlock check could be done there as well and >> omitted from the wrapper. The final state is specified as "U", though >> this should also be a conditional check, but there is no vnode locking >> value that generates a conditional unlock assertion. >> vop_rename_post() does not do any lock state sanity checks. >> >> BTW, the VOP_ISLOCKED(9) man page does not document that the return >> value is the shared/exclusive lock type. >> >> [disappearing into the void] > > I committed a stopgap measure (I disabled the erroneous checks), and > will look at how I can correctly enable them again. Do you think that > booting with DEBUG_VFS_LOCKS and performing a kernel build would be > enough to gain confidence that a particular assertion is correctly > generated? Any proposals for additional tests? (The system I use for > testing has unfortunately only a single processor). That should be sufficient. The VOP_ISLOCKED() bug gets tripped pretty quickly, when the root file system gets mounted as I recall. The VOP_RENAME() bugs got triggered during the transition to multi-user mode. Once I disabled the tests that I mentioned, I was able to build a bunch of ports. From owner-cvs-src@FreeBSD.ORG Wed May 31 09:31:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A66DE16A498; Wed, 31 May 2006 09:31:01 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (adsl-75-1-14-242.dsl.scrm01.sbcglobal.net [75.1.14.242]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67C3143D46; Wed, 31 May 2006 09:31:01 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id k4V9UpWa001360; Wed, 31 May 2006 02:30:55 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200605310930.k4V9UpWa001360@gw.catspoiler.org> Date: Wed, 31 May 2006 02:30:51 -0700 (PDT) From: Don Lewis To: mjacob@FreeBSD.org In-Reply-To: <200605302244.k4UMi0J7083158@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_all.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 09:31:02 -0000 On 30 May, Matt Jacob wrote: > mjacob 2006-05-30 22:44:00 UTC > > FreeBSD src repository > > Modified files: > sys/cam cam_xpt.c > sys/cam/scsi scsi_all.h > Log: > Handle some of the inquiry flags that have come into > usage as of SPC2r20. Specifically, handle the BQueue > flag which will indicate that a device supports the > Basic Queueing model (no Head of Queue or Ordered tags). > When this flag is set, SID_CmdQueue is clear. This has > causes FreeBSD to assume that the device did not support > tagged operations. This commit broke compilation of the ahb driver, which appears to be trying to get the number of ecbs from the spc2_flags member of scsi_inquiry_data, which it tries to access under the old member name, reserved[1]. Not that I care all that much because I don't have any ahb hardware, but this driver is included in the GENERIC kernel. From owner-cvs-src@FreeBSD.ORG Wed May 31 10:31:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6636216A420; Wed, 31 May 2006 10:31:34 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 199E243D46; Wed, 31 May 2006 10:31:34 +0000 (GMT) (envelope-from linimon@lonesome.com) Received: by mail.soaustin.net (Postfix, from userid 502) id C1F6448C0; Wed, 31 May 2006 05:31:33 -0500 (CDT) Date: Wed, 31 May 2006 05:31:33 -0500 To: Ceri Davies , Mark Linimon , Maxim Konovalov , linimon@FreeBSD.org, Matteo Riondato , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20060531103133.GB22144@soaustin.net> References: <200605301910.k4UJAIMw054372@repoman.freebsd.org> <20060530232844.W69922@mp2.macomnet.net> <20060530193804.GH29390@kaiser.sig11.org> <20060530235134.I69922@mp2.macomnet.net> <20060530200425.GA16937@soaustin.net> <20060531001204.O69922@mp2.macomnet.net> <20060530205745.GA32229@soaustin.net> <20060531083048.GL21998@submonkey.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060531083048.GL21998@submonkey.net> User-Agent: Mutt/1.5.9i From: linimon@lonesome.com (Mark Linimon) Cc: Subject: Re: cvs commit: src/tools/tools/recoverdisk Makefile recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 10:31:34 -0000 On Wed, May 31, 2006 at 09:30:48AM +0100, Ceri Davies wrote: > > Yes, but rather than trying to 'push' this information, I would suggest > > that people 'pull' it via webpage queries. > > Or a cronjob, preferably. Well, yes, but to what list? Everything's like drinking from a firehose as it is. Adding some duplicate postings across the various mailing lists doesn't seem like a good idea to me. Of course, if it's what people want to do, I think I actually understand the scripts these days. mcl From owner-cvs-src@FreeBSD.ORG Wed May 31 10:36:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA74A16A423; Wed, 31 May 2006 10:36:52 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-0-0-cust107.cdif.cable.ntl.com [81.104.168.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 387B143D48; Wed, 31 May 2006 10:36:51 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.62 (FreeBSD)) (envelope-from ) id 1FlO4G-0009jM-R9; Wed, 31 May 2006 11:36:48 +0100 Date: Wed, 31 May 2006 11:36:48 +0100 From: Ceri Davies To: Mark Linimon Message-ID: <20060531103648.GP21998@submonkey.net> Mail-Followup-To: Ceri Davies , Mark Linimon , Maxim Konovalov , linimon@FreeBSD.org, Matteo Riondato , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200605301910.k4UJAIMw054372@repoman.freebsd.org> <20060530232844.W69922@mp2.macomnet.net> <20060530193804.GH29390@kaiser.sig11.org> <20060530235134.I69922@mp2.macomnet.net> <20060530200425.GA16937@soaustin.net> <20060531001204.O69922@mp2.macomnet.net> <20060530205745.GA32229@soaustin.net> <20060531083048.GL21998@submonkey.net> <20060531103133.GB22144@soaustin.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bc2iwAtkAaXP8cWF" Content-Disposition: inline In-Reply-To: <20060531103133.GB22144@soaustin.net> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.11 Sender: Ceri Davies Cc: src-committers@FreeBSD.org, linimon@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Matteo Riondato , Maxim Konovalov Subject: Re: cvs commit: src/tools/tools/recoverdisk Makefile recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 10:36:52 -0000 --bc2iwAtkAaXP8cWF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 31, 2006 at 05:31:33AM -0500, Mark Linimon wrote: > On Wed, May 31, 2006 at 09:30:48AM +0100, Ceri Davies wrote: > > > Yes, but rather than trying to 'push' this information, I would sugge= st > > > that people 'pull' it via webpage queries. > >=20 > > Or a cronjob, preferably. >=20 > Well, yes, but to what list? Everything's like drinking from a firehose > as it is. Adding some duplicate postings across the various mailing lists > doesn't seem like a good idea to me. I meant that they could set up their own. Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --bc2iwAtkAaXP8cWF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEfXHAocfcwTS3JF8RAgVbAKC8SkH8ef0ZcCfwzR04YAzNsxu7RQCfRRdH UuaBzmqp1UHLUMArQML3GB0= =vvJb -----END PGP SIGNATURE----- --bc2iwAtkAaXP8cWF-- From owner-cvs-src@FreeBSD.ORG Wed May 31 11:14:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8058E16A420; Wed, 31 May 2006 11:14:32 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 49B5443D53; Wed, 31 May 2006 11:14:32 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VBDASw066926; Wed, 31 May 2006 11:13:10 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VBDAl6066925; Wed, 31 May 2006 11:13:10 GMT (envelope-from maxim) Message-Id: <200605311113.k4VBDAl6066925@repoman.freebsd.org> From: Maxim Konovalov Date: Wed, 31 May 2006 11:13:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/execve Makefile doexec.c execve.t src/tools/regression/execve/tests badinterplen devnullscript goodaout.c goodscript nonexistshell scriptarg scriptarg-nospace X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 11:14:32 -0000 maxim 2006-05-31 11:13:10 UTC FreeBSD src repository Added files: tools/regression/execve Makefile doexec.c execve.t tools/regression/execve/tests badinterplen devnullscript goodaout.c goodscript nonexistshell scriptarg scriptarg-nospace Log: o Add various regression tests for execve(2) syscall. Obtained from: NetBSD Revision Changes Path 1.1 +71 -0 src/tools/regression/execve/Makefile (new) 1.1 +58 -0 src/tools/regression/execve/doexec.c (new) 1.1 +27 -0 src/tools/regression/execve/execve.t (new) 1.1 +4 -0 src/tools/regression/execve/tests/badinterplen (new) 1.1 +4 -0 src/tools/regression/execve/tests/devnullscript (new) 1.1 +47 -0 src/tools/regression/execve/tests/goodaout.c (new) 1.1 +4 -0 src/tools/regression/execve/tests/goodscript (new) 1.1 +4 -0 src/tools/regression/execve/tests/nonexistshell (new) 1.1 +4 -0 src/tools/regression/execve/tests/scriptarg (new) 1.1 +4 -0 src/tools/regression/execve/tests/scriptarg-nospace (new) From owner-cvs-src@FreeBSD.ORG Wed May 31 11:16:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D184D16A420; Wed, 31 May 2006 11:16:38 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E60843D46; Wed, 31 May 2006 11:16:38 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VBFHO2067091; Wed, 31 May 2006 11:15:17 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VBFHIT067090; Wed, 31 May 2006 11:15:17 GMT (envelope-from maxim) Message-Id: <200605311115.k4VBFHIT067090@repoman.freebsd.org> From: Maxim Konovalov Date: Wed, 31 May 2006 11:15:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/execve Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 11:16:38 -0000 maxim 2006-05-31 11:15:16 UTC FreeBSD src repository Modified files: tools/regression/execve Makefile Log: Fix test for empty interpreter. Revision Changes Path 1.2 +1 -1 src/tools/regression/execve/Makefile From owner-cvs-src@FreeBSD.ORG Wed May 31 11:23:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4B1D16A442; Wed, 31 May 2006 11:23:39 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A98043D64; Wed, 31 May 2006 11:23:36 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VBMFgV067624; Wed, 31 May 2006 11:22:15 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VBMFE7067623; Wed, 31 May 2006 11:22:15 GMT (envelope-from maxim) Message-Id: <200605311122.k4VBMFE7067623@repoman.freebsd.org> From: Maxim Konovalov Date: Wed, 31 May 2006 11:22:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/execve Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 11:23:46 -0000 maxim 2006-05-31 11:22:15 UTC FreeBSD src repository Modified files: tools/regression/execve Makefile Log: Output directory has gone, remove it from Makefile. Revision Changes Path 1.3 +0 -1 src/tools/regression/execve/Makefile From owner-cvs-src@FreeBSD.ORG Wed May 31 11:59:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13EDA16A447; Wed, 31 May 2006 11:59:00 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A55C443D4C; Wed, 31 May 2006 11:58:59 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VBvcga076357; Wed, 31 May 2006 11:57:38 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VBvcOD076356; Wed, 31 May 2006 11:57:38 GMT (envelope-from cognet) Message-Id: <200605311157.k4VBvcOD076356@repoman.freebsd.org> From: Olivier Houchard Date: Wed, 31 May 2006 11:57:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/include pmap.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 11:59:02 -0000 cognet 2006-05-31 11:57:37 UTC FreeBSD src repository Modified files: sys/arm/include pmap.h Log: Include machine/cpuconf.h in pmap.h in order to get ARM_NMMUS defined, to appease -Wundef. Revision Changes Path 1.18 +1 -1 src/sys/arm/include/pmap.h From owner-cvs-src@FreeBSD.ORG Wed May 31 13:07:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23A0616A614; Wed, 31 May 2006 13:07:31 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C91EB43D70; Wed, 31 May 2006 13:07:30 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VD68d9093062; Wed, 31 May 2006 13:06:08 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VD68KC093061; Wed, 31 May 2006 13:06:08 GMT (envelope-from cognet) Message-Id: <200605311306.k4VD68KC093061@repoman.freebsd.org> From: Olivier Houchard Date: Wed, 31 May 2006 13:06:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/include cpuconf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 13:07:57 -0000 cognet 2006-05-31 13:06:08 UTC FreeBSD src repository Modified files: sys/arm/include cpuconf.h Log: Ooops arm10 is armv5, not armv4. Submitted by: kevlo Revision Changes Path 1.6 +3 -3 src/sys/arm/include/cpuconf.h From owner-cvs-src@FreeBSD.ORG Wed May 31 13:17:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9232C16AADB; Wed, 31 May 2006 13:17:00 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 194B543D91; Wed, 31 May 2006 13:16:51 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VDFUfE093629; Wed, 31 May 2006 13:15:30 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VDFUhD093628; Wed, 31 May 2006 13:15:30 GMT (envelope-from maxim) Message-Id: <200605311315.k4VDFUhD093628@repoman.freebsd.org> From: Maxim Konovalov Date: Wed, 31 May 2006 13:15:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 13:17:05 -0000 maxim 2006-05-31 13:15:29 UTC FreeBSD src repository Modified files: sys/ufs/ufs ufs_vnops.c Log: o According to POSIX, the result of ftruncate(2) is unspecified for file types other than VREG, VDIR and shared memory objects. We already handle VREG, VLNK and VDIR cases. Silently ignore truncate requests for all the rest. Adjust comments. PR: kern/98064 Submitted by: bde Security: local DoS Regress. test: regression/fifo/fifo_misc MFC after: 2 weeks Revision Changes Path 1.276 +22 -4 src/sys/ufs/ufs/ufs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed May 31 13:43:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 678ED16AF93; Wed, 31 May 2006 13:43:33 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id D463343D72; Wed, 31 May 2006 13:43:32 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k4VDhQ78098325; Wed, 31 May 2006 07:43:31 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <447D9DAB.90305@samsco.org> Date: Wed, 31 May 2006 07:44:11 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ian Dowse References: <200605310905.k4V95njZ054771@repoman.freebsd.org> In-Reply-To: <200605310905.k4V95njZ054771@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/libi386 biosdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 13:43:41 -0000 Ian Dowse wrote: > iedowse 2006-05-31 09:05:49 UTC > > FreeBSD src repository > > Modified files: > sys/boot/i386/libi386 biosdisk.c > Log: > Increment the disk block offset after writing, not before. This > fixes filesystem corruption when nextboot.conf is located after > cylinder 1023. The bug appears to have been introduced at the time > bd_read was copied to create bd_write. > > PR: bin/98005 > Reported by: yar > MFC after: 1 week > > Revision Changes Path > 1.47 +3 -3 src/sys/boot/i386/libi386/biosdisk.c Excellent job finding this! Scott From owner-cvs-src@FreeBSD.ORG Wed May 31 13:49:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 562C416A5EC; Wed, 31 May 2006 13:49:00 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56AD343D58; Wed, 31 May 2006 13:48:59 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VDlWZP097328; Wed, 31 May 2006 13:47:32 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VDlWEm097327; Wed, 31 May 2006 13:47:32 GMT (envelope-from maxim) Message-Id: <200605311347.k4VDlWEm097327@repoman.freebsd.org> From: Maxim Konovalov Date: Wed, 31 May 2006 13:47:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys elf_common.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 13:49:03 -0000 maxim 2006-05-31 13:47:32 UTC FreeBSD src repository Modified files: sys/sys elf_common.h Log: o Correct URL to ELF header documantation. PR: kern/98213 Submitted by: Robert Gogolok Revision Changes Path 1.19 +2 -2 src/sys/sys/elf_common.h From owner-cvs-src@FreeBSD.ORG Wed May 31 14:07:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6A3016A5D0; Wed, 31 May 2006 14:07:28 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 93DB543D53; Wed, 31 May 2006 14:07:28 +0000 (GMT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VE66WD099535; Wed, 31 May 2006 14:06:06 GMT (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VE666A099534; Wed, 31 May 2006 14:06:06 GMT (envelope-from dds) Message-Id: <200605311406.k4VE666A099534@repoman.freebsd.org> From: Diomidis Spinellis Date: Wed, 31 May 2006 14:06:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vnode_if.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 14:07:42 -0000 dds 2006-05-31 14:06:06 UTC FreeBSD src repository Modified files: sys/kern vnode_if.src Log: Remove two locking assertion entries that: a) were incorrectly written and therefore never compiled into assertions, and b) were incorrectly specified and when compiled resulted in a failed assertion. Revision Changes Path 1.83 +0 -2 src/sys/kern/vnode_if.src From owner-cvs-src@FreeBSD.ORG Wed May 31 14:19:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B268516A71C; Wed, 31 May 2006 14:19:27 +0000 (UTC) (envelope-from mj@feral.com) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 160CC43D6A; Wed, 31 May 2006 14:19:25 +0000 (GMT) (envelope-from mj@feral.com) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.6/8.13.6) with ESMTP id k4VEJPFX072659; Wed, 31 May 2006 07:19:25 -0700 (PDT) (envelope-from mj@feral.com) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.6/8.13.6/Submit) with ESMTP id k4VEJPw1072656; Wed, 31 May 2006 07:19:25 -0700 (PDT) (envelope-from mj@feral.com) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Wed, 31 May 2006 07:19:25 -0700 (PDT) From: Matthew Jacob X-X-Sender: mjacob@ns1.feral.com To: Don Lewis In-Reply-To: <200605310930.k4V9UpWa001360@gw.catspoiler.org> Message-ID: <20060531071852.Q72653@ns1.feral.com> References: <200605310930.k4V9UpWa001360@gw.catspoiler.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_all.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Matthew Jacob List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 14:19:36 -0000 *blink*? It did break things? My apologies- I could have sworn that I'd done a LINT check. Sorry- I'll get right on this. On Wed, 31 May 2006, Don Lewis wrote: > On 30 May, Matt Jacob wrote: >> mjacob 2006-05-30 22:44:00 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/cam cam_xpt.c >> sys/cam/scsi scsi_all.h >> Log: >> Handle some of the inquiry flags that have come into >> usage as of SPC2r20. Specifically, handle the BQueue >> flag which will indicate that a device supports the >> Basic Queueing model (no Head of Queue or Ordered tags). >> When this flag is set, SID_CmdQueue is clear. This has >> causes FreeBSD to assume that the device did not support >> tagged operations. > > This commit broke compilation of the ahb driver, which appears to be > trying to get the number of ecbs from the spc2_flags member of > scsi_inquiry_data, which it tries to access under the old member name, > reserved[1]. Not that I care all that much because I don't have any ahb > hardware, but this driver is included in the GENERIC kernel. > > From owner-cvs-src@FreeBSD.ORG Wed May 31 14:27:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB7EC16B2F8; Wed, 31 May 2006 14:27:25 +0000 (UTC) (envelope-from mj@feral.com) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2569843D46; Wed, 31 May 2006 14:27:25 +0000 (GMT) (envelope-from mj@feral.com) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.6/8.13.6) with ESMTP id k4VERO4X072820; Wed, 31 May 2006 07:27:24 -0700 (PDT) (envelope-from mj@feral.com) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.6/8.13.6/Submit) with ESMTP id k4VEROUu072817; Wed, 31 May 2006 07:27:24 -0700 (PDT) (envelope-from mj@feral.com) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Wed, 31 May 2006 07:27:24 -0700 (PDT) From: Matthew Jacob X-X-Sender: mjacob@ns1.feral.com To: Matthew Jacob In-Reply-To: <20060531071852.Q72653@ns1.feral.com> Message-ID: <20060531072706.U72653@ns1.feral.com> References: <200605310930.k4V9UpWa001360@gw.catspoiler.org> <20060531071852.Q72653@ns1.feral.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Don Lewis , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_all.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Matthew Jacob List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 14:27:30 -0000 Sorry- my bad- I did this for amd64 and somehow missed my checklist to do it also on i386. On Wed, 31 May 2006, Matthew Jacob wrote: > > *blink*? It did break things? My apologies- I could have sworn that I'd done > a LINT check. Sorry- I'll get right on this. > > On Wed, 31 May 2006, Don Lewis wrote: > >> On 30 May, Matt Jacob wrote: >>> mjacob 2006-05-30 22:44:00 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/cam cam_xpt.c >>> sys/cam/scsi scsi_all.h >>> Log: >>> Handle some of the inquiry flags that have come into >>> usage as of SPC2r20. Specifically, handle the BQueue >>> flag which will indicate that a device supports the >>> Basic Queueing model (no Head of Queue or Ordered tags). >>> When this flag is set, SID_CmdQueue is clear. This has >>> causes FreeBSD to assume that the device did not support >>> tagged operations. >> >> This commit broke compilation of the ahb driver, which appears to be >> trying to get the number of ecbs from the spc2_flags member of >> scsi_inquiry_data, which it tries to access under the old member name, >> reserved[1]. Not that I care all that much because I don't have any ahb >> hardware, but this driver is included in the GENERIC kernel. >> >> > From owner-cvs-src@FreeBSD.ORG Wed May 31 14:34:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3BF2616A5A6; Wed, 31 May 2006 14:34:46 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DDD0043D46; Wed, 31 May 2006 14:34:45 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VEXNgZ000885; Wed, 31 May 2006 14:33:23 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VEXN3Y000884; Wed, 31 May 2006 14:33:23 GMT (envelope-from mjacob) Message-Id: <200605311433.k4VEXN3Y000884@repoman.freebsd.org> From: Matt Jacob Date: Wed, 31 May 2006 14:33:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ahb ahb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 14:35:09 -0000 mjacob 2006-05-31 14:33:23 UTC FreeBSD src repository Modified files: sys/dev/ahb ahb.c Log: Fix missing update to reflect change in scsi_inquiry data structure. Revision Changes Path 1.35 +1 -1 src/sys/dev/ahb/ahb.c From owner-cvs-src@FreeBSD.ORG Wed May 31 14:50:29 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66EB816B122; Wed, 31 May 2006 14:50:29 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id A3FC443D48; Wed, 31 May 2006 14:50:26 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [131.106.61.215] (72-255-64-170.client.stsn.net [72.255.64.170]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k4VEoL84068255; Wed, 31 May 2006 10:50:25 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Wed, 31 May 2006 10:50:11 -0400 User-Agent: KMail/1.9.1 References: <200605252306.k4PN6cCS081708@repoman.freebsd.org> <44766F75.9060100@samsco.org> In-Reply-To: <44766F75.9060100@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200605311050.12156.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1501/Wed May 31 06:23:26 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.2 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Warner Losh , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/syscons/apm apm_saver.c src/sys/i386/bios apm.c apm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 14:50:32 -0000 On Thursday 25 May 2006 23:01, Scott Long wrote: > Warner Losh wrote: > > > imp 2006-05-25 23:06:38 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/syscons/apm apm_saver.c > > sys/i386/bios apm.c apm.h > > Log: > > APM was calling the suspend process from a timeout. This meant that > > other timeouts could not happen while suspending, including timeouts > > for things like msleep. This caused the system to hang on suspend > > when the cbb was enabled, since its suspend path powered down the > > socket which used a timeout to wait for it to be done. > > > > APM now creates a thread when it is enabled, and deletes the thread > > when it is disabled. This thread takes the place of the timeout by > > doing its polling every ~.9s. When the thread is disabled, it will > > wakeup early, otherwise it times out and polls the varius things the > > old timeout polled (APM events, suspend delays, etc). > > > > This makes my Sony VAIO 505TS suspend/resume correctly when APM is > > enabled (ACPI is black listed on my 505TS). > > > > This will likely fix other problems with the suspend path where > > drivers would sleep with msleep and/or do other timeouts. Maybe > > there's some special case code that would use DELAY while suspending > > and msleep otherwise that can be revisited and removed. > > > > This was also tested by glebius@, who pointed out that in the patch I > > sent him, I'd forgotten apm_saver.c > > > > MFC After: 3 weeks > > In the past, I've been against mandating that callouts/timeouts/generic > taskqueues should not be allowed to sleep. However, after looking over > the history of this problem as well as others, it seems that it's just > too easy for driver authors to make bad assumptions and wind up with a > priority inversion/deadlock like this. It would be relatively trivial > to mark these contexts as being non-sleepable and have the msleep code > enforce it, like is done with ithreads. What do you think? Anyways, > thanks for looking at this and fixing it. We already do for timeouts if INVARIANTS is on: softclock() { ... THREAD_NO_SLEEPING(); c_func(c_arg); THREAD_SLEEPING_OK(); ... } That has been in place since 6.0 IIRC. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Wed May 31 14:58:59 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 75CD216B1B3; Wed, 31 May 2006 14:58:59 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 95DA243D58; Wed, 31 May 2006 14:58:52 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [10.10.3.185] ([69.15.205.254]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k4VEwhoW098789; Wed, 31 May 2006 08:58:49 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <447DAF19.3050901@samsco.org> Date: Wed, 31 May 2006 08:58:33 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060206 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200605252306.k4PN6cCS081708@repoman.freebsd.org> <44766F75.9060100@samsco.org> <200605311050.12156.jhb@freebsd.org> In-Reply-To: <200605311050.12156.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=3.8 tests=none autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Warner Losh , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/syscons/apm apm_saver.c src/sys/i386/bios apm.c apm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 14:59:05 -0000 John Baldwin wrote: > On Thursday 25 May 2006 23:01, Scott Long wrote: > >>Warner Losh wrote: >> >> >>>imp 2006-05-25 23:06:38 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/dev/syscons/apm apm_saver.c >>> sys/i386/bios apm.c apm.h >>> Log: >>> APM was calling the suspend process from a timeout. This meant that >>> other timeouts could not happen while suspending, including timeouts >>> for things like msleep. This caused the system to hang on suspend >>> when the cbb was enabled, since its suspend path powered down the >>> socket which used a timeout to wait for it to be done. >>> >>> APM now creates a thread when it is enabled, and deletes the thread >>> when it is disabled. This thread takes the place of the timeout by >>> doing its polling every ~.9s. When the thread is disabled, it will >>> wakeup early, otherwise it times out and polls the varius things the >>> old timeout polled (APM events, suspend delays, etc). >>> >>> This makes my Sony VAIO 505TS suspend/resume correctly when APM is >>> enabled (ACPI is black listed on my 505TS). >>> >>> This will likely fix other problems with the suspend path where >>> drivers would sleep with msleep and/or do other timeouts. Maybe >>> there's some special case code that would use DELAY while suspending >>> and msleep otherwise that can be revisited and removed. >>> >>> This was also tested by glebius@, who pointed out that in the patch I >>> sent him, I'd forgotten apm_saver.c >>> >>> MFC After: 3 weeks >> >>In the past, I've been against mandating that callouts/timeouts/generic >>taskqueues should not be allowed to sleep. However, after looking over >>the history of this problem as well as others, it seems that it's just >>too easy for driver authors to make bad assumptions and wind up with a >>priority inversion/deadlock like this. It would be relatively trivial >>to mark these contexts as being non-sleepable and have the msleep code >>enforce it, like is done with ithreads. What do you think? Anyways, >>thanks for looking at this and fixing it. > > > We already do for timeouts if INVARIANTS is on: > > softclock() > { > ... > THREAD_NO_SLEEPING(); > c_func(c_arg); > THREAD_SLEEPING_OK(); > ... > } > > That has been in place since 6.0 IIRC. > I thought that it was only enabled for DIAGNOSTIC. Scott From owner-cvs-src@FreeBSD.ORG Wed May 31 15:36:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0641816A4AB; Wed, 31 May 2006 15:36:02 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4F7743D58; Wed, 31 May 2006 15:36:01 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VFYdeY005035; Wed, 31 May 2006 15:34:39 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VFYd4M005034; Wed, 31 May 2006 15:34:39 GMT (envelope-from bmah) Message-Id: <200605311534.k4VFYd4M005034@repoman.freebsd.org> From: "Bruce A. Mah" Date: Wed, 31 May 2006 15:34:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 15:36:05 -0000 bmah 2006-05-31 15:34:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/doc/en_US.ISO8859-1/errata article.sgml Log: New errata: Torrents are available. Revision Changes Path 1.69.2.38 +6 -1 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Wed May 31 15:51:19 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95CDB16A656; Wed, 31 May 2006 15:51:19 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id F27D443D55; Wed, 31 May 2006 15:51:18 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [131.106.61.215] (72-255-64-170.client.stsn.net [72.255.64.170]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k4VFpAY8068654; Wed, 31 May 2006 11:51:16 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Wed, 31 May 2006 11:23:01 -0400 User-Agent: KMail/1.9.1 References: <200605252306.k4PN6cCS081708@repoman.freebsd.org> <200605311050.12156.jhb@freebsd.org> <447DAF19.3050901@samsco.org> In-Reply-To: <447DAF19.3050901@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200605311123.02334.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1501/Wed May 31 06:23:26 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.1 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Warner Losh , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/syscons/apm apm_saver.c src/sys/i386/bios apm.c apm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 15:51:25 -0000 On Wednesday 31 May 2006 10:58, Scott Long wrote: > John Baldwin wrote: > > On Thursday 25 May 2006 23:01, Scott Long wrote: > > > >>Warner Losh wrote: > >> > >> > >>>imp 2006-05-25 23:06:38 UTC > >>> > >>> FreeBSD src repository > >>> > >>> Modified files: > >>> sys/dev/syscons/apm apm_saver.c > >>> sys/i386/bios apm.c apm.h > >>> Log: > >>> APM was calling the suspend process from a timeout. This meant that > >>> other timeouts could not happen while suspending, including timeouts > >>> for things like msleep. This caused the system to hang on suspend > >>> when the cbb was enabled, since its suspend path powered down the > >>> socket which used a timeout to wait for it to be done. > >>> > >>> APM now creates a thread when it is enabled, and deletes the thread > >>> when it is disabled. This thread takes the place of the timeout by > >>> doing its polling every ~.9s. When the thread is disabled, it will > >>> wakeup early, otherwise it times out and polls the varius things the > >>> old timeout polled (APM events, suspend delays, etc). > >>> > >>> This makes my Sony VAIO 505TS suspend/resume correctly when APM is > >>> enabled (ACPI is black listed on my 505TS). > >>> > >>> This will likely fix other problems with the suspend path where > >>> drivers would sleep with msleep and/or do other timeouts. Maybe > >>> there's some special case code that would use DELAY while suspending > >>> and msleep otherwise that can be revisited and removed. > >>> > >>> This was also tested by glebius@, who pointed out that in the patch I > >>> sent him, I'd forgotten apm_saver.c > >>> > >>> MFC After: 3 weeks > >> > >>In the past, I've been against mandating that callouts/timeouts/generic > >>taskqueues should not be allowed to sleep. However, after looking over > >>the history of this problem as well as others, it seems that it's just > >>too easy for driver authors to make bad assumptions and wind up with a > >>priority inversion/deadlock like this. It would be relatively trivial > >>to mark these contexts as being non-sleepable and have the msleep code > >>enforce it, like is done with ithreads. What do you think? Anyways, > >>thanks for looking at this and fixing it. > > > > > > We already do for timeouts if INVARIANTS is on: > > > > softclock() > > { > > ... > > THREAD_NO_SLEEPING(); > > c_func(c_arg); > > THREAD_SLEEPING_OK(); > > ... > > } > > > > That has been in place since 6.0 IIRC. > > > > I thought that it was only enabled for DIAGNOSTIC. > > Scott Nah, that was phk's other timekeeping code to see which timeouts take a long time to execute. The THREAD_NO_SLEEPING() stuff was added just before 6.0 was released and replaced a couple of "special" mutexes that were held just to provoke WITNESS warnings. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Wed May 31 15:51:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F9E216B7BB; Wed, 31 May 2006 15:51:56 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EDA2F43D53; Wed, 31 May 2006 15:51:55 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VFoXrK005768; Wed, 31 May 2006 15:50:33 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VFoXWr005766; Wed, 31 May 2006 15:50:33 GMT (envelope-from cognet) Message-Id: <200605311550.k4VFoXWr005766@repoman.freebsd.org> From: Olivier Houchard Date: Wed, 31 May 2006 15:50:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/arm busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 15:51:56 -0000 cognet 2006-05-31 15:50:33 UTC FreeBSD src repository Modified files: sys/arm/arm busdma_machdep.c Log: If our buffer is not aligned on the cache line size, write back/invalidate the first and last cache line in PREREAD, and just invalidate the cache lines in POSTREAD, instead of write-back/invalidating in POSTREAD, which could lead to stale data overriding what has been transfered by DMA. Revision Changes Path 1.26 +10 -7 src/sys/arm/arm/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Wed May 31 15:53:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 968B416AAC0; Wed, 31 May 2006 15:53:34 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F1E443D58; Wed, 31 May 2006 15:53:34 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VFqB8q005881; Wed, 31 May 2006 15:52:11 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VFqB7d005880; Wed, 31 May 2006 15:52:11 GMT (envelope-from cognet) Message-Id: <200605311552.k4VFqB7d005880@repoman.freebsd.org> From: Olivier Houchard Date: Wed, 31 May 2006 15:52:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/arm pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 15:53:41 -0000 cognet 2006-05-31 15:52:11 UTC FreeBSD src repository Modified files: sys/arm/arm pmap.c Log: Avoid a LOR by unlocking the vm_page_queue_mtx before calling uma_zalloc, and freeing the allocated memory if another thread already did the same. Revision Changes Path 1.51 +35 -5 src/sys/arm/arm/pmap.c From owner-cvs-src@FreeBSD.ORG Wed May 31 15:57:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D46116A720; Wed, 31 May 2006 15:57:15 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C2F643D46; Wed, 31 May 2006 15:57:15 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VFtqHn006114; Wed, 31 May 2006 15:55:52 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VFtq1p006113; Wed, 31 May 2006 15:55:52 GMT (envelope-from maxim) Message-Id: <200605311555.k4VFtq1p006113@repoman.freebsd.org> From: Maxim Konovalov Date: Wed, 31 May 2006 15:55:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 15:57:16 -0000 maxim 2006-05-31 15:55:52 UTC FreeBSD src repository Modified files: sys/ufs/ufs ufs_vnops.c Log: o Rearrange and remove incorrect comments. Requested by: bde Revision Changes Path 1.277 +3 -8 src/sys/ufs/ufs/ufs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed May 31 18:51:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F51216ACDE; Wed, 31 May 2006 18:51:14 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F20A43D53; Wed, 31 May 2006 18:51:14 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VInpeN040612; Wed, 31 May 2006 18:49:51 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VInpMj040611; Wed, 31 May 2006 18:49:51 GMT (envelope-from mjacob) Message-Id: <200605311849.k4VInpMj040611@repoman.freebsd.org> From: Matt Jacob Date: Wed, 31 May 2006 18:49:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/isp isp_freebsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 18:51:27 -0000 mjacob 2006-05-31 18:49:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/isp isp_freebsd.c Log: MFC 1.117: Don't set CAM_DEV_QFRZN when we get an ABORT_TASK. Just by itself, this makes no sense. Revision Changes Path 1.105.2.4 +1 -1 src/sys/dev/isp/isp_freebsd.c From owner-cvs-src@FreeBSD.ORG Wed May 31 19:13:24 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E24416BA1C; Wed, 31 May 2006 19:13:24 +0000 (UTC) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5352543D76; Wed, 31 May 2006 19:13:22 +0000 (GMT) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VJBxhv060568; Wed, 31 May 2006 19:11:59 GMT (envelope-from ceri@repoman.freebsd.org) Received: (from ceri@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VJBxGl060567; Wed, 31 May 2006 19:11:59 GMT (envelope-from ceri) Message-Id: <200605311911.k4VJBxGl060567@repoman.freebsd.org> From: Ceri Davies Date: Wed, 31 May 2006 19:11:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/crunch/crunchgen crunchgen.1 crunchgen.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 19:13:36 -0000 ceri 2006-05-31 19:11:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/crunch/crunchgen crunchgen.1 crunchgen.c Log: MFC crunchgen.1 revisions 1.29 - 1.30 and crunchgen.c revision 1.36: Commands like gmirror, graid3, ... and others which use dlopen() to load classes from say, /lib/geom, cannot be statically linked completely. Moreover, those shared objects may require other shared objects (i.e. for geom, libraries like -lmd, -lcrypto). The libs_so extension to crunchgen fixes this by allowing some libraries to be linked in dynamically. This requires that a copy of rtld and the shared libraries be made available to the crunched binary, and so is not suitable for all environments. Crunchgen configurations which do not use the 'libs_so' keyword are unaffected and produce identical binaries with and without this commit. Approved by: jhb In collaboration with: Adrian Steinmann Revision Changes Path 1.28.14.1 +31 -3 src/usr.sbin/crunch/crunchgen/crunchgen.1 1.35.2.1 +65 -2 src/usr.sbin/crunch/crunchgen/crunchgen.c From owner-cvs-src@FreeBSD.ORG Wed May 31 19:16:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A53416BA91; Wed, 31 May 2006 19:16:44 +0000 (UTC) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2DDD43D55; Wed, 31 May 2006 19:16:43 +0000 (GMT) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VJFKkY060743; Wed, 31 May 2006 19:15:21 GMT (envelope-from ceri@repoman.freebsd.org) Received: (from ceri@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VJFKef060742; Wed, 31 May 2006 19:15:20 GMT (envelope-from ceri) Message-Id: <200605311915.k4VJFKef060742@repoman.freebsd.org> From: Ceri Davies Date: Wed, 31 May 2006 19:15:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/sysinstall installUpgrade.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 19:16:54 -0000 ceri 2006-05-31 19:15:20 UTC FreeBSD src repository Modified files: usr.sbin/sysinstall installUpgrade.c Log: Update the location of the kernel for upgrades. I considered leaving /boot/kernel out of the chflags noschg line, but I seem to remember that there was a period where /boot/kernel was schg, so have left it in for safety's sake. Approved by: jhb MFC after: 1 month Revision Changes Path 1.88 +7 -6 src/usr.sbin/sysinstall/installUpgrade.c From owner-cvs-src@FreeBSD.ORG Wed May 31 19:18:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 72F7716BA9E; Wed, 31 May 2006 19:18:04 +0000 (UTC) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0FD7743D7B; Wed, 31 May 2006 19:17:58 +0000 (GMT) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VJGZZb060816; Wed, 31 May 2006 19:16:35 GMT (envelope-from ceri@repoman.freebsd.org) Received: (from ceri@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VJGZD3060815; Wed, 31 May 2006 19:16:35 GMT (envelope-from ceri) Message-Id: <200605311916.k4VJGZD3060815@repoman.freebsd.org> From: Ceri Davies Date: Wed, 31 May 2006 19:16:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/sysinstall installUpgrade.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 19:18:18 -0000 ceri 2006-05-31 19:16:34 UTC FreeBSD src repository Modified files: usr.sbin/sysinstall installUpgrade.c Log: Bring the "just copy" hit list closer to date. Approved by: jhb MFC after: 1 month Revision Changes Path 1.89 +9 -2 src/usr.sbin/sysinstall/installUpgrade.c From owner-cvs-src@FreeBSD.ORG Wed May 31 20:25:45 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 07CCB16AEF8; Wed, 31 May 2006 20:25:45 +0000 (UTC) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B141743D73; Wed, 31 May 2006 20:25:44 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VKOLhi067957; Wed, 31 May 2006 20:24:21 GMT (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VKOLFs067956; Wed, 31 May 2006 20:24:21 GMT (envelope-from ps) Message-Id: <200605312024.k4VKOLFs067956@repoman.freebsd.org> From: Paul Saab Date: Wed, 31 May 2006 20:24:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 20:25:52 -0000 ps 2006-05-31 20:24:21 UTC FreeBSD src repository Modified files: . access Log: Add davidch who will be maintaining the bce driver Approved by: core Revision Changes Path 1.774 +1 -0 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Wed May 31 21:26:48 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7124816B9A3; Wed, 31 May 2006 21:26:48 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from rwcrmhc11.comcast.net (rwcrmhc11.comcast.net [204.127.192.81]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5448443D4C; Wed, 31 May 2006 21:26:47 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-24-147-19-128.hsd1.ma.comcast.net (c-71-233-168-2.hsd1.ma.comcast.net[71.233.168.2](misconfigured sender)) by comcast.net (rwcrmhc11) with ESMTP id <20060531212645m1100gkpu7e>; Wed, 31 May 2006 21:26:46 +0000 Received: from c-24-147-19-128.hsd1.ma.comcast.net (localhost [127.0.0.1]) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1) with ESMTP id k4VLQjNa007550; Wed, 31 May 2006 17:26:45 -0400 (EDT) (envelope-from rodrigc@c-24-147-19-128.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1/Submit) id k4VLQiFs007549; Wed, 31 May 2006 17:26:44 -0400 (EDT) (envelope-from rodrigc) Date: Wed, 31 May 2006 17:26:44 -0400 From: Craig Rodrigues To: Maxim Konovalov Message-ID: <20060531212644.GA7541@crodrigues.org> References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> <20060529215827.D78736@mp2.macomnet.net> <20060530034531.GA36462@crodrigues.org> <20060530110750.A96470@mp2.macomnet.net> <20060530224448.GA42556@crodrigues.org> <20060531114119.T70660@mp2.macomnet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060531114119.T70660@mp2.macomnet.net> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 21:26:50 -0000 On Wed, May 31, 2006 at 11:44:14AM +0400, Maxim Konovalov wrote: > This one works, thanks! But I worry about mountd/NFS interaction to > mount I described in my first email. Any ideas? Not sure about the mountd/NFS interaction yet. This patch is a bit better for mount(8): Index: mount.c =================================================================== RCS file: /home/ncvs/src/sbin/mount/mount.c,v retrieving revision 1.84 diff -u -u -r1.84 mount.c --- mount.c 10 May 2006 14:40:40 -0000 1.84 +++ mount.c 31 May 2006 21:23:35 -0000 @@ -184,6 +184,26 @@ return (0); } +static +int specified_ro(const char *arg) +{ + char *optbuf, *opt; + int ret = 0; + + optbuf = strdup(arg); + if (optbuf == NULL) + err(1, NULL); + + for (opt = optbuf; (opt = strtok(opt, ",")) != NULL; opt = NULL) { + if (strcmp(opt, "ro") == 0) { + ret = 1; + break; + } + } + free(optbuf); + return (ret); +} + int main(int argc, char *argv[]) { @@ -215,8 +236,11 @@ init_flags |= MNT_FORCE; break; case 'o': - if (*optarg) + if (*optarg) { options = catopt(options, optarg); + if (specified_ro(optarg)) + ro = 1; + } break; case 'p': fstab_style = 1; -- Craig Rodrigues rodrigc@crodrigues.org From owner-cvs-src@FreeBSD.ORG Wed May 31 21:33:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E580016AC7B; Wed, 31 May 2006 21:33:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2443B43D6D; Wed, 31 May 2006 21:33:47 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VLWOtX087971; Wed, 31 May 2006 21:32:24 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VLWOKC087970; Wed, 31 May 2006 21:32:24 GMT (envelope-from jhb) Message-Id: <200605312132.k4VLWOKC087970@repoman.freebsd.org> From: John Baldwin Date: Wed, 31 May 2006 21:32:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/boot/i386/boot0 boot0.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 21:34:00 -0000 jhb 2006-05-31 21:32:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/boot/i386/boot0 boot0.S Log: MFC: Restore the pre-5.x behavior of only beeping if the user makes a bad selection. Revision Changes Path 1.14.2.1 +8 -5 src/sys/boot/i386/boot0/boot0.S From owner-cvs-src@FreeBSD.ORG Wed May 31 21:38:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3634C16B179; Wed, 31 May 2006 21:38:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB4B743D49; Wed, 31 May 2006 21:38:34 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VLbB6I088318; Wed, 31 May 2006 21:37:11 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VLbBiH088317; Wed, 31 May 2006 21:37:11 GMT (envelope-from jhb) Message-Id: <200605312137.k4VLbBiH088317@repoman.freebsd.org> From: John Baldwin Date: Wed, 31 May 2006 21:37:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/pci fixup_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 21:38:39 -0000 jhb 2006-05-31 21:37:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/pci fixup_pci.c Log: MFC: Workaround a hang on some nForce2 systems that can happen if the CPU goes into and out of the halt state very quickly. Revision Changes Path 1.6.8.1 +38 -0 src/sys/dev/pci/fixup_pci.c From owner-cvs-src@FreeBSD.ORG Wed May 31 21:43:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B99E816B6E6; Wed, 31 May 2006 21:43:35 +0000 (UTC) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7372C43D48; Wed, 31 May 2006 21:43:35 +0000 (GMT) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VLgC5D088549; Wed, 31 May 2006 21:42:12 GMT (envelope-from wilko@repoman.freebsd.org) Received: (from wilko@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VLgCoE088548; Wed, 31 May 2006 21:42:12 GMT (envelope-from wilko) Message-Id: <200605312142.k4VLgCoE088548@repoman.freebsd.org> From: Wilko Bulte Date: Wed, 31 May 2006 21:42:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/alpha/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 21:43:37 -0000 wilko 2006-05-31 21:42:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/alpha/conf GENERIC Log: add re(4) to GENERIC. The RL8169s worked just fine for me on my release building DS20E with the CVS repo mounted via NFS. For EUR 10 that is not too bad :) Revision Changes Path 1.186.2.5 +1 -0 src/sys/alpha/conf/GENERIC From owner-cvs-src@FreeBSD.ORG Wed May 31 22:32:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BADA16C065; Wed, 31 May 2006 22:32:34 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 79F5E43D6A; Wed, 31 May 2006 22:32:32 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VMV8ch093667; Wed, 31 May 2006 22:31:08 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VMV8pX093666; Wed, 31 May 2006 22:31:08 GMT (envelope-from cperciva) Message-Id: <200605312231.k4VMV8pX093666@repoman.freebsd.org> From: Colin Percival Date: Wed, 31 May 2006 22:31:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/smbfs smbfs_vnops.c src/usr.sbin/ypserv yp_access.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 22:32:38 -0000 cperciva 2006-05-31 22:31:08 UTC FreeBSD src repository Modified files: sys/fs/smbfs smbfs_vnops.c usr.sbin/ypserv yp_access.c Log: Enable inadvertantly disabled "securenet" access controls in ypserv. [1] Correct a bug in the handling of backslash characters in smbfs which can allow an attacker to escape from a chroot(2). [2] Security: FreeBSD-SA-06:15.ypserv [1] Security: FreeBSD-SA-06:16.smbfs [2] Revision Changes Path 1.62 +8 -1 src/sys/fs/smbfs/smbfs_vnops.c 1.23 +22 -15 src/usr.sbin/ypserv/yp_access.c From owner-cvs-src@FreeBSD.ORG Wed May 31 22:32:48 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BBE6316C046; Wed, 31 May 2006 22:32:48 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1357943D7B; Wed, 31 May 2006 22:32:45 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VMVLlN093719; Wed, 31 May 2006 22:31:21 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VMVLHM093718; Wed, 31 May 2006 22:31:21 GMT (envelope-from cperciva) Message-Id: <200605312231.k4VMVLHM093718@repoman.freebsd.org> From: Colin Percival Date: Wed, 31 May 2006 22:31:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/smbfs smbfs_vnops.c src/usr.sbin/ypserv yp_access.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 22:32:50 -0000 cperciva 2006-05-31 22:31:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/smbfs smbfs_vnops.c usr.sbin/ypserv yp_access.c Log: Enable inadvertantly disabled "securenet" access controls in ypserv. [1] Correct a bug in the handling of backslash characters in smbfs which can allow an attacker to escape from a chroot(2). [2] Security: FreeBSD-SA-06:15.ypserv [1] Security: FreeBSD-SA-06:16.smbfs [2] Revision Changes Path 1.61.2.2 +8 -1 src/sys/fs/smbfs/smbfs_vnops.c 1.22.12.1 +22 -15 src/usr.sbin/ypserv/yp_access.c From owner-cvs-src@FreeBSD.ORG Wed May 31 22:33:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5005E16C174; Wed, 31 May 2006 22:33:20 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D98743D93; Wed, 31 May 2006 22:33:06 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VMVgAd093811; Wed, 31 May 2006 22:31:42 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VMVgb6093810; Wed, 31 May 2006 22:31:42 GMT (envelope-from cperciva) Message-Id: <200605312231.k4VMVgb6093810@repoman.freebsd.org> From: Colin Percival Date: Wed, 31 May 2006 22:31:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_1 Cc: Subject: cvs commit: src UPDATING src/sys/conf newvers.sh src/sys/fs/smbfs smbfs_vnops.c src/usr.sbin/ypserv yp_access.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 22:33:21 -0000 cperciva 2006-05-31 22:31:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_1) . UPDATING sys/conf newvers.sh sys/fs/smbfs smbfs_vnops.c usr.sbin/ypserv yp_access.c Log: Enable inadvertantly disabled "securenet" access controls in ypserv. [1] Correct a bug in the handling of backslash characters in smbfs which can allow an attacker to escape from a chroot(2). [2] Approved by: so (cperciva) Security: FreeBSD-SA-06:15.ypserv [1] Security: FreeBSD-SA-06:16.smbfs [2] Revision Changes Path 1.416.2.22.2.3 +7 -0 src/UPDATING 1.69.2.11.2.3 +1 -1 src/sys/conf/newvers.sh 1.61.2.1.2.1 +8 -1 src/sys/fs/smbfs/smbfs_vnops.c 1.22.16.1 +22 -15 src/usr.sbin/ypserv/yp_access.c From owner-cvs-src@FreeBSD.ORG Wed May 31 22:33:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D53D16A899; Wed, 31 May 2006 22:33:35 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56A4E43D79; Wed, 31 May 2006 22:33:27 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VMW4Ia093935; Wed, 31 May 2006 22:32:04 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VMW45W093934; Wed, 31 May 2006 22:32:04 GMT (envelope-from cperciva) Message-Id: <200605312232.k4VMW45W093934@repoman.freebsd.org> From: Colin Percival Date: Wed, 31 May 2006 22:32:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_0 Cc: Subject: cvs commit: src UPDATING src/sys/conf newvers.sh src/sys/fs/smbfs smbfs_vnops.c src/usr.sbin/ypserv yp_access.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 22:33:41 -0000 cperciva 2006-05-31 22:32:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_0) . UPDATING sys/conf newvers.sh sys/fs/smbfs smbfs_vnops.c usr.sbin/ypserv yp_access.c Log: Enable inadvertantly disabled "securenet" access controls in ypserv. [1] Correct a bug in the handling of backslash characters in smbfs which can allow an attacker to escape from a chroot(2). [2] Approved by: so (cperciva) Security: FreeBSD-SA-06:15.ypserv [1] Security: FreeBSD-SA-06:16.smbfs [2] Revision Changes Path 1.416.2.3.2.13 +7 -0 src/UPDATING 1.69.2.8.2.9 +1 -1 src/sys/conf/newvers.sh 1.61.4.1 +8 -1 src/sys/fs/smbfs/smbfs_vnops.c 1.22.14.1 +22 -15 src/usr.sbin/ypserv/yp_access.c From owner-cvs-src@FreeBSD.ORG Wed May 31 22:33:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9650916BA24; Wed, 31 May 2006 22:33:47 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1DD6F43D62; Wed, 31 May 2006 22:33:46 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VMWMnH093999; Wed, 31 May 2006 22:32:22 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VMWMuJ093998; Wed, 31 May 2006 22:32:22 GMT (envelope-from cperciva) Message-Id: <200605312232.k4VMWMuJ093998@repoman.freebsd.org> From: Colin Percival Date: Wed, 31 May 2006 22:32:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/fs/smbfs smbfs_vnops.c src/usr.sbin/ypserv yp_access.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 22:33:55 -0000 cperciva 2006-05-31 22:32:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/fs/smbfs smbfs_vnops.c usr.sbin/ypserv yp_access.c Log: Enable inadvertantly disabled "securenet" access controls in ypserv. [1] Correct a bug in the handling of backslash characters in smbfs which can allow an attacker to escape from a chroot(2). [2] Security: FreeBSD-SA-06:15.ypserv [1] Security: FreeBSD-SA-06:16.smbfs [2] Revision Changes Path 1.46.2.2 +8 -1 src/sys/fs/smbfs/smbfs_vnops.c 1.22.6.1 +22 -15 src/usr.sbin/ypserv/yp_access.c From owner-cvs-src@FreeBSD.ORG Wed May 31 22:34:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 893A216C19B; Wed, 31 May 2006 22:34:17 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 24EAC43D6A; Wed, 31 May 2006 22:34:13 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VMWnUk094099; Wed, 31 May 2006 22:32:49 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VMWn2i094098; Wed, 31 May 2006 22:32:49 GMT (envelope-from cperciva) Message-Id: <200605312232.k4VMWn2i094098@repoman.freebsd.org> From: Colin Percival Date: Wed, 31 May 2006 22:32:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_5 Cc: Subject: cvs commit: src UPDATING src/sys/conf newvers.sh src/sys/fs/smbfs smbfs_vnops.c src/usr.sbin/ypserv yp_access.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 22:34:20 -0000 cperciva 2006-05-31 22:32:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_5) . UPDATING sys/conf newvers.sh sys/fs/smbfs smbfs_vnops.c usr.sbin/ypserv yp_access.c Log: Enable inadvertantly disabled "securenet" access controls in ypserv. [1] Correct a bug in the handling of backslash characters in smbfs which can allow an attacker to escape from a chroot(2). [2] Approved by: so (cperciva) Security: FreeBSD-SA-06:15.ypserv [1] Security: FreeBSD-SA-06:16.smbfs [2] Revision Changes Path 1.342.2.35.2.1 +10 -0 src/UPDATING 1.62.2.21.2.3 +1 -1 src/sys/conf/newvers.sh 1.46.2.1.4.1 +8 -1 src/sys/fs/smbfs/smbfs_vnops.c 1.22.18.1 +22 -15 src/usr.sbin/ypserv/yp_access.c From owner-cvs-src@FreeBSD.ORG Wed May 31 22:34:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A5BB616C1DC; Wed, 31 May 2006 22:34:47 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02E6443D77; Wed, 31 May 2006 22:34:41 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VMXHPw094212; Wed, 31 May 2006 22:33:17 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VMXH7e094211; Wed, 31 May 2006 22:33:17 GMT (envelope-from cperciva) Message-Id: <200605312233.k4VMXH7e094211@repoman.freebsd.org> From: Colin Percival Date: Wed, 31 May 2006 22:33:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_4 Cc: Subject: cvs commit: src UPDATING src/sys/conf newvers.sh src/sys/fs/smbfs smbfs_vnops.c src/usr.sbin/ypserv yp_access.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 22:34:49 -0000 cperciva 2006-05-31 22:33:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_4) . UPDATING sys/conf newvers.sh sys/fs/smbfs smbfs_vnops.c usr.sbin/ypserv yp_access.c Log: Enable inadvertantly disabled "securenet" access controls in ypserv. [1] Correct a bug in the handling of backslash characters in smbfs which can allow an attacker to escape from a chroot(2). [2] Approved by: so (cperciva) Security: FreeBSD-SA-06:15.ypserv [1] Security: FreeBSD-SA-06:16.smbfs [2] Revision Changes Path 1.342.2.24.2.24 +7 -0 src/UPDATING 1.62.2.18.2.20 +1 -1 src/sys/conf/newvers.sh 1.46.2.1.2.1 +8 -1 src/sys/fs/smbfs/smbfs_vnops.c 1.22.10.1 +22 -15 src/usr.sbin/ypserv/yp_access.c From owner-cvs-src@FreeBSD.ORG Wed May 31 22:35:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BEA516C2A6; Wed, 31 May 2006 22:35:29 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3818B43D7E; Wed, 31 May 2006 22:35:05 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VMXfFs094304; Wed, 31 May 2006 22:33:41 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VMXfeG094303; Wed, 31 May 2006 22:33:41 GMT (envelope-from cperciva) Message-Id: <200605312233.k4VMXfeG094303@repoman.freebsd.org> From: Colin Percival Date: Wed, 31 May 2006 22:33:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Cc: Subject: cvs commit: src UPDATING src/sys/conf newvers.sh src/sys/fs/smbfs smbfs_vnops.c src/usr.sbin/ypserv yp_access.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 22:35:35 -0000 cperciva 2006-05-31 22:33:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) . UPDATING sys/conf newvers.sh sys/fs/smbfs smbfs_vnops.c usr.sbin/ypserv yp_access.c Log: Enable inadvertantly disabled "securenet" access controls in ypserv. [1] Correct a bug in the handling of backslash characters in smbfs which can allow an attacker to escape from a chroot(2). [2] Approved by: so (cperciva) Security: FreeBSD-SA-06:15.ypserv [1] Security: FreeBSD-SA-06:16.smbfs [2] Revision Changes Path 1.342.2.13.2.33 +7 -0 src/UPDATING 1.62.2.15.2.35 +1 -1 src/sys/conf/newvers.sh 1.46.4.1 +8 -1 src/sys/fs/smbfs/smbfs_vnops.c 1.22.8.1 +22 -15 src/usr.sbin/ypserv/yp_access.c From owner-cvs-src@FreeBSD.ORG Wed May 31 22:36:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A16F16C46D; Wed, 31 May 2006 22:36:02 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD54043D8B; Wed, 31 May 2006 22:35:56 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VMYWjr094353; Wed, 31 May 2006 22:34:32 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VMYWHJ094352; Wed, 31 May 2006 22:34:32 GMT (envelope-from cperciva) Message-Id: <200605312234.k4VMYWHJ094352@repoman.freebsd.org> From: Colin Percival Date: Wed, 31 May 2006 22:34:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/sys/fs/smbfs smbfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 22:36:06 -0000 cperciva 2006-05-31 22:34:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/fs/smbfs smbfs_vnops.c Log: Correct a bug in the handling of backslash characters in smbfs which can allow an attacker to escape from a chroot(2). Security: FreeBSD-SA-06:16.smbfs Revision Changes Path 1.2.2.11 +8 -1 src/sys/fs/smbfs/smbfs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed May 31 22:36:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F74816B604; Wed, 31 May 2006 22:36:30 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B8BA43D70; Wed, 31 May 2006 22:36:17 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VMYr9g094425; Wed, 31 May 2006 22:34:53 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VMYraJ094424; Wed, 31 May 2006 22:34:53 GMT (envelope-from cperciva) Message-Id: <200605312234.k4VMYraJ094424@repoman.freebsd.org> From: Colin Percival Date: Wed, 31 May 2006 22:34:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4_11 Cc: Subject: cvs commit: src UPDATING src/sys/conf newvers.sh src/sys/fs/smbfs smbfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 22:36:35 -0000 cperciva 2006-05-31 22:34:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_4_11) . UPDATING sys/conf newvers.sh sys/fs/smbfs smbfs_vnops.c Log: Correct a bug in the handling of backslash characters in smbfs which can allow an attacker to escape from a chroot(2). Approved by: so (cperciva) Security: FreeBSD-SA-06:16.smbfs Revision Changes Path 1.73.2.91.2.19 +4 -0 src/UPDATING 1.44.2.39.2.22 +1 -1 src/sys/conf/newvers.sh 1.2.2.10.4.1 +8 -1 src/sys/fs/smbfs/smbfs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed May 31 22:37:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9980316C1B1; Wed, 31 May 2006 22:37:03 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B5AE43D5F; Wed, 31 May 2006 22:36:55 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VMZWFe094547; Wed, 31 May 2006 22:35:32 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VMZWeo094546; Wed, 31 May 2006 22:35:32 GMT (envelope-from cperciva) Message-Id: <200605312235.k4VMZWeo094546@repoman.freebsd.org> From: Colin Percival Date: Wed, 31 May 2006 22:35:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4_10 Cc: Subject: cvs commit: src UPDATING src/sys/conf newvers.sh src/sys/fs/smbfs smbfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 22:37:11 -0000 cperciva 2006-05-31 22:35:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_4_10) . UPDATING sys/conf newvers.sh sys/fs/smbfs smbfs_vnops.c Log: Correct a bug in the handling of backslash characters in smbfs which can allow an attacker to escape from a chroot(2). Approved by: so (cperciva) Security: FreeBSD-SA-06:16.smbfs Revision Changes Path 1.73.2.90.2.25 +4 -0 src/UPDATING 1.44.2.34.2.26 +1 -1 src/sys/conf/newvers.sh 1.2.2.10.2.1 +8 -1 src/sys/fs/smbfs/smbfs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed May 31 23:00:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0294A16A617; Wed, 31 May 2006 23:00:21 +0000 (UTC) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E622243D62; Wed, 31 May 2006 22:57:49 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VMtNlk095451; Wed, 31 May 2006 22:55:23 GMT (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VMtNdK095450; Wed, 31 May 2006 22:55:23 GMT (envelope-from ps) Message-Id: <200605312255.k4VMtNdK095450@repoman.freebsd.org> From: Paul Saab Date: Wed, 31 May 2006 22:55:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/vm vm_page.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 23:00:28 -0000 ps 2006-05-31 22:55:23 UTC FreeBSD src repository Modified files: sys/vm vm_page.c Log: Fix minidumps to include pages allocated via pmap_map on amd64. These pages are allocated from the direct map, and were not previous tracked. This included the vm_page_array and the early UMA bootstrap pages. Reviewed by: peter Revision Changes Path 1.316 +9 -0 src/sys/vm/vm_page.c From owner-cvs-src@FreeBSD.ORG Wed May 31 23:37:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B7B616CA3A; Wed, 31 May 2006 23:37:39 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 446D343D70; Wed, 31 May 2006 23:37:39 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VNaFgF099755; Wed, 31 May 2006 23:36:15 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VNaF5w099754; Wed, 31 May 2006 23:36:15 GMT (envelope-from bmah) Message-Id: <200605312336.k4VNaF5w099754@repoman.freebsd.org> From: "Bruce A. Mah" Date: Wed, 31 May 2006 23:36:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 23:37:45 -0000 bmah 2006-05-31 23:36:15 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: New release notes: SA-06:15, SA-06:16. Note: We should swing the URLs for all the older security advisories mentioned here over to the new location on security.FreeBSD.org. Revision Changes Path 1.937 +12 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Wed May 31 23:40:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 05B6C16A624; Wed, 31 May 2006 23:40:43 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6183A43D5D; Wed, 31 May 2006 23:40:42 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VNdInd099892; Wed, 31 May 2006 23:39:18 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VNdIIF099891; Wed, 31 May 2006 23:39:18 GMT (envelope-from bmah) Message-Id: <200605312339.k4VNdIIF099891@repoman.freebsd.org> From: "Bruce A. Mah" Date: Wed, 31 May 2006 23:39:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 23:40:51 -0000 bmah 2006-05-31 23:39:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC: SA-06:15, SA-06:16. Revision Changes Path 1.883.2.20 +12 -1 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Wed May 31 23:43:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DCC6A16CAEA; Wed, 31 May 2006 23:43:01 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8CCCC43D60; Wed, 31 May 2006 23:43:01 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VNfbeL000187; Wed, 31 May 2006 23:41:37 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VNfbX2000186; Wed, 31 May 2006 23:41:37 GMT (envelope-from bmah) Message-Id: <200605312341.k4VNfbX2000186@repoman.freebsd.org> From: "Bruce A. Mah" Date: Wed, 31 May 2006 23:41:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 23:43:07 -0000 bmah 2006-05-31 23:41:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC: SA-06:15, SA-06:16. Revision Changes Path 1.761.2.61 +12 -1 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Wed May 31 23:45:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A5D3916CB0F; Wed, 31 May 2006 23:45:50 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D70C343D80; Wed, 31 May 2006 23:45:49 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VNiQsq000328; Wed, 31 May 2006 23:44:26 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VNiPOw000327; Wed, 31 May 2006 23:44:25 GMT (envelope-from bmah) Message-Id: <200605312344.k4VNiPOw000327@repoman.freebsd.org> From: "Bruce A. Mah" Date: Wed, 31 May 2006 23:44:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 23:46:04 -0000 bmah 2006-05-31 23:44:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC: SA-06:16. Note: We should swing the URLs for all the older security advisories mentioned here over to the new location on security.FreeBSD.org. Revision Changes Path 1.22.2.432 +6 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Wed May 31 23:52:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 69BEB16A5BF; Wed, 31 May 2006 23:50:22 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2273D43D70; Wed, 31 May 2006 23:50:22 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VNmwJ5000610; Wed, 31 May 2006 23:48:58 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VNmw0v000609; Wed, 31 May 2006 23:48:58 GMT (envelope-from bmah) Message-Id: <200605312348.k4VNmw0v000609@repoman.freebsd.org> From: "Bruce A. Mah" Date: Wed, 31 May 2006 23:48:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 23:53:05 -0000 bmah 2006-05-31 23:48:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: Swing URLs to security advisories over to security.FreeBSD.org. Revision Changes Path 1.22.2.433 +10 -10 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Wed May 31 23:53:48 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 070A916C2ED; Wed, 31 May 2006 23:51:16 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E627543D69; Wed, 31 May 2006 23:51:15 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4VNnqLZ000654; Wed, 31 May 2006 23:49:52 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4VNnqYw000653; Wed, 31 May 2006 23:49:52 GMT (envelope-from bmah) Message-Id: <200605312349.k4VNnqYw000653@repoman.freebsd.org> From: "Bruce A. Mah" Date: Wed, 31 May 2006 23:49:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 23:53:55 -0000 bmah 2006-05-31 23:49:52 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: Swing URLs to security advisories over to security.FreeBSD.org. Revision Changes Path 1.938 +12 -12 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Thu Jun 1 00:42:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22FB416A4C6; Thu, 1 Jun 2006 00:42:32 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E814B43D46; Thu, 1 Jun 2006 00:42:31 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k510f71Y004202; Thu, 1 Jun 2006 00:41:07 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k510f7C6004201; Thu, 1 Jun 2006 00:41:07 GMT (envelope-from thompsa) Message-Id: <200606010041.k510f7C6004201@repoman.freebsd.org> From: Andrew Thompson Date: Thu, 1 Jun 2006 00:41:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc devd.conf src/etc/rc.d devd src/sys/net if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 00:42:57 -0000 thompsa 2006-06-01 00:41:07 UTC FreeBSD src repository Modified files: etc devd.conf etc/rc.d devd sys/net if.c Log: Announce all interfaces to devd on attach/detach. This adds a new devctl notification so all interfaces including pseudo are reported. When netif creates the clones at startup devctl_disable has not been turned off yet so the interfaces will not be initialised twice, enforce this by adding an explicit order between rc.d/netif and rc.d/devd. This change allows actions to taken in userland when an interface is cloned and the pseudo interface will be automatically configured if a ifconfig_="" line exists in rc.conf. Reviewed by: brooks No objections on: net Revision Changes Path 1.33 +10 -8 src/etc/devd.conf 1.9 +2 -2 src/etc/rc.d/devd 1.256 +2 -0 src/sys/net/if.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 01:21:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 82A2516C4B7; Thu, 1 Jun 2006 01:21:31 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D56C43D45; Thu, 1 Jun 2006 01:21:31 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 1F0391A4DB0; Wed, 31 May 2006 18:21:31 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 91F3C515DC; Wed, 31 May 2006 21:21:30 -0400 (EDT) Date: Wed, 31 May 2006 21:21:30 -0400 From: Kris Kennaway To: Ceri Davies Message-ID: <20060601012130.GA5066@xor.obsecurity.org> References: <200605311915.k4VJFKef060742@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OgqxwSJOaUobr8KG" Content-Disposition: inline In-Reply-To: <200605311915.k4VJFKef060742@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall installUpgrade.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 01:21:33 -0000 --OgqxwSJOaUobr8KG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 31, 2006 at 07:15:20PM +0000, Ceri Davies wrote: > ceri 2006-05-31 19:15:20 UTC >=20 > FreeBSD src repository >=20 > Modified files: > usr.sbin/sysinstall installUpgrade.c=20 > Log: > Update the location of the kernel for upgrades. > =20 > I considered leaving /boot/kernel out of the chflags noschg line, but I > seem to remember that there was a period where /boot/kernel was schg, so > have left it in for safety's sake. Does this explain the user report I have that a binary upgrade from 6.0 to 6.1 did not update the kernel? Kris --OgqxwSJOaUobr8KG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEfkEZWry0BWjoQKURAkQFAKCxckhiuDzCyp9rnsdd1D2MO6k+9gCfX98w RXHl6cU6KjN1QCn4zU35JIY= =700e -----END PGP SIGNATURE----- --OgqxwSJOaUobr8KG-- From owner-cvs-src@FreeBSD.ORG Thu Jun 1 01:32:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DA1E16A7BB; Thu, 1 Jun 2006 01:32:32 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF02543D48; Thu, 1 Jun 2006 01:32:31 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k511V7QW014983; Thu, 1 Jun 2006 01:31:07 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k511V7Nt014982; Thu, 1 Jun 2006 01:31:07 GMT (envelope-from alc) Message-Id: <200606010131.k511V7Nt014982@repoman.freebsd.org> From: Alan Cox Date: Thu, 1 Jun 2006 01:31:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/arm pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 01:32:41 -0000 alc 2006-06-01 01:31:07 UTC FreeBSD src repository Modified files: sys/arm/arm pmap.c Log: Introduce pmap_enter_locked() and use it to reimplement pmap_enter_quick(). Tested by: cognet@ Revision Changes Path 1.52 +19 -11 src/sys/arm/arm/pmap.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 02:26:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8CADB16B818; Thu, 1 Jun 2006 02:26:25 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3590443D58; Thu, 1 Jun 2006 02:26:25 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k512P0So019776; Thu, 1 Jun 2006 02:25:00 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k512P0bN019775; Thu, 1 Jun 2006 02:25:00 GMT (envelope-from rodrigc) Message-Id: <200606010225.k512P0bN019775@repoman.freebsd.org> From: Craig Rodrigues Date: Thu, 1 Jun 2006 02:25:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/msdosfs msdosfs_vfsops.c src/sbin/mount_msdosfs mount_msdosfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 02:26:32 -0000 rodrigc 2006-06-01 02:25:00 UTC FreeBSD src repository Modified files: sys/fs/msdosfs msdosfs_vfsops.c sbin/mount_msdosfs mount_msdosfs.c Log: mount_msdosfs.c: - remove call to getmntopts(), and just pass -o options to nmount(). This removes some confusion as to what options msdosfs can parse, by pushing the responsibility of option parsing to the VFS and FS specific code in the kernel. msdosfs_vfsops.c: - add "force" and "sync" to msdosfs_opts. They used to be specified in mount_msdosfs.c, so move them here. It's not clear whethere these options should be placed into global_opts in vfs_mount.c or not. Motivated by: marcus Revision Changes Path 1.42 +0 -10 src/sbin/mount_msdosfs/mount_msdosfs.c 1.151 +1 -1 src/sys/fs/msdosfs/msdosfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 02:35:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3316016AD75; Thu, 1 Jun 2006 02:35:25 +0000 (UTC) (envelope-from grog@lemis.com) Received: from ext-gw.lemis.com (ext-gw.lemis.com [150.101.14.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 95F5343D80; Thu, 1 Jun 2006 02:35:24 +0000 (GMT) (envelope-from grog@lemis.com) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.135]) by ext-gw.lemis.com (Postfix) with ESMTP id 5C173131E14; Thu, 1 Jun 2006 12:05:23 +0930 (CST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 3316D86F5B; Thu, 1 Jun 2006 12:05:23 +0930 (CST) Date: Thu, 1 Jun 2006 12:05:23 +0930 From: Greg 'groggy' Lehey To: Maxim Konovalov Message-ID: <20060601023523.GA80617@wantadilla.lemis.com> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: <200605311315.k4VDFUhD093628@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 VoIP: sip:0871270137@sip.internode.on.net WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 02:35:29 -0000 --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wednesday, 31 May 2006 at 13:15:29 +0000, Maxim Konovalov wrote: > maxim 2006-05-31 13:15:29 UTC > > FreeBSD src repository > > Modified files: > sys/ufs/ufs ufs_vnops.c > Log: > o According to POSIX, the result of ftruncate(2) is unspecified > for file types other than VREG, VDIR and shared memory objects. > We already handle VREG, VLNK and VDIR cases. Silently ignore > > Revision Changes Path > 1.276 +22 -4 src/sys/ufs/ufs/ufs_vnops.c Is this worth a man page update? Greg -- See complete headers for address and phone numbers. --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFEflJrIubykFB6QiMRAh+bAKCF/l7z4Mz6t9GmIVYm+MBMsEDcBgCdF8Ww kM0nUHKXDWXjoa1NyHOqEMk= =2oIS -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3-- From owner-cvs-src@FreeBSD.ORG Thu Jun 1 04:27:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22B0816B3B5; Thu, 1 Jun 2006 04:27:52 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 64ADA43D45; Thu, 1 Jun 2006 04:27:51 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k514Rm0G098139 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 1 Jun 2006 08:27:49 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k514Rmiw098138; Thu, 1 Jun 2006 08:27:48 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 1 Jun 2006 08:27:47 +0400 From: Gleb Smirnoff To: John Baldwin Message-ID: <20060601042747.GX27819@FreeBSD.org> References: <200605252306.k4PN6cCS081708@repoman.freebsd.org> <200605311050.12156.jhb@freebsd.org> <447DAF19.3050901@samsco.org> <200605311123.02334.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200605311123.02334.jhb@freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, Scott Long , src-committers@FreeBSD.org, Warner Losh , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/syscons/apm apm_saver.c src/sys/i386/bios apm.c apm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 04:27:53 -0000 On Wed, May 31, 2006 at 11:23:01AM -0400, John Baldwin wrote: J> Nah, that was phk's other timekeeping code to see which timeouts take a long J> time to execute. The THREAD_NO_SLEEPING() stuff was added just before 6.0 J> was released and replaced a couple of "special" mutexes that were held just J> to provoke WITNESS warnings. To take a long time to execute one doesn't need to sleep, it can also do a lot of job. I know at least two examples of heavy callouts: dummynet and pf. Under heavy traffic both subsystems process a lot of packets during one callout. I have patches to move their job to a separate taskqueue. The dummynet patch needs some testing and the pf patch waits for Max Laier to decide what to chose: taskqueue API or kthread_create() as newest pf in OpenBSD does. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Thu Jun 1 04:30:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF16A16B696; Thu, 1 Jun 2006 04:30:58 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6947943D70; Thu, 1 Jun 2006 04:30:54 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k514UqgQ098184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 1 Jun 2006 08:30:53 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k514Uq01098183; Thu, 1 Jun 2006 08:30:52 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 1 Jun 2006 08:30:52 +0400 From: Gleb Smirnoff To: Andrew Thompson Message-ID: <20060601043052.GY27819@FreeBSD.org> References: <200606010041.k510f7C6004201@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200606010041.k510f7C6004201@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc devd.conf src/etc/rc.d devd src/sys/net if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 04:31:23 -0000 On Thu, Jun 01, 2006 at 12:41:07AM +0000, Andrew Thompson wrote: A> This change allows actions to taken in userland when an interface is cloned A> and the pseudo interface will be automatically configured if a ifconfig_="" A> line exists in rc.conf. Nice! -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Thu Jun 1 04:46:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 382F416A444; Thu, 1 Jun 2006 04:46:10 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA72F43D4C; Thu, 1 Jun 2006 04:46:09 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k514ijjM030446; Thu, 1 Jun 2006 04:44:45 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k514ijnO030445; Thu, 1 Jun 2006 04:44:45 GMT (envelope-from bmah) Message-Id: <200606010444.k514ijnO030445@repoman.freebsd.org> From: "Bruce A. Mah" Date: Thu, 1 Jun 2006 04:44:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 04:46:10 -0000 bmah 2006-06-01 04:44:45 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/errata article.sgml Log: New errata: SA-06:15, SA-06:16. Revision Changes Path 1.73.2.21 +34 -1 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Thu Jun 1 04:50:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 756A016A433; Thu, 1 Jun 2006 04:50:26 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3295A43D53; Thu, 1 Jun 2006 04:50:26 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k514n12i038317; Thu, 1 Jun 2006 04:49:01 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k514n1lQ038316; Thu, 1 Jun 2006 04:49:01 GMT (envelope-from bmah) Message-Id: <200606010449.k514n1lQ038316@repoman.freebsd.org> From: "Bruce A. Mah" Date: Thu, 1 Jun 2006 04:49:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 04:50:27 -0000 bmah 2006-06-01 04:49:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/doc/en_US.ISO8859-1/errata article.sgml Log: New errata: SA-06:15, SA-06:16. Revision Changes Path 1.69.2.39 +34 -1 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Thu Jun 1 04:50:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC35B16A58D; Thu, 1 Jun 2006 04:50:54 +0000 (UTC) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A99BE43D4C; Thu, 1 Jun 2006 04:50:54 +0000 (GMT) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k514nThA038391; Thu, 1 Jun 2006 04:49:29 GMT (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k514nTYC038390; Thu, 1 Jun 2006 04:49:29 GMT (envelope-from silby) Message-Id: <200606010449.k514nTYC038390@repoman.freebsd.org> From: Mike Silbersack Date: Thu, 1 Jun 2006 04:49:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 busdma_machdep.c src/sys/amd64/amd64 busdma_machdep.c src/sys/ia64/ia64 busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 04:50:55 -0000 silby 2006-06-01 04:49:29 UTC FreeBSD src repository Modified files: sys/i386/i386 busdma_machdep.c sys/amd64/amd64 busdma_machdep.c sys/ia64/ia64 busdma_machdep.c Log: After much discussion with mjacob and scottl, change bus_dmamem_alloc so that it just warns the user with a printf when it misaligns a piece of memory that was requested through a busdma tag. Some drivers (such as mpt, and probably others) were asking for alignments that could not be satisfied, but as far as driver operation was concerned, that did not matter. In the theory that other drivers will fall into this same category, we agreed that panicing or making the allocation fail will cause more hardship than is necessary. The printf should be sufficient motivation to get the driver glitch fixed. Revision Changes Path 1.77 +3 -21 src/sys/amd64/amd64/busdma_machdep.c 1.80 +3 -21 src/sys/i386/i386/busdma_machdep.c 1.41 +11 -33 src/sys/ia64/ia64/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 04:58:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 06F7916A479; Thu, 1 Jun 2006 04:58:19 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF20043D46; Thu, 1 Jun 2006 04:58:18 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k514ur1l038771; Thu, 1 Jun 2006 04:56:53 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k514urhA038770; Thu, 1 Jun 2006 04:56:53 GMT (envelope-from bmah) Message-Id: <200606010456.k514urhA038770@repoman.freebsd.org> From: "Bruce A. Mah" Date: Thu, 1 Jun 2006 04:56:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 04:58:19 -0000 bmah 2006-06-01 04:56:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) release/doc/en_US.ISO8859-1/errata article.sgml Log: New errata: SA-06:16. While here, retarget advisory URLs (and one or two others) to use security.FreeBSD.org. Revision Changes Path 1.1.2.129 +20 -13 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Thu Jun 1 04:59:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B534816A488; Thu, 1 Jun 2006 04:59:23 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3DF1043D4C; Thu, 1 Jun 2006 04:59:23 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k514vwkd038821; Thu, 1 Jun 2006 04:57:58 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k514vwtP038820; Thu, 1 Jun 2006 04:57:58 GMT (envelope-from bmah) Message-Id: <200606010457.k514vwtP038820@repoman.freebsd.org> From: "Bruce A. Mah" Date: Thu, 1 Jun 2006 04:57:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 04:59:25 -0000 bmah 2006-06-01 04:57:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/errata article.sgml Log: Add SA- prefix to security advisory names. Revision Changes Path 1.73.2.22 +2 -2 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Thu Jun 1 04:59:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6359716B046; Thu, 1 Jun 2006 04:59:32 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F3C643D49; Thu, 1 Jun 2006 04:59:32 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k514w745038877; Thu, 1 Jun 2006 04:58:07 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k514w7eF038876; Thu, 1 Jun 2006 04:58:07 GMT (envelope-from bmah) Message-Id: <200606010458.k514w7eF038876@repoman.freebsd.org> From: "Bruce A. Mah" Date: Thu, 1 Jun 2006 04:58:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 04:59:35 -0000 bmah 2006-06-01 04:58:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/doc/en_US.ISO8859-1/errata article.sgml Log: Add SA- prefix to security advisory names. Revision Changes Path 1.69.2.40 +2 -2 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Thu Jun 1 05:08:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3045816AA37; Thu, 1 Jun 2006 05:08:20 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC2F243D58; Thu, 1 Jun 2006 05:08:19 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k5156t0k040561; Thu, 1 Jun 2006 05:06:55 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k5156tOI040560; Thu, 1 Jun 2006 05:06:55 GMT (envelope-from mjacob) Message-Id: <200606010506.k5156tOI040560@repoman.freebsd.org> From: Matt Jacob Date: Thu, 1 Jun 2006 05:06:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src MAINTAINERS X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 05:08:21 -0000 mjacob 2006-06-01 05:06:54 UTC FreeBSD src repository Modified files: . MAINTAINERS Log: Add scottl to maintainers to ask for Pre-commit review on all busdma changes. I was unaware of Scott's claim in this area and was abruptly so informed. Let's put such an interest in some visible place. Revision Changes Path 1.134 +2 -1 src/MAINTAINERS From owner-cvs-src@FreeBSD.ORG Thu Jun 1 07:00:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 024D216A53D; Thu, 1 Jun 2006 07:00:05 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A017343D49; Thu, 1 Jun 2006 07:00:05 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k516weMY049125; Thu, 1 Jun 2006 06:58:40 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k516weWQ049121; Thu, 1 Jun 2006 06:58:40 GMT (envelope-from mjacob) Message-Id: <200606010658.k516weWQ049121@repoman.freebsd.org> From: Matt Jacob Date: Thu, 1 Jun 2006 06:58:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/dev/isp isp.c isp_freebsd.c isp_freebsd.h isp_ioctl.h isp_library.c isp_library.h isp_pci.c isp_sbus.c isp_target.c isp_target.h isp_tpublic.h ispmbox.h ispreg.h ispvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 07:00:06 -0000 mjacob 2006-06-01 06:58:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/dev/isp isp.c isp_freebsd.c isp_freebsd.h isp_ioctl.h isp_library.c isp_library.h isp_pci.c isp_sbus.c isp_target.c isp_target.h isp_tpublic.h ispmbox.h ispreg.h ispvar.h Log: MFC: current state in RELENG_6 && -current as of 5/31/06. Lots of formatting changes and type rototilling. Some genuine bug fixes tho. Revision Changes Path 1.111.2.5 +267 -262 src/sys/dev/isp/isp.c 1.102.2.6 +212 -136 src/sys/dev/isp/isp_freebsd.c 1.75.2.5 +56 -36 src/sys/dev/isp/isp_freebsd.h 1.11.2.4 +23 -23 src/sys/dev/isp/isp_ioctl.h 1.1.4.2 +97 -80 src/sys/dev/isp/isp_library.c 1.1.4.2 +17 -11 src/sys/dev/isp/isp_library.h 1.98.2.5 +535 -254 src/sys/dev/isp/isp_pci.c 1.15.2.3 +35 -35 src/sys/dev/isp/isp_sbus.c 1.30.2.5 +50 -49 src/sys/dev/isp/isp_target.c 1.21.4.5 +189 -189 src/sys/dev/isp/isp_target.h 1.9.4.4 +133 -147 src/sys/dev/isp/isp_tpublic.h 1.46.2.4 +250 -246 src/sys/dev/isp/ispmbox.h 1.22.8.4 +50 -50 src/sys/dev/isp/ispreg.h 1.66.2.5 +134 -158 src/sys/dev/isp/ispvar.h From owner-cvs-src@FreeBSD.ORG Thu Jun 1 07:04:24 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A6FC616A49E; Thu, 1 Jun 2006 07:04:24 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F83743D4C; Thu, 1 Jun 2006 07:04:24 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k5172xN2052078; Thu, 1 Jun 2006 07:02:59 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k5172xEo052077; Thu, 1 Jun 2006 07:02:59 GMT (envelope-from mjacob) Message-Id: <200606010702.k5172xEo052077@repoman.freebsd.org> From: Matt Jacob Date: Thu, 1 Jun 2006 07:02:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/ispfw asm_2300.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 07:04:25 -0000 mjacob 2006-06-01 07:02:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/ispfw asm_2300.h Log: MFC: new 2300 firmware Revision Changes Path 1.8.2.1 +5986 -5795 src/sys/dev/ispfw/asm_2300.h From owner-cvs-src@FreeBSD.ORG Thu Jun 1 07:05:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2DC516AB45; Thu, 1 Jun 2006 07:05:49 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C5BC43D49; Thu, 1 Jun 2006 07:05:49 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k5174ONi053336; Thu, 1 Jun 2006 07:04:24 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k5174Ow5053335; Thu, 1 Jun 2006 07:04:24 GMT (envelope-from mjacob) Message-Id: <200606010704.k5174Ow5053335@repoman.freebsd.org> From: Matt Jacob Date: Thu, 1 Jun 2006 07:04:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/dev/ispfw asm_2300.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 07:05:54 -0000 mjacob 2006-06-01 07:04:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/dev/ispfw asm_2300.h Log: MFC: new 2300 firmware Revision Changes Path 1.6.2.3 +5986 -5795 src/sys/dev/ispfw/asm_2300.h From owner-cvs-src@FreeBSD.ORG Thu Jun 1 07:08:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2C6316A6A7; Thu, 1 Jun 2006 07:08:46 +0000 (UTC) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id AEFED43D4C; Thu, 1 Jun 2006 07:08:45 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.13.4/8.13.3) with ESMTP id k5178KDH029713; Thu, 1 Jun 2006 11:08:20 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Thu, 1 Jun 2006 11:08:20 +0400 (MSD) From: Maxim Konovalov To: Craig Rodrigues In-Reply-To: <20060531212644.GA7541@crodrigues.org> Message-ID: <20060601110758.T28667@mp2.macomnet.net> References: <200605261244.k4QCiCsl057619@repoman.freebsd.org> <20060529193947.M63890@mp2.macomnet.net> <20060529215827.D78736@mp2.macomnet.net> <20060530034531.GA36462@crodrigues.org> <20060530110750.A96470@mp2.macomnet.net> <20060530224448.GA42556@crodrigues.org> <20060531114119.T70660@mp2.macomnet.net> <20060531212644.GA7541@crodrigues.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 07:08:47 -0000 On Wed, 31 May 2006, 17:26-0400, Craig Rodrigues wrote: > On Wed, May 31, 2006 at 11:44:14AM +0400, Maxim Konovalov wrote: > > This one works, thanks! But I worry about mountd/NFS interaction to > > mount I described in my first email. Any ideas? > > Not sure about the mountd/NFS interaction yet. > > This patch is a bit better for mount(8): It passes my tests. Thanks! -- Maxim Konovalov From owner-cvs-src@FreeBSD.ORG Thu Jun 1 07:19:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C52716BC4D; Thu, 1 Jun 2006 07:19:53 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3718F43D48; Thu, 1 Jun 2006 07:19:52 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k517IR0Z061380; Thu, 1 Jun 2006 07:18:27 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k517IRt6061379; Thu, 1 Jun 2006 07:18:27 GMT (envelope-from mjacob) Message-Id: <200606010718.k517IRt6061379@repoman.freebsd.org> From: Matt Jacob Date: Thu, 1 Jun 2006 07:18:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/sys/dev/ispfw asm_1040.h asm_1080.h asm_12160.h asm_2100.h asm_2200.h asm_2300.h ispfw.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 07:19:54 -0000 mjacob 2006-06-01 07:18:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/ispfw asm_1040.h asm_1080.h asm_12160.h asm_2100.h asm_2200.h asm_2300.h ispfw.c Log: MFC 2300 firmware Revision Changes Path 1.1.2.4 +2 -2 src/sys/dev/ispfw/asm_1040.h 1.1.2.3 +2 -2 src/sys/dev/ispfw/asm_1080.h 1.2.2.4 +3959 -3820 src/sys/dev/ispfw/asm_12160.h 1.2.2.5 +1 -1 src/sys/dev/ispfw/asm_2100.h 1.2.2.6 +4589 -5010 src/sys/dev/ispfw/asm_2200.h 1.1.2.5 +6114 -5924 src/sys/dev/ispfw/asm_2300.h 1.2.2.6 +26 -9 src/sys/dev/ispfw/ispfw.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 07:31:48 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FD3B16BF70; Thu, 1 Jun 2006 07:31:48 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C5EC943D5C; Thu, 1 Jun 2006 07:31:47 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k517UMiI062092; Thu, 1 Jun 2006 07:30:22 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k517UMDP062091; Thu, 1 Jun 2006 07:30:22 GMT (envelope-from mjacob) Message-Id: <200606010730.k517UMDP062091@repoman.freebsd.org> From: Matt Jacob Date: Thu, 1 Jun 2006 07:30:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/sys/dev/isp isp.c isp_freebsd.c isp_freebsd.h isp_inline.h isp_ioctl.h isp_library.c isp_library.h isp_pci.c isp_target.c isp_target.h isp_tpublic.h ispmbox.h ispreg.h ispvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 07:32:04 -0000 mjacob 2006-06-01 07:30:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/isp isp.c isp_freebsd.c isp_freebsd.h isp_ioctl.h isp_pci.c isp_target.c isp_target.h isp_tpublic.h ispmbox.h ispreg.h ispvar.h Added files: (Branch: RELENG_4) sys/dev/isp isp_library.c isp_library.h Removed files: (Branch: RELENG_4) sys/dev/isp isp_inline.h Log: MFC: current state in RELENG_6 && -current as of 5/31/06. Lots of formatting changes and type rototilling. Some genuine bug fixes tho. Revision Changes Path 1.41.2.25 +456 -312 src/sys/dev/isp/isp.c 1.32.2.22 +738 -379 src/sys/dev/isp/isp_freebsd.c 1.26.2.18 +110 -83 src/sys/dev/isp/isp_freebsd.h 1.6.2.15 +0 -1484 src/sys/dev/isp/isp_inline.h (dead) 1.1.2.7 +57 -48 src/sys/dev/isp/isp_ioctl.h 1.3.2.1 +1727 -0 src/sys/dev/isp/isp_library.c (new) 1.2.2.1 +164 -0 src/sys/dev/isp/isp_library.h (new) 1.78.2.6 +795 -259 src/sys/dev/isp/isp_pci.c 1.5.4.12 +247 -155 src/sys/dev/isp/isp_target.c 1.3.4.15 +299 -155 src/sys/dev/isp/isp_target.h 1.2.4.5 +208 -237 src/sys/dev/isp/isp_tpublic.h 1.20.2.15 +270 -234 src/sys/dev/isp/ispmbox.h 1.13.2.8 +64 -53 src/sys/dev/isp/ispreg.h 1.25.2.19 +166 -181 src/sys/dev/isp/ispvar.h From owner-cvs-src@FreeBSD.ORG Thu Jun 1 07:33:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9912916C83F; Thu, 1 Jun 2006 07:33:10 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 37F4143D5E; Thu, 1 Jun 2006 07:33:10 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k517ViuJ062203; Thu, 1 Jun 2006 07:31:45 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k517ViNk062202; Thu, 1 Jun 2006 07:31:44 GMT (envelope-from mjacob) Message-Id: <200606010731.k517ViNk062202@repoman.freebsd.org> From: Matt Jacob Date: Thu, 1 Jun 2006 07:31:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/sys/conf files X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 07:33:21 -0000 mjacob 2006-06-01 07:31:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/conf files Log: MFC: current state in RELENG_6 && -current as of 5/31/06. Lots of formatting changes and type rototilling. Some genuine bug fixes tho. Revision Changes Path 1.340.2.158 +2 -1 src/sys/conf/files From owner-cvs-src@FreeBSD.ORG Thu Jun 1 08:41:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6029616A446; Thu, 1 Jun 2006 08:41:30 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-0-0-cust107.cdif.cable.ntl.com [81.104.168.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82BF343D4C; Thu, 1 Jun 2006 08:41:29 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.62 (FreeBSD)) (envelope-from ) id 1FlikB-000Irz-Vg; Thu, 01 Jun 2006 09:41:27 +0100 Date: Thu, 1 Jun 2006 09:41:27 +0100 From: Ceri Davies To: Kris Kennaway Message-ID: <20060601084127.GS21998@submonkey.net> Mail-Followup-To: Ceri Davies , Kris Kennaway , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200605311915.k4VJFKef060742@repoman.freebsd.org> <20060601012130.GA5066@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="E+SuQPWxZ0J/gtME" Content-Disposition: inline In-Reply-To: <20060601012130.GA5066@xor.obsecurity.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.11 Sender: Ceri Davies Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall installUpgrade.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 08:41:30 -0000 --E+SuQPWxZ0J/gtME Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 31, 2006 at 09:21:30PM -0400, Kris Kennaway wrote: > On Wed, May 31, 2006 at 07:15:20PM +0000, Ceri Davies wrote: > > ceri 2006-05-31 19:15:20 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > usr.sbin/sysinstall installUpgrade.c=20 > > Log: > > Update the location of the kernel for upgrades. > > =20 > > I considered leaving /boot/kernel out of the chflags noschg line, but= I > > seem to remember that there was a period where /boot/kernel was schg,= so > > have left it in for safety's sake. >=20 > Does this explain the user report I have that a binary upgrade from > 6.0 to 6.1 did not update the kernel? No, I don't think so. This is more to do with saving the old one for saftey's sake; there's nothing in here that should have prevented his old kernel from being committed to block limbo. I'll dig around and see if I can see how that might have happened, but I can't think of anything off the top of my head. Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --E+SuQPWxZ0J/gtME Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEfqg3ocfcwTS3JF8RAvDUAKCFVTufOwFesAX6OrLfwV1SpNSlSwCghrO9 awMSMURGwUIeJggKw7eYYlU= =GMLj -----END PGP SIGNATURE----- --E+SuQPWxZ0J/gtME-- From owner-cvs-src@FreeBSD.ORG Thu Jun 1 09:49:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 028DF16B47E; Thu, 1 Jun 2006 09:49:53 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-0-0-cust107.cdif.cable.ntl.com [81.104.168.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E22F43D46; Thu, 1 Jun 2006 09:49:51 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.62 (FreeBSD)) (envelope-from ) id 1FljoM-0008ma-6f; Thu, 01 Jun 2006 10:49:50 +0100 Date: Thu, 1 Jun 2006 10:49:50 +0100 From: Ceri Davies To: Greg 'groggy' Lehey Message-ID: <20060601094950.GU21998@submonkey.net> Mail-Followup-To: Ceri Davies , Greg 'groggy' Lehey , Maxim Konovalov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601023523.GA80617@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="21BR8y1c1zpF/Inb" Content-Disposition: inline In-Reply-To: <20060601023523.GA80617@wantadilla.lemis.com> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.11 Sender: Ceri Davies Cc: Maxim Konovalov , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 09:49:53 -0000 --21BR8y1c1zpF/Inb Content-Type: multipart/mixed; boundary="+NAfxSaP7cKOSWOx" Content-Disposition: inline --+NAfxSaP7cKOSWOx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 01, 2006 at 12:05:23PM +0930, Greg 'groggy' Lehey wrote: > On Wednesday, 31 May 2006 at 13:15:29 +0000, Maxim Konovalov wrote: > > maxim 2006-05-31 13:15:29 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/ufs/ufs ufs_vnops.c > > Log: > > o According to POSIX, the result of ftruncate(2) is unspecified > > for file types other than VREG, VDIR and shared memory objects. > > We already handle VREG, VLNK and VDIR cases. Silently ignore > > > > Revision Changes Path > > 1.276 +22 -4 src/sys/ufs/ufs/ufs_vnops.c >=20 > Is this worth a man page update? Undoubtedly. Does the attached look like enough? I'm not sure if we want to add a STANDARDS section for this when it's valid behaviour. Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --+NAfxSaP7cKOSWOx Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="truncate.diff" Index: src/lib/libc/sys/truncate.2 =================================================================== RCS file: /home/ncvs/src/lib/libc/sys/truncate.2,v retrieving revision 1.17 diff -u -r1.17 truncate.2 --- src/lib/libc/sys/truncate.2 20 Jan 2005 09:17:05 -0000 1.17 +++ src/lib/libc/sys/truncate.2 1 Jun 2006 09:47:19 -0000 @@ -32,7 +32,7 @@ .\" @(#)truncate.2 8.1 (Berkeley) 6/4/93 .\" $FreeBSD: src/lib/libc/sys/truncate.2,v 1.17 2005/01/20 09:17:05 ru Exp $ .\" -.Dd June 4, 1993 +.Dd June 1, 2006 .Dt TRUNCATE 2 .Os .Sh NAME @@ -69,6 +69,10 @@ the file must be open for writing. .Sh RETURN VALUES .Rv -std +If the file to be modified is not a directory or +a regular file, the +.Fn truncate +call will return the value 0. .Sh ERRORS The .Fn truncate --+NAfxSaP7cKOSWOx-- --21BR8y1c1zpF/Inb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEfrg+ocfcwTS3JF8RAqxoAKDALNnAowm29mvsNq5SrTbMgYwHLgCfXN3e Yobz5g8pb3A9FBq7vyzuaAE= =PFxl -----END PGP SIGNATURE----- --21BR8y1c1zpF/Inb-- From owner-cvs-src@FreeBSD.ORG Thu Jun 1 09:58:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5ECEE16B3E5; Thu, 1 Jun 2006 09:58:13 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5ED7343DA9; Thu, 1 Jun 2006 09:57:45 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k519vdlg005891; Thu, 1 Jun 2006 03:57:44 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <447EBA65.9000103@samsco.org> Date: Thu, 01 Jun 2006 03:59:01 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Maxim Konovalov References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> In-Reply-To: <200605311315.k4VDFUhD093628@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 09:58:18 -0000 Maxim Konovalov wrote: > maxim 2006-05-31 13:15:29 UTC > > FreeBSD src repository > > Modified files: > sys/ufs/ufs ufs_vnops.c > Log: > o According to POSIX, the result of ftruncate(2) is unspecified > for file types other than VREG, VDIR and shared memory objects. > We already handle VREG, VLNK and VDIR cases. Silently ignore > truncate requests for all the rest. Adjust comments. > > PR: kern/98064 > Submitted by: bde > Security: local DoS > Regress. test: regression/fifo/fifo_misc > MFC after: 2 weeks > > Revision Changes Path > 1.276 +22 -4 src/sys/ufs/ufs/ufs_vnops.c If POSIX says that the result is undefined, wouldn't it be in our best interests to return EBADF instead of 0? Or would that break 3rd party software? Scott From owner-cvs-src@FreeBSD.ORG Thu Jun 1 10:00:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9051D16B690; Thu, 1 Jun 2006 10:00:05 +0000 (UTC) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id C492E43D7E; Thu, 1 Jun 2006 10:00:04 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.13.4/8.13.3) with ESMTP id k51A00Xm057895; Thu, 1 Jun 2006 14:00:00 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Thu, 1 Jun 2006 14:00:00 +0400 (MSD) From: Maxim Konovalov To: Ceri Davies In-Reply-To: <20060601094950.GU21998@submonkey.net> Message-ID: <20060601135855.I24680@mp2.macomnet.net> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601023523.GA80617@wantadilla.lemis.com> <20060601094950.GU21998@submonkey.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Greg 'groggy' Lehey , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 10:00:10 -0000 On Thu, 1 Jun 2006, 10:49+0100, Ceri Davies wrote: > On Thu, Jun 01, 2006 at 12:05:23PM +0930, Greg 'groggy' Lehey wrote: > > On Wednesday, 31 May 2006 at 13:15:29 +0000, Maxim Konovalov wrote: > > > maxim 2006-05-31 13:15:29 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/ufs/ufs ufs_vnops.c > > > Log: > > > o According to POSIX, the result of ftruncate(2) is unspecified > > > for file types other than VREG, VDIR and shared memory objects. > > > We already handle VREG, VLNK and VDIR cases. Silently ignore > > > > > > Revision Changes Path > > > 1.276 +22 -4 src/sys/ufs/ufs/ufs_vnops.c > > > > Is this worth a man page update? > > Undoubtedly. Does the attached look like enough? I'm not sure if we > want to add a STANDARDS section for this when it's valid behaviour. @@ -69,6 +69,10 @@ the file must be open for writing. .Sh RETURN VALUES .Rv -std +If the file to be modified is not a directory or +a regular file, the +.Fn truncate +call will return the value 0. .Sh ERRORS The .Fn truncate We need to mention truncate(2) does nothing for such files. -- Maxim Konovalov From owner-cvs-src@FreeBSD.ORG Thu Jun 1 10:01:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 12BAF16B68A; Thu, 1 Jun 2006 10:01:28 +0000 (UTC) Date: Thu, 1 Jun 2006 10:01:27 +0000 From: Alexey Dokuchaev To: Ceri Davies , Greg 'groggy' Lehey , Maxim Konovalov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20060601100126.GA43737@FreeBSD.org> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601023523.GA80617@wantadilla.lemis.com> <20060601094950.GU21998@submonkey.net> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20060601094950.GU21998@submonkey.net> User-Agent: Mutt/1.4.2.1i Cc: Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 10:01:45 -0000 On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: > On Thu, Jun 01, 2006 at 12:05:23PM +0930, Greg 'groggy' Lehey wrote: > > On Wednesday, 31 May 2006 at 13:15:29 +0000, Maxim Konovalov wrote: > > > maxim 2006-05-31 13:15:29 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/ufs/ufs ufs_vnops.c > > > Log: > > > o According to POSIX, the result of ftruncate(2) is unspecified > > > for file types other than VREG, VDIR and shared memory objects. > > > We already handle VREG, VLNK and VDIR cases. Silently ignore > > > > > > Revision Changes Path > > > 1.276 +22 -4 src/sys/ufs/ufs/ufs_vnops.c > > > > Is this worth a man page update? > > Undoubtedly. Does the attached look like enough? I'm not sure if we > want to add a STANDARDS section for this when it's valid behaviour. > > Ceri > -- > That must be wonderful! I don't understand it at all. > -- Moliere > Index: src/lib/libc/sys/truncate.2 > =================================================================== > RCS file: /home/ncvs/src/lib/libc/sys/truncate.2,v > retrieving revision 1.17 > diff -u -r1.17 truncate.2 > --- src/lib/libc/sys/truncate.2 20 Jan 2005 09:17:05 -0000 1.17 > +++ src/lib/libc/sys/truncate.2 1 Jun 2006 09:47:19 -0000 > @@ -32,7 +32,7 @@ > .\" @(#)truncate.2 8.1 (Berkeley) 6/4/93 > .\" $FreeBSD: src/lib/libc/sys/truncate.2,v 1.17 2005/01/20 09:17:05 ru Exp $ > .\" > -.Dd June 4, 1993 > +.Dd June 1, 2006 > .Dt TRUNCATE 2 > .Os > .Sh NAME > @@ -69,6 +69,10 @@ > the file must be open for writing. > .Sh RETURN VALUES > .Rv -std > +If the file to be modified is not a directory or > +a regular file, the > +.Fn truncate > +call will return the value 0. Doesn't "value of 0" sound better? ./danfe From owner-cvs-src@FreeBSD.ORG Thu Jun 1 10:06:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4794D16B712; Thu, 1 Jun 2006 10:06:20 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-0-0-cust107.cdif.cable.ntl.com [81.104.168.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E2EB43D5C; Thu, 1 Jun 2006 10:06:18 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.62 (FreeBSD)) (envelope-from ) id 1Flk4H-000FKR-Cy; Thu, 01 Jun 2006 11:06:17 +0100 Date: Thu, 1 Jun 2006 11:06:17 +0100 From: Ceri Davies To: Maxim Konovalov Message-ID: <20060601100617.GW21998@submonkey.net> Mail-Followup-To: Ceri Davies , Maxim Konovalov , Greg 'groggy' Lehey , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601023523.GA80617@wantadilla.lemis.com> <20060601094950.GU21998@submonkey.net> <20060601135855.I24680@mp2.macomnet.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3E9L5busH6ECpa9r" Content-Disposition: inline In-Reply-To: <20060601135855.I24680@mp2.macomnet.net> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.11 Sender: Ceri Davies Cc: Greg 'groggy' Lehey , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 10:06:29 -0000 --3E9L5busH6ECpa9r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 01, 2006 at 02:00:00PM +0400, Maxim Konovalov wrote: > On Thu, 1 Jun 2006, 10:49+0100, Ceri Davies wrote: >=20 > > On Thu, Jun 01, 2006 at 12:05:23PM +0930, Greg 'groggy' Lehey wrote: > > > On Wednesday, 31 May 2006 at 13:15:29 +0000, Maxim Konovalov wrote: > > > > maxim 2006-05-31 13:15:29 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/ufs/ufs ufs_vnops.c > > > > Log: > > > > o According to POSIX, the result of ftruncate(2) is unspecified > > > > for file types other than VREG, VDIR and shared memory objects. > > > > We already handle VREG, VLNK and VDIR cases. Silently ignore > > > > > > > > Revision Changes Path > > > > 1.276 +22 -4 src/sys/ufs/ufs/ufs_vnops.c > > > > > > Is this worth a man page update? > > > > Undoubtedly. Does the attached look like enough? I'm not sure if we > > want to add a STANDARDS section for this when it's valid behaviour. >=20 > @@ -69,6 +69,10 @@ > the file must be open for writing. > .Sh RETURN VALUES > .Rv -std > +If the file to be modified is not a directory or > +a regular file, the > +.Fn truncate > +call will return the value 0. > .Sh ERRORS > The > .Fn truncate >=20 > We need to mention truncate(2) does nothing for such files. Whoops, yeah of course. Index: src/lib/libc/sys/truncate.2 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/lib/libc/sys/truncate.2,v retrieving revision 1.17 diff -u -r1.17 truncate.2 --- src/lib/libc/sys/truncate.2 20 Jan 2005 09:17:05 -0000 1.17 +++ src/lib/libc/sys/truncate.2 1 Jun 2006 10:04:18 -0000 @@ -32,7 +32,7 @@ .\" @(#)truncate.2 8.1 (Berkeley) 6/4/93 .\" $FreeBSD: src/lib/libc/sys/truncate.2,v 1.17 2005/01/20 09:17:05 ru Ex= p $ .\" -.Dd June 4, 1993 +.Dd June 1, 2006 .Dt TRUNCATE 2 .Os .Sh NAME @@ -69,6 +69,10 @@ the file must be open for writing. .Sh RETURN VALUES .Rv -std +If the file to be modified is not a directory or +a regular file, the +.Fn truncate +call has no effect and returns the value 0. .Sh ERRORS The .Fn truncate Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --3E9L5busH6ECpa9r Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEfrwZocfcwTS3JF8RAjFUAJ4zgrS354czkbBDt+FqGdEG6vEteQCaAvEz BQsr7o5yEwxb+Mdd5eo7tPw= =qA9i -----END PGP SIGNATURE----- --3E9L5busH6ECpa9r-- From owner-cvs-src@FreeBSD.ORG Thu Jun 1 10:12:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE00716AE16; Thu, 1 Jun 2006 10:12:31 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from pittgoth.com (ns1.pittgoth.com [216.38.206.188]) by mx1.FreeBSD.org (Postfix) with ESMTP id 697AB43D48; Thu, 1 Jun 2006 10:12:31 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from localhost (net-ix.gw.ai.net [205.134.160.6] (may be forged)) (authenticated bits=0) by pittgoth.com (8.13.4/8.13.4) with ESMTP id k51BLuqf061071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 1 Jun 2006 07:21:57 -0400 (EDT) (envelope-from trhodes@FreeBSD.org) Date: Thu, 1 Jun 2006 06:12:22 -0400 From: Tom Rhodes To: Alexey Dokuchaev Message-Id: <20060601061222.52aaed2d.trhodes@FreeBSD.org> In-Reply-To: <20060601100126.GA43737@FreeBSD.org> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601023523.GA80617@wantadilla.lemis.com> <20060601094950.GU21998@submonkey.net> <20060601100126.GA43737@FreeBSD.org> X-Mailer: Sylpheed version 1.0.6 (GTK+ 1.2.10; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: maxim@FreeBSD.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, grog@FreeBSD.org, ceri@submonkey.net Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 10:12:39 -0000 On Thu, 1 Jun 2006 10:01:27 +0000 Alexey Dokuchaev wrote: > On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: > > On Thu, Jun 01, 2006 at 12:05:23PM +0930, Greg 'groggy' Lehey wrote: > > > On Wednesday, 31 May 2006 at 13:15:29 +0000, Maxim Konovalov wrote: > > > > maxim 2006-05-31 13:15:29 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/ufs/ufs ufs_vnops.c > > > > Log: > > > > o According to POSIX, the result of ftruncate(2) is unspecified > > > > for file types other than VREG, VDIR and shared memory objects. > > > > We already handle VREG, VLNK and VDIR cases. Silently ignore > > > > > > > > Revision Changes Path > > > > 1.276 +22 -4 src/sys/ufs/ufs/ufs_vnops.c > > > > > > Is this worth a man page update? > > > > Undoubtedly. Does the attached look like enough? I'm not sure if we > > want to add a STANDARDS section for this when it's valid behaviour. > > > > Ceri > > -- > > That must be wonderful! I don't understand it at all. > > -- Moliere > > > Index: src/lib/libc/sys/truncate.2 > > =================================================================== > > RCS file: /home/ncvs/src/lib/libc/sys/truncate.2,v > > retrieving revision 1.17 > > diff -u -r1.17 truncate.2 > > --- src/lib/libc/sys/truncate.2 20 Jan 2005 09:17:05 -0000 1.17 > > +++ src/lib/libc/sys/truncate.2 1 Jun 2006 09:47:19 -0000 > > @@ -32,7 +32,7 @@ > > .\" @(#)truncate.2 8.1 (Berkeley) 6/4/93 > > .\" $FreeBSD: src/lib/libc/sys/truncate.2,v 1.17 2005/01/20 09:17:05 ru Exp $ > > .\" > > -.Dd June 4, 1993 > > +.Dd June 1, 2006 > > .Dt TRUNCATE 2 > > .Os > > .Sh NAME > > @@ -69,6 +69,10 @@ > > the file must be open for writing. > > .Sh RETURN VALUES > > .Rv -std > > +If the file to be modified is not a directory or > > +a regular file, the > > +.Fn truncate > > +call will return the value 0. > > Doesn't "value of 0" sound better? I like "zero" - we should see what core thinks first though. -- Tom Rhodes From owner-cvs-src@FreeBSD.ORG Thu Jun 1 10:51:02 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DDA9E16B6E6; Thu, 1 Jun 2006 10:51:02 +0000 (UTC) (envelope-from harry@schmalzbauer.de) Received: from flb.schmalzbauer.de (flb.schmalzbauer.de [62.245.232.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id 90C4C43D5C; Thu, 1 Jun 2006 10:50:54 +0000 (GMT) (envelope-from harry@schmalzbauer.de) Received: from sam.flintsbach.schmalzbauer.de (sam.flintsbach.schmalzbauer.de [172.21.2.4]) by flb.schmalzbauer.de (8.13.4/8.13.4) with ESMTP id k51Aptn8009648; Thu, 1 Jun 2006 12:51:56 +0200 (CEST) (envelope-from harry@schmalzbauer.de) Received: from cale.flintsbach.schmalzbauer.de (cale.flintsbach.schmalzbauer.de [172.21.1.204]) by sam.flintsbach.schmalzbauer.de (Postfix) with ESMTP id C96D6B62D; Thu, 1 Jun 2006 12:50:52 +0200 (CEST) Received: from cale.flintsbach.schmalzbauer.de (localhost [127.0.0.1]) by cale.flintsbach.schmalzbauer.de (8.13.6/8.13.6) with ESMTP id k51AoXP5020044; Thu, 1 Jun 2006 12:50:33 +0200 (CEST) (envelope-from harry@schmalzbauer.de) Received: from localhost (localhost [[UNIX: localhost]]) by cale.flintsbach.schmalzbauer.de (8.13.6/8.13.6/Submit) id k51AoWDk020043; Thu, 1 Jun 2006 12:50:32 +0200 (CEST) (envelope-from harry@schmalzbauer.de) X-Authentication-Warning: cale.flintsbach.schmalzbauer.de: harry set sender to harry@schmalzbauer.de using -f From: Harald Schmalzbauer To: cvs-src@freebsd.org Date: Thu, 1 Jun 2006 12:50:30 +0200 User-Agent: KMail/1.9.1 References: <200605270237.k4R2bbP2066298@repoman.freebsd.org> In-Reply-To: <200605270237.k4R2bbP2066298@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606011250.31904.harry@schmalzbauer.de> Cc: Craig Rodrigues Subject: Re: cvs commit: src/usr.sbin/rpc.lockd kern.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 10:51:11 -0000 Am Samstag, 27. Mai 2006 04:37 schrieb Craig Rodrigues: > rodrigc 2006-05-27 02:37:37 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/rpc.lockd kern.c > Log: > Move call to ignore SIGPIPE signals before calling fork(), > so that both parent and child processes ignore this signal. > > PR: bin/97768 > Submitted by: Gea-Suan Lin > MFC after: 3 days Hello, as far as I can see this and the last MFC (1.18) were forgotten. Could anybody please do them? Best regards, -Harry > > Revision Changes Path > 1.19 +3 -1 src/usr.sbin/rpc.lockd/kern.c > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" From owner-cvs-src@FreeBSD.ORG Thu Jun 1 11:03:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DDC316B678; Thu, 1 Jun 2006 11:03:20 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 557B843D48; Thu, 1 Jun 2006 11:03:20 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51B1s1j081866; Thu, 1 Jun 2006 11:01:54 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51B1stR081865; Thu, 1 Jun 2006 11:01:54 GMT (envelope-from thompsa) Message-Id: <200606011101.k51B1stR081865@repoman.freebsd.org> From: Andrew Thompson Date: Thu, 1 Jun 2006 11:01:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/defaults rc.conf src/etc/rc.d Makefile bridge netif src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 11:03:21 -0000 thompsa 2006-06-01 11:01:54 UTC FreeBSD src repository Modified files: etc/defaults rc.conf etc/rc.d Makefile netif share/man/man5 rc.conf.5 Added files: etc/rc.d bridge Log: Add rc.d/bridge which is invoked when a new interface arrives and can automaticly add it to an Ethernet bridge. This is intended for applications such as qemu, vmware, openvpn, ... which open tap interfaces and need them bridged with the hosts network adapter, the user can set up a glob for interfaces to be automatically added (eg tap*). Revision Changes Path 1.287 +3 -0 src/etc/defaults/rc.conf 1.73 +1 -1 src/etc/rc.d/Makefile 1.1 +93 -0 src/etc/rc.d/bridge (new) 1.20 +3 -0 src/etc/rc.d/netif 1.299 +18 -0 src/share/man/man5/rc.conf.5 From owner-cvs-src@FreeBSD.ORG Thu Jun 1 11:07:40 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8635D16B874 for ; Thu, 1 Jun 2006 11:07:40 +0000 (UTC) (envelope-from thompsa@freebsd.org) Received: from grunt13.ihug.co.nz (grunt13.ihug.co.nz [203.109.254.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id 80A2A43D70 for ; Thu, 1 Jun 2006 11:07:34 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from 203-109-251-39.static.bliink.ihug.co.nz (heff.fud.org.nz) [203.109.251.39] by grunt13.ihug.co.nz with smtp (Exim 3.35 #1 (Debian)) id 1Fll1W-0005g9-00; Thu, 01 Jun 2006 23:07:31 +1200 Received: by heff.fud.org.nz (Postfix, from userid 1001) id 0CAC51CC37; Thu, 1 Jun 2006 23:07:30 +1200 (NZST) Date: Thu, 1 Jun 2006 23:07:30 +1200 From: Andrew Thompson To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20060601110729.GA80230@heff.fud.org.nz> References: <200606011101.k51B1stR081865@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200606011101.k51B1stR081865@repoman.freebsd.org> User-Agent: Mutt/1.5.11 Cc: Subject: Re: cvs commit: src/etc/defaults rc.conf src/etc/rc.d Makefile bridge netif src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 11:07:51 -0000 On Thu, Jun 01, 2006 at 11:01:54AM +0000, Andrew Thompson wrote: > thompsa 2006-06-01 11:01:54 UTC > > FreeBSD src repository > > Modified files: > etc/defaults rc.conf > etc/rc.d Makefile netif > share/man/man5 rc.conf.5 > Added files: > etc/rc.d bridge > Log: > Add rc.d/bridge which is invoked when a new interface arrives and can > automaticly add it to an Ethernet bridge. This is intended for applications > such as qemu, vmware, openvpn, ... which open tap interfaces and need them > bridged with the hosts network adapter, the user can set up a glob for > interfaces to be automatically added (eg tap*). An example in rc.conf would be: # create the bridge and add the wired interface cloned_interfaces="bridge0" ifconfig_bridge0="up addm fxp0" # set it so that tap interfaces get added too autobridge_interfaces="bridge0" autobridge_bridge0="tap*" cheers, Andrew From owner-cvs-src@FreeBSD.ORG Thu Jun 1 11:08:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC9DE16B928; Thu, 1 Jun 2006 11:08:19 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6778C43D72; Thu, 1 Jun 2006 11:08:09 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id ED30C1151D; Thu, 1 Jun 2006 13:08:04 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 35851-02; Thu, 1 Jun 2006 13:07:59 +0200 (CEST) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id 6C69211493; Thu, 1 Jun 2006 13:07:58 +0200 (CEST) From: Florent Thoumie To: Andrew Thompson In-Reply-To: <200606011101.k51B1stR081865@repoman.freebsd.org> References: <200606011101.k51B1stR081865@repoman.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-IGjS8MoYq5yVesZ4sPga" Date: Thu, 01 Jun 2006 12:07:52 +0100 Message-Id: <1149160072.29704.0.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/defaults rc.conf src/etc/rc.d Makefile bridge netif src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 11:08:31 -0000 --=-IGjS8MoYq5yVesZ4sPga Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2006-06-01 at 11:01 +0000, Andrew Thompson wrote: > thompsa 2006-06-01 11:01:54 UTC >=20 > FreeBSD src repository >=20 > Modified files: > etc/defaults rc.conf=20 > etc/rc.d Makefile netif=20 > share/man/man5 rc.conf.5=20 > Added files: > etc/rc.d bridge=20 > Log: > Add rc.d/bridge which is invoked when a new interface arrives and can > automaticly add it to an Ethernet bridge. This is intended for applicat= ions > such as qemu, vmware, openvpn, ... which open tap interfaces and need t= hem > bridged with the hosts network adapter, the user can set up a glob for > interfaces to be automatically added (eg tap*). > =20 > Revision Changes Path > 1.287 +3 -0 src/etc/defaults/rc.conf > 1.73 +1 -1 src/etc/rc.d/Makefile > 1.1 +93 -0 src/etc/rc.d/bridge (new) > 1.20 +3 -0 src/etc/rc.d/netif > 1.299 +18 -0 src/share/man/man5/rc.conf.5 Cool! Are you planning to MFC this and the devd patch you committed earlier? --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --=-IGjS8MoYq5yVesZ4sPga Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBEfsqIMxEkbVFH3PQRAvsaAJ9pkZdy1638MFnvdAaioM/nhYI3jwCeP2WJ pOowH9phDpgRNF0sAy20nwI= =Z1Xv -----END PGP SIGNATURE----- --=-IGjS8MoYq5yVesZ4sPga-- From owner-cvs-src@FreeBSD.ORG Thu Jun 1 11:14:15 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4892A16B746 for ; Thu, 1 Jun 2006 11:14:15 +0000 (UTC) (envelope-from thompsa@freebsd.org) Received: from grunt8.ihug.co.nz (grunt8.ihug.co.nz [203.109.254.48]) by mx1.FreeBSD.org (Postfix) with ESMTP id A5F1A43D53 for ; Thu, 1 Jun 2006 11:14:14 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from 203-109-251-39.static.bliink.ihug.co.nz (heff.fud.org.nz) [203.109.251.39] by grunt8.ihug.co.nz with smtp (Exim 3.35 #1 (Debian)) id 1Fll7z-0006HK-00; Thu, 01 Jun 2006 23:14:11 +1200 Received: by heff.fud.org.nz (Postfix, from userid 1001) id C76B81CC37; Thu, 1 Jun 2006 23:14:10 +1200 (NZST) Date: Thu, 1 Jun 2006 23:14:10 +1200 From: Andrew Thompson To: Florent Thoumie Message-ID: <20060601111410.GB80230@heff.fud.org.nz> References: <200606011101.k51B1stR081865@repoman.freebsd.org> <1149160072.29704.0.camel@mayday.esat.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1149160072.29704.0.camel@mayday.esat.net> User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/defaults rc.conf src/etc/rc.d Makefile bridge netif src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 11:14:28 -0000 On Thu, Jun 01, 2006 at 12:07:52PM +0100, Florent Thoumie wrote: > On Thu, 2006-06-01 at 11:01 +0000, Andrew Thompson wrote: > > thompsa 2006-06-01 11:01:54 UTC > > > > FreeBSD src repository > > > > Modified files: > > etc/defaults rc.conf > > etc/rc.d Makefile netif > > share/man/man5 rc.conf.5 > > Added files: > > etc/rc.d bridge > > Log: > > Add rc.d/bridge which is invoked when a new interface arrives and can > > automaticly add it to an Ethernet bridge. This is intended for applications > > such as qemu, vmware, openvpn, ... which open tap interfaces and need them > > bridged with the hosts network adapter, the user can set up a glob for > > interfaces to be automatically added (eg tap*). > > Cool! > > Are you planning to MFC this and the devd patch you committed earlier? Yea, I would like to. I'd need to check that its ok to change the interface anouncement on the stable branch. Andrew From owner-cvs-src@FreeBSD.ORG Thu Jun 1 13:59:49 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F62116A567; Thu, 1 Jun 2006 13:59:49 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3802943D46; Thu, 1 Jun 2006 13:59:49 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout2.pacific.net.au (Postfix) with ESMTP id A1D926E782; Thu, 1 Jun 2006 23:59:47 +1000 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k51DxgWk029061; Thu, 1 Jun 2006 23:59:45 +1000 Date: Thu, 1 Jun 2006 23:59:42 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Scott Long In-Reply-To: <447EBA65.9000103@samsco.org> Message-ID: <20060601232412.F34374@delplex.bde.org> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <447EBA65.9000103@samsco.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Maxim Konovalov , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 13:59:49 -0000 On Thu, 1 Jun 2006, Scott Long wrote: > Maxim Konovalov wrote: > >> maxim 2006-05-31 13:15:29 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/ufs/ufs ufs_vnops.c Log: >> o According to POSIX, the result of ftruncate(2) is unspecified >> for file types other than VREG, VDIR and shared memory objects. >> We already handle VREG, VLNK and VDIR cases. Silently ignore >> truncate requests for all the rest. Adjust comments. > ... > If POSIX says that the result is undefined, wouldn't it be in our > best interests to return EBADF instead of 0? Or would that break > 3rd party software? POSIX says that the result is unspecified, not that it is undefined. truncate.2 has many bugs, but null changes to it are required to be (almost) consistent with this commit. This commit just makes the code agree with the documentation in one case. truncate.2 never documented that [f]truncate() panics on fifos. It tries to say that [f]truncate() always succeeds on fifos, but gets this wrong for truncate() on fifos (and device files...) residing on r/o file systems (unless we interpret fifos as not residing on file systems at all). It doesn't document that file systems cloned from ffs still panic for [f]truncate() on fifos, or the details of the panics; nor should it. See another reply for more details. Bruce From owner-cvs-src@FreeBSD.ORG Thu Jun 1 14:07:12 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6045716B20A; Thu, 1 Jun 2006 14:07:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A4E243D6D; Thu, 1 Jun 2006 14:07:05 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [131.106.58.208] (72-255-64-173.client.stsn.net [72.255.64.173]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k51E71Fv078629; Thu, 1 Jun 2006 10:07:04 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Gleb Smirnoff Date: Thu, 1 Jun 2006 08:54:16 -0400 User-Agent: KMail/1.9.1 References: <200605252306.k4PN6cCS081708@repoman.freebsd.org> <200605311123.02334.jhb@freebsd.org> <20060601042747.GX27819@FreeBSD.org> In-Reply-To: <20060601042747.GX27819@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606010854.17990.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1504/Wed May 31 15:59:14 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.1 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, Scott Long , src-committers@freebsd.org, Warner Losh , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/syscons/apm apm_saver.c src/sys/i386/bios apm.c apm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 14:07:12 -0000 On Thursday 01 June 2006 00:27, Gleb Smirnoff wrote: > On Wed, May 31, 2006 at 11:23:01AM -0400, John Baldwin wrote: > J> Nah, that was phk's other timekeeping code to see which timeouts take a long > J> time to execute. The THREAD_NO_SLEEPING() stuff was added just before 6.0 > J> was released and replaced a couple of "special" mutexes that were held just > J> to provoke WITNESS warnings. > > To take a long time to execute one doesn't need to sleep, it can also do > a lot of job. Yes, but sleeping in softclock leads to deadlock much more quickly than a long-running callout. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Thu Jun 1 14:07:18 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBA7C16BB22; Thu, 1 Jun 2006 14:07:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D48B43D46; Thu, 1 Jun 2006 14:07:14 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [131.106.58.208] (72-255-64-173.client.stsn.net [72.255.64.173]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k51E71Fw078629; Thu, 1 Jun 2006 10:07:11 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Alexey Dokuchaev Date: Thu, 1 Jun 2006 08:58:38 -0400 User-Agent: KMail/1.9.1 References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601094950.GU21998@submonkey.net> <20060601100126.GA43737@FreeBSD.org> In-Reply-To: <20060601100126.GA43737@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606010858.39417.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1504/Wed May 31 15:59:14 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.1 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Maxim Konovalov , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Greg 'groggy' Lehey , Ceri Davies Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 14:07:19 -0000 On Thursday 01 June 2006 06:01, Alexey Dokuchaev wrote: > On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: > > On Thu, Jun 01, 2006 at 12:05:23PM +0930, Greg 'groggy' Lehey wrote: > > > On Wednesday, 31 May 2006 at 13:15:29 +0000, Maxim Konovalov wrote: > > > > maxim 2006-05-31 13:15:29 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/ufs/ufs ufs_vnops.c > > > > Log: > > > > o According to POSIX, the result of ftruncate(2) is unspecified > > > > for file types other than VREG, VDIR and shared memory objects. > > > > We already handle VREG, VLNK and VDIR cases. Silently ignore > > > > > > > > Revision Changes Path > > > > 1.276 +22 -4 src/sys/ufs/ufs/ufs_vnops.c > > > > > > Is this worth a man page update? > > > > Undoubtedly. Does the attached look like enough? I'm not sure if we > > want to add a STANDARDS section for this when it's valid behaviour. > > > > Ceri > > -- > > That must be wonderful! I don't understand it at all. > > -- Moliere > > > Index: src/lib/libc/sys/truncate.2 > > =================================================================== > > RCS file: /home/ncvs/src/lib/libc/sys/truncate.2,v > > retrieving revision 1.17 > > diff -u -r1.17 truncate.2 > > --- src/lib/libc/sys/truncate.2 20 Jan 2005 09:17:05 -0000 1.17 > > +++ src/lib/libc/sys/truncate.2 1 Jun 2006 09:47:19 -0000 > > @@ -32,7 +32,7 @@ > > .\" @(#)truncate.2 8.1 (Berkeley) 6/4/93 > > .\" $FreeBSD: src/lib/libc/sys/truncate.2,v 1.17 2005/01/20 09:17:05 ru Exp $ > > .\" > > -.Dd June 4, 1993 > > +.Dd June 1, 2006 > > .Dt TRUNCATE 2 > > .Os > > .Sh NAME > > @@ -69,6 +69,10 @@ > > the file must be open for writing. > > .Sh RETURN VALUES > > .Rv -std > > +If the file to be modified is not a directory or > > +a regular file, the > > +.Fn truncate > > +call will return the value 0. > > Doesn't "value of 0" sound better? Not to me, though I can't explain why. I think the phrase "X will return the value Y" is common in man pages though. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Thu Jun 1 14:07:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B678516AC0D; Thu, 1 Jun 2006 14:07:59 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7212543D46; Thu, 1 Jun 2006 14:07:59 +0000 (GMT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51E6X73024531; Thu, 1 Jun 2006 14:06:33 GMT (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51E6WDK024530; Thu, 1 Jun 2006 14:06:32 GMT (envelope-from dds) Message-Id: <200606011406.k51E6WDK024530@repoman.freebsd.org> From: Diomidis Spinellis Date: Thu, 1 Jun 2006 14:06:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net80211 ieee80211_node.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 14:08:00 -0000 dds 2006-06-01 14:06:32 UTC FreeBSD src repository Modified files: sys/net80211 ieee80211_node.c Log: Move conditional preprocessing out from the IEEE80211_DPRINTF macro invocation. Per C99 6.10.3 paragraph 11 preprocessing directives appearing as macro arguments yield undefined behavior. Revision Changes Path 1.75 +8 -14 src/sys/net80211/ieee80211_node.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 14:16:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B76A316A989; Thu, 1 Jun 2006 14:16:26 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6FC0F43D53; Thu, 1 Jun 2006 14:16:26 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51EF0l6024837; Thu, 1 Jun 2006 14:15:00 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51EExJe024836; Thu, 1 Jun 2006 14:14:59 GMT (envelope-from csjp) Message-Id: <200606011414.k51EExJe024836@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Thu, 1 Jun 2006 14:14:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc hosts.allow X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 14:16:26 -0000 csjp 2006-06-01 14:14:58 UTC FreeBSD src repository Modified files: etc hosts.allow Log: Since NIS is an RPC based service, add a note that when adjusting access controls in NIS, similar access controls should be considered for the rpcbind as well. Revision Changes Path 1.22 +1 -0 src/etc/hosts.allow From owner-cvs-src@FreeBSD.ORG Thu Jun 1 14:22:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6737416B54C; Thu, 1 Jun 2006 14:22:10 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 20F4043D4C; Thu, 1 Jun 2006 14:22:10 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51EKh3e025119; Thu, 1 Jun 2006 14:20:43 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51EKhaT025118; Thu, 1 Jun 2006 14:20:43 GMT (envelope-from maxim) Message-Id: <200606011420.k51EKhaT025118@repoman.freebsd.org> From: Maxim Konovalov Date: Thu, 1 Jun 2006 14:20:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/sys truncate.2 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 14:22:10 -0000 maxim 2006-06-01 14:20:43 UTC FreeBSD src repository Modified files: lib/libc/sys truncate.2 Log: o Document the fact truncate(2) has no effect for !VDIR or !VREG files. Submitted by: ceri Revision Changes Path 1.18 +5 -1 src/lib/libc/sys/truncate.2 From owner-cvs-src@FreeBSD.ORG Thu Jun 1 15:04:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9F3A16ADB3; Thu, 1 Jun 2006 15:04:33 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9480743D45; Thu, 1 Jun 2006 15:04:33 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51F37Mq028711; Thu, 1 Jun 2006 15:03:07 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51F36hW028687; Thu, 1 Jun 2006 15:03:06 GMT (envelope-from maxim) Message-Id: <200606011503.k51F36hW028687@repoman.freebsd.org> From: Maxim Konovalov Date: Thu, 1 Jun 2006 15:03:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/cron/cron do_command.c popen.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 15:04:41 -0000 maxim 2006-06-01 15:03:06 UTC FreeBSD src repository Modified files: usr.sbin/cron/cron do_command.c popen.c Log: o Better be safe than sorry: check return code from setuid(2), setgid(2), setlogin(2) and initgroups(3). In theory they could fail for root with some third party mac(4) policies. Submitted by: Kostik Belousov MFC after: 1 month Revision Changes Path 1.24 +21 -4 src/usr.sbin/cron/cron/do_command.c 1.13 +9 -4 src/usr.sbin/cron/cron/popen.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 15:11:23 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3B5316ABA0; Thu, 1 Jun 2006 15:11:22 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6320743D7B; Thu, 1 Jun 2006 15:11:14 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout1.pacific.net.au (Postfix) with ESMTP id ED60B3A7C03; Fri, 2 Jun 2006 01:11:12 +1000 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k51FB90h005342; Fri, 2 Jun 2006 01:11:10 +1000 Date: Fri, 2 Jun 2006 01:11:09 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Ceri Davies In-Reply-To: <20060601094950.GU21998@submonkey.net> Message-ID: <20060602000029.C34374@delplex.bde.org> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601023523.GA80617@wantadilla.lemis.com> <20060601094950.GU21998@submonkey.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Greg 'groggy' Lehey , Maxim Konovalov , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 15:11:24 -0000 On Thu, 1 Jun 2006, Ceri Davies wrote: > On Thu, Jun 01, 2006 at 12:05:23PM +0930, Greg 'groggy' Lehey wrote: >> On Wednesday, 31 May 2006 at 13:15:29 +0000, Maxim Konovalov wrote: >>> maxim 2006-05-31 13:15:29 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/ufs/ufs ufs_vnops.c >>> Log: >>> o According to POSIX, the result of ftruncate(2) is unspecified >>> for file types other than VREG, VDIR and shared memory objects. >>> We already handle VREG, VLNK and VDIR cases. Silently ignore >>> >>> Revision Changes Path >>> 1.276 +22 -4 src/sys/ufs/ufs/ufs_vnops.c >> >> Is this worth a man page update? Only to the extent that the man page is generally broken. It has always tried to document the behaviour now implemented in ffs but it omits some details and is not clear on the [EROFS] case. The commit makes the man page actually agree with one file system (ffs; file systems cut and pasted from ffs, e.g., ext2fs, still panic). > Undoubtedly. Does the attached look like enough? I'm not sure if we Sorry, no. > want to add a STANDARDS section for this when it's valid behaviour. > Index: src/lib/libc/sys/truncate.2 > =================================================================== > RCS file: /home/ncvs/src/lib/libc/sys/truncate.2,v > retrieving revision 1.17 > diff -u -r1.17 truncate.2 > --- src/lib/libc/sys/truncate.2 20 Jan 2005 09:17:05 -0000 1.17 > +++ src/lib/libc/sys/truncate.2 1 Jun 2006 09:47:19 -0000 > ... > @@ -69,6 +69,10 @@ > the file must be open for writing. > .Sh RETURN VALUES > .Rv -std > +If the file to be modified is not a directory or > +a regular file, the > +.Fn truncate > +call will return the value 0. > .Sh ERRORS > The > .Fn truncate The man page already says this (in standard wording in ".Rv -std" and ERRORS): % RETURN VALUES % Upon successful completion, the value 0 is returned; otherwise the ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ % value -1 is returned and the global variable errno is set to indicate the % error. % % ERRORS % The truncate() system call succeeds unless: ^^^^^^^^^^^^^^^ % [... various unrelated errors] % [EISDIR] The named file is a directory. This covers the behaviour for directories in more detail. % [EROFS] The named file resides on a read-only file system. I originally misinterpreted "resides" as strictly applying to the name of a fifo (since fifo contents don't really reside anywhere) but it obviously should only apply to the contents. open(2) uses the same wording. The actual behaviour was (and still is on some file systems containing code cut and pasted from ffs, e.g., ext2fs): - [f]truncate() of a fifo on a r/w file system (for ffs and clones) acts as if there were a resource fork of the file, with one half of the fork containing the fifo and the other half containing a irregular file, where an irregular file in this context is a regular file that is inaccessible from userland except via stat(2) and statfs(2) to see some of its side effects, and via unlink(2) to clean it up. This used to be a small problem. However, some versions of FreeBSD have debugging code that panics on attempts to truncate the irregular file. - I thinl [f]truncate() of a fifo on a r/o file system panics unless the new size is 0. % [... various unrelated errors] % % The ftruncate() system call succeeds unless: % % [EBADF] The fd argument is not a valid descriptor. % % [EINVAL] The fd argument references a socket, not a file. % % [EINVAL] The fd descriptor is not open for writing. Note that there is no !directory or r/o restrictions here. These restrictions are in in open(2). There is an additional restriction here for sockets. Either this or the lack of such a restriction for truncate(2) must be a bug, since sockets may be bound to file systems and whether truncation succeeds shouldn't depend on the syscall used to do it. % BUGS % ... % % Use of truncate() to extend a file is not portable. This can only be a bug in programs which assume that extension using [f]truncate() is portable, not in [f]truncate(). (File) extension is an XSI (specification) extension in POSIX. The main bugs here are: - truncate.2 doesn't say that except for regular files, success consists of doing nothing (even when the caller asks for something to be done). - truncate.2 doesn't say that for regular files, certain timestamps (mainly ctime) are set on successful completion (even when the caller asks for nothing to be done). It shares this bug with most or all FreeBSD man pages for fs syscalls. POSIX is much more careful about such details. POSIX may be harder to read because it is more formal, but when detail is just absent in an informal description it is impossible to recover from the description. Bruce From owner-cvs-src@FreeBSD.ORG Thu Jun 1 15:18:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 64CB616C2A8; Thu, 1 Jun 2006 15:18:40 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1BDD043D45; Thu, 1 Jun 2006 15:18:40 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 042811A4E7B; Thu, 1 Jun 2006 08:18:40 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id A4E8A512F6; Thu, 1 Jun 2006 11:18:37 -0400 (EDT) Date: Thu, 1 Jun 2006 11:18:37 -0400 From: Kris Kennaway To: Ceri Davies , Kris Kennaway , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20060601151837.GA32439@xor.obsecurity.org> References: <200605311915.k4VJFKef060742@repoman.freebsd.org> <20060601012130.GA5066@xor.obsecurity.org> <20060601084127.GS21998@submonkey.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: <20060601084127.GS21998@submonkey.net> User-Agent: Mutt/1.4.2.1i Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall installUpgrade.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 15:18:43 -0000 --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 01, 2006 at 09:41:27AM +0100, Ceri Davies wrote: > On Wed, May 31, 2006 at 09:21:30PM -0400, Kris Kennaway wrote: > > On Wed, May 31, 2006 at 07:15:20PM +0000, Ceri Davies wrote: > > > ceri 2006-05-31 19:15:20 UTC > > >=20 > > > FreeBSD src repository > > >=20 > > > Modified files: > > > usr.sbin/sysinstall installUpgrade.c=20 > > > Log: > > > Update the location of the kernel for upgrades. > > > =20 > > > I considered leaving /boot/kernel out of the chflags noschg line, b= ut I > > > seem to remember that there was a period where /boot/kernel was sch= g, so > > > have left it in for safety's sake. > >=20 > > Does this explain the user report I have that a binary upgrade from > > 6.0 to 6.1 did not update the kernel? >=20 > No, I don't think so. This is more to do with saving the old one for > saftey's sake; there's nothing in here that should have prevented his > old kernel from being committed to block limbo. >=20 > I'll dig around and see if I can see how that might have happened, but I > can't think of anything off the top of my head. Never mind, it was user error (they were trying to use an 6.0 CD to update to 6.1 by changing the release name). This is actually fairly common, so I wonder if a bit of text could be added saying not to do this. Kris --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEfwVMWry0BWjoQKURAhmCAKDuAEa52r03wCtaeuiPPgyve3VnaQCgggqM Ol5jlmVnyAmIlkDSxw2eiLw= =1jyD -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH-- From owner-cvs-src@FreeBSD.ORG Thu Jun 1 15:40:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 20C7E16A4D8; Thu, 1 Jun 2006 15:40:03 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36E1543D7E; Thu, 1 Jun 2006 15:39:57 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51FcUtL030612; Thu, 1 Jun 2006 15:38:30 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51FcUao030611; Thu, 1 Jun 2006 15:38:30 GMT (envelope-from csjp) Message-Id: <200606011538.k51FcUao030611@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Thu, 1 Jun 2006 15:38:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/security/audit audit_bsm_klib.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 15:40:03 -0000 csjp 2006-06-01 15:38:30 UTC FreeBSD src repository Modified files: sys/security/audit audit_bsm_klib.c Log: Check to see if the rootdir is the same as the current working directory. If it is, and the pathname was relative, do not separate the componenets with a '/' character. Obtained from: TrustedBSD Project Revision Changes Path 1.3 +11 -3 src/sys/security/audit/audit_bsm_klib.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 15:46:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D44F316B0C5; Thu, 1 Jun 2006 15:46:34 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7FE8143D73; Thu, 1 Jun 2006 15:46:33 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51Fj6Ka030969; Thu, 1 Jun 2006 15:45:06 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51Fj62t030968; Thu, 1 Jun 2006 15:45:06 GMT (envelope-from maxim) Message-Id: <200606011545.k51Fj62t030968@repoman.freebsd.org> From: Maxim Konovalov Date: Thu, 1 Jun 2006 15:45:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/gen getgrent.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 15:46:36 -0000 maxim 2006-06-01 15:45:06 UTC FreeBSD src repository Modified files: lib/libc/gen getgrent.c Log: o Record a file offset for a last successfully parsed group file line. If the initial buffer size (1KB) for the given group line is not big enough, reset the offset. It helps to do not miss this line when getrg() reallocates the larger buffer and tries to parse the line again. PR: bin/52433, kern/55031, bin/83696, misc/97640, misc/98111 Submitted by: bsw71@mail.ru, Philip M. Gollucci, Justin Erenkrantz Glanced at: nectar MFC after: 1 month Revision Changes Path 1.34 +8 -0 src/lib/libc/gen/getgrent.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 16:19:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DF4BF16ADD0; Thu, 1 Jun 2006 16:19:11 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9851E43D45; Thu, 1 Jun 2006 16:19:11 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51GHiRc035302; Thu, 1 Jun 2006 16:17:44 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51GHi9P035301; Thu, 1 Jun 2006 16:17:44 GMT (envelope-from cognet) Message-Id: <200606011617.k51GHi9P035301@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 1 Jun 2006 16:17:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/include cpufunc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 16:19:12 -0000 cognet 2006-06-01 16:17:44 UTC FreeBSD src repository Modified files: sys/arm/include cpufunc.h Log: Don't enable the FIQ in enable_interrupts() if F32_bit is not specified. This has been committed by mistake. Reported by: ssouhlal Revision Changes Path 1.8 +1 -1 src/sys/arm/include/cpufunc.h From owner-cvs-src@FreeBSD.ORG Thu Jun 1 16:50:52 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5ECC216A4EB; Thu, 1 Jun 2006 16:50:52 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5AD8843D4C; Thu, 1 Jun 2006 16:50:51 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout1.pacific.net.au (Postfix) with ESMTP id 24A21527C92; Fri, 2 Jun 2006 02:50:50 +1000 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k51GolYG025799; Fri, 2 Jun 2006 02:50:48 +1000 Date: Fri, 2 Jun 2006 02:50:47 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: John Baldwin In-Reply-To: <200606010858.39417.jhb@freebsd.org> Message-ID: <20060602023102.J34761@delplex.bde.org> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601094950.GU21998@submonkey.net> <20060601100126.GA43737@FreeBSD.org> <200606010858.39417.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Maxim Konovalov , Alexey Dokuchaev , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Greg 'groggy' Lehey , Ceri Davies Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 16:51:07 -0000 On Thu, 1 Jun 2006, John Baldwin wrote: > On Thursday 01 June 2006 06:01, Alexey Dokuchaev wrote: >> On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: >>> @@ -69,6 +69,10 @@ >>> the file must be open for writing. >>> .Sh RETURN VALUES >>> .Rv -std >>> +If the file to be modified is not a directory or >>> +a regular file, the >>> +.Fn truncate >>> +call will return the value 0. >> >> Doesn't "value of 0" sound better? > > Not to me, though I can't explain why. I think the phrase "X will return the > value Y" is common in man pages though. "will return" sounds strange to be. Normal is "Upon successful completion, the value 0 is returned...". This is part of what ".Rv -std" expands to. POSIX says "Upon successful completion, ftruncate( ) shall return 0...". The POSIX wording is better. "the value 0" says nothing more than "0", and "returns" is clearer than "is returned". Saying "the value 0" is apparently a hack to give the clause a subject (or is it an object? -- I think the value is the object convoluted to a subject or vice versa). FreeBSD has a deshallify.sh script to adjust the POSIX wording. It does s/shall return/returns/. Bruce From owner-cvs-src@FreeBSD.ORG Thu Jun 1 17:15:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D2E4316A647; Thu, 1 Jun 2006 17:15:43 +0000 (UTC) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A16C43D46; Thu, 1 Jun 2006 17:15:43 +0000 (GMT) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51HEGaC053990; Thu, 1 Jun 2006 17:14:16 GMT (envelope-from wilko@repoman.freebsd.org) Received: (from wilko@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51HEGoJ053983; Thu, 1 Jun 2006 17:14:16 GMT (envelope-from wilko) Message-Id: <200606011714.k51HEGoJ053983@repoman.freebsd.org> From: Wilko Bulte Date: Thu, 1 Jun 2006 17:14:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 17:15:44 -0000 wilko 2006-06-01 17:14:16 UTC FreeBSD src repository Modified files: . access Log: markus has been granted a src commit bit. emax will be his mentor. congratulations! Submitted by: emax Approved by: core With hat: core-secretary Revision Changes Path 1.775 +1 -0 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Thu Jun 1 17:50:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 704A016ACDE; Thu, 1 Jun 2006 17:50:59 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 171C143D67; Thu, 1 Jun 2006 17:50:53 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51HnQSK062121; Thu, 1 Jun 2006 17:49:26 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51HnQYR062120; Thu, 1 Jun 2006 17:49:26 GMT (envelope-from bmah) Message-Id: <200606011749.k51HnQYR062120@repoman.freebsd.org> From: "Bruce A. Mah" Date: Thu, 1 Jun 2006 17:49:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 17:51:34 -0000 bmah 2006-06-01 17:49:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/errata article.sgml Log: New errata: rc.d/jail problems, snapshot/quota deadlock, NDP regression, multi-CDROM package loading problems, mbufs denied bug, i386/nextboot problem. These items will be updated as necessary to reflect reality. Edited alpha sysinstall(8) item for markup and punctuation nits. Revision Changes Path 1.73.2.23 +54 -7 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Thu Jun 1 19:03:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5DB6716A8AC; Thu, 1 Jun 2006 19:03:17 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BEE4043D6D; Thu, 1 Jun 2006 19:03:14 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51J1l12066708; Thu, 1 Jun 2006 19:01:47 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51J1lml066707; Thu, 1 Jun 2006 19:01:47 GMT (envelope-from imp) Message-Id: <200606011901.k51J1lml066707@repoman.freebsd.org> From: Warner Losh Date: Thu, 1 Jun 2006 19:01:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/gnu/fs/xfs xfs_attr.c xfs_dfrag.c xfs_dir2_trace.c xfs_inode.c xfs_iomap.c xfs_trans.c xfs_vfsops.c xfs_vnodeops.c src/sys/gnu/fs/xfs/FreeBSD xfs_frw.c xfs_fs_subr.c xfs_iget.c xfs_ioctl.c xfs_super.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 19:03:20 -0000 imp 2006-06-01 19:01:47 UTC FreeBSD src repository Modified files: sys/gnu/fs/xfs xfs_attr.c xfs_dfrag.c xfs_dir2_trace.c xfs_inode.c xfs_iomap.c xfs_trans.c xfs_vfsops.c xfs_vnodeops.c sys/gnu/fs/xfs/FreeBSD xfs_frw.c xfs_fs_subr.c xfs_iget.c xfs_ioctl.c xfs_super.c Log: Cope with -Wundef. This means including xfs_macros.h early in a few more files and changing #if XXXKAN -> #ifdef XXXKAN. # this is just compile tested, since I don't have xfs partitions. Revision Changes Path 1.2 +4 -3 src/sys/gnu/fs/xfs/FreeBSD/xfs_frw.c 1.2 +3 -3 src/sys/gnu/fs/xfs/FreeBSD/xfs_fs_subr.c 1.2 +2 -2 src/sys/gnu/fs/xfs/FreeBSD/xfs_iget.c 1.2 +2 -1 src/sys/gnu/fs/xfs/FreeBSD/xfs_ioctl.c 1.2 +1 -0 src/sys/gnu/fs/xfs/FreeBSD/xfs_super.c 1.2 +3 -3 src/sys/gnu/fs/xfs/xfs_attr.c 1.2 +1 -1 src/sys/gnu/fs/xfs/xfs_dfrag.c 1.2 +1 -0 src/sys/gnu/fs/xfs/xfs_dir2_trace.c 1.2 +3 -3 src/sys/gnu/fs/xfs/xfs_inode.c 1.2 +1 -0 src/sys/gnu/fs/xfs/xfs_iomap.c 1.2 +1 -1 src/sys/gnu/fs/xfs/xfs_trans.c 1.2 +1 -1 src/sys/gnu/fs/xfs/xfs_vfsops.c 1.2 +1 -1 src/sys/gnu/fs/xfs/xfs_vnodeops.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 19:25:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7471D16B232; Thu, 1 Jun 2006 19:25:13 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D018E43D4C; Thu, 1 Jun 2006 19:25:12 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51JNjrg068810; Thu, 1 Jun 2006 19:23:45 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51JNjSE068809; Thu, 1 Jun 2006 19:23:45 GMT (envelope-from alc) Message-Id: <200606011923.k51JNjSE068809@repoman.freebsd.org> From: Alan Cox Date: Thu, 1 Jun 2006 19:23:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ia64/ia64 busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 19:25:14 -0000 alc 2006-06-01 19:23:45 UTC FreeBSD src repository Modified files: sys/ia64/ia64 busdma_machdep.c Log: Correct a syntax error in the previous revision. Revision Changes Path 1.42 +1 -1 src/sys/ia64/ia64/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 19:59:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2896E16A42F; Thu, 1 Jun 2006 19:59:29 +0000 (UTC) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D6F3143D48; Thu, 1 Jun 2006 19:59:28 +0000 (GMT) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51Jw1Ts070123; Thu, 1 Jun 2006 19:58:01 GMT (envelope-from krion@repoman.freebsd.org) Received: (from krion@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51Jw1T5070122; Thu, 1 Jun 2006 19:58:01 GMT (envelope-from krion) Message-Id: <200606011958.k51Jw1T5070122@repoman.freebsd.org> From: Kirill Ponomarew Date: Thu, 1 Jun 2006 19:58:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/find function.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 19:59:29 -0000 krion 2006-06-01 19:58:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/find function.c Log: MFC: function.c: 1.57 date: 2006/05/25 21:20:43; author: krion; state: Exp; lines: +12 -4 Enable numeric arguments and +/- prefixes with -user (-group) options. PR: bin/71513 Submitted by: Andre Albsmeier Revision Changes Path 1.53.2.3 +12 -4 src/usr.bin/find/function.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 20:20:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B52BB16B725; Thu, 1 Jun 2006 20:20:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5FEE443D48; Thu, 1 Jun 2006 20:20:04 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51KIaRt072146; Thu, 1 Jun 2006 20:18:36 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51KIaWP072145; Thu, 1 Jun 2006 20:18:36 GMT (envelope-from jhb) Message-Id: <200606012018.k51KIaWP072145@repoman.freebsd.org> From: John Baldwin Date: Thu, 1 Jun 2006 20:18:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/nve if_nve.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 20:20:20 -0000 jhb 2006-06-01 20:18:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/nve if_nve.c Log: MFC: Improve reliability of nforce4 adapters: - When setting up a packet for transmit, if we the tx ring is over half full, kick the binary blob to force it to complete any pending tx completions. - In the watchdog routine, poke the binary blob to force it to flush any pending tx completions and only reset the chip if the blob doesn't complete any of them. Revision Changes Path 1.7.2.9 +33 -1 src/sys/dev/nve/if_nve.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 20:21:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F20C16B75B; Thu, 1 Jun 2006 20:21:46 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C1E8943D73; Thu, 1 Jun 2006 20:21:42 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51KKFnw072255; Thu, 1 Jun 2006 20:20:15 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51KKFv7072254; Thu, 1 Jun 2006 20:20:15 GMT (envelope-from jhb) Message-Id: <200606012020.k51KKFv7072254@repoman.freebsd.org> From: John Baldwin Date: Thu, 1 Jun 2006 20:20:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/digi digi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 20:21:56 -0000 jhb 2006-06-01 20:20:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/digi digi.c Log: MFC: Only reference the firmware module once rather than twice. Revision Changes Path 1.58.2.1 +0 -1 src/sys/dev/digi/digi.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 20:37:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C661716B7CD; Thu, 1 Jun 2006 20:37:17 +0000 (UTC) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9D1543D8C; Thu, 1 Jun 2006 20:36:47 +0000 (GMT) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51KZKwi072904; Thu, 1 Jun 2006 20:35:20 GMT (envelope-from krion@repoman.freebsd.org) Received: (from krion@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51KZKof072903; Thu, 1 Jun 2006 20:35:20 GMT (envelope-from krion) Message-Id: <200606012035.k51KZKof072903@repoman.freebsd.org> From: Kirill Ponomarew Date: Thu, 1 Jun 2006 20:35:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/find find.1 function.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 20:37:34 -0000 krion 2006-06-01 20:35:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/find find.1 function.c Log: MFC: function.c: 1.58; find.1: 1.77 date: 2006/05/27 18:27:41; author: krion; state: Exp; lines: +35 -3 Add the capability for a trailing scale indicator to cause the specified size to be read in the more familiar units of kilobytes, megabytes, gigabytes, terabytes and petabytes. PR: bin/50988 Submitted by: Matthew Seaman Revision Changes Path 1.73.2.2 +21 -2 src/usr.bin/find/find.1 1.53.2.4 +35 -3 src/usr.bin/find/function.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 20:53:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F0AC16BE0A; Thu, 1 Jun 2006 20:53:27 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CBCF743D48; Thu, 1 Jun 2006 20:53:26 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51Kpx0V081320; Thu, 1 Jun 2006 20:51:59 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51Kpx2S081319; Thu, 1 Jun 2006 20:51:59 GMT (envelope-from rodrigc) Message-Id: <200606012051.k51Kpx2S081319@repoman.freebsd.org> From: Craig Rodrigues Date: Thu, 1 Jun 2006 20:51:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/gnu/fs/xfs xfs_bit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 20:53:38 -0000 rodrigc 2006-06-01 20:51:59 UTC FreeBSD src repository Modified files: sys/gnu/fs/xfs xfs_bit.c Log: Include "xfs_macros.h" to fix tinderbox build breakage. Revision Changes Path 1.2 +1 -0 src/sys/gnu/fs/xfs/xfs_bit.c From owner-cvs-src@FreeBSD.ORG Thu Jun 1 21:10:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C59E16C578; Thu, 1 Jun 2006 21:10:10 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1318043DAA; Thu, 1 Jun 2006 21:09:43 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id k51L9fsO018339; Thu, 1 Jun 2006 17:09:42 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Kirill Ponomarew Date: Thu, 1 Jun 2006 17:09:26 -0400 User-Agent: KMail/1.6.2 References: <200605271827.k4RIRf7G078768@repoman.freebsd.org> In-Reply-To: <200605271827.k4RIRf7G078768@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: Multipart/Mixed; boundary="Boundary-00=_Ie1fErgPmDISPAA" Message-Id: <200606011709.28816.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV 0.88/1505/Thu Jun 1 14:29:37 2006 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/find find.1 function.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 21:10:41 -0000 --Boundary-00=_Ie1fErgPmDISPAA Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Saturday 27 May 2006 02:27 pm, Kirill Ponomarew wrote: > krion 2006-05-27 18:27:41 UTC > > FreeBSD src repository > > Modified files: > usr.bin/find find.1 function.c > Log: > Add the capability for a trailing scale indicator to cause the > specified size to be read in the more familiar units of > kilobytes, megabytes, gigabytes, terabytes and petabytes. > > PR: bin/50988 > Submitted by: Matthew Seaman > MFC after: 7 days > > Revision Changes Path > 1.77 +21 -2 src/usr.bin/find/find.1 > 1.58 +35 -3 src/usr.bin/find/function.c off_t may not be long long. I think you should do something like the attached patch and you may just remove the comments. Thanks! Jung-uk Kim --Boundary-00=_Ie1fErgPmDISPAA Content-Type: text/x-diff; charset="iso-8859-1"; name="find.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="find.diff" Index: function.c =================================================================== RCS file: /home/ncvs/src/usr.bin/find/function.c,v retrieving revision 1.58 diff -u -r1.58 function.c --- function.c 27 May 2006 18:27:41 -0000 1.58 +++ function.c 1 Jun 2006 21:01:00 -0000 @@ -1399,24 +1399,24 @@ if (endch != '\0') { divsize = 0; + scale = 1; switch (endch) { case 'c': /* characters */ - scale = 0x1LL; break; case 'k': /* kilobytes 1<<10 */ - scale = 0x400LL; + scale <<= 10; break; case 'M': /* megabytes 1<<20 */ - scale = 0x100000LL; + scale <<= 20; break; case 'G': /* gigabytes 1<<30 */ - scale = 0x40000000LL; + scale <<= 30; break; case 'T': /* terabytes 1<<40 */ - scale = 0x1000000000LL; + scale <<= 40; break; case 'P': /* petabytes 1<<50 */ - scale = 0x4000000000000LL; + scale <<= 50; break; default: errx(1, "%s: %s: illegal trailing character", --Boundary-00=_Ie1fErgPmDISPAA-- From owner-cvs-src@FreeBSD.ORG Thu Jun 1 21:33:08 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA97916BB48; Thu, 1 Jun 2006 21:33:08 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 715DD43D45; Thu, 1 Jun 2006 21:33:07 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 858441FFACC; Thu, 1 Jun 2006 23:33:05 +0200 (CEST) Received: by transport.cksoft.de (Postfix, from userid 66) id 186EA1FFACA; Thu, 1 Jun 2006 23:33:02 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id D26964448D6; Thu, 1 Jun 2006 21:32:27 +0000 (UTC) Date: Thu, 1 Jun 2006 21:32:25 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Jung-uk Kim In-Reply-To: <200606011709.28816.jkim@FreeBSD.org> Message-ID: <20060601212702.X79180@maildrop.int.zabbadoz.net> References: <200605271827.k4RIRf7G078768@repoman.freebsd.org> <200606011709.28816.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de Cc: cvs-src@FreeBSD.org, Kirill Ponomarew , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/find find.1 function.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 21:33:13 -0000 On Thu, 1 Jun 2006, Jung-uk Kim wrote: > On Saturday 27 May 2006 02:27 pm, Kirill Ponomarew wrote: >> krion 2006-05-27 18:27:41 UTC >> >> FreeBSD src repository >> >> Modified files: >> usr.bin/find find.1 function.c >> Log: >> Add the capability for a trailing scale indicator to cause the >> specified size to be read in the more familiar units of >> kilobytes, megabytes, gigabytes, terabytes and petabytes. >> > off_t may not be long long. I think you should do something like the > attached patch and you may just remove the comments. These names are wrong anyway. What you have are 2^10^{1,2,3,4,5} and that is {kibi,mebi,gibi,tebi,pebi}bytes [1]. [1] http://physics.nist.gov/cuu/Units/binary.html -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT From owner-cvs-src@FreeBSD.ORG Thu Jun 1 21:46:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95AF016B9CF; Thu, 1 Jun 2006 21:46:36 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E36343D58; Thu, 1 Jun 2006 21:46:35 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [IPv6:::1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k51LhWwJ080015; Thu, 1 Jun 2006 15:43:32 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 01 Jun 2006 15:43:39 -0600 (MDT) Message-Id: <20060601.154339.282836685.imp@bsdimp.com> To: bzeeb-lists@lists.zabbadoz.net From: "M. Warner Losh" In-Reply-To: <20060601212702.X79180@maildrop.int.zabbadoz.net> References: <200605271827.k4RIRf7G078768@repoman.freebsd.org> <200606011709.28816.jkim@FreeBSD.org> <20060601212702.X79180@maildrop.int.zabbadoz.net> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, krion@FreeBSD.org, cvs-all@FreeBSD.org, jkim@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/find find.1 function.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 21:46:46 -0000 In message: <20060601212702.X79180@maildrop.int.zabbadoz.net> "Bjoern A. Zeeb" writes: : On Thu, 1 Jun 2006, Jung-uk Kim wrote: : : > On Saturday 27 May 2006 02:27 pm, Kirill Ponomarew wrote: : >> krion 2006-05-27 18:27:41 UTC : >> : >> FreeBSD src repository : >> : >> Modified files: : >> usr.bin/find find.1 function.c : >> Log: : >> Add the capability for a trailing scale indicator to cause the : >> specified size to be read in the more familiar units of : >> kilobytes, megabytes, gigabytes, terabytes and petabytes. : >> : > off_t may not be long long. I think you should do something like the : > attached patch and you may just remove the comments. : : These names are wrong anyway. : What you have are 2^10^{1,2,3,4,5} and that is : {kibi,mebi,gibi,tebi,pebi}bytes [1]. : : [1] http://physics.nist.gov/cuu/Units/binary.html The 'bibibibibibibibibibi' byte stuff is silly. Historically that usage is correct. Warner From owner-cvs-src@FreeBSD.ORG Thu Jun 1 22:47:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D2DC16A46C; Thu, 1 Jun 2006 22:47:25 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3DF043D48; Thu, 1 Jun 2006 22:47:24 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51Mjv8R094870; Thu, 1 Jun 2006 22:45:57 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51MjumD094869; Thu, 1 Jun 2006 22:45:56 GMT (envelope-from cognet) Message-Id: <200606012245.k51MjumD094869@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 1 Jun 2006 22:45:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_switch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 22:47:31 -0000 cognet 2006-06-01 22:45:56 UTC FreeBSD src repository Modified files: sys/kern kern_switch.c Log: sched_rem() already sets ke->ke_state to KES_THREAD, so there's no need to redo it. Revision Changes Path 1.121 +0 -2 src/sys/kern/kern_switch.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 00:25:01 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C56B16A66A; Fri, 2 Jun 2006 00:25:01 +0000 (UTC) (envelope-from grog@lemis.com) Received: from ext-gw.lemis.com (ext-gw.lemis.com [150.101.14.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id B479C43D45; Fri, 2 Jun 2006 00:25:00 +0000 (GMT) (envelope-from grog@lemis.com) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.135]) by ext-gw.lemis.com (Postfix) with ESMTP id 93234131E64; Fri, 2 Jun 2006 09:54:59 +0930 (CST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 64B2886F56; Fri, 2 Jun 2006 09:54:59 +0930 (CST) Date: Fri, 2 Jun 2006 09:54:59 +0930 From: Greg 'groggy' Lehey To: Bruce Evans Message-ID: <20060602002459.GI80617@wantadilla.lemis.com> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601094950.GU21998@submonkey.net> <20060601100126.GA43737@FreeBSD.org> <200606010858.39417.jhb@freebsd.org> <20060602023102.J34761@delplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOhpupldhMlYbdva" Content-Disposition: inline In-Reply-To: <20060602023102.J34761@delplex.bde.org> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 VoIP: sip:0871270137@sip.internode.on.net WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Cc: Maxim Konovalov , Alexey Dokuchaev , src-committers@freebsd.org, John Baldwin , cvs-src@freebsd.org, cvs-all@freebsd.org, Ceri Davies Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 00:25:02 -0000 --BOhpupldhMlYbdva Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Friday, 2 June 2006 at 2:50:47 +1000, Bruce Evans wrote: > On Thu, 1 Jun 2006, John Baldwin wrote: > >> On Thursday 01 June 2006 06:01, Alexey Dokuchaev wrote: >>> On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: >>>> @@ -69,6 +69,10 @@ >>>> the file must be open for writing. >>>> .Sh RETURN VALUES >>>> .Rv -std >>>> +If the file to be modified is not a directory or >>>> +a regular file, the >>>> +.Fn truncate >>>> +call will return the value 0. >>> >>> Doesn't "value of 0" sound better? >> >> Not to me, though I can't explain why. I think the phrase "X will return >> the >> value Y" is common in man pages though. > > "will return" sounds strange to be. Yes, it will be better if you avoid the future tense. > Normal is "Upon successful completion, the value 0 is returned...". The passive is also to be avoided. How about "upon successful completion,\n.Nm\nreturns the value 0."? > This is part of what ".Rv -std" expands to. > > POSIX says "Upon successful completion, ftruncate( ) shall return 0...". Yes, but this is prescriptive. The man page should be descriptive. > The POSIX wording is better. "the value 0" says nothing more than > "0", It makes it clear that it's not a NULL pointer. > and "returns" is clearer than "is returned". Yes. > Saying "the value 0" is apparently a hack to give the clause a > subject (or is it an object? -- I think the value is the object > convoluted to a subject or vice versa). I don't think it makes any difference there. 0 is also a subject/object. Greg -- See complete headers for address and phone numbers. --BOhpupldhMlYbdva Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFEf4VbIubykFB6QiMRAsU5AKCDJ7KJ5iNz/52sgH+mJTW3lnbIaACgmtr1 63UjOjJwflItX43PDnXD990= =2Bjb -----END PGP SIGNATURE----- --BOhpupldhMlYbdva-- From owner-cvs-src@FreeBSD.ORG Fri Jun 2 00:27:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 740D316AAEF; Fri, 2 Jun 2006 00:27:56 +0000 (UTC) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA98843D5D; Fri, 2 Jun 2006 00:27:55 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k520QRtg001992; Fri, 2 Jun 2006 00:26:27 GMT (envelope-from tegge@repoman.freebsd.org) Received: (from tegge@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k520QRoF001991; Fri, 2 Jun 2006 00:26:27 GMT (envelope-from tegge) Message-Id: <200606020026.k520QRoF001991@repoman.freebsd.org> From: Tor Egge Date: Fri, 2 Jun 2006 00:26:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern kern_exit.c src/sys/vm vm_extern.h vm_glue.c vm_map.c vm_map.h vm_meter.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 00:27:59 -0000 tegge 2006-06-02 00:26:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern kern_exit.c sys/vm vm_extern.h vm_glue.c vm_map.c vm_map.h vm_meter.c Log: MFC: Close race between vmspace_exitfree() and exit1() and races between vmspace_exitfree() and vmspace_free() which could result in the same vmspace being freed twice. Factor out part of exit1() into new function vmspace_exit(). Attach to vmspace0 to allow old vmspace to be freed earlier. Add new function, vmspace_acquire_ref(), for obtaining a vmspace reference for a vmspace belonging to another process. Avoid changing vmspace refcount from 0 to 1 since that could also lead to the same vmspace being freed twice. Change vmtotal() and swapout_procs() to use vmspace_acquire_ref(). Revision Changes Path 1.263.2.9 +2 -30 src/sys/kern/kern_exit.c 1.76.2.2 +2 -0 src/sys/vm/vm_extern.h 1.213.2.2 +3 -6 src/sys/vm/vm_glue.c 1.366.2.3 +93 -16 src/sys/vm/vm_map.c 1.117.2.1 +0 -1 src/sys/vm/vm_map.h 1.85.2.1 +6 -1 src/sys/vm/vm_meter.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 00:30:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 34C9616AAA1; Fri, 2 Jun 2006 00:30:30 +0000 (UTC) (envelope-from markus@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB81D43D45; Fri, 2 Jun 2006 00:30:29 +0000 (GMT) (envelope-from markus@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k520T19b002108; Fri, 2 Jun 2006 00:29:01 GMT (envelope-from markus@repoman.freebsd.org) Received: (from markus@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k520T1jD002107; Fri, 2 Jun 2006 00:29:01 GMT (envelope-from markus) Message-Id: <200606020029.k520T1jD002107@repoman.freebsd.org> From: Markus Brueffer Date: Fri, 2 Jun 2006 00:29:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/bluetooth/hccontrol hccontrol.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 00:30:30 -0000 markus 2006-06-02 00:29:01 UTC FreeBSD src repository Modified files: usr.sbin/bluetooth/hccontrol hccontrol.c Log: - Only print a clarifying message about which HCI node has been used if there is more than one HCI node present - Use errx(3) instead of err(3) if there is no HCI node present as errno is 0 in this case and the resulting error message wouldn't make much sense Approved by: emax (mentor) Revision Changes Path 1.5 +6 -4 src/usr.sbin/bluetooth/hccontrol/hccontrol.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 01:22:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9890516ACEF; Fri, 2 Jun 2006 01:22:27 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31E8E43D46; Fri, 2 Jun 2006 01:22:27 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k521Kwkl013247; Fri, 2 Jun 2006 01:20:58 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k521KwSf013246; Fri, 2 Jun 2006 01:20:58 GMT (envelope-from rodrigc) Message-Id: <200606020120.k521KwSf013246@repoman.freebsd.org> From: Craig Rodrigues Date: Fri, 2 Jun 2006 01:20:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/rpc.lockd kern.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 01:22:28 -0000 rodrigc 2006-06-02 01:20:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/rpc.lockd kern.c Log: MFC: 1.19 Move call to ignore SIGPIPE signals before calling fork(), so that both parent and child processes ignore this signal. PR: bin/97768 Submitted by: Gea-Suan Lin Revision Changes Path 1.16.2.1 +3 -0 src/usr.sbin/rpc.lockd/kern.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 02:32:29 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AB3016AEE4; Fri, 2 Jun 2006 02:32:29 +0000 (UTC) (envelope-from harry@schmalzbauer.de) Received: from flb.schmalzbauer.de (flb.schmalzbauer.de [62.245.232.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id 54E6F43D45; Fri, 2 Jun 2006 02:32:27 +0000 (GMT) (envelope-from harry@schmalzbauer.de) Received: from sam.flintsbach.schmalzbauer.de (sam.flintsbach.schmalzbauer.de [172.21.2.4]) by flb.schmalzbauer.de (8.13.4/8.13.4) with ESMTP id k522XYQt012662; Fri, 2 Jun 2006 04:33:34 +0200 (CEST) (envelope-from harry@schmalzbauer.de) Received: from cale.flintsbach.schmalzbauer.de (cale.flintsbach.schmalzbauer.de [172.21.1.204]) by sam.flintsbach.schmalzbauer.de (Postfix) with ESMTP id B7775B62D; Fri, 2 Jun 2006 04:32:25 +0200 (CEST) Received: from cale.flintsbach.schmalzbauer.de (localhost [127.0.0.1]) by cale.flintsbach.schmalzbauer.de (8.13.6/8.13.6) with ESMTP id k522W96w058392; Fri, 2 Jun 2006 04:32:09 +0200 (CEST) (envelope-from harry@schmalzbauer.de) Received: from localhost (localhost [[UNIX: localhost]]) by cale.flintsbach.schmalzbauer.de (8.13.6/8.13.6/Submit) id k522W9aB058268; Fri, 2 Jun 2006 04:32:09 +0200 (CEST) (envelope-from harry@schmalzbauer.de) X-Authentication-Warning: cale.flintsbach.schmalzbauer.de: harry set sender to harry@schmalzbauer.de using -f From: Harald Schmalzbauer To: cvs-src@freebsd.org Date: Fri, 2 Jun 2006 04:32:07 +0200 User-Agent: KMail/1.9.1 References: <200606020120.k521KwSf013246@repoman.freebsd.org> In-Reply-To: <200606020120.k521KwSf013246@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606020432.08684.harry@schmalzbauer.de> Cc: Craig Rodrigues Subject: Re: cvs commit: src/usr.sbin/rpc.lockd kern.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 02:32:34 -0000 Am Freitag, 2. Juni 2006 03:20 schrieb Craig Rodrigues: > rodrigc 2006-06-02 01:20:58 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > usr.sbin/rpc.lockd kern.c > Log: > MFC: 1.19 Thank you! Shouldn't 1.17 also be MFC'd? (http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.sbin/rpc.lockd/kern.c.diff?r1=1.16&r2=1.17) Or does the problem not apply to RELENG_6? Thanks, -Harry > > Move call to ignore SIGPIPE signals before calling fork(), > so that both parent and child processes ignore this signal. > > PR: bin/97768 > Submitted by: Gea-Suan Lin > > Revision Changes Path > 1.16.2.1 +3 -0 src/usr.sbin/rpc.lockd/kern.c > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" From owner-cvs-src@FreeBSD.ORG Fri Jun 2 02:38:51 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DB7116A42C; Fri, 2 Jun 2006 02:38:51 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.152]) by mx1.FreeBSD.org (Postfix) with ESMTP id 22F5A43D45; Fri, 2 Jun 2006 02:38:50 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-24-147-19-128.hsd1.ma.comcast.net (c-71-233-168-2.hsd1.ma.comcast.net[71.233.168.2](misconfigured sender)) by comcast.net (rwcrmhc12) with ESMTP id <20060602023849m1200lrj96e>; Fri, 2 Jun 2006 02:38:49 +0000 Received: from c-24-147-19-128.hsd1.ma.comcast.net (localhost [127.0.0.1]) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1) with ESMTP id k522cnZZ020971; Thu, 1 Jun 2006 22:38:50 -0400 (EDT) (envelope-from rodrigc@c-24-147-19-128.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1/Submit) id k522cntw020970; Thu, 1 Jun 2006 22:38:49 -0400 (EDT) (envelope-from rodrigc) Date: Thu, 1 Jun 2006 22:38:49 -0400 From: Craig Rodrigues To: Harald Schmalzbauer Message-ID: <20060602023849.GA20954@crodrigues.org> References: <200606020120.k521KwSf013246@repoman.freebsd.org> <200606020432.08684.harry@schmalzbauer.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200606020432.08684.harry@schmalzbauer.de> User-Agent: Mutt/1.4.2.1i Cc: Craig Rodrigues , cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/rpc.lockd kern.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 02:38:52 -0000 On Fri, Jun 02, 2006 at 04:32:07AM +0200, Harald Schmalzbauer wrote: > Shouldn't 1.17 also be MFC'd? > (http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.sbin/rpc.lockd/kern.c.diff?r1=1.16&r2=1.17) > > Or does the problem not apply to RELENG_6? Ask Harti, that's not my commit. -- Craig Rodrigues rodrigc@crodrigues.org From owner-cvs-src@FreeBSD.ORG Fri Jun 2 04:03:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3B4416A502; Fri, 2 Jun 2006 04:03:35 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 708EC43D46; Fri, 2 Jun 2006 04:03:35 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52426N0024787; Fri, 2 Jun 2006 04:02:06 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k524266A024786; Fri, 2 Jun 2006 04:02:06 GMT (envelope-from mlaier) Message-Id: <200606020402.k524266A024786@repoman.freebsd.org> From: Max Laier Date: Fri, 2 Jun 2006 04:02:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 04:03:38 -0000 mlaier 2006-06-02 04:02:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netinet ip_fw2.c Log: MFC rev. 1.131: Use only lower 64bit of src/dest (and src/dest port) for hashing of IPv6 connections and get rid of the flow_id as it is not guaranteed to be stable some (most?) current implementations seem to just zero it out. PR: kern/88664 Revision Changes Path 1.106.2.13 +4 -4 src/sys/netinet/ip_fw2.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 04:47:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F388616A71C; Fri, 2 Jun 2006 04:47:55 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B30E043D48; Fri, 2 Jun 2006 04:47:55 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k524kQmJ027824; Fri, 2 Jun 2006 04:46:26 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k524kQHA027823; Fri, 2 Jun 2006 04:46:26 GMT (envelope-from imp) Message-Id: <200606020446.k524kQHA027823@repoman.freebsd.org> From: Warner Losh Date: Fri, 2 Jun 2006 04:46:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ia64/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 04:47:56 -0000 imp 2006-06-02 04:46:26 UTC FreeBSD src repository Modified files: sys/ia64/conf NOTES Log: EISA bus ia64 systems don't exist in reality. I'm told they may exist in theory, but that it was OK to remove from NOTES. OK'd by: marcel Revision Changes Path 1.10 +0 -1 src/sys/ia64/conf/NOTES From owner-cvs-src@FreeBSD.ORG Fri Jun 2 05:18:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3DAB16A514; Fri, 2 Jun 2006 05:18:46 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 95EA343D53; Fri, 2 Jun 2006 05:18:46 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k525HHFg037820; Fri, 2 Jun 2006 05:17:17 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k525HHLU037819; Fri, 2 Jun 2006 05:17:17 GMT (envelope-from mlaier) Message-Id: <200606020517.k525HHLU037819@repoman.freebsd.org> From: Max Laier Date: Fri, 2 Jun 2006 05:17:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/ipfw ipfw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 05:18:47 -0000 mlaier 2006-06-02 05:17:17 UTC FreeBSD src repository Modified files: sbin/ipfw ipfw2.c Log: Print dynamic rules for IPv6 as well. PR: bin/98349 Submitted by: Mark Andrews MFC after: 2 weeks Revision Changes Path 1.90 +15 -5 src/sbin/ipfw/ipfw2.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 06:35:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24AC116AB7E; Fri, 2 Jun 2006 06:35:05 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD73243D49; Fri, 2 Jun 2006 06:35:04 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k526XZsQ044632; Fri, 2 Jun 2006 06:33:35 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k526XZtQ044631; Fri, 2 Jun 2006 06:33:35 GMT (envelope-from imp) Message-Id: <200606020633.k526XZtQ044631@repoman.freebsd.org> From: Warner Losh Date: Fri, 2 Jun 2006 06:33:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccbb pccbb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 06:35:16 -0000 imp 2006-06-02 06:33:35 UTC FreeBSD src repository Modified files: sys/dev/pccbb pccbb.c Log: Zero out the devices when they are deleted. We can access the pointer after the bus detaches which can lead to core dumps. This is quite rare. Revision Changes Path 1.146 +5 -1 src/sys/dev/pccbb/pccbb.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 07:52:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8110016A44B; Fri, 2 Jun 2006 07:52:28 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E83643D48; Fri, 2 Jun 2006 07:52:28 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k527owFu049679; Fri, 2 Jun 2006 07:50:58 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k527ow1v049678; Fri, 2 Jun 2006 07:50:58 GMT (envelope-from glebius) Message-Id: <200606020750.k527ow1v049678@repoman.freebsd.org> From: Gleb Smirnoff Date: Fri, 2 Jun 2006 07:50:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_media.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 07:52:29 -0000 glebius 2006-06-02 07:50:58 UTC FreeBSD src repository Modified files: sys/net if_media.h Log: - Add definition for IFM_10G_CX4. - Put IFM_10G_CX4 and IFM_10G_SR into IFMEDIA_BAUDRATE array. Requested by: Jack Vogel Revision Changes Path 1.36 +4 -0 src/sys/net/if_media.h From owner-cvs-src@FreeBSD.ORG Fri Jun 2 08:19:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C3BFB16A4E9; Fri, 2 Jun 2006 08:19:57 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 51BCE43D48; Fri, 2 Jun 2006 08:19:57 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k528IRTL052037; Fri, 2 Jun 2006 08:18:27 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k528IRls052036; Fri, 2 Jun 2006 08:18:27 GMT (envelope-from rwatson) Message-Id: <200606020818.k528IRls052036@repoman.freebsd.org> From: Robert Watson Date: Fri, 2 Jun 2006 08:18:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet in_pcb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 08:19:57 -0000 rwatson 2006-06-02 08:18:27 UTC FreeBSD src repository Modified files: sys/netinet in_pcb.c Log: Minor restyling and cleanup around ipport_tick(). MFC after: 1 month Revision Changes Path 1.177 +9 -11 src/sys/netinet/in_pcb.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 08:28:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A9B816A42B; Fri, 2 Jun 2006 08:28:46 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA81243D45; Fri, 2 Jun 2006 08:28:45 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k528RFnV052427; Fri, 2 Jun 2006 08:27:15 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k528RFsp052426; Fri, 2 Jun 2006 08:27:15 GMT (envelope-from rwatson) Message-Id: <200606020827.k528RFsp052426@repoman.freebsd.org> From: Robert Watson Date: Fri, 2 Jun 2006 08:27:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net raw_cb.c raw_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 08:28:46 -0000 rwatson 2006-06-02 08:27:15 UTC FreeBSD src repository Modified files: sys/net raw_cb.c raw_usrreq.c Log: raw_disconnect() now disconnects but does not detach the raw pcb. As a result, raw_uabort() now needs to call raw_detach() directly. As raw_uabort() is never called, and raw_disconnect() is probably not ever actually called in practice, this is likely not a functional change, but improves congruence between protocols, and avoids a NULL raw cb pointer after disconnect, which could result in a panic. MFC after: 1 month Revision Changes Path 1.34 +1 -3 src/sys/net/raw_cb.c 1.42 +1 -0 src/sys/net/raw_usrreq.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 08:38:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3085016A420; Fri, 2 Jun 2006 08:38:32 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E026543D49; Fri, 2 Jun 2006 08:38:31 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k528b2QB052664; Fri, 2 Jun 2006 08:37:02 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k528b2eY052663; Fri, 2 Jun 2006 08:37:02 GMT (envelope-from davidxu) Message-Id: <200606020837.k528b2eY052663@repoman.freebsd.org> From: David Xu Date: Fri, 2 Jun 2006 08:37:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libthr/thread thr_mutex.c thr_private.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 08:38:32 -0000 davidxu 2006-06-02 08:37:01 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_mutex.c thr_private.h Log: Remove unused member field m_queue. Revision Changes Path 1.43 +1 -5 src/lib/libthr/thread/thr_mutex.c 1.64 +0 -1 src/lib/libthr/thread/thr_private.h From owner-cvs-src@FreeBSD.ORG Fri Jun 2 09:10:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 71BE916A491; Fri, 2 Jun 2006 09:10:22 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 089DF43D48; Fri, 2 Jun 2006 09:10:22 +0000 (GMT) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k5298qN1062294; Fri, 2 Jun 2006 09:08:52 GMT (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k5298qED062293; Fri, 2 Jun 2006 09:08:52 GMT (envelope-from dds) Message-Id: <200606020908.k5298qED062293@repoman.freebsd.org> From: Diomidis Spinellis Date: Fri, 2 Jun 2006 09:08:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph/atm/uni ng_uni_cust.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 09:10:24 -0000 dds 2006-06-02 09:08:51 UTC FreeBSD src repository Modified files: sys/netgraph/atm/uni ng_uni_cust.h Log: Replace the array initialization using the gcc-specific format [constant] value with the C99 format [constant] = value Revision Changes Path 1.6 +5 -5 src/sys/netgraph/atm/uni/ng_uni_cust.h From owner-cvs-src@FreeBSD.ORG Fri Jun 2 09:38:35 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 165C816A41F; Fri, 2 Jun 2006 09:38:35 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-0-0-cust107.cdif.cable.ntl.com [81.104.168.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7467443D49; Fri, 2 Jun 2006 09:38:34 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.62 (FreeBSD)) (envelope-from ) id 1Fm66w-000Gsa-1C; Fri, 02 Jun 2006 10:38:30 +0100 Date: Fri, 2 Jun 2006 10:38:29 +0100 From: Ceri Davies To: Greg 'groggy' Lehey Message-ID: <20060602093829.GE23618@submonkey.net> Mail-Followup-To: Ceri Davies , Greg 'groggy' Lehey , Bruce Evans , John Baldwin , Alexey Dokuchaev , Maxim Konovalov , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601094950.GU21998@submonkey.net> <20060601100126.GA43737@FreeBSD.org> <200606010858.39417.jhb@freebsd.org> <20060602023102.J34761@delplex.bde.org> <20060602002459.GI80617@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3siQDZowHQqNOShm" Content-Disposition: inline In-Reply-To: <20060602002459.GI80617@wantadilla.lemis.com> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.11 Sender: Ceri Davies Cc: Maxim Konovalov , Alexey Dokuchaev , src-committers@freebsd.org, Bruce Evans , John Baldwin , cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 09:38:35 -0000 --3siQDZowHQqNOShm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 02, 2006 at 09:54:59AM +0930, Greg 'groggy' Lehey wrote: > On Friday, 2 June 2006 at 2:50:47 +1000, Bruce Evans wrote: > > On Thu, 1 Jun 2006, John Baldwin wrote: > > > >> On Thursday 01 June 2006 06:01, Alexey Dokuchaev wrote: > >>> On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: > >>>> @@ -69,6 +69,10 @@ > >>>> the file must be open for writing. > >>>> .Sh RETURN VALUES > >>>> .Rv -std > >>>> +If the file to be modified is not a directory or > >>>> +a regular file, the > >>>> +.Fn truncate > >>>> +call will return the value 0. > >>> > >>> Doesn't "value of 0" sound better? > >> > >> Not to me, though I can't explain why. I think the phrase "X will ret= urn > >> the > >> value Y" is common in man pages though. > > > > "will return" sounds strange to be. >=20 > Yes, it will be better if you avoid the future tense. May I recommend that one of you just change it? Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --3siQDZowHQqNOShm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEgAcVocfcwTS3JF8RAs3CAKCV3ri/qblLbzWFOYjHflsL7ngb8ACfUJ4z 0/isunISXZmfXQjxODOt5c0= =hXfv -----END PGP SIGNATURE----- --3siQDZowHQqNOShm-- From owner-cvs-src@FreeBSD.ORG Fri Jun 2 09:40:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE41E16A41F; Fri, 2 Jun 2006 09:40:36 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD2DA43D45; Fri, 2 Jun 2006 09:40:36 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k529d613062904; Fri, 2 Jun 2006 09:39:06 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k529d605062903; Fri, 2 Jun 2006 09:39:06 GMT (envelope-from cognet) Message-Id: <200606020939.k529d605062903@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 2 Jun 2006 09:39:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/include cpuconf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 09:40:37 -0000 cognet 2006-06-02 09:39:06 UTC FreeBSD src repository Modified files: sys/arm/include cpuconf.h Log: Don't #error if no CPU is defined but we're not compiling the kernel. Revision Changes Path 1.7 +2 -2 src/sys/arm/include/cpuconf.h From owner-cvs-src@FreeBSD.ORG Fri Jun 2 09:40:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A773516A423; Fri, 2 Jun 2006 09:40:53 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-0-0-cust107.cdif.cable.ntl.com [81.104.168.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D58843D49; Fri, 2 Jun 2006 09:40:53 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.62 (FreeBSD)) (envelope-from ) id 1Fm69E-00063W-3O; Fri, 02 Jun 2006 10:40:52 +0100 Date: Fri, 2 Jun 2006 10:40:52 +0100 From: Ceri Davies To: Kris Kennaway Message-ID: <20060602094051.GF23618@submonkey.net> Mail-Followup-To: Ceri Davies , Kris Kennaway , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200605311915.k4VJFKef060742@repoman.freebsd.org> <20060601012130.GA5066@xor.obsecurity.org> <20060601084127.GS21998@submonkey.net> <20060601151837.GA32439@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XvKFcGCOAo53UbWW" Content-Disposition: inline In-Reply-To: <20060601151837.GA32439@xor.obsecurity.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.11 Sender: Ceri Davies Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall installUpgrade.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 09:40:53 -0000 --XvKFcGCOAo53UbWW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 01, 2006 at 11:18:37AM -0400, Kris Kennaway wrote: > On Thu, Jun 01, 2006 at 09:41:27AM +0100, Ceri Davies wrote: > > On Wed, May 31, 2006 at 09:21:30PM -0400, Kris Kennaway wrote: > > > On Wed, May 31, 2006 at 07:15:20PM +0000, Ceri Davies wrote: > > > > ceri 2006-05-31 19:15:20 UTC > > > >=20 > > > > FreeBSD src repository > > > >=20 > > > > Modified files: > > > > usr.sbin/sysinstall installUpgrade.c=20 > > > > Log: > > > > Update the location of the kernel for upgrades. > > > > =20 > > > > I considered leaving /boot/kernel out of the chflags noschg line,= but I > > > > seem to remember that there was a period where /boot/kernel was s= chg, so > > > > have left it in for safety's sake. > > >=20 > > > Does this explain the user report I have that a binary upgrade from > > > 6.0 to 6.1 did not update the kernel? > >=20 > > No, I don't think so. This is more to do with saving the old one for > > saftey's sake; there's nothing in here that should have prevented his > > old kernel from being committed to block limbo. > >=20 > > I'll dig around and see if I can see how that might have happened, but I > > can't think of anything off the top of my head. >=20 > Never mind, it was user error (they were trying to use an 6.0 CD to > update to 6.1 by changing the release name). This is actually fairly > common, so I wonder if a bit of text could be added saying not to do > this. Hmm. It's been a while since I tried that, but I remember that worked (so long as you pointed it at the internets). What you're asking for is that we check that the release name set in options matches the bits on the CD if we're extracting from CD, right? --=20 That must be wonderful! I don't understand it at all. -- Moliere --XvKFcGCOAo53UbWW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEgAejocfcwTS3JF8RArjgAJ9gV3irUx7Ye/hK4FLgJ66iGo5MWQCcDtPm n+EiiUKpgD0oj0s5yw/kYJU= =qDkk -----END PGP SIGNATURE----- --XvKFcGCOAo53UbWW-- From owner-cvs-src@FreeBSD.ORG Fri Jun 2 09:57:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B12B16A426; Fri, 2 Jun 2006 09:57:58 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A4DC43D46; Fri, 2 Jun 2006 09:57:58 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k529uSu8063372; Fri, 2 Jun 2006 09:56:28 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k529uSte063371; Fri, 2 Jun 2006 09:56:28 GMT (envelope-from rwatson) Message-Id: <200606020956.k529uSte063371@repoman.freebsd.org> From: Robert Watson Date: Fri, 2 Jun 2006 09:56:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 09:57:58 -0000 rwatson 2006-06-02 09:56:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/vm uma_core.c Log: Merge uma_core.c:1.137 from HEAD to RELENG_6: When allocating a bucket to hold a free'd item in UMA fails, don't report this as an allocation failure for the item type. The failure will be separately recorded with the bucket type. This may eliminate high mbuf allocation failure counts under some circumstances, which can be alarming in appearance, but not actually a problem in practice. Reported by: ps, Peter J. Blok , OxY , Gabor MICSKO This is a RELENG_6_1 merge candidate. Tested by: Peter J. Blok , OxY , Michael Butler Revision Changes Path 1.119.2.16 +1 -2 src/sys/vm/uma_core.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 10:25:08 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7BE9A16A475; Fri, 2 Jun 2006 10:25:08 +0000 (UTC) (envelope-from grog@lemis.com) Received: from ext-gw.lemis.com (ext-gw.lemis.com [150.101.14.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 42C3B43D73; Fri, 2 Jun 2006 10:25:03 +0000 (GMT) (envelope-from grog@lemis.com) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.135]) by ext-gw.lemis.com (Postfix) with ESMTP id 64D38131E13; Fri, 2 Jun 2006 19:55:02 +0930 (CST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 429E386F56; Fri, 2 Jun 2006 19:55:02 +0930 (CST) Date: Fri, 2 Jun 2006 19:55:02 +0930 From: Greg 'groggy' Lehey To: Ceri Davies , Bruce Evans , John Baldwin , Alexey Dokuchaev , Maxim Konovalov , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20060602102502.GF55506@wantadilla.lemis.com> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601094950.GU21998@submonkey.net> <20060601100126.GA43737@FreeBSD.org> <200606010858.39417.jhb@freebsd.org> <20060602023102.J34761@delplex.bde.org> <20060602002459.GI80617@wantadilla.lemis.com> <20060602093829.GE23618@submonkey.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z+pzSjdB7cqptWpS" Content-Disposition: inline In-Reply-To: <20060602093829.GE23618@submonkey.net> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 VoIP: sip:0871270137@sip.internode.on.net WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Cc: Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 10:25:08 -0000 --z+pzSjdB7cqptWpS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Friday, 2 June 2006 at 10:38:29 +0100, Ceri Davies wrote: > On Fri, Jun 02, 2006 at 09:54:59AM +0930, Greg 'groggy' Lehey wrote: >> On Friday, 2 June 2006 at 2:50:47 +1000, Bruce Evans wrote: >>> On Thu, 1 Jun 2006, John Baldwin wrote: >>> >>>> On Thursday 01 June 2006 06:01, Alexey Dokuchaev wrote: >>>>> On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: >>>>>> @@ -69,6 +69,10 @@ >>>>>> the file must be open for writing. >>>>>> .Sh RETURN VALUES >>>>>> .Rv -std >>>>>> +If the file to be modified is not a directory or >>>>>> +a regular file, the >>>>>> +.Fn truncate >>>>>> +call will return the value 0. >>>>> >>>>> Doesn't "value of 0" sound better? >>>> >>>> Not to me, though I can't explain why. I think the phrase "X will return >>>> the >>>> value Y" is common in man pages though. >>> >>> "will return" sounds strange to be. >> >> Yes, it will be better if you avoid the future tense. > > May I recommend that one of you just change it? What colour? Greg -- See complete headers for address and phone numbers. --z+pzSjdB7cqptWpS Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFEgBH+IubykFB6QiMRAnhOAJ0YiHWFaMfKCU6V3hbCGq3+3YT44gCfUyiW 9VKVFK6mZ/lRZWJuWaJC5sQ= =URe/ -----END PGP SIGNATURE----- --z+pzSjdB7cqptWpS-- From owner-cvs-src@FreeBSD.ORG Fri Jun 2 10:36:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F90816A481; Fri, 2 Jun 2006 10:36:49 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from pittgoth.com (ns1.pittgoth.com [216.38.206.188]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6281443D48; Fri, 2 Jun 2006 10:36:48 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from localhost (net-ix.gw.ai.net [205.134.160.6] (may be forged)) (authenticated bits=0) by pittgoth.com (8.13.4/8.13.4) with ESMTP id k52Bjw2o067620 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 2 Jun 2006 07:45:59 -0400 (EDT) (envelope-from trhodes@FreeBSD.org) Date: Fri, 2 Jun 2006 06:36:03 -0400 From: Tom Rhodes To: "Greg 'groggy' Lehey" Message-Id: <20060602063603.7c8e2d4d.trhodes@FreeBSD.org> In-Reply-To: <20060602102502.GF55506@wantadilla.lemis.com> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601094950.GU21998@submonkey.net> <20060601100126.GA43737@FreeBSD.org> <200606010858.39417.jhb@freebsd.org> <20060602023102.J34761@delplex.bde.org> <20060602002459.GI80617@wantadilla.lemis.com> <20060602093829.GE23618@submonkey.net> <20060602102502.GF55506@wantadilla.lemis.com> X-Mailer: Sylpheed version 1.0.6 (GTK+ 1.2.10; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: maxim@FreeBSD.org, danfe@FreeBSD.org, src-committers@FreeBSD.org, bde@zeta.org.au, jhb@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, ceri@submonkey.net Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 10:36:49 -0000 On Fri, 2 Jun 2006 19:55:02 +0930 "Greg 'groggy' Lehey" wrote: > On Friday, 2 June 2006 at 10:38:29 +0100, Ceri Davies wrote: > > On Fri, Jun 02, 2006 at 09:54:59AM +0930, Greg 'groggy' Lehey wrote: > >> On Friday, 2 June 2006 at 2:50:47 +1000, Bruce Evans wrote: > >>> On Thu, 1 Jun 2006, John Baldwin wrote: > >>> > >>>> On Thursday 01 June 2006 06:01, Alexey Dokuchaev wrote: > >>>>> On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: > >>>>>> @@ -69,6 +69,10 @@ > >>>>>> the file must be open for writing. > >>>>>> .Sh RETURN VALUES > >>>>>> .Rv -std > >>>>>> +If the file to be modified is not a directory or > >>>>>> +a regular file, the > >>>>>> +.Fn truncate > >>>>>> +call will return the value 0. > >>>>> > >>>>> Doesn't "value of 0" sound better? > >>>> > >>>> Not to me, though I can't explain why. I think the phrase "X will return > >>>> the > >>>> value Y" is common in man pages though. > >>> > >>> "will return" sounds strange to be. > >> > >> Yes, it will be better if you avoid the future tense. > > > > May I recommend that one of you just change it? > > What colour? Black. My answer would have to be black. -- Tom Rhodes From owner-cvs-src@FreeBSD.ORG Fri Jun 2 11:13:58 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8891216A421; Fri, 2 Jun 2006 11:13:58 +0000 (UTC) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from mail-gw4.york.ac.uk (mail-gw4.york.ac.uk [144.32.128.249]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5F8343D46; Fri, 2 Jun 2006 11:13:57 +0000 (GMT) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from buffy.york.ac.uk (buffy-128.york.ac.uk [144.32.128.160]) by mail-gw4.york.ac.uk (8.13.6/8.13.6) with ESMTP id k52BDrwv007580; Fri, 2 Jun 2006 12:13:53 +0100 (BST) Received: from buffy.york.ac.uk (localhost [127.0.0.1]) by buffy.york.ac.uk (8.13.6/8.13.6) with ESMTP id k52BDquc069073; Fri, 2 Jun 2006 12:13:52 +0100 (BST) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: (from ga9@localhost) by buffy.york.ac.uk (8.13.6/8.13.6/Submit) id k52BDpaV069072; Fri, 2 Jun 2006 12:13:51 +0100 (BST) (envelope-from gavin.atkinson@ury.york.ac.uk) X-Authentication-Warning: buffy.york.ac.uk: ga9 set sender to gavin.atkinson@ury.york.ac.uk using -f From: Gavin Atkinson To: Tor Egge In-Reply-To: <200606020026.k520QRoF001991@repoman.freebsd.org> References: <200606020026.k520QRoF001991@repoman.freebsd.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Fri, 02 Jun 2006 12:13:51 +0100 Message-Id: <1149246831.60897.63.camel@buffy.york.ac.uk> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 FreeBSD GNOME Team Port X-York-MailScanner: Found to be clean X-York-MailScanner-From: gavin.atkinson@ury.york.ac.uk Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c src/sys/vm vm_extern.h vm_glue.c vm_map.c vm_map.h vm_meter.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 11:13:58 -0000 On Fri, 2006-06-02 at 00:26 +0000, Tor Egge wrote: > tegge 2006-06-02 00:26:27 UTC > > Modified files: (Branch: RELENG_6) > sys/kern kern_exit.c > sys/vm vm_extern.h vm_glue.c vm_map.c vm_map.h > vm_meter.c > Log: > MFC: Close race between vmspace_exitfree() and exit1() and races between > vmspace_exitfree() and vmspace_free() which could result in the same > vmspace being freed twice. Is it possible that this may fix the "bad pte" panic with "TPTE at 0xffff8000040028c8 IS ZERO @ VA 800519000" that I saw at http://docs.FreeBSD.org/cgi/mid.cgi?1148482556.35287.18.camel ? I've only ever seen that panic once, so I can't really test this commit to see if it does indeed fix that issue. Thanks, Gavin From owner-cvs-src@FreeBSD.ORG Fri Jun 2 12:36:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4F1416A4A6; Fri, 2 Jun 2006 12:36:11 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5293443D45; Fri, 2 Jun 2006 12:36:10 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 715592086; Fri, 2 Jun 2006 14:36:06 +0200 (CEST) X-Spam-Tests: none X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on tim.des.no Received: from xps.des.no (des.no [80.203.243.180]) by tim.des.no (Postfix) with ESMTP id 6111C2082; Fri, 2 Jun 2006 14:36:06 +0200 (CEST) Received: by xps.des.no (Postfix, from userid 1001) id 3A3D133C8D; Fri, 2 Jun 2006 14:36:06 +0200 (CEST) From: des@des.no (Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?=) To: Guy Helmer References: <200605241403.k4OE3pvp007556@repoman.freebsd.org> Date: Fri, 02 Jun 2006 14:36:05 +0200 In-Reply-To: <200605241403.k4OE3pvp007556@repoman.freebsd.org> (Guy Helmer's message of "Wed, 24 May 2006 14:03:51 +0000 (UTC)") Message-ID: <86y7wf20qy.fsf@xps.des.no> User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/procfs procfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 12:36:19 -0000 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Guy Helmer writes: > Log: > Revision 1.4 set access for all sensitive files in /proc/ to mode 0 > if a process's uid or gid has changed, but the /proc/ directory > itself was also set to mode 0. Assuming this doesn't open any > security holes, open access to the /proc/ directory for users > other than root to read or search the directory. >=20=20=20 > Reviewed by: des (back in February) > MFC after: 3 weeks In hindsight, I think I prefer the attached (untested) solution... DES --=20 Dag-Erling Sm=F8rgrav - des@des.no --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=procfs.diff Index: sys/fs/procfs/procfs.c =================================================================== RCS file: /home/ncvs/src/sys/fs/procfs/procfs.c,v retrieving revision 1.13 diff -u -r1.13 procfs.c --- sys/fs/procfs/procfs.c 24 May 2006 14:03:51 -0000 1.13 +++ sys/fs/procfs/procfs.c 2 Jun 2006 12:35:55 -0000 @@ -98,12 +98,7 @@ PROC_LOCK_ASSERT(p, MA_OWNED); /* XXX inefficient, split into separate functions */ - if (p->p_flag & P_SUGID) { - if (pn->pn_type == pfstype_procdir) - vap->va_mode = 0555; - else - vap->va_mode = 0; - } else if (strcmp(pn->pn_name, "ctl") == 0 || + if (strcmp(pn->pn_name, "ctl") == 0 || strcmp(pn->pn_name, "note") == 0 || strcmp(pn->pn_name, "notepg") == 0) vap->va_mode = 0200; @@ -113,6 +108,9 @@ strcmp(pn->pn_name, "fpregs") == 0) vap->va_mode = 0600; + if ((p->p_flag & P_SUGID) && pn->pn_type != pfstype_procdir) + vap->va_mode &= ~077; + vap->va_uid = p->p_ucred->cr_uid; vap->va_gid = p->p_ucred->cr_gid; --=-=-=-- From owner-cvs-src@FreeBSD.ORG Fri Jun 2 12:56:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2606116A420; Fri, 2 Jun 2006 12:56:57 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D62D743D45; Fri, 2 Jun 2006 12:56:56 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52CtQSh087221; Fri, 2 Jun 2006 12:55:26 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52CtQlJ087220; Fri, 2 Jun 2006 12:55:26 GMT (envelope-from maxim) Message-Id: <200606021255.k52CtQlJ087220@repoman.freebsd.org> From: Maxim Konovalov Date: Fri, 2 Jun 2006 12:55:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/fsdb fsdb.8 fsdb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 12:56:57 -0000 maxim 2006-06-02 12:55:26 UTC FreeBSD src repository Modified files: sbin/fsdb fsdb.8 fsdb.c Log: o Implement findblk command: find the inode(s) owning the specified disk block(s) number(s). Obtained from: NetBSD MFC after: 2 months Revision Changes Path 1.29 +7 -1 src/sbin/fsdb/fsdb.8 1.33 +265 -0 src/sbin/fsdb/fsdb.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 13:02:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 16EFD16A4C9; Fri, 2 Jun 2006 13:02:57 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B10B243D46; Fri, 2 Jun 2006 13:02:56 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52D1PZK087466; Fri, 2 Jun 2006 13:01:26 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52D1P9l087465; Fri, 2 Jun 2006 13:01:25 GMT (envelope-from des) Message-Id: <200606021301.k52D1P9l087465@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Fri, 2 Jun 2006 13:01:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/linprocfs linprocfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 13:03:10 -0000 des 2006-06-02 13:01:25 UTC FreeBSD src repository Modified files: sys/compat/linprocfs linprocfs.c Log: As far as I can tell, the correct CPU family for amd64 (which Linux calls x86_64) is 15, not 6. MFC after: 3 weeks Revision Changes Path 1.94 +2 -2 src/sys/compat/linprocfs/linprocfs.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 13:20:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F39BE16A420; Fri, 2 Jun 2006 13:20:30 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B164143D46; Fri, 2 Jun 2006 13:20:30 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52DJ0Nd089426; Fri, 2 Jun 2006 13:19:00 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52DJ0VR089425; Fri, 2 Jun 2006 13:19:00 GMT (envelope-from pjd) Message-Id: <200606021319.k52DJ0VR089425@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 2 Jun 2006 13:18:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_event.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 13:20:49 -0000 pjd 2006-06-02 13:18:59 UTC FreeBSD src repository Modified files: sys/kern kern_event.c Log: Use SLIST_FOREACH_SAFE() macro, because knote_drop() can free an element which can be then used to find next element in the list. OK'ed by: jmg Revision Changes Path 1.100 +2 -2 src/sys/kern/kern_event.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 13:22:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2B43316A42B; Fri, 2 Jun 2006 13:22:54 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C413043D72; Fri, 2 Jun 2006 13:22:52 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52DLMAM089616; Fri, 2 Jun 2006 13:21:22 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52DLMVX089615; Fri, 2 Jun 2006 13:21:22 GMT (envelope-from pjd) Message-Id: <200606021321.k52DLMVX089615@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 2 Jun 2006 13:21:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_event.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 13:22:54 -0000 pjd 2006-06-02 13:21:22 UTC FreeBSD src repository Modified files: sys/kern kern_event.c Log: Remove confusing done_noglobal label. The KQ_GLOBAL_UNLOCK() macro know how to handle both situations - when kq_global lock is and is not held. OK'ed by: jmg Revision Changes Path 1.101 +1 -2 src/sys/kern/kern_event.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 13:25:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 16B1C16A42A; Fri, 2 Jun 2006 13:25:11 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B286643D49; Fri, 2 Jun 2006 13:25:10 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52DNe0Z089802; Fri, 2 Jun 2006 13:23:40 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52DNe5O089801; Fri, 2 Jun 2006 13:23:40 GMT (envelope-from pjd) Message-Id: <200606021323.k52DNe5O089801@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 2 Jun 2006 13:23:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_event.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 13:25:14 -0000 pjd 2006-06-02 13:23:40 UTC FreeBSD src repository Modified files: sys/kern kern_event.c Log: Don't forget to unlock kq lock in low memory situations. OK'ed by: jmg Revision Changes Path 1.102 +1 -0 src/sys/kern/kern_event.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 12:46:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 57DE516A576; Fri, 2 Jun 2006 12:46:00 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr2.xs4all.nl (smtp-vbr2.xs4all.nl [194.109.24.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A90143DAB; Fri, 2 Jun 2006 12:45:29 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr2.xs4all.nl (8.13.6/8.13.6) with ESMTP id k52CjFtF076620; Fri, 2 Jun 2006 14:45:16 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.6/8.13.3) with ESMTP id k52CjFcw007310; Fri, 2 Jun 2006 14:45:15 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.6/8.13.6/Submit) id k52CjDkK007305; Fri, 2 Jun 2006 14:45:13 +0200 (CEST) (envelope-from wb) Date: Fri, 2 Jun 2006 14:45:13 +0200 From: Wilko Bulte To: Tom Rhodes Message-ID: <20060602124513.GA7283@freebie.xs4all.nl> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601094950.GU21998@submonkey.net> <20060601100126.GA43737@FreeBSD.org> <200606010858.39417.jhb@freebsd.org> <20060602023102.J34761@delplex.bde.org> <20060602002459.GI80617@wantadilla.lemis.com> <20060602093829.GE23618@submonkey.net> <20060602102502.GF55506@wantadilla.lemis.com> <20060602063603.7c8e2d4d.trhodes@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060602063603.7c8e2d4d.trhodes@FreeBSD.org> User-Agent: Mutt/1.5.11 X-Virus-Scanned: by XS4ALL Virus Scanner X-Mailman-Approved-At: Fri, 02 Jun 2006 13:26:54 +0000 Cc: maxim@FreeBSD.ORG, danfe@FreeBSD.ORG, src-committers@FreeBSD.ORG, bde@zeta.org.au, jhb@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG, Greg 'groggy' Lehey , ceri@submonkey.net Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 12:46:01 -0000 On Fri, Jun 02, 2006 at 06:36:03AM -0400, Tom Rhodes wrote.. > On Fri, 2 Jun 2006 19:55:02 +0930 > "Greg 'groggy' Lehey" wrote: > > > On Friday, 2 June 2006 at 10:38:29 +0100, Ceri Davies wrote: > > > On Fri, Jun 02, 2006 at 09:54:59AM +0930, Greg 'groggy' Lehey wrote: > > >> On Friday, 2 June 2006 at 2:50:47 +1000, Bruce Evans wrote: > > >>> On Thu, 1 Jun 2006, John Baldwin wrote: > > >>> > > >>>> On Thursday 01 June 2006 06:01, Alexey Dokuchaev wrote: > > >>>>> On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: > > >>>>>> @@ -69,6 +69,10 @@ > > >>>>>> the file must be open for writing. > > >>>>>> .Sh RETURN VALUES > > >>>>>> .Rv -std > > >>>>>> +If the file to be modified is not a directory or > > >>>>>> +a regular file, the > > >>>>>> +.Fn truncate > > >>>>>> +call will return the value 0. > > >>>>> > > >>>>> Doesn't "value of 0" sound better? > > >>>> > > >>>> Not to me, though I can't explain why. I think the phrase "X will return > > >>>> the > > >>>> value Y" is common in man pages though. > > >>> > > >>> "will return" sounds strange to be. > > >> > > >> Yes, it will be better if you avoid the future tense. > > > > > > May I recommend that one of you just change it? > > > > What colour? > > Black. My answer would have to be black. Dull black I hope? Can't have it shiny. -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Fri Jun 2 13:56:23 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 866DB16A422; Fri, 2 Jun 2006 13:56:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 51B3443D60; Fri, 2 Jun 2006 13:56:17 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [131.106.58.208] (72-255-64-174.client.stsn.net [72.255.64.174]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k52Du2f7087699; Fri, 2 Jun 2006 09:56:04 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Greg 'groggy' Lehey" Date: Fri, 2 Jun 2006 09:26:13 -0400 User-Agent: KMail/1.9.1 References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060602093829.GE23618@submonkey.net> <20060602102502.GF55506@wantadilla.lemis.com> In-Reply-To: <20060602102502.GF55506@wantadilla.lemis.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606020926.14830.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1506/Fri Jun 2 00:01:20 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Maxim Konovalov , Alexey Dokuchaev , src-committers@freebsd.org, Bruce Evans , cvs-src@freebsd.org, cvs-all@freebsd.org, Ceri Davies Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 13:56:23 -0000 On Friday 02 June 2006 06:25, Greg 'groggy' Lehey wrote: > On Friday, 2 June 2006 at 10:38:29 +0100, Ceri Davies wrote: > > On Fri, Jun 02, 2006 at 09:54:59AM +0930, Greg 'groggy' Lehey wrote: > >> On Friday, 2 June 2006 at 2:50:47 +1000, Bruce Evans wrote: > >>> On Thu, 1 Jun 2006, John Baldwin wrote: > >>> > >>>> On Thursday 01 June 2006 06:01, Alexey Dokuchaev wrote: > >>>>> On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: > >>>>>> @@ -69,6 +69,10 @@ > >>>>>> the file must be open for writing. > >>>>>> .Sh RETURN VALUES > >>>>>> .Rv -std > >>>>>> +If the file to be modified is not a directory or > >>>>>> +a regular file, the > >>>>>> +.Fn truncate > >>>>>> +call will return the value 0. > >>>>> > >>>>> Doesn't "value of 0" sound better? > >>>> > >>>> Not to me, though I can't explain why. I think the phrase "X will return > >>>> the > >>>> value Y" is common in man pages though. > >>> > >>> "will return" sounds strange to be. > >> > >> Yes, it will be better if you avoid the future tense. > > > > May I recommend that one of you just change it? > > What colour? Shouldn't that be "Which colour?" or even "Which color?" *duck* -- John Baldwin From owner-cvs-src@FreeBSD.ORG Fri Jun 2 14:12:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6FB116A422; Fri, 2 Jun 2006 14:12:23 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 927D343D45; Fri, 2 Jun 2006 14:12:23 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52EAqFP093347; Fri, 2 Jun 2006 14:10:52 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52EAqvA093346; Fri, 2 Jun 2006 14:10:52 GMT (envelope-from glebius) Message-Id: <200606021410.k52EAqvA093346@repoman.freebsd.org> From: Gleb Smirnoff Date: Fri, 2 Jun 2006 14:10:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_gif.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 14:12:23 -0000 glebius 2006-06-02 14:10:52 UTC FreeBSD src repository Modified files: sys/net if_gif.c Log: Fix gif_output() so that GIF_UNLOCK() is performed only in case we have locked the softc. PR: kern/98298 Submitted by: Eugene Grosbein Revision Changes Path 1.59 +2 -2 src/sys/net/if_gif.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 14:22:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D09F916A420; Fri, 2 Jun 2006 14:22:51 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B48E43D53; Fri, 2 Jun 2006 14:22:51 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [IPv6:::1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k52EL4x7096002; Fri, 2 Jun 2006 08:21:04 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 02 Jun 2006 08:21:09 -0600 (MDT) Message-Id: <20060602.082109.58456160.imp@bsdimp.com> To: wb@freebie.xs4all.nl From: "M. Warner Losh" In-Reply-To: <20060602124513.GA7283@freebie.xs4all.nl> References: <20060602102502.GF55506@wantadilla.lemis.com> <20060602063603.7c8e2d4d.trhodes@FreeBSD.org> <20060602124513.GA7283@freebie.xs4all.nl> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 02 Jun 2006 14:47:57 +0000 Cc: maxim@FreeBSD.org, trhodes@FreeBSD.org, danfe@FreeBSD.org, src-committers@FreeBSD.org, bde@zeta.org.au, jhb@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, grog@FreeBSD.org, ceri@submonkey.net Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 14:22:51 -0000 In message: <20060602124513.GA7283@freebie.xs4all.nl> Wilko Bulte writes: : > > > May I recommend that one of you just change it? : > > : > > What colour? : > : > Black. My answer would have to be black. : : Dull black I hope? Can't have it shiny. Black on Black with a small black light that comes on when you press the black button that says please don't press this button. Warner From owner-cvs-src@FreeBSD.ORG Fri Jun 2 15:02:45 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC42216A51B; Fri, 2 Jun 2006 15:02:45 +0000 (UTC) (envelope-from motoyuki@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B66643D6E; Fri, 2 Jun 2006 15:02:42 +0000 (GMT) (envelope-from motoyuki@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52F1BYg095219; Fri, 2 Jun 2006 15:01:11 GMT (envelope-from motoyuki@repoman.freebsd.org) Received: (from motoyuki@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52F1BqW095218; Fri, 2 Jun 2006 15:01:11 GMT (envelope-from motoyuki) Message-Id: <200606021501.k52F1BqW095218@repoman.freebsd.org> From: Motoyuki Konno Date: Fri, 2 Jun 2006 15:01:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/examples/diskless clone_root X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 15:02:56 -0000 motoyuki 2006-06-02 15:01:11 UTC FreeBSD src repository Modified files: share/examples/diskless clone_root Log: doc fix: option MFS is obsolete. use MD_ROOT instead. PR: conf/93878 Revision Changes Path 1.4 +1 -1 src/share/examples/diskless/clone_root From owner-cvs-src@FreeBSD.ORG Fri Jun 2 15:06:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C5A8316A58F; Fri, 2 Jun 2006 15:06:11 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr8.xs4all.nl (smtp-vbr8.xs4all.nl [194.109.24.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45E7D43D62; Fri, 2 Jun 2006 15:06:10 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr8.xs4all.nl (8.13.6/8.13.6) with ESMTP id k52F5uuB081272; Fri, 2 Jun 2006 17:05:57 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.6/8.13.3) with ESMTP id k52F5uYb007996; Fri, 2 Jun 2006 17:05:56 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.6/8.13.6/Submit) id k52F5s5p007988; Fri, 2 Jun 2006 17:05:54 +0200 (CEST) (envelope-from wb) Date: Fri, 2 Jun 2006 17:05:54 +0200 From: Wilko Bulte To: "M. Warner Losh" Message-ID: <20060602150554.GA7975@freebie.xs4all.nl> References: <20060602102502.GF55506@wantadilla.lemis.com> <20060602063603.7c8e2d4d.trhodes@FreeBSD.org> <20060602124513.GA7283@freebie.xs4all.nl> <20060602.082109.58456160.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060602.082109.58456160.imp@bsdimp.com> User-Agent: Mutt/1.5.11 X-Virus-Scanned: by XS4ALL Virus Scanner X-Mailman-Approved-At: Fri, 02 Jun 2006 16:05:18 +0000 Cc: maxim@FreeBSD.org, trhodes@FreeBSD.org, danfe@FreeBSD.org, src-committers@FreeBSD.org, bde@zeta.org.au, jhb@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, grog@FreeBSD.org, ceri@submonkey.net Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 15:06:17 -0000 On Fri, Jun 02, 2006 at 08:21:09AM -0600, M. Warner Losh wrote.. > In message: <20060602124513.GA7283@freebie.xs4all.nl> > Wilko Bulte writes: > : > > > May I recommend that one of you just change it? > : > > > : > > What colour? > : > > : > Black. My answer would have to be black. > : > : Dull black I hope? Can't have it shiny. > > Black on Black with a small black light that comes on when you press > the black button that says please don't press this button. Exactly! -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Fri Jun 2 15:47:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 550CF16A41F; Fri, 2 Jun 2006 15:47:33 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 01F1D43D45; Fri, 2 Jun 2006 15:47:33 +0000 (GMT) (envelope-from linimon@lonesome.com) Received: by mail.soaustin.net (Postfix, from userid 502) id BADBE2F0E; Fri, 2 Jun 2006 10:47:32 -0500 (CDT) Date: Fri, 2 Jun 2006 10:47:31 -0500 To: Wilko Bulte Message-ID: <20060602154731.GC18607@soaustin.net> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060601094950.GU21998@submonkey.net> <20060601100126.GA43737@FreeBSD.org> <200606010858.39417.jhb@freebsd.org> <20060602023102.J34761@delplex.bde.org> <20060602002459.GI80617@wantadilla.lemis.com> <20060602093829.GE23618@submonkey.net> <20060602102502.GF55506@wantadilla.lemis.com> <20060602063603.7c8e2d4d.trhodes@FreeBSD.org> <20060602124513.GA7283@freebie.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060602124513.GA7283@freebie.xs4all.nl> User-Agent: Mutt/1.5.9i From: linimon@lonesome.com (Mark Linimon) X-Mailman-Approved-At: Fri, 02 Jun 2006 16:05:26 +0000 Cc: maxim@FreeBSD.ORG, Tom Rhodes , danfe@FreeBSD.ORG, src-committers@FreeBSD.ORG, bde@zeta.org.au, jhb@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG, Greg 'groggy' Lehey , ceri@submonkey.net Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 15:47:33 -0000 On Fri, Jun 02, 2006 at 02:45:13PM +0200, Wilko Bulte wrote: > Dull black I hope? Can't have it shiny. ooh! shiny! mcl From owner-cvs-src@FreeBSD.ORG Fri Jun 2 17:47:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BA1F16A434; Fri, 2 Jun 2006 17:47:20 +0000 (UTC) (envelope-from ambrisko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4A10243D46; Fri, 2 Jun 2006 17:47:20 +0000 (GMT) (envelope-from ambrisko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52Hjmv6013737; Fri, 2 Jun 2006 17:45:48 GMT (envelope-from ambrisko@repoman.freebsd.org) Received: (from ambrisko@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52Hjm8L013736; Fri, 2 Jun 2006 17:45:48 GMT (envelope-from ambrisko) Message-Id: <200606021745.k52Hjm8L013736@repoman.freebsd.org> From: Doug Ambrisko Date: Fri, 2 Jun 2006 17:45:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_aio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 17:47:20 -0000 ambrisko 2006-06-02 17:45:48 UTC FreeBSD src repository Modified files: sys/kern vfs_aio.c Log: Make lio ident more consistant with aio ident. Revision Changes Path 1.224 +1 -1 src/sys/kern/vfs_aio.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 17:55:18 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4579216A424; Fri, 2 Jun 2006 17:55:18 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0229343D45; Fri, 2 Jun 2006 17:55:18 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52HrkgE014084; Fri, 2 Jun 2006 17:53:46 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52HrkdU014083; Fri, 2 Jun 2006 17:53:46 GMT (envelope-from rodrigc) Message-Id: <200606021753.k52HrkdU014083@repoman.freebsd.org> From: Craig Rodrigues Date: Fri, 2 Jun 2006 17:53:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/mount mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 17:55:18 -0000 rodrigc 2006-06-02 17:53:46 UTC FreeBSD src repository Modified files: sbin/mount mount.c Log: Fix "mount -u -o ro". Requested by: maxim Revision Changes Path 1.85 +24 -1 src/sbin/mount/mount.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 18:52:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E011816A448; Fri, 2 Jun 2006 18:52:14 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 06AB543D78; Fri, 2 Jun 2006 18:52:11 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52IodIE017712; Fri, 2 Jun 2006 18:50:39 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52IodIQ017711; Fri, 2 Jun 2006 18:50:39 GMT (envelope-from mjacob) Message-Id: <200606021850.k52IodIQ017711@repoman.freebsd.org> From: Matt Jacob Date: Fri, 2 Jun 2006 18:50:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt.c mpt.h mpt_cam.c mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 18:52:24 -0000 mjacob 2006-06-02 18:50:39 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt.c mpt.h mpt_cam.c mpt_pci.c Log: More checkpointing on the way toward really (finally) fixing speed negotiation. Also fix the mpt_execute_req function to actually match mpt_execute_req_a64. This may explain why i386 users were having more grief. Revision Changes Path 1.31 +3 -0 src/sys/dev/mpt/mpt.c 1.23 +10 -2 src/sys/dev/mpt/mpt.h 1.22 +109 -108 src/sys/dev/mpt/mpt_cam.c 1.33 +1 -0 src/sys/dev/mpt/mpt_pci.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 19:02:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 068F816A427; Fri, 2 Jun 2006 19:02:56 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 562CA43D6E; Fri, 2 Jun 2006 19:02:53 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 3126D1A4EB5; Fri, 2 Jun 2006 12:02:53 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 9117451313; Fri, 2 Jun 2006 15:02:52 -0400 (EDT) Date: Fri, 2 Jun 2006 15:02:52 -0400 From: Kris Kennaway To: Ceri Davies , Kris Kennaway , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20060602190252.GA69363@xor.obsecurity.org> References: <200605311915.k4VJFKef060742@repoman.freebsd.org> <20060601012130.GA5066@xor.obsecurity.org> <20060601084127.GS21998@submonkey.net> <20060601151837.GA32439@xor.obsecurity.org> <20060602094051.GF23618@submonkey.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4Ckj6UjgE2iN1+kY" Content-Disposition: inline In-Reply-To: <20060602094051.GF23618@submonkey.net> User-Agent: Mutt/1.4.2.1i Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall installUpgrade.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 19:02:56 -0000 --4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 02, 2006 at 10:40:52AM +0100, Ceri Davies wrote: > On Thu, Jun 01, 2006 at 11:18:37AM -0400, Kris Kennaway wrote: > > On Thu, Jun 01, 2006 at 09:41:27AM +0100, Ceri Davies wrote: > > > On Wed, May 31, 2006 at 09:21:30PM -0400, Kris Kennaway wrote: > > > > On Wed, May 31, 2006 at 07:15:20PM +0000, Ceri Davies wrote: > > > > > ceri 2006-05-31 19:15:20 UTC > > > > >=20 > > > > > FreeBSD src repository > > > > >=20 > > > > > Modified files: > > > > > usr.sbin/sysinstall installUpgrade.c=20 > > > > > Log: > > > > > Update the location of the kernel for upgrades. > > > > > =20 > > > > > I considered leaving /boot/kernel out of the chflags noschg lin= e, but I > > > > > seem to remember that there was a period where /boot/kernel was= schg, so > > > > > have left it in for safety's sake. > > > >=20 > > > > Does this explain the user report I have that a binary upgrade from > > > > 6.0 to 6.1 did not update the kernel? > > >=20 > > > No, I don't think so. This is more to do with saving the old one for > > > saftey's sake; there's nothing in here that should have prevented his > > > old kernel from being committed to block limbo. > > >=20 > > > I'll dig around and see if I can see how that might have happened, bu= t I > > > can't think of anything off the top of my head. > >=20 > > Never mind, it was user error (they were trying to use an 6.0 CD to > > update to 6.1 by changing the release name). This is actually fairly > > common, so I wonder if a bit of text could be added saying not to do > > this. >=20 > Hmm. It's been a while since I tried that, but I remember that worked > (so long as you pointed it at the internets). What you're asking for is > that we check that the release name set in options matches the bits on > the CD if we're extracting from CD, right? I think he was using the CD to do an FTP install and manually changing the release name from 6.0 to 6.1. This tends to fail since the old release doesn't know all of the special steps that need to be done to update to the new version. In this case it didn't replace the kernel, maybe because it didn't know it was supposed to first chflags noschg it. Kris --4Ckj6UjgE2iN1+kY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEgItcWry0BWjoQKURAnikAKD3laP6ElYIARTvq+fmQknwRhRoFACcDER4 Gt9XnRIChmPNusC8GtORq/8= =HPaV -----END PGP SIGNATURE----- --4Ckj6UjgE2iN1+kY-- From owner-cvs-src@FreeBSD.ORG Fri Jun 2 19:16:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C31CF16A470; Fri, 2 Jun 2006 19:16:43 +0000 (UTC) (envelope-from ghelmer@palisadesys.com) Received: from magellan.palisadesys.com (magellan.palisadesys.com [192.188.162.211]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD23343D6D; Fri, 2 Jun 2006 19:16:35 +0000 (GMT) (envelope-from ghelmer@palisadesys.com) Received: from [192.188.162.240] (volans.palisadesys.com [192.188.162.240]) (authenticated bits=0) by magellan.palisadesys.com (8.13.4/8.13.4) with ESMTP id k52JGJCG039053 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 2 Jun 2006 14:16:22 -0500 (CDT) (envelope-from ghelmer@palisadesys.com) Message-ID: <44808E83.4070704@palisadesys.com> Date: Fri, 02 Jun 2006 14:16:19 -0500 From: Guy Helmer User-Agent: Thunderbird 1.5 (X11/20060207) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= References: <200605241403.k4OE3pvp007556@repoman.freebsd.org> <86y7wf20qy.fsf@xps.des.no> In-Reply-To: <86y7wf20qy.fsf@xps.des.no> X-Palisade-MailScanner-Information: Please contact the ISP for more information X-Palisade-MailScanner: Found to be clean X-Palisade-MailScanner-SpamCheck: not spam (whitelisted), SpamAssassin (score=-3.688, required 6, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -2.60, HTML_40_50 0.50, HTML_MESSAGE 0.00, HTML_TITLE_EMPTY 0.21) X-Palisade-MailScanner-From: ghelmer@palisadesys.com Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Guy Helmer , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/procfs procfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 19:16:44 -0000 Dag-Erling Smørgrav wrote: > Guy Helmer writes: > >> Log: >> Revision 1.4 set access for all sensitive files in /proc/ to mode 0 >> if a process's uid or gid has changed, but the /proc/ directory >> itself was also set to mode 0. Assuming this doesn't open any >> security holes, open access to the /proc/ directory for users >> other than root to read or search the directory. >> >> Reviewed by: des (back in February) >> MFC after: 3 weeks >> > > In hindsight, I think I prefer the attached (untested) solution... > > DES > After applying this patch, /proc//ctl is writable by the owner of a P_SUGID process: --w------- 1 ph ph 0 Jun 2 13:54 ctl (it used to be mode 000). Is that OK? It doesn't seem right to me... Guy From owner-cvs-src@FreeBSD.ORG Fri Jun 2 19:24:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBC2316A46F; Fri, 2 Jun 2006 19:24:52 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5BA8743D73; Fri, 2 Jun 2006 19:24:44 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52JNC7g020223; Fri, 2 Jun 2006 19:23:12 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52JNCo5020222; Fri, 2 Jun 2006 19:23:12 GMT (envelope-from mjacob) Message-Id: <200606021923.k52JNCo5020222@repoman.freebsd.org> From: Matt Jacob Date: Fri, 2 Jun 2006 19:23:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 19:24:59 -0000 mjacob 2006-06-02 19:23:12 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt.h Log: Make the code able to compile again in RELENG_4. Revision Changes Path 1.24 +1 -0 src/sys/dev/mpt/mpt.h From owner-cvs-src@FreeBSD.ORG Fri Jun 2 20:01:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 88EB616A4D8; Fri, 2 Jun 2006 20:01:05 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4341843D4C; Fri, 2 Jun 2006 20:01:05 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52JxXSC022149; Fri, 2 Jun 2006 19:59:33 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52JxXlr022148; Fri, 2 Jun 2006 19:59:33 GMT (envelope-from csjp) Message-Id: <200606021959.k52JxXlr022148@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Fri, 2 Jun 2006 19:59:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ath if_ath.c src/sys/dev/ipw if_ipw.c src/sys/dev/iwi if_iwi.c src/sys/dev/ral rt2560.c rt2661.c src/sys/dev/usb if_ural.c src/sys/dev/wi if_wi.c src/sys/net bpf.c bpf.h bpfdesc.h if_disc.c if_gif.c if_gre.c if_loop.c if_sl.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 20:01:07 -0000 csjp 2006-06-02 19:59:33 UTC FreeBSD src repository Modified files: sys/dev/ath if_ath.c sys/dev/ipw if_ipw.c sys/dev/iwi if_iwi.c sys/dev/ral rt2560.c rt2661.c sys/dev/usb if_ural.c sys/dev/wi if_wi.c sys/net bpf.c bpf.h bpfdesc.h if_disc.c if_gif.c if_gre.c if_loop.c if_sl.c if_stf.c if_tun.c sys/net80211 ieee80211_input.c sys/netinet ip_carp.c ip_gre.c Log: Fix the following bpf(4) race condition which can result in a panic: (1) bpf peer attaches to interface netif0 (2) Packet is received by netif0 (3) ifp->if_bpf pointer is checked and handed off to bpf (4) bpf peer detaches from netif0 resulting in ifp->if_bpf being initialized to NULL. (5) ifp->if_bpf is dereferenced by bpf machinery (6) Kaboom This race condition likely explains the various different kernel panics reported around sending SIGINT to tcpdump or dhclient processes. But really this race can result in kernel panics anywhere you have frequent bpf attach and detach operations with high packet per second load. Summary of changes: - Remove the bpf interface's "driverp" member - When we attach bpf interfaces, we now set the ifp->if_bpf member to the bpf interface structure. Once this is done, ifp->if_bpf should never be NULL. [1] - Introduce bpf_peers_present function, an inline operation which will do a lockless read bpf peer list associated with the interface. It should be noted that the bpf code will pickup the bpf_interface lock before adding or removing bpf peers. This should serialize the access to the bpf descriptor list, removing the race. - Expose the bpf_if structure in bpf.h so that the bpf_peers_present function can use it. This also removes the struct bpf_if; hack that was there. - Adjust all consumers of the raw if_bpf structure to use bpf_peers_present Now what happens is: (1) Packet is received by netif0 (2) Check to see if bpf descriptor list is empty (3) Pickup the bpf interface lock (4) Hand packet off to process From the attach/detach side: (1) Pickup the bpf interface lock (2) Add/remove from bpf descriptor list Now that we are storing the bpf interface structure with the ifnet, there is is no need to walk the bpf interface list to locate the correct bpf interface. We now simply look up the interface, and initialize the pointer. This has a nice side effect of changing a bpf interface attach operation from O(N) (where N is the number of bpf interfaces), to O(1). [1] From now on, we can no longer check ifp->if_bpf to tell us whether or not we have any bpf peers that might be interested in receiving packets. In collaboration with: sam@ MFC after: 1 month Revision Changes Path 1.145 +4 -3 src/sys/dev/ath/if_ath.c 1.20 +2 -2 src/sys/dev/ipw/if_ipw.c 1.37 +2 -2 src/sys/dev/iwi/if_iwi.c 1.5 +7 -7 src/sys/dev/ral/rt2560.c 1.6 +3 -3 src/sys/dev/ral/rt2661.c 1.39 +3 -3 src/sys/dev/usb/if_ural.c 1.196 +3 -3 src/sys/dev/wi/if_wi.c 1.166 +24 -71 src/sys/net/bpf.c 1.41 +22 -4 src/sys/net/bpf.h 1.34 +0 -13 src/sys/net/bpfdesc.h 1.52 +1 -1 src/sys/net/if_disc.c 1.60 +2 -4 src/sys/net/if_gif.c 1.42 +1 -1 src/sys/net/if_gre.c 1.109 +1 -1 src/sys/net/if_loop.c 1.132 +4 -4 src/sys/net/if_sl.c 1.54 +2 -2 src/sys/net/if_stf.c 1.155 +1 -1 src/sys/net/if_tun.c 1.91 +4 -4 src/sys/net80211/ieee80211_input.c 1.40 +1 -1 src/sys/netinet/ip_carp.c 1.24 +2 -2 src/sys/netinet/ip_gre.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 20:30:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C0F116A50E; Fri, 2 Jun 2006 20:30:34 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3809943D46; Fri, 2 Jun 2006 20:30:34 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52KT2UD024555; Fri, 2 Jun 2006 20:29:02 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52KT2el024554; Fri, 2 Jun 2006 20:29:02 GMT (envelope-from pjd) Message-Id: <200606022029.k52KT2el024554@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 2 Jun 2006 20:29:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 20:30:46 -0000 pjd 2006-06-02 20:29:02 UTC FreeBSD src repository Modified files: sys/kern vfs_mount.c Log: Fix a problem introduced in revision 1.220. On mount(2) failure, don't forget to unbusy file system before its destruction. This fixes the following warning on mount failure: Mount point had 1 dangling refs Tested by: wkoszek Revision Changes Path 1.226 +6 -5 src/sys/kern/vfs_mount.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 20:37:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC9A616A5B5; Fri, 2 Jun 2006 20:37:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DAF743D5F; Fri, 2 Jun 2006 20:37:11 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52KZdHF024928; Fri, 2 Jun 2006 20:35:39 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52KZdM1024927; Fri, 2 Jun 2006 20:35:39 GMT (envelope-from jhb) Message-Id: <200606022035.k52KZdM1024927@repoman.freebsd.org> From: John Baldwin Date: Fri, 2 Jun 2006 20:35:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_base.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 20:37:11 -0000 jhb 2006-06-02 20:35:39 UTC FreeBSD src repository Modified files: sys/netgraph ng_base.c Log: Conditionally acquire Giant in netgraph callouts to honor mpsafenet=0. Reported by: sekes MFC after: 1 week Revision Changes Path 1.123 +2 -0 src/sys/netgraph/ng_base.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 22:25:36 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 05ECA16A468; Fri, 2 Jun 2006 22:25:36 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [204.127.192.82]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B99443D45; Fri, 2 Jun 2006 22:25:35 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-24-147-19-128.hsd1.ma.comcast.net (c-71-233-168-2.hsd1.ma.comcast.net[71.233.168.2](misconfigured sender)) by comcast.net (rwcrmhc12) with ESMTP id <20060602222534m1200mans2e>; Fri, 2 Jun 2006 22:25:34 +0000 Received: from c-24-147-19-128.hsd1.ma.comcast.net (localhost [127.0.0.1]) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1) with ESMTP id k52MPaOr047930; Fri, 2 Jun 2006 18:25:36 -0400 (EDT) (envelope-from rodrigc@c-24-147-19-128.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1/Submit) id k52MPaEP047929; Fri, 2 Jun 2006 18:25:36 -0400 (EDT) (envelope-from rodrigc) Date: Fri, 2 Jun 2006 18:25:36 -0400 From: Craig Rodrigues To: Pawel Jakub Dawidek Message-ID: <20060602222536.GA45547@crodrigues.org> References: <200606022029.k52KT2el024554@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200606022029.k52KT2el024554@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 22:25:36 -0000 On Fri, Jun 02, 2006 at 08:29:02PM +0000, Pawel Jakub Dawidek wrote: > pjd 2006-06-02 20:29:02 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_mount.c > Log: > Fix a problem introduced in revision 1.220. On mount(2) failure, don't > forget to unbusy file system before its destruction. > > This fixes the following warning on mount failure: > > Mount point had 1 dangling refs > > Tested by: wkoszek > > Revision Changes Path > 1.226 +6 -5 src/sys/kern/vfs_mount.c Does this problem fix the slight delay that you get when doing a mount or update mount with a bad mount option? For example: mount -u -o nonexistentopt /mymount -- Craig Rodrigues rodrigc@crodrigues.org From owner-cvs-src@FreeBSD.ORG Fri Jun 2 23:16:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9014616A423; Fri, 2 Jun 2006 23:16:13 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4952643D48; Fri, 2 Jun 2006 23:16:13 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k52NEeQ1049218; Fri, 2 Jun 2006 23:14:40 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k52NEeVp049217; Fri, 2 Jun 2006 23:14:40 GMT (envelope-from sam) Message-Id: <200606022314.k52NEeVp049217@repoman.freebsd.org> From: Sam Leffler Date: Fri, 2 Jun 2006 23:14:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ath if_ath.c src/sys/dev/awi awi.c src/sys/dev/gem if_gem.c src/sys/dev/ipw if_ipw.c src/sys/dev/iwi if_iwi.c src/sys/dev/lmc if_lmc.h src/sys/dev/ral rt2661.c src/sys/dev/usb if_ural.c src/sys/net if_faith.c if_fwsubr.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 23:16:13 -0000 sam 2006-06-02 23:14:40 UTC FreeBSD src repository Modified files: sys/dev/ath if_ath.c sys/dev/awi awi.c sys/dev/gem if_gem.c sys/dev/ipw if_ipw.c sys/dev/iwi if_iwi.c sys/dev/lmc if_lmc.h sys/dev/ral rt2661.c sys/dev/usb if_ural.c sys/net if_faith.c if_fwsubr.c sys/netgraph ng_iface.c Log: add missed calls to bpf_peers_present Revision Changes Path 1.146 +1 -1 src/sys/dev/ath/if_ath.c 1.43 +2 -3 src/sys/dev/awi/awi.c 1.38 +1 -2 src/sys/dev/gem/if_gem.c 1.21 +1 -1 src/sys/dev/ipw/if_ipw.c 1.38 +1 -1 src/sys/dev/iwi/if_iwi.c 1.3 +1 -1 src/sys/dev/lmc/if_lmc.h 1.7 +2 -2 src/sys/dev/ral/rt2661.c 1.40 +2 -2 src/sys/dev/usb/if_ural.c 1.40 +1 -1 src/sys/net/if_faith.c 1.21 +2 -2 src/sys/net/if_fwsubr.c 1.47 +1 -1 src/sys/netgraph/ng_iface.c From owner-cvs-src@FreeBSD.ORG Fri Jun 2 23:18:30 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5227716A486; Fri, 2 Jun 2006 23:18:30 +0000 (UTC) (envelope-from erwin@mail.droso.net) Received: from mail.droso.net (koala.droso.net [193.88.12.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC11D43D46; Fri, 2 Jun 2006 23:18:23 +0000 (GMT) (envelope-from erwin@mail.droso.net) Received: by mail.droso.net (Postfix, from userid 1001) id 9C7B822C3B; Sat, 3 Jun 2006 01:18:22 +0200 (CEST) Date: Sat, 3 Jun 2006 01:18:22 +0200 From: Erwin Lansing To: John Baldwin Message-ID: <20060602231820.GV74938@droso.net> References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <20060602093829.GE23618@submonkey.net> <20060602102502.GF55506@wantadilla.lemis.com> <200606020926.14830.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Y+xroYBkGM9OatJL" Content-Disposition: inline In-Reply-To: <200606020926.14830.jhb@freebsd.org> X-Operating-System: FreeBSD/i386 5.4-RELEASE User-Agent: Mutt/1.5.11 Cc: Greg 'groggy' Lehey , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 23:18:30 -0000 --Y+xroYBkGM9OatJL Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 02, 2006 at 09:26:13AM -0400, John Baldwin wrote: > On Friday 02 June 2006 06:25, Greg 'groggy' Lehey wrote: > > On Friday, 2 June 2006 at 10:38:29 +0100, Ceri Davies wrote: > > > On Fri, Jun 02, 2006 at 09:54:59AM +0930, Greg 'groggy' Lehey wrote: > > >> On Friday, 2 June 2006 at 2:50:47 +1000, Bruce Evans wrote: > > >>> On Thu, 1 Jun 2006, John Baldwin wrote: > > >>> > > >>>> On Thursday 01 June 2006 06:01, Alexey Dokuchaev wrote: > > >>>>> On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: > > >>>>>> @@ -69,6 +69,10 @@ > > >>>>>> the file must be open for writing. > > >>>>>> .Sh RETURN VALUES > > >>>>>> .Rv -std > > >>>>>> +If the file to be modified is not a directory or > > >>>>>> +a regular file, the > > >>>>>> +.Fn truncate > > >>>>>> +call will return the value 0. > > >>>>> > > >>>>> Doesn't "value of 0" sound better? > > >>>> > > >>>> Not to me, though I can't explain why. I think the phrase "X will= =20 > return > > >>>> the > > >>>> value Y" is common in man pages though. > > >>> > > >>> "will return" sounds strange to be. > > >> > > >> Yes, it will be better if you avoid the future tense. > > > > > > May I recommend that one of you just change it? > >=20 > > What colour? >=20 > Shouldn't that be "Which colour?" or even "Which color?" *duck* >=20 That's a whole new shed. And definately a new tint! -erwin --=20 Erwin Lansing http://droso.org Security is like an onion. (o_ _o) It's made up of several layers \\\_\ /_/// erwin@FreeBSD.org And it makes you cry. <____) (____> erwin@aauug.dk --Y+xroYBkGM9OatJL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEgMc8qy9aWxUlaZARAgObAJ0f8UEXvtTBXYaEM4DJNJ8ATzMXnwCgpfll 4j318LPlWGHrXMT4FNqw1S4= =VGUA -----END PGP SIGNATURE----- --Y+xroYBkGM9OatJL-- From owner-cvs-src@FreeBSD.ORG Fri Jun 2 23:22:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA48F16A470 for ; Fri, 2 Jun 2006 23:22:17 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from ems01.seccuris.com (ems01.seccuris.com [204.112.0.35]) by mx1.FreeBSD.org (Postfix) with SMTP id 4447E43D55 for ; Fri, 2 Jun 2006 23:22:16 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: (qmail 4892 invoked by uid 86); 2 Jun 2006 23:48:09 -0000 Received: from unknown (HELO ?127.0.0.1?) (204.112.0.37) by ems01.seccuris.com with SMTP; 2 Jun 2006 23:48:09 -0000 Message-ID: <4480C827.9090607@FreeBSD.org> Date: Fri, 02 Jun 2006 18:22:15 -0500 From: "Christian S.J. Peron" User-Agent: Thunderbird 1.5.0.4 (Macintosh/20060530) MIME-Version: 1.0 To: Sam Leffler References: <200606022314.k52NEeVp049217@repoman.freebsd.org> In-Reply-To: <200606022314.k52NEeVp049217@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ath if_ath.c src/sys/dev/awi awi.c src/sys/dev/gem if_gem.c src/sys/dev/ipw if_ipw.c src/sys/dev/iwi if_iwi.c src/sys/dev/lmc if_lmc.h src/sys/dev/ral rt2661.c src/sys/dev/usb if_ural.c src/sys/net if_faith.c if_fwsubr.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 23:22:19 -0000 Sam Leffler wrote: > sam 2006-06-02 23:14:40 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ath if_ath.c > sys/dev/awi awi.c > sys/dev/gem if_gem.c > sys/dev/ipw if_ipw.c > sys/dev/iwi if_iwi.c > sys/dev/lmc if_lmc.h > sys/dev/ral rt2661.c > sys/dev/usb if_ural.c > sys/net if_faith.c if_fwsubr.c > sys/netgraph ng_iface.c > Log: > add missed calls to bpf_peers_present > > Revision Changes Path > 1.146 +1 -1 src/sys/dev/ath/if_ath.c > 1.43 +2 -3 src/sys/dev/awi/awi.c > 1.38 +1 -2 src/sys/dev/gem/if_gem.c > 1.21 +1 -1 src/sys/dev/ipw/if_ipw.c > 1.38 +1 -1 src/sys/dev/iwi/if_iwi.c > 1.3 +1 -1 src/sys/dev/lmc/if_lmc.h > 1.7 +2 -2 src/sys/dev/ral/rt2661.c > 1.40 +2 -2 src/sys/dev/usb/if_ural.c > 1.40 +1 -1 src/sys/net/if_faith.c > 1.21 +2 -2 src/sys/net/if_fwsubr.c > 1.47 +1 -1 src/sys/netgraph/ng_iface.c > > > Thanks! -- Christian S.J. Peron csjp@FreeBSD.ORG FreeBSD Committer FreeBSD Security Team From owner-cvs-src@FreeBSD.ORG Fri Jun 2 23:24:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0FCC816A41F; Fri, 2 Jun 2006 23:24:26 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD44443D68; Fri, 2 Jun 2006 23:24:21 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.199] ([10.0.0.199]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id k52NOK6s041305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 2 Jun 2006 16:24:21 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <4480C8A4.2020403@errno.com> Date: Fri, 02 Jun 2006 16:24:20 -0700 From: Sam Leffler Organization: Errno Consulting User-Agent: Thunderbird 1.5.0.4 (Macintosh/20060530) MIME-Version: 1.0 To: "Christian S.J. Peron" References: <200606021959.k52JxXlr022148@repoman.freebsd.org> In-Reply-To: <200606021959.k52JxXlr022148@repoman.freebsd.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ath if_ath.c src/sys/dev/ipw if_ipw.c src/sys/dev/iwi if_iwi.c src/sys/dev/ral rt2560.c rt2661.c src/sys/dev/usb if_ural.c src/sys/dev/wi if_wi.c src/sys/net bpf.c bpf.h bpfdesc.h if_disc.c if_gif.c if_gre.c if_loop.c if_sl.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 23:24:32 -0000 For the record we can eliminate the indirect ref through if_bpf if we embed the structure in the ifnet. For ifnet's that hookup to bpf this is a no-cost improvement. The downside is that ifnet's that don't work with bpf incur the overhead for the structure despite not using it. We decided to do this change separately in case anyone has an argument against it. Comments? Sam From owner-cvs-src@FreeBSD.ORG Fri Jun 2 23:30:24 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4D9216A5AF; Fri, 2 Jun 2006 23:30:24 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from pittgoth.com (ns1.pittgoth.com [216.38.206.188]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4491643D45; Fri, 2 Jun 2006 23:30:24 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from localhost (net-ix.gw.ai.net [205.134.160.6] (may be forged)) (authenticated bits=0) by pittgoth.com (8.13.4/8.13.4) with ESMTP id k530e5xf070884 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 2 Jun 2006 20:40:05 -0400 (EDT) (envelope-from trhodes@FreeBSD.org) Date: Fri, 2 Jun 2006 19:29:58 -0400 From: Tom Rhodes To: Wilko Bulte Message-Id: <20060602192958.38a711f9.trhodes@FreeBSD.org> In-Reply-To: <20060602150554.GA7975@freebie.xs4all.nl> References: <20060602102502.GF55506@wantadilla.lemis.com> <20060602063603.7c8e2d4d.trhodes@FreeBSD.org> <20060602124513.GA7283@freebie.xs4all.nl> <20060602.082109.58456160.imp@bsdimp.com> <20060602150554.GA7975@freebie.xs4all.nl> X-Mailer: Sylpheed version 1.0.6 (GTK+ 1.2.10; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 02 Jun 2006 23:31:34 +0000 Cc: maxim@FreeBSD.org, danfe@FreeBSD.org, src-committers@FreeBSD.org, jhb@FreeBSD.org, bde@zeta.org.au, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, grog@FreeBSD.org, ceri@submonkey.net, imp@bsdimp.com Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 23:30:24 -0000 On Fri, 2 Jun 2006 17:05:54 +0200 Wilko Bulte wrote: > On Fri, Jun 02, 2006 at 08:21:09AM -0600, M. Warner Losh wrote.. > > In message: <20060602124513.GA7283@freebie.xs4all.nl> > > Wilko Bulte writes: > > : > > > May I recommend that one of you just change it? > > : > > > > : > > What colour? > > : > > > : > Black. My answer would have to be black. > > : > > : Dull black I hope? Can't have it shiny. > > > > Black on Black with a small black light that comes on when you press > > the black button that says please don't press this button. > > Exactly! > As black as the deep, dark depths of my soul ... or something. Ok, time to go and watch goth talk[1]. [1]: Goth Talk was a kind of joke skit from the American SNL (Saturday Night Live) and done in the 80s or 90s or whatever. They basically did "good" satire of the losers in the scene. -- Tom Rhodes From owner-cvs-src@FreeBSD.ORG Fri Jun 2 23:58:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BADC16A422; Fri, 2 Jun 2006 23:58:15 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7413C43D45; Fri, 2 Jun 2006 23:58:13 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 1FD6351389; Sat, 3 Jun 2006 01:58:12 +0200 (CEST) Received: from localhost (unknown [10.1.0.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 3E07D51387; Sat, 3 Jun 2006 01:58:06 +0200 (CEST) Date: Sat, 3 Jun 2006 01:55:55 +0200 From: Pawel Jakub Dawidek To: Craig Rodrigues Message-ID: <20060602235555.GA55243@garage.freebsd.pl> References: <200606022029.k52KT2el024554@repoman.freebsd.org> <20060602222536.GA45547@crodrigues.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3MwIy2ne0vdjdPXF" Content-Disposition: inline In-Reply-To: <20060602222536.GA45547@crodrigues.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 23:58:15 -0000 --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 02, 2006 at 06:25:36PM -0400, Craig Rodrigues wrote: +> On Fri, Jun 02, 2006 at 08:29:02PM +0000, Pawel Jakub Dawidek wrote: +> > pjd 2006-06-02 20:29:02 UTC +> >=20 +> > FreeBSD src repository +> >=20 +> > Modified files: +> > sys/kern vfs_mount.c=20 +> > Log: +> > Fix a problem introduced in revision 1.220. On mount(2) failure, don= 't +> > forget to unbusy file system before its destruction. +> > =20 +> > This fixes the following warning on mount failure: +> > =20 +> > Mount point had 1 dangling refs +> > =20 +> > Tested by: wkoszek +> > =20 +> > Revision Changes Path +> > 1.226 +6 -5 src/sys/kern/vfs_mount.c +>=20 +>=20 +> Does this problem fix the slight delay that you get when +> doing a mount or update mount with a bad mount option? +>=20 +> For example: +>=20 +> mount -u -o nonexistentopt /mymount Yes, vfs_mount_destroy() waits 3 seconds if there is a dangling reference. Now there is no such reference when the function is called. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --3MwIy2ne0vdjdPXF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFEgNALForvXbEpPzQRAupyAKDXXTCFmPE0syUVzT7F5+/iVvNZcgCgj6wh WjxNns7KoFDETtqH0q30RLY= =8/Z2 -----END PGP SIGNATURE----- --3MwIy2ne0vdjdPXF-- From owner-cvs-src@FreeBSD.ORG Sat Jun 3 00:21:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 64D9B16A468; Sat, 3 Jun 2006 00:21:13 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2343543D45; Sat, 3 Jun 2006 00:21:13 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k530JeS5052963; Sat, 3 Jun 2006 00:19:40 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k530JeN7052962; Sat, 3 Jun 2006 00:19:40 GMT (envelope-from davidxu) Message-Id: <200606030019.k530JeN7052962@repoman.freebsd.org> From: David Xu Date: Sat, 3 Jun 2006 00:19:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libthr/thread thr_private.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 00:21:13 -0000 davidxu 2006-06-03 00:19:40 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_private.h Log: Remove unused member. Revision Changes Path 1.65 +0 -1 src/lib/libthr/thread/thr_private.h From owner-cvs-src@FreeBSD.ORG Sat Jun 3 01:53:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7192316A479; Sat, 3 Jun 2006 01:53:47 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D57643D48; Sat, 3 Jun 2006 01:53:45 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k531qC5u065628; Sat, 3 Jun 2006 01:52:12 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k531qCKG065627; Sat, 3 Jun 2006 01:52:12 GMT (envelope-from scottl) Message-Id: <200606030152.k531qCKG065627@repoman.freebsd.org> From: Scott Long Date: Sat, 3 Jun 2006 01:52:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src MAINTAINERS X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 01:53:51 -0000 scottl 2006-06-03 01:52:12 UTC FreeBSD src repository Modified files: . MAINTAINERS Log: Remove stale entries. Revision Changes Path 1.135 +0 -8 src/MAINTAINERS From owner-cvs-src@FreeBSD.ORG Sat Jun 3 04:34:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E40716A420; Sat, 3 Jun 2006 04:34:05 +0000 (UTC) (envelope-from benno@FreeBSD.org) Received: from mail.jeamland.net (rafe.jeamland.net [202.45.126.103]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3EDF43D45; Sat, 3 Jun 2006 04:34:04 +0000 (GMT) (envelope-from benno@FreeBSD.org) Received: from mail.jeamland.net (localhost [127.0.0.1]) by mail.jeamland.net (Postfix) with ESMTP id 7562C1CD32; Sat, 3 Jun 2006 14:34:01 +1000 (EST) Received: from [10.2.3.17] (ppp71-73.lns1.mel4.internode.on.net [59.167.71.73]) by mail.jeamland.net (Postfix) with ESMTP id 6D8381CD60; Sat, 3 Jun 2006 14:33:56 +1000 (EST) Message-ID: <4481112F.5080807@FreeBSD.org> Date: Sat, 03 Jun 2006 14:33:51 +1000 From: Benno Rice User-Agent: Thunderbird 1.5.0.2 (Macintosh/20060308) MIME-Version: 1.0 To: "Christian S.J. Peron" References: <200606021959.k52JxXlr022148@repoman.freebsd.org> In-Reply-To: <200606021959.k52JxXlr022148@repoman.freebsd.org> Content-Type: multipart/mixed; boundary="------------030502080208070809030700" X-Virus-Scanned: ClamAV using ClamSMTP at rafe.jeamland.net Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ath if_ath.c src/sys/dev/ipw if_ipw.c src/sys/dev/iwi if_iwi.c src/sys/dev/ral rt2560.c rt2661.c src/sys/dev/usb if_ural.c src/sys/dev/wi if_wi.c src/sys/net bpf.c bpf.h bpfdesc.h if_disc.c if_gif.c if_gre.c if_loop.c if_sl.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 04:34:05 -0000 This is a multi-part message in MIME format. --------------030502080208070809030700 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Christian S.J. Peron wrote: [snip] > Log: > Fix the following bpf(4) race condition which can result in a panic: [snip] This change causes panics in kernels that don't have device bpf present. The attached patch fixes this. -- Benno Rice benno@FreeBSD.org --------------030502080208070809030700 Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0"; name="bpf.h.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="bpf.h.diff" Index: bpf.h =================================================================== RCS file: /home/ncvs/src/sys/net/bpf.h,v retrieving revision 1.41 diff -u -r1.41 bpf.h --- bpf.h 2 Jun 2006 19:59:32 -0000 1.41 +++ bpf.h 3 Jun 2006 04:31:10 -0000 @@ -630,7 +630,11 @@ bpf_peers_present(struct bpf_if *bpf) { +#if defined(DEV_BPF) || defined(NETGRAPH_BPF) return !LIST_EMPTY(&bpf->bif_dlist); +#else + return (0); +#endif } #define BPF_TAP(_ifp,_pkt,_pktlen) do { \ --------------030502080208070809030700-- From owner-cvs-src@FreeBSD.ORG Sat Jun 3 06:38:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DFC9F16A421; Sat, 3 Jun 2006 06:38:34 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D0A243D46; Sat, 3 Jun 2006 06:38:34 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k536b0tG090866; Sat, 3 Jun 2006 06:37:00 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k536b0lr090865; Sat, 3 Jun 2006 06:37:00 GMT (envelope-from csjp) Message-Id: <200606030637.k536b0lr090865@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Sat, 3 Jun 2006 06:37:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net bpf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 06:38:35 -0000 csjp 2006-06-03 06:37:00 UTC FreeBSD src repository Modified files: sys/net bpf.h Log: Make sure we don't try to dereference the the if_bpf pointer when bpf has not been compiled into the the kernel. Submitted by: benno Revision Changes Path 1.42 +5 -1 src/sys/net/bpf.h From owner-cvs-src@FreeBSD.ORG Sat Jun 3 06:48:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 20DE016A46A for ; Sat, 3 Jun 2006 06:48:17 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from ems01.seccuris.com (ems01.seccuris.com [204.112.0.35]) by mx1.FreeBSD.org (Postfix) with SMTP id A212143D46 for ; Sat, 3 Jun 2006 06:48:15 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: (qmail 22419 invoked by uid 86); 3 Jun 2006 07:14:17 -0000 Received: from unknown (HELO ?127.0.0.1?) (204.112.0.37) by ems01.seccuris.com with SMTP; 3 Jun 2006 07:14:17 -0000 Message-ID: <448130AD.4080705@FreeBSD.org> Date: Sat, 03 Jun 2006 01:48:13 -0500 From: "Christian S.J. Peron" User-Agent: Thunderbird 1.5.0.4 (Macintosh/20060530) MIME-Version: 1.0 To: Benno Rice References: <200606021959.k52JxXlr022148@repoman.freebsd.org> <4481112F.5080807@FreeBSD.org> In-Reply-To: <4481112F.5080807@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ath if_ath.c src/sys/dev/ipw if_ipw.c src/sys/dev/iwi if_iwi.c src/sys/dev/ral rt2560.c rt2661.c src/sys/dev/usb if_ural.c src/sys/dev/wi if_wi.c src/sys/net bpf.c bpf.h bpfdesc.h if_disc.c if_gif.c if_gre.c if_loop.c if_sl.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 06:48:17 -0000 Committed, thanks. Benno Rice wrote: > Christian S.J. Peron wrote: > > [snip] > >> Log: >> Fix the following bpf(4) race condition which can result in a panic: > > [snip] > > This change causes panics in kernels that don't have device bpf present. > The attached patch fixes this. > > ------------------------------------------------------------------------ > > Index: bpf.h > =================================================================== > RCS file: /home/ncvs/src/sys/net/bpf.h,v > retrieving revision 1.41 > diff -u -r1.41 bpf.h > --- bpf.h 2 Jun 2006 19:59:32 -0000 1.41 > +++ bpf.h 3 Jun 2006 04:31:10 -0000 > @@ -630,7 +630,11 @@ > bpf_peers_present(struct bpf_if *bpf) > { > > +#if defined(DEV_BPF) || defined(NETGRAPH_BPF) > return !LIST_EMPTY(&bpf->bif_dlist); > +#else > + return (0); > +#endif > } > > #define BPF_TAP(_ifp,_pkt,_pktlen) do { \ > -- Christian S.J. Peron csjp@FreeBSD.ORG FreeBSD Committer FreeBSD Security Team From owner-cvs-src@FreeBSD.ORG Sat Jun 3 07:21:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9649816A420; Sat, 3 Jun 2006 07:21:19 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5354043D48; Sat, 3 Jun 2006 07:21:19 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k537Jjbs093654; Sat, 3 Jun 2006 07:19:45 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k537JjfL093653; Sat, 3 Jun 2006 07:19:45 GMT (envelope-from mjacob) Message-Id: <200606030719.k537JjfL093653@repoman.freebsd.org> From: Matt Jacob Date: Sat, 3 Jun 2006 07:19:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp_freebsd.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 07:21:19 -0000 mjacob 2006-06-03 07:19:45 UTC FreeBSD src repository Modified files: sys/dev/isp isp_freebsd.h Log: allow this to compile cleanly under RELENG_4 Revision Changes Path 1.90 +3 -0 src/sys/dev/isp/isp_freebsd.h From owner-cvs-src@FreeBSD.ORG Sat Jun 3 07:21:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D83416A59D; Sat, 3 Jun 2006 07:21:38 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A0DD43D48; Sat, 3 Jun 2006 07:21:38 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k537K4xm093715; Sat, 3 Jun 2006 07:20:04 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k537K4CC093714; Sat, 3 Jun 2006 07:20:04 GMT (envelope-from mjacob) Message-Id: <200606030720.k537K4CC093714@repoman.freebsd.org> From: Matt Jacob Date: Sat, 3 Jun 2006 07:20:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/isp isp_freebsd.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 07:21:38 -0000 mjacob 2006-06-03 07:20:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/isp isp_freebsd.h Log: MFC: allow this to compile cleanly under RELENG_4 Revision Changes Path 1.79.2.5 +3 -0 src/sys/dev/isp/isp_freebsd.h From owner-cvs-src@FreeBSD.ORG Sat Jun 3 07:21:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0907616A535; Sat, 3 Jun 2006 07:21:52 +0000 (UTC) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B41FE43D48; Sat, 3 Jun 2006 07:21:51 +0000 (GMT) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k537KH3A093769; Sat, 3 Jun 2006 07:20:17 GMT (envelope-from krion@repoman.freebsd.org) Received: (from krion@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k537KHA1093768; Sat, 3 Jun 2006 07:20:17 GMT (envelope-from krion) Message-Id: <200606030720.k537KHA1093768@repoman.freebsd.org> From: Kirill Ponomarew Date: Sat, 3 Jun 2006 07:20:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/sed process.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 07:21:52 -0000 krion 2006-06-03 07:20:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/sed process.c Log: MFC: process.c: 1.40 date: 2006/05/27 19:32:28; author: krion; state: Exp; lines: +1 -2 Fix using "P" command on empty pattern space. If the "P" command is used once on a non-empty pattern space and then again on an empty pattern space, the second usage restores the pattern space length to the length that it had when the first "P" was used. PR: bin/96052 Submitted by: Andrey Zholos Revision Changes Path 1.39.2.1 +1 -2 src/usr.bin/sed/process.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 07:22:18 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA1D016A492; Sat, 3 Jun 2006 07:22:18 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 96E8543D48; Sat, 3 Jun 2006 07:22:18 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k537KigC093803; Sat, 3 Jun 2006 07:20:44 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k537KiTJ093802; Sat, 3 Jun 2006 07:20:44 GMT (envelope-from mjacob) Message-Id: <200606030720.k537KiTJ093802@repoman.freebsd.org> From: Matt Jacob Date: Sat, 3 Jun 2006 07:20:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/dev/isp isp_freebsd.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 07:22:19 -0000 mjacob 2006-06-03 07:20:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/dev/isp isp_freebsd.h Log: MFC: allow this to compile cleanly under RELENG_4 Revision Changes Path 1.75.2.6 +3 -0 src/sys/dev/isp/isp_freebsd.h From owner-cvs-src@FreeBSD.ORG Sat Jun 3 07:22:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D0EB16A4A9; Sat, 3 Jun 2006 07:22:43 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 399D143D46; Sat, 3 Jun 2006 07:22:43 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k537L9Kg093851; Sat, 3 Jun 2006 07:21:09 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k537L94v093850; Sat, 3 Jun 2006 07:21:09 GMT (envelope-from mjacob) Message-Id: <200606030721.k537L94v093850@repoman.freebsd.org> From: Matt Jacob Date: Sat, 3 Jun 2006 07:21:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/sys/dev/isp isp_freebsd.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 07:22:43 -0000 mjacob 2006-06-03 07:21:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/isp isp_freebsd.h Log: MFC: allow this to compile cleanly under RELENG_4 Revision Changes Path 1.26.2.19 +3 -0 src/sys/dev/isp/isp_freebsd.h From owner-cvs-src@FreeBSD.ORG Sat Jun 3 09:09:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C6F5B16A477; Sat, 3 Jun 2006 09:09:21 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-0-0-cust107.cdif.cable.ntl.com [81.104.168.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2918C43D48; Sat, 3 Jun 2006 09:09:20 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.62 (FreeBSD)) (envelope-from ) id 1FmS8F-000PRx-A0; Sat, 03 Jun 2006 10:09:19 +0100 Date: Sat, 3 Jun 2006 10:09:19 +0100 From: Ceri Davies To: Kris Kennaway Message-ID: <20060603090919.GO23618@submonkey.net> Mail-Followup-To: Ceri Davies , Kris Kennaway , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200605311915.k4VJFKef060742@repoman.freebsd.org> <20060601012130.GA5066@xor.obsecurity.org> <20060601084127.GS21998@submonkey.net> <20060601151837.GA32439@xor.obsecurity.org> <20060602094051.GF23618@submonkey.net> <20060602190252.GA69363@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LZFKeWUZP29EKQNE" Content-Disposition: inline In-Reply-To: <20060602190252.GA69363@xor.obsecurity.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.11 Sender: Ceri Davies Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall installUpgrade.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 09:09:27 -0000 --LZFKeWUZP29EKQNE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 02, 2006 at 03:02:52PM -0400, Kris Kennaway wrote: > On Fri, Jun 02, 2006 at 10:40:52AM +0100, Ceri Davies wrote: > > On Thu, Jun 01, 2006 at 11:18:37AM -0400, Kris Kennaway wrote: > > > On Thu, Jun 01, 2006 at 09:41:27AM +0100, Ceri Davies wrote: > > > > On Wed, May 31, 2006 at 09:21:30PM -0400, Kris Kennaway wrote: > > > > > On Wed, May 31, 2006 at 07:15:20PM +0000, Ceri Davies wrote: > > > > > > ceri 2006-05-31 19:15:20 UTC > > > > > >=20 > > > > > > FreeBSD src repository > > > > > >=20 > > > > > > Modified files: > > > > > > usr.sbin/sysinstall installUpgrade.c=20 > > > > > > Log: > > > > > > Update the location of the kernel for upgrades. > > > > > > =20 > > > > > > I considered leaving /boot/kernel out of the chflags noschg l= ine, but I > > > > > > seem to remember that there was a period where /boot/kernel w= as schg, so > > > > > > have left it in for safety's sake. > > > > >=20 > > > > > Does this explain the user report I have that a binary upgrade fr= om > > > > > 6.0 to 6.1 did not update the kernel? > > > >=20 > > > > No, I don't think so. This is more to do with saving the old one f= or > > > > saftey's sake; there's nothing in here that should have prevented h= is > > > > old kernel from being committed to block limbo. > > > >=20 > > > > I'll dig around and see if I can see how that might have happened, = but I > > > > can't think of anything off the top of my head. > > >=20 > > > Never mind, it was user error (they were trying to use an 6.0 CD to > > > update to 6.1 by changing the release name). This is actually fairly > > > common, so I wonder if a bit of text could be added saying not to do > > > this. > >=20 > > Hmm. It's been a while since I tried that, but I remember that worked > > (so long as you pointed it at the internets). What you're asking for is > > that we check that the release name set in options matches the bits on > > the CD if we're extracting from CD, right? >=20 > I think he was using the CD to do an FTP install and manually changing > the release name from 6.0 to 6.1. This tends to fail since the old > release doesn't know all of the special steps that need to be done to > update to the new version. In this case it didn't replace the kernel, > maybe because it didn't know it was supposed to first chflags noschg > it. I'll mess about and try to reproduce it, thanks. Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --LZFKeWUZP29EKQNE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEgVG/ocfcwTS3JF8RAsDLAJwNTkxXA7B85Rn7JGomw3Yo/Tb2EACgiZwo itwjbYSkbnYQP/c80O3OBkM= =Mmh2 -----END PGP SIGNATURE----- --LZFKeWUZP29EKQNE-- From owner-cvs-src@FreeBSD.ORG Sat Jun 3 10:39:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E10116A479; Sat, 3 Jun 2006 10:39:17 +0000 (UTC) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2AF8543D45; Sat, 3 Jun 2006 10:39:17 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53AbgQS014428; Sat, 3 Jun 2006 10:37:42 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53AbgHh014427; Sat, 3 Jun 2006 10:37:42 GMT (envelope-from iedowse) Message-Id: <200606031037.k53AbgHh014427@repoman.freebsd.org> From: Ian Dowse Date: Sat, 3 Jun 2006 10:37:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb ugen.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 10:39:17 -0000 iedowse 2006-06-03 10:37:42 UTC FreeBSD src repository Modified files: sys/dev/usb ugen.c Log: Allow zero-length read/write operations to get through to the hardware. Also set both the read and write timeouts from the USB_SET_TIMEOUT ioctl. Revision Changes Path 1.105 +12 -5 src/sys/dev/usb/ugen.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 15:06:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C779416A484; Sat, 3 Jun 2006 15:06:30 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B47843D45; Sat, 3 Jun 2006 15:06:30 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id k53F6Tam044817 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 3 Jun 2006 08:06:30 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <4481A575.4020306@errno.com> Date: Sat, 03 Jun 2006 08:06:29 -0700 From: Sam Leffler User-Agent: Thunderbird 1.5.0.2 (X11/20060508) MIME-Version: 1.0 To: "Christian S.J. Peron" References: <200606030637.k536b0lr090865@repoman.freebsd.org> In-Reply-To: <200606030637.k536b0lr090865@repoman.freebsd.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net bpf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 15:06:35 -0000 Christian S.J. Peron wrote: > csjp 2006-06-03 06:37:00 UTC > > FreeBSD src repository > > Modified files: > sys/net bpf.h > Log: > Make sure we don't try to dereference the the if_bpf pointer when bpf has > not been compiled into the the kernel. > > Submitted by: benno Another option that avoids #ifdef's in bpf.h is to point all if_bpf's at a static structure that's initialized s.t. the list pointer is null. OTOH if we embed the data structure in the ifnet then in the no bpf config case the stub bpfattach code would just initialize the list head and again there'd be no issue. I think we can actually make bpf a loadable module now that bpf_if is exposed; I'll look at that. That should eliminate all these hacks we've been carrying around. Sam From owner-cvs-src@FreeBSD.ORG Sat Jun 3 15:39:45 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E073516A476; Sat, 3 Jun 2006 15:39:45 +0000 (UTC) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E53CD43D66; Sat, 3 Jun 2006 15:39:43 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53Fc8T3047193; Sat, 3 Jun 2006 15:38:08 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53Fc89J047192; Sat, 3 Jun 2006 15:38:08 GMT (envelope-from stefanf) Message-Id: <200606031538.k53Fc89J047192@repoman.freebsd.org> From: Stefan Farfeleder Date: Sat, 3 Jun 2006 15:38:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/bin/sh builtins.def eval.c exec.c exec.h input.c main.c mkbuiltins options.c sh.1 var.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 15:39:46 -0000 stefanf 2006-06-03 15:38:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) bin/sh builtins.def eval.c exec.c exec.h input.c main.c mkbuiltins options.c sh.1 var.c Log: MFC: - POSIX special built-ins (builtin.defs 1.19, main.c 1.28, mkbuiltins 1.16, eval.c 1.51, exec.c 1.29, exec.h 1.15, options.c 1.25) - Fix el_gets() buffer handling (input.c 1.23). - Sort 'set' output (var.c 1.31). - Document that '#' starts a comment (sh.1 1.118). Revision Changes Path 1.15.2.2 +22 -20 src/bin/sh/builtins.def 1.42.8.3 +9 -13 src/bin/sh/eval.c 1.25.2.2 +11 -4 src/bin/sh/exec.c 1.12.8.2 +2 -1 src/bin/sh/exec.h 1.22.8.1 +13 -4 src/bin/sh/input.c 1.26.8.1 +10 -8 src/bin/sh/main.c 1.14.2.2 +8 -2 src/bin/sh/mkbuiltins 1.23.2.2 +1 -1 src/bin/sh/options.c 1.102.2.3 +7 -0 src/bin/sh/sh.1 1.27.2.2 +47 -9 src/bin/sh/var.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 16:45:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A9F5816A474; Sat, 3 Jun 2006 16:45:10 +0000 (UTC) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F1D543D48; Sat, 3 Jun 2006 16:45:10 +0000 (GMT) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53GhYe5051508; Sat, 3 Jun 2006 16:43:34 GMT (envelope-from kan@repoman.freebsd.org) Received: (from kan@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53GhYHn051503; Sat, 3 Jun 2006 16:43:34 GMT (envelope-from kan) Message-Id: <200606031643.k53GhYHn051503@repoman.freebsd.org> From: Alexander Kabaev Date: Sat, 3 Jun 2006 16:43:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 16:45:10 -0000 kan 2006-06-03 16:43:34 UTC FreeBSD src repository Modified files: . access Log: Welcome Kostik Belousov to the ranks of src committers. Kostik has been tricked into working on various VFS issues and will be bringing in his patch for Giant-less UFS quotas shortly. kan and pjd will be his mentors. Approved by: core Revision Changes Path 1.776 +1 -0 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Sat Jun 3 18:18:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC86316A52B; Sat, 3 Jun 2006 18:18:30 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8886A43D46; Sat, 3 Jun 2006 18:18:30 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53IGsNY069106; Sat, 3 Jun 2006 18:16:54 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53IGsn0069105; Sat, 3 Jun 2006 18:16:54 GMT (envelope-from csjp) Message-Id: <200606031816.k53IGsn0069105@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Sat, 3 Jun 2006 18:16:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net bpf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 18:18:32 -0000 csjp 2006-06-03 18:16:54 UTC FreeBSD src repository Modified files: sys/net bpf.h Log: Temporarily include files so that our macro checks do something useful. Revision Changes Path 1.43 +3 -0 src/sys/net/bpf.h From owner-cvs-src@FreeBSD.ORG Sat Jun 3 18:49:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B4CE16A46F; Sat, 3 Jun 2006 18:49:50 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 47C4B43D45; Sat, 3 Jun 2006 18:49:50 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53ImEBN074117; Sat, 3 Jun 2006 18:48:14 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53ImE44074116; Sat, 3 Jun 2006 18:48:14 GMT (envelope-from csjp) Message-Id: <200606031848.k53ImE44074116@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Sat, 3 Jun 2006 18:48:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net bpf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 18:49:50 -0000 csjp 2006-06-03 18:48:14 UTC FreeBSD src repository Modified files: sys/net bpf.h Log: Back out previous two commits, this caused some problems in the namespace resulting in some build failures. Instead, to fix the problem of bpf not being present, check the pointer before dereferencing it. This is a temporary bandaid until we can decide on how we want to handle the bpf code not being present. This will be fixed shortly. Revision Changes Path 1.44 +2 -7 src/sys/net/bpf.h From owner-cvs-src@FreeBSD.ORG Sat Jun 3 18:59:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 25B1716A46F; Sat, 3 Jun 2006 18:59:05 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5D3C43D45; Sat, 3 Jun 2006 18:59:04 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53IvSa2075801; Sat, 3 Jun 2006 18:57:28 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53IvSvC075800; Sat, 3 Jun 2006 18:57:28 GMT (envelope-from imp) Message-Id: <200606031857.k53IvSvC075800@repoman.freebsd.org> From: Warner Losh Date: Sat, 3 Jun 2006 18:57:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccbb pccbb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 18:59:05 -0000 imp 2006-06-03 18:57:28 UTC FreeBSD src repository Modified files: sys/dev/pccbb pccbb.c Log: Succeed for writing bus value... nobody that calls must care :-( Revision Changes Path 1.147 +1 -1 src/sys/dev/pccbb/pccbb.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 19:00:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 57E0A16A41F; Sat, 3 Jun 2006 19:00:25 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D388D43D45; Sat, 3 Jun 2006 19:00:24 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53Iwm3O075891; Sat, 3 Jun 2006 18:58:48 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53Iwmf7075890; Sat, 3 Jun 2006 18:58:48 GMT (envelope-from imp) Message-Id: <200606031858.k53Iwmf7075890@repoman.freebsd.org> From: Warner Losh Date: Sat, 3 Jun 2006 18:58:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccbb pccbb_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 19:00:25 -0000 imp 2006-06-03 18:58:48 UTC FreeBSD src repository Modified files: sys/dev/pccbb pccbb_pci.c Log: Fix a couple printf's to be properly terminated. Use a better name for the cbb thread. Revision Changes Path 1.19 +3 -3 src/sys/dev/pccbb/pccbb_pci.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 19:08:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 916D716A50E; Sat, 3 Jun 2006 19:08:53 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9BBB43D55; Sat, 3 Jun 2006 19:08:52 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53J7GHP077556; Sat, 3 Jun 2006 19:07:16 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53J7G2t077555; Sat, 3 Jun 2006 19:07:16 GMT (envelope-from imp) Message-Id: <200606031907.k53J7G2t077555@repoman.freebsd.org> From: Warner Losh Date: Sat, 3 Jun 2006 19:07:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccbb pccbb.c pccbb_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 19:08:54 -0000 imp 2006-06-03 19:07:16 UTC FreeBSD src repository Modified files: sys/dev/pccbb pccbb.c pccbb_pci.c Log: The interrupt routine is pci specific. Move it into pccbb_pci.c. Revision Changes Path 1.148 +0 -69 src/sys/dev/pccbb/pccbb.c 1.20 +71 -1 src/sys/dev/pccbb/pccbb_pci.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 19:18:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA5B916A500; Sat, 3 Jun 2006 19:18:27 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D18AA43D45; Sat, 3 Jun 2006 19:18:21 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53JGjvk078023; Sat, 3 Jun 2006 19:16:45 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53JGj7N078022; Sat, 3 Jun 2006 19:16:45 GMT (envelope-from imp) Message-Id: <200606031916.k53JGj7N078022@repoman.freebsd.org> From: Warner Losh Date: Sat, 3 Jun 2006 19:16:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccbb pccbb.c pccbb_pci.c pccbbvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 19:18:31 -0000 imp 2006-06-03 19:16:45 UTC FreeBSD src repository Modified files: sys/dev/pccbb pccbb.c pccbb_pci.c pccbbvar.h Log: Move shutdown, and pci specific methods into pccbb_pci.c. Many more are needed still. Revision Changes Path 1.149 +1 -66 src/sys/dev/pccbb/pccbb.c 1.21 +66 -1 src/sys/dev/pccbb/pccbb_pci.c 1.28 +0 -7 src/sys/dev/pccbb/pccbbvar.h From owner-cvs-src@FreeBSD.ORG Sat Jun 3 19:31:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D8B716A4C6; Sat, 3 Jun 2006 19:31:03 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D2BE743D48; Sat, 3 Jun 2006 19:31:02 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53JTQCi078566; Sat, 3 Jun 2006 19:29:26 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53JTQXq078565; Sat, 3 Jun 2006 19:29:26 GMT (envelope-from rwatson) Message-Id: <200606031929.k53JTQXq078565@repoman.freebsd.org> From: Robert Watson Date: Sat, 3 Jun 2006 19:29:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet udp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 19:31:03 -0000 rwatson 2006-06-03 19:29:26 UTC FreeBSD src repository Modified files: sys/netinet udp_usrreq.c Log: Acquire udbinfo lock after call to soreserve() rather than before, as it is not required. This simplifies error-handling, and reduces the time that this lock is held. MFC after: 1 month Revision Changes Path 1.190 +2 -4 src/sys/netinet/udp_usrreq.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 19:38:45 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0077716A475; Sat, 3 Jun 2006 19:38:44 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B0BE243D45; Sat, 3 Jun 2006 19:38:44 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53Jb86W078868; Sat, 3 Jun 2006 19:37:08 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53Jb8L9078867; Sat, 3 Jun 2006 19:37:08 GMT (envelope-from rwatson) Message-Id: <200606031937.k53Jb8L9078867@repoman.freebsd.org> From: Robert Watson Date: Sat, 3 Jun 2006 19:37:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet tcp_timer.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 19:38:45 -0000 rwatson 2006-06-03 19:37:08 UTC FreeBSD src repository Modified files: sys/netinet tcp_timer.c Log: When entering a timer on a tcpcb, don't continue processing if it has been dropped. This prevents a bug introduced during the socket/pcb refcounting work from occuring, in which occasionally the retransmit timer may fire after a connection has been reset, resulting in the resulting R|A TCP packet having a source port of 0, as the port reservation has been released. While here, fixing up some RUNLOCK->WUNLOCK bugs. MFC after: 1 month Revision Changes Path 1.81 +14 -9 src/sys/netinet/tcp_timer.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 20:36:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CFCF116A4A6; Sat, 3 Jun 2006 20:36:32 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 89EAE43D46; Sat, 3 Jun 2006 20:36:32 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53KYuBZ083059; Sat, 3 Jun 2006 20:34:56 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53KYu40083058; Sat, 3 Jun 2006 20:34:56 GMT (envelope-from obrien) Message-Id: <200606032034.k53KYu40083058@repoman.freebsd.org> From: "David E. O'Brien" Date: Sat, 3 Jun 2006 20:34:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/vmstat vmstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 20:36:37 -0000 obrien 2006-06-03 20:34:56 UTC FreeBSD src repository Modified files: usr.bin/vmstat vmstat.c Log: Increase the field widths of flt (total number of page faults), fr (pages freed), & cs (CPU context switch rate). 'vmstat 1' output is now lined up for today's typical machines vs. a VAX. [tested my modest 1.6ghz laptop] Revision Changes Path 1.92 +5 -5 src/usr.bin/vmstat/vmstat.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 20:39:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 657BA16A41F; Sat, 3 Jun 2006 20:39:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F307743D48; Sat, 3 Jun 2006 20:39:32 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53Kbuon083269; Sat, 3 Jun 2006 20:37:56 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53Kbuph083268; Sat, 3 Jun 2006 20:37:56 GMT (envelope-from jhb) Message-Id: <200606032037.k53Kbuph083268@repoman.freebsd.org> From: John Baldwin Date: Sat, 3 Jun 2006 20:37:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/dc dcphy.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 20:39:35 -0000 jhb 2006-06-03 20:37:56 UTC FreeBSD src repository Modified files: sys/dev/dc dcphy.c Log: Use PCI bus accessors rather than reading config registers directly to get the subvendor device id. Revision Changes Path 1.31 +3 -2 src/sys/dev/dc/dcphy.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 20:43:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A60D16A473; Sat, 3 Jun 2006 20:43:32 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9E0843D49; Sat, 3 Jun 2006 20:43:31 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53Kft4g083560; Sat, 3 Jun 2006 20:41:55 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53KftGb083559; Sat, 3 Jun 2006 20:41:55 GMT (envelope-from jhb) Message-Id: <200606032041.k53KftGb083559@repoman.freebsd.org> From: John Baldwin Date: Sat, 3 Jun 2006 20:41:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/dc if_dc.c if_dcreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 20:43:35 -0000 jhb 2006-06-03 20:41:55 UTC FreeBSD src repository Modified files: sys/dev/dc if_dc.c if_dcreg.h Log: - Switch on the full 32-bit device ID to avoid collisions between the vendor-specific device ids across vendors. - Include the revision in the dc_devs[] array instead of special casing the revid handling in dc_devtype(). - Use PCI bus accessors to read registers instead of pci_read_config() where possible. - Use an 8-bit write to update the latency timer. - Use PCIR_xxx constants and remove unused DC_xxx related to standard PCI config registers. MFC after: 1 week Revision Changes Path 1.182 +88 -121 src/sys/dev/dc/if_dc.c 1.49 +6 -84 src/sys/dev/dc/if_dcreg.h From owner-cvs-src@FreeBSD.ORG Sat Jun 3 20:45:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2E4F916A4E9; Sat, 3 Jun 2006 20:45:38 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DFED943D49; Sat, 3 Jun 2006 20:45:37 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53Ki1qx083660; Sat, 3 Jun 2006 20:44:01 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53Ki1pA083659; Sat, 3 Jun 2006 20:44:01 GMT (envelope-from jhb) Message-Id: <200606032044.k53Ki1pA083659@repoman.freebsd.org> From: John Baldwin Date: Sat, 3 Jun 2006 20:44:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 20:45:43 -0000 jhb 2006-06-03 20:44:01 UTC FreeBSD src repository Modified files: sys/kern kern_mutex.c Log: Style fix to be more like _mtx_lock_sleep(): use 'while (!foo) { ... }' instead of 'for (;;) { if (foo) break; ... }'. Revision Changes Path 1.171 +1 -3 src/sys/kern/kern_mutex.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 20:46:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 281E516A47F; Sat, 3 Jun 2006 20:46:38 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9609243D46; Sat, 3 Jun 2006 20:46:37 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53Kj1rJ083711; Sat, 3 Jun 2006 20:45:01 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53Kj12Q083710; Sat, 3 Jun 2006 20:45:01 GMT (envelope-from jhb) Message-Id: <200606032045.k53Kj12Q083710@repoman.freebsd.org> From: John Baldwin Date: Sat, 3 Jun 2006 20:45:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 20:46:41 -0000 jhb 2006-06-03 20:45:01 UTC FreeBSD src repository Modified files: sys/kern kern_mutex.c Log: Simplify mtx_owner() so it only reads m->mtx_lock once. Revision Changes Path 1.172 +1 -2 src/sys/kern/kern_mutex.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 20:51:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A198416A57B; Sat, 3 Jun 2006 20:51:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ECEF943D5A; Sat, 3 Jun 2006 20:51:20 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53KniT2091615; Sat, 3 Jun 2006 20:49:44 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53KniT2091614; Sat, 3 Jun 2006 20:49:44 GMT (envelope-from jhb) Message-Id: <200606032049.k53KniT2091614@repoman.freebsd.org> From: John Baldwin Date: Sat, 3 Jun 2006 20:49:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_synch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 20:51:28 -0000 jhb 2006-06-03 20:49:44 UTC FreeBSD src repository Modified files: sys/kern kern_synch.c Log: In the case of reentering the debugger due to an attempt to perform a context switch while in the debugger, reenter the debugger sooner before performing any statistics updates. Revision Changes Path 1.280 +10 -10 src/sys/kern/kern_synch.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 21:07:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 127D816A41F; Sat, 3 Jun 2006 21:07:13 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C44A843D45; Sat, 3 Jun 2006 21:07:12 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53L5aMv093579; Sat, 3 Jun 2006 21:05:36 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53L5aJB093578; Sat, 3 Jun 2006 21:05:36 GMT (envelope-from imp) Message-Id: <200606032105.k53L5aJB093578@repoman.freebsd.org> From: Warner Losh Date: Sat, 3 Jun 2006 21:05:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccbb pccbb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 21:07:13 -0000 imp 2006-06-03 21:05:36 UTC FreeBSD src repository Modified files: sys/dev/pccbb pccbb.c Log: Since we turn off the interrupts, we don't need to disestablish our ISR. Revision Changes Path 1.150 +0 -13 src/sys/dev/pccbb/pccbb.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 21:12:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 61C5916A523; Sat, 3 Jun 2006 21:12:27 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F58143D45; Sat, 3 Jun 2006 21:12:27 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53LAoSQ093880; Sat, 3 Jun 2006 21:10:50 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53LAoLi093879; Sat, 3 Jun 2006 21:10:50 GMT (envelope-from imp) Message-Id: <200606032110.k53LAoLi093879@repoman.freebsd.org> From: Warner Losh Date: Sat, 3 Jun 2006 21:10:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccbb pccbb_isa.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 21:12:29 -0000 imp 2006-06-03 21:10:50 UTC FreeBSD src repository Modified files: sys/dev/pccbb pccbb_isa.c Log: We don't have a ISA specific shutdown routine at this time, so remove it. We just moved it to be pci specific, so this was causing compile problems (linking problems, so I didn't notice since I unwisely just built the module). Revision Changes Path 1.7 +0 -1 src/sys/dev/pccbb/pccbb_isa.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 21:13:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 20E7C16A54B; Sat, 3 Jun 2006 21:13:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D115B43D49; Sat, 3 Jun 2006 21:13:09 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53LBXIV093972; Sat, 3 Jun 2006 21:11:33 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53LBXWX093971; Sat, 3 Jun 2006 21:11:33 GMT (envelope-from jhb) Message-Id: <200606032111.k53LBXWX093971@repoman.freebsd.org> From: John Baldwin Date: Sat, 3 Jun 2006 21:11:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_mutex.c src/sys/sys mutex.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 21:13:25 -0000 jhb 2006-06-03 21:11:33 UTC FreeBSD src repository Modified files: sys/kern kern_mutex.c sys/sys mutex.h Log: Bah, fix fat finger in last. Invert the ~ on MTX_FLAGMASK as it's non-intuitive for the ~ to be built into the mask. All the users now explicitly ~ the mask. In addition, add MTX_UNOWNED to the mask even though it technically isn't a flag. This should unbreak mtx_owner(). Quickly spotted by: kris Revision Changes Path 1.173 +2 -2 src/sys/kern/kern_mutex.c 1.83 +2 -2 src/sys/sys/mutex.h From owner-cvs-src@FreeBSD.ORG Sat Jun 3 21:18:52 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD27D16A476; Sat, 3 Jun 2006 21:18:52 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0CB8A43D45; Sat, 3 Jun 2006 21:18:51 +0000 (GMT) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.13.6/8.13.6) with ESMTP id k53LIkpC011980; Sun, 4 Jun 2006 01:18:46 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Sun, 4 Jun 2006 01:18:46 +0400 (MSD) From: Dmitry Morozovsky To: Sam Leffler In-Reply-To: <4481A575.4020306@errno.com> Message-ID: <20060604011710.C11811@woozle.rinet.ru> References: <200606030637.k536b0lr090865@repoman.freebsd.org> <4481A575.4020306@errno.com> X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 (woozle.rinet.ru [0.0.0.0]); Sun, 04 Jun 2006 01:18:47 +0400 (MSD) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, "Christian S.J. Peron" , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net bpf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 21:18:53 -0000 On Sat, 3 Jun 2006, Sam Leffler wrote: SL> I think we can actually make bpf a loadable module now that bpf_if is SL> exposed; I'll look at that. That should eliminate all these hacks we've SL> been carrying around. That would be *extremely* useful especially in situations where you realized you should use tcpdump right now and then - that you have no bpf in the current kernel. Thanks! Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------ From owner-cvs-src@FreeBSD.ORG Sat Jun 3 21:22:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B322816A46F; Sat, 3 Jun 2006 21:22:14 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4AC2643D45; Sat, 3 Jun 2006 21:22:14 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53LKbK7094466; Sat, 3 Jun 2006 21:20:37 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53LKb9q094465; Sat, 3 Jun 2006 21:20:37 GMT (envelope-from rodrigc) Message-Id: <200606032120.k53LKb9q094465@repoman.freebsd.org> From: Craig Rodrigues Date: Sat, 3 Jun 2006 21:20:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 21:22:14 -0000 rodrigc 2006-06-03 21:20:37 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_vfsops.c Log: Check the sectorsize of the underlying disk before trying to bread() the UFS superblock. Should eliminate crashes when trying to do: mount -t ufs on an audio CD. PR: kern/85893 Reported by: Russell Francis MFC after: 1 week Revision Changes Path 1.316 +8 -1 src/sys/ufs/ffs/ffs_vfsops.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 21:48:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0794016A607; Sat, 3 Jun 2006 21:48:49 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B471D43D45; Sat, 3 Jun 2006 21:48:48 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53LlC25095613; Sat, 3 Jun 2006 21:47:12 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53LlCxw095612; Sat, 3 Jun 2006 21:47:12 GMT (envelope-from rodrigc) Message-Id: <200606032147.k53LlCxw095612@repoman.freebsd.org> From: Craig Rodrigues Date: Sat, 3 Jun 2006 21:47:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern vfs_mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 21:48:54 -0000 rodrigc 2006-06-03 21:47:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern vfs_mount.c Log: MFC: 1.207: Add "errmsg" to list of global mount options. 1.225: Add "update" mount option to global_opts array, for use with vfs_filteropt(). Revision Changes Path 1.196.2.10 +2 -0 src/sys/kern/vfs_mount.c From owner-cvs-src@FreeBSD.ORG Sat Jun 3 23:12:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F79816A52A; Sat, 3 Jun 2006 23:12:29 +0000 (UTC) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1D0DF43D78; Sat, 3 Jun 2006 23:12:23 +0000 (GMT) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53NAlKA001130; Sat, 3 Jun 2006 23:10:47 GMT (envelope-from wilko@repoman.freebsd.org) Received: (from wilko@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53NAkdl001129; Sat, 3 Jun 2006 23:10:46 GMT (envelope-from wilko) Message-Id: <200606032310.k53NAkdl001129@repoman.freebsd.org> From: Wilko Bulte Date: Sat, 3 Jun 2006 23:10:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/alpha/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 23:12:29 -0000 wilko 2006-06-03 23:10:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/alpha/conf GENERIC Log: Testing has shown that the stability problems (panic tracebacks showing lockmgr) encountered with "make -jX release" for X > 1 and running on SMP hardware are gone once PREEMPTION is disabled. Better ideas on fixing the problem are more than welcome. Revision Changes Path 1.186.2.6 +3 -1 src/sys/alpha/conf/GENERIC From owner-cvs-src@FreeBSD.ORG Sat Jun 3 23:22:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DAF2516A49E; Sat, 3 Jun 2006 23:22:23 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4B14D43D55; Sat, 3 Jun 2006 23:22:23 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53NKkwL001536; Sat, 3 Jun 2006 23:20:46 GMT (envelope-from kris@repoman.freebsd.org) Received: (from kris@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53NKkJd001535; Sat, 3 Jun 2006 23:20:46 GMT (envelope-from kris) Message-Id: <200606032320.k53NKkJd001535@repoman.freebsd.org> From: Kris Kennaway Date: Sat, 3 Jun 2006 23:20:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 ktr.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 23:22:24 -0000 kris 2006-06-03 23:20:46 UTC FreeBSD src repository Modified files: share/man/man4 ktr.4 Log: Strengthen wording; the KTR_ENTRIES value *must* be a power of two since the code depends on this. MFC after: 1 week Revision Changes Path 1.12 +1 -1 src/share/man/man4/ktr.4 From owner-cvs-src@FreeBSD.ORG Sat Jun 3 23:31:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 434DE16A59D; Sat, 3 Jun 2006 23:31:58 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1169143D70; Sat, 3 Jun 2006 23:31:54 +0000 (GMT) (envelope-from kris@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53NUH30001941; Sat, 3 Jun 2006 23:30:17 GMT (envelope-from kris@repoman.freebsd.org) Received: (from kris@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53NUHId001940; Sat, 3 Jun 2006 23:30:17 GMT (envelope-from kris) Message-Id: <200606032330.k53NUHId001940@repoman.freebsd.org> From: Kris Kennaway Date: Sat, 3 Jun 2006 23:30:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 23:32:03 -0000 kris 2006-06-03 23:30:17 UTC FreeBSD src repository Modified files: sys/conf NOTES Log: Note that KTR_ENTRIES must be a power of two. MFC after: 1 week Revision Changes Path 1.1365 +12 -10 src/sys/conf/NOTES From owner-cvs-src@FreeBSD.ORG Sat Jun 3 23:40:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 076D216A475; Sat, 3 Jun 2006 23:40:52 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E98B43D6B; Sat, 3 Jun 2006 23:40:51 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k53NdDgB002283; Sat, 3 Jun 2006 23:39:13 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k53NdD0L002282; Sat, 3 Jun 2006 23:39:13 GMT (envelope-from pjd) Message-Id: <200606032339.k53NdD0L002282@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 3 Jun 2006 23:39:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man9 crypto.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2006 23:40:54 -0000 pjd 2006-06-03 23:39:13 UTC FreeBSD src repository Modified files: share/man/man9 crypto.9 Log: Document more bits. Reviewed by: brd Revision Changes Path 1.11 +29 -6 src/share/man/man9/crypto.9