From owner-freebsd-arch@FreeBSD.ORG  Mon May 15 14:05:07 2006
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: arch@FreeBSD.org
Delivered-To: freebsd-arch@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CEF7316A449;
	Mon, 15 May 2006 14:05:07 +0000 (UTC)
	(envelope-from keramida@FreeBSD.org)
Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DEB4A43D78;
	Mon, 15 May 2006 14:04:51 +0000 (GMT)
	(envelope-from keramida@FreeBSD.org)
Received: from gothmog.pc (aris.bedc.ondsl.gr [62.103.39.226])
	(authenticated bits=128)
	by igloo.linux.gr (8.13.6/8.13.6/Debian-1) with ESMTP id k4FE4Tc3003965
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Mon, 15 May 2006 17:04:36 +0300
Received: from gothmog.pc (gothmog [127.0.0.1])
	by gothmog.pc (8.13.6/8.13.6) with ESMTP id k4FE6crc018009;
	Mon, 15 May 2006 17:06:38 +0300 (EEST)
	(envelope-from keramida@FreeBSD.org)
Received: (from giorgos@localhost)
	by gothmog.pc (8.13.6/8.13.6/Submit) id k4FE6bN6018008;
	Mon, 15 May 2006 17:06:37 +0300 (EEST)
	(envelope-from keramida@FreeBSD.org)
Date: Mon, 15 May 2006 17:06:37 +0300
From: Giorgos Keramidas <keramida@FreeBSD.org>
To: Rink Springer <rink@rink.nu>
Message-ID: <20060515140636.GA17196@gothmog.pc>
References: <20060328070332.GA53789@rink.nu>
	<20060328205625.658396e8.trhodes@FreeBSD.org>
	<20060513132917.GC79186@rink.nu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060513132917.GC79186@rink.nu>
X-Hellug-MailScanner: Found to be clean
X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-3.996,
	required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.40,
	BAYES_00 -2.60)
X-Hellug-MailScanner-From: keramida@freebsd.org
X-Spam-Status: No
Cc: Tom Rhodes <trhodes@FreeBSD.org>, arch@FreeBSD.org
Subject: Re: [RFC] Syslogd service patch
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 May 2006 14:05:10 -0000

On 2006-05-13 15:29, Rink Springer <rink@rink.nu> wrote:
> Hi Tom,
>
> Sorry for the extremely long delay (I was moving...). A new patch
> can be found at http://rink.nu/tmp/syslogd2.diff.
>
> As per your comments:
> [...]
> > ??  *cp++ = 0?
> >
> > Perhaps I'm just lost.
>
> This is used to null-terminate the host name; this avoids using the
> 'host:service' pair as the hostname.

This part should probably be written as:

	*cp++ = '\0';

I know this is just a style-change, but it conveys more clearly the
meaning of terminating a string with '\0', so I tend to like it
better this way.

- Giorgos