From owner-freebsd-doc@FreeBSD.ORG Sun Aug 27 00:08:26 2006 Return-Path: X-Original-To: doc@freebsd.org Delivered-To: freebsd-doc@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A70A16A4DD; Sun, 27 Aug 2006 00:08:26 +0000 (UTC) (envelope-from danger@FreeBSD.org) Received: from virtual.micronet.sk (smtp.micronet.sk [84.16.32.237]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A8F143D46; Sun, 27 Aug 2006 00:08:25 +0000 (GMT) (envelope-from danger@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by virtual.micronet.sk (Postfix) with ESMTP id A67B810E748; Sun, 27 Aug 2006 02:08:13 +0200 (CEST) X-Virus-Scanned: by amavisd-new at virtual.micronet.sk Received: from virtual.micronet.sk ([127.0.0.1]) by localhost (virtual.micronet.sk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sHrCyhQo3OH6; Sun, 27 Aug 2006 02:08:12 +0200 (CEST) Received: from danger.mcrn.sk (danger.mcrn.sk [84.16.37.254]) by virtual.micronet.sk (Postfix) with ESMTP id 63EED10E68A; Sun, 27 Aug 2006 02:08:12 +0200 (CEST) Date: Sun, 27 Aug 2006 02:08:27 +0200 From: Daniel Gerzo Organization: The FreeBSD Project X-Priority: 3 (Normal) Message-ID: <1543787677.20060827020827@rulez.sk> To: Ceri Davies In-Reply-To: References: <1418203821.20060822110342@rulez.sk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Daniel Gerzo , doc@freebsd.org Subject: Re[2]: merge query-pr.cgi and query-pr-summary.cgi, fix -T mode with new perl X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Gerzo List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Aug 2006 00:08:26 -0000 Hello Ceri, Saturday, August 26, 2006, 3:49:12 PM, you wrote: > On 22/8/06 10:03, "Daniel Gerzo" wrote: >> I would like you to review this patch. The only drawback I can see >> is that the query-pr-summary.cgi?prnumber does not work with new >> version. It is required to do query-pr-summary.cgi?pr=prnumber >> (which was standard for original version). > Please check the access logs to ensure that this isn't being used elsewhere. > Otherwise I'm afraid that keeping it is highly desirable - what's the > barrier to keeping it working? Fixing this would not really be a problem, I have an idea how to implement this functionality too. I'm waiting now for Simon's review, he denied access to the working script, becase he needs to be sure I have properly treated the user's input and that no dangerous characters are being passed into the command line. -- Best regards, Daniel mailto:danger@FreeBSD.org