From owner-freebsd-geom@FreeBSD.ORG Sun Oct 15 18:20:24 2006 Return-Path: X-Original-To: freebsd-geom@hub.freebsd.org Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CC8A16A412 for ; Sun, 15 Oct 2006 18:20:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8951343D45 for ; Sun, 15 Oct 2006 18:20:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k9FIKNiI034758 for ; Sun, 15 Oct 2006 18:20:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k9FIKNAW034757; Sun, 15 Oct 2006 18:20:23 GMT (envelope-from gnats) Date: Sun, 15 Oct 2006 18:20:23 GMT Message-Id: <200610151820.k9FIKNAW034757@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: "Poul-Henning Kamp" Cc: Subject: Re: kern/104389: sys/geom/geom_dump.c doesn't encode XML entities X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Poul-Henning Kamp List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Oct 2006 18:20:24 -0000 The following reply was made to PR kern/104389; it has been noted by GNATS. From: "Poul-Henning Kamp" To: douglas steinwand Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: kern/104389: sys/geom/geom_dump.c doesn't encode XML entities Date: Sun, 15 Oct 2006 18:12:56 +0000 In message <200610132043.k9DKh3lW055022@www.freebsd.org>, douglas steinwand wri tes: >geom_dump.c should encode XML entities. Attached is a patch. I don't like it in two ways. I'm not keep on the encoding, and would be inclined to say "Don't use such names then", but I can probably be convinced that this is actually a good idea if sensible examples are shown. The other thing is that in the patch, the _encode_entities() function should not have a leading underscore and should take arguments: static void encode_entities(struct sbuf *sb, const char *fmt, const char *str, int len); So that usage would not need a randomsized local buffer and double enveloping of the call: >- sbuf_printf(sb, "\t %s\n", pp->name); Should be: encode_entities(sb, "\t %s\n", pp->name, -1); (-1 for len means "use strlen") -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-freebsd-geom@FreeBSD.ORG Sun Oct 15 20:30:25 2006 Return-Path: X-Original-To: freebsd-geom@hub.freebsd.org Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3782E16A415 for ; Sun, 15 Oct 2006 20:30:25 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E531143D45 for ; Sun, 15 Oct 2006 20:30:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k9FKUOib045165 for ; Sun, 15 Oct 2006 20:30:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k9FKUOGa045164; Sun, 15 Oct 2006 20:30:24 GMT (envelope-from gnats) Date: Sun, 15 Oct 2006 20:30:24 GMT Message-Id: <200610152030.k9FKUOGa045164@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: douglas steinwand Cc: Subject: Re: kern/104389: sys/geom/geom_dump.c doesn't encode XML entities X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: douglas steinwand List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Oct 2006 20:30:25 -0000 The following reply was made to PR kern/104389; it has been noted by GNATS. From: douglas steinwand To: Poul-Henning Kamp Cc: douglas steinwand , freebsd-gnats-submit@FreeBSD.org Subject: Re: kern/104389: sys/geom/geom_dump.c doesn't encode XML entities Date: Sun, 15 Oct 2006 13:20:41 -0700 --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline * Poul-Henning Kamp [2006-10-15 18:12:56 +0000]: > I'm not keep on the encoding, and would be inclined to say > "Don't use such names then", but I can probably be convinced > that this is actually a good idea if sensible examples are shown. I encountered this issue thanks to a CD from Sun Microsystems: # glabel status Name Status Components iso9660/tools_&_driver_1.0 N/A acd0 The label on its ISO9660 filesystem has "&", which must be encoded in XML. > The other thing is that in the patch, the _encode_entities() > function should not have a leading underscore and should > take arguments: > > static void > encode_entities(struct sbuf *sb, const char *fmt, > const char *str, int len); My initial patch was just a quick hack to work around the problem. I didn't know how FreeBSD's developers wanted to address it. For example, if XML will be used widely in the kernel, should a new format code for kvprintf() do this XML encoding? > So that usage would not need a randomsized local buffer and > double enveloping of the call: > > >- sbuf_printf(sb, "\t %s\n", pp->name); > > Should be: > > encode_entities(sb, "\t %s\n", pp->name, -1); > > (-1 for len means "use strlen") Attached is a new patch for geom_dump.c which follows your recommendations. Thanks, - doug --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=patch-geom_dump --- sys/geom/geom_dump.c.orig Wed Mar 10 00:49:08 2004 +++ sys/geom/geom_dump.c Sun Oct 15 12:53:42 2006 @@ -45,6 +45,47 @@ #include #include +static void +encode_entities(struct sbuf *sb, const char *fmt, const char *str, int len) +{ + char *d, *dst; + const char *e; + int i; + + if (len == -1) + len = strlen(str); + /* Assume worst case expansion. */ + dst = d = g_malloc(len * 6 + 1, M_WAITOK); + + for(i = 0; i < len; i++) { + switch(str[i]) { + case '&': + e = "&"; + break; + case '<': + e = "<"; + break; + case '>': + e = ">"; + break; + case '\'': + e = "'"; + break; + case '"': + e = """; + break; + default: + *d++ = str[i]; + continue; + } + while(*e != '\0') + *d++ = *e++; + } + *d = '\0'; + + sbuf_printf(sb, fmt, dst); + g_free(dst); +} static void g_confdot_consumer(struct sbuf *sb, struct g_consumer *cp) @@ -182,7 +223,7 @@ sbuf_printf(sb, "\t \n", pp->geom); sbuf_printf(sb, "\t r%dw%de%d\n", pp->acr, pp->acw, pp->ace); - sbuf_printf(sb, "\t %s\n", pp->name); + encode_entities(sb, "\t %s\n", pp->name, -1); sbuf_printf(sb, "\t %jd\n", (intmax_t)pp->mediasize); sbuf_printf(sb, "\t %u\n", pp->sectorsize); @@ -205,7 +246,7 @@ sbuf_printf(sb, " \n", gp); sbuf_printf(sb, " \n", gp->class); - sbuf_printf(sb, " %s\n", gp->name); + encode_entities(sb, " %s\n", gp->name, -1); sbuf_printf(sb, " %d\n", gp->rank); if (gp->flags & G_GEOM_WITHER) sbuf_printf(sb, " \n"); @@ -234,7 +275,7 @@ struct g_geom *gp2; sbuf_printf(sb, " \n", mp); - sbuf_printf(sb, " %s\n", mp->name); + encode_entities(sb, " %s\n", mp->name, -1); LIST_FOREACH(gp2, &mp->geom, geom) { if (gp != NULL && gp != gp2) continue; --BXVAT5kNtrzKuDFl-- From owner-freebsd-geom@FreeBSD.ORG Sun Oct 15 20:30:51 2006 Return-Path: X-Original-To: freebsd-geom@FreeBSD.org Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 536F716A412 for ; Sun, 15 Oct 2006 20:30:51 +0000 (UTC) (envelope-from darkside@swipnet.se) Received: from amsfep16-int.chello.nl (amsfep17-int.chello.nl [213.46.243.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4859243D4C for ; Sun, 15 Oct 2006 20:30:49 +0000 (GMT) (envelope-from darkside@swipnet.se) Received: from [192.168.0.5] (really [213.89.209.56]) by amsfep16-int.chello.nl (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20061015203047.GLW25943.amsfep16-int.chello.nl@[192.168.0.5]> for ; Sun, 15 Oct 2006 22:30:47 +0200 Message-ID: <45329A7E.1010108@swipnet.se> Date: Sun, 15 Oct 2006 22:30:54 +0200 From: Nyaano User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: freebsd-geom@FreeBSD.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: GEOM vinum and SMP (AMD64) X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: darkside@swipnet.se List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Oct 2006 20:30:51 -0000 Hi, I've just tried out FreeBSD 6.2-BETA2 (AMD64) on a Core2Duo E6300. I installed the SMP kernel without any problem, made a gvinum configuration and created a RAID5 volume. I can mount it without any problems, and I added geom_vinum_load="YES" in /boot/loader.conf and the appropriate line in /etc/fstab after creating a filesystem on the volume. After that, I do a simple shutdown -r now because I want to make sure that everything starts up the way it should. When the system comes to the point where it's going to mount the RAID5 volume, it complains about the superblock and says it's corrupt. With exactly the same configuration, but with the GENERIC kernel, everything works without any problems. Before I spend more time on trying to get this working with SMP, I'd like to know if this is a known problem, and if it's not, what information is needed from me in order to track down what the problem is. Thank you, Nyaano From owner-freebsd-geom@FreeBSD.ORG Mon Oct 16 11:08:19 2006 Return-Path: X-Original-To: freebsd-geom@FreeBSD.org Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A1C0116A500 for ; Mon, 16 Oct 2006 11:08:19 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 28FFA43D60 for ; Mon, 16 Oct 2006 11:08:19 +0000 (GMT) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k9GB8JB1028131 for ; Mon, 16 Oct 2006 11:08:19 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k9GB8HS5028127 for freebsd-geom@FreeBSD.org; Mon, 16 Oct 2006 11:08:17 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 16 Oct 2006 11:08:17 GMT Message-Id: <200610161108.k9GB8HS5028127@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: linimon set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-geom@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2006 11:08:19 -0000 Current FreeBSD problem reports Critical problems Serious problems S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/73177 geom kldload geom_* causes panic due to memory exhaustion o kern/76538 geom [gbde] nfs-write on gbde partition stalls and continue o kern/83464 geom [geom] [patch] Unhandled malloc failures within libgeo o kern/84556 geom [geom] GBDE-encrypted swap causes panic at shutdown o kern/87544 geom [gbde] mmaping large files on a gbde filesystem deadlo o kern/89102 geom [geom_vfs] [panic] panic when forced unmount FS from u o bin/90093 geom fdisk(8) incapable of altering in-core geometry o kern/90582 geom [geom_mirror] [panic] Restore cause panic string (ffs_ o kern/98034 geom [geom] dereference of NULL pointer in acd_geom_detach o kern/104389 geom [geom] [patch] sys/geom/geom_dump.c doesn't encode XML 10 problems total. Non-critical problems S Tracker Resp. Description -------------------------------------------------------------------------------- o bin/78131 geom gbde "destroy" not working. o kern/79251 geom [2TB] newfs fails on 2.6TB gbde device o kern/94632 geom [geom] Kernel output resets input while GELI asks for 3 problems total. From owner-freebsd-geom@FreeBSD.ORG Wed Oct 18 17:07:58 2006 Return-Path: X-Original-To: freebsd-geom@FreeBSD.org Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0929516A407 for ; Wed, 18 Oct 2006 17:07:58 +0000 (UTC) (envelope-from lulf@pvv.ntnu.no) Received: from merke.itea.ntnu.no (merke.itea.ntnu.no [129.241.7.61]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2142543D5F for ; Wed, 18 Oct 2006 17:07:51 +0000 (GMT) (envelope-from lulf@pvv.ntnu.no) Received: from localhost (localhost [127.0.0.1]) by merke.itea.ntnu.no (Postfix) with ESMTP id DFFA513C8E1; Wed, 18 Oct 2006 19:07:46 +0200 (CEST) Received: from studby.ntnu.no (m044h.studby.ntnu.no [129.241.135.44]) by merke.itea.ntnu.no (Postfix) with ESMTP; Wed, 18 Oct 2006 19:07:46 +0200 (CEST) Received: by studby.ntnu.no (Postfix, from userid 1001) id 66FCC398F4; Wed, 18 Oct 2006 19:07:49 +0200 (CEST) Date: Wed, 18 Oct 2006 19:07:49 +0200 From: Ulf Lilleengen To: Nyaano Message-ID: <20061018170749.GA3547@vimes.studby.ntnu.no> References: <45329A7E.1010108@swipnet.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45329A7E.1010108@swipnet.se> User-Agent: Mutt/1.4.2.2i X-Content-Scanned: with sophos and spamassassin at mailgw.ntnu.no. Cc: freebsd-geom@FreeBSD.org Subject: Re: GEOM vinum and SMP (AMD64) X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2006 17:07:58 -0000 On Sun, Oct 15, 2006 at 10:30:54PM +0200, Nyaano wrote: > Hi, > > I've just tried out FreeBSD 6.2-BETA2 (AMD64) on a Core2Duo E6300. > I installed the SMP kernel without any problem, made a gvinum > configuration and created a RAID5 volume. > I can mount it without any problems, and I added geom_vinum_load="YES" > in /boot/loader.conf and the appropriate line in /etc/fstab after > creating a filesystem on the volume. > After that, I do a simple shutdown -r now because I want to make sure > that everything starts up the way it should. > When the system comes to the point where it's going to mount the RAID5 > volume, it complains about the superblock and says it's corrupt. > > With exactly the same configuration, but with the GENERIC kernel, > everything works without any problems. > > Before I spend more time on trying to get this working with SMP, I'd > like to know if this is a known problem, and if it's not, what > information is needed from me in order to track down what the problem is. Hi, Could you try to boot into single-user mode, try fsck on the volume, and then mount it? It would also be nice if you could send your config as well as any relevant error message. -- Ulf Lilleengen From owner-freebsd-geom@FreeBSD.ORG Wed Oct 18 19:58:02 2006 Return-Path: X-Original-To: freebsd-geom@FreeBSD.org Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7EC4416A407 for ; Wed, 18 Oct 2006 19:58:02 +0000 (UTC) (envelope-from darkside@swipnet.se) Received: from amsfep13-int.chello.nl (amsfep17-int.chello.nl [213.46.243.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 37A7543D5C for ; Wed, 18 Oct 2006 19:57:53 +0000 (GMT) (envelope-from darkside@swipnet.se) Received: from [192.168.0.5] (really [213.89.209.56]) by amsfep17-int.chello.nl (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20061018195639.QYQF9483.amsfep17-int.chello.nl@[192.168.0.5]>; Wed, 18 Oct 2006 21:56:39 +0200 Message-ID: <45368702.9000506@swipnet.se> Date: Wed, 18 Oct 2006 21:56:50 +0200 From: Nyaano User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Ulf Lilleengen References: <45329A7E.1010108@swipnet.se> <20061018170749.GA3547@vimes.studby.ntnu.no> In-Reply-To: <20061018170749.GA3547@vimes.studby.ntnu.no> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-geom@FreeBSD.org Subject: Re: GEOM vinum and SMP (AMD64) X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: darkside@swipnet.se List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2006 19:58:02 -0000 Ulf Lilleengen wrote: > On Sun, Oct 15, 2006 at 10:30:54PM +0200, Nyaano wrote: > >> Hi, >> >> I've just tried out FreeBSD 6.2-BETA2 (AMD64) on a Core2Duo E6300. >> I installed the SMP kernel without any problem, made a gvinum >> configuration and created a RAID5 volume. >> I can mount it without any problems, and I added geom_vinum_load="YES" >> in /boot/loader.conf and the appropriate line in /etc/fstab after >> creating a filesystem on the volume. >> After that, I do a simple shutdown -r now because I want to make sure >> that everything starts up the way it should. >> When the system comes to the point where it's going to mount the RAID5 >> volume, it complains about the superblock and says it's corrupt. >> >> With exactly the same configuration, but with the GENERIC kernel, >> everything works without any problems. >> >> Before I spend more time on trying to get this working with SMP, I'd >> like to know if this is a known problem, and if it's not, what >> information is needed from me in order to track down what the problem is. >> > > Hi, > > Could you try to boot into single-user mode, try fsck on the volume, and then > mount it? It would also be nice if you could send your config as well as any > relevant error message. > > The computer in question had the following setup (I write had because I had to put it to other use for now, will make a new attempt with FreeBSD when I can free it up again): Asus P5B Core 2 Duo E6300 1GB RAM 4x320GB WD3200KS on the mobo ICH8-controller (configured in BIOS as IDE, not AHCI because with AHCI FreeBSD would only detect two drives) 2x250GB WD2500KS on a Highpoint 2300 SATA-controller (using driver provided by Highpoint, configured for RAID1) 1 SATA CD/DVD on the JMicron controller (CD/DVD not detected by FreeBSD in either IDE or AHCI mode in BIOS) Some noname firewire PCI card Some nVidia PCI-Express graphics card What I did was install a minimal FreeBSD 6.2-BETA2 with SMP kernel from AMD64 iso, proceeded to run gvinum and produced a configuration that put the 4 320GB drives in a RAID5 volume, created filesystem with newfs -U, added lines in /boot/loader.conf (geom_vinum_load="YES") and /etc/fstab (can't recall exactly, but it was a standard line). After shutdown -r now it booted up fine but when it came to mounting the volume, it would complain about corrupt superblock (sorry, don't have exact error message). I tried to run fsck on the /dev/gvinum/fileserver volume, but it would complain about the superblock. To see if the same thing happened with GENERIC kernel, I installed from scratch and picked GENERIC instead, started gvinum and let that load the RAID5 config from the disks, then put on a new filesystem. shutdown -r now and it booted up to the prompt without any problems. Before I had to put the computer to other use, I tried again with SMP, and this time everything worked fine. I simply didn't have any more time to test these things further, but I started to question my own assumption that the problem was in GEOM vinum, as that should be well tested in both GENERIC and SMP configs, and started to wonder if the problem could be in the ICH8 driver instead. Lack of time, and not being too familiar with FreeBSD forced me to abandon this for now though. (I had previously already lost a lot of time from wondering how the network support could be so flaky during install until I discovered that it was the cable that was at fault and not the network card or FreeBSD, as well as trying to get FreeBSD to notice my SATA CD/DVD). I should be able to make a new attempt at this in a few weeks which should be a lot less painful experience :p Regards, Nyaano From owner-freebsd-geom@FreeBSD.ORG Fri Oct 20 17:59:09 2006 Return-Path: X-Original-To: freebsd-geom@freebsd.org Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6458D16A416 for ; Fri, 20 Oct 2006 17:59:09 +0000 (UTC) (envelope-from antik@bsd.ee) Received: from a5.virtuaal.com (a5.virtuaal.com [195.222.15.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8767243D5A for ; Fri, 20 Oct 2006 17:58:50 +0000 (GMT) (envelope-from antik@bsd.ee) Received: from pc122.host1.ida.starman.ee ([62.65.240.122] helo=[192.168.2.102]) by a5.virtuaal.com with esmtpsa (SSLv3:AES256-SHA:256) (Exim 4.52) id 1Gayds-0000MR-7R for freebsd-geom@freebsd.org; Fri, 20 Oct 2006 20:58:48 +0300 From: Andrei Kolu To: freebsd-geom@freebsd.org Date: Fri, 20 Oct 2006 20:54:48 -0700 User-Agent: KMail/1.9.4 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610202054.49390.antik@bsd.ee> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - a5.virtuaal.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [47 12] X-AntiAbuse: Sender Address Domain - bsd.ee X-Source: X-Source-Args: X-Source-Dir: Subject: Gjournal on FreeBSD 6.1p10 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2006 17:59:09 -0000 Hello! I am trying to build PC-BSD 1.3 beta with gjournal patch, but build bombs out with error: # cd /usr/src # mkdir sys/geom/journal sbin/geom/class/journal sys/modules/geom/geom_journal # patch < gjournal6_20061011.patch # make buildkernel ....................... /usr/src/sys/ufs/ufs/ufs_gjournal.c /usr/src/sys/ufs/ufs/ufs_gjournal.c:206: error: redefinition of 'ufs_gjournal_modref' /usr/src/sys/ufs/ufs/ufs_gjournal.c:56: error: previous definition of 'ufs_gjournal_modref' was here /usr/src/sys/ufs/ufs/ufs_gjournal.c:259: error: redefinition of 'ufs_gjournal_orphan' /usr/src/sys/ufs/ufs/ufs_gjournal.c:109: error: previous definition of 'ufs_gjournal_orphan' was here /usr/src/sys/ufs/ufs/ufs_gjournal.c:285: error: redefinition of 'ufs_gjournal_close' /usr/src/sys/ufs/ufs/ufs_gjournal.c:135: error: previous definition of 'ufs_gjournal_close' was here *** Error code 1 Stop in /usr/obj/usr/src/sys/PCBSDv1.3GJ. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. From owner-freebsd-geom@FreeBSD.ORG Fri Oct 20 18:33:53 2006 Return-Path: X-Original-To: freebsd-geom@freebsd.org Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D1F1516A412 for ; Fri, 20 Oct 2006 18:33:53 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA1F543E3B for ; Fri, 20 Oct 2006 18:31:43 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 5651645696; Fri, 20 Oct 2006 20:31:27 +0200 (CEST) Received: from localhost (dkk103.neoplus.adsl.tpnet.pl [83.24.14.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 30E4245684; Fri, 20 Oct 2006 20:31:22 +0200 (CEST) Date: Fri, 20 Oct 2006 20:31:04 +0200 From: Pawel Jakub Dawidek To: Andrei Kolu Message-ID: <20061020183104.GB56628@garage.freebsd.pl> References: <200610202054.49390.antik@bsd.ee> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0eh6TmSyL6TZE2Uz" Content-Disposition: inline In-Reply-To: <200610202054.49390.antik@bsd.ee> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: freebsd-geom@freebsd.org Subject: Re: Gjournal on FreeBSD 6.1p10 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2006 18:33:53 -0000 --0eh6TmSyL6TZE2Uz Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 20, 2006 at 08:54:48PM -0700, Andrei Kolu wrote: > Hello! >=20 > I am trying to build PC-BSD 1.3 beta with gjournal patch, but build bombs= out=20 > with error: >=20 > # cd /usr/src > # mkdir sys/geom/journal sbin/geom/class/journal sys/modules/geom/geom_jo= urnal > # patch < gjournal6_20061011.patch > # make buildkernel > ....................... > /usr/src/sys/ufs/ufs/ufs_gjournal.c > /usr/src/sys/ufs/ufs/ufs_gjournal.c:206: error: redefinition=20 > of 'ufs_gjournal_modref' > /usr/src/sys/ufs/ufs/ufs_gjournal.c:56: error: previous definition=20 > of 'ufs_gjournal_modref' was here > /usr/src/sys/ufs/ufs/ufs_gjournal.c:259: error: redefinition=20 > of 'ufs_gjournal_orphan' > /usr/src/sys/ufs/ufs/ufs_gjournal.c:109: error: previous definition=20 > of 'ufs_gjournal_orphan' was here > /usr/src/sys/ufs/ufs/ufs_gjournal.c:285: error: redefinition=20 > of 'ufs_gjournal_close' > /usr/src/sys/ufs/ufs/ufs_gjournal.c:135: error: previous definition=20 > of 'ufs_gjournal_close' was here > *** Error code 1 It looks that you patched your source twice. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --0eh6TmSyL6TZE2Uz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFFORXoForvXbEpPzQRAszfAJ9LDfG/uKDsc+6CtXNViSPQYMsYjgCeJGM8 9hdY4Y8qTj13mkfPizALGe0= =Unpt -----END PGP SIGNATURE----- --0eh6TmSyL6TZE2Uz-- From owner-freebsd-geom@FreeBSD.ORG Fri Oct 20 20:27:43 2006 Return-Path: X-Original-To: freebsd-geom@freebsd.org Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4432416A4CE for ; Fri, 20 Oct 2006 20:27:43 +0000 (UTC) (envelope-from antik@bsd.ee) Received: from a5.virtuaal.com (a5.virtuaal.com [195.222.15.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 97EA343F80 for ; Fri, 20 Oct 2006 20:20:06 +0000 (GMT) (envelope-from antik@bsd.ee) Received: from pc122.host1.ida.starman.ee ([62.65.240.122] helo=[192.168.2.102]) by a5.virtuaal.com with esmtpsa (SSLv3:AES256-SHA:256) (Exim 4.52) id 1Gb0qQ-0000gf-VT for freebsd-geom@freebsd.org; Fri, 20 Oct 2006 23:19:55 +0300 From: Andrei Kolu To: freebsd-geom@freebsd.org Date: Fri, 20 Oct 2006 23:19:52 -0700 User-Agent: KMail/1.9.4 References: <200610202054.49390.antik@bsd.ee> <20061020183104.GB56628@garage.freebsd.pl> In-Reply-To: <20061020183104.GB56628@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610202319.53110.antik@bsd.ee> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - a5.virtuaal.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [47 12] X-AntiAbuse: Sender Address Domain - bsd.ee X-Source: X-Source-Args: X-Source-Dir: Subject: Re: Gjournal on FreeBSD 6.1p10 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2006 20:27:43 -0000 On Friday 20 October 2006 11:31 am, you wrote: > On Fri, Oct 20, 2006 at 08:54:48PM -0700, Andrei Kolu wrote: > > Hello! > > > > I am trying to build PC-BSD 1.3 beta with gjournal patch, but build bombs > > out with error: > > > > # cd /usr/src > > # mkdir sys/geom/journal sbin/geom/class/journal > > sys/modules/geom/geom_journal # patch < gjournal6_20061011.patch > > # make buildkernel > > ....................... > > /usr/src/sys/ufs/ufs/ufs_gjournal.c > > /usr/src/sys/ufs/ufs/ufs_gjournal.c:206: error: redefinition > > of 'ufs_gjournal_modref' > > /usr/src/sys/ufs/ufs/ufs_gjournal.c:56: error: previous definition > > of 'ufs_gjournal_modref' was here > > /usr/src/sys/ufs/ufs/ufs_gjournal.c:259: error: redefinition > > of 'ufs_gjournal_orphan' > > /usr/src/sys/ufs/ufs/ufs_gjournal.c:109: error: previous definition > > of 'ufs_gjournal_orphan' was here > > /usr/src/sys/ufs/ufs/ufs_gjournal.c:285: error: redefinition > > of 'ufs_gjournal_close' > > /usr/src/sys/ufs/ufs/ufs_gjournal.c:135: error: previous definition > > of 'ufs_gjournal_close' was here > > *** Error code 1 > > It looks that you patched your source twice. Maybe, I resynced source with csup after unsuccessful patch (I forgot to make directories) but maybe I left some files from older sync... ------------------------------------------- Patching file sys/ufs/ufs/ufs_inode.c using Plan A... Hunk #1 succeeded at 57. Hunk #2 failed at 86. 1 out of 2 hunks failed--saving rejects to sys/ufs/ufs/ufs_inode.c.rej Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |--- sys/ufs/ufs/ufs_vnops.c.orig |+++ sys/ufs/ufs/ufs_vnops.c -------------------------- Patching file sys/ufs/ufs/ufs_vnops.c using Plan A... Hunk #1 succeeded at 81. Hunk #2 succeeded at 767 (offset -13 lines). Hunk #3 succeeded at 1676 (offset -13 lines). ------------------------------------------- I am sure I deleted whole /usr/src/sys directory and resynced it. From owner-freebsd-geom@FreeBSD.ORG Fri Oct 20 22:41:42 2006 Return-Path: X-Original-To: freebsd-geom@freebsd.org Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4AC5B16A407 for ; Fri, 20 Oct 2006 22:41:42 +0000 (UTC) (envelope-from antik@bsd.ee) Received: from a5.virtuaal.com (a5.virtuaal.com [195.222.15.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 06D2143D5F for ; Fri, 20 Oct 2006 22:41:40 +0000 (GMT) (envelope-from antik@bsd.ee) Received: from pc122.host1.ida.starman.ee ([62.65.240.122] helo=[192.168.2.102]) by a5.virtuaal.com with esmtpsa (SSLv3:AES256-SHA:256) (Exim 4.52) id 1Gb33a-0007gr-D6 for freebsd-geom@freebsd.org; Sat, 21 Oct 2006 01:41:38 +0300 From: Andrei Kolu To: freebsd-geom@freebsd.org Date: Sat, 21 Oct 2006 01:41:36 -0700 User-Agent: KMail/1.9.4 References: <200610202054.49390.antik@bsd.ee> <20061020183104.GB56628@garage.freebsd.pl> <200610202319.53110.antik@bsd.ee> In-Reply-To: <200610202319.53110.antik@bsd.ee> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610210141.36987.antik@bsd.ee> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - a5.virtuaal.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [47 12] X-AntiAbuse: Sender Address Domain - bsd.ee X-Source: X-Source-Args: X-Source-Dir: Subject: Re: Gjournal on FreeBSD 6.1p10 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2006 22:41:42 -0000 On Friday 20 October 2006 11:19 pm, Andrei Kolu wrote: > On Friday 20 October 2006 11:31 am, you wrote: > > On Fri, Oct 20, 2006 at 08:54:48PM -0700, Andrei Kolu wrote: > > > Hello! > > > > > > I am trying to build PC-BSD 1.3 beta with gjournal patch, but build > > > bombs out with error: > > > > > > # cd /usr/src > > > # mkdir sys/geom/journal sbin/geom/class/journal > > > sys/modules/geom/geom_journal # patch < gjournal6_20061011.patch > > > # make buildkernel > > > ....................... I deleted /usr/src directory contents and resynced source with csup made directories for gjournaling and patched system. RELENG_6_1 Now I got different error message. ===> geom/geom_concat (all) cc -O -pipe -march=pentiumpro -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I- -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/PCBSDv1.3GJ/opt_global.h -I. -I@ -I@/contrib/altq -I@/../include -finline-limit=8000 -fno-common -I/usr/obj/usr/src/sys/PCBSDv1.3GJ -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -c /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c: In function `g_concat_flush': /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c:223: error: `no' undeclared (first use in this function) /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c:223: error: (Each undeclared identifier is reported only once /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c:223: error: for each function it appears in.) /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c:220: warning: unused variable `n' *** Error code 1 Stop in /usr/src/sys/modules/geom/geom_concat. *** Error code 1 Stop in /usr/src/sys/modules/geom. *** Error code 1 Stop in /usr/src/sys/modules. *** Error code 1 Stop in /usr/obj/usr/src/sys/PCBSDv1.3GJ. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. From owner-freebsd-geom@FreeBSD.ORG Sat Oct 21 06:55:36 2006 Return-Path: X-Original-To: freebsd-geom@freebsd.org Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E83216A407 for ; Sat, 21 Oct 2006 06:55:36 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A71343D4C for ; Sat, 21 Oct 2006 06:55:34 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id D0DEF45CD9; Sat, 21 Oct 2006 08:55:32 +0200 (CEST) Received: from localhost (dkk103.neoplus.adsl.tpnet.pl [83.24.14.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 9C51945696; Sat, 21 Oct 2006 08:55:27 +0200 (CEST) Date: Sat, 21 Oct 2006 08:55:06 +0200 From: Pawel Jakub Dawidek To: Andrei Kolu Message-ID: <20061021065506.GC56628@garage.freebsd.pl> References: <200610202054.49390.antik@bsd.ee> <20061020183104.GB56628@garage.freebsd.pl> <200610202319.53110.antik@bsd.ee> <200610210141.36987.antik@bsd.ee> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s9fJI615cBHmzTOP" Content-Disposition: inline In-Reply-To: <200610210141.36987.antik@bsd.ee> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: freebsd-geom@freebsd.org Subject: Re: Gjournal on FreeBSD 6.1p10 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Oct 2006 06:55:36 -0000 --s9fJI615cBHmzTOP Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 21, 2006 at 01:41:36AM -0700, Andrei Kolu wrote: > On Friday 20 October 2006 11:19 pm, Andrei Kolu wrote: > > On Friday 20 October 2006 11:31 am, you wrote: > > > On Fri, Oct 20, 2006 at 08:54:48PM -0700, Andrei Kolu wrote: > > > > Hello! > > > > > > > > I am trying to build PC-BSD 1.3 beta with gjournal patch, but build > > > > bombs out with error: > > > > > > > > # cd /usr/src > > > > # mkdir sys/geom/journal sbin/geom/class/journal > > > > sys/modules/geom/geom_journal # patch < gjournal6_20061011.patch > > > > # make buildkernel > > > > ....................... > I deleted /usr/src directory contents and resynced source with csup > made directories for gjournaling and patched system. RELENG_6_1 >=20 > Now I got different error message. >=20 > =3D=3D=3D> geom/geom_concat (all) > cc -O -pipe -march=3Dpentiumpro -Werror -D_KERNEL -DKLD_MODULE -nostdinc = -I- -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/PCBSDv1.3G= J/opt_global.h -I. -I@ -I@/contrib/altq -I@/../include -finline-limit=3D800= 0 -fno-common -I/usr/obj/usr/src/sys/PCBSDv1.3GJ -mno-align-long-strings -= mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -ffre= estanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wm= issing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions= -std=3Dc99 -c /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g= _concat.c > /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c: In= =20 > function `g_concat_flush': > /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c:223= :=20 > error: `no' undeclared (first use in this function) > /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c:223= :=20 > error: (Each undeclared identifier is reported only once > /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c:223= :=20 > error: for each function it appears in.) > /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c:220= :=20 > warning: unused variable `n' > *** Error code 1 Could you change 'u_int n' to 'u_int no' in sys/geom/concat/g_concat.c file and try again? Or refetch the patch, I already fixed it. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --s9fJI615cBHmzTOP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFFOcRKForvXbEpPzQRAppRAKCcqrwLGIQImVX7nddToSP3DLBKRwCgzRYQ ACkoY7J6UX+96cViDSZE4k8= =GCYW -----END PGP SIGNATURE----- --s9fJI615cBHmzTOP-- From owner-freebsd-geom@FreeBSD.ORG Sat Oct 21 10:48:54 2006 Return-Path: X-Original-To: freebsd-geom@freebsd.org Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2CA7816A403 for ; Sat, 21 Oct 2006 10:48:54 +0000 (UTC) (envelope-from antik@bsd.ee) Received: from a5.virtuaal.com (a5.virtuaal.com [195.222.15.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id B31D343D55 for ; Sat, 21 Oct 2006 10:48:53 +0000 (GMT) (envelope-from antik@bsd.ee) Received: from pc122.host1.ida.starman.ee ([62.65.240.122] helo=[192.168.2.102]) by a5.virtuaal.com with esmtpsa (SSLv3:AES256-SHA:256) (Exim 4.52) id 1GbEPL-0000Hn-Ak for freebsd-geom@freebsd.org; Sat, 21 Oct 2006 13:48:51 +0300 From: Andrei Kolu To: freebsd-geom@freebsd.org Date: Sat, 21 Oct 2006 13:48:49 -0700 User-Agent: KMail/1.9.4 References: <200610202054.49390.antik@bsd.ee> <200610210141.36987.antik@bsd.ee> <20061021065506.GC56628@garage.freebsd.pl> In-Reply-To: <20061021065506.GC56628@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610211348.50304.antik@bsd.ee> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - a5.virtuaal.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [47 12] X-AntiAbuse: Sender Address Domain - bsd.ee X-Source: X-Source-Args: X-Source-Dir: Subject: Re: Gjournal on FreeBSD 6.1p10 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Oct 2006 10:48:54 -0000 On Friday 20 October 2006 11:55 pm, Pawel Jakub Dawidek wrote: > Could you change 'u_int n' to 'u_int no' in sys/geom/concat/g_concat.c > file and try again? Or refetch the patch, I already fixed it. Patched fresh src directory with newer patch downloaded from your site and buildkernel says: /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c: In function `g_concat_flush': /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c:238: error: invalid type argument of `->' /usr/src/sys/modules/geom/geom_concat/../../../geom/concat/g_concat.c:239: error: invalid type argument of `->' *** Error code 1 Stop in /usr/src/sys/modules/geom/geom_concat. *** Error code 1 From owner-freebsd-geom@FreeBSD.ORG Sat Oct 21 15:15:04 2006 Return-Path: X-Original-To: freebsd-geom@freebsd.org Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B09D16A403 for ; Sat, 21 Oct 2006 15:15:04 +0000 (UTC) (envelope-from nik@optim.com.ru) Received: from mail.optim-mol.cemu.ru (mail.optim-mol.cemu.ru [83.102.188.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A8F643D8A for ; Sat, 21 Oct 2006 15:14:57 +0000 (GMT) (envelope-from nik@optim.com.ru) Received: from [128.42.76.161] (ece-76-161.ece.rice.edu [128.42.76.161]) (authenticated bits=0) by mail.optim-mol.cemu.ru (8.13.8/8.13.8) with ESMTP id k9LFEojr017818 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 21 Oct 2006 19:14:53 +0400 (MSD) (envelope-from nik@optim.com.ru) Message-ID: <453A3969.7050005@optim.com.ru> Date: Sat, 21 Oct 2006 10:14:49 -0500 From: Nikolay Mirin User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: freebsd-geom@freebsd.org Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-98.7 required=5.0 tests=SPF_FAIL, USER_IN_WHITELIST autolearn=disabled version=3.1.4 X-Spam-Checker-Version: SpamAssassin 3.1.4 (2006-07-25) on mail.optim-mol.cemu.ru Subject: GELI provider would never detach X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Oct 2006 15:15:04 -0000 Hi, Everybody. I am trying out the geli partition and everything is just fine, except that it would never detach. It just freezes and I have to do "reboot -q" or "reboot -q -n" in order to start over. The thing seems happening only with large >100G partitions. 256Mb memory stick worked perfectly. I have recently updated all sources and recompiled the system. I waited about 4-5 hours for the provider to detach. I removed GBDE support from the kernel, just in case. Thank you for any comments about it, -Nikolay A Mirin