From owner-freebsd-qa@FreeBSD.ORG Sun Feb 26 11:25:29 2006 Return-Path: X-Original-To: freebsd-qa@hub.freebsd.org Delivered-To: freebsd-qa@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0110116A420; Sun, 26 Feb 2006 11:25:29 +0000 (GMT) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B0E6C43D45; Sun, 26 Feb 2006 11:25:28 +0000 (GMT) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1QBPS2K063903; Sun, 26 Feb 2006 11:25:28 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1QBPSAH063899; Sun, 26 Feb 2006 11:25:28 GMT (envelope-from linimon) Date: Sun, 26 Feb 2006 11:25:28 GMT From: Mark Linimon Message-Id: <200602261125.k1QBPSAH063899@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-qa@FreeBSD.org Cc: Subject: Re: bin/93853: [sysinstall] [patch]: Add country-specific keymap selection to sysinstall X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Feb 2006 11:25:29 -0000 Synopsis: [sysinstall] [patch]: Add country-specific keymap selection to sysinstall Responsible-Changed-From-To: freebsd-bugs->freebsd-qa Responsible-Changed-By: linimon Responsible-Changed-When: Sun Feb 26 11:25:03 UTC 2006 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=93853 From owner-freebsd-qa@FreeBSD.ORG Sun Feb 26 19:10:11 2006 Return-Path: X-Original-To: freebsd-qa@hub.freebsd.org Delivered-To: freebsd-qa@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 35E9516A420 for ; Sun, 26 Feb 2006 19:10:11 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D09FA43D48 for ; Sun, 26 Feb 2006 19:10:10 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1QJAAvB089791 for ; Sun, 26 Feb 2006 19:10:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1QJAAmZ089790; Sun, 26 Feb 2006 19:10:10 GMT (envelope-from gnats) Date: Sun, 26 Feb 2006 19:10:10 GMT Message-Id: <200602261910.k1QJAAmZ089790@freefall.freebsd.org> To: freebsd-qa@FreeBSD.org From: Seth Kingsley Cc: Subject: Re: bin/93853: [PATCH]: Add country-specific keymap selection to sysinstall X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Seth Kingsley List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Feb 2006 19:10:11 -0000 The following reply was made to PR bin/93853; it has been noted by GNATS. From: Seth Kingsley To: K?vesd?n G?bor Cc: bug-followup@FreeBSD.org Subject: Re: bin/93853: [PATCH]: Add country-specific keymap selection to sysinstall Date: Sun, 26 Feb 2006 11:02:51 -0800 On Sun, Feb 26, 2006 at 11:58:19AM +0100, K?vesd?n G?bor wrote: > Great idea, I'd love to see it implemented. :) > Could you possibly add Hungarian to the list, please? Hungary will work out of the box with this patch. I've just tested it. If you're looking at the mappings from country to language in the diff, that's only to handle cases where the keymap file is named after the language instead of the 2-letter country code, such as "danish.iso", instead of "dk.iso". All 240 countries listed in /usr/share/misc/iso3166 are included in the country selection menu. -- Seth Kingsley || sethk@magnesium.net From owner-freebsd-qa@FreeBSD.ORG Mon Feb 27 11:02:56 2006 Return-Path: X-Original-To: freebsd-qa@freebsd.org Delivered-To: freebsd-qa@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B3B516A426 for ; Mon, 27 Feb 2006 11:02:56 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D57BC43D48 for ; Mon, 27 Feb 2006 11:02:41 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1RB2fdc047130 for ; Mon, 27 Feb 2006 11:02:41 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1RB2ewc047124 for freebsd-qa@freebsd.org; Mon, 27 Feb 2006 11:02:40 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 27 Feb 2006 11:02:40 GMT Message-Id: <200602271102.k1RB2ewc047124@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: freebsd-qa@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2006 11:02:56 -0000 Current FreeBSD problem reports Critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2002/10/25] bin/44471 qa [sysinstall] 4.6 install writes MBR even o [2003/02/16] bin/48341 qa [sysinstall] sysinstall deletes mbr altho 2 problems total. Serious problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2000/02/24] bin/16948 qa [sysinstall] sysinstall/disklabel: bad pa o [2000/07/29] bin/20282 qa [sysinstall] sysinstall does not recover o [2000/11/25] bin/23098 qa [sysinstall] [patch] if installing on a s o [2001/04/27] bin/26897 qa [sysinstall] 4.3R sysinstall fails to cre o [2001/08/02] bin/29375 qa [sysinstall] disk editor gets confused by o [2001/09/26] bin/30837 qa [sysinstall] sysinstall doesn't set the s o [2001/10/18] bin/31363 qa [sysinstall] "partition editor" silently o [2001/12/31] bin/33370 qa [sysinstall] post-configuration issue o [2002/03/15] bin/35925 qa [sysinstall] fixit floppy cannot be mount a [2002/03/16] bin/35985 qa [sysinstall] swap double mount o [2002/03/29] bin/36508 qa [sysinstall] installation floppy bug (4.5 o [2002/04/08] bin/36911 qa [sysinstall] installation floppies miss a o [2002/05/03] bin/37710 qa [sysinstall] LAN interface in wrong state o [2002/05/26] bin/38582 qa [sysinstall] sysinstall sets newfs flag a o [2002/05/27] bin/38609 qa [sysinstall] sysinstall should know the s o [2002/07/06] bin/40260 qa [sysinstall] hang when detecting devices o [2002/08/18] bin/41757 qa [sysinstall] sysinstall 4.6.x unstable o [2002/08/21] bin/41850 qa [sysinstall] sysinstall fails to create r o [2002/11/21] bin/45565 qa [sysinstall] write error, filesystem full o [2003/01/01] bin/46670 qa [sysinstall] 5.0-RC2 install leaves CD dr o [2003/01/23] bin/47384 qa [sysinstall] sysinstall ignores intended o [2003/06/27] bin/53839 qa [sysinstall] disklabel editor fails on po o [2003/09/14] kern/56873 qa [boot] system hangs on boot at Buslogic d o [2004/01/10] bin/61152 qa [sysinstall] installer refuses to mount U o [2004/01/19] bin/61587 qa [sysinstall] [patch] installation problem o [2004/01/21] bin/61658 qa [sysinstall] 5.2R error "Add of package q o [2004/01/25] bin/61890 qa [sysinstall] fdisk(8) uses incorrect calc o [2004/01/26] bin/61937 qa [sysinstall] cannot install 5.2-REL via s o [2004/02/05] bin/62367 qa [sysinstall] 5.2.1-RC installation proble o [2004/02/05] bin/62375 qa [sysinstall] sysinstall core dump o [2004/02/14] bin/62833 qa [sysinstall] can't install: integer divid o [2004/04/14] bin/65546 qa [sysinstall] 4.10-BETA fails to install f o [2004/04/19] bin/65774 qa [sysinstall] cannot run repair disk when o [2004/05/07] bin/66350 qa [sysinstall] sysinstall creates a partiti o [2004/05/20] bin/66950 qa [sysinstall] upgrading to 4.10-RC3: packa o [2004/05/21] bin/66984 qa [2TB] [patch] teach sysinstall about larg o [2004/09/03] bin/71323 qa [sysinstall] FTP download from floppy boo o [2004/10/19] bin/72895 qa [sysinstall] Sysinstall generates invalid o [2004/10/23] kern/73035 qa [sysinstall] Upgrading from 5.2.1 to 5.3 o [2004/11/04] bin/73511 qa [sysinstall] SCSI drive install failure - o [2004/11/06] bin/73617 qa [sysinstall] fdisk editor unmarks active o [2005/03/17] bin/78964 qa [sysinstall] can not write labels to hdd o [2005/04/07] kern/79621 qa [sysinstall] sysinstall does not create a o [2005/04/14] bin/79910 qa [sysinstall] Cannot escape from failed po o [2005/08/08] bin/84668 qa [sysinstall] ssh and sysinstall problem f [2005/09/24] bin/86518 qa [sysinstall] USB keyboard not supported o [2005/12/19] bin/90656 qa [sysinstall] 6.0-RELEASE (i386) cannot be 47 problems total. Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [1997/09/28] bin/4646 qa [sysinstall] can't fixit with an NFS-moun s [1998/07/10] bin/7232 qa [sysinstall] suggestion for FreeBSD insta o [1998/11/27] bin/8867 qa [sysinstall] [patch] /stand/sysinstall co o [1999/06/21] bin/12324 qa [sysinstall] fdisk partition editor is mi o [1999/09/24] bin/13936 qa [sysinstall] no clear indication of how m o [1999/10/14] bin/14318 qa [sysinstall] sysinstall upon install has o [1999/11/22] bin/15038 qa [sysinstall] easy to not notice that sele o [2000/02/08] conf/16584 qa [sysinstall] Hostname field too small dur o [2000/03/22] bin/17546 qa [sysinstall] sysinstall does not let you o [2000/08/28] bin/20908 qa [sysinstall] /stand/sysinstall too limite a [2000/12/09] bin/23402 qa [sysinstall] upgrade ought to check parti o [2001/01/18] bin/24435 qa [libdisk] changing slice type causes Auto o [2001/02/06] bin/24907 qa [sysinstall] Options screen at MenuMedia o [2001/04/28] bin/26919 qa [sysinstall] fdisk should ONLY set one bo o [2001/05/08] bin/27216 qa [sysinstall] can not get to shell prompt o [2001/05/21] bin/27483 qa [sysinstall] [patch] make sysinstall ask f [2001/06/04] bin/27872 qa [sysinstall] "Load Config" hangs Compaq D a [2001/06/11] bin/28081 qa [sysinstall] /stand/sysinstall errs out i o [2001/08/20] bin/29893 qa [sysinstall] suggestions for 4.4 sysinsta o [2001/09/12] bin/30517 qa [sysinstall] using sysinstall with instal a [2001/09/22] bin/30737 qa sysinstall leaks file descriptors on rest f [2001/11/20] bin/32144 qa [sysinstall] unattended install with sysi a [2001/11/29] bin/32375 qa [sysinstall] sysinstall doesn't respect U o [2002/02/28] bin/35400 qa [sysinstall] sysinstall could improve man o [2002/03/20] bin/36118 qa [sysinstall] 4.5 Upgrade says it won't to o [2002/04/09] kern/36916 qa [libdisk] DOS active partition flag lost o [2002/04/16] bin/37160 qa [sysinstall] coredumps when trying to loa o [2002/05/14] bin/38055 qa [sysinstall] Groups (creation) item shoul o [2002/05/14] bin/38056 qa [sysinstall] User (creation)'s "Member gr o [2002/05/14] bin/38057 qa [sysinstall] "install" document doesn't d o [2002/05/24] bin/38478 qa [sysinstall] In Choose Distributions scre o [2002/05/24] bin/38480 qa [sysinstall] sysinstall should prompt for o [2002/05/27] bin/38610 qa [sysinstall] should be able to mount ISO o [2002/06/03] bin/38854 qa [sysinstall] resetting during setup cause o [2002/06/16] bin/39360 qa [sysinstall] if linux emu is added as a d o [2002/06/20] bin/39574 qa [sysinstall] error mounting /dev/acd0c on o [2002/07/23] kern/40926 qa [boot] After Upgrading or Clean Installin o [2002/08/01] bin/41238 qa [sysinstall] problems with FreeBSD instal o [2002/08/23] bin/41949 qa [sysinstall] sysinstall sorts /etc/rc.con o [2002/08/26] bin/42022 qa [sysinstall] non-interactive mode prompts o [2002/08/29] bin/42162 qa [sysinstall] installation crashes, md0c f o [2002/09/18] bin/42934 qa [sysinstall] installation procedure on in o [2002/11/05] bin/44915 qa [sysinstall] 'choose installation media' o [2002/11/13] bin/45254 qa [sysinstall] [patch] sysinstall installs o [2002/11/23] bin/45608 qa [sysinstall] install should config all et o [2003/01/09] bin/46905 qa [sysinstall] FreeBSD 5.x cannot be instal o [2003/02/04] bin/47908 qa [sysinstall] /stand/sysinstall can't disp o [2003/03/06] bin/48989 qa [sysinstall] Sysinstall's partition edit o [2003/05/15] bin/52271 qa [sysinstall] sysinstall panics in machine o [2003/06/10] bin/53131 qa [sysinstall] "ALL" could not turn check B o [2003/06/15] bin/53341 qa [sysinstall] [patch] dump frequency in sy o [2003/10/14] bin/58008 qa [sysinstall] [patch] sysinstall postfix i o [2003/11/26] bin/59708 qa [sysinstall] [patch] add sSMTP support fo o [2003/12/18] bin/60350 qa [sysinstall] in Choose Distributions scre o [2004/01/12] bin/61264 qa [sysinstall] unable To Use VT100 Terminal o [2004/01/16] kern/61438 qa [sysinstall] 5.2 nfs tasks running by def o [2004/02/11] bin/62702 qa [sysinstall] backup of /etc and /root dur o [2004/02/11] bin/62711 qa [sysinstall] installation: "Insert Next C o [2004/03/17] conf/64381 qa lo0 not up and no IPs assigned after inst o [2004/08/04] bin/69986 qa [sysinstall] [patch] no job control in fi o [2004/08/04] bin/70002 qa [sysinstall] fails to locate FTP dirs if o [2004/10/01] bin/72232 qa [sysinstall] Installer installs gui-enabl o [2004/10/15] misc/72741 qa ssh broken on fixit cd (missing /dev/rand o [2005/04/19] bin/80117 qa [sysinstall] [patch] smbfs install option o [2005/05/20] bin/81323 qa [sysinstall] Error in installation packag s [2005/07/25] bin/84084 qa [sysinstall] FreeBSD 4.11-R won't install o [2005/07/28] bin/84208 qa [sysinstall] "Leave the MBR untouched" op f [2005/08/08] bin/84667 qa [sysinstall] annoying installation proble o [2005/08/08] bin/84674 qa [sysinstall] Installer trying to install o [2005/08/28] bin/85367 qa [sysinstall] [patch] fix package categori o [2005/09/22] bin/86454 qa [sysinstall] sysinstall terminates with s o [2005/09/26] bin/86600 qa [sysinstall] Sysinstall boot manager scre o [2005/09/28] bin/86665 qa [sysinstall] sysinstall binary upgrade cl o [2005/10/03] bin/86859 qa [sysinstall] Installer should ask about L o [2005/11/11] bin/88826 qa [sysinstall] sysinstall infinity wait for o [2006/01/02] bin/91205 qa [sysinstall] sysinstall package options s o [2006/01/22] bin/92160 qa [sysinstall] [patch] Add new NTP servers o [2006/02/13] bin/93275 qa [sysinstall] Failure to install after res o [2006/02/26] bin/93853 qa [sysinstall] [patch]: Add country-specifi 79 problems total. From owner-freebsd-qa@FreeBSD.ORG Tue Feb 28 19:19:14 2006 Return-Path: X-Original-To: freebsd-qa@freebsd.org Delivered-To: freebsd-qa@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B70F16A427 for ; Tue, 28 Feb 2006 19:19:14 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id D431543D93 for ; Tue, 28 Feb 2006 19:18:56 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k1SJIlmh019026; Tue, 28 Feb 2006 14:18:54 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-qa@freebsd.org, Seth Kingsley Date: Tue, 28 Feb 2006 14:19:52 -0500 User-Agent: KMail/1.9.1 References: <200602261910.k1QJAAmZ089790@freefall.freebsd.org> In-Reply-To: <200602261910.k1QJAAmZ089790@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200602281419.53871.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1306/Tue Feb 28 04:50:04 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.4 required=4.2 tests=ALL_TRUSTED autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Subject: Re: bin/93853: [PATCH]: Add country-specific keymap selection to sysinstall X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2006 19:19:14 -0000 On Sunday 26 February 2006 14:10, Seth Kingsley wrote: > The following reply was made to PR bin/93853; it has been noted by GNATS. > > From: Seth Kingsley > To: K?vesd?n G?bor > Cc: bug-followup@FreeBSD.org > Subject: Re: bin/93853: [PATCH]: Add country-specific keymap selection to sysinstall > Date: Sun, 26 Feb 2006 11:02:51 -0800 > > On Sun, Feb 26, 2006 at 11:58:19AM +0100, K?vesd?n G?bor wrote: > > Great idea, I'd love to see it implemented. :) > > Could you possibly add Hungarian to the list, please? > > Hungary will work out of the box with this patch. I've just tested it. If > you're looking at the mappings from country to language in the diff, that's > only to handle cases where the keymap file is named after the language instead > of the 2-letter country code, such as "danish.iso", instead of "dk.iso". All > 240 countries listed in /usr/share/misc/iso3166 are included in the country > selection menu. Hmm, I tried this out. One thing I ran into just running it during multiuser is that hitting Enter didn't work in the country selection dialog. I had to hit 'O' for Ok for some reason. It works if I pick a non-default country actually, so it's something in the logic for the default country case. Hmm, I fixed this by fixing dmenuSetCountryVariable() to return DITEM_SUCCESS rather than void in the DEFAULT_COUNTRY case. That's really odd that it didn't flag that as a warning. Also, I fixed keymapMenuSelect() to correctly return a DITEM_* value if VAR_COUNTRY wasn't set (dmenuOpenSimple returns a boolean). Finally, I think that this should only popup during installs and if it is run as non-init it shouldn't pop this menu up (under the assumption that in multiuser you've already set the keymap). Updated portions of the diff look like: @@ -111,6 +112,21 @@ } int +dmenuSetCountryVariable(dialogMenuItem *tmp) +{ + variable_set((char *)tmp->data, FALSE); +#ifdef WITH_SYSCONS + /* Don't prompt the user for a keymap if they're using the default locale. */ + if (!strcmp(variable_get(VAR_COUNTRY), DEFAULT_COUNTRY)) + return DITEM_SUCCESS; + + return keymapMenuSelect(tmp); +#else + return DITEM_SUCCESS; +#endif +} ... + if ((country = variable_get(VAR_COUNTRY)) != NULL) + { + lang = country; + for (i = 0; map[i].country; ++i) + if (!strcmp(country, map[i].country)) + { + lang = map[i].lang; + break; + } + (simplified logic that defaults lang to country) ... + } + else + return dmenuOpenSimple(&MenuSysconsKeymap, FALSE) ? DITEM_SUCCESS : + DITEM_FAILURE; +} + ... @@ -158,6 +158,10 @@ systemShutdown(status); } + /* Get user's country and keymap */ + if (RunningAsInit) + configCountry(NULL); + /* Begin user dialog at outer menu */ dialog_clear(); while (1) { Does this sound ok? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-freebsd-qa@FreeBSD.ORG Tue Feb 28 20:11:12 2006 Return-Path: X-Original-To: freebsd-qa@freebsd.org Delivered-To: freebsd-qa@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D9B616A420; Tue, 28 Feb 2006 20:11:12 +0000 (GMT) (envelope-from sethk@magnesium.net) Received: from toxic.magnesium.net (toxic.magnesium.net [207.154.84.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id D950943D5D; Tue, 28 Feb 2006 20:11:11 +0000 (GMT) (envelope-from sethk@magnesium.net) Received: by toxic.magnesium.net (Postfix, from userid 1165) id 8A556DA8A0; Tue, 28 Feb 2006 12:11:11 -0800 (PST) Date: Tue, 28 Feb 2006 12:11:11 -0800 From: Seth Kingsley To: John Baldwin Message-ID: <20060228201111.GM2695@mail.meowfishies.com> References: <200602261910.k1QJAAmZ089790@freefall.freebsd.org> <200602281419.53871.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zhtSGe8h3+lMyY1M" Content-Disposition: inline In-Reply-To: <200602281419.53871.jhb@freebsd.org> X-Operating-System: FreeBSD 5.4-STABLE i386 X-GPG-Key-ID: 1024D/5C413B08 X-GPG-Key-Fingerprint: F772 5D24 02B4 D233 90F5 080F 0F50 3298 5C41 3B08 User-Agent: Mutt/1.5.11 Cc: freebsd-qa@freebsd.org Subject: Re: bin/93853: [PATCH]: Add country-specific keymap selection to sysinstall X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2006 20:11:12 -0000 --zhtSGe8h3+lMyY1M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 28, 2006 at 02:19:52PM -0500, John Baldwin wrote: > Hmm, I tried this out. One thing I ran into just running it during multi= user > is that hitting Enter didn't work in the country selection dialog. I had= to > hit 'O' for Ok for some reason. It works if I pick a non-default country > actually, so it's something in the logic for the default country case. H= mm, > I fixed this by fixing dmenuSetCountryVariable() to return DITEM_SUCCESS > rather than void in the DEFAULT_COUNTRY case. That's really odd that it > didn't flag that as a warning. Also, I fixed keymapMenuSelect() to corre= ctly > return a DITEM_* value if VAR_COUNTRY wasn't set (dmenuOpenSimple returns= a > boolean). Finally, I think that this should only popup during installs a= nd > if it is run as non-init it shouldn't pop this menu up (under the assumpt= ion > that in multiuser you've already set the keymap). Yeah, everything you've changed looks good. It occured to me last night as= I was using sysinstall to label a disk that it would be irritating for the country menu to come up post-install. Raising the WARNS to 2 shows that I also missed a restorescr(w) at the end = of configCountry(), and there are some orphaned functions sprinkled about. --=20 Seth Kingsley || sethk@magnesium.net --zhtSGe8h3+lMyY1M Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQFEBK5fD1AymFxBOwgRAjldAJ9XkQ69Hu+O3k3/7jC5RuQqZYuTrACeMpFu XhtECICThPOCMtAyZaLO8dI= =Tcof -----END PGP SIGNATURE----- --zhtSGe8h3+lMyY1M-- From owner-freebsd-qa@FreeBSD.ORG Tue Feb 28 20:30:15 2006 Return-Path: X-Original-To: freebsd-qa@hub.freebsd.org Delivered-To: freebsd-qa@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B6E0516A420 for ; Tue, 28 Feb 2006 20:30:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6164D43D49 for ; Tue, 28 Feb 2006 20:30:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1SKUFAG088560 for ; Tue, 28 Feb 2006 20:30:15 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1SKUFoK088559; Tue, 28 Feb 2006 20:30:15 GMT (envelope-from gnats) Date: Tue, 28 Feb 2006 20:30:15 GMT Message-Id: <200602282030.k1SKUFoK088559@freefall.freebsd.org> To: freebsd-qa@FreeBSD.org From: "Jose Liang" Cc: Subject: Re: bin/92160: [sysinstall] [patch] Add new NTP servers for Taiwan X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jose Liang List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2006 20:30:15 -0000 The following reply was made to PR bin/92160; it has been noted by GNATS. From: "Jose Liang" To: , Cc: Subject: Re: bin/92160: [sysinstall] [patch] Add new NTP servers for Taiwan Date: Wed, 1 Mar 2006 04:29:07 +0800 The following is the latest result with 6.1-PRELEASE: --- /usr/src/usr.sbin/sysinstall/menus.c Sat Feb 18 01:21:55 2006 +++ ./menus.c Wed Mar 1 04:24:38 2006 @@ -1732,6 +1732,21 @@ { "Scotland", "ntp.cs.strath.ac.uk", dmenuVarsCheck, dmenuSetVariables, NULL, "ntpdate_enable=YES,ntpdate_flags=ntp.cs.strath.ac.uk" }, + { "Taiwan", "time.stdtime.gov.tw", + dmenuVarsCheck, dmenuSetVariables, NULL, + "ntpdate_enable=YES,ntpdate_flags=time.stdtime.gov.tw" }, + { "Taiwan #2", "clock.stdtime.gov.tw", + dmenuVarsCheck, dmenuSetVariables, NULL, + "ntpdate_enable=YES,ntpdate_flags=clock.stdtime.gov.tw" }, + { "Taiwan #3", "tick.stdtime.gov.tw", + dmenuVarsCheck, dmenuSetVariables, NULL, + "ntpdate_enable=YES,ntpdate_flags=tick.stdtime.gov.tw" }, + { "Taiwan #4", "tock.stdtime.gov.tw", + dmenuVarsCheck, dmenuSetVariables, NULL, + "ntpdate_enable=YES,ntpdate_flags=tock.stdtime.gov.tw" }, + { "Taiwan #5", "watch.stdtime.gov.tw", + dmenuVarsCheck, dmenuSetVariables, NULL, + "ntpdate_enable=YES,ntpdate_flags=watch.stdtime.gov.tw" }, { "United Kingdom", "uk.pool.ntp.org", dmenuVarsCheck, dmenuSetVariables, NULL, "ntpdate_enable=YES,ntpdate_flags=uk.pool.ntp.org" }, From owner-freebsd-qa@FreeBSD.ORG Tue Feb 28 21:44:42 2006 Return-Path: X-Original-To: freebsd-qa@hub.freebsd.org Delivered-To: freebsd-qa@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E18A116A422; Tue, 28 Feb 2006 21:44:42 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DC9E43D68; Tue, 28 Feb 2006 21:44:42 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from freefall.freebsd.org (jhb@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1SLigBQ096075; Tue, 28 Feb 2006 21:44:42 GMT (envelope-from jhb@freefall.freebsd.org) Received: (from jhb@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1SLigEu096071; Tue, 28 Feb 2006 21:44:42 GMT (envelope-from jhb) Date: Tue, 28 Feb 2006 21:44:42 GMT From: John Baldwin Message-Id: <200602282144.k1SLigEu096071@freefall.freebsd.org> To: sethk@magnesium.net, jhb@FreeBSD.org, freebsd-qa@FreeBSD.org, jhb@FreeBSD.org Cc: Subject: Re: bin/93853: [sysinstall] [patch]: Add country-specific keymap selection to sysinstall X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2006 21:44:43 -0000 Synopsis: [sysinstall] [patch]: Add country-specific keymap selection to sysinstall State-Changed-From-To: open->patched State-Changed-By: jhb State-Changed-When: Tue Feb 28 21:44:15 UTC 2006 State-Changed-Why: Committed to HEAD, hopefully will be MFC'd for 6.1. Responsible-Changed-From-To: freebsd-qa->jhb Responsible-Changed-By: jhb Responsible-Changed-When: Tue Feb 28 21:44:15 UTC 2006 Responsible-Changed-Why: Committed to HEAD, hopefully will be MFC'd for 6.1. http://www.freebsd.org/cgi/query-pr.cgi?pr=93853 From owner-freebsd-qa@FreeBSD.ORG Wed Mar 1 18:38:31 2006 Return-Path: X-Original-To: freebsd-qa@hub.freebsd.org Delivered-To: freebsd-qa@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF41E16A422; Wed, 1 Mar 2006 18:38:31 +0000 (GMT) (envelope-from ceri@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 65B3D43D53; Wed, 1 Mar 2006 18:38:31 +0000 (GMT) (envelope-from ceri@FreeBSD.org) Received: from freefall.freebsd.org (ceri@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k21IcVAG076732; Wed, 1 Mar 2006 18:38:31 GMT (envelope-from ceri@freefall.freebsd.org) Received: (from ceri@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k21IcUg3076728; Wed, 1 Mar 2006 18:38:30 GMT (envelope-from ceri) Date: Wed, 1 Mar 2006 18:38:30 GMT From: Ceri Davies Message-Id: <200603011838.k21IcUg3076728@freefall.freebsd.org> To: jose@jose.idv.tw, ceri@FreeBSD.org, freebsd-qa@FreeBSD.org, ceri@FreeBSD.org Cc: Subject: Re: bin/92160: [sysinstall] [patch] Add new NTP servers for Taiwan X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2006 18:38:31 -0000 Synopsis: [sysinstall] [patch] Add new NTP servers for Taiwan State-Changed-From-To: open->patched State-Changed-By: ceri State-Changed-When: Wed Mar 1 18:37:52 UTC 2006 State-Changed-Why: Committed to -HEAD; will try to get this into 6.1 and 5.5 releases. Responsible-Changed-From-To: freebsd-qa->ceri Responsible-Changed-By: ceri Responsible-Changed-When: Wed Mar 1 18:37:52 UTC 2006 Responsible-Changed-Why: Committed to -HEAD; will try to get this into 6.1 and 5.5 releases. http://www.freebsd.org/cgi/query-pr.cgi?pr=92160 From owner-freebsd-qa@FreeBSD.ORG Sat Mar 4 12:36:57 2006 Return-Path: X-Original-To: freebsd-qa@hub.freebsd.org Delivered-To: freebsd-qa@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 851E716A422; Sat, 4 Mar 2006 12:36:57 +0000 (GMT) (envelope-from matteo@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D6E943D46; Sat, 4 Mar 2006 12:36:57 +0000 (GMT) (envelope-from matteo@FreeBSD.org) Received: from freefall.freebsd.org (matteo@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k24CavVq018485; Sat, 4 Mar 2006 12:36:57 GMT (envelope-from matteo@freefall.freebsd.org) Received: (from matteo@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k24CaugU018481; Sat, 4 Mar 2006 12:36:56 GMT (envelope-from matteo) Date: Sat, 4 Mar 2006 12:36:56 GMT From: Matteo Riondato Message-Id: <200603041236.k24CaugU018481@freefall.freebsd.org> To: peter@holm.cc, matteo@FreeBSD.org, freebsd-qa@FreeBSD.org Cc: Subject: Re: bin/12324: [sysinstall] fdisk partition editor is missing ">" flag for new slice X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2006 12:36:57 -0000 Synopsis: [sysinstall] fdisk partition editor is missing ">" flag for new slice State-Changed-From-To: open->closed State-Changed-By: matteo State-Changed-When: Sat Mar 4 12:36:33 UTC 2006 State-Changed-Why: This seems not to be a problem any longer http://www.freebsd.org/cgi/query-pr.cgi?pr=12324