From owner-freebsd-rc@FreeBSD.ORG Tue Apr 18 11:53:28 2006 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C68AD16A402; Tue, 18 Apr 2006 11:53:28 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C93C043D6E; Tue, 18 Apr 2006 11:53:27 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from freefall.freebsd.org (flz@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k3IBrRb8043646; Tue, 18 Apr 2006 11:53:27 GMT (envelope-from flz@freefall.freebsd.org) Received: (from flz@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k3IBrRJF043642; Tue, 18 Apr 2006 11:53:27 GMT (envelope-from flz) Date: Tue, 18 Apr 2006 11:53:27 GMT From: Florent Thoumie Message-Id: <200604181153.k3IBrRJF043642@freefall.freebsd.org> To: oliver@freebsd.org, flz@FreeBSD.org, freebsd-rc@FreeBSD.org Cc: Subject: Re: conf/73909: [patch] rc.d/sshd does not work with ports-ssh X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2006 11:53:28 -0000 Synopsis: [patch] rc.d/sshd does not work with ports-ssh State-Changed-From-To: open->patched State-Changed-By: flz State-Changed-When: Tue Apr 18 11:53:05 UTC 2006 State-Changed-Why: I committed a fix some days ago. I'm waiting for the freeze to end to MFC this change to RELENG_[56]. http://www.freebsd.org/cgi/query-pr.cgi?pr=73909 From owner-freebsd-rc@FreeBSD.ORG Wed Apr 19 01:03:52 2006 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1035) id DBC4516A403; Wed, 19 Apr 2006 01:03:52 +0000 (UTC) Date: Wed, 19 Apr 2006 01:03:52 +0000 From: Xin LI To: freebsd-rc@FreeBSD.org Message-ID: <20060419010352.GA54006@hub.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline User-Agent: Mutt/1.4.2.1i Cc: Subject: rc.d/SERVER patch for review (Reorder to make ldconfig start _before_ SERVER) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 01:03:52 -0000 --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Here is a patch that moves ldconfig before SERVER. The reason is that: - Now we start /usr/local/etc/rc.d scripts in the same order of base system rc.d scripts. - It is possible that a dynamically linked local daemon is started after SERVER, which requires ldconfig to be run before to function correctly. - According to the current rcorder ldconfig would start _after_ SERVER, which makes no guarantee that it was run before actual consumer. The attachment contains a tested patch that makes ldconfig a dependency of SERVER, thus makes it available for the application before actual SERVER daemons. Any comments? Thanks in advance! Cheers, --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=patch-rcng Index: SERVERS =================================================================== RCS file: /home/ncvs/src/etc/rc.d/SERVERS,v retrieving revision 1.6 diff -u -r1.6 SERVERS --- SERVERS 19 Feb 2006 08:18:48 -0000 1.6 +++ SERVERS 18 Apr 2006 13:38:33 -0000 @@ -5,7 +5,7 @@ # # PROVIDE: SERVERS -# REQUIRE: mountcritremote abi +# REQUIRE: mountcritremote abi ldconfig # This is a dummy dependency, for early-start servers relying on # some basic configuration. --LQksG6bCIzRHxTLp-- From owner-freebsd-rc@FreeBSD.ORG Wed Apr 19 04:06:40 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CCCD716A403; Wed, 19 Apr 2006 04:06:40 +0000 (UTC) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7CE6343D46; Wed, 19 Apr 2006 04:06:40 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k3J46d9G002125; Tue, 18 Apr 2006 21:06:39 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k3J46d9Z002124; Tue, 18 Apr 2006 21:06:39 -0700 Date: Tue, 18 Apr 2006 21:06:39 -0700 From: Brooks Davis To: Xin LI Message-ID: <20060419040639.GB30862@odin.ac.hmc.edu> References: <20060419010352.GA54006@hub.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jq0ap7NbKX2Kqbes" Content-Disposition: inline In-Reply-To: <20060419010352.GA54006@hub.freebsd.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org Subject: Re: rc.d/SERVER patch for review (Reorder to make ldconfig start _before_ SERVER) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 04:06:40 -0000 --jq0ap7NbKX2Kqbes Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 19, 2006 at 01:03:52AM +0000, Xin LI wrote: > Hi, >=20 > Here is a patch that moves ldconfig before SERVER. The reason is that: >=20 > - Now we start /usr/local/etc/rc.d scripts in the same order of base > system rc.d scripts. > - It is possible that a dynamically linked local daemon is started > after SERVER, which requires ldconfig to be run before to function > correctly. > - According to the current rcorder ldconfig would start _after_ SERVER, > which makes no guarantee that it was run before actual consumer. >=20 > The attachment contains a tested patch that makes ldconfig a dependency > of SERVER, thus makes it available for the application before actual > SERVER daemons. >=20 > Any comments? Seem harmless other than the fact that it makes it easy to incorrectly start services before DAEMON. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --jq0ap7NbKX2Kqbes Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFERbdOXY6L6fI4GtQRAnHpAKCk+yj6bHb7/h5boR5rJn+6grxmSACgipHs sCpL2mIeThXiaGaTN8170aM= =QkJp -----END PGP SIGNATURE----- --jq0ap7NbKX2Kqbes-- From owner-freebsd-rc@FreeBSD.ORG Wed Apr 19 08:14:04 2006 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 438FD16A401; Wed, 19 Apr 2006 08:14:04 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id CAD7F43D45; Wed, 19 Apr 2006 08:14:03 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id B30ED114B8; Wed, 19 Apr 2006 10:14:02 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 07135-06; Wed, 19 Apr 2006 10:13:54 +0200 (CEST) Received: from cream.stl.xbsd.org (unknown [193.120.13.130]) by smtp.xbsd.org (Postfix) with ESMTP id 0372511498; Wed, 19 Apr 2006 10:13:53 +0200 (CEST) From: Florent Thoumie To: Xin LI In-Reply-To: <20060419010352.GA54006@hub.freebsd.org> References: <20060419010352.GA54006@hub.freebsd.org> Content-Type: text/plain Date: Wed, 19 Apr 2006 09:13:49 +0200 Message-Id: <1145430829.900.20.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@FreeBSD.org Subject: Re: rc.d/SERVER patch for review (Reorder to make ldconfig start _before_ SERVER) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 08:14:04 -0000 On Wed, 2006-04-19 at 01:03 +0000, Xin LI wrote: > Hi, > > Here is a patch that moves ldconfig before SERVER. The reason is that: > > - Now we start /usr/local/etc/rc.d scripts in the same order of base > system rc.d scripts. > - It is possible that a dynamically linked local daemon is started > after SERVER, which requires ldconfig to be run before to function > correctly. > - According to the current rcorder ldconfig would start _after_ SERVER, > which makes no guarantee that it was run before actual consumer. > > The attachment contains a tested patch that makes ldconfig a dependency > of SERVER, thus makes it available for the application before actual > SERVER daemons. > > Any comments? I'd rather like seeing ports rc.d scripts fixed to require either DAEMON or LOGIN, depending on if they should run as root or not. After my latest commit to rc.d/named, ldconfig is started right after mountcritremote (means ASAP), so this change doesn't really do anything. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Wed Apr 19 09:02:31 2006 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 59C7316A406; Wed, 19 Apr 2006 09:02:31 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [210.51.165.229]) by mx1.FreeBSD.org (Postfix) with ESMTP id 262A643D53; Wed, 19 Apr 2006 09:02:29 +0000 (GMT) (envelope-from delphij@delphij.net) Received: from localhost (tarsier.geekcn.org [210.51.165.229]) by tarsier.geekcn.org (Postfix) with ESMTP id 8FDA7EB3C8D; Wed, 19 Apr 2006 17:02:27 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([210.51.165.229]) by localhost (mail.geekcn.org [210.51.165.229]) (amavisd-new, port 10024) with ESMTP id 48oyvLcwMupi; Wed, 19 Apr 2006 17:02:25 +0800 (CST) Received: from [10.217.12.81] (sina152-194.staff.sina.com.cn [61.135.152.194]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTP id 84D1BEB3CCE; Wed, 19 Apr 2006 17:02:24 +0800 (CST) From: Xin LI To: Florent Thoumie In-Reply-To: <1145430829.900.20.camel@localhost> References: <20060419010352.GA54006@hub.freebsd.org> <1145430829.900.20.camel@localhost> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-WvzIz2QKFo0Mqb1RzkBg" Organization: The FreeBSD Project Date: Wed, 19 Apr 2006 17:02:19 +0800 Message-Id: <1145437339.924.31.camel@spirit> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port Cc: freebsd-rc@FreeBSD.org Subject: Re: rc.d/SERVER patch for review (Reorder to make ldconfig start _before_ SERVER) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 09:02:31 -0000 --=-WvzIz2QKFo0Mqb1RzkBg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, Florent, =E5=9C=A8 2006-04-19=E4=B8=89=E7=9A=84 09:13 +0200=EF=BC=8CFlorent Thoumie= =E5=86=99=E9=81=93=EF=BC=9A [...] > I'd rather like seeing ports rc.d scripts fixed to require either DAEMON > or LOGIN, depending on if they should run as root or not. >=20 > After my latest commit to rc.d/named, ldconfig is started right after > mountcritremote (means ASAP), so this change doesn't really do anything. I would prefer that SERVERS to do REQUIRE: ldconfig for the following reasons: - SERVERS is the place (or divider) where we can ensure, say, critical early services, can start properly. We should implement the semantic. - Currently SERVERS already have a REQUIRE: line pointing to abi, which is, in my opinion, of the same nature with ldconfig. - With "BEFORE: named" we can effectively make ldconfig to run after our script. While BEFORE is generally not encouraged, I think it's confusing for programmer who writes rc.d scripts, and makes it hard to debug. Therefore I think making SERVERS to REQUIRE: ldconfig makes better protection for early startup daemons. Cheers, --=20 Xin LI http://www.delphij.net/ --=-WvzIz2QKFo0Mqb1RzkBg Content-Type: application/pgp-signature; name=signature.asc Content-Description: =?UTF-8?Q?=E8=BF=99=E6=98=AF=E4=BF=A1=E4=BB=B6=E7=9A=84=E6=95=B0?= =?UTF-8?Q?=E5=AD=97=E7=AD=BE=E5=90=8D=E9=83=A8=E5=88=86?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBERfybhcUczkLqiksRAvDgAKDWYAdAAB4yoB+LtxHsBmvll3mCggCg6ZdM /Y9o9YKRvyb4yuXo1epZjmk= =6lQ6 -----END PGP SIGNATURE----- --=-WvzIz2QKFo0Mqb1RzkBg-- From owner-freebsd-rc@FreeBSD.ORG Wed Apr 19 09:37:00 2006 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1129E16A401 for ; Wed, 19 Apr 2006 09:37:00 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 817D643D45 for ; Wed, 19 Apr 2006 09:36:59 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 20BA211A13; Wed, 19 Apr 2006 11:36:58 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 08337-02; Wed, 19 Apr 2006 11:36:51 +0200 (CEST) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id 5AE75118EB; Wed, 19 Apr 2006 11:36:51 +0200 (CEST) From: Florent Thoumie To: Xin LI In-Reply-To: <1145437339.924.31.camel@spirit> References: <20060419010352.GA54006@hub.freebsd.org> <1145430829.900.20.camel@localhost> <1145437339.924.31.camel@spirit> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-/U8JM8h5EVV52ZEtWjZH" Date: Wed, 19 Apr 2006 10:36:49 +0100 Message-Id: <1145439409.83576.44.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@FreeBSD.org Subject: Re: rc.d/SERVER patch for review (Reorder to make ldconfig start _before_ SERVER) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 09:37:00 -0000 --=-/U8JM8h5EVV52ZEtWjZH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 2006-04-19 at 17:02 +0800, Xin LI wrote: > Hi, Florent, >=20 > =E5=9C=A8 2006-04-19=E4=B8=89=E7=9A=84 09:13 +0200=EF=BC=8CFlorent Thoumi= e=E5=86=99=E9=81=93=EF=BC=9A > [...] > > I'd rather like seeing ports rc.d scripts fixed to require either DAEMO= N > > or LOGIN, depending on if they should run as root or not. > >=20 > > After my latest commit to rc.d/named, ldconfig is started right after > > mountcritremote (means ASAP), so this change doesn't really do anything= . >=20 > I would prefer that SERVERS to do REQUIRE: ldconfig for the following > reasons: > - SERVERS is the place (or divider) where we can ensure, say, critical > early services, can start properly. We should implement the semantic. > - Currently SERVERS already have a REQUIRE: line pointing to abi, which > is, in my opinion, of the same nature with ldconfig. > - With "BEFORE: named" we can effectively make ldconfig to run after > our script. While BEFORE is generally not encouraged, I think it's > confusing for programmer who writes rc.d scripts, and makes it hard to > debug. >=20 > Therefore I think making SERVERS to REQUIRE: ldconfig makes better > protection for early startup daemons. Ok, that makes sense. Feel free to backout my named change. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --=-/U8JM8h5EVV52ZEtWjZH Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBERgSxMxEkbVFH3PQRAl+PAJ0bg1zxk7ImEuxguPMif79j0PRmCQCgh3/L Lx115I+/hr10uvV/CG8+PMk= =2arZ -----END PGP SIGNATURE----- --=-/U8JM8h5EVV52ZEtWjZH-- From owner-freebsd-rc@FreeBSD.ORG Wed Apr 19 17:14:14 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B18916A401; Wed, 19 Apr 2006 17:14:14 +0000 (UTC) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1197943D46; Wed, 19 Apr 2006 17:14:14 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k3JHEDi7015882; Wed, 19 Apr 2006 10:14:13 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k3JHEDML015881; Wed, 19 Apr 2006 10:14:13 -0700 Date: Wed, 19 Apr 2006 10:14:13 -0700 From: Brooks Davis To: Florent Thoumie Message-ID: <20060419171413.GB11251@odin.ac.hmc.edu> References: <20060419010352.GA54006@hub.freebsd.org> <1145430829.900.20.camel@localhost> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b5gNqxB1S1yM7hjW" Content-Disposition: inline In-Reply-To: <1145430829.900.20.camel@localhost> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org Subject: Re: rc.d/SERVER patch for review (Reorder to make ldconfig start _before_ SERVER) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 17:14:14 -0000 --b5gNqxB1S1yM7hjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 19, 2006 at 09:13:49AM +0200, Florent Thoumie wrote: > On Wed, 2006-04-19 at 01:03 +0000, Xin LI wrote: > > Hi, > >=20 > > Here is a patch that moves ldconfig before SERVER. The reason is that: > >=20 > > - Now we start /usr/local/etc/rc.d scripts in the same order of base > > system rc.d scripts. > > - It is possible that a dynamically linked local daemon is started > > after SERVER, which requires ldconfig to be run before to function > > correctly. > > - According to the current rcorder ldconfig would start _after_ SERVER, > > which makes no guarantee that it was run before actual consumer. > >=20 > > The attachment contains a tested patch that makes ldconfig a dependency > > of SERVER, thus makes it available for the application before actual > > SERVER daemons. > >=20 > > Any comments? >=20 > I'd rather like seeing ports rc.d scripts fixed to require either DAEMON > or LOGIN, depending on if they should run as root or not. I'd like to see this added to portlint as a warning if possible. I haven't looked into it enough to know how hard that would be. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --b5gNqxB1S1yM7hjW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFERm/lXY6L6fI4GtQRAnGGAKCsNMthgsxmBoxrP2N/PQ7Uf1pjXwCgohRE qqRs4fqnDBWowobFuJdbySI= =cjsV -----END PGP SIGNATURE----- --b5gNqxB1S1yM7hjW-- From owner-freebsd-rc@FreeBSD.ORG Fri Apr 21 13:59:35 2006 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B7FE16A403 for ; Fri, 21 Apr 2006 13:59:35 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id C725843D46 for ; Fri, 21 Apr 2006 13:59:34 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id C498D118EB for ; Fri, 21 Apr 2006 15:59:33 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 57687-04 for ; Fri, 21 Apr 2006 15:59:24 +0200 (CEST) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id D299811A3D for ; Fri, 21 Apr 2006 15:59:23 +0200 (CEST) From: Florent Thoumie To: freebsd-rc@FreeBSD.org Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-8VvA7QWnQGm0CopccqJe" Date: Fri, 21 Apr 2006 14:59:22 +0100 Message-Id: <1145627962.83576.68.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: Subject: RFC: rc.subr changes X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Apr 2006 13:59:35 -0000 --=-8VvA7QWnQGm0CopccqJe Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I'd like to commit the following patches, but I'm welcoming any input I can get before doing so : http://people.freebsd.org/~flz/local/rc.subr-defaults.diff The point is to be able in the (near) future to add some features to bsd.port.mk like a ENABLE_RC_SCRIPT variable to automatically set *_enable variable in ${PREFIX}/etc/defaults/$name. Maintainers would be able to install default configuration flags in this file via a USE_RC_DEFAULTS variable (pretty much like what /etc/defaults/rc.conf does, but for ports/packages). This file would be overwritten each time the port/package is installed. Local specific configuration can already be done in ${PREFIX}/etc/rc.conf.d/$name, so that's another step towards ${PREFIX}-clean ports. Note: part of the patch is s/command/name/g, that's related to a previous commit I did to rc.subr, I just forgot to update the man page (no cookie). --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --=-8VvA7QWnQGm0CopccqJe Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBESOU6MxEkbVFH3PQRAjjpAKCIn1JQAxCQIvAWp1RW+bpmCL4XwgCdFWGC kA2SfUpy68jb6vijHJzmRVc= =mPQL -----END PGP SIGNATURE----- --=-8VvA7QWnQGm0CopccqJe--