From owner-p4-projects@FreeBSD.ORG  Sun Jun 18 02:38:15 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2109316A481; Sun, 18 Jun 2006 02:38:15 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CFE5916A47D;
	Sun, 18 Jun 2006 02:38:14 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 79EA543D46;
	Sun, 18 Jun 2006 02:38:14 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [IPv6:::1] (may be forged))
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k5I2Z8qH012692;
	Sat, 17 Jun 2006 20:35:08 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Sat, 17 Jun 2006 20:35:23 -0600 (MDT)
Message-Id: <20060617.203523.353410589.imp@bsdimp.com>
To: ryanb@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200606150629.k5F6T1lO099650@repoman.freebsd.org>
References: <200606150629.k5F6T1lO099650@repoman.freebsd.org>
X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 99283 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Jun 2006 02:38:15 -0000

In message: <200606150629.k5F6T1lO099650@repoman.freebsd.org>
            Ryan Beasley <ryanb@freebsd.org> writes:
: http://perforce.freebsd.org/chv.cgi?CH=99283
: 
: Change 99283 by ryanb@ryanb_yuki on 2006/06/15 06:28:44
: 
: 	Correct misuse of strncpy's length argument.
: 
: Affected files ...
: 
: .. //depot/projects/soc2006/rbeasley_sound/sys/dev/sound/pcm/sound.c#3 edit
: 
: Differences ...
: 
: ==== //depot/projects/soc2006/rbeasley_sound/sys/dev/sound/pcm/sound.c#3 (text+ko) ====
: 
: @@ -1140,8 +1140,8 @@
:  	static char si_product[] = "OSS/FreeBSD";
:  	static char si_version[] = "4.0.0a";
:  
: -	strncpy(si->product, si_product, sizeof(si->product));
: -	strncpy(si->version, si_version, sizeof(si->version));
: +	strncpy(si->product, si_product, sizeof(si->product) - 1);
: +	strncpy(si->version, si_version, sizeof(si->version) - 1);
:  	si->versionnum = SOUND_VERSION;
:  	si->numaudios = (pcm_devclass != NULL) ?
:  	    		devclass_get_count(pcm_devclass) :

strlcpy likely is better.

Warner