From owner-freebsd-current@FreeBSD.ORG  Sun May 11 00:59:54 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2E1351065671;
	Sun, 11 May 2008 00:59:54 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id 8566E8FC0A;
	Sun, 11 May 2008 00:59:53 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.14.2/8.14.2) with ESMTP id m4B0kA7t067436;
	Sun, 11 May 2008 04:46:10 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru;
	s=default; t=1210466770; bh=P1IItXsvyv1j8cOft3UzX51UZYCjTgQh18aXJMj
	Eomg=; l=1242; h=Date:From:To:Subject:Message-ID:MIME-Version:
	Content-Type; b=f4cNcKhZLuZajg3V/u1ZD+GwI7mo51oPwKGxBqoGLmxXoqBE7u
	0i7pa/cUX70Aa3qDJhO8i56VgfwKGDx01hAPC5ajX6wnXswJnEHqp9e6noOV5sreoMt
	CLndcXtHGNVluS0HiBCp3nTA69Kdb9832XiutJaxAVdkwzxlDhwROk=
Received: (from ache@localhost)
	by nagual.pp.ru (8.14.2/8.14.2/Submit) id m4B0k904067435;
	Sun, 11 May 2008 04:46:09 +0400 (MSD) (envelope-from ache)
Date: Sun, 11 May 2008 04:46:08 +0400
From: Andrey Chernov <ache@nagual.pp.ru>
To: sos@freebsd.org, grehan@freebsd.org, current@freebsd.org
Message-ID: <20080511004607.GA67182@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@nagual.pp.ru>, sos@freebsd.org,
	grehan@FreeBSD.ORG, current@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: 
Subject: atadev->param.model problem or bug with Marvell 88SE6811 chip
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 May 2008 00:59:54 -0000

I have device detection problem with device attached to
atapci0: <Marvell ATA controller> port 0xec00-0xec07,0xe880-0xe883,0xe800-0xe807,0xe480-0xe483,0xe400-0xe40f mem 0xfebffc00-0xfebfffff irq 16 at device 0.0 on pci3
(ASUS P5E3 motherboard).
It seems that this controller not fills atadev->param.model as current 
ata-all.c code expects:

    if (!error && (isprint(atadev->param.model[0]) ||
		   isprint(atadev->param.model[1]))) {

so whole probe is just skipped!
Namely it not pass printable atadev->param.model[0] or 
atadev->param.model[0] chars.

Here is 2 devices (master/slave) param.model hexdump and some debugging info:

command ATA_ATAPI_IDENTIFY
error 0
model 00:00:20:20:00:00:20:20:00:00:20:20:00:00:20:20:00:00:20:20:00:00:20:20:00:00:00:00:00:00:00:00:00:00:00:00:00:00:2e:31
      ^^ ^^
...
command ATA_ATAPI_IDENTIFY
error 0
model 00:00:37:31:00:00:34:32:00:00:20:20:00:00:20:20:00:00:20:20:00:00:20:20:00:00:00:00:00:00:00:00:00:00:00:00:00:00:2e:31
      ^^ ^^
As you can see, both first bytes are NULs. Those devices works perfectly
under M$ Win. I don't familiar with ATA specs. Is there some ideas
why it happens, what is the right fix or possible workaround?

-- 
http://ache.pp.ru/