From owner-cvs-src@FreeBSD.ORG Tue Aug 3 22:51:51 2010 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15B19106566C; Tue, 3 Aug 2010 22:51:51 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id E2E188FC1C; Tue, 3 Aug 2010 22:51:50 +0000 (UTC) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id 7D00B46B35; Tue, 3 Aug 2010 18:51:50 -0400 (EDT) Date: Tue, 3 Aug 2010 23:51:50 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Attilio Rao In-Reply-To: <200711142121.lAELLmo4018474@repoman.freebsd.org> Message-ID: References: <200711142121.lAELLmo4018474@repoman.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: alfred@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_rwlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2010 22:51:51 -0000 On Wed, 14 Nov 2007, Attilio Rao wrote: > attilio 2007-11-14 21:21:48 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_rwlock.c > Log: > Remove a bogus KASSERT which will prevent rwlock to be acquired > recursively in exclusive mode with debugging kernels. > > Submitted by: kmacy > Approved by: jeff > > Revision Changes Path > 1.30 +0 -3 src/sys/kern/kern_rwlock.c Hi Attilio-- This bug seems also to affect the 6.x backport of rwlocks that Alfred did. Might either you or Alfred consider doing an MFC of this change? Without it, recursive write locks on rwlocks are broken with INVARIANTS enabled. Thanks, Robert From owner-cvs-src@FreeBSD.ORG Wed Aug 4 13:19:21 2010 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41F4B1065677; Wed, 4 Aug 2010 13:19:21 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 543D98FC14; Wed, 4 Aug 2010 13:19:20 +0000 (UTC) Received: by wyj26 with SMTP id 26so6772276wyj.13 for ; Wed, 04 Aug 2010 06:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=rGWj638zwpW11cpy1lTACcbjNYyNKP5sSOvbf1+X4lI=; b=r1qoIXpTZGfU7YVIw09RosfUih1ONMeUT225Xwnwi+H1pObdKXd8wnr2hCHl3gVQ5L SEAjQmPZnvxefs2aqCTICoDMJkVln6ey1OwuOzJRNQbl/7+UDGrloPmW1r3b0g0etLJ6 SJutlEnpKzmo3dV3m89CmRxoTtBJ0yIVEFC3Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=mtHrYt9kx1gLmjtrA7sMOVo+YYhQnreYxlWxcFz9TFr8W+8DhpLbgOEBC2gEZAw/aw KoYjWN3Fmnq3qeuro8CjrMhlqvpkGAZVW4qd/QZRpi+4rfjd7MT/hqY8gdetYkqU4HaX TOe5Dp4yj1Kb3hjt9njKIHI/lSraN9G7mlcYA= MIME-Version: 1.0 Received: by 10.216.169.80 with SMTP id m58mr7672158wel.79.1280926256098; Wed, 04 Aug 2010 05:50:56 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.216.238.16 with HTTP; Wed, 4 Aug 2010 05:50:55 -0700 (PDT) In-Reply-To: References: <200711142121.lAELLmo4018474@repoman.freebsd.org> Date: Wed, 4 Aug 2010 14:50:55 +0200 X-Google-Sender-Auth: 9R_dKFuPcFCUSlXK0SYkBJTLHjc Message-ID: From: Attilio Rao To: Robert Watson Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, alfred@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_rwlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2010 13:19:21 -0000 2010/8/4 Robert Watson : > On Wed, 14 Nov 2007, Attilio Rao wrote: > >> attilio =C2=A0 =C2=A0 2007-11-14 21:21:48 UTC >> >> =C2=A0FreeBSD src repository >> >> =C2=A0Modified files: >> =C2=A0 sys/kern =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 kern_rwlock.c >> =C2=A0Log: >> =C2=A0Remove a bogus KASSERT which will prevent rwlock to be acquired >> =C2=A0recursively in exclusive mode with debugging kernels. >> >> =C2=A0Submitted by: kmacy >> =C2=A0Approved by: jeff >> >> =C2=A0Revision =C2=A0Changes =C2=A0 =C2=A0Path >> =C2=A01.30 =C2=A0 =C2=A0 =C2=A0+0 -3 =C2=A0 =C2=A0 =C2=A0src/sys/kern/ke= rn_rwlock.c > > Hi Attilio-- > > This bug seems also to affect the 6.x backport of rwlocks that Alfred did= . > Might either you or Alfred consider doing an MFC of this change? =C2=A0Wi= thout > it, recursive write locks on rwlocks are broken with INVARIANTS enabled. Thanks for signaling this, I'll take care. Attilio --=20 Peace can only be achieved by understanding - A. Einstein From owner-cvs-src@FreeBSD.ORG Wed Aug 4 13:21:16 2010 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2FD73106567E; Wed, 4 Aug 2010 13:21:16 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id F393C8FC21; Wed, 4 Aug 2010 13:21:14 +0000 (UTC) Received: by wyj26 with SMTP id 26so6774630wyj.13 for ; Wed, 04 Aug 2010 06:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=uvnV4n9W0xFr4u4HInqbNtdf9G0LESp6KQjy30r9vlI=; b=k/CNB7HZ9u8iZCw76aF2qIAUVw7guDQ0HsFU580Y3NTPwsn+pJbKQ3MuwkPMU2iqvf TDY8YOnKnwMvTz7tOAE5e+i0/zbUqqUFd7FylU7wUopyvwRXGyH0s7CTFaMZFt/eg5wa RJE3roAGGFAlGb/q3HinhbdiNbnyuzvYA2fnQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=x+BCLhbYCkXQO4nnBy/EBgpurfOBvmUJEfjf9cnMwjFj4pJGxogt1pNqn9oBhdmrza J45fsYPQ3/2D8aFWtqsMF3HYkXwgliyLoPywRt7oWW7DfpWeN17skpaum+41ypfvUVne HFATViOTTAR7Ql+s0EWByBTltgGPleLkYBQ3g= MIME-Version: 1.0 Received: by 10.216.10.145 with SMTP id 17mr7705682wev.27.1280928060438; Wed, 04 Aug 2010 06:21:00 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.216.238.16 with HTTP; Wed, 4 Aug 2010 06:21:00 -0700 (PDT) In-Reply-To: References: <200711142121.lAELLmo4018474@repoman.freebsd.org> Date: Wed, 4 Aug 2010 15:21:00 +0200 X-Google-Sender-Auth: cIg_Za3PLiUjVB_afbDrIudGrqc Message-ID: From: Attilio Rao To: Robert Watson Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, alfred@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_rwlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2010 13:21:16 -0000 2010/8/4 Attilio Rao : > 2010/8/4 Robert Watson : >> On Wed, 14 Nov 2007, Attilio Rao wrote: >> >>> attilio =C2=A0 =C2=A0 2007-11-14 21:21:48 UTC >>> >>> =C2=A0FreeBSD src repository >>> >>> =C2=A0Modified files: >>> =C2=A0 sys/kern =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 kern_rwlock.c >>> =C2=A0Log: >>> =C2=A0Remove a bogus KASSERT which will prevent rwlock to be acquired >>> =C2=A0recursively in exclusive mode with debugging kernels. >>> >>> =C2=A0Submitted by: kmacy >>> =C2=A0Approved by: jeff >>> >>> =C2=A0Revision =C2=A0Changes =C2=A0 =C2=A0Path >>> =C2=A01.30 =C2=A0 =C2=A0 =C2=A0+0 -3 =C2=A0 =C2=A0 =C2=A0src/sys/kern/k= ern_rwlock.c >> >> Hi Attilio-- >> >> This bug seems also to affect the 6.x backport of rwlocks that Alfred di= d. >> Might either you or Alfred consider doing an MFC of this change? =C2=A0W= ithout >> it, recursive write locks on rwlocks are broken with INVARIANTS enabled. > > Thanks for signaling this, I'll take care. r210844 may have fixed this. Thanks, Attilio --=20 Peace can only be achieved by understanding - A. Einstein From owner-cvs-src@FreeBSD.ORG Wed Aug 4 16:05:46 2010 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACFDD106566B; Wed, 4 Aug 2010 16:05:46 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 810FD8FC27; Wed, 4 Aug 2010 16:05:46 +0000 (UTC) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id 31E2A46BA3; Wed, 4 Aug 2010 12:05:46 -0400 (EDT) Date: Wed, 4 Aug 2010 17:05:46 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Attilio Rao In-Reply-To: Message-ID: References: <200711142121.lAELLmo4018474@repoman.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="621616949-1319501039-1280937946=:46788" Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, alfred@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_rwlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2010 16:05:46 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --621616949-1319501039-1280937946=:46788 Content-Type: TEXT/PLAIN; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Wed, 4 Aug 2010, Attilio Rao wrote: >>> This bug seems also to affect the 6.x backport of rwlocks that Alfred did. >>> Might either you or Alfred consider doing an MFC of this change?  Without >>> it, recursive write locks on rwlocks are broken with INVARIANTS enabled. >> >> Thanks for signaling this, I'll take care. > > r210844 may have fixed this. An identical patch applied locally to my 6.1 tree appeared to do so fine, thanks! Robert --621616949-1319501039-1280937946=:46788--