From owner-freebsd-geom@FreeBSD.ORG Mon Feb 7 11:07:00 2011 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB2821065672 for ; Mon, 7 Feb 2011 11:07:00 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 998168FC19 for ; Mon, 7 Feb 2011 11:07:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p17B70Cp027740 for ; Mon, 7 Feb 2011 11:07:00 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p17B70Jf027738 for freebsd-geom@FreeBSD.org; Mon, 7 Feb 2011 11:07:00 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 7 Feb 2011 11:07:00 GMT Message-Id: <201102071107.p17B70Jf027738@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-geom@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-geom@FreeBSD.org X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2011 11:07:00 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/154226 geom [geom] GEOM label does not change when you modify them o kern/152609 geom [geli] geli onetime on gzero panics o kern/150858 geom [geom] [geom_label] [patch] glabel(8) is not compatibl o kern/150626 geom [geom] [gjournal] gjournal(8) destroys label o kern/150555 geom [geom] gjournal unusable on GPT partitions o kern/150334 geom [geom] [udf] [patch] geom label does not support UDF o kern/149762 geom volume labels with rogue characters o bin/149215 geom [panic] [geom_part] gpart(8): Delete linux's slice via o kern/147667 geom [gmirror] Booting with one component of a gmirror, the o kern/145818 geom [geom] geom_stat_open showing cached information for n o kern/145042 geom [geom] System stops booting after printing message "GE o kern/144905 geom [geom][geom_part] panic in gpart_ctlreq when unpluggin o kern/143455 geom gstripe(8) in RELENG_8 (31st Jan 2010) broken o kern/142563 geom [geom] [hang] ioctl freeze in zpool o kern/141740 geom [geom] gjournal(8): g_journal_destroy concurrent error o kern/140352 geom [geom] gjournal + glabel not working o kern/135898 geom [geom] Severe filesystem corruption - large files or l o kern/134922 geom [gmirror] [panic] kernel panic when use fdisk on disk o kern/134113 geom [geli] Problem setting secondary GELI key o kern/133931 geom [geli] [request] intentionally wrong password to destr o bin/132845 geom [geom] [patch] ggated(8) does not close files opened a o kern/132273 geom glabel(8): [patch] failing on journaled partition o kern/131353 geom [geom] gjournal(8) kernel lock o kern/129674 geom [geom] gjournal root did not mount on boot o kern/129645 geom gjournal(8): GEOM_JOURNAL causes system to fail to boo o kern/129245 geom [geom] gcache is more suitable for suffix based provid f kern/128276 geom [gmirror] machine lock up when gmirror module is used o kern/127420 geom [geom] [gjournal] [panic] Journal overflow on gmirrore o kern/124973 geom [gjournal] [patch] boot order affects geom_journal con o kern/124969 geom gvinum(8): gvinum raid5 plex does not detect missing s o kern/123962 geom [panic] [gjournal] gjournal (455Gb data, 8Gb journal), o kern/123122 geom [geom] GEOM / gjournal kernel lock o kern/122738 geom [geom] gmirror list "losts consumers" after gmirror de o kern/122067 geom [geom] [panic] Geom crashed during boot o kern/121364 geom [gmirror] Removing all providers create a "zombie" mir o kern/120091 geom [geom] [geli] [gjournal] geli does not prompt for pass o kern/115856 geom [geli] ZFS thought it was degraded when it should have o kern/115547 geom [geom] [patch] [request] let GEOM Eli get password fro o kern/114532 geom [geom] GEOM_MIRROR shows up in kldstat even if compile f kern/113957 geom [gmirror] gmirror is intermittently reporting a degrad o kern/113837 geom [geom] unable to access 1024 sector size storage o kern/113419 geom [geom] geom fox multipathing not failing back o kern/107707 geom [geom] [patch] [request] add new class geom_xbox360 to o kern/94632 geom [geom] Kernel output resets input while GELI asks for o kern/90582 geom [geom] [panic] Restore cause panic string (ffs_blkfree o bin/90093 geom fdisk(8) incapable of altering in-core geometry o kern/88601 geom [geli] geli cause kernel panic under heavy disk usage o kern/87544 geom [gbde] mmaping large files on a gbde filesystem deadlo o kern/84556 geom [geom] [panic] GBDE-encrypted swap causes panic at shu o kern/79251 geom [2TB] newfs fails on 2.6TB gbde device o kern/79035 geom [vinum] gvinum unable to create a striped set of mirro o bin/78131 geom gbde(8) "destroy" not working. 52 problems total. From owner-freebsd-geom@FreeBSD.ORG Mon Feb 7 16:56:13 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 443AB106566B for ; Mon, 7 Feb 2011 16:56:13 +0000 (UTC) (envelope-from mlmichael70@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id CC79B8FC17 for ; Mon, 7 Feb 2011 16:56:12 +0000 (UTC) Received: by wwf26 with SMTP id 26so4825530wwf.31 for ; Mon, 07 Feb 2011 08:56:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :subject:content-type:content-transfer-encoding; bh=3+lMQtVofegPbqku2OSE4MlwM2DCC7UBQkdVxxFEeyE=; b=QzXi7AmIaxGU0tl5PdNvTtkvsnOa8J+jffM40Xe7F/3W4KjNjcaq1QUFDZTU6xnz4b k+tjWwJoLzzylMVzwAqFChcqUBfPhjtEc85nQKYDrW5I4abE+mtavzoiYrivSESir8Te HmvLdqk3K7PcbGi5lK9jLPRkSYTK1vIb80F3A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=tV4RMueFwQYNXd4+iwraE2rX+33dRvrR6ooXLPFhj4biHqIM7TWKdbA2ylqY9Y8TA9 SQW+jSo/HU7Y9t4lPOf8BgPCKZEhsjh+aiiFXvYDMqexNwqIdlCUKRWQU51sJddvHTR6 2LPcuG0+2UPgXWXKXQ95guqnLa2hi02LWzNRU= Received: by 10.227.138.19 with SMTP id y19mr2920429wbt.55.1297096074010; Mon, 07 Feb 2011 08:27:54 -0800 (PST) Received: from prime.nonspace ([82.132.211.88]) by mx.google.com with ESMTPS id f27sm3488369wbf.7.2011.02.07.08.27.52 (version=SSLv3 cipher=RC4-MD5); Mon, 07 Feb 2011 08:27:53 -0800 (PST) Message-ID: <4D501D97.1060804@gmail.com> Date: Mon, 07 Feb 2011 16:28:07 +0000 From: Michael User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20101215 Thunderbird/3.1.7 MIME-Version: 1.0 To: freebsd-geom@freebsd.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: chflags (uappnd) on ZFS X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2011 16:56:13 -0000 Hello, Is uappnd flag supported on ZFS? I'm using 8.1-R and when I try to: chflags uappnd file.txt then I get: chflags: file.txt: Operation not supported Thank you in advance, Michael From owner-freebsd-geom@FreeBSD.ORG Mon Feb 7 21:37:38 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1233) id 392491065673; Mon, 7 Feb 2011 21:37:38 +0000 (UTC) Date: Mon, 7 Feb 2011 21:37:38 +0000 From: Alexander Best To: freebsd-geom@freebsd.org Message-ID: <20110207213738.GA54609@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="45Z9DzgjV8m4Oswq" Content-Disposition: inline Subject: [patch] comparison of u_int against < 0 in g_journal.c X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2011 21:37:38 -0000 --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline hi there, this was reported by clang 2.9 (dev) as -Wtautological-compare warning. i think clang is right, because cswitch is of type u_int. cheers. alex -- a13x --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="g_journal.c.diff" Index: sys/geom/journal/g_journal.c =================================================================== --- sys/geom/journal/g_journal.c (revision 218413) +++ sys/geom/journal/g_journal.c (working copy) @@ -173,7 +173,7 @@ error = sysctl_handle_int(oidp, &cswitch, 0, req); if (error != 0 || req->newptr == NULL) return (error); - if (cswitch < 0 || cswitch > 100) + if (cswitch > 100) return (EINVAL); g_journal_cache_switch = cswitch; g_journal_cache_low = (g_journal_cache_limit / 100) * cswitch; --45Z9DzgjV8m4Oswq-- From owner-freebsd-geom@FreeBSD.ORG Fri Feb 11 09:13:00 2011 Return-Path: Delivered-To: geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E62FF106566B for ; Fri, 11 Feb 2011 09:13:00 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 3FB3A8FC18 for ; Fri, 11 Feb 2011 09:13:00 +0000 (UTC) Received: from outgoing.leidinger.net (p57B3B9CC.dip.t-dialin.net [87.179.185.204]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 0CA85844012; Fri, 11 Feb 2011 10:03:02 +0100 (CET) Received: from webmail.leidinger.net (unknown [IPv6:fd73:10c7:2053:1::2:102]) by outgoing.leidinger.net (Postfix) with ESMTP id DF3622F45; Fri, 11 Feb 2011 10:02:58 +0100 (CET) Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.13.8/Submit) id p1B92weP065959; Fri, 11 Feb 2011 10:02:58 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.ec.europa.eu (pslux.ec.europa.eu [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Fri, 11 Feb 2011 10:02:58 +0100 Message-ID: <20110211100258.18243dlaaz0iulog@webmail.leidinger.net> Date: Fri, 11 Feb 2011 10:02:58 +0100 From: Alexander Leidinger To: geom@freebsd.org References: <20110211100047.14771t9tnmafolog@webmail.leidinger.net> In-Reply-To: <20110211100047.14771t9tnmafolog@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_30palfo2nku8" Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 0CA85844012.AA112 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=1.274, required 6, autolearn=disabled, RDNS_NONE 1.27) X-EBL-MailScanner-SpamScore: s X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1298019786.34765@ZRZISRx1ZgtTwfp+gE1t5g X-EBL-Spam-Status: No Cc: kibab@freebsd.org Subject: Re: CFR: FEATURE macros for GEOM classes (with patch) X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2011 09:13:01 -0000 This message is in MIME format. --=_30palfo2nku8 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit Quoting Alexander Leidinger (from Fri, 11 Feb 2011 10:00:47 +0100): > Can someone please review if the patch is OK (bikesheds about the > description part need to contain corresponding patches for NOTES, > else we will not take the arguments into account)? It helps to attach the patch... Bye, Alexander. -- The great nations have always acted like gangsters and the small nations like prostitutes. -- Stanley Kubrick http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 --=_30palfo2nku8 Content-Type: text/x-patch; charset=UTF-8; name="features_geom.diff" Content-Disposition: attachment; filename="features_geom.diff" Content-Transfer-Encoding: 7bit Index: geom/label/g_label.c =================================================================== --- geom/label/g_label.c (Revision 218482) +++ geom/label/g_label.c (Arbeitskopie) @@ -36,10 +36,12 @@ #include #include #include +#include #include #include #include +FEATURE(geom_label, "GEOM labeling support"); SYSCTL_DECL(_kern_geom); SYSCTL_NODE(_kern_geom, OID_AUTO, label, CTLFLAG_RW, 0, "GEOM_LABEL stuff"); Index: geom/gate/g_gate.c =================================================================== --- geom/gate/g_gate.c (Revision 218482) +++ geom/gate/g_gate.c (Arbeitskopie) @@ -53,6 +53,8 @@ #include #include +FEATURE(geom_gate, "GEOM Gate module"); + static MALLOC_DEFINE(M_GATE, "gg_data", "GEOM Gate Data"); SYSCTL_DECL(_kern_geom); Index: geom/uzip/g_uzip.c =================================================================== --- geom/uzip/g_uzip.c (Revision 218482) +++ geom/uzip/g_uzip.c (Arbeitskopie) @@ -36,10 +36,13 @@ #include #include #include +#include #include #include +FEATURE(geom_uzip, "GEOM uzip read-only compressed disks support"); + #undef GEOM_UZIP_DEBUG #ifdef GEOM_UZIP_DEBUG #define DPRINTF(a) printf a Index: geom/geom_sunlabel.c =================================================================== --- geom/geom_sunlabel.c (Revision 218482) +++ geom/geom_sunlabel.c (Arbeitskopie) @@ -39,6 +39,7 @@ #include #include #include +#include #include #include #include @@ -51,6 +52,8 @@ #include #include +FEATURE(geom_sunlabel, "GEOM Sun/Solaris partitioning support"); + #define SUNLABEL_CLASS_NAME "SUN" struct g_sunlabel_softc { Index: geom/geom_bsd.c =================================================================== --- geom/geom_bsd.c (Revision 218482) +++ geom/geom_bsd.c (Arbeitskopie) @@ -45,6 +45,7 @@ #include #include #include +#include #include #include #include @@ -60,6 +61,8 @@ #include #include +FEATURE(geom_bsd, "GEOM BSD disklabels support"); + #define BSD_CLASS_NAME "BSD" #define ALPHA_LABEL_OFFSET 64 Index: geom/cache/g_cache.c =================================================================== --- geom/cache/g_cache.c (Revision 218482) +++ geom/cache/g_cache.c (Arbeitskopie) @@ -42,6 +42,8 @@ #include #include +FEATURE(geom_cache, "GEOM cache module"); + static MALLOC_DEFINE(M_GCACHE, "gcache_data", "GEOM_CACHE Data"); SYSCTL_DECL(_kern_geom); Index: geom/mirror/g_mirror.c =================================================================== --- geom/mirror/g_mirror.c (Revision 218482) +++ geom/mirror/g_mirror.c (Arbeitskopie) @@ -45,6 +45,7 @@ #include #include +FEATURE(geom_mirror, "GEOM mirroring support"); static MALLOC_DEFINE(M_MIRROR, "mirror_data", "GEOM_MIRROR Data"); Index: geom/geom_fox.c =================================================================== --- geom/geom_fox.c (Revision 218482) +++ geom/geom_fox.c (Arbeitskopie) @@ -37,6 +37,7 @@ #include #include +#include #include #include #include @@ -52,6 +53,8 @@ #define FOX_CLASS_NAME "FOX" #define FOX_MAGIC "GEOM::FOX" +FEATURE(geom_fox, "GEOM FOX redundant path mitigation support"); + struct g_fox_softc { off_t mediasize; u_int sectorsize; Index: geom/geom_vol_ffs.c =================================================================== --- geom/geom_vol_ffs.c (Revision 218482) +++ geom/geom_vol_ffs.c (Arbeitskopie) @@ -30,6 +30,7 @@ #include #include #include +#include #include #include #include @@ -42,6 +43,8 @@ #include #include +FEATURE(geom_vol, "GEOM support for volume names from UFS superblock"); + #define VOL_FFS_CLASS_NAME "VOL_FFS" static int superblocks[] = SBLOCKSEARCH; Index: geom/bde/g_bde.c =================================================================== --- geom/bde/g_bde.c (Revision 218482) +++ geom/bde/g_bde.c (Arbeitskopie) @@ -41,6 +41,7 @@ #include #include #include +#include #include #include @@ -48,6 +49,8 @@ #include #define BDE_CLASS_NAME "BDE" +FEATURE(geom_bde, "GEOM-based Disk Encryption"); + static void g_bde_start(struct bio *bp) { Index: geom/raid3/g_raid3.c =================================================================== --- geom/raid3/g_raid3.c (Revision 218482) +++ geom/raid3/g_raid3.c (Arbeitskopie) @@ -45,6 +45,7 @@ #include #include +FEATURE(geom_raid3, "GEOM RAID-3 functionality"); static MALLOC_DEFINE(M_RAID3, "raid3_data", "GEOM_RAID3 Data"); Index: geom/shsec/g_shsec.c =================================================================== --- geom/shsec/g_shsec.c (Revision 218482) +++ geom/shsec/g_shsec.c (Arbeitskopie) @@ -40,6 +40,7 @@ #include #include +FEATURE(geom_shsec, "GEOM shared secret device support"); static MALLOC_DEFINE(M_SHSEC, "shsec_data", "GEOM_SHSEC Data"); Index: geom/part/g_part_pc98.c =================================================================== --- geom/part/g_part_pc98.c (Revision 218482) +++ geom/part/g_part_pc98.c (Arbeitskopie) @@ -40,11 +40,14 @@ #include #include #include +#include #include #include #include "g_part_if.h" +FEATURE(geom_part_pc98, "GEOM partitioning class for PC-9800 disk partitions"); + #define SECSIZE 512 struct g_part_pc98_table { Index: geom/part/g_part_vtoc8.c =================================================================== --- geom/part/g_part_vtoc8.c (Revision 218482) +++ geom/part/g_part_vtoc8.c (Arbeitskopie) @@ -39,12 +39,15 @@ #include #include #include +#include #include #include #include #include "g_part_if.h" +FEATURE(geom_part_vtoc8, "GEOM partitioning class for SMI VTOC8 disk labels"); + struct g_part_vtoc8_table { struct g_part_table base; struct vtoc8 vtoc; Index: geom/part/g_part_bsd.c =================================================================== --- geom/part/g_part_bsd.c (Revision 218482) +++ geom/part/g_part_bsd.c (Arbeitskopie) @@ -40,11 +40,14 @@ #include #include #include +#include #include #include #include "g_part_if.h" +FEATURE(geom_part_bsd, "GEOM partitioning class for BSD disklabels"); + struct g_part_bsd_table { struct g_part_table base; u_char *bbarea; Index: geom/part/g_part_ebr.c =================================================================== --- geom/part/g_part_ebr.c (Revision 218482) +++ geom/part/g_part_ebr.c (Arbeitskopie) @@ -42,11 +42,19 @@ #include #include #include +#include #include #include #include "g_part_if.h" +FEATURE(geom_part_ebr, + "GEOM partitioning class for extended boot records support"); +#if defined(GEOM_PART_EBR_COMPAT) +FEATURE(geom_part_ebr_compat, + "GEOM EBR partitioning class: backward-compatible partition names"); +#endif + #define EBRSIZE 512 struct g_part_ebr_table { Index: geom/part/g_part_gpt.c =================================================================== --- geom/part/g_part_gpt.c (Revision 218482) +++ geom/part/g_part_gpt.c (Arbeitskopie) @@ -41,12 +41,15 @@ #include #include #include +#include #include #include #include #include "g_part_if.h" +FEATURE(geom_part_gpt, "GEOM partitioning class for GPT partitions support"); + CTASSERT(offsetof(struct gpt_hdr, padding) == 92); CTASSERT(sizeof(struct gpt_ent) == 128); Index: geom/part/g_part_apm.c =================================================================== --- geom/part/g_part_apm.c (Revision 218482) +++ geom/part/g_part_apm.c (Arbeitskopie) @@ -41,11 +41,14 @@ #include #include #include +#include #include #include #include "g_part_if.h" +FEATURE(geom_part_apm, "GEOM partitioning class for Apple-style partitions"); + struct g_part_apm_table { struct g_part_table base; struct apm_ddr ddr; Index: geom/part/g_part_mbr.c =================================================================== --- geom/part/g_part_mbr.c (Revision 218482) +++ geom/part/g_part_mbr.c (Arbeitskopie) @@ -40,11 +40,14 @@ #include #include #include +#include #include #include #include "g_part_if.h" +FEATURE(geom_part_mbr, "GEOM partitioning class for MBR support"); + #define MBRSIZE 512 struct g_part_mbr_table { Index: geom/stripe/g_stripe.c =================================================================== --- geom/stripe/g_stripe.c (Revision 218482) +++ geom/stripe/g_stripe.c (Arbeitskopie) @@ -40,6 +40,7 @@ #include #include +FEATURE(geom_stripe, "GEOM striping support"); static MALLOC_DEFINE(M_STRIPE, "stripe_data", "GEOM_STRIPE Data"); Index: geom/concat/g_concat.c =================================================================== --- geom/concat/g_concat.c (Revision 218482) +++ geom/concat/g_concat.c (Arbeitskopie) @@ -39,6 +39,7 @@ #include #include +FEATURE(geom_concat, "GEOM concatenation support"); static MALLOC_DEFINE(M_CONCAT, "concat_data", "GEOM_CONCAT Data"); Index: geom/multipath/g_multipath.c =================================================================== --- geom/multipath/g_multipath.c (Revision 218482) +++ geom/multipath/g_multipath.c (Arbeitskopie) @@ -44,6 +44,7 @@ #include #include +FEATURE(geom_multipath, "GEOM multipath support"); SYSCTL_DECL(_kern_geom); SYSCTL_NODE(_kern_geom, OID_AUTO, multipath, CTLFLAG_RW, 0, Index: geom/virstor/g_virstor.c =================================================================== --- geom/virstor/g_virstor.c (Revision 218482) +++ geom/virstor/g_virstor.c (Arbeitskopie) @@ -52,6 +52,8 @@ #include #include +FEATURE(g_virstor, "GEOM virtual storage support"); + /* Declare malloc(9) label */ static MALLOC_DEFINE(M_GVIRSTOR, "gvirstor", "GEOM_VIRSTOR Data"); Index: geom/geom_mbr.c =================================================================== --- geom/geom_mbr.c (Revision 218482) +++ geom/geom_mbr.c (Arbeitskopie) @@ -37,6 +37,7 @@ #include #include #include +#include #include #include #include @@ -50,6 +51,8 @@ #include #include +FEATURE(geom_mbr, "GEOM DOS/MBR partitioning support"); + #define MBR_CLASS_NAME "MBR" #define MBREXT_CLASS_NAME "MBREXT" Index: geom/eli/g_eli.c =================================================================== --- geom/eli/g_eli.c (Revision 218482) +++ geom/eli/g_eli.c (Arbeitskopie) @@ -51,6 +51,7 @@ #include #include +FEATURE(geom_eli, "GEOM crypto module"); MALLOC_DEFINE(M_ELI, "eli data", "GEOM_ELI Data"); Index: geom/journal/g_journal.c =================================================================== --- geom/journal/g_journal.c (Revision 218482) +++ geom/journal/g_journal.c (Arbeitskopie) @@ -55,6 +55,7 @@ #include +FEATURE(geom_journal, "GEOM journaling support"); /* * On-disk journal format: Index: geom/geom_pc98.c =================================================================== --- geom/geom_pc98.c (Revision 218482) +++ geom/geom_pc98.c (Arbeitskopie) @@ -36,6 +36,7 @@ #include #include #include +#include #include #include #include @@ -47,6 +48,8 @@ #include #include +FEATURE(geom_pc98, "GEOM NEC PC9800 partitioning support"); + #define PC98_CLASS_NAME "PC98" struct g_pc98_softc { Index: geom/linux_lvm/g_linux_lvm.c =================================================================== --- geom/linux_lvm/g_linux_lvm.c (Revision 218482) +++ geom/linux_lvm/g_linux_lvm.c (Arbeitskopie) @@ -42,6 +42,8 @@ #include +FEATURE(geom_linux_lvm, "GEOM Linux LVM partitioning support"); + /* Declare malloc(9) label */ static MALLOC_DEFINE(M_GLLVM, "gllvm", "GEOM_LINUX_LVM Data"); --=_30palfo2nku8-- From owner-freebsd-geom@FreeBSD.ORG Fri Feb 11 09:18:00 2011 Return-Path: Delivered-To: geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 36004106566B for ; Fri, 11 Feb 2011 09:18:00 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id E25958FC15 for ; Fri, 11 Feb 2011 09:17:59 +0000 (UTC) Received: from outgoing.leidinger.net (p57B3B9CC.dip.t-dialin.net [87.179.185.204]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 920F9844012; Fri, 11 Feb 2011 10:00:57 +0100 (CET) Received: from webmail.leidinger.net (unknown [IPv6:fd73:10c7:2053:1::2:102]) by outgoing.leidinger.net (Postfix) with ESMTP id E15562F44; Fri, 11 Feb 2011 10:00:52 +0100 (CET) Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.13.8/Submit) id p1B90lpl065433; Fri, 11 Feb 2011 10:00:47 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.ec.europa.eu (pslux.ec.europa.eu [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Fri, 11 Feb 2011 10:00:47 +0100 Message-ID: <20110211100047.14771t9tnmafolog@webmail.leidinger.net> Date: Fri, 11 Feb 2011 10:00:47 +0100 From: Alexander Leidinger To: geom@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 920F9844012.A69B2 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=1.274, required 6, autolearn=disabled, RDNS_NONE 1.27) X-EBL-MailScanner-SpamScore: s X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1298019659.17709@SdXcXGUWbjFSEYmDUa5Cbw X-EBL-Spam-Status: No Cc: kibab@freebsd.org Subject: CFR: FEATURE macros for GEOM classes X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2011 09:18:00 -0000 Hi, during the last GSoC some FEATURE macros where added to some GEOM classes. Basically the description from NOTES was taken as a description for the FEATURE macro. Can someone please review if the patch is OK (bikesheds about the description part need to contain corresponding patches for NOTES, else we will not take the arguments into account)? I would like to commit this patch soonish, maybe in 1-2 weeks if nobody complains until then (just tell if you need more time to review). Please CC us on replies. Thanks, Alexander. -- There is a great discovery still to be made in Literature: that of paying literary men by the quantity they do NOT write. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137