From owner-freebsd-geom@FreeBSD.ORG Mon Jun 27 10:44:18 2011 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5960D1065670; Mon, 27 Jun 2011 10:44:18 +0000 (UTC) (envelope-from ae@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 331928FC1A; Mon, 27 Jun 2011 10:44:18 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5RAiIlF051612; Mon, 27 Jun 2011 10:44:18 GMT (envelope-from ae@freefall.freebsd.org) Received: (from ae@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5RAiHkM051608; Mon, 27 Jun 2011 10:44:17 GMT (envelope-from ae) Date: Mon, 27 Jun 2011 10:44:17 GMT Message-Id: <201106271044.p5RAiHkM051608@freefall.freebsd.org> To: eirnym@gmail.com, ae@FreeBSD.org, freebsd-geom@FreeBSD.org From: ae@FreeBSD.org Cc: Subject: Re: kern/157819: [geom] gpart(8): drop serial from MBR X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 10:44:18 -0000 Synopsis: [geom] gpart(8): drop serial from MBR State-Changed-From-To: open->patched State-Changed-By: ae State-Changed-When: Mon Jun 27 10:43:56 UTC 2011 State-Changed-Why: Patched in head/. Thanks! http://www.freebsd.org/cgi/query-pr.cgi?pr=157819 From owner-freebsd-geom@FreeBSD.ORG Mon Jun 27 10:50:11 2011 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E4E92106564A for ; Mon, 27 Jun 2011 10:50:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 847E38FC0A for ; Mon, 27 Jun 2011 10:50:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5RAoB2T052385 for ; Mon, 27 Jun 2011 10:50:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5RAoB5t052383; Mon, 27 Jun 2011 10:50:11 GMT (envelope-from gnats) Date: Mon, 27 Jun 2011 10:50:11 GMT Message-Id: <201106271050.p5RAoB5t052383@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/157819: commit references a PR X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 10:50:12 -0000 The following reply was made to PR kern/157819; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/157819: commit references a PR Date: Mon, 27 Jun 2011 10:42:20 +0000 (UTC) Author: ae Date: Mon Jun 27 10:42:06 2011 New Revision: 223587 URL: http://svn.freebsd.org/changeset/base/223587 Log: MS Windows NT+ uses 4 bytes at offset 0x1b8 in the MBR to identify disk drive. The boot0cfg(8) utility preserves these 4 bytes when is writing bootcode to keep a multiboot ability. Change gpart's bootcode method to keep DSN if it is not zero. Also do not allow writing bootcode with size not equal to MBRSIZE. PR: kern/157819 Tested by: Eir Nym MFC after: 1 month Modified: head/sys/geom/part/g_part_mbr.c head/sys/sys/diskmbr.h Modified: head/sys/geom/part/g_part_mbr.c ============================================================================== --- head/sys/geom/part/g_part_mbr.c Mon Jun 27 09:15:41 2011 (r223586) +++ head/sys/geom/part/g_part_mbr.c Mon Jun 27 10:42:06 2011 (r223587) @@ -237,14 +237,16 @@ static int g_part_mbr_bootcode(struct g_part_table *basetable, struct g_part_parms *gpp) { struct g_part_mbr_table *table; - size_t codesz; + uint32_t dsn; + + if (gpp->gpp_codesize != MBRSIZE) + return (ENODEV); - codesz = DOSPARTOFF; table = (struct g_part_mbr_table *)basetable; - bzero(table->mbr, codesz); - codesz = MIN(codesz, gpp->gpp_codesize); - if (codesz > 0) - bcopy(gpp->gpp_codeptr, table->mbr, codesz); + dsn = *(uint32_t *)(table->mbr + DOSDSNOFF); + bcopy(gpp->gpp_codeptr, table->mbr, DOSPARTOFF); + if (dsn != 0) + *(uint32_t *)(table->mbr + DOSDSNOFF) = dsn; return (0); } Modified: head/sys/sys/diskmbr.h ============================================================================== --- head/sys/sys/diskmbr.h Mon Jun 27 09:15:41 2011 (r223586) +++ head/sys/sys/diskmbr.h Mon Jun 27 10:42:06 2011 (r223587) @@ -36,6 +36,7 @@ #include #define DOSBBSECTOR 0 /* DOS boot block relative sector number */ +#define DOSDSNOFF 440 /* WinNT/2K/XP Drive Serial Number offset */ #define DOSPARTOFF 446 #define DOSPARTSIZE 16 #define NDOSPART 4 _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-geom@FreeBSD.ORG Mon Jun 27 11:07:01 2011 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F0F1A106566C for ; Mon, 27 Jun 2011 11:07:01 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E03738FC12 for ; Mon, 27 Jun 2011 11:07:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5RB71RS071825 for ; Mon, 27 Jun 2011 11:07:01 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5RB71Eu071823 for freebsd-geom@FreeBSD.org; Mon, 27 Jun 2011 11:07:01 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 27 Jun 2011 11:07:01 GMT Message-Id: <201106271107.p5RB71Eu071823@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-geom@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-geom@FreeBSD.org X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 11:07:02 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/158197 geom [geom] geom_cache with size>1000 leads to panics o kern/157879 geom [libgeom] ABI change without version bump in 8.2 o kern/157863 geom [geli] kbdmux prevents geli passwords from being enter p kern/157819 geom [geom] gpart(8): drop serial from MBR o kern/157739 geom [geom] GPT labels with geom_multipath o kern/157724 geom [geom] gpart(8) 'add' command must preserve gap for sc o kern/157723 geom [geom] GEOM should not process 'c' (raw) partitions fo o kern/157108 geom [gjournal] dumpon(8) fails on gjournal providers o kern/155994 geom [geom] Long "Suspend time" when reading large files fr o kern/154226 geom [geom] GEOM label does not change when you modify them o kern/150858 geom [geom] [geom_label] [patch] glabel(8) is not compatibl o kern/150626 geom [geom] [gjournal] gjournal(8) destroys label o kern/150555 geom [geom] gjournal unusable on GPT partitions o kern/150334 geom [geom] [udf] [patch] geom label does not support UDF o kern/149762 geom volume labels with rogue characters o bin/149215 geom [panic] [geom_part] gpart(8): Delete linux's slice via o kern/147667 geom [gmirror] Booting with one component of a gmirror, the o kern/145818 geom [geom] geom_stat_open showing cached information for n o kern/145042 geom [geom] System stops booting after printing message "GE o kern/144905 geom [geom][geom_part] panic in gpart_ctlreq when unpluggin o kern/143455 geom gstripe(8) in RELENG_8 (31st Jan 2010) broken o kern/142563 geom [geom] [hang] ioctl freeze in zpool o kern/141740 geom [geom] gjournal(8): g_journal_destroy concurrent error o kern/140352 geom [geom] gjournal + glabel not working o kern/135898 geom [geom] Severe filesystem corruption - large files or l o kern/134922 geom [gmirror] [panic] kernel panic when use fdisk on disk o kern/134113 geom [geli] Problem setting secondary GELI key o kern/133931 geom [geli] [request] intentionally wrong password to destr o bin/132845 geom [geom] [patch] ggated(8) does not close files opened a o kern/131353 geom [geom] gjournal(8) kernel lock o kern/129674 geom [geom] gjournal root did not mount on boot o kern/129645 geom gjournal(8): GEOM_JOURNAL causes system to fail to boo o kern/129245 geom [geom] gcache is more suitable for suffix based provid f kern/128276 geom [gmirror] machine lock up when gmirror module is used o kern/127420 geom [geom] [gjournal] [panic] Journal overflow on gmirrore o kern/124973 geom [gjournal] [patch] boot order affects geom_journal con o kern/124969 geom gvinum(8): gvinum raid5 plex does not detect missing s o kern/123962 geom [panic] [gjournal] gjournal (455Gb data, 8Gb journal), o kern/123122 geom [geom] GEOM / gjournal kernel lock o kern/122738 geom [geom] gmirror list "losts consumers" after gmirror de o kern/122067 geom [geom] [panic] Geom crashed during boot o kern/121364 geom [gmirror] Removing all providers create a "zombie" mir o kern/120091 geom [geom] [geli] [gjournal] geli does not prompt for pass o kern/115856 geom [geli] ZFS thought it was degraded when it should have o kern/115547 geom [geom] [patch] [request] let GEOM Eli get password fro o kern/114532 geom [geom] GEOM_MIRROR shows up in kldstat even if compile f kern/113957 geom [gmirror] gmirror is intermittently reporting a degrad o kern/113837 geom [geom] unable to access 1024 sector size storage o kern/113419 geom [geom] geom fox multipathing not failing back o kern/107707 geom [geom] [patch] [request] add new class geom_xbox360 to o kern/94632 geom [geom] Kernel output resets input while GELI asks for o kern/90582 geom [geom] [panic] Restore cause panic string (ffs_blkfree o bin/90093 geom fdisk(8) incapable of altering in-core geometry o kern/87544 geom [gbde] mmaping large files on a gbde filesystem deadlo o bin/86388 geom [geom] [geom_part] periodic(8) daily should backup gpa o kern/84556 geom [geom] [panic] GBDE-encrypted swap causes panic at shu o kern/79251 geom [2TB] newfs fails on 2.6TB gbde device o kern/79035 geom [vinum] gvinum unable to create a striped set of mirro o bin/78131 geom gbde(8) "destroy" not working. 59 problems total. From owner-freebsd-geom@FreeBSD.ORG Mon Jun 27 11:40:11 2011 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E66E106566B for ; Mon, 27 Jun 2011 11:40:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 158F08FC0C for ; Mon, 27 Jun 2011 11:40:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5RBeA09006168 for ; Mon, 27 Jun 2011 11:40:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5RBeAa1006165; Mon, 27 Jun 2011 11:40:10 GMT (envelope-from gnats) Date: Mon, 27 Jun 2011 11:40:10 GMT Message-Id: <201106271140.p5RBeAa1006165@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: "Andrey V. Elsukov" Cc: Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Andrey V. Elsukov" List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 11:40:11 -0000 The following reply was made to PR kern/157724; it has been noted by GNATS. From: "Andrey V. Elsukov" To: bug-followup@FreeBSD.org, eirnym@gmail.com Cc: Marcel Moolenaar Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes Date: Mon, 27 Jun 2011 15:38:08 +0400 Hi, Eir Nym I am partially agree with you. geom_part_bsd does not protects metadata from overwriting. And it is bad for users which are not aware about this. Also it is easy to wipe metadata now, when first partition of BSD scheme should not always have UFS file system. -- WBR, Andrey V. Elsukov From owner-freebsd-geom@FreeBSD.ORG Mon Jun 27 16:12:51 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DDB70106566C for ; Mon, 27 Jun 2011 16:12:51 +0000 (UTC) (envelope-from piotr-l@netexpert.pl) Received: from poczta.netexpert.pl (poczta.netexpert.pl [81.210.116.233]) by mx1.freebsd.org (Postfix) with ESMTP id 9427A8FC1B for ; Mon, 27 Jun 2011 16:12:51 +0000 (UTC) Received: by poczta.netexpert.pl (Postfix, from userid 58) id 3ABB71702F; Mon, 27 Jun 2011 17:28:57 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on lancre.netexpert.net.pl X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=ham version=3.3.1 X-Spam-DCC: X-Spam-SCL: 1 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP Received: from [172.22.22.186] (evdo-78-30-69-51.subscribers.sferia.net [78.30.69.51]) by poczta.netexpert.pl (Postfix) with ESMTPA id 4E7271701A for ; Mon, 27 Jun 2011 17:28:52 +0200 (CEST) Message-ID: <4E08ABF2.3020504@netexpert.pl> Date: Mon, 27 Jun 2011 18:12:34 +0200 From: Piotr NetExpert User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.2.18) Gecko/20110616 Thunderbird MIME-Version: 1.0 To: freebsd-geom@freebsd.org References: <4E02E573.5070102@netexpert.pl> <20110623075926.GB1842@garage.freebsd.pl> In-Reply-To: <20110623075926.GB1842@garage.freebsd.pl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: *.journal missing X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 16:12:51 -0000 I am affraid I am back with my problem. I have recreated all journals. I am pretty sure I was able to reboot the system after that. The only thing I have done to disks today is adding a new disk to my mirror, disconnecting it after synchronized and forgetting it. Now I cannot reboot again. "Can't start /dev...journal: No such file or directory" >> >> I have got a journal made on top of a mirror. It was OK until today. >> After a reboot the system cannot mount journaled filesystems. >> >> After gjournal load I can see: >> GEOM_JOURNAL: Journal 4249355098: ifsid/4def2606510052ce contains data. >> GEOM_JOURNAL: Journal 4249355098: mirror/gm0s2h contains journal. >> GEOM_JOURNAL: Journal ifsid/4def2606510052ce clean. > I am able to start if I comment out geom_journal_load and load gjournal manualy in a single user mode. gjournal load GEOM_JOURNAL: Journal 904869055: mirror/gm0s2h contains journal. GEOM_JOURNAL: Journal 904869055: mirror/gm0s1h contains data. GEOM_JOURNAL: Journal mirror/gm0s1h clean. -- pozdrawiam Piotr Szafarczyk http://www.netexpert.pl From owner-freebsd-geom@FreeBSD.ORG Mon Jun 27 16:40:18 2011 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5938F106564A for ; Mon, 27 Jun 2011 16:40:18 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 48F8F8FC14 for ; Mon, 27 Jun 2011 16:40:18 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5RGeIVk082715 for ; Mon, 27 Jun 2011 16:40:18 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5RGeI0m082714; Mon, 27 Jun 2011 16:40:18 GMT (envelope-from gnats) Date: Mon, 27 Jun 2011 16:40:18 GMT Message-Id: <201106271640.p5RGeI0m082714@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Marcel Moolenaar Cc: Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Marcel Moolenaar List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 16:40:18 -0000 The following reply was made to PR kern/157724; it has been noted by GNATS. From: Marcel Moolenaar To: "Andrey V. Elsukov" Cc: bug-followup@FreeBSD.org, eirnym@gmail.com, Marcel Moolenaar Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes Date: Mon, 27 Jun 2011 09:39:11 -0700 On Jun 27, 2011, at 4:38 AM, Andrey V. Elsukov wrote: > Hi, Eir Nym > > I am partially agree with you. geom_part_bsd does not protects > metadata from overwriting. And it is bad for users which are not > aware about this. Also it is easy to wipe metadata now, when > first partition of BSD scheme should not always have UFS file > system. There isn't a lot we can do about it. This is one of those historical mistakes that you can't fix without breaking with 30+ years of history. It's not worth the hassle IMO... -- Marcel Moolenaar marcel@xcllnt.net From owner-freebsd-geom@FreeBSD.ORG Mon Jun 27 17:50:11 2011 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1859C106564A for ; Mon, 27 Jun 2011 17:50:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E2B9A8FC0A for ; Mon, 27 Jun 2011 17:50:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5RHoA8f046024 for ; Mon, 27 Jun 2011 17:50:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5RHoAN8046023; Mon, 27 Jun 2011 17:50:10 GMT (envelope-from gnats) Date: Mon, 27 Jun 2011 17:50:10 GMT Message-Id: <201106271750.p5RHoAN8046023@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: "Andrey V. Elsukov" Cc: Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Andrey V. Elsukov" List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 17:50:11 -0000 The following reply was made to PR kern/157724; it has been noted by GNATS. From: "Andrey V. Elsukov" To: Marcel Moolenaar Cc: bug-followup@FreeBSD.org, eirnym@gmail.com, Marcel Moolenaar Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes Date: Mon, 27 Jun 2011 21:40:41 +0400 This is a multi-part message in MIME format. --------------020406000309010000060206 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit On 27.06.2011 20:39, Marcel Moolenaar wrote: >> I am partially agree with you. geom_part_bsd does not protects >> metadata from overwriting. And it is bad for users which are not >> aware about this. Also it is easy to wipe metadata now, when >> first partition of BSD scheme should not always have UFS file >> system. > > There isn't a lot we can do about it. This is one of those > historical mistakes that you can't fix without breaking with > 30+ years of history. It's not worth the hassle IMO... Hi, Marcel I think we can just set gpt_first = 16 in g_part_bsd_create for new tables and for existing tables also set gpt_first = 16 if all partitions don not use this space. Something like this (untested): -- WBR, Andrey V. Elsukov --------------020406000309010000060206 Content-Type: text/plain; name="g_part_bsd.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="g_part_bsd.diff" Index: head/sys/geom/part/g_part_bsd.c =================================================================== --- head/sys/geom/part/g_part_bsd.c (revision 223600) +++ head/sys/geom/part/g_part_bsd.c (working copy) @@ -225,12 +225,12 @@ g_part_bsd_create(struct g_part_table *basetable, le16enc(ptr + 138, basetable->gpt_entries); /* d_npartitions */ le32enc(ptr + 140, BBSIZE); /* d_bbsize */ - basetable->gpt_first = 0; + basetable->gpt_first = BBSIZE / pp->sectorsize; basetable->gpt_last = msize - 1; basetable->gpt_isleaf = 1; baseentry = g_part_new_entry(basetable, RAW_PART + 1, - basetable->gpt_first, basetable->gpt_last); + 0, basetable->gpt_last); baseentry->gpe_internal = 1; entry = (struct g_part_bsd_entry *)baseentry; entry->part.p_size = basetable->gpt_last + 1; @@ -437,7 +437,11 @@ g_part_bsd_read(struct g_part_table *basetable, st entry->part = part; if (index == RAW_PART) baseentry->gpe_internal = 1; + else if (baseentry->gpe_start < BBSIZE / pp->sectorsize) + error = 1; } + if (error == 0) + basetable->gpt_first = BBSIZE / pp->sectorsize; return (0); --------------020406000309010000060206-- From owner-freebsd-geom@FreeBSD.ORG Mon Jun 27 18:10:11 2011 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C0738106564A for ; Mon, 27 Jun 2011 18:10:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B02D18FC0C for ; Mon, 27 Jun 2011 18:10:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5RIABhc063811 for ; Mon, 27 Jun 2011 18:10:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5RIABbI063810; Mon, 27 Jun 2011 18:10:11 GMT (envelope-from gnats) Date: Mon, 27 Jun 2011 18:10:11 GMT Message-Id: <201106271810.p5RIABbI063810@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Marcel Moolenaar Cc: Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Marcel Moolenaar List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 18:10:11 -0000 The following reply was made to PR kern/157724; it has been noted by GNATS. From: Marcel Moolenaar To: "Andrey V. Elsukov" Cc: bug-followup@FreeBSD.org, eirnym@gmail.com, Marcel Moolenaar Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes Date: Mon, 27 Jun 2011 11:01:33 -0700 On Jun 27, 2011, at 10:40 AM, Andrey V. Elsukov wrote: > On 27.06.2011 20:39, Marcel Moolenaar wrote: >>> I am partially agree with you. geom_part_bsd does not protects >>> metadata from overwriting. And it is bad for users which are not >>> aware about this. Also it is easy to wipe metadata now, when >>> first partition of BSD scheme should not always have UFS file >>> system. >> >> There isn't a lot we can do about it. This is one of those >> historical mistakes that you can't fix without breaking with >> 30+ years of history. It's not worth the hassle IMO... > > Hi, Marcel > > I think we can just set gpt_first = 16 in g_part_bsd_create for new > tables and for existing tables also set gpt_first = 16 if all partitions > don not use this space. Something like this (untested): You may want to look at /etc/disktab. Are you willing to change all entries and deal with the consequences? :-) -- Marcel Moolenaar marcel@xcllnt.net From owner-freebsd-geom@FreeBSD.ORG Mon Jun 27 18:22:18 2011 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id B823B106566C for ; Mon, 27 Jun 2011 18:22:18 +0000 (UTC) (envelope-from ae@FreeBSD.org) Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id E70BC178605; Mon, 27 Jun 2011 18:22:17 +0000 (UTC) Message-ID: <4E08CA46.6030904@FreeBSD.org> Date: Mon, 27 Jun 2011 22:21:58 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110429 Thunderbird/3.1.10 MIME-Version: 1.0 To: Marcel Moolenaar References: <201106271810.p5RIABbI063810@freefall.freebsd.org> In-Reply-To: <201106271810.p5RIABbI063810@freefall.freebsd.org> X-Enigmail-Version: 1.1.2 OpenPGP: id=10C8A17A Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig8E538BF9C7FC0419BC37DD2E" Cc: freebsd-geom@FreeBSD.org Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 18:22:18 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8E538BF9C7FC0419BC37DD2E Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On 27.06.2011 22:10, Marcel Moolenaar wrote: > >> There isn't a lot we can do about it. This is one of those > >> historical mistakes that you can't fix without breaking with > >> 30+ years of history. It's not worth the hassle IMO... > >=20 > > Hi, Marcel > >=20 > > I think we can just set gpt_first =3D 16 in g_part_bsd_create for ne= w > > tables and for existing tables also set gpt_first =3D 16 if all part= itions > > don not use this space. Something like this (untested): > =20 > You may want to look at /etc/disktab. Are you willing to > change all entries and deal with the consequences? :-) I do not see any problems here especially for gpart(8). bsdlabel(8) does not use gpart(8), it still can write label directly to the provider and it will be detected as before. --=20 WBR, Andrey V. Elsukov --------------enig8E538BF9C7FC0419BC37DD2E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBAgAGBQJOCMpNAAoJEAHF6gQQyKF610sH+gI1YkmdkeCLLDZdn/UUozb8 pUa+2uhH7TlrKsXLzBlL416iMskNNcuSXwXNPr22G4v/PS0LRQKXwQQXblTa+tlM H2Fnuksos3PWTy3u+IUgbMIVY12CG27xHLg20fBZ3ji3vMPyokJ4nE7/xnnmbD4N SY1u1Kr86aYxGkgMazfl7RbjNbNYYlAENvg5Tz8yPo0EoCE55LEIZIMuRs7X53i4 QhG68coid3uy4EFh6QiI0QOoKJi0Zp9ku0ryt+M2QucqCEIpS9PZ+ghQ3oFc5F0s CtFVq8Jf46US/rCJwUPgu+qGvV4/nucWigefvU0LiTHRnCpbwt+kO0S7kCxw6zM= =B7LZ -----END PGP SIGNATURE----- --------------enig8E538BF9C7FC0419BC37DD2E-- From owner-freebsd-geom@FreeBSD.ORG Mon Jun 27 18:27:22 2011 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDB9E106566C; Mon, 27 Jun 2011 18:27:22 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4]) by mx1.freebsd.org (Postfix) with ESMTP id 8E4A88FC1A; Mon, 27 Jun 2011 18:27:22 +0000 (UTC) Received: from sa-nc-common2-75.static.jnpr.net (natint3.juniper.net [66.129.224.36]) (authenticated bits=0) by mail.xcllnt.net (8.14.4/8.14.4) with ESMTP id p5RIRHTk096134 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 27 Jun 2011 11:27:23 -0700 (PDT) (envelope-from marcel@xcllnt.net) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Marcel Moolenaar In-Reply-To: <4E08CA46.6030904@FreeBSD.org> Date: Mon, 27 Jun 2011 11:27:10 -0700 Content-Transfer-Encoding: 7bit Message-Id: References: <201106271810.p5RIABbI063810@freefall.freebsd.org> <4E08CA46.6030904@FreeBSD.org> To: "Andrey V. Elsukov" X-Mailer: Apple Mail (2.1084) Cc: freebsd-geom@FreeBSD.org Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 18:27:22 -0000 On Jun 27, 2011, at 11:21 AM, Andrey V. Elsukov wrote: > On 27.06.2011 22:10, Marcel Moolenaar wrote: >>>> There isn't a lot we can do about it. This is one of those >>>> historical mistakes that you can't fix without breaking with >>>> 30+ years of history. It's not worth the hassle IMO... >>> >>> Hi, Marcel >>> >>> I think we can just set gpt_first = 16 in g_part_bsd_create for new >>> tables and for existing tables also set gpt_first = 16 if all partitions >>> don not use this space. Something like this (untested): >> >> You may want to look at /etc/disktab. Are you willing to >> change all entries and deal with the consequences? :-) > > I do not see any problems here especially for gpart(8). > bsdlabel(8) does not use gpart(8), it still can write label directly to > the provider and it will be detected as before. You're creating inconsistent behaviour between bsdlabel and gpart and that will result in PRs. Whatever you do, keep consistency. If you really want to change the default behaviour of gpart, I suggest you first get rid of bsdlabel, fdisk, et al... -- Marcel Moolenaar marcel@xcllnt.net From owner-freebsd-geom@FreeBSD.ORG Tue Jun 28 05:10:08 2011 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C0A4A1065672 for ; Tue, 28 Jun 2011 05:10:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A95FE8FC0C for ; Tue, 28 Jun 2011 05:10:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5S5A8jx073023 for ; Tue, 28 Jun 2011 05:10:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5S5A8O0073022; Tue, 28 Jun 2011 05:10:08 GMT (envelope-from gnats) Date: Tue, 28 Jun 2011 05:10:08 GMT Message-Id: <201106280510.p5S5A8O0073022@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Eir Nym Cc: Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Eir Nym List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2011 05:10:08 -0000 The following reply was made to PR kern/157724; it has been noted by GNATS. From: Eir Nym To: Marcel Moolenaar Cc: "Andrey V. Elsukov" , bug-followup@freebsd.org, Marcel Moolenaar Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes Date: Tue, 28 Jun 2011 05:06:06 +0000 On 27 June 2011 18:01, Marcel Moolenaar wrote: > > On Jun 27, 2011, at 10:40 AM, Andrey V. Elsukov wrote: > >> On 27.06.2011 20:39, Marcel Moolenaar wrote: >>>> I am partially agree with you. geom_part_bsd does not protects >>>> metadata from overwriting. And it is bad for users which are not >>>> aware about this. Also it is easy to wipe metadata now, when >>>> first partition of BSD scheme should not always have UFS file >>>> system. >>> >>> There isn't a lot we can do about it. This is one of those >>> historical mistakes that you can't fix without breaking with >>> 30+ years of history. It's not worth the hassle IMO... >> >> Hi, Marcel >> >> I think we can just set gpt_first = 16 in g_part_bsd_create for new >> tables and for existing tables also set gpt_first = 16 if all partitions >> don not use this space. Something like this (untested): > > You may want to look at /etc/disktab. Are you willing to > change all entries and deal with the consequences? :-) > according [1] and bsdlabel(8), we can preserve 0 if we use ZFS (this filesystem have space for boot code), and 8k for UFS (this filesystem have no space for boot code). So if we install UFS without boot, can we preserve no gap? [1]: [http://wiki.freebsd.org/RootOnZFS/ZFSBootPartition] -- Eir Nym > -- > Marcel Moolenaar > marcel@xcllnt.net > > From owner-freebsd-geom@FreeBSD.ORG Tue Jun 28 07:44:20 2011 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 98822106566B for ; Tue, 28 Jun 2011 07:44:20 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward4.mail.yandex.net (forward4.mail.yandex.net [77.88.46.9]) by mx1.freebsd.org (Postfix) with ESMTP id 462C88FC15 for ; Tue, 28 Jun 2011 07:44:19 +0000 (UTC) Received: from smtp3.mail.yandex.net (smtp3.mail.yandex.net [77.88.46.103]) by forward4.mail.yandex.net (Yandex) with ESMTP id 41FFD50402D; Tue, 28 Jun 2011 11:44:18 +0400 (MSD) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1309247058; bh=ZCSpRqyrGc3oV64Y64YpUbcpEDgx1W8oYbJXcHXeFIM=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=iuIw1/2H/4bJnHG/hLJveqmag+nMNTTNYvdYCodHf1m4cDIt8FfXZ/FKj4taFIZqS gARRoW7tOvW6vJtam0Phd79q7DBrHn2klvFxK5xg4AzyWsh3nOGMcwA+RI3NHdrGSs L89LZ9ZlUTq7d27SoY6lZ0cWdqBb/GH+OrV9UuRY= Received: from [127.0.0.1] (unknown [77.72.136.146]) by smtp3.mail.yandex.net (Yandex) with ESMTPSA id 07AB369800B5; Tue, 28 Jun 2011 11:44:17 +0400 (MSD) Message-ID: <4E098651.6020909@yandex.ru> Date: Tue, 28 Jun 2011 11:44:17 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla Thunderbird 1.5 (FreeBSD/20051231) MIME-Version: 1.0 To: Eir Nym References: <201106280510.p5S5A8O0073022@freefall.freebsd.org> In-Reply-To: <201106280510.p5S5A8O0073022@freefall.freebsd.org> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit X-Yandex-Spam: 1 Cc: freebsd-geom@FreeBSD.org Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2011 07:44:20 -0000 On 28.06.2011 9:10, Eir Nym wrote: > according [1] and bsdlabel(8), we can preserve 0 if we use ZFS (this > filesystem have space for boot code), and 8k for UFS (this filesystem > have no space for boot code). > > So if we install UFS without boot, can we preserve no gap? > > [1]: [http://wiki.freebsd.org/RootOnZFS/ZFSBootPartition] You can use UFS and swap without offset too. -- WBR, Andrey V. Elsukov From owner-freebsd-geom@FreeBSD.ORG Tue Jun 28 07:50:19 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 30803106566C for ; Tue, 28 Jun 2011 07:50:19 +0000 (UTC) (envelope-from eirnym@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id E80D38FC0C for ; Tue, 28 Jun 2011 07:50:18 +0000 (UTC) Received: by iwr19 with SMTP id 19so6620773iwr.13 for ; Tue, 28 Jun 2011 00:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=13JhvMLN7cCaPMIOfXbOvI+b88vfUr1LGMKBi4N1sF4=; b=wCkZqTID94LFm0OY3p7VMwB4lF1j/ww3jYuh6Va7B2pZmEl9yud0hWObYmnkuhMC9j TrK5LHrx7VpZOVTy5nSGDCkoz+zbKVYbrn+bhb748Hh8yt0sltOSzzXmVqZF/KfxZ/xS FrCMmJgPRl1+K/GUbqRGeYLaX2QQvzz92UlqY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=BXMusqxaojQkppeZGzCQsH8FW+hL9d2QBxAUycgMRI+V308L0ZTpWT8WaikM+2DaiY DWNvQHSAZDyGFtA/HoDaqUaWvVUUPESKDduSg14ec7suk/tx6soDwa90fnXxhHIGtMst 6QpFJVn5L0nVw965DFG7ODrlAktTEMWmzgzvQ= Received: by 10.231.207.71 with SMTP id fx7mr6565481ibb.168.1309247418269; Tue, 28 Jun 2011 00:50:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.38.5 with HTTP; Tue, 28 Jun 2011 00:49:58 -0700 (PDT) In-Reply-To: <4E098651.6020909@yandex.ru> References: <201106280510.p5S5A8O0073022@freefall.freebsd.org> <4E098651.6020909@yandex.ru> From: Eir Nym Date: Tue, 28 Jun 2011 11:49:58 +0400 Message-ID: To: "Andrey V. Elsukov" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-geom@freebsd.org Subject: Re: kern/157724: [geom] gpart(8) 'add' command must preserve gap for schemes X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2011 07:50:19 -0000 2011/6/28 Andrey V. Elsukov : > On 28.06.2011 9:10, Eir Nym wrote: >> =C2=A0according [1] and bsdlabel(8), we can preserve 0 if we use ZFS (th= is >> =C2=A0filesystem have space for boot code), and 8k for UFS (this filesys= tem >> =C2=A0have no space for boot code). >> >> =C2=A0So if we install UFS without boot, can we preserve no gap? >> >> =C2=A0[1]: [http://wiki.freebsd.org/RootOnZFS/ZFSBootPartition] > > You can use UFS and swap without offset too. > So we have answer what to do: we should document this gap for bootable UFS. I think boot(8) and gpart(8) man page is the best place to do this. But boot loader install process for ZFS should be documented in man page to= o. -- Eir Nym > -- > WBR, Andrey V. Elsukov > From owner-freebsd-geom@FreeBSD.ORG Wed Jun 29 07:22:51 2011 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F695106564A; Wed, 29 Jun 2011 07:22:51 +0000 (UTC) (envelope-from ae@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 386B18FC0A; Wed, 29 Jun 2011 07:22:51 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5T7MplM073365; Wed, 29 Jun 2011 07:22:51 GMT (envelope-from ae@freefall.freebsd.org) Received: (from ae@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5T7MpFr073361; Wed, 29 Jun 2011 07:22:51 GMT (envelope-from ae) Date: Wed, 29 Jun 2011 07:22:51 GMT Message-Id: <201106290722.p5T7MpFr073361@freefall.freebsd.org> To: ae@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-geom@FreeBSD.org From: ae@FreeBSD.org Cc: Subject: Re: kern/158398: [headers] [patch] includes gratuitously X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2011 07:22:51 -0000 Synopsis: [headers] [patch] includes gratuitously Responsible-Changed-From-To: freebsd-bugs->freebsd-geom Responsible-Changed-By: ae Responsible-Changed-When: Wed Jun 29 07:21:02 UTC 2011 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=158398 From owner-freebsd-geom@FreeBSD.ORG Wed Jun 29 17:50:49 2011 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 200711065673; Wed, 29 Jun 2011 17:50:49 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id AE24D8FC18; Wed, 29 Jun 2011 17:50:48 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id 0516C5D3; Wed, 29 Jun 2011 18:41:41 +0200 (CEST) Date: Wed, 29 Jun 2011 19:50:15 +0200 From: Pawel Jakub Dawidek To: Alexander Motin Message-ID: <20110629175015.GC1741@garage.freebsd.pl> References: <1308851620.3853.34.camel@buffy.york.ac.uk> <4E038051.3020809@FreeBSD.org> <4e03c408.45822a0a.66cf.ffffe135SMTPIN_ADDED@mx.google.com> <4E03C621.4050505@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TYecfFk8j8mZq+dy" Content-Disposition: inline In-Reply-To: <4E03C621.4050505@FreeBSD.org> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Gavin Atkinson , freebsd-geom@FreeBSD.org Subject: Re: geom_raid tasting providers that can't be raw disks X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2011 17:50:49 -0000 --TYecfFk8j8mZq+dy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 24, 2011 at 02:02:57AM +0300, Alexander Motin wrote: > It may depend on metadata format. For example, Intel format depends on > valid provider serial number. It can't be used on providers without > serial number -- it won't be able to find place in array for the > components. Not sure if any non-hardware provider has serial number, so > this limitation can be effectively the same. The geom_slice library handles GEOM::ident by querying underlying provider for its serial number and adding 's%d' suffix, where %d stands for slice index. So at least partitions have serial numbers if the underlying provider has it. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --TYecfFk8j8mZq+dy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk4LZdYACgkQForvXbEpPzTmFQCg+TuerK/Dv//e6j8UG12x//34 yr8An0a2F2AFAjVcetpIKlHgaAgQghqK =ns1U -----END PGP SIGNATURE----- --TYecfFk8j8mZq+dy-- From owner-freebsd-geom@FreeBSD.ORG Sat Jul 2 14:49:32 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B6201065673 for ; Sat, 2 Jul 2011 14:49:32 +0000 (UTC) (envelope-from cl000116@colombia.dattaweb.com) Received: from colombia.dattaweb.com (colombia.dattaweb.com [200.58.111.45]) by mx1.freebsd.org (Postfix) with ESMTP id 078D98FC14 for ; Sat, 2 Jul 2011 14:49:32 +0000 (UTC) Received: from cl000116 by colombia.dattaweb.com with local (Exim 4.71) (envelope-from ) id 1Qd0hf-0007My-A9 for freebsd-geom@freebsd.org; Sat, 02 Jul 2011 10:57:47 -0300 To: Freebsd Geom Date: Sat, 2 Jul 2011 10:57:47 -0300 From: centro medico revitalizare Message-ID: <0e5ba6112be284a60d81c039d1fa54e5@kelanea.com.ar> X-Priority: 3 X-Mailer: PHPMailer (phpmailer.sourceforge.net) [version 2.0.4] X-Mailid: 9 X-Subid: 18772 MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - colombia.dattaweb.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [619 618] / [502 502] X-AntiAbuse: Sender Address Domain - colombia.dattaweb.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: Primavera 2031 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: CMR List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jul 2011 14:49:32 -0000 F e l i z PRIMAVERA 2 0 3 1 drweschenfeller@gmail.com ( mailto:drweschenfeller@gmail.com ) rositapilotti02@gmail.com ( mailto:rositapilotti02@gmail.com ) CENTRO MEDICO REVITALIZARE® Resistencia Chaco Argentina Hola: queremos invitarte a la fiesta de PRIMAVERA del 2031 y a la de AÑO NUEVO 2032. Te sorprenderá, falta mucho todavía pero lo queremos hacer ahora para que sepas que vas a hacer con los 20 años que te quedan por delante y bien. Que tal, que te parece tener esas dos décadas y bien,con buen estado de salud y buen estado mental la de cosas que se pueden hacer, todo lo que se puede conocer o producir. Es como tener un plus y una nueva vida. Usamos técnicas antiage orthomelculares,quelación para limpieza arterial ,ozonoterapia , limpieza intersticial .Vacuna antiage 2011® Al mismo tiempo realizamos TERAPIAS METABOLICAS REPOLARIZANTES. Magnetoterapia pulsante y medicación con óxido nítrico. Implantes de factores de crecimientos y células madres autólogas por via endovenos. Si te interesa contacta con nosotros a los mails siguientes e vamos a decir como con gusto,drweschenfeller@gmail.com o rositapilotti02@gmail.com ( mailto:rositapilotti02@gmail.com ) y entrando a nuestra página de de revitalizare com podés suscribirte a nuestros fascículos de información y actualización. Queremos buscar entre todos como vivir nuestros primeros 100 años o los que sean pero muy bien!!! .Obvio si ya cumpliste los 100 esto todavía no es para vos. From owner-freebsd-geom@FreeBSD.ORG Sat Jul 2 17:00:26 2011 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D799106566C for ; Sat, 2 Jul 2011 17:00:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1CEB08FC0A for ; Sat, 2 Jul 2011 17:00:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p62H0Pqd041632 for ; Sat, 2 Jul 2011 17:00:25 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p62H0Pmn041631; Sat, 2 Jul 2011 17:00:25 GMT (envelope-from gnats) Date: Sat, 2 Jul 2011 17:00:25 GMT Message-Id: <201107021700.p62H0Pmn041631@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: "Andrey V. Elsukov" Cc: Subject: Re: kern/158398: [headers] [patch] < geom/geom.h> includes < sys/sbuf.h> gratuitously X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Andrey V. Elsukov" List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jul 2011 17:00:26 -0000 The following reply was made to PR kern/158398; it has been noted by GNATS. From: "Andrey V. Elsukov" To: bug-followup@FreeBSD.org, rmh@debian.org Cc: Subject: Re: kern/158398: [headers] [patch] <geom/geom.h> includes <sys/sbuf.h> gratuitously Date: Sat, 02 Jul 2011 20:52:22 +0400 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig65B144ED5E03B8970219EADD Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable Hi, Robert I think it is not enough. Actually this patch breaks building of many geom kernel modules. --=20 WBR, Andrey V. Elsukov --------------enig65B144ED5E03B8970219EADD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBAgAGBQJOD0zMAAoJEAHF6gQQyKF6qvYH/03n7UjuMSUImEQ/7FYzjVW/ cEEcAkZqGugXdV7wxJ5lG/G2AiFhTrdSXE4u8Pq9pYHwc64ta7w5pr6SUyd+lfO2 PSKBvELRYVquFbhZjtLoHc5uika36jpap61kJ7EwQ3OZXUZ0G7xmk1aRnpN+4Wnd mhEJQc49c8vB+1F2g+lfcLvuVHX/bIZ5w716fUOimKl8ynuDpE7qktrgS1CfMjlW YMSa1LOzeLEwqbHDyq4V62Ls7ie3+Osggfl1tcZEZUhehRL3dr/RAk4XRKlpPBBW cDECTGyzG+cG/Nblex30JPRjty+OyRy5UaahyJpY7CUoP6nXY8D6sVmHvhJ5JZE= =R0ME -----END PGP SIGNATURE----- --------------enig65B144ED5E03B8970219EADD-- From owner-freebsd-geom@FreeBSD.ORG Sat Jul 2 19:00:21 2011 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F7B8106566B for ; Sat, 2 Jul 2011 19:00:21 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 62FD28FC0A for ; Sat, 2 Jul 2011 19:00:21 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p62J0Lat052662 for ; Sat, 2 Jul 2011 19:00:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p62J0LtU052661; Sat, 2 Jul 2011 19:00:21 GMT (envelope-from gnats) Date: Sat, 2 Jul 2011 19:00:21 GMT Message-Id: <201107021900.p62J0LtU052661@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Robert Millan Cc: Subject: Re: kern/158398: [headers] [patch] <geom/geom.h> includes <sys/sbuf.h> gratuitously X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Robert Millan List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jul 2011 19:00:21 -0000 The following reply was made to PR kern/158398; it has been noted by GNATS. From: Robert Millan To: "Andrey V. Elsukov" Cc: bug-followup@freebsd.org Subject: Re: kern/158398: [headers] [patch] <geom/geom.h> includes <sys/sbuf.h> gratuitously Date: Sat, 2 Jul 2011 20:52:22 +0200 2011/7/2 Andrey V. Elsukov : > Hi, Robert > > I think it is not enough. Actually this patch breaks building of many > geom kernel modules. Sorry for the oversight. We test _KERNEL and non-_KERNEL mode with different patchsets, so I was only thinking on userland here. I'll have a look at this. -- Robert Millan