From owner-freebsd-standards@FreeBSD.ORG Sun Jan 16 20:50:12 2011 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 02314106564A for ; Sun, 16 Jan 2011 20:50:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E5B978FC19 for ; Sun, 16 Jan 2011 20:50:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0GKoBlc093551 for ; Sun, 16 Jan 2011 20:50:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0GKoB1j093550; Sun, 16 Jan 2011 20:50:11 GMT (envelope-from gnats) Date: Sun, 16 Jan 2011 20:50:11 GMT Message-Id: <201101162050.p0GKoB1j093550@freefall.freebsd.org> To: freebsd-standards@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: standards/123688: POSIX standard changes in unistd.h and grp.h X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 20:50:12 -0000 The following reply was made to PR standards/123688; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, giffunip@tutopia.com Cc: Subject: Re: standards/123688: POSIX standard changes in unistd.h and grp.h Date: Sun, 16 Jan 2011 12:21:17 -0800 Some comments: - getgrouplist, initgroups, and setgroups are no longer in the POSIX standard (if they were ever there -- my copy of SUSv7 doesn't list them in the system interfaces section). setgroups was actually still listed in grp.h so if anything glibc is now more inconsistent than FreeBSD's libc in terms of interface locations. - mknod and setgrent are still incorrect. Given that setgrent is an obsolete API required as an XSH extension which have been around for ages, I think leaving it alone would be best (FreeBSD does its best to honor standards, but standards don't always honor historical behavior unfortunately). As for mknod I'll see what the potential fallout would be in terms of fixing that header include. Thanks, -Garrett From owner-freebsd-standards@FreeBSD.ORG Sun Jan 16 21:00:26 2011 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5005B106566B for ; Sun, 16 Jan 2011 21:00:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 245D88FC17 for ; Sun, 16 Jan 2011 21:00:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0GL0PNM003844 for ; Sun, 16 Jan 2011 21:00:25 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0GL0PJG003819; Sun, 16 Jan 2011 21:00:25 GMT (envelope-from gnats) Date: Sun, 16 Jan 2011 21:00:25 GMT Message-Id: <201101162100.p0GL0PJG003819@freefall.freebsd.org> To: freebsd-standards@FreeBSD.org From: "Pedro F. Giffuni" Cc: Subject: Re: standards/123688: POSIX standard changes in unistd.h and grp.h X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Pedro F. Giffuni" List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 21:00:26 -0000 The following reply was made to PR standards/123688; it has been noted by GNATS. From: "Pedro F. Giffuni" To: bug-followup@FreeBSD.org, Garrett Cooper Cc: Subject: Re: standards/123688: POSIX standard changes in unistd.h and grp.h Date: Sun, 16 Jan 2011 12:56:28 -0800 (PST) Thanks for the review: When the PR was created the then current standards (SUSV3 I think) did have the old functions. Solaris indeed keeps them as the PR suggests. I am OK with keeping the current location if the newer standard permits it. Thanks for looking at this *old* PR. From owner-freebsd-standards@FreeBSD.ORG Sun Jan 16 21:30:15 2011 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2B4BA10656BA for ; Sun, 16 Jan 2011 21:30:15 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E803B8FC2F for ; Sun, 16 Jan 2011 21:30:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0GLUDAH036345 for ; Sun, 16 Jan 2011 21:30:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0GLUDQ8036342; Sun, 16 Jan 2011 21:30:13 GMT (envelope-from gnats) Date: Sun, 16 Jan 2011 21:30:13 GMT Message-Id: <201101162130.p0GLUDQ8036342@freefall.freebsd.org> To: freebsd-standards@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: kern/93705: [headers] [patch] ENODATA and EGREGIOUS (for glibc compat) X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 21:30:15 -0000 The following reply was made to PR kern/93705; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, rmh@aybabtu.com Cc: Subject: Re: kern/93705: [headers] [patch] ENODATA and EGREGIOUS (for glibc compat) Date: Sun, 16 Jan 2011 13:20:42 -0800 For starters this should be listed under standards, not kern. Second off, FreeBSD hasn't made a real effort to implement XSI streams, so I don't think that this really should be `fixed', but instead glibc should be adapted to work without XSI streams on FreeBSD, because regardless of whether or not the data type is defined, if the libcall can't function properly when calling the kernel interfaces, having an additional set of datatypes is essentially superfluous support. Thanks, -Garrett PS Just like glebius@ I'm not representing the official opinion of the project :). From owner-freebsd-standards@FreeBSD.ORG Sun Jan 16 21:30:18 2011 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0971C106564A for ; Sun, 16 Jan 2011 21:30:18 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D1C268FC13 for ; Sun, 16 Jan 2011 21:30:17 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0GLUHhK036646 for ; Sun, 16 Jan 2011 21:30:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0GLUHv4036635; Sun, 16 Jan 2011 21:30:17 GMT (envelope-from gnats) Date: Sun, 16 Jan 2011 21:30:17 GMT Message-Id: <201101162130.p0GLUHv4036635@freefall.freebsd.org> To: freebsd-standards@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: standards/123688: POSIX standard changes in unistd.h and grp.h X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 21:30:18 -0000 The following reply was made to PR standards/123688; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, giffunip@tutopia.com Cc: Subject: Re: standards/123688: POSIX standard changes in unistd.h and grp.h Date: Sun, 16 Jan 2011 13:18:24 -0800 --0016e6de03be220ca70499fd35a7 Content-Type: text/plain; charset=ISO-8859-1 Here's a patch for mknod(2)/mknodat(2). Only one source file in base was incorrect (cp(1)) and all of the other source files that used mknod(2) had sys/stat.h in there already. Thanks, -Garrett --0016e6de03be220ca70499fd35a7 Content-Type: text/x-patch; charset=US-ASCII; name="fix-mknod-syscall-unistd-vs-sys-stat-include.patch" Content-Disposition: attachment; filename="fix-mknod-syscall-unistd-vs-sys-stat-include.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gj0g69ps0 SW5kZXg6IGJpbi9jcC91dGlscy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGJpbi9jcC91dGlscy5jCShyZXZp c2lvbiAyMTc0NjgpCisrKyBiaW4vY3AvdXRpbHMuYwkod29ya2luZyBjb3B5KQpAQCAtNDMsNiAr NDMsNyBAQAogI2luY2x1ZGUgPHN5cy9tbWFuLmg+CiAjZW5kaWYKIAorI2luY2x1ZGUgPHN5cy9z dGF0Lmg+CiAjaW5jbHVkZSA8ZXJyLmg+CiAjaW5jbHVkZSA8ZXJybm8uaD4KICNpbmNsdWRlIDxm Y250bC5oPgpJbmRleDogbGliL2xpYmMvc3lzL21rbm9kLjIKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGliL2xp YmMvc3lzL21rbm9kLjIJKHJldmlzaW9uIDIxNzQ2OCkKKysrIGxpYi9saWJjL3N5cy9ta25vZC4y CSh3b3JraW5nIGNvcHkpCkBAIC0zOCw3ICszOCw3IEBACiAuU2ggTElCUkFSWQogLkxiIGxpYmMK IC5TaCBTWU5PUFNJUwotLkluIHVuaXN0ZC5oCisuSW4gc3lzL3N0YXQuaAogLkZ0IGludAogLkZu IG1rbm9kICJjb25zdCBjaGFyICpwYXRoIiAibW9kZV90IG1vZGUiICJkZXZfdCBkZXYiCiAuRnQg aW50Cg== --0016e6de03be220ca70499fd35a7-- From owner-freebsd-standards@FreeBSD.ORG Sun Jan 16 22:00:22 2011 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F5B5106566C for ; Sun, 16 Jan 2011 22:00:22 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8D8E88FC12 for ; Sun, 16 Jan 2011 22:00:19 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0GM0J5n066899 for ; Sun, 16 Jan 2011 22:00:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0GM0JuE066879; Sun, 16 Jan 2011 22:00:19 GMT (envelope-from gnats) Date: Sun, 16 Jan 2011 22:00:19 GMT Message-Id: <201101162200.p0GM0JuE066879@freefall.freebsd.org> To: freebsd-standards@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: standards/92362: [headers] [patch] Missing SIGPOLL in kernel headers X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 22:00:22 -0000 The following reply was made to PR standards/92362; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, rmh@aybabtu.com Cc: standards@freebsd.org Subject: Re: standards/92362: [headers] [patch] Missing SIGPOLL in kernel headers Date: Sun, 16 Jan 2011 13:50:00 -0800 The OP's claim is wrong. SIGIO is a signal that can be discarded, whereas SIGPOLL by definition terminates processes. From SUSv7 (pardon the poor formatting): The following signals shall be supported on all implementations (default actions are explained below the table): Signal Default Action Description SIGPOLL T Pollable event. T Abnormal termination of the process. The process is terminated with all the consequences of _exit() except that the status made available to wait() and waitpid() indicates abnormal termination by the specified signal. From signal(3) (pardon the poor formatting): 23 SIGIO discard signal I/O is possible on a descriptor (see fcntl(2)) SIGPOLL is actually somewhere between SIGIO and SIGIOT (SIBABRT), but there isn't a 1:1 mapping for the signal definition. This is also XSI Stream specific (which is not [fully] implemented in [Free]BSD). SIGIO is also used by fcntl(2) to denote when I/O is available, but this connotation is not noted in SUSv7 either. This item should probably be closed as WONTFIX as we don't implement SIGPOLL in its proper form. Thanks, -Garrett PS FWIW GNU/Linux needs to be educated on the fact that SIGIO is a discardable signal on other platforms and not an alias for SIGPOLL on BSD (especially when they use it as an alias but don't document the requirement >:(...), because a quick look at some glibc and Linux headers shows that they are using them as a 1:1 mapping (I am using Fedora 13 as a reference). From owner-freebsd-standards@FreeBSD.ORG Sun Jan 16 22:00:24 2011 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D283106564A for ; Sun, 16 Jan 2011 22:00:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EFBCC8FC18 for ; Sun, 16 Jan 2011 22:00:23 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0GM0N8I067790 for ; Sun, 16 Jan 2011 22:00:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0GM0N2Z067773; Sun, 16 Jan 2011 22:00:23 GMT (envelope-from gnats) Date: Sun, 16 Jan 2011 22:00:23 GMT Message-Id: <201101162200.p0GM0N2Z067773@freefall.freebsd.org> To: freebsd-standards@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: standards/123688: POSIX standard changes in unistd.h and grp.h X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 22:00:24 -0000 The following reply was made to PR standards/123688; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@freebsd.org, giffunip@tutopia.com Cc: Subject: Re: standards/123688: POSIX standard changes in unistd.h and grp.h Date: Sun, 16 Jan 2011 13:53:20 -0800 On Sun, Jan 16, 2011 at 1:18 PM, Garrett Cooper wrote: > =A0 =A0Here's a patch for mknod(2)/mknodat(2). Only one source file in > base was incorrect (cp(1)) and all of the other source files that used > mknod(2) had sys/stat.h in there already. Just as a comment, jilles@ pointed out to me that bin/cp/utils.c was already including sys/stat.h . So only the manpage needs to be updated. Thanks, -Garrett From owner-freebsd-standards@FreeBSD.ORG Sun Jan 16 22:08:38 2011 Return-Path: Delivered-To: standards@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DDCBC106564A for ; Sun, 16 Jan 2011 22:08:36 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3EB678FC08 for ; Sun, 16 Jan 2011 22:08:35 +0000 (UTC) Received: by wyf19 with SMTP id 19so4663285wyf.13 for ; Sun, 16 Jan 2011 14:08:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:date:x-google-sender-auth :message-id:subject:from:to:cc:content-type; bh=BH1gt2+Dz/G+WygClnKlVV/T469eNDmApmADYJhMZ4Q=; b=O7GUqxpdKdKLpadb4ab8kDoQatCAEgmEc1o1Zee9LRzsJTAHxCpNbRwfWfz196ikvc PMipuhBBeYvYh2oTX5tepU2BZLItW8HH/lFz1NEJcfywEJEL2tfM+BDXH2f+gY3fap8O GIgvRlTVLJqmJIdIaR4LMQEMpWhmaQoq5TAxs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; b=xtxMPAmY0SF1VZ04oGnfZY4LHFyiys6OvKSb6zLJCJzmoH/DAoc+ZTFHs7rW+N+86y fhB2zSGU1CtUKUDrGUeFEetoCszSyX/A6vVWmWGHNTYRGy6Fr/BSLGn9nNg6BBRTCfSN MUpe18CTuhai8eLqoFMHTlVrbJGb2H9gvbVao= MIME-Version: 1.0 Received: by 10.216.78.146 with SMTP id g18mr2738793wee.1.1295214600852; Sun, 16 Jan 2011 13:50:00 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.254.226 with HTTP; Sun, 16 Jan 2011 13:50:00 -0800 (PST) Date: Sun, 16 Jan 2011 13:50:00 -0800 X-Google-Sender-Auth: daXWmE-JcrqY8AWWKplZsY6PDNU Message-ID: From: Garrett Cooper To: bug-followup@FreeBSD.org, rmh@aybabtu.com Content-Type: text/plain; charset=ISO-8859-1 Cc: standards@freebsd.org Subject: Re: standards/92362: [headers] [patch] Missing SIGPOLL in kernel headers X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 22:08:39 -0000 The OP's claim is wrong. SIGIO is a signal that can be discarded, whereas SIGPOLL by definition terminates processes. From SUSv7 (pardon the poor formatting): The following signals shall be supported on all implementations (default actions are explained below the table): Signal Default Action Description SIGPOLL T Pollable event. T Abnormal termination of the process. The process is terminated with all the consequences of _exit() except that the status made available to wait() and waitpid() indicates abnormal termination by the specified signal. From signal(3) (pardon the poor formatting): 23 SIGIO discard signal I/O is possible on a descriptor (see fcntl(2)) SIGPOLL is actually somewhere between SIGIO and SIGIOT (SIBABRT), but there isn't a 1:1 mapping for the signal definition. This is also XSI Stream specific (which is not [fully] implemented in [Free]BSD). SIGIO is also used by fcntl(2) to denote when I/O is available, but this connotation is not noted in SUSv7 either. This item should probably be closed as WONTFIX as we don't implement SIGPOLL in its proper form. Thanks, -Garrett PS FWIW GNU/Linux needs to be educated on the fact that SIGIO is a discardable signal on other platforms and not an alias for SIGPOLL on BSD (especially when they use it as an alias but don't document the requirement >:(...), because a quick look at some glibc and Linux headers shows that they are using them as a 1:1 mapping (I am using Fedora 13 as a reference). From owner-freebsd-standards@FreeBSD.ORG Sun Jan 16 22:34:21 2011 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA84E1065672; Sun, 16 Jan 2011 22:34:21 +0000 (UTC) (envelope-from jilles@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B1CF28FC14; Sun, 16 Jan 2011 22:34:21 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0GMYLG6011009; Sun, 16 Jan 2011 22:34:21 GMT (envelope-from jilles@freefall.freebsd.org) Received: (from jilles@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0GMYLJO011004; Sun, 16 Jan 2011 22:34:21 GMT (envelope-from jilles) Date: Sun, 16 Jan 2011 22:34:21 GMT Message-Id: <201101162234.p0GMYLJO011004@freefall.freebsd.org> To: rmh@aybabtu.com, jilles@FreeBSD.org, freebsd-standards@FreeBSD.org From: jilles@FreeBSD.org Cc: Subject: Re: standards/92362: [headers] [patch] Missing SIGPOLL in kernel headers X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 22:34:21 -0000 Synopsis: [headers] [patch] Missing SIGPOLL in kernel headers State-Changed-From-To: open->closed State-Changed-By: jilles State-Changed-When: Sun Jan 16 22:33:04 UTC 2011 State-Changed-Why: Firstly, note that SIGPOLL is under the XSI option, which FreeBSD does not attempt to implement completely. (In SUSv4, it's even Obsolescent XSI STREAMS. We do not have STREAMS in FreeBSD.) Secondly, I don't think our siginfo-less default-to-ignore SIGIO is going to help a SIGPOLL-using program much. http://www.freebsd.org/cgi/query-pr.cgi?pr=92362 From owner-freebsd-standards@FreeBSD.ORG Sun Jan 16 23:05:13 2011 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 412541065672; Sun, 16 Jan 2011 23:05:13 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1716B8FC15; Sun, 16 Jan 2011 23:05:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0GN5CtX044049; Sun, 16 Jan 2011 23:05:12 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0GN5CCm044045; Sun, 16 Jan 2011 23:05:12 GMT (envelope-from linimon) Date: Sun, 16 Jan 2011 23:05:12 GMT Message-Id: <201101162305.p0GN5CCm044045@freefall.freebsd.org> To: dfilter@FreeBSD.ORG, linimon@FreeBSD.org, gnats-admin@FreeBSD.org, freebsd-standards@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: standards/154068: Re: standards/123688: commit references a PR X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 23:05:13 -0000 Old Synopsis: Re: standard/123688: commit references a PR New Synopsis: Re: standards/123688: commit references a PR State-Changed-From-To: open->closed State-Changed-By: linimon State-Changed-When: Sun Jan 16 23:04:39 UTC 2011 State-Changed-Why: Misfiled followup to standards/123688; content migrated. Responsible-Changed-From-To: gnats-admin->freebsd-standards Responsible-Changed-By: linimon Responsible-Changed-When: Sun Jan 16 23:04:39 UTC 2011 Responsible-Changed-Why: http://www.freebsd.org/cgi/query-pr.cgi?pr=154068 From owner-freebsd-standards@FreeBSD.ORG Sun Jan 16 23:10:11 2011 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C754E1065673 for ; Sun, 16 Jan 2011 23:10:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9C7478FC0A for ; Sun, 16 Jan 2011 23:10:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0GNABGa044563 for ; Sun, 16 Jan 2011 23:10:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0GNABlW044562; Sun, 16 Jan 2011 23:10:11 GMT (envelope-from gnats) Date: Sun, 16 Jan 2011 23:10:11 GMT Message-Id: <201101162310.p0GNABlW044562@freefall.freebsd.org> To: freebsd-standards@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: kern/93705: [headers] [patch] ENODATA and EGREGIOUS (for glibc compat) X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 23:10:11 -0000 The following reply was made to PR kern/93705; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, rmh@aybabtu.com Cc: Subject: Re: kern/93705: [headers] [patch] ENODATA and EGREGIOUS (for glibc compat) Date: Sun, 16 Jan 2011 15:02:10 -0800 My previous response was in regard to ENODATA, which is an obsolete XSI streams extension. EGREGIOUS wasn't present in Fedora 13's glibc, so apparently it was removed (EDOOFUS isn't present either :)...). Thanks, -Garrett From owner-freebsd-standards@FreeBSD.ORG Sun Jan 16 23:27:43 2011 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD8AE106566B; Sun, 16 Jan 2011 23:27:43 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B40C18FC0A; Sun, 16 Jan 2011 23:27:43 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0GNRhvr065196; Sun, 16 Jan 2011 23:27:43 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0GNRhRY065192; Sun, 16 Jan 2011 23:27:43 GMT (envelope-from linimon) Date: Sun, 16 Jan 2011 23:27:43 GMT Message-Id: <201101162327.p0GNRhRY065192@freefall.freebsd.org> To: rmh@aybabtu.com, linimon@FreeBSD.org, freebsd-standards@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/93705: [headers] [patch] ENODATA and EGREGIOUS (for glibc compat) X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 23:27:43 -0000 Synopsis: [headers] [patch] ENODATA and EGREGIOUS (for glibc compat) State-Changed-From-To: open->closed State-Changed-By: linimon State-Changed-When: Sun Jan 16 23:27:06 UTC 2011 State-Changed-Why: After some discussion, it seems that no one wants to implement these. Since submitter's email address now bounces, just close this one. http://www.freebsd.org/cgi/query-pr.cgi?pr=93705 From owner-freebsd-standards@FreeBSD.ORG Mon Jan 17 11:07:08 2011 Return-Path: Delivered-To: freebsd-standards@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D1978106566C for ; Mon, 17 Jan 2011 11:07:08 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BF9FD8FC1C for ; Mon, 17 Jan 2011 11:07:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0HB78Ab049018 for ; Mon, 17 Jan 2011 11:07:08 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0HB78sp049016 for freebsd-standards@FreeBSD.org; Mon, 17 Jan 2011 11:07:08 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 17 Jan 2011 11:07:08 GMT Message-Id: <201101171107.p0HB78sp049016@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-standards@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-standards@FreeBSD.org X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2011 11:07:08 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o stand/153756 standards fp leak in hesiod.c . o stand/152415 standards [libm] implementation of expl() o stand/151316 standards lib/libc/string/strerror.c r1.9 breaks POSIX o stand/150093 standards C++ std::locale support is broken a stand/149980 standards [libc] [patch] negative value integer to nanosleep(2) o stand/147210 standards xmmintrin.h and cstdlib conflicts with each other with o stand/144231 standards bind/connect/sendto too strict about sockaddr length o stand/142803 standards j0 Bessel function inaccurate near zeros of the functi s stand/141705 standards [libc] [request] libc lacks cexp (and friends) o stand/130067 standards Wrong numeric limits in system headers? o stand/124860 standards flockfile(3) doesn't work when the memory has been exh o stand/123688 standards POSIX standard changes in unistd.h and grp.h o stand/121921 standards [patch] Add leap second support to at(1), atrun(8) o stand/116826 standards [patch] sh support for POSIX character classes o stand/116477 standards rm(1): rm behaves unexpectedly when using -r and relat o bin/116413 standards incorrect getconf(1) handling of unsigned constants gi o stand/116081 standards make does not work with the directive sinclude o stand/114633 standards /etc/rc.subr: line 511: omits a quotation mark: "force p stand/107561 standards [libc] [patch] [request] Missing SUS function tcgetsid o stand/104743 standards [headers] [patch] Wrong values for _POSIX_ minimal lim o stand/100017 standards [Patch] Add fuser(1) functionality to fstat(1) o stand/96236 standards [patch] [posix] sed(1) incorrectly describes a functio o stand/96016 standards [headers] clock_getres et al should be in o stand/94729 standards [libc] fcntl() throws undocumented ENOTTY a stand/86484 standards [patch] mkfifo(1) uses wrong permissions o stand/82654 standards C99 long double math functions are missing o stand/81287 standards [patch] fingerd(8) might send a line not ending in CRL a stand/80293 standards sysconf() does not support well-defined unistd values o stand/79056 standards [feature request] [atch] regex(3) regression tests o stand/70813 standards [patch] ls(1) not Posix compliant o stand/66357 standards make POSIX conformance problem ('sh -e' & '+' command- s kern/64875 standards [libc] [patch] [request] add a system call: fdatasync( s stand/62858 standards malloc(0) not C99 compliant o stand/56476 standards [patch] cd9660 unicode support simple hack o stand/54410 standards one-true-awk not POSIX compliant (no extended REs) o stand/46119 standards Priority problems for SCHED_OTHER using pthreads o stand/44365 standards [headers] [patch] [request] introduce ulong and unchar a stand/41576 standards ln(1): replacing old dir-symlinks o stand/39256 standards snprintf/vsnprintf aren't POSIX-conformant for strings a docs/26003 standards getgroups(2) lists NGROUPS_MAX but not syslimits.h s stand/24590 standards timezone function not compatible witn Single Unix Spec o stand/21519 standards sys/dir.h should be deprecated some more s bin/14925 standards getsubopt isn't poisonous enough 43 problems total. From owner-freebsd-standards@FreeBSD.ORG Fri Jan 21 05:40:07 2011 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 439551065675 for ; Fri, 21 Jan 2011 05:40:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0731F8FC12 for ; Fri, 21 Jan 2011 05:40:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0L5e6n4076220 for ; Fri, 21 Jan 2011 05:40:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0L5e6eE076219; Fri, 21 Jan 2011 05:40:06 GMT (envelope-from gnats) Resent-Date: Fri, 21 Jan 2011 05:40:06 GMT Resent-Message-Id: <201101210540.p0L5e6eE076219@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-standards@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Zhouyi Zhou Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A49A7106564A for ; Fri, 21 Jan 2011 05:33:17 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 9494A8FC1D for ; Fri, 21 Jan 2011 05:33:17 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p0L5XHie003509 for ; Fri, 21 Jan 2011 05:33:17 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p0L5XHXL003508; Fri, 21 Jan 2011 05:33:17 GMT (envelope-from nobody) Message-Id: <201101210533.p0L5XHXL003508@red.freebsd.org> Date: Fri, 21 Jan 2011 05:33:17 GMT From: Zhouyi Zhou To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: standards/154185: race condition in mb_dupcl X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jan 2011 05:40:07 -0000 >Number: 154185 >Category: standards >Synopsis: race condition in mb_dupcl >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-standards >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jan 21 05:40:06 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Zhouyi Zhou >Release: FreeBSD 8.0 >Organization: ICT CAS >Environment: FreeBSD zzy 8.0-RELEASE FreeBSD 8.0-RELEASE #85: Fri Jan 21 12:56:40 UTC 2011 root@zzy:/root/sys/amd64/compile/GENERIC amd64 >Description: There is race condition in function mb_dupcl in src/sys/kern/uipc_mbuf.c The code to add reference count in mb_dupcl is as follows 390 if (*(m->m_ext.ref_cnt) == 1) 391 *(m->m_ext.ref_cnt) += 1; The x86 asm code for these two lines is: 0xffffffff807aa28d : sub $0x1,%eax 0xffffffff807aa290 : je 0xffffffff807aa2f0 .. 0xffffffff807aa2f0 : mov (%rdx),%ecx 0xffffffff807aa2f2 : add $0x1,%ecx 0xffffffff807aa2f5 : mov %ecx,(%rdx) It is appearant that multiple threads will race for the contents of (%rdx) >How-To-Repeat: Can write a kernel module like: struct mbuf *m; MGETHDR(m, M_DONTWAIT, MT_DATA); MCLGET(m, M_DONTWAIT); Then let multiple threads execute simulately: m1 = m_copypacket(m, M_DONTWAIT); m_freem(m1); >Fix: function mb_dupcl 390 - if (*(m->m_ext.ref_cnt) == 1) 391 - *(m->m_ext.ref_cnt) += 1; 392 - else 393 atomic_add_int(m->m_ext.ref_cnt, 1); >Release-Note: >Audit-Trail: >Unformatted: