Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 Oct 2011 21:15:40 +0100
From:      Hans Petter Selasky <hselasky@c2i.net>
To:        Pawel Jakub Dawidek <pjd@freebsd.org>
Cc:        freebsd-usb@freebsd.org
Subject:   Re: Quirk for a USB mass storage device
Message-ID:  <201110302115.40450.hselasky@c2i.net>
In-Reply-To: <20111029183807.GF1713@garage.freebsd.pl>
References:  <4EA9127E.80504@entel.upc.edu> <201110290851.15130.hselasky@c2i.net> <20111029183807.GF1713@garage.freebsd.pl>

next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 29 October 2011 20:38:07 Pawel Jakub Dawidek wrote:
> > +     err = usbd_do_request(udev, NULL, &req, &buf);
> > +     if (err)
> > +             buf = 0;
> > +
> > +     return (buf);
> > +}
> 
> You could drop 'err' variable and just check function return directly.
> There is only one extra empty line at the begining of the function.

No, because there is &buf.

I'll add your device to the device quirk list.

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110302115.40450.hselasky>