From owner-freebsd-acpi@FreeBSD.ORG Sun Jul 8 09:11:44 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0970C106566C for ; Sun, 8 Jul 2012 09:11:44 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 58F858FC0A for ; Sun, 8 Jul 2012 09:11:43 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA22598; Sun, 08 Jul 2012 12:11:35 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1SnnWh-000GpF-63; Sun, 08 Jul 2012 12:11:35 +0300 Message-ID: <4FF94EC4.1060109@FreeBSD.org> Date: Sun, 08 Jul 2012 12:11:32 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120620 Thunderbird/13.0.1 MIME-Version: 1.0 To: "freebsd-acpi@freebsd.org" X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=X-VIET-VPS Content-Transfer-Encoding: 7bit Cc: Subject: disabled CST_CNT write X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2012 09:11:44 -0000 acpi_cpu.c has a block of code to write CST_CNT to SMI_CMD, but the block is under #ifdef notyet. It seems that the code was added that many years ago and never enabled. Now, judging from the reports I've seen on this mailing list, it appears that _CST changes do happen and the driver seem to handle them sufficiently well. I think that a lot of modern platforms do not even provide CST_CNT and assume that an OS is able to handle C-state change notifications. So, I guess that it should be safe to enable the code in question now. Could anyone with a FreeBSD laptop and non-zero CST_CNT in FADT please test this? Thank you. -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Sun Jul 8 10:19:42 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0C5C51065676; Sun, 8 Jul 2012 10:19:42 +0000 (UTC) (envelope-from taku@tackymt.homeip.net) Received: from basalt.tackymt.homeip.net (unknown [IPv6:2001:3e0:577:0:20d:61ff:fecc:2253]) by mx1.freebsd.org (Postfix) with ESMTP id 9B7228FC14; Sun, 8 Jul 2012 10:19:41 +0000 (UTC) Received: from basalt.tackymt.homeip.net (localhost [127.0.0.1]) by basalt.tackymt.homeip.net (Postfix) with ESMTP id 791CF83A0; Sun, 8 Jul 2012 19:19:40 +0900 (JST) X-Virus-Scanned: amavisd-new at tackymt.homeip.net Received: from localhost by basalt.tackymt.homeip.net (amavisd-new, unix socket) with ESMTP id g0GXqs3N7Qd2; Sun, 8 Jul 2012 19:19:37 +0900 (JST) Received: from basalt.tackymt.homeip.net (basalt.tackymt.homeip.net [IPv6:2001:3e0:577:0:20d:61ff:fecc:2253]) by basalt.tackymt.homeip.net (Postfix) with ESMTPSA; Sun, 8 Jul 2012 19:19:37 +0900 (JST) Date: Sun, 8 Jul 2012 19:19:37 +0900 From: Taku YAMAMOTO To: Andriy Gapon Message-Id: <20120708191937.46148f65.taku@tackymt.homeip.net> In-Reply-To: <4FF94EC4.1060109@FreeBSD.org> References: <4FF94EC4.1060109@FreeBSD.org> X-Mailer: Sylpheed 3.0.3 (GTK+ 2.24.6; i386-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "freebsd-acpi@freebsd.org" Subject: Re: disabled CST_CNT write X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2012 10:19:42 -0000 On Sun, 08 Jul 2012 12:11:32 +0300 Andriy Gapon wrote: > > acpi_cpu.c has a block of code to write CST_CNT to SMI_CMD, but the block is > under #ifdef notyet. It seems that the code was added that many years ago and > never enabled. > Now, judging from the reports I've seen on this mailing list, it appears that > _CST changes do happen and the driver seem to handle them sufficiently well. > I think that a lot of modern platforms do not even provide CST_CNT and assume > that an OS is able to handle C-state change notifications. > So, I guess that it should be safe to enable the code in question now. > > Could anyone with a FreeBSD laptop and non-zero CST_CNT in FADT please test this? My Thinkpad X60 (Core 2 Duo) is such one of them. Enabling that code makes this laptop correctly raise _CST change notification on AC status change without a single problem. Without enabling that, this laptop never generates such notifications. In fact, I have been enabling that code locally for more than a couple of years without a problem :) In addition, that does not interfere with jkim's acpi_cx_native2.diff; I've been enjoying MWAIT C3 with varying sleep depth based upon AC availability. -- -|-__ YAMAMOTO, Taku | __ < - A chicken is an egg's way of producing more eggs. - From owner-freebsd-acpi@FreeBSD.ORG Sun Jul 8 10:22:58 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3B55B106566B; Sun, 8 Jul 2012 10:22:58 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 04F198FC19; Sun, 8 Jul 2012 10:22:53 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id NAA22884; Sun, 08 Jul 2012 13:22:52 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Snodg-000Gt5-2H; Sun, 08 Jul 2012 13:22:52 +0300 Message-ID: <4FF95F79.30309@FreeBSD.org> Date: Sun, 08 Jul 2012 13:22:49 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120620 Thunderbird/13.0.1 MIME-Version: 1.0 To: "freebsd-acpi@freebsd.org" X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=X-VIET-VPS Content-Transfer-Encoding: 7bit Cc: Vitaly Magerya , John Baldwin , Giovanni Trematerra Subject: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2012 10:22:58 -0000 I would like to propose the following change for review and testing: http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff The idea is to separate effective cx_lowest (the limit that the idling code should not currently exceed) from user-set cx_lowest limit/target. Specifically, this addresses dynamic C-state changes by ACPI platform. Currently if a user sets cx_lowest to, say, C3, then available C-states change so that C2 is the deepest available C-state and cx_lowest gets overridden to C2 and all memory of C3 setting is lost. Also, there is a problem with asynchronous nature of userland notification about power profile change and kernel notifications of _CST changes for each CPU in SMP system. That required work-arounds like one in r209213 which also introduced quite a bit of confusion about how per-CPU cpu_cx_lowest, global cpu_cx_lowest and dynamic C-state changes interact with each other. To this day I can not unwind the complete logic behind the following lines: if (sc->cpu_cx_lowest < cpu_cx_lowest) acpi_cpu_set_cx_lowest(sc, min(cpu_cx_lowest, sc->cpu_cx_count - 1)); So to avoid the problems described above I decided to split the cx_lowest limit into the persistent user-set limit, cpu_cx_lowest_lim, and dynamic effective limit. The logic to set cpu_cx_lowest based on cpu_cx_lowest_lim and cpu_cx_count is moved to acpi_cpu_set_cx_lowest(). Note that per-CPU cpu_cx_lowest_lim does not "interact" with global cpu_cx_lowest_lim. Whichever is set later (via sysctl) just overrides the other. With such a change it no longer makes sense to limit allowed cx_lowest sysctl values to currently available C-state levels. Indeed, if a user knows that his system may provide C6 under some circumstance, but currently only C1 is available, then there is no reason to disallow setting cx_lowest sysctl (cpu_cx_lowest_lim) to C6. So values up to MAX_CX_STATES are allowed. After this change cpu_cx_count _global_ variable became unused (write-only) and was removed. Additionally, I introduced magic value of "Cmax" for cx_lowest sysctls to mean that there should not be any limit on C-state depth. The change is partially based on submission from Vitaly: http://article.gmane.org/gmane.os.freebsd.devel.acpi/6892 -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Sun Jul 8 10:25:09 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3F3A41065673; Sun, 8 Jul 2012 10:25:09 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id D60C78FC12; Sun, 8 Jul 2012 10:25:07 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id NAA22900; Sun, 08 Jul 2012 13:25:06 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Snofq-000GtH-AD; Sun, 08 Jul 2012 13:25:06 +0300 Message-ID: <4FF96001.5050806@FreeBSD.org> Date: Sun, 08 Jul 2012 13:25:05 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120620 Thunderbird/13.0.1 MIME-Version: 1.0 To: "freebsd-acpi@freebsd.org" References: <4FF95F79.30309@FreeBSD.org> In-Reply-To: <4FF95F79.30309@FreeBSD.org> X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=x-viet-vps Content-Transfer-Encoding: 7bit Cc: Sean Bruno , Giovanni Trematerra , John Baldwin Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2012 10:25:09 -0000 on 08/07/2012 13:22 Andriy Gapon said the following: > The change is partially based on submission from Vitaly: > http://article.gmane.org/gmane.os.freebsd.devel.acpi/6892 Actually, Sean had a similar idea too with respect to cx_lowest valid values. -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Sun Jul 8 10:28:39 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EF50F106564A for ; Sun, 8 Jul 2012 10:28:38 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 490A68FC0C for ; Sun, 8 Jul 2012 10:28:38 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id NAA22912; Sun, 08 Jul 2012 13:28:29 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Snoj7-000GtX-Eu; Sun, 08 Jul 2012 13:28:29 +0300 Message-ID: <4FF960CC.1080909@FreeBSD.org> Date: Sun, 08 Jul 2012 13:28:28 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120620 Thunderbird/13.0.1 MIME-Version: 1.0 To: Taku YAMAMOTO References: <4FF94EC4.1060109@FreeBSD.org> <20120708191937.46148f65.taku@tackymt.homeip.net> In-Reply-To: <20120708191937.46148f65.taku@tackymt.homeip.net> X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "freebsd-acpi@freebsd.org" Subject: Re: disabled CST_CNT write X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2012 10:28:39 -0000 on 08/07/2012 13:19 Taku YAMAMOTO said the following: > On Sun, 08 Jul 2012 12:11:32 +0300 > Andriy Gapon wrote: > >> >> acpi_cpu.c has a block of code to write CST_CNT to SMI_CMD, but the block is >> under #ifdef notyet. It seems that the code was added that many years ago and >> never enabled. >> Now, judging from the reports I've seen on this mailing list, it appears that >> _CST changes do happen and the driver seem to handle them sufficiently well. >> I think that a lot of modern platforms do not even provide CST_CNT and assume >> that an OS is able to handle C-state change notifications. >> So, I guess that it should be safe to enable the code in question now. >> >> Could anyone with a FreeBSD laptop and non-zero CST_CNT in FADT please test this? > > My Thinkpad X60 (Core 2 Duo) is such one of them. > Enabling that code makes this laptop correctly raise _CST change > notification on AC status change without a single problem. > Without enabling that, this laptop never generates such notifications. > > In fact, I have been enabling that code locally for more than a couple of > years without a problem :) > > In addition, that does not interfere with jkim's acpi_cx_native2.diff; > I've been enjoying MWAIT C3 with varying sleep depth based upon AC availability. > Thank you very much for the information! I will commit this change. -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Sun Jul 8 10:39:23 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 043B81065672 for ; Sun, 8 Jul 2012 10:39:23 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 52BD68FC08 for ; Sun, 8 Jul 2012 10:39:22 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id NAA22949 for ; Sun, 08 Jul 2012 13:39:21 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Snotc-000GuB-OV for freebsd-acpi@FreeBSD.org; Sun, 08 Jul 2012 13:39:20 +0300 Message-ID: <4FF96357.1030601@FreeBSD.org> Date: Sun, 08 Jul 2012 13:39:19 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120620 Thunderbird/13.0.1 MIME-Version: 1.0 To: "freebsd-acpi@freebsd.org" X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=X-VIET-VPS Content-Transfer-Encoding: 7bit Cc: Subject: safe acpi_cpu_idle disabling X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2012 10:39:23 -0000 I would like to propose the following patch for your review: http://people.freebsd.org/~avg/acpi_cpu_disable_idle.diff The main purpose of this change is to provide safe interaction between acpi_cpu_idle and dynamic C-state changes by disabling acpi_cpu_idle while C-state data is updated. If my understanding is correct, currently there is no mutual protection between acpi_cpu_idle code and acpi_cpu_cx_cst. The code more or less works by never cleaning up old C-state data, so it is still accessible while the two functions have incoherent views. There still could be problems when acpi_cpu_idle expects C-state data at certain index to belong to one type while acpi_cpu_cx_cst changes it to a different type. P.S. I think that cpu_disable_idle should be made per-CPU (go to acpi_cpu softc). -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Sun Jul 8 11:58:09 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E26C9106564A; Sun, 8 Jul 2012 11:58:08 +0000 (UTC) (envelope-from dan@obluda.cz) Received: from kgw.obluda.cz (kgw.obluda.cz [193.179.199.50]) by mx1.freebsd.org (Postfix) with ESMTP id 48E828FC18; Sun, 8 Jul 2012 11:58:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by localhost (8.14.5/8.14.5) with ESMTP id q68BseAD002032; Sun, 8 Jul 2012 13:54:40 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by localhost (8.14.5/8.14.5/Submit) id q68BseNo002031; Sun, 8 Jul 2012 13:54:40 +0200 (CEST) (envelope-from dan@obluda.cz) Date: Sun, 8 Jul 2012 13:54:40 +0200 (CEST) Message-Id: <201207081154.q68BseNo002031@nb.obluda.cz> To: FreeBSD-gnats-submit@freebsd.org From: Dan Lukes X-send-pr-version: 3.113 X-GNATS-Notify: Cc: freebsd-acpi@freebsd.org, Hans-Joerg_Hoexer@genua.de Subject: [ patch ] improper handling of ACPI TCPA table, acpidump abend imminent X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dan Lukes List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2012 11:58:09 -0000 >Submitter-Id: current-users >Originator: Dan Lukes >Organization: Obludarium >Confidential: no >Synopsis: [ patch ] improper handling of ACPI TCPA table, acpidump abend imminent >Severity: serious >Priority: medium >Category: bin >Class: sw-bug >Release: FreeBSD 9.0 i386 >Environment: System: FreeBSD 9.0 src/usr.sbin/acpi/acpidump/acpi.c,v 1.42.2.1.2.1 but apply for all revisions past 1.38 (e.g. all RELENG_9 and HEAD) >Description: TCG ACPI (TPCA) support added as SVN rev 211196 1. event->event_type and event->event_size are big-endian (see TPCA PC Specific Specification, paragraph 7.2.2.2). Current code use them directly. It cause misinterpretation of values and may cause abend. 2. 'if (vaddr + event->event_size >= vend )' test is insufficient because: 2a) event->event_size is declared signed and may be negative (especialy when big-endian value used without proper conversion) 2b) vaddr+event->event_size may overflow / wrap around even in the case the event_size is positive in both cases, memory outside of range may be referenced. Abend is imminent. >How-To-Repeat: Dump non-empty TCPA table. It will print events incorrectly, may abend. >Fix: 1. use ntohl() to convert event->event_size and event->event_type before use 2. test vaddr + eventdatasize for wraparound/underflow case also --- usr.sbin/acpi/acpidump/acpi.c.old 2012-07-08 13:14:21.000000000 +0200 +++ usr.sbin/acpi/acpidump/acpi.c 2012-07-08 13:06:46.000000000 +0200 @@ -40,6 +40,7 @@ #include #include #include +#include #include "acpidump.h" @@ -538,10 +539,15 @@ { struct TCPApc_event *pc_event; char *eventname = NULL; + unsigned int eventid, eventdatasize; + + // EventID and EventDataSize are big endian (TPCA PC Specific Specification [7.2.2.2]) + eventid = ntohl(event->event_type); + eventdatasize = ntohl(event->event_size); pc_event = (struct TCPApc_event *)(event + 1); - switch(event->event_type) { + switch(eventid) { case PREBOOT: case POST_CODE: case UNUSED: @@ -559,12 +565,12 @@ case NONHOST_CONFIG: case NONHOST_INFO: asprintf(&eventname, "%s", - tcpa_event_type_strings[event->event_type]); + tcpa_event_type_strings[eventid]); break; case ACTION: - eventname = calloc(event->event_size + 1, sizeof(char)); - memcpy(eventname, pc_event, event->event_size); + eventname = calloc(eventdatasize + 1, sizeof(char)); + memcpy(eventname, pc_event, eventdatasize); break; case EVENT_TAG: @@ -593,7 +599,7 @@ break; default: - asprintf(&eventname, "", event->event_type); + asprintf(&eventname, "", eventid); break; } @@ -659,20 +665,27 @@ vend = vaddr + len; while (vaddr != NULL) { + unsigned int eventid, eventdatasize; + if (vaddr + sizeof(struct TCPAevent) >= vend) break; event = (struct TCPAevent *)(void *)vaddr; - if (vaddr + event->event_size >= vend) + // EventID and EventDataSize are big endian (TPCA PC Specific Specification [7.2.2.2]) + eventid = ntohl(event->event_type); + eventdatasize = ntohl(event->event_size); + if (vaddr + eventdatasize >= vend ) + break; + if (vaddr + eventdatasize < vaddr ) break; - if (event->event_type == 0 && event->event_size == 0) + if (eventid == 0 && eventdatasize == 0) break; #if 0 { unsigned int i, j, k; - printf("\n\tsize %d\n\t\t%p ", event->event_size, vaddr); + printf("\n\tsize %u\n\t\t%p ", eventdatasize, vaddr); for (j = 0, i = 0; i < - sizeof(struct TCPAevent) + event->event_size; i++) { + sizeof(struct TCPAevent) + eventdatasize; i++) { printf("%02x ", vaddr[i]); if ((i+1) % 8 == 0) { for (k = 0; k < 8; k++) @@ -686,7 +699,7 @@ #endif acpi_print_tcpa(event); - vaddr += sizeof(struct TCPAevent) + event->event_size; + vaddr += sizeof(struct TCPAevent) + eventdatasize; } printf(END_COMMENT); --- patch ends here --- From owner-freebsd-acpi@FreeBSD.ORG Sun Jul 8 10:11:29 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 011D6106566B for ; Sun, 8 Jul 2012 10:11:29 +0000 (UTC) (envelope-from honestqiao@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id C3E6D8FC0A for ; Sun, 8 Jul 2012 10:11:28 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so18689821pbb.13 for ; Sun, 08 Jul 2012 03:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:references:x-priority:x-has-attach:x-mailer :mime-version:message-id:content-type:content-transfer-encoding; bh=D5eaEY0kFeO51V2ExvmyIoBGVIdlk/oYKQ8HsxLhjb0=; b=TS4BpJl4x5OZBqDSk7KhN6CMwjehv1Sk8cOXPczpd9LjacFysZRJsElEWRmQaATYSv ImKftOopH6mqr43q9zHPLJaPCOcv6Za0oo6qbTilr3phPf5giau6w1e4DAu6MJ8gu7+M O1TNd0ltP6Ur42wXBXBmMszAUMSpQAmxjdY9L+iTj0rgRulvxOVRxSQJ/WCbAqRynZyV yPzHAGohQjjmDI9nRBt4sFKdJsco4LxhVcGs+oxnx9YqdX5o4B0QgZOEKKjpidqQzDaV 6Z3inT5whEujc4ZCmbDcX1ixluU2VtuLHwaqktzZhHSOyHi5T9YBtUx2cO0S1mPuRTfc ajHQ== Received: by 10.68.224.70 with SMTP id ra6mr50429343pbc.11.1341742288591; Sun, 08 Jul 2012 03:11:28 -0700 (PDT) Received: from HonestQiaoNB ([216.218.222.22]) by mx.google.com with ESMTPS id nh8sm25471218pbc.60.2012.07.08.03.11.24 (version=SSLv3 cipher=OTHER); Sun, 08 Jul 2012 03:11:27 -0700 (PDT) Date: Sun, 8 Jul 2012 18:11:20 +0800 From: =?gb2312?B?x8ez/i9Ib25lc3RRaWFv?= To: "Brandon Gooch" , mbsd References: <201207021729413382845@gmail.com> <4FF2599B.6050409@gmail.com> <201207031411248300207@gmail.com> <1341437029.4017.5.camel@localhost>, X-Priority: 3 X-Has-Attach: no X-Mailer: Foxmail 7.0.1.91[cn] Mime-Version: 1.0 Message-ID: <2012070818111721097510@gmail.com> Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 X-Mailman-Approved-At: Sun, 08 Jul 2012 12:40:06 +0000 Cc: freebsd-acpi Subject: Re: Re: Resume failed after Suspend on Thinkpad x201i X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2012 10:11:29 -0000 Pk9uIFdlZCwgSnVsIDQsIDIwMTIgYXQgNDoyMyBQTSwgbWJzZCA8bWJzZEBpc2dyb3VwLmNvbS51 YT4gd3JvdGU6DQo+PiBPbiBUdWUsIDIwMTItMDctMDMgYXQgMTQ6MTEgKzA4MDAsIMfHs/4vSG9u ZXN0UWlhbyB3cm90ZToNCj5bU05JUF0NCj4+Pg0KPj4+IEluIEFsbCB0aGUgdGVzdCwgdGhlIHNj cmVlbiBpcyBsaWdodCBhbmQgYmxhY2ssIHN5c3RlbSBpcyBoYW5ndXAsIG5vdGhpbmcgY2FuIGJl IGRvbmUuDQo+Pj4gVGhlIG9ubHkgdGhpbmcgY2FuIGJlIGRvbmUsIGlzIHB1c2ggcG93ZXIgYnV0 dG9uLCB0byBmb3JjZSBpdCBzaHV0ZG93bi4NCj4+DQo+PiBXaGljaCBncmFwaGljIGNhcmQgaGF2 ZSB5b3UgdXNlZD8gSWYgeW91IGhhdmUgaGFkIG52aWRpYSwgaXQncyBub3JtYWwsDQo+PiBJJ3Zl IGhhZCB0aGUgc2FtZSBwcm9ibGVtICJ0aGUgc2NyZWVuIGlzIGxpZ2h0IGFuZCBibGFjayIuDQo+ DQo+Q2FuIGJvdGggb2YgeW91IHNob3cgdGhlIG91dHB1dCBvZiBgZGV2aW5mbyAtdmAgZnJvbSB5 b3VyIHN5c3RlbXM/DQo+DQo+SSB3YXMgYWJsZSB0byBzb2x2ZSBteSBzdXNwZW5kL3Jlc3VtZSBp c3N1ZSB3aXRoIG15IG52aWRpYS1lcXVpcHBlZA0KPm5vdGVib29rIGJ5IGZvcmNpbmcgdGhlIG1v ZHVsZSBsb2FkIG9yZGVyaW5nIG9mIHZnYXBtIGluDQo+c3lzL2lzYS92Z2FfaXNhLmM6DQo+DQo+ SW5kZXg6IHN5cy9pc2EvdmdhX2lzYS5jDQo+PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KPi0tLSBzeXMvaXNhL3ZnYV9p c2EuYyAgIChyZXZpc2lvbiAyMzc3NzkpDQo+KysrIHN5cy9pc2EvdmdhX2lzYS5jICAgKHdvcmtp bmcgY29weSkNCj5AQCAtMzc5LDQgKzM3OSw0IEBADQo+ICAgICAgICAwDQo+IH07DQo+DQo+LURS SVZFUl9NT0RVTEUodmdhcG0sIHZnYXBjaSwgdmdhcG1fZHJpdmVyLCB2Z2FwbV9kZXZjbGFzcywg MCwgMCk7DQo+K0RSSVZFUl9NT0RVTEUodmdhcG0sIHZnYXBjaSwgdmdhcG1fZHJpdmVyLCB2Z2Fw bV9kZXZjbGFzcywgMCwgU0lfT1JERVJfQU5ZKTsNCj4NCj4NCj5UaGUgc3lzdGVtIHJlcXVpcmVz IGhvd2V2ZXIgdGhhdCBJIGxvYWQgdGhlIG52aWRpYSBtb2R1bGUgaW4NCj4vYm9vdC9sb2FkZXIu Y29uZiAoYXMgb3Bwb3NlZCB0byBsb2FkaW5nIGl0IGFmdGVyIHN5c3RlbSBpcyB1cCBhbmQNCj5y dW5uaW5nKS4NCj4NCj4tQnJhbmRvbg0KDQpkZXZpbmZvIC12IDogaHR0cDovL3Bhc3RlYmluLmNv bS9CRkJIdDNTcg0KZG1pZGVjb2RlOiBodHRwOi8vcGFzdGViaW4uY29tL2RXVmJlN3Q0DQoNCk15 IHgyMDFpOg0KTW9kZWw6IDMyNDlBNjQNCkNQVTogSW50ZWwoUikgQ29yZShUTSkgaTMgQ1BVICAg ICAgIE0gMzgwICBAIDIuNTNHSHoNCk1haW5Cb2FyZDogSW50ZWwgUU01Ny4NCkdyYXBoaWNzIGNh cmQgIGlzIEludGVsIEdNQSBIRChpbnRlZ3JhdGlvbikuDQoNCi9ldGMvbWFrZS5jb25mDQouLi4u Li4NCiNLTVMNCldJVEhfTkVXX1hPUkc9IllFUyINCldJVEhfS01TPSJZRVMiDQouLi4uLi4NCg0K TXkga2VybmVsIGJ1aWxkIHdpdGgga21zLCB3aGljaCBjYW4gc3VwcG9ydCB0aGUgSW50ZWwgR01B IEhEIGdyYXBoaWNzIGNhcmQuDQpNeSBndWkgaXMgdXNlZCBLREUgNC44LiBFdmVyeXRoaW5nIHJ1 bnMgb2ssIGV4Y2VwdCBzdXNwZW5kL3Jlc3VtZS4NCg0KVGhlIGxhdGVzdCBzaXR1YXRpb246DQpX aGVuIEkgY2xvc2UgIExDRKOseDIwMWkgd2lsbCBiZWNvbWUgdG8gU2xlZXAgc3RhdHVzLg0KU2xl ZXAgTEVEIGlzIGxpZ2h0LCBMQ0QgaXMgY2xvc2UuDQpCdXQsIG5vIGJ1dHRvbiBjYW4gcmVzdW1l IGl0Lg0K From owner-freebsd-acpi@FreeBSD.ORG Sun Jul 8 16:56:33 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A9FF7106568D; Sun, 8 Jul 2012 16:56:33 +0000 (UTC) (envelope-from nate@root.org) Received: from mail.rootlabs.com (rootlabs.com [208.72.84.106]) by mx1.freebsd.org (Postfix) with ESMTP id 848588FC08; Sun, 8 Jul 2012 16:56:33 +0000 (UTC) Received: from [192.168.1.100] (unknown [50.13.187.44]) by mail.rootlabs.com (Postfix) with ESMTPSA id 892C5EE23; Sun, 8 Jul 2012 16:50:21 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=iso-8859-1 From: Nate Lawson In-Reply-To: <4FF94EC4.1060109@FreeBSD.org> Date: Sun, 8 Jul 2012 09:49:57 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <023CA42F-C5FD-4F67-AD70-84DE68B3FBA8@root.org> References: <4FF94EC4.1060109@FreeBSD.org> To: Andriy Gapon X-Mailer: Apple Mail (2.1278) Cc: "freebsd-acpi@freebsd.org" Subject: Re: disabled CST_CNT write X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2012 16:56:33 -0000 On Jul 8, 2012, at 2:11 AM, Andriy Gapon wrote: > acpi_cpu.c has a block of code to write CST_CNT to SMI_CMD, but the = block is > under #ifdef notyet. It seems that the code was added that many years = ago and > never enabled. > Now, judging from the reports I've seen on this mailing list, it = appears that > _CST changes do happen and the driver seem to handle them sufficiently = well. > I think that a lot of modern platforms do not even provide CST_CNT and = assume > that an OS is able to handle C-state change notifications. > So, I guess that it should be safe to enable the code in question now. >=20 > Could anyone with a FreeBSD laptop and non-zero CST_CNT in FADT please = test this? It was only under an #ifdef because at the time our CST implementation = couldn't handle CST changes cleanly. I had added some support for it, = but since it couldn't be tested, I wasn't sure how actual hardware would = behave. I think it's fine to enable now. I think 2007-era Thinkpads were some of = the first to add this feature. -Nate From owner-freebsd-acpi@FreeBSD.ORG Sun Jul 8 23:01:09 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E6DFB106566B for ; Sun, 8 Jul 2012 23:01:09 +0000 (UTC) (envelope-from jamesbrandongooch@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id A93FE8FC0A for ; Sun, 8 Jul 2012 23:01:09 +0000 (UTC) Received: by obbun3 with SMTP id un3so23504473obb.13 for ; Sun, 08 Jul 2012 16:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=revkr+NJpi+i/cX/mAbCUSrQ5kZNLObmjBvUGpJsygg=; b=CPiCTU3EaOO0XR1MF0PfrUYoOM67oZUlG1n3NVwC4/5/UXA8ms8jPPnNnhhV6UnMBI +vxqt6IH8lU4f9nViph0LqkMCproAslSU4MufZfaIFV/pqV0/IMR0lBMUsEaXcyLxZEW 0ACTg+b3BInE3UmuPrO4e/hRoDN6WQxwDpTEa9QYGK/Qg3l8ciwINZZNId9ihJmvx3SU odQ7hWdpg1kumyV5NIx74+mX3mG2eEdXQTGQjni3vdzYUy/2DzeywPZJ2EhBkBt0xFq7 OwPT4xYf591e8JCAmFzhAzFMNJwjKBM+cA5C4gxKvW9nT35J/UqOpW2nZZ/vzsU57MAd otDQ== MIME-Version: 1.0 Received: by 10.60.6.73 with SMTP id y9mr39304214oey.17.1341788469300; Sun, 08 Jul 2012 16:01:09 -0700 (PDT) Received: by 10.60.61.38 with HTTP; Sun, 8 Jul 2012 16:01:09 -0700 (PDT) In-Reply-To: References: <201207021729413382845@gmail.com> <4FF2599B.6050409@gmail.com> <201207031411248300207@gmail.com> <1341437029.4017.5.camel@localhost> Date: Sun, 8 Jul 2012 18:01:09 -0500 Message-ID: From: Brandon Gooch To: mbsd , honestqiao@gmail.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-acpi@freebsd.org Subject: Re: Re: Resume failed after Suspend on Thinkpad x201i X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2012 23:01:10 -0000 On Sat, Jul 7, 2012 at 10:40 AM, Brandon Gooch wrote: > On Wed, Jul 4, 2012 at 4:23 PM, mbsd wrote: >> On Tue, 2012-07-03 at 14:11 +0800, =E4=B9=94=E6=A5=9A/HonestQiao wrote: > [SNIP] >>> >>> In All the test, the screen is light and black, system is hangup, nothi= ng can be done. >>> The only thing can be done, is push power button, to force it shutdown. >> >> Which graphic card have you used? If you have had nvidia, it's normal, >> I've had the same problem "the screen is light and black". > > Can both of you show the output of `devinfo -v` from your systems? > > I was able to solve my suspend/resume issue with my nvidia-equipped > notebook by forcing the module load ordering of vgapm in > sys/isa/vga_isa.c: > > Index: sys/isa/vga_isa.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/isa/vga_isa.c (revision 237779) > +++ sys/isa/vga_isa.c (working copy) > @@ -379,4 +379,4 @@ > 0 > }; > > -DRIVER_MODULE(vgapm, vgapci, vgapm_driver, vgapm_devclass, 0, 0); > +DRIVER_MODULE(vgapm, vgapci, vgapm_driver, vgapm_devclass, 0, SI_ORDER_A= NY); > > > The system requires however that I load the nvidia module in > /boot/loader.conf (as opposed to loading it after system is up and > running). > > -Brandon Oops, the patch above should instead be: Index: sys/isa/vga_isa.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/isa/vga_isa.c (revision 238266) +++ sys/isa/vga_isa.c (working copy) @@ -379,4 +379,4 @@ 0 }; -DRIVER_MODULE(vgapm, vgapci, vgapm_driver, vgapm_devclass, 0, 0); +DRIVER_MODULE_ORDERED(vgapm, vgapci, vgapm_driver, vgapm_devclass, NULL, NULL, SI_ORDER_ANY); I made the edit for the diff on a clean tree, but I'm actually building from another :) The above is correct. However, I'm still not sure this pertains to your Intel video problem. -Brandon From owner-freebsd-acpi@FreeBSD.ORG Mon Jul 9 11:07:03 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7FED01065674 for ; Mon, 9 Jul 2012 11:07:03 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 44D438FC1C for ; Mon, 9 Jul 2012 11:07:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q69B73t0075327 for ; Mon, 9 Jul 2012 11:07:03 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q69B72fs075325 for freebsd-acpi@FreeBSD.org; Mon, 9 Jul 2012 11:07:02 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 9 Jul 2012 11:07:02 GMT Message-Id: <201207091107.q69B72fs075325@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-acpi@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-acpi@FreeBSD.org X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 11:07:03 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/164329 acpi [acpi] hw.acpi.thermal.tz0.temperature shows strange v o kern/163268 acpi [acpi_hp] fix driver detach in absence of CMI o kern/162859 acpi [acpi] ACPI battery/acline monitoring partialy working o kern/161715 acpi [acpi] Dell E6520 doesn't resume after ACPI suspend o kern/161713 acpi [acpi] Suspend on Dell E6520 o kern/160838 acpi [acpi] ACPI Battery Monitor Non-Functional o kern/160419 acpi [acpi_thermal] acpi_thermal kernel thread high CPU usa o kern/158689 acpi [acpi] value of sysctl hw.acpi.thermal.polling_rate ne o kern/154955 acpi [acpi] Keyboard or ACPI doesn't work on Lenovo S10-3 o kern/152438 acpi [acpi]: patch to acpi_asus(4) to add extra sysctls for o kern/152098 acpi [acpi] Lenovo T61p does not resume o i386/146715 acpi [acpi] Suspend works, resume not on a HP Probook 4510s o kern/145306 acpi [acpi]: Can't change brightness on HP ProBook 4510s o i386/143798 acpi [acpi] shutdown problem with SiS K7S5A o kern/143420 acpi [acpi] ACPI issues with Toshiba o kern/142009 acpi [acpi] [panic] Panic in AcpiNsGetAttachedObject o kern/139088 acpi [acpi] ACPI Exception: AE_AML_INFINITE_LOOP error o amd64/138210 acpi [acpi] acer aspire 5536 ACPI problems (S3, brightness, o kern/137042 acpi [acpi] hp laptop's lcd not wakes up after suspend to r o i386/136008 acpi [acpi] Dell Vostro 1310 will not shutdown (Requires us o bin/135349 acpi [patch] teach acpidump(8) to disassemble arbitrary mem o kern/132602 acpi [acpi] ACPI Problem with Intel SS4200: System does not p kern/128634 acpi [patch] fix acpi_asus(4) in asus a6f laptop o bin/126162 acpi [acpi] ACPI autoload failed : loading required module o kern/123039 acpi [acpi] ACPI AML_BUFFER_LIMIT errors during boot a i386/122887 acpi [panic] [atkbdc] 7.0-RELEASE on IBM HS20 panics immed s kern/112544 acpi [acpi] [patch] Add High Precision Event Timer Driver f o kern/105537 acpi [acpi] problems in acpi on HP Compaq nc6320 o kern/91594 acpi [acpi] FreeBSD > 5.4 w/ACPI fails to detect Intel Pro/ o kern/73823 acpi [request] acpi / power-on by timer support o kern/56024 acpi ACPI suspend drains battery while in S3 31 problems total. From owner-freebsd-acpi@FreeBSD.ORG Mon Jul 9 15:06:17 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F20371065672; Mon, 9 Jul 2012 15:06:16 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id C56308FC0A; Mon, 9 Jul 2012 15:06:16 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 2E253B972; Mon, 9 Jul 2012 11:06:16 -0400 (EDT) From: John Baldwin To: freebsd-acpi@freebsd.org Date: Mon, 9 Jul 2012 08:34:44 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; ) References: <4FF95F79.30309@FreeBSD.org> In-Reply-To: <4FF95F79.30309@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201207090834.44758.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 09 Jul 2012 11:06:16 -0400 (EDT) Cc: Vitaly Magerya , Andriy Gapon , Giovanni Trematerra Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 15:06:17 -0000 On Sunday, July 08, 2012 6:22:49 am Andriy Gapon wrote: > > I would like to propose the following change for review and testing: > http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff > > The idea is to separate effective cx_lowest (the limit that the idling code > should not currently exceed) from user-set cx_lowest limit/target. > Specifically, this addresses dynamic C-state changes by ACPI platform. > Currently if a user sets cx_lowest to, say, C3, then available C-states change > so that C2 is the deepest available C-state and cx_lowest gets overridden to C2 > and all memory of C3 setting is lost. > Also, there is a problem with asynchronous nature of userland notification about > power profile change and kernel notifications of _CST changes for each CPU in > SMP system. That required work-arounds like one in r209213 which also > introduced quite a bit of confusion about how per-CPU cpu_cx_lowest, global > cpu_cx_lowest and dynamic C-state changes interact with each other. > To this day I can not unwind the complete logic behind the following lines: > if (sc->cpu_cx_lowest < cpu_cx_lowest) > acpi_cpu_set_cx_lowest(sc, min(cpu_cx_lowest, sc->cpu_cx_count - 1)); > > So to avoid the problems described above I decided to split the cx_lowest limit > into the persistent user-set limit, cpu_cx_lowest_lim, and dynamic effective limit. > The logic to set cpu_cx_lowest based on cpu_cx_lowest_lim and cpu_cx_count is > moved to acpi_cpu_set_cx_lowest(). > > Note that per-CPU cpu_cx_lowest_lim does not "interact" with global > cpu_cx_lowest_lim. Whichever is set later (via sysctl) just overrides the other. > > With such a change it no longer makes sense to limit allowed cx_lowest sysctl > values to currently available C-state levels. Indeed, if a user knows that his > system may provide C6 under some circumstance, but currently only C1 is > available, then there is no reason to disallow setting cx_lowest sysctl > (cpu_cx_lowest_lim) to C6. So values up to MAX_CX_STATES are allowed. > After this change cpu_cx_count _global_ variable became unused (write-only) and > was removed. > > Additionally, I introduced magic value of "Cmax" for cx_lowest sysctls to mean > that there should not be any limit on C-state depth. I like this change. -- John Baldwin From owner-freebsd-acpi@FreeBSD.ORG Mon Jul 9 15:06:17 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD0F8106564A; Mon, 9 Jul 2012 15:06:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 838FB8FC16; Mon, 9 Jul 2012 15:06:17 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id E6508B98B; Mon, 9 Jul 2012 11:06:16 -0400 (EDT) From: John Baldwin To: freebsd-acpi@freebsd.org Date: Mon, 9 Jul 2012 08:38:05 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; ) References: <4FF96357.1030601@FreeBSD.org> In-Reply-To: <4FF96357.1030601@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201207090838.05245.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 09 Jul 2012 11:06:17 -0400 (EDT) Cc: Andriy Gapon Subject: Re: safe acpi_cpu_idle disabling X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 15:06:17 -0000 On Sunday, July 08, 2012 6:39:19 am Andriy Gapon wrote: > > I would like to propose the following patch for your review: > http://people.freebsd.org/~avg/acpi_cpu_disable_idle.diff > > The main purpose of this change is to provide safe interaction between > acpi_cpu_idle and dynamic C-state changes by disabling acpi_cpu_idle while > C-state data is updated. > > If my understanding is correct, currently there is no mutual protection between > acpi_cpu_idle code and acpi_cpu_cx_cst. The code more or less works by never > cleaning up old C-state data, so it is still accessible while the two functions > have incoherent views. There still could be problems when acpi_cpu_idle expects > C-state data at certain index to belong to one type while acpi_cpu_cx_cst > changes it to a different type. > > P.S. I think that cpu_disable_idle should be made per-CPU (go to acpi_cpu softc). I don't think you need the locking, I think all you need to add is the smp_rendezvous() call. The IPI mechanism has sufficient membar's already, and the smp_rendezvous() function itself will not return to the caller until all the CPUs can see the write to disable idling. -- John Baldwin From owner-freebsd-acpi@FreeBSD.ORG Mon Jul 9 15:06:18 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 283C61065673; Mon, 9 Jul 2012 15:06:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id F1A638FC08; Mon, 9 Jul 2012 15:06:17 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 63F23B99B; Mon, 9 Jul 2012 11:06:17 -0400 (EDT) From: John Baldwin To: freebsd-acpi@freebsd.org, Dan Lukes Date: Mon, 9 Jul 2012 08:45:19 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; ) References: <201207081154.q68BseNo002031@nb.obluda.cz> In-Reply-To: <201207081154.q68BseNo002031@nb.obluda.cz> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201207090845.19091.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 09 Jul 2012 11:06:17 -0400 (EDT) Cc: FreeBSD-gnats-submit@freebsd.org, Hans-Joerg_Hoexer@genua.de Subject: Re: [ patch ] improper handling of ACPI TCPA table, acpidump abend imminent X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 15:06:18 -0000 On Sunday, July 08, 2012 7:54:40 am Dan Lukes wrote: > > >Submitter-Id: current-users > >Originator: Dan Lukes > >Organization: Obludarium > >Confidential: no > >Synopsis: [ patch ] improper handling of ACPI TCPA table, acpidump abend imminent > >Severity: serious > >Priority: medium > >Category: bin > >Class: sw-bug > >Release: FreeBSD 9.0 i386 > >Environment: > System: FreeBSD 9.0 > src/usr.sbin/acpi/acpidump/acpi.c,v 1.42.2.1.2.1 > > but apply for all revisions past 1.38 (e.g. all RELENG_9 and HEAD) > > >Description: > TCG ACPI (TPCA) support added as SVN rev 211196 > > 1. event->event_type and event->event_size are big-endian (see TPCA PC Specific Specification, paragraph 7.2.2.2). Current code use them directly. It cause misinterpretation of values and may cause abend. > > 2. 'if (vaddr + event->event_size >= vend )' test is insufficient because: > > 2a) event->event_size is declared signed and may be negative (especialy when big-endian value used without proper conversion) > 2b) vaddr+event->event_size may overflow / wrap around even in the case the event_size is positive > > in both cases, memory outside of range may be referenced. Abend is imminent. > > >How-To-Repeat: > Dump non-empty TCPA table. It will print events incorrectly, may abend. > > >Fix: > > 1. use ntohl() to convert event->event_size and event->event_type before use > 2. test vaddr + eventdatasize for wraparound/underflow case also It might be best to use betoh() macros from instead of nthol(). -- John Baldwin From owner-freebsd-acpi@FreeBSD.ORG Mon Jul 9 16:06:17 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4F4CC1065674; Mon, 9 Jul 2012 16:06:17 +0000 (UTC) (envelope-from smithi@nimnet.asn.au) Received: from sola.nimnet.asn.au (paqi.nimnet.asn.au [115.70.110.159]) by mx1.freebsd.org (Postfix) with ESMTP id C555C8FC08; Mon, 9 Jul 2012 16:06:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by sola.nimnet.asn.au (8.14.2/8.14.2) with ESMTP id q69G67i1092576; Tue, 10 Jul 2012 02:06:08 +1000 (EST) (envelope-from smithi@nimnet.asn.au) Date: Tue, 10 Jul 2012 02:06:07 +1000 (EST) From: Ian Smith To: Nate Lawson In-Reply-To: <023CA42F-C5FD-4F67-AD70-84DE68B3FBA8@root.org> Message-ID: <20120710014934.J42038@sola.nimnet.asn.au> References: <4FF94EC4.1060109@FreeBSD.org> <023CA42F-C5FD-4F67-AD70-84DE68B3FBA8@root.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: "freebsd-acpi@freebsd.org" , Andriy Gapon Subject: Re: disabled CST_CNT write X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 16:06:17 -0000 On Sun, 8 Jul 2012 09:49:57 -0700, Nate Lawson wrote: > On Jul 8, 2012, at 2:11 AM, Andriy Gapon wrote: > > > acpi_cpu.c has a block of code to write CST_CNT to SMI_CMD, but the block is > > under #ifdef notyet. It seems that the code was added that many years ago and > > never enabled. > > Now, judging from the reports I've seen on this mailing list, it appears that > > _CST changes do happen and the driver seem to handle them sufficiently well. > > I think that a lot of modern platforms do not even provide CST_CNT and assume > > that an OS is able to handle C-state change notifications. > > So, I guess that it should be safe to enable the code in question now. > > > > Could anyone with a FreeBSD laptop and non-zero CST_CNT in FADT > > please test this? This Thinkpad T23 with latest (Oct2006) BIOS & EC shows no FADT .. but FACP has CST_CNT=0xf4. Is that relevant at all? > It was only under an #ifdef because at the time our CST > implementation couldn't handle CST changes cleanly. I had added some > support for it, but since it couldn't be tested, I wasn't sure how > actual hardware would behave. > > I think it's fine to enable now. I think 2007-era Thinkpads were some > of the first to add this feature. T43? Maybe it's time I upgraded :) cheers, Ian From owner-freebsd-acpi@FreeBSD.ORG Mon Jul 9 19:02:44 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BAA5B106566B; Mon, 9 Jul 2012 19:02:44 +0000 (UTC) (envelope-from robert.moore@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx1.freebsd.org (Postfix) with ESMTP id 9062B8FC12; Mon, 9 Jul 2012 19:02:44 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 09 Jul 2012 12:01:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="175167547" Received: from orsmsx603.amr.corp.intel.com ([10.22.226.49]) by fmsmga001.fm.intel.com with ESMTP; 09 Jul 2012 12:01:35 -0700 Received: from orsmsx104.amr.corp.intel.com (10.22.225.131) by orsmsx603.amr.corp.intel.com (10.22.226.49) with Microsoft SMTP Server (TLS) id 8.2.255.0; Mon, 9 Jul 2012 12:01:35 -0700 Received: from orsmsx101.amr.corp.intel.com ([169.254.8.125]) by ORSMSX104.amr.corp.intel.com ([169.254.3.118]) with mapi id 14.01.0355.002; Mon, 9 Jul 2012 12:01:35 -0700 From: "Moore, Robert" To: Ian Smith , Nate Lawson Thread-Topic: disabled CST_CNT write Thread-Index: AQHNXOm4Gnse3k84fEq/PZ8XFH+/dZcgDu6AgAGGFoD//7t88A== Date: Mon, 9 Jul 2012 19:01:34 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E346B0A852@ORSMSX101.amr.corp.intel.com> References: <4FF94EC4.1060109@FreeBSD.org> <023CA42F-C5FD-4F67-AD70-84DE68B3FBA8@root.org> <20120710014934.J42038@sola.nimnet.asn.au> In-Reply-To: <20120710014934.J42038@sola.nimnet.asn.au> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "freebsd-acpi@freebsd.org" , Andriy Gapon Subject: RE: disabled CST_CNT write X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 19:02:44 -0000 > This Thinkpad T23 with latest (Oct2006) BIOS & EC shows no FADT .. but > FACP has CST_CNT=3D0xf4. Is that relevant at all? An oddity of ACPI -- the FADT has the signature "FACP". > -----Original Message----- > From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- > acpi@freebsd.org] On Behalf Of Ian Smith > Sent: Monday, July 09, 2012 9:06 AM > To: Nate Lawson > Cc: freebsd-acpi@freebsd.org; Andriy Gapon > Subject: Re: disabled CST_CNT write >=20 > On Sun, 8 Jul 2012 09:49:57 -0700, Nate Lawson wrote: > > On Jul 8, 2012, at 2:11 AM, Andriy Gapon wrote: > > > > > acpi_cpu.c has a block of code to write CST_CNT to SMI_CMD, but > the block is > > under #ifdef notyet. It seems that the code was > added that many years ago and > > never enabled. > > > Now, judging from the reports I've seen on this mailing list, it > appears that > > _CST changes do happen and the driver seem to handle > them sufficiently well. > > > I think that a lot of modern platforms do not even provide CST_CNT > and assume > > that an OS is able to handle C-state change > notifications. > > > So, I guess that it should be safe to enable the code in question > now. > > > > > > Could anyone with a FreeBSD laptop and non-zero CST_CNT in FADT > > > please test this? >=20 > This Thinkpad T23 with latest (Oct2006) BIOS & EC shows no FADT .. but > FACP has CST_CNT=3D0xf4. Is that relevant at all? >=20 > > It was only under an #ifdef because at the time our CST > > implementation couldn't handle CST changes cleanly. I had added some > > support for it, but since it couldn't be tested, I wasn't sure how > > actual hardware would behave. > > > > I think it's fine to enable now. I think 2007-era Thinkpads were > some > of the first to add this feature. >=20 > T43? Maybe it's time I upgraded :) >=20 > cheers, Ian > _______________________________________________ > freebsd-acpi@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-acpi > To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@freebsd.org" From owner-freebsd-acpi@FreeBSD.ORG Mon Jul 9 22:23:57 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7BFF1065670; Mon, 9 Jul 2012 22:23:57 +0000 (UTC) (envelope-from giovanni.trematerra@gmail.com) Received: from mail-qa0-f47.google.com (mail-qa0-f47.google.com [209.85.216.47]) by mx1.freebsd.org (Postfix) with ESMTP id 5956E8FC1E; Mon, 9 Jul 2012 22:23:57 +0000 (UTC) Received: by qabg1 with SMTP id g1so1948545qab.13 for ; Mon, 09 Jul 2012 15:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=sWtmVBr+yGooy5iNo+UJPxJ29exoTL/PDNph4mH3tBg=; b=RIb1IJPp7ovSF4ROHT5L7d6nx0z+nEhJoGlh/Dl26fEZM+aEXO4jlSjzDmFokrEMcD D+zEzEk+N5tBBMH0V1XR+srH5qE2nPxNt735orOGfaT8T4cy6AlSHnuJHIMIDxkz0Tbj +pwltRwTnVeJGuCTNmCUqWiJl+mcxksUAVlq+eUXNUngOa3PtUwriZYZjAxPeZk3cmIF EdQvlJNx7iEUD0/CyJCfcD6u0XFn1ROyC4bM5wHOB4c4yPdlejNRGYt8cx7V4FgKGyEm rBc5sfUUOcTD6a272FOaT4ZbKgf12W+Fbg033ZxVRp80hGdXFfNiiXaUQFbBO8l1E9ol QuRA== MIME-Version: 1.0 Received: by 10.229.134.195 with SMTP id k3mr18710107qct.6.1341872636573; Mon, 09 Jul 2012 15:23:56 -0700 (PDT) Sender: giovanni.trematerra@gmail.com Received: by 10.229.59.169 with HTTP; Mon, 9 Jul 2012 15:23:56 -0700 (PDT) In-Reply-To: <4FF95F79.30309@FreeBSD.org> References: <4FF95F79.30309@FreeBSD.org> Date: Tue, 10 Jul 2012 00:23:56 +0200 X-Google-Sender-Auth: KXLM6p4VTmhqVpqvkzIMnJSBz6E Message-ID: From: Giovanni Trematerra To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-acpi@freebsd.org" , Vitaly Magerya Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 22:23:57 -0000 On Sun, Jul 8, 2012 at 12:22 PM, Andriy Gapon wrote: > > I would like to propose the following change for review and testing: > http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff It seems good to me. -- Gianni From owner-freebsd-acpi@FreeBSD.ORG Tue Jul 10 08:46:06 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 638F5106564A for ; Tue, 10 Jul 2012 08:46:06 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id B13048FC18 for ; Tue, 10 Jul 2012 08:46:05 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA16837; Tue, 10 Jul 2012 11:46:01 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1SoW52-000OMQ-JV; Tue, 10 Jul 2012 11:46:00 +0300 Message-ID: <4FFBEBC8.2090309@FreeBSD.org> Date: Tue, 10 Jul 2012 11:46:00 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120620 Thunderbird/13.0.1 MIME-Version: 1.0 To: Nate Lawson References: <4FF94EC4.1060109@FreeBSD.org> <023CA42F-C5FD-4F67-AD70-84DE68B3FBA8@root.org> In-Reply-To: <023CA42F-C5FD-4F67-AD70-84DE68B3FBA8@root.org> X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "freebsd-acpi@freebsd.org" Subject: Re: disabled CST_CNT write X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 08:46:06 -0000 on 08/07/2012 19:49 Nate Lawson said the following: > On Jul 8, 2012, at 2:11 AM, Andriy Gapon wrote: > >> acpi_cpu.c has a block of code to write CST_CNT to SMI_CMD, but the block is >> under #ifdef notyet. It seems that the code was added that many years ago and >> never enabled. >> Now, judging from the reports I've seen on this mailing list, it appears that >> _CST changes do happen and the driver seem to handle them sufficiently well. >> I think that a lot of modern platforms do not even provide CST_CNT and assume >> that an OS is able to handle C-state change notifications. >> So, I guess that it should be safe to enable the code in question now. >> >> Could anyone with a FreeBSD laptop and non-zero CST_CNT in FADT please test this? > > It was only under an #ifdef because at the time our CST implementation couldn't handle CST changes cleanly. I had added some support for it, but since it couldn't be tested, I wasn't sure how actual hardware would behave. > > I think it's fine to enable now. I think 2007-era Thinkpads were some of the first to add this feature. Nate, thank you for the information/explanation. -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Tue Jul 10 14:27:57 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73DE4106564A; Tue, 10 Jul 2012 14:27:57 +0000 (UTC) (envelope-from smithi@nimnet.asn.au) Received: from sola.nimnet.asn.au (paqi.nimnet.asn.au [115.70.110.159]) by mx1.freebsd.org (Postfix) with ESMTP id C297D8FC0A; Tue, 10 Jul 2012 14:27:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by sola.nimnet.asn.au (8.14.2/8.14.2) with ESMTP id q6AERsPI039077; Wed, 11 Jul 2012 00:27:55 +1000 (EST) (envelope-from smithi@nimnet.asn.au) Date: Wed, 11 Jul 2012 00:27:54 +1000 (EST) From: Ian Smith To: Andriy Gapon In-Reply-To: <4FF95F79.30309@FreeBSD.org> Message-ID: <20120711000506.E42038@sola.nimnet.asn.au> References: <4FF95F79.30309@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: "freebsd-acpi@freebsd.org" , Vitaly Magerya , Giovanni Trematerra Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 14:27:57 -0000 On Sun, 8 Jul 2012 13:22:49 +0300, Andriy Gapon wrote: > I would like to propose the following change for review and testing: > http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff > > The idea is to separate effective cx_lowest (the limit that the idling code > should not currently exceed) from user-set cx_lowest limit/target. > Specifically, this addresses dynamic C-state changes by ACPI platform. > Currently if a user sets cx_lowest to, say, C3, then available C-states change > so that C2 is the deepest available C-state and cx_lowest gets overridden to C2 > and all memory of C3 setting is lost. I wonder if that explains why setting C3 on aforesaid T23 has no effect (in terms of dev.cpu.0.cx_usage indicating any time spent in C3) unless the machine happened to be booted up on battery, in which case C3 is shown as working whenever its enabled, by power_profile or manually? Would I be wasting my time or yours trying this on an 8.2-R kernel? Or are there other major changes that probably preclude this? The patch applies cleanly, but the offsets look a bit daunting: smithi on t23% patch < acpi_cpu_cx_lowest.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |diff --git a/sys/dev/acpica/acpi_cpu.c b/sys/dev/acpica/acpi_cpu.c |index e2a3dbf..e7ca14d 100644 |--- a/sys/dev/acpica/acpi_cpu.c |+++ b/sys/dev/acpica/acpi_cpu.c -------------------------- Patching file acpi_cpu.c using Plan A... Hunk #1 succeeded at 86 (offset -3 lines). Hunk #2 succeeded at 132 (offset -7 lines). Hunk #3 succeeded at 170 (offset -3 lines). Hunk #4 succeeded at 548 (offset -42 lines). Hunk #5 succeeded at 792 (offset -29 lines). Hunk #6 succeeded at 787 (offset -42 lines). Hunk #7 succeeded at 812 (offset -29 lines). Hunk #8 succeeded at 817 (offset -42 lines). Hunk #9 succeeded at 1013 (offset -31 lines). Hunk #10 succeeded at 1010 (offset -42 lines). Hunk #11 succeeded at 1150 (offset -31 lines). Hunk #12 succeeded at 1168 (offset -42 lines). Hunk #13 succeeded at 1208 (offset -31 lines). done I hope to get another machine going soon on which I can play with 9-stable, maybe 10, but meanwhile this one is bread and butter .. cheers, Ian From owner-freebsd-acpi@FreeBSD.ORG Tue Jul 10 15:50:02 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3C8C3106566C; Tue, 10 Jul 2012 15:50:02 +0000 (UTC) (envelope-from seanbru@yahoo-inc.com) Received: from mrout1.yahoo.com (mrout1.yahoo.com [216.145.54.171]) by mx1.freebsd.org (Postfix) with ESMTP id 1C85F8FC14; Tue, 10 Jul 2012 15:50:02 +0000 (UTC) Received: from [IPv6:::1] (proxy6.corp.yahoo.com [216.145.48.19]) by mrout1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id q6AFnVoA059233; Tue, 10 Jul 2012 08:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com; s=cobra; t=1341935373; bh=wUM79Fhpp6Cb2iFWrTi/4EMncKZiaSV9ylFDdzp4gF8=; h=Subject:From:Reply-To:To:Cc:In-Reply-To:References:Content-Type: Date:Message-ID:Mime-Version:Content-Transfer-Encoding; b=P1G123nO1BtcrDf7ZBoLZ0iXXHpNEFIrGMjcxPFG5Uoz1WBCEgKhk1gIHjGtRjWOz BeLKA+8zfIMCK6LqEcF0djhVlc6SCcf3QjuUOgazggXPzzv8QqNEOqJkh31EDo1LiE r2mG4cwtS2icWWhCBecEzxCFY0jc5GT6lksT1CWQ= From: Sean Bruno To: Andriy Gapon In-Reply-To: <4FF95F79.30309@FreeBSD.org> References: <4FF95F79.30309@FreeBSD.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 10 Jul 2012 08:49:30 -0700 Message-ID: <1341935370.4493.4.camel@powernoodle> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Milter-Version: master.31+4-gbc07cd5+ X-CLX-ID: 935371000 Cc: "freebsd-acpi@freebsd.org" , Vitaly Magerya , Giovanni Trematerra Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: sbruno@freebsd.org List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 15:50:02 -0000 On Sun, 2012-07-08 at 03:22 -0700, Andriy Gapon wrote: > I would like to propose the following change for review and testing: > http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff Very nice. After a review I went ahead and applied it for testing. All seems to be well on battery and A/C on my T520 so I'm very happy to see this go into the tree. Let me know if you want me to do the man page update for acpi_cpu(4) Sean From owner-freebsd-acpi@FreeBSD.ORG Tue Jul 10 16:30:58 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 56DC71065670; Tue, 10 Jul 2012 16:30:58 +0000 (UTC) (envelope-from vmagerya@gmail.com) Received: from mail-gg0-f182.google.com (mail-gg0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id CCB838FC14; Tue, 10 Jul 2012 16:30:57 +0000 (UTC) Received: by ggnm2 with SMTP id m2so213128ggn.13 for ; Tue, 10 Jul 2012 09:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=sc9v48x62yF38zbo98e4CkBZIX6txSf7onu8jiQbPdA=; b=Iy7sg7nI7a5T3FVixWHWw9IaA4TV8RNsqu68veBauR69eIBJCYGDNVgdyWnema6qia Hl6N/xnbXYoxgutJ34ugTPxbKhnZuhZLlKbmEoY+6aLk+G5cZ9Bmy3vOvDDBPN2ci2YC GTDZvO6jB2ql0A2JSZu6aNBGXRpBJBnLhAnZqJxw7Rxnueox89w25RmQc477BLNaVhUm caUQgLPDHSfj4Qew1Bygl8z3KQ4vEm2W9ZZDc43yTe8cf71ksLwE1sVnR0h3O1EnM/xm P+mo7DIEIrYX8bx4GqrLqNyGhh/Mbxwu+HYTTRIFtr9oVSgbRwGTrGzTc8hXEf9g4xN3 AUQA== MIME-Version: 1.0 Received: by 10.66.89.170 with SMTP id bp10mr74536229pab.12.1341937856861; Tue, 10 Jul 2012 09:30:56 -0700 (PDT) Received: by 10.142.239.12 with HTTP; Tue, 10 Jul 2012 09:30:56 -0700 (PDT) In-Reply-To: <4FF95F79.30309@FreeBSD.org> References: <4FF95F79.30309@FreeBSD.org> Date: Tue, 10 Jul 2012 19:30:56 +0300 Message-ID: From: Vitaly Magerya To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-acpi@freebsd.org" , Giovanni Trematerra Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 16:30:58 -0000 Andriy Gapon wrote: > I would like to propose the following change for review and testing: > http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff I just tested this on a laptop that jumps between reporting only C1, C1 and C2, and C1 through C3; in all cases your patch does the right thing, so this removes the need for kludges I had to do earlier; thank you, Andriy. Will you also change how /etc/rc.d/power_profile selects lowest_value? It currently uses the maximum from dev.cpu.0.cx_supported, but with your patch it'll be the right thing to simply use Cmax. From owner-freebsd-acpi@FreeBSD.ORG Tue Jul 10 16:32:30 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 765D3106566C; Tue, 10 Jul 2012 16:32:30 +0000 (UTC) (envelope-from seanbru@yahoo-inc.com) Received: from mrout1-b.corp.bf1.yahoo.com (mrout1-b.corp.bf1.yahoo.com [98.139.253.104]) by mx1.freebsd.org (Postfix) with ESMTP id 2C3778FC17; Tue, 10 Jul 2012 16:32:30 +0000 (UTC) Received: from [IPv6:::1] (rideseveral.corp.yahoo.com [10.73.160.231]) by mrout1-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id q6AGVQZw098478; Tue, 10 Jul 2012 09:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com; s=cobra; t=1341937888; bh=VMDUHLN0JDC7mb1KtQThwryCcHMyZ1RBGdugA/uKOcQ=; h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date: Message-ID:Mime-Version:Content-Transfer-Encoding; b=xDFsTm3oZxszMV+aPZ6RQ1D1RbpPXnhe6nROKa9vW/hSeZZDgWbC1q/yPOYYslr61 x2r8JcASvh02mB8oOAwd5wuNObZejSwtLRsW1A3gzBtllJ9FQI9stSaXM8WT7zCGqa 33pAh7uvK5c8PXqAR8mcof+9+n/1QXdF9clz0Wwc= From: Sean Bruno To: Ian Smith In-Reply-To: <20120711000506.E42038@sola.nimnet.asn.au> References: <4FF95F79.30309@FreeBSD.org> <20120711000506.E42038@sola.nimnet.asn.au> Content-Type: text/plain; charset="UTF-8" Date: Tue, 10 Jul 2012 09:31:26 -0700 Message-ID: <1341937886.2573.3.camel@powernoodle.corp.yahoo.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Milter-Version: master.31+4-gbc07cd5+ X-CLX-ID: 937887001 Cc: Giovanni, "freebsd-acpi@freebsd.org" , Vitaly Magerya , Andriy Gapon , Trematerra Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 16:32:30 -0000 On Tue, 2012-07-10 at 07:27 -0700, Ian Smith wrote: > I wonder if that explains why setting C3 on aforesaid T23 has no > effect > (in terms of dev.cpu.0.cx_usage indicating any time spent in C3) > unless > the machine happened to be booted up on battery, in which case C3 is > shown as working whenever its enabled, by power_profile or manually? > > silly question, did you set these in /etc/rc.conf ?? performance_cx_lowest="LOW" economy_cx_lowest="LOW" Sean From owner-freebsd-acpi@FreeBSD.ORG Wed Jul 11 08:07:12 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF2881065670; Wed, 11 Jul 2012 08:07:12 +0000 (UTC) (envelope-from smithi@nimnet.asn.au) Received: from sola.nimnet.asn.au (paqi.nimnet.asn.au [115.70.110.159]) by mx1.freebsd.org (Postfix) with ESMTP id 1D0838FC08; Wed, 11 Jul 2012 08:07:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by sola.nimnet.asn.au (8.14.2/8.14.2) with ESMTP id q6B873Tm076049; Wed, 11 Jul 2012 18:07:04 +1000 (EST) (envelope-from smithi@nimnet.asn.au) Date: Wed, 11 Jul 2012 18:07:03 +1000 (EST) From: Ian Smith To: Sean Bruno In-Reply-To: <1341937886.2573.3.camel@powernoodle.corp.yahoo.com> Message-ID: <20120711130700.H42038@sola.nimnet.asn.au> References: <4FF95F79.30309@FreeBSD.org> <20120711000506.E42038@sola.nimnet.asn.au> <1341937886.2573.3.camel@powernoodle.corp.yahoo.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: "freebsd-acpi@freebsd.org" , Vitaly Magerya , Andriy Gapon , Giovanni Trematerra Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2012 08:07:12 -0000 On Tue, 10 Jul 2012 09:31:26 -0700, Sean Bruno wrote: > On Tue, 2012-07-10 at 07:27 -0700, Ian Smith wrote: > > I wonder if that explains why setting C3 on aforesaid T23 has no > > effect > > (in terms of dev.cpu.0.cx_usage indicating any time spent in C3) > > unless > > the machine happened to be booted up on battery, in which case C3 is > > shown as working whenever its enabled, by power_profile or manually? > > > > > > silly question, did you set these in /etc/rc.conf ?? > > performance_cx_lowest="LOW" > economy_cx_lowest="LOW" Fair enough question. For years, since 7.0-R, I've been running performance_cx_lowest=C2 economy_cx_lowest=C3 but as reported yesterday, either way it wasn't actually using C3, and I'd checked it several times over maybe 20 minutes. However, after (inadvertantly) leaving hw.acpi.cpu.cx_lowest manually set to C3 while on AC power overnight, this morning I discover: dev.cpu.0.freq: 733 dev.cpu.0.freq_levels: 1133/19100 733/12500 dev.cpu.0.cx_supported: C1/0 C2/84 C3/120 dev.cpu.0.cx_lowest: C3 dev.cpu.0.cx_usage: 0.09% 11.29% 88.61% last 635us So, hmm, C3 must have kicked in sometime later? Now I can merrily change cpu.cx_lowest between C1, C2 or C3 and have that reflected in usage; now C3 on AC: dev.cpu.0.cx_usage: 0.03% 0.75% 99.21% last 683us confused :), Ian From owner-freebsd-acpi@FreeBSD.ORG Wed Jul 11 11:30:32 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 43A751065674 for ; Wed, 11 Jul 2012 11:30:32 +0000 (UTC) (envelope-from redrat@mail.ru) Received: from fallback3.mail.ru (fallback3.mail.ru [94.100.176.58]) by mx1.freebsd.org (Postfix) with ESMTP id A102A8FC22 for ; Wed, 11 Jul 2012 11:30:31 +0000 (UTC) Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.176.131]) by fallback3.mail.ru (mPOP.Fallback_MX) with ESMTP id 07FA2B5C5D4E for ; Wed, 11 Jul 2012 15:27:01 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date:Subject:To:From:Message-ID; bh=sFNjsPatVLof6vlu3oxiZpWHB6B2EiX+WcvcOrLkdDk=; b=qUVgWvTYIn/qyDo+uvhTYGNfnAbYjad3pQh2oWE2fw4FqvuzKD7ZSEWZl627Z9BovebShvnbJDOf1RP+qucQynbfylYvhqt4ANKNr4CXIeBCm7qpY1HVJaKe1wLH8vCW; Received: from [213.79.84.131] (port=2373 helo=redrat) by smtp3.mail.ru with esmtpa (envelope-from ) id 1Sov4I-00082e-6p for freebsd-acpi@FreeBSD.org; Wed, 11 Jul 2012 15:26:54 +0400 Message-ID: <99BEDCD0C12447D09304325E994083D6@complitex.local> From: "Alexey Markov" To: Date: Wed, 11 Jul 2012 15:26:25 +0400 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="koi8-r"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 FL-Build: Fidolook 2007 (HV) 6.0.6000.97 - 24/12/2008 20:32:05 X-Spam: Not detected X-Mras: Ok Cc: Subject: ACPI errors on ASUS M5A88-M m/b X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2012 11:30:32 -0000 Hello! Two days ago I have installed FreeBSD 8.3-RELEASE-p3 amd6 on ASUS M5A88-M motherboard with AMD Phenom II X4 925 processor, and got some ACPI errors in the dmesg: ACPI APIC Table: <031612 APIC2114> acpi0: <031612 XSDT2114> on motherboard ACPI Error: [PCI0] Namespace lookup failure, AE_NOT_FOUND (20101013/dswload-772) ACPI Exception: AE_NOT_FOUND, During name lookup/catalog (20101013/psloop-326) ACPI Error: Method parse/execution failed [\\] (Node 0xffffffff80654f00), AE_NOT_FOUND (20101013/psparse-633) acpi0: reservation of fee00000, 1000 (3) failed acpi0: reservation of ffb80000, 80000 (3) failed acpi0: reservation of fec10000, 20 (3) failed acpi0: reservation of fed40000, 5000 (3) failed acpi0: reservation of fed80000, 1000 (3) failed acpi0: reservation of 0, a0000 (3) failed acpi0: reservation of 100000, dff00000 (3) failed acpi_ec0: port 0x62,0x66 on acpi0 acpi_hpet0: iomem 0xfed00000-0xfed003ff on acpi0 acpi_hpet1: iomem 0xfed00000-0xfed003ff on acpi0 device_attach: acpi_hpet1 attach returned 12 Full dmesg listing is here: http://www.redrat.ru/files/misc/dmesg.txt host# sysctl hw.acpi hw.acpi.supported_sleep_state: S1 S3 S4 S5 hw.acpi.power_button_state: S5 hw.acpi.sleep_button_state: S1 hw.acpi.lid_switch_state: NONE hw.acpi.standby_state: S1 hw.acpi.suspend_state: S3 hw.acpi.sleep_delay: 1 hw.acpi.s4bios: 0 hw.acpi.verbose: 0 hw.acpi.disable_on_reboot: 0 hw.acpi.handle_reboot: 0 hw.acpi.reset_video: 0 hw.acpi.cpu.cx_lowest: C1 After loading aibs module I got on the console: host# kldload aibs aibs0: on cpi0 aibs0: VSIF not found aibs0: TSIF not found aibs0: FSIF not found acpi_hpet1: iomem 0xfe00000-0xfed003ff on acpi0 device_attach: acpi_hpet1 attach returned 12 and ASUS volrage/temperature/fan monitoring not working. I have tried to dump and recompile ACPI tables: host# acpidump -t -d > redrat-host.asl acpidump: RSDT entry 3 (sig OEMB) is corrupt Full output of acpidump is here: http://www.redrat.ru/files/misc/redrat-host.asl host# iasl redrat-host.asl > error.txt ACPI Warning: NsLookup: Type mismatch on RMEM (Region), searching for (Device) (20101013/nsaccess-731) In the error.txt files a lot of errors found: "Maximum error count (200) exceeded". Full list of errors is here: http://www.redrat.ru/files/misc/error.txt So, can I do something more to solve this problem? -- WBR, Alexey Markov. From owner-freebsd-acpi@FreeBSD.ORG Thu Jul 12 12:35:03 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2233F106566B for ; Thu, 12 Jul 2012 12:35:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id E8D168FC14 for ; Thu, 12 Jul 2012 12:35:02 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 53B57B91A; Thu, 12 Jul 2012 08:35:02 -0400 (EDT) From: John Baldwin To: freebsd-acpi@freebsd.org Date: Thu, 12 Jul 2012 07:38:40 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; ) References: <99BEDCD0C12447D09304325E994083D6@complitex.local> In-Reply-To: <99BEDCD0C12447D09304325E994083D6@complitex.local> MIME-Version: 1.0 Content-Type: Text/Plain; charset="koi8-r" Content-Transfer-Encoding: 7bit Message-Id: <201207120738.40491.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 12 Jul 2012 08:35:02 -0400 (EDT) Cc: Alexey Markov Subject: Re: ACPI errors on ASUS M5A88-M m/b X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2012 12:35:03 -0000 On Wednesday, July 11, 2012 7:26:25 am Alexey Markov wrote: > Hello! > > Two days ago I have installed FreeBSD 8.3-RELEASE-p3 amd6 on > ASUS M5A88-M motherboard with AMD Phenom II X4 925 processor, > and got some ACPI errors in the dmesg: Are you seeing any functional problems or just error messages? I realize aibs didn't work, though it seems it simply may not support your system. The acpi_hpet1 thing just seems to be a duplicate device (acpi_hpet0 attached fine), so I believe you can most likely ignore that. -- John Baldwin From owner-freebsd-acpi@FreeBSD.ORG Thu Jul 12 12:35:04 2012 Return-Path: Delivered-To: acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 070001065672; Thu, 12 Jul 2012 12:35:04 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id CA62E8FC16; Thu, 12 Jul 2012 12:35:03 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 27AE0B91E; Thu, 12 Jul 2012 08:35:03 -0400 (EDT) From: John Baldwin To: freebsd-amd64@freebsd.org Date: Thu, 12 Jul 2012 07:40:09 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; ) References: <201207110248.q6B2mplM078753@red.freebsd.org> In-Reply-To: <201207110248.q6B2mplM078753@red.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201207120740.09379.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 12 Jul 2012 08:35:03 -0400 (EDT) Cc: acpi@freebsd.org, freebsd-gnats-submit@freebsd.org, Axel Gonzalez Subject: Re: amd64/169779: [patch] powerd doesn't honor the -n flag X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2012 12:35:04 -0000 On Tuesday, July 10, 2012 10:48:51 pm Axel Gonzalez wrote: > > >Number: 169779 > >Category: amd64 > >Synopsis: [patch] powerd doesn't honor the -n flag > >Confidential: no > >Severity: serious > >Priority: low > >Responsible: freebsd-amd64 > >State: open > >Quarter: > >Keywords: > >Date-Required: > >Class: sw-bug > >Submitter-Id: current-users > >Arrival-Date: Wed Jul 11 02:50:10 UTC 2012 > >Closed-Date: > >Last-Modified: > >Originator: Axel Gonzalez > >Release: 9.0-RELEASE-p2 > >Organization: > >Environment: > FreeBSD moonlight 9.0-RELEASE-p2 FreeBSD 9.0-RELEASE-p2 #0: Tue Jun 12 02:12:57 CDT 2012 toor@moonlight:/usr/obj/usr/src/sys/LXCORE964 amd64 > >Description: > powerd never initializes the variable that keeps the status of the line status. This variable defaults to 0 (with the compiler? with the arch?) and results in powerd using the AC profile. > > This is a problem, since at start it says it is in unkown status, but doesn't respect the -n argument. > > Note: since the variable is not initialized, it can lead to other unexpected behaviour. > > >How-To-Repeat: > This should use the "adaptive" profile specified by -n, but uses hiadaptive > > # /usr/sbin/powerd -i 50 -r 80 -M 1800 -v -p 1000 -n adaptive > powerd: unable to determine AC line status > CPU frequency is above user-defined maximum; changing frequency to 1795 MHz > load 15%, current freq 1795 MHz ( 0), wanted freq 2094 MHz > > >Fix: > Initialize the variable > > --- powerd.c.orig 2012-07-10 21:21:07.882970887 -0500 > +++ powerd.c 2012-07-10 21:22:29.292974203 -0500 > @@ -278,6 +278,7 @@ > acline_init(void) > { > acline_mib_len = 4; > + acline_status = SRC_UNKNOWN; > > if (sysctlnametomib(ACPIAC, acline_mib, &acline_mib_len) == 0) { > acline_mode = ac_sysctl; I suspect this is correct, but cc'ing acpi@ to see if anyone there has any comments. -- John Baldwin From owner-freebsd-acpi@FreeBSD.ORG Fri Jul 13 08:13:09 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D3A0106564A; Fri, 13 Jul 2012 08:13:09 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id D50F38FC1B; Fri, 13 Jul 2012 08:13:07 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA03616; Fri, 13 Jul 2012 11:13:06 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Spazp-000ARQ-TT; Fri, 13 Jul 2012 11:13:06 +0300 Message-ID: <4FFFD891.2060109@FreeBSD.org> Date: Fri, 13 Jul 2012 11:13:05 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120620 Thunderbird/13.0.1 MIME-Version: 1.0 To: sbruno@FreeBSD.org, Vitaly Magerya , John Baldwin , Giovanni Trematerra References: <4FF95F79.30309@FreeBSD.org> <1341935370.4493.4.camel@powernoodle> In-Reply-To: <1341935370.4493.4.camel@powernoodle> X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "freebsd-acpi@freebsd.org" , Sean Bruno Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2012 08:13:09 -0000 Many thanks to all who reviewed and tested! I've just committed this change. -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Fri Jul 13 08:15:41 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A3D5106566B; Fri, 13 Jul 2012 08:15:41 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id BC5408FC08; Fri, 13 Jul 2012 08:15:39 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA03637; Fri, 13 Jul 2012 11:15:38 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Spb2I-000ARe-2s; Fri, 13 Jul 2012 11:15:38 +0300 Message-ID: <4FFFD92B.8080600@FreeBSD.org> Date: Fri, 13 Jul 2012 11:15:39 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120620 Thunderbird/13.0.1 MIME-Version: 1.0 To: sbruno@FreeBSD.org References: <4FF95F79.30309@FreeBSD.org> <1341935370.4493.4.camel@powernoodle> In-Reply-To: <1341935370.4493.4.camel@powernoodle> X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "freebsd-acpi@freebsd.org" , Giovanni Trematerra , Sean Bruno , John Baldwin , Vitaly Magerya Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2012 08:15:41 -0000 on 10/07/2012 18:49 Sean Bruno said the following: > On Sun, 2012-07-08 at 03:22 -0700, Andriy Gapon wrote: >> I would like to propose the following change for review and testing: >> http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff > > Very nice. After a review I went ahead and applied it for testing. All > seems to be well on battery and A/C on my T520 so I'm very happy to see > this go into the tree. > > Let me know if you want me to do the man page update for acpi_cpu(4) Sean, I would appreciate this a lot as I am currently a little bit busier than usual. On a related note I also have this change for acpi.4: --- a/share/man/man4/acpi.4 +++ b/share/man/man4/acpi.4 @@ -80,8 +80,12 @@ A scheduling algorithm will select states between and this setting as system load dictates. To enable ACPI CPU idling control, -.Va machdep.cpu_idle_hlt -must be set to 1. +.Va machdep.idle +should be set to +.Li acpi +if it is listed in +.Va machdep.idle_available +. .It Va hw.acpi.cpu.cx_supported List of supported CPU idle states and their transition latency in microseconds. How does this look? -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Fri Jul 13 08:16:25 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 39C1A106566B; Fri, 13 Jul 2012 08:16:25 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 1F42A8FC15; Fri, 13 Jul 2012 08:16:23 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA03645; Fri, 13 Jul 2012 11:16:21 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Spb2y-000ARj-SM; Fri, 13 Jul 2012 11:16:20 +0300 Message-ID: <4FFFD955.9030200@FreeBSD.org> Date: Fri, 13 Jul 2012 11:16:21 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120620 Thunderbird/13.0.1 MIME-Version: 1.0 To: Vitaly Magerya References: <4FF95F79.30309@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "freebsd-acpi@freebsd.org" , Giovanni Trematerra , John Baldwin Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2012 08:16:25 -0000 on 10/07/2012 19:30 Vitaly Magerya said the following: > Andriy Gapon wrote: >> I would like to propose the following change for review and testing: >> http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff > > I just tested this on a laptop that jumps between reporting only > C1, C1 and C2, and C1 through C3; in all cases your patch does > the right thing, so this removes the need for kludges I had to > do earlier; thank you, Andriy. > > Will you also change how /etc/rc.d/power_profile selects > lowest_value? It currently uses the maximum from dev.cpu.0.cx_supported, > but with your patch it'll be the right thing to simply use Cmax. I've put this on my to do list. Hope to commit this trivial change soon-ish. -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Fri Jul 13 12:38:40 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 95A01106566B; Fri, 13 Jul 2012 12:38:40 +0000 (UTC) (envelope-from redrat@mail.ru) Received: from smtp20.mail.ru (smtp20.mail.ru [94.100.176.173]) by mx1.freebsd.org (Postfix) with ESMTP id 012078FC14; Fri, 13 Jul 2012 12:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date:Subject:References:To:From:Message-ID; bh=Ak6skFx9WR5VJ6YqMPf7Ln6ZCiAxckw2uTSlI31Tp10=; b=iMqawTs6Un31ITo+xNGz5sxf82BGYW0ReX305rV6qdSjtjh/ViU+9DJ1Fdij8lEvllp8cxV63quaB2hpLXEoF6tHweobk64YM5zKHv98XSCcYTlEvn01dSmOXcb4cLRo; Received: from [213.79.84.131] (port=26491 helo=redrat) by smtp20.mail.ru with esmtpa (envelope-from ) id 1Spf8j-0001il-6k; Fri, 13 Jul 2012 16:38:33 +0400 Message-ID: From: "Alexey Markov" To: "John Baldwin" , References: <99BEDCD0C12447D09304325E994083D6@complitex.local> <201207120738.40491.jhb@freebsd.org> Date: Fri, 13 Jul 2012 16:38:25 +0400 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="koi8-r"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 FL-Build: Fidolook 2007 (HV) 6.0.6000.97 - 24/12/2008 20:32:05 X-Spam: Not detected X-Mras: Ok Cc: Subject: Re: ACPI errors on ASUS M5A88-M m/b X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2012 12:38:40 -0000 Hello, John! On July, 12 2012 at 15:38 you wrote to freebsd-acpi@freebsd.org: ??>> Two days ago I have installed FreeBSD 8.3-RELEASE-p3 amd6 on ??>> ASUS M5A88-M motherboard with AMD Phenom II X4 925 processor, ??>> and got some ACPI errors in the dmesg: JB> Are you seeing any functional problems or just error messages? I JB> realize aibs didn't work, though it seems it simply may not support JB> your system. I rebooted server from USB flash with Windows XP and installed ASUS ProbeII, it correctly show voltage/temperature/fan values. It seems that ASUS AI Booster in place and working in Windows. Also, manuals for my m/b mentions AI Booster sensors too. Except not working aibs sensors I can't see any problems yet. JB> The acpi_hpet1 thing just seems to be a duplicate device (acpi_hpet0 JB> attached fine), so I believe you can most likely ignore that. It's strange a little, why kernel trying to load second acpi_hpet0 even without aibs device? But if it harmless, I just will take no notice of it. -- WBR, Alexey Markov. From owner-freebsd-acpi@FreeBSD.ORG Fri Jul 13 14:42:08 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 400031065670 for ; Fri, 13 Jul 2012 14:42:08 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 154F28FC15 for ; Fri, 13 Jul 2012 14:42:08 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 8D7D9B946; Fri, 13 Jul 2012 10:42:07 -0400 (EDT) From: John Baldwin To: "Alexey Markov" Date: Fri, 13 Jul 2012 08:53:02 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; ) References: <99BEDCD0C12447D09304325E994083D6@complitex.local> <201207120738.40491.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="koi8-r" Content-Transfer-Encoding: 7bit Message-Id: <201207130853.02604.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 13 Jul 2012 10:42:07 -0400 (EDT) Cc: freebsd-acpi@freebsd.org Subject: Re: ACPI errors on ASUS M5A88-M m/b X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2012 14:42:08 -0000 On Friday, July 13, 2012 8:38:25 am Alexey Markov wrote: > Hello, John! > On July, 12 2012 at 15:38 you wrote to freebsd-acpi@freebsd.org: > > ??>> Two days ago I have installed FreeBSD 8.3-RELEASE-p3 amd6 on > ??>> ASUS M5A88-M motherboard with AMD Phenom II X4 925 processor, > ??>> and got some ACPI errors in the dmesg: > > JB> Are you seeing any functional problems or just error messages? I > JB> realize aibs didn't work, though it seems it simply may not support > JB> your system. > > I rebooted server from USB flash with Windows XP and installed ASUS > ProbeII, it correctly show voltage/temperature/fan values. It seems > that ASUS AI Booster in place and working in Windows. Also, manuals > for my m/b mentions AI Booster sensors too. > > Except not working aibs sensors I can't see any problems yet. Ok. I think then that aibs just needs updating for your machine perhaps. > JB> The acpi_hpet1 thing just seems to be a duplicate device (acpi_hpet0 > JB> attached fine), so I believe you can most likely ignore that. > > It's strange a little, why kernel trying to load second acpi_hpet0 > even without aibs device? But if it harmless, I just will take no > notice of it. This is due to the way new-bus works. When you load a new ACPI driver (like acpi_aiboost), all ACPI devices that don't have a driver are re-probed (in case the new driver handles any of those devices). This results in the extra HPET device being re-probed as well. -- John Baldwin From owner-freebsd-acpi@FreeBSD.ORG Sat Jul 14 13:16:31 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1DDD7106566C for ; Sat, 14 Jul 2012 13:16:31 +0000 (UTC) (envelope-from resuscitated_wael@hotmail.com) Received: from sam.nabble.com (sam.nabble.com [216.139.236.26]) by mx1.freebsd.org (Postfix) with ESMTP id 9A3628FC0C for ; Sat, 14 Jul 2012 13:16:30 +0000 (UTC) Received: from [192.168.236.26] (helo=sam.nabble.com) by sam.nabble.com with esmtp (Exim 4.72) (envelope-from ) id 1Sq2D0-0005qj-AA for freebsd-acpi@freebsd.org; Sat, 14 Jul 2012 06:16:30 -0700 Date: Sat, 14 Jul 2012 06:16:30 -0700 (PDT) From: SicoSico To: freebsd-acpi@freebsd.org Message-ID: <1342271790308-5726831.post@n5.nabble.com> In-Reply-To: <20120618.030725.95800960.iwasaki@jp.FreeBSD.org> References: <20120616.025804.48535013.iwasaki@jp.FreeBSD.org> <4FDBE1BA.3070204@gmail.com> <20120618.030725.95800960.iwasaki@jp.FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [CFT] acpi_ibm event handler X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2012 13:16:31 -0000 Hello Mitsuru IWASAKI, Could you please help me with a custom DSDT? I have a Lenovo Y570, I applied your patch but still sysctl -a doesn't show ibm I was discussing the issue in these links: http://freebsd.1045724.n5.nabble.com/Lenovo-Y570-backlight-td5726207.html http://freebsd.1045724.n5.nabble.com/Lenovo-Y570-backlight-td5726207.html http://freebsd.1045724.n5.nabble.com/Dual-video-card-notebook-no-X11-at-all-td5723538.html http://freebsd.1045724.n5.nabble.com/Dual-video-card-notebook-no-X11-at-all-td5723538.html Here is a link for my DSDT files: http://www.mediafire.com/?a2upinpllun05l3 -- View this message in context: http://freebsd.1045724.n5.nabble.com/CFT-acpi-ibm-event-handler-tp5718721p5726831.html Sent from the freebsd-acpi mailing list archive at Nabble.com.