Date: Sun, 29 Jan 2012 06:26:47 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Uffe Jakobsen <uffe@uffe.org> Cc: freebsd-fs@freebsd.org Subject: Re: kern/164516: [ext2fs] unable to mount EXT2 filesystem Message-ID: <20120129042647.GJ2726@deviant.kiev.zoral.com.ua> In-Reply-To: <4F248B44.1090304@uffe.org> References: <201201272310.q0RNABvZ065758@freefall.freebsd.org> <20120128004755.GA89980@icarus.home.lan> <4F246CA9.30803@uffe.org> <CADLo83_jMpKK60gu%2BVyejTudGicyHiqbGnP5JBpZ8d20pjndsg@mail.gmail.com> <4F248B44.1090304@uffe.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--SfgfV7onya2wNU+g
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Jan 29, 2012 at 12:56:52AM +0100, Uffe Jakobsen wrote:
>=20
>=20
> On 2012-01-28 23:31, Chris Rees wrote:
> >
> >On 28 Jan 2012 22:14, "Uffe Jakobsen" <uffe@uffe.org
> ><mailto:uffe@uffe.org>> wrote:
> > >
> > >
> > >
> > > On 2012-01-28 01:47, Jeremy Chadwick wrote:
> > >>
> > >> On Fri, Jan 27, 2012 at 11:10:11PM +0000, Uffe Jakobsen wrote:
> > >>>
> > >>> The following reply was made to PR kern/164516; it has been noted
> >by GNATS.
> > >>>
> > >>> From: Uffe Jakobsen<uffe@uffe.org <mailto:uffe@uffe.org>>
> > >>> To: bug-followup@FreeBSD.org
> > >>> Cc:
> > >>> Subject: Re: kern/164516: [ext2fs] unable to mount EXT2 filesystem
> > >>> Date: Fri, 27 Jan 2012 20:49:05 +0100
> > >>>
> > >>> >
> > >>> > Not a bug. The file system type name is "ext2fs" not "ext2".
> > >>> > Use "mount -t ext2fs /dev/md0 /mnt/tmp0" instead.
> > >>> >
> > >>>
> > >>> Instead of reporting "Operation not supported by device"
> > >>> Shouldn't it report unknown filesystem type ?
> > >>
> > >>
> > >> Please look through /usr/include/errno.h and let us know what error=
=20
> > code
> > >> would represent "unknown filesystem type". :-)
> > >>
> > >
> > > There are plenty of other places in the mount src where we exit
> >without a specific error code. Question is if there exists a scenario
> >where the requested filesystem type would/could not be found by
> >getvfsbyname() ?
> > >
> > > I've met this problem myself a number of times - and even in this
> >case I did not spot the spelling error right away ('ext2fs' and not=20
> >'ext2').
> > >
> > > The returned error 'Operation not supported by device' - atleast to
> >me - indicates that the mount process got much further before running
> >into some kind of problem. The times when I've met this error I've begun
> >inspecting mount options etc before realizing that the fstype had a typo.
> > >
> >
> >Normally when an error comes up I check the manpage.
>=20
> Manpage for mount does not at all mention any error conditions.
>=20
> You'll have to know the inner workings of mount in order to know that in=
=20
> certain cases everything is thrown into nmount() and any error that=20
> comes up would come directly from nmount()
>=20
> Anyway - would you accept a patch that checked the fstype using=20
> getvfsbyname() before calling nmount() ?
Kernel tries to load the named module if it is not registered in the
list of know VFSes. Your proposal would break this functionality.
--SfgfV7onya2wNU+g
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iEYEARECAAYFAk8kyocACgkQC3+MBN1Mb4hTRQCfabRZ11enKcKWKeNQeSoAeJQy
o3kAoNzkr8mcXCWXNjVQiZAz2RgHH8Xx
=scsm
-----END PGP SIGNATURE-----
--SfgfV7onya2wNU+g--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120129042647.GJ2726>