From owner-freebsd-fs@FreeBSD.ORG Sun Jan 29 04:56:19 2012 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41CBE106566B for ; Sun, 29 Jan 2012 04:56:19 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id CAA058FC08 for ; Sun, 29 Jan 2012 04:56:18 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q0T4Qm1d023888 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 29 Jan 2012 06:26:48 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q0T4QlHS084833; Sun, 29 Jan 2012 06:26:47 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q0T4QlNP084832; Sun, 29 Jan 2012 06:26:47 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 29 Jan 2012 06:26:47 +0200 From: Kostik Belousov To: Uffe Jakobsen Message-ID: <20120129042647.GJ2726@deviant.kiev.zoral.com.ua> References: <201201272310.q0RNABvZ065758@freefall.freebsd.org> <20120128004755.GA89980@icarus.home.lan> <4F246CA9.30803@uffe.org> <4F248B44.1090304@uffe.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SfgfV7onya2wNU+g" Content-Disposition: inline In-Reply-To: <4F248B44.1090304@uffe.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-fs@freebsd.org Subject: Re: kern/164516: [ext2fs] unable to mount EXT2 filesystem X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jan 2012 04:56:19 -0000 --SfgfV7onya2wNU+g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 29, 2012 at 12:56:52AM +0100, Uffe Jakobsen wrote: >=20 >=20 > On 2012-01-28 23:31, Chris Rees wrote: > > > >On 28 Jan 2012 22:14, "Uffe Jakobsen" >> wrote: > > > > > > > > > > > > On 2012-01-28 01:47, Jeremy Chadwick wrote: > > >> > > >> On Fri, Jan 27, 2012 at 11:10:11PM +0000, Uffe Jakobsen wrote: > > >>> > > >>> The following reply was made to PR kern/164516; it has been noted > >by GNATS. > > >>> > > >>> From: Uffe Jakobsen> > > >>> To: bug-followup@FreeBSD.org > > >>> Cc: > > >>> Subject: Re: kern/164516: [ext2fs] unable to mount EXT2 filesystem > > >>> Date: Fri, 27 Jan 2012 20:49:05 +0100 > > >>> > > >>> > > > >>> > Not a bug. The file system type name is "ext2fs" not "ext2". > > >>> > Use "mount -t ext2fs /dev/md0 /mnt/tmp0" instead. > > >>> > > > >>> > > >>> Instead of reporting "Operation not supported by device" > > >>> Shouldn't it report unknown filesystem type ? > > >> > > >> > > >> Please look through /usr/include/errno.h and let us know what error= =20 > > code > > >> would represent "unknown filesystem type". :-) > > >> > > > > > > There are plenty of other places in the mount src where we exit > >without a specific error code. Question is if there exists a scenario > >where the requested filesystem type would/could not be found by > >getvfsbyname() ? > > > > > > I've met this problem myself a number of times - and even in this > >case I did not spot the spelling error right away ('ext2fs' and not=20 > >'ext2'). > > > > > > The returned error 'Operation not supported by device' - atleast to > >me - indicates that the mount process got much further before running > >into some kind of problem. The times when I've met this error I've begun > >inspecting mount options etc before realizing that the fstype had a typo. > > > > > > >Normally when an error comes up I check the manpage. >=20 > Manpage for mount does not at all mention any error conditions. >=20 > You'll have to know the inner workings of mount in order to know that in= =20 > certain cases everything is thrown into nmount() and any error that=20 > comes up would come directly from nmount() >=20 > Anyway - would you accept a patch that checked the fstype using=20 > getvfsbyname() before calling nmount() ? Kernel tries to load the named module if it is not registered in the list of know VFSes. Your proposal would break this functionality. --SfgfV7onya2wNU+g Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk8kyocACgkQC3+MBN1Mb4hTRQCfabRZ11enKcKWKeNQeSoAeJQy o3kAoNzkr8mcXCWXNjVQiZAz2RgHH8Xx =scsm -----END PGP SIGNATURE----- --SfgfV7onya2wNU+g--