From owner-freebsd-geom@FreeBSD.ORG Mon Apr 2 11:07:07 2012 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BF11110656D0 for ; Mon, 2 Apr 2012 11:07:07 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9FDF78FC1A for ; Mon, 2 Apr 2012 11:07:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q32B77Id046779 for ; Mon, 2 Apr 2012 11:07:07 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q32B77dV046777 for freebsd-geom@FreeBSD.org; Mon, 2 Apr 2012 11:07:07 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 2 Apr 2012 11:07:07 GMT Message-Id: <201204021107.q32B77dV046777@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-geom@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-geom@FreeBSD.org X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2012 11:07:07 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- f bin/165789 geom bsdlabel(8): partition c doesn't cover the whole unit! o kern/165745 geom [geom] geom_multipath page fault on removed drive p kern/165573 geom [geom] Strange behavior of geom_part_* modules o kern/165428 geom [glabel][patch] Add xfs support to glabel o kern/164254 geom [geom] gjournal not stopping on GPT partitions o kern/164252 geom [geom] gjournal overflow o kern/164143 geom [geom] Partition table not recognized after upgrade R8 a kern/163020 geom [geli] [patch] enable the Camellia-XTS on GEOM ELI o kern/162010 geom [geli] panic: Provider's error should be set (error=0) o kern/161979 geom [geom] glabel doesn't update after newfs, and glabel s o kern/161752 geom [geom] glabel(8) doesn't get gpt label change o bin/161677 geom gpart(8) Probably bug in gptboot o kern/160562 geom [geom][patch] Allow to insert new component to geom_ra o kern/160409 geom [geli] failed to attach provider f kern/159595 geom [geom] [panic] panic on gmirror unload in vbox [regres p kern/158398 geom [headers] [patch] includes o kern/158197 geom [geom] geom_cache with size>1000 leads to panics o kern/157879 geom [libgeom] [regression] ABI change without version bump o kern/157863 geom [geli] kbdmux prevents geli passwords from being enter o kern/157739 geom [geom] GPT labels with geom_multipath o kern/157724 geom [geom] gpart(8) 'add' command must preserve gap for sc o kern/157723 geom [geom] GEOM should not process 'c' (raw) partitions fo o kern/157108 geom [gjournal] dumpon(8) fails on gjournal providers o kern/155994 geom [geom] Long "Suspend time" when reading large files fr o kern/154226 geom [geom] GEOM label does not change when you modify them o kern/150858 geom [geom] [geom_label] [patch] glabel(8) is not compatibl o kern/150626 geom [geom] [gjournal] gjournal(8) destroys label o kern/150555 geom [geom] gjournal unusable on GPT partitions o kern/150334 geom [geom] [udf] [patch] geom label does not support UDF o kern/149762 geom volume labels with rogue characters o bin/149215 geom [panic] [geom_part] gpart(8): Delete linux's slice via o kern/147667 geom [gmirror] Booting with one component of a gmirror, the o kern/145818 geom [geom] geom_stat_open showing cached information for n o kern/145042 geom [geom] System stops booting after printing message "GE o kern/143455 geom gstripe(8) in RELENG_8 (31st Jan 2010) broken o kern/142563 geom [geom] [hang] ioctl freeze in zpool o kern/141740 geom [geom] gjournal(8): g_journal_destroy concurrent error o kern/140352 geom [geom] gjournal + glabel not working o kern/135898 geom [geom] Severe filesystem corruption - large files or l o kern/134922 geom [gmirror] [panic] kernel panic when use fdisk on disk o kern/134113 geom [geli] Problem setting secondary GELI key o kern/133931 geom [geli] [request] intentionally wrong password to destr o bin/132845 geom [geom] [patch] ggated(8) does not close files opened a o bin/131415 geom [geli] keystrokes are unregulary sent to Geli when typ o kern/131353 geom [geom] gjournal(8) kernel lock o kern/129674 geom [geom] gjournal root did not mount on boot o kern/129645 geom gjournal(8): GEOM_JOURNAL causes system to fail to boo o kern/129245 geom [geom] gcache is more suitable for suffix based provid f kern/128276 geom [gmirror] machine lock up when gmirror module is used o kern/127420 geom [geom] [gjournal] [panic] Journal overflow on gmirrore o kern/124973 geom [gjournal] [patch] boot order affects geom_journal con o kern/124969 geom gvinum(8): gvinum raid5 plex does not detect missing s o kern/123962 geom [panic] [gjournal] gjournal (455Gb data, 8Gb journal), o kern/123122 geom [geom] GEOM / gjournal kernel lock o kern/122738 geom [geom] gmirror list "losts consumers" after gmirror de o kern/122067 geom [geom] [panic] Geom crashed during boot o kern/121364 geom [gmirror] Removing all providers create a "zombie" mir o kern/120091 geom [geom] [geli] [gjournal] geli does not prompt for pass o kern/115856 geom [geli] ZFS thought it was degraded when it should have o kern/115547 geom [geom] [patch] [request] let GEOM Eli get password fro o kern/114532 geom [geom] GEOM_MIRROR shows up in kldstat even if compile f kern/113957 geom [gmirror] gmirror is intermittently reporting a degrad o kern/113837 geom [geom] unable to access 1024 sector size storage o kern/113419 geom [geom] geom fox multipathing not failing back o kern/107707 geom [geom] [patch] [request] add new class geom_xbox360 to o kern/94632 geom [geom] Kernel output resets input while GELI asks for o kern/90582 geom [geom] [panic] Restore cause panic string (ffs_blkfree o bin/90093 geom fdisk(8) incapable of altering in-core geometry o kern/87544 geom [gbde] mmaping large files on a gbde filesystem deadlo o bin/86388 geom [geom] [geom_part] periodic(8) daily should backup gpa o kern/84556 geom [geom] [panic] GBDE-encrypted swap causes panic at shu o kern/79251 geom [2TB] newfs fails on 2.6TB gbde device o kern/79035 geom [vinum] gvinum unable to create a striped set of mirro o bin/78131 geom gbde(8) "destroy" not working. 74 problems total. From owner-freebsd-geom@FreeBSD.ORG Mon Apr 2 21:37:38 2012 Return-Path: Delivered-To: geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 914F4106566C; Mon, 2 Apr 2012 21:37:38 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4]) by mx1.freebsd.org (Postfix) with ESMTP id 2D8F38FC15; Mon, 2 Apr 2012 21:37:31 +0000 (UTC) Received: from sa-nc-ipg-172-23-0-161.static.jnpr.net (natint3.juniper.net [66.129.224.36]) (authenticated bits=0) by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id q32LbO76067348 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 2 Apr 2012 14:37:30 -0700 (PDT) (envelope-from marcel@xcllnt.net) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1257) From: Marcel Moolenaar Date: Mon, 2 Apr 2012 14:37:18 -0700 Content-Transfer-Encoding: 7bit Message-Id: To: Grzegorz Bernacki X-Mailer: Apple Mail (2.1257) Cc: geom@FreeBSD.org, fs@FreeBSD.org Subject: Review of projects/nand branch X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2012 21:37:38 -0000 Grzegorz, I reviewed the changes on the projects/nand branch and in general it's of high quality and any problems, improvements and/or cleanups can be addressed after it gets merged into -current, with the following caveat: 1. Changes to sys/kern, sys/geom and sys/sys should be reviewed and approved by people on fs@freebsd.org and/or geom@freebsd.org. I saw comments from pjd already for example. 2. Please address the following points before merging onto head: o In include/Makefile: fs/fifofs is removed. Deliberate? o In sbin/Makefile: we should have a distinct MK_NANDFS option for use by the file system code. o In sbin/nandfs/nandfs.8: could elaborate for what one could use the snapshots. o In sbin/nandfs/nandfs.h: define NANDFS_H. o In sbin/nandfs/nandfs.c: usage() is wrong. o In sbin/nandfs/Makefile: $FreeBSD$ is missing. o In sbin/mount_nandfs/mount_nandfs.8: copyright notice seems bogusly copied. Also, cleanerd is gone so it needs updating. o In sbin/mount_nandfs/mount_nandfs.c: cleanerd is gone, so this file could do with a some cleanups. o In sbin/mount_nandfs/Makefile: $FreeBSD$ is missing. o In sbin/mount/mntopts.h: cleanerd is gone, so should not be needed anymore. o In sbin/newfs_nandfs/newfs_nandfs.c: we have CRC32 code for re-use. No need to implement again. o In sbin/newfs_nandfs/Makefile: missing DPADD. o In share/mk/bsd.own.mk: Add NANDFS as well. May also want to add NANDSIM separately. o In share/man/man5/Makefile: should be NANDFS. o In usr.sbin/nandtool/Makefile: missing $FreeBSD$ o In usr.sbin/nandsim/Makefile: missing $FreeBSD$ o usr.sbin/Makefile should have nandtool and nandsim when MK_NAND is defined. o In lib/Makefile: should be MK_NANDFS; not MK_NAND. o In lib/libstand/nandfs.c: should use common CRC32 impl. o In lib/libstand/Makefile: should be MK_NANDFS; not MK_NAND. o Please get buy-in for changes to sys/kern/vfs_vnops.c, sys/kern/vfs_bio.c and sys/kern/vfs_subr.c from people on fs@freebsd.org. o In sys/modules/Makefile: always build nandfs module. Make nandsim module dependent on MK_NAND or MK_NANDSIM if added. o Please get buy-in for changes to sys/geom/geom_dev.c, sys/geom/geom_disk.c, sys/geom/geom_disk.h, sys/geom/geom.h and sys/geom/geom_slice.c from people on geom@freebsd.org. o Please get buy-in for changes to sys/sys/disk.h and sys/sys/bio.h from people on either fs@freebsd.org or geom@freebsd.org. I also have a general usability question relating snapshots. Currently snapshots are read-only. A useful feature in the embedded space is to make a snapshot, attempt a software update and revert to the snapshot if and when the update fails or gets aborted. Is it possible to extend the snapshot feature in the future to allow for this use case (i.e. ignore any and all modifications that happened after a snapshot was made and mount the snapshot R/W as representing the current/latest state of the file system)? I'd like to thank Semihalf and the Foundation for bringing this code into FreeBSD. Well done! Thanks, -- Marcel Moolenaar marcel@xcllnt.net From owner-freebsd-geom@FreeBSD.ORG Tue Apr 3 03:10:17 2012 Return-Path: Delivered-To: geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F0380106564A; Tue, 3 Apr 2012 03:10:16 +0000 (UTC) (envelope-from gjb@semihalf.com) Received: from smtp.semihalf.com (smtp.semihalf.com [213.17.239.109]) by mx1.freebsd.org (Postfix) with ESMTP id 686278FC08; Tue, 3 Apr 2012 03:10:16 +0000 (UTC) Received: from localhost (unknown [213.17.239.109]) by smtp.semihalf.com (Postfix) with ESMTP id 0413AC4B60; Tue, 3 Apr 2012 05:10:02 +0200 (CEST) X-Virus-Scanned: by amavisd-new at semihalf.com Received: from smtp.semihalf.com ([213.17.239.109]) by localhost (smtp.semihalf.com [213.17.239.109]) (amavisd-new, port 10024) with ESMTP id 3VSuFgcJfFBz; Tue, 3 Apr 2012 05:10:01 +0200 (CEST) Received: from [172.17.136.194] (adsl-66-120-169-242.dsl.sntc01.pacbell.net [66.120.169.242]) by smtp.semihalf.com (Postfix) with ESMTPSA id 8D9C6C4B48; Tue, 3 Apr 2012 05:09:59 +0200 (CEST) Message-ID: <4F7A6A0B.5000308@semihalf.com> Date: Tue, 03 Apr 2012 05:10:03 +0200 From: Grzegorz Bernacki User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Marcel Moolenaar References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: geom@FreeBSD.org, fs@FreeBSD.org Subject: Re: Review of projects/nand branch X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2012 03:10:17 -0000 W dniu 2012-04-02 23:37, Marcel Moolenaar pisze: > Grzegorz, > > I reviewed the changes on the projects/nand branch and in general > it's of high quality and any problems, improvements and/or cleanups > can be addressed after it gets merged into -current, with the > following caveat: > 1. Changes to sys/kern, sys/geom and sys/sys should be reviewed and > approved by people on fs@freebsd.org and/or geom@freebsd.org. I > saw comments from pjd already for example. > 2. Please address the following points before merging onto head: > > o In include/Makefile: fs/fifofs is removed. Deliberate? > o In sbin/Makefile: we should have a distinct MK_NANDFS option > for use by the file system code. > o In sbin/nandfs/nandfs.8: could elaborate for what one could > use the snapshots. > o In sbin/nandfs/nandfs.h: define NANDFS_H. > o In sbin/nandfs/nandfs.c: usage() is wrong. > o In sbin/nandfs/Makefile: $FreeBSD$ is missing. > o In sbin/mount_nandfs/mount_nandfs.8: copyright notice seems > bogusly copied. Also, cleanerd is gone so it needs updating. > o In sbin/mount_nandfs/mount_nandfs.c: cleanerd is gone, so > this file could do with a some cleanups. > o In sbin/mount_nandfs/Makefile: $FreeBSD$ is missing. > o In sbin/mount/mntopts.h: cleanerd is gone, so should not be > needed anymore. > o In sbin/newfs_nandfs/newfs_nandfs.c: we have CRC32 code for > re-use. No need to implement again. > o In sbin/newfs_nandfs/Makefile: missing DPADD. > o In share/mk/bsd.own.mk: Add NANDFS as well. May also want to > add NANDSIM separately. > o In share/man/man5/Makefile: should be NANDFS. > o In usr.sbin/nandtool/Makefile: missing $FreeBSD$ > o In usr.sbin/nandsim/Makefile: missing $FreeBSD$ > o usr.sbin/Makefile should have nandtool and nandsim when > MK_NAND is defined. > o In lib/Makefile: should be MK_NANDFS; not MK_NAND. > o In lib/libstand/nandfs.c: should use common CRC32 impl. > o In lib/libstand/Makefile: should be MK_NANDFS; not MK_NAND. > o Please get buy-in for changes to sys/kern/vfs_vnops.c, > sys/kern/vfs_bio.c and sys/kern/vfs_subr.c from people > on fs@freebsd.org. > o In sys/modules/Makefile: always build nandfs module. Make > nandsim module dependent on MK_NAND or MK_NANDSIM if added. > o Please get buy-in for changes to sys/geom/geom_dev.c, > sys/geom/geom_disk.c, sys/geom/geom_disk.h, sys/geom/geom.h > and sys/geom/geom_slice.c from people on geom@freebsd.org. > o Please get buy-in for changes to sys/sys/disk.h and > sys/sys/bio.h from people on either fs@freebsd.org or > geom@freebsd.org. > > I also have a general usability question relating snapshots. > Currently snapshots are read-only. A useful feature in the > embedded space is to make a snapshot, attempt a software > update and revert to the snapshot if and when the update fails > or gets aborted. Is it possible to extend the snapshot feature > in the future to allow for this use case (i.e. ignore any and > all modifications that happened after a snapshot was made and > mount the snapshot R/W as representing the current/latest state > of the file system)? > > I'd like to thank Semihalf and the Foundation for bringing > this code into FreeBSD. Well done! > Thanks for the comments. We are going to get rid of all the changes in files from sys/geom, sys/sys, and sys/kern directories. Soon those changes will be merged into nand project branch. For the rest of your changes, let us go through them and then we will response to them. thanks, grzesiek From owner-freebsd-geom@FreeBSD.ORG Thu Apr 5 22:10:06 2012 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 41B6A106566B for ; Thu, 5 Apr 2012 22:10:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 12F1D8FC0A for ; Thu, 5 Apr 2012 22:10:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q35MA5Ow065890 for ; Thu, 5 Apr 2012 22:10:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q35MA5gt065889; Thu, 5 Apr 2012 22:10:05 GMT (envelope-from gnats) Date: Thu, 5 Apr 2012 22:10:05 GMT Message-Id: <201204052210.q35MA5gt065889@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Bengt Ahlgren Cc: Subject: Re: bin/165789: bsdlabel(8): partition c doesn't cover the whole unit! X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bengt Ahlgren List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2012 22:10:06 -0000 The following reply was made to PR bin/165789; it has been noted by GNATS. From: Bengt Ahlgren To: bug-followup@freebsd.org, jguojun@sbcglobal.net Cc: ae@freebsd.org Subject: Re: bin/165789: bsdlabel(8): partition c doesn't cover the whole unit! Date: Fri, 6 Apr 2012 00:05:39 +0200 I got the same message on my system newly upgraded to 8.3-RC1 (r232744). I have not touched the partitions since installing some time ago. I definitely did not get this message from bsdlabel before. It also was bsdlabel that created the partitions, but I don't remember from which OS version. I want to point out that the "c" partition does indeed cover the whole slice. See here: # gpart show ada1 => 63 1953525105 ada1 MBR (931G) 63 62926542 1 freebsd [active] (30G) 62926605 62926605 2 freebsd (30G) 125853210 1827671958 3 freebsd (871G) # gpart show ada1s1 => 0 62926542 ada1s1 BSD (30G) 0 16 - free - (8.0k) 16 2097152 1 freebsd-ufs (1.0G) 2097168 8388608 2 freebsd-swap (4.0G) 10485776 4194304 4 freebsd-ufs (2.0G) 14680080 48246462 5 freebsd-ufs (23G) # bsdlabel ada1s1 # /dev/ada1s1: 8 partitions: # size offset fstype [fsize bsize bps/cpg] a: 2097152 16 4.2BSD 0 0 0 b: 8388608 2097168 swap c: 62926542 0 unused 0 0 # "raw" part, don't edit d: 4194304 10485776 4.2BSD 0 0 0 e: 48246462 14680080 4.2BSD 0 0 0 bsdlabel: partition c doesn't cover the whole unit! bsdlabel: An incorrect partition c may cause problems for standard system utilities I added a printout of the value bsdlabel compares with: bsdlabel: partition c doesn't cover the whole unit! 1953525168 This number corresponds to the size of the whole disk, not the size of the slice, so lp->d_secperunit is not the right variable to use, or is incorrectly set. Finally, I stepped back to r220455 (in stable/8). That version of bsdlabel did not complain, so it seems that r227564 by ae (cc:d) is causing, or making visible, this problem. Bengt From owner-freebsd-geom@FreeBSD.ORG Fri Apr 6 04:36:47 2012 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 27A75106566C for ; Fri, 6 Apr 2012 04:36:47 +0000 (UTC) (envelope-from ae@FreeBSD.org) Received: from mail.kirov.so-ups.ru (mail.kirov.so-ups.ru [178.74.170.1]) by mx1.freebsd.org (Postfix) with ESMTP id C02888FC1D for ; Fri, 6 Apr 2012 04:36:46 +0000 (UTC) Received: from kas30pipe.localhost (localhost.kirov.so-ups.ru [127.0.0.1]) by mail.kirov.so-ups.ru (Postfix) with SMTP id 1F2E8B8029; Fri, 6 Apr 2012 08:36:40 +0400 (MSK) Received: from kirov.so-ups.ru (unknown [172.21.81.1]) by mail.kirov.so-ups.ru (Postfix) with ESMTP id 19DA8B8028; Fri, 6 Apr 2012 08:36:40 +0400 (MSK) Received: by ns.kirov.so-ups.ru (Postfix, from userid 1010) id 015CABA01C; Fri, 6 Apr 2012 08:36:40 +0400 (MSK) Received: from [127.0.0.1] (elsukov.kirov.oduur.so [10.118.3.52]) by ns.kirov.so-ups.ru (Postfix) with ESMTP id B1888BA008; Fri, 6 Apr 2012 08:36:39 +0400 (MSK) Message-ID: <4F7E72D7.6040501@FreeBSD.org> Date: Fri, 06 Apr 2012 08:36:39 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla Thunderbird 1.5 (FreeBSD/20051231) MIME-Version: 1.0 To: Bengt Ahlgren References: <201204052210.q35MA5gt065889@freefall.freebsd.org> In-Reply-To: <201204052210.q35MA5gt065889@freefall.freebsd.org> X-Enigmail-Version: 1.4 Content-Type: multipart/mixed; boundary="------------020200020100040002090800" X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0284], KAS30/Release X-SpamTest-Info: Not protected Cc: freebsd-geom@FreeBSD.org Subject: Re: bin/165789: bsdlabel(8): partition c doesn't cover the whole unit! X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2012 04:36:47 -0000 This is a multi-part message in MIME format. --------------020200020100040002090800 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit On 06.04.2012 2:10, Bengt Ahlgren wrote: > bsdlabel: partition c doesn't cover the whole unit! > bsdlabel: An incorrect partition c may cause problems for standard system utilities > > I added a printout of the value bsdlabel compares with: > > bsdlabel: partition c doesn't cover the whole unit! 1953525168 > > This number corresponds to the size of the whole disk, not the size of > the slice, so lp->d_secperunit is not the right variable to use, or is > incorrectly set. > > Finally, I stepped back to r220455 (in stable/8). That version of > bsdlabel did not complain, so it seems that r227564 by ae (cc:d) is > causing, or making visible, this problem. Hi, Thank you for your report. Yes, r227564 has made visible a known sysinstall's bug. GEOM_PART_BSD already has quirk that automatically fixes it, can you try attached patch? -- WBR, Andrey V. Elsukov --------------020200020100040002090800 Content-Type: text/plain; charset=windows-1251; name="bsdlabel.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="bsdlabel.diff" Index: head/sbin/bsdlabel/bsdlabel.c =================================================================== --- head/sbin/bsdlabel/bsdlabel.c (revision 233932) +++ head/sbin/bsdlabel/bsdlabel.c (working copy) @@ -1194,7 +1194,8 @@ checklabel(struct disklabel *lp) lp->d_interleave = vl->d_interleave; if (lp->d_secpercyl == 0) lp->d_secpercyl = vl->d_secpercyl; - if (lp->d_secperunit == 0) + if (lp->d_secperunit == 0 || /* Fix-up a sysinstall bug. */ + lp->d_secperunit > vl->d_secperunit) lp->d_secperunit = vl->d_secperunit; if (lp->d_bbsize == 0) lp->d_bbsize = vl->d_bbsize; --------------020200020100040002090800-- From owner-freebsd-geom@FreeBSD.ORG Fri Apr 6 14:26:42 2012 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 07CF81065670; Fri, 6 Apr 2012 14:26:42 +0000 (UTC) (envelope-from bengta@P142.sics.se) Received: from sink.sics.se (sink.sics.se [193.10.64.88]) by mx1.freebsd.org (Postfix) with ESMTP id 8078B8FC1A; Fri, 6 Apr 2012 14:26:41 +0000 (UTC) Received: from P142.sics.se (h139n3-u-d1.ias.bredband.telia.com [90.228.197.139]) by sink.sics.se (8.14.4/8.14.4) with ESMTP id q36DxF4g055237 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Apr 2012 15:59:15 +0200 (CEST) (envelope-from bengta@P142.sics.se) Received: from P142.sics.se (localhost [127.0.0.1]) by P142.sics.se (8.14.5/8.14.4) with ESMTP id q36Dxhqu002227; Fri, 6 Apr 2012 15:59:43 +0200 (CEST) (envelope-from bengta@P142.sics.se) Received: (from bengta@localhost) by P142.sics.se (8.14.5/8.14.5/Submit) id q36DxhDW002226; Fri, 6 Apr 2012 15:59:43 +0200 (CEST) (envelope-from bengta@P142.sics.se) From: Bengt Ahlgren To: "Andrey V. Elsukov" In-Reply-To: <4F7E72D7.6040501@FreeBSD.org> (Andrey V. Elsukov's message of "Fri, 06 Apr 2012 08:36:39 +0400") References: <201204052210.q35MA5gt065889@freefall.freebsd.org> <4F7E72D7.6040501@FreeBSD.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (berkeley-unix) Date: Fri, 06 Apr 2012 15:59:43 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-geom@FreeBSD.org Subject: Re: bin/165789: bsdlabel(8): partition c doesn't cover the whole unit! X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2012 14:26:42 -0000 "Andrey V. Elsukov" writes: > On 06.04.2012 2:10, Bengt Ahlgren wrote: >> bsdlabel: partition c doesn't cover the whole unit! >> bsdlabel: An incorrect partition c may cause problems for standard system utilities >> >> I added a printout of the value bsdlabel compares with: >> >> bsdlabel: partition c doesn't cover the whole unit! 1953525168 >> >> This number corresponds to the size of the whole disk, not the size of >> the slice, so lp->d_secperunit is not the right variable to use, or is >> incorrectly set. >> >> Finally, I stepped back to r220455 (in stable/8). That version of >> bsdlabel did not complain, so it seems that r227564 by ae (cc:d) is >> causing, or making visible, this problem. > > Hi, > > Thank you for your report. Yes, r227564 has made visible a known sysinstall's bug. > GEOM_PART_BSD already has quirk that automatically fixes it, can you try attached patch? The patch does fix the issue with bsdlabel - thanks! I am however curious to why you refer to a sysinstall bug. I did not use sysinstall to create the partitions. Bengt