From owner-freebsd-geom@FreeBSD.ORG Mon Apr 16 11:07:18 2012 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2BCA81065672 for ; Mon, 16 Apr 2012 11:07:18 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0B5DF8FC1B for ; Mon, 16 Apr 2012 11:07:17 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3GB7HDx022386 for ; Mon, 16 Apr 2012 11:07:17 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3GB7HWY022384 for freebsd-geom@FreeBSD.org; Mon, 16 Apr 2012 11:07:17 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 16 Apr 2012 11:07:17 GMT Message-Id: <201204161107.q3GB7HWY022384@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-geom@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-geom@FreeBSD.org X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2012 11:07:18 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- f bin/165789 geom bsdlabel(8): partition c doesn't cover the whole unit! o kern/165745 geom [geom] geom_multipath page fault on removed drive o kern/165428 geom [glabel][patch] Add xfs support to glabel o kern/164254 geom [geom] gjournal not stopping on GPT partitions o kern/164252 geom [geom] gjournal overflow o kern/164143 geom [geom] Partition table not recognized after upgrade R8 a kern/163020 geom [geli] [patch] enable the Camellia-XTS on GEOM ELI o kern/162010 geom [geli] panic: Provider's error should be set (error=0) o kern/161979 geom [geom] glabel doesn't update after newfs, and glabel s o kern/161752 geom [geom] glabel(8) doesn't get gpt label change o bin/161677 geom gpart(8) Probably bug in gptboot o kern/160562 geom [geom][patch] Allow to insert new component to geom_ra o kern/160409 geom [geli] failed to attach provider f kern/159595 geom [geom] [panic] panic on gmirror unload in vbox [regres p kern/158398 geom [headers] [patch] includes o kern/158197 geom [geom] geom_cache with size>1000 leads to panics o kern/157879 geom [libgeom] [regression] ABI change without version bump o kern/157863 geom [geli] kbdmux prevents geli passwords from being enter o kern/157739 geom [geom] GPT labels with geom_multipath o kern/157724 geom [geom] gpart(8) 'add' command must preserve gap for sc o kern/157723 geom [geom] GEOM should not process 'c' (raw) partitions fo o kern/157108 geom [gjournal] dumpon(8) fails on gjournal providers o kern/155994 geom [geom] Long "Suspend time" when reading large files fr o kern/154226 geom [geom] GEOM label does not change when you modify them o kern/150858 geom [geom] [geom_label] [patch] glabel(8) is not compatibl o kern/150626 geom [geom] [gjournal] gjournal(8) destroys label o kern/150555 geom [geom] gjournal unusable on GPT partitions o kern/150334 geom [geom] [udf] [patch] geom label does not support UDF o kern/149762 geom volume labels with rogue characters o bin/149215 geom [panic] [geom_part] gpart(8): Delete linux's slice via o kern/147667 geom [gmirror] Booting with one component of a gmirror, the o kern/145818 geom [geom] geom_stat_open showing cached information for n o kern/145042 geom [geom] System stops booting after printing message "GE o kern/143455 geom gstripe(8) in RELENG_8 (31st Jan 2010) broken o kern/142563 geom [geom] [hang] ioctl freeze in zpool o kern/141740 geom [geom] gjournal(8): g_journal_destroy concurrent error o kern/140352 geom [geom] gjournal + glabel not working o kern/135898 geom [geom] Severe filesystem corruption - large files or l o kern/134922 geom [gmirror] [panic] kernel panic when use fdisk on disk o kern/134113 geom [geli] Problem setting secondary GELI key o kern/133931 geom [geli] [request] intentionally wrong password to destr o bin/132845 geom [geom] [patch] ggated(8) does not close files opened a o bin/131415 geom [geli] keystrokes are unregulary sent to Geli when typ o kern/131353 geom [geom] gjournal(8) kernel lock o kern/129674 geom [geom] gjournal root did not mount on boot o kern/129645 geom gjournal(8): GEOM_JOURNAL causes system to fail to boo o kern/129245 geom [geom] gcache is more suitable for suffix based provid f kern/128276 geom [gmirror] machine lock up when gmirror module is used o kern/127420 geom [geom] [gjournal] [panic] Journal overflow on gmirrore o kern/124973 geom [gjournal] [patch] boot order affects geom_journal con o kern/124969 geom gvinum(8): gvinum raid5 plex does not detect missing s o kern/123962 geom [panic] [gjournal] gjournal (455Gb data, 8Gb journal), o kern/123122 geom [geom] GEOM / gjournal kernel lock o kern/122738 geom [geom] gmirror list "losts consumers" after gmirror de o kern/122067 geom [geom] [panic] Geom crashed during boot o kern/121364 geom [gmirror] Removing all providers create a "zombie" mir o kern/120091 geom [geom] [geli] [gjournal] geli does not prompt for pass o kern/115856 geom [geli] ZFS thought it was degraded when it should have o kern/115547 geom [geom] [patch] [request] let GEOM Eli get password fro o kern/114532 geom [geom] GEOM_MIRROR shows up in kldstat even if compile f kern/113957 geom [gmirror] gmirror is intermittently reporting a degrad o kern/113837 geom [geom] unable to access 1024 sector size storage o kern/113419 geom [geom] geom fox multipathing not failing back o kern/107707 geom [geom] [patch] [request] add new class geom_xbox360 to o kern/94632 geom [geom] Kernel output resets input while GELI asks for o kern/90582 geom [geom] [panic] Restore cause panic string (ffs_blkfree o bin/90093 geom fdisk(8) incapable of altering in-core geometry o kern/87544 geom [gbde] mmaping large files on a gbde filesystem deadlo o bin/86388 geom [geom] [geom_part] periodic(8) daily should backup gpa o kern/84556 geom [geom] [panic] GBDE-encrypted swap causes panic at shu o kern/79251 geom [2TB] newfs fails on 2.6TB gbde device o kern/79035 geom [vinum] gvinum unable to create a striped set of mirro o bin/78131 geom gbde(8) "destroy" not working. 73 problems total. From owner-freebsd-geom@FreeBSD.ORG Mon Apr 16 11:08:31 2012 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 42F16106564A for ; Mon, 16 Apr 2012 11:08:31 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from onlyone.friendlyhosting.spb.ru (onlyone.friendlyhosting.spb.ru [46.4.40.135]) by mx1.freebsd.org (Postfix) with ESMTP id F2D188FC29 for ; Mon, 16 Apr 2012 11:08:30 +0000 (UTC) Received: from lion.home.serebryakov.spb.ru (89.112.15.178.pppoe.eltel.net [89.112.15.178]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.friendlyhosting.spb.ru (Postfix) with ESMTPA id CE44F4AC1C; Mon, 16 Apr 2012 15:08:23 +0400 (MSK) Date: Mon, 16 Apr 2012 15:08:21 +0400 From: Lev Serebryakov Organization: FreeBSD X-Priority: 3 (Normal) Message-ID: <103630107.20120416150821@serebryakov.spb.ru> To: Robert Simmons In-Reply-To: References: <20120411093458.GC1319@garage.freebsd.pl> <4f864bb4.Q7/highsGaOoTKF6%perryh@pluto.rain.com> MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: quoted-printable Cc: freebsd-geom@freebsd.org Subject: Re: Automatic Geli? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lev@FreeBSD.org List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2012 11:08:31 -0000 Hello, Robert. You wrote 12 =E0=EF=F0=E5=EB=FF 2012 =E3., 20:24:25: > It will stop those who can figure out how???? It's a file in the > unencrypted portion of the image. "extracting" would entail "geli > attach -j /pathto/foo.pass -k /pathto/foo.key /dev/foo0" > There is no effort involved. And they are not "bypassing the > encryption" or "making offline access non-trivial". They are "doing > it wrong". > I'm not sure that anything you said makes sense. It makes perfect sense. If you know only Windows and use this "cache" CD in small office as some "black box", you cannot call "geli attach". You could read CD and even unpack "tar.gz" but nothing more. Any non-standard encryption, even with empty passphrase is adequate protection in such cases. --=20 // Black Lion AKA Lev Serebryakov t From owner-freebsd-geom@FreeBSD.ORG Mon Apr 16 11:11:26 2012 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 25DA8106564A for ; Mon, 16 Apr 2012 11:11:26 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from onlyone.friendlyhosting.spb.ru (onlyone.friendlyhosting.spb.ru [IPv6:2a01:4f8:131:60a2::2]) by mx1.freebsd.org (Postfix) with ESMTP id AEEE98FC18 for ; Mon, 16 Apr 2012 11:11:25 +0000 (UTC) Received: from lion.home.serebryakov.spb.ru (89.112.15.178.pppoe.eltel.net [89.112.15.178]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.friendlyhosting.spb.ru (Postfix) with ESMTPA id 8A0B34AC1C; Mon, 16 Apr 2012 15:11:24 +0400 (MSK) Date: Mon, 16 Apr 2012 15:11:22 +0400 From: Lev Serebryakov Organization: FreeBSD X-Priority: 3 (Normal) Message-ID: <11610157719.20120416151122@serebryakov.spb.ru> To: Robert Simmons In-Reply-To: References: <20120411093458.GC1319@garage.freebsd.pl> <4f864bb4.Q7/highsGaOoTKF6%perryh@pluto.rain.com> MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: quoted-printable Cc: freebsd-geom@freebsd.org Subject: Re: Automatic Geli? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lev@FreeBSD.org List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2012 11:11:26 -0000 Hello, Robert. You wrote 13 =E0=EF=F0=E5=EB=FF 2012 =E3., 3:10:44: > Fascinating. A blank passphrase. What's the point? To stop script-kiddies with Windows from reading sources of their ``know-how'' -- web UI for standard caching software, I belive. --=20 // Black Lion AKA Lev Serebryakov From owner-freebsd-geom@FreeBSD.ORG Mon Apr 16 23:26:42 2012 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8AFEF106564A for ; Mon, 16 Apr 2012 23:26:42 +0000 (UTC) (envelope-from rsimmons0@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 3A9348FC08 for ; Mon, 16 Apr 2012 23:26:42 +0000 (UTC) Received: by vbmv11 with SMTP id v11so5310522vbm.13 for ; Mon, 16 Apr 2012 16:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=mZc4Vw2Rnd23E83iw1BZVVqu+O5l5YzlFx0I/XaKViU=; b=x8r7HW0zp8PNhzSyhOHIHRpSOOkQ5lM8gAbZTo+NKsm6mKnHBpVxbg4SCsXndx9GBT 3QbgEqpoAxHYyPt0cNOalaYLHcIqKysYGDENcTxIK2SeexADvzLg/kHLTu/phk6+Q4Oy iUllfroLNu73272ttEapD0AH0e4QpfxGN8VBtpegAPHux9Uv54TOhaXrBzxZ0qC+KvgD FbOUg3DAziF/o6v9EJNM4dst8+5cWirKCA+CA32sGNMbEUlhrY8E4rKCgV9/mC3tO7zy 6MtNO9ACBMT1NP3lDex8Z1cESZe4rOeuaJo4olq6+4eFa8dXbygvFoamPlmrGgxhxGW7 fMaA== MIME-Version: 1.0 Received: by 10.52.95.42 with SMTP id dh10mr5705718vdb.37.1334618801626; Mon, 16 Apr 2012 16:26:41 -0700 (PDT) Received: by 10.52.66.239 with HTTP; Mon, 16 Apr 2012 16:26:41 -0700 (PDT) In-Reply-To: <103630107.20120416150821@serebryakov.spb.ru> References: <20120411093458.GC1319@garage.freebsd.pl> <4f864bb4.Q7/highsGaOoTKF6%perryh@pluto.rain.com> <103630107.20120416150821@serebryakov.spb.ru> Date: Mon, 16 Apr 2012 19:26:41 -0400 Message-ID: From: Robert Simmons To: freebsd-geom@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: Automatic Geli? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2012 23:26:42 -0000 On Mon, Apr 16, 2012 at 7:08 AM, Lev Serebryakov wrote: > Hello, Robert. > You wrote 12 =D0=B0=D0=BF=D1=80=D0=B5=D0=BB=D1=8F 2012 =D0=B3., 20:24:25: > >> It will stop those who can figure out how???? =C2=A0It's a file in the >> unencrypted portion of the image. =C2=A0"extracting" would entail "geli >> attach -j /pathto/foo.pass -k /pathto/foo.key /dev/foo0" > >> There is no effort involved. =C2=A0And they are not "bypassing the >> encryption" or "making offline access non-trivial". =C2=A0They are "doin= g >> it wrong". > >> I'm not sure that anything you said makes sense. > =C2=A0It makes perfect sense. If you know only Windows and use this "cach= e" > CD in small office as some "black box", you cannot call "geli > attach". You could read CD and even unpack "tar.gz" but nothing more. > Any non-standard encryption, even with empty passphrase is adequate > protection in such cases. Not intelligent. If it is meant as a cache in this case, and geli lets you setup a provider with a one time key for precisely this exact purpose, then using the software incorrectly is stupid. And, no, it's not adequate protection to use a blank passphrase. That too is stupid. You're making a bad argument. From owner-freebsd-geom@FreeBSD.ORG Mon Apr 16 23:37:14 2012 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DD856106564A for ; Mon, 16 Apr 2012 23:37:14 +0000 (UTC) (envelope-from rsimmons0@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9239A8FC12 for ; Mon, 16 Apr 2012 23:37:14 +0000 (UTC) Received: by vbmv11 with SMTP id v11so5314892vbm.13 for ; Mon, 16 Apr 2012 16:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=uB3i4hD4p8gmgD/ujmD8MvDMzjPBVH8UHCadQLb94xg=; b=a/QPyaDHsPa+NGaNmSIhlR3a+QFnj5NUW0REAT4DjtCh6uPtG/2yd+XqHSRP0MX368 s7NugZu4NFmIIUGwz7vGjygC8UiwCTj4OpX7hIHkYzJcGAhnLIfWhFZv1wWhqEyEZjam VjUesy4Wvrs17m1GJNcG7JYl1Ztggru7qXXhU+JmXf7EjrDsfTdqlmxf07vYtRxl9DS9 4j/N/UIPrm8TbcKfIEUOpC2TSjcjfNZqsRgo/EnILYg6qOcASKCv/JcqI5dYBX7ANwV9 Jdp4KgZUhUHIfQMu4Uha+baiudcAsNx8vbiHGHf6LBcLLPZll0FHpot7PvEvqlh+lc9F OR9A== MIME-Version: 1.0 Received: by 10.220.35.73 with SMTP id o9mr7546824vcd.74.1334619434166; Mon, 16 Apr 2012 16:37:14 -0700 (PDT) Received: by 10.52.66.239 with HTTP; Mon, 16 Apr 2012 16:37:14 -0700 (PDT) In-Reply-To: <11610157719.20120416151122@serebryakov.spb.ru> References: <20120411093458.GC1319@garage.freebsd.pl> <4f864bb4.Q7/highsGaOoTKF6%perryh@pluto.rain.com> <11610157719.20120416151122@serebryakov.spb.ru> Date: Mon, 16 Apr 2012 19:37:14 -0400 Message-ID: From: Robert Simmons To: freebsd-geom@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: Automatic Geli? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2012 23:37:14 -0000 On Mon, Apr 16, 2012 at 7:11 AM, Lev Serebryakov wrote: > Hello, Robert. > You wrote 13 =D0=B0=D0=BF=D1=80=D0=B5=D0=BB=D1=8F 2012 =D0=B3., 3:10:44: > >> Fascinating. =C2=A0A blank passphrase. =C2=A0What's the point? > =C2=A0To stop script-kiddies with Windows from reading sources of their > ``know-how'' -- web UI for standard caching software, I belive. Do you honestly believe that a company that is making a product should be worried about script kiddies with windows. HA! Properly implemented security has an added side effect of also keeping script kiddies out, but believe me, script kiddies should not be your target. If they are, then your product will fail. Examples: http://en.wikipedia.org/wiki/CueCat http://en.wikipedia.org/wiki/Content_Scramble_System History is littered with failed products that share your idea of security. From owner-freebsd-geom@FreeBSD.ORG Wed Apr 18 05:18:03 2012 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BBAB9106566B; Wed, 18 Apr 2012 05:18:03 +0000 (UTC) (envelope-from ae@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9068E8FC0A; Wed, 18 Apr 2012 05:18:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3I5I3p2055883; Wed, 18 Apr 2012 05:18:03 GMT (envelope-from ae@freefall.freebsd.org) Received: (from ae@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3I5I3o2055879; Wed, 18 Apr 2012 05:18:03 GMT (envelope-from ae) Date: Wed, 18 Apr 2012 05:18:03 GMT Message-Id: <201204180518.q3I5I3o2055879@freefall.freebsd.org> To: jguojun@sbcglobal.net, ae@FreeBSD.org, freebsd-geom@FreeBSD.org From: ae@FreeBSD.org Cc: Subject: Re: bin/165789: bsdlabel(8): partition c doesn't cover the whole unit! X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2012 05:18:03 -0000 Synopsis: bsdlabel(8): partition c doesn't cover the whole unit! State-Changed-From-To: feedback->closed State-Changed-By: ae State-Changed-When: Wed Apr 18 05:17:27 UTC 2012 State-Changed-Why: Fixed in head/, stable/9 and stable/8. Thanks! http://www.freebsd.org/cgi/query-pr.cgi?pr=165789 From owner-freebsd-geom@FreeBSD.ORG Wed Apr 18 05:20:05 2012 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05960106566C for ; Wed, 18 Apr 2012 05:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E550C8FC0A for ; Wed, 18 Apr 2012 05:20:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3I5K4rD056249 for ; Wed, 18 Apr 2012 05:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3I5K4rJ056248; Wed, 18 Apr 2012 05:20:04 GMT (envelope-from gnats) Date: Wed, 18 Apr 2012 05:20:04 GMT Message-Id: <201204180520.q3I5K4rJ056248@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: bin/165789: commit references a PR X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2012 05:20:05 -0000 The following reply was made to PR bin/165789; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: bin/165789: commit references a PR Date: Wed, 18 Apr 2012 05:16:12 +0000 (UTC) Author: ae Date: Wed Apr 18 05:16:02 2012 New Revision: 234410 URL: http://svn.freebsd.org/changeset/base/234410 Log: MFC r234122: It seems that libdisk(3) incorrectly sets d_secperunit value. Automatically fix it like GEOM_PART_BSD does. PR: bin/165789 Modified: stable/9/sbin/bsdlabel/bsdlabel.c Directory Properties: stable/9/sbin/bsdlabel/ (props changed) Modified: stable/9/sbin/bsdlabel/bsdlabel.c ============================================================================== --- stable/9/sbin/bsdlabel/bsdlabel.c Wed Apr 18 05:12:17 2012 (r234409) +++ stable/9/sbin/bsdlabel/bsdlabel.c Wed Apr 18 05:16:02 2012 (r234410) @@ -1194,7 +1194,8 @@ checklabel(struct disklabel *lp) lp->d_interleave = vl->d_interleave; if (lp->d_secpercyl == 0) lp->d_secpercyl = vl->d_secpercyl; - if (lp->d_secperunit == 0) + if (lp->d_secperunit == 0 || + lp->d_secperunit > vl->d_secperunit) lp->d_secperunit = vl->d_secperunit; if (lp->d_bbsize == 0) lp->d_bbsize = vl->d_bbsize; _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-geom@FreeBSD.ORG Wed Apr 18 05:20:07 2012 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 99399106564A for ; Wed, 18 Apr 2012 05:20:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 852D18FC0C for ; Wed, 18 Apr 2012 05:20:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3I5K7Rj056261 for ; Wed, 18 Apr 2012 05:20:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3I5K7IO056260; Wed, 18 Apr 2012 05:20:07 GMT (envelope-from gnats) Date: Wed, 18 Apr 2012 05:20:07 GMT Message-Id: <201204180520.q3I5K7IO056260@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: bin/165789: commit references a PR X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2012 05:20:07 -0000 The following reply was made to PR bin/165789; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: bin/165789: commit references a PR Date: Wed, 18 Apr 2012 05:16:28 +0000 (UTC) Author: ae Date: Wed Apr 18 05:16:20 2012 New Revision: 234411 URL: http://svn.freebsd.org/changeset/base/234411 Log: MFC r234122: It seems that libdisk(3) incorrectly sets d_secperunit value. Automatically fix it like GEOM_PART_BSD does. PR: bin/165789 Modified: stable/8/sbin/bsdlabel/bsdlabel.c Directory Properties: stable/8/sbin/bsdlabel/ (props changed) Modified: stable/8/sbin/bsdlabel/bsdlabel.c ============================================================================== --- stable/8/sbin/bsdlabel/bsdlabel.c Wed Apr 18 05:16:02 2012 (r234410) +++ stable/8/sbin/bsdlabel/bsdlabel.c Wed Apr 18 05:16:20 2012 (r234411) @@ -1187,7 +1187,8 @@ checklabel(struct disklabel *lp) lp->d_interleave = vl->d_interleave; if (lp->d_secpercyl == 0) lp->d_secpercyl = vl->d_secpercyl; - if (lp->d_secperunit == 0) + if (lp->d_secperunit == 0 || + lp->d_secperunit > vl->d_secperunit) lp->d_secperunit = vl->d_secperunit; if (lp->d_bbsize == 0) lp->d_bbsize = vl->d_bbsize; _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"