From owner-freebsd-net@FreeBSD.ORG Sun Jan 22 07:29:19 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 70807106566B for ; Sun, 22 Jan 2012 07:29:19 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 28CA98FC0C for ; Sun, 22 Jan 2012 07:29:18 +0000 (UTC) Received: by vcbfl17 with SMTP id fl17so1951858vcb.13 for ; Sat, 21 Jan 2012 23:29:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=JPn6blT3YaXhLXbItrEOrqfVLM0WvapPEOcrsgF/Wxs=; b=uqflAVJ4osyiMuRBRLbq1x+QrJZYISqkhUE+yPyYb6EnDX1l4P+zUYqw1W26nSDem8 WHoMOCHsSBmvkj1zA6jHH10n8TJ1udI+WYXKuk0+0aUGXgwUh+6zv0Mug6Qwcj+w9VJD 5sWHtiijVbTNhYbshafl6fJiFhkmz5/CgPWfA= MIME-Version: 1.0 Received: by 10.220.156.134 with SMTP id x6mr2112064vcw.17.1327217356933; Sat, 21 Jan 2012 23:29:16 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.36.5 with HTTP; Sat, 21 Jan 2012 23:29:16 -0800 (PST) In-Reply-To: <4F1ABF9C.5010608@gmx.com> References: <4F1ABF9C.5010608@gmx.com> Date: Sat, 21 Jan 2012 23:29:16 -0800 X-Google-Sender-Auth: 1MZ00kHebbQbyedoXMmpwkwwrIs Message-ID: From: Adrian Chadd To: Nikos Vassiliadis Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-net@freebsd.org Subject: Re: STP id selection X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jan 2012 07:29:19 -0000 On 21 January 2012 05:37, Nikos Vassiliadis wrote: > Hi, > > The current code in bridgestp.c finds the lower MAC address from all > available ethernets and uses it as the STP id. This is problematic when > more than one STP bridges participate in the same STP domain because > more than one bridges will use the same id. A similar fix was applied > to the OpenBSD version of the code[1]. Could you review the attached > patch? > > 1.http://www.openbsd.org/cgi-**bin/cvsweb/src/sys/net/** > bridgestp.c?rev=1.33 > > Thanks, Nikos > > .. that sounds sensible enough. Sure, please create a PR and then tell me what the ID is. I keep finding myself knee deep in the bridge code so this is something I can test out locally. Adrian