Date: Sun, 18 Mar 2012 05:06:47 +0000 From: "Schmehl, Paul L" <pauls@utdallas.edu> To: Steve Wills <swills@FreeBSD.org> Cc: "perl@FreeBSD.org" <perl@FreeBSD.org> Subject: RE: ports/165826: [PATCH] net/p5-Net-Nessus-XMLRPC: add missing DEPENDS Message-ID: <C18603D41186F047B761885262E39F452C7F84@UTDEX23.campus.ad.utdallas.edu> In-Reply-To: <4F6515CC.8000807@FreeBSD.org> References: <201203071740.q27HeCFT018574@freefall.freebsd.org>, <4F6515CC.8000807@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
________________________________________=0A= From: Steve Wills [swills@FreeBSD.org]=0A= Sent: Saturday, March 17, 2012 5:53 PM=0A= To: Schmehl, Paul L=0A= Cc: perl@FreeBSD.org=0A= Subject: Re: ports/165826: [PATCH] net/p5-Net-Nessus-XMLRPC: add missing DE= PENDS=0A= =0A= On 03/07/12 12:40, Paul Schmehl wrote:=0A= >=0A= > According to the CPAN page=0A= > (<http://search.cpan.org/~kost/Net-Nessus-XMLRPC-0.30/lib/Net/Nessus/XML= RPC.pm>),=0A= > only IO::Socket::SSL is required (and in FreeBSD, Net::SSL is a RUN_DEPE= NDS=0A= > for IO::Socket::SSL. anyway.)=0A= >=0A= > "'This CPAN module uses LWP for communicating with Nessus over XMLRPC vi= a=0A= > https. Therefore, make sure that you have Net::SSL (provided by=0A= > Crypt::SSLeay): http://search.cpan.org/perldoc?Crypt::SSLeay or=0A= > IO::Socket::SSL: http://search.cpan.org/perldoc?IO::Socket::SSL"=0A= >=0A= > If you want to argue that LWP is a RUN_DEPENDS, I can see that, but why= =0A= > HTML::Message and XML::Simple? Why does the author think these other=0A= > modules are required?=0A= >=0A= > I need more information before making this change.=0A= =0A= Unfortunately, the documentation doesn't match the code. I found these=0A= by running "make test" with just the package installed (in a chroot).=0A= Looking at the code:=0A= =0A= ./work/Net-Nessus-XMLRPC-0.30/lib/Net/Nessus/XMLRPC.pm:use=0A= HTTP::Request::Common;=0A= =0A= hence the dep on HTML::Message. Similarly:=0A= =0A= ./work/Net-Nessus-XMLRPC-0.30/lib/Net/Nessus/XMLRPC.pm:use XML::Simple;=0A= =0A= hence the dep on XML::Simple.=0A= =0A= > Even if these other modules were required, they wouldn't be BUILD_DEPEND= S,=0A= > they would be RUN_DEPENDS, so the patch would need to be corrected for t= hat.=0A= =0A= The "build" will complain that these modules are missing at build time:=0A= =0A= =3D=3D=3D> Configuring for p5-Net-Nessus-XMLRPC-0.30=0A= Warning: prerequisite HTTP::Request::Common 0 not found.=0A= Warning: prerequisite LWP::UserAgent 0 not found.=0A= Warning: prerequisite XML::Simple 0 not found.=0A= =0A= I like to avoid those warnings so that if, for example, an update to the=0A= module requires a new module I can see it easily instead of comparing=0A= that list to the RUN_DEPENDS to see if any are missing.=0A= =0A= >From a package standpoint it makes no difference if they're also=0A= BUILD_DEPENDS because they're going to be RUN_DEPENDS anyway and from a=0A= ports (building from source) perspective, it's cleaner, easier to see=0A= new depends, let's you run "make test" if you want and less worrisome=0A= for the uninformed.=0A= =0A= Steve=0A= =0A= Makes perfect sense. I approve the changes.=0A=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C18603D41186F047B761885262E39F452C7F84>