From owner-freebsd-perl@FreeBSD.ORG Mon Sep 3 11:14:26 2012 Return-Path: Delivered-To: perl@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C2B37106566B for ; Mon, 3 Sep 2012 11:14:26 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AD8258FC1E for ; Mon, 3 Sep 2012 11:14:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q83BEQb7092454 for ; Mon, 3 Sep 2012 11:14:26 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q83BEObL092108 for perl@FreeBSD.org; Mon, 3 Sep 2012 11:14:24 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 3 Sep 2012 11:14:24 GMT Message-Id: <201209031114.q83BEObL092108@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: perl@FreeBSD.org Cc: Subject: Current problem reports assigned to perl@FreeBSD.org X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2012 11:14:26 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o ports/171217 perl audio/pacpl: remove deprecated kdebase component o ports/171164 perl New port: www/p5-Nginx-Simple o ports/170802 perl [PATCH] audio/pacpl: fix AMAROK ports option o ports/169024 perl [PATCH] security/p5-GD-SecurityImage: fix dependency o o ports/168620 perl security/p5-GSSAPI build fails with heimdal port in ja o ports/167134 perl [port update] from devel/p5-doxygenfilter to devel/p5- 6 problems total. From owner-freebsd-perl@FreeBSD.ORG Wed Sep 5 08:42:19 2012 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 196711065675; Wed, 5 Sep 2012 08:42:19 +0000 (UTC) (envelope-from 5u623l20@gmail.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id AA2548FC08; Wed, 5 Sep 2012 08:42:18 +0000 (UTC) Received: by vcbgb30 with SMTP id gb30so432702vcb.13 for ; Wed, 05 Sep 2012 01:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=QnVZLcBVsA7/GpaDbIeL0HVNeayiD8coIb8M8cMjCis=; b=ulAPMmuw57Fw5q3q5Bn/zvU6VNK0Agekm79r+sREGuJbM58JTy1pAMHnQoOcyhBUAC ZHysT7StM6PuD7gQT10NEfwi5uY+JJ6zCHzO06yoqm/X/YiMIcrZOgxLvg1un4NsWan6 B4RSFIxNNW+f8jQjESgEKSUDfQGIew66OH0GMI7Eu4VuBozYQr94MMSmjEVqrx8hYQ6B md1GeDdR/+oTpzstThe2igo9SXYTZSScCN/48eW7PgVm16CmMSg/tKu+ruY07z1Pz+07 7cHu+F0uV2heGKO1mNMfHVKxKNfK2+xqi5nn/5CIv9EV69z3YCsAW9J7WXKOG2QVjwZp va7A== MIME-Version: 1.0 Received: by 10.52.16.239 with SMTP id j15mr15172270vdd.7.1346834537964; Wed, 05 Sep 2012 01:42:17 -0700 (PDT) Received: by 10.59.5.7 with HTTP; Wed, 5 Sep 2012 01:42:17 -0700 (PDT) In-Reply-To: <201208221246.q7MCkZTr000934@freefall.freebsd.org> References: <201208221246.q7MCkZTr000934@freefall.freebsd.org> Date: Wed, 5 Sep 2012 14:42:17 +0600 Message-ID: From: Muhammad Moinur Rahman <5u623l20@gmail.com> To: swills@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: perl@freebsd.org Subject: Re: ports/170840: [patch] update www/p5-Mason to latest version X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2012 08:42:19 -0000 Approved On Wed, Aug 22, 2012 at 6:46 PM, wrote: > Synopsis: [patch] update www/p5-Mason to latest version > > Responsible-Changed-From-To: perl->swills > Responsible-Changed-By: swills > Responsible-Changed-When: Wed Aug 22 12:46:34 UTC 2012 > Responsible-Changed-Why: > I'll take it. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=170840 > From owner-freebsd-perl@FreeBSD.ORG Wed Sep 5 08:47:29 2012 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B51E106566C; Wed, 5 Sep 2012 08:47:29 +0000 (UTC) (envelope-from 5u623l20@gmail.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 289458FC18; Wed, 5 Sep 2012 08:47:28 +0000 (UTC) Received: by vcbgb30 with SMTP id gb30so440758vcb.13 for ; Wed, 05 Sep 2012 01:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ariTE0qZStwwIaewkUF3zSvXk5ERkuqwBB+yrplACJs=; b=mct853bP/Yo/Lecm4t9XLQWMzvIxQUCvLnuf5BnJh1w6uM17K57If4TZEk9NDfjpS4 TAS1Ds+IdxKm0JW8CUQHW3xtfSgAGCpF5WeymZmHEiy+DsrtRl9TDKt/vu5+R5xCXTjO kGmacY7/HZSU3g0U98u0ZDPrC22oGWuEsAhkGa8f13g+Uv0n9QgomBGYfwtN/B8uoVzs NIiV7iMZ13t+M2Q5SOjzAWgphEcT3ugII8TaBvMzq/ZoTdTCkZq1rjUgQDxhiuIrOsWx s4nQviaNQsgZD9488xWB9MeXwuGU/uaPf6JZJ8lHHBGmu6MSDBWjZqPwvffESL+bHwU5 pHpA== MIME-Version: 1.0 Received: by 10.59.1.162 with SMTP id bh2mr20376233ved.13.1346834848350; Wed, 05 Sep 2012 01:47:28 -0700 (PDT) Received: by 10.59.5.7 with HTTP; Wed, 5 Sep 2012 01:47:28 -0700 (PDT) In-Reply-To: <201208221246.q7MCkSuV000831@freefall.freebsd.org> References: <201208221246.q7MCkSuV000831@freefall.freebsd.org> Date: Wed, 5 Sep 2012 14:47:28 +0600 Message-ID: From: Muhammad Moinur Rahman <5u623l20@gmail.com> To: swills@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: perl@freebsd.org Subject: Re: ports/170839: [patch] Fix plist for devel/p5-Test-Class-Most X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2012 08:47:29 -0000 There is a problem with this. Let us suppose that the mentioned PLIST_DIRS have other files by other packages like p5-Test-Class-*. So in that case we will have to move for pkg-plist files. Waiting for your feedback. Regards, Muhammad On Wed, Aug 22, 2012 at 6:46 PM, wrote: > Synopsis: [patch] Fix plist for devel/p5-Test-Class-Most > > Responsible-Changed-From-To: perl->swills > Responsible-Changed-By: swills > Responsible-Changed-When: Wed Aug 22 12:46:28 UTC 2012 > Responsible-Changed-Why: > I'll take it. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=170839 > From owner-freebsd-perl@FreeBSD.ORG Wed Sep 5 16:47:29 2012 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B91631065688 for ; Wed, 5 Sep 2012 16:47:29 +0000 (UTC) (envelope-from web@umich.edu) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 2D32A8FC14 for ; Wed, 5 Sep 2012 16:47:28 +0000 (UTC) Received: by iayy25 with SMTP id y25so1309237iay.13 for ; Wed, 05 Sep 2012 09:47:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent:x-gm-message-state; bh=Hxp7TkgD+k/t9nFjGAA/RaN6Jh3ViM7TBU5Hu5oH8hI=; b=NU8cgccAWpsYhlAy+HiZ6OuIyFRFj5DBMd1DubwDfxfbMxQIVZmxttrNAokYiCe+0D +LDmmtRZSxhlHS/ECsFJ5r7rws5mWkR4bl0n44kWAnMFvwX+dwcLQxrXEIOvhWR/xZIa DcbnfW+vkcUoGwzLCZK8bm8AHjZ9FLO7L78QyeiV7FhuGX923DeETFH5aNE5w1veMicP 178M8TrCIM/ZWZcQpms+PMnXIJbAvhzg5fDhZ6Yasg+cHZfv8Ppw7oc0+3Y9AXhtRQVf k7zq1AQPMCZvcUzUQlAtzBAL5g/FVgUU6ry1tDFp1LsRFRgJZGqR5ymX62YaISnHKtqS kYyA== Received: by 10.42.163.135 with SMTP id c7mr8872460icy.45.1346863648546; Wed, 05 Sep 2012 09:47:28 -0700 (PDT) Received: from localhost (itcom245.staff.itd.umich.edu. [141.213.135.249]) by mx.google.com with ESMTPS id ud8sm4125070igb.4.2012.09.05.09.47.27 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 05 Sep 2012 09:47:27 -0700 (PDT) Date: Wed, 5 Sep 2012 12:47:26 -0400 From: William Bulley To: perl@FreeBSD.org Message-ID: <20120905164726.GS1621@itcom245.staff.itd.umich.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="6c2NcOVqGQ03X4Wi" Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQmW+12a1apD1i9HovSSvrUKqMh1reOtkTXDI+F2s0gWdpgNWNYb0Qb0BsLXCT8u3Dwe2KOu Cc: ports@FreeBSD.org Subject: FreeBSD Port: p5-DBD-Oracle-1.14_3 X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2012 16:47:29 -0000 --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline /usr/ports/databases/p5-DBD-Oracle was marked as "broken" five weeks ago (as of this writing). I commented out the "broken" directive in the Makefile and found that it was indeed "broken" but I know I had made this port from source in the past, and I recalled the error messages I was seeing today, and I recalled (roughly) what it was I had done in the past to make the port build and install. I don't submit bug reports (and perhaps I should) but here is my poor man's way of submitting my patch diffs for databases/p5-DBD-Oracle: I have attached a text file of context diffs and included it here: --- Oracle.c.orig 2012-09-05 11:59:43.000000000 -0400 +++ Oracle.c 2012-09-05 12:12:04.000000000 -0400 @@ -1493,11 +1493,11 @@ XS_EUPXS(XS_DBD__Oracle__st_ora_execute_array); /* prototype to pass -Wmissing-prototypes */ XS_EUPXS(XS_DBD__Oracle__st_ora_execute_array) { dVAR; dXSARGS; if (items < 4 || items > 5) - croak_xs_usage(cv, "sth, tuples, exe_count, tuples_status, cols=&sv_undef"); + croak_xs_usage(cv, "sth, tuples, exe_count, tuples_status, cols=&PL_sv_undef"); { SV * sth = ST(0) ; SV * tuples = ST(1) ; @@ -1510,11 +1510,11 @@ D_imp_sth(sth); int retval; #line 1513 "Oracle.c" if (items < 5) - cols = &sv_undef; + cols = &PL_sv_undef; else { cols = ST(4) ; } #line 127 "Oracle.xs" @@ -1547,11 +1547,11 @@ { SV * sth = ST(0) ; #line 147 "Oracle.xs" D_imp_sth(sth); - ST(0) = dbd_st_cancel(sth, imp_sth) ? &sv_yes : &sv_no; + ST(0) = dbd_st_cancel(sth, imp_sth) ? &PL_sv_yes : &PL_sv_no; #line 1554 "Oracle.c" } XSRETURN(1); } @@ -1569,11 +1569,11 @@ ; char * pwd = (char *)SvPV_nolen(ST(2)) ; #line 159 "Oracle.xs" D_imp_dbh(dbh); - ST(0) = ora_db_reauthenticate(dbh, imp_dbh, uid, pwd) ? &sv_yes : &sv_no; + ST(0) = ora_db_reauthenticate(dbh, imp_dbh, uid, pwd) ? &PL_sv_yes : &PL_sv_no; #line 1576 "Oracle.c" } XSRETURN(1); } @@ -1621,19 +1621,19 @@ /* added by lab: */ /* LAB do something about length here? see above comment */ OCILobCharSetForm_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csform, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetForm"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #ifdef OCI_ATTR_CHARSET_ID /* Effectively only used so AL32UTF8 works properly */ OCILobCharSetId_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csid, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetId"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #endif /* OCI_ATTR_CHARSET_ID */ /* if data is utf8 but charset isn't then switch to utf8 csid */ csid = (SvUTF8(data) && !CS_IS_UTF8(csid)) ? utf8_csid : CSFORM_IMPLIED_CSID(csform); @@ -1643,14 +1643,14 @@ bufp, (ub4)data_len, OCI_ONE_PIECE, NULL, NULL, (ub2)0, csform , status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobWrite"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } #line 1654 "Oracle.c" } XSRETURN(1); } @@ -1700,19 +1700,19 @@ /* added by lab: */ /* LAB do something about length here? see above comment */ OCILobCharSetForm_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csform, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetForm"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #ifdef OCI_ATTR_CHARSET_ID /* Effectively only used so AL32UTF8 works properly */ OCILobCharSetId_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csid, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetId"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #endif /* OCI_ATTR_CHARSET_ID */ /* if data is utf8 but charset isn't then switch to utf8 csid */ csid = (SvUTF8(data) && !CS_IS_UTF8(csid)) ? utf8_csid : CSFORM_IMPLIED_CSID(csform); @@ -1721,20 +1721,20 @@ &amtp, bufp, (ub4)data_len, OCI_ONE_PIECE, NULL, NULL, csid, csform, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobWriteAppend"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } #else OCILobGetLength_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &startp, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobGetLength"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { /* start one after the end -- the first position in the LOB is 1 */ startp++; if (DBIS->debug >= 2 ) PerlIO_printf(DBILOGFP, " Calling OCILobWrite with csid=%d csform=%d\n",csid, csform ); @@ -1743,14 +1743,14 @@ bufp, (ub4)data_len, OCI_ONE_PIECE, NULL, NULL, csid, csform , status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobWrite"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } } #endif #line 1756 "Oracle.c" } @@ -1803,20 +1803,20 @@ /* if (0 && SvUTF8(dest_sv) && !IN_BYTES) { amtp = sv_len_utf8(dest_sv); } */ /* added by lab: */ OCILobCharSetForm_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csform, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetForm"); - dest_sv = &sv_undef; + dest_sv = &PL_sv_undef; return; } OCILobRead_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &amtp, (ub4)offset, /* offset starts at 1 */ bufp, (ub4)bufp_len, 0, 0, (ub2)0, csform, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobRead"); - dest_sv = &sv_undef; + dest_sv = &PL_sv_undef; } else { SvCUR(dest_sv) = amtp; /* always bytes here */ *SvEND(dest_sv) = '\0'; if (CSFORM_IMPLIES_UTF8(csform)) @@ -1858,14 +1858,14 @@ ; #line 353 "Oracle.xs" OCILobTrim_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, length, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobTrim"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } #line 1869 "Oracle.c" } XSRETURN(1); } @@ -1898,11 +1898,11 @@ ; #line 371 "Oracle.xs" OCILobGetLength_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &len, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobTrim"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { ST(0) = sv_2mortal(newSVuv(len)); } #line 1909 "Oracle.c" --- Oracle.xs.orig 2006-10-02 08:08:50.000000000 -0400 +++ Oracle.xs 2012-09-05 12:09:06.000000000 -0400 @@ -112,11 +112,11 @@ if (debug >= 2 && SvTRUE(DBIc_ERR(imp_sth))) PerlIO_printf(DBILOGFP, " !! ERROR: %s %s", neatsvpv(DBIc_ERR(imp_sth),0), neatsvpv(DBIc_ERRSTR(imp_sth),0)); void -ora_execute_array(sth, tuples, exe_count, tuples_status, cols=&sv_undef) +ora_execute_array(sth, tuples, exe_count, tuples_status, cols=&PL_sv_undef) SV * sth SV * tuples IV exe_count SV * tuples_status SV * cols @@ -143,11 +143,11 @@ void cancel(sth) SV * sth CODE: D_imp_sth(sth); - ST(0) = dbd_st_cancel(sth, imp_sth) ? &sv_yes : &sv_no; + ST(0) = dbd_st_cancel(sth, imp_sth) ? &PL_sv_yes : &PL_sv_no; MODULE = DBD::Oracle PACKAGE = DBD::Oracle::db void @@ -155,11 +155,11 @@ SV * dbh char * uid char * pwd CODE: D_imp_dbh(dbh); - ST(0) = ora_db_reauthenticate(dbh, imp_dbh, uid, pwd) ? &sv_yes : &sv_no; + ST(0) = ora_db_reauthenticate(dbh, imp_dbh, uid, pwd) ? &PL_sv_yes : &PL_sv_no; void ora_lob_write(dbh, locator, offset, data) SV *dbh OCILobLocator *locator @@ -183,19 +183,19 @@ /* added by lab: */ /* LAB do something about length here? see above comment */ OCILobCharSetForm_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csform, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetForm"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #ifdef OCI_ATTR_CHARSET_ID /* Effectively only used so AL32UTF8 works properly */ OCILobCharSetId_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csid, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetId"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #endif /* OCI_ATTR_CHARSET_ID */ /* if data is utf8 but charset isn't then switch to utf8 csid */ csid = (SvUTF8(data) && !CS_IS_UTF8(csid)) ? utf8_csid : CSFORM_IMPLIED_CSID(csform); @@ -205,14 +205,14 @@ bufp, (ub4)data_len, OCI_ONE_PIECE, NULL, NULL, (ub2)0, csform , status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobWrite"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } void ora_lob_append(dbh, locator, data) SV *dbh @@ -239,19 +239,19 @@ /* added by lab: */ /* LAB do something about length here? see above comment */ OCILobCharSetForm_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csform, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetForm"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #ifdef OCI_ATTR_CHARSET_ID /* Effectively only used so AL32UTF8 works properly */ OCILobCharSetId_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csid, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetId"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #endif /* OCI_ATTR_CHARSET_ID */ /* if data is utf8 but charset isn't then switch to utf8 csid */ csid = (SvUTF8(data) && !CS_IS_UTF8(csid)) ? utf8_csid : CSFORM_IMPLIED_CSID(csform); @@ -260,20 +260,20 @@ &amtp, bufp, (ub4)data_len, OCI_ONE_PIECE, NULL, NULL, csid, csform, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobWriteAppend"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } #else OCILobGetLength_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &startp, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobGetLength"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { /* start one after the end -- the first position in the LOB is 1 */ startp++; if (DBIS->debug >= 2 ) PerlIO_printf(DBILOGFP, " Calling OCILobWrite with csid=%d csform=%d\n",csid, csform ); @@ -282,14 +282,14 @@ bufp, (ub4)data_len, OCI_ONE_PIECE, NULL, NULL, csid, csform , status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobWrite"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } } #endif @@ -319,20 +319,20 @@ /* if (0 && SvUTF8(dest_sv) && !IN_BYTES) { amtp = sv_len_utf8(dest_sv); } */ /* added by lab: */ OCILobCharSetForm_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csform, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetForm"); - dest_sv = &sv_undef; + dest_sv = &PL_sv_undef; return; } OCILobRead_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &amtp, (ub4)offset, /* offset starts at 1 */ bufp, (ub4)bufp_len, 0, 0, (ub2)0, csform, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobRead"); - dest_sv = &sv_undef; + dest_sv = &PL_sv_undef; } else { SvCUR(dest_sv) = amtp; /* always bytes here */ *SvEND(dest_sv) = '\0'; if (CSFORM_IMPLIES_UTF8(csform)) @@ -351,14 +351,14 @@ sword status; CODE: OCILobTrim_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, length, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobTrim"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } void ora_lob_length(dbh, locator) SV *dbh @@ -369,11 +369,11 @@ ub4 len = 0; CODE: OCILobGetLength_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &len, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobTrim"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { ST(0) = sv_2mortal(newSVuv(len)); } --- dbdimp.c.orig 2006-11-03 09:05:46.000000000 -0500 +++ dbdimp.c 2012-09-05 12:16:19.000000000 -0400 @@ -188,11 +188,11 @@ dbd_discon_all(SV *drh, imp_drh_t *imp_drh) { dTHR; /* The disconnect_all concept is flawed and needs more work */ - if (!dirty && !SvTRUE(perl_get_sv("DBI::PERL_ENDING",0))) { + if (!PL_dirty && !SvTRUE(perl_get_sv("DBI::PERL_ENDING",0))) { DBIh_SET_ERR_CHAR(drh, (imp_xxh_t*)imp_drh, Nullch, 1, "disconnect_all not implemented", Nullch, Nullch); return FALSE; } return FALSE; } @@ -902,11 +902,11 @@ SV **svp = hv_fetch((HV*)SvRV(dbh), key, kl, 1); sv_free(*svp); *svp = retsv; (void)SvREFCNT_inc(retsv); /* so sv_2mortal won't free it */ } - if (retsv == &sv_yes || retsv == &sv_no) + if (retsv == &PL_sv_yes || retsv == &PL_sv_no) return retsv; /* no need to mortalize yes or no */ return sv_2mortal(retsv); } @@ -937,11 +937,11 @@ /* initialise phs ready to be cloned per placeholder */ memset(&phs_tpl, 0, sizeof(phs_tpl)); phs_tpl.imp_sth = imp_sth; phs_tpl.ftype = imp_dbh->ph_type; phs_tpl.csform = imp_dbh->ph_csform; - phs_tpl.sv = &sv_undef; + phs_tpl.sv = &PL_sv_undef; src = statement; dest = imp_sth->statement; while(*src) { @@ -1102,11 +1102,11 @@ at_exec = (phs->desc_h == NULL); if (!SvPOK(phs->sv)) { /* normalizations for special cases */ if (SvOK(phs->sv)) { /* ie a number, convert to string ASAP */ if (!(SvROK(phs->sv) && phs->is_inout)) - sv_2pv(phs->sv, &na); + sv_2pv(phs->sv, &PL_na); } else /* ensure we're at least an SVt_PV (so SvPVX etc work) */ SvUPGRADE(phs->sv, SVt_PV); } @@ -1497,11 +1497,11 @@ phs_svp = hv_fetch(imp_sth->all_params_hv, name, name_len, 0); if (phs_svp == NULL) croak("Can't bind unknown placeholder '%s' (%s)", name, neatsvpv(ph_namesv,0)); phs = (phs_t*)(void*)SvPVX(*phs_svp); /* placeholder struct */ - if (phs->sv == &sv_undef) { /* first bind for this placeholder */ + if (phs->sv == &PL_sv_undef) { /* first bind for this placeholder */ phs->is_inout = is_inout; if (is_inout) { /* phs->sv assigned in the code below */ ++imp_sth->has_inout_params; /* build array of phs's so we can deal with out vars fast */ @@ -1560,15 +1560,15 @@ } phs->maxlen = maxlen; /* 0 if not inout */ if (!is_inout) { /* normal bind so take a (new) copy of current value */ - if (phs->sv == &sv_undef) /* (first time bind) */ + if (phs->sv == &PL_sv_undef) /* (first time bind) */ phs->sv = newSV(0); sv_setsv(phs->sv, newvalue); if (SvAMAGIC(phs->sv)) /* overloaded. XXX hack, logic ought to be pushed deeper */ - sv_pvn_force(phs->sv, &na); + sv_pvn_force(phs->sv, &PL_na); } else if (newvalue != phs->sv) { if (phs->sv) SvREFCNT_dec(phs->sv); phs->sv = SvREFCNT_inc(newvalue); /* point to live var */ @@ -1833,11 +1833,11 @@ static void init_bind_for_array_exec(phs) phs_t *phs; { - if (phs->sv == &sv_undef) { /* first bind for this placeholder */ + if (phs->sv == &PL_sv_undef) { /* first bind for this placeholder */ phs->is_inout = 0; phs->maxlen = 1; /* treat Oracle7 SQLT_CUR as SQLT_RSET for Oracle8 */ if (phs->ftype==102) phs->ftype = 116; @@ -2164,11 +2164,11 @@ for(i=0; i < num_fields; ++i) { imp_fbh_t *fbh = &imp_sth->fbh[i]; if (fbh->fetch_cleanup) fbh->fetch_cleanup(sth, fbh); } - if (dirty) /* don't walk on the wild side */ + if (PL_dirty) /* don't walk on the wild side */ return 1; if (!DBIc_ACTIVE(imp_dbh)) /* no longer connected */ return 1; @@ -2242,14 +2242,14 @@ when they are no longer needed. */ if (DBIc_DBISTATE(imp_sth)->debug >= 6) PerlIO_printf(DBIc_LOGPIO(imp_sth), " dbd_st_destroy %s\n", - (dirty) ? "(OCIHandleFree skipped during global destruction)" : + (PL_dirty) ? "(OCIHandleFree skipped during global destruction)" : (imp_sth->nested_cursor) ?"(OCIHandleFree skipped for nested cursor)" : ""); - if (!dirty) { /* XXX not ideal, leak may be a problem in some cases */ + if (!PL_dirty) { /* XXX not ideal, leak may be a problem in some cases */ if (!imp_sth->nested_cursor) { OCIHandleFree_log_stat(imp_sth->stmhp, OCI_HTYPE_STMT, status); if (status != OCI_SUCCESS) oci_error(sth, imp_sth->errhp, status, "OCIHandleFree"); } @@ -2280,11 +2280,11 @@ SV *sv; char *key; I32 retlen; hv_iterinit(hv); while( (sv = hv_iternextsv(hv, &key, &retlen)) != NULL ) { - if (sv != &sv_undef) { + if (sv != &PL_sv_undef) { phs_t *phs = (phs_t*)(void*)SvPVX(sv); if (phs->desc_h && phs->desc_t == OCI_DTYPE_LOB) ora_free_templob(sth, imp_sth, (OCILobLocator*)phs->desc_h); @@ -2340,11 +2340,11 @@ STRLEN lna; /* dbd_describe has already called ora_error() */ /* we can't return Nullsv here because the xs code will */ /* then just pass the attribute name to DBI for FETCH. */ croak("Describe failed during %s->FETCH(%s): %ld: %s", - SvPV(sth,na), key, (long)SvIV(DBIc_ERR(imp_sth)), + SvPV(sth,PL_na), key, (long)SvIV(DBIc_ERR(imp_sth)), SvPV(DBIc_ERRSTR(imp_sth),lna) ); } i = DBIc_NUM_FIELDS(imp_sth); --- oci8.c.orig 2012-09-05 12:16:27.000000000 -0400 +++ oci8.c 2012-09-05 12:17:35.000000000 -0400 @@ -1536,11 +1536,11 @@ fbh->ftype = fbh->dbtype; fbh->disize = fbh->dbsize; p = "Field %d has an Oracle type (%d) which is not explicitly supported%s"; if (DBIS->debug >= 1) PerlIO_printf(DBILOGFP, p, i, fbh->dbtype, "\n"); - if (dowarn) + if (PL_dowarn) warn(p, i, fbh->dbtype, ""); break; } if (DBIS->debug >= 3) PerlIO_printf(DBILOGFP, @@ -2056,11 +2056,11 @@ hv_iterinit(imp_sth->all_params_hv); while( (sv = hv_iternextsv(imp_sth->all_params_hv, &p, &i)) != NULL ) { int matched = 0; phs_t *phs = (phs_t*)(void*)SvPVX(sv); - if (sv == &sv_undef || !phs) + if (sv == &PL_sv_undef || !phs) croak("panic: unbound params"); if (phs->ftype != SQLT_CLOB && phs->ftype != SQLT_BLOB) continue; hv_iterinit(lob_cols_hv); Regards, web... -- William Bulley Email: web@umich.edu 72 characters width template ----------------------------------------->| --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="p5.DBD.Oracle.patches" --- Oracle.c.orig 2012-09-05 11:59:43.000000000 -0400 +++ Oracle.c 2012-09-05 12:12:04.000000000 -0400 @@ -1493,11 +1493,11 @@ XS_EUPXS(XS_DBD__Oracle__st_ora_execute_array); /* prototype to pass -Wmissing-prototypes */ XS_EUPXS(XS_DBD__Oracle__st_ora_execute_array) { dVAR; dXSARGS; if (items < 4 || items > 5) - croak_xs_usage(cv, "sth, tuples, exe_count, tuples_status, cols=&sv_undef"); + croak_xs_usage(cv, "sth, tuples, exe_count, tuples_status, cols=&PL_sv_undef"); { SV * sth = ST(0) ; SV * tuples = ST(1) ; @@ -1510,11 +1510,11 @@ D_imp_sth(sth); int retval; #line 1513 "Oracle.c" if (items < 5) - cols = &sv_undef; + cols = &PL_sv_undef; else { cols = ST(4) ; } #line 127 "Oracle.xs" @@ -1547,11 +1547,11 @@ { SV * sth = ST(0) ; #line 147 "Oracle.xs" D_imp_sth(sth); - ST(0) = dbd_st_cancel(sth, imp_sth) ? &sv_yes : &sv_no; + ST(0) = dbd_st_cancel(sth, imp_sth) ? &PL_sv_yes : &PL_sv_no; #line 1554 "Oracle.c" } XSRETURN(1); } @@ -1569,11 +1569,11 @@ ; char * pwd = (char *)SvPV_nolen(ST(2)) ; #line 159 "Oracle.xs" D_imp_dbh(dbh); - ST(0) = ora_db_reauthenticate(dbh, imp_dbh, uid, pwd) ? &sv_yes : &sv_no; + ST(0) = ora_db_reauthenticate(dbh, imp_dbh, uid, pwd) ? &PL_sv_yes : &PL_sv_no; #line 1576 "Oracle.c" } XSRETURN(1); } @@ -1621,19 +1621,19 @@ /* added by lab: */ /* LAB do something about length here? see above comment */ OCILobCharSetForm_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csform, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetForm"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #ifdef OCI_ATTR_CHARSET_ID /* Effectively only used so AL32UTF8 works properly */ OCILobCharSetId_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csid, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetId"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #endif /* OCI_ATTR_CHARSET_ID */ /* if data is utf8 but charset isn't then switch to utf8 csid */ csid = (SvUTF8(data) && !CS_IS_UTF8(csid)) ? utf8_csid : CSFORM_IMPLIED_CSID(csform); @@ -1643,14 +1643,14 @@ bufp, (ub4)data_len, OCI_ONE_PIECE, NULL, NULL, (ub2)0, csform , status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobWrite"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } #line 1654 "Oracle.c" } XSRETURN(1); } @@ -1700,19 +1700,19 @@ /* added by lab: */ /* LAB do something about length here? see above comment */ OCILobCharSetForm_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csform, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetForm"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #ifdef OCI_ATTR_CHARSET_ID /* Effectively only used so AL32UTF8 works properly */ OCILobCharSetId_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csid, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetId"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #endif /* OCI_ATTR_CHARSET_ID */ /* if data is utf8 but charset isn't then switch to utf8 csid */ csid = (SvUTF8(data) && !CS_IS_UTF8(csid)) ? utf8_csid : CSFORM_IMPLIED_CSID(csform); @@ -1721,20 +1721,20 @@ &amtp, bufp, (ub4)data_len, OCI_ONE_PIECE, NULL, NULL, csid, csform, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobWriteAppend"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } #else OCILobGetLength_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &startp, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobGetLength"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { /* start one after the end -- the first position in the LOB is 1 */ startp++; if (DBIS->debug >= 2 ) PerlIO_printf(DBILOGFP, " Calling OCILobWrite with csid=%d csform=%d\n",csid, csform ); @@ -1743,14 +1743,14 @@ bufp, (ub4)data_len, OCI_ONE_PIECE, NULL, NULL, csid, csform , status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobWrite"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } } #endif #line 1756 "Oracle.c" } @@ -1803,20 +1803,20 @@ /* if (0 && SvUTF8(dest_sv) && !IN_BYTES) { amtp = sv_len_utf8(dest_sv); } */ /* added by lab: */ OCILobCharSetForm_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csform, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetForm"); - dest_sv = &sv_undef; + dest_sv = &PL_sv_undef; return; } OCILobRead_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &amtp, (ub4)offset, /* offset starts at 1 */ bufp, (ub4)bufp_len, 0, 0, (ub2)0, csform, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobRead"); - dest_sv = &sv_undef; + dest_sv = &PL_sv_undef; } else { SvCUR(dest_sv) = amtp; /* always bytes here */ *SvEND(dest_sv) = '\0'; if (CSFORM_IMPLIES_UTF8(csform)) @@ -1858,14 +1858,14 @@ ; #line 353 "Oracle.xs" OCILobTrim_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, length, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobTrim"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } #line 1869 "Oracle.c" } XSRETURN(1); } @@ -1898,11 +1898,11 @@ ; #line 371 "Oracle.xs" OCILobGetLength_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &len, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobTrim"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { ST(0) = sv_2mortal(newSVuv(len)); } #line 1909 "Oracle.c" --- Oracle.xs.orig 2006-10-02 08:08:50.000000000 -0400 +++ Oracle.xs 2012-09-05 12:09:06.000000000 -0400 @@ -112,11 +112,11 @@ if (debug >= 2 && SvTRUE(DBIc_ERR(imp_sth))) PerlIO_printf(DBILOGFP, " !! ERROR: %s %s", neatsvpv(DBIc_ERR(imp_sth),0), neatsvpv(DBIc_ERRSTR(imp_sth),0)); void -ora_execute_array(sth, tuples, exe_count, tuples_status, cols=&sv_undef) +ora_execute_array(sth, tuples, exe_count, tuples_status, cols=&PL_sv_undef) SV * sth SV * tuples IV exe_count SV * tuples_status SV * cols @@ -143,11 +143,11 @@ void cancel(sth) SV * sth CODE: D_imp_sth(sth); - ST(0) = dbd_st_cancel(sth, imp_sth) ? &sv_yes : &sv_no; + ST(0) = dbd_st_cancel(sth, imp_sth) ? &PL_sv_yes : &PL_sv_no; MODULE = DBD::Oracle PACKAGE = DBD::Oracle::db void @@ -155,11 +155,11 @@ SV * dbh char * uid char * pwd CODE: D_imp_dbh(dbh); - ST(0) = ora_db_reauthenticate(dbh, imp_dbh, uid, pwd) ? &sv_yes : &sv_no; + ST(0) = ora_db_reauthenticate(dbh, imp_dbh, uid, pwd) ? &PL_sv_yes : &PL_sv_no; void ora_lob_write(dbh, locator, offset, data) SV *dbh OCILobLocator *locator @@ -183,19 +183,19 @@ /* added by lab: */ /* LAB do something about length here? see above comment */ OCILobCharSetForm_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csform, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetForm"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #ifdef OCI_ATTR_CHARSET_ID /* Effectively only used so AL32UTF8 works properly */ OCILobCharSetId_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csid, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetId"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #endif /* OCI_ATTR_CHARSET_ID */ /* if data is utf8 but charset isn't then switch to utf8 csid */ csid = (SvUTF8(data) && !CS_IS_UTF8(csid)) ? utf8_csid : CSFORM_IMPLIED_CSID(csform); @@ -205,14 +205,14 @@ bufp, (ub4)data_len, OCI_ONE_PIECE, NULL, NULL, (ub2)0, csform , status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobWrite"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } void ora_lob_append(dbh, locator, data) SV *dbh @@ -239,19 +239,19 @@ /* added by lab: */ /* LAB do something about length here? see above comment */ OCILobCharSetForm_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csform, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetForm"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #ifdef OCI_ATTR_CHARSET_ID /* Effectively only used so AL32UTF8 works properly */ OCILobCharSetId_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csid, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetId"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; return; } #endif /* OCI_ATTR_CHARSET_ID */ /* if data is utf8 but charset isn't then switch to utf8 csid */ csid = (SvUTF8(data) && !CS_IS_UTF8(csid)) ? utf8_csid : CSFORM_IMPLIED_CSID(csform); @@ -260,20 +260,20 @@ &amtp, bufp, (ub4)data_len, OCI_ONE_PIECE, NULL, NULL, csid, csform, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobWriteAppend"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } #else OCILobGetLength_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &startp, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobGetLength"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { /* start one after the end -- the first position in the LOB is 1 */ startp++; if (DBIS->debug >= 2 ) PerlIO_printf(DBILOGFP, " Calling OCILobWrite with csid=%d csform=%d\n",csid, csform ); @@ -282,14 +282,14 @@ bufp, (ub4)data_len, OCI_ONE_PIECE, NULL, NULL, csid, csform , status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobWrite"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } } #endif @@ -319,20 +319,20 @@ /* if (0 && SvUTF8(dest_sv) && !IN_BYTES) { amtp = sv_len_utf8(dest_sv); } */ /* added by lab: */ OCILobCharSetForm_log_stat( imp_dbh->envhp, imp_dbh->errhp, locator, &csform, status ); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobCharSetForm"); - dest_sv = &sv_undef; + dest_sv = &PL_sv_undef; return; } OCILobRead_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &amtp, (ub4)offset, /* offset starts at 1 */ bufp, (ub4)bufp_len, 0, 0, (ub2)0, csform, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobRead"); - dest_sv = &sv_undef; + dest_sv = &PL_sv_undef; } else { SvCUR(dest_sv) = amtp; /* always bytes here */ *SvEND(dest_sv) = '\0'; if (CSFORM_IMPLIES_UTF8(csform)) @@ -351,14 +351,14 @@ sword status; CODE: OCILobTrim_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, length, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobTrim"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { - ST(0) = &sv_yes; + ST(0) = &PL_sv_yes; } void ora_lob_length(dbh, locator) SV *dbh @@ -369,11 +369,11 @@ ub4 len = 0; CODE: OCILobGetLength_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &len, status); if (status != OCI_SUCCESS) { oci_error(dbh, imp_dbh->errhp, status, "OCILobTrim"); - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; } else { ST(0) = sv_2mortal(newSVuv(len)); } --- dbdimp.c.orig 2006-11-03 09:05:46.000000000 -0500 +++ dbdimp.c 2012-09-05 12:16:19.000000000 -0400 @@ -188,11 +188,11 @@ dbd_discon_all(SV *drh, imp_drh_t *imp_drh) { dTHR; /* The disconnect_all concept is flawed and needs more work */ - if (!dirty && !SvTRUE(perl_get_sv("DBI::PERL_ENDING",0))) { + if (!PL_dirty && !SvTRUE(perl_get_sv("DBI::PERL_ENDING",0))) { DBIh_SET_ERR_CHAR(drh, (imp_xxh_t*)imp_drh, Nullch, 1, "disconnect_all not implemented", Nullch, Nullch); return FALSE; } return FALSE; } @@ -902,11 +902,11 @@ SV **svp = hv_fetch((HV*)SvRV(dbh), key, kl, 1); sv_free(*svp); *svp = retsv; (void)SvREFCNT_inc(retsv); /* so sv_2mortal won't free it */ } - if (retsv == &sv_yes || retsv == &sv_no) + if (retsv == &PL_sv_yes || retsv == &PL_sv_no) return retsv; /* no need to mortalize yes or no */ return sv_2mortal(retsv); } @@ -937,11 +937,11 @@ /* initialise phs ready to be cloned per placeholder */ memset(&phs_tpl, 0, sizeof(phs_tpl)); phs_tpl.imp_sth = imp_sth; phs_tpl.ftype = imp_dbh->ph_type; phs_tpl.csform = imp_dbh->ph_csform; - phs_tpl.sv = &sv_undef; + phs_tpl.sv = &PL_sv_undef; src = statement; dest = imp_sth->statement; while(*src) { @@ -1102,11 +1102,11 @@ at_exec = (phs->desc_h == NULL); if (!SvPOK(phs->sv)) { /* normalizations for special cases */ if (SvOK(phs->sv)) { /* ie a number, convert to string ASAP */ if (!(SvROK(phs->sv) && phs->is_inout)) - sv_2pv(phs->sv, &na); + sv_2pv(phs->sv, &PL_na); } else /* ensure we're at least an SVt_PV (so SvPVX etc work) */ SvUPGRADE(phs->sv, SVt_PV); } @@ -1497,11 +1497,11 @@ phs_svp = hv_fetch(imp_sth->all_params_hv, name, name_len, 0); if (phs_svp == NULL) croak("Can't bind unknown placeholder '%s' (%s)", name, neatsvpv(ph_namesv,0)); phs = (phs_t*)(void*)SvPVX(*phs_svp); /* placeholder struct */ - if (phs->sv == &sv_undef) { /* first bind for this placeholder */ + if (phs->sv == &PL_sv_undef) { /* first bind for this placeholder */ phs->is_inout = is_inout; if (is_inout) { /* phs->sv assigned in the code below */ ++imp_sth->has_inout_params; /* build array of phs's so we can deal with out vars fast */ @@ -1560,15 +1560,15 @@ } phs->maxlen = maxlen; /* 0 if not inout */ if (!is_inout) { /* normal bind so take a (new) copy of current value */ - if (phs->sv == &sv_undef) /* (first time bind) */ + if (phs->sv == &PL_sv_undef) /* (first time bind) */ phs->sv = newSV(0); sv_setsv(phs->sv, newvalue); if (SvAMAGIC(phs->sv)) /* overloaded. XXX hack, logic ought to be pushed deeper */ - sv_pvn_force(phs->sv, &na); + sv_pvn_force(phs->sv, &PL_na); } else if (newvalue != phs->sv) { if (phs->sv) SvREFCNT_dec(phs->sv); phs->sv = SvREFCNT_inc(newvalue); /* point to live var */ @@ -1833,11 +1833,11 @@ static void init_bind_for_array_exec(phs) phs_t *phs; { - if (phs->sv == &sv_undef) { /* first bind for this placeholder */ + if (phs->sv == &PL_sv_undef) { /* first bind for this placeholder */ phs->is_inout = 0; phs->maxlen = 1; /* treat Oracle7 SQLT_CUR as SQLT_RSET for Oracle8 */ if (phs->ftype==102) phs->ftype = 116; @@ -2164,11 +2164,11 @@ for(i=0; i < num_fields; ++i) { imp_fbh_t *fbh = &imp_sth->fbh[i]; if (fbh->fetch_cleanup) fbh->fetch_cleanup(sth, fbh); } - if (dirty) /* don't walk on the wild side */ + if (PL_dirty) /* don't walk on the wild side */ return 1; if (!DBIc_ACTIVE(imp_dbh)) /* no longer connected */ return 1; @@ -2242,14 +2242,14 @@ when they are no longer needed. */ if (DBIc_DBISTATE(imp_sth)->debug >= 6) PerlIO_printf(DBIc_LOGPIO(imp_sth), " dbd_st_destroy %s\n", - (dirty) ? "(OCIHandleFree skipped during global destruction)" : + (PL_dirty) ? "(OCIHandleFree skipped during global destruction)" : (imp_sth->nested_cursor) ?"(OCIHandleFree skipped for nested cursor)" : ""); - if (!dirty) { /* XXX not ideal, leak may be a problem in some cases */ + if (!PL_dirty) { /* XXX not ideal, leak may be a problem in some cases */ if (!imp_sth->nested_cursor) { OCIHandleFree_log_stat(imp_sth->stmhp, OCI_HTYPE_STMT, status); if (status != OCI_SUCCESS) oci_error(sth, imp_sth->errhp, status, "OCIHandleFree"); } @@ -2280,11 +2280,11 @@ SV *sv; char *key; I32 retlen; hv_iterinit(hv); while( (sv = hv_iternextsv(hv, &key, &retlen)) != NULL ) { - if (sv != &sv_undef) { + if (sv != &PL_sv_undef) { phs_t *phs = (phs_t*)(void*)SvPVX(sv); if (phs->desc_h && phs->desc_t == OCI_DTYPE_LOB) ora_free_templob(sth, imp_sth, (OCILobLocator*)phs->desc_h); @@ -2340,11 +2340,11 @@ STRLEN lna; /* dbd_describe has already called ora_error() */ /* we can't return Nullsv here because the xs code will */ /* then just pass the attribute name to DBI for FETCH. */ croak("Describe failed during %s->FETCH(%s): %ld: %s", - SvPV(sth,na), key, (long)SvIV(DBIc_ERR(imp_sth)), + SvPV(sth,PL_na), key, (long)SvIV(DBIc_ERR(imp_sth)), SvPV(DBIc_ERRSTR(imp_sth),lna) ); } i = DBIc_NUM_FIELDS(imp_sth); --- oci8.c.orig 2012-09-05 12:16:27.000000000 -0400 +++ oci8.c 2012-09-05 12:17:35.000000000 -0400 @@ -1536,11 +1536,11 @@ fbh->ftype = fbh->dbtype; fbh->disize = fbh->dbsize; p = "Field %d has an Oracle type (%d) which is not explicitly supported%s"; if (DBIS->debug >= 1) PerlIO_printf(DBILOGFP, p, i, fbh->dbtype, "\n"); - if (dowarn) + if (PL_dowarn) warn(p, i, fbh->dbtype, ""); break; } if (DBIS->debug >= 3) PerlIO_printf(DBILOGFP, @@ -2056,11 +2056,11 @@ hv_iterinit(imp_sth->all_params_hv); while( (sv = hv_iternextsv(imp_sth->all_params_hv, &p, &i)) != NULL ) { int matched = 0; phs_t *phs = (phs_t*)(void*)SvPVX(sv); - if (sv == &sv_undef || !phs) + if (sv == &PL_sv_undef || !phs) croak("panic: unbound params"); if (phs->ftype != SQLT_CLOB && phs->ftype != SQLT_BLOB) continue; hv_iterinit(lob_cols_hv); --6c2NcOVqGQ03X4Wi-- From owner-freebsd-perl@FreeBSD.ORG Fri Sep 7 08:28:27 2012 Return-Path: Delivered-To: perl@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E1691065670 for ; Fri, 7 Sep 2012 08:28:27 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from portsmonj.FreeBSD.org (portsmonj.freebsd.org [69.147.83.46]) by mx1.freebsd.org (Postfix) with ESMTP id 5C3498FC20 for ; Fri, 7 Sep 2012 08:28:27 +0000 (UTC) Received: from portsmonj.freebsd.org (portsmonj.freebsd.org [69.147.83.46]) by portsmonj.FreeBSD.org (8.14.5/8.14.4) with ESMTP id q878SRiY082892 for ; Fri, 7 Sep 2012 08:28:27 GMT (envelope-from linimon@FreeBSD.org) Date: Fri, 7 Sep 2012 08:28:27 GMT Message-Id: <201209070828.q878SRiY082892@portsmonj.FreeBSD.org> From: linimon@FreeBSD.org To: perl@FreeBSD.org Cc: Subject: FreeBSD ports that you maintain which are currently marked broken X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: portmgr-feedback@FreeBSD.org List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Sep 2012 08:28:27 -0000 Dear FreeBSD port maintainer: As part of an ongoing effort to reduce the number of problems in the FreeBSD ports system, we periodically notify users of ports that are marked as "broken" in their Makefiles. In many cases these ports are failing to compile on some subset of the FreeBSD build environments. The most common problem is that recent versions of -CURRENT include gcc4.2, which is much stricter than older versions. The next most common problem is that compiles succeed on the i386 architecture (e.g. the common Intel PC), but fail on one or more of the other architectures due to assumptions about things such as size of various types, byte-alignment issues, and so forth. In occasional cases we see that the same port may have different errors in different build environments. The script that runs on the build cluster uses heuristics to try to 'guess' the error type to help you isolate problems, but it is only a rough guide. One more note: on occasion, there are transient build errors seen on the build farm. Unfortunately, there is not yet any way for this algorithm to tell the difference (humans are much, much better at this kind of thing.) The errors are listed below. In the case where the same problem exists on more than one build environment, the URL points to the latest errorlog for that type. (By 'build environment' here we mean 'combination of 7.x/8.x/9.x/-current with target architecture'.) (Note: the dates are included to help you to gauge whether or not the error still applies to the latest version. The program that generates this report is not yet able to determine this automatically.) portname: databases/p5-DBD-Oracle broken because: Does not build build errors: http://pointyhat.FreeBSD.org/errorlogs/i386-errorlogs/e.7.20120816063236/p5-DBD-Oracle-1.14_3.log (_Jul_25_10:00:26_UTC_2012) overview: http://portsmon.FreeBSD.org/portoverview.py?category=databases&portname=p5-DBD-Oracle portname: multimedia/p5-Video-Info broken because: does not fetch build errors: none. overview: http://portsmon.FreeBSD.org/portoverview.py?category=multimedia&portname=p5-Video-Info portname: www/p5-Apache2-Scoreboard broken because: does not configure build errors: http://pointyhat.FreeBSD.org/errorlogs/powerpc-errorlogs/e.8.20120528024705/p5-Apache2-Scoreboard-2.09.2_2.log (_Aug_11_07:54:40_UTC_2012) overview: http://portsmon.FreeBSD.org/portoverview.py?category=www&portname=p5-Apache2-Scoreboard If these errors are ones that you are already aware of, please accept our apologies and ignore this message. On the other hand, if you no longer wish to maintain this port (or ports), please reply with a message stating that, and accept our thanks for your efforts in the past. Every effort has been made to make sure that these error reports really do correspond to a port that you maintain. However, due to the fact that this is an automated process, it may indeed generate false matches. If one of these errors fits that description, please forward this email to the author of this software, Mark Linimon , so that he can attempt to fix the problem in the future. Thanks for your efforts to help improve FreeBSD. From owner-freebsd-perl@FreeBSD.ORG Fri Sep 7 08:29:28 2012 Return-Path: Delivered-To: perl@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 10B6B1065709 for ; Fri, 7 Sep 2012 08:29:28 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from portsmonj.FreeBSD.org (portsmonj.freebsd.org [69.147.83.46]) by mx1.freebsd.org (Postfix) with ESMTP id F3C878FC0A for ; Fri, 7 Sep 2012 08:29:27 +0000 (UTC) Received: from portsmonj.freebsd.org (portsmonj.freebsd.org [69.147.83.46]) by portsmonj.FreeBSD.org (8.14.5/8.14.4) with ESMTP id q878TRFl089163 for ; Fri, 7 Sep 2012 08:29:27 GMT (envelope-from linimon@FreeBSD.org) Date: Fri, 7 Sep 2012 08:29:27 GMT Message-Id: <201209070829.q878TRFl089163@portsmonj.FreeBSD.org> From: linimon@FreeBSD.org To: perl@FreeBSD.org Cc: Subject: FreeBSD ports that you maintain which are currently scheduled for deletion X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: portmgr-feedback@FreeBSD.org List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Sep 2012 08:29:28 -0000 Dear FreeBSD port maintainer: As part of an ongoing effort to reduce the number of problems in the FreeBSD ports system, we periodically schedule removal of ports that have been judged to have outlived their usefulness. Often, this is due to a better alternative having become available and/or the cessation of development on the existing port. In some cases, ports are marked for removal because they fail to build and install correctly from their sources, or otherwise fail in operation. The ports, and the reason and date that they have been scheduled for removal, are listed below. If no one has stepped forward before that time to propose a way to fix the problems (such as via a PR), the ports will be deleted. portname: devel/p5-Class-Fields description: Set of modules to operate with class fields and members access maintainer: perl@FreeBSD.org deprecated because: considered obsolete by upstream expiration date: 2012-07-11 build errors: none. overview: http://portsmon.FreeBSD.org/portoverview.py?category=devel&portname=p5-Class-Fields portname: multimedia/p5-Video-Info description: Retrieve video properties such as: height width codec fps maintainer: perl@FreeBSD.org status: BROKEN deprecated because: BROKEN for more than 6 month expiration date: 2012-05-10 build errors: none. overview: http://portsmon.FreeBSD.org/portoverview.py?category=multimedia&portname=p5-Video-Info If this problem is one that you are already aware of, please accept our apologies and ignore this message. On the other hand, if you no longer wish to maintain this port (or ports), please reply with a message stating that, and accept our thanks for your efforts in the past. Thanks for your efforts to help improve FreeBSD.